[04:22:42] (CR) AndyRussG: "Rebased again..." [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [04:24:09] (PS27) AndyRussG: Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) [04:25:12] (CR) jenkins-bot: [V: -1] Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [08:44:06] (CR) Siebrand: [C: 1] "i18n/L10n reviewed." [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [16:10:15] (CR) Ejegg: "I like that it cleans up after itself, but it's kinda gross to have to store the instance as a static variable. I'd prefer explicitly cal" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/218438 (owner: Awight) [16:18:54] * AndyRussG waves at ejegg cwdent dstrine :) [16:19:21] Anyone have any idea why this now respons "no tests execute"? php tests/phpunit/phpunit.php --group CentralNotice [16:20:04] ejegg: ^ ? [16:20:07] Hi AndyRussG [16:20:12] Hey! :) [16:20:15] Lemme see if I get the same [16:20:46] I just updated my version of core, but going back in time also doesn't seem to help right now... [16:21:00] Thanks!! [16:23:01] it's running tests for me if I use the makefile [16:23:20] cd into tests/phpunit, then make phpunit FLAGS="--group CentralNotice" [16:23:32] AndyRussG: ^^ [16:24:05] ejegg: ah hmm OK lemme try that..... [16:26:38] ejegg: yeah that worked, thanks so much! [16:26:42] yw [16:27:37] I truthfully have no idea what you did there... Isn't make for, like, building C programs? rrrg (/me growls at own ignorance) [16:31:23] yeah, i dunno. i recite the incantation and the planes drop the goods! [16:32:33] Who told u the sekret? [16:33:37] i think that dir's README pointed me towards 'make help' [16:34:56] ejegg: thx! [16:36:18] back in a sec (silly Gnome bug ate my mouse cursor...) [16:43:30] fanny was pretty brave on the ice this weekend http://i.imgur.com/5GK1ksd.jpg [16:48:16] (CR) Ejegg: [C: 2] "Looks good. More like 'Write _and_ test contact group import', though!" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/217989 (owner: Awight) [16:51:42] cwdent: wow, that much ice at the summer solstice? [16:53:20] ejegg: if you go up far enough! we were near this: https://en.wikipedia.org/wiki/Rollins_Pass [16:54:06] wow, that's pretty high! [16:55:11] cwdent: wow, that's gorgeous! [16:56:22] it's beautiful up there. here's a better view of that lake: http://i.imgur.com/hMSj9Ox.jpg [16:58:53] cwdent: fantastic [16:59:16] Yeah I really want to take my family on a camping trip sometime... It won't be until we get back from Mexico tho [16:59:21] (leaving tomorrow morning!) [17:02:11] AndyRussG: i bet there's some awesome camping in mexico! [17:03:02] cwdent: hmmmmmmmm yeah possibly... The kids will be busy being spoilt by their grandparents, tho 8p [17:04:26] AndyRussG: are they in mexico city? [17:04:44] cwdent: yeah! We'll be staying with them, in fact [17:05:31] well that is pretty convenient! [17:06:12] Heh yeah! We lucked out with the Wikimania location this year [17:06:30] In Mexico City we had a bit of a bubble that we were used to living in... As things are, I don't feel especially enthusiastic about venturing too far outside of the bubble, especially with the kids... [17:06:49] Not to discourage anyone else who may be planning to adventure a bit while there, though...! [17:07:30] The kids will also be busy with sleepover parties and such with their friends from the school they went to there... [17:08:21] yeah the political situation down there sure is hard to understand from up here [17:09:20] We'll probably go to Taxco, though, which is where my parents-in-law's extended families are from... outdoorsy camping with kids, mmm I guess if we investigated we might find a place to go, maybe on the recommendations of friends [17:10:05] cwdent: in fact a large percentage of the people living there feel similarly--it's very complicated and hard to know what's really going on [17:10:20] Beyond the fact that the news is not very good.. [17:11:51] I'm sure things will be fine for the conference in Mexico City tho [17:12:59] yeah it seems like every part of the socio economic scale is well represented in mexico [17:13:14] Heh some more than others! [17:14:19] Such a huge range of incomes and levels of well-being and education, it's hard to talk about even a "middle class", since really there are dozens of different "middle" classes... [17:14:54] It's an amazing place on many, many levels, though. And there's so much you can learn there! [17:16:03] absolutely, oaxaca was one of my favorite places i've been [17:16:36] i've never spent time in mexico city [17:17:44] cwdent: you should go! [17:19:56] sure wish i could come to wikimania! but i've got a wedding to go to in wisconsin, and i'm in it, so i can't skip :( [17:20:52] Ah right yeah! That'll be fun too :) [17:21:21] Anyway Mexico City will still be there, and there'll be other Wikimanias [17:21:43] yup :) [17:22:29] cwdent: ejegg: XenoRyet: If I have TODO that's the same for three methods in a class (that has several more methods) where do you think I should put it? In the PHPDoc for each method? Inline // in the code of each method? Somehwere at the top of the class? [17:23:15] That's a good question [17:23:20] top of the class sounds good, or on top of the first method with the names of the other two [17:23:58] I was leaning a little towards inline, but on the first method with reference to the other two sounds good as well. [17:27:15] ejegg: XenoRyet: thx! :) [17:41:27] (CR) AndyRussG: "PHPUnit tests should pass when I6033e03e is merged into core..." [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [17:45:28] Fundraising Sprint Miles Davis, Fundraising-Backlog, Astropay Integration, Patch-For-Review: Forms seem to be fitting to size of security text instead of what we had before - https://phabricator.wikimedia.org/T101564#1388588 (jrobell) Thanks @ejegg and @atgo for fixing this! [17:48:00] ejegg: Just wanted to chat about the RAII antipattern... [17:48:16] I made the variable static so that it can be used in the dataProvider [17:48:25] oh, i see [17:48:42] perhaps I could destroy in tearDownClass, but my instinct is that RAII might be cleaner [17:48:54] i don't have really strong feelings about it either way [17:48:54] Happy to do something else if u find it horrifying though! [17:49:04] ok, me neither [17:49:16] nah, I'm fine with it. Will review again [17:49:35] In the other places it gets used, it's function-scoped, so is torn down around tearDown time [17:49:53] yeah, that works [17:49:57] I gotta figure out a better solution for dataProviders though, this is something I've run into before [17:50:06] IMO, PHPUnit needs to be patched [17:50:20] dataproviders are called before setupclass, I think that should be switched around. [17:50:36] Then we could create and destroy static stuff in the usual places. [17:50:44] oh yeah, that does seem wrong [17:53:44] (CR) AndyRussG: bannerController.lib: KV store with localStorage (1 comment) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) (owner: AndyRussG) [17:55:28] (CR) Awight: "Thanks! Fixing commit msg now..." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/217989 (owner: Awight) [17:56:13] (PS6) AndyRussG: bannerController.lib: KV store with localStorage [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) [17:56:15] (PS9) Awight: Write contact_groups import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/217989 [17:56:17] (CR) jenkins-bot: [V: -1] Write contact_groups import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/217989 (owner: Awight) [17:57:02] (CR) jenkins-bot: [V: -1] bannerController.lib: KV store with localStorage [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) (owner: AndyRussG) [17:57:06] (CR) AndyRussG: "Rebayss't" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) (owner: AndyRussG) [17:58:23] (PS6) Awight: Use RAII for fixtures [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/218438 [17:58:32] (PS7) Awight: Use RAII for fixtures [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/218438 [17:58:34] (CR) jenkins-bot: [V: -1] Use RAII for fixtures [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/218438 (owner: Awight) [18:00:24] that patch seems to be caught in a causality loop [18:00:36] It's horrible. origin/master is hosed too, somehow [18:00:41] Hey, go home! [18:01:06] I'd much rather see you at Wikimania than watch any work get done until then [18:01:23] heh. i really hope i can still go [18:13:15] cwdent: Can you mail me the failure you're seeing during refund? [18:13:53] awight: i think it has changed since that recent migration [18:13:58] lol [18:14:24] now i get Cannot create contribution, civi error! Source: 'Unknown error' [18:14:37] Any stack trace? [18:15:30] yeah i've got it up in xdebug [18:16:07] labs is back, i want to get this stuff set up there, so anyone can look at it [18:16:31] paste me that trace and I'll try to write a unit test for it [18:16:46] ok one sec [18:17:52] which was the local paste? [18:18:07] on gerrit or phab? [18:18:27] This is a nice one: https://phabricator.wikimedia.org/paste/create/ [18:21:26] (PS8) Awight: Use RAII for fixtures [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/218438 [18:21:56] (PS10) Awight: Write contact_groups import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/217989 [18:21:58] (CR) jenkins-bot: [V: -1] Write contact_groups import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/217989 (owner: Awight) [18:22:23] awight: the error is getting caught so i don't get a normal stacktrace, i have the call list in xdebug [18:22:33] rats [18:22:38] is there a log level i should turn up? [18:22:40] That's a good start though [18:22:57] There is... something that causes a stack trace every time an exception is thrown, I think [18:23:00] looking [18:23:07] I've wanted that recently but been too lazy to find it. [18:23:58] They say Xdebug does that by default, http://stackoverflow.com/questions/1159216/how-can-i-get-php-to-produce-a-backtrace-upon-errors [18:24:21] hmm, lessee [18:24:44] blech, maybne it's just on fatal errors. [18:24:58] xdebug.auto_trace = 1 [18:25:20] Nvm, I have no clue what goes on in there. [18:25:37] But the call list will be helpful, anyway [18:25:58] xdebug.show_exception_trace=1 ; bool: Show a stack trace whenever an exception is raised. [18:27:53] Yeah, we have two unreviewed patches on origin/master [18:31:16] K4-713: one sec! [18:31:52] No worries. [18:32:26] awight: https://phabricator.wikimedia.org/P820 [18:32:44] there's the watchdog output and call stack at the time of error [18:53:35] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1388893 (awight) A small change to the Organization import te... [18:54:56] cwdent: Cool, that trace was very helpful. [18:55:24] awight: i can give you the values of any variables at that time too [18:55:47] cwdent: Can you check that you have the following fields in wmf_contribution_extra: gateway, gateway_txn_id, original_currency, original_amount [18:56:17] "unknown error" sounds like a database error [18:56:37] in the table schema? [18:56:42] and the hook that failed is supposed to parse the trxn_id and source fields into a custom table [18:56:45] yeah [18:57:15] yeah i have all those [18:57:20] eff [18:57:25] I mean, good [18:57:30] heh [18:58:48] cwdent: Can you still dump $params from CRM_Core_BAO_CustomValueTable::setValues [18:59:25] one moment [19:04:13] awight: amended this paste https://phabricator.wikimedia.org/P820 [19:04:21] pardon the question marks [19:04:25] i have unicode issues [19:05:29] ah. Something is borken [19:05:54] The custom_ thing means that Civi couldn't map a custom field to its ID [19:06:14] Looks like it was the original_amount field [19:06:44] cwdent: Try this, select * from civicrm_custom_field where name='original_amount'\G [19:07:23] nothing [19:07:26] ok. [19:07:33] how did you determine original_amount? [19:07:49] Just guessing based on the value it was putting in there [19:09:24] select * from civicrm_custom_field f join civicrm_custom_group g on f.custom_group_id=g.id where g.name='contribution_extra'; [19:10:12] The group should have been created by migration wmf_civicrm:7001 [19:10:44] The original_amount field, by migration 7005 [19:11:16] i re-ran the install script recently so all migrations should be in place [19:11:47] You can try "update drupal.system set schema_version=0 where name='wmf_civicrm'", then drush updatedb, but you're probably better off rebuilding the DB from scratch. [19:11:56] so at a high level...custom groups are a key val store inside sql that can boil down to html elements [19:12:00] do i have that right? [19:12:32] It's possible you were bitten by "Renumber 6000-series updates" [19:12:46] Um, yeah that's a good way to look at it [19:13:18] Custom fields are properties external to CiviCRM core, but they show up in the edit and search web dialogs. [19:28:49] git newby question: Is there an argument for git add that will stage all modified files, instead of having to add one by one? [19:32:42] XenoRyet: "git add ." should do it [19:32:58] Cool, thanks [19:33:37] np! [19:41:02] (PS5) XenoRyet: Red Text validation messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/217158 (https://phabricator.wikimedia.org/T86214) [19:56:13] (CR) Awight: Red Text validation messages (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/217158 (https://phabricator.wikimedia.org/T86214) (owner: XenoRyet) [19:56:34] XenoRyet: +256 lines--totally good luck! [19:57:52] Yea, right? [19:58:12] jenkins liked it though, so can't be all bad. [20:01:54] Can anyone take a peek at this? https://gerrit.wikimedia.org/r/#/c/219495/ [20:30:00] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner history mixins and data - https://phabricator.wikimedia.org/T90918#1389291 (DStrine) [20:43:10] cwdent: I'm online again [20:43:30] XenoRyet: fyi, I made a few inline comments on that patch [20:43:40] I think you might be able to abandon the form changes... [20:44:10] I'll take a look. [20:45:15] Fundraising-Backlog, Astropay Integration: Donate by Boletos in Brazil - https://phabricator.wikimedia.org/T98215#1389404 (atgo) [20:48:59] cwdent: queue2civicrm/tests/phpunit/ProcessMessageTest.php testRefund [21:15:04] (PS3) Awight: Passthrough more payment types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219492 (https://phabricator.wikimedia.org/T88836) [21:15:06] (PS12) Awight: Test more fields used by WmfImportFile format [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/218567 [21:15:08] (PS3) Awight: Drop "Amount (USD)" column [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219493 (https://phabricator.wikimedia.org/T88836) [21:15:10] (PS3) Awight: Update Civi to pick up fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219498 [21:15:12] (PS3) Awight: Iterate offline keying template [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219438 [21:15:14] (PS2) Awight: WIP Migration for Restrictions options [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219480 [21:15:16] (PS2) Awight: Add and fix migrations for legacy custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219436 [21:15:18] (PS3) Awight: Remove fictitious letter_code field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219437 [21:15:20] (PS3) Awight: Make WmfImportFile the default offline import format [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219224 (https://phabricator.wikimedia.org/T88836) [21:15:22] (PS12) Awight: Import organization contact name and title [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/217990 [21:15:24] (PS1) Awight: Use RAII for fixtures [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219983 [21:15:26] (PS1) Awight: Write contact_groups import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219984 [21:15:28] (CR) jenkins-bot: [V: -1] Passthrough more payment types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219492 (https://phabricator.wikimedia.org/T88836) (owner: Awight) [21:15:30] (CR) jenkins-bot: [V: -1] Test more fields used by WmfImportFile format [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/218567 (owner: Awight) [21:15:32] (CR) jenkins-bot: [V: -1] Drop "Amount (USD)" column [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219493 (https://phabricator.wikimedia.org/T88836) (owner: Awight) [21:15:34] (CR) jenkins-bot: [V: -1] Update Civi to pick up fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219498 (owner: Awight) [21:15:36] (CR) jenkins-bot: [V: -1] Iterate offline keying template [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219438 (owner: Awight) [21:15:38] (CR) jenkins-bot: [V: -1] WIP Migration for Restrictions options [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219480 (owner: Awight) [21:15:40] (CR) jenkins-bot: [V: -1] Add and fix migrations for legacy custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219436 (owner: Awight) [21:15:42] (CR) jenkins-bot: [V: -1] Remove fictitious letter_code field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219437 (owner: Awight) [21:15:44] (CR) jenkins-bot: [V: -1] Make WmfImportFile the default offline import format [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219224 (https://phabricator.wikimedia.org/T88836) (owner: Awight) [21:15:46] (CR) jenkins-bot: [V: -1] Import organization contact name and title [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/217990 (owner: Awight) [21:15:48] (CR) jenkins-bot: [V: -1] Write contact_groups import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219984 (owner: Awight) [21:15:53] (Abandoned) Awight: Use RAII for fixtures [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/218438 (owner: Awight) [21:15:55] (Abandoned) Awight: Write contact_groups import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/217989 (owner: Awight) [21:27:28] Fundraising-Backlog, Astropay Integration: Donate by Boletos in Brazil - https://phabricator.wikimedia.org/T98215#1389635 (atgo) [21:27:47] Fundraising-Backlog, Astropay Integration: Donate by Bank Transfer in Brazil - https://phabricator.wikimedia.org/T98216#1389636 (atgo) [21:37:19] (PS3) Awight: Migration for Restrictions and Gift Source options [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219480 [21:37:21] (CR) jenkins-bot: [V: -1] Migration for Restrictions and Gift Source options [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219480 (owner: Awight) [21:38:28] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1389732 (RLewis) @awight yeah we don't overly use the Prefix... [21:41:59] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1389753 (awight) I was thinking I'd just drop for the Organiz... [21:43:40] (PS1) Awight: Revert "Use RAII for fixtures" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219993 [21:43:42] (PS1) Awight: Revert "Write test for contact_groups import" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219994 [21:44:13] (CR) Awight: [C: 2 V: 2] "Reverting unreviewed change." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219993 (owner: Awight) [21:44:26] (CR) Awight: [C: 2 V: 2] "Reverting unreviewed change." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219994 (owner: Awight) [21:44:54] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1389776 (RLewis) @awight drop it from the Org template I thin... [21:45:40] (PS2) Awight: Write contact_groups import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219984 [21:45:42] (PS4) Awight: Passthrough more payment types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219492 (https://phabricator.wikimedia.org/T88836) [21:45:44] (PS13) Awight: Test more fields used by WmfImportFile format [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/218567 [21:45:46] (PS4) Awight: Drop "Amount (USD)" column [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219493 (https://phabricator.wikimedia.org/T88836) [21:45:48] (PS4) Awight: Update Civi to pick up fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219498 [21:45:50] (PS4) Awight: Iterate offline keying template [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219438 [21:45:52] (PS4) Awight: Migration for Restrictions and Gift Source options [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219480 [21:45:54] (PS3) Awight: Add and fix migrations for legacy custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219436 [21:45:56] (PS4) Awight: Remove fictitious letter_code field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219437 [21:45:58] (PS4) Awight: Make WmfImportFile the default offline import format [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219224 (https://phabricator.wikimedia.org/T88836) [21:46:00] (PS2) Awight: Use RAII for fixtures [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219983 [21:46:02] (PS13) Awight: Import organization contact name and title [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/217990 [21:48:16] (PS1) Awight: Draft template for Organization import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219997 (https://phabricator.wikimedia.org/T88836) [21:51:13] (CR) jenkins-bot: [V: -1] Migration for Restrictions and Gift Source options [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219480 (owner: Awight) [21:56:00] (CR) jenkins-bot: [V: -1] Draft template for Organization import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219997 (https://phabricator.wikimedia.org/T88836) (owner: Awight) [22:02:02] (PS1) Awight: Provide Generic Org import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220001 [22:02:25] (CR) jenkins-bot: [V: -1] Provide Generic Org import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220001 (owner: Awight) [22:11:49] Relocating, will be back online in an hour... [22:57:23] (CR) Katie Horn: [C: 2] build: Configure banana-checker and jsonlint [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/218956 (owner: Legoktm) [23:30:10] awight: Oh hey. [23:30:31] Can you poke these two things? https://gerrit.wikimedia.org/r/#/c/216368/ and https://gerrit.wikimedia.org/r/#/c/216369/ ? [23:36:31] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1390211 (awight) @RLewis Here's a tough one... how do you wan... [23:36:37] K4-713: yep, sure! [23:36:57] They made you say that? :p [23:37:22] (PS3) Awight: build: Add explicit dependency upon grunt-cli [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/216368 (owner: Legoktm) [23:37:33] (CR) Awight: [C: 2] "Thanks for thinking of us!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/216368 (owner: Legoktm) [23:37:45] awight: Kind of! [23:37:46] :p [23:37:48] K4-713, awight: thanks :D [23:37:51] (PS3) Awight: build: Updating development dependencies [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/216369 (owner: Legoktm) [23:37:57] (CR) Awight: [C: 2] build: Updating development dependencies [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/216369 (owner: Legoktm) [23:38:13] (Merged) jenkins-bot: build: Add explicit dependency upon grunt-cli [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/216368 (owner: Legoktm) [23:38:14] legoktm: drop by more often ;) [23:38:32] (Merged) jenkins-bot: build: Updating development dependencies [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/216369 (owner: Legoktm) [23:38:52] awight: just emailed you some new clues about that custom field error, imma roll outta here but i'll probably be back on later to continue futzing [23:39:03] sounds fun! [23:39:11] whee [23:39:39] cwdent|afk: option_group_id is supposed to be null... it's custom_group_id that links to the group table [23:40:21] option_group_id is for linking to a set of multiple choices, see https://gerrit.wikimedia.org/r/#/c/219480/ for fixes to those [23:50:01] (PS5) Awight: Fix required import data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219242