[16:40:18] (PS2) Ejegg: Add astropay audit downloader and example config [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/219034 (https://phabricator.wikimedia.org/T94088) [16:45:17] * AndyRussG waves [16:45:32] ejegg|away: shouldn't you be resting? [16:46:06] heh, mostly I am! [16:47:02] ejegg|away: cool...! Surgery all good BTW? [16:47:23] (don't worry about answering much :) ) [16:48:05] yep, they say they got the bone pulled back together well. A ton more screws than I expected though, and man does it ache! [16:48:48] brutal [16:48:53] glad to hear it went well though [16:50:09] ejegg|away: good, though ouch! hope it feels better soon!! [16:51:35] cwdent ejegg|away: anything special that I should mention at scrum-of-scrums, other than summarize sprint board? [16:52:00] nothing from me [16:54:48] cwdent: cool thx! [16:58:34] is everybody going to the FR retro? [17:02:27] cwdent: when is it? [17:03:06] AndyRussG: right now [17:03:16] arg! [17:03:58] heh, i'm not sure if us programmers are integral [17:04:55] cwdent: I'd go if I weren't getting ready for scrum-of-scrums and trying to finish some stuff for today... [17:05:09] I'm sure you could go though! [17:05:56] well i'm right in the middle of some debugging [17:06:09] but i don't see anyone from tech in there [17:08:01] atgo: does the fr retro need a tech rep? [17:08:08] only if you want to join [17:08:17] k4 dstrine and i are here [17:08:40] sure, i'm debugging some stuff but i'll listen [17:29:28] Fundraising Tech Backlog: GlobalCollect audit processor should give prefer ".wx2" files over ".wx1" - https://phabricator.wikimedia.org/T103717#1397150 (awight) NEW [17:31:09] Fundraising Tech Backlog: GlobalCollect audit processor should give prefer ".wx2" files over ".wx1" - https://phabricator.wikimedia.org/T103717#1397172 (atgo) Hey @awight should we make this a requirement for T86090 instead? [17:31:51] Fundraising Tech Backlog: GlobalCollect audit processor should give prefer ".wx2" files over ".wx1" - https://phabricator.wikimedia.org/T103717#1397175 (awight) [17:31:53] Fundraising Sprint Lou Reed, Fundraising-Backlog, § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, and 3 others: Update GC audit to read WX file - https://phabricator.wikimedia.org/T86090#1397174 (awight) [17:32:01] Fundraising Tech Backlog: GlobalCollect audit processor should give prefer ".wx2" files over ".wx1" - https://phabricator.wikimedia.org/T103717#1397150 (awight) Mos def. [17:33:22] cwdent: Nice debugging, I think you're right about the $ridiculous_value_str [17:35:33] awight: yeah that civi code looks obviously broken... exception case => overwrite exception case with default behavior [17:36:12] Anything that inserts ^Aid^A into a database is foolhardy to begin with, if I may [17:36:17] awight: cwdent: ejegg|away: XenoRyet: LMK if you want to change/add stuff here: http://etherpad.wikimedia.org/p/Scrum-of-Scrums [17:36:20] (going on now) [17:37:12] (PS4) Awight: Add and fix migrations for legacy custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219436 [17:37:37] (CR) Awight: Add and fix migrations for legacy custom fields (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219436 (owner: Awight) [17:40:31] awight: cwdent: ejegg|away: XenoRyet: just updated our section of the etherpad (somehow I got disconnected) [17:40:36] (re: SoS) [17:40:38] awight: i still have no idea about that other error. once it starts happening i can't make it stop, not by checking out earlier commits, rebuilding dbs... [17:40:49] Fundraising Sprint Miles Davis, Unplanned-Sprint-Work, WMF FR, Patch-For-Review: Drupal 7.38 upgrade - https://phabricator.wikimedia.org/T103006#1397207 (awight) p:Triage>Normal [17:41:32] the bug extrapolates itself once observed [17:41:52] cwdent: whaa [17:42:15] Can you [17:42:31] Can u write a unit test that hits the bug? [17:42:42] Do the builtin tests pass for you? [17:43:29] lemmesee [17:43:35] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Amend rule for Engage team members - https://phabricator.wikimedia.org/T101179#1397216 (awight) p:Triage>Unbreak! [17:44:00] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Amend rule for Engage team members - https://phabricator.wikimedia.org/T101179#1331962 (awight) [17:45:21] awight: yeah tests pass [17:45:26] ooof [17:45:30] Well that's sort of good. [17:45:41] Can you write the test that doesn't pass, then? [17:46:10] there's gotta be a way [17:46:20] * cwdent puts on xdebug goggles [17:47:14] I know I'm going back n forth on whether it's worthwhile to write a test for broken schema, but currently I'm thinking that it will make us more confident that our migrations are correct, or expose incorrectness. [17:47:59] Feel free to merge stuff while you're in there, I think it's just you and me for the forseeable future, and my tower of patches is getting pretty rickety [17:49:33] Wikimedia-Fundraising, Community-Liaison, Performance-Team, Privacy: parsing legacy GeoIP cookies fails (no regex match), enwiki geonotice broken for users with those legacy cookies - https://phabricator.wikimedia.org/T103720#1397236 (jeremyb-phone) NEW [17:50:05] Wikimedia-Fundraising, Community-Liaison, Performance-Team, Privacy: parsing legacy GeoIP cookies fails (no regex match), enwiki geonotice broken for users with those legacy cookies - https://phabricator.wikimedia.org/T103720#1397236 (jeremyb-phone) [17:50:54] atgo: ^ [17:51:35] awight: sounds good, mostly looks good to go, just need to find the nature of this bug and i'll start merging [17:52:04] cwdent: is your WIP code pushed to gerrit so I can try to reproduce manually? [17:52:20] awight: argh. need anything from me? [17:53:25] awight: i'm on a totally vanilla version of the tip of master :-\ [17:54:10] i've burned everythign to the ground and the error persists [17:54:16] i literally can't even [17:54:29] Main take-away from SoS: deployments roadmap in the process of moving to Phabricator: https://phabricator.wikimedia.org/project/sprint/board/1109/ [17:54:33] cwdent: master is currently not OK [17:54:45] cwdent: you need lots of those queued changes to get the correct schema [17:55:26] aha, ok [17:55:34] awight: want to check in on the recurring stuff later? seems like you're in deep on this thing? [17:55:35] what is the minimum viable commit? [17:58:00] i didn't realize master was still broke post those reverts [17:58:04] awight: moved the meeting :) [17:58:13] Wikimedia-Fundraising, Community-Liaison, Performance-Team, Privacy: parsing legacy GeoIP cookies fails (no regex match), enwiki geonotice broken for users with those legacy cookies - https://phabricator.wikimedia.org/T103720#1397260 (awight) Confirmed that this is a problem, and I think @Jeremyb is... [17:58:20] atgo: oh, now would be fine [17:58:31] ok i've got a few min with lisa, so i'll just grab you when i'm done [17:58:34] if that's OK [17:58:36] sure [17:58:47] (almost type "sire" which would be feudally funny) [17:59:54] cwdent: you really want at least https://gerrit.wikimedia.org/r/#/c/219480/ [18:00:06] You should base your work on the tip of that chain [18:03:43] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Amend rule for Engage team members - https://phabricator.wikimedia.org/T101179#1397283 (awight) @RLewis We're hoping to get confirmation that the keying staff is abl... [18:09:27] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1397312 (awight) Templates refer to target contact by numeric... [18:10:05] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1397316 (awight) [18:13:12] (PS5) Awight: Remove fictitious letter_code field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219437 [18:13:17] (PS5) Awight: Iterate offline keying template [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219438 [18:13:21] (PS14) Awight: Test more fields used by WmfImportFile format [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/218567 [18:13:28] (PS5) Awight: Passthrough more payment types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219492 (https://phabricator.wikimedia.org/T88836) [18:13:32] (PS5) Awight: Drop "Amount (USD)" column [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219493 (https://phabricator.wikimedia.org/T88836) [18:13:37] (PS5) Awight: Update Civi to pick up fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219498 [18:13:41] (PS5) Awight: Migration for Restrictions and Gift Source options [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219480 [18:13:46] (PS2) Awight: Draft template for Organization import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219997 (https://phabricator.wikimedia.org/T88836) [18:13:52] (PS2) Awight: Provide Generic Org import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220001 [18:14:02] awight: bannerStats? [18:15:09] (Abandoned) Awight: Draft template for Organization import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219997 (https://phabricator.wikimedia.org/T88836) (owner: Awight) [18:15:55] (PS3) Awight: Provide Generic Org import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220001 (https://phabricator.wikimedia.org/T88836) [18:16:09] AndyRussG: sorry, what's the context? [18:16:35] CN RL modules are flying about and I'm wondering where to settle that one... [18:17:22] settle like where a pigeon goes at night? [18:17:37] Like, marke with a TODO to deprecate, I guess? [18:18:03] Yes a big jolly roger [18:18:17] Is this wrt SoS? [18:18:45] (CR) jenkins-bot: [V: -1] Migration for Restrictions and Gift Source options [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219480 (owner: Awight) [18:19:38] awight: No, not SoS, just banner history refactor stuff [18:19:59] (CR) jenkins-bot: [V: -1] Provide Generic Org import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220001 (https://phabricator.wikimedia.org/T88836) (owner: Awight) [18:20:52] Hmm, yeah I think we're on the same page. The existing banner stats infrastructure is dragging us down. [18:21:08] We can't get rid of it until banner history or other mechanisms have been proven in the field, though. [18:21:43] Banner stats are definitely covered by our code freeze, unfortunately, so IMO we shouldn't try replacing after August or so. [18:22:00] Wait what are we talking about? [18:22:02] Perfectly fine to build up the shadow solution during that time, however. [18:22:43] awight: bannerStats RL module has... no code? [18:23:10] oh dear. I thought we were talking about DjangoBannerStats [18:23:18] Aaaaaaaaaaaaaaahhhhh [18:23:25] * AndyRussG sighs in relief [18:23:28] * awight rerereads [18:23:37] I wasn't clear, sorrrry [18:23:50] https://www.mediawiki.org/wiki/Extension:CentralNotice/Notes/Banner_controller_refactoring ? [18:23:53] I don't see bannerStats [18:24:07] hehe, I'm never clear, no worries [18:24:48] Right! And... I don't see it added anywhere.... Mmmm just I want to mark it with a TODO and shuttle it to a section of the .modules.php file where I'm putting other stuff that I'm... axing heheheheh <_< [18:28:05] Gotcha--heartily agreed. There was only one commit to that module, in 2012 [18:28:21] Thanks for noticing it! [18:28:53] awight: Ah K... thanks! Mmm just scolding myself after I realized I hadn't looked at it before 8p [18:38:01] awight: BTW also if you want to tear down any parts of https://www.mediawiki.org/wiki/Extension:CentralNotice/Notes/Banner_controller_refactoring, now's the time! [18:39:05] AndyRussG: docstrings on your proposed api functions would be appreciated, I still don't understand well enuf to give any feedback on bannersWillDisplay vs cancelBanner [18:40:02] It might be helpful to document the Mixin api also, i.e. I have no idea how setPreBannerHandler should work [18:40:13] awight: Ah OK yes good point [18:40:30] I may just document in the WIP code, too... [18:40:41] sure, that works. I should probably just read the code [18:42:12] btw, I'm running into a less than charming Gerrit workflow issue that might affect you, too. I've amended a patch deep in a feature branch, and realized that now I can't work on the tip without clicking the "rebase" button on everything in between, or else I'll overwrite the amended patch with an older patchset when pushing new work. [18:42:17] wheeee [18:43:20] another random API criticism, I'm still uncomfortable about the KVstorage stuff not being encapsulated in a class. [18:43:35] awight: ah it's getting encapsulated! [18:44:01] cool. If it's generic, it should be encapsulated, if coupled to something, then the name should reflect that [18:44:03] awight: WRT Gerrit, what repo? Is CN impcated? [18:44:27] AndyRussG: nope, the crm repo. Just noting cos you also have long feature branches. [18:44:38] awight: aaaaah right [18:44:51] XenoRyet: did you say that you needed help reviewing this task? https://phabricator.wikimedia.org/T86214 [18:45:33] Yea, awight looked at it, and I made some changes based on that, now it needs reviewed again. [18:45:43] ooh kk [18:45:46] XenoRyet: awesome. I need to run locally, but the code looked good to me. [18:45:52] Cool [18:45:59] Sorry I'm bottleneck-shaped [18:46:09] Yea, no worries, I understand. [18:46:15] oh hey, https://plus.google.com/hangouts/_/wikimedia.org/can-we-close?authuser=0 [18:46:28] sorry to bug. I'm not totally able to decode all of the conversations here just yet [18:46:44] dstrine: did you want to do IRC-only, or with a video link as well? [18:46:44] Wuz there a checkin now or not? I guess I have nothing to close per se [18:46:53] no just chatting here [18:47:28] there was a feeling yesterday during standup that people were waiting on info and help [18:47:30] dstrine: What do you recommend we do about the blocked orphan slayer stuff? [18:47:39] dstrine: ah OK [18:47:40] Is there a good way to tag that? [18:49:24] (CR) Legoktm: [C: 2] Replace deprecated $wgSpecialPageGroups [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/220211 (owner: Umherirrender) [18:49:39] (Merged) jenkins-bot: Replace deprecated $wgSpecialPageGroups [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/220211 (owner: Umherirrender) [18:52:21] Wikimedia-Fundraising, Community-Liaison, Performance-Team, Privacy: parsing legacy GeoIP cookies fails (no regex match), enwiki geonotice broken for users with those legacy cookies - https://phabricator.wikimedia.org/T103720#1397464 (Gilles) I see, so the old format is getting cached for a long tim... [18:52:23] (CR) Legoktm: [C: 2] Replace deprecated $wgSpecialPageGroups [extensions/ContributionReporting] - https://gerrit.wikimedia.org/r/220229 (owner: Umherirrender) [18:53:25] (Merged) jenkins-bot: Replace deprecated $wgSpecialPageGroups [extensions/ContributionReporting] - https://gerrit.wikimedia.org/r/220229 (owner: Umherirrender) [18:56:02] Wikimedia-Fundraising, Community-Liaison, Performance-Team, Privacy: parsing legacy GeoIP cookies fails (no regex match), enwiki geonotice broken for users with those legacy cookies - https://phabricator.wikimedia.org/T103720#1397473 (Gilles) a:Gilles [19:00:12] cwdent: Hey, good news--I can sort of reproduce a migration error locally :) [19:00:56] ok well is sounds like everyone has talked. I just wanted to make sure people got a chance to sync this morning. [19:16:22] Awight: what error? The implode one? [19:17:57] cwdent: this one https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm/366/console [19:18:08] Turns out I didn't reproduce the same thing as here [19:18:10] aaargh [19:20:36] (PS6) Awight: Migration for Restrictions and Gift Source options [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219480 [19:20:59] (CR) jenkins-bot: [V: -1] Migration for Restrictions and Gift Source options [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219480 (owner: Awight) [19:22:33] (PS7) Awight: WIP Migration for Restrictions and Gift Source options [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219480 [19:22:57] (CR) jenkins-bot: [V: -1] WIP Migration for Restrictions and Gift Source options [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219480 (owner: Awight) [19:24:14] (PS8) Awight: WIP Migration for Restrictions and Gift Source options [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219480 [19:24:35] (CR) jenkins-bot: [V: -1] WIP Migration for Restrictions and Gift Source options [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219480 (owner: Awight) [19:25:03] omg. [19:25:24] (PS4) Awight: Provide Generic Org import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220001 (https://phabricator.wikimedia.org/T88836) [19:25:26] (PS9) Awight: WIP Migration for Restrictions and Gift Source options [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219480 [19:25:47] (CR) jenkins-bot: [V: -1] Provide Generic Org import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220001 (https://phabricator.wikimedia.org/T88836) (owner: Awight) [19:25:56] hi awight :) [19:26:01] you look rather busy! [19:26:14] (CR) jenkins-bot: [V: -1] WIP Migration for Restrictions and Gift Source options [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219480 (owner: Awight) [19:26:19] is there a good time I can come bother you today for 15 minutes or so? [19:27:10] ccogdill: any time! [19:27:27] woohoo! are you in the office today? [19:27:30] yah [19:27:36] mind if I come down? [19:27:51] of course [19:28:24] I’m going to take that as you DON’T mind :p [19:28:27] be right down! [19:28:30] cwdent: can you kick this one? https://gerrit.wikimedia.org/r/#/c/219495/ [19:28:35] It's blocking CI... [19:34:46] (PS1) Gilles: Parse older format of Geo cookies [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/220559 (https://phabricator.wikimedia.org/T103720) [19:36:39] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Amend rule for Engage team members - https://phabricator.wikimedia.org/T101179#1397583 (RLewis) @awight confirmed they can enter additional gift sources. [19:39:00] (PS2) Gilles: Parse older format of Geo cookies [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/220559 (https://phabricator.wikimedia.org/T103720) [19:48:21] (CR) Cdentinger: [C: 2] Only delete option groups that exist [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/219495 (owner: Awight) [19:49:03] (Merged) jenkins-bot: Only delete option groups that exist [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/219495 (owner: Awight) [20:01:43] Fundraising-Backlog: Replicate silverpop export (barium) on lutetium - https://phabricator.wikimedia.org/T103740#1397685 (CCogdill_WMF) NEW [20:02:22] awight|afk: syntax error in wmf_civicrm_update_7032() ?? [20:02:25] that's a new one [20:03:58] Wikimedia-Fundraising, Community-Liaison, Performance-Team, Patch-For-Review, Privacy: parsing legacy GeoIP cookies fails (no regex match), enwiki geonotice broken for users with those legacy cookies - https://phabricator.wikimedia.org/T103720#1397696 (AndyRussG) Where can I see an example of a l... [20:10:15] cwdent: I've tracked that down like 3 times now :( [20:10:29] It all comes back to that Civi patch u just merged (thx) [20:10:43] aah right on [20:11:01] awight|afk: sometimes i seriously have no idea why diff conflicts: http://i.imgur.com/6Py65T8.png [20:11:06] can you explain that? [20:12:09] meh, there were some changes on the other branch I suppose. I remember I added 7032 temporarily, then removed it again [20:12:40] oooh, so 7032 is gone now? [20:13:27] nah [20:13:57] I had done something crazy where I cherry-picked 7032 to master so you could have it early, but that was ridiculous, so I put it back in the patch chain [20:14:27] word [20:14:48] in a vacuum i don't understand why that patch wouldn't apply cleanly [20:15:08] but that's also like the least worthwhile thing to investigate [20:15:57] cwdent: It all depends on how you're doing the merge, AFAIK [20:16:14] sometimes u make it easy for git, sometimes difficult [20:16:36] (PS5) Awight: Provide Generic Org import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220001 (https://phabricator.wikimedia.org/T88836) [20:16:38] (PS10) Awight: Migration for Restrictions and Gift Source options [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219480 [20:18:13] Wikimedia-Fundraising, Community-Liaison, Performance-Team, Patch-For-Review, Privacy: parsing legacy GeoIP cookies fails (no regex match), enwiki geonotice broken for users with those legacy cookies - https://phabricator.wikimedia.org/T103720#1397756 (awight) You can make a legacy cookie by dele... [20:19:10] cwdent: I can make lots of time for helping unblock you, just lmk how it goes basing your work on https://gerrit.wikimedia.org/r/220001 [20:20:01] awight: ok! i'll slap that on right now [20:20:23] Don't play it through your nice speakers :p [20:21:27] heheh, victrola only [20:22:40] awight: so i try to fetch that on top of master and it cries. am i crazy? [20:23:18] (PS9) Awight: Red Text validation messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/217158 (https://phabricator.wikimedia.org/T86214) (owner: XenoRyet) [20:25:45] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, and 5 others: Change errors on GC forms from popup to red text - https://phabricator.wikimedia.org/T86214#1397800 (awight) Uploading some screenshots so @MeganHernandez... [20:28:11] (CR) Awight: "Looks really good and I've verified it works locally. Just one more clean-up thing, we need the styles to be encapsulated in classes so t" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/217158 (https://phabricator.wikimedia.org/T86214) (owner: XenoRyet) [20:28:14] (CR) Awight: [C: -1] Red Text validation messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/217158 (https://phabricator.wikimedia.org/T86214) (owner: XenoRyet) [20:29:05] XenoRyet: Elegant hack btw! I'm wowed by how little you had to change in validate_input.js [20:29:22] cwdent: What are you doing, exactly? [20:29:37] Thanks, I was really trying to have as light a touch there as possible, so as not to break things I didn't know about yet. [20:29:38] I'm suggesting something like, "git review -d 220001; git cherry-pick SQUARE" [20:30:07] XenoRyet: yeah that is admirable. I see you've worked in legacy systems before ;) [20:30:22] ;-) [20:30:25] awight: i just copied the fetch command from gerrit and tried it on master [20:31:05] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Amend rule for Engage team members - https://phabricator.wikimedia.org/T101179#1397808 (awight) Open>Resolved Thanks! [20:31:06] not messing with the square stuff yet [20:31:23] cwdent: naw, you will need that entire patch chain [20:31:38] review -d should do the trick [20:32:04] ah, ok i was wondering about that [20:32:08] thx [20:52:56] Wikimedia-Fundraising, Community-Liaison, Performance-Team, Patch-For-Review, Privacy: parsing legacy GeoIP cookies fails (no regex match), enwiki geonotice broken for users with those legacy cookies - https://phabricator.wikimedia.org/T103720#1397850 (Gilles) Example of new format cookie: ```... [20:57:04] Fundraising-Backlog, fundraising-tech-ops: Replicate silverpop export (barium) on lutetium - https://phabricator.wikimedia.org/T103740#1397864 (atgo) [21:01:53] cwdent: u might take a peel at wmf_common/WmfException.php [21:01:56] peek [21:02:07] awight: getting the square file to handle a refund for a non-existent donation might require messing with the general refund stuff [21:02:16] do you think? [21:02:25] and if so should that block this? [21:02:36] I think we should just kick the message out and scream about it [21:04:33] it doesn't seem to error in that situation right now [21:04:38] but i may be missing something [21:04:51] What is the precedent? [21:05:06] The coinbase thing is specifically horrific [21:05:41] awight: check out the file attached here: https://phabricator.wikimedia.org/T92582 [21:05:54] And, I'm pretty sure wmf_civicrm_mark_refund will die loudly if you try to refund a non-existent contrib [21:05:57] dave@gmail [21:06:17] ok [21:06:46] hrm, ok let me dig at this a little more and make sure i got the basic logic right [21:06:53] Will that payment ID match the original contrib? [21:07:09] Did you happen to mail them asking for more complete sample data? [21:07:26] good question [21:07:29] and i think atgo did [21:07:32] Seems like we're missing information about what they'll do to actually refund [21:07:38] yep [21:08:12] but refunding non existent donations would be a good extortion vector [21:08:19] all the time! [21:08:37] or, would tell us we're getting crap data from the vendor [21:09:20] You might also ask them if they can guarantee that the refund appears after the payment, if they are nearly simultaneous [21:09:44] i did cwdent [21:12:38] i'm at the library in boulder today and there's a large and crowded kale festival going on outside [21:12:56] that is so crunchy [21:13:24] without a hint of irony or self deprecation [21:14:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: TargetSmart to update Civi contact information for the LA region - https://phabricator.wikimedia.org/T97196#1397937 (atgo) a:atgo>None [21:14:10] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Amend fields for International Check Importer - https://phabricator.wikimedia.org/T92325#1397938 (atgo) a:atgo>None [21:14:12] Not a Cale festival? [21:15:01] no i'm pretty sure that would only happen in chelsea [21:19:05] Wikimedia-Fundraising, Community-Liaison, Performance-Team, Patch-For-Review, Privacy: parsing legacy GeoIP cookies fails (no regex match), enwiki geonotice broken for users with those legacy cookies - https://phabricator.wikimedia.org/T103720#1397970 (AndyRussG) OK... If I remove region from the... [21:33:16] (PS1) Awight: Implement contact relationship import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220628 (https://phabricator.wikimedia.org/T88836) [21:56:28] (PS1) Awight: WIP Import name prefix and suffix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220629 (https://phabricator.wikimedia.org/T88836) [21:57:03] (CR) jenkins-bot: [V: -1] WIP Import name prefix and suffix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220629 (https://phabricator.wikimedia.org/T88836) (owner: Awight) [21:58:56] (PS2) Awight: Import name prefix and suffix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220629 (https://phabricator.wikimedia.org/T88836) [22:08:00] hey MBeat - i tagged you in this before you had visibility [22:08:02] https://phabricator.wikimedia.org/T92582 [22:08:03] awight, AndyRussG, atgo, cwdent, dstrine, XenoRyet: Please blame everything on this: http://www.swpc.noaa.gov/news/another-storm-forecast-wednesday-nightthursday [22:08:41] ah, thanks for heads up atgo [22:08:59] it would be awesome to get that file attached, and if not i'll get questions answered by Ayo [22:13:57] take a look and see if you can open it, atgo-meeting [22:14:25] MBeat: not seeing the attachment? [22:14:34] there it goes :) [22:14:38] reload? [22:34:14] Fundraising-Backlog: Wikimania! GOAL: - https://phabricator.wikimedia.org/T102197#1398166 (atgo) [22:36:41] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner history mixins and data - https://phabricator.wikimedia.org/T90918#1398195 (AndyRussG) a:AndyRussG [22:36:53] Wikimedia-Fundraising, Community-Liaison, Performance-Team, Patch-For-Review, Privacy: parsing legacy GeoIP cookies fails (no regex match), enwiki geonotice broken for users with those legacy cookies - https://phabricator.wikimedia.org/T103720#1398196 (jeremyb) I wasn't getting console errors but... [22:39:55] Fundraising-Backlog: [Finish Q4] GOAL: Clear out Q4 goals! Wrap up Astropay round 1 and banner history - https://phabricator.wikimedia.org/T102196#1398215 (atgo) [22:49:59] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Deploy patch so that GR can import TargetSmart to update Civi contact information for the LA region - https://phabricator.wikimedia.org/T97196#1398227 (atgo) [22:50:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Deploy patch so that GR can import TargetSmart to update Civi contact information for the LA region - https://phabricator.wikimedia.org/T97196#1235468 (atgo) [22:56:23] Fundraising Sprint Flaming Lips, Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, and 6 others: Implement campaign associated mixins per findings from T90913 - https://phabricator.wikimedia.org/T90915#1398265 (AndyRussG) [22:57:13] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Refactor bannerController API as required for banner history - https://phabricator.wikimedia.org/T100686#1398266 (AndyRussG) [22:59:11] Fundraising Sprint Lou Reed, Fundraising Sprint N, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Few/no banners shown on 1 June? - https://phabricator.wikimedia.org/T101265#1398283 (atgo) [22:59:14] Fundraising Sprint N, Fundraising Tech Backlog, Fundraising-Backlog, Astropay Integration: Write Astropay audit file processor - https://phabricator.wikimedia.org/T90507#1398286 (atgo) [22:59:24] Fundraising Sprint N, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Deploy patch so that GR can import TargetSmart to update Civi contact information for the LA region - https://phabricator.wikimedia.org/T97196#1398287 (atgo) [23:00:12] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint N, Fundraising Tech Backlog, and 3 others: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1398299 (atgo) [23:00:21] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint N, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Refactor bannerController API as required for banner history - https://phabricator.wikimedia.org/T100686#1398301 (atgo) [23:01:09] Fundraising Sprint Miles Davis, Fundraising Sprint N, Unplanned-Sprint-Work, WMF FR, Patch-For-Review: Drupal 7.38 upgrade - https://phabricator.wikimedia.org/T103006#1398320 (DStrine) [23:01:10] Fundraising Dash, Fundraising Sprint Miles Davis, Fundraising Sprint N, Wikimedia-Fundraising-CiviCRM: Generate fake data for Dash/CiviCRM - https://phabricator.wikimedia.org/T101904#1398321 (DStrine) [23:01:12] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint N, and 3 others: Upgrade payments mw-core to REL1_25 - https://phabricator.wikimedia.org/T94528#1398322 (DStrine) [23:01:30] Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, and 4 others: Document how the new queueing stuff will work - https://phabricator.wikimedia.org/T96434#1398332 (DStrine) [23:01:42] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint N, Fundraising Tech Backlog, Unplanned-Sprint-Work: Find a PHP Redis client that supports CAS transactions against a cluster - https://phabricator.wikimedia.org/T103206#1398335 (DStrine) [23:01:44] Fundraising Sprint Miles Davis, Fundraising Sprint N, Astropay Integration: Some style issues with Astropay form - https://phabricator.wikimedia.org/T101234#1398336 (DStrine) [23:01:46] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint N, Wikimedia-Fundraising-CiviCRM: Recent Engage Import - Contribution Type = Cash when it should be Engage - https://phabricator.wikimedia.org/T100853#1398337 (DStrine) [23:02:16] Fundraising Sprint Lou Reed, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Few/no banners shown on 1 June? - https://phabricator.wikimedia.org/T101265#1398339 (atgo) [23:04:13] Fundraising Sprint N, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner history mixins and data - https://phabricator.wikimedia.org/T90918#1398354 (AndyRussG) [23:05:11] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint N, and 3 others: Provide access to limbo messages without knowing keys - https://phabricator.wikimedia.org/T99152#1398362 (DStrine) [23:05:49] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint N, and 3 others: Orphan slayer reads from frack Redis rather than ActiveMQ - https://phabricator.wikimedia.org/T99017#1398368 (DStrine) [23:06:29] Fundraising Sprint Flaming Lips, Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, and 7 others: Implement campaign associated mixins per findings from T90913 - https://phabricator.wikimedia.org/T90915#1398374 (AndyRussG) [23:06:56] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, and 5 others: CentralNotice: key-value storage for new campaign-associated mixins/banner history - https://phabricator.wikimedia.org/T94763#1398383 (DStrine) [23:07:20] Fundraising-Backlog, Recurring-Donations: Spike: Use WMF-hosted unsubscribe page for Fundraising emails, make conditional opt-out options - https://phabricator.wikimedia.org/T99821#1398390 (atgo) [23:08:23] Fundraising Dash, Fundraising Sprint Miles Davis, Fundraising Sprint N: "Get Test" in A/B testing header - https://phabricator.wikimedia.org/T89990#1398398 (DStrine) [23:08:46] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint N, and 2 others: Confirm orphan slaying works once using Redis, then stop writing to ActiveMQ - https://phabricator.wikimedia.org/T99018#1398403 (awight) Taking out of the sprint until it's... [23:08:56] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Confirm orphan slaying works once using Redis, then stop writing to ActiveMQ - https://phabricator.wikimedia.org/T99018#1398405 (awight) [23:09:24] Fundraising Dash, Fundraising Sprint Miles Davis, Fundraising Sprint N: Create "A/B testing" board in Dash - https://phabricator.wikimedia.org/T98927#1281111 (DStrine) [23:09:26] Fundraising Dash, Fundraising-Backlog: Search and return results for Campaign name - https://phabricator.wikimedia.org/T89980#1398410 (atgo) [23:09:55] Fundraising Dash, operations: Create sandbox site for Dash - https://phabricator.wikimedia.org/T87809#1398412 (atgo) [23:10:04] Fundraising Dash, MediaWiki-Vagrant: create vagrant role for fundraising dash - https://phabricator.wikimedia.org/T99869#1398413 (atgo) [23:10:20] Fundraising Dash, Fundraising Sprint Miles Davis, Fundraising Sprint N, Fundraising-Backlog: Create "A/B testing" board in Dash - https://phabricator.wikimedia.org/T98927#1398416 (atgo) [23:10:36] Fundraising Dash, Fundraising Sprint Miles Davis, Fundraising-Backlog: Create "A/B testing" board in Dash - https://phabricator.wikimedia.org/T98927#1281111 (atgo) [23:10:43] Fundraising Dash, Fundraising Sprint Miles Davis: "Get Test" in A/B testing header - https://phabricator.wikimedia.org/T89990#1398421 (atgo) [23:23:27] Fundraising Sprint N, Fundraising Tech Backlog, Fundraising-Backlog, Astropay Integration: Write Astropay audit file processor - https://phabricator.wikimedia.org/T90507#1398442 (awight) a:awight [23:23:39] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner history mixins and data - https://phabricator.wikimedia.org/T90918#1398443 (DStrine) [23:26:41] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Recent Engage Import - Contribution Type = Cash when it should be Engage - https://phabricator.wikimedia.org/T100853#1398453 (DStrine) [23:46:00] i gotta catch my ride back to longmont! [23:59:52] Fundraising Dash, Fundraising Sprint Miles Davis, Fundraising Sprint N*E*R*D, Wikimedia-Fundraising-CiviCRM: Generate fake data for Dash/CiviCRM - https://phabricator.wikimedia.org/T101904#1398576 (awight) Awesome. The only tweak I would suggest is to make the data slightly less realistic. It may...