[00:00:24] (CR) Awight: "recheck" [wikimedia/fundraising/crm/drupal] (contrib) - https://gerrit.wikimedia.org/r/219443 (https://phabricator.wikimedia.org/T103006) (owner: Ejegg) [00:00:44] (CR) Awight: "The issue here is that the CI job is picking up an outdated crm master branch." [wikimedia/fundraising/crm/drupal] (contrib) - https://gerrit.wikimedia.org/r/219443 (https://phabricator.wikimedia.org/T103006) (owner: Ejegg) [00:02:34] (CR) AndyRussG: "recheck" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [00:04:31] awight: https://gerrit.wikimedia.org/r/#/c/202310/ :) [00:04:56] (tests now pass following the merge of the le last RL core changement) [00:10:57] (CR) Awight: "recheck" [wikimedia/fundraising/crm/drupal] (contrib) - https://gerrit.wikimedia.org/r/219443 (https://phabricator.wikimedia.org/T103006) (owner: Ejegg) [00:11:05] (CR) Awight: "Previous comment was wrong." [wikimedia/fundraising/crm/drupal] (contrib) - https://gerrit.wikimedia.org/r/219443 (https://phabricator.wikimedia.org/T103006) (owner: Ejegg) [00:14:43] (CR) Awight: [C: 2] Merge branch 'master' into campaign_mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/219120 (owner: AndyRussG) [00:14:58] (CR) Awight: [C: 2] Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [00:15:09] awight: weeee! :) [00:15:21] (CR) jenkins-bot: [V: -1] Merge branch 'master' into campaign_mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/219120 (owner: AndyRussG) [00:15:23] (CR) jenkins-bot: [V: -1] Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [00:15:25] (CR) jenkins-bot: [V: -1] bannerController.lib: KV store with localStorage [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) (owner: AndyRussG) [00:15:36] awwwwwwww wut? [00:15:45] 00:00:08.192 /tmp/hudson780356142644053216.sh: line 3: /srv/deployment/integration/slave-scripts/bin/mw-set-env-qunit.sh: No such file or directory [00:15:52] Probably not your fault [00:16:02] Fundraising Sprint Miles Davis, Fundraising Sprint N*E*R*D, Unplanned-Sprint-Work, WMF FR, Patch-For-Review: Drupal 7.38 upgrade - https://phabricator.wikimedia.org/T103006#1398623 (awight) I can confirm that the upgrade is still breaking at wmf_civicrm:7014, but new code is checked out to the cr... [00:41:26] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/220672 [00:41:45] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/220672 (owner: Awight) [00:41:50] (Merged) jenkins-bot: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/220672 (owner: Awight) [00:43:02] !log update crm from bd8a00196071ddd04efbff7b30567dd9357c9000 to e923225e423948bd70440e2d1131460b10cefac1 [00:43:08] Logged the message, Master [00:49:26] XenoRyet: Hey, I moved that red text card back to "Doing" just so it catches my eye when you do the next iteration! [00:49:39] Good call [00:50:25] Anything to break the monotony ;) the next thing I'm supposed to do is write an audit processor... /me tongues around for the cyanide tooth [00:54:06] (PS3) Awight: WIP / DO NOT MERGE - GC WX audit module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/199653 (owner: Katie Horn) [00:54:19] (PS4) Awight: WIP / DO NOT MERGE - GC WX audit module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/199653 (https://phabricator.wikimedia.org/T86090) (owner: Katie Horn) [00:56:16] (CR) AndyRussG: "recheck" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/219120 (owner: AndyRussG) [01:00:50] (PS5) Awight: WIP / DO NOT MERGE - GC WX audit module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/199653 (https://phabricator.wikimedia.org/T86090) (owner: Katie Horn) [01:01:10] (CR) AndyRussG: "recheck" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/219120 (owner: AndyRussG) [01:05:45] (PS6) Awight: GlobalCollect WX audit module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/199653 (https://phabricator.wikimedia.org/T86090) (owner: Katie Horn) [01:05:47] (PS1) Awight: Move GC audit module to _old [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220680 (https://phabricator.wikimedia.org/T86090) [01:13:48] (CR) Krinkle: "recheck" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/219120 (owner: AndyRussG) [01:14:03] (CR) AndyRussG: "recheck" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/219120 (owner: AndyRussG) [02:53:59] (PS1) AndyRussG: Remove unused BannerStats RL module [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/220696 [02:54:44] (CR) jenkins-bot: [V: -1] Remove unused BannerStats RL module [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/220696 (owner: AndyRussG) [03:06:25] (CR) AndyRussG: "recheck" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/220696 (owner: AndyRussG) [06:00:11] (PS1) Awight: Use new names for fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220708 [06:00:13] (PS1) Awight: Step up convenience function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220709 [06:00:15] (PS1) Awight: Remove unsupported "direct" mode [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220710 [06:00:17] (PS1) Awight: WIP remove audit cruft [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220711 [06:42:12] (PS1) Awight: WIP Minimum split of BaseAuditProcessor from functions that don't require context [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220714 [08:09:02] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, and 6 others: Change errors on GC forms from popup to red text - https://phabricator.wikimedia.org/T86214#1399392 (MeganHernandez_WMF) Thank you! So great this is happe... [15:12:42] Morning cwdent! [15:13:15] howdy AndyRussG [15:13:18] how's mexico? [15:13:49] Not bad! I haven't left my parents-in-law's apartment since we arrived though, heh ;) [15:14:17] It's an interesting feeling though... Coming back to something so familiar, after leaving a place that's so familiar, too [15:14:52] We'll see how it feels after a month of us all piled in here 8p [15:15:09] How's everything with you? [15:16:00] good! same old stuff here [15:16:16] sounds like you all must get along well [15:16:41] Heheheh it has its ups and downs! [15:17:24] My parents-in-law were understandbaly not thrilled when we moved to Canada [15:18:05] Overall yes, we get a long well, though.... they live in the same apartment complex where we used to live, so we did see each other often [15:18:17] We stayed with them when we came in December, too [15:18:48] you are from montreal originally? [15:20:19] Almost! I mean, yes, principally--I grew up there, though in fact I was born in the U.S., in the Bay Area. Moved to Montreal when I was 1 1/2 years old, so it seems like the right place to answer when people ask where I'm "from" [15:20:51] ha that's interesting [15:21:08] When people in Montreal ask us where we're from collectively as a family, I'll say Mexico, though ;) [15:21:42] are you a canadian citizen? [15:21:49] or dual? [15:21:56] Did you grow up in Colorado? (Sorry if you've told me this before--I think you may have!!! Rggg early onset senility...) [15:22:12] Dual U.S./Canadian [15:22:28] nice [15:22:37] i was born in new mexico but grew up in duluth minnesota [15:22:55] been in colorado about 7 years [15:23:34] Ah hmmm [15:23:42] Did you move to Colorado for work? [15:24:17] nah, for weather. i had had enough mn winters [15:25:27] i love the mountains but i miss the water [15:25:45] Hmmm right [15:25:54] Yeah I did once go to Thunder Bay in the winter! Rough! [15:26:52] We had a pretty intense Winter in Montreal this year, too... A lot more really cold days than there used to be, I think [15:27:00] not too far from duluth! the whole north shore of lake superior is brutal [15:28:01] What do you miss about the lake? Did you fish or go boating there, or do you mean mainly the view? [15:29:02] oh i was an avid fisherman and canoeist [15:29:46] there's some alright stream fishing in colorado but really nowhere worth getting in a boat IMO [15:31:00] Ah cool! [15:32:21] The other day we saw some folks fishing in a the Lachine Canal (an old waterway with docks that connects with the St. Laurence River here, now used for recreation) [15:32:55] I have no idea what the pollution content of those fish would be... At least on Lake Superior you're much further upstream... [15:33:25] (PS1) Cdentinger: adds engage test data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220778 [15:33:26] s/docks/locks/ [15:34:40] heh yeah lake superior is relatively clean [15:34:52] but they're building that oil pipline right through duluth so we'll see [15:35:54] arg yeah potential for disaster there... :( [15:38:32] * AndyRussG worries how we're going to look the next generations in the eye WRT climate change, mass extinctions, etc. [15:40:30] Fundraising Dash, Fundraising Sprint Miles Davis, Fundraising Sprint N*E*R*D, Wikimedia-Fundraising-CiviCRM: Generate fake data for Dash/CiviCRM - https://phabricator.wikimedia.org/T101904#1400787 (cwdent) easy as /\(Corporate Gift,[^ ]* \)/\1TEST / i just put them in a test_data dir for now, lmk... [15:44:30] me too :-\ [15:48:01] cwdent: quick question: when you go to English WP, are you getting "NS_ERROR_DOM_QUOTA_REACHED: Persistent storage maximum size reached" errors? [15:52:01] hmm no i don't see anything in chrome [15:52:06] just any old page? [15:55:44] Yeah [15:55:51] Or in Firefox? [15:56:35] well i'm on the chromebook :P but let me check the real computer [15:59:29] AndyRussG: no errors in ff either, but i am also not seeing any banners [15:59:57] hey all, we kind of left sprint planning in a hurry. are there any tickets in the doing column that should be in the review column? https://phabricator.wikimedia.org/tag/fundraising_sprint_n*e*r*d/ [15:59:59] cwdent: good about the errors, I don't know if you should be seeing banners or anything [16:01:11] dstrine: mine are correct [16:01:14] cwdent: yeah the errors I'm getting are not from CentralNotice, they're from ResourceLoader filling up localStorage, which is just worrisome because we are about to start using localStorage [16:01:16] perhaps these? https://phabricator.wikimedia.org/T86214 [16:01:22] https://phabricator.wikimedia.org/T103006 [16:03:12] (CR) Awight: "Well, if it's gonna live in that module, how about the existing tests/data dir?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220778 (owner: Cdentinger) [16:03:56] awight: i was gonna put it there, but i thought maybe it's conceptually different because it isn't used by automated tests? [16:04:10] not yet ;) OK sure, I buy it [16:04:28] but yeah it very well could be [16:04:33] * awight reads http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-fundraising/20150625.txt for more context [16:05:12] nice, didn't know there was persistent scrollback [16:05:25] dstrine: Ah, yeah I moved T103006 back into Doing because there's a hiccough with the upgrade. Not sure we should spend the time to debug it right now cos this is not a critical upgrade. [16:05:32] or at least, outside of freenode [16:06:17] and T86214 is back in Doing for a small thing XenoRyet is correcting, just the next lane change makes it obvious when it's ready for review again [16:06:41] cwdent: Is there one built into freenode? [16:07:23] awight: hi! Hopefully the Jenkins QUnit issue is all resolv'd now, if you feel like kicking any patches... Here's a new one BTW, now at the head of the same series: https://gerrit.wikimedia.org/r/#/c/220696/ [16:07:24] i assumed that but maybe i'm dumb [16:07:36] K4-713: hey, when you have the chance, can you add http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-fundraising to the topic again, or give me privs to do so? [16:08:04] hm [16:08:08] ...probably? [16:08:11] this is really good https://www.youtube.com/watch?v=wJelEXaPhJ8&feature=youtu.be&t=15 [16:08:12] AndyRussG: great! All it took was a merge from trunk? Or should I not ask... [16:08:44] awight: no, it was a qunit setup issue that Krinkle was working on [16:09:05] hehe ok [16:09:09] trunk? [16:09:13] * AndyRussG reminisces [16:09:20] :D [16:09:32] wier mussen heil master branch [16:10:19] I dunno, I think it's the one that gets merged into the most... [16:11:09] * K4-713 headscratches [16:11:19] (CR) Awight: [C: 2] adds engage test data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220778 (owner: Cdentinger) [16:12:01] (Merged) jenkins-bot: adds engage test data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220778 (owner: Cdentinger) [16:12:04] (CR) Awight: [C: 2] Merge branch 'master' into campaign_mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/219120 (owner: AndyRussG) [16:12:57] oh oops "wir mussen" [16:13:06] (Merged) jenkins-bot: Merge branch 'master' into campaign_mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/219120 (owner: AndyRussG) [16:13:12] (Merged) jenkins-bot: Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [16:13:14] (Merged) jenkins-bot: bannerController.lib: KV store with localStorage [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) (owner: AndyRussG) [16:13:56] Weee! Por fin [16:14:41] AndyRussG: May I cherry-pick the bannerStats change to master, or you have a reason to do it on this feature branch? [16:15:58] awight: not a big reason, just that the feature branch should itself merge to master soon, and I fear possible merge conflicts due to cherry-pick... [16:16:02] awight: Maybe something fundamental has changed? http://wm-bot.wmflabs.org/browser/index.php?start=06%2F25%2F2015&end=06%2F25%2F2015&display=%23wikimedia-fundraising [16:16:30] (CR) Awight: [C: 2] "Thanks for finding this!" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/220696 (owner: AndyRussG) [16:16:36] awight: I did the bannerStas one now 'cause I'm reorganizing the whole modules directory structure and contents [16:17:21] (Merged) jenkins-bot: Remove unused BannerStats RL module [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/220696 (owner: AndyRussG) [16:17:22] K4-713: That's nice! I could live without the "Fork me" banner though... such a grim state of affairs [16:17:30] AndyRussG: right, ok! [16:17:30] So rather than find a cruft-storage location I thought, might as well ditch it... [16:17:36] hehe [16:18:13] awight: It appears to be writing just fine to the index you linked to before, too. [16:18:24] So... what was the... problem? [16:18:36] K4-713: aw jesus, "This page is generated from SQL logs" [16:19:04] K4-713: um the only issue is that there's no link from the channel to those logs. It used to be mentioned in our topic. [16:19:17] lol [16:19:23] awight: thx! [16:19:28] I get it now. [16:20:09] That'll teach me to try to read things before I finish one cup of coffee. [16:20:10] cool, "Convert to wiki text", for those who don't like 
[16:20:22] 	 sorry, I didn't realize!
[16:20:26] 	 Next time, I'm just not logging on. It's the only way to be sure.
[16:20:36] 	 Is "bannerControllerObjects" way too hoaky a name?
[16:20:43] * awight dodges half cup of coffee pouring through keyboard
[16:20:53] 	 ooof!
[16:20:54] 	 AndyRussG: Since you ask, that does sound a little silly
[16:21:15] 	 transferrence coffee, no worries
[16:21:21] 	 bannerControllerLib or bannerController.lib would cause confusion with the old module name that I have to deprecate
[16:21:50] 	 It's not really "banner" anymore
[16:21:56] 	 and bannerController is also taken, by the name of a module I can't deprecate
[16:22:04] 	 (yet)
[16:22:49] 	 FUNRAISING FOLKS!
[16:22:54] 	 I COME BEARING NEWS FROM LABS LAND
[16:23:01] 	 Hi!  Drop by more often
[16:23:13] 	 YuviPanda: hey! :)
[16:23:20] 	 awight: and cwdent https://phabricator.wikimedia.org/T103865 - you guys both have files in your NFS homedirs, mind if I rescue them to somewhere else and get rid of NFS?
[16:23:21] 	 Oh shit, labs has caps lock issues again?
[16:23:22] 	 hi AndyRussG / awight :)
[16:23:35] 	 awight: I just have a messiah complex, different ;)
[16:23:38] 	 YuviPanda: no problem for me
[16:23:40] 	 lolo
[16:23:51] 	 hahah
[16:24:04] 	 Similar symptoms to the uninitiated observer
[16:24:12] 	 indeed
[16:24:21] 	 Well, thank you for thinking to save my files' souls
[16:24:25] 	 I thought it was something worse, like a bug that made turned all donations into refunds
[16:24:35] 	 It's probably just crap anyway, lemme clean up before you bother copying
[16:24:47] 	 awight: alright :)
[16:24:51] 	 AndyRussG: that sounds like a fun bug
[16:25:00] 	 YuviPanda: you can nuke mine
[16:25:25] 	 sweet!
[16:25:33] 	 can you sign the consent form (aka the phab ticket saying it is ok)?
[16:25:39] 	 "As a prize for clicking on donate, chose the amount you'd like to receive"
[16:25:56] 	 "congratulations, you are the 1000000000000th donator to our website!! now click the monkey!"
[16:26:37] 	 done and done!  i make sure to never store stuff i care about on nfs :P
[16:26:38] 	 YuviPanda: I need a hint, where do I go to see this homedir?  I'm just seeing /dev/vda1 stuff
[16:26:48] 	 awight: aren't you seeing it in your home?
[16:26:52] 	 awight: try sudo mount /home?
[16:27:02] 	 cwdent: +1, things you care about should be on git ;)
[16:27:21] 	 For example,  df /home
[16:27:21] 	 Filesystem     1K-blocks    Used Available Use% Mounted on
[16:27:21] 	 /dev/vda1       18569668 7338364  10264972  42% /
[16:27:30] 	 awight: I guess we could put bannerController in line for deprecation, make it empty, and just depend on some new stuff
[16:27:51] 	 And we could get rid of the whole "bannerController" nomenclature
[16:28:33] 	 AndyRussG: I'm thinking it's more like campaignRenderer or something now
[16:28:53] 	 We aren't actually running banner-level business logic
[16:29:04] 	 awight: yeah that makes a lot of sense
[16:29:32] * AndyRussG kicks scope
[16:29:39] 	 naming things!
[16:29:50] 	 YuviPanda: so home dirs are just going to be on the fs of the vm now right?  not replaced with a different network fs?
[16:30:15] 	 Maybe "campaignBannerRendererOnTrackForWorldDomination"
[16:30:39] 	 cwdent: yeah
[16:30:42] 	 cwdent: just on the VM
[16:30:44] 	 "jsSploitInjextor"
[16:30:51] 	 awight: which instance is htis?
[16:31:10] 	 Fundraising-Backlog, Phabricator: Migration of Fundraising Tech team to Phabricator - https://phabricator.wikimedia.org/T831#1401129 (DStrine)
[16:31:24] 	 YuviPanda: ah, reading the task now.  I looked on bastion1 and integration-slave-trusty-1014, now I see I should be looking at a fundraising instance
[16:31:25] 	 bueno
[16:31:35] 	 awight: yup :)
[16:31:39] 	 of which i think mine is the only one
[16:31:58] 	 cwdent: what is hostname again?
[16:32:07] 	 civi-casey.eqiad.wmflabs
[16:32:17] 	 you need some ssh config stuff which i think you have...
[16:32:26] 	 proxycommand
[16:32:40] 	 Still no /home on nfs
[16:32:45] 	 checking now
[16:32:48] 	 only labstore1003.eqiad.wmnet:/dumps and /scratch
[16:33:28] 	 ok I see the fstab entry
[16:33:40] 	 YuviPanda: i should also say i haven't seen my nfs home dir since labs came back up, kinda assume they were already gone :)
[16:33:46] 	 Looks like I killed the machine with sudo mount /home
[16:33:52] 	 heh
[16:33:55] 	 awight: haha
[16:33:58] 	 Forgot to check if that was a -o soft mount
[16:34:10] 	 awight: am gonna reboot
[16:34:11] 	 that ok?
[16:34:23] * cwdent saves work
[16:34:46] 	 YuviPanda: yep.
[16:35:17] 	 I'm becoming less worried about that share, but if you have access to the server, can you just ls -ltra for me?
[16:47:51] 	 aww fuck
[16:47:51] 	 I reoboted the NFS server
[16:47:51] 	 baaahahaha
[16:47:51] 	 accidentally
[16:47:52] 	 careful doing sysadminery with caps lock jammed down
[16:47:52] 	 ¯\_(ツ)_/¯
[16:47:52] 	 O_o
[16:51:09] 	 Fundraising Sprint N*E*R*D, Fundraising-Backlog: [Finish Q4] GOAL: Clear out Q4 goals! Wrap up Astropay round 1 and banner history - https://phabricator.wikimedia.org/T102196#1401177 (DStrine)
[16:51:13] 	 Fundraising-Backlog: GOAL: SP +2 - https://phabricator.wikimedia.org/T102198#1401183 (DStrine)
[16:51:17] 	 Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint N*E*R*D, Fundraising Tech Backlog, and 2 others: Find a PHP Redis client that supports CAS transactions against a cluster - https://phabricator.wikimedia.org/T103206#1401190 (atgo)
[16:51:19] 	 Fundraising Sprint Miles Davis, Fundraising Sprint N*E*R*D, Fundraising-Backlog, Astropay Integration: Some style issues with Astropay form - https://phabricator.wikimedia.org/T101234#1401193 (atgo)
[16:51:20] 	 Fundraising Sprint Miles Davis, Fundraising Sprint N*E*R*D, Fundraising-Backlog, Unplanned-Sprint-Work, and 2 others: Drupal 7.38 upgrade - https://phabricator.wikimedia.org/T103006#1401191 (atgo)
[16:51:22] 	 Fundraising Dash, Fundraising Sprint Miles Davis, Fundraising Sprint N*E*R*D, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Generate fake data for Dash/CiviCRM - https://phabricator.wikimedia.org/T101904#1401192 (atgo)
[16:51:25] 	 Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint N*E*R*D, and 4 others: Provide access to limbo messages without knowing keys - https://phabricator.wikimedia.org/T99152#1401194 (atgo)
[16:51:28] 	 Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, and 5 others: Document how the new queueing stuff will work - https://phabricator.wikimedia.org/T96434#1401196 (atgo)
[16:52:07] 	 Fundraising-Backlog, Phabricator: Create project for Fundraising - https://phabricator.wikimedia.org/T682#1401235 (DStrine)
[16:55:08] 	 (PS2) Awight: WIP Minimum split of BaseAuditProcessor from functions that don't require context [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220714
[16:55:54] 	 (CR) jenkins-bot: [V: -1] WIP Minimum split of BaseAuditProcessor from functions that don't require context [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220714 (owner: Awight)
[17:08:08] 	 (PS3) Awight: WIP Minimum split of BaseAuditProcessor from functions that don't require context [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220714
[17:08:10] 	 (PS2) Awight: Move GC audit module to _old [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220680 (https://phabricator.wikimedia.org/T86090)
[17:13:53] 	 K4-713: Thanks!
[17:14:05] 	 Yep.
[17:14:32] 	 Only got totally distracted by about six things in the middle there.
[17:17:46] 	 Fundraising-Backlog: Sprint O - Wikimania! GOAL:  - https://phabricator.wikimedia.org/T102197#1401394 (atgo)
[17:19:23] 	 awight: I just emailed you the output of find
[17:29:11] 	 YuviSheep|zzz: awight@ ? Didn't receive an email yet.
[17:29:16] 	 Wikimedia-Fundraising, Community-Liaison, Performance-Team, Patch-For-Review, Privacy: parsing legacy GeoIP cookies fails (no regex match), enwiki geonotice broken for users with those legacy cookies - https://phabricator.wikimedia.org/T103720#1401457 (atgo) Hello! Do you guys know when this star...
[17:31:34] 	 Wikimedia-Fundraising, Community-Liaison, Performance-Team, Patch-For-Review, Privacy: parsing legacy GeoIP cookies fails (no regex match), enwiki geonotice broken for users with those legacy cookies - https://phabricator.wikimedia.org/T103720#1401479 (awight) It looks like the breaking change wa...
[17:34:38] 	 awight: did you get the crm master time loop untangled?
[17:35:42] 	 hey ejegg!  how's the ankle?
[17:36:02] 	 feeling way better than yesterday!
[17:36:11] 	 Got a solid night's sleep
[17:36:18] 	 thanks!
[17:37:50] 	 glad to hear it!
[17:45:17] 	 ejegg: No, actually!
[17:45:34] 	 Already diving back in with your bionic ankle?
[17:45:56] 	 awight: yeah, today is 'quit trolling for sympathy and get back to work' day
[17:46:13] 	 :p  I started going completely crazy in wmf_audit, in preparation for actually writing an audit processor...
[17:46:24] 	 ooh, lemme take a look
[17:47:08] 	 there was some audit stuff in SmashPig too, but I guess that was rudimentary and as yet unused?
[17:48:05] 	 In the long term, I'd like to push the auditing code entirely into SmashPig
[17:48:28] 	 I think the meat of the WorldPay audit processor is in there, but the logfile marriage stuff is still in the crm repo
[17:48:42] 	 (PS4) Awight: WIP Minimum split of BaseAuditProcessor from functions that don't require context [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220714
[17:48:44] 	 (PS1) Awight: Move shared functions to the base class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220835
[17:48:50] 	 wait, so the gerrit master is still effed and unmergeable?
[17:49:35] 	 Just trimmed the required interface down a lot, but it still has some XML assumptions.
[17:49:41] 	 Ah
[17:49:44] 	 no, that's fixed
[17:49:50] 	 ah, nice
[17:50:04] 	 I forgot about that, thought you were talking about the Drupal 7.38 fubar
[17:50:13] 	 ... which did not get better
[17:50:22] 	 quite the patch queue...
[17:50:29] * ejegg gets to the reviewin'
[17:50:49] 	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic: [epic] Banner History - https://phabricator.wikimedia.org/T78089#1401539 (DStrine)
[17:51:22] 	 ejegg: I think cwdent is churning through the generic import patch chain...
[17:51:32] 	 ahh, cool
[17:51:44] 	 looking at the audit stuff now
[17:52:05] 	 It's scary.  I really want to massage the codeball into a testable state
[17:53:14] 	 what's the biggest obstacle to getting it our kind of testable (e.g. may be destructive to databases)
[17:55:28] 	 * I wasn't smart enough to tell wtf was happening, so had to peel back the weeds * Input and output are hardcoded * Configuration is a brew of filesystem directories and dates
[17:56:25] 	 oh jeez, yeah:define( 'CONTRIBUTION_AUDIT_WR1_FILES_DIR', '/usr/local/src/Wr1_files/' );
[17:56:31] 	 I've pushed the global function magick into classes now, so I can almost conceive of how to test
[17:56:42] 	 well, that define is used as the default for a drupal variable_get :)
[17:56:55] 	 This is a report of an old port
[17:57:11] 	 guess a test can always redefine
[17:57:25] 	 awight: are we waiting on rosie's approval to merge any of the generic import stuff?
[17:57:31] 	 The echo stuff needs to be suppressed cos that will kill phpunit
[17:57:38] 	 oh yeah
[17:57:50] 	 cwdent: Not waiting to merge, but yeah we want her to sign off before we declare done-ness
[17:58:24] 	 cool, i will get it tested up to the latest today
[17:58:56] 	 just commented on that square ticket...i don't think it's worth messing with that stuff until we are sure the format is consistent
[17:59:13] 	 awight: is the worldpay_audit code in crm still being used?  I mean, when we've got WP on?
[17:59:21] 	 cwdent: lol I just read your comments :)  Yeah I hate pioneering file formats for our vendors
[17:59:27] 	 ejegg: yeah
[17:59:31] 	 ok
[17:59:46] 	 That's the one where the actual parser is in SP, I hope... checking
[18:00:17] 	 totally.  quite wholesome, actually
[18:00:27] 	 That's a port from python :)
[18:00:33] 	 cool
[18:00:50] * awight looks up average janitor's salary
[18:00:58] 	 is square wiring up a special format for wmf?  or is this what they give everyone?
[18:01:10] 	 Oh, we are getting overpaid.
[18:01:35] 	 cwdent: Well, they had nothing of the sort until we asked for it, but now it looks like they have another client making requests.
[18:01:51] 	 Important part is, I'm sure they're still flexible
[18:02:12] 	 that's pretty surprising
[18:02:22] 	 I know...
[18:02:36] 	 the food truck industry for instance is like 100% square
[18:02:42] 	 but apparently not accounting heavy
[18:02:57] 	 I'm horrified at the state of audit files and processing--I'm pretty sure we're the only ones who have ever parsed *PayPal* audit files, if that gives you an idea of the market
[18:03:15] 	 mmm food truck
[18:03:16] 	 the horror...
[18:03:42] 	 oh ok you sent me all the money, cool.  I'll just go back to pecking at my ipad now
[18:04:26] 	 cwdent: btw, we're using http://php.net/manual/en/function.fgetcsv.php -- it does handle most of the weirdness like double-quoting
[18:05:07] 	 ah, cool cool
[18:05:39] 	 awight: have you ever played with https://github.com/onyxfish/csvkit ?
[18:05:47] 	 it's pretty cool
[18:05:52] 	 you can query your spreadsheets
[18:06:32] 	 awight: apparently I fucked that up too
[18:06:33] 	 I was so happy doing CSV stuff in Python.  But here we are
[18:06:39] 	 Should be in right spot now
[18:06:48] 	 YuviSheep|zzz: :D go to sleep, I'm sure I don't need any of that stuff
[18:06:55] 	 I was just being greedy
[18:09:16] 	 ejegg: If you want to write the SP half which turns log lines into normalized messages, I could wire up the effing wmf_audit stuff...
[18:10:02] 	 oh yeah?  Sure... I'll just look over a bunch of these submitted patches first
[18:10:47] 	 awight: is there test data for the generic import available?
[18:11:11] 	 ejegg: thanks!
[18:11:21] 	 cwdent: yep, it's in my emails to RLewis
[18:11:41] 	 ty
[18:11:42] 	 fwiw, I wrote wmf_civicrm unit tests for all the fields, but no integration test from offline2civicrm
[18:11:49] 	 (PS1) Awight: Fix case WorldPay -> Worldpay [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/220840
[18:13:30] 	 ah, cool
[18:14:42] 	 (PS2) Ejegg: Use new names for fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220708 (owner: Awight)
[18:14:44] 	 awight|afk: thanks for getting that location types thing out!
[18:15:23] 	 (CR) Ejegg: [C: 2] "Looks good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220708 (owner: Awight)
[18:16:02] 	 (Merged) jenkins-bot: Use new names for fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220708 (owner: Awight)
[18:17:47] 	 atgo: of course; thanks for reminding me that we were blocking other work
[18:18:09] 	 (PS2) Awight: Step up convenience function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220709
[18:18:14] 	 (PS2) Awight: Remove unsupported "direct" mode [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220710
[18:18:20] 	 (PS3) Awight: Move GC audit module to _old [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220680 (https://phabricator.wikimedia.org/T86090)
[18:18:41] 	 (PS5) Awight: WIP Minimum split of BaseAuditProcessor from functions that don't require context [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220714
[18:18:47] 	 (PS2) Awight: Move shared functions to the base class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220835
[18:28:07] 	 (PS10) XenoRyet: Red Text validation messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/217158 (https://phabricator.wikimedia.org/T86214)
[18:40:30] 	 ejegg: hey! How's they ankle?
[18:41:35] 	 Anyone, comments on these improved names for modules? https://www.mediawiki.org/wiki/Extension:CentralNotice/Notes/Banner_controller_refactoring#Proposal_2
[18:45:46] 	 Fundraising Tech Backlog, Recurring-Donations: Fix recurring date calculation for HHVM - https://phabricator.wikimedia.org/T102230#1401721 (atgo)
[18:47:23] 	 AndyRussG: Hello!  Feeling a lot better than yesterday, thanks!
[18:47:32] 	 ejegg: fantastic!! :)
[18:48:09] 	 Have you decided if you'll be flying in for Wikimania yet?
[18:48:59] 	 Fundraising Tech Backlog, Recurring-Donations: Fix recurring date calculation for HHVM - https://phabricator.wikimedia.org/T102230#1401733 (awight)
[18:49:08] 	 not yet - i want to see if i can quantify the risk of dropping dead from a blood clot to the brain...
[18:49:26] 	 i guess that's why they say not to fly soon after surgery
[18:49:50] 	 ack!
[18:50:07] 	 safety first
[18:50:33] 	 yeah, but how does it compare to car accidents or just flying in the first place?
[18:52:09] 	 good question
[18:53:41] 	 ejegg: ouch! had no idea about that...
[18:54:08] 	 oh, looks like the worry is lungs, not brain
[18:54:26] 	 ejegg: you could take the bus! I did that for many years. Dunno what the effects of busriding would be on such things, tho...
[18:54:41] 	 Pretty bumpy buses!
[18:55:22] 	 Slower than the plane, too
[18:55:31] 	 ah crikey
[18:55:49] 	 AndyRussG: how long is the bus ride from montreal to mexico city??
[18:55:50] 	 whew, that'd be a heck of a bus ride!
[18:56:08] 	 3 days and 3 nights, including waiting to change busses, etc
[18:56:11] 	 AndyRussG: I like those names
[18:56:17] 	 awight: cool!
[18:56:38] 	 I think I'm gonna go all out and just kill the "banner-" prefix everwhere!
[18:56:50] 	 for xample, bannerChoiceData => choiceData
[18:56:52] 	 ok, awesome!
[18:57:11] 	 Maybe write out the migration plan...
[18:57:23] 	 hahahahah migration plan?
[18:57:31] 	 just so the rest of us can help fan the flames :p
[18:57:58] * awight scrubs the Mingle off my browser
[18:58:08] 	 awight: the idea is just that all existing modules will be deprecated and empty, and only a couple of them will have as dependencies the new ones
[18:58:28] 	 At the same time we'll start injecting into the HTML skin the calls to load the new ones right away
[18:58:52] 	 So one month after the initial deploy, we can just remove the old modules bwahahahahaha
[18:58:57] 	 (CR) Ejegg: [C: 2] Step up convenience function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220709 (owner: Awight)
[18:59:52] 	 awight: K you're right, I should write that out ;p
[18:59:58] 	 hehehe
[19:00:23] 	 I do have some notes...
[19:01:05] 	 (CR) Ejegg: [C: 2] Remove unsupported "direct" mode [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220710 (owner: Awight)
[19:02:40] 	 awight: Is moving the gc audit module to _old supposed to make us hurry up and get the WX file working? :)
[19:03:55] 	 oho, I see you rebased the WX thing on top of that.  And no WIP... *eyebrows*
[19:04:06] 	 ejegg: I... don't really know.  I split a patch so I could see what was happening.  I guess the deal is that we want to name the new extension globalcollect_audit
[19:04:10] 	 no WIP??
[19:04:28] * awight charges back in with a roll of biohazard tape
[19:04:31] 	 not on https://gerrit.wikimedia.org/r/#/c/199653/, anyway
[19:04:35] 	 hehe
[19:04:44] 	 (PS7) Awight: WIP GlobalCollect WX audit module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/199653 (https://phabricator.wikimedia.org/T86090) (owner: Katie Horn)
[19:04:45] 	 (CR) jenkins-bot: [V: -1] WIP GlobalCollect WX audit module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/199653 (https://phabricator.wikimedia.org/T86090) (owner: Katie Horn)
[19:04:50] 	 thx
[19:06:59] 	 awight: i'm trying to understand git review -d
[19:07:12] 	 (CR) Ejegg: [C: 2] Fix case WorldPay -> Worldpay [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/220840 (owner: Awight)
[19:07:22] 	 it knows about the dependency chain in gerrit?
[19:07:48] 	 cwdent: yep, it just does a checkout
[19:08:41] 	 but they aren't actually a branch in gerrit are they?  just a bunch of independent change sets?
[19:09:10] 	 (Merged) jenkins-bot: Fix case WorldPay -> Worldpay [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/220840 (owner: Awight)
[19:09:18] 	 In the web interface, click the Download -> Checkout and copy that git command.  AFAIK that's pretty much what git review -d does.
[19:10:24] 	 cwdent: They're a branch, with some insane name... but all that matters is that each commit has a parent
[19:10:31] 	 but cherry-pick still refers to a single commit right?
[19:10:34] 	 yeah
[19:10:50] 	 ok gotcha
[19:11:04] 	 and is there a better way to view the "branch" than clicking "depends on" over and over?
[19:11:11] 	 hehehe
[19:11:13] 	 hell no
[19:11:21] 	 not that I know of, at least
[19:11:46] * awight rattles cane at the sky
[19:12:06] 	 Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, and 6 others: Change errors on GC forms from popup to red text - https://phabricator.wikimedia.org/T86214#1401822 (XenoRyet) The error message is drawing 'zip' from the...
[19:12:10] 	 heh, oh well
[19:12:17] 	 something tells me i don't want to try building one
[19:12:37] 	 Holy crap, I tried to change one small thing in there...
[19:13:09] 	 i can just tell from the UI what the code must be like
[19:13:43] 	 I was enraged at having to declare my one UI element in three totally different places, using three completely different conventions, totally defeating all the fancy dependency injection they built this garbage heap on top of.
[19:14:23] 	 Then it turned out that the build system was too sophisticated to actually run.  Designed for like an entire data center or something.  I kid you not, I think the build system is called "GIT!" spelled just like that.
[19:14:40] 	 oh wrong. "BUCK!"
[19:14:55] 	 cwdent: if you click on the branch's name in the default view, it should take you to search results for status:open, with matching project / branch / topic
[19:15:56] 	 if I had been using topics correctly ;)
[19:16:03] 	 heh
[19:16:31] 	 thank ejegg!
[19:16:52] 	 come on github open source your shit
[19:17:03] 	 you make all your money off open source code
[19:17:23] 	 everybody who pays for private repos now will still do it
[19:18:24] 	 It's probably stolen code, that's why they hide it
[19:20:07] 	 the basic functionality does not seem all that complicated.  and if people were running stuff locally they wouldn't need the scaling stuff which is probably most of the complexity
[19:20:34] 	 pull requests are basically the only thing that's not just wrapping git
[19:20:43] 	 >
[19:20:43] 	 Watchman is used internally by Buck to monitor directory trees and is needed for buck daemon to work properly. Because buckd is activated by default in the latest version of Buck, it searches for the watchman executable in the path and issues a warning when it is not found and kills buckd.
[19:20:49] * awight stabs a puppet
[19:21:14] 	 D:
[19:24:50] 	 (CR) AndyRussG: "> > It's just a long string that's repeated in many contexts where the details of what it refers to are" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/213988 (owner: Jdlrobson)
[19:28:55] 	 (PS1) Awight: Move the Drush command hook to the base module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220940
[19:29:51] 	 (CR) Awight: "Found a dangling inline style in globalcollect_gateway/forms/html/_personal-information/CA.html" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/217158 (https://phabricator.wikimedia.org/T86214) (owner: XenoRyet)
[19:31:22] 	 (CR) Awight: Red Text validation messages (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/217158 (https://phabricator.wikimedia.org/T86214) (owner: XenoRyet)
[19:32:36] 	 (PS11) XenoRyet: Red Text validation messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/217158 (https://phabricator.wikimedia.org/T86214)
[19:33:09] 	 awight:  Good catch, fixed.
[19:36:48] 	 (CR) Awight: "Noticed an i18n issue, and the cookies error will not display." (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/217158 (https://phabricator.wikimedia.org/T86214) (owner: XenoRyet)
[19:37:06] 	 XenoRyet: sorry for the piecemeal review, I just realized the i18n needs tweaking.
[19:37:27] 	 The string concat thing is an error Siebrand Mazeland likes to call "lego messages"
[19:37:35] 	 ... in case you hear the term elsewhere
[19:37:58] 	 awight: anyway, mesa doing the NFS removal now. reboot of labs instances now ok?
[19:38:02] 	 cwdent: ^
[19:38:53] 	 YuviSheep sure!
[19:39:15] 	 XenoRyet: you can add "?uselang=sq" to your URL for an example of a language where the sentence doesn't end with the field name
[19:39:21] 	 gateway_common/i18n/interface/sq.json:  "donate_interface-error-msg": "Ju lutemi, vendsoni $1 tuaj",
[19:39:43] 	 alright then
[19:41:45] 	 cwdent: wrt Square audit file, it might be worth asking them for docs on the stock "transaction history download" file format... always better for us to not be a special case.
[19:43:12] 	 done
[19:43:36] 	 YuviSheep: fine with me!
[19:43:43] 	 :D
[19:43:49] 	 awight: yeah i was thinking the same thing
[19:45:16] * cwdent really wants to type ayo, ayo!
[19:45:50] 	 this is your big chance :D
[19:45:58] 	 (PS1) Awight: WIP AstroPay audit module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220944
[19:48:36] 	 Must have been in there before, the old alert box was using the same deal.  No time like the present to fix it though.
[19:48:47] 	 Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, and 6 others: Change errors on GC forms from popup to red text - https://phabricator.wikimedia.org/T86214#1401967 (awight) @XenoRyet, it can be done in a follow-up patc...
[19:49:03] 	 XenoRyet: yeah, I think i18n has been totally hosed for those alert dialogs
[19:50:16] 	 awight: think it's ok for me to email?  i don't want to step on atgo's toes
[19:50:53] 	 It's fine!
[19:51:02] 	 There are very few toes to worry about...
[20:02:41] 	 Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, and 6 others: Change errors on GC forms from popup to red text - https://phabricator.wikimedia.org/T86214#1402041 (XenoRyet) @awight, that's definitely the right way to...
[20:07:33] 	 AndyRussG: your VM is hanging today?
[20:07:43] 	 awight: oooh oooops!
[20:07:44] 	 One sec
[20:46:24] 	 http://welcometobusinesstown.tumblr.com/
[20:46:31] 	 K4-713: I missed like the first minute of what you said during standup right after I went! sorry for my silly audio cutting in and out just... because...
[20:47:00] 	 AndyRussG: No worries. I'll PM you. :)
[20:48:15] 	 cwdent: +1!
[20:53:37] 	 awight: how do you want to distinguish refund messages from payment messages on the crm side?  The worldpay audit processor adds a 'type' => 'refund' field to the message (along with setting the gateway_refund_id and gateway_parent_id to gateway_txn_id).  Sound good?
[20:56:26] 	 That doesn't sound right, lemme take a look at the queue consumer
[20:56:56] 	 I did see that it's what is currently happening, though, and the record_is_a_ functions reply on that field name
[20:57:32] 	 ejegg: actually, that is correct.  queue2civicrm/refund/wmf_refund_qc.module
[20:59:10] 	 ok, cool
[20:59:25] 	 i won't rock the boat on that just yet
[21:00:08] 	 ejegg: Surprisingly, I remembered to include that in the doc: https://wikitech.wikimedia.org/wiki/Fundraising/Normalized_donation_messages#Refunds
[21:00:22] 	 ah, thanks!
[21:03:19] 	 awight: the CRM side will likely need the same pending queue lookup I added for messages from the listener - I'll set the completion_message_id same as the listener does
[21:04:59] 	 great, document on that page if you're in the mood
[21:34:56] 	 Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, and 6 others: Change errors on GC forms from popup to red text - https://phabricator.wikimedia.org/T86214#1402495 (awight) Good point, don't bother with a kludge.  It's...
[21:37:12] 	 cwdent: I missed the links u sent in the standup hanout 'cause... closed tab ;p
[21:37:20] 	 silly me...
[21:37:48] 	 it's pretty great https://www.youtube.com/watch?v=wJelEXaPhJ8&feature=youtu.be&t=15
[21:38:51] 	 what does "soft credit target" mean?
[21:38:56] 	 specifically bad soft credit target
[21:39:09] 	 cwdent: thx!
[21:39:32] 	 cwdent: soft credit is a PAC thing, in which money is funneled from one org through another, to a third.
[21:39:56] 	 One org is normal ("hard", which I don't think they say) credited, the other is soft credited
[21:40:43] 	 Don't ask me which is which cos donor advised funds and matching gifts seem to use reverse link orientations.
[21:40:48] 	 of one another.
[21:41:15] 	 The bad target test is just, if the import specifies a soft credit target by name and there is either zero or more than one contact with exactly that name.
[21:41:42] 	 so in that situation is wmf the middleman?
[21:44:57] 	 anyone intersted in CN stuff, here is the RL module refactor plan: https://www.mediawiki.org/wiki/Extension:CentralNotice/Notes/Banner_controller_refactoring#RL_module_deprecation
[21:45:03] 	 Already vetted by Krinkle
[21:48:30] 	 awight: do refund messages only need the fields listed in their normalized message documentation section, or are those fields in addition to the normal donation fields?
[21:48:49] 	 Just the few ones.
[21:48:56] 	 Good thing to make clear in the doc!
[21:50:21] 	 Thanks!
[21:51:50] 	 ejegg: btw, Stop it!  I can't stand thinking that you're sitting with your foot not pointed up, acting like it's normal to have an elaborately butchered refrigerator terminal block bolted on
[21:52:01] 	 hah!
[21:52:31] 	 I feel way better hanging out at the coffee shop getting stuff done than I would moping around the house
[21:52:43] 	 Don't they have moving sidewalks in Somaville
[21:52:46] 	 the foot's up on a chair...
[21:52:47] 	 oh hell no, you're out??
[21:53:10] 	 Get that clear splint...
[21:53:28] 	 i sure as hell ain't going to act like i'm under 6 weeks of house arrest
[21:53:37] 	 you are!
[21:53:54] 	 hey, they told me to start putting a little weight on it already!
[21:53:57] 	 Do you at least have a push wheelchair?
[21:54:19] 	 ah, nope.  i'll probably catch the bus for the 8 block trip home though
[21:54:29] 	 Dude, sorry to have to parent here, but the risk is not about what you plan to do, it's about the potential for more accidents...
[21:54:50] * AndyRussG seconds awight's scolding of ejegg
[21:55:10] 	 ejegg: get a cab! I'm sure u can find a way for the WMF or someone to foot the bill
[21:55:15] 	 (no pun intended)
[21:55:15] 	 Party's at your house this month!
[21:55:18] 	 ok guys, i'll take it slow and careful...
[21:55:26] * awight AndyRussG that was great
[21:56:08] * awight checks on WMFcam link that ejegg is behaving with propriety
[21:56:31] 	 good citizen...
[21:56:58] 	 heh puns start off on the best foot when unintended
[21:57:14] 	 ejegg: no *break* dancing, eh?
[21:57:17] 	 awight: wrinkle for astropay is that the refund's txn id seems to be a different identity column - numbers are way smaller.  They do give us the parent txn id in another column.
[21:57:24] 	 AndyRussG: groan...
[21:58:04] 	 hehe be careful or I'll continue.... ;p
[21:58:25] 	 awight: think I'll just prefix the refund_txn_id with 'refund:' unless that'll break some other parsing
[21:59:00] 	 ejegg: I don't see the problem yet--fwiw we are inconsistent about whether the refund has its own txn_id (cos the processors are inconsistent), hence the "RFD" suffix in the contribution.trxn_id
[21:59:32] 	 Yeah it looks like we're talking about the same issue.  Sure, the string prefix sounds good.
[21:59:40] 	 ok, cool
[21:59:53] 	 (more todo doc)
[22:00:35] 	 ah, cool
[22:03:42] 	 Main "lunch" meal time!
[22:03:52] 	 (bassoon)
[22:05:13] 	 supper!
[22:29:16] 	 (CR) Cdentinger: [C: 2] "one comment about future use of civifixtures but everything here looks good" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219983 (owner: Awight)
[22:34:03] 	 (CR) Awight: Use RAII for fixtures (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219983 (owner: Awight)
[22:48:24] 	 ejegg: Just noticed that the other audit processors pull their additional information from the payments logs, not the pending queue...
[22:48:45] 	 I think I should have remembered that a month ago...
[22:50:08] 	 (CR) Cdentinger: [C: 2] Write contact_groups import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219984 (owner: Awight)
[22:50:26] 	 awight: hmm, ok
[22:50:46] 	 (Merged) jenkins-bot: Use RAII for fixtures [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219983 (owner: Awight)
[22:51:12] 	 There's reusable code that marries the log data to transactions, so if you want to go that way, just log the donor info on the payments cluster.
[22:51:34] 	 where is that?
[22:51:42] 	 In wmf_audit
[22:51:47] 	 thanks!
[22:52:05] 	 Currently it assumes get_xml_log_data_by_order_id but that's easy to generalize
[22:52:19] 	 ah, yep, no XML with these guys
[22:52:35] 	 On the other hand, I'm not convinced we need to keep this design going forwards...
[22:52:48] 	 also, we don't get the data echoed back in the NewInvoice response
[22:53:08] 	 Yeah, it'll have to be logged explicitly
[22:53:44] 	 Huh.  I'd really like to just re-use the completion_message_id.
[22:54:21] 	 I'm totally fine with adding additional data matching backends to the audit processor.
[22:54:41] 	 Then if the completion message is not found (already acked by listener message consume), we check to make sure the donation already exists and just update it with any new info
[22:55:16] 	 I guess the advantage of the log lookup is that it makes it much easier to reprocess old audit files.
[22:55:39] 	 hmm, yeah, i guess so
[22:55:45] 	 And, this stuff should sort of be idempotent so consuming the pending queue is not the greatest
[22:56:01] 	 ok, i'm convinced
[22:56:08] 	 We could log from the pending queue to a file as they are processed...
[22:56:16] 	 That at least gives us idempotency back
[22:56:29] 	 you think the listener message consumer should also use logs?
[22:56:39] 	 No...
[22:56:57] 	 At least that is more guaranteed to happen within the month.
[22:57:10] 	 ok.  Then I'd still want to log the info before redirect instead of on pending consume
[22:57:23] 	 Just in case the audit processor is the first thing to find a txn
[22:57:28] 	 There's stuff in the payment logs marrier I'd like to roll into the bay, though.  lots of system calls.
[22:57:45] 	 eugh
[22:58:21] * awight goes blind trying to decipher Worldpay fixed-length records...
[22:58:43] 	 1500000004***************5151****000000000802609140929000E002133A  000000100EUR2000000100EUR2ABC000
[22:58:46] 	 16000000052784431000000000000019330306.0
[22:58:51] 	 Assfaces.  And it's two lines per record.
[22:58:52] 	 *barf*
[22:59:47] 	 Don't worry, the more modern CSV format for a different Worldpay gateway isn't lacking in surprises--it's missing column headers and I think they change depending on the line format.
[23:00:35] 	 wheee
[23:00:37] 	 When I say "assface", I'm referring to our wonderful WP comrades' forefathers, I should say.  all ass no face
[23:00:51] 	 The current people are actually really great to talk to.
[23:01:07] 	 long live the young turks!
[23:02:02] 	 http://www.funnyjunk.com/Dogs+ass+face/funny-gifs/5532598
[23:02:06] 	 eh, that rad news show?
[23:02:09] 	 assface connection?
[23:02:49] 	 (CR) Cdentinger: [C: 2] Import organization contact name and title [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/217990 (owner: Awight)
[23:03:01] 	 ah, no, i thought young turks just referred to revolutionary new blood or something
[23:03:18] 	 oh!  Now the news show makes more sense...
[23:04:01] * awight basks in a little free knowledge
[23:04:12] 	 hehe
[23:04:32] 	 (Merged) jenkins-bot: Write contact_groups import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219984 (owner: Awight)
[23:07:43] 	 (CR) Cdentinger: [C: 2] Make WmfImportFile the default offline import format [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219224 (https://phabricator.wikimedia.org/T88836) (owner: Awight)
[23:08:58] 	 (PS1) Ejegg: WIP Astropay audit file processing [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/220998 (https://phabricator.wikimedia.org/T90507)
[23:10:18] 	 (CR) jenkins-bot: [V: -1] Make WmfImportFile the default offline import format [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219224 (https://phabricator.wikimedia.org/T88836) (owner: Awight)
[23:10:47] 	 wat
[23:11:16] 	 aargh, time loop again?
[23:11:18] 	 (PS14) Awight: Import organization contact name and title [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/217990
[23:11:28] 	 (PS5) Awight: Make WmfImportFile the default offline import format [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219224 (https://phabricator.wikimedia.org/T88836)
[23:11:35] 	 (PS5) Awight: Add and fix migrations for legacy custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219436
[23:11:40] 	 (PS6) Awight: Remove fictitious letter_code field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219437
[23:11:46] 	 (PS6) Awight: Iterate offline keying template [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219438
[23:11:54] 	 (PS15) Awight: Test more fields used by WmfImportFile format [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/218567
[23:11:59] 	 (PS6) Awight: Passthrough more payment types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219492 (https://phabricator.wikimedia.org/T88836)
[23:12:06] * awight dies of pressing "Rebase"
[23:12:14] 	 (PS6) Awight: Drop "Amount (USD)" column [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219493 (https://phabricator.wikimedia.org/T88836)
[23:12:20] 	 (PS6) Awight: Update Civi to pick up fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219498
[23:12:25] 	 (PS11) Awight: Migration for Restrictions and Gift Source options [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219480
[23:12:31] 	 (PS6) Awight: Provide Generic Org import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220001 (https://phabricator.wikimedia.org/T88836)
[23:12:37] 	 did gerrit try to merge them out of order or something?
[23:12:38] 	 (PS2) Awight: Implement contact relationship import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220628 (https://phabricator.wikimedia.org/T88836)
[23:12:45] 	 (PS3) Awight: Import name prefix and suffix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220629 (https://phabricator.wikimedia.org/T88836)
[23:13:10] * awight uses time-travel loop to stop Gerrit's developers from taking apart that mac plus
[23:14:28] 	 well i got run club on thursday so i gotta...run
[23:14:34] 	 but i'll finish up with those patches later
[23:14:41] 	 see ya!
[23:15:09] 	 Thanks for all the review!
[23:39:57] 	 (PS1) Awight: WIP Tests for audit processing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221003
[23:40:41] 	 (CR) jenkins-bot: [V: -1] WIP Tests for audit processing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221003 (owner: Awight)
[23:41:41] 	 (PS1) Ejegg: Before Astropay redirect, log details for audit processor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/221005 (https://phabricator.wikimedia.org/T90507)
[23:42:19] 	 (CR) jenkins-bot: [V: -1] Before Astropay redirect, log details for audit processor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/221005 (https://phabricator.wikimedia.org/T90507) (owner: Ejegg)
[23:49:47] 	 (PS2) Ejegg: Before Astropay redirect, log details for audit processor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/221005 (https://phabricator.wikimedia.org/T90507)
[23:50:23] 	 ok friends, going home to take your relaxation suggestions!
[23:50:29] * awight bristles
[23:50:36] 	 See you in a week!