[15:24:09] (CR) Cdentinger: [C: 2] "one question, but looks good and tests pass" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220628 (https://phabricator.wikimedia.org/T88836) (owner: Awight) [15:29:43] (Merged) jenkins-bot: Implement contact relationship import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220628 (https://phabricator.wikimedia.org/T88836) (owner: Awight) [17:25:10] Fundraising Sprint N*E*R*D, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Deploy patch so that GR can import TargetSmart to update Civi contact information for the LA region - https://phabricator.wikimedia.org/T97196#1410222 (awight) From Kellie: > Our plan is to import the records with CiviCRM... [17:25:56] Fundraising Sprint N*E*R*D, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Deploy patch so that GR can import TargetSmart to update Civi contact information for the LA region - https://phabricator.wikimedia.org/T97196#1410235 (awight) Oops, just noticed that the above comment belongs on the block... [17:58:57] Fundraising-Backlog, fundraising-tech-ops: New password+CIVI certificate for PPENA - https://phabricator.wikimedia.org/T103997#1410793 (Jgreen) What happened to your old computer? If you still have it we can transfer your ssh keys to start, otherwise we need to issue you new SSH keys too. [18:11:21] hey Jeff_Green! thanks for jumping on that call and the giant rabbit stuff when you're straight back from vacation :) [18:11:42] ha no problem, although i'm still 85% useless [18:12:57] hehe. /me looks forward to increasing own uselessness ratio [18:12:59] aww [18:13:16] Jeff_Green: how much time should i block out for a "civi + campaigns down" tomorrow meeting? [18:14:39] I'm not sure, for the part they identified which involves me, that's a repeat of last time and an hour was plenty [18:15:22] cool. I'll send that invite [18:16:43] (CR) Awight: Implement contact relationship import (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220628 (https://phabricator.wikimedia.org/T88836) (owner: Awight) [18:19:30] i got you an hour and a half [18:35:07] AndyRussG: ping? [18:35:23] K4-713: Hi! Really sorry I'm late!!! [18:35:47] Ah, no worries. [18:35:54] I don't have a lot today anyway. [18:36:12] K4-713: had some minor... difficulties here.... [18:36:35] That sounds ominous. [18:40:02] AndyRussG! hii! i have a question for you... is that geoip thing totally resolved? [18:40:12] awight: I'm out of things to do, any suggestions on what I should do next? [18:40:29] XenoRyet: sure, lemme look around! [18:41:56] hi one sec! [18:58:05] awight: i am getting an error about missing payment instrument. how do those get added? i ran all the migrations but only have 5. [18:58:16] yipes. [18:58:17] 5 payment instruments i mean [18:58:28] cwdent: wmf_civicrm_update_7000 [18:59:48] hrm, i bet i have a bad version selected [18:59:57] (PS1) Awight: Correct column header [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221727 (https://phabricator.wikimedia.org/T88836) [19:00:32] whaa [19:00:35] wat [19:00:59] i mean in drupal.system [19:02:09] But whatchu mean, "selected"? [19:02:14] Hi atgo, sorry I was in a call... WRT GeoIP, I think it's resolved but I haven't been able to test yet [19:02:24] I'll take a peek in a little bit [19:02:46] atgo: I have to be AFK for a short while, hopefully not long, back soon!!!!!! Thx [19:02:47] cwdent: You can cheat it out a bit if you want, update drupal.system set schema_version=6999 where name='wmf_civicrm'; then add a die statement at the end of the 7000 migration [19:02:55] * AndyRussG waves at everyone! [19:03:03] You might corrupt your stuff, but at least it will demonstrate whether the migration is borken or not. [19:03:03] back in a shortish while! [19:03:06] AndyRussG: hi! [19:03:07] bye :p [19:03:15] hibi! [19:05:09] awight: yeah, i was messing with that db a lot, just gonna start fresh [19:06:27] healthy practice [19:07:16] those two scripts do make it a breeze [19:07:34] great to hear! Please do make any improvements you think of [19:19:29] (PS3) Ejegg: Astropay audit file processing [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/220998 (https://phabricator.wikimedia.org/T90507) [19:25:34] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm/drupal] (contrib) - https://gerrit.wikimedia.org/r/219443 (https://phabricator.wikimedia.org/T103006) (owner: Ejegg) [19:50:28] XenoRyet: Sorry to drop the ball there! Looking for stuff again... [19:53:46] No worries, I've been keeping busy poking around trying to learn things. [19:54:17] awight: with the files in your emails to rosie i get "Bad soft credit target" on org and a payment_instrument "Stock" error with individual. i think db is up to date, any idea why i'd be missing those? [19:56:36] did we run banners on Android last year? [19:57:34] pizzzacat: lots, afaik. Email MHernandez or PCoombe for details! [19:57:58] ok thanks! [19:58:03] Fundraising Sprint Indigo Girls, Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, MediaWiki-Templates, and 3 others: Mustache renderer needs to support i18n - https://phabricator.wikimedia.org/T97149#1411393 (awight) Deployed, can close? [19:58:39] XenoRyet: Want to tackle this one? https://phabricator.wikimedia.org/T96621 [19:59:06] I can fill in the task with more details if it sounds interesting. [20:01:22] Yea, that looks good. More detail is always appreciated too. [20:18:10] Fundraising Sprint N*E*R*D, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Deprecate "language" parameter - https://phabricator.wikimedia.org/T96621#1411445 (DStrine) a:XenoRyet [20:29:21] Fundraising-Backlog: Rearrange order of CC logos on GC form for Japan - https://phabricator.wikimedia.org/T102496#1411463 (DStrine) [20:40:03] cwdent: did you sort out your bad soft credit target? [20:40:50] ejegg: not yet, but just heard back from ayo at square [20:41:20] i don't know if we have the org inserts scripted up anywhere [20:41:26] haha cwdent told you :P [20:41:51] heh yeah I should have done that sooner [20:43:06] atgo: what was that task about brazil bank transfer you were trying to scope? [20:43:16] https://phabricator.wikimedia.org/T98216 [20:43:18] ejegg: ^ [20:43:21] thanks! [20:45:28] pizzzacat: !! hi!! [20:45:33] we ran on mobile web but not native [20:47:14] Fundraising Sprint N*E*R*D, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Deprecate "language" parameter - https://phabricator.wikimedia.org/T96621#1411532 (awight) [20:47:30] XenoRyet: Fleshed that out a bit, lmk if anything is unclear! ^ [20:49:36] awight: Will do. Definitely looks like enough to get started. [20:51:18] haha hi atgo!! [20:51:22] XenoRyet: one thing to watch out for is the 'language' parameter in queue messages and internal, normalized donation data... we still want that one, unless you see a reason to change it. [20:51:26] <:o) [20:51:53] 10-4 [21:06:16] (PS1) AndyRussG: WIP - Pls. Don't Merge - Refactor banner display, RL modules and API for banners [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) [21:07:09] (CR) jenkins-bot: [V: -1] WIP - Pls. Don't Merge - Refactor banner display, RL modules and API for banners [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [21:10:17] Fundraising-Backlog, Astropay Integration: Donate by Bank Transfer in Brazil - https://phabricator.wikimedia.org/T98216#1411620 (Ejegg) [21:11:56] Fundraising-Backlog, Astropay Integration: Donate by Bank Transfer in Brazil - https://phabricator.wikimedia.org/T98216#1262484 (Ejegg) Removing the message for non-cc methods would be easy and consistent with the Globalcollect RTBT form for Netherlands. We also don't need the bank name field, as the ra... [21:12:37] Fundraising-Backlog, Astropay Integration: Donate by Bank Transfer in Brazil - https://phabricator.wikimedia.org/T98216#1411629 (awight) Just for consistency, please update the task description to make it clear whether we're doing this through AstroPay or GlobalCollect... [21:13:34] awight: ejegg: cwdent|lunch: XenoRyet: ^ Here is a WIP for anyone who'd like to check it out. The file modules/subscribing/ext.centralNotice.geoIP.js should do the same job as the GeoIP code in modules/ext.centralNotice.bannerController/bannerController.js (which will be removed in this patch, it's just still there as for WIP purposes). It's called from subscribing/ext.centralNotice.startUp.js, which is also basically finished. I'll [21:13:34] ping as more bits and pieces become ready for review! [21:13:45] Pls LMK if u have questions [21:13:49] thanks AndyRussG|school , I'll take a look! [21:13:50] Also apologies for the flaky internet [21:14:05] ejegg: thanks much! [21:15:42] Fundraising-Backlog, Astropay Integration: Donate by Bank Transfer in Brazil via Astropay - https://phabricator.wikimedia.org/T98216#1411651 (Ejegg) [21:16:34] (PS11) Awight: WIP Tests for audit processing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221003 [21:17:30] (CR) jenkins-bot: [V: -1] WIP Tests for audit processing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221003 (owner: Awight) [21:22:40] (PS2) AndyRussG: WIP - Pls. Don't Merge - Refactor banner display, RL modules and API for banners [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) [21:23:31] (CR) jenkins-bot: [V: -1] WIP - Pls. Don't Merge - Refactor banner display, RL modules and API for banners [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [21:32:47] (PS1) Awight: Need to composer install as part of testing [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/221768 [21:33:02] ejegg: ^ When you have a minute [21:33:23] sure! [21:33:53] Turns out, I was getting confused by the "composer install" in civicrm-buildkit, which was for that tool's dependencies, not the crm ones. [21:34:07] ah, yup [21:34:33] glad that stuff is possible in the CI environment now! [21:35:19] Pretty nasty that we don't have real VM isolation yet [21:35:20] (CR) Ejegg: [C: 2 V: 2] "yep, this is necessary!" [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/221768 (owner: Awight) [21:35:27] thanks! [21:35:44] yeah, i guess that's why the builds need to queue up behind each other [21:37:31] argh, phpunit incompatibility... 00:00:47.291 Fatal error: Call to undefined method LargeDonationTest::setDisallowChangesToGlobalState() in /mnt/jenkins-workspace/workspace/wikimedia-fundraising-civicrm/src/wikimedia/fundraising/crm/vendor/phpunit/phpunit/src/Framework/TestSuite.php on line 732 [21:37:39] * awight dives into raw sewage [21:42:11] Wheee. 00:00:20.183 The .git directory is missing from /mnt/jenkins-workspace/workspace/wikimedia-fundraising-civicrm/src/wikimedia/fundraising/crm/vendor/wikimedia/donation-interface, see https://getcomposer.org/commit-deps for more information [21:43:46] rm -rf FTW [21:44:57] (CR) Awight: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221003 (owner: Awight) [21:46:07] awight: Haz 'splanations on this line from bannerController.js (line 371): mw.centralNotice.data.addressFamily = ( window.Geo.IPv6 || window.Geo.af === 'v6' ) ? 'IPv6' : 'IPv4'; [21:46:11] ? [21:47:52] Moreoever, why does mw.centralNotice.data have an addressFamily on it? [21:49:57] awight: yeah i always get that from stock phpunit and have to install with composer [21:52:50] cwdent: Looks like the problem is caused by one of our libs pulling in phpunit as a dev dependency, so then the autoloader prefers vendor/ phpunit over the one you're running as the test framework. [21:53:18] AndyRussG: I have no idea! [21:53:28] awight: ;D [21:53:36] Sure looks scary, though [21:55:58] (PS1) Awight: Port cal_days_in_month to hhvm [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221776 (https://phabricator.wikimedia.org/T91898) [21:56:10] (PS2) Awight: Port cal_days_in_month to hhvm [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221776 (https://phabricator.wikimedia.org/T91898) [21:56:20] awight: I'm tossing it in the bit-basurra [21:56:48] Fundraising Sprint N*E*R*D, Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, and 2 others: Make recurring next scheduled calculation HHVM-compatible - https://phabricator.wikimedia.org/T91898#1411806 (awight) [21:57:43] AndyRussG: The only relevant detail I know about is that ipv6 support has been pretty useless in our GeoIP database, but that should be slowly improving with time. [21:58:21] Hmm I see it was added by ori in March of last year... [21:58:29] Sounds right [21:58:49] I don't get why it would be on cn.data tho [21:59:19] Might be worth a quick search through metawiki to see if any banners reference that variable [21:59:23] :-/ [22:00:01] (PS12) Awight: Tests for audit processing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221003 [22:00:03] awight: yeah [22:01:14] (CR) jenkins-bot: [V: -1] Tests for audit processing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221003 (owner: Awight) [22:01:21] awight: not anywhere on Meta: https://meta.wikimedia.org/w/index.php?title=Special%3ASearch&profile=advanced&search=addressFamily&fulltext=Search&ns8=1&ns200=1&ns202=1&profile=advanced [22:05:32] AndyRussG: cool! U could ask him, but it sure smells unused [22:06:03] awight: Looks like it was once used internally in CN but then for some unknown reason was no longer [22:07:34] awight: https://gerrit.wikimedia.org/r/#/c/116857/ [22:07:45] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Run CRM on HHVM - https://phabricator.wikimedia.org/T91896#1411858 (awight) @Jgreen: just a heads-up that this is about to be unblocked. This upgrade might be a big win, it should improve web UI latency. I think the number was on average 2x faste... [22:08:50] funky! [22:27:38] awight: next up in the mystery lineup, bannerController line 372: mw.centralNotice.isPreviewFrame = (mw.config.get( 'wgCanonicalSpecialPageName' ) === 'BannerPreview'); [22:27:40] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm/drupal] (contrib) - https://gerrit.wikimedia.org/r/219443 (https://phabricator.wikimedia.org/T103006) (owner: Ejegg) [22:27:56] AndyRussG: oooh, that one is actually my fault. It can get the axe. [22:27:57] disabled tests on contrib ^^^ [22:28:26] I was experimenting with different ways to display a preview rendered banner, and that was from an iframe approach. [22:28:37] awight: ahh OK :) [22:28:50] awight: git blame impinges not on the realm of the moral [22:28:54] (CR) Awight: [C: 2] "Hooray!" [wikimedia/fundraising/crm/drupal] (contrib) - https://gerrit.wikimedia.org/r/219443 (https://phabricator.wikimedia.org/T103006) (owner: Ejegg) [22:29:02] (Merged) jenkins-bot: Upgrade to Drupal 7.38 upstream [wikimedia/fundraising/crm/drupal] (contrib) - https://gerrit.wikimedia.org/r/219443 (https://phabricator.wikimedia.org/T103006) (owner: Ejegg) [22:32:37] (CR) Awight: "Now we're down to the real brass tacks: the test fails exactly every other time, due to grep: /tmp/test-working/20140829_worldpay.working:" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221003 (owner: Awight) [22:36:27] Arg! Boo internet, switching connections again [22:38:40] (PS1) Ejegg: Merge branch 'contrib' [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/221784 [22:40:58] atgo: You still here? :) [22:41:02] yes [22:44:50] awight: ejegg: cwdent: XenoRyet: am I crazy, or is the condition on line 17 BS? https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCentralNotice/8135c1783023c854d27a49000534b6f060cb254c/modules%2Fext.centralNotice.bannerController%2Fmobile%2Fdevice.js [22:45:02] How did I become |school? school's out! [22:45:27] AndyRussGAre you taking other people to school? I mean... figuratively. [22:45:55] (CR) Awight: "Looks great and very concise, just a few pedantic inline comments..." (6 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/220998 (https://phabricator.wikimedia.org/T90507) (owner: Ejegg) [22:46:19] Thanks for the CR! [22:46:30] cat /dev/zero | school > /dev/null for ever! [22:46:31] K4-713: School chauffering is literally what I use that nick for. But now it seems like my IRC client has a mind of its own [22:46:46] Maybe it's like a truant officer, since in fact, here in Mexico school _isn't_ out! [22:47:05] awight: hahahahaha [22:49:38] AndyRussG: Yea, unless I'm missing something it looks like 'name' is never going to evaluate to false on that line. [22:50:04] XenoRyet: thanks! I knew the looney bin was still a few all-nighters away \o/ [22:50:20] ;-) [22:50:38] AndyRussG: That condition explains why desktop is otherwise known as "unknown" :) [22:50:38] My bet is someone was just reflexively checking for nulls there. [22:51:01] Now I worry that we're taking that device name verbatim. [22:51:08] oh, we are. [22:51:21] sorry, I missed which codebase that was in. [22:51:26] awight: oh noes, you're right! Arrrg, the only reason that code works is that it's only loaded on the mobile site [22:52:06] OK, we need to know the standard client-side method of determining if you're in the mobile skin [22:52:14] * AndyRussG heads to #wikimedia-mobile [22:52:18] There's a huge UA regex in our varnish configuration, for mobile's benefit. I wonder if it sets any headers we could use instead of repeating bad code here? [22:54:26] awight: Ahh good point, thx, lemme check on that, too [22:56:34] AndyRussG: nvm about the headers, looks like nothing is set: https://git.wikimedia.org/blob/operations%2Fpuppet.git/71441fbd476cf822caea5784152b3b1eb7d3ff91/templates%2Fvarnish%2Ftext-frontend.inc.vcl.erb [23:01:40] awight: rmoen sez: "isMobile = mw.config.get('skin') === 'minerva'" [23:04:40] ouch [23:04:47] I'm sure the skin name will never change. [23:09:33] I'll add a TODO to the line for future improvement in case one day it becomse feasible [23:11:10] Pretty amusing, seems like it's such a horrible hack that everyone is embarrassed to canonize in a wrapper function. [23:18:04] (PS4) Ejegg: Astropay audit file processing [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/220998 (https://phabricator.wikimedia.org/T90507) [23:19:25] (CR) Ejegg: "Should address your concerns, but you might have a better idea about where to put the UTC date utility method." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/220998 (https://phabricator.wikimedia.org/T90507) (owner: Ejegg) [23:23:27] (CR) Awight: Astropay audit file processing (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/220998 (https://phabricator.wikimedia.org/T90507) (owner: Ejegg) [23:23:30] (PS5) Awight: Astropay audit file processing [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/220998 (https://phabricator.wikimedia.org/T90507) (owner: Ejegg) [23:23:40] (CR) Awight: [C: 2] "With tests, awesome!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/220998 (https://phabricator.wikimedia.org/T90507) (owner: Ejegg) [23:24:44] Fundraising Tech Backlog, Continuous-Integration-Config: Enable PHPUnit testing on the wikimedia/fundraising/SmashPig repo - https://phabricator.wikimedia.org/T104264#1412163 (awight) NEW [23:28:25] woohoo! [23:29:49] (Merged) jenkins-bot: Astropay audit file processing [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/220998 (https://phabricator.wikimedia.org/T90507) (owner: Ejegg) [23:31:33] (PS1) Ejegg: Cleanup whitespace, 'use' instead of \ [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/221792 [23:54:40] Fundraising Sprint N*E*R*D, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: Make recurring next scheduled calculation HHVM-compatible - https://phabricator.wikimedia.org/T91898#1412288 (atgo) [23:54:42] Fundraising Sprint N*E*R*D, Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Deprecate "language" parameter - https://phabricator.wikimedia.org/T96621#1412287 (atgo)