[00:28:14] (PS4) Awight: DO NOT MERGE Move GC audit module to _old [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220680 (https://phabricator.wikimedia.org/T86090) [00:28:16] (PS4) Awight: Move shared functions to the base class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220835 [00:28:18] (PS7) Awight: Minimum split of BaseAuditProcessor from functions that don't require context [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220714 [00:28:20] (PS3) Awight: Move the Drush command hook to the base module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220940 [00:28:22] (PS13) Awight: Tests for audit processing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221003 [00:28:24] (PS4) Awight: Audit cleanup and fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221274 [00:28:26] (PS4) Awight: Correct code to run the audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221275 [00:28:28] (PS4) Awight: Robustness fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221276 [00:45:23] (PS14) Awight: Tests for audit processing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221003 [00:53:24] (PS15) Awight: Tests for audit processing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221003 [00:53:26] (PS1) Awight: Use instance rather than static scope [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/222227 (https://phabricator.wikimedia.org/T104507) [00:53:28] (PS1) Awight: Update Worldpay case [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/222228 [00:54:19] (CR) jenkins-bot: [V: -1] Tests for audit processing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221003 (owner: Awight) [01:00:12] (PS16) Awight: Tests for audit processing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221003 [01:15:05] (CR) Awight: "Ready for review again." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221003 (owner: Awight) [05:49:38] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Point amp cache to $WORKSPACE - https://phabricator.wikimedia.org/T91911#1419809 (awight) totten closed the upstream feature request! He says the new revision of amp isn't merged into civicrm-buildkit's composer.lock yet, so watch this space. [08:41:02] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Point amp cache to $WORKSPACE - https://phabricator.wikimedia.org/T91911#1420005 (hashar) Great! Thanks for keeping track of it @awight [14:23:09] Fundraising Sprint Kraftwerk, Community-Advocacy, MediaWiki-extensions-CentralNotice: [bug] Banners adding themselves to some buckets - https://phabricator.wikimedia.org/T99915#1421031 (Philippe-WMF) [15:41:42] (PS2) Ejegg: s/Spanish/Portuguese [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/221886 (https://phabricator.wikimedia.org/T98216) [16:28:48] (CR) Ejegg: [C: 2] "Awesome! Could use some whitespace normalization and more (and more specific) exceptions, but I'm not going to let those derail this grea" (5 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220714 (owner: Awight) [16:38:28] (PS1) Ejegg: Use consistent convention to generate refund ID [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/222338 (https://phabricator.wikimedia.org/T90507) [16:41:20] K4-713: do you live?? [16:41:36] I live, yes. But in a sort of ragged kind of way. [16:41:52] Ugh. I hear it's really going around in the office. [16:42:10] (PS5) Ejegg: Move shared functions to the base class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220835 (owner: Awight) [16:42:27] (CR) Ejegg: "Nice gastric bypass on that bloated interface, doc!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220835 (owner: Awight) [16:42:38] * K4-713 giggles at ^^ [16:42:49] haha [16:43:01] K4-713: trevor was here yesterday talking about feeling sick [16:43:07] i was like "GO HOME YOU JERK" [16:43:14] hah [16:43:41] Yeah, I was going to try to do stuff yesterday, and ended up sleeping through most of it. [16:44:25] good for you [16:44:29] are you wfh? or...? [16:44:39] Wake up, drag self to kitchen, make food happen, eat food... wake up later not realizing I had fallen asleep again... [16:44:44] I'm going to try to work today. [16:45:05] yeah i've had those days [16:45:17] cool.... we should get a draft intot he quarterly review deck if possible [16:45:33] Yeah, that's the one thing I have to get done somehow. [16:45:47] Top of a very short list. [16:50:43] atgo: Hmm. We have a meeting in 10 minutes? [16:51:24] I don't know what I will be able to talk about in realtime. [16:51:43] yeah [16:52:00] it was to help you out if you wanted to do it together... but if you just want to catch up on it after a first pass that's fine, too [16:52:26] Yeah, I think that may be the easiest / most efficient way to go about it. [16:52:43] Particularly when my brain is apparently overheating. [16:53:09] atgo: Ah, are you sticking around for a standard day today? [16:53:14] mhm [16:53:44] okay. I'm going to try to get a first swipe in front of you as early as possible. [16:54:06] sounds good [17:12:22] (CR) Awight: Use consistent convention to generate refund ID (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/222338 (https://phabricator.wikimedia.org/T90507) (owner: Ejegg) [17:13:03] (CR) Awight: "needs manual rebase" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/222148 (owner: Cdentinger) [17:14:21] (CR) Ejegg: "cwdent rolled this into the parent - can be abandoned" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/222148 (owner: Cdentinger) [17:15:55] cwdent: ^ when you're in a test-writing mood, that looks like something that should really be tested... [17:16:20] (Abandoned) Cdentinger: protected function handleDuplicate [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/222148 (owner: Cdentinger) [17:16:49] awight: the handleDuplicate method you mean? [17:17:02] probably a good idea [17:17:09] (CR) Awight: s/Spanish/Portuguese (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/221886 (https://phabricator.wikimedia.org/T98216) (owner: Ejegg) [17:17:12] cwdent: totally... [17:17:44] yeah lemme dig at that. been fighting with this asus since about 7pm yesterday [17:18:01] got the software raid0 working and it's superfast [17:18:17] but there are about 50 little things that make me twitch [17:18:18] ah, good. I was about to say it sounds like you're breaking up with it [17:19:16] awight: were you able to get any good unicode support in jessie? [17:19:47] cwdent: No problems that I've noticed. I have my LANG set to es just to eff with myself [17:20:10] hehe [17:20:13] you using gnome shell? [17:20:31] You haž bugs? [17:20:38] yeah [17:20:50] oh weird that displayed fine [17:20:55] but i'm definitely missing a bunch of them [17:20:57] xmonad tho [17:21:55] I had a hilaarious one yesterday, when I booted I only had the letters i, l, and u [17:22:17] wat [17:22:25] so for example, there was an alert at the bottom of the screen that said, " u l i " [17:23:01] hahaha [17:23:02] brutal [17:23:47] and my launcher was pretty funny too. "ii" "i" "" which application u want, I got 'em [17:23:47] i notice they have a wayland option now. i tried it and my cursor went behind all the windows. it was like that secret in mario 3 where you can run behind the level [17:23:59] z-index! [17:24:52] i was having some ugly scrolling behavior in FF that i was able to fix by enabling off-main-thread-compositing [17:25:02] actually just makes the whole browser work a little better [17:25:06] on this machine anyway [17:25:59] of course the latest iceweasel doesn't work with hangouts so it's all academic anyway [17:26:15] I hope you're having fun perving out... I'm sure you realize that machine is capable of running apps > 1MB of core? [17:26:26] You can say "gdm3" and everything will work... [17:27:27] heh, oh yeah i'm running through gdm still [17:27:34] cwdent: One more mundane critique of the awesome handleDuplicate work-- that stuff could use comments. I'm not smart enough to understand what it's doing... [17:27:35] everything is hosed without it [17:27:45] And after 6 more months of PHP, you might not be either :p [17:28:06] yeah good call [17:28:22] if we're actually not concerned with deploying it right away i'll comment and write the tests today [17:36:57] cwdent: You're right, deployment is probably 1st priority [17:37:30] cool, well i'm ready to do that whenever unless you see a problem [17:37:42] that handleDupes does change checksfile [17:37:49] fire away! [17:38:07] AndyRussG|mob: I'm ready to deploy the CN schema change on your mark... [17:38:31] awight: mgmgrrrrgggg!!!! Bwahahahahaha!!!!!! [17:38:43] Woops wrong personality [17:38:54] * AndyRussG reboots with different options [17:39:18] awight: ejegg|afk was saying he'd hold my hand through that...unless you want to [17:39:26] but i don't even know what box these things are on [17:39:44] awight: How about if we just deploy it to the beta cluster to start? [17:39:47] AndyRussG: hehe. The not so mad scientist [17:40:01] AndyRussG: sure thing, lemme start that... [17:40:04] Does that make sense...? [17:40:22] awight: should we just verify the details of the patch/SHA change you're taking it from? [17:41:15] AndyRussG: it's probably best to merge the migration to master, just so the historical record is available if there are issues [17:41:16] mad mad mad mad!!! /me shhhhusshes self [17:42:05] awight: indeed. Well, it's either cherry pick it from the feature branch, or wait... The latter might be OK also if it's just as easy [17:42:06] hey Jeff_Green! are you the person who can add people to fr mailing lists? [17:42:22] yup [17:43:02] AndyRussG: Cool, I'll cherry-pick [17:43:05] should i make a ticket Jeff_Green? [17:43:13] just make an ops ticket [17:43:26] awight: just to check, that won't hoarify things when we merge in the feature branch, right? [17:43:28] it might get triaged to me, or someone might do it before I get to it [17:43:29] ... which project is that Jeff_Green? [17:43:33] there are a number [17:44:01] actually I don't think you even need to assign a project, isn't that part of triaging? [17:44:12] i have no idea [17:44:19] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Make CiviMail useful - https://phabricator.wikimedia.org/T91710#1421840 (awight) This would be a good time of year to give it another try... [17:45:02] AndyRussG: nah, git is pretty good at reconciling cherry-picks as long as you use the commands rather than just applying a patch manually [17:45:21] awight: fantasmagorygood! [17:45:33] uuh, I mean OK [17:45:41] or, OK :) [17:46:35] (PS1) Awight: Campaign-associated mixins: schema update [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/222353 (https://phabricator.wikimedia.org/T90915) [17:47:16] AndyRussG: Hmm, before I do this... we were having a holy war about BLOB... [17:48:01] awight: no blobs in there now, eh? [17:48:12] does phabricator look different for everyone or am i going insane? [17:48:41] Though there is a plain "TEXT" datatype [17:48:57] https://gerrit.wikimedia.org/r/#/c/222353/1/patches/patch-notice-mixins-log.sql,unified [17:49:02] atgo: confirmed [17:49:26] atgo: it looks a little different to me today [17:49:49] awight: ahh rrgg right (didn't scroll down on the plain SQL) [17:50:24] atgo: I would just add project "operations" [17:50:51] AndyRussG: I'm fine with this... I mean, I have objections that I can reserve. But the question is whether you want to deploy it like this, then migrate later once we have experience using the schema [17:50:51] awight: IIRC TEXT datatype is better 'cause it handles char encoding, no? [17:51:19] More that I'm offended by the schemalessness of it all [17:51:22] awight: doesn't sound like the toastiest way to go [17:51:53] awight: it's just the log part... Not sure how to do that differently... [17:52:01] awight: since we're having doubts let's wait then [17:52:22] aah sorry, I see now [17:52:22] awight: sorry! I thought that part was fer sure all set :/ [17:52:32] Yeah I don't care about the log, as long as we're not destroying data [17:53:14] OK, moving right along... [17:53:16] awight: did you check out a deploy slot just for this? is it possible just to deploy to the beta cluster? [17:53:30] AndyRussG: Yeah I'm gonna just deploy to beta then get the free lunch upstairs ;) [17:53:41] awight: OK sounds phab :) [17:53:46] awight: thanks much!!! [17:55:43] (CR) Awight: [C: 2] Campaign-associated mixins: schema update [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/222353 (https://phabricator.wikimedia.org/T90915) (owner: Awight) [17:56:50] (Merged) jenkins-bot: Campaign-associated mixins: schema update [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/222353 (https://phabricator.wikimedia.org/T90915) (owner: Awight) [17:58:44] AndyRussG: Ran out of time, sorry--I need to read more about schema migrations to beta... [17:58:50] I'll ping you when I try again. [17:58:55] awight: np! thanks! [18:07:15] cwdent: hello! [18:08:21] howdy! [18:09:21] are you still planning to deploy your Square import soonish? [18:09:49] ejegg: yeah i was just gonna try but computer problems [18:09:52] one sec [18:10:15] k. just ping me when it's bleeping and blooping in tune [18:20:35] (PS3) Ejegg: s/Spanish/Portuguese [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/221886 (https://phabricator.wikimedia.org/T98216) [18:22:55] (PS17) AndyRussG: WIP - Pls. Don't Merge - Refactor banner display, RL modules and client-side API [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) [18:23:45] (CR) jenkins-bot: [V: -1] WIP - Pls. Don't Merge - Refactor banner display, RL modules and client-side API [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [18:24:27] (CR) AndyRussG: "Special:RecordImpression, legacy in-banner hide logic support, and more doc!" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [18:59:12] (CR) Ejegg: [C: 2] Move shared functions to the base class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220835 (owner: Awight) [19:53:06] (PS1) Awight: remove merge marker [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/222462 [19:54:04] (CR) Ejegg: [C: 2] remove merge marker [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/222462 (owner: Awight) [19:57:49] ejegg: I'm going crazy? title=Special:AstropayGateway&appeal=JimmyQuote&recurring=&uselang=en&language=en¤cy=BRL&country=BR&amount=11.01 [19:57:58] I don't have any of the payment methods, etc. [19:58:22] ah dang, i'm probably not setting a default [19:58:35] Send me an URL you use? [19:58:59] just add payment_method=cc [19:59:17] ahh thanks [19:59:20] or bt, if that's what you're looking at [19:59:32] looks real good [19:59:44] should probably have a default, tho! [20:00:22] (PS3) Awight: Add logo filename to submethod meta, add big logos [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/222180 (https://phabricator.wikimedia.org/T101234) (owner: Ejegg) [20:00:26] (CR) Awight: [C: 2] Add logo filename to submethod meta, add big logos [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/222180 (https://phabricator.wikimedia.org/T101234) (owner: Ejegg) [20:00:36] yay! [20:01:08] (CR) Awight: [C: 2] Add Brazil banks and logos for Astropay (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/221888 (https://phabricator.wikimedia.org/T98216) (owner: Ejegg) [20:01:12] (Merged) jenkins-bot: Add logo filename to submethod meta, add big logos [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/222180 (https://phabricator.wikimedia.org/T101234) (owner: Ejegg) [20:01:20] (PS3) Awight: Add Brazil banks and logos for Astropay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/221888 (https://phabricator.wikimedia.org/T98216) (owner: Ejegg) [20:01:38] (PS4) Awight: Hide 'your card is safe' message for non-card methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/221892 (https://phabricator.wikimedia.org/T98216) (owner: Ejegg) [20:02:15] (CR) Awight: [C: 2] "Ooh, secure page! :p" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/221892 (https://phabricator.wikimedia.org/T98216) (owner: Ejegg) [20:04:07] (Merged) jenkins-bot: Add Brazil banks and logos for Astropay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/221888 (https://phabricator.wikimedia.org/T98216) (owner: Ejegg) [20:04:09] (Merged) jenkins-bot: Hide 'your card is safe' message for non-card methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/221892 (https://phabricator.wikimedia.org/T98216) (owner: Ejegg) [20:04:52] ejegg: standup? [20:22:16] Fundraising Sprint N*E*R*D, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: Make recurring next scheduled calculation HHVM-compatible - https://phabricator.wikimedia.org/T91898#1422661 (DStrine) a:awight [20:31:14] (CR) Awight: [C: 2] s/Spanish/Portuguese [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/221886 (https://phabricator.wikimedia.org/T98216) (owner: Ejegg) [20:31:17] (Merged) jenkins-bot: s/Spanish/Portuguese [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/221886 (https://phabricator.wikimedia.org/T98216) (owner: Ejegg) [20:36:31] AndyRussG|mob: yikes. I just learned this: https://wikitech.wikimedia.org/wiki/Nova_Resource:Deployment-prep/How_code_is_updated#How_does_the_database_get_upgraded.3F [20:55:20] awight: did you somehow merge crm deployment around the redis change we didn't want to deploy? [20:55:41] Or was I mistaken in thinking there was something we couldn't deploy till redis was set up? [20:56:20] ejegg: That's in DonationInterface. Lemme check that we aren't totally hosed there, since you mention it. [20:56:27] oh man, that was totally DonationInterface [20:56:31] sorry! [20:56:50] Really good point [20:59:28] awight: we cool to deploy generic import? [20:59:32] (PS1) Awight: Revert "Orphan slayer reads from frack Redis" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/222481 [20:59:40] ejegg: mos def [21:00:11] (CR) Awight: [C: 2] "Back this out until Redis is in place." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/222481 (owner: Awight) [21:00:34] (Merged) jenkins-bot: Revert "Orphan slayer reads from frack Redis" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/222481 (owner: Awight) [21:01:14] ejegg: ^ DI should be safe to merge hence forward. [21:01:22] thanks! [21:01:25] henceforth, I suppose they say [21:01:35] (PS1) Legoktm: Only add UserMerge tables if $wgNoticeInfrastructure = true; [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/222482 [21:01:54] ^ so, just discovered that those tables don't exist on most wikis [21:01:58] oooh [21:02:05] Wrenching up the works? [21:02:10] (PS2) Awight: Only add UserMerge tables if $wgNoticeInfrastructure = true; [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/222482 (owner: Legoktm) [21:02:37] yeah... [21:02:38] Error: 1146 Table 'aswiki.cn_notice_log' doesn't exist (10.64.16.27) [21:02:41] bunch of those [21:02:42] (CR) Awight: [C: 2] "Thanks!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/222482 (owner: Legoktm) [21:03:38] (Merged) jenkins-bot: Only add UserMerge tables if $wgNoticeInfrastructure = true; [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/222482 (owner: Legoktm) [21:03:43] awight: if I need to backport that, how would I do that? [21:04:05] Fundraising Sprint N*E*R*D, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Deploy patch so that GR can import TargetSmart to update Civi contact information for the LA region - https://phabricator.wikimedia.org/T97196#1422843 (atgo) Open>Resolved a:atgo I think this is resolved... [21:05:40] legoktm: Good question--that extension is configured to be deployed from wmf_deploy, so I'm not certain how the maintenance branches work [21:05:43] lemme see... [21:06:16] (PS1) Cdentinger: Merge commit '5e04ea121d7903f4a0e164499e98fec753cc6319' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/222483 [21:06:31] legoktm: Looks like we only have the REL branch tags [21:06:42] do I cherry-pick it to wmf_deploy? [21:06:50] (CR) Cdentinger: [C: 2] "self-merge" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/222483 (owner: Cdentinger) [21:06:57] legoktm: yes [21:07:11] Do you need to backport to older MW releases as well? [21:07:16] nah [21:07:40] ah ok great. yep, merge to that branch then it will go out on the train, or you can lightning deploy [21:10:21] (PS1) Legoktm: Only add UserMerge tables if $wgNoticeInfrastructure = true; [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/222484 [21:10:49] (CR) Legoktm: [C: 2] Only add UserMerge tables if $wgNoticeInfrastructure = true; [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/222484 (owner: Legoktm) [21:11:30] (PS3) Awight: enable passthru of utm_* fields during check import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/217018 (owner: Cdentinger) [21:12:23] (Merged) jenkins-bot: Merge commit '5e04ea121d7903f4a0e164499e98fec753cc6319' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/222483 (owner: Cdentinger) [21:12:25] (PS4) Awight: Import name prefix and suffix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220629 (https://phabricator.wikimedia.org/T88836) [21:13:28] (Abandoned) Awight: update vendor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/184705 (owner: Awight) [21:13:43] (PS2) Awight: Correct column header [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221727 (https://phabricator.wikimedia.org/T88836) [21:14:05] (PS6) Awight: Fix required import data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219242 [21:16:44] (PS3) Awight: Move date munging into mungeMessage [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/218561 [21:16:52] !log updated civicrm from 4fe0648ea9f36282731bf651a59ca1a617db6c08 to 04efc7d5c7bbb068f907125f2184692aee676123 [21:16:59] Logged the message, Master [21:17:10] (PS3) Awight: Minor cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/212029 (owner: Ejegg) [21:17:27] (CR) Awight: [C: 2] Minor cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/212029 (owner: Ejegg) [21:17:53] (Merged) jenkins-bot: Only add UserMerge tables if $wgNoticeInfrastructure = true; [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/222484 (owner: Legoktm) [21:18:10] (Abandoned) Awight: WIP General donations import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/201427 (https://phabricator.wikimedia.org/T88836) (owner: Awight) [21:18:21] (Abandoned) Awight: WIP test commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/194995 (owner: Awight) [21:19:13] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint N*E*R*D, Fundraising Tech Backlog, and 3 others: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1422915 (awight) Code left to review: * https://gerrit... [21:22:06] (Merged) jenkins-bot: Minor cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/212029 (owner: Ejegg) [21:27:14] (Abandoned) Ejegg: Update composer dependencies [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/217733 (owner: Ejegg) [21:29:23] (CR) Ejegg: "Guessing you add a call to ->run() in a later PS?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220940 (owner: Awight) [21:29:48] ejegg: hehe, lemme squash those two patches together for sanity [21:30:12] ah, there it is! [21:30:27] no worries, they're relatively adjacent [21:31:03] (PS4) Awight: Move the Drush command hook to the base module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220940 [21:31:05] (PS5) Awight: Audit cleanup and fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221274 [21:31:09] (Abandoned) Awight: Correct code to run the audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221275 (owner: Awight) [21:31:11] (CR) jenkins-bot: [V: -1] Audit cleanup and fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221274 (owner: Awight) [21:32:22] (PS5) Awight: Move the Drush command hook to the base module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220940 [21:32:27] (PS6) Awight: Audit cleanup and fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221274 [21:34:33] (CR) Ejegg: [C: 2] "good stuff!" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220940 (owner: Awight) [21:38:00] (PS1) Awight: Normalize whitespace [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/222492 [21:38:02] (CR) jenkins-bot: [V: -1] Normalize whitespace [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/222492 (owner: Awight) [21:38:14] https://www.airbnb.com/rooms/1107343 [21:38:40] Bed type: Real Bed?? [21:38:46] false advertising! [21:39:03] " From the front, you’d never guess this little oasis of tranquility was tucked away back there" [21:39:23] (Merged) jenkins-bot: Move the Drush command hook to the base module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220940 (owner: Awight) [21:39:24] Music is good. Jamming is encouraged. [21:39:25] Not good: tuba waltzes; [21:41:52] (CR) Ejegg: [C: 2] "good stuff" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221274 (owner: Awight) [21:43:57] (CR) Ejegg: "Thanks for squashing that last pair! This needs manual rebase now tho" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221276 (owner: Awight) [21:46:26] (PS5) Awight: Robustness fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221276 [21:49:54] (PS17) Awight: Tests for audit processing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221003 [21:49:56] (PS2) Awight: Update Worldpay case [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/222228 [21:49:58] (PS2) Awight: Use instance rather than static scope [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/222227 (https://phabricator.wikimedia.org/T104507) [21:50:02] (CR) jenkins-bot: [V: -1] Tests for audit processing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221003 (owner: Awight) [21:50:04] (CR) jenkins-bot: [V: -1] Update Worldpay case [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/222228 (owner: Awight) [21:50:06] (CR) jenkins-bot: [V: -1] Use instance rather than static scope [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/222227 (https://phabricator.wikimedia.org/T104507) (owner: Awight) [21:50:08] (Abandoned) Awight: Normalize whitespace [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/222492 (owner: Awight) [21:50:12] urrrgh rebase hell [21:50:28] (PS6) Awight: Robustness fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221276 [21:53:11] (PS18) Awight: Tests for audit processing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221003 [21:53:13] (PS3) Awight: Update Worldpay case [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/222228 [21:53:15] (PS3) Awight: Use instance rather than static scope [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/222227 (https://phabricator.wikimedia.org/T104507) [21:53:48] ah, no worries! [21:53:56] awight: I'll rebase as I go [21:54:14] though those merges are taking their time [21:54:24] I just needed you to break that one dependency [21:56:55] awight: i'd be glad to test on fr-dev (should we have done that before deploy?) but i don't have an account on there [21:57:02] just got one on live civi today [21:57:11] cwdent: ah lemme set u up [21:57:15] Then I have a thing at 3:00 [21:59:17] Give it a whirl! [22:19:55] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Edits to LYBUNT report - https://phabricator.wikimedia.org/T88819#1423209 (atgo) [22:24:51] (CR) Ejegg: [C: 2] "chinstrap for that glass jaw" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221276 (owner: Awight) [22:25:05] hey ejegg|brb - how did you hurt yourself again? [22:27:24] atgo: breaking up dead logs for a bonfire [22:27:37] with your legs, right? awight was disagreeing [22:27:50] beacuse... i've totally done that [22:27:53] yeah. then stumbled and caught my foot under a different log [22:27:56] and i will probably think better [22:27:59] aww... that sounds so miserable [22:28:26] dat bonfire tho! [22:28:35] hahahaha [22:28:47] there's an argument here about whether an ax was involved or not [22:29:03] :P [22:29:07] heh, no, not even stone age [22:29:28] most advanced we got was using the crook of a branch for leverage [22:29:50] hey ejegg, can you make me so i can import checks on civi.fr-dev? [22:29:58] cwdent: lemme see [22:32:51] cwdent: huh, looks like you have the privs you need [22:33:24] https://civicrm.wikimedia.org/admin/import_checks doesn't let you do it? [22:34:04] oh yep it works on live [22:34:10] i but i wanted to test on fr-dev [22:34:14] adam just signed me up there [22:34:20] oh, derp, i missed that bit. [22:34:22] one sec [22:35:17] good thing that env bar was there! [22:35:22] heh [22:35:31] i totally wouldn't have noticed [22:35:56] ok, you should be all set on fr-dev, probably after a logout/login [22:36:13] thanks! [22:37:49] (CR) Ejegg: [C: 2] "freaking function static scope... guess it's better than all global if you have no classes?" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/222227 (https://phabricator.wikimedia.org/T104507) (owner: Awight) [22:38:58] (CR) Ejegg: [C: 2] "Correct-er!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/222228 (owner: Awight) [22:46:15] hmm yeah staging def doesn't work, i wonder if it needs a cc all [22:46:40] it's at the right commit? [22:49:05] yep cc all fixed it [22:49:08] * cwdent wipes brow [23:06:42] (PS1) Ejegg: Nother couple WorldPay->Worldpay [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/222505 [23:12:32] phew, i gotta find an ergonomic way to use this lappy with my foot up. [23:13:16] gonna sign off for now and hope the foot needs less elevation by monday [23:13:48] have a good weekend ejegg [23:13:59] awight: sorry I didn't merge the payoff commit yet - for some reason the test can't find WorldpayAuditProcessor, even after all my cache purge tricks [23:14:04] you too cwdent ! [23:14:32] don't nobody blow no fingers off... [23:23:30] well i gotta go meet a friend for dinner, but i'll check back later in case anyone tries my feature [23:26:48] The board elections thing is gonna be interesting! [23:35:24] Wikimedia-Fundraising-CiviCRM: Access to https://civicrm.frdev.wikimedia.org/ - https://phabricator.wikimedia.org/T104658#1423423 (LeanneS) NEW a:atgo [23:36:24] Fundraising Sprint N*E*R*D, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Access to https://civicrm.frdev.wikimedia.org/ - https://phabricator.wikimedia.org/T104658#1423433 (atgo) @awight can you give her an account? Or is this a Jeff thing?