[00:55:45] Fundraising Sprint N*E*R*D, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate, Unplanned-Sprint-Work: Publishing translations for central notice banners fails - https://phabricator.wikimedia.org/T104774#1432637 (Ejegg) I don't see any settings on meta chan... [01:01:55] (CR) Ejegg: WIP - Pls. Don't Merge - Refactor banner display, RL modules and client-side API (2 comments) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [01:16:36] (CR) AndyRussG: WIP - Pls. Don't Merge - Refactor banner display, RL modules and client-side API (2 comments) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [01:37:19] (PS23) AndyRussG: WIP - Pls. Don't Merge - Refactor banner display, RL modules and client-side API [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) [01:38:10] (CR) jenkins-bot: [V: -1] WIP - Pls. Don't Merge - Refactor banner display, RL modules and client-side API [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [01:38:42] (CR) AndyRussG: "Landing pages!!!!" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [06:34:55] (PS24) AndyRussG: WIP - Pls. Don't Merge - Refactor banner display, RL modules and client-side API [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) [06:35:59] (CR) jenkins-bot: [V: -1] WIP - Pls. Don't Merge - Refactor banner display, RL modules and client-side API [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [06:36:26] (CR) AndyRussG: "Test banners via banner URL param!!" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [13:44:44] fundraising-tech-ops, Wikimania-Hackathon-2015: overhaul fundraising cluster monitoring - https://phabricator.wikimedia.org/T91508#1433907 (Qgil) @Jgreen, are you planning to work on this task at Wikimania? [13:47:37] fundraising-tech-ops, Wikimania-Hackathon-2015: overhaul fundraising cluster monitoring - https://phabricator.wikimedia.org/T91508#1433917 (Jgreen) No, unfortunately I won't be attending this year. [13:58:38] (PS25) AndyRussG: WIP - Pls. Don't Merge - Refactor banner display, RL modules and client-side API [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) [13:59:38] fundraising-tech-ops: overhaul fundraising cluster monitoring - https://phabricator.wikimedia.org/T91508#1433983 (Qgil) [13:59:42] (CR) jenkins-bot: [V: -1] WIP - Pls. Don't Merge - Refactor banner display, RL modules and client-side API [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [14:05:26] (CR) Krinkle: WIP - Pls. Don't Merge - Refactor banner display, RL modules and client-side API (1 comment) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [15:43:54] Fundraising Sprint Lou Reed, MediaWiki-extensions-CentralNotice, Epic, Patch-For-Review, and 2 others: CentralNotice mobile modules should not be loaded in the head - https://phabricator.wikimedia.org/T100372#1434613 (phuedx) @Jdlrobson, @AndyRussG: Can this be closed? [15:47:04] Fundraising Sprint Lou Reed, MediaWiki-extensions-CentralNotice, Epic, Patch-For-Review, and 2 others: CentralNotice mobile modules should not be loaded in the head - https://phabricator.wikimedia.org/T100372#1434647 (AndyRussG) >>! In T100372#1434613, @phuedx wrote: > @Jdlrobson, @AndyRussG: Can t... [15:59:49] (PS26) AndyRussG: WIP - Pls. Don't Merge - Refactor banner display, RL modules and client-side API [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) [16:00:48] (CR) jenkins-bot: [V: -1] WIP - Pls. Don't Merge - Refactor banner display, RL modules and client-side API [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [16:03:47] (CR) AndyRussG: WIP - Pls. Don't Merge - Refactor banner display, RL modules and client-side API (1 comment) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [16:13:55] hey AndyRussG - should we schedule this guy? https://phabricator.wikimedia.org/T100372 [16:14:20] it doesn't seem urgent to me [16:14:55] atgo: Hi! It's already fully taken care of in the big WIP refactor/IP patch ;) [16:15:09] so.. it's been in sprint? [16:15:10] :P [16:15:17] No [16:15:40] ok... i'm just seeing if we should make time for this to make it a priority [16:15:55] But it's just... since I was rewiring all that code, there was no reason not to do it [16:16:06] I was gonna link my patch as a patch-for-review for that task [16:17:23] atgo: no need to make time for it, since it's done ;) but you could add it to a sprint to get some extra point candy [16:17:27] P.S. I might have missed something 'cause flaky internet [16:17:35] ah cool [16:17:50] well maybe dstrine-away has an opinion about how to track? ^ [16:19:18] yeah :) [16:44:49] Fundraising-Backlog: Recent recurring GC donations not recurring or displaying as such at GC - https://phabricator.wikimedia.org/T105041#1434994 (MBeat33) NEW [17:15:07] (PS27) AndyRussG: WIP - Don't merge but please review - Refactor client-side API and RL modules for banner display [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) [17:16:05] (CR) jenkins-bot: [V: -1] WIP - Don't merge but please review - Refactor client-side API and RL modules for banner display [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [17:18:59] (PS28) AndyRussG: WIP - Don't merge but please review - Refactor client-side API and RL modules for banner display [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) [17:19:31] heya AndyRussG: and atgo: re T100372 is the ticket essentially moot because another ticket was done earlier? [17:19:47] (CR) jenkins-bot: [V: -1] WIP - Don't merge but please review - Refactor client-side API and RL modules for banner display [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [17:30:46] (PS29) AndyRussG: WIP - Don't merge but please review - Refactor client-side API and RL modules for banner display [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) [17:31:48] (CR) jenkins-bot: [V: -1] WIP - Don't merge but please review - Refactor client-side API and RL modules for banner display [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [17:40:40] Fundraising-Backlog: Create a civi account for Anna Stillwell and David Strine - https://phabricator.wikimedia.org/T104496#1435230 (DStrine) a:K4-713 [17:43:49] (PS30) AndyRussG: WIP - Don't merge but please review - Refactor client-side API and RL modules for banner display [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) [18:13:46] (CR) Ejegg: [C: 2] "Looks good. There's a thing to clean up from the original code, and the order id retrieval will need to be overridden for Astropay, but t" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/222714 (https://phabricator.wikimedia.org/T104718) (owner: Awight) [18:20:52] Fundraising-Backlog: Recent recurring GC donations not recurring or displaying as such at GC - https://phabricator.wikimedia.org/T105041#1435387 (atgo) p:Normal>High [18:23:49] (PS2) Ejegg: Use consistent convention to generate refund ID [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/222338 (https://phabricator.wikimedia.org/T90507) [18:28:50] (PS11) Ejegg: AstroPay audit glue module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220944 (https://phabricator.wikimedia.org/T104718) (owner: Awight) [18:29:51] Anybody opposed to a DonationInterface deploy? I'd like to push out the logging changes we need for the audit, as well as the style updates. [18:30:06] * AndyRussG waves at ejegg :) [18:30:13] atgo: K4-713: cwdent|lunch, XenoRyet ^^^ > [18:30:16] Hi AndyRussG ! [18:30:20] hi friends! [18:30:24] Mmm sorry not much ideas about DIdeploy [18:30:25] Hi atgo! [18:30:29] fine by me! [18:30:36] Gopher it. [18:30:39] :) [18:30:48] rockin, will prep the deploy branch [18:30:57] I'm... going to get food now. [18:31:00] Because: Starving. [18:31:05] Well... not literally. [18:31:07] bon appetit! [18:31:12] Don't starve! [18:51:39] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/223372 [18:52:08] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/223372 (owner: Ejegg) [18:54:35] (PS1) Ejegg: Update DI submodule for deploy [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/223374 [18:54:58] (CR) Ejegg: [C: 2 V: 2] Update DI submodule for deploy [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/223374 (owner: Ejegg) [18:58:08] !log updated payments from a17ee221db0dbde70c92e24fc188379b6dbad613 to ec34ebf61e5962f66b807abdcb519ff323d41e8e [18:58:13] Logged the message, Master [19:06:28] Fundraising Sprint Miles Davis, Fundraising Sprint N*E*R*D, Fundraising-Backlog, Astropay Integration, Patch-For-Review: Some style issues with Astropay form - https://phabricator.wikimedia.org/T101234#1333279 (Ejegg) Deployed! Note that two of the small logos are being cached 'coz I didn't ch... [19:56:24] (PS12) Ejegg: AstroPay audit glue module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220944 (https://phabricator.wikimedia.org/T104718) (owner: Awight) [20:00:34] (PS13) Ejegg: AstroPay audit glue module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220944 (https://phabricator.wikimedia.org/T104718) (owner: Awight) [20:01:01] (CR) Ejegg: "PS12+13: WS" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220944 (https://phabricator.wikimedia.org/T104718) (owner: Awight) [20:01:13] hey dstrine are we doing remote for standup, too? [20:01:34] yeah I'm hiding [20:01:39] I'm on the call [20:08:07] Fundraising Sprint N*E*R*D, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Unplanned-Sprint-Work: Access to https://civicrm.frdev.wikimedia.org/ - https://phabricator.wikimedia.org/T104658#1435745 (atgo) Open>Resolved [20:13:34] Fundraising Sprint Lou Reed, Fundraising Sprint N*E*R*D, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, and 4 others: CentralNotice mobile modules should not be loaded in the head - https://phabricator.wikimedia.org/T100372#1435761 (DStrine) a:AndyRussG [20:50:37] hey ejegg - wrt astropay methods, i'm going to talk to megan's team about when they'd like to take on the rest of it. adding the other countries/methods is not a colossal effort, right? [20:50:54] and we'd need to do something to audit to get it to accept other currencies iirc? [21:04:21] atgo: Right on both counts! [21:04:40] ok so there's non-trivial but non-colossal work :) [21:04:41] thanks ejegg! [21:35:13] hey dstrine - since we've determined that https://phabricator.wikimedia.org/T104774 isn't in our house, how should we deal with that in the sprint? [21:45:36] bassoon! [21:46:41] ...huh. [22:14:01] (PS14) Ejegg: AstroPay audit glue module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220944 (https://phabricator.wikimedia.org/T104718) (owner: Awight) [22:15:13] (CR) jenkins-bot: [V: -1] AstroPay audit glue module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220944 (https://phabricator.wikimedia.org/T104718) (owner: Awight) [22:15:15] (CR) Ejegg: "Updated test log file to match real production format, updated regex and get_order_id to use ct_id, normalized fields from log" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220944 (https://phabricator.wikimedia.org/T104718) (owner: Awight) [22:19:57] (PS15) Ejegg: AstroPay audit glue module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220944 (https://phabricator.wikimedia.org/T104718) (owner: Awight) [22:39:58] Fundraising Sprint N*E*R*D, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate, Unplanned-Sprint-Work: Publishing translations for central notice banners fails - https://phabricator.wikimedia.org/T104774#1436224 (atgo) we're pretty sure this isn't in anythi... [22:42:20] ejegg: Class 'AstroPayAuditProcessor' not found -- you have tricks besides cc all to clear the class cache? that file is present so i dunno why it's complaining [22:43:14] uff [22:43:38] well that's a pain [22:43:38] Because drupal is... likely to lose its mind? [22:44:24] if it really is a problem with the registry, disabling the module, clearing cache, and enabling sometimes helps [22:44:44] the old turn it off and on again [22:44:51] Also: Clearing "all", doesn't actually clear all, all the time. [22:45:10] but that file was there in the first version of the module [22:45:27] oh, wtf [22:45:46] You didn't move the file, did you? [22:45:55] Probably a silly question. [22:45:59] you have the astropay_audit module enabled, not just wmf_audit? [22:46:26] K4-713: nope it's a vanilla copy [22:46:33] ejegg: lemme check on that [22:47:11] also, phpunit or drush? i've just been doing phpunit locally so far [22:48:20] ejegg: doh yeah i just hadn't enabled the module [22:48:22] thanks [22:48:29] and yeah phpunit [22:49:46] ah, cool [22:50:17] smashpig should get updated with composer? [23:04:43] Fundraising-Backlog, Astropay Integration: Bank Transfer for Caixa and HSBC in Brazil are sending to the wrong page - https://phabricator.wikimedia.org/T105096#1436293 (atgo) NEW [23:06:18] Fundraising-Backlog, Astropay Integration: Itau messaging about popups is in English when you enter the flow in Portuguese - https://phabricator.wikimedia.org/T105097#1436302 (atgo) NEW [23:19:10] cwdent: sorry, missed your last question. Yep, pulling in SmashPig with composer. I use --no-dev to avoid interfering with my system phpunit [23:19:47] ejegg: gotcha. it looks like there are changes to smashpig with astropay audit? [23:20:04] a couple, we'll need those for the refunds [23:20:30] what's the procedure for getting those in dev? [23:20:59] frex: Class 'SmashPig\PaymentProviders\Astropay\Audit\AstropayAudit' not found [23:23:03] oh, does composer install --no-dev not pick that up for you? [23:23:53] ejegg: well i have smash-pig but i don't see that particular file, i figured it was added with this change [23:24:04] hmm, lemme look at composer.lock [23:25:00] huh, should be pulling c7f306e3d3926e798d8e9bacd9fcc9b436a30f50, which has that class [23:26:59] oh hrm, well lemme mess around some more [23:27:25] i end up with a weird composer situation every time because system drush/phpunit don't work right [23:29:30] (PS3) Awight: Use consistent convention to generate refund ID [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/222338 (https://phabricator.wikimedia.org/T90507) (owner: Ejegg) [23:30:00] (CR) Awight: [C: 2] "Holler if you have more thoughts about extracting helper stuff into SmashPig!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/222338 (https://phabricator.wikimedia.org/T90507) (owner: Ejegg) [23:30:02] (Merged) jenkins-bot: Use consistent convention to generate refund ID [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/222338 (https://phabricator.wikimedia.org/T90507) (owner: Ejegg) [23:30:13] ejegg: yeah that was my bad, sorry! [23:30:22] (PS2) Awight: Add CT_ID to Astropay audit refund messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/223122 (https://phabricator.wikimedia.org/T90507) (owner: Ejegg) [23:31:26] (CR) Awight: [C: 2] Add CT_ID to Astropay audit refund messages (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/223122 (https://phabricator.wikimedia.org/T90507) (owner: Ejegg) [23:31:28] (Merged) jenkins-bot: Add CT_ID to Astropay audit refund messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/223122 (https://phabricator.wikimedia.org/T90507) (owner: Ejegg) [23:31:50] (PS2) Awight: Delete 'use' statement that causes warning [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/223083 (owner: Ejegg) [23:33:26] (CR) Awight: [C: 2] "OH. Right, there's no namespace in this file." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/223083 (owner: Ejegg) [23:33:43] awight: you're supposed to be on vacation! [23:34:10] Privyet, my droogs! [23:34:22] (Merged) jenkins-bot: Delete 'use' statement that causes warning [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/223083 (owner: Ejegg) [23:34:31] Don't worry, we're fully supine [23:35:20] Is it too maddening to smell all the ocean while you're hard at work? [23:35:40] aww, me jelly [23:35:58] hehehe, that was the one South Park I actually watched [23:36:03] it's friggin brilliant. [23:36:11] totally on point [23:36:26] heh, i didn't even realize i was referencing anything! [23:36:45] awight! [23:37:00] K4-713: wassaaaap? [23:37:25] ejegg: "Wendy gets Jelly" [23:37:27] Just noticed you were in the channel. [23:37:29] That's all. [23:38:07] Aren't you incredibly far off the clock? [23:38:08] K4-713: If you feel like dealing with the extra weight + customs, I was hoping you could mule some business cards for me. [23:38:16] And, yeah. I can do that. [23:38:26] I was talking to AndyRussG this morning, so IRC still open. [23:38:56] We're headed to smoked lobster or something in a few minutes, it's not like I'm recompiling my kernel to support AstroPay or anything ;0 [23:39:18] Headed to... smoked... lobster? [23:39:23] !! [23:39:43] That's what I said. [23:39:48] Sorry everyone, I feel like that guy who graduates high school and is all like, "you suckers are still here?" [23:39:55] Bahaha [23:40:03] Not cool. [23:40:22] It's ok, we'll live vicariously through your smoked lobster [23:40:37] :) [23:40:41] * K4-713 pinches [23:41:14] Hey, on this note: the catastrophic lack of fr-tech at this Wikimania can only mean one thing: we should come up with a rippin' team week, and soon. [23:41:40] awight: I gave Emmett and Marty a bath this weekend. [23:42:27] Emmett was most definitely not a fan, until I administered the shampoo. [23:42:33] lol, did you spin the loose fur? [23:42:48] I hella could have made a sweater. [23:43:07] And then they were SO FLUFFY. [23:43:10] omg [23:43:18] I fail at life for having no pictures. [23:43:39] My dog is a bit too short-haired to change much after a bath, but he sure smells like a million bucks! [23:43:50] OK more on this later! [23:44:48] Can confirm, IRC has not shut down [23:44:57] Truth. :) [23:45:00] Hey AndyRussG! [23:45:08] K4-713: hi! [23:45:13] How goes? [23:46:16] Eh not bad! This morning I woke up at 7 and motored through the final features + commit message of the big CN API and refactor patch... Didn't even look for food or coffee until like past noon [23:46:53] Dang [23:46:58] So only making tests run is needed there, + changes in response to review [23:47:22] Nice. :) [23:47:55] Yeah! I've been kinda all funny tunnel vision... Look up from the laptop screen and I feel disoriented, as if I had been imagining I was elsewhere [23:48:14] A bunch of non-work distractions since then, though, just getting back to the grindstone for real again [23:48:49] How's stuff w/ you? [23:51:16] Oh, you know. Beginning of the new fiscal year stuff. [23:51:26] Looking forward to getting out of town, for sure. [23:51:35] I bet! When do you fly in? [23:52:19] Really early Tuesday morning. [23:54:10] check this - reading's QR is at 8 tomorrow. [23:54:20] so... could've been worse...? [23:54:48] Uff. [23:56:54] Does ours have a time yet? [23:57:22] ours was this morning [23:57:43] wat? [23:57:48] yep [23:57:50] atgo: did I like... mis it? [23:57:51] Done. [23:58:01] Well, not everybody is supposed to go. [23:58:11] In fact, most people don't. [23:58:20] K4-713: atgo: QR for FR or FR tech? [23:58:25] Yes. [23:58:26] All of it. [23:58:30] and partnerships [23:58:36] we shared the time with community engagement, too [23:58:37] ++ zero... [23:58:37] Ah arrrgh [23:58:53] Damn that must have been... short [23:59:01] ha yeah... fr-tech had about 4 minutes [23:59:04] Did we do... OK? [23:59:07] * AndyRussG cowers in a corner [23:59:09] Oh sure. [23:59:11] yeah! all went well :)