[00:00:04] Ah good news then! [00:00:28] i shared the deck with you earlier today if you want to look [00:00:42] AndyRussG: Basically, I think of QRs as more of a chance for the execs to knock middle-management around. [00:01:04] If they feel like it. [00:01:05] :p [00:01:27] atgo: yeah I saw the e-mail about the document share but wrongly assumed it was a pre-QR thing 8p [00:01:32] ah yeah [00:01:46] i'd love to get that around to you guys in advance for comment in the future, but it's a really tight turnaround [00:02:04] at least this time [00:02:18] anyway.. i've got to run to the chiropractor [00:02:26] atgo: 'bye! [00:02:29] atgo: cya! [00:02:31] see you! [00:02:55] K4-713: could be, though that doesn't mean that it isn't important to be strategic about 'em [00:03:07] Oh, they're plenty strategic. [00:03:41] (for example, by middle management appropriately knocking around people further along the chain of command... or at least pretending to have done so!) [00:03:54] Har... [00:04:05] Nah, it's more like "PLAN YOUR STUFF BETTER!" [00:04:08] And we go "Yes!" [00:04:55] In more seriousness, though, it's also a chance to communicate systemic issues that set entire teams up for failure. [00:04:59] Hmmm then repeat next... But is it an infinite loop? [00:05:05] ...or, you know: Raging successes. [00:05:10] Talking points. [00:05:17] Heh indeed [00:06:15] There is also a component of... they know we're looking at things if they make us do reports about them. [00:06:21] * K4-713 shrugs [00:10:23] Yes wel in life there are lots of things that go wrong or that don't work like they should, and then when you try to imagine what the ideal way for them to work would be, you end up coming up with something not all that different from the thing that was going wrong in the first place ;/ [00:11:05] That can happen, yes. [00:11:14] Which of course doesn't diminish the wrongness of the way things may have been going in any case [00:11:14] And, it should be known that nobody is going for perfection. [00:12:34] But, there's "We didn't make the goal because we were being totally ambitious when we wrote it, but we got pretty close anyway..." and there's "We didn't make the goal because we planned a quarter as if we were going to have zero interruptions of a personal or technological nature, and totally failed to take inter-team dependencies into account". [00:13:14] There is an astonishing tendency, to plan like the second group. [00:13:27] In the industry at large. [00:13:34] Basically, people need to get real. [00:13:34] Hmmm [00:13:40] Yeah that makes sense [00:13:45] Perfection would be boring... Everyone has green checkmarks? Yep? No problems? No? K see u in 3 months... [00:14:09] Yeah, that says to me that your goals were "Assert daily that team's navels are lint-free". [00:14:39] Heh especially when we have navellint jobs on Jenkins! [00:14:46] mhm. [00:15:02] Continuous navel inspection. [00:15:40] heh [00:15:56] This QR was especially dumb for us, because all the engineering teams were only supposed to have one goal last quarter. [00:16:35] Huh [00:16:41] I spent my three slides saying that we overstuffed that goal, and that one goal wasn't representative of our team's output at all. [00:17:09] Next quarter should be more interesting to do the QR for. [00:17:25] Hmmm [00:17:40] * AndyRussG checks quarter goals [00:18:19] Our internal goals should be more or less the same as what we were allowed to officially write down, this time. :p [00:18:51] Last quarter we pretty much threw a dart at all the genuinely immovable objects, and then managed to bloat it out with stretch goals anyway. [00:19:34] But again, it's less about getting the whole grid to go green, and more to get people thinking along the same lines. [00:20:01] Probably with about 50% focus on planning, and 50% on execution. [00:20:41] Hmmm [00:20:45] Sounds like a resonable approach! [00:26:22] Ideally it sounds like setting rigid goals and evaluations of them is only partly about seeing the direct results of that exercise, and partly about the collective thought process related it brings out [00:26:41] Well... "rigid goals" is also a lie. [00:26:47] They don't even want those. [00:27:35] We should probably all be careful about how we frame the exercise, and how we write the goals. [00:28:11] Rigidly defined quarterly goals can easily make people think that they have no option but to stay on the rails the whole time. [00:28:24] Even if it becomes apparent two hours later, that the goal is incredibly stupid. :) [00:28:51] That is not an intended outcome of all of this, and it can *really* come across that way. [00:29:45] For the record, I have no problem standing up and explaining why we ditched a goal two hours in to a quarter. [00:30:08] If you notice something is dumb? Don't do it. :D [00:34:43] Heh also good point... [00:37:59] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: By default, set the box that says, "I'm not a sociopath or anything, so please show my banner no more than 5 times" on (=banners limited) - https://phabricator.wikimedia.org/T105109#1436502 (Whatamidoing-WMF) NEW [01:56:16] Fundraising-Backlog: Review Coinbase API upgrade docs - https://phabricator.wikimedia.org/T105111#1436550 (atgo) NEW [06:19:53] (PS31) AndyRussG: WIP - Don't merge but please review - Refactor client-side API and RL modules for banner display [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) [06:21:23] (CR) jenkins-bot: [V: -1] WIP - Don't merge but please review - Refactor client-side API and RL modules for banner display [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [06:45:54] (PS32) AndyRussG: WIP - Don't merge but please review - Refactor client-side API and RL modules for banner display [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) [06:54:08] (CR) AndyRussG: "QUnit tests and old fields on S:RI!!" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [10:01:00] Fundraising Sprint N*E*R*D, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate, Unplanned-Sprint-Work: Publishing translations for central notice banners fails - https://phabricator.wikimedia.org/T104774#1437099 (Nikerabbit) Hi, I am the creator of the Tran... [15:58:32] AndyRussG: should this be in "pending deployment"? https://phabricator.wikimedia.org/T100372 [15:59:59] ejegg: did you ever hear back from Jeff on: https://phabricator.wikimedia.org/T97071 [16:00:12] (CR) Cdentinger: [C: 2] "M1876734769 makes it to civicrm_option_value" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220629 (https://phabricator.wikimedia.org/T88836) (owner: Awight) [16:00:37] Hi dstrine... It could go in Review, rather. I was looking yesterday at the details of the contents of the card, and it's not as cut and dried as I remembered WRT the description and title of the card, so I might comment on it to clarify exactly what we're doing and how it relates to the card's exact scope [16:00:54] But yeah, for our purposes, let's put it in Review! :) thanks also :) [16:01:12] kk I moved it [16:01:28] (Merged) jenkins-bot: Import name prefix and suffix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220629 (https://phabricator.wikimedia.org/T88836) (owner: Awight) [16:01:38] so AndyRussG do you need help reviewing a bunch of stuff? [16:02:08] I'm just doing a pass on the board and thinking about what could be cleared out before "shrimp prawning" [16:02:52] Yeah, when folks have a chance! :) Last night I moved the 4-pt card into Review since I've done everything on that patch that I can think, until I get more feedback :) [16:03:49] dstrine: I'd also be into adding this one right away: https://phabricator.wikimedia.org/T90918 [16:03:54] (CR) Cdentinger: [C: 2] Correct column header [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221727 (https://phabricator.wikimedia.org/T88836) (owner: Awight) [16:04:17] that is listed in the next sprint [16:04:32] so it'll be on the agenda this afternoon [16:04:34] i think i can clear out the stuff blocking the hand keyed import [16:04:50] (Merged) jenkins-bot: Correct column header [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/221727 (https://phabricator.wikimedia.org/T88836) (owner: Awight) [16:05:02] cwdent: cool! [16:05:33] and maybe that astropay crm glue patch... i don't really know enough about the audit file import to say if it's correct or not but the code seems to do what it says [16:05:48] if ejegg thinks it's cool i'm fine pressing the button [16:06:32] cwdent: it's not quite getting refunds right yet, but I can iterate in another patch [16:07:24] ejegg: hmm, would it screw things up in the mean time if an audit file showed up with a refund? [16:07:52] hmm. it might! let me mess around with it a little more [16:08:41] cool, i'll hold off on that one [16:13:15] ejegg: would it help if I pinged Jeff for that public key? [16:13:55] dstrine: I'm pretty sure he's on it. I chatted him up yesterday and he just had a couple things to do first [16:14:29] ok cool... I'm always available to track people down. [16:14:39] * dstrine uses shifty eyes [16:14:45] heh [16:15:27] ejegg: i want to push a change to an existing patch set. i checked it out with git review -d. is it safe to just commit and git review? [16:15:55] cwdent: yeah, just amend it and review [16:16:26] oh right, to keep the same change id [16:16:31] ty! [16:16:34] yw [16:19:15] Fundraising Sprint Miles Davis, Fundraising Sprint N*E*R*D, Fundraising-Backlog, Astropay Integration, Patch-For-Review: Some style issues with Astropay form - https://phabricator.wikimedia.org/T101234#1438114 (DStrine) Open>Resolved [16:21:11] Fundraising Sprint N*E*R*D, Fundraising-Backlog, Astropay Integration, Unplanned-Sprint-Work, Patch-For-Review: Donate by Bank Transfer in Brazil via Astropay - https://phabricator.wikimedia.org/T98216#1438119 (DStrine) Open>Resolved [16:21:13] Fundraising-Backlog, Wikimedia-Fundraising, Epic: [epic] Integrate processing in Brazil via Astropay - https://phabricator.wikimedia.org/T77907#1438121 (DStrine) [16:22:21] (PS7) Cdentinger: Fix required import data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219242 (owner: Awight) [16:26:44] (CR) Cdentinger: [C: 2] "added the same change to squarefile" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219242 (owner: Awight) [16:27:35] (Merged) jenkins-bot: Fix required import data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219242 (owner: Awight) [16:46:08] ejegg: i notice some merge commits from gerritbot for things i just approved. did i screw something up? should i have rebased? [16:46:33] ehh, no big deal. [16:46:46] But yeah, if you rebase before +2ing they don't happen [16:46:58] doh, sorry about that [16:47:07] is the rebase button sufficient? [16:47:08] no worries, i forget that pretty often too [16:47:10] i still haven't touched that thing [16:47:17] yeah, the rebase button is pretty handy! [16:47:38] automatically leaves a comment tagging that PS as a rebase even [16:48:08] nice, i'll try that with this next one [16:48:39] The change could not be rebased due to a path conflict during merge. [16:48:41] sigh [16:48:59] i'm pretty sure i know why [16:51:34] ah, oh well [16:53:33] yeah there's a conflict that needs manual resolution, but it makes me look like the author of the patch when i pull --rebase and fix it. should i annotate that somehow? [16:54:08] huh, really? Usually the original person still shows up as 'owner' and you'd just be the 'submitter' [16:54:18] Same change ID? [16:56:02] it has a new change ID but i just amended that. what i did was git pull --rebase origin master, fixed the conflict, and git commit, which made a new commit with the previous changes plus the conflict resolution [16:56:20] there might be a better workflow... [16:56:38] hmm [16:57:35] i usually use rebase -i master, but that's usually just a slower version of what you did [16:57:51] it does preserve the change id though [16:58:15] guess you can just amend your commit message to restore the old change id [16:58:19] i just amended my commit with the old message and change id [16:58:31] yeah, and i put a note that says this was a rebase conflict [16:58:42] i'll just try to push that up and see if it looks right [16:58:46] cool, then gerrit should still list the original owner [16:59:31] (PS4) Cdentinger: Move date munging into mungeMessage [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/218561 (owner: Awight) [17:00:42] ejegg: you wanna take a peek at that and make sure i didn't screw something up? [17:00:54] sure thing! [17:01:12] thanks! [17:03:01] rebase looks good to me. Does moving that code have a practical impact, or just organization? [17:04:07] there was a problem with php's datetime choking on a unix timestamp (sigh) [17:04:21] so that let's it pass through cleanly [17:04:24] iirc that was the rationale [17:05:05] there was another way to fix it but i think adam liked it better this way [17:05:43] ah, hmm. ok [17:07:04] so i guess this lets you modify the data before it hits the normalizer [17:16:11] cwdent, K4-713, XenoRyet, AndyRussG|school, atgo, dstrine: anyone have anything to share with / ask from other teams? [17:16:38] just PCI for security, but they know [17:16:43] ok, cool [17:17:06] all good here [17:17:35] I'm all good [17:18:25] I have plenty of chances to get my stuff in these days, so... not really. [17:18:40] The security team should be well aware of what we need forPCI. [17:19:40] rockin [17:33:50] (CR) Cdentinger: [C: 2] "should give the ability to edit datetime fields before they hit php's datetime which bails on lots of stuff" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/218561 (owner: Awight) [17:34:44] (Merged) jenkins-bot: Move date munging into mungeMessage [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/218561 (owner: Awight) [17:51:33] ejegg: thanks, all good here! [19:00:45] hey atgo [19:08:04] Fundraising-Backlog, fundraising-tech-ops: Select website domains for Major Gifts events tool - https://phabricator.wikimedia.org/T104357#1438807 (CCogdill_WMF) Hey @Jgreen, any idea who I can ping to move this along? [19:15:44] Fundraising-Backlog, fundraising-tech-ops: Select website domains for Major Gifts events tool - https://phabricator.wikimedia.org/T104357#1438812 (CaitVirtue) [20:43:42] hey atgo, regarding that phone number issue [20:43:49] yessir [20:44:04] ejegg might know more than i do, but it looks like checksfile imports don't have a place to keep it [20:44:24] i should have noticed this earlier but the only other file that mentions phone is coinbase and it says: [20:44:26] phone number issue? [20:44:36] you mean not being able to search on them? [20:44:40] modules/offline2civicrm/CoinbaseFile.php: 'Phone Number' => 'phone', // TODO: not stored [20:45:24] i looked in what i know to be the relevant tables and don't see a column for phone number [20:45:26] oh, huh. Actually, I don't recall seeing that field around the rest of the import logic [20:45:29] contact/address [20:46:05] are any btc donors actually giving us a phone #? [20:46:32] knowing bitcoin users i doubt it :P [20:48:01] haha [20:48:10] we are getting phone numbers from Square, ejegg [20:48:15] we'd like to import them along with the rest of the info [20:50:12] atgo: if the square-specific import is mapping it to a message field, we probably need to update the shared contact creation logic to actually look at that field [20:51:52] hm [20:53:04] ejegg: where would it go in the database? i haven't been able to find a phone number field in the civi db [20:53:31] hmm, lemme check [20:55:00] cwdent: it's got its own table - civicrm_phone [20:55:12] oh that is sense-making [20:55:25] oh duh :-\ [20:56:15] so would we want to plumb this in to wimf_civicrm_message_contact_import ? [21:03:59] cwdent: I think so... [21:07:30] Fundraising Sprint N*E*R*D, Fundraising-Backlog: [Finish Q4] GOAL: Clear out Q4 goals! Wrap up Astropay round 1 and banner history - https://phabricator.wikimedia.org/T102196#1439153 (DStrine) Open>Resolved [21:09:29] Fundraising-Backlog, Astropay Integration: Remove Bank Transfer for Caixa and HSBC in Brazil from Astropay page - https://phabricator.wikimedia.org/T105096#1439169 (atgo) [21:16:20] Fundraising-Backlog, Astropay Integration: Itau messaging about popups is in English when you enter the flow in Portuguese - https://phabricator.wikimedia.org/T105097#1439209 (atgo) Open>Invalid [21:16:35] Fundraising-Backlog, Astropay Integration: Itau messaging about popups is in English when you enter the flow in Portuguese - https://phabricator.wikimedia.org/T105097#1436302 (atgo) Astropay says this is based on location, not any lang param :( [21:24:19] https://github.com/wikimedia/wikimedia-fundraising-crm-civicrm/blob/master/api/api.php#L50 [21:24:47] mfw http://4.bp.blogspot.com/-I49ZZJyrcJs/U7s_mP4wYKI/AAAAAAAABEk/zYZtJHkni24/s1600/frustrated+dog.jpg [21:25:56] Fundraising-Backlog: Sprint O - Wikimania! GOAL: Finish Banner History & Astropay. Investigate Amazon. Dance like nobody is watching. - https://phabricator.wikimedia.org/T102197#1439251 (atgo) [21:37:38] (PS16) Ejegg: AstroPay audit glue module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220944 (https://phabricator.wikimedia.org/T104718) (owner: Awight) [21:37:50] (CR) jenkins-bot: [V: -1] AstroPay audit glue module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220944 (https://phabricator.wikimedia.org/T104718) (owner: Awight) [21:40:26] o no, somebody died in the middle of writing a comment! [21:42:12] (PS17) Ejegg: AstroPay audit glue module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220944 (https://phabricator.wikimedia.org/T104718) (owner: Awight) [21:43:11] (CR) jenkins-bot: [V: -1] AstroPay audit glue module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220944 (https://phabricator.wikimedia.org/T104718) (owner: Awight) [21:44:03] Look, if he was dying, he wouldn't bother to carve 'aaggggh'. He'd just say it! [21:50:37] hee [21:51:10] (PS18) Ejegg: AstroPay audit glue module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220944 (https://phabricator.wikimedia.org/T104718) (owner: Awight) [21:51:59] (CR) jenkins-bot: [V: -1] AstroPay audit glue module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220944 (https://phabricator.wikimedia.org/T104718) (owner: Awight) [21:55:31] (PS19) Ejegg: AstroPay audit glue module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220944 (https://phabricator.wikimedia.org/T104718) (owner: Awight) [21:56:12] we oughtta seed that test db with some exchange rates [21:56:24] (CR) jenkins-bot: [V: -1] AstroPay audit glue module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220944 (https://phabricator.wikimedia.org/T104718) (owner: Awight) [21:56:28] grr [22:08:37] yo AndyRussG [22:08:42] atgo_: hey ho! [22:08:48] coming to prawning?? [22:09:01] Ohhh woops I was think it was at 5:30 [22:09:04] Arrrrrrgggggggg [22:09:11] atgo: yes of course one sec [22:09:18] :P [22:09:24] AndyRussG: worldtimebuddy.com [22:39:53] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, and 6 others: Change errors on GC forms from popup to red text - https://phabricator.wikimedia.org/T86214#1439477 (atgo) Open>Resolved [22:45:32] Fundraising Sprint Lou Reed, Fundraising Sprint N*E*R*D, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 5 others: CentralNotice mobile modules should not be loaded in the head - https://phabricator.wikimedia.org/T100372#1439489 (atgo) [22:46:38] Fundraising Sprint N*E*R*D, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate, Unplanned-Sprint-Work: Publishing translations for central notice banners fails - https://phabricator.wikimedia.org/T104774#1439494 (AndyRussG) a:AndyRussG [22:47:26] Fundraising Sprint N*E*R*D, Fundraising-Backlog: Enable checks import to save phone number - https://phabricator.wikimedia.org/T105244#1439497 (cwdent) NEW a:Cdentinger [22:48:16] Fundraising Sprint N*E*R*D, Fundraising-Backlog: Enable checks import to save phone number - https://phabricator.wikimedia.org/T105244#1439507 (atgo) a:Cdentinger>cwdent [23:01:16] Fundraising-Backlog, Astropay Integration: Remove Bank Transfer for Caixa and HSBC in Brazil from Astropay page - https://phabricator.wikimedia.org/T105096#1439543 (atgo) [23:01:35] Fundraising-Backlog, Astropay Integration: Remove Bank Transfer for Caixa and HSBC in Brazil from Astropay page - https://phabricator.wikimedia.org/T105096#1439544 (DStrine) [23:01:46] Fundraising-Backlog, Astropay Integration: Remove Bank Transfer for Caixa and HSBC in Brazil from Astropay page - https://phabricator.wikimedia.org/T105096#1439546 (atgo) [23:03:34] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner history mixins and data - https://phabricator.wikimedia.org/T90918#1439548 (atgo) [23:14:38] Fundraising Sprint N*E*R*D, Fundraising Sprint O, Fundraising-Backlog: Enable checks import to save phone number - https://phabricator.wikimedia.org/T105244#1439594 (DStrine) [23:14:40] Fundraising Sprint O, Fundraising-Backlog, Astropay Integration: Remove Bank Transfer for Caixa and HSBC in Brazil from Astropay page - https://phabricator.wikimedia.org/T105096#1439595 (DStrine) [23:14:42] Fundraising Sprint N*E*R*D, Fundraising Sprint O, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Implement CRM glue for AstroPay audit processor - https://phabricator.wikimedia.org/T104718#1439597 (DStrine) [23:14:44] Fundraising Sprint N*E*R*D, Fundraising Sprint O, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: Publishing translations for central notice banners fails - https://phabricator.wikimedia.org/T104774#1439596 (DStrine) [23:16:30] Fundraising Sprint O, Fundraising-Backlog: Create a civi account for Anna Stillwell and David Strine - https://phabricator.wikimedia.org/T104496#1418723 (K4-713) [23:19:25] Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, and 4 others: Document how the new queueing stuff will work - https://phabricator.wikimedia.org/T96434#1439639 (atgo) [23:50:40] (PS20) Ejegg: AstroPay audit glue module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220944 (https://phabricator.wikimedia.org/T104718) (owner: Awight) [23:51:48] (CR) jenkins-bot: [V: -1] AstroPay audit glue module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220944 (https://phabricator.wikimedia.org/T104718) (owner: Awight) [23:59:39] Fundraising-Backlog: Add field data back into Silverpop export - https://phabricator.wikimedia.org/T105254#1439804 (CCogdill_WMF) NEW