[00:02:53] (PS21) Ejegg: AstroPay audit glue module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220944 (https://phabricator.wikimedia.org/T104718) (owner: Awight) [00:03:46] (CR) jenkins-bot: [V: -1] AstroPay audit glue module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220944 (https://phabricator.wikimedia.org/T104718) (owner: Awight) [00:08:30] (PS22) Ejegg: AstroPay audit glue module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220944 (https://phabricator.wikimedia.org/T104718) (owner: Awight) [00:09:37] phew! [00:10:01] cwdent|afk: if you have a chance before you take off, https://gerrit.wikimedia.org/r/220944 ought to be ready for review [03:08:05] Fundraising Sprint Lou Reed, Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, Fundraising-Backlog, and 6 others: CentralNotice mobile modules should not be loaded in the head - https://phabricator.wikimedia.org/T100372#1439974 (AndyRussG) The current patch for review, like the previous one, sign... [04:13:31] Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: Publishing translations for central notice banners fails - https://phabricator.wikimedia.org/T104774#1439989 (AndyRussG) Hi! Two questions: - Are there any other reports of t... [04:31:21] Fundraising Tech Backlog: Review and improve fields we parse from PayPal IPN messages - https://phabricator.wikimedia.org/T105263#1439994 (awight) NEW [16:57:19] (PS1) Ejegg: Make CurrencyRates last update visible [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/223826 [16:57:21] (PS1) Ejegg: Update currency rates [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/223827 [16:58:16] (CR) jenkins-bot: [V: -1] Update currency rates [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/223827 (owner: Ejegg) [17:11:48] hey Ya'll.... I don't feel like we answered a question in sprint planning. If I remember correctly, we wanted to hold off on all the astropay stuff because adam needed to comment on something. right? I see him answering emails.. even if we still wait for him to comment on monday, could we at least fire off an email to him stating what needs feedback? [17:12:18] is everything cool to go out? [17:12:33] (PS2) Ejegg: Update currency rates [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/223827 [17:13:28] dstrine: There's a commit that awight and I have both worked on which needs reviewing [17:13:43] ok [17:13:47] yeah that [17:13:49] :) [17:15:58] (PS1) Cdentinger: import phone in wmf_civicrm [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/223833 [17:18:24] hey ejegg ^^, i did the phone import stuff on the plane, it was actually pretty simple once i found the right place [17:18:39] or i think that's the right place anyway [17:19:29] cwdent|afk: productive! [17:19:35] I'll take a look [17:20:06] thanks! i'm putting the computer away now :P [17:20:08] later! [17:33:28] (PS1) Ejegg: Dynamically generate JS currency minimum amounts [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/223839 [17:36:29] AndyRussG|mob: got some small DonationInterface changes that you could totally review: https://gerrit.wikimedia.org/r/#/c/223826/1 [18:02:51] (PS1) Ejegg: WIP initialize exchange rate tables [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/223845 [18:03:39] (CR) jenkins-bot: [V: -1] WIP initialize exchange rate tables [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/223845 (owner: Ejegg) [18:10:32] (PS1) Ejegg: Cache one exchange rate per currency per day [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/223846 [18:23:37] (PS2) Ejegg: WIP initialize exchange rate tables [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/223845 [18:24:10] (CR) jenkins-bot: [V: -1] WIP initialize exchange rate tables [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/223845 (owner: Ejegg) [18:35:53] atgo: was K4 off today? [18:36:01] no, she's around [18:36:34] k. I guess she'll ping me if she wants to do the 1 on 1 [19:02:19] (CR) Awight: "What's the purpose of this patch? Seems like the wrong way around to me. There's a WIP script to generate CurrencyRates from the real ex" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/223845 (owner: Ejegg) [19:12:58] (CR) Ejegg: "Yeah, this was for dev installs and for testing. The data may be static, but we at least can set the date at which it was valid to indica" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/223845 (owner: Ejegg) [19:23:44] Fundraising Sprint ODB, Fundraising-Backlog, Astropay Integration: Remove Bank Transfer for Caixa and HSBC in Brazil from Astropay page - https://phabricator.wikimedia.org/T105096#1442592 (Ejegg) a:Ejegg [19:24:05] (PS1) Ejegg: Remove HSBC and Caixa banks from Astropay form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/223889 (https://phabricator.wikimedia.org/T105096) [19:50:34] (PS1) Ejegg: Adapt CSS to number of subpayment choices [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/223894 (https://phabricator.wikimedia.org/T105096) [20:13:52] (CR) Awight: "Great approach! See also modules/exchange_rates/make_exchange_refs.drush.inc for code you might want to reuse or move around..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/223839 (owner: Ejegg) [20:18:05] Is this the channel to complain about eating too much fish? We caught 35 lb of super bloody, high trophic level predator fishmeat yesterday... I feel like I've been pigging out on fishy leftovers for a lifetime now [20:18:14] hi. [20:18:35] awight: ! [20:18:36] awight: Hey! [20:18:41] is it raining in mexico!? [20:18:47] that's the only possible explanation. [20:19:10] atgo: oh hehe you missed my rationale above. I ate tooo much fish meat and cannot move [20:19:21] AndyRussG: what i was asking is if, when we enable banner history mixins and such, readers will sort of reset on the 1st impression [20:19:48] so if megan's team wants to start running some tests next week, and then banner history goes out shortly there after, will people be back at the beginning? [20:20:00] not a huge deal, but trying to investigate/plan [20:20:43] * awight totally butts in. I think banner history will be running in parallel with existing banner diet infrastructure for the forseeable future [20:24:26] thanks awight :) [20:24:31] atgo: ^ you might try email, I've hit a lot of turbulence chatting with AndyRussG|mob on his travelnet [20:24:59] i figured we wouldn't kill anything outright, but eventually we would have to switch over from 1 to the other [20:25:34] Yeah, AndyRussG|mob is kicking all kinds of butt at the conservative migrations [20:28:42] word [20:28:46] ok i'll send an email [20:39:44] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: By default, set the box that says, "I'm not a sociopath or anything, so please show my banner no more than 5 times" on (=banners limited) - https://phabricator.wikimedia.org/T105109#1442915 (atgo) Agreed! We definitely want that to be on by default... [20:40:24] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: By default, set the box that says, "I'm not a sociopath or anything, so please show my banner no more than 5 times" on (=banners limited) - https://phabricator.wikimedia.org/T105109#1442921 (atgo) [20:40:27] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic: [epic] Banner History - https://phabricator.wikimedia.org/T78089#1442920 (atgo) [20:40:52] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic: [epic] Banner History - https://phabricator.wikimedia.org/T78089#835293 (atgo) [20:40:54] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: By default, set the box that says, "I'm not a sociopath or anything, so please show my banner no more than 5 times" on (=banners limited) - https://phabricator.wikimedia.org/T105109#1436502 (atgo) [20:42:48] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Create UI for limiting banner impressions (banner diet?) - https://phabricator.wikimedia.org/T105109#1442942 (atgo) [20:43:10] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Create UI for limiting banner impressions (banner diet?) - https://phabricator.wikimedia.org/T105109#1436502 (atgo) [21:19:40] (CR) Ejegg: "Wow, those seem antediluvian. git log --name-only doesn't list any ExchangeRates files in crm, DI, CN, or tools, anywhere in our history." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/223839 (owner: Ejegg) [21:24:26] Hi atgo! Sorry, I couldn't undertand most of your question for me at the end of Standup... The network turned you into a robot just at the wrong moment... Then, for some reason my chat messages in the hangout didn't seem to go through. What I meant to say at the end was, "maybe we can talk about it on IRC...?" [21:24:34] no worries :) [21:24:38] i also said maybe ew can talk on IRC [21:24:56] what i was asking is if, when we enable banner history mixins and such, readers will sort of reset on the 1st impression [21:24:56] 13:19 atgo: so if megan's team wants to start running some tests next week, and then banner history goes out shortly there after, will people be back at the beginning? [21:24:56] 13:20 atgo: not a huge deal, but trying to investigate/plan [21:24:58] 13:20 awight totally butts in. I think banner history will be running in parallel with existing banner diet infrastructure for the forseeable future [21:24:59] Ah cool! coincidence [21:25:46] ah right [21:26:19] well the history feature itself is different from the replacing the show/hide scripts [21:27:06] We can have the history feature and still be using the same old show/hide stuff (though I might want to double-check the compatibility of that in-banner JS...) [21:27:50] I'll be more optimisitic than awight and say that I think the new show/hide stuff isn't far off! [21:28:29] atgo: ^ [21:29:01] cool, that's what i thought [21:29:34] atgo: IIRC, what we said about the new show/hide stuff is that we could also try to use existing status data about where a user is in the show/hide processes [21:29:50] awesome, thanks [21:29:56] Precisely so as to not disturb that [21:29:59] np! :) [21:33:52] (Abandoned) Ejegg: WIP initialize exchange rate tables [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/223845 (owner: Ejegg) [21:57:02] (PS1) Ejegg: Generate CurrencyRates.php instead of old tables [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/223971 [22:12:04] (PS1) Ejegg: Use static data as ultimate forex fallback [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/223973 [23:55:20] (CR) Awight: "Awesome. In that case, maybe package it as a drush command rather than as a db migration or default behavior? I would think the user sho" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/223845 (owner: Ejegg) [23:56:35] (CR) Awight: "These are really cool changes, but see my comment in the other patch--there should be no way to hit this code on production, without calli" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/223973 (owner: Ejegg)