[16:28:03] ejegg: I just saw that email from Santiago.. does that mean we are blocked on astro pay until monday? [16:28:12] Hi dstrine [16:28:22] was just discussing with ppena in other channel [16:29:39] i mean, we can do it, and either I'll manually retrieve a report or two, or we'll just test the rest of the pipeline now and wait till monday for the audit bit to get its workout [16:34:20] oh sorry [17:04:21] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Don't make donors guess minimum donation amount - https://phabricator.wikimedia.org/T105618#1449876 (atgo) [17:21:09] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: "Preview all approved translations" is dead - https://phabricator.wikimedia.org/T105558#1449942 (atgo) @dstrine we should triage this? [18:24:48] XenoRyet: thanks for merging that audit thing! Do you have a minute to review a couple tiny DonationInterface changes? [18:25:14] If so, they are https://gerrit.wikimedia.org/r/223889 and https://gerrit.wikimedia.org/r/223894 [18:43:43] fundraising-tech-ops, Traffic, operations, Patch-For-Review: Decide what to do with *.donate.wikimedia.org subdomain + TLS - https://phabricator.wikimedia.org/T102827#1450272 (BBlack) p:Triage>Normal [18:57:13] (PS1) Ejegg: Astropay audit: add log_id with full ctid.attempt [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/224457 (https://phabricator.wikimedia.org/T90507) [19:12:17] (PS1) Ejegg: Fix case Astropay->AstroPay [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224459 [19:23:09] (PS1) Ejegg: WIP match on log_id, not just ct_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224462 (https://phabricator.wikimedia.org/T90507) [19:24:10] (CR) jenkins-bot: [V: -1] WIP match on log_id, not just ct_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224462 (https://phabricator.wikimedia.org/T90507) (owner: Ejegg) [19:27:25] Fundraising-Backlog: Investigate World Pay Options for Enhanced silent Order Post (HCG) - https://phabricator.wikimedia.org/T105730#1450390 (DStrine) NEW [19:45:16] (PS1) Ejegg: Whitespace fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224494 [19:56:48] (PS1) Cdentinger: test coverage for phone number import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224496 [20:29:07] XenoRyet: these two are the ones I was talking about: https://gerrit.wikimedia.org/r/223889 and https://gerrit.wikimedia.org/r/223894 [20:29:21] Cool, I'll take a peek, see what's what. [20:29:25] Thanks! [20:30:29] cwdent: I've got one update in SmashPig (https://gerrit.wikimedia.org/r/224457 ), and once that's merged I can update the lib in crm and un-WIP this patch: https://gerrit.wikimedia.org/r/224462 [20:30:51] i'll take a look! [20:30:56] thank you! [20:31:12] if you're bored feel free to check out that test coverage patch above [20:31:14] it's pretty simple [20:31:18] yep, will do! [20:33:00] ejegg: Are we anticipating turning Caixa and HSBC back on at some point in the nearish future? [20:33:29] XenoRyet: maybe! [20:34:01] They said they don't flip them on and off fast enough to mean we should be checking their API's 'what banks are on' call daily [20:34:10] but they didn't say those banks were out for good [20:35:05] Ok, cool. Just weighing between commenting them out and removing them entirely. Sounds like commenting is the way to go for now. [20:43:21] cwdent: that getInfo method is some kind of bridge between PHPUnit tests and simpletest? [20:43:54] heh...good question! it was in the test i copypasted from [20:44:14] thought it might be TAP output or something [20:45:24] oh hey, lots of our PHPUnit tests have them... let me see if simpletest can actually run that stuff [20:54:26] (CR) Ejegg: [C: 2] "Looks good! TODO: figure out if we need to keep adding those getInfo() methods to our PHPUnit tests" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224496 (owner: Cdentinger) [20:55:29] (Merged) jenkins-bot: test coverage for phone number import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224496 (owner: Cdentinger) [20:57:52] ejegg: Looks good to me. If you're confident too, I'll go ahead and +2 [20:58:11] thanks XenoRyet, please go ahead! [20:58:18] (CR) XenoRyet: [C: 2] Remove HSBC and Caixa banks from Astropay form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/223889 (https://phabricator.wikimedia.org/T105096) (owner: Ejegg) [20:58:54] (Merged) jenkins-bot: Remove HSBC and Caixa banks from Astropay form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/223889 (https://phabricator.wikimedia.org/T105096) (owner: Ejegg) [20:59:38] (CR) Cdentinger: [C: 2] "looks like what the crm change needs, i'll take your word for it that those are the right fields, wouldn't hurt anything anyway" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/224457 (https://phabricator.wikimedia.org/T90507) (owner: Ejegg) [20:59:40] (Merged) jenkins-bot: Astropay audit: add log_id with full ctid.attempt [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/224457 (https://phabricator.wikimedia.org/T90507) (owner: Ejegg) [20:59:50] (CR) XenoRyet: [C: 2] Adapt CSS to number of subpayment choices [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/223894 (https://phabricator.wikimedia.org/T105096) (owner: Ejegg) [21:03:20] (PS1) Ejegg: Add @group annotation to PHPUnit tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224513 [21:03:38] thanks cwdent, I'll update the crm patch! [21:03:59] you want that one merged too? [21:04:14] I just need to update the composer.lock [21:04:32] cool [21:04:52] ejegg: wrt that @group one, is that what phpunit needs to make use of --group ? [21:05:05] yep! [21:05:08] nice [21:05:21] very handy to just run a couple tests [21:05:28] and we can phpdoc if we want [21:05:49] also nice to have :) [21:09:18] hey ejegg, i think that ctid thing actually broke the astropay audit test [21:09:24] - 'gateway_refund_id' => 'RFD 33333' [21:09:26] + 'gateway_refund_id' => 'refund:33333' [21:09:42] cwdent: oh dang, I'll update that too! [21:10:12] i probably should have ran the tests before merging... [21:11:50] ah crap, the fixed test is sitting there unstaged [21:12:26] wait, no [21:13:20] huh i'm getting some other new failures too [21:13:26] gonna investigate [21:14:42] (PS1) Ejegg: Fix Astropay Audit test [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/224515 [21:15:49] ejegg: if you run the whole test suite, do you see errors about db constraint violations? [21:15:57] in SmashPig? [21:16:00] or in crm? [21:16:10] in crm [21:16:13] wmf_communication\CiviMailTest [21:17:31] grr, every time I forget --no-dev i get conflicting phpunit versions [21:18:32] heh yeah i get that too, annoying [21:20:10] huh, I get one error in the ImportMessageTest (Exception: field ID needs to be of type Integer for index) which i think is a custom field value misconfigured locally [21:20:25] and one failure in WmfCampaignTest::testMatchingDonation [21:20:37] but my civimail tests pass with flying colors [21:20:50] heh damn [21:20:53] we need tests for the tests [21:21:24] this might be some bunk data in my db [21:25:28] (PS2) Ejegg: Fix case Astropay->AstroPay [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224459 [21:25:30] (PS2) Ejegg: AstroPay audit: match on log_id, not just ct_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224462 (https://phabricator.wikimedia.org/T90507) [21:25:59] ejegg: i think this failure is actually from that glue module commit [21:26:50] (CR) jenkins-bot: [V: -1] Fix case Astropay->AstroPay [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224459 (owner: Ejegg) [21:26:56] ah, phooey [21:27:00] in BaseAuditProcessor [21:27:36] is it the test donation I'm trying to add for the refund? [21:28:10] i think it's the way gateway_refund_id is getting built [21:28:28] - 'gateway_refund_id' => 'RFD 33333' [21:28:30] + 'gateway_refund_id' => 'refund:33333' [21:30:26] "after intense deliberation, we don't actually care what this is at all." [21:31:16] i did change smashPig to go to 'RFD ' instead of 'refund:' - did that get undone somehow? [21:32:18] oh maybe my smashpig is out of date [21:32:22] cwdent, can you doublecheck what revision of smashPig you're at in vendor/wikimedia/smash-pig? [21:32:34] heh, exactly [21:34:12] heh yeah i'm sure that's it but now i must fight with phpunit/drush for a minute [21:34:22] composer update hoses stuff [21:34:29] uff, yeah [21:35:10] why do we manage smashpig with composer instead of a submodule? [21:35:46] idk.. we wanted to be cool kids? [21:36:16] hehe [21:45:28] fatal: Couldn't find remote ref refs/changes/15/224515/1 [21:45:30] wat [21:45:43] blarg? [21:46:09] (PS3) Ejegg: Fix case Astropay->AstroPay [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224459 [21:46:11] (PS3) Ejegg: AstroPay audit: match on log_id, not just ct_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224462 (https://phabricator.wikimedia.org/T90507) [21:46:56] "git review -d 224515" <-- idgi [21:48:47] cwdent: so very odd.. it finds 'em fine with git fetch ssh://ejegg@gerrit.wikimedia.org:29418/wikimedia/fundraising/SmashPig refs/changes/15/224515/1 [21:49:34] wtf [21:54:28] (PS2) Ejegg: Adapt CSS to number of subpayment choices [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/223894 (https://phabricator.wikimedia.org/T105096) [21:55:22] (CR) Ejegg: Adapt CSS to number of subpayment choices (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/223894 (https://phabricator.wikimedia.org/T105096) (owner: Ejegg) [21:57:12] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/223894 (https://phabricator.wikimedia.org/T105096) (owner: Ejegg) [22:00:06] XenoRyet: Jenkins is being dumb and not merging https://gerrit.wikimedia.org/r/223894 . Sometimes it helps to remove the reviewer that originally +2ed it, and have them +2 it again. Got a sec to help battle the bot? [22:00:25] Yea, no problem [22:00:56] Thanks! I just zapped your original approval [22:01:24] (CR) XenoRyet: [C: 2] Adapt CSS to number of subpayment choices [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/223894 (https://phabricator.wikimedia.org/T105096) (owner: Ejegg) [22:01:45] * ejegg crosses fingers [22:01:57] (Merged) jenkins-bot: Adapt CSS to number of subpayment choices [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/223894 (https://phabricator.wikimedia.org/T105096) (owner: Ejegg) [22:01:59] woot! [22:02:02] nice [22:02:06] thanks again XenoRyet [22:02:09] No worries [22:02:21] k, gonna do a tiny DI update on prod to push that out [22:02:31] Cool [22:03:58] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/224523 [22:04:30] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/224523 (owner: Ejegg) [22:06:38] (PS1) Ejegg: Update DonationInterface for deploy [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/224524 [22:07:02] (CR) Ejegg: [C: 2] Update DonationInterface for deploy [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/224524 (owner: Ejegg) [22:12:03] ejegg: i have to go meet the fam for dinner but i'll hop on later/tomorrow and finish merging those tests [22:12:12] thanks! Enjoy dinner [22:12:15] got into some git fuckery with that patch [22:12:25] that wouldn't download for whatever reason [22:12:33] so very odd [22:12:50] i'll figure it out [22:12:52] ttyl! [22:13:05] !log updated payments from ec34ebf61e5962f66b807abdcb519ff323d41e8e to 4ca95d55a9745c05ccfbb16ee6f23a6f75328824 [22:13:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:10:06] (PS1) Ejegg: Show transaction errors, delete dead code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/224539 [23:13:45] (PS2) Ejegg: Show transaction errors, delete dead code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/224539