[00:04:19] (PS1) Ejegg: WIP Interpret AstroPay's shiny new error codes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/224546 [06:38:06] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Remove "getInfo" methods from CRM test classes - https://phabricator.wikimedia.org/T105769#1451306 (awight) NEW [06:49:07] (CR) Awight: [C: 2] "Woohoo! This is huge." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224513 (owner: Ejegg) [06:50:17] (Merged) jenkins-bot: Add @group annotation to PHPUnit tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224513 (owner: Ejegg) [07:01:31] (CR) Ejegg: "Huge, in a totally inconsequential way. Now to figure out what's up with those getInfo methods..." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224513 (owner: Ejegg) [07:01:33] (PS2) Awight: Whitespace and other minor fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224494 (owner: Ejegg) [07:01:39] (PS3) Awight: Whitespace and other minor fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224494 (owner: Ejegg) [07:03:07] (CR) Awight: [C: 2] "Thanks for the consistency!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224494 (owner: Ejegg) [07:04:00] (Merged) jenkins-bot: Whitespace and other minor fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224494 (owner: Ejegg) [07:05:16] (CR) Ejegg: "And thank you for making the commit message more truthful! Thought I could sneak that local variable deletion past the committee..." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224494 (owner: Ejegg) [07:11:41] (CR) Awight: [C: 2] "gah, why has this not been a problem?" (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/224539 (owner: Ejegg) [07:12:11] (Merged) jenkins-bot: Show transaction errors, delete dead code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/224539 (owner: Ejegg) [07:12:57] (PS4) Awight: Fix case Astropay->AstroPay [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224459 (owner: Ejegg) [07:13:35] (CR) Awight: [C: 2] Fix case Astropay->AstroPay [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224459 (owner: Ejegg) [07:14:56] (Merged) jenkins-bot: Fix case Astropay->AstroPay [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224459 (owner: Ejegg) [13:01:20] (CR) Awight: "Just cos we're adding fields to a pretty well-established though funky normalized message schema, what is this new field? Please add a fe" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/224457 (https://phabricator.wikimedia.org/T90507) (owner: Ejegg) [13:02:13] (CR) Awight: [C: 2] Fix Astropay Audit test [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/224515 (owner: Ejegg) [13:02:45] (Merged) jenkins-bot: Fix Astropay Audit test [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/224515 (owner: Ejegg) [14:56:54] Fundraising Tech Backlog: GC prepayment fraud filter: investigate high rejection rate from India test on 7/2 - https://phabricator.wikimedia.org/T105798#1451829 (MBeat33) NEW [17:37:41] hola! [17:39:21] Fundraising Tech Backlog, Fundraising-Backlog: GC prepayment fraud filter: investigate high rejection rate from India test on 7/2 - https://phabricator.wikimedia.org/T105798#1452204 (DStrine) [17:41:33] hi [17:41:56] were you going to ask about: https://phabricator.wikimedia.org/T105244 [17:42:17] I was going to ask at standup [17:45:25] Fundraising-Backlog, Zero: Disable fundraising banners for zero rated devices - https://phabricator.wikimedia.org/T105816#1452215 (atgo) NEW [17:46:10] hey dstrine! [17:46:12] yeah vaguely [17:46:18] i replied anyway [17:46:28] i have a checking with pp mb and cc in a few minutes, too [17:47:08] icinga did barf on everything this morning :P [17:47:27] what do you mean by " i have a checking with pp mb and cc in a few minutes, too" [17:48:11] I'm about to step away for an early lunch but I'll be back well before standup [17:50:01] atgo: will you be at standup or is there anything you would like us to discuss in that time? [17:50:11] yeah i will be at standup [17:50:14] kk [17:50:20] i have a weekly meeting with pats, michael, and caitlin c [17:50:23] that is in a few minutes [17:50:32] undoubtedly the phone number thing will come up [17:52:11] hmm cwdent is looking afk [17:54:48] hey ejegg - just checking in... when do you guys plan to deploy civi stuff that's in PD? [17:57:29] atgo: very soon! [17:57:40] cool, that's what i figured [17:57:47] like... today soon or this week soon? [17:58:01] (PS4) Ejegg: AstroPay audit: match on log_id, not just ct_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224462 (https://phabricator.wikimedia.org/T90507) [17:58:23] atgo: just as soon as I can get that one merged ^^^ [17:58:40] yahoo! [17:58:42] thanks :) [18:24:16] XenoRyet: feel up to one more review in that audit jungle? [18:24:24] Very small one this time [18:24:34] Yea, no problem. [18:24:40] What do you need me to look at? [18:25:00] https://gerrit.wikimedia.org/r/224462 just makes the regex look for a more specific number [18:25:34] the contribution tracking ID is the same for a donor's repeated attempts in the same session [18:25:47] oooh, regex fun. Yea, I'll take a look. [18:25:55] so i added this janky 'log_id' parameter to the parser's messages [18:26:06] that has the whole ct_id.num_attempt [18:30:19] Yea, pretty straightforward. Looks fine to me. [18:30:46] Great! [18:31:04] Once we merge that I can deploy a bunch of CRM stuff [18:31:16] (CR) XenoRyet: [C: 2] AstroPay audit: match on log_id, not just ct_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224462 (https://phabricator.wikimedia.org/T90507) (owner: Ejegg) [18:32:24] (Merged) jenkins-bot: AstroPay audit: match on log_id, not just ct_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224462 (https://phabricator.wikimedia.org/T90507) (owner: Ejegg) [18:32:37] Thanks XenoRyet ! [18:32:48] Yea, no worries. [18:45:56] Fundraising-Backlog, Zero: Disable fundraising banners for zero rated devices - https://phabricator.wikimedia.org/T105816#1452323 (Pcoombe) Do we need to hide all banners, or just fundraising ones? [18:55:04] (PS1) Ejegg: Update dependencies for deploy [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/224653 [18:59:31] (PS2) Ejegg: Update dependencies for deploy [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/224653 [19:38:25] fundraising-tech-ops, Traffic, operations, Patch-For-Review: Decide what to do with *.donate.wikimedia.org subdomain + TLS - https://phabricator.wikimedia.org/T102827#1452388 (Pcoombe) I'm fine with dropping the www.* subdomains if they're going to cause extra work/cost. Couldn't find anywhere that... [19:44:14] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/224661 [19:57:32] (CR) Ejegg: [C: 2] Update dependencies for deploy [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/224653 (owner: Ejegg) [20:00:05] Hi atgomex ! How was the flight? [20:00:11] good! [20:00:15] a bit short for a redeye, to be honest [20:00:17] but otherwise just fine [20:00:27] nice [20:00:32] Fundraising Sprint Lou Reed, Fundraising-Backlog, § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, and 4 others: Update GC audit to read WX file - https://phabricator.wikimedia.org/T86090#1452443 (atgo) [20:01:58] yeah! how's you? [20:02:08] i's good! [20:57:56] hey ejegg, got things almost working again but i keep getting Class 'AstroPayAuditProcessor' not found [20:58:17] i clear the cache but see: [20:58:23] mysql> select * from registry where name like "%astro%"; [20:58:24] Empty set (0.00 sec) [21:00:00] drush en astrpoay_audit ? [21:00:38] yep it's enabled [21:00:43] switching branches sometimes confuses drupal about modules, i think... [21:00:45] and i see the files [21:01:03] well this is a brand new copy, i haven't switched any branches [21:01:07] dang... [21:01:42] does the entry in the syatem table look ok? [21:03:06] as far as i can tell... [21:03:12] is there an astropay_audit module? [21:03:52] yeah [21:04:13] it and the worldpay one are like submodules [21:04:18] oh, well that must be it [21:04:36] i just copy the module enable command from the buildkit [21:04:41] oh, only wmf_audit enabled... [21:04:50] ooh, i need to update that! [21:05:46] and remind myself if those new tests were really running in ci [21:06:37] aaah, all tests passing again [21:06:39] feels good [21:10:45] woohoo [21:35:14] (PS1) Cdentinger: set location and phone type [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224724 [21:40:37] (CR) Ejegg: [C: -1] "Let's look up the magic numbers" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224724 (owner: Cdentinger) [21:45:14] (PS2) Cdentinger: set location and phone type and update test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224724 [22:07:05] (PS3) Cdentinger: set location and phone type and update test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224724 [22:07:26] fundraising-tech-ops, Traffic, operations, Patch-For-Review: Decide what to do with *.donate.wikimedia.org subdomain + TLS - https://phabricator.wikimedia.org/T102827#1452705 (CCogdill_WMF) @Chmarkine, @BBlack, @faidon - can one of you give me a summary of the domains you're proposing we delete? I'... [22:08:40] (CR) Ejegg: [C: 2] "Lookin good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224724 (owner: Cdentinger) [22:14:22] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/224725 [22:14:40] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/224661 (owner: Ejegg) [22:14:58] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/224725 (owner: Ejegg) [22:22:47] !log updated civicrm from 04efc7d5c7bbb068f907125f2184692aee676123 to 6560cefa8d7e68e35e30b310d6691ab57798a4c9 [22:22:52] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:27:01] wahooooooo [22:47:40] hey ejegg! do you need a hand coordinating getting a 1-hour test for Brazil going? [22:47:51] since i theorize that ^ meant the audit stuff went out? :) [22:47:58] Hi atgomex ! [22:48:34] It doesn't matter much to me when we do the test [22:49:02] I do have one more teeny bit of config to ask Jeff_Green for in order to run the audit scripts [22:49:12] before we start receiving donations? [22:49:18] I forgot there were a few directories to create [22:49:44] No, we can get the donations any time now [22:49:51] cool. would it be helpful to start getting files with data in them? [22:49:58] definitely [22:50:32] hmm, i guess i would want to be able to watch the logs though... [22:51:28] So yeah, I'll just email Pats and see what time works for all involved [22:52:38] ah ok. i've got something drafted, too [22:52:48] i'm a little caffeinated and working very quickly ;) [22:52:57] oh, please go ahead then! [22:53:01] thank you! [22:53:46] Just making a phab request for Jeff_Green about those dirs [22:53:54] awesome [22:54:01] feel free to jump in on what i just sent and correct anything [22:55:22] ty [23:00:19] hey atgomex -- phone number thing went out, still set at 0 but i think it's a solid 1-pointer, want me to update the card? [23:00:33] that's probably a dstrine question ^ [23:00:48] oh yeah! [23:01:07] * atgomex passes the torch ;) [23:02:43] first off: LOL "atgomex: i'm a little caffeinated and working very quickly ;)" [23:03:22] cwdent: RE 1 pointer ..yeah mark it [23:04:22] i only speak the truth [23:05:47] I was looking for a Gif of Walter from the big lebowski but they all have "mark it zero" in text at the bottom [23:05:55] * dstrine needs to make his own gifs [23:08:47] Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, Fundraising-Backlog: Enable checks import to save phone number - https://phabricator.wikimedia.org/T105244#1452773 (cwdent) [23:09:20] this is a league game smoky [23:10:50] hehe [23:10:57] must run! family time. ttyl [23:12:00] seeya [23:24:00] well it's looking pretty quiet over here. I'm going to head out too [23:24:11] Catch ya later [23:27:07] time for me too, house is empty, need groceries! [23:27:11] later [23:27:18] so long! [23:31:07] (PS1) Ejegg: Fix drush parse-audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224732 (https://phabricator.wikimedia.org/T90507)