[00:26:07] Fundraising Sprint ODB, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: GlobalCollect is not recurring: something wrong with "batch mode" in DonatioinInterface - https://phabricator.wikimedia.org/T105848#1455872 (Ejegg) The changes I deployed yesterday i... [00:26:28] Fundraising Sprint ODB, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: GlobalCollect is not recurring: something wrong with "batch mode" in DonatioinInterface - https://phabricator.wikimedia.org/T105848#1455876 (Ejegg) a:Ejegg [00:44:34] (PS1) Ejegg: Update recurring GC for DonationInterface changes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224986 (https://phabricator.wikimedia.org/T105848) [00:45:44] (CR) jenkins-bot: [V: -1] Update recurring GC for DonationInterface changes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224986 (https://phabricator.wikimedia.org/T105848) (owner: Ejegg) [00:49:58] (PS2) Ejegg: Update recurring GC for DonationInterface changes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224986 (https://phabricator.wikimedia.org/T105848) [00:55:05] (PS3) Ejegg: Update recurring GC for DonationInterface changes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224986 (https://phabricator.wikimedia.org/T105848) [01:12:11] (PS1) Ejegg: PHPUnit test for DonationInterface::createAdapter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224991 (https://phabricator.wikimedia.org/T105848) [01:15:15] (CR) Ejegg: "Ah, it's only failing for me 'coz strict mode" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224991 (https://phabricator.wikimedia.org/T105848) (owner: Ejegg) [01:15:40] (PS2) Ejegg: PHPUnit test for DonationInterface::createAdapter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224991 (https://phabricator.wikimedia.org/T105848) [04:50:27] Fundraising Tech Backlog, Documentation: Entity relationship diagram for Fundraising - https://phabricator.wikimedia.org/T105991#1456282 (awight) NEW [10:52:17] Fundraising Sprint ODB, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, and 2 others: DonationInterface spam in LocalisationUpdate logs - https://phabricator.wikimedia.org/T105850#1456678 (hashar) a:Ejegg [14:55:13] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/225059 [14:55:50] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/225059 (owner: Ejegg) [14:57:02] (PS1) Ejegg: Update DonationInterface for deploy [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/225061 [14:57:14] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface for deploy [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/225061 (owner: Ejegg) [15:03:34] !log updated payments from 4ca95d55a9745c05ccfbb16ee6f23a6f75328824 to ebb1a9e52172a4793cf5feb33220b4d7edfcad70 [15:03:39] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [15:36:47] hi cwdent! [15:37:01] yo! want those changes to go? [15:37:12] the basic idea is it's returning an object instead of an array? [15:37:16] yep! [15:37:30] that and the new global were all I saw to change [15:37:47] nice, looks super simple [15:38:02] and it can't really get any more broken, want me to merge? [15:39:20] plus there's a nice test now [15:40:09] ack wait, speaking of that: [15:40:13] 1) DonationInterfaceTest::testCreateAdapter [15:40:15] Undefined variable: _SESSION [15:40:39] is there a way to fake sessions for tests? [15:49:51] AndyRussG: Hey, where are you? [15:49:54] Just curious. [15:50:09] Giving a talk! [15:50:17] ha! Neat. :) [15:57:01] Fundraising-Backlog, Astropay Integration: AstroPay gateway not incrementing order ID in some circumstances - https://phabricator.wikimedia.org/T106039#1457464 (Ejegg) NEW [15:57:53] cwdent: oops, sorry [15:58:21] cwdent: yeah, we should be avoiding that session code altogether [15:58:27] np! would just defining global session in the test fix it? [15:58:28] see the commit message for PS1 of that test [15:58:53] There's some code in DI to check if session is a thing before trying to use it for anything [15:59:14] aah, gotcha [15:59:14] but it's not quite doing its job, leading to log spam and strict-mode fails [16:00:06] but yeah, if you like what you see please go ahead and merge! [16:00:25] We can deploy and test a single contribution [16:00:56] ejegg: thanks for helping the astropay test. It's really cool to see this go out. [16:01:20] dstrine: sure is! [16:01:20] gateway.adapter.php 3883L, 130492C [16:01:22] damn [16:01:30] eugh... [16:02:17] cwdent: uh, it's verbosely commented... [16:02:27] :P [16:02:30] think it's probably best to merge now to get this fixed and worry about the test later? [16:02:31] haha [16:02:59] the test actually passes in jenkins... no strict-mode :S [16:03:39] i'm hoping if we merge it it'll prompt us to clean up that session stuff the right wayh [16:03:55] oh word yeah it's just an undef warning [16:04:30] (CR) Cdentinger: [C: 2] Update recurring GC for DonationInterface changes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224986 (https://phabricator.wikimedia.org/T105848) (owner: Ejegg) [16:05:28] (CR) Cdentinger: [C: 2] "there's a warning in strict mode about session being undefined, let's figure out something for that" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224991 (https://phabricator.wikimedia.org/T105848) (owner: Ejegg) [16:05:47] (Merged) jenkins-bot: Update recurring GC for DonationInterface changes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224986 (https://phabricator.wikimedia.org/T105848) (owner: Ejegg) [16:06:42] (Merged) jenkins-bot: PHPUnit test for DonationInterface::createAdapter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224991 (https://phabricator.wikimedia.org/T105848) (owner: Ejegg) [16:07:02] ejegg: one of the biggest favors i ever did myself was wrapping session (and basically every vanilla php feature) in accessor classes [16:07:24] so you can intercept and define whatever behavior you need [16:07:49] good call. we've got wrapper functions in the adapters [16:08:12] but moving them out to a separate class is on the todo list [16:08:33] the scope of changing it everywhere would be insane of course but if we are careful we can probably just do it and plug in as needed [16:10:19] as sprawling as DI is, it does a halfway decent job of containing globals [16:11:14] hey ejegg the-wub i haven’t been checking. going ok? [16:11:21] need anything from me? [16:11:43] meganhernandez: yes it seems fine. we're monitoring in the other channel [16:11:55] seems mostly good so far! [16:12:51] getting a few timeouts trying to initiate payments when traffic is heavy [16:14:12] and uncovered a situation where we sometimes don't update our order id on 2nd attempts [16:14:59] but no bad data or collapses anywhere [16:19:40] Fundraising Tech Backlog: "Transaction communication failed" log line no longer provides useful information - https://phabricator.wikimedia.org/T106048#1457648 (Ejegg) NEW [16:22:34] Fundraising Tech Backlog, Astropay Integration: Clean up AstroPay ffname logspam - https://phabricator.wikimedia.org/T106050#1457668 (Ejegg) NEW [16:23:28] Fundraising Tech Backlog, Fundraising-Backlog, Astropay Integration: Clean up AstroPay ffname logspam - https://phabricator.wikimedia.org/T106050#1457676 (DStrine) [16:34:24] Fundraising-Backlog, Astropay Integration: Add AstroPay to FundraiserLandingPage for Brazil - https://phabricator.wikimedia.org/T106052#1457712 (Ejegg) NEW [16:43:18] Fundraising-Backlog, Astropay Integration: Parse AstroPay error codes / description and display appropriate messages to donor - https://phabricator.wikimedia.org/T106053#1457747 (Ejegg) NEW [16:43:47] Fundraising-Backlog, Astropay Integration: Add AstroPay to FundraiserLandingPage for Brazil - https://phabricator.wikimedia.org/T106052#1457754 (Pcoombe) a:Pcoombe [16:43:50] K4-713: Hey! I'm done the talk and follow-up q & a [16:44:33] Cool. And now I'm involved in things. [16:44:42] I will just see you when I see you. :) [16:45:34] K! [17:08:10] Fundraising Sprint Enya, Fundraising Sprint Flaming Lips, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Make Civi Reminders work in Staging - https://phabricator.wikimedia.org/T86345#1457910 (Jgreen) [17:08:12] Wikimedia-Fundraising, fundraising-tech-ops: Need access to PHP error logs on lutetium - https://phabricator.wikimedia.org/T89992#1457908 (Jgreen) Open>Resolved this is done! [17:15:22] Fundraising-Backlog, fundraising-tech-ops, Security-Reviews: Select website domains for Major Gifts events tool - https://phabricator.wikimedia.org/T104357#1457958 (csteipp) @CCogdill_WMF, I'm happy to chat with them. I'm in the office this week, and out all next week. [17:19:28] fundraising-tech-ops: overhaul fundraising cluster monitoring - https://phabricator.wikimedia.org/T91508#1457973 (Jgreen) [17:48:09] Fundraising-Backlog, Astropay Integration: Parse AstroPay error codes / description and display appropriate messages to donor - https://phabricator.wikimedia.org/T106053#1458064 (Ejegg) Here's the full dump of possible responses provided by AstroPay: | {"status":"1","desc":"Empty param x_login"}... [18:20:23] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/225108 [18:20:46] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/225108 (owner: Ejegg) [18:22:13] !log updated civicrm from 24e0fc854433ea4982e94a0fd2f8bdad8f8dcad7 to fa724dd2e2e69545d81015c943cb7f52cf6de8e1 [18:22:18] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:23:23] ok, going to try sending through one recurring donor [18:26:08] !log changed batch size from 250 to 1 in RGC jenkins job [18:26:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:29:27] hmm, seems to be getting through 1 new one successfully, then dying trying to retry 1 old one [18:34:30] Fundraising Sprint ODB, Fundraising-Backlog: Rearrange order of CC logos on GC form for Japan - https://phabricator.wikimedia.org/T102496#1458268 (XenoRyet) a:XenoRyet [19:18:26] hi awight! How's the mania? [19:24:45] ejegg: hey! It officially starts tomorrow, but pre-conference stuff has been a blast so far. [19:24:56] Editors are fascinating animals as always [19:26:00] I see you've been causing serious Phabricator collateral damage [19:26:18] Need me to jump on any CR? [19:27:23] btw, next year's wikimania will be a much more epic venue... the organizer is a wiki genius, as well, so I have high expectations [19:28:38] aww, wish i was there. definitely next year! [19:29:19] cwdent reviewed the patches I had, but that wasn't all the fix we needed [19:30:10] I tried running a batch size of 1 - it correctly charged the first user, but when it retried a failed charge it errored out [19:31:29] with the 'Not implemented' stdClass::__set_state(array(... [19:31:53] Ouch. Annoying that we didn't get a stack trace in syslog or anything... [19:32:01] code paths don't look so different [19:32:19] that array is definitely select * from civicrm_contribution_recur [19:32:26] Or maybe we did? Seems like there's only those two functions which can cause the Not implemented exception. Maybe it's worth just freaking implementing them... [19:32:41] * AndyRussG waves [19:32:47] wmf_communication already has the i18n message stuff if you want [19:32:49] AndyRussG: hey! [19:33:27] Wait, which functions cause Not implemented ? [19:33:38] AndyRussG: fwiw I'm headed to the "World cafe" ed program thing at 3:45, it's helpful to hear real stories [19:33:46] ejegg: ah sorry, I think I commented in the parallel Phab task or something [19:33:59] It's coming from a stub function in WmfFramework [19:34:28] oh, so source: stdClass::__set_state is a big red herring [19:34:40] I've seen that before, but can't remember wtf it means [19:34:48] awight: I've been talking to Harej and Isarra about editor campaigns [19:34:49] silly PHP internal [19:34:52] yeah, red herring IMO [19:35:20] AndyRussG: great! Looking forward to getting the skinny [19:36:13] What's the world cafe? [19:36:48] AndyRussG: I know... the EP program is really poorly explained, I was complaining about that to Floor and she said, we wouldn't want even more people to be interested than already are ;) [19:37:11] AndyRussG: lemme paste the blurb, it's in the google registration form O_O [19:39:29] awight: thx! [19:39:34] np! [19:40:57] ejegg: It's embarrassing, but I only wrote shim functions to replace MediaWiki core calls if they were in the code paths we used for RGC, two years ago. It's not at all surprising that we would need to shim out a few more functions as our code evolves. [19:41:14] In other words, this probably isn't a bug, just hitting new code. [19:41:31] right... [19:41:57] i also want to make a logger that outputs to drush [19:42:01] Cool! [19:42:16] Or... actually watchdog -> syslog would be better [19:42:28] then the code isn't coupled to drush [19:42:51] ah right, and we still get it in the drush -v output [19:43:00] yep [19:43:09] also in syslog [19:43:32] furthermore: I hate drush. [19:43:58] Just cos it's better than clicking through the Drupal labyrinth doesn't make it okay [19:44:34] ahem [19:44:58] Sorry, the thing really slowing me down on the CR is that I haven't set up a payments instance yet. [19:45:13] nor crm [19:45:19] what am I even doing with my life :) [19:45:28] hehe, sounds like paradise [19:45:29] oh, I have crm [19:45:32] baaahahaha [19:45:43] just fishing at the beach and ignoring my email [19:46:08] You should try it. [19:46:27] AndyRussG: you in the hacking cave? [19:46:32] oh, i'll take a nice vaca soon enough! [19:46:41] awight: yep! [19:46:59] Haven't been to New Orleans in 2 years... [19:47:17] ejegg: awesome! We'll batten the hatches to keep DonationInterface from flooding while you're gone [19:51:52] was that a katrina joke? [20:05:39] ejegg: you around for standup? [20:05:49] oh shoot, be there in one sec! [21:19:04] hey ejegg, got a few to explain the GC recurring problem space? i'm ready whenever [21:20:00] oh man, i'm just confusing myself more the more i look [21:20:02] but sure! [21:20:04] now is good [21:20:12] cool! i'll ring ya [22:21:49] hello! [22:21:53] hi [22:22:01] how's it going? [22:24:50] good! sorry i missed autopsy. things ran super late and buses are slow slow in mexico [22:25:52] you have some stuff in email but the astropay test looked successful [22:26:04] we have some bugs in the analysis column [22:26:32] ejegg: and cwdent: were actively discussing the recurring payment bugs [22:27:30] Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Write Astropay audit file processor - https://phabricator.wikimedia.org/T90507#1459047 (atgo) This is the most exciting! [22:29:23] yeeeeaaaaah...complimuhcated [22:30:03] yeah i just looked through the emails! awesome [22:30:07] Fundraising-Backlog, Astropay Integration: Add AstroPay to FundraiserLandingPage for Brazil - https://phabricator.wikimedia.org/T106052#1459060 (Pcoombe) Open>Resolved [22:30:15] is there anything i can triage today? [22:30:43] that you need :) [22:31:08] how do you feel about the prioritization of sprint +2? [22:35:15] (PS1) Ejegg: Quit demoting log messages to debug under drupal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/225257 (https://phabricator.wikimedia.org/T105848) [22:36:17] let me look [22:41:06] dstrine: should i pull things into +1? [22:43:07] we were going to see how much info we got out of amazon and that would take precedence in sprint 1 but if you can communicate a line or something that would be helpful. We need to know what MUST happen along with amazon ... then the rest can be in priority order [22:43:35] that might not be a clear answer :) [22:45:10] cool i got you [22:45:24] yar [22:45:55] Fundraising-Backlog: Sprint P GOAL: start amazon, major gifts import, and finish banner history! - https://phabricator.wikimedia.org/T102198#1459131 (atgo) [22:46:18] yeah banner history will definitely spill over [22:46:45] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Recent Engage Import - Contribution Type = Cash when it should be Engage - https://phabricator.wikimedia.org/T100853#1322277 (atgo) @ppena wanted to make sure you know this is an issue... [22:46:47] word [22:47:01] k i'm going to leave it at that [22:47:25] ok I see more stuff in sprint 1 [22:47:36] is sprint 2 in an ok order ... just in case? [22:50:03] oui [22:50:20] danke [22:50:55] Fundraising Tech Backlog, Fundraising-Backlog, Epic: [epic] PCI gap analysis and Improvements - https://phabricator.wikimedia.org/T77912#1459148 (atgo) [22:51:04] I think that's what we need for next week [22:51:19] We'll just follow priority order [22:51:29] (PS1) Ejegg: Better success check for recurring globalcollect [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/225261 (https://phabricator.wikimedia.org/T105848) [22:52:12] awesome! [22:52:18] :) [22:58:13] hey dstrine can you send the sprint summary email next week? :D [22:58:30] yeah sure [22:58:52] I'm making an hidden meeting reminder for myself [23:01:14] (PS1) Ejegg: Get all the log messages from DonationInterface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/225263 [23:10:16] (PS1) Ejegg: WIP: Fix recurring GC false success report [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/225265 (https://phabricator.wikimedia.org/T105848) [23:10:30] ok, I'm out for the evening. Have a good one all! [23:10:46] (CR) jenkins-bot: [V: -1] WIP: Fix recurring GC false success report [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/225265 (https://phabricator.wikimedia.org/T105848) (owner: Ejegg) [23:10:59] seeya Congrats on getting Astropay out!!! [23:11:56] thanks! [23:58:33] Fundraising-Backlog, fundraising-tech-ops, Security-Reviews: Select website domains for Major Gifts events tool - https://phabricator.wikimedia.org/T104357#1459220 (CCogdill_WMF)