[03:07:15] <grrrit-wm>	 (PS1) Ori.livneh: Remove dead code for targetting users based on UserDailyContribs data [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/225669
[03:08:00] <grrrit-wm>	 (PS2) Ori.livneh: Remove dead code for targetting users based on UserDailyContribs data [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/225669
[12:59:40] <awight>	 atgo: Stop that immediately
[13:00:53] <atgo>	 awight: ...?
[13:01:05] <awight>	 Aha!  You're actually working, I saw it
[13:01:18] <atgo>	 last night!
[13:01:32] <atgo>	 i'm on vacation startingt omorrow :)
[13:07:46] <awight>	 ©_©
[13:08:06] <awight>	 Just trying to take it out on someone else that I'm working too
[13:11:11] <atgo>	 hehe i saw your email
[13:11:29] <awight>	 Yeah that thing Megan uncovered is interesting.
[13:11:47] <awight>	 I've been imagining how to collect all our gotchas... it's a long list.
[13:11:58] <atgo>	 i think she's only concerned about the new subscriptions
[13:12:16] <awight>	 perfect
[13:13:53] <awight>	 I'm very curious to hear what she's currently using to look at this data, though.  Like I wrote, I don't remember having this discussion yet.
[15:44:08] <grrrit-wm>	 (CR) Awight: [C: 2] Fix undefined var warning [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/225560 (owner: Ejegg)
[15:44:10] <grrrit-wm>	 (Merged) jenkins-bot: Fix undefined var warning [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/225560 (owner: Ejegg)
[15:44:59] <awight>	 ejegg|away: Holding off on the crm->DI rollback, cos the tests fail...  That's still the plan though, right?
[15:45:17] <grrrit-wm>	 (PS3) Awight: amend update to fix Direct Mail Appeal custom field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/225492 (owner: Cdentinger)
[15:50:54] <grrrit-wm>	 (CR) Awight: [C: 2] "Thanks for writing this, it makes the code way more readable! There are some small things to fix, see the inline comments, but totally me" (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/225492 (owner: Cdentinger)
[15:51:05] <grrrit-wm>	 (PS3) Awight: Rearrange order of CC logos on GC form for Japan [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/225359 (https://phabricator.wikimedia.org/T102496) (owner: XenoRyet)
[15:51:46] <grrrit-wm>	 (Merged) jenkins-bot: amend update to fix Direct Mail Appeal custom field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/225492 (owner: Cdentinger)
[15:51:50] <grrrit-wm>	 (CR) Awight: [C: 2] Rearrange order of CC logos on GC form for Japan (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/225359 (https://phabricator.wikimedia.org/T102496) (owner: XenoRyet)
[15:52:15] <grrrit-wm>	 (Merged) jenkins-bot: Rearrange order of CC logos on GC form for Japan [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/225359 (https://phabricator.wikimedia.org/T102496) (owner: XenoRyet)
[15:52:24] <grrrit-wm>	 (CR) Awight: [C: -2] "I'm temporarily blocking this, cos it looks like it depends on the newer DI?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/225261 (https://phabricator.wikimedia.org/T105848) (owner: Ejegg)
[15:54:53] <grrrit-wm>	 (CR) Awight: [C: 2] "Sorry, I think I reviewed this from an airport. I'm merging cos it's great, but there are things to fix inline, and the cross-repo CG iss" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/223971 (owner: Ejegg)
[15:55:03] <grrrit-wm>	 (PS2) Awight: Generate CurrencyRates.php instead of old tables [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/223971 (owner: Ejegg)
[15:55:22] <grrrit-wm>	 (PS4) Awight: Update currency rates [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/223827 (owner: Ejegg)
[15:56:50] <grrrit-wm>	 (CR) Awight: [C: 2] "I'm not sure what's going on here--we shouldn't depend on actual reference data for testing, there should be separate fixtures which set a" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/223827 (owner: Ejegg)
[15:57:12] <grrrit-wm>	 (PS2) Awight: Dynamically generate JS currency minimum amounts [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/223839 (owner: Ejegg)
[15:57:14] <grrrit-wm>	 (Merged) jenkins-bot: Update currency rates [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/223827 (owner: Ejegg)
[15:58:45] <grrrit-wm>	 (CR) Awight: [C: 2] "Clever! It would be much less complicated to just generate the .js file, though. What am I missing?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/223839 (owner: Ejegg)
[15:59:13] <grrrit-wm>	 (Merged) jenkins-bot: Dynamically generate JS currency minimum amounts [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/223839 (owner: Ejegg)
[16:00:51] <grrrit-wm>	 (CR) Awight: [C: -1] "Can you fix it in your local setup instead? We shouldn't have to have an origin repo, and many of us are cloning from https, then using g" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224872 (owner: Ejegg)
[16:08:06] <grrrit-wm>	 (PS4) Awight: enable passthru of utm_* fields during check import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/217018 (owner: Cdentinger)
[16:09:19] <grrrit-wm>	 (CR) Awight: [C: 2] "Nvm, my comments weren't valid. We won't be importing recurring contrib in the near future, and having something in utm_medium is just fi" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/217018 (owner: Cdentinger)
[16:10:13] <grrrit-wm>	 (Merged) jenkins-bot: enable passthru of utm_* fields during check import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/217018 (owner: Cdentinger)
[16:16:54] <wikibugs>	 Fundraising-Backlog: Put real-time email ecom data in Google Spreadsheet - https://phabricator.wikimedia.org/T105900#1463674 (awight) Source code for my prototype is here, http://git.wikimedia.org/tree/wikimedia%2Ffundraising%2Ftools/HEAD/live_analysis  The roadmap, if we decide to pursue this, would be some...
[16:18:21] <grrrit-wm>	 (PS3) Awight: Generate CurrencyRates.php instead of old tables [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/223971 (owner: Ejegg)
[16:19:08] <grrrit-wm>	 (CR) Awight: [C: -1] Use static data as ultimate forex fallback [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/223973 (owner: Ejegg)
[17:59:32] <grrrit-wm>	 (CR) AndyRussG: "Thanks!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/225669 (owner: Ori.livneh)
[18:01:10] <grrrit-wm>	 (CR) Legoktm: "Since this is being exported as a JS variable, do we need to check if any banners are using it...?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/225669 (owner: Ori.livneh)
[18:01:32] <grrrit-wm>	 (CR) Legoktm: "...I'm slow." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/225669 (owner: Ori.livneh)
[20:19:18] <wikibugs>	 Fundraising-Backlog: Set up import for Major Gifts events payment/invitation tool - https://phabricator.wikimedia.org/T101191#1464047 (awight) Looks like this is on track.  Here are our canonical templates, or the link @ejegg sent works fine, too.  http://git.wikimedia.org/tree/wikimedia%2Ffundraising%2Fcrm/...
[20:22:40] <wikibugs>	 Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, and 4 others: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1464054 (awight) @LeanneS: Those are up to date, but the...
[20:24:18] <wikibugs>	 Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, and 4 others: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1464056 (awight) omg.  One moment please, we're having t...