[12:04:13] (PS1) Paladox: Remove i18n shim [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/226064 [12:04:28] (PS2) Paladox: Remove i18n shim [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/226064 [12:23:27] (PS3) Paladox: Updated extension registration to new system [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/213315 (https://phabricator.wikimedia.org/T87903) (owner: Parent5446) [15:06:23] morning ejegg [15:06:30] hi cwdent [15:06:39] can i ask you a central notice question? [15:06:41] pretty basic [15:06:45] sure [15:07:27] it says my user needs centralnotice-admin permission to manage banners -- does that go in user_groups? [15:08:33] huh, i actually don't know what tables hold permissions! I think the structure is user - group/role - permission [15:08:47] so I'd guess more like group_permissions [15:09:00] but let me take a look [15:09:29] hrm i don't see that table...i see user_properties [15:09:44] up_value | blob [15:09:47] o_O [15:11:33] huh, not seeing anything likely here either [15:12:03] this is where i'm looking fyi https://www.mediawiki.org/wiki/Extension:CentralNotice#Permissions [15:14:36] yeah, I guess user_groups is the table [15:14:40] ejegg: well adding it to user_groups worked [15:14:42] whoop, yeah [15:14:47] and I guess the groups themselves are all in code [15:14:54] not db [15:14:55] is there UI for that? i just did it from sql cli [15:15:09] Special:UserRights [15:15:23] nice [15:15:29] but for some reason my CN wiki isn't showing the CN admin group as an option... [15:15:58] yeah i don't see it either [15:16:24] guessing it's a hook some place to add your extension's roles [15:20:08] "We expect to begin offering NextLight service to our Phase 2 customers in August." [15:20:11] * cwdent rejoices [15:24:21] ejegg: Think I should deploy the 1.25 upgrade to paymentswiki today? [15:25:08] sure, if Jeff_Green is available for backup/restore! [15:25:21] whut. yeah [15:25:40] just to backup/restore the paymentswiki database? [15:25:52] traffic seemed pretty light yesterday during donationinterface deploy [15:26:57] it's fine with me, i'm around [15:27:02] Jeff_Green: yeah, just in case. i think there are some big schema changes [15:27:03] the paymentsdb gets backed up nightly [15:27:06] k [15:27:11] nice [15:27:33] awight: let's do it! [15:27:41] Yeah, and it's a maintenance mode sort of thing... the-wub what do you think? [15:28:42] I see there are some long-running tests, but no short ones until tomorrow, which is good. [15:29:14] awight: we're still up high level in Japan, but it's the middle of the night there so we should be okay if it's a quick deploy [15:30:50] Okay, perfect. I'll email the outage window when we finish. [15:31:22] I'm missed a lot... no problems reported with the JP campaign? wowza [15:32:50] Fundraising Sprint ODB, Fundraising-Backlog, Patch-For-Review: Rearrange order of CC logos on GC form for Japan - https://phabricator.wikimedia.org/T102496#1467064 (Ejegg) Open>Resolved [15:33:36] apologies, am on a train so internet is shaky. awight ejegg: how long do you think the maintenance mode will be needed? [15:35:29] the-wub_: hehe. We can wait until you land, if you wish. Maintenance mode will be between 5 minutes and an hour. [15:35:54] the-wub_: For convenience, http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-fundraising/ [15:36:03] the-wub_: You didn't miss anything, though. [15:36:20] oh cool, K4-713 put the link back into the /topic [15:39:13] ok thanks awight. I should be off the train and on better internet in about 30 minutes or so. let me know when works for you [15:39:32] should also give megan a heads up [15:40:17] That sounds perfect. We can also wait a day so meganhernandez is in the loop. [15:40:47] I'll prepare the deployment, and try pinging her via email. [15:40:47] megan's planning big EN tests tomorrow though [15:40:57] I think she's online, just not in irc [15:40:58] ooh. hrm.. hmph [15:48:10] (PS1) Awight: Merge REL1_25 into fundraising/REL1_25 [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/226088 [15:53:04] (PS1) Awight: update DonationInterface to current deployment head [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/226089 [15:53:23] ejegg: I'm smoke testing ^^ these two now [15:53:33] nice, I'll take a look too [15:53:38] thanks! [15:54:58] looks like I need to bump vendor/ as well [15:55:11] ah, probably [16:05:32] ok awight, I'm back and on sweet sweet wi-fi [16:06:28] the-wub: rad, and sorry to rush you. I'm still fiddling with the repos, then will spend a bit testing basic behavior. [16:10:32] (PS1) Awight: update vendor submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/226093 [16:21:55] awight: ygm. how big a hassle if we delay the payments upgrade until Thursday? [16:26:08] the-wub: no problem, I'm emailing back now! [16:26:31] It's been a long-term goal anyway, makes sense to do the exciting deployment at the best possible time. [16:36:13] i got a CN banner to show up [16:36:15] hooray [16:36:24] hehehe [16:39:08] is it possible to use the same wiki as vendor and subscriber? [16:39:10] for CN? [16:39:42] just put banner in the url? [16:40:28] cwdent: yes, it should be easy. the banner= param is just for forcing the banner to display [16:40:44] Maybe you need to set the project global... looking for that now [16:41:29] i noticed that wgNoticeInfrastructure is supposed to be true for vendor but false for subscriber [16:41:55] subscriber doesn't have any checks [16:42:05] so if you set it to true, you can play both boxes [16:42:09] ah cool [16:42:16] btw, start the process to get yerself on this list: https://meta.wikimedia.org/w/index.php?title=Special:ListUsers&group=centralnoticeadmin [16:43:06] $wgNoticeProject is the one to look at [16:43:27] cool, it defaults to 'wikipedia' [16:43:38] awight: what's the process? [16:43:49] so if your banner is set to always display on enwiki, and your local wiki is set to English, you should see the banner. [16:43:52] cwdent: [16:44:10] cwdent: Good question. I think you have to bug a bureaucrat. jalexander or pbeaudette [16:44:19] are pretty responsive [16:44:41] cool, will do [16:49:21] cwdent: Note that banners don't appear in the Special: namespace, so go to the main page or a Random article. [16:50:06] cool [16:50:32] i would definitely be interested in digging in to CN if there is a need [16:50:35] it's a cool project [16:51:20] this is good: http://idlewords.com/talks/web_design_first_100_years.htm [16:53:46] cwdent: are you able to attend the team health check on thursday? [16:54:10] for sure [16:57:58] dstrine: Hey, sorry if you're still sailing solo, clinging to the rigging in the fundraising pirate corner [16:58:16] yar! [16:58:37] * awight lets loose a volley of leeward grapeshot [16:58:37] I'm chillin in sf... and I mean it's finally cold again :) [16:59:09] thanks cwdent: [16:59:29] Yeah, if it's 73 here, probably 53 over there :p [17:03:18] cwdent: The not-so-spruce goose: http://www.businessinsider.com/the-soviet-unions-secret-flying-ekranoplan-2014-2 [17:04:03] somehow, it looks like it was built with rust and lichen included [17:06:12] "add engines until airborne" [17:08:28] lol wow [17:08:59] there are some really great photos of the abandoned soviet shuttle program to [17:09:07] * dstrine digs through facebook [17:09:49] http://www.businessinsider.com/photos-of-russian-abandoned-space-shuttles-by-ralph-mirebs-2015-6 [17:17:07] cwdent: I'm only part way through that article... its very cool [17:17:43] So beautiful, it really says a lot about humans. We're like a colony of genius ants. [17:20:42] (PS3) Ejegg: Validate fiscal number when exists, require for AstroPay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/225349 (https://phabricator.wikimedia.org/T106171) [17:23:10] (ejegg) Payments 1.25 passes my local smoke test, via GC [17:23:15] Lookin' good. [17:23:58] Where do I find the test creds for Astropay? [17:23:59] awight: nice! I didn't see any issues loading things or hitting the AstroPay sandbox [17:24:05] oh, good! [17:24:16] well, lemme tag the patches with the bug number... [17:24:55] (PS2) Awight: update vendor submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/226093 (https://phabricator.wikimedia.org/T94528) [17:25:13] awight: that vendor update doesn't seem to point to an existing revision tho [17:26:01] it's in review! [17:26:10] oh, sorry! [17:53:39] awight: I'm thinking about the paynments wiki upgrade. I'm not sure anyone outside of fr-tech knew that was on the table this week (I didn't either). How risky is an upgrade like that? Is there a minimum amount of notice we should be giving for these? [17:54:03] Oops, I made that upgrade meeting in the wrong time zone. [17:54:10] dstrine: It's not particularly risky [17:54:24] ok [17:54:32] I explained a bit in the meeting description, the annoying part is a database restore to roll back the schema migrations. [17:54:46] Fortunately, it's a tiny database, and there's no donor data. [17:55:35] ok [17:55:44] Thurdsay, 10-11 PDT [17:55:58] dstrine: And, sorry to rattle everyone with a spontaneous decision to deploy. [17:56:05] just saw the invite and joined it [17:56:15] It surprised me, too :) [17:56:32] I don't know that is was that big an issue...I'm just trying to learn risk levels [17:56:40] Just looking for something to do, and that'll be a nice introductory thing to get me back into the swing of it [17:56:48] cool cool [17:57:08] Thursday works perfectly as well! [17:57:14] so awight: whats the worst that could happen? [17:57:17] This is https://phabricator.wikimedia.org/T94528 fyi [17:57:32] The worst scenario is that we take an hour to get back online [17:58:21] so if a campaign was turned on at that time... would donations fail in some way? [18:00:35] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Machine-readable CentralNotice and paymentswiki outage log - https://phabricator.wikimedia.org/T106394#1467894 (awight) NEW [18:00:54] dstrine: yes, we should disable FR campaigns during this time! [18:01:18] dstrine: Thanks, adding that to the deployment notes. [18:01:19] aight [18:05:19] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint N*E*R*D, and 5 others: Upgrade payments mw-core to REL1_25 - https://phabricator.wikimedia.org/T94528#1467950 (awight) [18:06:52] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint N*E*R*D, and 5 others: Upgrade payments mw-core to REL1_25 - https://phabricator.wikimedia.org/T94528#1165770 (awight) [18:09:53] (PS2) Awight: update DonationInterface to current deployment head [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/226089 (https://phabricator.wikimedia.org/T94528) [18:10:08] (PS2) Awight: Merge REL1_25 into fundraising/REL1_25 [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/226088 (https://phabricator.wikimedia.org/T94528) [19:23:58] (PS4) Awight: Validate fiscal number when exists, require for AstroPay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/225349 (https://phabricator.wikimedia.org/T106171) (owner: Ejegg) [19:28:55] (CR) Awight: [C: -1] "Looks too strict." (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/225349 (https://phabricator.wikimedia.org/T106171) (owner: Ejegg) [19:34:31] awight: what is in the 1.25 version of wikipayments? Is there anything user facing? [19:42:58] dstrine: There are lots of minor things, I should scan the release notes for anything notable, though. [19:46:26] dstrine: All I can think of is that CSS changes might make our forms look funny... [19:47:51] sorry to bug at lunch. My irc had 2 of you until I reconnected :P [19:48:16] this is just me learning... where would I find release notes? I see a tasks here: https://phabricator.wikimedia.org/T94528 [19:48:41] but it has a lot of gerrit stuff I can't grok [19:49:34] No worries, I think I lunch'd after you mentioned it [19:52:15] Here's the not-so-skinny: http://git.wikimedia.org/raw/mediawiki%2Fcore.git/4b0ed1b799e34a5f9c941f7c15ce8f6d28a1ffb1/HISTORY [19:57:56] jeez that's a longlist [19:58:53] did fr-tech implement all this? [19:59:55] aw hell nah [20:00:14] dstrine: if i understand correctly we're upgrading mediawiki core on the payments box [20:00:29] oooh ok [20:00:35] which is literally _the_ wiki [20:00:59] I hear about new tools and stuff every other day so I keep assuming I'm hearing about something new [20:01:54] well i guess _the_ wiki is http://c2.com/cgi/wiki [20:02:10] hehe dstrine me too [20:40:24] sorry ejegg: ! [20:40:42] ehh, I blame AT&T [20:41:07] ok I thought we got too serious in our BS session [20:41:09] 4g always gets flaky around 1/2 hr of video chat [20:41:16] oh weird [20:41:30] either that or my phone can't handle it [20:41:32] well that keeps meetings efficient! [20:41:54] dstrine: no way [20:41:57] This is amazing [20:52:58] ok it's looking rather dead on the 3rd floor. I'm going to run home and sign back on. talk to ya'll in a bit [21:07:32] Minor thing--can someone lmk whether you can edit the description of this Loomio discussion? https://www.loomio.org/d/di5AzlCH/referendum-minutes-taking-agreements [21:09:26] yeah i can [21:09:30] i added 2 spaces at the end [21:11:37] Thank you for your feedback :) [21:37:24] (PS1) Ejegg: Add country-specific versions of fiscal_number [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226231 (https://phabricator.wikimedia.org/T106137) [21:43:07] (CR) Awight: [C: 2] "A big improvement! Looks like the fallback message should be generalized, though. I'm not sure there are cases where we get this message" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226231 (https://phabricator.wikimedia.org/T106137) (owner: Ejegg) [21:44:22] ejegg: Donno if you want to track this discussion, http://lists.civicrm.org/lists/arc/civicrm-api/2015-07/msg00012.html [21:46:46] awight: ooh, reminder tokens! [21:47:11] yeah, that stuff definitely needs work [21:47:50] Probably not something we'll need to worry about for a few years of release cycle, as well, but it might be worth throwing a stone [21:48:12] right... [22:24:37] ejegg: Inexplicable: There's no "submit" button on https://gerrit.wikimedia.org/r/#/c/226231/ ?? [22:24:59] Do json-only commits have special rules? [22:25:27] well, hold off for a second in any case - i'll fix those generic messages in pt and pt-br [22:25:54] ejegg: Oh! interesting [22:31:21] cwdent: select * from civicrm_custom_field f join civicrm_custom_group g on f.custom_group_id=g.id where column_name='import_batch_number'; [22:31:40] "extends" is still mostly a medieval mystery to me... [22:32:56] 'extends' is the entity type a custom group applies to. There's also a sub-type restriction... [22:33:19] extends_entity_column_* are where I get subverbal [22:33:31] for example, extends_entity_column_value: ^A17^A21^A13^A [22:33:37] That is not okay in any sense of the word. [22:34:05] please tell me that's control characters that have been normalized to ascii and put in a database [22:35:43] that's a list separator. Don't even ask about the alpha and the omega [22:36:16] I sincerely hope these values were created manually at some point in the evolution of this feature. [22:37:33] it looks like whatever i print when i type ctl+v ctl+a [22:38:56] (PS5) Ejegg: Validate fiscal number when exists, require for AstroPay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/225349 (https://phabricator.wikimedia.org/T106171) [22:42:14] (PS2) Ejegg: Add country-specific versions of fiscal_number [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226231 (https://phabricator.wikimedia.org/T106137) [22:53:33] (CR) Awight: [C: 2] "Very nice!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226231 (https://phabricator.wikimedia.org/T106137) (owner: Ejegg) [22:53:46] Meanwhile, how to submit? [22:54:22] heh, i'm about to tack on a unit test to see if a php file helps [22:55:25] (PS3) Ejegg: Add country-specific versions of fiscal_number [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226231 (https://phabricator.wikimedia.org/T106137) [22:56:07] oops, looks like jenkins was about to merge that last PS [22:57:08] bah, nope. [22:57:30] ok, gonna abandon and resubmit with a different change ID [22:57:46] (Abandoned) Ejegg: Add country-specific versions of fiscal_number [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226231 (https://phabricator.wikimedia.org/T106137) (owner: Ejegg) [22:58:14] (PS1) Ejegg: Add country-specific versions of fiscal_number [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226239 (https://phabricator.wikimedia.org/T106137) [22:59:56] awight: I may have messed up that last one by adding a new PS while jenkins was running gate-and-submit. Can I trouble you to bless the reincarnated version ^^ [23:00:00] ? [23:03:30] (CR) Awight: "By the way, this is a great compromise, to validate length only." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/225349 (https://phabricator.wikimedia.org/T106171) (owner: Ejegg) [23:03:37] (PS6) Awight: Validate fiscal number when exists, require for AstroPay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/225349 (https://phabricator.wikimedia.org/T106171) (owner: Ejegg) [23:11:36] (CR) Awight: [C: 2] "I think I found a dried booger, but it doesn't hurt anything." (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/225349 (https://phabricator.wikimedia.org/T106171) (owner: Ejegg) [23:11:59] (Merged) jenkins-bot: Validate fiscal number when exists, require for AstroPay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/225349 (https://phabricator.wikimedia.org/T106171) (owner: Ejegg) [23:13:22] ejegg: hehehe, ok looking again [23:13:36] (PS2) Awight: Add country-specific versions of fiscal_number [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226239 (https://phabricator.wikimedia.org/T106137) (owner: Ejegg) [23:14:03] (CR) Ejegg: "Oh darn, I meant to take that back out of DonationData. I moved it to gateway-specific staging in case other processors want to get the p" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/225349 (https://phabricator.wikimedia.org/T106171) (owner: Ejegg) [23:28:54] Fundraising Sprint ODB, Fundraising-Backlog, Astropay Integration, Patch-For-Review: Update Brazil fiscal number to CPF - https://phabricator.wikimedia.org/T106137#1469368 (Ejegg) [23:32:41] (PS1) Ejegg: Undo last commit's fiscal number normalization [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226248 (https://phabricator.wikimedia.org/T106171) [23:58:10] (CR) Awight: [C: 2] "Sure!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226248 (https://phabricator.wikimedia.org/T106171) (owner: Ejegg) [23:58:31] (Merged) jenkins-bot: Undo last commit's fiscal number normalization [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226248 (https://phabricator.wikimedia.org/T106171) (owner: Ejegg)