[00:00:37] <wikibugs>	 Fundraising research, Research-and-Data: Consult on FR "Banner History" cookie - https://phabricator.wikimedia.org/T99170#1477475 (DarTar)
[00:02:04] <wikibugs>	 Fundraising research, Research-and-Data: Scope donor contribution campaign test - https://phabricator.wikimedia.org/T104652#1477487 (DarTar)
[00:07:55] <awight>	 K4-713: AndyRussG|souper: so... ori infected me with his enthusiasm, and I think it's possible to kill a major fire-breathing head of special:recordimpression
[00:07:58] <awight>	 like this evening.
[00:08:58] <awight>	 OK nvm, I have no deployment access at the moment.
[00:09:02] <awight>	 Well played, opsen.
[00:24:45] <wikibugs>	 Fundraising research, Research-and-Data-Archive: Fundraising add notebooks to google drive folder - https://phabricator.wikimedia.org/T99192#1477584 (DarTar)
[00:24:54] <wikibugs>	 Fundraising research, Research-and-Data-Archive: Fundraising recurring estimate fiscal year 2015 - 2016 - https://phabricator.wikimedia.org/T99190#1477586 (DarTar)
[00:25:16] <wikibugs>	 Fundraising research, Research-and-Data-Archive: Fundraising April 2015 repeat test analysis - https://phabricator.wikimedia.org/T99185#1477589 (DarTar)
[00:25:43] <wikibugs>	 Fundraising research, Research-and-Data-Archive: Fundraising "wikigrok" style data question - https://phabricator.wikimedia.org/T99186#1477592 (DarTar)
[00:26:01] <wikibugs>	 Fundraising research, Research-and-Data-Archive: US mobile traffic projections - https://phabricator.wikimedia.org/T99183#1477595 (DarTar)
[00:39:42] <K4-713>	 Aw, oops.
[00:39:56] <K4-713>	 Well... maybe it's for the best.
[00:40:27] <K4-713>	 marktraceur: Hey, you might still be here.
[00:41:51] <K4-713>	 ...d'oh.
[00:41:54] <K4-713>	 Ah well.
[00:52:03] <AndyRussG|souper>	 ?
[00:52:04] <AndyRussG|souper>	 basson
[00:54:05] <K4-713>	 AndyRussG|souper: bahaha
[00:54:18] <K4-713>	 My desktop computer, is fine.
[00:54:25] <K4-713>	 It was in fact a dead power supply.
[00:54:40] <K4-713>	 I did not lose aaaaall the data.
[00:56:41] <AndyRussG|souper>	 Cool! Wikipedia lives to see another day :)
[01:00:06] <K4-713>	 Har, not that data.
[01:00:21] <K4-713>	 My data has been in danger way too many times this year.
[01:00:34] <K4-713>	 But the cloud can go to hell. I got this.
[01:12:31] <AndyRussG>	 Hmmm... Yeah I'm also somewhat cloud-phobic
[01:12:38] <AndyRussG>	 I do like web sites, though
[01:12:51] <AndyRussG>	 So long as they're sunny
[01:17:12] <marktraceur>	 K4-713: Oh no, what?
[01:17:48] <marktraceur>	 AndyRussG: That must make flying difficult
[01:20:13] <AndyRussG>	 marktraceur: heh it depends on the altitude
[08:37:07] <wikibugs>	 Fundraising Sprint The Pogues, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Epic, and 3 others: Eliminate PHP backend call for Special:RecordImpression - https://phabricator.wikimedia.org/T106624#1478358 (Nemo_bis) How about `/beacon/impression` instead of `//{$wmfHostnames['meta']}/b...
[09:41:55] <wikibugs>	 Fundraising Sprint The Pogues, Fundraising-Backlog, Unplanned-Sprint-Work: Footer images on payments missing - https://phabricator.wikimedia.org/T106728#1478532 (Pcoombe) Resolved>Open poweredby_mediawiki is still missing. Even though we don't actually show it in the footer, it still causes a 40...
[15:01:26] <wikibugs>	 Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Confirm orphan slaying works once using Redis, then stop writing to ActiveMQ - https://phabricator.wikimedia.org/T99018#1479201 (Jgreen)
[16:15:57] <cwdent>	 awight: did you go to bed last night?
[16:16:07] <awight>	 ha
[16:16:21] <awight>	 Too many babies and dogs in my bed for sleep
[16:17:00] <cwdent>	 best 30 seconds i've spent today https://www.youtube.com/watch?v=wKiIroiCvZ0
[16:25:11] <cwdent>	 follow up https://www.youtube.com/watch?v=F4wh_mc8hRE
[16:26:55] <cwdent>	 awight: could you give me just a real basic explanation of how messages get stored in groups in the db wrt translate extension?  i see the groups but don't get the mapping.
[16:27:25] <awight>	 it's rough.  This is the class to look at, CN/includes/BannerMessageGroup.php
[16:27:56] <cwdent>	 ah perfect, thanks
[16:28:03] <awight>	 banner content: MediaWiki:Centralnotice-template-BANNERNAME
[16:28:31] <awight>	 message key (after group is published, or if not using translate): Centralnotice-BANNERNAME-MESSAGENAME
[16:29:10] <awight>	 translation group name: MediaWiki:Centralnotice-tgroup-BANNERNAME
[16:29:24] <cwdent>	 yeah, i see those in the translate table
[16:29:39] <cwdent>	 just somehow the messages i create are not getting added to the group
[16:29:45] <awight>	 Apparently, translation messages go to the translation group first, then when you publish them, they're copied into mediawiki:
[16:30:09] <awight>	 You need a special permission to publish CN translation groups.
[16:30:56] <wikibugs>	 Fundraising research, Research-and-Data: Spain recurring fundraising test - https://phabricator.wikimedia.org/T99199#1479496 (DarTar) p:Triage>Normal
[16:31:11] <cwdent>	 i thought i heard something about these getting stored as wikitext flatfiles...is there any truth to that?
[16:32:05] <cwdent>	 and yeah awight from my limited knowledge the problem definitely appears to be in the translation -> mediawiki step
[16:33:52] <awight>	 I haven't heard anything about wikitext representation.  I would have immediately stepped into the amnesia strobe if I had heard such a thing, though.
[16:35:12] <cwdent>	 hehe ok, so a translate message can basically be any field in a table?  is that what that messageindex map table is about?
[16:35:26] <wikibugs>	 Fundraising research, Research-and-Data: Review Finland banner testing strategies - https://phabricator.wikimedia.org/T105561#1479588 (DarTar) p:Triage>Normal
[16:35:51] <awight>	 cwdent: Donno what a "table" is in this context
[16:35:58] <awight>	 now have I heard of messageindex map
[16:36:06] <awight>	 ^w^r
[16:37:00] <cwdent>	 heh ok, i'm just stabbing blindly.  i read the translate docs i could find but they are more geared towards translators than debuggers
[16:37:22] <awight>	 Have you been able to go through the process of creating and publishing messages locally?
[16:37:55] <cwdent>	 i can create them, but when i click on em it says nothing in this group, so i can't publish
[16:38:00] <awight>	 ooh
[16:38:08] <cwdent>	 i may be missing a step
[16:38:19] <awight>	 Will try locally in a minute
[16:38:36] <cwdent>	 kk, only if you're bored, i don't mind futzing
[16:40:42] <wikibugs>	 Fundraising Sprint The Pogues, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Epic, and 3 others: Eliminate PHP backend call for Special:RecordImpression - https://phabricator.wikimedia.org/T106624#1479624 (awight) @Nemo_bis: great idea!
[16:48:33] <awight>	 Hah, I'm getting so many exceptions...
[17:05:00] <awight>	 cwdent: Okay, I'm with you now.  "This message group is empty"
[17:05:44] <cwdent>	 cool.  this must be a configuration thing, i assume people do this in prod with some regularity
[17:05:51] <awight>	 yeah
[17:05:55] <awight>	 this sucks
[17:06:17] <cwdent>	 hehe, don't burden yourself, i'm on the case
[17:07:16] <awight>	 translate_* tables are mostly empty...
[17:08:12] <cwdent>	 yeah, except group.  could it be a hook that adds messages to groups that's missing?
[17:08:26] <awight>	 Not seeing anything exciting in the mediawiki-config/wmf-config
[17:09:52] <awight>	 I tried setting the en message in the banner editor; tried setting a priority language
[17:12:10] <cwdent>	 hmm, i see this registerGroupHook that sets a group to translatable
[17:14:14] <awight>	 I'm getting an exception whenever I save banner content with a new message, it's trying to add to the wrong banner.  I think that's just db corruption, though.
[17:14:47] <cwdent>	 hrm yeah that seems to work for me
[17:18:52] <awight>	 rebuilding new db...
[17:20:57] <awight>	 cwdent: This is a legit bug.
[17:21:04] <awight>	 Can you make a task for it?
[17:21:50] <cwdent>	 you bet
[17:21:55] <awight>	 I totally started from scratch, made a banner, added a message, it created the translation group, and: empty.
[17:22:04] <cwdent>	 happy to assign myself and keep digging
[17:22:24] <awight>	 thx.  Not too surprising, I think we last touched the Translate integration around mw 1.22 or 1.23
[17:22:42] <awight>	 Why does it work on production...
[17:22:49] <cwdent>	 yeah that's what i wanna know
[17:23:07] <awight>	 IMO we should be documenting or even better, shipping, dev settings that make it possible to do all the things.
[17:24:08] <cwdent>	 definitely, especially if we want community hacking to occur
[17:31:33] <ejegg>	 Re: encouraging community hacking, I scribbled some thoughts on pushing stuff into SmashPig here: https://www.mediawiki.org/wiki/Fundraising_tech/Refactor
[17:31:57] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate: New banner messages not added to message group - https://phabricator.wikimedia.org/T106856#1479964 (cwdent) NEW a:cwdent
[17:32:06] <ejegg>	 I'm pretty sure awight has a similar brainstorm someplace, but I can't remember where
[17:32:23] <awight>	 Awesome!
[17:33:03] <ejegg>	 K4-713 / cwdent, I'd love it if you had any feedback / edits / comments on https://www.mediawiki.org/wiki/Fundraising_tech/Refactor
[17:33:06] <awight>	 A big DI responsibility to call out: form generation
[17:33:08] <cwdent>	 righteous ejegg
[17:33:23] <K4-713>	 woo!
[17:34:17] <K4-713>	 Oh, I have so many things to add here.
[17:34:18] <awight>	 SP things TODO: component that helps manage normalized donation messages at the point of use (from the CRM)
[17:34:38] <ejegg>	 I figure I shouldn't spend too much more time rearranging deck chairs on the gateway adapters as they stand now
[17:34:40] <K4-713>	 So many things.
[17:34:51] <awight>	 Anyone mind if I blow up the world for a bit?
[17:34:58] <K4-713>	 GO FOR IT, ADAM.
[17:35:01] <K4-713>	 :p
[17:35:02] * ejegg absconds to moon
[17:36:11] <K4-713>	 ejegg: Some fun smashpiggy thoughts: So far, all our information about what payment methods work for who, is entirely dependent on our account configuration.
[17:36:25] <K4-713>	 If we want other people to use this, it's going to have to be two layers.
[17:36:41] <ejegg>	 hmm, yeah
[17:36:45] <K4-713>	 Universal truths, and our settings.
[17:37:01] <ejegg>	 I was thinking we'd need different classes for different integration types with the same processor too
[17:37:07] <K4-713>	 yep
[17:37:38] <K4-713>	 Totally Hosted, iFrame Migraine Mode, and PCI Rules Lawyer mode.
[17:37:40] <awight>	 cool
[17:37:47] <ejegg>	 heh
[17:38:02] <ejegg>	 please edit away!
[17:38:26] <ejegg>	  / reorganize / move to more descriptive title
[17:42:15] <wikibugs>	 Fundraising Sprint The Pogues, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Epic, and 3 others: Eliminate PHP backend call for Special:RecordImpression - https://phabricator.wikimedia.org/T106624#1480059 (AndyRussG) Looking great!!  When would be a likely deploy time (just so we can g...
[17:42:40] <wikibugs>	 Fundraising Sprint The Pogues, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Epic, and 3 others: Eliminate PHP backend call for Special:RecordImpression - https://phabricator.wikimedia.org/T106624#1480060 (awight)
[17:42:48] <wikibugs>	 Fundraising Sprint The Pogues, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Epic, and 3 others: Eliminate PHP backend call for Special:RecordImpression - https://phabricator.wikimedia.org/T106624#1473154 (awight)
[17:44:00] <AndyRussG>	 awight: oooh checklist
[17:44:13] <AndyRussG>	 cool!
[17:44:13] <awight>	 ino!  I just learned that from halfak
[17:44:51] <AndyRussG>	 neat! indeed Phab is pretty markdown-full
[17:45:15] <awight>	 Can't say I ever miss bugzilla
[17:45:37] <AndyRussG>	 aww bugzilla was classic!
[17:46:07] <wikibugs>	 Fundraising Sprint The Pogues, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Epic, and 3 others: Eliminate PHP backend call for Special:RecordImpression - https://phabricator.wikimedia.org/T106624#1480082 (awight)
[17:46:29] <awight>	 sure, but I never think to myself, "where's that feature that we used to have"
[17:47:27] <cwdent>	 if no one minds i'm going to head down to boulder and meet the homies for lunch
[17:48:14] <awight>	 Hey, can someone send me the URL for the google calendar with the FR testing schedule?
[17:48:57] <awight>	 or I guess they work by unique email address
[17:49:39] <AndyRussG>	 cwdent: have fun!
[17:49:42] <AndyRussG>	 awight: wat?
[17:50:07] <awight>	 There's a google calendar with the exact banner testing schedule... I used to have it...
[17:51:06] <cwdent>	 yeah!  i'll be available on phone and back before standup
[17:55:33] <AndyRussG>	 awight: nice! I didn't know... Hmmm don't see the-wub or his teamies around
[17:56:27] <awight>	 K4-713: can you get that calendar ID for us? ^^
[17:56:39] <K4-713>	 maybe?
[17:56:43] <awight>	 hehe
[17:57:00] * awight scowls about how this is probably already on a hidden wiki page
[17:57:45] <K4-713>	 awight: Okay, so... I can give you the ID, but the permissions are set such that it won't help you.
[17:57:53] <awight>	 no
[17:57:58] <K4-713>	 I think you have to ask meganhernandez to add you.
[17:58:05] <awight>	 I... used to be able to see it
[17:58:10] <awight>	 it's just not searchable, it seems
[17:58:22] <K4-713>	 "Anyone can: See nothing"
[17:58:52] <K4-713>	 How do you look at the calendars?
[17:59:19] <K4-713>	 I'm not sure how you go about losing one unless you're doing some funny API magic.
[17:59:55] <K4-713>	 Just to clarify: That wasn't "How does one look at calendars." it was meant to be "how do you specifically, choose to access your calendars?"
[18:01:50] <awight>	 if you click on the dropdown next to the calendar name in the left sidebar, "Calendar settings", there's a calendar ID, e.g.  nh6tvfh5cilocrjmbdhflb5vsk@group.calendar.google.com for "Fundraising Schedule"
[18:02:00] <K4-713>	 Yeah, I get that.
[18:02:01] <awight>	 you probably can't edit visibility on the testing one
[18:02:25] <awight>	 So, I'm able to see Fundraising Schedule and it also says "anyone can: see nothing" which is not even grammar
[18:02:41] <K4-713>	 How can you get to that, and not see the events?
[18:02:58] <K4-713>	 I see the same thing there.
[18:02:59] <awight>	 I need the other one--the testing calendar
[18:03:15] * awight prepares a facepalm for self
[18:03:40] <K4-713>	 Ooooh.
[18:03:45] <K4-713>	 That's an everyone calendar.
[18:03:50] <K4-713>	 Calendar ID:  8bhpbpjtu1k7agbck05j59lmv4@group.calendar.google.com
[18:04:43] <grrrit-wm>	 (PS1) Ori.livneh: Only call MobileContext::getMobileUrl() for non-relative URLs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/226751
[18:05:12] <awight>	 K4-713: THANKS
[18:05:46] <K4-713>	 yar
[18:06:17] <awight>	 AndyRussG: ^ since you understand this diceyness better than me...
[18:06:33] <K4-713>	 Lesson here: Never try to multitask while the other thing is trying to comprehend ADP.
[18:10:49] <AndyRussG>	 awight: thanks... BTW I'm now not remembering the exact conclusion from yesterday about geoIP: should the new and separated geoIP module be top-loaded, or are we gonna bottom-then-middle it like we'll probably do with the rest, and just see what breaks?
[18:12:10] <awight>	 Krinkle was fine with moving it to the bottom and seeing what breaks.
[18:12:51] <awight>	 We can continue setting the Geo global for a slightly polite deprecation, but anything that needs geoip should depend on this module from now on.
[18:13:01] <grrrit-wm>	 (CR) AndyRussG: "I think this is a weedy patch of code... Lemme check if it's even at all useful... Sorry we haven't been trimming the overgrowth much! (Or" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/226751 (owner: Ori.livneh)
[18:13:55] <AndyRussG>	 awight: K thanks! Mmm where do you think it should go eventually? Core?
[18:14:13] <awight>	 mmmpfff
[18:14:14] <AndyRussG>	 Also, I think moving modules from one queue to another will take a month of cache-convection
[18:14:31] <awight>	 a month?
[18:14:41] <AndyRussG>	 'cause it's in the HTML
[18:15:01] <AndyRussG>	 in a <script> tag that gets the long cache
[18:15:03] <awight>	 ooooh
[18:15:11] <awight>	 rats
[18:15:39] <grrrit-wm>	 (CR) Awight: "I worry that we still want the mobile URL, even if this code is passed relative URLs. Seems like a better workaround, until MobileContext" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/226751 (owner: Ori.livneh)
[18:16:54] <AndyRussG>	 Still, likely no harm if we gt a mix of tops and bottoms for a while
[18:17:00] <AndyRussG>	 Variety is the spice of cache-life
[18:17:40] <AndyRussG>	 Arrg I gotta go drive people around in a little while!
[18:25:12] <grrrit-wm>	 (CR) Awight: [C: -1] "Per discussion." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/226751 (owner: Ori.livneh)
[18:30:17] <wikibugs>	 Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Determine how to load CentralNotice RL modules and when to execute campaign and banner selection logic - https://phabricator.wikimedia.org/T106577#1480320 (AndyRussG) Some notes from yesterday's meeting: - P...
[18:42:47] <grrrit-wm>	 (PS1) Awight: Read banner impressions from new file [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/226766 (https://phabricator.wikimedia.org/T106624)
[18:47:53] <grrrit-wm>	 (CR) Ori.livneh: [C: 1] Read banner impressions from new file [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/226766 (https://phabricator.wikimedia.org/T106624) (owner: Awight)
[18:48:17] <grrrit-wm>	 (PS2) Awight: Read banner impressions from new file [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/226766 (https://phabricator.wikimedia.org/T106624)
[19:01:31] <grrrit-wm>	 (CR) Ejegg: "Just one question" (1 comment) [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/226766 (https://phabricator.wikimedia.org/T106624) (owner: Awight)
[19:01:58] <wikibugs>	 Fundraising Sprint The Pogues, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Epic, and 3 others: Eliminate PHP backend call for Special:RecordImpression - https://phabricator.wikimedia.org/T106624#1480432 (awight) The CentralNotice config change was deployed at 20150724 18:39. > ori Sy...
[19:03:30] <grrrit-wm>	 (CR) Awight: Read banner impressions from new file (1 comment) [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/226766 (https://phabricator.wikimedia.org/T106624) (owner: Awight)
[19:03:57] <grrrit-wm>	 (PS3) Awight: Read banner impressions from new file [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/226766 (https://phabricator.wikimedia.org/T106624)
[19:06:10] <ejegg>	 awight: cutover on the beacon URL is just the cache time for mw global settings, right?
[19:06:37] <awight|fud>	 ejegg: it should be 5 min, but there seems to be a lot of laggy stuff coming in.
[19:06:49] <awight|fud>	 I'm pretty sad we can't parse both streams of files.
[19:06:55] <awight|fud>	 Back in a minute!
[19:07:36] <ejegg>	 cool.  So FR won't spend much time pining for the beacon impressions
[19:38:03] <awight>	 ejegg: okay, we've parsed most of the old file's tail.  Wanna CR that django patch
[19:38:06] <awight>	 ?
[19:38:41] <grrrit-wm>	 (CR) Ejegg: [C: 2 V: 2] "slick!" [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/226766 (https://phabricator.wikimedia.org/T106624) (owner: Awight)
[19:38:48] * awight blinks
[19:39:21] <ejegg>	 heh, got distracted after I grepped for other occurrences of 'bannerImpressions'
[19:39:27] <ejegg>	 ty for reminder
[19:40:23] <awight>	 !log updated DjangoBannerStats from 3db799dc8705c728c7261ae433e8197f5498fa1b to 57a0392b3f43b65050b01a0465e120ed609a769e
[19:40:29] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[19:40:35] <awight>	 No problem, it was... instantaneous
[19:44:08] <wikibugs>	 Fundraising Sprint The Pogues, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Epic, and 3 others: Eliminate PHP backend call for Special:RecordImpression - https://phabricator.wikimedia.org/T106624#1473154 (awight) We'll need to occasionally trawl the bannerImpressions files to import t...
[19:45:52] <wikibugs>	 Fundraising Sprint The Pogues, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Epic, and 3 others: Eliminate PHP backend call for Special:RecordImpression - https://phabricator.wikimedia.org/T106624#1480644 (awight) Confirmed that the database is populated with counts from the new files.
[19:53:23] <ejegg>	 awight: awesome!
[19:56:35] <awight>	 Freaking thrilling!
[19:56:55] <awight>	 I estimate we were still making about 1M S:RI calls per hour.  All were hitting the app servers
[19:57:11] <awight>	 And that's down from maybe 100M an hour, before AndyRussG's sampling patch!
[20:10:31] <wikibugs>	 Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate, Unplanned-Sprint-Work: New banner messages not added to message group - https://phabricator.wikimedia.org/T106856#1480766 (awight)
[20:13:21] <wikibugs>	 Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate, Unplanned-Sprint-Work: New banner messages not added to message group - https://phabricator.wikimedia.org/T106856#1480796 (awight)
[20:13:24] <wikibugs>	 Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, Fundraising Sprint The Pogues, Fundraising-Backlog, and 4 others: Publishing translations for central notice banners fails - https://phabricator.wikimedia.org/T104774#1480795 (awight)
[20:32:43] <wikibugs>	 Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Epic, Patch-For-Review, and 2 others: Special:RecordImpression should die in a fire - https://phabricator.wikimedia.org/T45250#1480864 (awight)
[20:32:46] <wikibugs>	 Fundraising Sprint The Pogues, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Epic, and 3 others: Eliminate PHP backend call for Special:RecordImpression - https://phabricator.wikimedia.org/T106624#1480863 (awight) Open>Resolved
[20:33:26] <awight>	 I'm gonna relocate in a bit, anybody need things from me before I get on the train?
[20:34:45] <cwdent>	 not i
[20:35:01] * awight continues marching up and down the square
[20:38:00] <wikibugs>	 Fundraising Sprint The Pogues, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Patch-For-Review, and 2 others: Eliminate PHP backend call for Special:RecordImpression - https://phabricator.wikimedia.org/T106624#1480875 (Nemo_bis)
[20:47:43] <awight>	 OK, relocating...
[21:16:39] <grrrit-wm>	 (PS1) Ejegg: Use old error forms for AstroPay fail page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226917 (https://phabricator.wikimedia.org/T106053)
[21:24:35] <grrrit-wm>	 (PS1) Ejegg: Check error['context'] to place error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226920 (https://phabricator.wikimedia.org/T106053)
[21:26:10] <grrrit-wm>	 (PS3) Ejegg: Parse more of AstroPay's error descriptions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/224546 (https://phabricator.wikimedia.org/T106053)
[21:29:10] <grrrit-wm>	 (PS4) Ejegg: Parse more of AstroPay's error descriptions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/224546 (https://phabricator.wikimedia.org/T106053)
[21:42:31] <ejegg>	 oh damn, numAttempt does not necessarily mean what I think it means
[21:42:51] <ejegg>	 just noticing it only gets incremented when you set a final status
[21:43:31] <ejegg>	 so that explains https://phabricator.wikimedia.org/T106039
[21:46:11] <wikibugs>	 Fundraising Sprint The Pogues, Fundraising-Backlog, Astropay Integration: AstroPay gateway not incrementing order ID in some circumstances - https://phabricator.wikimedia.org/T106039#1481098 (Ejegg) Note to self: numAttempt only gets incremented when you set a final status.  Either the AstroPay adapte...
[22:03:20] <grrrit-wm>	 (PS5) Ejegg: Parse more of AstroPay's error descriptions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/224546 (https://phabricator.wikimedia.org/T106053)
[22:05:24] <K4-713>	 ejegg: numAttempt?
[22:05:46] <K4-713>	 Yeah, it's supposed to count discrete payment attempts according to the user.
[22:06:24] <K4-713>	 Just out of curiosity, what did you think it was doing?
[22:08:30] <wikibugs>	 Fundraising Sprint The Pogues, Fundraising-Backlog, Astropay Integration, Patch-For-Review: Parse AstroPay error codes / description and display appropriate messages to donor - https://phabricator.wikimedia.org/T106053#1481156 (Ejegg) We only saw 'invalid control' errors for users who put spaces in...
[22:17:38] <awight>	 Got totally kid-jacked by the neighbors...
[22:17:42] <awight>	 no fence
[22:17:47] <awight>	 what is this, a commune?
[22:23:49] <awight>	 That's completely insane.  One of them has hearing protectors which allows her to make a 90dB sound with the recorder
[22:32:46] <wikibugs>	 Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Epic, Patch-For-Review, and 2 others: Special:RecordImpression should die in a fire - https://phabricator.wikimedia.org/T45250#1481216 (ori) {F251375}
[22:41:58] <dstrine>	 sorry but: https://en.wikipedia.org/wiki/Schadenfreude
[22:42:14] <dstrine>	 "awight> what is this, a commune?" lulz
[22:45:14] <awight>	 You have to nip this sort of visiting in the bud, you see.  Next thing you know, there will be decentralized decision-making and nothing will ever get decided, just a forkbomb of reply-all emails talking about what kind of granola to buy the kids
[22:48:58] <dstrine>	 lololol
[22:51:42] <wikibugs>	 Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint The Pogues, and 4 others: Populate 30-60 minutes of limbo queue in the new Redis store - https://phabricator.wikimedia.org/T106906#1481292 (awight) NEW a:awight
[22:52:37] <wikibugs>	 Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint The Pogues, and 4 others: Orphan slayer reads from frack Redis rather than ActiveMQ - https://phabricator.wikimedia.org/T99017#1481301 (awight)
[22:52:39] <wikibugs>	 Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Tech Backlog, and 3 others: Provide access to limbo messages without knowing keys - https://phabricator.wikimedia.org/T99152#1481299 (awight) Open>Resolved This code has been written.  Tra...
[22:53:26] <wikibugs>	 Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Stop writing to ActiveMQ once orphan slaying on Redis has been tested  - https://phabricator.wikimedia.org/T99018#1481302 (awight)
[22:54:19] <wikibugs>	 Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint The Pogues, and 4 others: Populate an hour of limbo queue in the new Redis store - https://phabricator.wikimedia.org/T106906#1481303 (awight)
[22:57:24] <ejegg>	 K4-713: oops, sorry I missed your ping!  I thought numAttempt got incremented with each submit, or at least with each new round of API calls to the processor
[22:57:51] <wikibugs>	 Fundraising Sprint James Brown, Fundraising Sprint The Pogues, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: All code that writes to the limbo queue will start writing to both queues. - https://phabricator.wikimedia.org/T99015#1481314 (awight)
[22:58:08] <K4-713>	 ejegg: We really need some documentation, huh?
[22:58:32] <ejegg>	 heh, guess so.
[22:58:52] <ejegg>	 I think I'm going to increment it on each NumAttempt call for AstroPay
[22:59:12] <ejegg>	 I'd count it as an 'attempt' if we validate it ok, even if the processor doesn't
[22:59:48] <K4-713>	 There are more things that key off that, though.
[22:59:48] <ejegg>	 Do we analyze attempt counts or use that number for other important stuff?
[23:00:11] <K4-713>	 Like, the validation token.
[23:00:15] <ejegg>	 Hmm, OK
[23:00:22] <K4-713>	 And... whether or not we refresh the contribution tracking ID.
[23:00:48] <K4-713>	 So, if you increment numAttempt a lot, you won't be able to correlate anything in the logs, really.
[23:00:59] <ejegg>	 Oh dang, really?
[23:01:06] <K4-713>	 Antifraud may also go mad.
[23:01:21] <ejegg>	 So that would mean there's no reason at all to use the ct_id.numAttempt format for order ID
[23:01:41] <K4-713>	 Oh. Also I think when ctid goes, so does the session data.
[23:01:46] <ejegg>	 We do need something to increment with each API call though, so we don't get all these order id collisions
[23:02:09] <K4-713>	 This is a problem we have had before.
[23:02:33] <K4-713>	 I... think we may have cheaped out and solved it with a rand().
[23:03:19] <ejegg>	 aw man
[23:03:52] <K4-713>	 well... order_id . '.' . rand()
[23:04:04] <ejegg>	 ok, i'll take a good hard look at this stuff before I start screwing with numAttempt any further
[23:04:25] <K4-713>	 Yeah, numAttempt is a complicated hairball.
[23:04:54] <K4-713>	 Hehe... it used to be a hidden form field that would just post back to the system, instead of contained in the session data.
[23:05:22] <K4-713>	 So, people could just keep using the same post data to... harm.
[23:05:32] <K4-713>	 That's how I found it.
[23:05:36] <ejegg>	 ahh, cool
[23:05:39] <K4-713>	 And now I'm getting all nostalgic again.
[23:06:02] <ejegg>	 hehe
[23:06:31] <ejegg>	 well, guess i'll pick that up again monday... have a great weekend!
[23:06:36] <K4-713>	 You too!
[23:10:06] <wikibugs>	 Fundraising research, Research-and-Data: Fundraising how to calculate confidence on future recurring donations - https://phabricator.wikimedia.org/T99191#1481382 (DarTar)
[23:17:18] <wikibugs>	 Fundraising Sprint James Brown, Fundraising Sprint The Pogues, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: All code that writes to the limbo queue will start writing to both queues. - https://phabricator.wikimedia.org/T99015#1481442 (awight)
[23:29:21] <dstrine>	 I'm heading out. Have a good weekend: http://p.fod4.com/p/media/c83462f691/MEBAEfsfRICDdwzvYlbA_s1.gif
[23:30:44] <awight>	 O_O subscribe