[00:22:51] awight: cwdent|afk: did u get why Krinkle said not to worry about testing the full stack of functionality in geoIP? Maybe 'cause it's not unit-y? Or 'cause it's not what's prone to failure? [00:24:14] Prolly just so that we're testing our own code and not random external things [00:24:45] Personally I like units + integration [00:31:09] awight: ah right... Yes indeed we wouldn't test the live call, instead we'd mock it [00:44:01] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Gateway reconciliation might not be recognizing Square refunds - https://phabricator.wikimedia.org/T107228#1490371 (atgo) [00:47:10] AndyRussG: oh definitely mock any 3rd party stuff. But I think Krinkle was suggesting that we don't even bother running the code that would make the call. [00:47:15] Doesn't sound right to me ;) [00:47:44] awight: Yeah agree'd [00:50:52] AndyRussG: yes i agree we fake the ajax call but worth mocking it [00:51:07] cwdent: cool! [00:51:47] awight: cwdent: I guess make the adjustments to geoIP to have access to methods on this patch, and then add the tests in a follow-on patch? [00:52:02] or do it all in the follow-on patch? [00:52:56] AndyRussG: i guess whatever you're comfortable with? as far as this patch merging before that has coverage [00:53:49] cwdent: yeah lemme quickly send up a version with the stuff public-privatized, and then make add your tests in a follow-on patch? Sound good? [00:54:14] AndyRussG: sounds good! [01:03:21] (PS40) AndyRussG: WIP - Don't merge but please review - Refactor client-side API and RL modules for banner display [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) [01:03:53] cwdent: ^ that now the stuff made public! Mmm just let's also look at the promise fail/succeed stuff [01:06:14] yeah definitely I wasn't doing that right [01:07:00] AndyRussG: excellent, i can do that soon [01:07:21] Ah almost there now too! [01:07:27] i just need to find whatever i screwed up with the square cash import [01:08:25] cwdent: np! p.s. yay jquery [01:26:04] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Gateway reconciliation might not be recognizing Square refunds - https://phabricator.wikimedia.org/T107228#1490417 (cwdent) Some basic checking against the staging DB does turn up refunds that as far as I know look correct.... [01:57:37] (PS41) AndyRussG: WIP - Don't merge but please review - Refactor client-side API and RL modules for banner display [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) [01:58:09] cwdent: ^ promise now correctly resolved or rejected as needed. Thanks for that!! I was definitely doing it wrong [03:27:07] Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Remove "Automatically create landing page link" feature - https://phabricator.wikimedia.org/T98747#1490565 (AndyRussG) a:AndyRussG [03:27:23] Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Remove "Automatically create landing page link" feature - https://phabricator.wikimedia.org/T98747#1276429 (AndyRussG) [05:20:59] (PS1) AndyRussG: Remove automatic landing page links feature [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227647 (https://phabricator.wikimedia.org/T98747) [05:21:46] (CR) jenkins-bot: [V: -1] Remove automatic landing page links feature [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227647 (https://phabricator.wikimedia.org/T98747) (owner: AndyRussG) [05:29:05] (PS2) AndyRussG: Remove automatic landing page links feature [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227647 (https://phabricator.wikimedia.org/T98747) [05:34:31] (PS42) AndyRussG: WIP - Don't merge but please review - Refactor client-side API and RL modules for banner display [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) [05:37:12] (CR) AndyRussG: "Rebased" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [05:40:51] (PS43) AndyRussG: WIP - Don't merge but please review - Refactor client-side API and RL modules for banner display [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) [05:42:44] (CR) AndyRussG: "Removed implementation of now-removed autolink/landing page feature" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [08:38:56] (PS1) Awight: Add Square gateway to GatewayReconciliation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/227661 (https://phabricator.wikimedia.org/T107224) [08:39:14] Fundraising Sprint The Pogues, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add Square to the list of gateways in the Gateway Reconciliation report - https://phabricator.wikimedia.org/T107224#1490870 (awight) [08:44:15] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Gateway reconciliation might not be recognizing Square refunds - https://phabricator.wikimedia.org/T107228#1490873 (awight) That refund totally does look right. Probably even better than the other gateways... I'd have to... [11:09:58] TCB-Team-Fundraising-Sprint-2015-07-29, TCB-Team: [WMDE-Fundraising] Write update script for DB schema changes - https://phabricator.wikimedia.org/T107273#1491224 (Tobi_WMDE_SW) NEW [11:10:09] TCB-Team-Fundraising-Sprint-2015-07-29, TCB-Team: [WMDE-Fundraising] Write update script for DB schema changes - https://phabricator.wikimedia.org/T107273#1491232 (Tobi_WMDE_SW) [11:13:03] TCB-Team-Fundraising-Sprint-2015-07-29, TCB-Team: [WMDE-Fundraising] Estimate effort: english donation pages and form - https://phabricator.wikimedia.org/T107258#1491239 (Tobi_WMDE_SW) p:Normal>High [11:15:52] TCB-Team-Fundraising-Sprint-2015-07-29, TCB-Team: [WMDE-Fundraising] Broken sensitive banner on wp.de - https://phabricator.wikimedia.org/T107259#1491243 (Tobi_WMDE_SW) [11:28:24] TCB-Team-Fundraising-Sprint-2015-07-29, TCB-Team: [WMDE-Fundraising] Provide concept for handling UTF-8 data in exports - https://phabricator.wikimedia.org/T107274#1491251 (Tobi_WMDE_SW) NEW [11:28:38] TCB-Team-Fundraising-Sprint-2015-07-29, TCB-Team: [WMDE-Fundraising] Provide concept for handling UTF-8 data in exports - https://phabricator.wikimedia.org/T107274#1491251 (Tobi_WMDE_SW) [11:34:04] TCB-Team-Fundraising-Sprint-2015-07-29, TCB-Team: [WMDE-Fundraising] Investigation and provide a plan for implementing a test system for memberships - https://phabricator.wikimedia.org/T107276#1491271 (Tobi_WMDE_SW) NEW [11:34:20] TCB-Team-Fundraising-Sprint-2015-07-29, TCB-Team: [WMDE-Fundraising] Investigation and provide a plan for implementing a test system for memberships - https://phabricator.wikimedia.org/T107276#1491271 (Tobi_WMDE_SW) [11:36:19] TCB-Team-Fundraising-Sprint-2015-07-29, TCB-Team: [WMDE-Fundraising] Create diagram of fundraising components - https://phabricator.wikimedia.org/T107277#1491280 (Tobi_WMDE_SW) NEW [11:37:16] TCB-Team-Fundraising-Sprint-2015-07-29, TCB-Team: [WMDE-Fundraising] Create diagram of fundraising components - https://phabricator.wikimedia.org/T107277#1491287 (Tobi_WMDE_SW) [12:47:59] TCB-Team-Fundraising-Sprint-2015-07-29, TCB-Team: [WMDE-Fundraising] Broken sensitive banner on wp.de - https://phabricator.wikimedia.org/T107259#1491385 (WMDE-Fisch) Open>Resolved a:WMDE-Fisch [13:53:49] TCB-Team-Fundraising-Sprint-2015-07-29, TCB-Team: [WMDE-Fundraising] Provide concept for handling UTF-8 data in exports - https://phabricator.wikimedia.org/T107274#1491554 (WMDE-Fisch) a:WMDE-Fisch [14:26:29] TCB-Team-Fundraising-Sprint-2015-07-29, TCB-Team: [WMDE-Fundraising] Provide concept for handling UTF-8 data in exports - https://phabricator.wikimedia.org/T107274#1491625 (WMDE-Fisch) Open>Resolved see https://github.com/wmde/fundraising/issues/59 [16:19:18] ejegg: you happen to know how to get to the gateway reconciliation report in civi? i don't see anything that looks like that in the reports list [16:20:17] cwdent: not offhand, but I can take a look [16:20:53] i see the file, GatewayReconciliation.php [16:21:01] but not sure where to go to fire it up [16:21:22] hmm, I'd take a look at the wmf reports module [16:25:02] yeah, that's where that file lives [16:25:03] cwdent: try 'Create Report From Template' [16:25:40] I guess in civi terms, a 'report' is a particular selection of columns and filters on a 'report template' [16:25:55] and Gateway Reconciliation is a template [16:27:00] aah, cool i'll try that [16:27:03] thanks! [16:27:13] hmm, we're now getting the german chapter's fundraising phab tasks announced in this channel. Donno if they hang out here, but it might be interesting the see what they're up to [16:51:58] ejegg: saw your email about the TCB tasks. It's odd that they showed up here [16:52:29] dstrine: wikibugs is just configured to send anything from a project with 'Fundraising' in the name to this channel [16:52:42] yeah ok [16:52:46] I was just going to say that [16:53:11] (PS1) Cdentinger: add Square gateway to reconciliation report [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/227749 [16:53:20] ok well thanks for helping with the change [16:54:49] If no one responds to your email, I will bring it up in shrimp chicken [17:00:34] ejegg: would you be ok with the suggested 9 or 9:30 test window for astro pay tomorrow? [17:00:44] I can put something on the fundraising calendar [17:01:40] dstrine: Sure, that works for me [17:01:50] a calendar entry would be great [17:02:04] I'm going into standup with the other FR people and I will confirm there [17:04:34] Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Patch-For-Review: Remove "Automatically create landing page link" feature - https://phabricator.wikimedia.org/T98747#1492165 (atgo) [17:06:29] hey cwdent! question, do you know if the square issue would effect numbers in general for queries from square or just pp's report? [17:07:28] atgo: good question. adam confirmed the data looks good, so it's _probably_ a problem with the recon report and other queries should be fine [17:08:23] danke [17:08:34] they're going to start testing next week so we should keep an eye :) [17:09:24] for sure. i'm pretty sure i'll have this solved today [17:11:00] * AndyRussG waves [17:11:23] Hi AndyRussG ! [17:11:28] ejegg: :) [17:11:59] cwdent, AndyRussG, XenoRyet: anything you want brought up at Scrum of Scrums? [17:12:09] ejegg: thanks, all good here :) [17:12:21] yep, all good too thanks [17:12:38] kewl [17:13:21] Hey atgo just to give you the summary explanation on T98747, basically I was asking about testing the implementation of the landing pages feature in the refactored banner controller code, and awight mentioned that it's actually no longer used and already slated for removal. So just doing that quickly seemed better than testing the new code for it, and almost as easy [17:13:33] sure! sounds good [17:13:42] thanks, just wanted to tag it for later tracking [17:14:24] atgo: thx! yeah it's basically done, just needing review now [17:26:23] Fundraising-Backlog, Astropay Integration: Add 'loading' indicator to AstroPay form - https://phabricator.wikimedia.org/T107321#1492231 (Ejegg) NEW [17:27:44] Fundraising-Backlog, Astropay Integration: Add 'loading' indicator to AstroPay form - https://phabricator.wikimedia.org/T107321#1492241 (atgo) Can we also disable the button once clicked? [17:28:08] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint The Pogues, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Recent Engage Import - Contribution Type = Cash when it should be Engage - https://phabricator.wikimedia.org/T100853#1492242 (atgo) Hey @leannes could... [18:00:39] AndyRussG: there were a couple of things you might be interested in at SoS [18:01:02] ejegg: ah! flying sauers! [18:01:06] There's a meeting Monday about a scalable replacement for event logging [18:01:16] maybe relevant to banner history? [18:01:22] ejegg: aaah yes, I got an invite infact [18:01:49] also, the selenium gerrit/zuul job is now considered stable [18:01:58] thanks much [18:02:07] it even records video and saves it as jenkins artifacts! [18:02:20] ahh selenium... right browser tests, no? [18:02:29] yep: https://www.mediawiki.org/wiki/Continuous_integration/Browser_tests [18:02:53] ejegg: fantastic! Yeah I saw that there has been work on that, it maybe that our tests are failing now just because outdated [18:03:33] K I'll look into it :) [18:03:44] ah right, we're already using that! [18:08:04] cwdent|afk: hehehe, see email [18:10:25] ejegg: heh well, we were using it, and now we're obstaclizing it by running always-failing tests that not even we look at [18:17:38] Is vagrant still broken, or did that get fixed? [18:18:26] XenoRyet: good question. I have a patch out which helps, but I've moved on to DonationInterface stuff (for which it does work) [18:19:00] It installs Civi stuff too, right? [18:19:24] That's what is borken for me. Start with this patch... https://gerrit.wikimedia.org/r/#/c/227388/ [18:19:30] But from there, I'm not sure how to fix it [18:19:43] 10-4 [18:19:43] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint The Pogues, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Recent Engage Import - Contribution Type = Cash when it should be Engage - https://phabricator.wikimedia.org/T100853#1492386 (LeanneS) These records a... [18:20:58] XenoRyet: there are some cheesy scripts that are sort of working, which let u provision on bare metal: crm/bin/*-install.sh [18:22:35] I'm planning to modify the vagrant stuff to run those scripts, actually. [18:22:48] Cool [18:26:00] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint The Pogues, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Recent Engage Import - Contribution Type = Cash when it should be Engage - https://phabricator.wikimedia.org/T100853#1492409 (atgo) Open>Resolved [18:27:47] Fundraising Tech Backlog: [BUG] GC Japan donation from 7/9 has no donor details - https://phabricator.wikimedia.org/T105537#1492410 (atgo) Hey @mbeat33 did you find any others that have looked like this since? [18:28:24] Fundraising Tech Backlog, Fundraising-Backlog: [BUG] GC Japan donation from 7/9 has no donor details - https://phabricator.wikimedia.org/T105537#1492414 (atgo) [18:29:09] XenoRyet: fwiw, fixing pieces of our vagrant role is totally a worthwhile project in itself! [18:29:44] Yea, seems like. [18:32:52] Awight: oh geez, good catch! [18:36:32] Fundraising Tech Backlog, Fundraising-Backlog: [BUG] GC Japan donation from 7/9 has no donor details - https://phabricator.wikimedia.org/T105537#1492451 (MBeat33) Hi @atgo, no, nothing has come from GC-Japan since this one without //something// in first & last name fields. [18:58:15] Fundraising Tech Backlog, Fundraising-Backlog: [BUG] GC Japan donation from 7/9 has no donor details - https://phabricator.wikimedia.org/T105537#1492487 (atgo) Anything in general? Not just concerned about Japan :) [19:12:03] Fundraising Tech Backlog, Fundraising-Backlog: [BUG] GC Japan donation from 7/9 has no donor details - https://phabricator.wikimedia.org/T105537#1492500 (MBeat33) Nope, everything from GC & PayPal since then has data in those fields. Clearly not a systemic problem! [19:12:20] Fundraising Tech Backlog, Fundraising-Backlog, ยง Fundraising Sprint Abba: Make GC and WP visually match what's on donate wiki (and consequently eachother) - https://phabricator.wikimedia.org/T86086#1492501 (atgo) [19:17:56] (Abandoned) Cdentinger: add Square gateway to reconciliation report [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/227749 (owner: Cdentinger) [19:18:22] (CR) Cdentinger: [C: 2] Add Square gateway to GatewayReconciliation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/227661 (https://phabricator.wikimedia.org/T107224) (owner: Awight) [19:19:08] (Merged) jenkins-bot: Add Square gateway to GatewayReconciliation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/227661 (https://phabricator.wikimedia.org/T107224) (owner: Awight) [20:08:54] AndyRussG: qunit setup and teardown run for every test, or every group of tests? [20:10:38] cwdent: mmm good question, don't recall for sure... I think it may be for every group [20:11:06] i'll test! [20:11:15] cwdent: ah yeh good approach! [20:14:10] AndyRussG: yep looks like every group [20:14:26] cwdent: cool! [20:14:44] I mean... Mmmm not the greatest of isolation mechanisms... [20:16:42] cwdent: btw if LMK if u need help running the tests from the command line. Sometimes tests will pass when run on the special page, but fail when on Jenkins, precisely because of funky lack of total isolation stuff. Running locally on the command line uses the same method Jenkins does so can be better in those cases [20:17:19] oh funny, yeah i will hit you up about that, i should have these tests ready before long [20:17:32] also i'm not so sure about that teardown thing after all, one minute [20:18:34] never mind it looks like they do run for each test [20:18:40] i had some stuff commented out and confused myself [20:19:45] cwdent: btw u have the most recent patch set? Yesterday evening I added the reject promise code path for when the lookup fails [20:20:21] Just working on a few more final details, doing some final code reading, to send up a version no longer "WIP" [20:20:55] nice! [20:20:59] yeah i pulled down the most recent [20:21:16] in fact it looks like the constructor runs for every test too [20:21:34] even the function scope stuff gets reset [20:24:45] sorry just to check, which constructor do you mean? [20:25:58] like...the function that is the jquery plugin [20:26:03] i'm bad at knowing what to call things in JS [20:29:05] np! mmm so which function? [20:29:25] You mean the one that wraps the entire script of the module under test? [20:32:01] yep! the one that starts with 'use strict' [20:32:18] that syntax dangles it off jquery right? [20:34:43] err, runs immediately and takes jquery and mw [20:35:07] sorry i have been into node lately but it's been awhile since i wrote browser js! [20:52:23] cwdent: np! Ah yeah that one. Yes, our RL module JS scripts are wrapped in those... [20:54:00] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Gateway reconciliation might not be recognizing Square refunds - https://phabricator.wikimedia.org/T107228#1492754 (atgo) Open>Invalid [20:54:05] interesting! So, that wrapper function gets called for each QUnit.test (not once for each QUnit.module)? hmm interesting! [20:54:34] (rrrg repeating oneself is a sign of old age) [20:56:31] that's sure what it looks like, the member vars got reinitialized [21:10:13] * AndyRussG represses self from saying "interesting" again [21:11:37] Don't worry, you caught it from me [21:12:55] awight: does that sound weird to you? the wrapper function getting called for each test? [21:13:08] well i'll know for certain soon enough [21:13:21] * awight backscrolls to see which wrapper function this is [21:13:34] the namespace closure? entire resourceloader module under test? [21:14:10] i think it's the whole module [21:14:15] like...the whole qunit file [21:14:31] qunit file or the resourceloaer file? [21:14:56] either one would surprise me, really [21:16:07] But to back up a minute, what's the goal here? U trying to find a place to jam some initialization code? [21:16:38] Fundraising-Backlog: Sprint R Goal: - https://phabricator.wikimedia.org/T107346#1492857 (atgo) [21:16:49] Fundraising-Backlog: Sprint S Goal: - https://phabricator.wikimedia.org/T107347#1492859 (atgo) NEW [21:16:51] just trying to find the right place to reset stuff [21:17:59] cwdent: check out tests/qunit/subscribing/ext.centralNotice.display.tests.js line 92. That's the best practice AFAICT [21:18:29] Actually, you might want to copy that setup code into a new function so it can be reused from new test modules. [21:19:00] ah yeah, that's pretty much what i based mine on [21:19:20] Fundraising-Backlog: Sprint Q Goal (midway through quarter): - https://phabricator.wikimedia.org/T104402#1492868 (atgo) [21:19:32] cwdent: Also check out function efCentralNoticeResourceLoaderTestModules [21:19:36] cwdent: Is it not working? [21:19:37] but yeah it definitely looks like stuff set in the function namespace is reinitialized between tests [21:19:43] e.g. realAjax [21:20:30] That shouldn't matter, as long as the setup method is still called for every test [21:20:48] oh, yeah it is [21:20:57] just confused me is all [21:21:13] realAjax should always point to the real ajax function, then... [21:21:26] But that's horrific that the whole namespace closure gets reevaluated [21:21:45] yeah, i don't think it's causing any problems but it's not what i expected [21:21:54] I don't even understand how that's possible, cos that's where we declare the tests, so I'd imagine we'd end up with infinite cat testing if that were true [21:22:51] i'll read the source to QUnit.test() later [21:23:08] just wanna finish these while i'm in the head space [21:23:16] hehehe. You can also poke Krinkle, he wrote the book on QUnit [21:24:06] just seems like it would make setup and teardown redundant [21:24:17] except i guess if you were messing with cookies or localstorage [21:24:46] what would make setup and teardown redundant? [21:25:18] Busted. https://github.com/Krinkle/qunit/commits?author=Krinkle [21:26:03] heh [21:27:35] awight: if the object is built and destroyed you sort of get implicit setup and teardown, except for persistent stuff [21:29:06] What are you doing that gives the impression it's being reloaded for each test? I don't thing javascript even does that? [21:29:15] s/thing/think :) [21:30:54] well, i set member var to true in the function scope, false in test 1, and it's true in test 2 [21:32:54] That could be due to some other bizarre mechanism [21:32:56] try console.log [21:33:39] * awight determines to schedule a vow renewal ceremony between myself and "printf" [21:36:41] hehe [21:37:02] i wrote a poem about php: [21:37:27] echo "
";
[21:37:29] 	 print_r($val);
[21:37:31] 	 die;
[21:37:33] 	 the end
[21:47:13] 	 awww
[21:47:39] 	 what is PHP a metaphore for then?
[21:51:21] 	 (PS44) AndyRussG: Refactor client-side API and RL modules for banner display [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686)
[21:52:25] 	 AndyRussG: too many to list...
[21:52:47] 	 AndyRussG: the "blank" cookie should fail isGeoDataValid right?
[21:53:53] 	 cwdent: yeah exactly!
[21:54:00] 	 heh
[21:55:03] 	 hmm yeah it definitely is but the success callback for then() is still firing
[21:55:12] 	 even though the promise gets rejected in there
[21:58:53] 	 (PS5) Awight: Orphan slayer reads from frack Redis [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226947 (https://phabricator.wikimedia.org/T99017)
[21:59:06] 	 AndyRussG: maybe i will just push this PS up and you can take a look?
[21:59:18] 	 we're still WIP right? :)
[21:59:26] 	 (CR) jenkins-bot: [V: -1] Orphan slayer reads from frack Redis [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226947 (https://phabricator.wikimedia.org/T99017) (owner: Awight)
[21:59:36] 	 (CR) Awight: [C: -2] "This code works well for me, but I still need to precede it with a write-only patch to populate an hour of Redis data." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226947 (https://phabricator.wikimedia.org/T99017) (owner: Awight)
[22:02:04] 	 (CR) AndyRussG: "Now sporting an absence of WIP tag!!" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG)
[22:02:54] 	 hey awight joining me on 6 for chicken?
[22:07:05] 	 Fundraising Sprint The Pogues, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add Square to the list of gateways in the Gateway Reconciliation report - https://phabricator.wikimedia.org/T107224#1492984 (atgo) a:awight
[22:09:54] 	 AndyRussG: fyi - https://office.wikimedia.org/wiki/Expense_reports
[22:10:23] 	 atgo: thx!
[22:10:29] 	 it's.. not very helpful
[22:10:41] 	 this is what you need: https://office.wikimedia.org/wiki/File:Expense_Reimbursement_Open_Office_Employee_v1.1.ods
[22:11:43] 	 (PS1) Cdentinger: adds geoIP tests [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227889
[22:12:55] 	 (CR) jenkins-bot: [V: -1] adds geoIP tests [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227889 (owner: Cdentinger)
[22:14:57] 	 Fundraising Sprint The Pogues, Fundraising-Backlog, Unplanned-Sprint-Work: Footer images on payments missing - https://phabricator.wikimedia.org/T106728#1493012 (awight) a:Jgreen
[22:15:27] 	 Fundraising Sprint The Pogues, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Footer images on payments missing - https://phabricator.wikimedia.org/T106728#1493013 (atgo)
[22:18:07] 	 Fundraising Sprint The Pogues, Fundraising-Backlog, Unplanned-Sprint-Work: Kick Silverpop export job - https://phabricator.wikimedia.org/T107184#1493035 (awight) a:awight
[22:18:16] 	 Fundraising Sprint The Pogues, Fundraising-Backlog, Unplanned-Sprint-Work: Kick Silverpop export job - https://phabricator.wikimedia.org/T107184#1493037 (atgo) @ccogdill_wmf - @awight kicked this, all good?
[22:19:21] 	 Fundraising Sprint The Pogues, Fundraising-Backlog, Unplanned-Sprint-Work: Kick Silverpop export job - https://phabricator.wikimedia.org/T107184#1493041 (CCogdill_WMF) Open>Resolved @atgo yes, Brian was able to fix the issue after @awight did this. Thanks again!!
[22:23:19] 	 Fundraising Sprint The Pogues, Fundraising-Backlog, Unplanned-Sprint-Work: Kick Silverpop export job - https://phabricator.wikimedia.org/T107184#1493072 (atgo) Thanks!
[22:23:39] 	 Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Determine how to load CentralNotice RL modules and when to execute campaign and banner selection logic - https://phabricator.wikimedia.org/T106577#1493075 (awight) This looks great, from what little I unders...
[22:25:34] 	 Fundraising-Backlog: Sprint Q Goal (midway through quarter): start amazon - https://phabricator.wikimedia.org/T104402#1493084 (atgo)
[22:25:56] 	 Fundraising Sprint The Pogues, MediaWiki-extensions-CentralNotice: Test coverage for GeoIP module - https://phabricator.wikimedia.org/T107359#1493085 (cwdent) NEW a:cwdent
[22:31:42] 	 Fundraising-Backlog: Change error messages on new GC red text to match field name - https://phabricator.wikimedia.org/T106172#1493122 (DStrine)
[22:31:43] 	 Fundraising-Backlog: Change error messages on new GC red text to match field name - https://phabricator.wikimedia.org/T106172#1493124 (atgo) p:Triage>Normal
[22:32:26] 	 Fundraising-Backlog, Astropay Integration: Add 'loading' indicator to AstroPay form - https://phabricator.wikimedia.org/T107321#1493127 (DStrine)
[22:32:36] 	 Fundraising-Backlog, Astropay Integration: Add 'loading' indicator to AstroPay form - https://phabricator.wikimedia.org/T107321#1493131 (atgo)
[22:39:12] 	 Fundraising-Backlog, Astropay Integration: Astropay errors should be red text and not popup - https://phabricator.wikimedia.org/T107363#1493155 (atgo) NEW
[22:40:25] 	 Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Deprecate "language" parameter - https://phabricator.wikimedia.org/T96621#1493171 (awight) We're going to split this into smaller tasks so the work has a definite beginning and end.
[22:41:30] 	 Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Deprecate "language" parameter - https://phabricator.wikimedia.org/T96621#1493178 (XenoRyet) a:XenoRyet>None
[22:42:03] 	 Fundraising-Backlog, Astropay Integration: Astropay errors should be red text and not popup - https://phabricator.wikimedia.org/T107363#1493180 (DStrine)
[22:43:09] 	 Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Verify that DonationInterface doesn't require "uselang" parameter - https://phabricator.wikimedia.org/T107364#1493185 (awight) NEW
[22:44:13] 	 Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Don't require "language" parameter in FundraisingLandingPage  - https://phabricator.wikimedia.org/T107365#1493192 (awight) NEW
[22:44:21] 	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding 1 Custom field to "primary fields" export list: Do Not Solicit - https://phabricator.wikimedia.org/T105918#1493198 (atgo)
[22:44:27] 	 Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Don't require "language" parameter in FundraisingLandingPage - https://phabricator.wikimedia.org/T107365#1493192 (awight)
[22:44:47] 	 Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Verify that DonationInterface doesn't require "uselang" parameter - https://phabricator.wikimedia.org/T107364#1493185 (awight)
[22:44:49] 	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding 1 Custom field to "primary fields" export list: Do Not Solicit - https://phabricator.wikimedia.org/T105918#1493204 (atgo) p:Triage>Normal
[22:45:39] 	 Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Don't require "language" parameter in FundraisingLandingPage - https://phabricator.wikimedia.org/T107365#1493192 (awight)
[22:48:39] 	 (PS2) Cdentinger: adds geoIP tests [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227889
[22:49:30] 	 (CR) jenkins-bot: [V: -1] adds geoIP tests [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227889 (owner: Cdentinger)
[22:52:52] 	 (PS3) Cdentinger: adds geoIP tests [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227889
[22:53:44] 	 (CR) jenkins-bot: [V: -1] adds geoIP tests [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227889 (owner: Cdentinger)
[23:04:06] 	 dstrine: thanks for proposing all that stuff! I think there's always room for exploring process, and it all sounds quite reasonably thought out!
[23:05:57] 	 dstrine: I'm pretty sure no process anyone has is the be-all and end-all of process--neither what we had before, nor what we could try--but that definitely argues for exploring, as you suggest!
[23:06:32] 	 no problem! it's what I'm here for. I also have a philosophy of a "project management tool box" there are many tools available to improve, teams can pick up some or switch as needed.
[23:06:47] 	 yeah that!
[23:06:53] 	 (P.S. Also at the end of the call I was gonna un-mute and say thanks for all these suggestions, but I pressed hang up instead of unmute by mistake! :p )
[23:07:03] 	 lol it's cool
[23:08:25] 	 yeah that sounds great! also like you said, there can be lots of emergent effects of any set of procedures, like any system, stuff that's hard to have any idea about until you try it
[23:09:01] 	 (I guess a little similar to what happens when you estimate the cost of a new software feature, heh)
[23:09:04] 	 totally!
[23:09:24] * dstrine high fives AndyRussG:
[23:09:55] 	 (CR) Awight: [C: -1] "Does it seem reasonable to actually do the removals here rather than commenting?" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227647 (https://phabricator.wikimedia.org/T98747) (owner: AndyRussG)
[23:10:10] 	 dstrine: :D
[23:10:59] 	 AndyRussG: can you show me how to run qunit from the command line?  confused about the way it fails on jenkins
[23:11:20] 	 cwdent: Yea you bet! just one sec :)
[23:11:55] 	 atgo: http://ocremix.org/game/702/katamari-damacy-ps2
[23:12:03] 	 Let me know if any of it is good.
[23:12:05] 	 :D
[23:13:46] 	 K4-713: if you want a social game, I really want to get people together to play this: http://www.artemis.eochu.com/
[23:14:03] 	 I have the full game from steam. We need 6 players
[23:15:52] 	 dstrine: Here is the extent of my evil plan: https://office.wikimedia.org/wiki/Video_Games
[23:16:05] 	 ...so far.
[23:17:05] 	 cool
[23:17:31] 	 Mostly wanting to get people to connect on internet-enabled games they're already playing, so remote people don't have to be local to enjoy recreational activities.
[23:18:54] 	 yeah totally... although I can't pick up animal crossing again... it really drew me in for a while
[23:19:57] 	 have you guys ever played spaceteam?
[23:20:00] 	 awight: Hey, i'm automating the setup of browser test bots and I'm testing out the script for different extensions.  Thoughts about me setting one up for CentralNotice?
[23:20:27] 	 Spaceteam?  I don't recall.  What kind of game is it?
[23:20:29] 	 man if someone set up a quake 2 server it'd be on
[23:20:43] 	 think that was the last era of video games i was privy to
[23:21:06] 	 also it works in linux
[23:21:19] 	 cwdent: K all set... lemme see where's the doc...
[23:21:48] 	 rmoen: --> AndyRussG is the guy to ask!  Thanks for doing this!
[23:22:07] 	 np :)
[23:22:11] 	 We've been talking a lot about our browser tests, recently.  We have a lot of false negatives we'd like to debug.
[23:22:23] 	 Cool
[23:22:23] 	 err, failures when the code is fine.
[23:22:29] 	 rmoen: ?
[23:22:39] 	 Hi AndyRussG
[23:22:39] 	 AndyRussG: 16:20 < rmoen> awight: Hey, i'm automating the setup of browser test bots and I'm testing out the script for different extensions.  Thoughts  about me setting one up for CentralNotice?
[23:22:41] 	 Ah our red-light browser tests?
[23:23:14] 	 heh i feel like i might be seeing one of those... the nature of these errors make me think it's using a different promise implementation on jenkins
[23:23:26] 	 rmoen: well we have a single cucumber test and a bunch of platforms
[23:23:40] 	 spaceteam is on smartphones and you have to have 2-4 people in the same room
[23:23:48] 	 connected either by wifi or bluetooh
[23:23:58] 	 AndyRussG: ahh this would run them in phandomjs
[23:24:15] 	 Oh, yea, I think I know that one.  Never played it, but it did sound super fun.
[23:24:20] 	 and then paste failures to phabricator and in gerrit
[23:24:20] 	 rmoen: last I looked into it, there was a nest of issues between SauceLabs and beta cluster and such, so a bunch of tests were failing. I was gonna get to debuging, but just didn't have the chance
[23:24:31] 	 and you each have a really janky control panel on your phone and you get instructions about things to do (like "turn volume to 11!") and then you ahve to get someone in your group to do it (whoeer has the control)
[23:24:33] 	 rmoen: and then later I learned that they're now all failing all the time
[23:24:40] 	 it's really fun and brings real life interaction into games :)
[23:24:43] 	 cwdent: I've definitely seen async stuff go wrong in Jenkins, in places unrelated to what I was working on.  It really seemed like I was corrupting some global resource...
[23:24:46] 	 also, lots of yelling and silliness.
[23:25:06] 	 AndyRussG: no worries.  just wondering if this would be usefull or if yall minded that test the bot against your one cucumber test
[23:25:08] 	 rmoen: any help you can suggest is great! https://integration.wikimedia.org/ci/view/BrowserTests/view/CentralNotice/
[23:25:15] 	 useful *
[23:25:19] 	 awight: sounds like a pleasure
[23:25:41] 	 rmoen: ah yes sounds excellent! Please go ahead
[23:25:53] 	 dstrine: spaceteam is like artemis but way more chaotic
[23:26:01] 	 rmoen: btw in a little while I'll check our setup on the beta cluster, that's my first stop for figuring out why they're all a-failin'
[23:26:28] 	 AndyRussG: cool &  thanks for the green light.
[23:26:34] 	 atgo: yeah I've played. it's pretty crazy.
[23:26:40] 	 so fun
[23:27:16] 	 Too bad you have to be on wi-fi together or we could do it over hangouts.
[23:27:32] 	 rmoen: ah yeah just confirmed the banners the test runs against on beta labs are just turned off, so that's the first thing to fix to get any green!
[23:27:41] 	 being a total star trek nerd I really want to play artemis. However the captain job is dumb. I want to add an element where your rotate positions
[23:27:43] 	 http://meta.wikimedia.beta.wmflabs.org/wiki/Special:CentralNotice
[23:28:22] 	 ok well I've been on for a while. I'm going to call it for today.
[23:28:24] 	 rmoen: From my perspective, there's one serious shortcoming in our browser testing framework--we rely on some fixtures that we manually enter into the betawiki GUI.  I'd much rather have that written in configuration or code.
[23:28:24] 	 i like to play zero player mode in dwarf fortress
[23:28:39] 	 omfg dwarf fortress....
[23:28:47] 	 where you just observe the world building itself
[23:28:52] 	 Fundraising Tech Backlog, Fundraising-Backlog, Recurring-Donations: Add logic to double-check that we are never double-charging recurring contributions - https://phabricator.wikimedia.org/T107370#1493368 (atgo) NEW
[23:29:07] 	 that's rough
[23:29:23] 	 (PS6) Awight: Orphan slayer reads from frack Redis [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226947 (https://phabricator.wikimedia.org/T99017)
[23:29:25] 	 (PS1) Awight: Clean up Redis and slayer stuff [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/227908
[23:29:37] 	 I just got xwing vs tie fighter off good old games.. gonna break that open some day
[23:29:38] 	 Fundraising Tech Backlog, Fundraising-Backlog, Recurring-Donations: Recurring Globalcollect: only mark subscription as failed if it was a processor failure - https://phabricator.wikimedia.org/T107371#1493380 (atgo) NEW
[23:29:46] 	 (CR) jenkins-bot: [V: -1] Orphan slayer reads from frack Redis [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226947 (https://phabricator.wikimedia.org/T99017) (owner: Awight)
[23:29:47] 	 cwdent: https://www.mediawiki.org/wiki/Manual:JavaScript_unit_testing#From_the_command_line
[23:29:58] 	 awight: yeah that seems the be true for for us as well.  Are you talking about importing content into the test wiki ?
[23:29:59] 	 (CR) jenkins-bot: [V: -1] Clean up Redis and slayer stuff [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/227908 (owner: Awight)
[23:29:59] 	 Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint The Pogues, and 4 others: Populate an hour of limbo queue in the new Redis store - https://phabricator.wikimedia.org/T106906#1493387 (awight) Oh good--the code is already deployed to do th...
[23:30:02] 	 that's my vintage dstrine
[23:30:13] 	 Fundraising-Backlog, Recurring-Donations: Recurring Globalcollect: only mark subscription as failed if it was a processor failure - https://phabricator.wikimedia.org/T107371#1493380 (atgo)
[23:30:15] 	 thanks AndyRussG!  taking a look
[23:30:22] 	 cwdent: you'll need to set some environment variables too, but start w/ that
[23:30:22] 	 rmoen: yeah, exactly.  In our case, it's Special:CentralNotice campaign configuration.
[23:30:44] 	 cwdent: I'm so stoked for battlefront I'm playing any star wars I can.
[23:30:46] 	 rmoen: marxarelli|cafe and I chatted about this briefly, I'd love to follow up if we can be helpful.
[23:30:56] 	 awight: i may need setup information
[23:31:31] 	 rmoen: err, sorry what do you mean?
[23:31:45] 	 Fundraising Tech Backlog, Fundraising-Backlog, Recurring-Donations: Move gateway-specific normalizations out of recurring.module - https://phabricator.wikimedia.org/T107372#1493395 (atgo) NEW
[23:31:46] 	 awight, AndyRussG: as I will be setting up a wikitech-instance
[23:31:50] 	 aaah
[23:31:51] 	 thx
[23:31:52] 	 rmoen: oooh
[23:32:11] 	 Some examples on configuring would be good
[23:32:17] 	 seeya all
[23:32:19] 	 marxarelli:  rmoen: we actually have a heft
[23:32:26] 	 y set of test fixtures
[23:32:47] 	 that we use in both qunit and phpunit tests
[23:33:04] 	 AndyRussG: those are already handled, though.
[23:33:05] 	 Fundraising Tech Backlog, Fundraising-Backlog, Recurring-Donations: Move base functionality from recurring_globalcollect into recurring - https://phabricator.wikimedia.org/T107373#1493401 (atgo) NEW
[23:33:13] 	 I meant the browser test ones, which we have to set up by hand
[23:33:45] 	 Right so mainly the browser test requirements
[23:34:06] 	 awight: I guess... I mean it might be fun to set up instances and run them through different browsers as full-stack integration tests...
[23:34:18] 	 But they don't target specifically expected browser differences
[23:34:28] 	 Fundraising Tech Backlog, Fundraising-Backlog, Recurring-Donations: Move base functionality from recurring_globalcollect into recurring - https://phabricator.wikimedia.org/T107373#1493401 (atgo)
[23:34:29] 	 Fundraising-Backlog, Recurring-Donations: WorldPay Recurring - https://phabricator.wikimedia.org/T103448#1493421 (atgo)
[23:34:50] 	 Fundraising Tech Backlog, Fundraising-Backlog, Recurring-Donations: Move gateway-specific normalizations out of recurring.module - https://phabricator.wikimedia.org/T107372#1493428 (atgo)
[23:34:52] 	 Fundraising-Backlog, Recurring-Donations: WorldPay Recurring - https://phabricator.wikimedia.org/T103448#1390456 (atgo)
[23:34:56] 	 There are definitely other things I'd want to poke first for expanding cross-browser tests...
[23:34:56] 	 Yeah would be running them in headless chrome
[23:35:31] 	 Fundraising-Backlog, Recurring-Donations, Epic: [epic] Recurring cleanup - https://phabricator.wikimedia.org/T90241#1493432 (atgo) Open>Invalid a:atgo Made this into the umbrella project #recurring-donations
[23:35:31] 	 AndyRussG: I don't see our three testing campaigns... I thought we were pointed at http://meta.wikimedia.beta.wmflabs.org/wiki/Special:CentralNotice ?
[23:35:32] 	 Fundraising-Backlog, Epic: [epic] PayPal upgrade - https://phabricator.wikimedia.org/T87621#1493435 (atgo)
[23:35:46] 	 awight: what kind of test content are we talking about?
[23:36:03] 	 you can use the api from within mw-selenium tests to initialize test content
[23:36:07] 	 awight: someone turned 'em off and archived 'em
[23:36:08] 	 http://meta.wikimedia.beta.wmflabs.org/w/index.php?title=Special:CentralNotice&subaction=noticeDetail¬ice=CN+browser+tests
[23:36:33] 	 marxarelli: rmoen: ^ that's what our cucumber test runs against
[23:36:37] 	 and if there's a more formal requirement for fixtures, we can easily extend the framework
[23:36:45] 	 marxarelli: oh yeah?  That would be fine, we can write the APIs for what we need.  Thanks, I think you mentioned as much to me :)
[23:38:11] 	 awight:arrgg I forgot again my labs password, but if u wanna turn em on again...
[23:38:30] 	 AndyRussG: ok i'm where it asks me about env vars.  also should npm install node, and grunt globally?
[23:39:04] 	 cwdent: hmm I guess I don't recall! I may have tried things first w/ an apt-get
[23:39:11] 	 or do you edit your path to include those dirs?
[23:39:29] 	 AndyRussG: looks like unarchive isn't implemented yet >.<
[23:39:34] 	 marxarelli: rmoen: will this framework eventually run on more platforms? How does it relate to current SauceLabs stuff?
[23:40:25] 	 node is really irritating with that stuff.  last i was using it, if you want any chance of getting the right versions, you use apt to install npm, npm to install n, n to install node
[23:40:38] 	 awight: hmm maybe a new campaign w/ same banners?
[23:40:42] 	 AndyRussG, awight: my approach to testing that would be: 1) a handful of tests that cover the CN admin interface itself, basically where it's the subject of the test; and 2) test "helpers" that use the api to setup campaigns where that is a precondition
[23:41:04] 	 cwdent: I don't remember ever having to symlink stuff
[23:41:18] 	 So right now it is very primitive.  We are exploring real time testing.  Also I don't think it relates to saucelabs.  Right now we are setting these up to run on test instances so they are running on a single platform.  Not sure what the future is.  THE CI stuff you guys have with sacelabs is interesting to me though and i'm not sure why we didn't think
[23:41:19] 	 about going that route for our browser tests.
[23:41:28] 	 cwdent: grr, running grunt locally is really unpleasant.
[23:41:51] 	 cwdent: here is my env var stuff: export MW_SERVER='http://localhost'; export MW_SCRIPT_PATH='/mw1'
[23:42:02] 	 (my local install is at http://localhost/mw1)
[23:42:05] 	 cwdent: 10:28 < awight> BTW for anyone that needs it, I found how to run the qunit tests headless, go to your integration-jenkins repo, and run: ./bin/wmfgrunt qunit --verbose '--qunit-url=http://YOURWIKI/index.php/Special:JavaScriptTest/qunit'
[23:42:31] 	 awight: oh nice, you're using mediawiki_selenium 1.x. you should have an `api` method already available that returns an authenticated api client
[23:42:36] 	 interesting that we have totally different commandlines...
[23:42:42] 	 marxarelli: wicked.
[23:43:11] 	 awight: https://doc.wikimedia.org/rubygems/mediawiki-selenium/MediawikiSelenium/ApiHelper.html#api-instance_method
[23:43:12] 	 nice, thanks guys
[23:43:17] 	 AndyRussG: shall I make a task for adding the campaigns via API, or hold off until this smoke clears?
[23:43:43] 	 awight: wohoo yea sounds rad :)
[23:44:54] 	 marxarelli: rmoen: fun! I guess I'd add maybe the CentralNotice admin interface is not the best target for testing in that it's been edging towards the front of our "tear down and radically improve" queue for a while now
[23:45:20] 	 AndyRussG: this look familiar?
[23:45:27] 	 Warning: Task "karma:main" failed. Use --force to continue.
[23:45:29] 	 Aborted due to warnings.
[23:45:31] 	 both for how it is on the outside, and how it works on the inside
[23:45:32] 	 AndyRussG: sorry, we do have "unarchive", I logged in with the wrong account is all.
[23:46:07] 	 cwdent: hmmm not sure... just lemme try here too...
[23:46:12] 	 Psych.  That did nothing.
[23:46:55] 	 ugh.  yes it did.  Nice GUI
[23:47:37] 	 rmoen: fwiw, this is the fixture our browser tests are expecting.  It's enabled now: http://meta.wikimedia.beta.wmflabs.org/w/index.php?title=Special:CentralNotice&subaction=noticeDetail¬ice=CN+browser+tests
[23:47:57] 	 cwdent: I'm getting "Done, without errors" on grunt qunit for your tests!
[23:48:10] 	 ha!
[23:48:22] 	 AndyRussG: https://integration.wikimedia.org/ci/job/mwext-qunit/3395/console
[23:48:42] 	 what i'm pretty sure that indicates is that the callbacks in the promise resolutions are not getting called
[23:49:25] 	 Fundraising Tech Backlog, Browser-Tests, MediaWiki-extensions-CentralNotice: Write API for campaign creation and use it to create browser test fixtures - https://phabricator.wikimedia.org/T107376#1493504 (awight) NEW
[23:50:52] 	 cwdent: hmm weird... Supposedly locally you get the same browser environment (Chrome) as you get on Jenkins QUnit
[23:52:04] 	 huh, well fwiw i was running them on chrome myself so it could be a version thing, however that wouldn't explain broken $.Deferred because that's sourced manually right?
[23:52:17] 	 within MW
[23:52:58] 	 marxarelli: rmoen: BTW the above comment ^ about CN admin UI being not-so-testworthy was not meant to discourage!! If u like we can look into what the most interesting target would be fore expanded browser tests, I think especially on the subscribing (i.e., banner-receiving) end of things :) sounds like really fun stuff!
[23:53:30] 	 cwdent: yeah we have our own jquery stuff in our codebase...
[23:54:34] 	 hrmph
[23:54:35] 	 heh in a smallish number of minutes I have to go do family eating type things
[23:54:41] 	 (PS2) Awight: Clean up Redis and slayer stuff [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/227908
[23:54:54] 	 good idea AndyRussG
[23:55:00] 	 (CR) jenkins-bot: [V: -1] Clean up Redis and slayer stuff [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/227908 (owner: Awight)
[23:55:08] 	 i'll bash on this in the morning
[23:56:11] 	 cwdent: since I haven't read the test code I don't yet have many ideas about the error. But if continues to seem impenetrable and works fine on grunt locally, we can definitely poke others for help...
[23:56:55] 	 cool, you might also look at the code and see something obvious
[23:57:03] 	 (PS7) Awight: Orphan slayer reads from frack Redis [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226947 (https://phabricator.wikimedia.org/T99017)
[23:57:36] 	 (CR) jenkins-bot: [V: -1] Orphan slayer reads from frack Redis [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226947 (https://phabricator.wikimedia.org/T99017) (owner: Awight)
[23:58:52] 	 Fundraising-Backlog, Recurring-Donations: Support subscription modification - https://phabricator.wikimedia.org/T107379#1493605 (atgo) NEW