[00:00:30] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Performance: CiviCRM queries become slower over time, require manual "flushing" - https://phabricator.wikimedia.org/T87032#1497350 (awight) [00:01:24] awight: Prepping for something? [00:02:59] eh? the tasks? hell no [00:03:14] I mean, well yes exactly [00:03:22] Winter is coming. [00:03:46] I didn't mean to say it quite like, "back the dump truck off a pier" [00:04:36] hah [00:05:34] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Make CRM version stamp thing robust on dev boxes - https://phabricator.wikimedia.org/T88376#1497374 (awight) [00:06:33] hi greg-g! [00:07:25] atgo: sorry for the skinning conversation today :) [00:12:03] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Log timing for each cURL attempt, not cumulative time - https://phabricator.wikimedia.org/T107539#1497398 (Ejegg) NEW [00:33:17] (PS1) Ejegg: Log timing of each cURL attempt, not cumulative [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/228186 (https://phabricator.wikimedia.org/T107539) [00:33:42] ^^^ leetle bug was throwing off my API response time stats [00:36:47] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: "ERROR: Cancelling payment" message is at the wrong severity level. - https://phabricator.wikimedia.org/T107541#1497441 (awight) NEW [00:37:02] oh! [00:37:32] Did that affect the timeout comparison, too? [00:37:59] Must have been, or you would have seen times > 12s, eh? [00:40:20] yeah, that was what tipped me off [00:40:54] I mean, max duration was 29 sec [00:41:01] and timeout was only 12 [00:43:24] (CR) Awight: [C: 2] "Noted some things inline." (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/228186 (https://phabricator.wikimedia.org/T107539) (owner: Ejegg) [00:43:49] (Merged) jenkins-bot: Log timing of each cURL attempt, not cumulative [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/228186 (https://phabricator.wikimedia.org/T107539) (owner: Ejegg) [00:44:36] sounds like we might need to tweak the php script timeout, too. That defaults to 30 sec I think, unless Jeff tweaked it already. [00:45:09] oh, i didn't even think of that when I upped the AP curl timeout to 12s [00:45:27] but yeah, we're almost hitting that during high load [00:49:54] I'm done. Was that really only 90 min of deployment strobe action? [00:51:09] Fundraising Sprint The Pogues, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, Patch-For-Review: Log timing for each cURL attempt, not cumulative time - https://phabricator.wikimedia.org/T107539#1497502 (Ejegg) a:Ejegg [00:51:41] small one if you get the chance, https://gerrit.wikimedia.org/r/#/c/228038/ [00:51:43] awight: exhausting! [00:51:45] See you Monday! [00:51:52] enjoy yr weekend! [00:52:20] yeah I feel like a rock star... something along the lines of mick jagger, in his perpetual later years [01:24:59] Fundraising Sprint House of Pain, Fundraising Tech Backlog, Fundraising-Backlog: Backfill donor language information from logs? - https://phabricator.wikimedia.org/T94670#1497538 (awight) Doesn't look like it from this card, but I do remember soing some related work.... [01:50:55] (CR) Ejegg: [C: 2] "Oops, my bad! Thanks for catching this." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/228038 (owner: Awight) [01:51:24] (Merged) jenkins-bot: Fix name conflict with mw-core phpunit [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/228038 (owner: Awight) [03:25:59] (PS5) Cdentinger: WIP: adds geoIP tests [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227889 [03:27:01] (CR) jenkins-bot: [V: -1] WIP: adds geoIP tests [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227889 (owner: Cdentinger) [03:28:48] (PS6) Cdentinger: WIP: adds geoIP tests [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227889 [04:11:11] (CR) AndyRussG: [C: -1] "Yay, definitely getting there!!! \o/" (6 comments) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227889 (owner: Cdentinger) [04:11:48] cwdent: fun stuff! cheers, hitting the hay now... :) [07:47:28] TCB-Team-Fundraising-Sprint-2015-07-29, TCB-Team: [WMDE-Fundraising] Write update script for DB schema changes - https://phabricator.wikimedia.org/T107273#1497826 (WMDE-Fisch) a:WMDE-Fisch [09:44:08] TCB-Team-Fundraising-Sprint-2015-07-29, TCB-Team: [WMDE-Fundraising] Investigation and provide a plan for implementing a test system for memberships - https://phabricator.wikimedia.org/T107276#1498025 (WMDE-leszek) a:WMDE-leszek [11:20:21] Wikimedia-Fundraising, I18n: Should FundraisingEmailUnsubscribe be translated? - https://phabricator.wikimedia.org/T75286#1498154 (Pcoombe) If it's really not being used anywhere, then I can't see a reason to keep it being translated. Is there a way to mark extensions as unused/abandoned? [11:38:44] Wikimedia-Fundraising, I18n: Should FundraisingEmailUnsubscribe be translated? - https://phabricator.wikimedia.org/T75286#1498187 (Raymond) Open>Resolved a:Raymond Disabled on translatewiki.net with https://gerrit.wikimedia.org/r/228234 [12:58:31] Fundraising Tech Backlog, Fundraising-Backlog, I18n: Set up out-of-sync alerts so that the tech team immediately discovers translations ready for publishing - https://phabricator.wikimedia.org/T89910#1498244 (jrobell) Thank you, @awight! This would be great, particularly for the Thank you email transl... [15:45:35] (PS7) Cdentinger: WIP: adds geoIP tests [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227889 [15:46:29] (CR) jenkins-bot: [V: -1] WIP: adds geoIP tests [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227889 (owner: Cdentinger) [15:49:01] (PS8) Cdentinger: WIP: adds geoIP tests [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227889 [16:06:11] (PS9) Cdentinger: WIP: adds geoIP tests [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227889 [16:07:53] cwdent: https://github.com/carhartl/jquery-cookie [16:08:28] cwdent: $.cookie( COOKIE_NAME, cookieValue, { path: '/' } ); [16:33:24] http://img.memecdn.com/cookie-monster_o_601017.jpg [16:46:12] https://twitter.com/moklick/status/626334093660286976 [16:46:32] reposotory [16:47:11] Wow [16:48:24] woohoo fork my code! [16:48:58] AndyRussG|bassoo: i'll remember to send you an e-note when i'm done [16:49:28] So long as it's not a C#, it's cool :) [16:50:59] oh man... [16:51:40] where's the reposotory for the visual basic GUI to track the killers? [17:04:35] can i link to a line number in gerrit? [17:05:44] cwdent: yeah, i've seen it done, but i forget the syntax atm [17:06:30] oh hey, the blue line numbers at left are all anchor tags [17:06:49] ah nope, just js links [17:07:11] heh yeah they need names [17:08:03] well anyway [17:08:05] https://gerrit.wikimedia.org/r/#/c/221759/44/resources/subscribing/ext.centralNotice.geoIP.js [17:08:51] AndyRussG|bassoo line 48/49 there...the parsefloat can actually make a subtly different cookie than varnish sets by stripping trailing zeros [17:09:31] also the syntax confused me...i feel like in php that would set them to a boolean? [17:34:32] Fundraising research, Analytics-Backlog, Research-and-Data: What's our projected ability to fundraise in the coming years - https://phabricator.wikimedia.org/T107606#1499030 (DarTar) NEW [17:36:28] cwdent: ah heh interesting! Yeah that bit is taken from legacy code verbatim [17:37:07] The syntax is pretty standard way of checking for null or undefined before operating on something [17:37:40] cwdent: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Logical_Operators [17:39:01] cool yeah...too much php lately! [17:41:23] it's tough...i can't think of a fix for this [17:41:48] 1.1 === 1.10000 [17:42:14] but i don't know how to tell js to write the latter value to the cookie [17:49:50] mm cookies [17:54:30] cwdent: couldn't you remove the trailing "0" from the longitude in the mocked GOOD_COOKIE? [17:55:21] AndyRussG: yep, i could, but that is a real life cookie that varnish will return so i thought that would reduce the coverage slightly [17:55:41] but that's definitely the easiest way [17:56:13] good cookie! even better! [17:56:20] i guess that could vary per browser though [17:56:20] * atgo chuckles in her corner [17:56:25] how that number is represented [17:56:26] atgo: ther's also an invalid one :) [17:56:40] what about a delicious_cookie [17:56:45] BAD_COOKIE [17:56:47] or a chocolatechip_cookie [17:56:54] mm nom nom [17:57:04] ok i'll stop trolling :) running to a thing [17:58:11] cwdent: hmmm yeah I think it's OK. It's not a fundamental feature of this code that it strips the trailing zeros. Whether it does or it doesn't doesn't affect the needed functionality, so don't worry about eliminating test coverage of it, I think (just my 2 cents)... [17:58:38] AndyRussG: yeah sounds good, i'll push this up now [17:58:45] cwdent: cool!! :) [18:00:14] (PS10) Cdentinger: WIP: adds geoIP tests [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227889 [18:12:18] Wikimedia-Fundraising, Mobile: Mobile fundraising banners appearing within other apps, moving up the screen - https://phabricator.wikimedia.org/T100421#1499189 (Pcoombe) Open>Invalid a:Pcoombe Closing as Invalid since the banners are intentional, and there's little we can do about the formatting... [18:17:20] (PS1) Ejegg: Add payWithAmazon feature branch [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/228306 [19:06:15] (CR) AndyRussG: [C: -1] "Really close!!! :D" (2 comments) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227889 (owner: Cdentinger) [19:12:13] Fundraising Sprint The Pogues, Fundraising-Backlog, Astropay Integration: Expand Astropay audit to include Mexico - https://phabricator.wikimedia.org/T105906#1499308 (Ejegg) a:Ejegg [19:12:31] (PS1) Ejegg: Add currency column to AstroPay audit processor [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/228333 (https://phabricator.wikimedia.org/T105906) [19:13:01] Tiny update to the astropay audit parser, if anyone's got a minute ^^^ [19:43:34] (PS1) Ejegg: Add mustache loading overlay, show on form submit [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/228352 (https://phabricator.wikimedia.org/T107321) [19:43:50] anybody call for a mustache loader? [19:44:48] Fundraising Sprint The Pogues, Fundraising-Backlog, Astropay Integration, Unplanned-Sprint-Work, Patch-For-Review: Add 'loading' indicator to AstroPay form - https://phabricator.wikimedia.org/T107321#1499422 (Ejegg) a:Ejegg [19:51:08] (PS1) Ejegg: Deal with 'Could not make the deposit' AstroPay errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/228397 [20:06:15] Fundraising Sprint The Pogues, Fundraising-Backlog, Astropay Integration, Unplanned-Sprint-Work, Patch-For-Review: Expand Astropay audit to include Mexico - https://phabricator.wikimedia.org/T105906#1499453 (DStrine) [20:26:51] Fundraising research, Analytics-Backlog, Research-and-Data: What's our projected ability to fundraise in the coming years - https://phabricator.wikimedia.org/T107606#1499480 (DarTar) Workplan: https://docs.google.com/document/d/1htMGoux82i0885T2XxhlE6tOCW5thACfwE3_V7mN_9E/edit [20:27:02] Fundraising research, Analytics-Backlog, Research-and-Data: What's our projected ability to fundraise in the coming years - https://phabricator.wikimedia.org/T107606#1499481 (DarTar) [20:31:19] http://agar.io/ [20:51:53] AndyRussG: ok if i remove WIP for this next patch? just changes the commit message and removes the geo data in the failure test [20:52:31] cwdent: yeah! sounds great :) [20:53:35] (PS11) Cdentinger: Add geoIP tests [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227889 (https://phabricator.wikimedia.org/T107359) [21:02:51] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Tracking: General DonationInterface code cleanup - https://phabricator.wikimedia.org/T87043#1499615 (atgo) [21:04:00] Fundraising Tech Backlog, Browser-Tests, Continuous-Integration-Infrastructure: Create unit and integration tests for Fundraising extensions to identify breaking MediaWiki changes - https://phabricator.wikimedia.org/T89404#1499619 (atgo) [21:04:19] IRC spaaaaaam! [21:05:04] Fundraising Tech Backlog: Scrap custom fundraising logging, integrate with PSR-3 core stuff - https://phabricator.wikimedia.org/T87065#1499621 (atgo) [21:05:21] Fundraising Tech Backlog: Look at using Lua for donatewiki - https://phabricator.wikimedia.org/T87669#1499623 (atgo) [21:05:46] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Use Extension:JsonConfig to enable and disable payment processing stuff on donatewiki and paymentswiki - https://phabricator.wikimedia.org/T87671#1499624 (atgo) [21:05:51] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Queue consumer should warn about unknown fields - https://phabricator.wikimedia.org/T88339#1499625 (atgo) [21:06:28] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Thank You module should default to using a dummy mailer - https://phabricator.wikimedia.org/T88377#1499626 (atgo) Updating card title to reflect "dev and staging servers" [21:06:42] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Thank You module should default to using a dummy mailer on development and staging servers - https://phabricator.wikimedia.org/T88377#1499627 (atgo) [21:06:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Thank You module should default to using a dummy mailer on development and staging servers - https://phabricator.wikimedia.org/T88377#1010298 (atgo) [21:07:01] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Thank You module should default to using a dummy mailer on development and staging servers - https://phabricator.wikimedia.org/T88377#1010298 (atgo) [21:07:22] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Remove tests from CRM deployment - https://phabricator.wikimedia.org/T88378#1499631 (atgo) [21:07:32] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Skip tests when modules not enabled - https://phabricator.wikimedia.org/T88379#1499632 (atgo) [21:08:11] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Make CRM version stamp thing robust on dev boxes - https://phabricator.wikimedia.org/T88376#1499634 (atgo) [21:09:11] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Improve Civi error reporting - https://phabricator.wikimedia.org/T89868#1499636 (atgo) [21:09:46] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Client-side validation breaks credit card button on GC forms - https://phabricator.wikimedia.org/T89412#1499647 (atgo) [21:10:42] Fundraising Tech Backlog: Tracking: Fundraising Tech Staging - https://phabricator.wikimedia.org/T88657#1499652 (atgo) [21:10:48] Fundraising Tech Backlog, Epic: Write puppet modules to provision all fundraising components - https://phabricator.wikimedia.org/T88658#1499655 (atgo) [21:11:07] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Move GET/POST/COOKIE/SESSION assumptions into the UI controller - https://phabricator.wikimedia.org/T91670#1499658 (atgo) [21:11:24] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Stray comma causes all kinds of failures in Civi records - https://phabricator.wikimedia.org/T90232#1499660 (atgo) [21:12:03] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Spike: can we log acquirer authorization information? - https://phabricator.wikimedia.org/T92467#1499671 (atgo) [21:13:50] Fundraising-Backlog, Wikimedia-Fundraising: Make it easier to cancel recurring giving - https://phabricator.wikimedia.org/T94530#1165791 (atgo) @mbeat33 - do you guys get a lot of feedback about this process being problematic? [21:14:32] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Documentation: Document wmf_contribution_extra table - https://phabricator.wikimedia.org/T97190#1499688 (atgo) [21:14:58] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Compile release notes and gotchas - https://phabricator.wikimedia.org/T99841#1499690 (atgo) [21:15:29] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Compile release notes and gotchas for CiviCRM - https://phabricator.wikimedia.org/T99841#1499691 (atgo) [21:15:55] Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Continuous-Integration-Config, Patch-For-Review: mediawiki/core fundraising/REL branches should use git submodule - https://phabricator.wikimedia.org/T100637#1499694 (atgo) [21:17:40] Fundraising Tech Backlog, Recurring-Donations: RGC batch size config is being overridden in the Jenkins job config - https://phabricator.wikimedia.org/T107388#1499716 (atgo) [21:18:12] Fundraising Tech Backlog, Recurring-Donations: Don't HTML escape watchdog logs - https://phabricator.wikimedia.org/T107387#1499718 (atgo) [21:18:45] Fundraising Tech Backlog, Recurring-Donations: drush command does not handle some exceptions, and incorrectly returns success - https://phabricator.wikimedia.org/T107380#1499721 (atgo) [21:19:17] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Verify that DonationInterface doesn't require "uselang" parameter - https://phabricator.wikimedia.org/T107364#1499726 (atgo) [21:23:28] Fundraising-Backlog: Remove Amazon from forms (Aug 21) - https://phabricator.wikimedia.org/T107528#1499745 (atgo) [21:24:40] Fundraising-Backlog, Epic: [epic] Handle gateway (sub) accounts throughout pipeline - https://phabricator.wikimedia.org/T102701#1499749 (atgo) @dstrine - heads up for breaking out these tasks that this exists, too. [21:26:12] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Make JP Morgan Import a bit more robust - https://phabricator.wikimedia.org/T95487#1499770 (atgo) hey @leannes do you have any insight on this one? I'd love to close it out @ejegg looks like you did t... [21:26:44] Fundraising-Backlog, Wikimedia-Fundraising: Make it easier to cancel recurring giving - https://phabricator.wikimedia.org/T94530#1499772 (MBeat33) @atgo - the feedback we do get is more about making it easier to update, rather than cancel, recurring donations. It is not one of the top 6 donor feedback/re... [21:29:36] Fundraising-Backlog, Wikimedia-Fundraising: Make it easier to cancel recurring giving - https://phabricator.wikimedia.org/T94530#1499784 (atgo) Something to noodle on for sure... maybe once we get to the consolidated receipts this is something we could look into since we'd have recurring-specific Thank Y... [21:36:13] You weren't kidding about the wikibugs spam, were you? [21:36:41] dude i used to have an audible alert for when i get pinged in IRC [21:36:50] Fundraising-Backlog, Recurring-Donations: Create option for EOY receipt for recurring donors - https://phabricator.wikimedia.org/T103447#1499815 (MBeat33) This would be cool to have, we get asked about it frequently enough. Would we need to localize the send date by tax day/fiscal year per country? [21:37:17] and it would be all "DING. DING. DINGDINGDING." and i'd yell at adam for wikibugs and then sometimes passive aggressively turn my volume on so he could hear how annoying it was [21:37:29] then he was like "how about you just turn off sounds..." and i was like "oh. yeah." [21:37:38] Heh [21:42:09] Fundraising-Backlog, Wikimedia-Fundraising: Make it easier to cancel recurring giving - https://phabricator.wikimedia.org/T94530#1499835 (MBeat33) Yes, T107932 would be great to have - people do ask about annual or quarterly recurring options. Consolidated annual tax receipts is also one of the top reque... [21:46:10] Fundraising-Backlog, Recurring-Donations: Create option for EOY receipt for recurring donors - https://phabricator.wikimedia.org/T103447#1499842 (atgo) Ooh good thinking... however, we can only offer tax-exempt status in the US and NL https://wikimediafoundation.org/wiki/Tax_Deductibility/en Both are on... [21:47:09] Fundraising-Backlog, Wikimedia-Fundraising: Make it easier to cancel recurring giving - https://phabricator.wikimedia.org/T94530#1499843 (atgo) Yeah I don't think we'll get to a place where we can update CC details any time soon, but we could investigate alternative schedules. Thanks for the speedy feedb... [21:47:24] Fundraising-Backlog, Wikimedia-Fundraising: Make it easier to cancel recurring giving - https://phabricator.wikimedia.org/T94530#1499845 (atgo) p:Triage>Low [21:48:35] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding 1 Custom field to "primary fields" export list: Do Not Solicit - https://phabricator.wikimedia.org/T105918#1499850 (atgo) [21:49:19] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding 1 Custom field to "primary fields" export list: Do Not Solicit - https://phabricator.wikimedia.org/T105918#1454681 (atgo) @caitvirtue what's the urgency for you on this? I think we probably want this to be taken care of before big EN, but anythin... [22:10:20] Fundraising Sprint The Pogues, Fundraising-Backlog: Sprint P GOAL: scope amazon, major gifts import, and finish banner history! - https://phabricator.wikimedia.org/T102198#1499922 (atgo) [22:11:18] Fundraising-Backlog: Sprint Q Goal (midway through quarter): start amazon, astropay is campaign-ready - https://phabricator.wikimedia.org/T104402#1499925 (atgo) [22:28:27] Fundraising-Backlog, Recurring-Donations: Create option for EOY receipt for recurring donors - https://phabricator.wikimedia.org/T103447#1499980 (MBeat33) Good point :)