[16:12:16] AndyRussG: latest patch for those tests is up for review, any other particular areas of the new refactor you want me to look at? [16:52:46] fundraising-tech-ops, Traffic, operations, Patch-For-Review: Decide what to do with *.donate.wikimedia.org subdomain + TLS - https://phabricator.wikimedia.org/T102827#1503467 (CCogdill_WMF) @BBlack I wanted to make sure you saw this as it relates to T107059. I don't have an ETA yet but expect this... [17:03:00] Fundraising Sprint The Pogues, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Astropay Integration, and 2 others: AstroPay audit parse failure - https://phabricator.wikimedia.org/T107673#1503509 (atgo) [17:04:31] cwdent: hi! sorry I didn't see your ping until now... Yeah, I was just reviewing them, it had seemed like I'd come across a bug but it was just a silly incompatibility due to my switching around branche [17:04:33] branches [17:05:33] AndyRussG: yeah i was able to make the tests fail by fiddling with cookies...i'm not sure how to prevent that though because cookies are kind of hard to search [17:05:52] cwdent: ? [17:06:07] cwdent: fiddling with the cookie definitions in the tests, or elsewhere? [17:06:33] AndyRussG: no in my browser, for instance if i had 2 of the same name set at different paths [17:06:53] or one with a path specified and one with none, it did not seem to be deterministic about which it'd find first [17:07:16] cwdent: really! Hmm I thought it was first with the one set on the root patch [17:07:18] path [17:07:56] Mmm since no where does the code set it on a path other than the root, I think we can safely assume there won't be one not on the root path [17:08:42] Stuff to fiddle with to make the tests fail would be, I think, (maybe you already did this) modifying the code under test temporarily so it doesn't do what it's expected to [17:08:49] AndyRussG: yeah, the failure i was seeing was when it'd find the one with no path first [17:09:03] Hmm! [17:09:04] so i had to delete that cookie in order to get expected behavior [17:09:26] Hmm... interesting... well, I think that's OK [17:09:43] cwdent: here are more things to smoke or qunit test, now or eventually: https://www.mediawiki.org/wiki/Extension:CentralNotice/Notes/Banner_controller_refactoring#Smoke_and_unit_testing [17:09:44] i feel like it's not idea, but i also have no idea what could be done about it [17:09:57] *ideal [17:10:05] cwdent: not sure where priorities lie on that or other stuff, if you have more time this sprint... [17:10:30] yes i do, would love to help get this branch out if you think it's possible [17:10:40] cwdent: re: having to delete the cookie, I think it's not a problem, because we don't have any expectation that it'll ever be set again [17:11:19] AndyRussG: the pathless one? is there any chance people will be arriving with them still set? [17:11:28] cwdent: cool! [17:11:37] cwdent: no, our code only sets it on the root path [17:11:56] oh good [17:11:57] no one ever is expected to have a GeoIP cookie from a path other than '/' [17:12:07] also they're just session cookies [17:12:17] (though it's true they can still stay around for a while) [17:40:07] ejegg: Hey, wanna take a look at the orphan slayer patch? [17:40:26] https://gerrit.wikimedia.org/r/#/c/226947/ [17:41:37] awight: oh right, that looked pretty good [17:44:22] I see a small glitch, that nothing is popped off the zset fifo queue [17:44:32] Gotta check whether that is harmless or not [17:44:50] this is happening with the write-only patch currently deployed [17:45:07] the instance()->pop( $current_queue ) isn't doing it? [17:45:22] I don't think the deployed code has that... [17:45:49] right, that's the new patch [17:46:13] oh, you mean the existing one is expiring messages but leaving them in the fifo [17:46:24] yeah, I'm wondering if that will cause all kinds of fail [17:46:34] didn't we decide that was fine, and when we're popping them off we just keep going till we find an unexpired one? [17:46:51] lemme look at phpqueue [17:47:04] The scary part is that the k/v part of the message is deleted, but the fifo entry is not [17:48:03] ah, hmm, we don't seem to be dealing with that [17:48:29] but the pop-till-you-find-a-real-one strategy would work, right? [17:48:55] otherwise we have to do something on expiry [17:48:56] yep! [17:49:05] right, there's that too [17:49:52] imo we should handle that transparently in the predis backend's pop method, not in the orphan script. [17:50:03] agreed [17:50:52] well, the read patch still looks pretty good. Do you want to keep it in review till you can roll in a phpqueue update? [17:51:11] sure! [17:51:18] k [17:59:50] (PS1) Awight: pop() should ignore expired or missing elements [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/228869 [18:02:29] (PS10) Awight: Orphan slayer reads from frack Redis [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226947 (https://phabricator.wikimedia.org/T99017) [18:02:32] (CR) jenkins-bot: [V: -1] Orphan slayer reads from frack Redis [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226947 (https://phabricator.wikimedia.org/T99017) (owner: Awight) [18:09:36] local testing is emitting smokeless fire, one moment please [18:09:49] (CR) Ejegg: [C: 2 V: 2] "Looks like that should do it!" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/228869 (owner: Awight) [18:10:29] oop [18:10:39] no worries--turns out it was my config [18:10:57] yep, it works. [18:11:57] woohoo [18:19:46] (PS11) Awight: Orphan slayer reads from frack Redis [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226947 (https://phabricator.wikimedia.org/T99017) [18:27:01] Fundraising-Backlog, Wikimedia-Fundraising: Make it easier to cancel recurring giving - https://phabricator.wikimedia.org/T94530#1503799 (Capt_Swing) Thanks for thinking about and triaging this ticket. Not sure how widespread the need/desire for this feature is across our financial contributor base is. I... [18:43:50] Fundraising Sprint The Pogues, Astropay Integration, Unplanned-Sprint-Work: AstroPay adapter is spamming cc-limbo queue - https://phabricator.wikimedia.org/T107787#1503895 (Ejegg) NEW a:Ejegg [18:44:29] (PS1) Ejegg: Quit sending AstroPay txns to limbo queue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/228879 (https://phabricator.wikimedia.org/T107787) [18:44:54] (CR) Awight: [C: 2] Quit sending AstroPay txns to limbo queue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/228879 (https://phabricator.wikimedia.org/T107787) (owner: Ejegg) [18:45:01] merge me, merge me! [18:45:18] ty! [18:49:48] (Merged) jenkins-bot: Quit sending AstroPay txns to limbo queue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/228879 (https://phabricator.wikimedia.org/T107787) (owner: Ejegg) [19:03:01] (PS2) Awight: Add mustache loading overlay, show on form submit [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/228352 (https://phabricator.wikimedia.org/T107321) (owner: Ejegg) [19:05:31] ejegg: On my dev instance, the AP form loads with no continue button. Is mw-vagrant up to date with the config I need? [19:05:39] http://payments.wiki.local.wmftest.net:8080/w/index.php?title=Special:AstropayGateway&appeal=JimmyQuote&recurring=&uselang=en¤cy=BRL&country=BR&amount=200.01 [19:05:46] awight: it works like GC [19:06:10] But I have no payment method buttons... [19:06:43] oh man, i should really set a default payment_method! [19:06:56] try adding that param to the url [19:07:03] cc or bt should get you some buttons [19:07:15] gotcha, thanks! [19:07:32] Maybe not a default, but a validation error when no method is provided [19:07:49] something other than a useless form, anyway [19:08:19] Please enter your Please enter a valid email address i.e. name@domain.com. [19:08:31] hehe don't let me distract you from CR [19:08:32] ooh, that's gross [19:08:56] right, I was going to play with that cyclic queue patch! [19:09:23] got lost in some musty jetty config files [19:09:29] that's merged already? [19:09:46] no, i mean the DI bit using it... [19:09:54] ah thx [19:10:01] Just wanted to do more local testing here [19:11:34] (CR) Awight: "The loading spinner works perfectly, but I'm having some issues with the first click on the CC icons being eaten. Checking to see if that" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/228352 (https://phabricator.wikimedia.org/T107321) (owner: Ejegg) [19:15:49] (CR) Awight: [C: 2] "Great!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/228352 (https://phabricator.wikimedia.org/T107321) (owner: Ejegg) [19:16:51] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint The Pogues, and 4 others: Orphan slayer reads from frack Redis rather than ActiveMQ - https://phabricator.wikimedia.org/T99017#1504050 (awight) [19:16:53] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint The Pogues, and 4 others: Populate an hour of limbo queue in the new Redis store - https://phabricator.wikimedia.org/T106906#1504049 (awight) Open>Resolved [19:16:56] Fundraising Sprint James Brown, Fundraising Sprint The Pogues, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: All code that writes to the limbo queue will start writing to both queues. - https://phabricator.wikimedia.org/T99015#1504051 (awight) Open>Res... [19:16:59] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Tech Backlog, and 3 others: Use the new queue wrapper for limbo, antimessage, and orphan slaying - https://phabricator.wikimedia.org/T92922#1504052 (awight) [19:17:24] Fundraising Sprint The Pogues, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Astropay Integration, and 2 others: AstroPay audit parse failure - https://phabricator.wikimedia.org/T107673#1504053 (awight) Open>Invalid [19:17:26] (Merged) jenkins-bot: Add mustache loading overlay, show on form submit [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/228352 (https://phabricator.wikimedia.org/T107321) (owner: Ejegg) [19:17:55] Fundraising Sprint The Pogues, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Astropay Integration, and 2 others: AstroPay audit parse failure - https://phabricator.wikimedia.org/T107673#1500851 (awight) This was already covered by T105906. [19:18:43] (CR) Awight: [C: 2] Remove automatic landing page links feature [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227647 (https://phabricator.wikimedia.org/T98747) (owner: AndyRussG) [19:20:50] (Merged) jenkins-bot: Remove automatic landing page links feature [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227647 (https://phabricator.wikimedia.org/T98747) (owner: AndyRussG) [19:30:57] (PS12) Ejegg: Orphan slayer reads from frack Redis [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226947 (https://phabricator.wikimedia.org/T99017) (owner: Awight) [19:33:42] (CR) Ejegg: [C: 2] "Very nice" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226947 (https://phabricator.wikimedia.org/T99017) (owner: Awight) [19:34:05] (Merged) jenkins-bot: Orphan slayer reads from frack Redis [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226947 (https://phabricator.wikimedia.org/T99017) (owner: Awight) [19:43:24] (PS1) Ejegg: Update SmashPig to add currency to AstroPay audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/228896 (https://phabricator.wikimedia.org/T105906) [19:43:43] (CR) jenkins-bot: [V: -1] Update SmashPig to add currency to AstroPay audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/228896 (https://phabricator.wikimedia.org/T105906) (owner: Ejegg) [19:45:22] Fundraising Sprint The Pogues, Fundraising-Backlog, Astropay Integration, Unplanned-Sprint-Work, Patch-For-Review: Expand Astropay audit to include Mexico - https://phabricator.wikimedia.org/T105906#1504209 (atgo) [19:45:24] Fundraising Sprint The Pogues, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Astropay Integration, and 2 others: AstroPay audit parse failure - https://phabricator.wikimedia.org/T107673#1504208 (atgo) [19:52:00] Fundraising-Backlog, Wikimedia-Fundraising: Make it easier to cancel recurring giving - https://phabricator.wikimedia.org/T94530#1504243 (atgo) Thanks! [19:57:41] woohoo! [19:58:36] awight: redis looking good? [20:00:07] (PS2) Ejegg: Update SmashPig to add currency to AstroPay audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/228896 (https://phabricator.wikimedia.org/T105906) [20:01:30] (CR) jenkins-bot: [V: -1] Update SmashPig to add currency to AstroPay audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/228896 (https://phabricator.wikimedia.org/T105906) (owner: Ejegg) [20:11:25] Fundraising Sprint The Pogues, Astropay Integration, Unplanned-Sprint-Work, Patch-For-Review: AstroPay adapter is spamming cc-limbo queue - https://phabricator.wikimedia.org/T107787#1504284 (DStrine) [20:11:40] Fundraising Sprint The Pogues, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add Square to the list of gateways in the Gateway Reconciliation report - https://phabricator.wikimedia.org/T107224#1504286 (DStrine) [20:14:38] Fundraising-Backlog: Remove Amazon from forms (Aug 21) - https://phabricator.wikimedia.org/T107528#1504290 (DStrine) [20:15:24] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding 1 Custom field to "primary fields" export list: Do Not Solicit - https://phabricator.wikimedia.org/T105918#1504293 (DStrine) [20:17:50] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Deploy CentralNotice schema change - https://phabricator.wikimedia.org/T104508#1504302 (DStrine) [20:38:40] I'm totally going to cast some resin isolinear chips with usb drives in them: http://vignette2.wikia.nocookie.net/memoryalpha/images/2/2d/Insidepadd.jpg/revision/latest?cb=20140629141146&path-prefix=en [20:38:57] look for that stuff on etsy ... soon [20:39:38] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Make JP Morgan Import a bit more robust - https://phabricator.wikimedia.org/T95487#1504371 (LeanneS) I'm not sure about the second bullet point in the task, but I know that the import is still case sens... [20:42:05] (PS1) Awight: Follow composer.lock [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/228972 [20:42:17] (CR) Awight: [C: 2] Follow composer.lock [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/228972 (owner: Awight) [20:42:30] (PS1) Awight: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/228973 [20:42:36] (CR) Awight: [V: 2] Follow composer.lock [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/228972 (owner: Awight) [20:43:12] (CR) Awight: [C: 2 V: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/228973 (owner: Awight) [20:45:05] (PS3) Ejegg: Update SmashPig to add currency to AstroPay audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/228896 (https://phabricator.wikimedia.org/T105906) [20:46:13] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/228977 [20:46:44] MBeat: Heads-up, I'm going to do a payments deployment in the next few minutes [20:47:01] (CR) Awight: [C: 2 V: 2] update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/228977 (owner: Awight) [20:47:01] cool, thanks [20:47:15] affecting just GC or all methods, awight? [20:47:34] directly affecting only GC CC [20:47:42] cool, thx [20:51:48] !log updating paymentswiki from d4bdce1cae168448b116d75e3dcd3303b0f13dd2 to d56dad49ef0da0a8b9c7da410bcac12e48724ae5 [20:51:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [20:51:58] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Make JP Morgan Import a bit more robust - https://phabricator.wikimedia.org/T95487#1504392 (atgo) I'm not seeing a patch attached here with a note to the case sensitivity.... maybe that got missed? [20:52:10] MBeat: okay, deployed... [20:52:22] Wikimedia-Fundraising, MediaWiki-extensions-DonationInterface, I18n: MediaWiki:Donate interface-error-msg-field-correction not properly translatable due to several grammatical genders - https://phabricator.wikimedia.org/T48395#1504393 (atgo) Open>Resolved a:atgo Thanks @tolino! [20:54:13] I'm actually pretty certain this won't interrupt any frontend stuff, it's mostly a change to the "orphan slayer" that resolves unfinished transactions. [20:55:07] ejegg: I deployed the AP spinner patch, fyi [20:55:17] awight: thanks! [20:57:55] (Abandoned) Awight: WIP Use DonationQueue in the orphan slayer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/203282 (https://phabricator.wikimedia.org/T92922) (owner: Awight) [20:58:34] cool, that looked OK [20:58:42] the spinner I mean [21:04:42] (Abandoned) Awight: Remove legacy ActiveMQ code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/203000 (owner: Awight) [21:05:04] (Abandoned) Awight: WIP Stop writing limbo messages to ActiveMQ [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207017 (https://phabricator.wikimedia.org/T92922) (owner: Awight) [21:05:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding 1 Custom field to "primary fields" export list: Do Not Solicit - https://phabricator.wikimedia.org/T105918#1504434 (CaitVirtue) @atgo definitely before big EN. Given the time that we pull the lists for that by late-October would be ideal. [21:05:14] (Abandoned) Awight: WIP Stop using STOMP in the orphan slayer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207741 (owner: Awight) [21:06:07] ejegg: Not sure I left a TODO anywhere but in my abandoned patch, but I wanted to mention that the AP audit parser is way too fragile. [21:06:36] It should validate required fields, but needs to take the CSV columns from the file itself [21:07:17] yeah, that fixed order is pretty hokey [21:12:20] limbo deployment is not looking good [21:20:20] (PS1) Awight: Debugging hack [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/228986 [21:20:30] K4-713: want to give director-level approval for that one? :p ^ [21:21:35] ejegg: ^ [21:21:58] taking a look [21:22:02] awight: Sorry: Meeting. [21:22:08] Looks scary, though... [21:23:14] (CR) Ejegg: [C: 2] "let's see what this uncovers!" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/228986 (owner: Awight) [21:24:10] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/228988 [21:24:19] (CR) Awight: [C: 2 V: 2] update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/228988 (owner: Awight) [21:25:39] !log updating payments1004 to 1daf9d0fe773c022a2ab8de5542fc15ddc261e75 [21:25:43] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:29:03] (CR) Awight: Orphan slayer reads from frack Redis (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226947 (https://phabricator.wikimedia.org/T99017) (owner: Awight) [21:30:24] MBeat: the deployment is not going well--still no frontend breakage I'm aware of, but we're going to have a bunch of unsettled status 600s. Not sure what we do about that. [21:31:06] I can research & settle the ones that look legit; did the test begin 22:38? [21:31:53] (CR) Ejegg: Orphan slayer reads from frack Redis (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/226947 (https://phabricator.wikimedia.org/T99017) (owner: Awight) [21:32:45] !log deploy paymentswiki-staging configuration [21:32:50] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:33:13] MBeat: 20:51 UTC [21:33:39] thanks awight [21:34:58] Fundraising Sprint The Pogues, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Some errors are not being logged, and are not caught in the right context - https://phabricator.wikimedia.org/T107531#1504533 (awight) Confirmed again. This is really bad. Fata... [21:36:13] Fundraising Sprint The Pogues, Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Some errors are not being logged, and are not caught in the right context - https://phabricator.wikimedia.org/T107531#1504535 (awight) [21:37:24] dstrine: Know of a way to filter for tasks in FTB and not in FB? [21:38:11] (PS1) Awight: Revert "Debugging hack" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/228990 [21:38:40] (CR) Ejegg: [C: 2] Revert "Debugging hack" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/228990 (owner: Awight) [21:40:04] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: "ERROR: Cancelling payment" message is at the wrong severity level. - https://phabricator.wikimedia.org/T107541#1504549 (awight) [21:43:40] !log deploy paymentswiki-staging configuration: add explicit queue name for payments4 connecting to payments1-3 [21:43:46] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:46:47] ejegg: hehe, fwiw it was all configuration issues. [21:47:19] Needed the password, and had to alias the queue name to be consistent. [21:47:42] d'oh! [21:48:00] That logging issue is definitely high priority [21:48:07] yeah it's killing me [21:48:16] I think that's php.ini stuff, though [21:48:34] We shouldn't actually have to wrap all our stuff in last-chance error handling... [21:48:40] makes sense [21:50:40] BTW, we're totally doing the unthinkable: popping a bunch of messages off the queue, then crashing. [21:52:17] fatal php errors never get logged? [21:52:28] on payments? [21:54:07] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Verify that DonationInterface doesn't require "uselang" parameter - https://phabricator.wikimedia.org/T107364#1504564 (awight) [21:55:54] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Remove "getInfo" methods from CRM test classes - https://phabricator.wikimedia.org/T105769#1504568 (awight) [21:56:39] Fundraising Tech Backlog, Fundraising-Backlog, Continuous-Integration-Config: Enable PHPUnit testing on the wikimedia/fundraising/SmashPig repo - https://phabricator.wikimedia.org/T104264#1504569 (awight) [21:57:14] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Drupal password reset doesn't work - https://phabricator.wikimedia.org/T103457#1504573 (awight) [21:57:41] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Write migration for Gift Source option values - https://phabricator.wikimedia.org/T103203#1504575 (awight) already done? [21:57:52] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Write migration for Campaign options and custom groups - https://phabricator.wikimedia.org/T103187#1504577 (awight) already done? [21:58:41] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Port crm mw-vagrant to rely more on civicrm-buildkit - https://phabricator.wikimedia.org/T103180#1504580 (awight) Or consider using our bash scripts in crm/bin. Anyway, stop having four ways of doing this. [22:01:26] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1504586 (awight) [22:02:32] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix blank no_thank_you - https://phabricator.wikimedia.org/T97684#1504587 (awight) [22:02:57] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: All contributions should be assigned a trxn_id - https://phabricator.wikimedia.org/T97683#1504588 (awight) [22:04:44] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Epic: Hackathon idea: Make the DonationInterface extension as friendly as possible - https://phabricator.wikimedia.org/T89188#1504600 (awight) [22:04:46] Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, and 2 others: DonationInterface config should be less of a snowflake - https://phabricator.wikimedia.org/T94477#1504598 (awight) Open>Resolved This actually happened. [22:04:57] Fundraising Tech Backlog: Vagrant role for paymentswiki - https://phabricator.wikimedia.org/T94305#1504601 (awight) Open>Resolved a:awight [22:05:16] Fundraising Tech Backlog: Upgrade fundraising deploy branch of mediawiki core - https://phabricator.wikimedia.org/T93957#1504605 (awight) Open>Invalid a:awight Duplicate. [22:08:06] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Tech Backlog, and 4 others: Use the new queue wrapper for limbo, antimessage, and orphan slaying - https://phabricator.wikimedia.org/T92922#1504619 (awight) [22:08:37] Fundraising Tech Backlog, Fundraising-Backlog: Document IP and Session velocity filters - https://phabricator.wikimedia.org/T92054#1504622 (awight) [22:08:46] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Point amp cache to $WORKSPACE - https://phabricator.wikimedia.org/T91911#1504623 (awight) [22:09:15] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Run CRM on HHVM - https://phabricator.wikimedia.org/T91896#1504624 (awight) [22:09:30] Fundraising Tech Backlog, Fundraising-Backlog: Run Payments wiki on HHVM - https://phabricator.wikimedia.org/T91899#1504625 (awight) [22:12:23] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Skip tests when modules not enabled - https://phabricator.wikimedia.org/T88379#1504639 (awight) [22:13:13] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Make CRM version stamp thing robust on dev boxes - https://phabricator.wikimedia.org/T88376#1504640 (awight) [22:14:01] Fundraising Sprint Enya, Fundraising Tech Backlog, Fundraising-Backlog, § Fundraising Sprint Abba, and 4 others: Do banner hiding with mixins - https://phabricator.wikimedia.org/T86100#1504641 (awight) [22:14:38] Fundraising Tech Backlog: DonationInterface should autoload 3rd party dependencies via Composer - https://phabricator.wikimedia.org/T86267#1504643 (awight) Open>Resolved a:awight I believe this works now! [22:14:51] Fundraising Tech Backlog, Fundraising-Backlog: Do not log CC exp date - https://phabricator.wikimedia.org/T86234#1504646 (awight) [22:15:03] Fundraising Tech Backlog, Fundraising-Backlog, § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, § Fundraising Sprint the Cure: Kill all "original_"- fields - https://phabricator.wikimedia.org/T86102#1504647 (awight) [22:15:22] cwdent, XenoRyet: got a minute to review a library version bump? https://gerrit.wikimedia.org/r/228896 [22:15:58] sure [22:16:14] thanks! [22:16:54] ejegg: what's the deal with those report file changes? [22:17:14] they're test data [22:17:30] though that test is duplicating a test from SmashPig [22:18:30] well, partly [22:18:43] (CR) Cdentinger: Refactor client-side API and RL modules for banner display (1 comment) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [22:19:12] gotcha, and these are things that changed in the lib version? [22:19:32] exactly [22:20:15] (CR) Cdentinger: [C: 2] Update SmashPig to add currency to AstroPay audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/228896 (https://phabricator.wikimedia.org/T105906) (owner: Ejegg) [22:20:21] ty [22:20:25] np! [22:20:57] AndyRussG: think i found an important typo up there! [22:21:12] (Merged) jenkins-bot: Update SmashPig to add currency to AstroPay audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/228896 (https://phabricator.wikimedia.org/T105906) (owner: Ejegg) [22:21:13] Hey cwdent! Thanks 4 the review :) [22:21:59] gerrit does not make it easy to navigate to comments [22:22:11] Heh true also [22:22:23] Mmm I understand that it sounds like that given the name of the method... Basically the mixins are campaign-associated in that a campaign can have mixins associated with it... [22:22:34] you bet AndyRussG, just noticed as i was looking to make that mixin test [22:22:41] However a given mixin will be able to be associated with many campaigns [22:23:05] yep, but the spelling! [22:23:27] cwdent: aaaaaaaaaaaaaaaaaaaaaaaaah [22:23:29] * AndyRussG facepalms [22:23:44] Heh I thought you were talking about the variable... [22:24:08] (PS1) Awight: More debug hacks [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/229002 [22:24:10] Heh yes gotta fix that! [22:24:15] ejegg: /me looks sadly at ^ [22:24:43] hehe, i couldn't find a campagin to register with [22:24:55] heh, not getting what you expect out of redis? [22:25:03] erp, I do keep accidentally calling them that [22:25:20] Maybe we should just change everything else to campagins instead [22:25:25] (CR) Ejegg: [C: 2] "wheee" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/229002 (owner: Awight) [22:26:12] Awight: check out the "typeaheads" section of this page: https://www.mediawiki.org/wiki/Team_Practices_Group/Phabricator_tips/Maniphest [22:26:37] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/229003 [22:26:47] typeaheads are what would happen if autcomplete had a baby with a drop down menu [22:26:51] http://screencast.com/t/K7n6TlBxcE3I [22:26:55] (CR) Awight: [C: 2 V: 2] update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/229003 (owner: Awight) [22:27:51] !log deployed debug hack to payments1004 [22:27:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:28:48] (PS1) Ejegg: Update SmashPig library for AstroPay audit [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/229004 [22:29:29] (CR) Ejegg: [C: 2 V: 2] Update SmashPig library for AstroPay audit [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/229004 (owner: Ejegg) [22:30:46] AndyRussG: luckily it is consistent unto itself and would have not actually caused a bug! [22:31:06] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/229005 [22:31:09] cwdent: yeah if it hadn't been we might have caught it though... [22:31:32] at least it ext.centralNotice.placeholderCampaignMixin.js [22:31:33] In the absence of static typing + IDE, copy-paste! [22:31:48] Yeh I'll fix that too .) [22:31:50] :) [22:31:58] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/229005 (owner: Ejegg) [22:32:04] (CR) AndyRussG: "Great!! Heheh, the relevance of my comments diminishes exponentially with each patch set... :)" (5 comments) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227889 (https://phabricator.wikimedia.org/T107359) (owner: Cdentinger) [22:33:19] !log updated crm from db417a28a247a3fdf3e3023a700d6266e04f3e9d to 4f40ac6de0385982d8e672b1ed30ff1a2a2a2aa1 [22:33:24] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:33:24] awight, I don’t see a batch of gc600s after 20:51 UTC at GC; should they be appearing yet? [22:34:20] HEY ALL, due to some meeting silliness in office, I need to move the Amazon conversation to 2pm tomorrow. Is that ok with everyone? [22:34:42] If not I might have a time slot the next day [22:34:50] dstrine: sure, fine by me [22:34:53] fine here [22:35:11] MBeat: spooky. Maybe it hasn't happened yet. [22:35:22] dstrine: Yea, works for me [22:35:22] The "orphan" traffic levels are really low, usually. [22:35:31] prognosticator, you [22:36:10] AndyRussG: would you be ok to have a meeting at 2pm pst tomorrow? (see comment above) [22:37:20] dstrine: yeah all good! Thanx 4 asking :) [22:37:36] ok thanks all! [22:41:40] (PS1) Awight: Revert "More debug hacks" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/229010 [22:41:42] (PS1) Awight: Revert "Orphan slayer reads from frack Redis" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/229011 [22:42:00] Fundraising Sprint The Pogues, Fundraising-Backlog, Astropay Integration, Unplanned-Sprint-Work, Patch-For-Review: Add 'loading' indicator to AstroPay form - https://phabricator.wikimedia.org/T107321#1504806 (Ejegg) Open>Resolved [22:42:25] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint The Pogues, and 4 others: Orphan slayer reads from frack Redis rather than ActiveMQ - https://phabricator.wikimedia.org/T99017#1283622 (awight) [22:44:23] awight: ah dang, that's a lot of mismatched key names [22:44:28] (CR) Awight: [C: 2 V: 2] Revert "More debug hacks" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/229010 (owner: Awight) [22:44:39] (CR) Awight: [C: 2 V: 2] Revert "Orphan slayer reads from frack Redis" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/229011 (owner: Awight) [22:44:48] ejegg: something horrible like that [22:44:56] I think it has to do with the buildMessage helper functions. [22:45:18] It also looks like we might be using the simplified message, which only has what we needed to make the API call... [22:45:54] (PS1) Awight: update DonationInterface submodule (revert orphan slayer limbo change) [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/229013 [22:46:04] (CR) Awight: [C: 2 V: 2] update DonationInterface submodule (revert orphan slayer limbo change) [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/229013 (owner: Awight) [22:46:28] all those null values make me think it's just looking at the wrong keys [22:46:45] currency, first_name, last_name [22:46:49] !log reverting paymentswiki, to 6dbbb4c784349ace5a0ac616c61ec0c3fffa0eff [22:46:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:47:11] cwdent: heh, found another with grep -ri campagin [22:48:03] it really is easier to type [22:48:37] i'll be back later [22:49:32] hee hee [22:49:48] campaigns are for Dvorak keyboard users! [22:50:44] (PS45) AndyRussG: Refactor client-side API and RL modules for banner display [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) [22:52:44] AndyRussG: chrome stores cookies in sqlite so if things got ugly enough the chromium source would probably provide some visibility into how it searches for cookies [22:53:15] cwdent: hmm! interesting [22:53:17] sounds like the nuclear option though [22:53:36] heh yeah I was just thinking of a comment to explain why the code is fine as is :) [22:53:47] in case any readers start wondering [22:53:52] yep! adding that now [22:55:48] thx! (Also if you disagree with any comments, pls always feel free to say so and not take any suggestions!) [22:56:00] (PS12) Cdentinger: Add geoIP tests [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227889 (https://phabricator.wikimedia.org/T107359) [22:56:57] AndyRussG: no i definitely agree! [22:58:13] ah K cool :) [23:10:00] (PS2) AndyRussG: Fix campaign mixin update bug [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/228440 [23:10:10] (PS2) AndyRussG: Fix campaign mixin query bugs [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/228441 [23:10:27] Oh rebase button, how I do love thee (today only) [23:10:53] My specialty is using the rebase button, then forgetting to pull the new code to my development repo [23:11:09] awight: ooh! good point 8p [23:11:34] It turns out it's surprisingly easy to rebase a long chain of commits, then silently push old patchset revisions on top of newer work [23:11:45] The amend workflow is so stupid. [23:12:05] https://about.gitlab.com/ [23:12:07] jussayin [23:12:14] Oh git review -d \d+, though an afterthought you may be, still dear to my heart you remain! [23:12:15] also whatever that phab thing is [23:12:45] O_o [23:12:58] rrrg except when you create a branch of a different name! [23:15:21] Oh git commit -a --amend... [23:15:30] ... [23:16:19] * AndyRussG looks for a new career [23:16:32] * AndyRussG fails in his new career as a command-line poet [23:17:03] git itself is just ridiculous. from the maker of linux comes an anti tool philosophy tool [23:17:20] it's amazing and powerful but the interface is insane [23:17:44] what does git checkout do? oh, 4 or 5 tangentially related core tasks [23:17:56] Good call. It's hilariously just a filesystem with a bunch of shitty scripts to wrap its functionality to look like a VCS [23:18:49] If you really want a scapegoat, though, I hope you've seen this: https://en.wikibooks.org/wiki/Git/Gerrit_Code_Review#JGit [23:18:51] whoa really!? [23:18:54] you assume --amend would have a shorthand of -a? why would you think that? [23:19:41] oh god it's not even real git?? [23:19:44] * cwdent cries [23:19:48] AndyRussG: well, no, I'm exaggerating a lot, but: https://git-scm.com/book/en/v1/Git-Internals [23:20:01] "First, if it isn’t yet clear, Git is fundamentally a content-addressable filesystem with a VCS user interface written on top of it." [23:20:04] run away!!! [23:20:40] legend has it He wrote it in one night [23:20:45] oh dear [23:20:55] in reformed hieroglyphic obj-c [23:21:06] on a chromebook [23:22:33] right! Now, if had been an Asus... [23:23:02] he wouldn't have been able to type staring at his reflection the whole time [23:23:25] naw i actually have an asus chromebook with a matte display! [23:23:49] can you get matte touchescreens? [23:24:36] Actually now I totally wanna read that Git-Internals chapter! [23:25:02] IMO it's a great book [23:26:08] Tomorrow we can write one about FR tech, in the same style [23:26:29] using a ouija board [23:27:58] AndyRussG: not that i know of, but i'm too old to adopt a new fundamental laptop feature anyway [23:28:11] modprobe -r hid_multitouch [23:28:21] awwww [23:28:37] i kept being like what's that little piece of dust ohgodiclickedsomething [23:29:26] heheh that's true [23:29:53] I get an good excuse forbid my kids from touching my screen [23:30:22] Now I'm looking for a gif of kids trying to swipe on a the screen of a feature phone [23:30:33] hehe [23:30:41] well i gotta mow the lawn, ttyl! [23:33:14] Mmm looks like I'm also afk-bound, cya! [23:42:20] (PS1) Awight: Message helpers can handle both transaction or message-keyed source data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229027 (https://phabricator.wikimedia.org/T99017) [23:42:33] ejegg|away: a treat when you get back ^ [23:42:40] K4-713: or you want to laugh at me? ^ [23:43:06] ...do I? [23:43:10] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint The Pogues, and 4 others: Orphan slayer reads from frack Redis rather than ActiveMQ - https://phabricator.wikimedia.org/T99017#1505011 (awight) This was deployed for a while today, but the... [23:43:23] I'm sort of wrecking important stuff inside of DI [23:43:51] ...ha [23:43:58] thx ;) [23:44:30] awight: Is currency really optional? [23:44:42] no. [23:44:54] But it's not this function's job to complain... [23:45:05] Isn't it? [23:45:18] Eh. [23:45:24] It wasn't doing anything useful, other than cause a strict warning [23:45:40] I... could rename the variable though [23:46:01] Fundraising research, Research-and-Data, Research management: P/T fundraising data analyst JD - https://phabricator.wikimedia.org/T107822#1505024 (DarTar) NEW a:DarTar [23:46:09] What would renaming get you, though? [23:46:11] <_< [23:46:16] um it would make the code more readable [23:46:31] Fundraising research, Research-and-Data, Research management: P/T fundraising data analyst JD - https://phabricator.wikimedia.org/T107822#1505033 (DarTar) This is now with Lisa and @MeganHernandez_WMF for review. [23:46:32] But then you would have to do it all over the place. [23:46:35] Everywhere. [23:47:03] oh hehe, I meant renaming $optional_keys [23:47:16] to $effing_optional_or_just_plain_mapping_whatever [23:47:18] oh, blah [23:47:36] but I'm sure you guessed, I do want to do that other thing you said [23:48:08] (CR) Katie Horn: [C: 2] Message helpers can handle both transaction or message-keyed source data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229027 (https://phabricator.wikimedia.org/T99017) (owner: Awight) [23:48:19] * awight shoots some holes in the ceiling [23:48:28] Yeeeeeeehaw [23:48:28] (Merged) jenkins-bot: Message helpers can handle both transaction or message-keyed source data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229027 (https://phabricator.wikimedia.org/T99017) (owner: Awight) [23:48:42] So I can't ride my horse in here, u say? [23:48:50] That doesn't sound like me at all. [23:49:46] (PS1) Awight: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/229028 [23:49:57] (CR) Awight: [C: 2 V: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/229028 (owner: Awight) [23:50:50] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/229029 [23:51:00] (CR) Awight: [C: 2 V: 2] update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/229029 (owner: Awight) [23:51:10] darn.. saloon doors cramping my style [23:52:20] ha--yubikey PSA: don't hold down the key while using the fob [23:52:27] that was crazy. [23:52:37] What happens? [23:52:56] I mean, if you tell me that with no conclusion, I will probably have to do it myself. [23:53:12] Does it call the police? [23:53:28] Silent alarm action? [23:53:48] it acts like you pressed ^-random string of letters [23:53:52] very exciting, I promise [23:54:19] If I had the thing plugged in just now, I'd probably have just done that. [23:55:01] lowercase roulette [23:55:36] ctrl-random does sound interesting in the old proverb sense. [23:56:24] !log updating paymentswiki to b20559f75e0fc0d863efe027d76b78462555767c [23:56:29] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:56:32] baaaahaha [23:56:56] *computer loses entire mind* [23:57:27] It's like that Borges story, the lottery in babylon [23:58:18] efffbomb [23:59:23] (PS1) Awight: Orphan slayer reads from frack Redis [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/229032 (https://phabricator.wikimedia.org/T99017) [23:59:38] (CR) Awight: [C: 2 V: 2] "Merge to deployment," [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/229032 (https://phabricator.wikimedia.org/T99017) (owner: Awight)