[00:00:05] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/229034 [00:00:17] (CR) Awight: [C: 2 V: 2] update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/229034 (owner: Awight) [00:01:16] Not a bad random string, for my 9th deployment of the day: Ok? Enter the following 4-digit key if you're sure: fug9 / [no]: fug9 [00:01:50] * K4-713 smirks [00:02:00] !log updated paymentswiki to a8c0ecbedef6179c78ed833da9f2049cb0f2641b [00:02:05] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:04:44] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Add a parameter which forces creation of a 600 orphan - https://phabricator.wikimedia.org/T107826#1505118 (awight) NEW [00:06:45] looks like k4 beat me to the code review, and you beat me to complaining about 'optional' [00:07:16] hehe [00:12:05] Fundraising-Backlog, fundraising-tech-ops: php.ini questions on payments1004 - https://phabricator.wikimedia.org/T107827#1505133 (awight) NEW [00:12:56] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Stop writing to ActiveMQ once orphan slaying on Redis has been tested - https://phabricator.wikimedia.org/T99018#1505143 (awight) [00:12:59] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Tech Backlog, and 4 others: Use the new queue wrapper for limbo, antimessage, and orphan slaying - https://phabricator.wikimedia.org/T92922#1505144 (awight) [00:13:02] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint The Pogues, and 4 others: Orphan slayer reads from frack Redis rather than ActiveMQ - https://phabricator.wikimedia.org/T99017#1505141 (awight) Open>Resolved Deployed. [00:13:22] Fundraising Sprint The Pogues, Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: Modify DonationInterface limbo code for high availability deployment - https://phabricator.wikimedia.org/T104499#1505145 (awight) Open>Resolved [00:13:43] JFYI, Done! Final results: 0 destroyed via antimessage (called 1 times) 4 rectified orphans 0 errored out 0 false orphans caught Status 25 = 3 Status 800 = 1 Approximately 15 seconds to execute. [00:13:49] We're back in black [00:14:16] I'll let that burn in for a few days, then we can start removing antimessage and STOMP code [00:19:06] aww yeah [00:19:18] wooooo [00:21:30] Fundraising-Backlog, fundraising-tech-ops: php.ini questions on payments1004 - https://phabricator.wikimedia.org/T107827#1505167 (awight) Just confirmed with a command-line PHP script that there's no 30-second time limit. Hopefully exception logging will reveal the issue! [00:27:12] awight: ejegg: K4-713: sounds like congratulations are in order! [00:27:56] It'll be nice to have this out of the way... it's been 6 months or so! [00:35:39] awight: cool! [00:36:08] Always fun when all the parts of a big project start to fall into place :) [00:37:30] ... or obstacles die of boredom [01:16:47] cwdent|afk: We're pretty invested in Phabricator at this point. Not sure GitLab is a real option. [01:17:24] I use it where I work. It's gotten a lot better in the past year or two. [01:38:56] gerrit wherefor art thou? [01:39:38] (PS3) AndyRussG: Fix campaign mixin update bug [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/228440 [01:40:00] (PS3) AndyRussG: Fix campaign mixin query bugs [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/228441 [01:53:58] Fundraising research, Research-and-Data: Review Finland banner testing strategies - https://phabricator.wikimedia.org/T105561#1505295 (Tnegrin) Hi Research -- it looks like this test will take place in late August/September. We'll reach out to meet on strategies. thanks, -Toby [03:17:59] (PS13) AndyRussG: Add geoIP tests [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227889 (https://phabricator.wikimedia.org/T107359) (owner: Cdentinger) [03:21:19] (CR) AndyRussG: [C: 2] "Fantastic! \o/" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/227889 (https://phabricator.wikimedia.org/T107359) (owner: Cdentinger) [05:58:29] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Spike: Lots of 21000050 errors for Globalcollect, since July - https://phabricator.wikimedia.org/T107845#1505515 (awight) NEW [06:06:21] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Orphan slayer's txn_id prefix is screwy - https://phabricator.wikimedia.org/T107847#1505534 (awight) NEW [06:11:51] Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Orphan logline conspicuously missing - https://phabricator.wikimedia.org/T107848#1505546 (awight) NEW a:awight [06:12:40] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Tech Backlog, and 4 others: Use the new queue wrapper for limbo, antimessage, and orphan slaying - https://phabricator.wikimedia.org/T92922#1505557 (awight) [06:12:42] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint The Pogues, and 4 others: Orphan slayer reads from frack Redis rather than ActiveMQ - https://phabricator.wikimedia.org/T99017#1505554 (awight) Resolved>Open On second thought, let m... [06:12:45] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Stop writing to ActiveMQ once orphan slaying on Redis has been tested - https://phabricator.wikimedia.org/T99018#1505556 (awight) [06:15:56] Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Orphan logline conspicuously missing - https://phabricator.wikimedia.org/T107848#1505569 (awight) [06:21:26] Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Orphan logline conspicuously missing - https://phabricator.wikimedia.org/T107848#1505579 (awight) [06:22:36] Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Orphan logline conspicuously missing - https://phabricator.wikimedia.org/T107848#1505546 (awight) [06:34:54] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Mirror orphan logging to stdout - https://phabricator.wikimedia.org/T107851#1505590 (awight) NEW [06:40:49] Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Fix cheesiness: be more transactional when popping messages from the limbo queue - https://phabricator.wikimedia.org/T107852#1505602 (awight) NEW a:awight [06:41:23] Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Spike: Orphan logline conspicuously missing - https://phabricator.wikimedia.org/T107848#1505610 (awight) [06:45:06] Fundraising Sprint The Pogues, MediaWiki-extensions-CentralNotice: Test coverage for GeoIP module - https://phabricator.wikimedia.org/T107359#1505614 (awight) gerrit-bot: https://gerrit.wikimedia.org/r/#/c/227889/ [07:31:53] (CR) Awight: [C: 2] "Like surfing a tidal wave full of delicious and attractive fish!" (4 comments) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [07:32:39] (PS1) Awight: DO NOT MERGE Remove legacy STOMP code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229079 (https://phabricator.wikimedia.org/T99018) [07:33:02] (Merged) jenkins-bot: Refactor client-side API and RL modules for banner display [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/221759 (https://phabricator.wikimedia.org/T100686) (owner: AndyRussG) [07:33:13] (CR) jenkins-bot: [V: -1] DO NOT MERGE Remove legacy STOMP code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229079 (https://phabricator.wikimedia.org/T99018) (owner: Awight) [12:01:48] Fundraising-Backlog, fundraising-tech-ops: php.ini questions on payments1004 - https://phabricator.wikimedia.org/T107827#1506050 (Jgreen) Looks like the application is doing its own logging rather than using the php framework: $wgDebugLogFile = '/var/log/mw/debug'; $wgDebugLogGroups = array( 'memcache... [12:02:10] Fundraising-Backlog, fundraising-tech-ops: php.ini questions on payments1004 - https://phabricator.wikimedia.org/T107827#1506051 (Jgreen) Open>Resolved a:Jgreen [12:11:03] (PS2) Paladox: Add extension.json, empty old PHP entry point [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/213255 (https://phabricator.wikimedia.org/T88050) (owner: Alex Monk) [12:11:42] (CR) Paladox: [C: 1] Add extension.json, empty old PHP entry point [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/213255 (https://phabricator.wikimedia.org/T88050) (owner: Alex Monk) [15:15:05] AndyRussG: :D [15:15:08] Morning cwdent! BTW I think we can move the GeoIP card to pending deployment, since it's merged into the feature branch now :) [15:15:20] cwdent: hi! :) [15:15:24] great! feeling confident? [15:15:50] heheh confident I'll find some more unexpecteds :) [15:15:57] so, yes :) [15:16:02] you? [15:16:32] heh, well i feel like my visibility is pretty limited, but from what i know yes! [15:16:48] i think all the tests passing is a very good sign [15:17:30] yeah! [15:20:13] Here also is an interesting one: https://phabricator.wikimedia.org/T107503 [15:21:22] ah yes, i can poke at that [15:22:44] Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance: Test for performance regressions - https://phabricator.wikimedia.org/T107503#1506461 (AndyRussG) Related note (courtesy @Jdlrobson via @awight -- thx!): https://lists.wikimedia.org/pipermail/wikite... [15:23:04] cwdent: ^ just added a cool related link awight sent the other day [15:23:17] cwdent: cool! :) [16:38:26] aaarg grammar! "Label for the banner history logger campaign mixin maximum entry age parameter" [16:38:47] Now try that in German! [16:39:11] hehe, it's probably one word in german [16:40:38] AndyRussG: fwiw i can't see any appreciable difference in load time when being targeted by a campaign/banner on the new branch vs. old [16:40:54] of course it's really hard to simulate what actual load will look like [16:41:20] cwdent: fantastic thanks! If you have a sec, post your results and methodology on the task, maybe? [16:41:58] sure, i'll read up on that wikitech thread and try to contribute something useful [16:41:59] Also, note the task's suggestion of pulling in a baseline on all the performance specs we'd like to check on production, before the deploy [16:42:27] I think the same could be done for wmflabs beta cluster, so we can do the same there [16:42:45] are you thinking of timing specific tasks like how long did it take to choose a banner? [16:43:07] cwdent: P.S. I have no idea how prioritize-y this is, dunno if atgo has opined yet ;p [16:43:47] cwdent: I think the main two things are time to first paint, minified size of centralnotice JS loaded [16:44:18] sounds good, yeah the 2nd one should be easy to determine [16:44:20] And when there is a banner shown, any page bump [16:44:27] yeah [16:44:58] For the second one, one option would be to just pull the localStorage module store contents [16:46:06] When applicable, everything should be checked in at least 3 circumstnaces: 1) when there are no possible banners in choiceData, 2) when there are possible banners in choiceData but no campaign is chosen, and 3) when a campaign is chosen and banner is chosen and shown [16:46:30] arrrg correcting 1) when there are no campaigns in choiceData [16:48:55] newbie question: what are we using for minification? is it the same on live vs. dev? [16:49:34] locally it doesn't look super aggressive, variable and function names seem intact [16:59:42] i should also add that i am not an expert in this area [17:00:21] cwdent: not sure! It's built into resourceloader [17:00:48] It just minifies unless you do debug=true [17:01:15] Yeah it could do better... No variable name replacement [17:01:57] Heh of course that's just a very simple problem [17:02:09] i have also seen overly aggressive minification break stuff so... [17:02:13] better safe than sorry [17:04:57] the simplest possible test shows the new branch transferring about 5k more overall [17:14:39] Going to run an errand really quick. BRB [17:27:13] TIL https://performance.wikimedia.org/ [17:27:17] nice [17:31:38] cwdent: woo! [17:31:46] awight: thx! [17:34:20] (PS1) AndyRussG: Campaign mixins: Fix handling of removed parameters [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229164 [17:41:06] Hmmm my trackpad button doesn't like it when I hit it too hard [17:41:18] Maybe it gets a buttonache [17:46:51] (PS2) AndyRussG: Campaign mixins: Fix handling of removed parameters [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229164 [17:47:12] bassoon! [17:47:16] cwdent: I wonder if we can get one of those for betawiki... [17:47:45] this looks fun too http://www.sitespeed.io/ [17:48:04] but yeah it would be great to get metrics _before_ code rolls [17:50:07] right! [18:22:19] (PS1) Awight: Include main Special page aliases file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229181 [18:27:56] Fundraising Sprint The Pogues, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Make DonationInterface fatal errors accessible - https://phabricator.wikimedia.org/T107918#1507162 (awight) NEW [18:29:13] (CR) Ejegg: [C: 2] "Did I do that? " [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229181 (owner: Awight) [18:34:14] Fundraising Sprint ODB, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, and 2 others: DonationInterface spam in LocalisationUpdate logs - https://phabricator.wikimedia.org/T105850#1507194 (Ejegg) Open>Resolved [18:35:30] MBeat: Hi! When you have a minute, can you confirm that Globalcollect order id 5716793541 was settled correctly? I expect it is, just doing due diligence on my changes to the orphan slayer... [18:35:59] (Merged) jenkins-bot: Include main Special page aliases file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229181 (owner: Awight) [18:36:38] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: We need a way to debug which form partials are being loaded - https://phabricator.wikimedia.org/T96440#1507234 (Ejegg) [18:43:16] Fundraising Tech Backlog, Fundraising-Backlog: Track settlement currencies other than USD (was: Make sure we do not lose gateway conversion information) - https://phabricator.wikimedia.org/T86568#1507277 (Ejegg) [18:45:08] Fundraising Tech Backlog, Fundraising-Backlog, § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, § Fundraising Sprint the Cure: Kill all "original_"- fields - https://phabricator.wikimedia.org/T86102#1507301 (Ejegg) Open>Resolved Looks like we got 'em all! [18:48:15] Fundraising Tech Backlog, Fundraising-Backlog, § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, § Fundraising Sprint the Cure: Kill all "original_"- fields - https://phabricator.wikimedia.org/T86102#1507314 (awight) Resolved>Open You totally got my hopes up, only to dash th... [18:50:49] (PS2) Awight: DO NOT MERGE Remove legacy STOMP code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229079 (https://phabricator.wikimedia.org/T99018) [19:54:13] Hmm I wonder who owns mw.Uri [20:01:08] might be late to standup - appt running late [20:58:32] dstrine: the room is crossed out [21:03:36] AndyRussG: are you available for a meeting? [21:04:23] ejegg: are you on the hangout? [21:04:35] dstrine: yes coming! Sorry, just trying to get my web cam working again 8p [21:04:54] dstrine, atgo sorry, cascade of connectivity issues [21:05:31] just had a big lightning storm and cable internet is not happening at all. Phone internet doesn't seem to be much better [21:06:03] K4-713: ^^ [21:06:27] Yow! [21:06:31] How are you doing this? [21:06:45] IRC interface in your head? [21:06:53] Phone's letting enough trickle thru to do IRC [21:07:01] :) [21:07:02] but vidchat seems to be out [21:07:16] Sorry, can we reschedule this for tomorrow? [21:08:04] aww sadness [21:08:44] yeah, phooey indeed [21:10:13] Fundraising Sprint The Pogues, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Make DonationInterface fatal errors accessible - https://phabricator.wikimedia.org/T107918#1507939 (atgo) a:awight [21:10:49] ejegg: we just moved the meeting to tomorrow [21:10:58] thanks dstrine [21:11:03] Sorry to hear about the internet :( [21:11:05] sorry for the inconvenience [21:34:55] Fundraising research, Research-and-Data: Revenue Projections - https://phabricator.wikimedia.org/T107946#1508048 (ellery) NEW a:ellery [21:46:05] It's all good.we got time tomorrow [21:59:44] https://www.youtube.com/watch?v=UiyDmqO59QE [22:04:24] Nice [22:05:02] <3 5SF [22:06:37] is there a FR retro tomorrow unrepresented by a calendar entry? [22:07:13] i see it - lemme add you if you're not already on [22:07:28] cool, thanks [22:15:54] RE: retro meeting tomorrow: I'm going to make sure the series is on the fundraising calendar so people can see it and join if they want to. [22:30:52] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: We need a way to debug which form partials are being loaded - https://phabricator.wikimedia.org/T96440#1508228 (pizzzacat) a:pizzzacat>None [22:31:31] Fundraising Dash: Handle time ranges for chart data client-side - https://phabricator.wikimedia.org/T86841#1508234 (pizzzacat) a:pizzzacat>None [22:31:39] Fundraising Dash: "Saved Charts" button functionality, X-by-Y widget (Persistence) - https://phabricator.wikimedia.org/T86835#1508241 (pizzzacat) a:pizzzacat>None [22:31:48] Fundraising Tech Backlog: Delete unused i18n strings in Donation Interface - https://phabricator.wikimedia.org/T86255#1508243 (pizzzacat) a:pizzzacat>None [22:31:52] Fundraising Tech Backlog: Delete unused CSS in Donation Interface extension - https://phabricator.wikimedia.org/T86254#1508252 (pizzzacat) a:pizzzacat>None [22:32:00] Fundraising Tech Backlog: Front-end form validation cleanup for Donation Interface - https://phabricator.wikimedia.org/T86252#1508255 (pizzzacat) a:pizzzacat>None [22:32:09] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Make the forms come from one template - https://phabricator.wikimedia.org/T86248#1508259 (pizzzacat) a:pizzzacat>None [22:32:15] Fundraising Dash, § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, Patch-For-Review: Dash: Allow settings/filters to be saved for each user - https://phabricator.wikimedia.org/T86095#1508263 (pizzzacat) a:pizzzacat>None [22:32:21] Fundraising Dash, § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys: Dash: breakdown bars - https://phabricator.wikimedia.org/T86094#1508265 (pizzzacat) a:pizzzacat>None [22:32:29] Fundraising Dash: User Profile page - https://phabricator.wikimedia.org/T86839#1508267 (pizzzacat) a:pizzzacat>None [22:32:51] AndyRussG: regarding mixins i'm a little confused. i was under the impression that they were previously associated with banners but can now be attached campaign wide. however the display code looks like it only gathers them from the campaign for preBannerMixinHooks. is that the case? [22:33:23] cwdent: uhh almost. There are two kinds of mixins that are pretty different. The banner kind and the campaign kind [22:33:42] Both will be available though the campaign kind is new and is needed for the banner history [22:34:04] The banner kind will also be really useful but we haven't yet used it for stuff on production [22:34:22] oh, so what kind are currently used? any? [22:34:25] That kind sends JS in with banners [22:34:52] In production banners, neither, though the base implementation of the banner kind is in the deployed code on production [22:35:33] The campaign kind is what we'll start using... For the real banner history patch, I'm just writing the first campaign kind now! [22:36:33] so banner mixins will not be a thing? [22:36:59] The should be! We just need to transform some of the on-wiki banner JS into them :) [22:37:27] Basically, right now a lot of JS is added to banners using a funky mechanism called transclusion. Wiki pages included in other wiki apges [22:37:57] Lemme get an example [22:38:25] that would be great [22:38:27] https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/B1516_0730_enBR_ipd_p1_lg_amt_10 [22:38:59] So at the bottom of that page you see the bit that says, "Included templates" [22:39:03] ah yes [22:39:08] Those are all other wiki pages that have js that is included in that banner [22:39:17] All snippets! [22:39:40] will the new approach still gather the includes from here? [22:39:50] Heh and editable by a surprisingly large number of folks [22:40:01] Mmm well we're not removing the ability to do this [22:40:01] yeah :-\ [22:40:11] oh ok, just introducing a more proper way? [22:40:24] Yeah... and bit by bit farming this JS off into more the desireable places... [22:40:51] right on, when i first saw this i definitely thought omg [22:40:54] So currently all this JS is loaded with the banner [22:41:07] It does make sense for some of it to do that, i.e., run when the banner is loaded [22:41:15] For example, the currency stuf [22:41:31] sure, but other things could be deferred? [22:41:47] Other bits of JS, however, should really run after the campaign is chosen, but before the banner is chosen... So actually not deferred, but pre-ferred, i.e. run sooner [22:42:00] hehe, gotcha [22:42:10] so those are the prebannerhooks [22:42:34] Specifically, these FR banners don't actually appear automatically when injected into the DOM. They're initially hidden, and some JS runs to decide whether to _really_ show them [22:42:38] That's the main gotcha [22:43:05] ah, so some js should run whether or not the banner gets actually shown [22:43:25] is that right? [22:43:28] Yeah... by moving that logic to pre-banner selection and server-fetch, and deciding whether or not to show the banner as soon as the campaign is chosen, we can avoid unnecessary banner fetches [22:43:41] nice [22:43:52] Basically, the new go-to logic will be, if you load it, you show it [22:44:15] are the prebannerhooks instrumental in deciding if it should be shown or not? [22:44:18] And if you're not sure whether to show it, you run your show-or-no-show logic before fetching it [22:44:22] yeah! [22:44:46] cool, that makes sense [22:44:47] Among other things, this will allow us to count banner displays by just counting the requests to fetch the banner [22:45:15] i'm sure this will also significantly reduce requests [22:45:16] cwdent: have you seen this? Overview of this change https://www.mediawiki.org/wiki/Extension:CentralNotice/Notes/Campaign-associated_mixins_and_banner_history [22:45:46] yep i've been reading that [22:45:50] cwdent: yeah that's been a significant concer of Ops: https://phabricator.wikimedia.org/T45250 [22:46:28] it looks like the mixins are a json object that describe functions to run with args, and which type they are (pre vs. post) [22:46:38] is that right? [22:46:40] Runing the campaign-mixins has other advantages, too, namely avoiding a heinous thing called a "lost impression" that we get to avoid re-showing large-sized banners [22:47:06] Well mmm not quite, no, there's a lot more to it [22:47:29] There is json that is sent to the client by the ext.centralNotice.choiceData RL module [22:47:36] That is a resourceloader module that's implemented in PHP [22:47:55] And it holds a list of possible campaigns available for any given user [22:48:12] cwdent: https://www.mediawiki.org/wiki/Extension:CentralNotice/Campaign_and_banner_selection [22:48:37] You can configure campaigns to use or not use any of the available campaign mixins [22:48:43] ah ha [22:48:55] that's that registerCampaignMixin thing? [22:48:55] And campaign mixins have parameters that can differ from one campaign to another [22:49:46] Yeah... So the mixin code itself is also in ResorceLoader module form. So ext.centralNotice.choiceData uses the ResourceLoader dependency mechanism to bring in any mixin code that may be needed [22:50:22] And it sends the parameters for the mixin for any campaigns that use them in the json with the data about possible campaigns available [22:50:22] ok, i was wondering where the functions would actually be defined [22:50:49] In the feature branch head, check out the placeholder mixin [22:51:31] resources/subscribing/ext.centralNotice.placeholderCampaignMixin.js [22:51:54] The WIP patch I'll send off in a bit removes that one and adds the new banner history logger mixin [22:52:25] oh awesome, so going forward this is what a mixin will look like? [22:52:50] we will code it and place it in a file instead of the wiki js? [22:54:06] cwdent: exactly! yeah code review etc etc [22:54:18] minification [22:54:26] and running before the banner is loaded [22:54:33] excellent [22:54:47] so i see pre and post both in here, so one mixin can have both of those? [22:55:09] In reallyChooseAndMaybeDisplay() in display, you can see we give the mixin the chance to actually cancel a banner [22:55:31] cwdent: yeah! I remember I was thinking about another possible hook too one day, not sure what it was now... [22:55:55] also i need to stop starting sentences with "so" because it transmits no meaning [22:55:59] stupid millenial [22:58:28] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Run CRM on HHVM - https://phabricator.wikimedia.org/T91896#1508364 (awight) @JGreen: We're ready to move on this--not sure if speeding up CiviCRM or the payments cluster will be the bigger win, see also T91899 [22:58:41] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Run CRM on HHVM - https://phabricator.wikimedia.org/T91896#1508366 (awight) [22:58:57] Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops: Run Payments wiki on HHVM - https://phabricator.wikimedia.org/T91899#1098384 (awight) [22:59:21] AndyRussG: i notice that the mixin registers itself with the campaign. how will the choice be made whether or not to register? [23:00:02] Heh I think "so" says something! :) [23:00:43] cwdent: no, the mixin registers itself with mw.centralNotice, that is with the main display code in mw.centralNotice.display.js [23:01:28] Oooooh wait do I have a really dumb bug!?!?! [23:01:36] Arrrrrrrggggh [23:01:57] D: [23:02:11] ...i have no idea [23:02:49] bwahahaha forgot to even check that a mixin is activated for a campaign mmmrrrgggpplll [23:03:29] cwdent: ah no, not true [23:03:31] 8p [23:03:34] It's late [23:03:41] OK try this agin... [23:03:59] Fundraising-Backlog: GeoIP cookie causing country=XX when I load donate page - https://phabricator.wikimedia.org/T107957#1508395 (CCogdill_WMF) NEW [23:05:46] cwdent: Whenever the mixin code is loaded, it will be registered, yes [23:06:02] But it will only run its hooks if it has been activated for the campaign that has been chosen for this user [23:06:35] gotcha, that must be the getCampaign().mixins part? [23:06:38] see runMixinHooks() in ext.centralNotice.display.js [23:06:40] Yeah [23:06:53] $.each( state.getCampaign().mixins, function( mixinName, mixinParams ) { [23:07:38] cwdent: BTW in a minute or two I have to do family fooding time [23:08:13] yes please do! i don't mean to bother you about this at 7pm [23:08:33] this has been great and i think i have enough to go on, thank you! [23:10:54] Fundraising Sprint The Pogues, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Make DonationInterface fatal errors accessible - https://phabricator.wikimedia.org/T107918#1508433 (awight) According to https://www.mediawiki.org/wiki/Manual:How_to_debug#Creating_custom_log_groups w... [23:13:18] cwdent: ah it's no bother at all! I often get going late and have interruptions during the day, so this is totally normal work hours for me :) [23:13:41] Also it's no bother to ask anything anytime, if I can't answer I... may just not... so pls don't worry about it :) [23:13:43] K cya soon! [23:13:51] have a good night! [23:13:57] cwdent: likewise! [23:14:19] Fundraising Sprint The Pogues, Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Reduce cheesiness: Abort ophan slayer job when we hit a total elapsed time like 4 minutes - https://phabricator.wikimedia.org/T107958#1508450 (awight) NEW [23:22:24] Fundraising-Backlog: Add GC failure "Remarks" data to contribution tracking - https://phabricator.wikimedia.org/T107960#1508486 (CCogdill_WMF) NEW [23:26:37] Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Spike: Orphan logline conspicuously missing - https://phabricator.wikimedia.org/T107848#1508529 (awight) [23:29:00] (PS2) Ejegg: P.O.C. Amazon Express Donation autopost form [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/228498 (https://phabricator.wikimedia.org/T102255) [23:29:02] (PS3) Ejegg: Add payWithAmazon feature branch [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/228306 [23:29:04] (PS1) Ejegg: Add pay with Amazon SDK composer package [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/229277 [23:29:06] (PS1) Ejegg: P.O.C. Amazon result switcher [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/229278 [23:29:24] (CR) jenkins-bot: [V: -1] P.O.C. Amazon Express Donation autopost form [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/228498 (https://phabricator.wikimedia.org/T102255) (owner: Ejegg) [23:29:29] (CR) jenkins-bot: [V: -1] P.O.C. Amazon result switcher [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/229278 (owner: Ejegg) [23:29:31] (CR) jenkins-bot: [V: -1] Add pay with Amazon SDK composer package [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/229277 (owner: Ejegg) [23:38:25] Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Spike: Orphan logline conspicuously missing - https://phabricator.wikimedia.org/T107848#1508562 (awight) Looking at `orphans.php`, I think I can narrow the failure down to `rectifyOrphan`, either `$results->get... [23:45:57] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint The Pogues, and 4 others: Orphan slayer reads from frack Redis rather than ActiveMQ - https://phabricator.wikimedia.org/T99017#1508605 (awight) [23:46:00] Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Spike: Orphan logline conspicuously missing - https://phabricator.wikimedia.org/T107848#1508603 (awight) Open>Resolved Could not find the issue. Closing until we have more information. [23:49:07] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Reduce cheesiness: Abort ophan slayer job when we hit a total elapsed time like 4 minutes - https://phabricator.wikimedia.org/T107958#1508450 (awight) [23:49:39] Fundraising Sprint The Pogues, Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Some errors are not being logged, and are not caught in the right context - https://phabricator.wikimedia.org/T107531#1508611 (awight) [23:49:43] Fundraising Sprint The Pogues, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Make DonationInterface fatal errors accessible - https://phabricator.wikimedia.org/T107918#1508612 (awight)