[00:01:15] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: investigate negative scroll offset for cancelling "banner bump" - https://phabricator.wikimedia.org/T107967#1508646 (awight) NEW [00:06:10] Fundraising-Backlog: Add GC failure "Remarks" data to contribution tracking - https://phabricator.wikimedia.org/T107960#1508663 (awight) Just noting that the "remarks" field is probably just a translation of the error code. Either way, we should definitely store the error codes as well cos they might give u... [00:15:02] awight: hi! :) Nice card! any ideas about https://phabricator.wikimedia.org/T106577 ? The scrollybump is noted there I think (it does also deserve specifically investigating, though, I think!) [00:19:43] Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Determine how to load CentralNotice RL modules and when to execute campaign and banner selection logic - https://phabricator.wikimedia.org/T106577#1508743 (awight) [00:20:22] Hehe, I do not have any ideas about that [00:20:40] Just throwing out some old notes... I added the subtask # to that epic spike [00:22:58] I'm on board with the plan to possibly delay banner loading to slightly later, if it makes the main content render faster. We can do evil magic with the bump if necessary. [00:23:46] awight: cool! In fact I don't think it'll really be later than currently [00:24:04] ...considering that cn doesn't do initialize() until the DOM is ready... [00:24:54] Well, if we postpone our RL stuff to not be part of the top scripts... [00:25:40] will it really run much later? I guess I hadn't checked when those actually do run. They're loaded in another script tag at the bottom [00:26:19] awight: you said there are bits you're not sure you're understanding? [00:26:55] hehe I definitely implied that [00:27:47] ...? specific questions? [00:28:59] Nah, I think I get the general picture! [00:30:51] awight: fantastic :) [00:31:20] Heh while I'm poking also recall the follow-on minor bugfix patches :) [00:32:30] https://gerrit.wikimedia.org/r/#/c/228440/ & friends... [00:33:20] and thx in advance (& of course np if you're busy, have other priorities or... aren't working ;) ) [00:34:53] (PS4) Awight: Fix campaign mixin update bug [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/228440 (owner: AndyRussG) [00:35:10] (CR) Awight: [C: 2] Fix campaign mixin update bug [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/228440 (owner: AndyRussG) [00:35:16] (PS4) Awight: Fix campaign mixin query bugs [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/228441 (owner: AndyRussG) [00:35:35] wohoo! [00:36:07] (Merged) jenkins-bot: Fix campaign mixin update bug [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/228440 (owner: AndyRussG) [00:42:21] (CR) Awight: [C: 2] "I think we can get rid of the references... comments inline." (1 comment) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/228441 (owner: AndyRussG) [00:42:39] (PS3) Awight: Campaign mixins: Fix handling of removed parameters [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229164 (owner: AndyRussG) [00:43:39] (CR) Awight: [C: 2] Campaign mixins: Fix handling of removed parameters (1 comment) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229164 (owner: AndyRussG) [00:43:48] k, gotta run! [00:43:48] (Merged) jenkins-bot: Fix campaign mixin query bugs [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/228441 (owner: AndyRussG) [00:44:03] AndyRussG: I left some comments, mostly persnickety [00:44:30] The references stuff should really go away, though, I think there's a simpler way to achieve whatchu want [00:48:49] (CR) AndyRussG: Fix campaign mixin query bugs (1 comment) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/228441 (owner: AndyRussG) [00:48:55] (Merged) jenkins-bot: Campaign mixins: Fix handling of removed parameters [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229164 (owner: AndyRussG) [01:16:26] hi [09:14:25] TCB-Team-Fundraising-Sprint-2015-07-29, TCB-Team: [WMDE-Fundraising] Investigation and provide a plan for implementing a test system for memberships - https://phabricator.wikimedia.org/T107276#1510068 (WMDE-leszek) I have listed my thoughts in a rather lengthy form in a comment in https://github.com/wmde/f... [09:50:43] TCB-Team-Fundraising-Sprint-2015-07-29, TCB-Team: [WMDE-Fundraising] Write update script for DB schema changes - https://phabricator.wikimedia.org/T107273#1510158 (WMDE-Fisch) To update the DB to the current schema we can use the Doctrine CLI SchemaTool. It works fine for simple cases like adding columns... [09:51:34] TCB-Team-Fundraising-Sprint-2015-07-29, TCB-Team: [WMDE-Fundraising] Create diagram of fundraising components - https://phabricator.wikimedia.org/T107277#1510161 (WMDE-Fisch) a:WMDE-Fisch [11:12:16] TCB-Team-Fundraising-Sprint-2015-07-29, TCB-Team-Fundraising-Sprint-2015-08-05, TCB-Team: [WMDE-Fundraising] Investigation and provide a plan for implementing a test system for memberships - https://phabricator.wikimedia.org/T107276#1510348 (Tobi_WMDE_SW) [11:13:07] TCB-Team-Fundraising-Sprint-2015-07-29, TCB-Team-Fundraising-Sprint-2015-08-05, TCB-Team: [WMDE-Fundraising] Create diagram of fundraising components - https://phabricator.wikimedia.org/T107277#1510349 (Tobi_WMDE_SW) [11:19:53] TCB-Team-Fundraising-Sprint-2015-08-05, TCB-Team: [WMDE-Fundraising] Estimate effort: english donation pages and form - https://phabricator.wikimedia.org/T107258#1510370 (Tobi_WMDE_SW) [11:52:53] TCB-Team-Fundraising-Sprint-2015-08-05, TCB-Team: [WMDE-Fundraising] Cross-check contact data for host europe - https://phabricator.wikimedia.org/T108016#1510427 (Tobi_WMDE_SW) NEW [11:54:34] TCB-Team-Fundraising-Sprint-2015-08-05, TCB-Team: [WMDE-Fundraising] Cross-check contact data for host europe - https://phabricator.wikimedia.org/T108016#1510438 (Tobi_WMDE_SW) [11:56:30] TCB-Team-Fundraising-Sprint-2015-08-05, TCB-Team: [WMDE-Fundraising] Investigate security settings for "sensitive banner" - https://phabricator.wikimedia.org/T108017#1510441 (Tobi_WMDE_SW) NEW [11:56:41] TCB-Team-Fundraising-Sprint-2015-08-05, TCB-Team: [WMDE-Fundraising] Investigate security settings for "sensitive banner" - https://phabricator.wikimedia.org/T108017#1510449 (Tobi_WMDE_SW) [11:56:49] TCB-Team-Fundraising-Sprint-2015-08-05, TCB-Team: [WMDE-Fundraising] Investigate security settings for "sensitive banner" - https://phabricator.wikimedia.org/T108017#1510451 (Tobi_WMDE_SW) p:Triage>Normal [14:56:42] TCB-Team-Fundraising-Sprint-2015-08-12, TCB-Team: [WMDE-Fundraising] Move Piwik to its own VM - https://phabricator.wikimedia.org/T105289#1510784 (Tobi_WMDE_SW) [15:52:57] * AndyRussG waves [15:53:08] mornin [15:53:18] Morning ejegg cwdent XenoRyet :) [15:53:33] Hi AndyRussG ! [15:53:39] :D [15:53:40] and cwdent and XenoRyet ! [15:53:58] wassup wassup [15:54:16] ejegg: I think I heard somewhere talk about removing the "language" parameter from the donation pipeline in favor of "uselang"--is that true? I'm asking 'cause I'm wondering which name I should call it in the banner history log... [15:56:48] AndyRussG: oh, I thought it was the other way around... [15:57:10] ejegg: ah certainly possible! I have no idea [15:57:15] there must be a phabricator ticket for it! [15:57:21] yeah hmmm [15:59:23] Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Determine how to load CentralNotice RL modules and when to execute campaign and banner selection logic - https://phabricator.wikimedia.org/T106577#1510956 (AndyRussG) [16:01:51] Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Determine how to load CentralNotice RL modules and when to execute campaign and banner selection logic - https://phabricator.wikimedia.org/T106577#1510962 (AndyRussG) [16:02:39] Fundraising Sprint The Pogues, MediaWiki-extensions-DonationInterface: FailPage logic is all jacked up - https://phabricator.wikimedia.org/T108041#1510966 (Ejegg) NEW a:Ejegg [16:04:03] ejegg: https://phabricator.wikimedia.org/T96621 [16:04:25] ahh, guess you had it the right way round [16:04:25] Not sure if it's relevant at all to banner history, though I guess we should makes params coherent as possible for the sake of those querying [16:04:29] morning! [16:04:40] hi atgo [16:05:23] Fundraising Sprint The Pogues, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: FailPage logic is all jacked up - https://phabricator.wikimedia.org/T108041#1510987 (atgo) [16:11:40] AndyRussG: how to instruct RL to load a campaign mixin? [16:13:13] cwdent: Ah the UI bits are in the same campaign definition UI. Go to the infrastructure wiki Special:CentralNotice [16:13:59] Then navigate to the campaign, and you should see it under "Extra campaign features" [16:14:20] aah ok, so for testing purposes i would add the mixin to the example data? [16:16:31] cwdent: yep! [16:32:12] 🍕 [16:36:50] AndyRussG: rrgh sorry i'm still confused. when i add the placeholder to the test data it still bails on this check: if ( !( mixinName in campaignMixins ) ) { [16:37:10] if i'm reading right it should get added to that array when the mixin is loaded by RL [16:37:20] but that's the part i'm not sure how to enable [16:41:04] cwdent: maybe pastebin or send up a WIP patch? [16:41:35] sure, one sec [16:44:28] AndyRussG: http://pastebin.com/9Mdd9WnK [16:44:38] that's how i added it to the test data [16:44:52] plz ignore my tab characters [16:47:06] (PS1) Ejegg: Fix fail page redirection [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229414 (https://phabricator.wikimedia.org/T108041) [16:48:27] XenoRyet: the error handling logic on production is currently really screwed up and sending users to a 404 page. ^^^ should make that better if you have a chance to review. [16:49:08] Fundraising Sprint The Pogues, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, Patch-For-Review: FailPage logic is all jacked up - https://phabricator.wikimedia.org/T108041#1510966 (Ejegg) [16:53:53] Fundraising Sprint The Pogues, Astropay Integration, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: AstroPay donors all sent to fail page - https://phabricator.wikimedia.org/T108059#1511283 (Ejegg) NEW a:Ejegg [16:54:22] Fundraising Sprint The Pogues, Astropay Integration, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: AstroPay donors all sent to fail page - https://phabricator.wikimedia.org/T108059#1511283 (Ejegg) [16:54:44] cwdent: Hmmm... In theory it looks OK... To see what choiceData should look like, you can actually add the mixin to the campaign and check mw.centralNotice.choiceData, or look at http://localhost/mw1/api.php?action=centralnoticechoicedata&project={...}&language=en [16:54:58] (adapt for your local setup) [16:55:30] cwdent: also note that the placeholder mixin will be removed. Not sure what the best strategy will be to test the general mixin facilities... [16:55:49] AndyRussG: do you also remove the tests before deploy? [16:56:05] i could make a test mixin inside the test file i suppose [16:56:27] AndyRussG, cwdent, XenoRyet: anything for Scrum of Scrums today? [16:56:42] ejegg: thanks, not today! [16:56:47] nothing from me [16:56:58] k [16:57:30] Na, I'm good [16:57:51] cwdent: hmmm I dunno, maybe that's it... I think that the failure on the line you point out is 'cause the mixin RL module is not being loaded in the test, so registerCampaignMixin() is not being called [16:58:44] i bet this channel gets alive around december right? [16:58:54] AndyRussG: yep that's my impression... i guess that's what i'm trying to understand, how does RL get instructed to load the mixin? is there a good reason that shouldn't happen in the tests? [16:59:04] cwdent: yes [17:00:21] cwdent: RL is instructed to load the mixin because when a mixin is set for any campaign in choiceData, the mixin's RL module is dynamically made a dependency of ext.centralNotice.choiceData RL module [17:00:53] cwdent: see getDependencies() in includes/CNChoiceDataResourceLoaderModule.php [17:01:48] I think for the test it'd be good enough to call registerCampaignMixin() manually, with code that is like that of an actual mixin, without being a real RL module [17:02:21] yeah that's what i was thinking, we're testing that the mixin gets run, not that it can load one [17:05:27] 🍕💃 [17:05:41] TOFU. [17:05:44] pizza! dancer! [17:05:50] tofu tofu. [17:05:57] 🐶 [17:05:58] oh boy, unicode replacement characters! [17:06:04] ...more tofu. [17:06:23] They should have a tofu emoji. [17:06:44] cwdent: yep! [17:06:47] K4-713: do you see the hex code or just the question-mark-in-diamond? [17:07:01] I just see these recangles [17:07:15] 🐙 [17:07:37] lame. [17:07:47] ooh, I gotta try this: http://xkr47.outerspace.dyndns.org/howtos/irssi-utf-8-guide.txt [17:08:08] However I can google! [17:08:42] Soo, pizza dance octopus [17:08:48] It's like a joke that someone has to explain to you [17:08:59] google knows all [17:09:40] AndyRussG: http://www.i18nguy.com/markup/i18n-glossary.html#tofu [17:12:57] ejegg|mtg: I am getting visible hex code in the tofu, yes. [17:13:39] Maybe pidgeon has a plugin to sort out this MESS. [17:14:26] K4-713: hmmmm [17:18:14] * AndyRussG fetches ham sandwich [17:18:42] ejegg|mtg: Reviewing your error handling patch. When you get a second: Is there a good way to invoke an error on production so I can see the bad behavior? [17:19:25] XenoRyet: yeah, due to another bug, the ResultSwitcher for astropay always errors out [17:19:33] 1 sec, let me get you a link [17:24:20] arg we're outta ham! [17:24:45] * AndyRussG chortles rice 'n' beans [17:28:58] (PS1) Cdentinger: WIP: Add preBannerMixinHook test. [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229422 [17:29:38] AndyRussG: ^ lemme know what you think about that! [17:29:58] (CR) jenkins-bot: [V: -1] WIP: Add preBannerMixinHook test. [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229422 (owner: Cdentinger) [17:30:32] cwdent: cool! [17:30:48] BTW, I'm off to pick up kids from day camp.. Back in like 1 hr :) [17:32:47] (PS2) Cdentinger: WIP: Add preBannerMixinHook test. [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229422 [17:33:47] (CR) jenkins-bot: [V: -1] WIP: Add preBannerMixinHook test. [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229422 (owner: Cdentinger) [17:37:01] (PS3) Cdentinger: WIP: Add preBannerMixinHook test. [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229422 [17:37:53] (CR) jenkins-bot: [V: -1] WIP: Add preBannerMixinHook test. [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229422 (owner: Cdentinger) [17:40:13] (PS4) Cdentinger: WIP: Add preBannerMixinHook test. [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229422 [17:50:09] Analytics reports there was a 6 hour Kafka outage on Monday. Does that affect our statistics at all? [18:04:48] Fundraising-Backlog: Change error messages on new GC red text to match field name - https://phabricator.wikimedia.org/T106172#1511684 (atgo) [18:05:50] Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: Publishing translations for central notice banners fails - https://phabricator.wikimedia.org/T104774#1511687 (atgo) [18:06:32] Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 3 others: Publishing translations for central notice banners fails - https://phabricator.wikimedia.org/T104774#1511688 (DStrine) [18:06:52] Fundraising-Backlog, Astropay Integration: Astropay errors should be red text and not popup - https://phabricator.wikimedia.org/T107363#1511689 (atgo) [18:09:49] i've gotta run some errands, back in a bit [18:10:27] Fundraising-Backlog: Remove Amazon from forms (Aug 21) - https://phabricator.wikimedia.org/T107528#1511703 (atgo) [18:10:44] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding 1 Custom field to "primary fields" export list: Do Not Solicit - https://phabricator.wikimedia.org/T105918#1511708 (atgo) [18:14:29] awight: if you have a sec, tiny patch to make it non-fatal when a queue doesn't support delete: https://gerrit.wikimedia.org/r/229394 [18:15:51] also, XenoRyet is on this one, but you might be interested too: https://gerrit.wikimedia.org/r/229414 [18:16:35] (CR) Awight: [C: 2] Don't crash when queue backend can't delete message (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229394 (owner: Ejegg) [18:17:01] thanks! [18:17:07] (Merged) jenkins-bot: Don't crash when queue backend can't delete message [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229394 (owner: Ejegg) [18:17:19] ah, good call on catching more specific exceptions [18:17:58] Probably not possible at the moment... [18:19:07] oh hey, it's a BadMethodCallException. that's actually helpful [18:20:23] * awight beams at rare instance of own foresight [18:25:45] (CR) Awight: Fix fail page redirection (6 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229414 (https://phabricator.wikimedia.org/T108041) (owner: Ejegg) [18:26:21] (PS1) Ejegg: Catch specific exception in deleteLimboMessage [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229435 (https://phabricator.wikimedia.org/T108059) [18:27:09] (CR) Awight: Catch specific exception in deleteLimboMessage (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229435 (https://phabricator.wikimedia.org/T108059) (owner: Ejegg) [18:29:38] thanks for all the feedback awight! [18:30:04] there's more where that came from ;) [18:30:12] I gotta go see the ankle doc. See you all at the Amazon scoping meeting! [18:30:22] good luck breaking your chains! [18:31:47] (PS2) Ejegg: Catch specific exception in deleteLimboMessage [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229435 (https://phabricator.wikimedia.org/T108059) [18:32:08] (CR) Awight: [C: 2] Catch specific exception in deleteLimboMessage [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229435 (https://phabricator.wikimedia.org/T108059) (owner: Ejegg) [18:32:10] (CR) Ejegg: Catch specific exception in deleteLimboMessage (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229435 (https://phabricator.wikimedia.org/T108059) (owner: Ejegg) [18:32:33] (Merged) jenkins-bot: Catch specific exception in deleteLimboMessage [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229435 (https://phabricator.wikimedia.org/T108059) (owner: Ejegg) [18:33:33] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Spike: Investigate AVS + CVV issues - https://phabricator.wikimedia.org/T108076#1511809 (awight) NEW [18:33:42] hey awight - id you have a minute, i'd love to pick your brain about the cvv thign IRL [18:33:51] just to... clarify. i think i understand but trying to translate :) [18:33:52] atgo_: sure, this is a good time [18:33:59] k i'm at the lunch table :) [18:52:47] hey MBeat [18:52:55] howdy [18:53:17] so you just hit the resend TY button in civi and this is what you got? [18:53:49] yes, I went to the contrib record in Civi and checked the Send TY email box, then save [18:53:55] weird. [18:54:24] ok so awight says "don't do that" [18:54:31] i figured! [18:54:49] we should either kill the box, or make it send the right TY [18:55:26] could you make a task for that? [18:55:45] agreed. and sure thing. [18:55:49] @dmv [18:55:54] Sux [18:56:06] ooh i was there for 3 hours yesterday! [18:56:18] D: [18:56:42] Getting plates for your genuine buddy? [18:57:57] yep! [18:57:59] the cutest. [19:16:47] (PS1) AndyRussG: Fix reference issue in Campaign::getCampaignMixins() [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229461 [19:17:47] (CR) jenkins-bot: [V: -1] Fix reference issue in Campaign::getCampaignMixins() [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229461 (owner: AndyRussG) [19:55:26] Wikimedia-Fundraising-CiviCRM: Civi Send Receipt? check box - review and filter what info it generates, or disable - https://phabricator.wikimedia.org/T108088#1512165 (Krenair) [20:00:43] (PS1) AndyRussG: KVStore: Various minor improvements [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229484 [20:08:13] (PS1) AndyRussG: Display: Improvement and fix in public bucket methods [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229488 [20:08:39] (CR) AndyRussG: "recheck" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229461 (owner: AndyRussG) [20:09:42] AndyRussG: do you think there'd be any utility in providing promises that resolve when the mixins run? when i run chooseandmaybedisplay followed by assertions, aren't i sort of gambling about order of execution? [20:10:15] cwdent: hmmm lemmesee [20:15:52] cwdent: you're right, because of the execution following the geoIP promises [20:16:16] I bet if you delete your geoIP cookie and turn off your network connection, the tests might have issues locally [20:17:26] oh, i was actually thinking about these mixin tests i'm writing now [20:17:31] It's an issue with all or most of the tests in that same file, though! Really we should do a setup thing to replace geoIP with a mock so a promise that's resolved already is what mw.geoIP.getPromise() returns [20:17:33] but the geoIP tests have a race condition too? [20:17:42] Potentially, yeah! [20:17:57] Isn't that the reson you were worried about order of execution? [20:18:16] ah actually no but you're probably right [20:18:24] Otherwise reallyChooseAndMaybeDisplay seems synchronous [20:18:31] at least in the part you're testing [20:18:41] i was thinking this: https://gerrit.wikimedia.org/r/#/c/229422/4/tests/qunit/subscribing/ext.centralNotice.display.tests.js [20:19:05] Yeah that's where I'm looking! [20:19:38] the assert at the end there...since the mixin handlers are callbacks, can't chooseAndMaybe potentially return before they execute? [20:19:42] Yeah let's dig into that to make sure we're not relying on flaky geoIP or other promise-related assumptions [20:20:57] cwdent: regarding this general concern ^ well, we are depending on an implementation detail of the mixing handling code [20:21:14] That wouldn't be OK for other non-test code outside the display RL module to do [20:21:58] But it is OK for a test of the display RL module. Tests are allowed to depend on some implementation details of the code under test. At least in my book ;) Often I think there's no way around it [20:22:27] Does that more or less get at what you were worried about? [20:23:30] what is the detail you're referring to? [20:25:43] err, i think i get it [20:26:52] chooseandmaybe calls runprebannerhooks in sync before handling canceled banners etc [20:27:04] i think that alleviates my concern [20:29:45] cwdent: yeah exactly. So we're allowed to take this into account when in tests, though it might be a violation of encapsulation for a mixing handler to do so [20:30:04] I do think the geoIP should be mocked in all the tests in that file, tho :) [20:30:15] could also be in a separate patch [20:30:36] cool cool, yeah you mean so it's not potentially breaking waiting for that promise [20:31:04] so i guess promises for the mixins would actually be a _bad_ idea because we're depending on synchronous behavior [20:31:36] comiiiing sorry [20:32:55] Fundraising Sprint The Pogues, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Footer images on payments missing - https://phabricator.wikimedia.org/T106728#1512284 (Jgreen) >>! In T106728#1486924, @Ejegg wrote: > weird, resources/assets/poweredby_mediawiki_88x31.png definitely e... [20:33:25] dstrine: one sec, coming... [20:36:55] Fundraising Sprint The Pogues, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Footer images on payments missing - https://phabricator.wikimedia.org/T106728#1512286 (Jgreen) looks better now ya? [20:50:20] ejegg: Hey, copy those links to vagrant/puppet/modules/payments/files/Main_Page.wiki ! [20:54:43] (PS1) AndyRussG: WIP Banner history logger campaign mixin [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229560 [20:55:47] (CR) jenkins-bot: [V: -1] WIP Banner history logger campaign mixin [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229560 (owner: AndyRussG) [21:05:19] (PS2) AndyRussG: WIP Banner history logger campaign mixin [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229560 (https://phabricator.wikimedia.org/T90918) [21:06:23] (CR) jenkins-bot: [V: -1] WIP Banner history logger campaign mixin [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229560 (https://phabricator.wikimedia.org/T90918) (owner: AndyRussG) [21:14:06] (PS3) AndyRussG: WIP Banner history logger campaign mixin [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229560 (https://phabricator.wikimedia.org/T90918) [21:17:13] Fundraising-Backlog: [EPIC] Amazon embedded internal test - https://phabricator.wikimedia.org/T108102#1512386 (DStrine) NEW [21:17:57] Fundraising-Backlog: [EPIC] Amazon (embedded) internal test - https://phabricator.wikimedia.org/T108102#1512400 (awight) [21:19:08] Fundraising-Backlog: [EPIC] Amazon embedded 1-hour test version - https://phabricator.wikimedia.org/T108106#1512420 (DStrine) NEW [21:20:39] Fundraising-Backlog: [EPIC] Amazon embedded campaign ready version - https://phabricator.wikimedia.org/T108109#1512442 (DStrine) NEW [21:28:03] Fundraising-Backlog: Spike: get Amazon authentication working with automatic redirect - https://phabricator.wikimedia.org/T108112#1512479 (Ejegg) NEW [21:31:42] Fundraising-Backlog: Create MW API method to sign Amazon requests - https://phabricator.wikimedia.org/T108113#1512496 (Ejegg) NEW [21:36:12] Fundraising-Backlog: Make Mustache form flexible enough to load custom js & widgets - https://phabricator.wikimedia.org/T108114#1512518 (Ejegg) NEW [21:38:38] Fundraising-Backlog: Implement Amazon wallet widget - https://phabricator.wikimedia.org/T108116#1512535 (Ejegg) NEW [21:42:38] Wikimedia-Fundraising-CiviCRM: Adding Anna Stillwell as a Steward. and Solicitor - https://phabricator.wikimedia.org/T108118#1512560 (astillwell) NEW a:atgo [21:43:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding Anna Stillwell as a Steward. and Solicitor - https://phabricator.wikimedia.org/T108118#1512568 (atgo) a:atgo>None [21:43:33] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding Anna Stillwell as a Steward. and Solicitor - https://phabricator.wikimedia.org/T108118#1512560 (atgo) thanks @astillwell - you did great. Just try to tag things with #fundraising-backlog, too :) [21:44:33] Fundraising-Backlog: Make Amazon API calls to set order details - https://phabricator.wikimedia.org/T108119#1512577 (Ejegg) NEW [21:45:46] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Make Amazon API calls to set order details and capture payment - https://phabricator.wikimedia.org/T108119#1512583 (Ejegg) [21:51:33] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Handle result of Amazon API calls - https://phabricator.wikimedia.org/T108123#1512622 (Ejegg) NEW [21:54:12] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Handle result of Amazon API calls - https://phabricator.wikimedia.org/T108123#1512653 (Ejegg) [21:54:15] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Make Amazon API calls to set order details and capture payment - https://phabricator.wikimedia.org/T108119#1512654 (Ejegg) [21:54:18] Fundraising-Backlog: Create MW API method to sign Amazon requests - https://phabricator.wikimedia.org/T108113#1512657 (Ejegg) [21:54:20] Fundraising-Backlog: Spike: get Amazon authentication working with automatic redirect - https://phabricator.wikimedia.org/T108112#1512658 (Ejegg) [21:54:22] Fundraising-Backlog: Implement Amazon wallet widget - https://phabricator.wikimedia.org/T108116#1512655 (Ejegg) [21:54:24] Fundraising-Backlog: Make Mustache form flexible enough to load custom js & widgets - https://phabricator.wikimedia.org/T108114#1512656 (Ejegg) [22:02:39] Fundraising-Backlog, Epic: [epic] Amazon upgrade - https://phabricator.wikimedia.org/T87625#1512678 (DStrine) [22:03:18] Fundraising Sprint The Pogues, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add Square to the list of gateways in the Gateway Reconciliation report - https://phabricator.wikimedia.org/T107224#1512682 (atgo) @ppena can you confirm this is taken care of? thanks! [22:03:23] Fundraising Sprint The Pogues, Fundraising-Backlog, Astropay Integration, Unplanned-Sprint-Work, Patch-For-Review: Expand Astropay audit to include Mexico - https://phabricator.wikimedia.org/T105906#1512684 (Ejegg) Open>Resolved [22:04:18] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Tech Backlog, and 4 others: Use the new queue wrapper for limbo, antimessage, and orphan slaying - https://phabricator.wikimedia.org/T92922#1512688 (DStrine) [22:04:21] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Tech Backlog, and 2 others: Stop writing to ActiveMQ once orphan slaying on Redis has been tested - https://phabricator.wikimedia.org/T99018#1512687 (DStrine) [22:04:24] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint The Pogues, and 4 others: Orphan slayer reads from frack Redis rather than ActiveMQ - https://phabricator.wikimedia.org/T99017#1512686 (DStrine) Open>Resolved [22:04:29] Fundraising Sprint The Pogues, Astropay Integration, Unplanned-Sprint-Work, Patch-For-Review: AstroPay adapter is spamming cc-limbo queue - https://phabricator.wikimedia.org/T107787#1512689 (Ejegg) Open>Resolved [22:04:43] Fundraising Sprint The Pogues, Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Log timing for each cURL attempt, not cumulative time - https://phabricator.wikimedia.org/T107539#1512693 (atgo) [22:04:46] Fundraising Sprint The Pogues, Fundraising-Backlog, Astropay Integration, Unplanned-Sprint-Work, Patch-For-Review: AstroPay adapter is spamming cc-limbo queue - https://phabricator.wikimedia.org/T107787#1512692 (atgo) [22:04:56] Fundraising Sprint The Pogues, Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, and 3 others: Eliminate PHP backend call for Special:RecordImpression - https://phabricator.wikimedia.org/T106624#1512698 (atgo) [22:06:21] Fundraising Sprint The Pogues, Fundraising-Backlog: Sprint P GOAL: scope amazon, major gifts import, and finish banner history! - https://phabricator.wikimedia.org/T102198#1512721 (DStrine) Open>Resolved [22:06:52] Fundraising Sprint The Pogues, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, Patch-For-Review: Log timing for each cURL attempt, not cumulative time - https://phabricator.wikimedia.org/T107539#1512724 (Ejegg) Open>Resolved [22:08:58] Fundraising-Backlog: Sprint Q Goal (midway through quarter): start amazon, astropay is campaign-ready, deploy banner history - https://phabricator.wikimedia.org/T104402#1512730 (atgo) [22:09:19] Fundraising-Backlog: Sprint Q Goal (midway through quarter): start amazon, astropay is campaign-ready, deploy banner history, kick PCI - https://phabricator.wikimedia.org/T104402#1415943 (atgo) [22:10:21] Fundraising Sprint The Pogues, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Make DonationInterface fatal errors accessible - https://phabricator.wikimedia.org/T107918#1512740 (DStrine) [22:11:20] Fundraising-Backlog: Spike: get Amazon authentication working with automatic redirect - https://phabricator.wikimedia.org/T108112#1512744 (DStrine) [22:12:54] atgo Yes! its done-thank you [22:14:41] Fundraising Sprint The Pogues, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add Square to the list of gateways in the Gateway Reconciliation report - https://phabricator.wikimedia.org/T107224#1512757 (Ppena) confirmed [22:18:36] Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Determine how to load CentralNotice RL modules and when to execute campaign and banner selection logic - https://phabricator.wikimedia.org/T106577#1512765 (AndyRussG) [22:18:39] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic: [epic] Banner History - https://phabricator.wikimedia.org/T78089#1512764 (AndyRussG) [22:22:59] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Make Amazon API calls to set order details and capture payment - https://phabricator.wikimedia.org/T108119#1512787 (Ejegg) [22:27:55] Fundraising Sprint Q, Fundraising-Backlog: Spike: get Amazon authentication working with automatic redirect - https://phabricator.wikimedia.org/T108112#1512800 (atgo) [22:27:56] Fundraising Sprint Q, Fundraising Sprint The Pogues, Fundraising-Backlog, Astropay Integration, and 3 others: AstroPay donors all sent to fail page - https://phabricator.wikimedia.org/T108059#1512801 (atgo) [22:27:59] Fundraising Sprint Q, Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: FailPage logic is all jacked up - https://phabricator.wikimedia.org/T108041#1512802 (atgo) [22:28:27] Fundraising Sprint Q, Fundraising-Backlog: Test coverage for CentralNotice refactor - https://phabricator.wikimedia.org/T108127#1512827 (cwdent) [22:35:39] Fundraising Sprint Q, Fundraising Sprint The Pogues, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add Square to the list of gateways in the Gateway Reconciliation report - https://phabricator.wikimedia.org/T107224#1512864 (atgo) Open>Resolved [22:35:46] Fundraising Sprint The Pogues, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add Square to the list of gateways in the Gateway Reconciliation report - https://phabricator.wikimedia.org/T107224#1490090 (atgo) [22:38:01] http://static.fjcdn.com/gifs/Skrillex+attacked+by+a+bee+silly+skrilly_052c5f_3057947.gif [22:38:55] Fundraising Tech Backlog: Review AVS setting for South Africa - re: Mastercard reenter transaction errors - https://phabricator.wikimedia.org/T108129#1512872 (MBeat33) NEW [22:43:01] https://commons.wikimedia.org/wiki/File:Hannover7909.jpg [22:48:46] https://phabricator.wikimedia.org/T108129 [22:53:51] (PS1) Cdentinger: WIP: Add postBannerMixinHook test. [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229595 [22:54:44] (CR) jenkins-bot: [V: -1] WIP: Add postBannerMixinHook test. [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229595 (owner: Cdentinger) [23:13:52] (PS2) Cdentinger: WIP: Add postBannerMixinHook test. [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229595 [23:29:13] !lastlog log [23:29:23] bah [23:57:56] Fundraising-Backlog, FR-Campaigns: Legal language entry in Translatewiki for LATAM - https://phabricator.wikimedia.org/T105142#1513251 (atgo)