[00:05:43] Fundraising research, Research-and-Data, Research management: P/T fundraising data analyst JD - https://phabricator.wikimedia.org/T107822#1505024 (DarTar) This has been approved, moving forward sourcing potential candidates. [01:21:04] Fundraising Sprint Queen, Fundraising Sprint The Pogues, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Footer images on payments missing - https://phabricator.wikimedia.org/T106728#1513441 (awight) Open>Resolved Thanks! [03:53:18] Fundraising Sprint The Pogues, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Footer images on payments missing - https://phabricator.wikimedia.org/T106728#1513557 (atgo) [08:53:56] TCB-Team-Fundraising-Sprint-2015-08-05, TCB-Team: [WMDE-Fundraising] Estimate effort: english donation pages and form - https://phabricator.wikimedia.org/T107258#1513863 (WMDE-leszek) a:WMDE-leszek [09:58:56] TCB-Team-Fundraising-Sprint-2015-07-29, Attribution-Generator, TCB-Team: [AG] When checking assets under public domain back button should be working - https://phabricator.wikimedia.org/T107264#1514042 (Tobi_WMDE_SW) [15:56:43] (CR) AndyRussG: "Nice!! :D" (1 comment) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229422 (owner: Cdentinger) [15:58:36] cwdent: hi! I had forgotten that geoIP and window.Geo were already mocked out in the display tests, so that's all good :) [15:58:59] good! [15:59:38] Also BTW dunno if you want to add in any other mixin handler tests in the same Gerrit change, or in a separate one... Whichever you prefer is great! [16:01:54] AndyRussG: yeah probably i can logically group like tests into patch sets [16:03:59] cool! I mean, whatever works for you, just thought I'd mention the idea... Apologies for the train-of-thought excessive verbage... [16:04:38] ha, not at all! in fact i think i'll smash those two patch sets together and abandon one of them [16:07:23] cwdent: oh which other patch set? [16:07:55] cwdent: ah no don't worry about it then! Heh, I hadn't even seen the other! [16:07:56] AndyRussG: https://gerrit.wikimedia.org/r/#/c/229595/ basically the same thing but for post [16:08:32] those could easily just be one that says "mixin tests" [16:08:34] cwdent: really I was just thinking out loud, since they're already two separate changes, pls don't worry about it 8p sorry about not seeing it also [16:09:01] np, nearly identical commit messages are confusing [16:11:12] (CR) AndyRussG: WIP: Add postBannerMixinHook test. (1 comment) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229595 (owner: Cdentinger) [16:11:55] rrrrg I'd say just ignore me and do what u you think is best 8p [16:13:31] AndyRussG: yeah that's a good idea, will also help me wrap my head around the different possible execution paths [16:13:49] btw i mean the comment, not ignoring you :) [16:14:08] heheh it's OK [16:17:27] Regarding Anne's astropay test email: how much monitoring do we really need to do for that? [16:18:02] this is to anyone ^^^ [16:20:37] dstrine: I can monitor. I do think we should... [16:20:51] 10 PDT, still? [16:22:03] Is the alternative to move the test? [16:25:44] hey awight dstrine - how about 11 for the test? [16:25:50] watch the logs during metrics? :) [16:26:34] heh [16:26:46] or we can wait until monday. i [16:26:55] am with dstrine on not doing it right during the mtg [16:27:10] 11 works for me, too. [16:27:30] I can multitask drooling at logs and staring at metrics [16:27:41] hehe [16:28:36] I'm off to chauffeur a bit, back for the meeting... [16:29:10] thanks for discussing! [16:32:34] hey dstrine - i'll do the sprint plan/summary email, yeah? [16:33:36] oh yeah I had not crossed my mind [16:33:40] cool, sounds good [16:33:43] i'm on it [16:48:07] atgo: I updated the dashboard panel in in phab [16:48:13] (PS5) Cdentinger: WIP: Add BannerMixinHook tests. [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229422 [16:48:21] Does anyone use the fr-tech test dash? [16:48:39] (Abandoned) Cdentinger: WIP: Add postBannerMixinHook test. [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229595 (owner: Cdentinger) [16:48:45] It usually takes me about an hour to switch the sprints [16:49:10] I'm just wondering if I need to keep doing it [16:49:24] (CR) jenkins-bot: [V: -1] WIP: Add BannerMixinHook tests. [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229422 (owner: Cdentinger) [16:50:48] (PS6) Cdentinger: WIP: Add BannerMixinHook tests. [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229422 [16:57:28] Fundraising-Backlog, Labs-Vagrant, MediaWiki-Vagrant: Make it easier to use the fundraising puppet role on labs - https://phabricator.wikimedia.org/T102304#1515045 (awight) p:Triage>Normal [16:58:25] thanks dstrine [16:59:03] hey the-wub! did you see jessica's email about timing for brazil test? [17:02:05] hey atgo-meeting, just replying now [17:02:35] ejegg: and AndyRussG: you free for a meeting? [17:02:36] K4-713 dstrine http://media.catmoji.com/post/cw2r/cat-loaf.jpg [17:03:00] aggh i am having such internet troubles. [17:28:18] thanks the-wub :) [17:43:10] AndyRussG: lost you! [17:53:42] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/229772 [17:54:01] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/229772 (owner: Ejegg) [17:55:04] (PS1) Addshore: Remove use of deprecated wfRunHooks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229777 [17:56:03] (PS1) Ejegg: Update DonationInterface for deploy [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/229781 [17:56:16] (CR) jenkins-bot: [V: -1] Update DonationInterface for deploy [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/229781 (owner: Ejegg) [18:00:12] (PS2) Ejegg: Update DonationInterface for deploy [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/229781 [18:02:05] dstrine-meeting: Thanks for taking the time to explain this stuff! [18:02:37] (CR) Ejegg: [C: 2] Update DonationInterface for deploy [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/229781 (owner: Ejegg) [18:03:18] lost you guys in the elevator [18:11:05] !log updated payments from a8c0ecbedef6179c78ed833da9f2049cb0f2641b to bbec5799db42f6f5302920a1a69123de7e4986df [18:11:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:14:06] (PS2) Ejegg: Deal with 'Could not make the deposit' AstroPay errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/228397 [18:14:45] If anybody's lurking here during metrics, ^^^^ would be nice to have for the AstroPay test that starts in a couple hours [18:15:53] sure i'll take a look [18:16:57] awight: for sure... and just to reiterate, there are pieces we could adopt... if we want. It's not a whole package. I definitely believe life is more "a la carte". [18:24:09] dstrine: yes! I think the philosphy is great, and I'm very happy to be part of experimenting with stuff that might help us... I think the question behind my complaints is really, "hey, I've been doing this process for a few years now and I don't think I'm getting any better. what's up" [18:28:08] awight: yeah totally [18:31:26] (CR) Cdentinger: [C: 2] Deal with 'Could not make the deposit' AstroPay errors (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/228397 (owner: Ejegg) [18:42:32] (Merged) jenkins-bot: Deal with 'Could not make the deposit' AstroPay errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/228397 (owner: Ejegg) [18:42:39] (CR) Jforrester: [C: 1] Remove use of deprecated wfRunHooks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229777 (owner: Addshore) [18:42:55] thanks cwdent ! [18:43:14] np! [18:47:42] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/229853 [18:50:33] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/229853 (owner: Ejegg) [18:53:36] (PS1) Ejegg: Update DonationInterface for deploy [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/229854 [18:54:16] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface for deploy [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/229854 (owner: Ejegg) [18:56:59] !log updated payments from bbec5799db42f6f5302920a1a69123de7e4986df to 5bc32b7d0969878e441394c828620d5a44683c18 [18:57:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [19:18:54] Fundraising-Backlog: GeoIP cookie causing country=XX when I load donate page - https://phabricator.wikimedia.org/T107957#1515561 (atgo) @ccogdill_WMF this happens to me sometimes, too, but I think we're pretty sure this is an issue only for us. We've investigated a few times. If you hear of other reports of... [19:24:03] Fundraising-Backlog: GeoIP cookie causing country=XX when I load donate page - https://phabricator.wikimedia.org/T107957#1515575 (atgo) Open>declined a:atgo [19:24:11] Fundraising-Backlog: GeoIP cookie causing country=XX when I load donate page - https://phabricator.wikimedia.org/T107957#1515577 (atgo) Argh I can't find the task for the last time we looked at this, but I swear it happened :P [19:29:24] Fundraising-Backlog: GeoIP cookie causing country=XX when I load donate page - https://phabricator.wikimedia.org/T107957#1515617 (awight) Our donors wouldn't know that they're getting country=XX, right? I think we should look at the apache logs for payments1001-3 and get a quick count on how many times this... [19:35:17] Fundraising-Backlog: GeoIP cookie causing country=XX when I load donate page - https://phabricator.wikimedia.org/T107957#1515643 (atgo) Found some breadcrumbs from the last time: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2209 It was a real problem, and then we fixed it, and... [19:38:18] Fundraising-Backlog: GeoIP cookie causing country=XX when I load donate page - https://phabricator.wikimedia.org/T107957#1515647 (awight) Just to clarify, none of my patches "fixed it", they were just cleaning up some things that were obviously sketchy. I'm sure we never actually solved the issue. There wa... [19:38:58] (PS3) Awight: Remove legacy STOMP code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229079 (https://phabricator.wikimedia.org/T99018) [19:39:14] (PS4) Awight: Remove legacy STOMP code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229079 (https://phabricator.wikimedia.org/T99018) [19:40:56] Fundraising Sprint Queen, Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, and 3 others: Stop writing to ActiveMQ once orphan slaying on Redis has been tested - https://phabricator.wikimedia.org/T99018#1515652 (awight) Adding this to the sprint as a backg... [19:41:45] Jeff_Green: no rush, but this is waiting for you to review: https://phabricator.wikimedia.org/T107918 [19:42:32] hmmm [19:42:41] i don't understand the question there [19:43:16] "Will it be easy to sync this file into the shared directory?" [19:43:18] what does that mean? [19:43:29] It looks like we can split out the exception and error-level messages so they aren't logged to the mw/debug file [19:43:50] I don't know how it will behave if we point two streams at the same file [19:44:11] And I don't know how the file replication is set up--should we point it to /var/log/fundraising ? [19:44:27] err, should we have MediaWiki log to that other directory? [19:44:32] we can't point two streams at the same file [19:44:39] Jesus, I don't quite understand what I was asking, either [19:44:47] ha [19:44:49] that's funny :) [19:45:01] :( [19:45:28] "can you confirm this is useful" should actually just result in the person writing such a thing being fired. [19:45:42] ha [19:46:00] or perhaps the answer should be in the form of an obfuscating question [19:46:31] can mediawiki or the extension use syslog? [19:46:34] lemme look at the main cluster logs, cos... I'm mostly worried that we might not get timestamps [19:46:42] I don't think so. [19:46:45] POS by design [19:47:08] sigh [19:47:46] maybe we need a sane logging extension :-) [19:47:57] Check out fluorine:/a/mw-log/exception.log [19:48:01] want. [19:48:19] Also want fatal.log [19:49:31] well there are 162 defunct udp2log processes there :-) [19:49:53] Fundraising Sprint Queen, Fundraising Sprint The Pogues, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Make DonationInterface fatal errors accessible - https://phabricator.wikimedia.org/T107918#1515680 (awight) Trying to rephrase my earlier comment to say something not insa... [19:50:07] wat [19:50:36] omg some of those files are >80GB [19:50:49] i am 49% confident what I'm seeing here will make me want to poke sticks in my eyes [19:51:49] I think $wgDebugLogGroups is the key, and I can configure that no problem. I just need to know * where to put the files and * how to get the freaking timestamps [19:52:19] I do wish we could write to syslog. But that's an enterprise feature, we can't afford [19:52:22] well [19:52:26] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi Send Receipt? check box - review and filter what info it generates, or disable - https://phabricator.wikimedia.org/T108088#1515685 (atgo) thanks for adding the project, @krenair. @mbeat33 please associated at least #fundraising-backlog with ticket... [19:52:47] ok so, as far as I can tell (and I am by no means expert on this) we are using udp2log to catch output from mw [19:52:56] * awight cringes [19:53:05] lemme see if I can find documentation [19:53:14] That sure does seem to be the case on the cluster [19:53:22] judging by owner [19:53:32] but why? [19:53:32] fwiw, https://wikitech.wikimedia.org/wiki/Logs [19:53:36] WHHHHYYYYYY. [19:53:42] cos, there are many nodes? [19:53:53] it's like syslog for dummies [19:54:03] I fail to understand [19:54:12] i mean maybe I understand, but I fail to agree with the line of thinking [19:54:17] https://wikitech.wikimedia.org/wiki/MediaWiki_UDP_logging [19:54:49] You know. I'd be happy changing this fubar code to write to syslog, it's not hard. [19:55:03] i mean 10 years ago we were doing this at scale with syslog-ng or whatever [19:55:04] Then another fr-tech can merge and we'll sail off to a happy island [19:55:15] you don't like dropping packets? [19:55:31] you can drop packets just great with syslog if you want :-) [19:56:02] hehe, okay I'm on board. [19:56:50] We can set this aside and just stew on how to do it without all committing seppuku [19:56:51] Hi ejegg! [19:57:13] hey jes [19:57:15] jessicarobell: [19:57:16] :P [19:57:20] banners are set to go up in BR in 3 minutes [19:57:29] hi atgo! :) [19:57:44] hi jessicarobell [19:57:47] ah great! heads up awight cwdent dstrine XenoRyet AndyRussG [19:57:54] ok, i'm looking at the logs! [19:58:10] excite [19:58:11] thanks guys! :) [19:58:12] atgo: ? [19:58:17] awight it would be fantastic if we could fix mediawiki to optionally spew syslog protocol where it spews udp2log protocol [19:58:46] you'd hope that there would be a single place to shim that into the code, but what do I know [19:58:58] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi Send Receipt? check box - review and filter what info it generates, or disable - https://phabricator.wikimedia.org/T108088#1515719 (MBeat33) Sorry, @atgo, will do. [19:58:59] Jeff_Green: One more sharp stick to sit on... we're suddenly unblocked to replace silicon:ActiveMQ with Redis. When would you be up for trying this? Next January maybe? [19:59:01] other than that, it's pretty much log-stays-on-box or variants of seppuku [19:59:36] January sounds good yeah [19:59:38] Jeff_Green: I could live with four error log files, one for each node. For now. [19:59:41] k [20:00:47] awight so basically you're asking for a hackjob to fetch them nightly to somewhere [20:01:13] where we have realtime delivery if only the application can spew a sane protocol [20:01:33] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Tech Backlog, and 4 others: Use the new queue wrapper for limbo, antimessage, and orphan slaying - https://phabricator.wikimedia.org/T92922#1515738 (awight) Open>Resolved [20:01:43] OK, banners are up in BR! atgo awight cwdent dstrine XenoRyet AndyRussG [20:02:25] ejegg: ^ [20:02:50] nice, waiting for the first hit on the logs [20:02:59] cool! [20:04:16] Fundraising-Backlog, fundraising-tech-ops: Replace ActiveMQ donation queues with Redis - https://phabricator.wikimedia.org/T108229#1515750 (awight) NEW [20:04:48] Jeff_Green: I see. yeah, nightly isn't useful [20:04:57] Lemme look into syslogging from MW [20:05:38] or even just bypassing udp2log and letting it go through the apache or php logging mechanisms, both of which can spew syslog [20:05:53] actually they both do already, and they're centralized [20:10:13] Fundraising Sprint Queen, Fundraising Sprint The Pogues, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Make DonationInterface fatal errors accessible - https://phabricator.wikimedia.org/T107918#1515795 (Jgreen) Right now they're either syslogged-and-centralized (apache err... [20:11:14] jessicarobell: I think we're getting lowercase currency codes from somewhere, which is confusing the form chooser. [20:12:00] hmmm not sure what that means ejegg, a bad sign I guess? [20:12:11] seeing a bunch of different utm_sources, so not sure if it's a banner thing [20:13:08] Should be really easy to deal with that on the receiving end though [20:13:23] Ok, sorry I not very skilled on the technical parts of these banners.. let me know if I should be taking campaigns down ejegg. I can see donations coming in on my end [20:13:36] no, it's a small percentage of donors [20:15:12] ok! [20:17:48] awight: this looks almost relevant https://gerrit.wikimedia.org/r/#/c/190231/ possibly maybe? [20:42:31] Jeff_Green: good find! [20:43:08] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Normalize currency_code to uppercase - https://phabricator.wikimedia.org/T108242#1515982 (Ejegg) NEW a:Ejegg [20:44:18] ejegg how is the BR test looking so far on your end? [20:44:37] jessicarobell: so far so good [20:44:45] getting way better response times from AstroPay! [20:45:06] most under a second, and the longest was less than 4 sec [20:45:30] that's great news! [20:46:51] ejegg: You wanna put the cement shoes on that legacy STOMP code? https://gerrit.wikimedia.org/r/#/c/229079/ [20:47:02] are we OK to keep this test going for a while, to get more data over a longer period of time? We would ideally like to keep the test going for a 24 hour cycle. do you think we are ready for that? [20:47:04] awight: sounds good! [20:47:17] jessicarobell: yeah, we can definitely keep it up for a while [20:49:03] So, those donors with lowercase 'brl' for whatever reason are shown an error message and asked to edit their amount and select a currency code. The fix is really easy, but deploying might skew subsequent success rates upward relative to before the fix. [20:49:16] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Normalize currency_code to uppercase - https://phabricator.wikimedia.org/T108242#1516006 (atgo) Is this related to Astropay? [20:49:20] great ejgg. So I will set it to go down at 1pm PST tomorrow. Could you guys keep an eye on the logs for the next couple of hours and take the campaigns down if something looks off? cc: atgo [20:49:53] (PS1) Ejegg: Normalize currency_code to uppercase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229948 (https://phabricator.wikimedia.org/T108242) [20:50:16] (CR) jenkins-bot: [V: -1] Normalize currency_code to uppercase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229948 (https://phabricator.wikimedia.org/T108242) (owner: Ejegg) [20:52:40] (PS2) Ejegg: Normalize currency_code to uppercase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229948 (https://phabricator.wikimedia.org/T108242) [20:52:57] jessicarobell: OK with us deploying that fix mid-test? [20:54:08] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Normalize currency_code to uppercase - https://phabricator.wikimedia.org/T108242#1516011 (Ejegg) Yep @atgo, it's the main reason for those ffname errors. [20:56:47] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Normalize currency_code to uppercase - https://phabricator.wikimedia.org/T108242#1516013 (atgo) [20:56:50] Fundraising Tech Backlog, Fundraising-Backlog, Astropay Integration: Diagnose AstroPay ffname errors - https://phabricator.wikimedia.org/T106050#1516012 (atgo) [20:57:20] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Normalize currency_code to uppercase - https://phabricator.wikimedia.org/T108242#1515982 (atgo) Awesome. Should we pull this into sprint? [20:58:32] Fundraising Sprint Queen, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Normalize currency_code to uppercase - https://phabricator.wikimedia.org/T108242#1516020 (Ejegg) Might as well - the code's already written! [21:02:27] ejegg, do we risk breaking anything deploying the fix mid-test? You are a better person to make that call that I am.. :) [21:02:52] jessicarobell: Very low risk of breakage! [21:03:19] OK, I say go ahead then. Thanks! [21:04:47] AndyRussG: i'm trying to find a good way to get a test to not find a banner so i can test the post hooks in that instance. i've tried unsetting the test data banners as well as setting their devices to an invalid value but neither seem to work. do you have some insight on that? [21:05:11] Fundraising Tech Backlog, Fundraising-Backlog, Astropay Integration: Diagnose AstroPay ffname errors - https://phabricator.wikimedia.org/T106050#1516040 (Ejegg) Most of them were due to lowercase currency codes coming in (T108242) , but another set are from mismatched payment method and submethod. T... [21:05:15] cwdent: ah heh that's a silly edge case, yeah [21:05:21] ty jessicarobell [21:05:38] PPena mhernandez do you have a minute? [21:06:21] jessicarobell on a call now, can join in a few minute [21:06:38] thanks, no problem [21:07:22] cwdent: one case is a campaign that has two buckets, and each bucket has a banner targeting one device. The banner in one bucket is for the device the user is on, but the user is in the other bucket. [21:07:28] Fundraising Sprint Queen, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, Patch-For-Review: Normalize currency_code to uppercase - https://phabricator.wikimedia.org/T108242#1516061 (atgo) [21:08:15] AndyRussG: aah ok, can i specify which bucket i'm in? [21:08:49] cwdent: Since the campaign includes banners for the device the user is on, it is not eliminated in the first pass filter, and can get selected. Only after a campaign is selected do we get the bucket for that campaign, which happens to be the one with no banners for the user's device [21:09:17] cwdent: yeah! There's a method on mw.centralNotice just for that :) [21:09:33] ok, so the reason my previous approaches wouldn't work is no campaign gets selected at all if it doesn't look like there's a possible banner? [21:10:11] Yeah! Normally all the banners in a campaign have the same device assignements, so in those cases we just write of the campaign in the first pass [21:10:46] ok great that clears that up, thanks! [21:10:57] cwdent: BTW make your patch follow on my mini bucket improvements patch: https://gerrit.wikimedia.org/r/#/c/229488/ [21:11:02] yw! [21:25:18] jessicarobell im free [21:25:33] jessicarobell how can i help? [21:25:36] hey PPena. Thanks! [21:26:24] looks like we are not seeing many errors in the BR test, just wanted to double check with you that you are OK keeping the test up for a couple of hours, to get more data on the ask string [21:26:36] jessicarobell oh I see [21:26:42] hey jessicarobell ejegg just getting caught up on the fix question. let me know if i can help at all :) [21:26:50] sure let me triple check with Astro, but AFAIK all looks good [21:26:55] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Reset payment submethod on payment method switch - https://phabricator.wikimedia.org/T108248#1516138 (Ejegg) NEW [21:27:37] hi atgo, thanks for the offer! [21:28:05] thanks atgo! ejegg, are we seeing any other issues so far? [21:28:40] jessicarobell: nope, that looks like the only one affecting the donation experience! [21:30:39] cwdent / XenoRyet : want to peek at another tiny DonationInterface fix? Just uppercasing the currency code on the way in: https://gerrit.wikimedia.org/r/229948 [21:31:23] that sounds good, ejegg! To be sure I got this right, donors who use lowercase letters in the form get an error, is that right? [21:31:40] jessicarobell if ejegg says all is well, I say leave it up (campaign) and go to sleep! ;) [21:31:55] catching up on the thread abt this bug [21:32:21] jessicarobell: no, it's something in our pipeline between the banner and the form on payments setting a lowercase currency code for some reason [21:32:54] it's happening for a bunch of different banner names, so maybe it's a script that a few of them share [21:33:13] (CR) XenoRyet: [C: 2] Normalize currency_code to uppercase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229948 (https://phabricator.wikimedia.org/T108242) (owner: Ejegg) [21:33:18] thanks XenoRyet ! [21:33:22] No worries [21:33:43] hey guys - i'm going to run an errand. be back in a bit! [21:33:47] seeya atgo-errand [21:34:00] ejegg is the bug being fixed now/was it already fixed/ [21:34:02] ? [21:34:55] PPena: XenoRyet just gave a positive review to a patch that lets us accept the lowercase, so it'll be ready to deploy within minutes [21:35:06] ejegg cool [21:35:21] thanks ejegg [21:37:58] jessicarobell go to sleep! [21:38:00] Fundraising Tech Backlog, Fundraising-Backlog, Astropay Integration: Diagnose AstroPay ffname errors - https://phabricator.wikimedia.org/T106050#1516191 (Ejegg) [21:39:26] haha. I will PPena :) thanks. ejegg: I will leave the campaigns up to get some more data, and check in on the tests again UTC morning. If anything looks bad, feel free to take the campaigns down in Central Notice. thank you! [21:39:39] good night jessicarobell ! [21:39:44] jessicarobell goo night! [21:39:50] good night! :) [21:41:10] (Merged) jenkins-bot: Normalize currency_code to uppercase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229948 (https://phabricator.wikimedia.org/T108242) (owner: Ejegg) [21:42:31] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/229964 [21:42:50] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/229964 (owner: Ejegg) [21:44:52] (PS1) Ejegg: Update DonationInterface for deploy [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/229966 [21:45:07] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface for deploy [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/229966 (owner: Ejegg) [21:46:35] !log updated payments from 5bc32b7d0969878e441394c828620d5a44683c18 to af16d371f9c46d4f0b78986080f2a2be3226ace8 [21:46:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:51:32] "For the Minuteman ICBM force, the US Air Force's Strategic Air Command worried that in times of need the codes would not be available, so they quietly decided to set them to 00000000. The missile launch checklists included an item confirming this combination until 1977." [21:52:02] Holy crap [21:55:19] Fundraising Sprint Queen, Fundraising Sprint The Pogues, Fundraising-Backlog, Astropay Integration, and 3 others: AstroPay donors all sent to fail page - https://phabricator.wikimedia.org/T108059#1516272 (Ejegg) Open>Resolved [21:56:57] Fundraising Tech Backlog, Fundraising-Backlog, Astropay Integration: Diagnose AstroPay ffname errors - https://phabricator.wikimedia.org/T106050#1516279 (Ejegg) [21:56:58] Fundraising Sprint Queen, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, Patch-For-Review: Normalize currency_code to uppercase - https://phabricator.wikimedia.org/T108242#1516277 (Ejegg) Open>Resolved [21:59:15] awight: did you tell me about Roger Fisher? "He proposed a volunteer with the launch codes implanted in a little capsule near his heart. The president would have a big butcher knife in the satchel, or football, where the launch codes are kept now," [22:00:26] Fisher confirmed that he once presented this idea at the Pentagon. "They said, 'You can't do this; it would distort the president's judgment!'" [22:01:07] I have heard that story as well [22:01:40] tell that to those guys that scuba dived under chernobyl to save millions of lives [22:01:48] and then died agonizing deaths from radiation poisoning [22:01:51] mutually assured destruction was favored over that [22:06:52] The butcher protocol is such a great idea! Like the naked caveman circus between world leaders in All quiet on the western front--you like bloodshed? You go ahead and see how that works out for u, meanwhile all your the erstwhile cannon fodder is gonna stay at home and fahkin' compose piano music or something. [22:21:58] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: WMF's Fundraising Banner for 2015 is ridiculously big - https://phabricator.wikimedia.org/T108256#1516394 (He7d3r) NEW [22:25:29] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice: WMF's Fundraising Banner for 2015 is ridiculously big - https://phabricator.wikimedia.org/T108256#1516416 (atgo) [22:28:17] Fundraising-Backlog: GeoIP cookie causing country=XX when I load donate page - https://phabricator.wikimedia.org/T107957#1516431 (AndyRussG) Interesting that the cookie in the image says 'v6' for type of IP address. When geo info is not available for a user with an IPv6 address, the geoIP code in CentralNoti... [22:29:24] (PS1) Awight: WIP Provide a method to peek at the top of a queue [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/229987 [22:29:30] gotta run [22:30:23] Fundraising research, Analytics-Backlog, Research-and-Data: What's our projected ability to fundraise in the coming years - https://phabricator.wikimedia.org/T107606#1516444 (DarTar) a:ellery [22:36:36] Fundraising research, Research-and-Data: Scope donor contribution campaign test - https://phabricator.wikimedia.org/T104652#1516457 (leila) I am interested in this if Wikidata contributions are considered. [22:38:40] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Accessibility, Browser-Support-Firefox: Can't see or click login button due to fundraising banner - https://phabricator.wikimedia.org/T74013#1516471 (He7d3r) [23:04:26] (CR) Ejegg: [C: -1] "Great to see this stuff go the way of the dodo! There's a little bit more that should probably be excised at the same time." (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229079 (https://phabricator.wikimedia.org/T99018) (owner: Awight) [23:09:26] AndyRussG: this seems so weird. simply setting the campaign bucket_count to 2 triggers no banner. but i'm logging the chosen bucket and it says 1. [23:10:16] cwdent: hmmm where did you set it, and where are you logging it? [23:12:34] in the test i said: mw.centralNotice.choiceData[0].bucket_count = 2; [23:12:52] and i logged it right after bucketer.process() [23:13:17] it says 1, but the postbanner mixin still fires [23:13:45] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice: Use CSS instead of obsolete HTML attributes on CentralNotice tables - https://phabricator.wikimedia.org/T108259#1516638 (atgo) [23:24:37] cwdent: that's correct! The postBannerMixin is supposed to fire in that case. In the mixin handler, you can check that mw.centralNotice.data.status === mw.centralNotice.interal.state.STATUSES.NO_BANNER_AVAILABLE [23:24:58] AndyRussG: however if i log the campaign immediately after setting bucket_count to 2, it says 1! [23:25:04] am i crazy? or just mislead [23:25:20] Heh if misled it's surely my fault :( [23:25:37] oh i didn't mean like that [23:25:42] just...pulling on the wrong string [23:25:44] heh np ;p [23:25:49] jk [23:26:11] what do you log after setting bucket_count to 2 [23:26:12] ? [23:26:29] like this: [23:26:32] cwdent: is ur code up on Gerrit? [23:26:33] >--->---mw.centralNotice.choiceData[0].bucket_count = 2; [23:26:35] >--->---console.log( mw.centralNotice.choiceData[0] ); [23:26:51] this isn't quite yet, i have a ton of stuff commented out to isolate this particular test [23:27:59] that console log says bucket_count = 1 [23:29:50] cwdent: hmmm no idea what's going on there... BTW in case it's not so, really the bucket count should already be there in the test data set, shouldn't have to set it per se [23:30:06] (except in the declaration of the choiceData used for the test) [23:30:25] ah yeah i was kicking around making a new test data set [23:30:28] that's probably a better idea [23:31:59] yeah it'd be quite odd if that didn't work [23:32:14] Though really I have no idea where the above switch is coming from 8p [23:33:26] AndyRussG: well now i don't know what i'm looking at: http://i.imgur.com/Low3BL2.png [23:33:52] in the object summary it says the correct buckets but when i open it up it shows how it was initialized [23:34:46] cwdent: heh looks like a chrome dev tools object caching ishyew! [23:35:02] I just tried stuff in FF (Iceweasel) and it's all good [23:35:10] oh geez [23:35:20] now that's misleading [23:35:30] heh so you are misled! [23:36:41] AndyRussG: the part i still don't understand is why just setting the buckets to 2 causes no banner, even without making an invalid banner or reassigning them to new buckets [23:37:07] cwdent: ah hmm [23:37:22] not sure about the details, though not first that bucket numbers start at 0 [23:38:00] If the user is on bucket 1 and there's no banner at all, that will indeed cause no banner! It's another even more annoying edge case, though for that one there's even a warning in the UI to avoid people doing it.... [23:38:23] I mean, if the user is on bucket 1 and there's no banner for bucket 1 [23:39:11] cwdent: gotta dash! I'll leave this on and will get backscroll, though, and should be back in less than an hour:) [23:48:55] I'm going to run. Seeya tomorrow [23:51:32] (PS7) Cdentinger: WIP: Add BannerMixinHook tests. [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229422 [23:54:01] sounds good AndyRussG|souper, i'm gonna sign off for now, but i just pushed a PS you could take a look at if you get bored. i'm pretty sure that situation should just get modeled in test data but the current code poses a question. have a good night, and thanks again for your guidance!