[01:04:22] * K4-713 yawns [01:48:38] marktraceur: I just found the Thai Food archive. [03:40:46] (PS2) AndyRussG: WIP Banner history logger: minify and cutoff for EL data [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/231060 [03:41:57] (CR) jenkins-bot: [V: -1] WIP Banner history logger: minify and cutoff for EL data [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/231060 (owner: AndyRussG) [03:44:20] (PS3) AndyRussG: WIP Banner history logger: minify and cutoff for EL data [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/231060 [03:58:55] It has suffered. [06:39:35] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Convert CentralNotice to use extension registration - https://phabricator.wikimedia.org/T108721#1533987 (Legoktm) [06:39:44] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Convert DonationInterface to use extension registration - https://phabricator.wikimedia.org/T108763#1533988 (Legoktm) [06:39:51] Fundraising Tech Backlog: Convert DonationEmailUnsubscribe to use extension registration - https://phabricator.wikimedia.org/T108764#1533989 (Legoktm) [16:02:05] (CR) Ejegg: [C: 2] "Looks like a clean removal! Minus 1500 LOC ought to be up there on the leaderboard..." (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229079 (https://phabricator.wikimedia.org/T99018) (owner: Awight) [16:05:40] (Merged) jenkins-bot: Remove legacy STOMP code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229079 (https://phabricator.wikimedia.org/T99018) (owner: Awight) [16:10:16] Wikimedia-Fundraising: Javascript error on Thank You page: $ is not defined - https://phabricator.wikimedia.org/T108882#1535503 (Pcoombe) Open>Resolved Fixed, and also on older pages like https://wikimediafoundation.org/wiki/Thank_You/es [16:24:17] Wikimedia-Fundraising: Javascript error on Ways to Give: $ is not defined - https://phabricator.wikimedia.org/T108883#1535623 (Pcoombe) Open>Resolved [16:32:22] (PS4) AndyRussG: WIP Banner history logger: minify and cutoff for EL data [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/231060 [16:33:32] (CR) jenkins-bot: [V: -1] WIP Banner history logger: minify and cutoff for EL data [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/231060 (owner: AndyRussG) [16:35:02] * AndyRussG waves [16:35:13] howdy [16:35:22] cwdent: morning! [16:35:52] cwdent: dstrine: ejegg: apologies again for missing chicken shrimp yesterday... How did it go? [16:36:22] Pretty well - we sorted out a whole lot of cards for the rest of the quarter [16:36:37] yep it was productive [16:36:40] ah fantastic [16:36:56] yea really sorry about missing that :/ [16:38:02] no worries here! [16:38:06] patch is looking good [16:39:05] ejegg: i started looking at this https://phabricator.wikimedia.org/T105730 <-- would be supplemental to the DI gateway right? not the crm audit import [16:39:27] cwdent: yep, donationinterface all the way [16:40:23] cwdent: ah thx! yeah still a few more details to work out, the calculation was working for the encodeURI length I get for the JSON'd log on the console, but now it seems in the actual URL encoding is a bit different (commas and colons also encoded...) [16:40:38] AndyRussG: thanks for the note. I think we're just eager to hear the next steps in banner history. I'm sorry it's way too technical for me. I may just peek into those conversations if they get too quiet for too long [16:41:06] EL or something is actually throwing an error when the URL is too long, which seems good! [16:41:58] dstrine: yeah I imagine, that's one reason I was worried about not being able to be there :( [16:42:34] yeah we just went on to teh backlog and did other stuff [16:42:51] AndyRussG: i was kicking around all kinds of ways to compress the data in my head, but what do you think the odds are that this will be a permanent solution? guessing ideally kafka is going to make splitting up packages easy [16:42:51] I think another hangout with just FR-tech would be useful. Though first we need a couple more answers from Ellery [16:43:36] Fundraising Sprint Queen, Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Fix cheesiness: be more transactional when popping messages from the limbo queue - https://phabricator.wikimedia.org/T107852#1535747 (Ejegg) Sorry @awight, I... [16:43:57] highlevel summary from yesterday: the column "Sprint +3" is actually the end of the quarter. The 3 sprint columns should be able to tell us what is left to finish. https://phabricator.wikimedia.org/tag/fundraising-backlog [16:44:45] cwdent: I feel like we should take Analytics up on their offer to prioritize the EventLogging paylod limitation bug. Since EL does indeed handle nested structures, then if that's fixed, it's a fine solution I think [16:45:18] cool, so hopefully the necessity to compress the data is temporary [16:45:19] cwdent: or at least, it leaves the ball in Analytics's court to make something that scales up more, if that doesn't [16:45:32] cwdent: yeah! I think so [16:45:37] although even if they lift the limit, i'm not sure how big you want to go with a URL [16:46:08] i saw my old boss stick about 1MB in there and it "worked" [16:46:14] Mmmm I think lifting the limit will involve moving to POST [16:46:27] ah yes that would be good [16:49:27] dstrine: cwdent: ejegg: maybe the sequence of stuff to do could go like this: 1) checking that Ellery is OK starting out with only 8-10 log entries (that estimate seems to check out so far) and removing all those fields, 2) finding out how soon Analytics can fix the payload limit bug if they prioritize it, 3) having a meeting FR-tech to agree on the solution [16:50:08] sounds reasonable [16:50:37] Also I feel like awight still might favor the other solution of a big-ish series of EL calls, so I'd like to make sure to understand his thinking and that we take it into account [16:51:33] dstrine: also if you like I could meet with you anytime to explain more details about this and answer any questions u have :) [16:51:36] i think ellery made a good point that if we start storing a client side ID a lot of this becomes redundant [16:51:55] basically this is a huge workaround to respect DNT [16:51:59] cwdent: heh, actually I wanted to address that 'cause it's not quite true [16:52:26] oh yeah? i'm just a hippie about that stuff [16:52:51] heh I mean, I would still favor workarounds to respect DNT... [16:53:04] but all the work we've done on the banner history track was also necessary to turn off Special:RecordImpression [16:53:58] It's true that if there were already a global client-side unique ID in place, they could have gotten banner history right away through Special:RecordImpression. But it is definitely necessary to turn that off, and after that point, they'd still need something like what we're building [16:54:58] The reason being that the calls to Special:BannerLoader, which is what will replace Special:RecordImpression, only will be able to track actual banner displays [16:55:11] but in banner history they also want to track banner hides and the reasons for them [16:55:43] AndyRussG: we could just check in at standup. As scrum master I'm objective and not a part of choosing a path. I just make sure we have a path [16:55:46] and you can't get that from Special:BannerLoader [16:56:26] dstrine: sure! I mean, in any case, maybe it would help you in that role to have some more details about all this, though? [16:57:18] might help you to detect when we're getting closer or further from a path, or moderate meetings to help build consensus? [17:00:26] * AndyRussG waves at XenoRyet [17:00:33] arggh, bassoon! [17:00:36] Hi [17:00:55] XenoRyet: :) [17:01:00] (PS1) Ejegg: Fix orphan loop, remove 'antimessage' references [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231304 (https://phabricator.wikimedia.org/T99018) [17:02:51] (PS1) Ejegg: Stop fetching fields twice in message creation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231306 [17:03:59] morning atgo, awight [17:04:01] hi awight! [17:04:14] hiii [17:04:19] awight: atgo: apologies again for missing chikin' yesterday [17:04:23] morrrnoon [17:04:24] guys i'm becoming a free parking ninja [17:04:26] awight, this may interest you: https://gerrit.wikimedia.org/r/231304 [17:04:33] no worries, we made a lot of decisions for you [17:04:38] :p j/k [17:04:40] awight: fantastic :) [17:04:45] i think 1/4 of my commute time is me finding free parking [17:04:53] atgo: aww [17:05:10] atgo: your superpower is emerging! [17:06:08] atgo: should parking a scooter be easy? [17:06:19] it IS easy! [17:06:22] but there are still meters here [17:06:29] at least there are day-long meters for motos [17:06:48] yeah i got a parking ticket on my bike the other week in boulder :-\ [17:06:52] so you can pay $7/day (ouch) or you can sneak around until you find a tiny place that you can wedge a moto in that doesn't have a meter [17:07:04] awight: we were just talking about banner history and EL... I was gonna suggest meeting up sometime soon to talk about all this, maybe after but maybe before Ellery lets us know his minimum for history log entries and log properties... I was just about to run off but... will u be around a little later today? [17:07:09] YEAH i got a $68 ticket for street cleaning in front of my house on Monday! arrrrrggghh [17:07:37] atgo: argh I hate those! I got that the week I got back from Mexico 'cause I hadn' adjusted my time zone yet [17:08:16] have we covered what the icinga alerts were all about? anything i should worry about Jeff_Green? [17:09:07] (CR) Awight: [C: 2] "grep -r antimessage || echo "Saaafe!"" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231304 (https://phabricator.wikimedia.org/T99018) (owner: Ejegg) [17:09:16] awight: I want to make sure I'm not being stupidly even stubborner than usual, got the sense you have more to say about the EL stuff? [17:09:31] (Merged) jenkins-bot: Fix orphan loop, remove 'antimessage' references [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231304 (https://phabricator.wikimedia.org/T99018) (owner: Ejegg) [17:09:40] thanks awight ! [17:09:54] AndyRussG|bassoo: not at all... I totally trust your instincts on that. [17:10:10] awight: heh ah noooooooooooooo [17:10:26] thing that pissed me off is i was not taking up a parking space, i was at the end of the block where a car would not fit [17:10:34] My job is mostly to protect you from accidentally inheriting infrastructure [17:10:53] awight: heh yea good point :) [17:10:59] awight: you're around a bit later today? [17:11:47] or are u off half today / half tomorrow? [17:13:19] K really bassoon now! [17:14:58] AndyRussG|bassoo: yep, I'm around all day, and not tomorrow. I'll email that out... [17:15:22] atgo the alerts last night/early AM about globalcollect or did I miss something new? [17:15:27] awight: fanyastic thx! [17:15:31] Jeff_Green: middle of the night stuff [17:15:54] gcsip is globalcollect? [17:15:59] yeah [17:16:11] noted [17:16:15] awight: dunno if you saw my comment on T107852, but we're still not being very transactional with those orphan messages [17:16:16] that and mingraud [17:16:17] they were connectivity failures, looked like maybe 30 minutes? [17:16:20] ah ok [17:16:39] so we may have seen some donor failures around then? [17:16:48] ejegg: oh dear, looking now. And thanks for the thorough review! [17:17:05] concievable yeah, although what the tests test isn't always a perfect indication of what a donor sees [17:17:21] cool, thank you [17:17:33] (PS2) Ejegg: Log original GlobalCollect validation error [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231186 (https://phabricator.wikimedia.org/T107845) [17:19:02] XenoRyet: Tiny patch to review if you're looking for a distraction ^^ [17:19:31] Sure, I'll take a look [17:19:35] thanks! [17:26:18] (CR) XenoRyet: [C: 2] Log original GlobalCollect validation error [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231186 (https://phabricator.wikimedia.org/T107845) (owner: Ejegg) [17:26:38] ejegg: Looks good to me [17:26:39] (Merged) jenkins-bot: Log original GlobalCollect validation error [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231186 (https://phabricator.wikimedia.org/T107845) (owner: Ejegg) [17:33:26] kewl [17:34:52] (PS2) Awight: Fix reference issue in Campaign::getCampaignMixins() [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229461 (owner: AndyRussG) [17:35:11] (CR) Awight: [C: 2] Fix reference issue in Campaign::getCampaignMixins() [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229461 (owner: AndyRussG) [17:35:22] (PS2) Awight: KVStore: Various minor improvements [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229484 (owner: AndyRussG) [17:36:21] (Merged) jenkins-bot: Fix reference issue in Campaign::getCampaignMixins() [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229461 (owner: AndyRussG) [17:37:10] (CR) Awight: [C: 2] KVStore: Various minor improvements [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229484 (owner: AndyRussG) [17:37:17] (PS2) Awight: Display: Improvement and fix in public bucket methods [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229488 (owner: AndyRussG) [17:37:34] (CR) Awight: [C: 2] Display: Improvement and fix in public bucket methods [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229488 (owner: AndyRussG) [17:38:10] (Merged) jenkins-bot: KVStore: Various minor improvements [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229484 (owner: AndyRussG) [17:38:16] ejegg: https://gerrit.wikimedia.org/r/#/c/230706/ vs https://gerrit.wikimedia.org/r/#/c/230939/ ? [17:38:31] (PS7) Awight: Add payWithAmazon feature branch [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/228306 (owner: Ejegg) [17:38:33] (Merged) jenkins-bot: Display: Improvement and fix in public bucket methods [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229488 (owner: AndyRussG) [17:38:40] (CR) Awight: [C: 2] Add payWithAmazon feature branch [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/228306 (owner: Ejegg) [17:38:59] (PS6) Awight: Clear out old Amazon code to prepare for PwA [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230253 (https://phabricator.wikimedia.org/T108659) (owner: Ejegg) [17:39:05] (Merged) jenkins-bot: Add payWithAmazon feature branch [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/228306 (owner: Ejegg) [17:39:59] (CR) Awight: [C: 2] Clear out old Amazon code to prepare for PwA [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230253 (https://phabricator.wikimedia.org/T108659) (owner: Ejegg) [17:41:22] (Merged) jenkins-bot: Clear out old Amazon code to prepare for PwA [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230253 (https://phabricator.wikimedia.org/T108659) (owner: Ejegg) [17:42:11] (Abandoned) Ejegg: Add id attribute to amount and currency [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230706 (owner: Ejegg) [17:42:39] awight: oops, deleted the obsolete one [17:43:07] (PS5) Awight: Switch Amazon to Mustache form, add modules [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230724 (https://phabricator.wikimedia.org/T108114) (owner: Ejegg) [17:43:17] I'm hunting wabbits... [17:44:41] also, thanks for merging the old code deletion! I was just starting to ponder making old and new work side-by-side, but that would be a huge waste of time [17:45:24] hehe, glad I could preclude that. Yeah, for a 1-week overlap that would be silly. If it were 6 mo out, maybe... [17:46:13] aw drat, I've been locally rebasing onto master, but I forgot to shove the gerrit branch point forward [17:46:23] eff. [17:46:38] shouldn't have been much overlap [17:51:58] (CR) Awight: "I can merge if that's helpful for you, but please see my objections, inline." (4 comments) [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230724 (https://phabricator.wikimedia.org/T108114) (owner: Ejegg) [17:52:52] (PS2) Awight: Add id attribute to amount and currency [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/230939 (owner: Ejegg) [17:53:17] (CR) Awight: [C: 2] Add id attribute to amount and currency [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/230939 (owner: Ejegg) [17:53:35] (PS2) Awight: Stop fetching fields twice in message creation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231306 (owner: Ejegg) [17:53:40] (Merged) jenkins-bot: Add id attribute to amount and currency [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/230939 (owner: Ejegg) [17:53:58] (CR) Awight: [C: 2] Stop fetching fields twice in message creation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231306 (owner: Ejegg) [17:54:05] (PS3) Awight: Stop fetching fields twice in message creation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231306 (owner: Ejegg) [17:54:42] (PS7) Awight: Redirect to Amazon for login [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230707 (https://phabricator.wikimedia.org/T108112) (owner: Ejegg) [17:58:43] ejegg: /[?|&|#]/, really? [17:58:57] I think those need to be parens? [17:59:07] k, see you in a minute [17:59:13] awight: ehh, I was lazy and just copied their fn from the docs [17:59:37] awight|meat: yeah, i should tidy that up [17:59:44] and not steal code [18:02:30] we are going to meet briefly for an astropay retro if anyone wants to join [18:38:16] (CR) Ejegg: "Thanks for the ideas! Lemme take another crack at this." (4 comments) [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230724 (https://phabricator.wikimedia.org/T108114) (owner: Ejegg) [18:55:53] Fundraising Sprint Lou Reed, Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, Fundraising-Backlog, and 5 others: CentralNotice mobile modules should not be loaded in the head - https://phabricator.wikimedia.org/T100372#1536491 (Jhernandez) [18:58:11] K4-713: https://www.mediawiki.org/wiki/Fundraising_tech/Roles_and_Responsibilities#Tech_Sheepdog [19:02:00] Director of Pundraising [19:02:37] ejegg: ah, I realized the square bracket thing would match almost the same stuff, except it would also match "|name=" which is probably not intentional [19:02:56] [?&#] works [19:03:14] aww man, that regex is scaring me [19:03:27] The dollar sign... I don't think that's what they mean [19:03:51] awight: yeah, and I only use it in one place... will nuke that fn and replace with something simpler [19:04:00] see ya shortly [19:04:04] cya [19:34:33] (PS6) Ejegg: Switch Amazon to Mustache form, add modules [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230724 (https://phabricator.wikimedia.org/T108114) [19:35:17] (CR) jenkins-bot: [V: -1] Switch Amazon to Mustache form, add modules [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230724 (https://phabricator.wikimedia.org/T108114) (owner: Ejegg) [19:46:11] (PS7) Ejegg: Switch Amazon to Mustache form, add modules [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230724 (https://phabricator.wikimedia.org/T108114) [19:56:27] (PS8) Ejegg: Switch Amazon to Mustache form, add modules [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230724 (https://phabricator.wikimedia.org/T108114) [19:56:55] (CR) Awight: [C: 2] Switch Amazon to Mustache form, add modules [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230724 (https://phabricator.wikimedia.org/T108114) (owner: Ejegg) [19:57:20] (Merged) jenkins-bot: Switch Amazon to Mustache form, add modules [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230724 (https://phabricator.wikimedia.org/T108114) (owner: Ejegg) [19:58:28] Thanks awight! I tried the widget container, but realized I was just pushing presentation into the logic layer [19:58:46] Didn't want to pull in client-side mustache just yet [19:58:58] ejegg: no prob, we can iron this stuff out later [20:00:39] (PS8) Awight: Redirect to Amazon for login [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230707 (https://phabricator.wikimedia.org/T108112) (owner: Ejegg) [20:00:50] (CR) Awight: Redirect to Amazon for login (3 comments) [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230707 (https://phabricator.wikimedia.org/T108112) (owner: Ejegg) [20:00:56] (CR) Awight: [C: 2] Redirect to Amazon for login [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230707 (https://phabricator.wikimedia.org/T108112) (owner: Ejegg) [20:01:05] (PS6) Awight: Add Amazon wallet widget [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230711 (https://phabricator.wikimedia.org/T108116) (owner: Ejegg) [20:01:19] (Merged) jenkins-bot: Redirect to Amazon for login [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230707 (https://phabricator.wikimedia.org/T108112) (owner: Ejegg) [20:01:50] (CR) Awight: [C: 2] "Looking great!" [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230711 (https://phabricator.wikimedia.org/T108116) (owner: Ejegg) [20:02:15] (Merged) jenkins-bot: Add Amazon wallet widget [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230711 (https://phabricator.wikimedia.org/T108116) (owner: Ejegg) [20:15:19] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Easy, Technical-Debt: Use CSS instead of obsolete HTML attributes on CentralNotice tables - https://phabricator.wikimedia.org/T108259#1536982 (DStrine) p:Triage>Low [20:15:40] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Easy, Technical-Debt: Use CSS instead of obsolete HTML attributes on CentralNotice tables - https://phabricator.wikimedia.org/T108259#1516462 (DStrine) We're going to be doing some UI work and will tie this in during that. [20:23:11] Fundraising Sprint Queen, Fundraising-Backlog, Unplanned-Sprint-Work: Investigate AstroPay SmashPig FailMail - https://phabricator.wikimedia.org/T108995#1537033 (Ejegg) NEW a:Ejegg [20:35:51] so are we taking campaigns down again? [20:35:52] tethering really drives home how much bandwidth hangouts uses [20:37:41] atgo: https://www.youtube.com/watch?v=KFw-yXUHTLg [20:38:27] Heeee [20:42:48] lols [20:45:11] awight: cwdent: ejegg: XenoRyet: anyone interested in talking banner history eventlogging any time soon? Also, I assume no objections if I send another e-mail on that thread just to single out the questions we'd need Ellery to answer? By doing so with my intention wouldn't be to imply that a specific approach has been decided or anything... [20:45:47] (CR) Awight: Redirect to Amazon for login (3 comments) [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230707 (https://phabricator.wikimedia.org/T108112) (owner: Ejegg) [20:46:20] (CR) Awight: "Crap. I didn't mean to merge this, please see comments." [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230707 (https://phabricator.wikimedia.org/T108112) (owner: Ejegg) [20:47:03] AndyRussG: any time! [20:47:16] dstrine: https://www.youtube.com/watch?v=arisT3U-SSc [20:47:17] (PS4) Awight: Add pay with Amazon SDK composer package [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/229277 (owner: Ejegg) [20:47:29] #sorrynotsorry [20:47:43] ejegg: jfyi there were some things left to fix in https://gerrit.wikimedia.org/r/230707, not sure how I accidentally merged [20:48:19] K4-713: I'll see that and raise you: https://www.youtube.com/watch?v=lVIGhYMwRgs [20:48:32] AndyRussG: yeah anytime for me as well! [20:48:38] (CR) Awight: [C: 2] Add pay with Amazon SDK composer package [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/229277 (owner: Ejegg) [20:48:45] (PS3) Awight: Add Amazon API endpoint [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230940 (https://phabricator.wikimedia.org/T108113) (owner: Ejegg) [20:49:12] awight: ok, i'll fix in a follow-on patch [20:49:30] dstrine: Why do people keep sending me that video? :p [20:50:14] K4-713: because you have a framed picture of Commander William T Riker on your desk ..... [20:50:51] There are reasons. [20:53:36] (Merged) jenkins-bot: Add pay with Amazon SDK composer package [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/229277 (owner: Ejegg) [20:53:53] PayPal is back [20:54:18] They were quicker on the revert button this time. [20:54:32] (CR) Awight: [C: 2] Add Amazon API endpoint (2 comments) [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230940 (https://phabricator.wikimedia.org/T108113) (owner: Ejegg) [20:57:01] thanks for all the feedback awight ! [21:00:16] (Merged) jenkins-bot: Add Amazon API endpoint [extensions/DonationInterface] (payWithAmazon) - https://gerrit.wikimedia.org/r/230940 (https://phabricator.wikimedia.org/T108113) (owner: Ejegg) [21:02:45] ejegg: Take a holiday, man. Nobody should go straight from one payments integration to another [21:03:46] awight: what were you saying the other option (rather than making a whole new adapter) is for this WP thing is? [21:04:01] cwdent: well, it depends on how different the integration is. [21:04:07] is it the same api? [21:04:19] We might be able to just new code paths... [21:04:26] Donno if it's the same api [21:04:34] They sure have a proliferation of apis [21:05:01] they seem to be rebranding a bunch of subprocessors, and they don't do any work to standardize the interface, we just deal with the subprocessor's raw thing. [21:05:29] gotcha, yeah, so worldpay is just a middleman for a bunch of int'l processors? [21:05:35] We're already hitting multiple backends, not sure what that looks like in the code, though. [21:05:38] yeah [21:05:58] Streamline, High Capacity Gateway, some other thing... [21:06:13] cool, yeah i have a very murky understanding of the overall setup [21:06:20] amusingly, one of their processors reversed the meaning of "store id" and "merchant id" [21:06:28] handy [21:06:36] I wish there were a cool drawing I could point you to. [21:06:56] hehe, well yeah i've checked out K4's wonderful flow chart [21:07:11] so you think it might be possible to just add more code paths to the existing adapter? [21:07:15] The basic idea is, can doPayment handle all of our use cases, if we decide to to this new integration? [21:07:51] Everything else is just supporting, and is already pretty heavily switched. Like, making a new form is a piece of cake. You can even write the new one in mustache if you want, without forking the rest of the gateway. [21:08:03] s/to to/to do/ [21:09:08] but would that rely on the general exchange format being the same, or is that templated too? [21:09:47] although i guess it does look more or less the same based on what's in that ticket [21:10:30] Fundraising Sprint Queen, Fundraising-Backlog, Unplanned-Sprint-Work: Deploy pt-br translation Thank you email - https://phabricator.wikimedia.org/T108703#1527960 (awight) [21:11:28] cwdent: It's possible for each API call to have its own formatting and so on. [21:11:39] err, like it can be XML or json, etc. [21:14:22] does Enhanced silent order post imply that we currently use a non-enhanced silent order post? [21:14:28] No [21:14:30] sadly [21:14:44] gotcha, we are not currently posting any silent orders? [21:14:46] whatever that means [21:15:05] We started implementing this for Adyen, but never finished. [21:15:53] I think it's marketese for "form hosted on your page, cardholder details sent directly from the client, or encrypted and relayed through merchant's server" [21:16:51] gotcha, an api call as opposed to an iframe? [21:17:28] ohwait, this says iframe [21:17:48] oh hrm. Not sure how it works in this case. looking now [21:17:54] wait! i have answers for thi [21:18:04] we grilled WorldPay about this on the call [21:18:08] basically, it's an iframe. [21:18:11] hehe /me wipes almost learning furrows from brow [21:18:20] there's nothing special about "enhanced" SO POst [21:18:36] K4-713 and PPena and i wer eon a call with them where it took like 20 minutes to get to that, but that's the answer. [21:18:56] (seriously) [21:19:00] wtf [21:19:00] * atgo grumbles [21:19:06] false advertising [21:19:16] unless i'm completely lying... K4-713 PPena? [21:19:18] cwdent: awight: K! I'm good for a video call right now if u like :) [21:19:19] yeah i know [21:19:30] we spent ages being like "so it's an... iframe?" [21:19:44] Oh, that mess. [21:19:48] That was *ridiculous*. [21:20:23] ah ha, so being an iframe, would this even touch the adapter code? [21:20:32] (PS1) Awight: Follow breaking change in MediaWiki API response [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/231431 [21:20:54] that part i do not have an answer for cwdent ;) [21:20:56] cwdent: Probably, yes [21:21:06] we basically serve up this iframe and they take care of receiving the post and processing the payment? [21:21:16] But hopefully, we can handle it by just adding new cases to our do_transaction switch [21:21:23] donno that part yet [21:21:34] "This is the enhanced version" "...but it sounds like the way we've been doing things for a couple years already, that we are working with you expressly to get away from" "*embarrassed phone silence*" [21:22:10] cwdent: It basically sounded exactly like the GC solution we already have. [21:22:18] ...which is certainly not a redirect type. [21:22:24] It's... kind of huge in there. [21:22:27] now a "silent post" [21:22:29] *nor [21:22:33] (PS1) Awight: Update pt-br thank you letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/231432 (https://phabricator.wikimedia.org/T108703) [21:23:03] Fundraising Sprint Queen, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Deploy pt-br translation Thank you email - https://phabricator.wikimedia.org/T108703#1527960 (awight) [21:23:43] K4-713: yeah it looks hairy [21:23:50] aye [21:23:56] And then there's the antifraud dance. [21:24:16] the thing that confuses me about the iframe is...a lot [21:24:41] Think of it as sending donors off to a 3rd party just to deliver the cc information. [21:24:42] if we are just serving up an iframe that is hosted elsewhere and posts elsewhere, what does the adapter do? [21:24:49] heh [21:24:53] With GC, we do a few API calls from the server, which sets up the transaction [21:25:01] We have secrets such as our account information [21:25:22] GC responds with an URL unique to the transaction, which we use as the source for the iframe. [21:25:49] ah ha, ok that makes sense [21:26:07] so that's what the adapter does is retrieve a url? [21:26:12] We say "we want to start a payment, and here are all the details of that payment. Please get this person's credit card information, which is the only missing thing." Then they hand us a URL that has a token which only works for one submit on their end, and dies completely after... 30 minutes or something. [21:26:30] It shouldn't be possible to say "http://worldpay.com/pay/wmf" and put any arbitrary parameters on there, cos we want to do fraud tests, block countries, validate the amount, collect donor personal info... [21:27:37] totally. so the adapter in this case is just there to initiate the transaction, then we send the user off to sea [21:27:54] Also, when they come back to us, we have to verify that the person apparently trying to wrap up a payment, is the person who left a minute ago. [21:28:09] Otherwise: serious attack vector. [21:28:13] yeap [21:28:46] where do they land when they come back? in DI somewhere? [21:28:46] Once they come back, the adapter has to do all the tricky things, actually. [21:29:02] We can't do any antifraud tests on the card account until this stage. [21:29:10] ...because we never see any of it directly. [21:29:32] cwdent: fwiw, this is not how the WP adapter currently works. Currently, we present the form ourselves, but we build a small message on the client which we send directly to WP, including "cardholder details" (cc#), and get a token back. Then we respond to the WMF server with the donor's name, address, and this transaction token [21:29:36] yeah i'm guessing they don't show back up with a cleartext cc# [21:29:59] bahahahaha.... yeah, that would defeat the whole purpose of sending them off to a different form in the first place. :) [21:30:30] except kicking the responsibility can down the information superhighway [21:30:44] Yeah, that's what I'm saying. [21:31:02] The second a cc details come back to us, we're not... gaining anything. [21:31:07] So, they don't. [21:31:15] yep, makes sense [21:31:31] Usually, the gateway returns whether or not the transaction *would* go through, and some information about the AVS and CVV test results. [21:31:53] what kind of fraud tests can we do with just that token? [21:31:54] But, it's safer to query for that separately, because it can be faked if it just comes back as a querystring parameter. [21:32:15] Which token? [21:32:28] cwdent: nothing. We check the other stuff [21:32:59] name, IP, etc. See extras/custom_filters/filters/minfraud/ [21:33:00] aah, pitch them against goverment lists and stuff? [21:33:09] we don't ask those questions ;) [21:33:17] minfraud does some... Things. [21:33:21] We send it off to an AI deep underground [21:33:22] It's sort of black box in there. [21:33:32] But we know about some things they do. [21:33:37] * awight checks that me and K4 are still different people [21:33:44] hehe [21:33:51] They have their own IP and email blacklists, and do some geography math... [21:34:05] We do... other things ourselves. [21:34:06] hey, that's nice though to not have to own that part [21:34:22] Most of the stuff we control, has been the most useful. [21:34:40] i remember writing about 100 jobs to sync down homeland security dbs [21:34:57] iata blacklists [21:35:01] huh [21:35:11] no lithium batteries to russia! [21:35:15] etc [21:37:07] bearing in mind what awight said about how the current WP adapter is not an iframe and this one is, does that change the scope? [21:37:20] hmm [21:37:30] (PS1) Awight: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/231435 [21:37:42] I don't know if there's enough overlap in the product for us to have the luxury of not doing a total rewrite. [21:37:51] (CR) Awight: [C: 2 V: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/231435 (owner: Awight) [21:37:54] Or... parallel write. [21:38:08] Figuring that out should be step 1, I think. [21:38:43] Yep. I can't even say if it's worth the extra effort to consolidate the two integrations into one class, it might easily not be. [21:38:43] If we're lucky, we won't have to do *yet another* nightly audit parser. [21:39:02] * awight chiaroscuros [21:39:15] But... knowing WP, it's going to be a format that only works with that ONE WAY OF DOING THINGS, WHY CAN THEY NOT PICK INTERNAL STANDARDS. [21:39:18] * K4-713 bites things [21:39:28] for an even more basic question, what do we get out of this? the task mentions france, but i see comments about france in the current adapter that imply that it does work for france? [21:39:57] * K4-713 sighs [21:40:07] It's so that we don't need PCI-A EP [21:40:08] The explanation is simple, but... infuriating. [21:40:24] There are no technical blockers to the thing we have, working. [21:40:35] But, PCI standards changed, right after we got the thing out the door. [21:40:50] Unfortunately, this integration is more limited than what we've already done--e.g. the translations will suck and layout will be out of our control. [21:40:56] And despite the fact that I asked WP several times to their faces if we had to worry about the new DSS... [21:41:03] oh geez [21:41:36] Never ask a salesman if you have to worry about something. [21:42:39] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/231436 [21:42:48] (CR) Awight: [C: 2 V: 2] update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/231436 (owner: Awight) [21:43:05] and this is considered safer because we host less ourselves? [21:43:32] hehe yeah, isn't that ironic [21:43:34] and presumably WP has more PCI merit badges than we do [21:43:49] exactly. [21:43:52] sigh [21:43:53] They have to go through all the pain. [21:44:19] Keep in mind, though, that their salesmen do not write code. [21:44:41] if they did, they'd probably quit being salesmen and be programmers [21:44:47] hmmmm [21:44:49] I don't know about that. [21:45:03] There's not enough outright lying in programming. [21:45:09] !log update payments-wiki-staging from 99e3ce08117d18b15bc8138b447c4c21bd452d28 to 96a369651c1130b0a8e53a6395f83c0b9329b9f8 [21:45:14] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:45:24] hehe, truth [21:45:42] !log rollback payments-wiki-staging to 99e3ce08117d18b15bc8138b447c4c21bd452d28 [21:45:46] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:46:24] I usually waffle dramatically between "never blame any company for the actions of its salespeople" and "YOU HAVE THE POWER TO END THIS". [21:47:51] K4-713: i wonder if that correlates with the amount of time it's been since you had to talk to salespeople [21:48:23] Oh, I'd guess... total direct causation. [21:48:42] You know? That's my favorite thing about this job. [21:48:51] All the salespeople are not us. [21:49:05] oh yeah [21:49:17] the worst is when you're the tech person on the salesperson's team in the meeting [21:49:26] just grinding your teeth while they talk [21:49:33] It's been years since somebody cruised by my desk and shouted that "NOBODY AROUND HERE WOULD HAVE A JOB IF IT WASN'T FOR ME." [21:49:46] Like... 4.5. [21:50:31] I had to be the only tech person at a sales seminar once. [21:50:35] I was... filming. [21:50:45] I thought for a minute I'd have to gnaw my own leg off. [21:50:49] oh man, brutal [21:51:10] i've gotten sent to the objectively wrong conference a couple times [21:51:18] haaa [21:51:22] had some really nice vacations [21:51:28] At least they know I wasn't one of them. [21:51:33] *knew [21:51:42] Support role and everything. [21:52:21] I don't know what I'd do if they started being all conspiratorial buddy-buddy. [21:52:36] Maybe break a beer bottle and defend myself. [21:52:44] film it and upload to youtube [21:52:48] :D [21:53:59] thanks for explaining the WP flow to me, that was immensely helpful [21:54:17] Any time I' [21:54:23] am not stuck in meetingtown. [21:54:37] I want to do this all on wikis. [21:55:24] i fully support that [21:55:52] i was getting strung out on finding all the disparate wiki pages until i dusted off the old browser bookmark feature [21:56:02] hey old pal how long has it been [21:56:11] Oh man. That's a bad sign. [21:56:21] (PS1) Awight: Don't delete the message until we're done with it [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231441 (https://phabricator.wikimedia.org/T107852) [21:56:29] ejegg: ^ quick one... [21:56:46] cwdent: At some point, you should just nuke an index-type page and replace it with an HTML export of your bookmarks, then. :p [21:57:10] i haven't mentally modeled the difference between office/meta/collab/tech/regular wm [21:57:14] yet [21:57:16] I hear that a lot. [21:58:30] (CR) Ejegg: [C: -1] "Solution is not quite this trivial - $current_queue means nothing in the rectifying loop" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231441 (https://phabricator.wikimedia.org/T107852) (owner: Awight) [21:58:47] cwdent: It's not quite okay, but what we have so far is: [21:58:55] collab = needs to be secret [21:59:17] wikitech = only relevant for WMF configuration [21:59:23] meta = drama [21:59:28] hahaha [21:59:32] mediawiki = generic software dox [21:59:38] office = snacks and VPN [21:59:53] (salary = snacks= [21:59:53] ejegg: thanks! [21:59:54] ) [21:59:57] :) [22:00:12] * AndyRussG works for peanut butter [22:00:17] hehe, excellent breakdown [22:00:20] ...and then some [22:00:25] bread [22:01:52] atgo: got a sec? [22:01:57] yep! [22:02:00] cool! [22:02:01] i'm just reading "playing to win" [22:02:03] (PS2) Awight: Don't delete the message until we're done with it [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231441 (https://phabricator.wikimedia.org/T107852) [22:02:05] it's a blast [22:02:11] hmm never heard of it [22:02:15] yeaaah [22:02:19] don't bother [22:02:23] what's up> [22:02:24] ? [22:02:28] i added that to my place where i remember stuff: http://squiggle.city/~casey/ [22:02:47] * K4-713 dies a little [22:02:50] * AndyRussG googles and looks for the enwiki link [22:03:32] it's funny that collab is the secret one [22:03:38] ino! [22:03:39] wait andyrussg i'll brb [22:03:44] so like...collab, but not too much collab [22:03:46] atgo: k [22:03:55] cwdent: ....sort of. [22:04:11] cwdent: yeah... selective collab [22:04:32] The actual way it shakes out, is: If the documentation was written to be used *by* us... it generally ends up on collab. [22:04:48] The reason is a little nuanced, but it goes like this. [22:05:01] All the stuff we can't say in public, is usually the stuff we need to be able to look up *fast*. [22:05:48] So, in order to avoid some world of half-pages about components... [22:06:12] * K4-713 frowns [22:06:16] It still makes me sad. [22:06:23] heh yeah that makes sense tho [22:06:48] But, writing half-pages of documentation on wikis that don't talk to eachother, would be even more confusioning. [22:06:51] we need a redacted tag on mw [22:06:54] (CR) Ejegg: [C: 2] "That oughtta work!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231441 (https://phabricator.wikimedia.org/T107852) (owner: Awight) [22:06:55] i'm sure that would go over well [22:07:00] HA [22:07:19] So... then there's smashpig. [22:07:22] (Merged) jenkins-bot: Don't delete the message until we're done with it [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231441 (https://phabricator.wikimedia.org/T107852) (owner: Awight) [22:07:26] btw, it's fine to link to the secret docs. [22:07:32] Yeah. [22:07:37] That's a neat trick. [22:07:47] See our fraud filter settings here! Just kidding. [22:08:00] K4-713: I don't agree with the "used by us" thing. [22:08:06] I figured. [22:08:08] you mean link them publicly? [22:08:13] IMO, we should only put actually secret stuff on collab. [22:08:16] cause no one can get there anyway [22:08:19] otherwise, wikitech or mediawiki [22:08:25] hehe. mediawiki just needs cross-wiki transclusion with permissions [22:08:25] But, then again, how much comprehensive documentation have you tried to write? [22:08:33] that's fair. [22:08:35] Crosslinked docs and locations of logs and... [22:08:41] ...server names. [22:08:50] servername are fair game, they can be public [22:09:03] Yeah, but we try not to id specific services on our stuff. [22:09:04] i thought i saw that was a no-no somewhere [22:09:10] server names in particular [22:09:24] Ganglia exists, which complicates things more than somewhat in that area. [22:10:03] But, I'd prefer not painting a giant target on the exact queue server. [22:10:13] K4-713: I agree with what you said in the intro, https://collab.wikimedia.org/wiki/Fundraising/Engineering [22:10:18] https://meta.wikimedia.org/wiki/Wikimedia_servers [22:10:20] heh [22:10:31] Pretty sure Jeff doesn't care if we spread the server names around, but that's a detail [22:10:48] We have... gone back and forth on that onw. [22:10:50] *one [22:10:58] Long conversations, though. [22:11:22] Basically, if Ganglia wasn't there, we'd probably tell people not to even mention names in public. [22:11:33] At least, that's what we were thinking last time we went around with this one. [22:11:48] I'd like to move towards wikitech for pretty much everything you're saying should be on collab [22:11:58] unless it's generic, in which case it goes on mediawiki [22:12:05] Until we get smashpig. [22:12:09] BAHAHA [22:12:10] harr [22:12:12] MOAR FRAGMENT [22:12:23] a twist of the monkey wrench [22:12:33] sorry...what's ganglia? [22:12:40] oooooooooh, you'll like this. [22:12:55] Let me get a good one... [22:13:03] http://ganglia.wikimedia.org/latest/?r=hour&cs=&ce=&m=cpu_report&s=by+name&c=Fundraising%2520eqiad&tab=m&vn=&hide-hf=false [22:13:10] ». [22:13:10] EvoSwitch and Kennisnet are recognised as benefactors for their in-kind donations. See the current list of benefactors. [22:13:12] This, then... is us. [22:13:20] ok AndyRussG here! [22:13:30] blarg, middle click spam [22:13:41] atgo: cool thx! yeah so I remembered at one meeting (I think I'm recalling and In understood correctly?) someone mentioned that it might be important to check with Legal about correlating banner history logs to specific donors. Also we heard at another meeting that that's essential for a MVP [22:13:42] well how about that [22:13:51] the hackers will be able to see their progress! [22:14:03] ddos [22:14:37] atgo: so I was just wondering if some action is needed there? [22:14:46] that being said the graphs look good. is this munin? [22:16:02] cwdent: This is a fun one to watch when campaigns go up / down / sideways: http://ganglia.wikimedia.org/latest/graph_all_periods.php?c=Fundraising%20eqiad&h=silicon.frack.eqiad.wmnet&r=hour&z=small&jr=&js=&st=1439504001&v=0&m=ActiveMQ%20QueueSize%20donations&vl=Messages&z=large [22:16:04] atgo: I can code it up and we could include it in initial tests [22:16:24] (PS1) Awight: Include the monolog library [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/231444 (https://phabricator.wikimedia.org/T108605) [22:16:28] cwdent: I think ganglia is just ganglia. [22:16:44] hey AndyRussG - let me look into that [22:16:57] i double-checked with stephen about what's written on the mediawiki page yesterday and he signed off [22:17:04] cwdent: http://ganglia.sourceforge.net/ [22:17:10] Not really particular to us. [22:17:35] oh cool [22:18:33] sourceforge [22:18:37] * cwdent nostalgias [22:18:43] (PS1) Awight: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/231445 [22:18:52] actually AndyRussG i think i shared an outdated page with him [22:18:52] (CR) Awight: [C: 2 V: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/231445 (owner: Awight) [22:19:14] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/231447 [22:19:20] atgo: cool! You mean this page https://www.mediawiki.org/wiki/Extension:CentralNotice/Notes/Campaign-associated_mixins_and_banner_history ? or which one? Or maybe the collab one? [22:19:24] (CR) jenkins-bot: [V: -1] Include the monolog library [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/231444 (https://phabricator.wikimedia.org/T108605) (owner: Awight) [22:19:32] yeah i re-shared him the one from way back [22:19:36] so, i will send him this again [22:19:39] hmmm [22:19:46] yeah this one is pretty technical... [22:19:48] but the question is can we tie these back to contributions, yes? [22:19:54] yeah [22:19:55] well we'd already described it in the past pretty significantly [22:20:00] and the mediawiki.org apparently doesn't mention it [22:20:19] ok. i'll keep asking [22:21:08] atgo: basically when someone clicks to donate we'll definitely log their banner history (instead of just sampling, which is what we'll do for everyone) and that will be linkable to the specific donor [22:21:31] cool! Yeah I have no idea about the status of all that, I just remembered that someone mentioned it as something to do ;p [22:21:41] (CR) Awight: [C: 2 V: 2] Include the monolog library [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/231444 (https://phabricator.wikimedia.org/T108605) (owner: Awight) [22:21:51] (CR) Awight: [C: 2 V: 2] update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/231447 (owner: Awight) [22:23:26] !log update payments-wiki-staging from 99e3ce08117d18b15bc8138b447c4c21bd452d28 to 2e7b449224317779d53ff84527166c0d378a0a40 [22:23:31] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:29:05] !log update paymentswiki from 823393264d6795bbaec490ff86f17580f722e598 to 2e7b449224317779d53ff84527166c0d378a0a40 [22:29:10] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:31:35] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint The Pogues, and 4 others: Orphan slayer reads from frack Redis rather than ActiveMQ - https://phabricator.wikimedia.org/T99017#1537767 (awight) [22:31:37] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Tech Backlog, and 4 others: Use the new queue wrapper for limbo, antimessage, and orphan slaying - https://phabricator.wikimedia.org/T92922#1537768 (awight) [22:34:45] K4-713: just heard https://www.dnalounge.com/calendar/2015/08-13.html on the radio [22:35:06] awight: Ha, yep. [22:35:22] People keep texting me about that. [22:35:53] !log rollback payments-wiki-staging to 99e3ce08117d18b15bc8138b447c4c21bd452d28 [22:35:56] aargh [22:36:07] Jeff_Green: fyi, I just created a runaway process on payments1004 [22:39:20] Can we share templates cross-wiki yet? [22:39:31] * K4-713 is currently being a jerk [22:39:33] awight: what kind of breakage? [22:39:43] awight: i take it you're responsible for the failmail? fyi mbeat ccogdill [22:40:26] ooh [22:40:27] yikes! that’s a lot of fail mails [22:40:38] ejegg: infinite loop [22:40:43] erk [22:40:59] sure looks like my failmails, too [22:44:01] sure does, awight ;) [22:45:08] i'm just sending mbeat an email heads up FYI [22:47:47] ok cool. should not have donor-facing impact though [22:49:26] (PS5) AndyRussG: WIP Banner history logger campaign mixin [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229560 (https://phabricator.wikimedia.org/T90918) [22:50:02] yeah i just don't want him to be alarmed [22:51:44] (PS1) Awight: Rectify orphans inside the fetch loop [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231452 (https://phabricator.wikimedia.org/T107852) [22:52:09] awight: d'oh! [22:52:22] oh, /that/ infinite loop... [22:54:59] not every day I get to write one of those [22:55:07] not every day I get to write one of those [22:55:11] not every day I get to write one of those [22:55:22] bzzzzt [22:55:26] (CR) Ejegg: [C: 2] "Sorry, my halting determination algorithm must have malfunctioned while examining that last commit!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231452 (https://phabricator.wikimedia.org/T107852) (owner: Awight) [22:55:40] I think I'll test this one locally [22:55:52] (Merged) jenkins-bot: Rectify orphans inside the fetch loop [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231452 (https://phabricator.wikimedia.org/T107852) (owner: Awight) [22:56:07] hehe. good call [22:57:12] (PS5) AndyRussG: WIP Banner history logger: minify and cutoff for EL data [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/231060 [22:57:49] man i didn't even know do/while was a thing in php [22:58:05] (CR) jenkins-bot: [V: -1] WIP Banner history logger: minify and cutoff for EL data [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/231060 (owner: AndyRussG) [22:58:20] omg process_orphans calls processOrphans [22:58:23] this is not my day [22:59:24] oof. i think my +2 license is in trouble [22:59:51] It's not you, it's me [23:01:11] (PS1) Awight: Clean up process_orphans vs processOrphans [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231454 [23:05:47] ejegg: wanna kick that for good measure? [23:05:52] Smoke tests OK locally... [23:06:18] taking a look [23:10:51] (CR) Ejegg: [C: 2] "consolidated!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231454 (owner: Awight) [23:11:17] (Merged) jenkins-bot: Clean up process_orphans vs processOrphans [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231454 (owner: Awight) [23:13:08] (PS1) Awight: Merge branch master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/231456 [23:13:35] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/231457 [23:13:44] (CR) Awight: [C: 2 V: 2] update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/231457 (owner: Awight) [23:14:48] (CR) Awight: [C: 2 V: 2] Merge branch master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/231456 (owner: Awight) [23:15:21] best of luck with this one awight - i've got to sign off [23:15:23] !log update paymentswiki-staging 99e3ce08117d18b15bc8138b447c4c21bd452d28 to 65b05fc11896325ae9749318b296c4396a64f649 [23:15:32] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:15:36] hang loose! [23:16:25] awight: i'll be here for a bit if you need any questionably useful CR [23:16:57] * cwdent DI newb [23:23:40] hehe [23:24:04] Mostly, I need someone to help find the shards of my broken pride [23:26:28] awight: here i got you this https://31.media.tumblr.com/56e594fc5bddc70206f0f94f660e9e1e/tumblr_np346hoRIL1uwmsumo1_400.gif [23:26:54] millions and millions of galaxies! [23:29:01] http://i.imgur.com/DFzDXES.jpg [23:29:31] Ha [23:32:43] awight: u OK? don't worry!!!!! [23:34:46] arg I just found a much simpler way to limit the EL URL [23:35:08] what's that AndyRussG ? [23:35:20] cwdent: user eventLogging's own methods and checks! [23:36:17] AndyRussG: like an api for EL? [23:36:27] cwdent: hahah yeah it's all there for the taking! [23:36:47] mw-eventLog.makeBeaconUrl() [23:36:48] awesome! [23:36:56] mw.eventLog.makeBeaconUrl() [23:37:28] and of course mw.eventLog.checkUrlSize() [23:37:29] does that actually use the browser beacon thing? thought that wasn't well supported [23:37:36] it has a fallback [23:38:23] excellent [23:39:15] yeah [23:39:30] chalk one up for non-strict encapsulation [23:45:30] (PS6) AndyRussG: WIP Banner history logger: minify and cutoff for EL data [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/231060 [23:45:43] !log rollback paymentswiki from 2e7b449224317779d53ff84527166c0d378a0a40 to 823393264d6795bbaec490ff86f17580f722e598 [23:45:47] ^ aaaaalmost works, apparently, anyway it's an idea [23:45:48] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:46:24] (CR) jenkins-bot: [V: -1] WIP Banner history logger: minify and cutoff for EL data [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/231060 (owner: AndyRussG) [23:56:34] Fundraising Sprint Queen, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Something broken in payments-antifraud and payments-initial message generation - https://phabricator.wikimedia.org/T109022#1538016 (awight) NEW [23:56:40] Fundraising Sprint Queen, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Something broken in payments-antifraud and payments-initial message generation - https://phabricator.wikimedia.org/T109022#1538024 (awight)