[08:45:15] Fundraising Sprint Queen, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Deploy pt-br translation Thank you email - https://phabricator.wikimedia.org/T108703#1544132 (jrobell) Thanks everyone! [13:10:47] TCB-Team-Fundraising-Sprint-2015-08-05, TCB-Team-Fundraising-Sprint-2015-08-12, TCB-Team: [WMDE-Fundraising] Estimate effort: english donation pages and form - https://phabricator.wikimedia.org/T107258#1544807 (WMDE-leszek) We have decided to use [[https://www.mediawiki.org/wiki/Extension:Translate|Ext... [14:08:11] (PS2) Ejegg: Follow breaking change in MediaWiki API response [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/231431 (owner: Awight) [14:08:40] (CR) Ejegg: [C: 2] "Yep, we need this alright!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/231431 (owner: Awight) [14:10:50] (Merged) jenkins-bot: Follow breaking change in MediaWiki API response [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/231431 (owner: Awight) [14:58:58] (PS2) Ejegg: Fix fail page redirection (see deploy note!) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229414 (https://phabricator.wikimedia.org/T108041) [14:59:03] (CR) jenkins-bot: [V: -1] Fix fail page redirection (see deploy note!) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229414 (https://phabricator.wikimedia.org/T108041) (owner: Ejegg) [15:00:46] (PS3) Ejegg: Fix fail page redirection (see deploy note!) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229414 (https://phabricator.wikimedia.org/T108041) [15:01:11] (CR) Ejegg: "PS3: Manual rebase" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229414 (https://phabricator.wikimedia.org/T108041) (owner: Ejegg) [15:01:30] (CR) Ejegg: Fix fail page redirection (see deploy note!) (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/229414 (https://phabricator.wikimedia.org/T108041) (owner: Ejegg) [15:45:28] Fundraising Sprint Queen, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Deploy pt-br translation Thank you email - https://phabricator.wikimedia.org/T108703#1545733 (Ejegg) Open>Resolved p:Triage>Normal [16:54:46] Fundraising Sprint Queen, Fundraising-Backlog, Astropay Integration: Investigate 'Invalid control' errors from AstroPay - https://phabricator.wikimedia.org/T109335#1546374 (Ejegg) NEW a:Ejegg [17:01:27] (PS1) Ejegg: Log signed message and signature on 'Invalid control' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/232071 (https://phabricator.wikimedia.org/T109335) [17:01:39] Fundraising Sprint Queen, Fundraising-Backlog, Astropay Integration, Unplanned-Sprint-Work, Patch-For-Review: Investigate 'Invalid control' errors from AstroPay - https://phabricator.wikimedia.org/T109335#1546435 (Ejegg) [17:12:30] Fundraising Sprint Queen, Fundraising Sprint ODB, Fundraising Sprint The Pogues, Fundraising-Backlog, and 2 others: Banner history mixins and data - https://phabricator.wikimedia.org/T90918#1546481 (AndyRussG) The schema is [[ https://meta.wikimedia.org/wiki/Schema:CentralNoticeBannerHistory | he... [17:20:48] I'm going to take a long lunch today. see you in a couple hrs! [17:43:11] see you ejegg|away [18:10:10] (PS10) AndyRussG: Banner history logger campaign mixin [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229560 (https://phabricator.wikimedia.org/T90918) [18:11:37] (CR) jenkins-bot: [V: -1] Banner history logger campaign mixin [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229560 (https://phabricator.wikimedia.org/T90918) (owner: AndyRussG) [18:26:55] Fundraising Tech Backlog: Add Brazil credit card option to Ways_to_Give/pt-br - https://phabricator.wikimedia.org/T109348#1546753 (MBeat33) NEW [18:29:12] (PS11) AndyRussG: Banner history logger campaign mixin [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229560 (https://phabricator.wikimedia.org/T90918) [18:30:00] Fundraising Sprint Queen, Fundraising Sprint ODB, Fundraising Sprint The Pogues, Fundraising-Backlog, and 2 others: Banner history mixins and data - https://phabricator.wikimedia.org/T90918#1546762 (AndyRussG) [[ https://gerrit.wikimedia.org/r/#/c/229560/ | Patch ]] is no longer WIP! [18:49:30] Fundraising Tech Backlog: Add Brazil credit card option to Ways_to_Give/pt-br - https://phabricator.wikimedia.org/T109348#1546818 (atgo) @mbeat33 please add things to #fundraising-backlog instead of the tech backlog. @pcoombe - this one's for you I think. Lmk if you want it somewhere else or if you need he... [18:49:40] Fundraising-Backlog: Add Brazil credit card option to Ways_to_Give/pt-br - https://phabricator.wikimedia.org/T109348#1546819 (atgo) [18:52:58] Fundraising-Backlog: Add Brazil credit card option to Ways_to_Give/pt-br - https://phabricator.wikimedia.org/T109348#1546852 (Pcoombe) a:Pcoombe [18:53:55] * AndyRussG waves [18:54:12] Hi cwdent XenoRyet dstrine atgo :) [18:54:42] * XenoRyet waves [18:54:43] hi ejegg|away [18:54:45] :) [18:54:47] hiii [18:55:21] cwdent: ejegg|away: banner history patch and schema are no longer work-in-progress, if you feel like reviewing anytime!! :) [18:55:22] yo [18:55:28] hey :) [18:55:43] AndyRussG: saw that! congrats, i'll check it out shortly [18:55:55] cwdent: fantatic, thx!! [18:57:41] AndyRussG: !!!! [18:57:46] i SAW!! how exciting!! [18:57:52] now for lunching... /nick atgo-away [18:57:56] oops haha [18:57:59] atgo: thx [18:58:17] bon appétit [18:59:05] (PS5) Awight: Stop fetching fields twice in message creation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231306 (owner: Ejegg) [18:59:31] (CR) Awight: [C: 2] Stop fetching fields twice in message creation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231306 (owner: Ejegg) [18:59:58] (Merged) jenkins-bot: Stop fetching fields twice in message creation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/231306 (owner: Ejegg) [19:02:33] (PS2) Awight: Log signed message and signature on 'Invalid control' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/232071 (https://phabricator.wikimedia.org/T109335) (owner: Ejegg) [19:04:40] (CR) Awight: [C: 2] "Cryptic!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/232071 (https://phabricator.wikimedia.org/T109335) (owner: Ejegg) [19:05:03] (Merged) jenkins-bot: Log signed message and signature on 'Invalid control' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/232071 (https://phabricator.wikimedia.org/T109335) (owner: Ejegg) [19:36:26] (PS12) AndyRussG: Banner history logger campaign mixin [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229560 (https://phabricator.wikimedia.org/T90918) [19:39:48] Fundraising Sprint Queen, Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance: Test for performance regressions - https://phabricator.wikimedia.org/T107503#1547081 (AndyRussG) a:AndyRussG [20:25:28] https://office.wikimedia.org/wiki/Bash [20:31:04] https://github.com/minimaxir/big-list-of-naughty-strings [20:35:24] https://github.com/minimaxir/big-list-of-naughty-strings/blob/master/blns.txt#L330-L334 [20:37:01] cwdent: hahahah [20:39:27] best part: try viewing the raw file [21:08:30] cwdent: I don't see any difference in the raw file? [21:09:18] ha, they must have just fixed it [21:09:25] the raw link was 503 before [21:09:40] aaaw hahahaha [21:09:57] cwdent: but... are you sure? [21:10:12] How sure? [21:10:37] heh yeah i had other people confirm [21:12:51] though i suppose it could have been this: https://twitter.com/githubstatus/status/633384515336052737 [21:12:55] AndyRussG: just sent you a quick draft of the email for online [21:23:34] atgo: thx! [21:25:16] (CR) Cdentinger: Banner history logger campaign mixin (1 comment) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229560 (https://phabricator.wikimedia.org/T90918) (owner: AndyRussG) [21:25:41] another thing that's ridiculous about gerritt is you can't make a comment without performing a "review" [21:26:04] imo those are conceptually different things [21:27:09] cwdent: good point [21:27:53] On a unrelated note, if you eat corn chips that are supposedly "plain" flavor, and they're a little, old, and you start noticing the have a very mild, tangy aftertaste, what should you do? [21:28:34] add more salsa [21:28:40] heheh also good point [21:28:43] guac [21:30:17] (PS1) Ejegg: Set correlationId up front for AstroPay messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/232213 (https://phabricator.wikimedia.org/T108995) [21:32:27] Fundraising Sprint Queen, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Investigate AstroPay SmashPig FailMail - https://phabricator.wikimedia.org/T108995#1547434 (Ejegg) [22:06:07] Fundraising Sprint Queen, Fundraising Sprint The Pogues, Fundraising-Backlog: Recent recurring GC donations not recurring or displaying as such at GC - https://phabricator.wikimedia.org/T105041#1547590 (Ejegg) a:Ejegg [22:14:25] (Abandoned) AndyRussG: Pls don't merge - WIP - CNBannerChoiceDataResourceLoaderModule::getDependencies() method signature [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/211657 (owner: AndyRussG) [22:15:57] Fundraising Sprint Queen, Fundraising Sprint The Pogues, Fundraising-Backlog: Recent recurring GC donations not recurring or displaying as such at GC - https://phabricator.wikimedia.org/T105041#1547636 (Ejegg) Investigating #4699088506 shows that the donor initiated a non-recurring donation via form... [22:20:27] atgo: the bit in square brackets is a questions to address now, right, not part of draft itself? [22:20:37] indeed AndyRussG [22:20:52] atgo: cool! Mmm what do you mean by running in parallel? [22:21:07] so, let's say we did this for the ZA campaign, which is up now [22:21:21] mmm [22:21:24] and what we get from the new thing is giving very different results than the old thing [22:21:35] right [22:21:36] is there any way that they'll be able to still have the trusted data? [22:21:41] or is it 1 or the other? [22:21:50] Ahhh OK right. So the risk isn't really the data [22:22:28] The risk is the system falling over itself and not showing banners, making other things break, ruining free knowledge around the globe, etc. [22:22:58] That's just because it's a lot of new code going out in a complicated system with a zillion edge cases [22:23:23] They can continue to trust Special:RecordImpression, that's not going away right away... [22:23:43] ahh just that? [22:23:44] :P [22:23:45] (Unless, of course, whatever goes wrong goes wrong with the code that calls that.. but it's not the most likely scenario) [22:24:00] Yeah [22:24:02] ok.. so what's the benefit of doing this as a cutover on the same campaign then? [22:24:08] i thought that's why we had talked about this? [22:24:26] "Another point we'd discussed is the possibility of starting a campaign off the new system, and turning on the system once the campaign is already going, just to check if there's any noticeable jump in results... Dunno if that's worth bringing up here... " [22:24:35] Correct [22:25:03] So a jump in the results could be due to some problem with the data reporting, but it could more easily, I think, be due to something else going awary [22:25:10] For example banners not showing as expected [22:25:39] So starting in the middle of a campaign with solid, moderately predictable results is a like one more way of detecting that [22:26:18] If all of a sudden we get a lot less donations, or we get more donations but the same number of S:RI impressions, or whatever [22:26:43] Basically the plan is that everything should continue to run smoothly. No noticeable change for the user experience [22:26:55] Or the FR-online team experience [22:27:07] Or the WMF's coffers' experience [22:28:16] So if we have something going and we can reasonably say, this is pretty stable and we expect it to continue along a trodden path, and in the middle of that, we turn it on, if something--anything--jumps out as different exactly at the same time we turned it on, it's a pretty good indication that something's wrong [22:29:06] When I say "turn on the new system", I don't mean necessarily activating banner history for the campaign, I mean, deploying all the new CN code [22:29:19] We could even do it in a couple stages [22:29:26] 1) deploy the new code and watch what happens [22:29:44] 2) turn on banner history and watch what happens [22:29:53] 3) either celebrate or cry and revert [22:30:14] ok... i'll take whatever you guys think is the best way to deploy. we can work with online about that [22:30:18] (sorry if I wasn't clear before) [22:30:21] i'll just remove this bracket-y bit and send, ok? [22:30:31] no worries. it's all good info to have. [22:30:39] atgo: sure! :D [22:31:38] atgo: yeah do send it... That said ^ we should be aware of and watching _all_ FR campaigns that are running at the time of deploy [22:31:45] thanks much also :) [22:31:48] yes :) [22:46:11] (PS1) Ejegg: Truncate referrers when hosts match a pattern [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/232218 [22:47:35] (PS2) Ejegg: Truncate referrers when hosts match a pattern [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/232218 [22:48:04] Speaking of not associating individual donations with any browsing data ^^^ [22:48:49] Suppose I should make a phab card, but I'm wary of causing a fuss [22:51:11] nice ejegg [22:58:16] https://www.youtube.com/watch?v=_BXf_h8tEes [23:00:13] cwdent: that's good stuff. Massachusetts has one of those, but I'm sure they paid a contract a lot for a map that'll be out of date soon [23:00:20] *contractor [23:02:24] yeah, in spite of everything it remains tough to hate google [23:02:43] i'm sure this was a 20% time idea [23:02:51] if alphabet was a move to decentralize their power that'd be awesome [23:02:53] of course it's not [23:03:20] ejegg: yeah probably [23:03:48] but we HAVE to centralize all the information so we can organize it! [23:07:26] the nsa doesn't want scattered details! [23:31:15] hey jeff_green - anything to worry about with all these alerts? [23:33:55] atgo: looks like those alerts are for the new failover cluster that's not being used yet [23:34:04] ah ok. thanks ejegg! [23:39:43] not to worry [23:39:57] apparently the newer apache release doesn't like my syntax