[00:06:50] AndyRussG: yeah that sounds very similar to the problems i was having with the passiness of those tests [00:06:55] very non deterministic [00:15:33] atgo: I worked on a mythbusters show where we made a giant lego ball. go to 2:20 here: https://www.youtube.com/watch?v=M8vdTXO0lpE [00:15:42] :O [00:15:54] I remember that episode :D [00:16:18] I was a production assistant "mythturn" for a while [00:22:16] nice :D [00:22:19] that sounds awesome [00:35:01] (PS19) AndyRussG: Add BannerMixinHook tests. [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229422 (owner: Cdentinger) [00:35:26] (CR) AndyRussG: "Rebased" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229422 (owner: Cdentinger) [02:08:27] cwdent: found it! had to do with execution order of insertBanner(). It's a small fix, I'll just put it in a commit, sound good? [02:34:07] (CR) AndyRussG: "Almost there!! While this works on Special:JavaScriptTest and on Jenkins, I still had issues running grunt qunit on the command line. See " (4 comments) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229422 (owner: Cdentinger) [02:44:17] (CR) AndyRussG: "Thanks!" (1 comment) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/233057 (owner: AndyRussG) [02:48:47] AndyRussG: glad to hear it! [02:49:10] Heh I was kinda facepalm when I saw it...! [02:49:25] Seeing as I had just fixed some other tests with exactly the same issue [02:50:21] (PS1) AndyRussG: GeoIP tests: move saving of original values outside setup [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/233654 [02:53:24] AndyRussG: whew, looks like it was pretty complicated to find! i hadn't dug into these files at all [02:58:59] ah the bucketer problem was something else I noticed when trying to isolate the test by commenting out all the others.. [03:00:01] So yeah the no banner available test was depending on side effects of the previous tests [03:00:24] the one that I was stuck on for a bit was the insertBanner() vs reallyInsertBanner() [13:24:24] TCB-Team-Fundraising-Sprint-2015-08-12, TCB-Team: [WMDE-Fundraising] BE: member-view in analyzation-section - https://phabricator.wikimedia.org/T104435#1570990 (WMDE-Fisch) [13:24:37] TCB-Team-Fundraising-Sprint-2015-08-12, TCB-Team: [WMDE-Fundraising] BE: member-view in analyzation-section - https://phabricator.wikimedia.org/T104435#1570994 (WMDE-Fisch) a:WMDE-Fisch [15:37:54] Fundraising-Backlog: Spike: Investigate NULL country values in drupal - https://phabricator.wikimedia.org/T99128#1571294 (atgo) This is now our 5th biggest country. :o [15:39:54] Fundraising-Backlog: Spike: Investigate NULL country values in drupal - https://phabricator.wikimedia.org/T99128#1571309 (atgo) [16:10:10] * AndyRussG waves [16:10:15] dstrine: I'm curious what the new Phabricator tags are--I've been trying to use "tech debt" for maintenance [16:10:24] AndyRussG: hi! [16:10:27] awight: :) [16:10:46] hey awight [16:10:50] AndyRussG: got CR you needs? [16:10:59] awight: ah yes indeeeed [16:11:36] Nothing jumping off the board at me... [16:12:09] There is is are conversations about how to make a global definition for maintenance that is a bit beyond tech debt. Have you been using the tech debt tag recently? [16:12:19] I'm pretty inconsistent about it. [16:12:19] awight: https://gerrit.wikimedia.org/r/233654 https://gerrit.wikimedia.org/r/233065 [16:12:43] Cool, yeah I'd like to see maintenance become a first-class concern. [16:12:44] awight: I guess we could also merge the whole feature branch even before those. I still should send out an e-mail to Ellery about the last one [16:12:59] (PS4) Awight: BannerHistoryLogger: Increase random shift of timestamps [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/233065 (owner: AndyRussG) [16:13:13] (CR) Awight: [C: 2] BannerHistoryLogger: Increase random shift of timestamps [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/233065 (owner: AndyRussG) [16:13:24] awight: thx! [16:13:44] GeoIP tests I should leave for cwdent to merge, but taking a look now. [16:14:03] awight: it's just fixing a small oversight [16:14:07] yeah i'll take a look at that too [16:15:09] awight: yeah we are just going to do a quick pass on the closed items in the last two sprints and discuss. Every team will sort of have their own definition and we'll pull them together somehow. [16:15:12] (CR) Awight: [C: 1] "Makes sense at a casual glance. This should reduce the opportunity for accidentally corrupting the values, and might speed tests up by a " [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/233654 (owner: AndyRussG) [16:15:30] (Merged) jenkins-bot: BannerHistoryLogger: Increase random shift of timestamps [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/233065 (owner: AndyRussG) [16:15:55] dstrine: That's awesome. Having more of a structure to balance debt against new will make it less likely that I have to go on new feature strike. [16:16:05] lol yeah [16:16:30] I'm dead serious ;) [16:17:01] It's hard to build these underground pyramids in quicksand [16:19:38] (CR) Cdentinger: [C: 1] "lgtm2" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/233654 (owner: AndyRussG) [16:20:11] cwdent: :p someone has to merge that thing [16:20:22] 1+1 != 2 [16:20:23] cwdent: do you have +2 rights? If u do, pls go ahead [16:21:00] (CR) Cdentinger: [C: 2] GeoIP tests: move saving of original values outside setup [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/233654 (owner: AndyRussG) [16:21:05] :) [16:21:15] yeah i thought +1 + +1 = +2 [16:21:29] nah Gerrit doesn't do arithmetic [16:21:50] two "meh"s don't make a right [16:22:23] cwdent: awight: when are we ready to create a Gerrit change to merge the feature branch? [16:22:33] your call! [16:22:35] outstanding patches on the feature branch could later be cherry-picked or re-merged [16:23:00] dooo eeeet [16:23:06] K!! [16:23:19] (Merged) jenkins-bot: GeoIP tests: move saving of original values outside setup [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/233654 (owner: AndyRussG) [16:23:35] I haven't been paying attention to smoke test anecdotes, but it's probably fine to do that on master+beta, either way [16:23:36] just checking out your latest comments on the mixin tests AndyRussG [16:24:09] cwdent: a K, thx, pls lmk if u have questions or would like to toss me a virtual rotten tomato [16:27:32] awight: to reset .gitreview to have master as the default branch: should I do that in the same commit as the merge, or in a separate commit/Gerrit change? [16:29:23] AndyRussG: about that hide cookie... is there a consistent name that would be safe to use? centralnotice_hide_fundraising for example? [16:30:40] cwdent: yep! U can see this in ext.centralNotice.hide.js, line 38 [16:31:38] cwdent: the category is already there in the test data in ext.centralNotice.display.tests.js, that's why we'd use that category, since any other cookies should not affect the test or be affected by it [16:32:08] This is essentially to prevent any cross-contamination from tests, or from tests onto a developer's local setup or vice versa [16:32:16] cross-contamination among tests, I meant [16:32:41] gotcha, looks good! [16:36:33] AndyRussG: Even if there were edit conflicts in .gitreview, they're easy to resolve, so it's fine to include that change in the merge. [16:37:40] >It turned out that the RD (Redirect) Service has not been configured [16:37:42] >UserMame [16:37:44] >please obfuscate the password [16:37:48] http://i1.kym-cdn.com/photos/images/facebook/000/321/729/80f.jpg [16:37:52] * awight slaps self awake [16:38:17] Granular as half a cube of sugar [16:38:19] awight: K... It's really funny, though, when I do git merge campaign_mixins locally, it just resets the head of master to the head of campaign_mixins. No new commits created. Then if I add in the .gitreview change it creates a whole new commit with the tip of campaign_mixins as its only parent. Looks really ugly [16:38:41] So I'm gonna update the .gitreview as a separate patch on the feature branch [16:38:49] ok, interesting! [16:39:57] Yeah! I have no idea how it'd look in Gerrit, maybe the world would just end [16:40:12] (PS1) AndyRussG: Reset .gitreview defaultbranch to master [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/233744 [16:41:05] K unless there are objections, I'll wait 4 that to be OK'd and merge ^ [16:42:22] AndyRussG: heh, looks like that will merge to master! [16:54:06] AndyRussG: do you think we should expose the cookie name in the hide module somehow, or just use "centralnotice_hide_fundraising" literal in tests? [17:06:27] (Abandoned) AndyRussG: Reset .gitreview defaultbranch to master [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/233744 (owner: AndyRussG) [17:07:05] cwdent: let's just do the literal. It's simple enough, and tests are allowed to depend on the inner working of the code under test [17:07:14] (and its environs) [17:07:23] ejegg: weeee thanks much for catching that!! [17:07:43] I got used to saying "git review -R" without expliciting the feature branch [17:08:14] ohh, so there is a way to specify a different branch than the one in .gitreview? [17:08:57] git push master HEAD:refs/for/branch [17:09:17] looking forward to using maniphest... [17:09:46] AndyRussG: did you see my post-merge comment on 'anticipate resources'? [17:11:07] ejegg: yeah thanks I did see the comment, and I replied to it in Gerrit! Pls LMK if it seems not sensical :) [17:11:18] Oops, sorry, lemme read that [17:11:25] ejegg: yes git review [17:12:55] (PS1) AndyRussG: Reset .gitreview defaultbranch to master [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/233752 [17:13:23] hey AndyRussG! do we have a date for banner history rollout? or are we waiting for review? [17:15:20] atgo: we're just preparing the Gerrit change to merge the feature branch into master. I don't know how much review our colleagues want to put into that one, I think at least awight wants to check out the whole branch at least a bit :) [17:15:21] AndyRussG: Ahh, good points all. I wasn't thinking about how many would get the history logger code loaded but never end up seeing a banner [17:15:35] ooh neat [17:15:55] ejegg: cool thanks. yeah that's one of the hard-to-see issues about how this all works. I'll add a comment in the code, then! [17:16:31] so AndyRussG - do you need anything else from Online? [17:17:00] I guess if we were really concerned about eliminating any conditionally-needed mixin dependencies we could work on combining them with the banner load [17:17:20] atgo: no, the last message was a huge help, also digging into that now! :D thanks much for staying on top of that!!! [17:17:27] i mean eliminating extra requests, and combine them with the banner request... [17:18:01] ejegg: well no, unfortunately, since the whole point of campaign mixins is that they can run code _before_ a banner is chosen and fetched [17:18:14] ejegg: great idea for banner-based mixins though!! [17:18:42] AndyRussG: let's smoke test on beta rather than locally, cos the ResourceLoader config will be more realistic, I'm assuming. [17:18:55] in other words, I promise not to veto this merge :) [17:18:56] awight: okidoki \o/ [17:19:18] awight: ah no pls go ahead w/ any vetos that you may find to be needed [17:21:04] Just brainstorming potential failure modes, I assume if something goes wrong during real deployment we will want to roll back the entire branch, rather than individual commits? [17:21:52] You might want to try that locally, it can be tricky to roll back merge commits IIR [17:23:12] cwdent: i would add this matt to whatever ongoing worldpay threads you've got goign - he's the more senior of the group [17:23:40] Fundraising-Backlog: Spike: Investigate NULL country values in drupal - https://phabricator.wikimedia.org/T99128#1572293 (CCogdill_WMF) FWIW, this does not impact email data; we have only 3 NULL or blank country values for past donors in our email database. If we're not using billing address to check for blo... [17:23:56] awight: yep i forwarded the other thread to him [17:23:59] errr [17:24:01] atgo: [17:24:12] hehe :) [17:24:48] we're easy to mix up [17:25:08] atgo: Are all of our vendor contacts named Matt now? Is this part of our standard contract? [17:25:16] matt or kyle or adam [17:25:24] we've got a few jessicas too [17:25:25] * awight is still working on the matt, brick, matt joke [17:25:28] heh [17:25:54] that brick is stuck between a... no [17:25:56] all vendor names come from the bible [17:26:07] names you can trust [17:26:48] speaking of witch, the Republican debates were apparently officially sponsored by Facebook and Fox? [17:27:00] interesting [17:27:07] eew, c'mon facebook! [17:27:18] They were prominently featured. [17:27:38] Might as well have chromekeyed bodysuits on these clowns [17:27:38] Yes, because Facebook is a thing that lends credibility to a debate. [17:27:50] There were carefully selected questions from real people. [17:28:07] Fox example, "what is your plan to eliminate ISIS within 6 months?" [17:28:29] with the selfie edited in and everything [17:28:46] okay you got to watch a bit to get the overall game show ambience [17:32:00] So, is there some documentation about fredge out there that I'm not finding? [17:32:13] lemme find some [17:32:32] I was trying to figure it out, but it's starting to feel like one of those things I should just ask about. [17:33:08] definitely [17:33:16] Though apparently K4 is the only one with an X next to fredge on that 'who knows about what' page. [17:33:58] XenoRyet: http://git.wikimedia.org/blob/mediawiki%2Fvagrant/3a0cf0d63e1ae35bc1608824031640dde00c7ed6/puppet%2Fmodules%2Fcrm%2Ftemplates%2Fsettings.php.erb [17:34:18] That's just the settings [17:34:42] fredge itself is a really cool idea K4 had, where we send fraud and log stuff back to the CRM via message passing. [17:37:08] XenoRyet: here is the type of data the fredge queue consumer records: https://collab.wikimedia.org/wiki/Fundraising/Engineering/Fun_SQL_Queries#FREDGE.21 [17:37:36] Cool [17:38:17] everyone: since XenoRyet mentions it, can you all update https://www.mediawiki.org/wiki/Fundraising_tech/Training when you get the chance? [17:38:28] hehe did you see how I blamed you? [17:38:37] Yea, caught that ;-) [17:38:55] Did that settings file answer the question? [17:39:27] It's a nasty situation, I'd like to redo the config so we default to reusing the drupal database. [17:39:59] That setting file looks vagrant related. I never did get vagrant to do civi for me. Had to set it all up manualy, which is probably why I'm missing the fredge db. [17:40:38] Sorry to hear it, we should do a screenshare soon to fix that [17:40:58] imma run out for a bit [17:41:14] Yea, if you want to try that, I'd love to be back in vagrant-land. [17:41:40] ok cool, grab maybe 30 min on my calendar whenever it's convenient! [17:42:52] I did want to see the lightning talks, and I don't want to stomp on lunch. Maybe after standup? [17:43:37] sure! [17:43:55] Cool, thanks. [17:44:53] awight: ah, guess I did have some learning to add. thanks for the reminder! [17:44:55] Today's a good day, I need regular breaks from this byzantine monolog config riddle [17:47:07] ejegg: Thank you! I suspect we need rows for new stuff, too [17:47:13] e.g. Mustache [17:47:19] ooh, yeah [17:47:32] and the other queueing stuff [17:51:35] aha! Fun. Hrm we could add more info to this chart by linking the titles to existing documentation. Which would also create a hit list of people we need to hit up to write more docs [17:51:42] * awight whooohahaha's [17:52:18] hehe, nice scheme [17:52:39] I'm clearly looking for ways to procrastinate [17:54:55] Careful what you wish for -- those Amazon cleanups you wanted on the login redirect are in review! [17:55:38] * awight claws at the saltpeter [17:56:24] Jeff_Green: I've been having inappropriate thoughts about getting payments config into private puppet... [17:56:39] ha [17:56:46] imo that is a sane thing to do [17:56:55] I'd really like the source control [17:57:19] we could even do it as a template and only put the sensitive bits in the private repo [17:57:27] That would be so rad. [17:57:32] I'll entodo it [17:57:35] there's a module that is just for storing passwords [17:57:37] ok [17:57:48] Passwords and fraud bits [17:58:17] although, I've been noticing that an interesting amount of our real-life fraud config is actually included in DonationInterface.php as defaults. [17:58:45] ha [17:59:17] i'm sorta burned out on modsecurity for the moment, so I'll do this now :-) [18:00:52] haha perfect--c.f. my history of procrastination in the backscroll [18:03:19] Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops, Technical-Debt: Move all fundraising component config into Puppet - https://phabricator.wikimedia.org/T110224#1572549 (awight) NEW [18:04:08] Jeff_Green: Is there anything we can do to help with the WAF or other PCI crap, btw? Want fourth and sixth eyes on the warning logs or whatev? [18:04:46] awight: absolutely. I've been sorta working my way toward a point where other people can make sense of the insanity [18:04:58] and also figuring out various limitations [18:05:00] ejegg: want to give a second opinion on https://phabricator.wikimedia.org/T110224 ? [18:05:18] OK great. You want to write a spike for us? [18:05:19] I finally figured out all the PCRE limits exceeded stuff [18:05:29] wat. [18:05:31] soon yeah, [18:05:34] awight: yeah, that sounds like a great idea! [18:05:34] so it's amusing [18:05:56] the entire thing is built of turtles and rats [18:06:00] ejegg: thanks. Anything but https://phabricator.wikimedia.org/T107918, which behaves differently on every machine I try it on. [18:06:01] it's all regex matching [18:06:03] PCRE [18:06:08] modsecurity? [18:06:11] yes [18:06:15] fuck that. [18:06:39] and we're buffer overflowing the ridiculous apache calling code? [18:06:40] if regexes match, it either takes an action or it nudges up some score which is later checked [18:06:46] oh jeez, that looks baroque [18:06:50] well no [18:07:03] so there are configured limits to prevent that [18:07:45] ejegg: I whined a bit to bd808 already, but he has a valid point, that there are no defaults, so what do I expect to override... [18:07:47] the part I figured out was how a regex relates to those limits, which in retrospect should have been obvious, but I don't think it is and I don't think the people writing rules really seem to understand that [18:08:25] Sounds like skipping a tooth on the timing belt of an interference engine [18:08:48] I love when code is distributed which doesn't work with factory settings [18:08:58] unsafe at any speed. [18:09:20] basically if the string being checked is longer than the PCRE recursion/character limit, and the regex isn't limited (you use * or +), and the pattern starts to match a string longer than the limit, you hit the limit and lose the data [18:09:55] awight: interference engine? https://en.wikipedia.org/wiki/Inference_engine [18:10:03] :) [18:10:27] an inference engine that will break its own valves [18:10:27] so /drop\s+database\s+\S+/ against a 1500 character string has a pretty good chance of hitting the limit [18:10:38] wait, seriously? [18:10:44] seriously [18:10:47] a limit on the pattern being searched? [18:10:48] oh right: https://en.wikipedia.org/wiki/Interference_engine [18:10:51] I can't look [18:11:07] ^L^L [18:11:32] Jeff_Green: is this stuff alpha? [18:11:36] no [18:11:40] it has a long history [18:12:03] and that behavior actually makes sense for what it is, imo [18:12:17] otherwise you could soak up all your RAM catching a pattern [18:12:42] but... regex has been running on unlimited length text for its entire existence [18:12:44] so the thing that took me about a week was figuring out how all this works and figuring out how to rewrite patterns [18:13:10] ... and overflowing resources doing so [18:13:20] Why don't other people have this problem? [18:13:24] they do! [18:13:28] they just haven't figured out why [18:13:53] holy cow [18:14:02] modsecurity pcre recursion limit [18:14:06] Thanks for your contribution to this grim ecosystem [18:14:06] google ^^^ [18:14:15] ^C^V [18:14:32] lolol first result "What are PCRE limits?" [18:14:36] people get hung up on individual rules [18:14:50] so I'm working with OWASP's Core Rule Set [18:15:00] baahahaha that's why this is such ass. It's written in PHP [18:15:06] which is an opensource thing that is generally pointed to as the place to start [18:15:24] i don't think it is [18:15:27] it's an apache module [18:15:33] wouldn't that be c? [18:15:41] I would have hoped [18:15:47] On serverfault I see this, though: pcre.backtrack_limit = 10000000 [18:15:49] people are confused about the configuration options [18:16:14] ah nvm, I see some talk about "compiled" [18:16:15] somewhere someone says "yeah, adjusting the php limits isn't going to help, it's an apache module, not php code" [18:16:17] C indeed [18:16:23] annnnyway [18:16:50] hehe. "I'm getting these errors for a Rails app, not PHP" [18:16:52] so what I've been doing is finding the rules that explode at the default limit of 1000 characters, and redoing them as locally-modified versions [18:17:12] that was serious pain point #1 [18:17:16] #2 is... [18:17:37] regexes vs non-ascii character sets [18:17:39] That sounds a lot better than randomly cranking up apache limits [18:19:17] charset conversion isn't built into modsecurity? [18:19:18] like--'referrer' off of some russian language wiki page with the \\\\398\\\34\fd\\3434\\\\34\\ false-positives as a potential SQL attack [18:19:44] i need to research it more, it's possible it is and the rules aren't being run post-conversion [18:20:13] it probably is a SQL attack, that's the way those Rooskies talk :p [18:20:47] they speak entirely in attacks! [18:22:22] Jeff_Green: Completely insane workaround, https://lists.owasp.org/pipermail/owasp-modsecurity-core-rule-set/2014-June/001582.html [18:22:40] yup yup [18:22:49] it's not insane [18:23:05] that's the place where I think it would be helpful to start getting other non-me folks involved [18:23:24] this is exactly how I'm fixing the PCRE expansion disaster rules [18:24:08] i think things will be a lot easier if we build a whitelist of things we want rather than whittling away the rules that don't work for us [18:27:30] Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops: Adjust modsecurity rules to work for us - https://phabricator.wikimedia.org/T110227#1572640 (awight) NEW [18:28:37] I have a hard time imagining what we would whitelist, like "any Russian text" is obviously not the answer. [18:29:15] dstrine-lunch: atgo-mee_: Considering pulling https://phabricator.wikimedia.org/T110227 into the sprint, it's a small thing we can do to help with PCI hell. [18:29:16] i have to study what the options are [18:29:53] but you can do sophisticated stuff with modsecurity--call out to external code, process text before analysing, etc etc [18:30:36] good. Developing apache modules is a little squirrely from what I remember, but doable if we need to. [18:31:05] My guess would be that regex tweaks are all we need, though. [18:31:36] ya maybe so [18:34:57] Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops: Adjust modsecurity rules to work for us - https://phabricator.wikimedia.org/T110227#1572681 (awight) [18:34:58] Fundraising Tech Backlog, Fundraising-Backlog, Epic: [epic] PCI gap analysis and Improvements - https://phabricator.wikimedia.org/T77912#1572680 (awight) [18:36:45] (PS4) Ejegg: Authorize and capture Amazon payment [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/231801 (https://phabricator.wikimedia.org/T108119) [18:41:28] (PS1) AndyRussG: Banner history: improved async dependencies and added comment [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/233767 [18:41:29] Fundraising-Backlog, Wikimedia-Fundraising, Epic: [epic] Amazon upgrade - https://phabricator.wikimedia.org/T87625#1572689 (MBeat33) [18:41:31] Fundraising-Backlog: [EPIC] Amazon embedded 1-hour test version - https://phabricator.wikimedia.org/T108106#1572688 (MBeat33) [18:41:32] Fundraising-Backlog: Parse Amazon last name data differently (or: review the way we receive Amazon name data) - https://phabricator.wikimedia.org/T86720#1572686 (MBeat33) declined>Open I ask only because when Zendesk ticket volume ramps up during big-EN these tickets take an inordinate amount of time t... [18:42:51] (PS2) AndyRussG: Reset .gitreview defaultbranch to master [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/233752 [18:42:55] Fundraising-Backlog: Parse Amazon last name data differently (or: review the way we receive Amazon name data) - https://phabricator.wikimedia.org/T86720#1572692 (atgo) a:atgo>None [18:43:43] cwdent|afk: ejegg: awight: https://gerrit.wikimedia.org/r/233767 https://gerrit.wikimedia.org/r/233752 :D [18:43:59] (The former just a tweak as I was adding a comment as a follow-on from CR.) [18:44:01] AndyRussG: taking a look! [18:44:06] Thanks! [18:45:29] Fundraising-Backlog: Parse Amazon last name data differently (or: review the way we receive Amazon name data) - https://phabricator.wikimedia.org/T86720#1572694 (awight) p:Low>Normal @MBeat33: Can you explain the impact this is having on your process? It sounds like the last name search only does pref... [18:58:33] Fundraising-Backlog: Parse Amazon last name data differently (or: review the way we receive Amazon name data) - https://phabricator.wikimedia.org/T86720#1572711 (MBeat33) @awight, Amazon gives us little for search parameters at their portal. If we need to locate a transaction in Civi it's basically a name se... [19:05:49] awight: is T110227 actively blocking anything? There are a lot of things still in progress in the sprint [19:06:18] Jeff_Green: ^ [19:06:36] I think it's blocking Jeff's progress on the WAF, but I'm not sure [19:08:26] awight: you already have 2 things in backlog. If this comes in should those be pushed out? [19:08:51] Fundraising-Backlog: Parse Amazon last name data differently (or: review the way we receive Amazon name data) - https://phabricator.wikimedia.org/T86720#1572793 (atgo) @awight why the uptick on priority? [19:09:45] dstrine: I'll wait to see what Jeff_Green says about blockingness... [19:10:00] looking [19:10:28] atgo: I increased the priority cos it makes a big difference in MBeat's workflow. "Low" doesn't seem right. [19:10:40] Also, there's a time constraint so it's not low urgency, either. [19:11:29] i suppose it should be considered a blocker for T91449 yeah [19:11:56] according to Tom we can use the WAF in detection-only mode [19:12:07] but we need to notify in the event of an attack [19:12:13] which is imo sort of nonsense [19:12:16] but there you have it [19:12:20] Fundraising-Backlog: 2015 Lila thank you email - https://phabricator.wikimedia.org/T110232#1572822 (Krenair) Looks Fundraising-related [19:12:24] Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops: Adjust modsecurity rules to work for us - https://phabricator.wikimedia.org/T110227#1572825 (awight) [19:21:51] Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops: Adjust modsecurity rules to work for us - https://phabricator.wikimedia.org/T110227#1572880 (Jgreen) We have so far: 1) OWASP Core Rule Set https://github.com/SpiderLabs/owasp-modsecurity-crs 2) several explody rules disabled via... [19:24:53] Fundraising Sprint Queen, Fundraising Sprint Rowlf the Dog, Fundraising Sprint The Pogues, Fundraising-Backlog, fundraising-tech-ops: Make DonationInterface fatal errors accessible - https://phabricator.wikimedia.org/T107918#1572895 (awight) [19:26:48] Anyone feel like taking a look at https://phabricator.wikimedia.org/T107918? [19:37:52] (PS5) Ejegg: Authorize and capture Amazon payment [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/231801 (https://phabricator.wikimedia.org/T108119) [19:39:54] Fundraising Sprint Queen, Fundraising Sprint Rowlf the Dog, Fundraising Sprint The Pogues, Fundraising-Backlog, fundraising-tech-ops: Log DonationInterface fatal errors to syslog - https://phabricator.wikimedia.org/T107918#1572960 (awight) [19:57:05] Fundraising Sprint Queen, Fundraising Sprint Rowlf the Dog, Fundraising Sprint The Pogues, Fundraising-Backlog, fundraising-tech-ops: Log DonationInterface fatal errors to syslog - https://phabricator.wikimedia.org/T107918#1573008 (awight) [20:01:24] (PS20) Cdentinger: Add BannerMixinHook tests. [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229422 [20:14:56] (PS1) Awight: Check Stomp API result [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/233833 (https://phabricator.wikimedia.org/T109901) [20:20:16] Fundraising Sprint Rowlf the Dog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Handle result of Amazon API calls - https://phabricator.wikimedia.org/T108123#1573086 (Ejegg) a:Ejegg [20:39:36] 450 Sansome Street, 14th Floor <-- world pay [20:39:43] cwdent: yep. neighbors :) [20:39:46] we even see them IRL sometimes [20:39:55] funny [20:41:02] this matt guy wants to talk on the phone, spose i'll oblige. atgo you think anyone else needs to be on there? [20:41:28] cwdent: what's the meeting about? [20:41:39] it might be good to loop in fr-tech and pats to all comms with them for record keeping [20:42:23] he just said "do you have time to talk" [20:42:47] hm... PPena? [20:42:49] ^ [20:43:16] i think whatever you feel like you need support on, cwdent. he's there to help make things smooth [20:44:03] sure, i'll just have him call me and if it gets out of scope i'll rope y'all in [20:44:08] yee haw [20:44:25] Fundraising-Backlog: 2015 Lila thank you email - https://phabricator.wikimedia.org/T110232#1573152 (atgo) a:atgo>None [20:45:25] cool cool :) [20:45:45] Fundraising-Backlog: 2015 Lila thank you email - https://phabricator.wikimedia.org/T110232#1573161 (atgo) a:MeganHernandez_WMF Thanks for the project assignment, @krenair @meganhernandez_WMF - I'm assigning this to you until the draft is fully completed. When it is, please remove yourself from the "assi... [20:46:55] hey dstrine - do you think you can wrangle the email summary/question about PCI stuff? [21:01:18] atgo: he just wanted to understand what we are doing [21:01:38] which is to say we want ESOP because we can't do the other without the PCI merit badge [21:01:47] ahh [21:04:19] awight: are you free for a chat? [21:04:37] cwdent: looks great! Just one... more... detail! :) You need the { path: '/' } on the $.removeCookie calls https://github.com/carhartl/jquery-cookie [21:04:53] whoops! i'll get that in [21:05:04] thx! [21:09:22] Fundraising Sprint The Pogues, Fundraising-Backlog, Astropay Integration, Patch-For-Review, WorkTypeNewFunctionality: Parse AstroPay error codes / description and display appropriate messages to donor - https://phabricator.wikimedia.org/T106053#1573264 (DStrine) [21:11:28] Fundraising Sprint Queen, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, WorkTypeNewFunctionality: Implement Amazon wallet widget - https://phabricator.wikimedia.org/T108116#1573272 (DStrine) [21:11:55] Fundraising Sprint Queen, Fundraising-Backlog, Patch-For-Review, WorkTypeNewFunctionality: Switch Amazon to use Mustache form, load custom JS and widgets - https://phabricator.wikimedia.org/T108114#1573273 (DStrine) [21:13:33] Fundraising Sprint Queen, Fundraising-Backlog, Patch-For-Review: Switch Amazon to use Mustache form, load custom JS and widgets - https://phabricator.wikimedia.org/T108114#1512518 (DStrine) [21:15:59] Fundraising Sprint Queen, Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, WorkTypeNewFunctionality: Test coverage for GeoIP module - https://phabricator.wikimedia.org/T107359#1573291 (DStrine) [21:17:13] Fundraising Sprint The Pogues, Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: Modify DonationInterface limbo code for high availability deployment - https://phabricator.wikimedia.org/T104499#1573292 (DStrine) [21:18:00] Fundraising Sprint The Pogues, Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, and 4 others: Eliminate PHP backend call for Special:RecordImpression - https://phabricator.wikimedia.org/T106624#1573293 (DStrine) [21:18:36] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, and 6 others: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1573295 (DStrine) [21:20:12] Fundraising Sprint The Pogues, Fundraising-Backlog, Astropay Integration, Patch-For-Review, WorkTypeNewFunctionality: Add 'loading' indicator to AstroPay form - https://phabricator.wikimedia.org/T107321#1573301 (DStrine) [21:22:59] Fundraising Sprint The Pogues, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, WorkTypeNewFunctionality: Add Square to the list of gateways in the Gateway Reconciliation report - https://phabricator.wikimedia.org/T107224#1573304 (DStrine) [21:23:16] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint The Pogues, and 5 others: Populate an hour of limbo queue in the new Redis store - https://phabricator.wikimedia.org/T106906#1573305 (DStrine) [21:23:36] Fundraising Sprint The Pogues, Fundraising-Backlog, Astropay Integration, Patch-For-Review, WorkTypeNewFunctionality: Expand Astropay audit to include Mexico - https://phabricator.wikimedia.org/T105906#1573306 (DStrine) [21:23:50] Fundraising Sprint ODB, Fundraising Sprint The Pogues, Fundraising-Backlog, Astropay Integration, and 2 others: Validate CPF for AstroPay - https://phabricator.wikimedia.org/T106171#1573307 (DStrine) [21:24:02] Fundraising Sprint ODB, Fundraising Sprint The Pogues, Fundraising-Backlog, Astropay Integration, and 2 others: Update Brazil fiscal number to CPF - https://phabricator.wikimedia.org/T106137#1573308 (DStrine) [21:24:17] Fundraising Sprint Queen, Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, and 5 others: Stop writing to ActiveMQ once orphan slaying on Redis has been tested - https://phabricator.wikimedia.org/T99018#1573312 (DStrine) [21:24:43] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint The Pogues, and 5 others: Orphan slayer reads from frack Redis rather than ActiveMQ - https://phabricator.wikimedia.org/T99017#1573313 (DStrine) [21:25:38] * atgo wishes she could mute dstrine's phabricator activity [21:26:10] * atgo checks [21:26:18] * atgo sighs [21:26:26] thanks for nothing, phabricator. [21:32:41] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic: [epic] Banner History MVP - https://phabricator.wikimedia.org/T78089#1573339 (atgo) [21:33:33] dstrine: This guy: http://www.jameshance.com/ [21:34:08] K4-713: dstrine your meeting looks more fun than mine. [21:34:21] aw [21:34:27] I WANT ALL OF THESE [21:34:41] atgo: you were all complain-y before [21:35:05] dstrine: That's pretty much what I said, when I discovered him through Wookiee the Chew. [21:35:39] Fundraising-Backlog: Deploy 2015 Lila thank you email - https://phabricator.wikimedia.org/T110232#1573350 (atgo) [21:39:47] the's so prolific [21:40:05] this will be the source for so many birthday and christmas gifts [21:41:40] :) [21:42:16] Sometimes, he posts works in progress on his FB page, and auctions off the original on ebay when he's finished. [21:47:02] (PS3) AndyRussG: Reset .gitreview defaultbranch to master [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/233752 [21:47:42] (CR) AndyRussG: [C: 2 V: 2] "Just a .gitreview change" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/233752 (owner: AndyRussG) [21:50:34] ejegg|mtg: that seemed useful! [21:50:38] right? [21:50:47] yeah, definitely! [21:51:13] Especially that bits about other changes needed in the SDK to use it for reports [21:51:22] yeah totally [21:51:28] i like how proactive he's being [21:51:33] may all matt's be so helpful :P [21:51:40] Heh, yeah [21:53:14] K4-713: /me hints that my kid is size 3 [21:53:56] (Merged) jenkins-bot: Reset .gitreview defaultbranch to master [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/233752 (owner: AndyRussG) [21:54:43] my matt sounded like a surfer bro [21:54:55] but that might just be how californians sound to me [21:55:06] yeah, not much we can do [21:55:19] rounded vowels up the greenroom [21:55:40] Plus: that's better than the ones who you can't read [21:59:19] dstrine: wow, I'm so sorry about the meeting--I've been thinking it was at 3 all along... [21:59:37] I'm free if you still interested. [22:00:14] Katie and I did a pass on the closed tasks from the last 2 sprints: https://phabricator.wikimedia.org/maniphest/query/oVFAiB1yVmVt/#R [22:00:17] that's all of them [22:00:48] we figured it would be easier to tag the new stuff lol [22:00:57] this is just the new stuff filtered down: https://phabricator.wikimedia.org/maniphest/query/4128KxwkahmM/#R [22:00:59] :) [22:01:21] So I see you're tagging all subtasks as well [22:01:42] Hmmm somehow can't submit the merge [22:01:46] Since it doesn't create a new commit [22:01:52] we were just trying this [22:02:05] here is the work that couldn't be clearly labeled as new: https://phabricator.wikimedia.org/maniphest/query/k9M6S6HXTTcT/#R [22:02:15] amazon is in a weird middle ground [22:02:25] XenoRyet: I found the issue, it's silly. rm srv/org.wikimedia.civicrm/sites/default/settings.php [22:02:30] "No changes between HEAD and origin/master. Submitting for review would [22:02:30] be pointless" [22:02:33] not the database :) [22:02:49] I love that we can filter [22:02:59] Alright, let me try that. [22:03:30] AndyRussG: sounds like it was a fast-forward merge? [22:04:05] you can force the branch, with "git push gerrit HEAD:refs/for/master" [22:04:29] err, which doesn't force it like -f, just makes the branch explicit [22:04:54] can you git log -1 HEAD and origin/master? [22:05:28] maybe you're in a merge conflict? [22:05:36] git status say anything unusual? [22:05:54] Paypal is being paypal again [22:06:09] atgo: awight: ^ [22:06:47] dstrine: that looks less of a problem than 'major impact to live site' [22:06:48] this doesn't sound as bad [22:06:55] yeah [22:07:21] let's wait and see if the audit parser gets indigestion [22:07:51] Nah let's disable it like they recommend. [22:07:52] I'm generally entertained by most of the sentences in this chat :) [22:08:00] awight: ok [22:08:02] I don't want to have to backfill incorrect data [22:08:13] "some reports may reflect incorrect gross amount for some transactions." [22:08:19] nice that they noticed!! [22:08:20] ooh, right. I just got to that bit [22:08:55] I'll disable the downloader as well... [22:09:13] oh, you got it? [22:09:22] yeah, will disable both [22:09:45] awesome, thank you [22:10:54] !log disabled paypal audit downloader and parser due to them warning of incorrect data [22:10:59] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:12:17] is this all backend? will donors or anyone in fr-online see something? [22:12:31] dstrine: all backend [22:12:38] kk [22:13:16] (PS21) Cdentinger: Add BannerMixinHook tests. [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229422 [22:15:25] awight: no git status is cool [22:15:32] $ git status [22:15:32] On branch master [22:15:32] Your branch is ahead of 'origin/master' by 35 commits. [22:15:32] (use "git push" to publish your local commits) [22:15:32] nothing to commit, working directory clean [22:16:39] awight: No dice, still getting the same error. Destroy and recreate didn't get it done either. [22:16:43] awight: maybe it'll be easier to undo if it's really its own commit? [22:16:58] that is certainly not "No changes", that's 35 freaking changes. [22:17:11] Did the git push work? That circumvents all the git-review garbage. [22:20:47] awight: I'm hesitant 'cause I'd like to have a real commit to be able to revert... or does that make no sense? [22:23:11] I agree, but I don't think you get that with any type of merge except --squash [22:23:24] (CR) AndyRussG: [C: 2] "Woohoo!!! \o/" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229422 (owner: Cdentinger) [22:24:04] Donno if this helps, https://github.com/git/git/blob/master/Documentation/howto/revert-a-faulty-merge.txt [22:24:20] awight: what will the commit message say? It'll be the same as the commit message of the tip of campaign_mixins branch. That'll be confusing [22:24:22] (Merged) jenkins-bot: Add BannerMixinHook tests. [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/229422 (owner: Cdentinger) [22:24:57] hooray [22:25:07] ino [22:25:07] :D [22:25:26] I don't think the merge commit makes a bit of different wrt revert, though [22:25:34] awight: K [22:25:35] unless you do --squash, which is probably not what u want [22:25:43] https://img.4plebs.org/boards/pol/image/1411/67/1411676201464.gif [22:25:51] awight: if anyone ever tries to search for it in the log, they'll be all WTF [22:26:16] yep [22:27:50] heh yeah I recall seeing that post once before, "reverting the revert" [22:28:13] * AndyRussG skims for already-seen phrases [22:29:02] oh yeah, that's the one about "git squashing the elephant" and "git mud-wrestling" too [22:29:03] jk [22:29:31] It's a pretty unhealthy length... that's how you know Linus is hiding something [22:31:24] heheh [22:31:37] awight: looks like there's an option: git merge --no-ff [22:32:26] Good call. That solves the log issue, if not the revert one [22:32:39] yeah but it sounds like revert is just whatever anyway [22:32:51] seriously. [22:33:31] Probably worth preparing one as DO NOT MERGE, if you have any doubts about a major CentralNotice rewrite working correctly the first try :) [22:33:35] http://git-man-page-generator.lokaltog.net/ [22:33:51] such an amazing script [22:34:50] yeah it really rides the line of coherence [22:34:54] just like the actual docs [22:35:09] hahahah [22:37:16] (PS1) AndyRussG: Merge branch 'campaign_mixins' [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/233869 (https://phabricator.wikimedia.org/T78089) [22:38:57] (PS2) Ejegg: Banner history: improved async dependencies and added comment [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/233767 (owner: AndyRussG) [22:39:17] (CR) Ejegg: [C: 2] Banner history: improved async dependencies and added comment [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/233767 (owner: AndyRussG) [22:40:18] Mmm one sec then :) [22:40:33] (Merged) jenkins-bot: Banner history: improved async dependencies and added comment [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/233767 (owner: AndyRussG) [22:42:19] ejegg: cool, thx! [22:44:03] ty for the explanation! [22:48:07] (PS2) AndyRussG: Merge branch 'campaign_mixins' [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/233869 (https://phabricator.wikimedia.org/T78089) [22:49:43] Arg internet connectivity silliness [22:53:15] I can't imagine anything called "Videotron" ever flaking out. Betamax? [22:57:08] awight: Videotron is a fantastic ISP hahahah not really [22:57:16] They used to be just the cable company around here [22:57:25] Now they have us for everything... [22:57:39] The flakiness was actually due to the microwave being on, though! [22:59:13] now that's RF leakage ... and sort of distressing [23:00:07] yeah that's nuts [23:03:30] hilarious! Hope you run that thing in its own wing [23:03:43] My kid loves watching the microwave :( [23:04:12] Just right for her attention span, I think. 90 seconds later, It's ready!! [23:06:48] https://twitter.com/avestal/status/635633671131652097 [23:11:44] it is distressing! isn't it supposed to happen, though? [23:12:42] I've never had a microwave interfere with wifi [23:15:42] some day I'm going to get one of these for public transportation: http://www.jammer-store.com/2g-3g-4g-lte-phone-jammer.html [23:16:52] nice [23:16:58] rogue social facilitator [23:17:01] http://www.ladyada.net/make/wavebubble/ trading $1000 labor for $500 price point tho [23:20:54] awight: Sorry to drag you back into this, but removing that settings.php file didn't work for me. Still ended up with the same error. [23:21:01] any other ideas? [23:21:15] destroy and re-up then, i guess [23:21:46] Tried that as well, no joy there either. Same error keeps coming around. [23:22:02] okay lemme try to reproduce locally [23:22:07] 10-4 [23:26:10] dstrine: did you say something about unexpected stuff showing up? Someone ordered a pizza for me using a wikimedia e-mail address [23:26:33] lol umm did it already show up at your house? [23:26:49] how do you know this? [23:26:55] lol [23:27:00] * dstrine uses shifty eyes [23:27:02] haha [23:27:04] time zones! [23:27:23] nooo this is worse than timezones [23:27:28] that reminds me of all the lives saved by carbombs with trick 24-hour clocks [23:27:35] dstrine: a pizza restaurant called me and asked if I had ordered a pizza for 12:55 pm. Since my wife was out, I thought maybe she had, and had made a mistake with the time zone [23:27:54] sorry 12:55 am [23:28:12] it was ordered for 12:55 am [23:28:13] well i gotta jet, later! [23:28:13] um they should be delivering it tomorrow at 10am pst what timezone are you in? [23:29:35] dstrine: well, we're eating it now. I thought it was credit card fraud. Just gonna call the place back to tell them that it wasn't 8p [23:29:39] dstrine: and thanks! [23:29:47] lolollol [23:29:50] awe crap [23:29:56] ok [23:30:06] Heh, my pizza came today too. [23:30:21] I'll save some leftovers for tomorrow though ;-) [23:30:30] well tomorrow...in our meeting.. imagine something was delivered magically at just the right time [23:30:38] noooo [23:30:40] ds;afdjalkjfdkls [23:30:41] asdlk;fadjskfj;dlkf [23:30:58] oh man this is going to be interesting [23:31:20] we have people in london and Paris too... I wonder what they will get [23:31:25] Na, it'll be fun. Surprise pizza just behaving in a little more surprising way than you thought. [23:31:26] (PS1) Awight: Clean up orphan classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/233877 [23:31:37] Good pizza though, thanks. [23:31:43] fuck [23:31:44] dstrine: OK I'll imagine that! it's pretty good pizza, yeah [23:31:54] (CR) jenkins-bot: [V: -1] Clean up orphan classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/233877 (owner: Awight) [23:31:56] thanks for playing guys [23:32:13] * awight lunges at imaginary pizza [23:32:42] awight: who knows when you'll get yours [23:33:11] (PS2) Awight: Clean up orphan classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/233877 [23:33:14] dstrine: oh, I got a notification for a delivery at 3:20, but nothing came. [23:33:14] gotta rethink this sorta thing next time [23:33:25] WHAT [23:33:36] The food delivery industry just maybe isn't ready for an internationally coordinated pizza delivery effort. [23:33:38] for the record, I did not actually do the ordering [23:33:46] it's already sort of a reverse party, you're treating us to celebrating your own vacation :D [23:33:50] i thought maybe you had my number in the account and it was a notification for /your/ lunch [23:34:44] you think there's a Pie in the Sky company that delivers via paraglider? [23:34:46] XenoRyet: this is true ... we'll probably get this sort of thing just after the flying car [23:35:10] oooh actually amazon drone deliveries should totally solve this [23:36:17] well this was a good test [23:36:28] failure is information [23:36:37] pizza is always still pizza [23:37:42] pizza is a constant containing more delicious constants [23:38:34] "pizza like objects" and "burrito like objects" are found in almost every culture [23:39:01] bread-as-a-handle [23:39:22] Yep, everyone has a tasty flatbread type dish. [23:39:38] * K4-713 looks around for snacks [23:40:26] K gonna eat now, thanks dstrine! [23:41:10] nomnomnommm [23:41:18] save some for leftovers for tomorrow!