[01:59:23] (PS2) Ejegg: Really don't do session stuff in batch mode [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234717 (owner: Awight) [01:59:35] (CR) Ejegg: [C: 2] Really don't do session stuff in batch mode [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234717 (owner: Awight) [02:00:09] (Merged) jenkins-bot: Really don't do session stuff in batch mode [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234717 (owner: Awight) [10:53:12] Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: Publishing translations for central notice banners fails - https://phabricator.wikimedia.org/T104774#1588875 (jrobell) Thanks everyone for looking into this. I am still havin... [11:08:03] TCB-Team-Fundraising-Sprint-2015-08-26, TCB-Team: [WMDE-Fundraising] Remove unused templates from content staging wiki - https://phabricator.wikimedia.org/T110322#1588899 (WMDE-Fisch) a:WMDE-Fisch [14:50:15] TCB-Team-Fundraising-Sprint-2015-08-26, TCB-Team: [WMDE-Fundraising] Determine current tracking waypoints and identify missing ones - https://phabricator.wikimedia.org/T110318#1589328 (WMDE-leszek) a:WMDE-leszek [16:52:49] ejegg: Sorry to burn up the weekend like you were trying to avoid... [16:52:56] Anything I can do to help? CR, testing? [16:53:24] Hi awight! [16:53:40] aftermorn! [16:54:22] OK, let me squash your typo fix into my original refund commit. Anything else you think should squash together? [16:56:13] don't matter to me, I'm fine reviewing as-is [16:56:28] I don't think we'll be reverting to any of the intervening commits [16:56:56] (PS4) Ejegg: More refund logic tweaks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234672 (https://phabricator.wikimedia.org/T110367) [16:57:18] awight: ok, let's review 'em as they are [16:58:27] lemme just see if there's more to address from your initial comments [17:00:41] awight: you wanted more discussion on making doRefund public like doPayemnt? And maybe throw exceptions on failure instead of returning a failed PaymentResult? [17:05:26] morning awight! [17:05:41] are you coming upstairs, or did you decide not to since Katie’s here? [17:17:22] Question about length of translations https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Donate_interface-donor-zip/en_length [17:18:22] Nemo_bis: Oh, good catch. We should take a look at the form and see how broken it looks for the outsized ones [17:25:58] Nemo_bis: Yeah, doesn't look so good http://ejegg.com/zip_truncate.png [17:26:33] But maybe 10 chars is the real limit, depending on character width [17:28:28] (PS1) Ejegg: Set errors on failed PaymentResult [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/235045 [17:28:49] (CR) jenkins-bot: [V: -1] Set errors on failed PaymentResult [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/235045 (owner: Ejegg) [17:29:53] ejegg: I updated docs, what to do with existing translations? [17:30:22] does marking them 'fuzzy' put them on the list for re-translation? [17:30:30] yes, more or less [17:31:00] But there is a chance that translators don't understand why [17:31:27] In the screnshot, it looks like wrapping could be possible. No idea how space sensitive the form is [17:32:00] Ahh, should we put the length restriction in all caps? [17:32:03] heh [17:32:29] The form is kind of responsive - on a little screen each box gets its own line [17:33:14] but on a medium size screen we show the jimmy wales quote on the left half and put the city/state/zip on one line as displayed in the screenshot [17:33:33] https://payments.wikimedia.org/index.php?title=Special:GlobalCollectGateway&appeal=JimmyQuote&ffname=cc-vmad&recurring=&payment_method=cc&utm_source=Waystogive.default~default~default~default~control.cc&utm_medium=Waystogive&utm_campaign=C11_Waystogive&utm_key=&referrer=&language=hsb&country=US&returnto=Thank_You%2Fhsb&amountGiven=¤cy_code=USD&frequency=onetime&amount=3&uselang=hsb [17:33:55] whew, gotta love them payment form urls [17:34:41] back now! [17:35:28] (PS6) Awight: GlobalCollect refund API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234459 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg) [17:35:49] (CR) Awight: [C: 2] "do not deploy this version, must include followon patches." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234459 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg) [17:35:57] (PS3) Awight: Correct typos [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234470 [17:36:08] (PS3) Awight: Tweak the cancel/refund logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234474 (https://phabricator.wikimedia.org/T110367) [17:36:14] (PS3) Awight: Cancel subscriptions programatically [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234476 (https://phabricator.wikimedia.org/T110367) [17:36:17] (Merged) jenkins-bot: GlobalCollect refund API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234459 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg) [17:36:19] (PS5) Awight: More refund logic tweaks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234672 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg) [17:36:38] (CR) Ejegg: [C: 2] "Thanks for the fixes!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234470 (owner: Awight) [17:37:20] (Merged) jenkins-bot: Correct typos [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234470 (owner: Awight) [17:37:26] ejegg: My comments about the doPayment stuff etc should wait for the future... maybe we should use the DI refactor page to have those discussions? [17:39:17] (CR) Ejegg: [C: 2] "Good to have the new statuses! Not going to fight a new American revolution over the double Ls :P" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234474 (https://phabricator.wikimedia.org/T110367) (owner: Awight) [17:39:33] awight: sounds good [17:39:51] (Merged) jenkins-bot: Tweak the cancel/refund logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234474 (https://phabricator.wikimedia.org/T110367) (owner: Awight) [17:40:54] awight, ejegg: anything familiar sounding about this? "DOMDocument::loadXML(): EntityRef: expecting ';' in Entity, line: 1 in /srv/DonationInterface/gateway_common/gateway.adapter.php on line 1572 " [17:41:00] (CR) Ejegg: [C: 2] "Reiterating previous comment, we should split this operation off from refunding payments, but that can wait for another patch" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234476 (https://phabricator.wikimedia.org/T110367) (owner: Awight) [17:41:03] trying to load xml from WP [17:41:24] (Merged) jenkins-bot: Cancel subscriptions programatically [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234476 (https://phabricator.wikimedia.org/T110367) (owner: Awight) [17:41:26] cwdent: can you dump that xml somewhere private? [17:41:28] cwdent: eew, WP sending us bad entities? [17:41:34] that doesn't ring a bell [17:41:47] unescaped ampersand, I guess [17:46:07] cwdent: Here's some mud to sling: http://www.w3.org/TR/2000/REC-xml-20001006#syntax [17:48:33] awight: just the caboose left on the refund train - https://gerrit.wikimedia.org/r/234672 [17:49:18] yes! going over it now, it looks good [17:49:29] scary though, we definitely hit a wall with the final status stuff [17:49:36] heh, sorry to pester [17:50:00] no way! This and the orphan recovery are top o' my list [17:50:21] Did you happen to run this job already? [17:50:40] awight: yeah, seemed to work for refunding the payments [17:50:49] oh! [17:50:53] ha ok good [17:50:57] great [17:51:11] but neither cancel_order nor end_order went through with the refund requests still active [17:51:24] wait. that sucks [17:51:32] it's much more expensive to refund than to cancel [17:52:01] we gotta call them on that [17:52:20] awight: Right, I ran it with your patch to try cancel_payment before do_refund [17:53:07] but closing out the subscription didn't work while there were still not-fully-settled / not-fully-refunded payment attempts [17:53:24] ooh sorry I see, cancel_order vs cancel_payment [17:53:38] luckily that stuff is idempotent, we can run the same batch again [17:53:56] yah, I figured we'd do that today or tomorrow, once the refunds are done [17:54:23] but that was the reason for my 'split the operations' comment [17:54:32] ah, thx [17:56:46] should we also drop messages in the refund queue? I see a comment in the audit parser saying it's not cool enough to handle recurring yet [17:56:58] rats. [17:57:40] Maybe the first thing to fix is the audit processing. [17:58:03] heh, get K4's masterpiece across the finish line? [17:58:13] (CR) Awight: [C: 2] "The negative refund ID really worries me, everything else looks great and I hear it even works." (6 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234672 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg) [17:58:24] I think I have a supersize RV of commits on that topic [17:58:33] heh [18:00:24] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Refund payment and cancel subscription scripts should be separate - https://phabricator.wikimedia.org/T110917#1589924 (awight) NEW [18:00:34] (CR) Awight: "Yes, let's split the operations! I'll leave breadcrumbs in Phabricator: T110917" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234476 (https://phabricator.wikimedia.org/T110367) (owner: Awight) [18:01:25] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Refund payment and cancel subscription scripts should be separate - https://phabricator.wikimedia.org/T110917#1589934 (awight) p:Triage>Normal [18:02:21] (Merged) jenkins-bot: More refund logic tweaks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234672 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg) [18:02:41] (CR) Ejegg: More refund logic tweaks (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234672 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg) [18:04:28] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Gateway adapter final status should be flexible enough to handle refunds - https://phabricator.wikimedia.org/T110919#1589957 (awight) NEW [18:06:16] (CR) Awight: More refund logic tweaks (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234672 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg) [18:08:36] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Spike: confirm effort_id handling during refund processing - https://phabricator.wikimedia.org/T110920#1589972 (awight) NEW [18:12:48] (PS3) Awight: WIP New maintenance scripts for manipulating GC charges [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234417 (https://phabricator.wikimedia.org/T109668) [18:15:30] (CR) jenkins-bot: [V: -1] WIP New maintenance scripts for manipulating GC charges [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234417 (https://phabricator.wikimedia.org/T109668) (owner: Awight) [18:24:42] (PS2) Ejegg: Set errors on failed PaymentResult [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/235045 [18:26:47] (CR) Awight: [C: 2] "Great, more errorful!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/235045 (owner: Ejegg) [18:29:18] (Merged) jenkins-bot: Set errors on failed PaymentResult [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/235045 (owner: Ejegg) [18:49:31] (PS1) Ejegg: Add amount and currency to Amazon API post [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/235057 (https://phabricator.wikimedia.org/T108123) [18:50:00] (PS2) Ejegg: WIP respond to status [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/233993 [19:15:40] (CR) Awight: [C: -1] Add amount and currency to Amazon API post (1 comment) [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/235057 (https://phabricator.wikimedia.org/T108123) (owner: Ejegg) [19:16:50] AndyRussG: Hi! [19:16:56] Anything I can help with today? [19:20:34] (PS2) Ejegg: Add amount and currency to Amazon API post [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/235057 (https://phabricator.wikimedia.org/T108123) [19:22:02] (CR) Ejegg: "d'oh! Same mistake as I made with the refund script. Maybe this time it'll sink in." (1 comment) [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/235057 (https://phabricator.wikimedia.org/T108123) (owner: Ejegg) [19:22:27] (CR) Awight: [C: 2] Add amount and currency to Amazon API post [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/235057 (https://phabricator.wikimedia.org/T108123) (owner: Ejegg) [19:24:30] awight|eat: hi! mmm not yet, soooon tho I think [19:24:50] ok holler [19:25:33] K will do! ¡Provecho! [19:30:49] (Merged) jenkins-bot: Add amount and currency to Amazon API post [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/235057 (https://phabricator.wikimedia.org/T108123) (owner: Ejegg) [19:46:27] (CR) Ejegg: "Heh, RapidHTML's way of localizing the forms was a big part of what we went to Mustache to avoid! See: worldpay_gateway/forms/_personal-i" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234579 (owner: Cdentinger) [20:04:58] awight|eat: pavucontrol [20:07:28] ejegg: https://www.debian-administration.org/article/165/Mounting_remote_filesystems_with_smbfs [20:40:09] hi eileen! [20:41:35] ejegg: Hey! [20:42:01] I hear you're going to solve all our CRM problems :) [20:42:08] ah right... [20:42:08] ejegg: you're definitely on VPN, right? [20:42:10] eileen: hi! [20:42:15] hey awight [20:42:29] I am waiting for me WMF laptop to get onto VPN [20:42:31] awight: yep, i'll figure it out [20:42:37] yep, domain=WORKGROUP [20:42:43] hoping the postie will bring it this morning [20:42:48] eileen: no rush on that stuff [20:43:13] There's plenty of gasping in horror at the state of things u can do before checking in any code ;) [20:43:21] :-) [20:43:29] I don't suppose you got off 4.2.... [20:43:29] ? [20:43:32] nope! [20:43:36] sadly, not yet [20:43:52] I was afraid of that [20:44:21] eileen: I was openly hoping you might want to lead that push. I can be available to do any of the low-level patch stuff [20:45:10] ok - where is it at? Are there known issues to be resolved? Or is the testing path not clear? [20:45:36] There are two issues I'm worried about, otherwise I think we're in pretty good shape. [20:45:48] first, we have a metric ton of unupstreamed patches [20:46:11] ah ok - I can definitely start tackling that [20:47:01] then, I'm concerned about our modules. We use every flavor of API, and do a lot of contribution things which are affected by the financial type migration. [20:47:27] When I tested the upgrade about 1.5 years ago, the financial vs contribution type thing burned, badly. [20:47:51] ok - so stuff needs testing - unknown fallout [20:48:07] eileen: http://git.wikimedia.org/tree/wikimedia%2Ffundraising%2Fcrm%2Fcivicrm.git/dbeff641f99bfa73fd820e20ccd61ebb822a5d25/patches [20:48:11] Is the plan still to go to 4.4 or given 4.6 being about to become the LTS will you go there? [20:48:19] You tell us! [20:48:45] The only WMF factor is that there's a lot of pressure to use the Giant Rabbit reporting code, which was written for 4.4 [20:49:01] I assume it's pretty simple to port from 4.4 to 4.6, though? [20:49:24] yeah - that's mostly contained to the report classes isn't it? [20:49:35] Are you guys on d6? [20:49:42] https://phabricator.wikimedia.org/T99837 [20:49:47] praise allah no, d7 [20:50:43] ah - I was wondering about the d6 in here http://git.wikimedia.org/blob/wikimedia%2Ffundraising%2Fcrm%2Fcivicrm.git/dbeff641f99bfa73fd820e20ccd61ebb822a5d25/patches%2Fcivicrm-4.1.1-drupal6-wmf.patch [20:51:21] that's archival [20:51:36] we're on 4.2.19, d7 [20:52:31] cwdent: omg, I just realized that Worldpay probably can't fix the bad xml cos all their other clients are relying on it. [20:52:43] there's another 2 weeks of pointless discussion [20:52:55] awight: yeah i wondered about that [20:52:59] :-) [20:53:00] aw jeez, workarounds for everybody! [20:53:09] this... isn't even workaroundable [20:53:23] however i think the case can be made "srsly guise it's in the spec" [20:53:24] we would have to find an xml parser that doesn't adhere to the spec [20:53:41] they can add the special case for us vs. the inverse [20:53:55] cwdent: well, that happened just a few months ago and ejegg had to walk backwards spider to break the spec on our end [20:54:16] ack, the encoding crap [20:54:18] =[ [20:54:44] yeah, that was no fun. I got to learn about some cool transliteration utilities though! [20:55:51] well i'm excited to see their answer anyway [20:55:53] should be entertaining [20:56:49] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Prepare CiviCRM 4.4 upstream and Giant Rabbit branches - https://phabricator.wikimedia.org/T99837#1590620 (awight) [20:57:01] eileen: here's a link to Giant Rabbit's reporting patch ^ [20:59:15] awight: from here https://phabricator.wikimedia.org/T99836 there is a 'here' link - but that changeset doesn't seem related in the way the other list did... [21:00:10] oh thx, that's bad copypasta! [21:01:15] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Triage what to do with civi-core patches: extensions, upstream, or abandon - https://phabricator.wikimedia.org/T99836#1590633 (awight) [21:01:24] eileen: updated now [21:02:20] Fundraising Sprint Rowlf the Dog, Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Triage what to do with civi-core patches: extensions, upstream, or abandon - https://phabricator.wikimedia.org/T99836#1300095 (awight) [21:04:11] so - how do we track things back - e.g this one https://gerrit.wikimedia.org/r/#/c/212447/1/patches/civicrm-4.2.19-drupal-wmf-big-fields.patch [21:04:21] is obviously because the core fields are too small [21:04:36] & we would need to 'make a case' for it for core [21:04:46] but, I'm not sure the reason [21:06:02] & then how would you break down a long list like that to track it? Create an issue for each one? [21:06:19] Hmm, international-friendly postal codes and longer email addresses seem pretty handy for anyone [21:07:35] so there are a bunch of countries that have longer than 12 & you just picked 64 as a 'bigger number'? [21:07:37] Is it expected to have a github issue for any suggested change to core? [21:07:48] JIRA [21:08:02] https://issues.civicrm.org/jira/secure/Dashboard.jspa [21:08:04] That particular patch predates me! [21:09:05] I guess if I had an example of something longer than the defaults then that would give enough to log to JIRA & fix upstream [21:09:32] sorry longer than core fields [21:10:52] huh, yeah, i'm looking at formats online but not seeing anything over 12. Lemme see what kind of jumbo ones we've got [21:13:24] eileen: I think I did file some bugs and patches for the field lengths... [21:13:52] To answer the bigger question though, yeah we could either create tasks for each one, or track all the work on a single wiki page somewhere. [21:14:24] It's probably best to keep the overhead, friction and confusion to a minimum, so IMO we should just create patches and JIRA tickets [21:15:11] awight: yeah - I'm inclined to review each patch & create a JIRA ticket for each one [21:15:17] & then use a label in JIRA [21:15:28] so we can see the list of 'still to be upstreamed' there [21:15:34] eileen: here's one, https://issues.civicrm.org/jira/browse/CRM-13326?jql=reporter%20in%20%28currentUser%28%29%29 [21:16:12] ok sweet that is in 4.4 [21:16:53] eileen: this is horrible, but https://issues.civicrm.org/jira/issues/?jql=reporter%20in%20%28adamw%29 [21:16:56] any reason I shouldn't add the label 'wmf' to the JIRA tickets we want to track? [21:17:17] would contain anything in our patch list which I tried to upstream [21:17:26] eileen: sounds good to me--or maybe wmf-4.4? [21:17:41] meh I have no opinion on that [21:17:49] I'll add wmf for now & can change later if we want [21:18:13] awesome! yeah I'm sure we'll have an ongoing tally well beyond 4.4 [21:18:48] https://issues.civicrm.org/jira/browse/CRM-14232?jql=reporter%20in%20%28adamw%29 [21:19:00] (I tend to use adding & removing labels a bit like a to-do list in JIRA since assigning them to me implies I will do them :-) [21:19:24] huh, couple of nordic countries seem to tack the region name on to the alphanumeric code, and a lot of the Japanese ones use double-byte numerals. [21:19:41] https://issues.civicrm.org/jira/browse/CRM-12341 [21:19:54] ejegg: what codes are these? [21:20:30] just looking in civicrm_address for length(rtrim(postal_code)) > 12 [21:20:31] postal codes [21:20:31] https://issues.civicrm.org/jira/browse/CRM-11551?jql=reporter%20in%20%28adamw%29 [21:20:45] ejegg: oh hehe postal workers are crazy [21:21:01] https://issues.civicrm.org/jira/browse/CRM-11558?jql=reporter%20in%20%28adamw%29 [21:21:39] ejegg: what is the longest postal_code? [21:23:52] well, let me toss out this joker who pasted lorem ipsum into all the fields and see what else we've got [21:24:19] :-) [21:24:51] eileen: I'm tagging closed bugs too, hopefully that makes it easier to compare with our list of patches. [21:26:31] awight: yeah - I think the idea is to go through the list of patches & ensure that each one is either fixed in 4.4 AND 4.6 or there is a tagged JIRA issue [21:28:38] If I want to add a comment to the patch do I need to edit the patch? [21:28:39] https://gerrit.wikimedia.org/r/#/c/212447/1/patches/civicrm-4.2.19-drupal-wmf-big-fields.patch [21:29:34] hmm & which password is gerrit...... [21:29:41] oh man, our data is so dirty. The longest I can see that was at all intentional was a 30-char bit that included the nearby intersections. [21:30:02] eileen: yeah, once you're logged in you can just double-click in that patch view to leave comments. [21:30:07] Sorry we're in Gerrit. [21:30:21] looks like we have or had some kind of bug that appended email address to zip code for some forms. That bears investigating! [21:30:37] You'll probably have to make a login there, see https://wikitech.wikimedia.org/w/index.php?title=Special:UserLogin&type=signup&returnto=Main+Page [21:30:39] hmm - so it's not clear how long a 'valid' post code could be [21:32:02] hmm - that's not it... [21:32:04] Account creation error [21:32:04] The user name "EMcnaughton (WMF)" has been banned from creation. It matches the following blacklist entry: .*WMF.* [21:32:21] d'oh [21:32:26] or is that username only for 'other things' [21:32:45] I'm not totally clear on this, ops had to merge my usernames cos I did something naughty it seems [21:33:05] try joining #wikmedia-dev and asking ^d [21:33:30] not around. looking for more volunteers... [21:34:21] eileen: https://www.mediawiki.org/wiki/Gerrit/Getting_started [21:34:37] says to just create an account on wikitech... try making a username w/o WMF? [21:34:40] sorry! [21:37:27] Ok - that worked I think... [21:38:47] eileen: hi! welcome! :) [21:38:58] Hey AndyRussG [21:39:07] Hows's day 1? [21:39:24] OK - a bit confused about all the different sites / systems! [21:39:43] heh yeah we have more than 2 or 3 ;p [21:40:15] I probably haven't run out of fingers yet.... [21:40:34] when the hazing is over, we'll show you the system where everything is collected in one place and makes sense [21:41:00] awight: wut? you mean, after nearly 2 years, I'm still being hazed? [21:41:10] :-) [21:41:38] awight: cwdent: ejegg: arrrg! I realized I have an umovable personal commitment during the possible deploy window we talked about (Thursday 2pm Pacific) :( [21:42:06] However there's a similar spot on Wednesday, 2pm Pacific [21:42:16] fine w/ me! [21:43:30] awight: would that time work for you to help out with the schema deploy? also, do you think it's OK to ask greg- -g about doing that on 2 days notice? [21:48:04] can do! I'm sure it's ok to ask greg-g, he won't be shy with the feedback [21:50:42] heh :) [21:50:56] 2 days is a little short /me has no context [21:52:25] ejegg: is there a current example of a form field in mustache that causes another to update? like the country/regions thing [21:52:51] greg-g: sorry I didn't realize that a week or so advance warning would be important. This is a change that Fundraising has been waiting a while for, and that we've just been testing on the beta cluster [21:53:30] greg-g: everything seems OK so far. Just doing now some comparative performance analysis [21:54:10] greg-g: I was just about to suggest Thursday at 2 PST, but I realized I have a personal commitment at that time that I really can't change :( [21:54:50] cwdent: nope, we haven't needed anything that fancy so far [21:54:50] I still don't konw the context :) [21:55:07] greg-g: context, as in what code is changeing, or what it's for? [21:55:12] yep [21:55:15] I care about those things [21:55:27] both [21:55:28] It's a major refactor of client-side CentralNotice code. [21:55:51] We've been working on it on a feature branch for a while and just recently merged it into master to test on the beta cluster [21:56:15] gotcha, will it be auto deployed for you tomorrow with the train? [21:56:17] ejegg: i imagine it will require bundling some js with the partial, is that kosher? [21:56:17] Plus it's a new feature that FR wants, that is made possible by the refactor [21:56:20] since it's in master? [21:56:33] greg-g: no, CentralNotice doesn't ride the train automatically [21:56:36] cool [21:56:45] greg-g: We'd deploy it ourselves [21:56:47] cwdent: Hmm, maybe that's a valid case for a common mustache.scripts module [21:56:50] so, good job testing on BC :) [21:56:51] It also involves a schema change, BTW [21:57:18] AndyRussG: have you coordinated that part with Ops? [21:57:33] awight will be supervising that part, which we'll also do, since he also has experience with that [21:57:47] ejegg: i was thinking about that, what if there was a series of hooks? rather than gateway specific js files [21:57:56] No, I haven't coordinated anything specifically with them [21:58:05] or event callbacks [21:58:14] AndyRussG: awight do you need help from Ops to do the schema change? has it been reviewed by jynus/whomever? [21:58:35] greg-g: We would love some review of the schema change, haven't done that yet [21:58:55] please do get that first [21:59:06] cwdent: events / hooks might be nice, but I'd still like to keep each gateway's front end code in different files [21:59:10] it sounds like 2 days is a hard timeline for that :/ [21:59:38] greg-g: mmm indeed... K sorry I didn't know it needed such [21:59:44] greg-g: This is new schema fwiw, there's no impact on existing data. [21:59:47] I have to run afk (not feeling well), so, please just email ops@ with your plans and what you need [21:59:50] ahh, that helps [22:00:05] ah yeah [22:00:06] I'll let ops give us more feedback [22:00:10] Thanks, feel better! [22:00:11] greg-g: K wil do! thanks a ton! [22:00:15] thank you [22:00:26] hope u get well soon! [22:01:40] ejegg: yeah, i can imagine doing that with events and keeping it separated out still [22:02:02] but i feel like that will kill the WP deadline if i try to do that [22:03:29] So events like 'choseCard', 'fieldChanged', 'clickedContinue', etc? [22:04:46] Hmmm, jynus and springle don't seem to be online on #wikimedia-operations [22:04:58] but named more consistently [22:04:58] ejegg: yeah, does that make sense to you? [22:06:03] AndyRussG: (/me is still here, leaving now ;) ) springle no longer works for us and jynus lives in Spain [22:06:20] cwdent: maybe! Trying to see where it'll make more sense for the gateway-specific code to attach to a form event rather than the UI bits specifically. More testable, I guess! [22:06:25] greg-g: ah K anyone besdies jynus? [22:06:35] sadly no, we're back to 1 DBA :( [22:07:00] Oh, and if you had some common functions that didn't need to run for every gateway, they could hang out in the main module and just be attached as needed [22:07:12] AndyRussG: writing that ops email now... you want to review before I send? [22:07:21] awight: sure! [22:07:45] greg-g: thanks! [22:08:23] ejegg: yeah my thinking is it feels cleaner to have an event listener that never fires than some DOM specific code with no element to attach to [22:08:32] since it's abstracted across a couple independent files [22:09:24] yeah, that does seem worth trying out! [22:09:56] ok i'll start messing with it [22:10:52] AndyRussG: https://phabricator.wikimedia.org/P1955 [22:13:56] awight: great! LGTM, thanks much :) Maybe also link to the feature branch, since that'd also go out, not just the schema change? [22:14:41] https://git.wikimedia.org/log/mediawiki%2Fextensions%2FCentralNotice.git/refs%2Fheads%2Fcampaign_mixins [22:14:43] AndyRussG: I think it's better to keep it simple, does that sound okay to you? [22:14:49] awight: sure, sounds great! [22:15:00] The DBAs would get deeply confused, I'm afraid ;) [22:15:12] hmmmm all one of 'em [22:15:17] K sounds good [22:15:19] hahaha right [22:16:24] nvm, I'm going with your suggestion [22:17:59] Hmm I wonder if there's a way on gitblit to show the exact differnce between the what's in deploy and what'd go out in master [22:19:03] ejegg: do the mustache templates assume a jquery dependency? [22:19:41] ooh there is! [22:19:43] cwdent: Looks like it! Not sure if that needs to be explicit [22:19:53] AndyRussG: oops, sent already [22:20:11] ah well, for posterity neway: http://git.wikimedia.org/compare/mediawiki%2Fextensions%2FCentralNotice.git/refs%2Fheads%2Fwmf_deploy..refs%2Fheads%2Fmaster [22:20:18] ejegg: thanks! [22:20:32] cool! [22:21:11] awight: Is it a mailing list or an e-mail address in this case? [22:21:37] ops@? a mailing list [22:21:49] you should subscribe, it's moderated [22:21:59] I don't think the archives are public :/ [22:23:43] yurp I think someone suggested I do so once... [22:24:09] awight: not here https://lists.wikimedia.org/mailman/listinfo/ [22:25:46] Ah found it [22:25:53] oh good! I haven't [22:26:43] ejegg: eeh i dunno if there's an advantage over using the normal events as you did in astropay. but i could see the utility to having some common ones centralized (like populate regions on country update) [22:27:33] cwdent: well, with luck it won't be too hard to adapt later if you just want to keep 'em independent for now [22:28:01] awight: it's mentioned here: https://wikitech.wikimedia.org/wiki/Lists.wikimedia.org#Authorized_recipients_for_Ops.40lists.wikimedia.org but I don't see where to subscribe, other than just writing to that address... [22:28:41] ejegg: sounds good. where could i find said lists of countries and regions? did we already go over that? cause it seems like it might be a massive amount of data [22:30:04] one sec, doing my 1:1 with k4 [22:32:11] cwdent: ./gateway_forms/includes/StateAbbreviations.php [22:32:23] ./gateway_common/i18n/us-states/en.json <-- yuck [22:33:09] globalcollect_gateway/forms/html/_personal-information/BR.html [22:33:11] NOT cool [22:33:35] damn [22:34:03] FYI, civicrm has its own lists of provinces etc, so it's not worth scraping from the intertubes. We'll probably have to write a job to export from the Civi DB into codegenerated files [22:34:07] in the future... [22:34:13] How many countries are you doing, just FR? [22:35:15] hrm, i suppose we only really need FR for the MVP [22:35:21] Now you see why we're salting the earth behind us :) [22:35:41] heh [22:37:42] awight: can i safely just make this france specific for the time being? in the name of deadlines [22:38:17] also ideally we just rip this code out post pci scan right? or leave it in as a backup? [22:40:03] cwdent: yeah I think it's safe to just do FR for now, cos atgo set the dependencies as only blocking https://phabricator.wikimedia.org/T110111 [22:40:52] Do whatchu want wrt engineered obsolescence, I'm sad to say. There are some parts that would be really useful if done nicely, such as consolidating mustache, but if anything looks too hard then punt by all means. [22:40:59] And this is how we get ants. [22:41:39] awight: yeah...well i'm blocked by them now anyway so i might as well explore doing the Right Thing [22:44:02] awesome [22:44:08] I mean... sort of [22:52:32] Fundraising Sprint Rowlf the Dog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Deploy CentralNotice schema change - https://phabricator.wikimedia.org/T104508#1590976 (awight) [22:56:13] ejegg: where do i look to see how that l10n function in mustache works? [22:57:24] cwdent: The static fn in Mustache.php calls a thing in MessageUtils [22:57:47] ah, heh, which calls stuff in WmfFramework so it doesn't bust in drupal [22:58:11] aaah, heheh cool i can pull on that string [22:58:12] WmfFramework functions are all thin wrappers around global fns in MW core [22:58:24] * awight weeps quietly [22:59:18] MW core really needs a messageExists function... [23:00:10] this is probably one of those times when i should xdebug [23:03:29] * awight nudges cwdent, you might wanna send the entire API conversation [23:03:58] awight: ok will do [23:08:16] not to add to the stress, I'm just thinking it might reduce the number of round-trips though [23:09:21] for sure! [23:24:46] awight: urgent EducationProgram bug, talking about it w/ ori in [23:24:52] #wikimedia-perf [23:24:53] cwdent: still being persnickety... where did the "?" go in the full conversation? [23:24:56] k [23:24:58] https://phabricator.wikimedia.org/T110972 [23:25:02] awight: ^ [23:25:04] "perf". that's silly [23:33:53] heading out for a while, might be back on in a couple hrs. See ya later!