[00:10:49] (PS4) Awight: WIP New maintenance scripts for manipulating GC charges [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234417 (https://phabricator.wikimedia.org/T109668) [00:11:11] gotta run [00:11:23] (CR) jenkins-bot: [V: -1] WIP New maintenance scripts for manipulating GC charges [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234417 (https://phabricator.wikimedia.org/T109668) (owner: Awight) [00:13:20] awight: good question [00:51:24] (PS1) Eileen: Anotate CiviCRM patches. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/235164 [00:52:23] I managed to figure out the system enoug to push something for review... [01:49:31] pretty impressive eileen! i'm casey btw, another dev in fr tech [01:55:01] cwdent: nice to meet you! [01:55:35] does fr tech stand for fundraising tech? [01:56:48] yep! [01:57:31] are you in SF? [01:58:39] nope i'm in colorado. you're in NZ right? [01:58:44] yep [01:58:58] early afternoon on Tuesday here [01:59:15] far out [01:59:25] monday night here [01:59:32] I was in Colorado in April - we got to go into the mountains which was great [01:59:51] cool! yeah i live in the front range near boulder [01:59:59] nice! [02:00:40] I didn't get to Boulder - just Denver & then the place in the mountains [02:02:26] i have never been to NZ, but i hear it's amazing [02:03:31] yeah - it's nice. Not so dramatic where I am but nice & warm and good beaches [02:03:41] further south there are mountains [02:03:59] are you from there? [02:04:22] yeah - I grew up here [02:04:40] & you? [02:05:40] i grew up in Minnesota but have been here about 7 years [02:06:39] I was going to say Minnesota is cold - but then Colorado is too - at least half the year [02:07:20] although no wind chill in Denver from what I remember [02:08:38] whew yeah nothing like MN! [02:08:46] except way up in the mountains [02:08:58] is it nice in NZ all the time? [02:09:09] not all the time! [02:09:30] and NZ is quite long & quite hilly [02:09:36] so it changes depending where you are [02:09:56] I live quite far north so we get very mild winters [02:10:21] there are mountains and skiing and stuff right? [02:10:47] yeah - not so close to where I am - but about 7 hours drive south from me [02:11:06] and then in the south island there is a ridge of mountains the whole way down [02:11:40] wow [02:11:50] i have heard it is somewhere people go for vacation and never come home [02:12:30] yeah - as long as you don't need big city life [02:13:09] (We have cities & I guess Auckland is quite big) [02:13:59] but, it's still a small country [02:19:48] eileen: well i'm signing off, but nice to meet you! i've only been here about 4 months so you probably know more than i do about this code base, but more than happy to answer any questions you have about onboarding! it is a formidable process [02:20:25] cwdent: yep - nice to meet you too! have a good evening [02:20:37] you too! [04:25:23] (PS3) Ejegg: WIP handle errors in Amazon API calls [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/233993 (https://phabricator.wikimedia.org/T108123) [04:25:25] (PS1) Ejegg: Quit validating that order_id is numeric [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/235182 [10:17:29] TCB-Team-Fundraising-Sprint-2015-08-26, TCB-Team: [WMDE-Fundraising] avoid category tag showing in raw ripped content - https://phabricator.wikimedia.org/T111019#1592159 (WMDE-Fisch) NEW [10:17:59] TCB-Team-Fundraising-Sprint-2015-08-26, TCB-Team: [WMDE-Fundraising] avoid category tag showing in raw ripped content - https://phabricator.wikimedia.org/T111019#1592169 (WMDE-Fisch) [10:18:02] TCB-Team-Fundraising-Sprint-2015-08-26, TCB-Team: [WMDE-Fundraising] Remove unused templates from content staging wiki - https://phabricator.wikimedia.org/T110322#1592168 (WMDE-Fisch) [10:18:24] TCB-Team-Fundraising-Sprint-2015-08-26, TCB-Team: [WMDE-Fundraising] avoid category tag showing in raw ripped content - https://phabricator.wikimedia.org/T111019#1592159 (WMDE-Fisch) [10:18:40] TCB-Team-Fundraising-Sprint-2015-08-26, TCB-Team: [WMDE-Fundraising] avoid category tag showing in raw ripped content - https://phabricator.wikimedia.org/T111019#1592173 (WMDE-Fisch) a:WMDE-Fisch [12:37:47] TCB-Team-Fundraising-Sprint-2015-08-26, TCB-Team: [WMDE-Fundraising] avoid category tag showing in raw ripped content - https://phabricator.wikimedia.org/T111019#1592531 (WMDE-leszek) a:WMDE-Fisch>WMDE-leszek [12:41:45] TCB-Team-Fundraising-Sprint-2015-08-26, TCB-Team: [WMDE-Fundraising] avoid category tag showing in raw ripped content - https://phabricator.wikimedia.org/T111019#1592541 (WMDE-leszek) Pull request on github: https://github.com/wmde/fundraising/pull/629 [13:32:18] Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: Publishing translations for central notice banners fails - https://phabricator.wikimedia.org/T104774#1592738 (AndyRussG) @jrobell thanks a lot for mentioning this! I didn't k... [15:41:52] Fundraising-Backlog, Wikimedia-Site-Requests: Geolocation not available on wikimediafoundation.org - https://phabricator.wikimedia.org/T73747#1593355 (Krenair) [16:34:04] Anyone interested in talking about a schema deploy for CN may proceed to #wikimedia-databases [16:34:50] * K4-713 goes to lurk [16:47:08] sup ejegg [16:47:35] hi cwdent! [16:48:03] am i correct thinking there is not a mustache function for generating dropdowns from json yet? [16:48:57] nope, best it can do is loop over a list [16:51:43] think it would be prudent for me to make one? [16:51:57] make a list of french provinces [16:52:00] *made [16:52:15] the best part was s/^\([^\t]*\)\t\([^$]*\)/"donate_interface-province-dropdown-\2": "\1",/g [16:53:38] i think awight would say "pervy" [16:55:12] eew [16:56:13] yeah, i think a helper function to populate a state array based on country, plus a partial to include when reqiured [16:56:38] sounds good! [16:57:33] annoying thing about mustache loops is no access to array keys, so you have to make key + value both properties of the elements [16:58:19] strange! [16:59:20] of all the annoyingly named software projects mustache has to be one of the most ungooglable [17:03:43] heh. try mustachejs [17:04:07] ah yeah [17:04:40] i think the worst thing i've seen is the new node version manager, n [17:33:35] ejegg: one weird thing, the codes for these france provinces in civi are numbers and letters, mostly like 10 11 12 and a couple like 12a [17:34:35] where ever i put the helper it seems like it needs to have access to that json directly to spit out the l10n keys [17:35:00] for instance "donate_interface-province-dropdown-75": "Paris", [17:35:09] oh, like the arondissements of paris [17:35:39] huh, is that how rapidhtml does it? [17:37:19] i'm not sure! the country functions get a static list of country codes from the adapter and use it to populate the l10n keys [17:37:37] but i haven't found where this happens for provinces (does it?) [17:37:40] oh, it's not even making state dropdowns.... those are all hardcoded in the country-specific personal info 'partials' [17:37:48] yeeeeeah [17:37:51] eew [17:38:05] there is one file in i18n for canada provinces but i couldn't find it used anywhere [17:38:25] ah man [17:38:43] i think that file is added to the list of all message files [17:38:59] and then they are all available to the mw message functions [17:39:46] so, maybe let's see what's in cldr [17:39:46] I think that's meant for lists like this [17:39:57] ok [17:40:53] huh, just countries and currencies. [17:41:45] hrmph [17:42:04] totally should have states [17:42:09] i could just stick this in a static array in the WP adapter [17:42:26] there's quite a bit of stuff like that now [17:42:34] augh [17:42:58] hopefully mostly wp-specific? [17:43:27] yeah i think so [17:43:36] currency codes and cc types... [17:44:22] it is not trivial to make the l10n json available to mustache.php is it? [17:44:37] PHP can decode JSON pretty trivially, we'd just want to cache it after reading the file once [17:46:10] yeah...i guess i'd want to make sure this is a good way to move forward [17:46:11] in the general case [17:46:20] cause it'd be very easy to do something hacky and france specific [17:46:46] it would be better to generalize for sure but i'd want to do it the right way and not regret it later [17:47:36] really should be a non-donation-interface thing [17:47:52] yeah... [17:49:16] there's this: https://packagist.org/packages/phine/country [17:49:34] but the github repo is under 'kherge-abandoned' :( [17:50:42] still, was updated in April [17:50:43] there's something taking care of this in civi isn't there? [17:50:44] that's where i pulled the list from [17:50:44] ooh, good point! [17:52:15] well, i'd still say either add it to cldr or try to find a better library. We don't need to maintain that list ourselves. [17:52:51] aren't most of those json files hand made? or are they auto updated somehow? [17:53:42] the json files are translated by an army of elves on translatewiki [17:55:41] hey, looks like Wiki Loves Monuments would benefit from CLDR having subdivision data: https://www.mediawiki.org/wiki/Wiki_Loves_Monuments_mobile_application/Data_issues [17:55:42] oh awesome [17:55:42] they also point to data dumps, but there's another page complaining that the Chilean names are wrong in spanish [18:43:52] Fundraising-Backlog, Wikimedia-Site-Requests: Geolocation not available on wikimediafoundation.org - https://phabricator.wikimedia.org/T73747#1594014 (Pcoombe) See also T102848, but I'm not sure what the status of that is. [19:06:20] Fundraising Sprint Queen, Fundraising Sprint Rowlf the Dog, Fundraising Sprint The Pogues, Fundraising-Backlog, and 2 others: Test for performance regressions - https://phabricator.wikimedia.org/T107503#1594153 (AndyRussG) Using [[ http://www.webpagetest.org | WebPageTest ]] and a labs instance,... [19:06:40] cwdent: ejegg: XenoRyet: ^ comments welcome! [19:07:02] I like the conclusions! [19:08:23] nice AndyRussG! looks like things smoothed over with ops re the schema change? [19:08:59] Heheh hopefully it wasn't forgone due to how I tested... Still, if you see the averages on the second page of the spreadsheet, it's hard to imagine there'll be serious problems [19:09:16] cwdent: yeah! Schema is all deployed! I'm just gonna send an e-mail :) [19:09:27] awesome! [19:28:21] (PS4) Ejegg: WIP handle errors in Amazon API calls [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/233993 (https://phabricator.wikimedia.org/T108123) [19:28:23] (PS1) Ejegg: Allow callables in GatewayAdapter::$error_map [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/235293 (https://phabricator.wikimedia.org/T108123) [19:29:15] ejegg: ah ha, gateway_forms/includes/ProvinceAbbreviations.php [19:29:43] oh rly? [19:30:03] i guess that's how it'd spit the l10n keys out [19:30:16] but those are canada specific [19:30:43] yeah... and what's with the hardcoded english names? [19:31:24] those look more like candidate for a code cull [19:31:25] ¯\_(ツ)_/¯ [19:31:30] *candidates [19:31:54] yep, nothing using those classes [19:31:56] yeah i think it could get more consistent [19:32:07] Hi! [19:32:34] sup awight [19:32:36] Hi awight! [19:32:54] * awight ducks before there are any questions about the FR province codes [19:32:56] (PS5) Ejegg: Handle errors in Amazon API calls [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/233993 (https://phabricator.wikimedia.org/T108123) [19:33:00] lemme know if I can help with anything [19:33:09] http://m.snopes.com/mount-mckinley-denali/ [19:33:17] (CR) jenkins-bot: [V: -1] Handle errors in Amazon API calls [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/233993 (https://phabricator.wikimedia.org/T108123) (owner: Ejegg) [19:33:18] I'm going to deploy some CRM changes that should hopefully get the recurring job on its feet again... [19:33:21] awight: what do you think of adding country subdivisions to cldr? [19:33:51] Looks like wiki loves monuments could use it: https://www.mediawiki.org/wiki/Wiki_Loves_Monuments_mobile_application/Data_issues [19:33:59] MBeat: heads up, I'm going to turn the recurring job back on in a bit, there should be a flood of email receipts... [19:34:19] ejegg: CiviCRM has the lists already, I think we should write something that dumps their database into files. [19:34:36] and put those files in cldr? [19:34:48] ejegg: do you think that info is available through cldr and our adapter just doesn't know how to get it? [19:35:04] Just thinking there's nothing donation-interface-specific about states and provinces [19:35:19] cwdent: no, there's nothing in cldr for subdivisions yet [19:35:35] awight: ejegg: cwdent: XenoRyet: I booked a CentralNotice deploy slot for tomorow at 16:00. awight, I'm just gonna reply on the Ops thread to say thanks 4 the schema deploy--should I also mention that I booked the slot tomorrow? [19:35:35] mmm, yeah i donno about cldr. [19:35:48] AndyRussG: totally. and awesome! [19:35:53] awight: like, the whole way it does things? [19:36:03] haha that's another story [19:36:20] no, I mean it seems like we shouldn't attach this cruft to anything really. It could be a standalone library, whatev [19:36:30] Actually--it should be a civicrm component [19:36:37] I wonder how they input those files? [19:36:56] * awight glances towards eileen [19:37:10] I mean, it could go in smashpig, but it still seems non-specific to payments [19:37:25] Fundraising-Backlog: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1594364 (MeganHernandez_WMF) Update, I think we've sorted out the "start editing" link. Thank you @awight! English is done & we're getting a batch of translations together so these can all... [19:37:30] Well, maybe we can put them in a formal e.g. yaml which translatewiki.net can parse [19:37:34] we could adopt this thing: https://github.com/kherge-abandoned/lib-country [19:37:59] horrible to couple it to PHP, even. [19:38:12] for now, let's just deal with French provinces [19:38:12] heh, true [19:38:28] i have it in a json file right now i pulled from civi [19:38:39] perhaps we can brainstorm on a TODO task [19:38:59] oh look, that library is just a wrapper around a couple XML exports from the ISO! [19:39:09] it's easy to load it up with the rest of em in wgMessagesDirs [19:39:15] cwdent: wait. why do you need provinces? [19:39:20] is that part of the worldpay spec? [19:39:32] no i don't think we send them _any_ address info do we? [19:39:35] right [19:39:48] awight: there was some reason we wanted to start collecting them. let me see... [19:40:01] but just so we can stuff it in the session for when they come back and save...yeah what ejegg said [19:40:10] If we can avoid it for now, I'd say we should do the MVP without any frills [19:40:35] awight: i'm blocked on a couple questions on their end right now [19:40:43] so i was just exploring [19:40:53] cwdent: can you mock the iframe URL and continue? [19:41:30] awight: sure i can do like the iframe display i suppose [19:41:50] but i think trying to code around the iframe workflow without seeing a real one is...speculative [19:42:38] I agree, but the display part and generalizing mustache things is probably hard enuf to last a few days at least [19:42:49] huh, maybe I imagined that... [19:44:24] gotta hand lord of the land my rent, one moment please [19:48:51] ejegg: should i just use the vanilla form now without address stuff? [19:50:44] http://techcrunch.com/2015/09/01/google-gets-a-new-logo/ [19:54:54] well that's less interesting [19:55:15] they got jealous of how boring yahoo looks now? [19:55:46] i'm getting a real panicked vibe from google these days [19:56:18] like they're on the verge of an empire destroying "rebrand" [19:56:25] woohoo! [19:56:28] FB just took over as top referral source to news articles [19:56:51] oh god. right, we don't want the vice-president in charge either [19:57:11] hehe, spiro agnew 2016! [19:57:30] ross perot! [19:57:50] i was thinking, what if the trump vs. sanders ticket emerges [19:57:57] spiro agnew is an anagram of grow a penis, at it turns out [19:57:59] guys like ross perot are going to rejoice [19:57:59] *as [19:58:14] awight: awesome [19:58:28] maybe Vonnegut or something [19:58:36] that made my day [19:58:43] oh, "grow a spine" [19:58:50] that too! [19:58:59] wtf, that made it into his WP page [20:00:36] I can't tell if the article is vandalized, he's one of those self-parodying characters [20:00:49] "His conscience gone, he became a politician, and made successful use of knockout drugs to secure appointment to the Baltimore County Board of Appeals" [20:00:53] man, he and tricky dick made quite a pair. only veep to resign on criminal charges [20:00:59] hah! [20:01:31] oh. uncyclopedia [20:01:36] * awight facepalms [20:01:42] There should be more of that. [20:02:07] google should occasionally source knowledge graph from there, just to see if anybody notices [20:02:13] {{ unencyclopaedic_tone }} [20:02:14] :) [20:02:26] citation not included [20:09:56] awight: hangout? [20:10:13] d'oh! [20:16:40] AndyRussG: https://performance.wikimedia.org/#!/week [20:35:48] https://www.sparkfun.com/news/782 [20:35:51] ^geiger counter train [20:42:19] cwdent: neat! [20:42:35] awight: do you know how they actually get those numbers? [20:42:47] I think at least some similar things are in the JSON files from webtestpage [20:42:53] AndyRussG: no idea! [20:43:09] Good point, if they use the same tool it's not helpful to compare [20:47:11] (PS1) Eileen: Annotate CiviCRM patches [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/235359 (https://phabricator.wikimedia.org/T99836) [20:47:32] * awight blinks [20:47:54] hey awight I think I have figured it out WRT gerrit + review? [20:48:06] eileen: Hi! [20:48:10] Great idea btw [20:48:19] Yes, the patchset is perfect [20:49:01] awight: ok cool - I added a bunch more - actually I thought I did that yesterday - but there was a confirm on my screen when I turned it on [20:49:29] As far as actually acting on these recommendations, however you want to track that work is fine by me. [20:49:58] ok - I was thinking I probably should ensure the ones that I think need action each have a a JIRA [20:50:14] well it's fine to have a general Wiki baseline! however also we're pulling from our own instance, and those are averages from the whole world w/ all its crazy latencies and such [20:50:15] although probably not the css one - I think that should be elsewhere [20:50:18] awight: ^ [20:50:22] also, BRB! [20:51:15] eileen: oh, right :) JIRA tickets will track the work [20:51:50] awight: I'm going to look through the patches again & the JIRA tickets & then I might try to talk through with you to check my assumptions - esp about the ones I think may not be needed going forwards [20:52:15] Fundraising Sprint Rowlf the Dog, Fundraising Tech Backlog, Fundraising-Backlog, Unplanned-Sprint-Work: Recurring job dies on simple errors - https://phabricator.wikimedia.org/T111108#1594685 (awight) NEW a:awight [20:53:17] eileen: I'm so psyched, thanks for doing this. They look right from the few I've skimmed. [20:53:57] Fundraising Sprint Rowlf the Dog, Fundraising Tech Backlog, Fundraising-Backlog, Unplanned-Sprint-Work: Recurring job dies on simple errors - https://phabricator.wikimedia.org/T111108#1594685 (awight) https://gerrit.wikimedia.org/r/#/c/234717/ [20:55:04] awight: cool - good to hear [20:58:05] looks like it's best to keep ammending that commit as I figure out more - does that leave a trail of no-longer-valid review tickets (& does it matter if it does?) [20:58:27] eileen: If you don't mind, I'll use gerrit to have a discussion about your findings? Or if you prefer, I can merge the patch? [20:58:57] yeah, unfortunately we do use the commit --amend workflow, in Gerrit at least. [20:59:24] The hope is that we can stop that and use feature branches once the WMF migrates to something... else. Maniphest. [20:59:51] awight: I am not sure what works best as the workflow [21:00:12] but, I expect I'll add a bunch of minor changes to the comments as I find related JIRA etc [21:00:56] but if I commit & amend - does it keep the same gerrit ticket alive- or does it generate a new one? [21:04:26] eileen: the gerrit ticket is connected to the change id appended to the bottom of your commit message [21:04:38] so as long as that's the same, it'll reuse the gerrit ticket [21:05:38] ok - thanks [21:06:40] AndyRussG|thnrgx, awight, ejegg, anyone... i have gotten this during dev a couple times recently: [21:06:43] PHP Warning: $context is required for campaign mixins. [Called from C [21:06:45] NChoiceDataResourceLoaderModule::getDependencies in /srv/CentralNotice/includes/CNChoiceDataResourceLoaderModule.php at line 137] in /srv/core/includes [21:06:47] /debug/MWDebug.php on line 300 [21:06:57] it seems to start at random and persist until i nuke the session cookie [21:07:28] huh, nothing I'd seen, but I'll take a look! [21:07:51] cwdent: that's a version incompatibility between your mw-core and centralnotice [21:07:55] try updating both [21:08:21] ah ha! yeah i'm on rel23 cause i'm working with DI [21:10:00] (PS6) Ejegg: Handle errors in Amazon API calls [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/233993 (https://phabricator.wikimedia.org/T108123) [21:10:01] (PS6) Ejegg: Handle errors in Amazon API calls [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/233993 (https://phabricator.wikimedia.org/T108123) [21:10:12] twins! [21:35:05] (PS2) Eileen: Annotate CiviCRM patches [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/235359 (https://phabricator.wikimedia.org/T99836) [21:37:52] cwdent: ooh no wikis will come down :( [21:37:54] jk!!! [21:38:17] cwdent: update your mediawiki core, it should work after that [21:38:41] ah oops [21:38:44] * AndyRussG reads backscroll [21:39:41] AndyRussG: heh got it sorted out [21:39:47] whew! [21:39:56] cwdent: yeah I see! Yeah thanks for the quick report :) [21:40:29] http://www.independent.co.uk/news/uk/crime/wikipedia-rocked-by-rogue-editors-blackmail-scam-targeting-small-businesses-and-celebrities-10481993.html [21:58:39] (CR) Awight: "Thanks!" (21 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/235359 (https://phabricator.wikimedia.org/T99836) (owner: Eileen) [22:00:21] (CR) Awight: Annotate CiviCRM patches (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/235359 (https://phabricator.wikimedia.org/T99836) (owner: Eileen) [22:16:10] (PS7) Ejegg: Handle errors in Amazon API calls [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/233993 (https://phabricator.wikimedia.org/T108123) [22:16:12] (PS2) Ejegg: Allow callables in GatewayAdapter::$error_map [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/235293 (https://phabricator.wikimedia.org/T108123) [22:16:14] (PS1) Ejegg: Move Amazon test responses into their own files [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/235369 (https://phabricator.wikimedia.org/T108123) [22:16:32] (CR) jenkins-bot: [V: -1] Handle errors in Amazon API calls [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/233993 (https://phabricator.wikimedia.org/T108123) (owner: Ejegg) [22:16:41] (CR) jenkins-bot: [V: -1] Allow callables in GatewayAdapter::$error_map [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/235293 (https://phabricator.wikimedia.org/T108123) (owner: Ejegg) [22:16:45] (CR) jenkins-bot: [V: -1] Move Amazon test responses into their own files [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/235369 (https://phabricator.wikimedia.org/T108123) (owner: Ejegg) [22:17:38] dang! [22:20:54] (PS8) Ejegg: Handle errors in Amazon API calls [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/233993 (https://phabricator.wikimedia.org/T108123) [22:20:56] (PS3) Ejegg: Allow callables in GatewayAdapter::$error_map [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/235293 (https://phabricator.wikimedia.org/T108123) [22:20:58] (PS2) Ejegg: Move Amazon test responses into their own files [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/235369 (https://phabricator.wikimedia.org/T108123) [22:21:10] (PS1) Awight: Explain some disablement [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/235371 [22:22:56] (PS1) Awight: Update DonationInterface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/235372 [22:42:51] (PS1) Awight: Follow composer.lock [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/235373 [22:43:45] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/235374 [22:43:47] (PS1) Awight: Update vendor libs [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/235375 [22:45:30] (CR) Awight: [C: 2] Update DonationInterface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/235372 (owner: Awight) [22:45:52] (CR) Awight: [C: 2] Follow composer.lock [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/235373 (owner: Awight) [22:46:01] (CR) Awight: [V: 2] Follow composer.lock [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/235373 (owner: Awight) [22:46:23] (CR) Awight: [C: 2 V: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/235374 (owner: Awight) [22:46:36] (CR) Awight: [C: 2 V: 2] Update vendor libs [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/235375 (owner: Awight) [22:50:27] !log update CRM from 0fc8474338e7a31fdde79287bd667b98cd96a252 to abc34b87ee9d1dbb1176f1929a3d748e1ee5ac7b [22:50:32] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:51:42] awight: in addition there _is_ a small follow-on tweak for compatibility with existing scripts [22:51:50] coming up in short little bit [22:52:27] and also there will be some small tweaks to make in in-banner scripts. I think we can do that ourselves. If it's OK, I'll check that w/ Peter tomorrow morning [22:53:30] Yeah that's definitely fine. Still nice to warn the-wub, of course! [22:53:38] Yeah, will do! [22:58:02] Fundraising Sprint Rowlf the Dog, Fundraising Tech Backlog, Fundraising-Backlog, Unplanned-Sprint-Work: Recurring job dies on simple errors - https://phabricator.wikimedia.org/T111108#1594685 (awight) Deployed but not verified working. I'm going to break my GC recurring record and run the job. [23:00:11] cwdent: Thank you for the Mt McKinley post :) totally gonna troll a few well-meaning bigots I know [23:03:37] awight: there are so many things i love about it i don't even know where to start [23:05:37] This joke must have been make already, but I started calling the prez Unabama, in honor of the merciless drone strikes on civilians. [23:06:10] What was Clinton's average, though? Two bombing runs per day over Iraq, without declaring war? [23:07:41] awight - when I go here https://gerrit.wikimedia.org/r/#/c/235359 I can easily see your last comment - but not the previous 21 - is that a pitfall of git commit --amend [23:07:42] ? [23:08:05] ah right - I see the patch set 1 is still there [23:08:33] just minimised [23:09:01] yep! it's horrible [23:09:53] I tripped over that interface for a while too. Gerrit definitely doesn't make it obvious. [23:11:10] https://www.youtube.com/watch?v=1o_8b31GRnU [23:11:12] running an update query on the live civi db and it's taking forever... I keep double-taking the where clause [23:11:31] what is the query? [23:11:48] mysql> update wmf_contribution_extra set gateway_txn_id='bork 1572566344' where entity_id=11879116; [23:11:54] I think it's a column type issue? [23:12:02] But that would be freakish [23:12:26] I'm gonna file a bug when it comes back, cos I'm sure we sometimes join on entity_id [23:12:42] column type should matter if there is a join.... [23:13:12] it's an int(10) unsigned, so that theory's out the door [23:13:14] WAT [23:13:35] It must be deadlocked, in that case! [23:13:59] cmjohnson1: when you get the chance, can you look for deadlock on db1008? [23:14:20] Or evidence that it just happened? The suspicious query is the UPDATE, above ^^ [23:14:39] looking [23:15:05] We would be getting failmails like it's locust season if that were happening, though... [23:16:05] thanks! [23:19:49] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM quicksearch has annoying key behavior - https://phabricator.wikimedia.org/T111128#1595340 (awight) NEW [23:19:50] awight: when I reply to your comment it seems to stay as a draft comment - not sure how to change that [23:20:24] eileen: You have to "review" the patchset--you can leave the verified and code review radio buttons at "0" [23:21:23] cmjohnson1: If it helps, I need to run the same query again cos I actually did want it to happen :) [23:21:30] trying that now... [23:22:20] okay, it worked that time. [23:22:37] okay...Bear with me ...mysql is not my forte [23:23:19] I'm less concerned now that my query worked, so feel free to ignore this unless you're curious [23:24:07] i am going to poke around [23:24:13] Lock contention in this database has me pretty twitchy, cos I naively put overly large transactions around some of our core code... [23:25:39] (CR) Eileen: Annotate CiviCRM patches (2 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/235359 (https://phabricator.wikimedia.org/T99836) (owner: Eileen) [23:31:44] (PS1) AndyRussG: Support legacy banner_count field for S:RI [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235381 [23:31:51] awight: ^ [23:32:35] Heh I'm psyched! Looks like we'll really get this out tomorrow!! [23:33:05] K I'm going to eat, back in a little while :) [23:36:47] (CR) Eileen: Annotate CiviCRM patches (7 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/235359 (https://phabricator.wikimedia.org/T99836) (owner: Eileen) [23:45:38] awight: do GiantRabbit have a git repo with their commits? This one has them bundled into a single commit http://git.wikimedia.org/commit/wikimedia%2Ffundraising%2Fcrm%2Fcivicrm.git/7c21dba263c6868c5701f99b7fac8c0f66156904 [23:47:43] I'm a little sad about that, too, but no that's all we have [23:48:31] awight: ok - I'll make sense of it... [23:51:55] Feel free to contact anemirovsky, they're still working with us, are friendly and awesome to chat with [23:58:23] awight: ok - cool - I should. Another question then... what exactly has this been applied to http://git.wikimedia.org/commit/wikimedia%2Ffundraising%2Fcrm%2Fcivicrm.git/7c21dba263c6868c5701f99b7fac8c0f66156904 - when I look at the civicrm repo I don't see that commit incorporated [23:59:07] (CR) Awight: Annotate CiviCRM patches (6 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/235359 (https://phabricator.wikimedia.org/T99836) (owner: Eileen)