[00:05:43] K4-713: XenoRyet:cwdent|afk:ejegg|away:all deployeedddddd! Seems to work!! [00:05:56] I'm gonna lurk and watch a bit more, and then re-enable FR campaigns [00:06:02] Good times! [00:06:07] hi-ten! [00:06:19] ok I'm going to assimilate into the subway hordes [00:06:25] Yoohooo [00:06:43] That was cool for me to watch too. Good call on the screen sharing. [00:08:53] XenoRyet: Glad to hear it!! I'm much more comfrotable deploying if someone else can help check stuff. in real time, really appreciate it :D [00:11:50] Wow, guys. Nice job. [00:12:09] I don't want to congratulate you too thoroughly until it stays put for a few hours, but... well done. [00:12:15] :D [00:12:47] K4-713: thanks! Yeah I'll be here watching [00:13:02] Just notified on -operations and -mobile [00:13:28] woooo [00:13:41] * K4-713 wanders off to get a snack [00:15:25] K4-713: really appreciate that no one got peeved about the de-meetingification... Should I expand the time slot of tomorrow's standup? I think maybe I heard that WP said they would "try" for 1 pm Pacific? [00:18:15] fundraising-tech-ops, Traffic, operations, IPv6: Enable IPv6 on donate.wikimedia.org - https://phabricator.wikimedia.org/T73267#1600417 (faidon) p:Low>High [00:28:25] fundraising-tech-ops, Traffic, operations, IPv6: Enable IPv6 on donate.wikimedia.org - https://phabricator.wikimedia.org/T73267#1600444 (faidon) I'm not sure if there's anything that prevents IPv6 from being enabled on donate; if so, could we have it detailed in this task? Adding IPv6 to donate wo... [00:35:19] AndyRussG: all looking good still? [00:39:36] cwdent|afk: yep! no complaints or errors seen so far!!! [00:40:11] awesome! [00:40:52] yeah! I can still hardly believe it [00:41:14] We'll see for sure over the coming hours, and when we get some impression numbers [00:41:51] yeah, that will be interesting! [00:45:37] i think the WLM banner would benefit from an oxford comma [00:47:10] cwdent|afk: maybe next deploy, I guess... [00:47:45] hehe [00:48:04] i am generally comma agnostic [01:44:26] Fundraising Tech Backlog, operations: Add emcnaughton@wikimedia.org to fr-tech@ email group - https://phabricator.wikimedia.org/T111257#1600643 (Dzahn) a:Dzahn [01:45:10] AndyRussG: huge congrats on the deploy! was awesome to watch and excited to see how the new data gets used. i'm signing off, have a good night [01:47:05] cwdent|afk: thanks, thanks so much for your help too!! Really appreciate it :) [01:47:07] cya tomorrow! [01:54:56] Fundraising Tech Backlog, operations: Add emcnaughton@wikimedia.org to fr-tech@ email group - https://phabricator.wikimedia.org/T111257#1600663 (Dzahn) done. added her to fr-tech and fr-tech adds her to fr-online and that adds her to fr-all. yep let me know if you want me to paste all the lists (civicr... [01:56:35] eileen: hi, i assume that was for you ^ [01:57:18] you should get mail now when those group aliases get mail [01:59:36] Fundraising Tech Backlog, operations: Add emcnaughton@wikimedia.org to fr-tech@ email group - https://phabricator.wikimedia.org/T111257#1600675 (Dzahn) Open>Resolved has been applied on the mail server [02:49:08] mutante: thanks! [02:54:48] eileen: welcome. and good night [03:13:12] :-) [03:28:11] (PS1) AndyRussG: KVStore: remove error cookie [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235667 [03:35:07] (CR) Ori.livneh: KVStore: remove error cookie (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235667 (owner: AndyRussG) [03:44:24] (PS2) AndyRussG: KVStore: remove error cookie [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235667 [03:45:36] (CR) AndyRussG: KVStore: remove error cookie (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235667 (owner: AndyRussG) [03:57:09] (CR) Ori.livneh: [C: 1] "LGTM. I could merge but I'm not sure what the protocol is for FR-related changesets." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235667 (owner: AndyRussG) [06:48:03] (PS1) Amire80: Consistent "JavaScript" spelling [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235681 [08:11:45] (CR) Addshore: [C: 2] Consistent "JavaScript" spelling [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235681 (owner: Amire80) [08:12:38] (Merged) jenkins-bot: Consistent "JavaScript" spelling [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235681 (owner: Amire80) [13:17:47] Fundraising-Backlog: donatewiki access for Trilogy - https://phabricator.wikimedia.org/T110038#1602044 (Pcoombe) @awight @K4-713 Any chance of this happening soon, this week or next? [15:45:25] (CR) AndyRussG: "Thanks!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235681 (owner: Amire80) [16:05:17] fundraising-tech-ops, Traffic, operations, IPv6, Patch-For-Review: Enable IPv6 on donate.wikimedia.org - https://phabricator.wikimedia.org/T73267#1602727 (BBlack) Actually, it was implemented currently via "text-addrs-v4". Simply removing the trailing "-v4" in a few places fixes this, as shown... [16:23:57] Fundraising Sprint Queen, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, and 10 others: CentralNotice: key-value storage for new campaign-associated mixins/banner history - https://phabricator.wikimedia.org/T94763#1602768 (AndyRussG) Open>... [16:23:59] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic, Patch-For-Review: [epic] Banner History MVP - https://phabricator.wikimedia.org/T78089#1602770 (AndyRussG) [16:24:02] Fundraising Sprint Enya, Fundraising Tech Backlog, Fundraising-Backlog, § Fundraising Sprint Abba, and 4 others: Do banner hiding with mixins - https://phabricator.wikimedia.org/T86100#1602769 (AndyRussG) [16:24:05] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Epic, Patch-For-Review, and 2 others: Special:RecordImpression should die in a fire - https://phabricator.wikimedia.org/T45250#1602771 (AndyRussG) [16:25:52] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic, Patch-For-Review: [epic] Banner History MVP - https://phabricator.wikimedia.org/T78089#835293 (AndyRussG) [16:25:55] Fundraising Sprint Queen, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, and 10 others: CentralNotice: key-value storage for new campaign-associated mixins/banner history - https://phabricator.wikimedia.org/T94763#1172159 (AndyRussG) Resolved... [16:25:58] Fundraising Sprint Enya, Fundraising Tech Backlog, Fundraising-Backlog, § Fundraising Sprint Abba, and 4 others: Do banner hiding with mixins - https://phabricator.wikimedia.org/T86100#961432 (AndyRussG) [16:26:01] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Epic, Patch-For-Review, and 2 others: Special:RecordImpression should die in a fire - https://phabricator.wikimedia.org/T45250#1042272 (AndyRussG) [16:26:05] Fundraising Sprint Queen, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, and 10 others: CentralNotice: key-value storage for new campaign-associated mixins/banner history - https://phabricator.wikimedia.org/T94763#1602777 (AndyRussG) Only [[ ht... [16:26:58] Fundraising Sprint Enya, Fundraising Tech Backlog, Fundraising-Backlog, § Fundraising Sprint Abba, and 4 others: Do banner hiding with mixins - https://phabricator.wikimedia.org/T86100#1602780 (AndyRussG) [16:27:01] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic, Patch-For-Review: [epic] Banner History MVP - https://phabricator.wikimedia.org/T78089#1602781 (AndyRussG) [16:27:04] Fundraising Sprint Queen, Fundraising Sprint Flaming Lips, Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, and 12 others: Implement campaign associated mixins per findings from T90913 - https://phabricator.wikimedia.org/T90915#1602779 (AndyRussG) Open>Resolved [16:27:07] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Epic, Patch-For-Review, and 2 others: Special:RecordImpression should die in a fire - https://phabricator.wikimedia.org/T45250#1602782 (AndyRussG) [16:27:22] Fundraising Sprint Rowlf the Dog, Fundraising Sprint The Pogues, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: Remove "Automatically create landing page link" feature - https://phabricator.wikimedia.org/T98747#1602784 (AndyRussG) Open>Resolved [16:28:06] Fundraising Sprint Queen, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint N*E*R*D, and 6 others: Refactor bannerController API as required for banner history - https://phabricator.wikimedia.org/T100686#1602799 (AndyRussG) Open>Resolved [16:28:09] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic, Patch-For-Review: [epic] Banner History MVP - https://phabricator.wikimedia.org/T78089#835293 (AndyRussG) [16:29:12] Fundraising Sprint Queen, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, and 10 others: CentralNotice: key-value storage for new campaign-associated mixins/banner history - https://phabricator.wikimedia.org/T94763#1602802 (AndyRussG) [16:29:15] Fundraising Sprint Queen, Fundraising Sprint ODB, Fundraising Sprint Rowlf the Dog, Fundraising Sprint The Pogues, and 3 others: Banner history mixins and data - https://phabricator.wikimedia.org/T90918#1602801 (AndyRussG) [16:33:08] Fundraising Sprint Rowlf the Dog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Give KVStore items limited TTL - https://phabricator.wikimedia.org/T111385#1602849 (AndyRussG) NEW [16:33:32] Fundraising Sprint Rowlf the Dog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Give KVStore items limited TTL - https://phabricator.wikimedia.org/T111385#1602860 (AndyRussG) a:AndyRussG [16:33:48] Fundraising Sprint Rowlf the Dog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Give KVStore items limited TTL - https://phabricator.wikimedia.org/T111385#1602849 (AndyRussG) [16:34:41] Fundraising Sprint Rowlf the Dog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Give KVStore items limited TTL - https://phabricator.wikimedia.org/T111385#1602849 (AndyRussG) [16:34:44] Fundraising Sprint Queen, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, and 10 others: CentralNotice: key-value storage for new campaign-associated mixins/banner history - https://phabricator.wikimedia.org/T94763#1602875 (AndyRussG) [16:35:35] Fundraising Sprint Queen, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, and 10 others: CentralNotice: key-value storage for new campaign-associated mixins/banner history - https://phabricator.wikimedia.org/T94763#1172159 (AndyRussG) ...well, s... [16:36:55] Fundraising Sprint Rowlf the Dog, MediaWiki-extensions-CentralNotice: Documentation: overview of new CN code and instructions for CN admins. - https://phabricator.wikimedia.org/T111386#1602900 (AndyRussG) NEW a:AndyRussG [16:37:06] Fundraising Sprint Rowlf the Dog, MediaWiki-extensions-CentralNotice: Documentation: overview of new CN code and instructions for CN admins. - https://phabricator.wikimedia.org/T111386#1602910 (AndyRussG) [16:37:38] Fundraising Sprint Rowlf the Dog, MediaWiki-extensions-CentralNotice: Documentation: overview of new CN code and instructions for CN admins - https://phabricator.wikimedia.org/T111386#1602917 (AndyRussG) [16:40:09] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: JS code style, JSCS and JSDuck - https://phabricator.wikimedia.org/T111387#1602931 (AndyRussG) NEW [16:42:40] (PS1) AndyRussG: Subscribing RL modules: Whitespace style for function declarations [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235759 (https://phabricator.wikimedia.org/T111387) [16:48:34] AndyRussG: quick thing... would you mind pinging ewulczyn about banner history? I think he's waiting for the OK to turn on the feature and start pulling #s [16:48:43] Just talked to meganhernandez about this. [16:49:42] awight: hi! we shouldn't turn it on yet [16:49:48] o! [16:49:59] Glad I asked ;) [16:50:18] Heh also per e-mail to fr-tech :) [16:50:27] Ah will try reading my email, then [16:50:55] Eh np, I usually miss 99% of the important ones, usually it's necessary to maintain a semblance of sanity [16:51:08] I guess I'm just passing on a reminder that Ellery is doing other stuff and you might want to shout loudly when it's his time to get involved [16:51:24] Yeah cool, much appreciated! [16:51:31] The timetable isn't a big deal as I understand it [16:53:17] What is the email subject I should look for? "Banner History ROllout"? [16:53:23] yes [16:53:40] Heh good to hear! Yeah I'd also be happy to wait for a bit more days of impression data, in any case [16:53:41] Yesterday I got some flack over the KV store error cookie. It could deteriorate performance, leak data to us, and should have been mentioned in the deploy announcement. Here's the change to remove it: https://gerrit.wikimedia.org/r/#/c/235667/ [16:54:31] The other issue is that the KV store items never expire. I've been working on a patch for that too, but I think maybe some doc, especially for CN admins, is more urgent [16:54:44] Sounds right. [16:55:04] Yep! [16:55:22] Anyway, at least mobile banners are still up in Finland! [16:55:37] lol hopefully we didn't facilitate that [16:55:44] Nothing serious is here: https://performance.wikimedia.org/ [16:55:51] awight: we did, it's our job :) [16:56:15] That doesn't make it moral :p [16:57:26] True, though battles to wage must also be triaged... How is it that the iPhone app isn't fully FOSS? I don't get it... If that's the case issue shouldn't be that we're announcing it, but that we're working on it... [16:58:02] I'd say that was a poorly thought-through missive [16:58:10] Really divisive [16:58:16] the banner? or the project? [16:58:41] ori's letter scolding the droid team [16:59:18] Turns out, fundraising is doing exactly the same thing, driving people towards really evil closed source, for-profit sites [17:01:00] mmm... I'm imagining that e-mail letter was really the n-th rebound of some other ricocheting projectiles [17:01:21] on that note, privacy badger seems to kill the WP iframe workflow [17:01:38] ah hmmm! [17:01:52] hehehe [17:01:54] blocked by client [17:02:17] WRT the for-profit sites, mmm... I guess I can't disagree, but also my computer has a non-free BIOS. Should I toss it? [17:03:09] exactly [17:03:18] well, that's not really fair [17:03:26] heheh also true [17:03:46] Sending people to G$$gle Play is a bit embarrassing, and more avoidable than using a bios. [17:04:03] Oh yeah indeed [17:04:06] tangential but the entire firmware on a raspi is proprietary [17:04:10] bootloader and everything [17:04:13] COME ON [17:04:21] heh didn't know that [17:04:31] just case it gets hailed as so open [17:04:36] *cause [17:04:38] * AndyRussG was dreaming of a phone w/ GPS yesterday [17:04:50] aaarggg! Really appreciate everyone's help and patience yesterday, once again...!! I'm gonna take care of some personal hygeine (showering and dishes) , back shortly! [17:06:27] awight: i finally have the WP workflow for popping open the iframe w/ returned url, will take some wedges to make it not break the current one but should be no big deal [17:06:41] holy cow, that's awesome [17:06:51] so if we do get some answers from them trying it out should be easy [17:06:55] did I miss any progress on the XML garbage [17:06:59] ah ok no then [17:07:13] heh nah, i just have it regexing in another url [17:07:20] with proper escaping [17:07:30] btw I'm not planning on being on the call today unless you think it would be helpful for me to get mad or something [17:07:39] nice [17:07:42] hehe totally up to you [17:07:55] then, no :) [17:08:15] i do think it'd be ridiculous to support non compliant xml and i'll probably say that [17:08:25] we *can't* is what I'd add [17:08:54] yeah, good, i also think that should be a hard line [17:09:09] and i was hoping you would too [17:10:06] There's just no way to safely parse bad XML [17:10:32] an & could appear anywhere in their response. it could be &... [17:10:44] ooh and the catbox! love that cabox. It's sooo sweeet the way our cat carefully buries each pooh [17:10:48] we can't even safely identify which field is the stupid OTTblablah [17:10:55] O_o [17:11:04] K4-713: you missed it. [17:11:16] yeah exactly, the precise reason they put it in the spec [17:11:29] awight: What'd I miss? [17:11:38] hehe wow [17:11:55] someone should add that to the topic [17:12:04] AndyRussG|sortof: my cat got into the middle of a crow fight last night [17:12:07] it was nuts [17:12:22] right outside our bedroom window, one crow even jumped into the house for a second until Michelle beat it back with a bookend. [17:12:25] 5:30 AM [17:12:33] whoa [17:12:44] the cat disabled one crow, which then looked at me like, "What." [17:13:04] omg [17:13:10] they know too much [17:13:22] crows are crazy smrt [17:13:34] heh my cat is afraid of squirels [17:13:44] Then of course I set my pitbull loose on the whole scene, and he chased the wrong guy. Treed my cat. [17:13:52] I'm surprised we got back to sleep, actually. [17:14:06] haha squirrels are not much individually, but fearsome as a gang [17:14:35] They sure are breeding here! Yesterday I saw 4 at once on our tree [17:14:44] i saw this thing where crows drop nuts in the road and wait for cars to run over them, then go down and wait for the walk signal to go get their cracked nuts [17:15:14] that's so cool [17:15:40] There was a girl on TV who had befriended the crows. They would follow her to the school bus and give her presents, which she collected into really cool art [17:16:03] gotta run, taking the kid into the office for semifree lunch! [17:16:06] Used to get crows near my Dad's auto shop that would line walnuts up on the train tracks and wait for a train to come by. [17:17:17] corvids are freaking brilliant [17:18:59] Yea, scary smart. They know you by your face too, pays to not be a jerk to them. [17:19:18] Not that I would anyway, they're cool as hell. [17:19:48] yeah i totally don't look at them like animals anymore [17:19:56] they get it [18:11:06] cwdent: Awesome to hear you've got the iframe thing working! If you've got a satisfying way of separating the form stuff from the generic mustache payment form I'd love to see your WIP so I can align the Amazon branch with it [18:12:34] ejegg: for sure, one sec... [18:13:22] ejegg: this is what i did so far https://gerrit.wikimedia.org/r/#/c/234584/1 [18:13:38] i think it's more or less what needs to happen, but might not be the best way, lmk what you think [18:14:29] Oh yeah, moving the generic out into astropay looks good. What about how you're adding the WP-specific behavior? [18:14:52] I mean, moving the not-quite-generic stuff [18:15:07] i just stuck a new file in wp/forms/js and added it as an RL module [18:16:09] ah, ok - just appending the iframe to existing form elements? [18:16:32] yep, i copied that from...webitect.js or something? [18:16:37] ok [18:16:44] the markup is super rough right now [18:17:04] i just figure let's proof of concept the behavior before bother with polish [18:17:22] cool [18:17:26] also i am awful at design and will probably ask for your help :) [18:17:46] heh, this whole team is kinda lacking in that department right now! [18:18:44] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Nightly Amazon report download - https://phabricator.wikimedia.org/T109654#1603514 (Ejegg) [18:18:51] ejegg: the thing i'm fiddling with now is passing ffname with the token request so the adapter can know to do a couple different things [18:19:02] on the ajax call [18:19:46] oh yeah, since that's the determinant for which WP method is used [18:20:14] yep...i think i need to add it to var map or something? [18:20:32] varMap is used in staging [18:20:45] adapter file is mondo [18:20:54] to map our internal names for things to gateway API parameter names [18:21:18] ok yeah [18:21:25] it doesn't need to get sent [18:21:29] feel free to tear at any seams you may find in that monster [18:22:31] hehe, ok [18:27:00] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Comb Amazon out of our Mustache - https://phabricator.wikimedia.org/T111424#1603542 (Ejegg) [18:27:10] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Comb Amazon out of our Mustache - https://phabricator.wikimedia.org/T111424#1603535 (Ejegg) [18:31:21] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Parse new Amazon transaction reports and import into Civi - https://phabricator.wikimedia.org/T111425#1603560 (Ejegg) NEW [18:32:18] Fundraising-Backlog: [EPIC] Amazon (embedded) internal test - https://phabricator.wikimedia.org/T108102#1603567 (Ejegg) [18:32:19] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Comb Amazon out of our Mustache - https://phabricator.wikimedia.org/T111424#1603568 (Ejegg) [18:34:07] Fundraising-Backlog: [EPIC] Amazon embedded campaign ready version - https://phabricator.wikimedia.org/T108109#1603570 (Ejegg) [18:34:08] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Parse new Amazon transaction reports and import into Civi - https://phabricator.wikimedia.org/T111425#1603571 (Ejegg) [18:57:09] (PS2) Cdentinger: WIP worldpay ESOP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234691 [18:57:55] (CR) jenkins-bot: [V: -1] WIP worldpay ESOP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234691 (owner: Cdentinger) [19:01:23] hmm that's interesting [19:01:26] 18:57:29 ^ 'submitForm' was used before it was defined. [19:01:31] itchy trigger finger jenkins [19:10:53] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Implement Amazon recurring widget client-side - https://phabricator.wikimedia.org/T111428#1603672 (Ejegg) NEW [19:19:25] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Implement recurring logic in Amazon gateway adapter - https://phabricator.wikimedia.org/T111430#1603703 (Ejegg) NEW [19:20:18] PPena: msg from WP, i am fine having the call or skipping it based on what he said, whatever you think [19:20:57] ejegg: do you happen to know if adding cdata tags will satisfy our xml parser? [19:21:13] cwdent if a call wont help you, I think we should skip it and not waste your time :) Did his email make sense and you think evrything you need will be fixed? [19:21:27] cwdent: actually, that might do the trick! [19:21:30] would you like to follow up over email and confirm any questions? [19:21:55] PPena: sure sounds good, yes if what he says is getting fixed actually does, i think it will work [19:22:14] i have everything mocked up on our end so if we get a good url things should move rather quickly [19:22:31] great. After this gest fixed (today or tomorrow) do you need any extra info from them to move forward? [19:22:51] not at this point [19:22:56] i'll reply to the message [19:27:16] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Recurring donation module should be able to charge Amazon recurring donations - https://phabricator.wikimedia.org/T111431#1603726 (Ejegg) NEW [19:30:54] cwdent: how about defining an mw.paymentForm module in the common mustache forms.js for shared functionality? Astropay is sharing some old janky validation logic with (i think) globalcollect, and we could port XenoRyet's nicer stuff into paymentForm [19:33:52] yeah that sounds like a good idea [19:34:10] cool [19:34:16] I do sort of recall that WP was calling the same validation function as GC, theoretically it'd be easy to slide the new stuff in. [19:35:43] nice. If it's got nothing to do with the way the form's rendered, maybe just change the existing script to hang the validate function on a mw.something module instead of window. [19:36:47] ejegg: do you want everything from the astropay file to go in the general one? [19:37:32] cwdent: Not all of it. The continue button shouldn't necessarily submit the form. [19:38:59] I'm warming to the event thing though. That way we can change the button ids and only have to make 1 change in js [19:40:20] so general stuff includes: validation, events for submethod select, continue button press, maybe field changes, and functions to show/hide the loader overlay [19:43:26] cool [19:43:45] are we gonna prawn in 20 still? maybe we could make a task for it [19:43:53] yeah, making it now! [19:44:04] oh righteous [19:50:36] Ugh. Food cooks a lot better in the rice cooker when you push the button down to "cook". [19:50:51] well at least it got wet! [19:50:56] It did, yes. [19:51:12] Tepid... [19:51:16] * K4-713 sighs [19:51:33] Sorry, but I'm probably going to have to eat at you all during the meeting. [19:52:34] K4-713: do you have one where you put the vegetables in the top? [19:52:59] I do, but I'm not doing that. [19:53:11] Mostly I just throw it all in the food hole and hit the "go" button. [19:53:31] nice [19:53:34] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Move shared client-side functions to an mw.something module - https://phabricator.wikimedia.org/T111436#1603820 (Ejegg) [19:53:35] Works pretty well if you just want rice with with frozen [whatever]. [19:53:59] my favorite is when it's done i throw it in a pan with some oil and crack an egg in there [19:54:09] Ooooh, yes. [19:54:15] That is a good strategy. [19:54:27] I am usually too lazy for that kind of thing. [19:55:11] Rice, mushrooms, peeled edamame, coconut oil, some kind of protein, maybe some sauce if I'm feeling fancy... [19:55:30] Then "go" button. [19:55:56] you are vegetarian right? [19:55:59] Aye. [19:56:19] Today's foodball features some pretty convincing veggie chicken. [19:56:39] Maybe help seeds. [19:57:02] nice. i'm nothing, but dani is vegan so we do a lot of experimenting with protein sources [20:00:16] cwdent: You're probably sick of coconut oil then, too, huh? :) [20:00:27] I *love* the stuff. [20:00:38] But I never really liked butter. [20:01:00] oh yeah i love coconut oil [20:01:11] I buy actual buckets of it. [20:01:29] we eat mad this stuff http://earthbalancenatural.com/product/original-buttery-spread/ [20:01:38] it's super good and has like 3 ingredients [20:01:39] K4-713: the laptop is still stuck in customs :-( [20:02:31] eileen: Noooooooes! [20:02:32] ...it's okay. [20:02:56] Sad, but okay. [20:03:36] It sounds like you're finding a lot of interesting stuff to tackle anyway, though, so I'm not too worried. [20:03:53] I do want to get you in to poke around on prod as soon as it shows up, though. :) [20:04:06] K4-713: yeah - that will be interesting! [20:04:14] Then you will be able to peer directly into our weirdness. [20:04:24] ...instead of just hearing stories. [20:04:26] I'm going to fire up the Giant Rabbit report locally & see what they look like today [20:04:38] Great! [20:05:59] K4-713: also - I got tickets to the GSOC summit in Nov - I'll be in SF from 3-15 Nov - please don't tell me you guys will all be in Brazil then! [20:06:38] Ha, no. Somebody will be here. I think both awight and me. [20:06:52] That's great news. :) [20:07:31] There will probably be some civi frontend users in major gifts and donor services that would love to meet you. [20:07:31] Fundraising-Backlog: Implement Amazon payment notification listener - https://phabricator.wikimedia.org/T109649#1603900 (Ejegg) [20:08:36] seconded. K4-713 [20:09:02] K4-713: cool - I managed to get the ticket within the GSOC price limit - all I had to do to stay up until 2am when a super-special promotion came on :-) [20:11:49] Fundraising Sprint S, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Move shared client-side functions to an mw.something module - https://phabricator.wikimedia.org/T111436#1603926 (cwdent) a:cwdent [20:16:01] Fundraising Sprint S, Fundraising-Backlog: MW-Vagrant CRM role needs maintenance - https://phabricator.wikimedia.org/T110372#1603960 (Ejegg) [20:16:02] Fundraising Sprint Rowlf the Dog, Fundraising Sprint S, Fundraising-Backlog, Recurring-Donations, Patch-For-Review: GC error causing donors to create multiple recurring donations - https://phabricator.wikimedia.org/T110367#1603961 (Ejegg) [20:16:03] Fundraising Sprint S, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM interface for repairing damaged recurring contributions - https://phabricator.wikimedia.org/T110095#1603962 (Ejegg) [20:16:05] Fundraising Sprint Rowlf the Dog, Fundraising Sprint S, Fundraising Tech Backlog, Fundraising-Backlog, Patch-For-Review: Review and fix error handling in php-queue - https://phabricator.wikimedia.org/T109901#1603963 (Ejegg) [20:16:07] Fundraising Sprint Rowlf the Dog, Fundraising Sprint S, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Settle unslain orphans - https://phabricator.wikimedia.org/T109668#1603964 (Ejegg) [20:16:23] Fundraising Sprint Queen, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, and 11 others: CentralNotice: key-value storage for new campaign-associated mixins/banner history - https://phabricator.wikimedia.org/T94763#1603978 (Ejegg) [20:16:26] Fundraising Sprint Queen, Fundraising Sprint ODB, Fundraising Sprint Rowlf the Dog, Fundraising Sprint S, and 4 others: Banner history mixins and data - https://phabricator.wikimedia.org/T90918#1603979 (Ejegg) [20:18:21] Fundraising Sprint Rowlf the Dog, Fundraising-Backlog: Sprint R Goal: Amazon internal test, banner history beta test - https://phabricator.wikimedia.org/T107346#1603992 (Ejegg) [20:18:55] Fundraising Tech Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: JS code style, JSCS and JSDuck - https://phabricator.wikimedia.org/T111387#1603996 (AndyRussG) [20:24:12] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: JS code style, JSCS and JSDuck - https://phabricator.wikimedia.org/T111387#1604028 (AndyRussG) [20:24:50] Fundraising Sprint S, Fundraising-Backlog: Sprint S Goal: worldpay internal test and continue Amazon - https://phabricator.wikimedia.org/T107347#1604036 (cwdent) [20:25:06] Fundraising Sprint S, Fundraising-Backlog: worldpay internal test: Add forms to form chooser settings - https://phabricator.wikimedia.org/T110426#1604037 (cwdent) [20:25:15] Fundraising Sprint S, Fundraising-Backlog: worldpay internal test: Make API requests to get iframe URL - https://phabricator.wikimedia.org/T110422#1604040 (cwdent) [20:25:20] Fundraising Sprint Rowlf the Dog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Deploy CentralNotice schema change - https://phabricator.wikimedia.org/T104508#1604042 (AndyRussG) Open>Resolved [20:25:22] Fundraising Sprint Queen, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, and 11 others: CentralNotice: key-value storage for new campaign-associated mixins/banner history - https://phabricator.wikimedia.org/T94763#1604044 (AndyRussG) [20:25:37] Fundraising Sprint S, Fundraising-Backlog: worldpay internal test:Display Iframe - https://phabricator.wikimedia.org/T110423#1604048 (cwdent) [20:25:52] Fundraising Sprint S, Fundraising-Backlog: worldpay internal test: Write controller logic to handle return from iframe - https://phabricator.wikimedia.org/T110424#1604051 (cwdent) [20:26:09] Fundraising Sprint S, Fundraising-Backlog: worldpay internal test: Store donor info in a limbo or pending queue - https://phabricator.wikimedia.org/T110425#1604054 (cwdent) [20:27:05] Fundraising Sprint S, Fundraising-Backlog: [epic] Internal testing with French credit cards - https://phabricator.wikimedia.org/T110112#1604059 (cwdent) [20:27:45] Fundraising Sprint S, Fundraising-Backlog: [epic] Internal testing with French credit cards - https://phabricator.wikimedia.org/T110112#1604065 (cwdent) a:cwdent [20:27:55] Fundraising Sprint S, Fundraising-Backlog: worldpay internal test: Store donor info in a limbo or pending queue - https://phabricator.wikimedia.org/T110425#1604066 (cwdent) a:cwdent [20:28:03] Fundraising Sprint S, Fundraising-Backlog: worldpay internal test: Write controller logic to handle return from iframe - https://phabricator.wikimedia.org/T110424#1604067 (cwdent) a:cwdent [20:28:13] Fundraising Sprint S, Fundraising-Backlog: worldpay internal test:Display Iframe - https://phabricator.wikimedia.org/T110423#1604068 (cwdent) a:cwdent [20:28:23] Fundraising Sprint S, Fundraising-Backlog: worldpay internal test: Make API requests to get iframe URL - https://phabricator.wikimedia.org/T110422#1604069 (cwdent) a:cwdent [20:28:32] Fundraising Sprint S, Fundraising-Backlog: worldpay internal test: Add forms to form chooser settings - https://phabricator.wikimedia.org/T110426#1604070 (cwdent) a:cwdent [20:28:46] hi ejegg, can I ask you a quick question? [20:28:59] Fundraising Sprint Rowlf the Dog, Fundraising Sprint S, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Give KVStore items limited TTL - https://phabricator.wikimedia.org/T111385#1604074 (AndyRussG) [20:30:02] Fundraising Sprint Rowlf the Dog, Fundraising Sprint S, Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Triage what to do with civi-core patches: extensions, upstream, or abandon - https://phabricator.wikimedia.org/T99836#1604080 (Ejegg) [20:30:20] what's up ccogdill ? [20:30:24] Fundraising Sprint Rowlf the Dog, Fundraising Sprint S, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Documentation: overview of new CN code and instructions for CN admins - https://phabricator.wikimedia.org/T111386#1604083 (AndyRussG) [20:30:34] I’m trying to match some GC data with data in Civi [20:30:45] ok [20:30:52] they sent me email addresses (sadly I don’t have order IDs) and I want to get preferred language [20:31:04] but the catch is these are for failed payments [20:31:18] do we keep emails for failed payments anywhere for a short period of time? [20:31:26] this is from the weird outage yesterday [20:31:31] ooh, if they failed we would have to get those from the payments cluster logs [20:31:42] is that not something I can easily do? [20:32:03] are you familiar with the command line tool 'grep' ? [20:32:09] never used it before [20:32:26] is that outside of mysql? [20:32:44] yeah, it's a way to filter through files to find just the lines you want [20:32:57] but there's a bit of a learning curve [20:33:06] haha. not so easy then [20:33:15] Want to make a ticket for it? [20:33:27] one of fr-tech can probably get that without too much trouble [20:33:59] hmm… this is kind of time sensitive. the farther we get away from the failure date, the less it makes sense to contact people. you think it could get done today or early tomorrow? [20:34:14] otherwise I can see if maybe we want to gamble with the language data and make decisions based on country… [20:34:38] Fundraising Sprint S, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate: Central Notice message groups are slow to index - https://phabricator.wikimedia.org/T111189#1604128 (AndyRussG) a:AndyRussG [20:35:02] yeah, we can definitely prioritize this [20:35:11] okay cool, I’ll make a card [20:35:19] sorry for the last minute notice [20:35:35] no worries! This stuff happens... [20:35:51] ooh, i hope we actually have language in the logs. I /think/ we do [20:35:59] :D [20:36:00] Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, Fundraising Sprint S, Fundraising-Backlog, and 3 others: Publishing translations for central notice banners fails - https://phabricator.wikimedia.org/T104774#1604135 (AndyRussG) [20:36:01] fingers crossed [20:37:10] Fundraising Sprint S, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate: New banner messages not added to message group - https://phabricator.wikimedia.org/T106856#1604138 (AndyRussG) [20:37:44] Fundraising Sprint S, Fundraising-Backlog: worldpay internal test:Display Iframe - https://phabricator.wikimedia.org/T110423#1604141 (cwdent) [20:37:50] Fundraising Sprint S, Fundraising-Backlog: worldpay internal test: Make API requests to get iframe URL - https://phabricator.wikimedia.org/T110422#1604142 (cwdent) [20:39:09] Fundraising Sprint S, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate: New banner messages not added to message group - https://phabricator.wikimedia.org/T106856#1604145 (AndyRussG) a:AndyRussG [20:41:52] Fundraising Sprint S, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Comb Amazon out of our Mustache - https://phabricator.wikimedia.org/T111424#1604158 (Ejegg) [20:42:34] Fundraising Sprint S, Fundraising-Backlog: Implement Amazon payment notification listener - https://phabricator.wikimedia.org/T109649#1604162 (Ejegg) a:Ejegg [20:42:58] Fundraising-Backlog: Parse Amazon last name data differently (or: review the way we receive Amazon name data) - https://phabricator.wikimedia.org/T86720#1604164 (Ejegg) [20:46:00] https://www.youtube.com/watch?v=vlmPFLClPjM [20:46:07] SERIOUS BUSINESS ^^ [20:51:15] Fundraising-Backlog: Append preferred language data to list of email addresses from failed GC payments - https://phabricator.wikimedia.org/T111448#1604178 (CCogdill_WMF) NEW [21:17:14] cwdent, XenoRyet, ejegg|bike, AndyRussG: I feel I should apologize again for the terribleness of that meeting. [21:17:16] Ow. [21:17:38] hey, it was fine! [21:17:44] It's crazy how much I just lost, about how to run those things. [21:17:59] i think it went pretty well! [21:18:17] It really underlines why David and Anne are amazing, I think. [21:18:28] Very complimentary. :) [21:28:00] K4-713: yeah i agree, it is a real privilege having that aspect of things so well taken care of [21:28:25] i was the one stop shop for all computer related complaints for many years [21:28:47] Oof. [21:28:59] I had that job for a while too. [21:29:11] Network Admin + I/T + Complaints Department [21:29:38] yep [21:29:45] printer support [21:29:47] kill me [21:29:54] PC Load Letter. [21:30:13] ohh I did that too. We used to get people call up to move their monitor ! [21:30:22] :( [21:30:26] so, we used to send down our staff member who was normally tiny [21:30:32] except she was 8 months pregnant [21:30:45] turned out people could move them themselves when we sent her :-) [21:30:50] hehe [21:31:01] :D [21:31:15] When I was doing that job, it was with a bunch of dudes. [21:31:20] In that they employed no other women at all. [21:31:44] we always had such cheap hardware, i'd smell burning power supply walking down the hall and be like, welp gonna get an email about that [21:31:59] :-) [21:32:00] And every time I had to carry a thing as part of my job: "Oh here, let me get that for you." They also didn't like me crawling around on the ground or messing with cables or... touching devices. [21:32:21] heh [21:32:43] We went to do a PC rollout in a rural office & we asked people to help us move the PCs [21:33:10] only one person said yes & when we asked for a trolley to get things to the front door he brought out his ute [21:33:28] (what do you call them? like a pickup truck I guess) [21:33:57] oh dear [21:34:08] but, after I carried one of those old 19 inch monitors throught the office all the big burly blokes were suddenly happy to help [21:34:18] a bit of shame never hurts [21:34:56] hehe, ute, never heard that before [21:35:11] It's short for utility vehicle [21:35:39] it's getting multicultural in -fr [21:35:55] CRM/Report/Form/Instance.php [21:36:01] sorry wrong paster [21:36:25] https://www.google.com/search?q=toyota+ute&tbm=isch&imgil=6U3QPdsa4o4B5M%253A%253BQgtOVO_pNtrUbM%253Bhttp%25253A%25252F%25252Fcottesloecarhire.net.au%25252F&source=iu&pf=m&fir=6U3QPdsa4o4B5M%253A%252CQgtOVO_pNtrUbM%252C_&biw=1600&bih=739&usg=__DHXzxi2uqOx24K9p_AkYgNy_v_I%3D&ved=0CFQQyjdqFQoTCKi96_no28cCFcEYpgodomkM2g&ei=Fr3oVajaB8GxmAWi07HQDQ#imgrc=6U3QPdsa4o4B5M%3A&usg=__DHXzxi2uqOx24K9p_AkYgNy_v_I%3D [21:36:47] or ... https://en.wikipedia.org/wiki/Ute_%28vehicle%29 [21:37:23] can you buy a toyota hilux in NZ? [21:37:36] Yep! [21:38:06] nice, i want one of those [21:38:22] they used to have them in the US but call T100, but now we don't have them at all [21:38:49] lots of people have them rurally - the farm dogs can ride on the back [21:39:03] (we don't have farm dogs - but we have a friend who does) [21:59:03] I have to be AFK for an event at my kids' school, back in a couple hrs! [22:01:48] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog: Append preferred language data to list of email addresses from failed GC payments - https://phabricator.wikimedia.org/T111448#1604505 (Ejegg) a:Ejegg [23:04:30] (PS1) Legoktm: build: Updating development dependencies [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/235916 [23:07:25] (CR) Jforrester: [C: 2] build: Updating development dependencies [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/235916 (owner: Legoktm) [23:10:37] fundraising-tech-ops, netops, operations: Cleanup layer2 firewall config from pfw-eqiad - https://phabricator.wikimedia.org/T111463#1604749 (faidon) NEW [23:24:01] (Merged) jenkins-bot: build: Updating development dependencies [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/235916 (owner: Legoktm)