[00:04:03] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Write banner diet campaign mixin - https://phabricator.wikimedia.org/T112017#1623250 (awight) a:awight [00:04:25] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Write banner diet campaign mixin - https://phabricator.wikimedia.org/T112017#1622856 (awight) [00:49:11] (PS1) Awight: Group mixin controls in a nested fieldset [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237308 [01:07:17] (PS1) Ejegg: Add PayWithAmazon SDK [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/237312 [01:10:56] (PS2) Ejegg: Add PayWithAmazon SDK [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/237312 [01:14:16] (PS1) Ejegg: WIP New Amazon payment listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/237313 (https://phabricator.wikimedia.org/T109649) [01:32:46] (PS2) Ejegg: WIP New Amazon payment listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/237313 (https://phabricator.wikimedia.org/T109649) [01:34:22] (PS3) Ejegg: WIP New Amazon payment listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/237313 (https://phabricator.wikimedia.org/T109649) [05:28:52] (CR) Ejegg: "I really like this feature! It would be too bad to introduce it with x-small text though. Noted a couple other ways I saw enwiki display" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236422 (owner: Awight) [12:15:44] TCB-Team-Fundraising-Sprint-2015-08-12, TCB-Team-Fundraising-Sprint-2015-08-26, TCB-Team-Fundraising-Sprint-2015-09-02, TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team: [WMDE-Fundraising] Move Piwik to its own VM - https://phabricator.wikimedia.org/T105289#1624873 (Tobi_WMDE_SW) [12:51:09] TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team: [WMDE-Fundraising] Bug: fix contact form error - https://phabricator.wikimedia.org/T111683#1624988 (Tobi_WMDE_SW) [12:54:29] TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team: [WMDE-Fundraising] Add validation api to the fundraising app - https://phabricator.wikimedia.org/T112063#1625003 (Tobi_WMDE_SW) [12:55:25] TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team: [WMDE-Fundraising] Add storing api to the fundraising app - https://phabricator.wikimedia.org/T112065#1625008 (Tobi_WMDE_SW) [12:56:09] TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team: [WMDE-Fundraising] Create a validation mechanism for Doctrine Entity Classes - https://phabricator.wikimedia.org/T112076#1625018 (Tobi_WMDE_SW) [12:58:58] TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team: [WMDE-Fundraising] Implement validator class for donations - https://phabricator.wikimedia.org/T112076#1625023 (WMDE-leszek) [13:00:50] TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team: [WMDE-Fundraising] export x-tracking - https://phabricator.wikimedia.org/T112092#1625032 (Tobi_WMDE_SW) NEW [13:00:53] TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team: [WMDE-Fundraising] export x-tracking - https://phabricator.wikimedia.org/T112092#1625039 (Tobi_WMDE_SW) [13:12:47] TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team: [WMDE-Fundraising] estimate effort: membership payment processing via ppl and cc and money transfer - https://phabricator.wikimedia.org/T112094#1625086 (Tobi_WMDE_SW) NEW [13:12:58] TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team: [WMDE-Fundraising] estimate effort: membership payment processing via ppl and cc and money transfer - https://phabricator.wikimedia.org/T112094#1625093 (Tobi_WMDE_SW) [13:21:26] (PS2) AndyRussG: Subscribing RL modules: Whitespace style for function declarations [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235759 (https://phabricator.wikimedia.org/T111387) [13:24:05] TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team: [WMDE-Fundraising] estimate effort: membership payment processing via ppl and cc and money transfer - https://phabricator.wikimedia.org/T112094#1625147 (Tobi_WMDE_SW) [14:05:43] morning the-wub ! [14:06:03] hey cwdent :) how's it going? [14:06:50] not bad, i'm up and available if someone from worldpay wants to talk! [14:42:06] WP just hung up on me [14:44:59] TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team: [WMDE-Fundraising] export x-tracking - https://phabricator.wikimedia.org/T112092#1625487 (kai.nissen) a:kai.nissen [14:49:32] TCB-Team-Fundraising-Sprint-2015-09-02, TCB-Team: [WMDE Fundraising] Detailed implementation plan and estimation for sensitive banner - https://phabricator.wikimedia.org/T111165#1625494 (Tobi_WMDE_SW) Open>Resolved a:Tobi_WMDE_SW [14:49:54] TCB-Team-Fundraising-Sprint-2015-09-02, TCB-Team: [WMDE-Fundraising] Investigate Twitter Bootstrap to improve mobile experience - https://phabricator.wikimedia.org/T111168#1625499 (Tobi_WMDE_SW) Open>Resolved [14:50:48] TCB-Team-Fundraising-Sprint-2015-09-02, TCB-Team: [WMDE-Fundraising] Investigate general ways of improving mobile experience - https://phabricator.wikimedia.org/T111169#1625506 (Tobi_WMDE_SW) Open>Resolved [14:51:32] TCB-Team-Fundraising-Sprint-2015-09-02, TCB-Team: [WMDE-Fundraising] Document current status of mobile tracking - https://phabricator.wikimedia.org/T111167#1625516 (Tobi_WMDE_SW) Open>Resolved [14:52:40] TCB-Team-Fundraising-Sprint-2015-09-02, TCB-Team: [WMDE-Fundraising] Number of views of desktop page with mobile devices during campaign - https://phabricator.wikimedia.org/T111166#1625519 (Tobi_WMDE_SW) Open>Resolved [14:54:49] TCB-Team-Fundraising-Sprint-2015-08-26, TCB-Team-Fundraising-Sprint-2015-09-02, TCB-Team: [WMDE-Fundraising] Determine current tracking waypoints and identify missing ones - https://phabricator.wikimedia.org/T110318#1625534 (Tobi_WMDE_SW) Open>Resolved [14:55:40] TCB-Team-Fundraising-Sprint-2015-08-26, TCB-Team-Fundraising-Sprint-2015-09-02, TCB-Team: [WMDE-Fundraising] Remove unused templates from content staging wiki - https://phabricator.wikimedia.org/T110322#1625537 (Tobi_WMDE_SW) Open>Resolved [15:47:14] TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team: [WMDE-Fundraising] Bug: fix contact form error - https://phabricator.wikimedia.org/T111683#1613601 (WMDE-leszek) Patch on github: https://github.com/wmde/fundraising/pull/677 [15:48:17] (PS2) Awight: Support help text for mixin parameters [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236422 [15:48:18] (PS4) Awight: WIP Banner diet mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 [15:49:49] (CR) jenkins-bot: [V: -1] WIP Banner diet mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (owner: Awight) [15:53:12] (CR) Ejegg: [C: 2] Group mixin controls in a nested fieldset [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237308 (owner: Awight) [16:04:45] (CR) AndyRussG: "Woohoo!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237308 (owner: Awight) [16:05:59] is gmail slow for anyone else today? [16:07:57] Hmm no problems w/ my client (Icedove a.k.a Thunderbird) [16:15:23] i am just a filthy casual on the web client [16:15:47] you know it usually works great but navigating this huge thread with churning recipients is kinda brutal [16:24:29] Hmmm [16:32:17] (PS2) AndyRussG: Typo and whitespace [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237296 (owner: Awight) [16:33:30] (CR) AndyRussG: [C: 2] Typo and whitespace [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237296 (owner: Awight) [16:33:43] Caminando por el campo, una vaca me encontré [16:34:19] Sorry, I've always wanted to write that in IRC and have always repressed the desire, until now [16:38:38] Como no tenía nombre, le puse: "Jenkins" [16:38:44] Oh, Jenkins, la vaca eres tú [16:39:07] Si te jalo de la cola, ¿qué dices tú? [16:39:15] (CR) Siebrand: [C: -1] "See notes on PS3." (4 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (owner: Awight) [16:39:39] (to the tune of Oh Susanna) [16:44:21] On another note, if anyone's been following the news out of Mexico, the government there has just implicated itself in the cover-up of the real motive of the killing of 43 student teachers almost 1 year ago: http://www.jornada.unam.mx/2015/09/10/politica/010n2pol [16:47:15] (PS1) AndyRussG: Subscribing JS: remove proxy methods on cn object [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237418 [17:55:47] sup awight [17:58:13] hey awight - we're in the hangout i believe [17:58:22] i can get a different link for you if you've maybe got the wrong one [18:10:55] fundraising-tech-ops, operations: build libanon package for trusty - https://phabricator.wikimedia.org/T110739#1626728 (Jgreen) >>! In T110739#1585629, @Jgreen wrote: > Doesn't compile: > > checking whether to build shared libraries... yes > checking whether to build static libraries... yes > ./configure... [18:12:18] fundraising-tech-ops: build librdkafka for Trusty - https://phabricator.wikimedia.org/T112139#1626733 (Jgreen) NEW a:Jgreen [18:12:53] fundraising-tech-ops: build librdkafka for Trusty - https://phabricator.wikimedia.org/T112139#1626742 (Jgreen) [18:12:55] fundraising-tech-ops, operations: package udp-filter for Trusty, for use on fundraising banner_logger - https://phabricator.wikimedia.org/T110592#1626741 (Jgreen) [18:13:14] fundraising-tech-ops: build librdkafka for Trusty - https://phabricator.wikimedia.org/T112139#1626733 (Jgreen) builds clean on trusty, security review required [18:14:26] fundraising-tech-ops, operations: package udp-filter for Trusty, for use on fundraising banner_logger - https://phabricator.wikimedia.org/T110592#1581705 (Jgreen) >>! In T110592#1620649, @Ottomata wrote: > Ah hm. Ok! Since they work fine there, maybe we can just reprepro copy them into Trusty? I don't... [18:17:31] fundraising-tech-ops, operations: package udp-filter for Trusty, for use on fundraising banner_logger - https://phabricator.wikimedia.org/T110592#1626773 (Jgreen) Package builds for Precise, but explodes in a ball of fire on Trusty in what appears to be an automake forward incompatibility: > Makefile.am:... [18:19:53] (PS1) Alex Monk: Fix undefined $result variable [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237450 (https://phabricator.wikimedia.org/T112138) [18:21:03] (CR) Alex Monk: Campaign-associated mixins (1 comment) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [18:24:58] fundraising-tech-ops: Give @sventura civicrm cert on her new computer - https://phabricator.wikimedia.org/T112143#1626822 (atgo) NEW a:Jgreen [18:31:04] (CR) AndyRussG: [C: 2] "Thanks!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234830 (owner: Glaisher) [18:33:56] (Merged) jenkins-bot: Fix undefined variable notice from CentralNoticeCampaignLogPager::testTextChange() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234830 (owner: Glaisher) [18:34:56] ejegg: can i ask you a couple DI questions? [18:35:08] sure, what's on your mind? [18:35:53] ok, when the user lands back on the special page after the iframe, it fires off a QueryTokenData request [18:36:41] the problem is the token (OTT) doesn't make it into the xml, i think because it's not happening as a response process but just a redirect? [18:37:10] but i am also confused as to how it decides to do that QueryTokenData...because OTT is present in the url maybe? [18:38:16] yep, see that 'isProcessImmediate' function in worldpay_gateway.body.php [18:38:30] (CR) AndyRussG: "Thanks so much!!! There was another patch already in the pipeline, I31f72041d5, which also fixed this, and which I just +2'ed. MMmm, also," [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237450 (https://phabricator.wikimedia.org/T112138) (owner: Alex Monk) [18:38:45] (Abandoned) AndyRussG: Fix undefined $result variable [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237450 (https://phabricator.wikimedia.org/T112138) (owner: Alex Monk) [18:38:54] that's what the base GatewayPage class calls to determine whether to just show the form or to call doPayment [18:40:35] ah! [18:41:43] can you tell whether wp_one_time_token is set in unstaged or staged data by the time do_transaction is called for the token query? [18:42:12] seems like a good midpoint to start debugging its absence in the sent XML [18:42:28] ejegg: it's definitely not in staged, let me check unstaged [18:45:44] huh, not seeing where we read it back in from the querystring [18:46:30] it does look like we store it in session after we generate the token. We're still doing that before we open the iframe, right? [18:47:42] (PS1) 20after4: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/237458 [18:48:19] ejegg: i think they don't actually send it with the first response [18:48:26] in the SOP world [18:48:29] only with the iframe url [18:48:55] Oh, so we don't parse it out of there. [18:49:10] Do they append it to the querystring on the return URL? [18:49:32] yep [18:49:48] (with an ampersand :P) [18:50:05] Heh. OK, so we need to do something to pull it from there. I think we must have been relying on the session value before [18:50:50] or we could parse it out of the returned iframe URL and store it in session then [18:51:28] ok yeah that's what i thought [18:52:02] we don't really have a smart way for gateways to ask for non-standard things to be pulled from the browser's POST [18:52:20] see comment on DonationData::populateData [18:53:09] how to those stage_varname functions get fired? i'm guessing dynamically... [18:53:46] yeah, stageData looks at the list of staged_vars [18:53:59] and calls any stage_x functions that exist [18:55:07] ah ha, but i actually just have to get this into unstaged and it will get staged? [18:55:51] yeah, we gotta pull it from the reqest or session somewhere [18:56:01] what if i subclass stageData to pull it from the url if it exists? [18:56:11] (CR) AndyRussG: [C: 2] ":)" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/237458 (owner: 20after4) [18:56:11] subfunction [18:57:07] yeah, you could do that. We really need to solve the custom request vars thing [18:57:36] otherwise we just keep coupling front end to back end more and more [18:57:57] maybe in the wp gateway body class? [18:58:29] i dunno which is less bad... [19:00:22] (CR) 20after4: [C: 2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/237458 (owner: 20after4) [19:00:25] yeah it's gonna be hacky [19:01:02] when we move it to smash pig we can go, well what are all the hacks and how can they become not edge cases [19:02:23] yeah. the adapter basically needs to tell the frontend what it expects for input, then get back an associative array, maybe tagged with source (get/post/session) [19:02:34] or something [19:03:19] yep that makes sense [19:03:33] anyway, over in worldpay_gateway.body's handleRequest you can call $this-adapter->addRequestData [19:04:08] no need to write a stage_ function unless you need to transform it somehow [19:04:50] oh awesome [19:05:47] i forget about that body file, still wrapping my head around DI [19:06:39] yah, fortunately awight slimmed those all down and de-duplicated the code up in the base GatewayPage earlier this year [19:07:00] so they mostly just do tiny customizations now [19:07:12] like add the css & js modules [19:07:46] nice, seems like a not terrible place to hang this [19:08:02] (Merged) jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/237458 (owner: 20after4) [19:12:05] Fundraising Sprint Snoop (Dogg|Lion), MediaWiki-extensions-CentralNotice: Activate Banner History!!!!1one! - https://phabricator.wikimedia.org/T112020#1627364 (atgo) We made this to mark a clear point of activation for the new banner history stuff [19:27:31] fundraising-tech-ops: Give @sventura civicrm cert on her new computer - https://phabricator.wikimedia.org/T112143#1627469 (SVentura) hello @jgreen, let me know what I need to do on this new computer to get back into Civi. Thanks! [19:33:40] Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops, MediaWiki-extensions-DonationInterface: payments1004 should have the "mwscript" frontend to MW maintenance scripts - https://phabricator.wikimedia.org/T109665#1627499 (Jgreen) p:Triage>Normal [19:34:00] Fundraising-Backlog, fundraising-tech-ops: Replace ActiveMQ donation queues with Redis - https://phabricator.wikimedia.org/T108229#1627503 (Jgreen) p:Triage>Normal [20:20:59] Fundraising Sprint Snoop (Dogg|Lion), MediaWiki-extensions-CentralNotice: [Mini epic] Activate Banner History! - https://phabricator.wikimedia.org/T112020#1627793 (DStrine) [20:33:39] awight: i'm gonna step out too, back in like 30m [20:45:47] hey awight - did you look at what I made of the Giant Rabbit reports ... https://docs.google.com/spreadsheets/d/1IcTicTdKwgf62INuTEoRjHZ_5ostMLCnfl6ahn3s8u0/edit#gid=0 [20:56:27] AndyRussG: looks like RL does store modules in localStorage, and its prune feature deletes all modules where version doesnt match the current module registry. looks to be called on each load [20:57:20] ejegg|food: ahh I understand what you meant. Right, yes it does store in localStorage. I thought you meant that it had a feature for storing in LS like kvStore 8p [20:58:23] ah right, mw.loader.store seems to be specialized for modules [21:06:47] yeah [21:07:37] awight: ejegg|food: atgo: Regarding needing a global out-of-campaign TTL for kvStore items: "There's a very finite amount of space and there are a lot of players. We're already at high capacity (I'd etimate 80%) of the roughly 5M space available." [21:07:54] (TTL = time to live, i.e. expiry date) [21:13:01] ok [21:13:07] i just sent out an email that talks about a tentative plan [21:13:53] Fundraising-Backlog: Sprint V goal: - https://phabricator.wikimedia.org/T112180#1628182 (atgo) NEW [21:13:53] atgo: OK! [21:14:30] awight: you around? [21:15:16] Fundraising-Backlog: Recent iframe errors from up-to-date browsers - https://phabricator.wikimedia.org/T112181#1628194 (MBeat33) NEW [21:15:28] awight is not around.... [21:15:46] unless he's donned his invisibility cloak [21:15:50] or got a laptop [21:16:06] i think he said he was gonna get lunch [21:16:25] Fundraising-Backlog: Sprint T goal (End Q1 + code slush): - https://phabricator.wikimedia.org/T108406#1628204 (atgo) [21:16:31] word. [21:17:10] Fundraising Tech Backlog, Fundraising-Backlog: Do not log CC exp date - https://phabricator.wikimedia.org/T86234#1628211 (atgo) [21:18:21] AndyRussG: Hmm, mw.storage is pretty feature-light. Wonder if that should be extended with expiration dates? [21:20:11] cwdent: I'm still invisible, but here now [21:20:43] ghostly! [21:20:46] oh hey, jStorage does TTL! from ext.wikimediaEvents.search.js: $.jStorage.set( 'searchSessionId', 'rejected', { TTL: 2 * sessionLifetimeMs } ); [21:21:38] awight: do you wanna get on the phone when you've got a few minutes? [21:22:05] sorry, RL stuff [21:22:07] gimme two [21:22:11] np! [21:28:29] ejegg: hm! I wonder how that works? It's not only for the cookie fallback? [21:28:41] (which I think we sepcifically don't want, in the BH history case) [21:29:08] AndyRussG: right, I don't think jStorage falls back to cookies [21:29:41] it polls on a timeout, so it can even expire stuff while you're still looking at the same page [21:30:14] but it doesn't seem to be loaded on each pageview yet, so that might be more of a load than we want to add [21:30:47] that search event only runs code using jStorage on the search results page [21:30:55] and loads it conditionally [21:32:13] ejegg: I don't understand... ? [21:32:14] https://github.com/martinkr/jStorage [21:32:56] ooh, ok, i didn't read the docs, just skimmed the code in our resources/lib folder [21:33:38] what do you mean "polls on a timeout..." ^ ? [21:34:19] hmm, we seem to have a different version in our repo than the one on github [21:34:22] one sec [21:35:33] oh, our version is ancient! [21:35:35] https://github.com/wikimedia/mediawiki/blob/master/resources/lib/jquery/jquery.jStorage.js [21:35:47] 0.4.12 [21:36:15] there's a _handleTTL function that fires at intervals and deletes expired stuff [21:37:01] (PS2) AndyRussG: Subscribing JS: remove proxy methods on cn object [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237418 [21:39:54] Hmmmmmmm [21:40:05] ejegg: but that's not what RL module uses for its stuff, is it? [21:40:39] nope, RL just goes by module version [21:41:57] https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki/mediawiki.js#L2219 [21:44:51] ejegg: hmm... Yeah I think we're just gonna go it alone here too [21:46:28] yeah. outdated version in lib + newest version not supporting expiry, and also not touched for 2 yrs = bring the wheel design in-house [21:48:31] awight: has the lurgh left the house? [21:49:07] eileen: aahhhem [21:49:09] what! [21:49:56] Hi, I'll have to run in ten minutes, but then back for the rest of my day [21:50:14] Can I help with anything? [21:50:45] (PS3) AndyRussG: Subscribing JS: remove proxy methods on cn object [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237418 [21:51:25] awight: I just wanted to check if you had any input on my take on the GR Report work (https://docs.google.com/spreadsheets/d/1IcTicTdKwgf62INuTEoRjHZ_5ostMLCnfl6ahn3s8u0/edit#gid=0 ) [21:54:23] k, looking now [21:54:30] o wow [21:56:50] brb [22:14:01] cwdent: hi! back from the dead [22:14:23] wb! [22:14:27] wan chat? [22:14:33] totally [22:14:49] cool just call me whenever you're ready [22:24:01] Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops, Technical-Debt: Move all fundraising component config into Puppet - https://phabricator.wikimedia.org/T110224#1628602 (atgo) @awight is this blocking for PCI? [22:28:41] Fundraising-Backlog: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1628623 (atgo) [22:29:11] Fundraising-Backlog: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1572762 (atgo) [22:29:47] Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops, Technical-Debt: Move all fundraising component config into Puppet - https://phabricator.wikimedia.org/T110224#1628630 (awight) @atgo: Nope! This is so devs can deploy configuration in a sane way, and we get version control audit... [22:42:40] (PS4) Ejegg: WIP New Amazon payment listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/237313 (https://phabricator.wikimedia.org/T109649) [22:44:21] (PS1) AndyRussG: WIP KVStore TTL [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237526 (https://phabricator.wikimedia.org/T111385) [22:44:40] ejegg: awight: cwdent: ^ WIP patch for kvstore TTL [22:44:50] Gotta run to parent-teacher meeting!!!!!! cya later :) [22:44:52] nice, I'll take a look! [22:45:17] ejegg: thanks much! It's WIP and is not quite doing what it should, but you can at least see the general idea! :D [22:45:37] (CR) jenkins-bot: [V: -1] WIP KVStore TTL [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237526 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG) [22:46:41] oops, commit might be missing a js file [22:51:41] gonna relocate, back in a bit [22:57:34] Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops, Technical-Debt: Move all fundraising component config into Puppet - https://phabricator.wikimedia.org/T110224#1628803 (K4-713) Will a single person still be able to do things like quickly disable components on the payments cluste... [23:03:05] ejegg|bike: ohyeah [23:03:24] (PS2) AndyRussG: WIP KVStore TTL [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237526 (https://phabricator.wikimedia.org/T111385) [23:03:30] cya! [23:04:43] (CR) jenkins-bot: [V: -1] WIP KVStore TTL [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237526 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG) [23:16:19] eileen: Just sent you a link to the original feature specs [23:19:53] awight - cool - I'll read through them [23:23:20] eileen: Our plan has been to deploy the GR reporting patch and start using it, before doing another iteration and attempting to upstream. [23:23:40] Just mentioning cos I see you're taking more of an upstreamy approach [23:23:53] awight: OK - the tricky thing is the schema change in there [23:23:59] because that will be hard to manage [23:24:14] What are your current thoughts about 4.4 vs 4.6, and how we can get the GR reporting merged in? [23:24:53] Could we move the schema change into a new table for now, and treat this as a pseudo-extension? [23:25:24] yeah - the whole private reports feature could be an extension rather than core... [23:25:49] ie. that is one of the features in there [23:26:06] Does it look easy to port to an extension? I was under the impression that these changes were tightly coupled to core stuff that isn't made to be extended [23:26:45] maybe that part of it [23:27:00] but I will talk to core a bit more on it [23:27:15] (10 mins someone at the door) [23:27:40] k [23:35:58] Fundraising Sprint Snoop (Dogg|Lion): Associate banner history ID with contribution ID - https://phabricator.wikimedia.org/T112022#1629019 (awight) [23:36:16] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog: Associate banner history ID with contribution ID - https://phabricator.wikimedia.org/T112022#1622923 (awight) [23:40:58] awight: sorry about that [23:41:12] looking at the spec I think only phase 1 is completed? [23:41:26] yep. I think we realized that phase 2 should be a cron job. [23:42:45] so the last of the 4 features - I was leaning towards a quick upstream on that one "Feature: Save and Save a Copy options on each Report Criteria and Report Results page" [23:43:04] Seems like a stand-alone feature that can easily be a patch on wmf & in 4.7 [23:43:30] sorry the feature was this one Feature: Actions Menu on the Report Listing page and on each Report Criteria and Report Results page [23:43:54] But to back up a step--we're still talking about targeting 4.6 for the WMF upgrade, right? [23:44:11] Therefore the GR patch has to be ported one way or another [23:44:43] awight: yeah - I would expect to extract that specific feature into one patch against 4.6 & also submit it to 4.7 [23:44:50] I think it's great to upstream the low-hanging fruit, that makes everything simpler going forward. [23:44:53] cool [23:45:15] The other low-hanging is the report menu restructure [23:45:46] The part I want to repeat just cos this is IRC, is that we might not like how this patch changes things. We were hoping to try it out before upstreaming some of these features. [23:46:00] OK [23:46:33] The report menu infrastructure is already hierarchical in core 4.6, right? [23:46:39] not really [23:46:44] ah, ok [23:46:59] but, the patch actually doesn't change anything - unless you click a button [23:47:03] or call an api [23:47:12] We should get atgo__ involved in prioritizing here, but I think the most important change is simply taking off the reset=1 param... [23:47:21] yes? hi what? [23:47:27] * atgo__ reads backscroll [23:47:49] "save a copy" is already upstreamed--that would be my personal next against the wall [23:48:08] then would be the "My Reports" thing, but I don't know how much we care about that. atgo ? [23:48:24] ah man. i need to re-familiarize myself with all of this for sure [23:48:32] awight: send me the link you sent eileen? [23:48:41] atgo: https://docs.google.com/document/d/11vGGaDovjaRlurWHcZeuQpe7VzdqoJqIAh6Xpek6KPI/edit# [23:48:55] eileen awight the thinking was to get all of this on our instance before upstreaming so that we could shake out bugs and possibly tweak a bit before upstreaming [23:49:10] totally. I was stuttering that just a minute ago [23:49:15] i'm open to whatever you guys think is the right approach (and from the Product Owner standpoint would love to get it to _our_ users ASAP) [23:49:22] this was giant rabbit's suggestion [23:49:24] yeah - I'll try to port & split to patches [23:49:35] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog: Associate banner history ID with contribution ID - https://phabricator.wikimedia.org/T112022#1629038 (Ejegg) Do we need to tie a specific banner history to a specific contribution? The original plan was a standalone table that just got an entry f... [23:49:48] atgo: What do you think about the urgency of "My reports"? [23:49:48] but... if it makes more sense to upstream sooner because of we could make that work [23:49:58] I would normally pursue the upstreaming in paralell - although not necessarily integrate it immediately [23:50:11] I will gladly take your advice on that [23:50:22] eileen: that's why you're the expert :) [23:50:35] i think this one is probably the most important: https://docs.google.com/document/d/11vGGaDovjaRlurWHcZeuQpe7VzdqoJqIAh6Xpek6KPI/edit#heading=h.oq53o59hntrt [23:50:56] "my reports" also important, but getting to a place that they could adjust criteria before running the (long) report would be really rad [23:51:00] ie. upstreaming involves several steps: liaising, agreeing changes for core, putting in JIRA, providing a patch - so good to keep those things happening at the same time [23:51:23] eileen: i think awight and i are saying the same thing, which is that we 100% trust your instincts on that part [23:51:37] atgo: Absolutely agree that the performance thing of not running the report every time is #1. [23:51:49] eileen says that all we have to do is take off the "&reset=1" part of the URL. [23:51:52] * awight flips a table [23:52:00] One thing I don't get with the report thing is that when I tried it out on 4.6 what I found was that reset=1 wasn't forcing [23:52:02] oh man, really? [23:52:04] hrm [23:52:28] yeah - that was my first testing experience - I'd want to be more sure about that - [23:53:00] eileen awight i'm adding some numbers to what i see as priority for implementation on our instance [23:53:02] to the doc [23:53:02] eileen: I left a comment, but probably ejegg would also like to know: can you point us to docs about "reset" and "force"? [23:53:09] It really seems backwards to me... [23:53:17] atgo: great, thank you! [23:53:44] hmm - I just tried on dmaster demo ... http://dmaster.demo.civicrm.org/civicrm/report/instance/26?reset=1 & I did get results - so .... I might have to take that back [23:54:59] eileen awight - added some numbers for prioritization (1-5)... i think that makes the most sense, though it's been ages since i've looked at this so if it seems crazy happy to discuss [23:55:35] where did you add the numbers? [23:55:36] atgo: That matches my gut reactions [23:55:42] eileen: in the table of contents [23:55:51] I see now! [23:56:14] i've got 2 questions out to WP, should be close to internal test once these get resolved. i'm going to sign off for a bit but i'll check in later [23:56:45] cwdent|afk: you'll need some r+r after this one... [23:56:49] the my-Reports one is the only one that has a schema change - so that's the tricky one [23:58:22] ie the rest can just run as patches on top of the core version & be dropped as they go into core (need some discussion on that at some point - I like creating a branch for each point release & rebasing over master each time & keeping all patches fresh & trimmed rather than merging) [23:58:47] That sounds perfect, let's backburner my reports until the upgrade is stabilized, IMO [23:59:08] It's lower priority, and has potential to break things before we get a working baseline [23:59:16] awight: OK - so I have a version of 4.6 with your patches on it [23:59:23] * awight blinks again [23:59:32] ok... um what do we owe you :D [23:59:35] woohoo, for reals?