[00:00:10] I can't guarantee they are all good though - https://github.com/fuzionnz/civicrm-core/commits/4.6.9-wmf [00:00:27] Let's drop that on the staging server ASAP [00:00:31] sweet! Let's get that up in staging [00:00:34] heh, jinx [00:00:37] 1..10 [00:00:45] So, it's based on the CiviCRM repo structure [00:00:52] excellent [00:00:54] dying to see what the migration looks like [00:01:06] I can generate a tarball off it - if that's the easiest way [00:01:12] that means civibuild should do all the right stuff, correct? [00:01:27] eileen: Do you have our entire Drupal directory? wikimedia/fundraising/crm repo [00:01:36] civicrm is a submodule of that. [00:01:40] no - that is just the civicrm dir [00:01:55] cwdent|afk: you rock. [00:01:58] The additional repos will need to be mirrored in Gerrit, unfortunately. [00:01:58] & there is a difficulty with your repo [00:02:16] ie. your repo started not-based-on civicrm-core I believe? [00:02:37] 3 cheers for eileen [00:02:53] not so fast - some of those ports might be completely borked! [00:02:54] Sorry, I'm sort of jumping the gun here. We should settle the prognosis for our customizations first... [00:02:55] so the only missing piece will be the "my reports" feature? [00:02:56] eileen: yep, it's been tarballs all the way [00:02:57] yep [00:03:22] OK - so, civicrm obviously moved to git since 4.2 [00:03:49] & they adopted a structure where you basically need a handful of repos & then there is a process to create distribution tarballs [00:03:51] How do you recommend we deal with the compilation steps? [00:04:06] It would be a bit annoying to have a source and a compiled repo [00:04:12] well - I can easily do a tarball because we have it set up on Fuzion [00:04:21] are they all submodules of one big repo? [00:04:24] that sounds perfect [00:04:33] but, in terms of ongoing patching it's easier to work with the one based on civicrm-core [00:04:37] and could we assemble Voltron with symlinks? [00:04:48] but I guess we can do that & then package into a tarball & commit that? [00:04:53] sorry, US-based 80s reference [00:04:57] :) [00:05:25] ok - well - why don't I make a tarball now & paste the link in - give me 10 [00:05:44] does the source need to be transformed a lot, or is it just a matter of putting all the code in the right places? [00:06:54] basically the separate packages & drupal repos are added in, the DAO files are compiled, some files are added in, some removed (randomly) & composer & bower_install run [00:07:08] all of which civibuild can do I expect. [00:07:20] sorry - no I expect, it can [00:07:32] ahh, gotcha [00:08:08] Is it a bad idea / impossible to have the source and compiled versions in the same repo on different branches? [00:08:28] I haven't kept up to date on the best practices there [00:08:34] heh, I'll just let awight say all the things we're both thinking [00:08:41] It's funny, don't worry [00:08:55] yeah - we've kind of struggled to find a best way of working with the CiviCRM repo structure [00:09:13] It would be nice if compiled things went into an isolated directory. Sigh [00:09:27] This is something I thought we figured out in the '90s! [00:09:43] different branches is probably OK - the thing is you really want the uncomplied version to be based on core repo - not pre-git-civi-history [00:09:53] The 'compiled' branch idea is because our deploy process is basically checking a branch out of git and pushing it to the target machines... [00:10:25] yeah, I agree we definitely want to follow core commits! [00:11:11] yeah - & I think a deployed branch would probably work fine [00:11:48] heh, definitely gonna want scripts to merge to deploy-src, run civibuild, commit to compiled, /then/ update the submodule pointer in crm [00:12:17] sorry, getting into the weeds of our processes here [00:12:25] this is huge news! [00:12:53] The big thing we're missing is... our staging box isn't actually integrated with all the subsystems. That's the part that really needs hammering upon. [00:13:19] https://etherpad.wikimedia.org/p/Civi_4.6_staging_deployment [00:13:22] yeah, that 'complete testing copy of everything' dream [00:17:30] ok, gotta run, but I'll be excited to check out the 4.6.WMF version tomorrow! [00:17:47] eileen: If you'd like, I'm putting some notes into that etherpad ^ [00:17:52] ejegg: bye! [00:20:20] Nothing too exciting, now that I'm writing it down. [00:20:39] awight: I don't know if you saw it but I put ongoing notes into the readme in the patches folder in the civicrm repo [00:20:49] OK sure! [00:21:16] I can just turn my notes into a Phabricator task, too, I'm just trying to imagine what the next steps are. [00:21:21] the obvious things that I think will need re-visiting are the exception stuff & some of the db extra reporting [00:21:43] because there was significant code change [00:21:51] I owe you some explanation of what we were trying to do there... [00:22:01] I basically did a first cull, broke things into separate patches & applied them [00:22:37] Ok - here is a link to a tarball - https://dist.fudev.co.nz/by-date/latest/4.6.9-wmf/ [00:23:06] (I used buildkit to generate that - the distmaker script) [00:24:28] I have some suspicions that there will be some performance issues around 1) smart groups - 2) autocomplete [00:24:47] history on #1 - autocomplete before 4.5 uses quicksearch, after it uses getlist [00:24:57] I fixed quicksearch recently [00:25:43] just commented about that. [00:25:47] but, getlist still needs to be looked at - it has the same problem that advanced search does when you choose to search by name - & that quicksearch used to have [00:25:47] (CR) Awight: Annotate CiviCRM patches (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/235359 (https://phabricator.wikimedia.org/T99836) (owner: Eileen) [00:27:20] eileen: Can you get to our prod + staging Civis yet? [00:27:43] I suppose that can wait. [00:28:01] But if you have access, I invite you to play with the name + email search settings on staging [00:29:27] We can just wait until staging is running 4.6, then see what issues remain. [00:30:51] awight: yeah - I think it makes sense to tackle that in core & put some head space into it [00:31:29] because it has to be possible to make that query work [00:32:07] I can't get to prod / staging until my power cord arrives - because the laptop only has a US charger :-) [00:32:57] It's possible that the tarball ( https://dist.fudev.co.nz/by-date/latest/4.6.9-wmf/ ) has a fundamental fatal error in it of course! [00:41:15] awight: so I guess I'd like to know if the tarball actually works & whether the DB will upgrade onto it - how do we test that? [00:51:48] eileen: Hey, sorry RL conversation. [00:52:32] what's RL stand for? [00:52:40] really-long? [00:53:33] Testing the tarball will be a little be involved. We'll have to get Jeff_Green (ops) involved, and create a new site on the staging box that either runs from a directory or from a git checkout of your repo. Then clone the db and try to migrate it. [00:53:37] RL=real life [00:53:50] we do that so infrequently it probably doesn't need an abbreviation ;) [00:53:50] ah [00:54:03] :-) [00:55:20] Fundraising Sprint Rowlf the Dog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, Technical-Debt: Error provisioning drupal_db_install - https://phabricator.wikimedia.org/T110371#1629224 (awight) [00:55:30] Fundraising Sprint Rowlf the Dog, Fundraising Tech Backlog, Fundraising-Backlog, Unplanned-Sprint-Work: Specify STOMP server port in config files - https://phabricator.wikimedia.org/T109911#1629226 (awight) [00:56:05] Fundraising Sprint Rowlf the Dog, Fundraising Tech Backlog, Beta-Cluster, MediaWiki-extensions-CentralNotice: Create meta.m.wikimedia.beta.wmflabs.org - https://phabricator.wikimedia.org/T110273#1629227 (awight) [00:56:28] Fundraising Sprint Rowlf the Dog, Fundraising Tech Backlog, Fundraising-Backlog, Unplanned-Sprint-Work: Recurring job dies on simple errors - https://phabricator.wikimedia.org/T111108#1629229 (awight) [00:56:55] awight: perhaps I should run up the tarball on some thing else first to get a quick test - since there could be a fatal flaw [00:57:06] That sounds sane. [00:57:21] but, I guess also, need to kick off the process if it won't happen straight away [00:58:15] I think I'll make a Phabricator task for putting 4.6-wmf on staging, so we have a place to discuss and hilight blocking tasks [01:02:04] Fundraising Sprint Snoop (Dogg|Lion), Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Deploy CiviCRM 4.6-wmf to staging - https://phabricator.wikimedia.org/T112221#1629256 (awight) NEW [01:13:37] eileen: I'm gonna leave soon, can I help with anything? [01:19:38] oh - I awight no that's all good [01:19:53] talk to you next week [01:20:06] Okay, thanks again! [01:20:44] yeah - will be interesting to see if the upgrade works - I'll test it somewhere else now though & update phab with whether it worked [01:21:06] I bet it will--I had no problems running the 4.4 upgrade on our db a few months ago [01:21:14] Our data's pretty simple, there's just a lot of it. [01:21:36] ok cool - 4.4 is more challenging than 4.6 because of the activity contact restructure [01:21:53] Ah. hmm, I think we started using that a bit in the meantime [01:22:18] I'm also worried about the triggers thing, lemme see what we've discussed so far... [01:22:55] that doesn't look right [01:23:51] (CR) Awight: Annotate CiviCRM patches (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/235359 (https://phabricator.wikimedia.org/T99836) (owner: Eileen) [01:30:25] awight: One last thing - I'd like to find out if dropping FKs on the cache tables stops them from being slow to truncate - do I log a phabricator ticket for that? [01:30:56] Sure! We should probably get heads together about how you want to organize your work... [01:31:38] IMO, you can do anything that's convenient, but it makes sense to create Phabricator tasks when you want to get other people's attention [01:31:58] This would be a good one for someone else to take on [01:34:49] Not my most helpful response ;) [01:34:55] ok gotta run! [02:59:12] (PS5) Cdentinger: WIP worldpay ESOP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234691 [03:00:06] (CR) jenkins-bot: [V: -1] WIP worldpay ESOP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234691 (owner: Cdentinger) [13:14:12] TCB-Team-Fundraising-Sprint-2015-09-10, Phragile, TCB-Team, Phragile-1.1-release: [Phragile] Display hint/warning when creating a new Phragile sprint for an existing Phabricator project - https://phabricator.wikimedia.org/T110896#1630339 (Tobi_WMDE_SW) [14:52:30] (CR) Cdentinger: WIP worldpay ESOP (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234691 (owner: Cdentinger) [14:58:53] TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team: [WMDE-Fundraising] Implement validator class for donations - https://phabricator.wikimedia.org/T112076#1630617 (WMDE-leszek) Pull request on Github: https://github.com/wmde/fundraising/pull/599 [14:59:00] TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team: [WMDE-Fundraising] Implement validator class for donations - https://phabricator.wikimedia.org/T112076#1630618 (WMDE-leszek) a:WMDE-leszek [15:11:36] morning ejegg [15:11:48] hi cwdent [15:11:53] how's it going? [15:12:02] pretty good, you? [15:12:05] happy friday [15:12:14] woot [15:13:50] i got a WP payment all the way through the test workflow to the thanks page (which doesn't exist :P) [15:15:48] oh hell yeah! [15:16:56] heh, right, I think we should include some kind of Special:ThankYou and Special:DonationFailed to use as defaults when there's no wiki content [15:17:48] yeah that sounds reasonable [15:17:50] but no big deal [15:17:58] so the stuff i have on my to do list: [15:18:18] iframe liberator, activemq setup [15:18:31] write some markup to make it look like something [15:18:39] cool, cool [15:18:49] also all the card types are blank in the radio button matrix? [15:18:58] i think there are supposed to be images in there [15:19:18] ah, you might need to add 'logo' keys to the payment_submethods [15:19:27] take a look at astropay's submethods [15:19:46] am i correct thinking the iframe liberator is to make the final post show up as the whole page? [15:19:48] the thank you page [15:19:53] yeah, exactly [15:30:03] ejegg: is there a live processor i can play with to see what the iframe workflow is supposed to look like? [15:34:28] cwdent: I think globalcollect does the same thing [15:35:49] oh nice yeah, pretty close to what i've got actually, except the slidedown effect [15:36:18] cool - easy with jQuery, or might even be using css3 [15:52:56] ejegg: i wonder if we even need the card type radio buttons? this is in the iframe: http://i.imgur.com/VHJBxwo.png [15:53:35] Fundraising Tech Backlog, operations: Document FR-Tech hosts on wikitech - https://phabricator.wikimedia.org/T112278#1630820 (greg) NEW a:Jgreen [15:53:50] Oh, guess that's not totally necessary then! [15:54:04] we could just use the 'continue' button to show the frame [15:54:29] though we do like to record which card type they use for some reason [15:56:33] yeah, makes sense, i don't think i am even sending that right now [15:56:57] (PS3) AndyRussG: WIP KVStore TTL [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237526 (https://phabricator.wikimedia.org/T111385) [15:57:04] I think fr-not-tech likes to know which are popular so they know what to ask processors for [15:57:35] but of course there'd be no guarantee the donor actually uses the same card as they clicked [15:57:48] that makes sense. i wonder if we can get that info from WP somehow [15:58:08] (CR) jenkins-bot: [V: -1] WIP KVStore TTL [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237526 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG) [15:58:08] oh yeah, i think you actually do! [15:59:32] so sure, let's just use the continue button [16:00:07] yeah, i see an unstage_payment_submethod that seems to translate back from WP's codes to our own [16:00:23] oh nice [16:00:26] cool, no need to mess with any more logos [16:00:51] hooray [16:01:19] so i'll want to make the payment method include optional in the mustache index? [16:01:40] ah, yeah [16:02:13] whichever way you choose to do that, I'll adopt for amazon instead of polluting the template with an is_amazon switch like i'm doing now [16:02:53] i wonder what the most appropriate place for that would be? the adapter? seems more like display logic [16:04:03] :) [16:04:20] * K4-713 wanders off again [16:05:20] cwdent: My thought is that the adapter states what input it needs, maybe in payment_method metadata [16:05:48] and the frontent logic decides how to get that from the user / session / whatever [16:06:20] sure that sounds good [16:06:35] i feel like i'm going to break the old WP in several ways here [16:06:40] but it may be broken already [16:06:51] Oh? What else are you changing? [16:07:19] Also, yeah, I wouldn't be suprised if something we've done while it's been deactivated screwed it up [16:07:32] well all the code is here https://gerrit.wikimedia.org/r/#/c/234691/ [16:07:42] i mostly cased it using ffname [16:08:21] one thing i know of is it gets both stylesheets right now, the old WP page [16:08:34] because of how they're loaded in the body file [16:09:03] ah well. [16:09:26] rather i think that's a side effect of using the mustache templates in something that already has rapidhtml [16:09:35] we abstracted the mustache js out but not the css [16:09:41] maybe wrap that ffname test in a public isEsop function so it's easy to check from everywhere including body? [16:09:59] ejegg: yeah good idea [16:10:07] this has been very...organic so far [16:10:39] hehe, seems to have been the case in DI for a while [16:10:53] ants love organic environs [16:11:01] hehe [16:12:34] (PS5) Ejegg: PayWithAmazon IPN listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/237313 (https://phabricator.wikimedia.org/T109649) [16:12:35] i think the problems with the code reflect the general problems pretty well though, and lay out a pretty good map for a refactor [16:12:56] like, just gotta pull all this stuff from the edges into the middle [16:13:25] yep, just as soon as we get a couple months of not having to add new stuff [16:13:52] might be awhile :) [16:14:25] * cwdent goes back to adding terrible things [16:24:44] ejegg: by the time handleRequest runs in the body file, the adapter has already loaded up its unstaged data right? [16:25:24] yeah [16:25:33] it should load up most of that right in the constructor [16:26:10] nice [16:26:30] ah yeah i just cracked open DonationData for the first time last night [16:27:02] Fundraising Tech Backlog, operations: Document FR-Tech hosts on wikitech - https://phabricator.wikimedia.org/T112278#1630972 (greg) [16:45:54] (PS6) Cdentinger: WIP worldpay ESOP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234691 [16:46:33] ejegg: https://gerrit.wikimedia.org/r/#/c/234691/6/gateway_forms/mustache/payment_method.html.mustache [16:46:36] (CR) jenkins-bot: [V: -1] WIP worldpay ESOP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234691 (owner: Cdentinger) [16:46:57] then added it to requiredfields in the adapter...how does that look? [16:53:57] sure, maybe say payment_submethod instead? [16:54:08] cwdent: ^ [16:54:49] (PS7) Cdentinger: WIP worldpay ESOP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234691 [16:55:01] good call [16:55:33] (CR) jenkins-bot: [V: -1] WIP worldpay ESOP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234691 (owner: Cdentinger) [16:57:55] (PS8) Cdentinger: WIP worldpay ESOP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234691 [17:12:25] Fundraising Tech Backlog, operations: Document FR-Tech hosts on wikitech - https://phabricator.wikimedia.org/T112278#1631305 (Jgreen) Open>Resolved Fundraising system/service documentation is on collab wiki because some of it is sensitive. I added a table with host information here: https://collab.w... [17:14:23] ES6 is stable in node now and my friend is building out these api tools: https://github.com/adafruit/io-client-node/blob/unify/server/lib/models/Base.js#L58 [17:14:27] it doesn't even look like js [17:19:44] wow [17:45:13] Fundraising Tech Backlog, operations: Document FR-Tech hosts on wikitech - https://phabricator.wikimedia.org/T112278#1631493 (greg) On that page I linked. [17:46:17] awight: laptop all good? [17:46:30] * AndyRussG checks mail [17:47:15] Sort of, as long as I type really gently :) [17:47:24] hey, Pats just send a paypal email to us. should we be concerned? [17:48:21] dstrine: It's Sept 30, but lemme take a longer look [17:49:54] aaarg debounce is not a function! but it isssssssss [17:50:20] no kids or roosters allowed near the laptop then? [17:51:41] ^ another unexpected error on the CN admin interface that seem to happen intermittently :( [17:52:38] well, that is, if once = "intermittently" [17:54:23] "however, we may need to change this date on short notice to you to align to the industry security standard." thanks paypal [17:55:27] dstrine: OK, kicked that can to Jeff_Green :) [17:55:56] AndyRussG: looks like it's a separate module? [17:56:16] atgo: ino, classy [17:56:31] it's in jquery, but somehow indicative of a javascript death somewhere along the line [17:56:40] Usually works sehr OK [17:57:40] I don't think it's in jquery proper [17:57:52] perhaps "jquery.throttle-debounce" ? [17:58:31] Yeah, looking at mw-core/resources/Resources.php, you have to explicitly depend on that module [17:58:41] silly race conditions [17:58:57] Gonna be a minute late to meeting [17:59:00] awight: oh! damn nice, thanks [18:00:17] fundraising-tech-ops, Traffic, operations, IPv6, Patch-For-Review: Enable IPv6 on donate.wikimedia.org - https://phabricator.wikimedia.org/T73267#1631563 (Jgreen) > Assigning an IP and adding it to our GeoDNS is trivial, so at this point the only blocker is for fr-tech to lift their objection. @... [18:02:02] anyone down to talk about Q2? [18:02:18] Heh, lost track of time. Joining. [18:03:23] Fundraising-Backlog, Editing-Analysis, WMF-Product-Strategy: Investigate using Optimizely for UI A/B testing - https://phabricator.wikimedia.org/T76917#1631584 (awight) [18:03:25] awight: you available for a chat? [18:13:16] Fundraising-Backlog, Epic: [epic] Update how we do the List-Unsubscribe email header - https://phabricator.wikimedia.org/T91476#1631640 (atgo) Hey @ccogdill_wmf we're looking at what's coming up for the next few sprints/that we can accomplish in advance of Big EN. This one's on the edge of what we may be... [18:13:40] Fundraising-Backlog, Epic: [epic] Update how we do the List-Unsubscribe email header - https://phabricator.wikimedia.org/T91476#1631644 (atgo) Also do you have a sense from the industry if this is coming up for us? [18:13:57] Fundraising-Backlog, Epic: [epic] Update how we do the List-Unsubscribe email header - https://phabricator.wikimedia.org/T91476#1631645 (awight) We're taking the unsub link out of the thank-you letter, so this isn't affected by code freeze. What are the bulk emails currently using for unsubscribe? Aren'... [18:15:18] fundraising-tech-ops, Traffic, operations, IPv6, Patch-For-Review: Enable IPv6 on donate.wikimedia.org - https://phabricator.wikimedia.org/T73267#1631660 (BBlack) @Jgreen - Is the payment geography something custom in FR's software, or is it our standard GeoIP cookie stuff we use on the main sites? [18:16:20] Fundraising-Backlog, Epic: [epic] Update how we do the List-Unsubscribe email header - https://phabricator.wikimedia.org/T91476#1631670 (CCogdill_WMF) @atgo @awight yeah, I didn't think of that! I think we can probably decline this task with the removal of the TY letter unsubscribe. [18:19:10] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Install 4.4 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1631690 (awight) [18:19:10] Fundraising Sprint Snoop (Dogg|Lion), Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Deploy CiviCRM 4.6-wmf to staging - https://phabricator.wikimedia.org/T112221#1631689 (awight) [18:19:37] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Install 4.6 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1631691 (awight) [18:20:01] fundraising-tech-ops, Traffic, operations, IPv6, Patch-For-Review: Enable IPv6 on donate.wikimedia.org - https://phabricator.wikimedia.org/T73267#1631695 (Jgreen) It's the standard stuff. [18:24:42] assaaS: assholes as a service [18:24:57] Fundraising-Backlog, Astropay Integration: [epic] Processing via Astropay for Spanish-speaking LATAM countries - https://phabricator.wikimedia.org/T102143#1631713 (atgo) p:High>Normal [18:34:05] Fundraising Tech Backlog, Fundraising-Backlog: contribution_source triggers seem to be failing - https://phabricator.wikimedia.org/T98643#1631763 (atgo) p:Triage>High [18:36:48] Fundraising-Backlog: Dedupe data in Silverpop file - https://phabricator.wikimedia.org/T107045#1631773 (atgo) hey @ccogdill_wmf - this is looking like best case to happen in November based on other work. Thoughts? [18:41:48] Fundraising-Backlog: Dedupe data in Silverpop file - https://phabricator.wikimedia.org/T107045#1631780 (CCogdill_WMF) @atgo October would be best because we're planning on sending the bulk of email in November this year. However, we're not actually sure if that will just be email 1, or emails 2 and 3 as well... [18:42:01] Fundraising-Backlog: donatewiki access for Trilogy - https://phabricator.wikimedia.org/T110038#1631784 (awight) @Pcoombe: Why donatewiki? Is this for LP1 or banners? We're not inclined to give donatewiki access, so let's keep discussing. Images in banners should be uploaded to commons, right? [18:42:44] Fundraising-Backlog: Record if a donation amount was chosen from one of the fixed amounts - https://phabricator.wikimedia.org/T92462#1631795 (awight) [18:43:09] fundraising-tech-ops, Traffic, operations, IPv6, Patch-For-Review: Enable IPv6 on donate.wikimedia.org - https://phabricator.wikimedia.org/T73267#1631798 (BBlack) >>! In T73267#1631563, @Jgreen wrote: >> Assigning an IP and adding it to our GeoDNS is trivial, so at this point the only blocker is... [18:43:18] Fundraising-Backlog: Record if a donation amount was chosen from one of the fixed amounts - https://phabricator.wikimedia.org/T92462#1111585 (awight) Isn't this already in contribution_tracking.form_amount? [18:46:40] fundraising-tech-ops, Traffic, operations, IPv6, Patch-For-Review: Enable IPv6 on donate.wikimedia.org - https://phabricator.wikimedia.org/T73267#1631812 (CCogdill_WMF) @BBlack thanks for the heads up, I think that's fine if fr-tech is OK with it. @MBeat33 should be in the loop since he manages... [18:50:51] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-ContributionTracking: SPIKE: Check status of ContributionTracking code on donate wiki landing page - https://phabricator.wikimedia.org/T108741#1631838 (awight) [18:50:53] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog: Associate banner history ID with contribution ID - https://phabricator.wikimedia.org/T112022#1631837 (awight) [18:51:28] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice RFC for methodology for scoping medium- and long-term requirements and making a roadmap - https://phabricator.wikimedia.org/T108747#1631839 (DStrine) [19:06:33] Wikimedia-Fundraising-CiviCRM: Deploy CiviCRM 4.6-wmf to staging - https://phabricator.wikimedia.org/T112221#1631873 (awight) [19:07:35] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Install 4.6 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1631884 (awight) [19:10:15] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Configure new CiviCRM staging instance for testing 4.6 upgrade - https://phabricator.wikimedia.org/T112314#1631890 (awight) NEW [19:10:25] Jeff_Green: I made this for you ^ [19:11:06] awight: ok [19:11:07] I'm not marking this stuff high priority at this point, but for context, we're pushing to do the Civi upgrade ahead of Big English. [19:11:17] right [19:11:23] shouldn't be a big deal, we can do it next week [19:12:04] Thanks! Failing to accomplish the upgrade is certainly an option, it won't blow anything. There's a lot of smoke testing to do before we can throw the switch... [19:12:19] XenoRyet: is now good, or later better? [19:13:35] awight: After standup would be better. I want to hammer on a thing first so we have something to talk about. [19:13:40] sure! [19:41:33] awight: I think my problem heard you were coming. It just sorted itself out. [19:41:42] ha! [19:42:03] Yea, no real idea what went differently this time, but it seems to have updated what I needed updated. [19:42:12] fundraising-tech-ops, Traffic, operations, IPv6, Patch-For-Review: Enable IPv6 on donate.wikimedia.org - https://phabricator.wikimedia.org/T73267#1632059 (BBlack) We can also just wait to do this until after you're done with that email. [19:42:19] It's pretty amazing how that works, things just leap into place when someone walks by with a hammer [19:42:26] Right? [19:42:40] OKOK i'll be in place, just don't use that thing! [19:43:04] um, still wanna talk just to figure out overview things or any other pain points? [19:43:37] Let me poke around a little more, but yea, maybe. [19:43:45] cool [19:43:47] fundraising-tech-ops, Traffic, operations, IPv6, Patch-For-Review: Enable IPv6 on donate.wikimedia.org - https://phabricator.wikimedia.org/T73267#1632072 (CCogdill_WMF) @BBlack emails are most productive in their first 24 hours, so I wouldn't mind waiting until Tuesday, 9/15 if that works for you. [19:44:01] Sort of a painful day, with meetings an hour apart [19:44:14] Yea, hard to get in the zone. [19:44:35] * awight gazes hopefully at some leftovers [19:45:12] Got bureaucratic stuff too, trying to figure out if I can/should come to the dev summit part of all hands. Heard the rest of you guys are going to be there. [19:46:01] (CR) Awight: Support help text for mixin parameters (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236422 (owner: Awight) [19:47:18] I haven't actually attended a "dev summit" yet, there was an invitation-only thing a couple of years ago which sort of permanently turned me off [19:48:17] now it's just the pretentious, hierarchicy-oriented name that bugs me, but I should look past that... [19:48:57] Yea, that is a pretty pretentious thing to call it, but I was trying not to pay attention either. [19:48:58] Visit for the extra time, keeping the option open to do something more interesting :) [19:49:52] That's what I was leaning towards. If the whole team is in SF, seems good to be there. Balancing that against leaving Mom home alone for a whole week with the 1 year old though. [19:52:14] Heh, anyway yea, looks like everything works now, and this patch is probably ready for review. Thanks for scaring off my bug. [19:52:19] Fundraising-Backlog: Dedupe data in Silverpop file - https://phabricator.wikimedia.org/T107045#1632113 (atgo) Thanks! We'll leave it in Q2 for now and get to it ASAP. [19:54:01] fundraising-tech-ops, Traffic, operations, IPv6, Patch-For-Review: Enable IPv6 on donate.wikimedia.org - https://phabricator.wikimedia.org/T73267#1632124 (BBlack) Ok sounds good. [19:57:17] XenoRyet: that's awesome, we should do this more often ;) [19:57:26] Totally [20:01:28] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Mustache forms should provide server-side error map to client-side script - https://phabricator.wikimedia.org/T112323#1632173 (Ejegg) NEW [20:03:53] cwdent: you might want to track ejegg's work there ^ [20:04:00] (PS4) AndyRussG: KVStore: itmes have limited TTL [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237526 (https://phabricator.wikimedia.org/T111385) [20:04:31] awight: will do [20:04:49] (PS3) Awight: Support help text for mixin parameters [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236422 [20:04:51] (PS5) Awight: WIP Banner diet mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 [20:05:15] (CR) jenkins-bot: [V: -1] KVStore: itmes have limited TTL [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237526 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG) [20:05:32] XenoRyet: we are standing up if you're available [20:05:46] BRT, forgot to look at the clock again [20:06:03] (CR) jenkins-bot: [V: -1] WIP Banner diet mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (owner: Awight) [20:12:37] (PS5) AndyRussG: KVStore: itmes have limited TTL [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237526 (https://phabricator.wikimedia.org/T111385) [20:36:48] * awight 's gonna go to the car parts store... again. [20:36:59] nick awight|away [20:41:48] (PS12) Ejegg: Handle errors in Amazon API calls [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/233993 (https://phabricator.wikimedia.org/T108123) [20:46:17] (PS1) Ejegg: Don't submit an Amazon payment with invalid amount [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/237748 (https://phabricator.wikimedia.org/T108123) [20:46:48] (CR) jenkins-bot: [V: -1] Don't submit an Amazon payment with invalid amount [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/237748 (https://phabricator.wikimedia.org/T108123) (owner: Ejegg) [20:48:40] (PS9) Cdentinger: WIP worldpay ESOP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234691 [20:48:58] (PS2) Ejegg: Don't submit an Amazon payment with invalid amount [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/237748 (https://phabricator.wikimedia.org/T108123) [20:49:04] (CR) jenkins-bot: [V: -1] WIP worldpay ESOP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234691 (owner: Cdentinger) [20:51:55] (PS10) Cdentinger: WIP worldpay ESOP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234691 [20:52:51] does grrrit-wm respond to anything in irc? [20:53:10] or can i chastise it without fear of misbehavior [20:53:47] heh, i've never held back [20:54:12] though i've always directed my anger at jenkins [20:54:30] i just see grrrit-wm as a herald [20:58:49] hehe, maybe jenkins needs an irc bot that just apologizes [21:12:04] fundraising-tech-ops, operations: package udp-filter for Trusty, for use on fundraising banner_logger - https://phabricator.wikimedia.org/T110592#1632526 (Jgreen) Ok these hacks make it compile on with automake 1.14 1) modify configure.ac: -AM_INIT_AUTOMAKE +AM_INIT_AUTOMAKE([subdir-objects foreign]) 2... [21:14:10] RMS on 'Netflix and chill?' https://twitter.com/gexcolo/status/637383659318734849 [21:17:01] incredible [21:23:03] (PS4) Ejegg: Support help text for mixin parameters [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236422 (owner: Awight) [21:23:30] (CR) Ejegg: [C: 2] "Informative!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236422 (owner: Awight) [21:24:12] (PS3) Ejegg: Typo and whitespace [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237296 (owner: Awight) [21:24:31] (Merged) jenkins-bot: Support help text for mixin parameters [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236422 (owner: Awight) [21:25:25] ejegg: $self = $this; <- i take it payments is stuck on 5.3? [21:26:04] yeah :P [21:27:03] oh well. does core support go back that far too? [21:27:29] I think I've had to amend every commit that includes a closure [21:27:53] yeah, they do keep debating upping the requirement [21:28:13] 5.4 had short array...and traits too? [21:28:15] but the counter-argument is that ppl on old webhosts won't be able to use new mediawiki [21:28:26] yeah, no traits for us either [21:28:34] i don't even know what stable php is anymore [21:28:50] 7! [21:29:08] damn [21:29:13] not really [21:29:32] 5.6, officially [21:29:58] oh man, zend security patches for 5.4 end in 2 days! [21:30:10] heh [21:33:18] This nifty 5.4 feature will let us send more-accurate approximations of UTF-8 names to relics like WP: http://php.net/manual/en/transliterator.transliterate.php [21:34:42] that's actually pretty good [21:35:09] DI's EncodingMangler uses that instead of iconv when the Transliterator class exists [21:38:05] a handy thing would be a localsettings manager where you could add and remove blocks by name [21:38:37] oh, huh. like ifdefs around chunks of settings? [21:39:20] yeah and then you have a shell tool that chunks it up into stuff in .localsettings and can build one on command [21:39:54] ooh, php7 is on RC2, with RC3 in 6 days, and release scheduled in November! [21:40:03] and you can name a group of groups as a version of a file [21:40:11] wow [21:40:47] cwdent: interesting... you can definitely have your LocalSettings just include a bunch of other php files [21:41:37] actually, i should organize a couple things like that [21:42:34] yeah that might be good enough, just a bunch of includes that makes it quick to edit [21:46:35] ooh, php7 generates an abstract syntax tree as an intermediate compliation step [21:47:26] they are talking about an "event loop" [21:47:30] sigh [21:47:33] c#'s roslyn let you do that, and it was pretty fun to play with. i got some nice optimizations out of some crazy thing with it [21:47:41] wait, for real? [21:47:45] huh [21:48:09] that is completely at odds with php's execution model [21:48:14] i'll believe it when i see it [21:49:41] i just wonder if the zend people actually have any good ideas [21:49:57] or they are just saying they're going to do the things that people like in other languages [21:50:04] and face book eats their lunch [21:50:56] well, there are plenty of good ideas to steal [21:51:05] cause i'm pretty sure writing to a queue is as async as php is going to get [21:51:30] oh yeah there are totally good ideas, they just don't have a track record of good implementations [21:51:55] oh you guys want closures? here! what? do they have scope? no. [21:52:00] heh [21:54:08] i just don't see how they could possibly maintain any reasonable amount of backwards compatibility and also make it faster [21:54:16] ah man, that's right... brb, adding ampersands to all of my use( ) blocks [21:54:49] X( [21:55:18] my first thought when I saw 'use' was "ok, it's kind of cool to explicitly say what the closure needs to access" [21:56:07] yeah that's what that ES6 syntax is too...like ( function ) => { scope } [21:57:16] but probably a lot of php programmers will ptsd at => [21:58:27] alright, i'm getting distracted by a bunch of things. gonna sign off for now, but I'll drop in for CR later in case the WIP comes off those mustache patches [21:58:42] later cwdent [21:58:51] have a good weekend! [21:58:56] you too! [21:58:58] ejegg|away: cya! [21:59:06] have a good one AndyRussG ! [21:59:14] likewise!! :) [22:15:43] atgo: do you know is it normal practice to remove the WIP before people will review? [22:16:13] that i do not know [22:16:19] thinking i'll remove it on the WP patch, hopefully get things moving next week for an internal test [22:16:28] yeah.... maybe that's how people do things [22:16:34] no more tech online? :P [22:16:46] it's definitely not ready to deploy but kinda works [22:17:20] AndyRussG: do you know about that practice? CN might be a little different cause other departments watch it [22:18:13] cwdent: I think it's not official policy but something similar is not uncommon in other teams [22:20:53] (PS2) Cdentinger: optional address fields for mustache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234579 [22:21:05] I don't think it's that people wouldn't review a WIP patch if you ask them and explain it. Rather it's that the WIP is a way of saying, don't merge [22:21:36] As in, you might want feedback but be pretty sure that it shouldn't be +2'ed yet [22:21:43] (PS2) Cdentinger: de-centralize mustache js [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234584 [22:21:48] That's the way I understood it. Have a look, but don't nobody +2 yet. [22:22:09] The commit message is just a natural place to put messages like that, since it's one of the first thinks you look at when you check out a patch [22:22:13] Still, if it's not ready, it's not going to get +2'd anyway. [22:22:28] Also useful due to the kindabrokenness of Gerrit's draft feature [22:22:41] UGH everything about gerrit [22:22:52] XenoRyet: usually the case, but sometimes there are missing elements that the author knows about, or changes that he or she has in mind, but that are not evident to the reviewers [22:23:02] For sure [22:23:04] cwdent: but... I love th colors! [22:23:14] And the favicon! [22:23:31] make a bunch of comments on a patch...fix some useless whitespace...push new patch...goodbye comments [22:23:47] That part does drive me up the wall. [22:24:02] It's just a fun treasure hunt [22:24:06] if only git had some way of resolving what parts of the file changed [22:24:13] oh wait that's the entire point of git [22:24:51] Sometimes the e-mail stream is actually a better interface [22:25:06] heh yeah [22:26:12] i love that comment and review do the same thing [22:26:19] as well as publish comments and submit review [22:27:15] It's to cognitively prime your brain for working on code where several words mean exactly the same thing [22:27:27] hehe [22:32:04] See, it's the perfect fit for Mediawiki [22:32:09] Or at the very least, CentralNotice [22:32:20] and a few other of its cohorts [22:33:52] (PS11) Cdentinger: worldpay ESOP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234691 [22:43:01] i've got an appt friends, i'll be back online in a bit [22:43:40] hello awight [22:43:51] did you get a car part? [22:44:20] In an odd turn of events, I may have to step out for a few minutes to go save a little old lady I've never met from a power outtage. [22:45:24] Out of town friend's sister's mom apparently lives quite close to me, and needs a circut breaker flipped. I'll be back in a few. [22:45:31] good man [22:46:19] You do what you can. [22:50:43] cwdent: yup, dual purpose errand / bore the baby to sleep [22:51:58] hehehe. charge at least $100 [22:55:25] lol [22:55:33] awe awight: that's mean [22:59:37] awight: i removed WIP from the WP stuff (confusing) [22:59:48] any time you wanna start pointing and laughing at it that would be awesome [23:02:14] oh, sure! [23:03:32] cwdent: looks like you needa have a rebase party [23:04:11] uh oh [23:08:14] (CR) Awight: "Not the fault of this commit, but noting that we should use labels instead of placeholder text." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234579 (owner: Cdentinger) [23:12:42] I'm just going to leave this here: https://www.youtube.com/watch?v=DlS3w1GGE8g [23:13:01] (CR) Awight: [C: -1] "Needs to be a little more optional. Or maybe the required fields stuff doesn't work like I'm imagining?" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234579 (owner: Cdentinger) [23:13:25] (CR) Awight: optional address fields for mustache (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234579 (owner: Cdentinger) [23:13:47] Fundraising Tech Backlog, MediaWiki-Vagrant: Multiwiki settings are not loaded correctly - https://phabricator.wikimedia.org/T98632#1632970 (bd808) Open>Invalid a:bd808 [23:16:41] (CR) Awight: [C: 2] "Good idea!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234584 (owner: Cdentinger) [23:17:22] cwdent: this is awesome [23:20:32] (CR) Cdentinger: optional address fields for mustache (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234579 (owner: Cdentinger) [23:25:46] :) [23:25:55] i'm gonna sign off for a bit but i'll check in later [23:27:13] (CR) Cdentinger: "Yeah you make a good point though about conditionally including optional fields. I'll think of an approach for that." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234579 (owner: Cdentinger) [23:32:00] (CR) Awight: optional address fields for mustache (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234579 (owner: Cdentinger) [23:32:13] cwdent|afk: cya! [23:32:31] (CR) Awight: [C: 2] "Required field thing is unintroduced two commits later." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234579 (owner: Cdentinger) [23:32:37] (PS3) Awight: optional address fields for mustache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234579 (owner: Cdentinger) [23:32:46] (PS3) Awight: de-centralize mustache js [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234584 (owner: Cdentinger) [23:35:58] (CR) Awight: "Looks really good! I have a few questions that I'll wait on before merging, but no blocking issues that I could uncover." (8 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234691 (owner: Cdentinger) [23:35:59] Old lady saved, and got a sweet batch of avocados out of the deal. [23:36:04] :D [23:36:15] the golden eggs [23:36:21] Indeed [23:46:35] Wait. Who saved an old lady? [23:46:48] I thought those were just gnomes and illusions. [23:47:39] Nope, real old lady gave me avocados in exchange for restoring the flow of electrons to her house. [23:48:46] Nice! [23:49:34] Just a flipped breaker, but she couldn't quite throw it herself. [23:49:57] XenoRyet: Electromagnetic leakage again? what's up with your neighborhood? [23:51:53] It's almost too weird to tell. Cat got a call from a friend of ours who lives out of state, explaining that her mom is home alone and this circut breaker tripped and left her without power in our current 90+ temps. Turns out the mom lives just around the corner, so wondered if I could go over and fix it.