[00:00:11] soggy slog? [00:00:30] At least when you're biking in the rain, you generate some internal heat [00:01:11] glad i have a good jacket [00:02:31] awight|afk: yeah i tried that...responception [00:03:12] i think that todo in gatewaypage before processresponse outlines the challenges [00:19:04] (PS2) XenoRyet: Set up import for Major Gifts events payment/invitation tool [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/237864 (https://phabricator.wikimedia.org/T101191) [00:19:41] cwdent: I don't think any of that stuff is necessary, though... [00:20:28] awight: yeah i think you're right [00:20:43] pulling on a string exposed by Call to undefined method PaymentTransactionResponse::getElementsByTagName() in /srv/DonationInterface/worldpay_gateway/worldpay.adapter.php on line 823 [00:21:23] (CR) Awight: [C: 2] "Awesome!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/237864 (https://phabricator.wikimedia.org/T101191) (owner: XenoRyet) [00:21:29] (CR) XenoRyet: "Think I hit all the comments there. We don't know the filename pattern yet, so I left off the upload_form.js bit for now." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/237864 (https://phabricator.wikimedia.org/T101191) (owner: XenoRyet) [00:25:03] (CR) Ejegg: "In which we justify using hasOwnProperty" (1 comment) [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/233993 (https://phabricator.wikimedia.org/T108123) (owner: Ejegg) [00:27:04] (Merged) jenkins-bot: Set up import for Major Gifts events payment/invitation tool [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/237864 (https://phabricator.wikimedia.org/T101191) (owner: XenoRyet) [00:29:36] Yay merged. Now back to CR. [00:29:57] :) [00:30:05] yay XenoRyet! [00:30:40] :) [00:31:01] (PS1) Awight: WIP Update to the 20150904 thank you letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/238365 (https://phabricator.wikimedia.org/T110232) [00:33:17] awesome, congrats [00:33:26] Fundraising-Backlog, Patch-For-Review: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1640033 (atgo) @awight does this include all the languages? Will this go to Staging first as we'd talked about? [00:34:44] Long time coming for a 70 line patch, but at least I kind of have a handle on Civi now. [00:35:44] Unearthing those vagrant issues was a big help! [00:35:56] Yea, that was an interesting hole to fall into. [00:36:30] I think I saw a patch in review for some of that, I should probably take a look. [00:39:51] Fundraising-Backlog, Patch-For-Review: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1640038 (awight) New messages are deployed to staging, use this URL to test: https://civicrm.frdev.wikimedia.org/admin/config/thank_you/test [00:42:06] Fundraising-Backlog, Patch-For-Review: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1640054 (awight) The "start editing" link looks good to me! Have you checked with the community engagement and editing teams that we should be steering people to the si... [00:42:47] gotta run! [00:43:17] Fundraising-Backlog, Patch-For-Review: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1640055 (atgo) hey @jrobell @meganhernandez_wmf - you'd mentioned that you wanted to proof these before they're live. Is that for all of the 20 languages? [01:03:58] fundraising-tech-ops, Traffic, operations, Patch-For-Review: Decide what to do with *.donate.wikimedia.org subdomain + TLS - https://phabricator.wikimedia.org/T102827#1640098 (BBlack) [01:04:14] fundraising-tech-ops, Traffic, operations, Patch-For-Review: Decide what to do with *.donate.wikimedia.org subdomain + TLS - https://phabricator.wikimedia.org/T102827#1374642 (BBlack) [01:56:21] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Epic: [epic] Port our CiviCRM customizations to 4.4 upstream, and to extensions - https://phabricator.wikimedia.org/T99838#1640165 (Eileenmcnaughton) I've set up the wmf-tarball locally. I hit enotices on 2 of the patches & have upstreamed them... [03:40:00] (PS1) Cdentinger: Worldpay resultswitcher [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238386 [03:46:43] (CR) Cdentinger: Worldpay resultswitcher (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238386 (owner: Cdentinger) [03:50:56] (CR) Krinkle: "Internal contract with what? Can that code be updated?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/238326 (https://phabricator.wikimedia.org/T112590) (owner: AndyRussG) [03:52:15] (CR) Krinkle: "(Note: Object.defineProperty cannot be shimmed in old browsers, es5-shim does not create Object.defineProperty.)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/238326 (https://phabricator.wikimedia.org/T112590) (owner: AndyRussG) [12:21:34] Fundraising-Backlog, Patch-For-Review: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1641140 (jrobell) thank you @atgo and @awight! I have checked all 20 languages and the letters look good to me. Regarding the editing link, @MeganHernandez_WMF check... [14:00:17] Fundraising-Backlog, Patch-For-Review: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1641439 (MeganHernandez_WMF) The link is good for now. There's work being done on a new place to send people to learn to edit, but in the meantime, I think we're good t... [14:50:56] (PS2) Cdentinger: Worldpay resultswitcher [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238386 (https://phabricator.wikimedia.org/T110423) [14:58:28] atgo: pending review and merge of https://gerrit.wikimedia.org/r/#/c/238386/ i think we are in good shape to try a live transaction [14:58:40] except i don't know where to deploy everything to provide FR folks a link [15:29:37] wow! [15:29:44] cwdent: that's rad [15:29:55] so we should have to make a form and add it to form chooser, as i understand it [15:32:00] (CR) AndyRussG: "> Internal contract with what? Can that code be updated?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/238326 (https://phabricator.wikimedia.org/T112590) (owner: AndyRussG) [15:32:17] Fundraising-Backlog, Patch-For-Review: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1641737 (atgo) Great. It sounds like we're good to go to prod. Thanks! [15:34:04] atgo: yeah, but do we want to push it to the live servers? seems hasty [15:34:23] cwdent: i leave that question to tech... i'm not sure what our typical workflow is [15:41:21] ejegg: what have you done for the first live tests for processors in the past? [15:41:24] cwdent: ready to deploy some stuff? [15:41:36] hopefully soon [15:42:09] Basically just deploy it and carefully watch the logs [15:42:32] whew [15:42:57] well this is what i did to make the iframe situation work out: https://gerrit.wikimedia.org/r/#/c/238386/ [15:43:05] i *think* it covers all the bases [15:43:13] ah, cool! Taking a look [15:44:50] ejegg: also this is just pasta, but i bet it should change: https://gerrit.wikimedia.org/r/#/c/234691/12/DonationInterfaceFormSettings.php [15:45:42] hmm, yeah, we should decide which we want to be default [15:45:55] probably ESOP, if the changes break non-ESOP [15:46:07] So maybe just dial up the selection weight [15:47:02] ah ha, i could just comment out the top part also [15:47:08] i dunno how selection weight works [15:47:39] it's just the tiebreaker if all else is equal [15:48:45] should i change it to just be in france or something? [15:49:31] nah, leave the rest of the countries in [16:03:04] (CR) Ejegg: "Looking good! It's too bad GatewayPage's handleResultRequest isn't quite up to the task. It's got a lot of checks on when to process and" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238386 (https://phabricator.wikimedia.org/T110423) (owner: Cdentinger) [16:03:08] Fundraising-Backlog, Patch-For-Review: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1641834 (Pcoombe) Hold on, the links are broken for zh-hans and pt-br since those don't exist as wikipedia subdomains. Give me a few minutes, I'll try and fix them on wiki. [16:03:36] Fundraising-Backlog: Unbreak Worldpay API workflow - https://phabricator.wikimedia.org/T112665#1641838 (cwdent) NEW [16:05:13] ejegg: yeah i tried to use handleresultrequest but it isn't wired up quite right with the processor response [16:05:34] i basically stripped down the code in the GC resultswitcher [16:05:46] think you can break that fn up and reuse the iframe bits? [16:06:14] handleresultrequest? [16:06:34] yeah - I see a 'popout_if_iframe' fn in gc [16:06:41] that could probably be in the base class [16:06:57] just so we do the same logging and checks across gateways [16:07:00] ejegg: yeah there seems to be some duplication there [16:07:26] but this is all extra credit... I'm ready to +2 the PS as is if you're eager to deploy and test [16:08:38] good question [16:09:57] a lot of this shared functionality should definitely be centralized [16:10:06] but i worry about falling down the rabbit hole [16:10:13] with the deadline looming [16:10:37] heh, ok, let's leave it alone for now [16:14:49] (CR) Ejegg: [C: 2] "Awesome! GatewayPage::renderResponse might be the cheapest way to get the error handling you want. At some point we should de-dupe the r" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238386 (https://phabricator.wikimedia.org/T110423) (owner: Cdentinger) [16:16:19] cwdent: now that I think of it, we /should/ comment out any other forms for WP when we turn it back on [16:17:55] (Merged) jenkins-bot: Worldpay resultswitcher [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238386 (https://phabricator.wikimedia.org/T110423) (owner: Cdentinger) [16:18:07] Fundraising-Backlog: Unbreak Worldpay API workflow - https://phabricator.wikimedia.org/T112665#1641914 (atgo) Is this for when we would turn WP back on with PCI SAQ A-EP? letters :P [16:22:54] ejegg: ok will do [16:23:41] Fundraising-Backlog: Unbreak Worldpay API workflow - https://phabricator.wikimedia.org/T112665#1641936 (cwdent) Yep that's the idea. I don't know for a fact that the new stuff breaks the old stuff but I am highly suspicious. [16:34:32] ejegg: well commenting it out breaks a bunch of things that refer to it [16:35:20] oh, I just meant in the form settings! [16:35:54] yeah that's what i did...but then i get a bunch of "undefined index worldpay" [16:39:13] cwdent: oh, maybe leave the directory in the array, just make it so the only valid form is the mustache one [16:39:28] oh ok [16:40:28] cool yeah that works [16:41:08] (PS1) Cdentinger: Comment out old WP API for now. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238483 [16:42:00] (PS2) Cdentinger: Comment out old WP API for now. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238483 [16:42:36] i accidentally sent that on top of two merged commits cause my local gerrit remote was out of date again [16:42:46] i pressed rebase and it seems to be ok [16:46:09] (CR) Ejegg: "Just to cover all the sinkholes, want to comment out the 'worldpay form tests' block too?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238483 (owner: Cdentinger) [16:46:10] Fundraising-Backlog, Patch-For-Review: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1642019 (Pcoombe) Okay, it was trickier than expected but I've fixed pt-br and zh-hans links on wiki. @awight can you generate a new patch please? [16:54:16] (PS3) Cdentinger: Comment out old WP API for now. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238483 [17:02:51] Hey are you guys available to talk estimation and what not? [17:03:59] AndyRussG: and ejegg: [17:04:46] be right there! [17:06:18] Fundraising-Backlog: Unbreak WMF-hosted Worldpay workflow - https://phabricator.wikimedia.org/T112665#1642062 (awight) [17:06:22] dstrine: woops, coming!! [17:08:14] Fundraising-Backlog: Unbreak WMF-hosted Worldpay workflow - https://phabricator.wikimedia.org/T112665#1642067 (atgo) Let's leave some more breadcrumbs here? It might be a while before we get that back on, so it'd be good to have more info. [17:08:34] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Comb Amazon out of our Mustache - https://phabricator.wikimedia.org/T111424#1642071 (Ejegg) a:Ejegg [17:08:36] Fundraising-Backlog: Unbreak WMF-hosted Worldpay workflow - https://phabricator.wikimedia.org/T112665#1642073 (atgo) [17:09:42] Fundraising-Backlog, Patch-For-Review: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1642077 (awight) [17:10:17] Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops, Technical-Debt: Move all fundraising component config into Puppet - https://phabricator.wikimedia.org/T110224#1642084 (DStrine) [17:10:33] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [epic] Upgrade Civi to 4.6 & integrate new reporting - https://phabricator.wikimedia.org/T77910#1642087 (awight) [17:13:34] Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Triage what to do with civi-core patches: extensions, upstream, or abandon - https://phabricator.wikimedia.org/T99836#1300095 (atgo) [17:13:55] dstrine: https://phabricator.wikimedia.org/T110113 [17:14:04] Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops: Orphan slayer cron should spam us with failmail if there are errors - https://phabricator.wikimedia.org/T109885#1642102 (awight) [17:14:27] Fundraising Tech Backlog, Fundraising-Backlog: contribution_source triggers seem to be failing - https://phabricator.wikimedia.org/T98643#1642106 (awight) [17:14:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi Prospect Field - Saving Error - https://phabricator.wikimedia.org/T107087#1642109 (awight) [17:24:03] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Show large screen banner and then top screen banner without losing an impression - https://phabricator.wikimedia.org/T90919#1642149 (awight) [17:25:14] Fundraising-Backlog: Spike: Do we have data on unsubscribe & abuse rates from Civi TY emails? - https://phabricator.wikimedia.org/T108892#1642158 (atgo) Open>declined a:atgo We've already decided to go ahead with removing the unsubscribe, as described in T110232, so this seems superfluous. [17:26:07] Fundraising-Backlog, Epic: [epic] Update how we do the List-Unsubscribe email header - https://phabricator.wikimedia.org/T91476#1642169 (atgo) Open>declined [17:26:24] Fundraising Tech Backlog, Fundraising-Backlog: Update unsubscribe link in TY email header - https://phabricator.wikimedia.org/T93946#1642171 (atgo) [17:26:24] Fundraising-Backlog, Epic: [epic] Update how we do the List-Unsubscribe email header - https://phabricator.wikimedia.org/T91476#1085243 (atgo) [17:26:26] Fundraising-Backlog: Accept incoming unsubscribe emails - https://phabricator.wikimedia.org/T93427#1642170 (atgo) Open>declined [17:26:29] Fundraising Tech Backlog, Fundraising-Backlog: Update unsubscribe link in TY email header - https://phabricator.wikimedia.org/T93946#1642173 (atgo) Open>declined [17:26:30] Fundraising-Backlog, Epic: [epic] Update how we do the List-Unsubscribe email header - https://phabricator.wikimedia.org/T91476#1085243 (atgo) [17:28:16] Fundraising-Backlog: [epic] worldpay 1 hour test in France - https://phabricator.wikimedia.org/T110113#1642190 (DStrine) [17:30:13] Fundraising-Backlog: Dedupe data in Silverpop file - https://phabricator.wikimedia.org/T107045#1642193 (awight) [17:31:03] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Orphan slayer's txn_id prefix is screwy - https://phabricator.wikimedia.org/T107847#1642197 (awight) [17:31:08] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations: Spike: do cancelled paypal subscriptions appear in civi? - https://phabricator.wikimedia.org/T92326#1642200 (awight) [17:32:28] Fundraising-Backlog: Record if a donation amount was chosen from one of the fixed amounts - https://phabricator.wikimedia.org/T92462#1642205 (awight) [17:33:08] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Import unsubscribe data from Silverpop - https://phabricator.wikimedia.org/T112674#1642215 (Ejegg) NEW [17:34:06] Fundraising-Backlog: donatewiki access for Trilogy - https://phabricator.wikimedia.org/T110038#1642239 (atgo) @pcoombe has that happened? [17:35:43] Fundraising-Backlog: [epic] Use Silverpop API to import email data to CiviCRM - https://phabricator.wikimedia.org/T108891#1642251 (Ejegg) [17:35:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Import unsubscribe data from Silverpop - https://phabricator.wikimedia.org/T112674#1642252 (Ejegg) [17:36:54] Fundraising-Backlog, Astropay Integration, MediaWiki-extensions-DonationInterface: AstroPay 'deposit' error actually indicates a CPF problem - https://phabricator.wikimedia.org/T109918#1642255 (atgo) @ejegg did this get resolved? or should we be concerned about this before getting more countries online? [17:37:27] Fundraising Tech Backlog, Fundraising-Backlog, Recurring-Donations: Paypal recurring are sometimes added with currency=null - https://phabricator.wikimedia.org/T107378#1642257 (DStrine) [17:37:40] Fundraising-Backlog: Record if a donation amount was chosen from one of the fixed amounts - https://phabricator.wikimedia.org/T92462#1642264 (awight) @ellery: How about a boolean that tells us whether the amount was from a radio button vs. from the Other box? One thing I'm not sure about is whether the form... [17:38:31] Fundraising Sprint House of Pain, Fundraising Tech Backlog, Fundraising-Backlog: Backfill donor language information from logs? - https://phabricator.wikimedia.org/T94670#1642268 (DStrine) [17:39:16] Fundraising Sprint House of Pain, Fundraising Tech Backlog, Fundraising-Backlog: Backfill donor language information from logs? - https://phabricator.wikimedia.org/T94670#1642273 (awight) Try to reuse log parsing stuff that I'm adding as part of orphan rectification repair [17:40:01] Fundraising-Backlog: Spike: WorldPay Reconciliation FY15/16 - https://phabricator.wikimedia.org/T109494#1642279 (DStrine) [17:40:04] Fundraising-Backlog: Spike: WorldPay Reconciliation FY15/16 - https://phabricator.wikimedia.org/T109494#1642282 (atgo) Hey @ppena have you heard anything else about this from worldpay's side? [17:41:48] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice cross-browser tests: debug and expand - https://phabricator.wikimedia.org/T108746#1642292 (DStrine) [17:42:04] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, I18n: Three messages need a better explanation for being optional - https://phabricator.wikimedia.org/T109194#1642296 (awight) [17:43:23] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Reduce cheesiness: Abort orphan slayer job when we hit a total elapsed time like 4 minutes - https://phabricator.wikimedia.org/T107958#1642302 (awight) Open>Invalid a:awight This was already implemented. [17:43:25] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint The Pogues, and 5 others: Orphan slayer reads from frack Redis rather than ActiveMQ - https://phabricator.wikimedia.org/T99017#1642305 (awight) [17:43:53] Fundraising-Backlog, Community-Advocacy, MediaWiki-extensions-CentralNotice: Get banner count via Special:BannerLoader - https://phabricator.wikimedia.org/T90917#1642308 (DStrine) [17:44:00] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-ContributionTracking: SPIKE: Check status of ContributionTracking code on donate wiki landing page - https://phabricator.wikimedia.org/T108741#1642309 (awight) [17:44:05] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Remove "getInfo" methods from CRM test classes - https://phabricator.wikimedia.org/T105769#1642310 (awight) [17:44:16] Fundraising Tech Backlog, Fundraising-Backlog, Continuous-Integration-Config: Enable PHPUnit testing on the wikimedia/fundraising/SmashPig repo - https://phabricator.wikimedia.org/T104264#1642312 (awight) [17:44:27] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: All contributions should be assigned a trxn_id - https://phabricator.wikimedia.org/T97683#1642314 (awight) [17:44:43] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: "ERROR: Canceling payment" message is at the wrong severity level. - https://phabricator.wikimedia.org/T107541#1642315 (awight) [17:44:45] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice RFC for methodology for scoping medium- and long-term requirements and making a roadmap - https://phabricator.wikimedia.org/T108747#1642316 (AndyRussG) [17:44:48] Fundraising Tech Backlog, Fundraising-Backlog: Document IP and Session velocity filters - https://phabricator.wikimedia.org/T92054#1642317 (awight) [17:45:00] Fundraising Tech Backlog, Fundraising-Backlog, Recurring-Donations: Recurring Globalcollect gateway_txn_id is incorrect - https://phabricator.wikimedia.org/T107382#1642318 (awight) [17:45:08] Fundraising-Backlog, Zero: Disable fundraising banners for zero rated devices - https://phabricator.wikimedia.org/T105816#1642320 (awight) [17:45:13] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix blank no_thank_you - https://phabricator.wikimedia.org/T97684#1642322 (awight) [17:45:36] Fundraising-Backlog, Recurring-Donations: Spike: Investigate GC subscriptions that just kind of end - https://phabricator.wikimedia.org/T107390#1642324 (Ejegg) [17:45:44] Fundraising-Backlog, Recurring-Donations: Stop retrying certain types of GC recurring failures - https://phabricator.wikimedia.org/T100536#1642326 (awight) [17:46:03] Fundraising-Backlog, Epic: Migrate images, etc. from Sahar's hosting to WMF - https://phabricator.wikimedia.org/T90810#1642327 (awight) [17:46:09] Fundraising Dash, Fundraising-Backlog: Add country & date filters to Fraud widget on Dash - https://phabricator.wikimedia.org/T89526#1642328 (DStrine) [17:46:21] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Easy: Legal text should only be under form on LP1 - https://phabricator.wikimedia.org/T94048#1642330 (awight) [17:46:34] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Quotation marks are low on Jimmy quote - https://phabricator.wikimedia.org/T94049#1642332 (awight) [17:47:56] Fundraising-Backlog: Spike: Do we have data on unsubscribe & abuse rates from Civi TY emails? - https://phabricator.wikimedia.org/T108892#1642335 (CCogdill_WMF) @atgo if tech has abuse rates, that would still be important data. Abuse complaints are made directly through the email client (Gmail, Yahoo, etc),... [17:47:57] Fundraising-Backlog, Epic: Spike: Write roadmap for language variant work - https://phabricator.wikimedia.org/T112678#1642336 (awight) NEW [17:48:55] Fundraising-Backlog, Epic: [epic] Support language variants throughout donation pipeline - https://phabricator.wikimedia.org/T96594#1642347 (DStrine) [17:49:24] Fundraising-Backlog: Spike: Do we have data on unsubscribe & abuse rates from Civi TY emails? - https://phabricator.wikimedia.org/T108892#1642350 (atgo) declined>Open [17:49:39] Fundraising-Backlog: Spike: Do we have data on unsubscribe & abuse rates from Civi TY emails? - https://phabricator.wikimedia.org/T108892#1533227 (atgo) @ccogdill_wmf updated the task description, please modify if that seems wrong. [17:49:41] Fundraising Tech Backlog, Fundraising-Backlog: Make a form without city/state for a test - https://phabricator.wikimedia.org/T86239#1642353 (awight) [17:49:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Documentation: Document Civi admin pages - https://phabricator.wikimedia.org/T108390#1642354 (awight) [17:49:55] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Point amp cache to $WORKSPACE - https://phabricator.wikimedia.org/T91911#1642355 (awight) [17:50:41] Fundraising-Backlog: Spike: Do we have data on unsubscribe & abuse rates from Civi TY emails? - https://phabricator.wikimedia.org/T108892#1642357 (CCogdill_WMF) Works for me, thanks @atgo. [17:51:16] Fundraising Tech Backlog, Fundraising-Backlog, Recurring-Donations: Move base functionality from recurring_globalcollect into recurring - https://phabricator.wikimedia.org/T107373#1642366 (awight) [17:51:24] Fundraising Tech Backlog, Fundraising-Backlog, Recurring-Donations: Move gateway-specific normalizations out of recurring.module - https://phabricator.wikimedia.org/T107372#1642371 (awight) [17:52:35] (PS1) Cdentinger: Case IsHosted parameter for ESOP only. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238502 [17:56:27] Fundraising-Backlog: Unbreak WMF-hosted Worldpay workflow - https://phabricator.wikimedia.org/T112665#1642395 (cwdent) Since the iframe uses mustache forms and the API uses Rapidhtml there is currently no way to stop the latter from getting both stylesheets and looking bad. I changed the way the URL we send... [18:00:23] Heh, that is one giant wall of wikibugs. [18:14:16] Fundraising-Backlog: donatewiki access for Trilogy - https://phabricator.wikimedia.org/T110038#1642472 (awight) Here's an example WLM banner which uses images from commons, https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/wlm_2015_de Using this image: https://commons.wikimedia.org/wiki/File... [18:18:02] (CR) Awight: [C: -1] "Use a statement like," [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238502 (owner: Cdentinger) [18:19:37] Jeff_Green: Where did we leave things with the paymentswiki puppetization? [18:24:34] Fundraising-Backlog, Patch-For-Review: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1642502 (awight) @Pcoombe: I don't see the changes yet... looking onwiki to see if they need to be published. [18:25:30] awight: it's currently swapped off of my stack, but still a work in progress [18:25:56] i got sorta alarmed about the state of the banner log pipeline, want that done ASAP [18:28:14] Jeff_Green: ok--fyi there's talk about trying to swap out udp2log for kafkatee or something. https://phabricator.wikimedia.org/T97676 [18:28:23] yes [18:28:28] that's what I'm working on [18:28:34] That's blocked on ewulczyn letting us know if he cares about the statistical difference, though. [18:28:38] it's almost reached its ghastly fruition [18:28:41] right [18:29:08] what's going to happen--we're going to start collecting kafkatee-style to a new set of servers, which are already in place [18:29:11] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1642509 (awight) @ellery: Can you let us know what you think about the impact on st... [18:29:40] Great, so we have both in place until we can switch our consuming code? That sounds perfect. [18:29:42] they'll be mounted alongside the netapp, so switching from the udp2log pipeline/logs to the kafkatee pipeline/logs is a matter of changing the log consumer config [18:30:04] already there/collecting/mounted, I'm working on log rotation now [18:30:47] cool. No big rush on puppetization, other than code freeze, I was mostly checking that you weren't waiting for more feedback from me. [18:30:54] k [18:31:01] when is the code freeze? [18:31:07] mmm. now-ish [18:31:09] October [18:31:09] ha [18:31:25] given that chances aren't great we'll get it done [18:32:06] Seems like a safe change to make into the slush, I imagine we can do it in a way that errors wouldn't be subtly. [18:32:09] subtle [18:32:30] yeah [18:33:02] For the warm fuzzy feeling of having revision history on our config, I think it's worth the small risk. [18:33:35] yeah [18:35:08] so we have an interesting new possibility now [18:36:18] which is to say...logs are collecting in realtime on the fundraising collector, so we could in theory process them closer to realtime rather than 15 min intervals [18:36:38] Fundraising-Backlog, Patch-For-Review: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1642537 (awight) @Pcoombe: @jrobell: There's a lot of disabled interface for zh-hans. How do I publish these changes? https://meta.wikimedia.org/w/index.php?title=Spec... [18:38:04] Jeff_Green: I'm not sure where we're headed once Special:RecordImpression is vanquished. We might still rely on logs (Special:BannerLoader), or we might use another mechanism entirely. Realtime would be nice, though. [18:38:16] yup [18:38:30] we can sanitize them and convert them to SMS messages :-) [18:40:00] yay, intl fees may apply [18:40:32] Fundraising-Backlog, Patch-For-Review: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1642550 (awight) I'm also puzzled by the behavior of the pt-br translation interface. I see that one message is outdated, but it doesn't appear in any of the review pan... [18:40:46] Fundraising-Backlog, I18n, Patch-For-Review: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1642551 (awight) [18:48:10] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1642592 (awight) @Jgreen mentions that the new log pipeline will be updated in real... [18:54:54] back in a bit! [19:01:03] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: default submit in Special:CentralNotice is wrong - https://phabricator.wikimedia.org/T49223#1642629 (awight) [19:01:31] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: default submit in Special:CentralNotice is wrong - https://phabricator.wikimedia.org/T49223#1642635 (awight) @Pcoombe: Do you run into this? I'm crazy annoyed trying to use the campaign editor on my dev box. [19:08:36] Fundraising-Backlog, Wikimedia-Site-Requests: Geolocation not available on wikimediafoundation.org - https://phabricator.wikimedia.org/T73747#1642659 (Krenair) Which team would be responsible for handling this? [19:10:45] Fundraising-Backlog, Wikimedia-Site-Requests: Geolocation not available on wikimediafoundation.org - https://phabricator.wikimedia.org/T73747#1642676 (awight) @Krenair: IMO ops should own geolocation. Fundraising Tech has been trying to push it out of the nest for a while now, as it involves Varnish and... [19:34:46] Fundraising-Backlog, I18n, Patch-For-Review: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1642769 (Pcoombe) @awight I just republished all languages, could you try again? [19:46:58] (CR) Ejegg: [C: 2 V: 2] Add PayWithAmazon SDK [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/237312 (owner: Ejegg) [19:48:51] (PS2) Cdentinger: Case IsHosted parameter for ESOP only. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238502 [19:52:03] Fundraising-Backlog, I18n, Patch-For-Review: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1642831 (awight) @Pcoombe: Now there's an untranslated English paragraph up in every language. You can see it here: https://meta.wikimedia.org/wiki/Fundraising... [20:05:25] AndyRussG and Ejegg: you around? [20:32:34] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, I18n, Patch-For-Review: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1642968 (awight) [20:33:02] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Write banner diet campaign mixin - https://phabricator.wikimedia.org/T112017#1642970 (awight) [20:33:19] (PS7) Ejegg: PayWithAmazon IPN listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/237313 (https://phabricator.wikimedia.org/T109649) [20:38:09] (CR) Awight: PayWithAmazon IPN listener (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/237313 (https://phabricator.wikimedia.org/T109649) (owner: Ejegg) [20:38:14] (CR) Awight: [C: 2] PayWithAmazon IPN listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/237313 (https://phabricator.wikimedia.org/T109649) (owner: Ejegg) [20:38:18] (Merged) jenkins-bot: PayWithAmazon IPN listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/237313 (https://phabricator.wikimedia.org/T109649) (owner: Ejegg) [20:39:42] thanks awight! [20:40:26] Any time you need someone to badger you to remove enterprisey code patterns, I can make time. [20:41:00] hehe, yeah, much less complicated now [20:43:31] wut, remove enterprisey code patterns? no way! [20:44:12] :D [20:44:16] (PS1) Cdentinger: Stylesheet for Worldpay. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238546 [20:44:16] See, with a FactoryFactory, you can keep all you classes closed to modification... [20:44:28] * awight sneaks a plastic knife into centralnotice [20:44:31] heheheh [20:45:09] worker threads of the world, untie! You have nothing to loose but your sync [20:45:46] I always thought that rhetoric was sketchy, at least when coming from the AK press evangelists at rage against the machine concerts [20:45:57] AK? [20:46:12] They're ok. http://www.akpress.org/ [20:46:33] awight: there's that stylesheet w/ RL module. think it's ok to send the stylesheet over or should i wait until it's deployed and give them the link? [20:46:44] Speaking of leftist infighting... this is the real one you wanna get books from, http://www.pmpress.org/content/index.php [20:47:13] cwdent: I think both. Send a file, ask all yr questions, and iterate in a week :) [20:47:26] sounds good [20:47:41] weeee [20:48:05] feminist science fiction [20:48:11] like...alien? [20:48:22] PM press gave me their 50% off code a couple of years ago... I went off the deep end, bought $400 of books and gave them away. Anyone want the code? [20:48:27] They like when people use it. [20:48:48] Hey, don't alienate those aliens [20:49:10] Ursula LeGuin and Octavia Butler? [20:49:37] terminator also has a strong female lead [20:49:56] ah, pm looks interesting [20:50:09] but i think it might be more indicative of the type of women james cameron is into [20:50:18] :p [20:50:47] do they have books for kids? [20:51:34] https://secure.pmpress.org/index.php?l=product_list&c=49 [20:52:22] I actually went to the extreme of hiding our collection of "Dork Diaries" (the first of which we purchased before realizing how retrograde they are) https://en.wikipedia.org/wiki/Dork_Diaries [20:52:53] aww, it sounds fun [20:52:58] All bout hair, being popular, and competing for male attentino [20:53:16] Basically those are the main themes [20:53:16] http://www.akpress.org/books.html?topics=37 [20:53:57] cool! thanks :) [20:55:05] http://www.akpress.org/youhavetofuckingeat.html [20:55:23] his other book "Go the Fuck to Sleep" was brilliant... [20:55:47] hehe [20:55:55] i heard sam jackson read that [20:56:06] that's right! I haven't heard it yet [21:02:14] I've heard of it, not seen it yet [21:03:10] They should also make a "Fucking Study for Your Exam" [21:03:20] 8) [21:05:28] Most urgent CN patches: https://gerrit.wikimedia.org/r/#/c/238326/ https://gerrit.wikimedia.org/r/#/c/237526/ , and as a dependency, https://gerrit.wikimedia.org/r/#/c/237418/ [21:05:33] (PS1) Ejegg: Minor Amazon formatting cleanup [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/238603 [21:05:39] XenoRyet, anyone else interested ^ [21:05:44] 10-4 [21:05:49] Thanks much! [21:13:58] ejegg: XenoRyet: awight: cwdent: I'm a bit stuck choosing a strategy for the donate-click event-logging call [21:14:28] that is, for the fallback for browsers that don't support sendBeacon [21:14:54] The general strategy I think should be to have a timeout, and try to detect if the logging call was made before the timeout finishes [21:15:26] If it was, navegate away to the next page right away [21:15:41] Otherwise, only wait 'till the end of the timeout to do so [21:15:51] AndyRussG: is something bouncing before the call gets made? [21:16:09] cwdent: what do u mean bouncing? [21:16:29] if you use $.ajax... i mean like are they leaving the page? [21:16:33] I've been looking at this approach, which used to be used by the GettingStarted extension: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGettingStarted.git/b315e6f2c8db6b8e7c68beffed94cb761a0643b8/resources%2Fext.gettingstarted.logging.js#L67 [21:16:59] cwdent: yeah, we're trying to make a last-second logging call before they click donate [21:17:11] or, when they click donate, but before they leave the page [21:17:22] That sounds like a good strategy. If the log ID is sent along to the donation system, it'll be easy for us to estimate how many people are falling through and not storing log data. [21:17:43] ah ha, but not block? [21:17:54] awight: yes... But I'm having trouble finding the exact way to implement it [21:18:05] actually... do people always need to choose/type an amount before clicking donate? [21:18:05] atgo: Just bumping the topic--we need ewulczyn to test on his side, stat. [21:18:18] ejegg: yes [21:18:30] aha, so we need to log then [21:18:40] cwdent: we have to go through the EventLogging system, so that limits what we can do [21:19:07] ejegg: I don't quite see how the amount is related? [21:19:07] here's the EL method we have to call [21:19:08] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FEventLogging/a019982d48b63c59b94b3e376bfde672f64d9fd9/modules%2Fext.eventLogging.core.js#L261 [21:19:48] that's one hell of a ternary [21:20:11] AndyRussG: if we triggered on an action that very likely precedes a donate click, we might not have to block / delay [21:20:12] hahah yes... Line 244, the details of the sendbeacon method [21:20:26] or not as much, anyway [21:20:44] sorry, that was meant for awight [21:20:49] AndyRussG: I see. So the EL code doesn't have any concept of timeout, if we're not using sendBeacon [21:21:02] ejegg: ah K [21:21:29] awight: yeah. I actually don't understand how (or if?) the GettingStarted workaround works [21:21:48] Or in fact, why the logEvent method uses a promise, since I don't see anything async about it [21:21:56] Where is "GettingStarted"? [21:22:12] It's an extension... Se the above link ^ [21:22:22] ah [21:22:24] awight: here it is again https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGettingStarted.git/b315e6f2c8db6b8e7c68beffed94cb761a0643b8/resources%2Fext.gettingstarted.logging.js#L67 [21:23:31] AndyRussG: the promise only catches url size overflow, I guess? [21:23:57] Yeah but why doesn't it just return false or something? [21:24:14] right. cos someone was clearly feeling fancy :) [21:24:36] The GettingStarted code seems to imply that it can actually tell when the non-beacon call is confirmed to be made [21:24:50] I agree w/u that there's no way to do that [21:25:07] I was thinking of trying to follow the the onload event of the img tag that's created in the non-beacon option, but since it's not attached to the DOM, I can't find it using JQuery [21:25:13] You can test !navigator.sendBeacon and just wait a few seconds if it's not available... [21:25:21] :( [21:25:38] awight: yeah that's the worst case fallback. I was thinking more like 200 milliseconds again [21:26:12] why a timeout instead of a callback? to put a hard limit on it for UX sake? [21:26:27] I doubt anyone will make it under that bar [21:26:46] cwdent: You see somewhere to hang a callback? [21:27:18] Maybe create blocks? [21:27:20] oh i guess i could look at the code :P [21:27:50] I was checking that out, it seems it doesn't [21:27:54] http://stackoverflow.com/questions/9421202/how-do-i-make-an-image-load-synchronously [21:28:01] But we don't have access to the img, like you said [21:28:56] looks like connecting the img load with the promise would be a good EL patch [21:29:10] Unless it somehow blocks on the sending of the request but not thre response [21:29:17] ejegg: also a fun idea [21:29:21] My battery is about to die [21:30:10] +1 ejegg [21:31:42] Rggg gotta drive now too, bassoon [21:34:11] (PS3) Awight: Case IsHosted parameter for ESOP only. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238502 (https://phabricator.wikimedia.org/T112665) (owner: Cdentinger) [21:34:19] (CR) Awight: [C: 2] "Thanks!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238502 (https://phabricator.wikimedia.org/T112665) (owner: Cdentinger) [21:35:20] (CR) Awight: [C: -1] "Small tweak suggested." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238483 (owner: Cdentinger) [21:36:52] (CR) Awight: Stylesheet for Worldpay. (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238546 (owner: Cdentinger) [21:38:48] awight: i was thinking just that ^ [21:39:04] i could go back and rename the js file...that seems more correct [21:39:37] wfm! [22:00:53] (PS6) Awight: WIP Banner diet mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 [22:01:04] (PS7) Awight: WIP Banner diet mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 [22:01:31] cwdent: "Enhance Silent Port" [22:01:44] Keep that one in your pocket next time you need clarification wrt doxx [22:02:09] (CR) jenkins-bot: [V: -1] WIP Banner diet mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (owner: Awight) [22:02:11] hahaha [22:02:13] amazing [22:02:14] I'd probably feel the same way if my job were to emit nonsense acronyms [22:03:15] aww, grimoire/mockflow is down [22:15:10] (PS8) Awight: WIP Banner diet mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 [22:15:18] If anyone wants to look at that ^ [22:16:22] (CR) jenkins-bot: [V: -1] WIP Banner diet mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (owner: Awight) [22:16:24] (PS9) Awight: WIP Banner diet mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 [22:18:07] Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Triage what to do with civi-core patches: extensions, upstream, or abandon - https://phabricator.wikimedia.org/T99836#1643305 (awight) a:Eileenmcnaughton [22:18:52] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Install Civi 4.6 to production - https://phabricator.wikimedia.org/T99844#1643309 (awight) [22:19:13] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Prepare CiviCRM 4.6 upstream and Giant Rabbit branches - https://phabricator.wikimedia.org/T99837#1643313 (awight) [22:19:21] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Prepare CiviCRM 4.6 upstream and Giant Rabbit branches - https://phabricator.wikimedia.org/T99837#1300103 (awight) a:Eileenmcnaughton [22:19:30] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Prepare CiviCRM 4.6 upstream and Giant Rabbit branches - https://phabricator.wikimedia.org/T99837#1300103 (awight) [22:25:45] awight, i heard you like big ternaries: https://gerrit.wikimedia.org/r/238623/ [22:26:59] That's just sick [22:27:05] :P [22:27:13] Trying to keep up with the Joneses? [22:27:46] but nice work! [22:33:30] (PS10) Awight: WIP Banner diet mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 [22:33:30] awight: XenoRyet: cwdent: ejegg: sorry to have asked for advice and then taken off... Mmm the idea of patching EL itself sounds fun... any other thoughts? [22:33:52] hehe ejegg may have patched it already [22:33:57] https://gerrit.wikimedia.org/r/238623/ [22:34:08] careful with that magic lantern! [22:34:29] (PS2) Cdentinger: Stylesheet for Worldpay. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238546 [22:34:57] wow! [22:35:17] The ternary is even more pervy now [22:35:53] (PS3) Cdentinger: Stylesheet for Worldpay. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238546 [22:36:25] I was about to say, yeah [22:36:36] it's a pervary [22:36:42] melee a trois [22:36:54] Nested even [22:37:47] eileen: I was hoping to get your advice on https://phabricator.wikimedia.org/T105918 [22:38:55] Is a saved field mapping the only way I can override the primary field map to add a custom field? [22:38:58] awight: so, the idea is that the field CAN be exported but you want it to be exported by default? [22:39:04] yah [22:39:13] awight: ejegg: XenoRyet: cwdent: the funny thing I ran into is the second answer here: http://stackoverflow.com/questions/3584288/can-the-unload-event-be-used-to-reliably-fire-ajax-request [22:39:57] yeah - so that’s the expected way at the moment. I’ll take a look at the code - it might make sense to add a hook [22:40:08] It sez that "the script will block", but testing it out, I didn't see evidence thereof [22:40:32] or else perhaps primary fields *should* be a reserved saved mapping - that would be editable at own risk [22:42:12] AndyRussG: Can I make a test campaign for ewulczyn? Do you recommend production or beta? [22:43:04] awight: there's already one in beta! I don't see why he couldn't try that one out. It's already got some of the changes that are awaiting deploy [22:43:13] ok excellent, thx [22:43:54] awight: http://en.wikipedia.beta.wmflabs.org/wiki/Main_Page?country=AQ [22:44:12] awight: I’ll take a look & put some notes on that ticket [22:44:14] Unless there's something he'll get out of production that he can't get on beta, I don't see why not beta [22:44:20] hey cwdent - would it be useful to get trilogy to come up with some css for the iframe? [22:44:28] (PS4) Cdentinger: Comment out old WP API for now. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238483 [22:44:50] uhm [22:44:56] atgo: what is trilogy? [22:46:07] awight: rrrg something's odd there [22:47:48] awight: hmmm maybe it was a dev tools bork or a local cache sneeze, somehow one some calls I wasn't getting the banner history filled up, but then it jumped up 2 entries at once [22:47:53] awight: broke out the implementations to slim down the ternary - https://gerrit.wikimedia.org/r/238629 [22:49:02] bah, what's jshint complaining about? [22:49:10] AndyRussG: hey, I don't see any localstorage action: http://meta.wikimedia.beta.wmflabs.org/w/index.php?title=Www.wikinews.org_template&banner=CN_banner_history_test_banner&uselang=en [22:49:30] oops, self is already defined? [22:49:32] oh... [22:49:34] awight: no, when you test the banner you won't get any. It's only when you get the campaign [22:49:45] The mixin isn't associated with the banner, but with the campaign. [22:50:05] oh hehe thx. I'd deleted the force= but forgot the banner= param [22:50:34] Also to force logging, do this: http://en.wikipedia.beta.wmflabs.org/wiki/Main_Page?country=AQ&bannerHistoryLogRate=1 [22:50:47] awight: no, banner= won't do you anything either [22:51:18] You need to actually go to a page where you get the campaign, telling CN that you're in the campaign's segment of users [22:51:41] woohoo! [22:52:29] got some data in LocalStorage [22:53:15] eileen: Sorry, I didn't mean to distract you with that export job, just hoping there was an easier answer than whatever I was about to hack up... [22:54:24] no that’s cool - I’m talking with atgo in a few mins - but I think it would be worth chatting with totten about his thoughts on adding a hook into that function [22:54:55] unfortunately he isn’t on irc right now (or maybe fortunately since I have the other lined up in a few mins) [22:55:15] Donno--it might be nicer to have a way to build saved mappings which add to the primary fields. [22:55:49] right so prefill the mapping & then save it? [22:56:06] rather than having to start from scratch [22:56:28] atgo: i think the css is probably fine, just copied it from the mustache form [22:56:35] imma go build some fly rafters [22:56:49] this is about convenience rather than stopping people from making mistakes? [22:56:59] That still sounds fragile. I assume that the primary fields change with every update, so I'd rather have a saved mapping which was built like "primary fields + WMF custom field group" [22:57:23] awight: cool! [22:57:36] hmm? [22:57:55] yeah that makes sense [22:57:56] that it works? Yeah, I became more happy! [22:58:51] awight: I can take a look at how that might work after I talk to Anne if you want [22:59:28] We can wait until after the upgrade, I think. I'll check. [22:59:57] There's a long list of this sort of request :) [23:12:35] (PS1) Awight: Include custom fields in default export [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/238636 (https://phabricator.wikimedia.org/T105918) [23:15:12] Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Adding 1 Custom field to "primary fields" export list: Do Not Solicit - https://phabricator.wikimedia.org/T105918#1643507 (awight) @CaitVirtue: Doing thi... [23:15:27] eileen: You might be amused ^ [23:22:58] (PS5) Awight: WIP New maintenance scripts for manipulating GC charges [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234417 (https://phabricator.wikimedia.org/T109668) [23:23:25] (CR) jenkins-bot: [V: -1] WIP New maintenance scripts for manipulating GC charges [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234417 (https://phabricator.wikimedia.org/T109668) (owner: Awight) [23:32:37] dstrine-meeting: you there? [23:35:19] awight|meets: I think that patch works for now…. perhaps a better fix is a longer term goal [23:59:46] (Abandoned) Awight: WIP New maintenance scripts for manipulating GC charges [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234417 (https://phabricator.wikimedia.org/T109668) (owner: Awight)