[00:00:58] Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Settle unslain orphans - https://phabricator.wikimedia.org/T109668#1643593 (awight) Open>declined We might need this again, but I'm giving up on the current ba... [00:01:32] AndyRussG: Any thoughts about my impressionDiet mixin would be much appreciated, when you have the chance. [00:01:53] awight: you bet! [00:02:18] thanks! [00:02:30] awight: likewise! [00:02:55] It was kinda fun--want me to look at the fullscreen mixin? [00:03:01] sure! [00:03:11] * awight claps hand to mouth, too late [00:03:14] though more urgent is CR... [00:03:20] ok, will do [00:03:28] thanks!! [00:03:47] (PS4) Awight: Fallback for browsers that don't support Object.defineProperty [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/238326 (https://phabricator.wikimedia.org/T112590) (owner: AndyRussG) [00:12:04] (CR) Awight: "How about we just call into cn.internal.state.getData() directly when cn.data is needed? That feels more honest..." (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/238326 (https://phabricator.wikimedia.org/T112590) (owner: AndyRussG) [00:15:47] AndyRussG: ^ alternatively, if the mw.cn dependency ordering thing could be resolved, maybe we wouldn't need to run $.extend in the first place? [00:20:24] awight: wrt being sure about when mw.cn is created, it's not really possible, because several things need to add stuff directly to the object, and the dependencies are used to make sure certain things are there before others [00:24:30] (PS5) AndyRussG: Fallback for browsers that don't support Object.defineProperty [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/238326 (https://phabricator.wikimedia.org/T112590) [00:26:05] AndyRussG: As usual, I don't understand it well enuf to be convinced ;) [00:26:49] It seems like we should be able to use dependencies to correctly order which modules depend on data from the others, but to build the mw.cn namespace we should be able to use namespace closure tricks. [00:28:07] The problem is currently, that we have to merge two already formed mw.cn objects together? [00:28:36] awight: heheh lemme dredge up the sordid details! :) [00:28:45] sorry to do this to you for the 10th time... [00:29:15] (CR) AndyRussG: "> How about we just call into cn.internal.state.getData() directly when cn.data" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/238326 (https://phabricator.wikimedia.org/T112590) (owner: AndyRussG) [00:29:37] ^ I meant, legacy scripts in banners [00:29:47] a ha. [00:29:49] well... [00:29:53] grr [00:29:55] (in the Gerrit coment) [00:30:16] right [00:31:28] wow, that's a lot of legacy scripts. [00:31:37] 1,431 hits for https://meta.wikimedia.org/w/index.php?title=Special%3ASearch&profile=advanced&search=mw.centralNotice.data&fulltext=Search&ns0=1&ns8=1&ns10=1&ns12=1&ns200=1&ns202=1&ns866=1&profile=advanced [00:32:03] awight: yeah, we couldn't expect to change all that from the get-go [00:32:12] oh hold on, these are transclusions [00:33:18] I think you'll get the real deal if you just put in the mw namespace? [00:33:28] I think it comes down to literally a handful of .js [00:33:46] ah no hmm not sure [00:34:04] One way to tell would be to refactor those 4 js files and see what remains... [00:34:49] Heh also [00:34:53] mind if I do? [00:34:59] Yes [00:35:04] ...rr I mind [00:35:16] One of my stock end-of-day threats ;) [00:35:20] heheheheh [00:35:32] It's OK, I've seen worse [00:36:27] (was just working with Sofía help her finish her French homework before she showed signs of tiredness and no longer learning a darn thing, now she and her sister are off to sleep...) [00:36:38] I think it would be safe, though, if done in a controlled, working hours sort of fashion [00:36:50] (...so there were some end-of-the-day threats flying on both sides there...) [00:37:15] Well, I'm just not sure there may not be stuff that's live right now [00:37:44] Yes, I agree it could be done. I'd at least want to check all live campaigns and talk to the-wub [00:38:50] https://meta.wikimedia.org/w/index.php?title=Special%3ASearch&profile=advanced&search=mw.centralNotice.data+-%22mw.centralNotice.data.getVars.banner+%29+{+var+newBucket%22+-%22mw.centralNotice.data.getVars.banner+%29+{+if+%28+mw.cnBannerControllerLib%22+-%22Boolean%28mw.centralNotice.data.getVars.forceBannerDisplay%22+-%22parseInt%28mw.centralNotice.data.bucket%2C+10%29%3B%22&fulltext=Search& [00:38:51] so... wrt the $.extend basically all over the place we have stuff that either adds to an existing cn object or creates one and adds to that [00:38:56] ns0=1&ns8=1&ns10=1&ns12=1&ns200=1&ns202=1&ns866=1&profile=advanced [00:39:02] wut? [00:39:20] The uses of mw.cn.data seem to break down into 4 transcluded snippets [00:39:47] IMO it's very preferable to fix these usages than to add really fragile looking back-compat code [00:40:01] * awight is spilling superlatives [00:40:28] awight: the above URL didn't work for me? no results [00:40:31] "URL" [00:40:56] exactly! it's a search for mw.cn.data, minus the four transcluded examples [00:41:09] if you do each quoted string separately, you'll see the .js it comes from [00:42:45] awight: ah brilliant [00:43:04] * awight hides [00:43:31] Sorry that my response to this interesting patch is to throw a temper tantrum :) [00:44:17] More silliness tomorrow! [00:44:59] heh it makes a lot of sense [00:45:17] I didn't think there was so much transculsion when I originally checked out what to support and what not [00:45:34] we can also substitute data.getVars.banner for the new shiny proper test, too [00:45:40] Praise allah... I'd be sad if there was that much copypasta [00:45:47] heheheh [00:46:08] ok, ttyl [00:46:15] awight: K I'll send up another patch and ping pcoomb tomorrow [00:46:18] cya! thanks! [00:58:35] (PS1) Ejegg: Bring Amazon branch in line with WP templating [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/238661 (https://phabricator.wikimedia.org/T111424) [00:59:16] heading out for the night, folks. have a good one! [01:42:22] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog: Associate banner history ID with contribution ID - https://phabricator.wikimedia.org/T112022#1643745 (AndyRussG) Here's a beta cluster banner with a wee script that does this: http://meta.wikimedia.beta.wmflabs.org/wiki/Special:CentralNoticeBanne... [09:34:47] (PS1) Awight: Shut it off. [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/238697 [09:35:30] (CR) Awight: [C: 2 V: 2] "Needs retroactive CR, I suppose." [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/238697 (owner: Awight) [09:37:02] !log ruthlessly disabled PayPal IPN listener [09:37:07] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [10:36:20] TCB-Team-Fundraising-Sprint-2015-08-12, TCB-Team-Fundraising-Sprint-2015-08-26, TCB-Team-Fundraising-Sprint-2015-09-02, TCB-Team-Fundraising-Sprint-2015-09-10, and 2 others: [WMDE-Fundraising] Move Piwik to its own VM - https://phabricator.wikimedia.org/T105289#1644515 (Tobi_WMDE_SW) [10:42:17] TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team: [WMDE-Fundraising] Add validation api to the fundraising app - https://phabricator.wikimedia.org/T112063#1644536 (WMDE-leszek) Pull request on Github: https://github.com/wmde/fundraising/pull/685 [11:04:46] TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team: [WMDE-Fundraising] Add validation api to the fundraising app - https://phabricator.wikimedia.org/T112063#1644556 (Tobi_WMDE_SW) [11:04:51] TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team: [WMDE-Fundraising] Implement validator class for donations - https://phabricator.wikimedia.org/T112076#1644557 (Tobi_WMDE_SW) [11:16:51] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, I18n, Patch-For-Review: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1644571 (jrobell) @awight @Pcoombe: Thank you for your work on this. I believe we actually want to use zh and not zh-... [11:23:52] TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team: [WMDE-Fundraising] Create entry point class/application for server requests coming from the sensitive banner - https://phabricator.wikimedia.org/T112061#1644580 (Tobi_WMDE_SW) [11:29:15] TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team: [WMDE-Fundraising] Implement general communication mechanism for the sensitive banner - https://phabricator.wikimedia.org/T112058#1644584 (Tobi_WMDE_SW) [11:32:46] TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team: [WMDE-Fundraising] Implement basic tracking of the actual banner usage - https://phabricator.wikimedia.org/T112068#1644586 (Tobi_WMDE_SW) [11:36:43] TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team: [WMDE-Fundraising] Request CentralNotice adminship rights - https://phabricator.wikimedia.org/T112059#1644608 (Tobi_WMDE_SW) [15:35:38] (CR) Krinkle: "I agree it's not a priority to keep .data up to date for legacy. However I would recommend in that case to set it to a compatible empty va" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/238326 (https://phabricator.wikimedia.org/T112590) (owner: AndyRussG) [15:39:39] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: default submit in Special:CentralNotice is wrong - https://phabricator.wikimedia.org/T49223#1645240 (Pcoombe) @awight I don't tend to hit Return to submit. However it would definitely be nice to improve the banner filtering to be ajax and/or use a... [16:13:20] cwdent: I think this one brings the Amazon forms back in line with how WP's doing it on master: https://gerrit.wikimedia.org/r/238661/ [16:13:38] cool, looking [16:14:53] it's undoing a lot of changes from If3a2f138e3df7bbd96b43ffffa38074acfd5ecf1 [16:15:13] maybe I'll point to that in the commit message [16:16:42] (PS2) Ejegg: Bring Amazon branch back to normal Mustache templates [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/238661 (https://phabricator.wikimedia.org/T111424) [16:17:59] If anyone else gets OCD today, https://www.mediawiki.org/wiki/Fundraising_tech/Glossary [16:18:56] ah, nice. I'll add stuff as inspiration strikes [16:22:05] man good call [16:25:14] awight: how did you know there were a million emails coming in at 2:30 am? do you get automatic calls or texts? [16:25:30] dstrine: I had the ill fortune to be awake... [16:25:51] I honestly don't have failmails filters dialed in. [16:25:54] kk that's not a tactic I plan to adopt :) [16:26:19] fundraising-tech-ops, operations: reformulate kafkatee package to work with Trusty - https://phabricator.wikimedia.org/T110591#1645409 (Jgreen) working fine [16:26:22] I've been thinking lately... * we all need to study K4's filters, and * Maybe we should consider rotating pager duty? [16:26:42] fundraising-tech-ops, operations: reformulate kafkatee package to work with Trusty - https://phabricator.wikimedia.org/T110591#1645412 (Jgreen) Open>Resolved [16:26:58] I've used a service called "pager duty" but as far as I can remember a human still has to call you [16:27:28] Also. This one was really hard to shut off, I'm looking forward to https://phabricator.wikimedia.org/T110224 [16:27:53] nevermind found more info: https://www.pagerduty.com/tour/easy-setup/ [16:27:57] my uncle works at https://victorops.com/ [16:28:10] we used pagerduty at sparkfun, it was fine [16:28:23] Well, this could be something like we set up a shared email account that has nice failmail filtering, and then point it at a pager service [16:28:45] Or less formally, we just agree to actually read these goddamn emails on certain days [16:29:15] but what do we do about 1am on a saturday morning? awight: [16:29:26] Even a low volume of these things is distracting enuf to the whole team that we end up either ignoring them or losing sleep [16:29:47] my typing fails have begun and it's not 10am [16:29:48] well, whoever drew the sat night straw that week eats it, I guess [16:29:53] :) [16:30:15] ok so you are still proposing an on call schedule [16:30:19] ? [16:30:28] * cwdent winces [16:30:37] :( I don't want to. But I don't see how else we keep this ship afloat [16:30:42] sorry cwdent I'm just asking [16:31:05] I mean. I'm sort of okay with waking up to 10,000 failmails, but it could involve actually screwing donors [16:31:34] it would be nice if we had more tech people in the other hemisphere [16:31:35] are we also going to have some hard rules like "absolutely no deploy after 1pm on thursday"? [16:32:18] we should have large amounts of space to protect the weekend [16:32:25] (CR) Cdentinger: [C: 2] "looks great!" [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/238661 (https://phabricator.wikimedia.org/T111424) (owner: Ejegg) [16:32:50] thanks cwdent! Now let's see how that merges... [16:32:52] cwdent: +1 [16:33:31] Yeah we definitely need to stick to our deployment rules, but there are * bugfixes and * unexpected things [16:33:46] unexpected as in, processor decides to go batshit [16:33:56] yeah, like paypal's ipn postback dropping out of dns [16:34:47] what *was* that? [16:34:48] yep and that's one that no automation could have really understood [16:34:54] xactly [16:35:05] other than: ow it hurts, shut it off [16:35:37] That's not a bad idea, really... have a failmail threshold tied to deadman switch for each service [16:35:44] yeah i was thinking about that [16:36:04] https://en.wikipedia.org/wiki/Monit [16:36:11] that is a pretty good service watchdog [16:36:45] Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops, Technical-Debt: Move all fundraising component config into Puppet - https://phabricator.wikimedia.org/T110224#1645472 (awight) [16:38:05] (Merged) jenkins-bot: Bring Amazon branch back to normal Mustache templates [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/238661 (https://phabricator.wikimedia.org/T111424) (owner: Ejegg) [16:42:08] https://www.mediawiki.org/wiki/Fundraising_tech/New_integration_manual [16:44:23] I don't know that this is helpful, but I wanted to translate our recent outlines into something general ^ [16:44:31] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, Unplanned-Sprint-Work, I18n, Patch-For-Review: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1645524 (DStrine) [16:46:48] hey all: Could everyone do a pass on the current sprint and add "Unplanned sprint work" to anything you pulled in after sprint planning? I've seen some stuff move in over the last few days but I wasn't there when you guys started this sprint. Any help would be greatly appreciated [16:46:58] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, Unplanned-Sprint-Work, I18n, Patch-For-Review: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1645528 (awight) @Amire80: If you have time to look at this, we're all a little uncomfortabl... [16:47:28] will do dstrine [16:47:41] thanks! [16:47:58] Thanks for keeping us honest! [16:54:48] Fundraising Tech Backlog, fundraising-tech-ops: Set up fr-tech permissions for Eileen - https://phabricator.wikimedia.org/T109765#1645582 (Jgreen) p:Normal>High [17:04:21] fr retro, anyone who's interested! [17:06:29] (CR) Krinkle: [C: -1] Migrate to a terser cookie name and format (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235979 (https://phabricator.wikimedia.org/T110353) (owner: Ori.livneh) [17:10:58] * awight|retro pokes AndyRussG with https://gerrit.wikimedia.org/r/#/c/236229/ [17:11:38] * AndyRussG acknowledges awight|retro's poke [17:13:42] Hey the-wub! Quick quesiton: talking to awight yesterday about deprecating mw.centralNotice.data for something better like mw.centralNotice.getData()... It seems there are only 4 scripts that access mw.centralNotice.data, though they're transcluded all over the place... As a migration strategy, we were thinking we could probably just update those scripts... Does that sound right from your perspective? [17:15:37] AndyRussG: the main problem is that we use mw.centralNotice.bannerData.hideResult usually outside of any templates [17:15:57] the-wub: ah no, mw.centralNotice.bannerData wouldn't change [17:16:01] Just mw.centralNotice.data [17:16:08] oh sorry, I misread [17:16:14] np :) [17:18:09] AndyRussG: ah mw.centralNotice.data I think we just use for getting banner and campaign names. I've no objection to changing that for something else if needed [17:18:25] the-wub: fantastic! Thanks, it's just a little nitpicky tweak... [17:18:28] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1645798 (Jgreen) [17:18:49] Any news for scrum of scrums, awight|retro , AndyRussG , cwdent , XenoRyet ? [17:19:00] ejegg: none here, thanks much! [17:19:11] Not that I can think of [17:19:25] cool [17:19:53] nah, all good [17:23:34] (CR) AndyRussG: "As per IRC yesterday:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/238326 (https://phabricator.wikimedia.org/T112590) (owner: AndyRussG) [17:24:10] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1645833 (Jgreen) The new kafkatee-based banner log pipeline is up and running on am... [17:27:18] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, Unplanned-Sprint-Work: AstroPay audit parser failing - https://phabricator.wikimedia.org/T112779#1645869 (Ejegg) NEW [17:30:11] Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Adding 1 Custom field to "primary fields" export list: Do Not Solicit - https://phabricator.wikimedia.org/T105918#1645891 (CaitVirtue) @awight: I just r... [17:31:23] Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Adding 1 Custom field to "primary fields" export list: Do Not Solicit - https://phabricator.wikimedia.org/T105918#1645903 (atgo) In review right now, we'... [17:32:42] Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Adding 1 Custom field to "primary fields" export list: Do Not Solicit - https://phabricator.wikimedia.org/T105918#1645904 (CaitVirtue) ok, thank you. [17:47:21] (PS4) Cdentinger: Case IsHosted parameter for ESOP only. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238502 (https://phabricator.wikimedia.org/T112665) [18:03:14] (CR) Awight: [C: 2] Comment out old WP API for now. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238483 (owner: Cdentinger) [18:03:42] (Merged) jenkins-bot: Comment out old WP API for now. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238483 (owner: Cdentinger) [18:03:44] (PS4) Awight: Stylesheet for Worldpay. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238546 (owner: Cdentinger) [18:03:47] (Merged) jenkins-bot: Case IsHosted parameter for ESOP only. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238502 (https://phabricator.wikimedia.org/T112665) (owner: Cdentinger) [18:08:54] (PS1) Ejegg: Merge branch 'amazon' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238803 [18:12:28] cwdent: want to try kicking that merge ^^ around to make sure it doesn't bust WP? [18:13:04] ejegg: will do! [18:15:58] Fundraising Sprint Snoop (Dogg|Lion), Analytics-EventLogging, Unplanned-Sprint-Work, Patch-For-Review: Promise returned from LogEvent should resolve when logging is complete - https://phabricator.wikimedia.org/T112788#1646145 (Ejegg) p:Triage>Normal a:Ejegg [18:16:12] Fundraising Sprint Snoop (Dogg|Lion), Analytics-EventLogging, Unplanned-Sprint-Work, Patch-For-Review: Promise returned from LogEvent should resolve when logging is complete - https://phabricator.wikimedia.org/T112788#1646019 (Ejegg) [18:29:40] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, Unplanned-Sprint-Work: AstroPay audit parser failing - https://phabricator.wikimedia.org/T112779#1646271 (Ejegg) a:Ejegg [18:32:55] cwdent: http://git.wikimedia.org/blob/mediawiki%2Fvagrant/a9138bfcb04bac7626977b373011541d44fc19b4/puppet%2Fmodules%2Fpayments%2Fmanifests%2Fdonation_interface.pp#L71 [18:33:19] http://git.wikimedia.org/blob/mediawiki%2Fvagrant/a9138bfcb04bac7626977b373011541d44fc19b4/puppet%2Fmodules%2Fpayments%2Fmanifests%2Fdonation_interface.pp#L16 [18:33:37] (PS1) Cdentinger: selection weight = 0 for worldpay iframe [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238809 [18:33:40] Those two variables should be all you need to send completed messages to a local stock Redis [18:34:01] awight: awesome [18:34:19] just php5-redis package? [18:34:26] Research showcase is gonna be awesome! [18:34:39] cwdent: no, just redis [18:34:59] we use the predis client library for now, but it's pulled in by Composer. [18:35:16] oh right on [18:37:40] http://www.jornada.unam.mx/ultimas/portada/ awight, any other Spanish speakers, check out the part under "interactivo" [18:40:22] (PS1) Ejegg: Deal with stray 's' on the end of 'chargebacks' [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/238813 (https://phabricator.wikimedia.org/T112779) [18:40:47] trivial fix to the astropay audit processor if anyone wants to CR ^^^ [18:42:57] wow [18:43:12] silly, huh? [18:43:15] (CR) Awight: [C: 2] Deal with stray 's' on the end of 'chargebacks' [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/238813 (https://phabricator.wikimedia.org/T112779) (owner: Ejegg) [18:43:18] (Merged) jenkins-bot: Deal with stray 's' on the end of 'chargebacks' [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/238813 (https://phabricator.wikimedia.org/T112779) (owner: Ejegg) [18:43:21] thanks! [18:43:26] That's pretty sillys [18:43:33] hehe [18:43:52] looks like someone's got a case of the chargebacks! [18:44:27] Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, Recurring-Donations, Patch-For-Review: GC error causing donors to create multiple recurring donations - https://phabricator.wikimedia.org/T110367#1646387 (Ejegg) Leaving this open till I can make sure a... [19:01:39] (PS1) AndyRussG: bannerHistoryLogger.sendLog: use the promise from logEvent [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/238820 (https://phabricator.wikimedia.org/T112022) [19:03:03] (PS1) Ejegg: Update SmashPig to get AstroPay audit fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/238822 (https://phabricator.wikimedia.org/T112779) [19:07:11] awight: so is redis running on 61613 w/ vagrant? [19:08:14] (CR) Ejegg: [C: 2] "Looks good!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/238820 (https://phabricator.wikimedia.org/T112022) (owner: AndyRussG) [19:12:37] cwdent: uh, oh... [19:13:03] cwdent: that was way off. [19:13:04] Try, [19:13:05] 'type' => 'PHPQueue\Backend\Predis', [19:13:05] 'servers' => 'tcp://localhost', [19:13:18] Sorry, I gave you the configuration for STOMP [19:14:08] skip the 'expiry' and 'order_key'--unfortunately, order_key magically changes the queue's behavior to include FIFO traits [19:14:31] <_< [19:14:32] >_> [19:14:35] heh weird [19:14:38] * awight realized I haven't thought about this at all [19:14:48] redis quirk or something in php? [19:14:51] well, I'm to blame [19:15:21] The PHPQueue redis driver was already overloaded to give two different behaviors, so I added a third [19:15:33] It should really be a different driver class [19:16:23] ah, oh well [19:16:37] I think we actually do want to use order_key. 'order_key' => 'date' [19:16:43] awight: i see in syslog Pushing transaction to payments-init queue. [19:16:53] but i do monitor is redis and i don't see anything [19:17:03] for context... I think you would be the first one using Redis for the main queue [19:17:06] awight: I saw your ping on acl things for phab. The possibilities there has improved maybe and also releng has taken it over (read: not my team) but greg is out this week mostly so let me try to ask him what he wants to do there if that's alright [19:17:43] chasemp: ah, thanks! I'll take it up with greg-g [19:18:14] sure, fwiw there is a new security gating mechanism called "spaces" that may suit entire fundraising stuffs better [19:18:22] feel free to loop me in if you want to talk about it [19:18:53] cwdent: Those logs are a bit misleading. See DonationQueue.php, if $wgDonationInterfaceEnabledQueue is false, we silently do nothing. [19:20:24] ha ha how the eff did i miss that [19:21:48] awight: jackpot [19:21:49] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, Patch-For-Review: Associate banner history ID with contribution ID - https://phabricator.wikimedia.org/T112022#1646531 (AndyRussG) Confirmed on my local setup that the 200 ms delay (same as in the test banner on the beta cluster) is enough to g... [19:21:55] i see 2 rpushes [19:22:05] antifraud and complete [19:22:37] sweet [19:22:47] dump that json to a file, then try: [19:22:50] cd crm/drupal [19:23:31] hey cwdent awight ejegg - just thinking, if you're going to do a DI deployment today to get WorldPay form out, will that also bring along the pending Amazon stuff so we cand o the internal test there [19:23:32] ? [19:23:47] drush donations-process-messagefile [19:24:16] atgo - I've got a merge up in code review to pull all the amazon stuff into master [19:24:30] ooh exciting [19:24:36] I think cwdent was going to make sure it didn't mess up WP [19:24:52] yeah, that would sure be a drag [19:25:18] ejegg: will do, just gotta make sure the queue stuff works [19:25:28] nice! [19:25:33] awight: stupid question but is there an easy way to get json out of redis? [19:26:11] (PS2) Ejegg: Update SmashPig to get AstroPay audit fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/238822 (https://phabricator.wikimedia.org/T112779) [19:26:38] cwdent: donno, but you could run a command from the cli [19:26:47] (CR) Ejegg: [C: 2] "Self-merging library update" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/238822 (https://phabricator.wikimedia.org/T112779) (owner: Ejegg) [19:27:16] grrrit's got a funny accent today [19:27:39] or maybe that's kermit the frog filling in [19:27:54] (Merged) jenkins-bot: Update SmashPig to get AstroPay audit fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/238822 (https://phabricator.wikimedia.org/T112779) (owner: Ejegg) [19:28:34] so wait, in the simplest of english ejegg cwdent - is that a yes? [19:29:18] yes, as long as there's no problem with the merge [19:30:21] awesome!!!!! [19:30:32] * atgo gets celebratory lunch [19:33:52] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1646579 (ellery) I'll respond later with a more detailed report but here are some i... [19:34:19] (PS1) Ejegg: Update SmashPig and dependencies [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/238838 [19:34:52] awight: these entries show up as linked lists in redis and i can't "get" them [19:35:12] (CR) Ejegg: [C: 2 V: 2] Update SmashPig and dependencies [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/238838 (owner: Ejegg) [19:35:43] z... [19:36:03] um, interesting. I guess you want to leave order_key off for this debugging, but in the future we'll turn that on. [19:36:19] when order_key is set, we're storing order set data, the zset* functions [19:36:25] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/238840 [19:36:26] so use "zrange 0 -1" [19:36:33] zrange 0 -1 [19:37:53] keeps saying WRONGTYPE Operation against a key holding the wrong kind of value [19:38:28] it likes l* [19:38:31] try "TYPE key" [19:38:45] ah, you go it then [19:38:57] *got [19:39:29] XenoRyet: about to deploy crm, with the new TrilogyFile stuff [19:39:39] Cool [19:39:47] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/238840 (owner: Ejegg) [19:41:32] Thanks! [19:42:09] !log updated crm from abc34b87ee9d1dbb1176f1929a3d748e1ee5ac7b to 15ea14f61338ca9f34e9ccb9f56eae14a161380a [19:42:17] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [19:48:27] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: AstroPay audit parser failing - https://phabricator.wikimedia.org/T112779#1646625 (Ejegg) Open>Resolved [19:50:10] awight: errors decoding json. i'm guessing predis takes care of making good json? [19:50:23] No, that's us [19:50:25] paste it 4 me? [19:50:37] Maybe you have a linefeed? [19:52:29] awight: redis outputs with all the quotes escaped, should i remote the slashes? [19:52:44] *v [19:53:16] aaargh [19:53:17] yeah [19:57:02] Fundraising-Backlog: Review audit parsing, review whether existing stuff is working. (Worldpay 1 hour test) - https://phabricator.wikimedia.org/T112807#1646663 (DStrine) NEW [19:57:25] dstrine: Thanks! [19:57:28] awight: ok i got the json formatted, now i see INVALID_MESSAGE No payment instrument specified [19:57:42] probably need to fix something [19:57:43] awight: no problem [19:57:59] These tasks will be a bit "information light" [19:58:09] Fundraising-Backlog: Queue messages should be consumable. - https://phabricator.wikimedia.org/T112808#1646672 (DStrine) NEW [19:58:37] http://www.theatlantic.com/photo/2015/09/the-pope-vs-the-wind/405622/ [19:58:40] cwdent: If you wanna really get crazy, you can set up mw-vagrant and forward ActiveMQ to the host. [19:59:01] Fundraising-Backlog: Style iframe contents more if necessary. (worldpay 1hour test) - https://phabricator.wikimedia.org/T112809#1646682 (DStrine) NEW [19:59:26] seems like redis is getting the messages fine right? they're just not valid [19:59:34] Fundraising-Backlog: Queue messages should be consumable. (worldpay 1 hour test) - https://phabricator.wikimedia.org/T112808#1646672 (DStrine) [19:59:44] cwdent: It's a sign. [20:00:26] of what? [20:00:32] Fundraising-Backlog: Style iframe contents more if necessary. (worldpay 1hour test) - https://phabricator.wikimedia.org/T112809#1646682 (DStrine) [20:00:45] Fundraising-Backlog: Review audit parsing, review whether existing stuff is working. (Worldpay 1 hour test) - https://phabricator.wikimedia.org/T112807#1646714 (DStrine) [20:00:53] Diabolical, something to do with how amazing and holy marriage is for conservatives. [20:00:56] Fundraising-Backlog: Queue messages should be consumable. (worldpay 1 hour test) - https://phabricator.wikimedia.org/T112808#1646716 (DStrine) [20:01:09] Also: When the pope waves his hand with the two fingers, that means "pass--go long" [20:01:35] oh heheh, i thought you meant redis [20:01:40] yes indeed [20:01:50] the power of CHRIST compels you [20:03:41] how ready is this? https://phabricator.wikimedia.org/T101191 [20:03:57] Major gifts has mentioned this as a blocker a couple times this week [20:03:57] awight: i should probably just find out why payment instrument isn't set? [20:04:49] dstrine: just deployed it! [20:04:54] ?!?!?!? [20:04:58] really ?! [20:05:12] yep - XenoRyet, want to take a look at prod? [20:05:20] cwdent: might as well [20:05:33] Yea, let me do that. [20:06:18] awight: if this blocks the test i think it's going to get pushed back a ways [20:06:36] whole new area of the code for me [20:06:56] thanks ejegg: and XenoRyet: [20:08:04] cwdent: i'll take a look too [20:08:26] couldn't it just be missing data in my local db? [20:08:45] looking at wmf_civicrm_get_message_payment_instrument [20:09:13] did the queue message have payment_method set? [20:09:22] and / or payment_submethod? [20:09:45] yep, cc [20:09:59] submethod visa [20:10:11] well that sounds right [20:10:29] but if i don't have all the payment instruments from live maybe it can't find a match? [20:10:36] could be! [20:10:41] * cwdent doesn't actually know what payment instruments are [20:10:52] We /should/ have scripted all those up in the crm install [20:11:03] let's see what's in your db [20:11:21] they're in i think the civicrm_option_value table [20:11:25] cwdent: oh, are you saying you ran the import? [20:11:33] musical payment instruments [20:11:42] awight: yeah [20:11:57] If it kicks out the message with a non-fatal error, we're good to go. [20:12:33] so just figure out the option group id - select * from civicrm_option_group where name like '%instrument%' [20:13:09] cwdent: Have you updated the Drupal db, ever? [20:13:15] yeah i have a bunch of them [20:13:22] payment instruments that is [20:13:36] hmm yeah I guess you must have updated when installing the wmf_civicrm module in the first place. [20:13:38] but yeah awight the error was handled [20:13:46] ejegg: Production civi isn't taking my usual usernames. I'm guessing it has its own set of accounts that I just never got set up for? [20:14:03] XenoRyet: ah, yep. Plus a client cert you have to install in the browser [20:14:17] cwdent: If you want to dig into the pathology, wmf_civicrm_get_message_payment_instrument [20:14:28] It likes the cert I have just fine, just don't have a login I think. [20:14:40] XenoRyet: I'll check for an account [20:14:47] Thanks [20:14:53] awight: yeah i'll check it out [20:15:13] but is it worth waiting on or should be move forward with the test and i'll fix this in the interim? [20:15:36] cwdent: we can do the internal test like this [20:16:16] ok, imma merge ejegg's merge then [20:16:24] woohoo! [20:17:02] this one should probably go too https://gerrit.wikimedia.org/r/#/c/238809/ [20:17:35] (CR) Awight: [C: 2] selection weight = 0 for worldpay iframe [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238809 (owner: Cdentinger) [20:17:54] ty! [20:18:01] (Merged) jenkins-bot: selection weight = 0 for worldpay iframe [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238809 (owner: Cdentinger) [20:18:25] oh actually this one too, renames a js file https://gerrit.wikimedia.org/r/#/c/238546/ [20:18:44] and since we cache html for a month i'm guessing that's a no no [20:19:08] nah, paymentswiki isn't cached at all, AFAIK [20:19:18] (PS5) Awight: Stylesheet for Worldpay. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238546 (owner: Cdentinger) [20:19:30] (PS1) Zfilipin: Updated watir-webdriver Ruby gem to the latest version [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/238851 (https://phabricator.wikimedia.org/T112748) [20:19:57] (CR) Awight: [C: 2] Stylesheet for Worldpay. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238546 (owner: Cdentinger) [20:20:36] Fundraising-Backlog: [epic] Worldpay campaign ready in France - https://phabricator.wikimedia.org/T110114#1646806 (DStrine) [20:21:01] (Merged) jenkins-bot: Stylesheet for Worldpay. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238546 (owner: Cdentinger) [20:22:46] ejegg: i am confused by this merge commit...where are all the changes? [20:23:02] +2, -76 [20:23:17] you'll only see diffs for conflict resolution [20:24:59] oh ok [20:25:06] but this has all the patches as deps? [20:25:27] yep, +2 this and it'll merge in everything I listed in the commit msg [20:29:28] ejegg: i get some conflicts when i try to rebase onto master [20:29:38] from the merge PS [20:29:53] error: could not apply 7a2590b... Clear out old Amazon code to prepare for PwA [20:31:00] ah crap [20:31:05] i'll redo it locally [20:31:18] awight, ejegg something i just thought of [20:31:56] since the new WP form can be reached without the ffname (since it gets set automatically) it will be the same link as last time WP was active [20:32:07] it could be in someone's browser history [20:32:12] or indexed by robots [20:32:47] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, Unplanned-Sprint-Work, I18n, Patch-For-Review: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1646846 (atgo) a:awight [20:33:14] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, Patch-For-Review: Associate banner history ID with contribution ID - https://phabricator.wikimedia.org/T112022#1646847 (atgo) a:AndyRussG [20:33:18] it's been a good long time since WP was turned off [20:33:33] cwdent: Good call. Maybe we'll catch a ghost [20:34:23] i'll keep a close eye on the log [20:36:56] (PS1) Ejegg: Merge branch 'amazon' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238866 [20:37:46] (Abandoned) Ejegg: Merge branch 'amazon' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238803 (owner: Ejegg) [20:38:37] cwdent: ok, the new one ought to be merge-able https://gerrit.wikimedia.org/r/238866 [20:39:00] ejegg: cool, thanks! have a couple very recent things on master [20:39:52] Fundraising-Backlog: Sprint U goal: - https://phabricator.wikimedia.org/T112816#1646877 (atgo) NEW [20:40:23] yah, anyway, the merge wasn't too painful to redo [20:40:34] Fundraising-Backlog: Sprint X goal: - https://phabricator.wikimedia.org/T112816#1646886 (atgo) [20:44:17] Fundraising-Backlog: [EPIC] Amazon post campaign ready - https://phabricator.wikimedia.org/T112817#1646912 (DStrine) [20:45:01] ejegg: i just need to add name and email to req fields on my branch and everything works [20:45:04] so imma hit merge [20:45:07] then do that on master [20:46:13] nice! [20:47:01] (CR) Cdentinger: [C: 2] Merge branch 'amazon' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238866 (owner: Ejegg) [20:48:22] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1646933 (Ottomata) Ellery, call to your Senator and tell her you want a realtime st... [20:50:14] (Merged) jenkins-bot: Merge branch 'amazon' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238866 (owner: Ejegg) [20:51:21] (PS1) Cdentinger: add name and email to required fields for WP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238958 [20:52:58] wait a minute [20:53:08] it's a grrrit-wm imposter [20:53:51] hi [20:54:56] hi Alejandra [20:55:02] (CR) Ejegg: "let's have both fname and lname required. Adding 'name' and 'email' to the validation node of the payment methods (see astropay) will get" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238958 (owner: Cdentinger) [20:55:12] hi a todos [20:56:02] (CR) XenoRyet: [C: 2] "This patch looks fine to me, and your suggested path forward makes sense." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/238326 (https://phabricator.wikimedia.org/T112590) (owner: AndyRussG) [20:56:21] como estan todos [20:56:34] bien, gracias! [20:56:44] mmm me alegra [20:56:47] muchisimo [20:59:45] (PS1) Ejegg: Minor Amazon formatting cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238961 [21:00:46] (PS2) Cdentinger: add name and email to required fields for WP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238958 [21:01:25] aquiel abla español.? [21:01:44] (CR) Ejegg: [C: 2] "Looks good!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238958 (owner: Cdentinger) [21:02:06] (Merged) jenkins-bot: add name and email to required fields for WP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238958 (owner: Cdentinger) [21:03:04] it's all coming together! [21:03:24] (CR) XenoRyet: [C: 2] Subscribing JS: remove proxy methods on cn object [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237418 (owner: AndyRussG) [21:04:34] Alejandra: [21:05:02] ¿Qué pasó? [21:05:14] XenoRyet: thanks!! [21:06:03] No worries. Looking at the TTL one now. [21:07:29] XenoRyet: :) [21:08:46] awight: i notice that 0293617c17d9c236267043531de2224df77c0838 deleted a file that breaks DonationInterface_Adapter_GlobalCollect_Orphans_GlobalCollectTest [21:11:10] (PS2) Cdentinger: Minor Amazon formatting cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238961 (owner: Ejegg) [21:12:20] (CR) Cdentinger: [C: 2] Minor Amazon formatting cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238961 (owner: Ejegg) [21:12:48] (Merged) jenkins-bot: Minor Amazon formatting cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/238961 (owner: Ejegg) [21:13:13] ejegg: you have reason to wait on this deploy? [21:13:28] nope! [21:13:41] https://en.wikipedia.org/wiki/Wikipedia:Be_bold [21:13:42] old amazon's logic's been off for a few weeks [21:14:05] I'll get the amazon credentials ready on the deploy box [21:14:20] ok, i just have one localsettings change too [21:14:33] you want to do that first? [21:14:38] I need to look this stuff up [21:14:42] sure, just edit the file? [21:15:01] cwdent: Can you tell which file that was? Are CI tests breaking? [21:15:07] yeah.... we'll have it in version control soon! [21:15:36] awight: it was globalcollect_gateway/scripts/orphan_adapter.php [21:15:52] ah, that was renamed [21:15:53] as far as CI...i would think so but i guess not? [21:16:16] and the old filename might still be in your vendor classmap [21:16:27] doh, that must be it [21:16:34] ejegg: awight: cwdent: XenoRyet: for purposes of the contribution tracking ID part of this task https://phabricator.wikimedia.org/T112022 is it useful for me to run a vagrant-based DI? What can I do or should I learn to work on that? [21:16:45] my bad [21:17:07] AndyRussG: I don't know if you need to worry too much about what happend to the parameter after you throw it over the fence! [21:17:15] ^ that :) [21:17:26] Unless you want to get out of CN land for a bit? [21:17:52] ejegg: awight: hmmm yes I was thinking this was my chance to make a break for the hole in the fence [21:18:05] (having passed up more than a few so far...) [21:18:34] the part of that task involving tossing the parameter is done for now, I think [21:19:08] Basically, if the navegator doesn't support sendBeacon, you get a 200 ms delay, and that's it [21:19:25] And it's probably enuf for the log to be sent [21:19:47] ok! [21:19:50] cool! Yeah, vagrant will be the quickest way to get going [21:20:19] ejegg: awight: great! Yeah I wasn't even sure if the tables mentioned were DI tables... [21:20:34] (...provisioning right now...) [21:21:21] They're created by the ContributionTracking extension, which is a dependency of DonationInterface [21:22:04] (PS11) AndyRussG: WIP Banner diet mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (owner: Awight) [21:22:14] awight: ah K [21:25:26] cwdent: ok, editing localsettings [21:26:31] we should get some scary default prompts on the production boxen [21:26:42] heh, yeah [21:27:22] you just need WorldpayGatewayEnabled set to true, right? [21:27:24] ☠☠☠ [21:27:33] heh, nice [21:27:35] oh, that too [21:27:45] you wanna do that while you're in there? [21:27:49] i had to change the account number [21:28:05] ok, i'll let you know when i've got amazon all sorted [21:28:27] cool [21:28:47] be sure not to ggVG:wq [21:29:03] or ggVGd:wq i mean [21:29:24] Just get in the habit of typing ZZ all the time [21:30:51] the thing i miss with ZZ Is there's no analog to :q [21:33:35] sprint planning ya'll? [21:37:32] sorry, hangouts is taking forever to load [22:04:02] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog: MW-Vagrant CRM role needs maintenance - https://phabricator.wikimedia.org/T110372#1647168 (awight) a:awight>None [22:06:15] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, Analytics-EventLogging, Unplanned-Sprint-Work, Patch-For-Review: Promise returned from LogEvent should resolve when logging is complete - https://phabricator.wikimedia.org/T112788#1647179 (atgo) [22:06:17] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, MediaWiki-extensions-CentralNotice: [Mini epic] Activate Banner History! - https://phabricator.wikimedia.org/T112020#1647181 (atgo) [22:06:20] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Patch-For-Review: Fix error for non-ECMA5 browsers in ext.centralNotice.display - https://phabricator.wikimedia.org/T112590#1647180 (atgo) [22:08:45] (PS1) Ejegg: Add Amazon SDK [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/238984 [22:11:36] (PS1) Ejegg: Add Pay with Amazon SDK [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/238986 [22:11:53] (CR) Ejegg: [C: 2 V: 2] Add Pay with Amazon SDK [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/238986 (owner: Ejegg) [22:12:28] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog: MW-Vagrant CRM role needs maintenance - https://phabricator.wikimedia.org/T110372#1647209 (awight) Open>Resolved a:awight Subtasks are looking pretty good. [22:14:49] Fundraising-Backlog: Style iframe contents more if necessary. (worldpay 1hour test) - https://phabricator.wikimedia.org/T112809#1647226 (DStrine) [22:16:11] Fundraising-Backlog: Queue messages should be consumable. (worldpay 1 hour test) - https://phabricator.wikimedia.org/T112808#1647227 (DStrine) [22:16:47] Fundraising-Backlog: Review audit parsing, review whether existing stuff is working. (Worldpay 1 hour test) - https://phabricator.wikimedia.org/T112807#1647228 (DStrine) [22:17:14] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog: Sprint S Goal: worldpay internal test and continue Amazon - https://phabricator.wikimedia.org/T107347#1647230 (DStrine) Open>Resolved [22:26:14] !log updated SmashPig from fdb053efa617162ac9f695e493c390987a069140 to d5895428d1d8ebc5a6e172e8cdec6dbec0b10d85 [22:26:22] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:30:16] (PS1) Cdentinger: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/238989 [22:46:46] ummm google tells me I'm not allowed to join the call :/ [22:46:50] after like 90 minutes [22:47:21] I'm gonna have to disappear any minute, btw [22:47:35] I can't get back into the hangout [22:47:50] what's in the hangout? [22:48:02] * awight nervously looks around for more meetings [22:48:17] cwdent: and ejegg: how close are you to closing all those tasks in snoop dog? [22:48:23] * dstrine-meeting loves the sentence above [22:48:42] http://weirdestbandintheworld.com/2010/01/18/hatebeak/ [22:48:45] *dogg [22:49:14] lol hatebeak [22:49:24] dstrine-meeting: pretty close, about to merge the merge [22:49:40] (CR) Ejegg: [C: 2] "All systems go!" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/238989 (owner: Cdentinger) [22:50:06] ok just ping me [22:50:26] I'm listening to hatebeak .... um it's interesting [22:50:51] hehe [22:50:55] (PS1) Ejegg: Update DonationInterface for deploy [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/238994 [22:51:30] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface for deploy [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/238994 (owner: Ejegg) [22:51:43] Fundraising-Backlog: CRM consumers should be able to read from Redis - https://phabricator.wikimedia.org/T112832#1647403 (awight) NEW [22:51:53] ejegg: DI is a submodule on payments yeah? [22:52:23] cwdent: yep, a mediawiki-core submodule only on the fundraising/REL1_25 branch of core [22:52:26] http://www.metalunderground.com/news/details.cfm?newsid=12898 [22:52:57] we should be all set to fundraising_code_update and rsync_blast [22:53:09] far out [22:53:11] want me to do it? [22:53:22] sure! [23:03:55] !log updated payments from 9fc8ab40b7f70c7b588c2b9e7b5c94b1f893faa1 to 155cdeb737c01baf62551292764fd2f5a93a9a63 [23:04:03] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:04:37] (PS2) Awight: Update to the 20150904 thank you letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/238365 (https://phabricator.wikimedia.org/T110232) [23:06:38] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, Unplanned-Sprint-Work, I18n, Patch-For-Review: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1647443 (awight) Thanks for all the clarification! The new changeset with updated pt-br lin... [23:09:27] XenoRyet: did you ping a major gifts person to check the import? [23:10:33] Not yet. I was going to kick it myself first, but was unsure of fake data on production. [23:10:57] kk [23:11:00] egegg suggested we deploy it on staging for that purpose, but then I got distracted and I think he dug into this bigger deploy. [23:11:23] If someone from major gifts wants to test it though, I have no objections. [23:13:29] gotta go! [23:14:53] dstrine: Think I should just ping somebody about it? ccogdill maybe? It was her phab task to start with. [23:15:24] XenoRyet I won’t be managing the import [23:15:39] Ah, probably not you then. [23:15:44] I’m just pm-ing this for them… Leanne will be doing the import so I’d have her do it [23:16:04] Well it is deployed if she wants to take a look. [23:16:09] k cool, I’ll ping her [23:16:10] thanks! [23:16:15] No worries [23:16:25] Have her let me know if she sees any weirdness. [23:16:44] Ah thanks ccogdill: I was just going to ping a bunch of people :) [23:16:54] :) [23:17:15] I basically live on the contact page:https://office.wikimedia.org/wiki/Contact_list [23:17:29] I'm just constantly looking up IRC nicknames [23:18:29] major gifts isn’t good at being on IRC, sadly [23:18:42] so I’m going to email her and ping her on the phab task [23:20:37] Fundraising Sprint Queen, Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint The Pogues, and 2 others: Set up import for Major Gifts events payment/invitation tool - https://phabricator.wikimedia.org/T101191#1647479 (CCogdill_WMF) @LeanneS - @XenoRyet just... [23:49:34] (PS1) Ejegg: Log all Amazon SDK calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239004 [23:50:17] XenoRyet: care to ogle a logging patch? ^^^ [23:50:28] Sure [23:50:35] thanks! [23:52:23] (PS1) Cdentinger: handle return result and maybe show fail page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239005 [23:52:52] ejegg: i think that one should show the fail page on fail, but i don't know how to make the test server fail :P [23:53:13] so i can't actually confirm [23:59:51] hmm