[00:00:02] cwdent: taking a look [00:00:27] and man, it would be nice to be able to test for error conditions [00:00:47] srsly [00:01:27] (CR) XenoRyet: [C: 2] Log all Amazon SDK calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239004 (owner: Ejegg) [00:01:38] ejegg: Looks good [00:01:50] (Merged) jenkins-bot: Log all Amazon SDK calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239004 (owner: Ejegg) [00:04:21] (CR) Ejegg: [C: 2] "Ought to do the trick! There's a 'goToThankYouOn' array that you could use here, but it looks like we're only doing that for GC. TODO: a" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239005 (owner: Cdentinger) [00:04:57] thanks XenoRyet ! [00:04:58] (Merged) jenkins-bot: handle return result and maybe show fail page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239005 (owner: Cdentinger) [00:05:24] cwdent: we don't have a card for de-duping the resultswitcher code for iframes etc, do we? [00:06:55] ejegg: i don't think there's one yet but there should be [00:07:05] k, making one [00:07:50] thanks! [00:11:16] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: De-duplicate result switcher code - https://phabricator.wikimedia.org/T112839#1647669 (Ejegg) NEW [00:11:22] ejegg: how soon do we need to do that task? [00:11:45] dstrine: not urgent, just a code cleanup thing [00:12:00] kk thanks [00:12:06] so not this next sprint? [00:12:21] not unless we get bored [00:13:33] lol with almost 50 SP of work I don't think that'll happen [00:13:41] thanks for the info [00:13:54] dstrine, atgo - I forgot to ask for the Amazon API endpoints to be whitelisted before Jeff_Green signed off. Got a request to him in phab, so hopefully we can do amazon internal test tomorrow [00:16:09] ok so we can't resolve the amazon stuff in the "pending deployment" column in snoop dogg? [00:16:50] dstrine: well, it's deployed! [00:17:00] just neutered for now [00:18:07] kk let's count is in sprint Tom Waits [00:18:23] cwdent: is the worldpay stuff closeable [00:24:09] (PS1) Cdentinger: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/239011 [00:24:20] dstrine: a few minutes from finding out [00:24:46] dstrine: sorry yeah what ejegg said [00:24:52] cwdent: ah dang, didn't get the amazon logging patch? [00:25:26] damn, lemme do that [00:27:16] (PS1) Cdentinger: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/239012 [00:27:37] (Abandoned) Cdentinger: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/239011 (owner: Cdentinger) [00:27:56] (CR) Ejegg: [C: 2] "thanks!" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/239012 (owner: Cdentinger) [00:28:33] ejegg: yeah i need to get a workflow for my extensions dir vs. the different projects [00:28:40] (PS1) Ejegg: Update DI submodule for deploy [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/239013 [00:28:56] heh, i just have a little script to swap em [00:29:12] mv extensions extensions.local [00:29:20] mv extensions.deploy extensions [00:29:26] and then vice-versa [00:30:30] nice [00:30:49] a unified tool for that stuff, submodules, localsettings would be grand [00:31:04] yah [00:31:30] and very useful for like...5 people [00:31:49] :P [00:32:14] hey, it could be good for other folks developing extensions! [00:32:39] yeah true, if we made it nice and general [00:32:50] some yaml file describes the differences between prod and dev [00:32:59] (CR) Ejegg: [C: 2 V: 2] Update DI submodule for deploy [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/239013 (owner: Ejegg) [00:33:06] ok, ready to roll [00:33:12] ok, hitting it [00:35:39] oh, please !log after you rsync [00:35:44] !log updated payments from 155cdeb737c01baf62551292764fd2f5a93a9a63 to 1bdd287b083032ff418434ad6bb6920735af918a [00:35:50] thanks! [00:35:52] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:35:54] :) [00:36:27] oops, i totally missed you doing that the last time... [00:36:39] fail page works [00:36:41] holla [00:36:43] woohoo! [00:37:27] ok, i'm going to sign off for now - nothing more I can do on amazon till i get mws whitelisted [00:37:31] see ya! [00:38:03] have a good one! [00:38:37] oooh fail page [00:39:03] so is that it for worldpay? [00:39:30] dstrine: yeah i think so, atgo's gonna try another [00:39:39] cool [00:40:47] atgo: ^ [00:41:14] fail page failed! [00:41:17] dstrine: cwdent [00:42:02] atgo: ...good fail or bad fail? [00:42:06] good fail [00:42:10] * cwdent wipes brow [00:42:12] failed when it should've [00:42:21] * atgo realizes that previous comment was confusing [00:42:26] way to crush it cwdent! [00:43:02] thanks! [00:43:09] did you get another successful one through? [00:43:59] wow so we can close all those worldpay tasks in snoop dog? [00:44:45] ugh. snoop. [00:44:58] cwdent: let me try again [01:04:11] cwdent: do you think we can close those tasks? I also don't want to bug if you are actively working through stuff. [01:05:07] dstrine: i think it's cool to close em, the stuff they relate to is working as described but we are having some avs/cvv weirdness that is buried in the fraud check code somewhere [01:07:41] ok thanks [01:07:58] Fundraising-Backlog: [epic] Internal testing with French credit cards - https://phabricator.wikimedia.org/T110112#1647765 (DStrine) [01:07:59] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog: worldpay internal test: Store donor info in a limbo or pending queue - https://phabricator.wikimedia.org/T110425#1647764 (DStrine) Open>Resolved [01:08:09] Fundraising-Backlog: [epic] Internal testing with French credit cards - https://phabricator.wikimedia.org/T110112#1569244 (DStrine) [01:08:10] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog: worldpay internal test: Add forms to form chooser settings - https://phabricator.wikimedia.org/T110426#1647767 (DStrine) Open>Resolved [01:08:16] Fundraising-Backlog: [epic] Internal testing with French credit cards - https://phabricator.wikimedia.org/T110112#1569244 (DStrine) [01:08:18] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog: worldpay internal test:Display Iframe - https://phabricator.wikimedia.org/T110423#1647771 (DStrine) Open>Resolved [01:08:24] Fundraising-Backlog: [epic] Accept credit cards in France via Enhanced Silent Order Post - https://phabricator.wikimedia.org/T110111#1647775 (DStrine) [01:08:32] Fundraising-Backlog: [epic] Internal testing with French credit cards - https://phabricator.wikimedia.org/T110112#1569244 (DStrine) [01:08:33] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog: worldpay internal test: Make API requests to get iframe URL - https://phabricator.wikimedia.org/T110422#1647777 (DStrine) Open>Resolved [01:08:40] Fundraising-Backlog: [epic] Internal testing with French credit cards - https://phabricator.wikimedia.org/T110112#1569244 (DStrine) [01:08:41] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog: worldpay internal test: Write controller logic to handle return from iframe - https://phabricator.wikimedia.org/T110424#1647781 (DStrine) Open>Resolved [01:09:15] dstrine: also i think several of those were still marked 0, they can all be 1's as far as i'm concerned [01:09:57] ok ... adding hassle cost :) [01:10:06] :) [01:10:08] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog: worldpay internal test: Write controller logic to handle return from iframe - https://phabricator.wikimedia.org/T110424#1577556 (DStrine) [01:10:16] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog: worldpay internal test: Store donor info in a limbo or pending queue - https://phabricator.wikimedia.org/T110425#1647795 (DStrine) [01:10:23] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog: worldpay internal test: Add forms to form chooser settings - https://phabricator.wikimedia.org/T110426#1647796 (DStrine) [01:11:03] I'm about to blow up your inboxes [01:11:12] moving things to sprint Tom Waits [01:11:20] BOOM [01:11:26] congrats on testing this!!! [01:11:27] http://media.tumblr.com/tumblr_m8f12pUE9K1r30m4f.gif [01:12:16] Fundraising Sprint Tom Waits, Fundraising-Backlog: Style iframe contents more if necessary. (worldpay 1hour test) - https://phabricator.wikimedia.org/T112809#1647798 (DStrine) [01:12:17] Fundraising Sprint Tom Waits, Fundraising-Backlog: Review audit parsing, review whether existing stuff is working. (Worldpay 1 hour test) - https://phabricator.wikimedia.org/T112807#1647800 (DStrine) [01:12:18] Fundraising Sprint Tom Waits, Fundraising-Backlog: Queue messages should be consumable. (worldpay 1 hour test) - https://phabricator.wikimedia.org/T112808#1647799 (DStrine) [01:12:21] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: Fix error for non-ECMA5 browsers in ext.centralNotice.display - https://phabricator.wikimedia.org/T112590#1647802 (DStrine) [01:12:23] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Configure new CiviCRM staging instance for testing 4.6 upgrade - https://phabricator.wikimedia.org/T112314#1647803 (DStrine) [01:12:53] Fundraising Sprint Queen, Fundraising Sprint ODB, Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), and 5 others: Banner history mixins and data - https://phabricator.wikimedia.org/T90918#1647828 (DStrine) [01:18:34] dstrine: was "step right up" an intentional tom waits reference? [01:18:55] did you see the youtube link? [01:19:05] oh [01:19:10] * cwdent actually opens the email [01:19:25] good one tho [01:19:25] the video is totally dumb [01:19:48] ugh, fanvid [01:20:20] just keep it on a separate tab and do something else [01:21:35] i once bothered to learn all the words to that song even though it's totally improvised [01:21:39] can i just say that i'm glad that we are done with the snoop sprint, as it'll just serve of a constant reminder of what my wednesday could've been. [01:21:42] * atgo sulks [01:21:56] :( [01:22:17] i once paid $1000 to see tom waits live [01:22:41] outing myself as a huge loser, nbd [01:24:19] wow! [01:24:23] I would love to see him [01:25:27] apparently he and Tom petty had cabins near mine in like the early-mid 90s and they would play at the bar in town [01:25:41] they'd just show up randomly [01:25:54] damn that would be amazing [01:26:03] afaik he lives in sonoma county so that checks out [01:26:09] It was a while ago. It's like the last cool thing that happened up there [01:26:47] hang on, there's cool stuff in sonoma [01:26:53] I'm a fan too. I have raindogs and small change on vinyl [01:28:06] yeah sonoma county has stuff (where he lives) but my cabin is deep in truck nuts territory near yosemite [01:39:18] hehe, truck nuts territory [01:39:33] for realz [01:39:33] ok well I'm going to head out [01:39:40] cwdent: thanks and congrats [01:39:43] yep me too [01:39:48] thanks dstrine ! [01:39:50] is this ok to revisit tmorrow? [01:39:52] oh good [01:39:57] yeah definitely [01:40:01] great [01:40:05] i'll comb the logs [01:40:07] have a good one [01:40:23] aight seeya [06:12:59] (CR) Siebrand: [C: 1] "i18n/L10n reviewed." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (owner: Awight) [08:44:49] Fundraising-Backlog, fundraising-tech-ops: Spike: How to configure a staging server for payments? - https://phabricator.wikimedia.org/T112857#1648333 (awight) NEW [08:45:06] Fundraising-Backlog, fundraising-tech-ops: Spike: How to configure a staging server for payments? - https://phabricator.wikimedia.org/T112857#1648341 (awight) [08:45:08] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Adjustable load balancer to direct small samples of donors to staging payments - https://phabricator.wikimedia.org/T97745#1648340 (awight) [08:51:36] Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, and 2 others: Adding 1 Custom field to "primary fields" export list: Do Not Solicit - https://phabricator.wikimedia.org/T105918#1648358 (awight) @CaitVirtue: Thanks for taking... [09:00:25] Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, and 2 others: Adding 1 Custom field to "primary fields" export list: Do Not Solicit - https://phabricator.wikimedia.org/T105918#1648379 (awight) And a contribution export has..... [10:51:36] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work, and 2 others: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1648613 (jrobell) thank you @awight! The pt-br letter looks fine to me now... [12:48:51] TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team: [WMDE-Fundraising] Request CentralNotice adminship rights - https://phabricator.wikimedia.org/T112059#1648821 (kai.nissen) [12:49:23] TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team: [WMDE-Fundraising] Request CentralNotice adminship rights - https://phabricator.wikimedia.org/T112059#1623983 (kai.nissen) [13:17:42] fundraising-tech-ops, Traffic, operations, IPv6, Patch-For-Review: Enable IPv6 on donate.wikimedia.org - https://phabricator.wikimedia.org/T73267#1648879 (BBlack) Are we still good to go for this? I had planned to push this change Tues or Weds, but finally have some time to come back around to i... [13:24:53] fundraising-tech-ops, Traffic, operations, IPv6, Patch-For-Review: Enable IPv6 on donate.wikimedia.org - https://phabricator.wikimedia.org/T73267#1648900 (jrobell) @BBlack thanks for the update. There was an email sent out to Italy donors this morning that might be affected by this deployment.... [13:26:26] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work, and 2 others: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1648911 (Pcoombe) All looks good to me too. Thanks @awight. [14:28:51] Good morning all [14:57:40] (CR) Ejegg: "Functionality looks good! Please update param names in doc comment ( and maybe spacing in parens )." (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (owner: Awight) [14:59:00] Hi Jeff_Green! I deployed some stuff for the new Amazon donation flow yesterday evening, but I think I need their API whitelisted to make it work. [14:59:29] where was it deployed? [14:59:38] payments-wiki [14:59:57] and there will be another thing on barium that will need to talk to the same endpoint [15:00:00] ok. i saw the ticket but I haven't looked at it yet [15:00:20] oh shoot, i should look up the IP range that url resolves to, if they've got that in docs [15:00:25] I'll add that to the ticket [15:00:38] iirc amazon is absolutely insane when it comes to whitelisting [15:00:57] ah man, they don't have a very compact address range, huh? [15:00:59] they don't seem to make any effort to segment their network between customers and corporation [15:01:09] no, not at all [15:02:10] yeah, i guess that's a consequence of them basically just renting out idle bits of their own infrastructure [16:22:18] Fundraising-Backlog: [EPIC] Amazon (embedded) internal test - https://phabricator.wikimedia.org/T108102#1649680 (Ejegg) [16:38:00] Fundraising-Backlog: Sprint W goal: - https://phabricator.wikimedia.org/T112816#1649807 (atgo) [16:44:39] fundraising-tech-ops, Traffic, operations, IPv6, Patch-For-Review: Enable IPv6 on donate.wikimedia.org - https://phabricator.wikimedia.org/T73267#1649822 (CCogdill_WMF) @BBlack no emails will be going out for the rest of the week, so today or tomorrow would be great. I'm assuming gerrit or somet... [16:47:13] (CR) Ejegg: "What's up with all the deleted languages? Do we prefer sending out email in a fallback language to sending out an older translation?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/238365 (https://phabricator.wikimedia.org/T110232) (owner: Awight) [16:52:49] Fundraising-Backlog, Epic: [epic] Support language variants throughout donation pipeline - https://phabricator.wikimedia.org/T96594#1649876 (DStrine) [16:53:06] Fundraising-Backlog, Epic: [epic] Support language variants throughout donation pipeline - https://phabricator.wikimedia.org/T96594#1221549 (DStrine) [17:39:19] (CR) Awight: "Yeah, I'm almost certain this is what fr-creative wants. I'll add a note in the task!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/238365 (https://phabricator.wikimedia.org/T110232) (owner: Awight) [17:41:18] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work, and 2 others: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1650035 (awight) Just a reminder that we're losing some languages here, due... [17:42:58] guys do we have a task for the IPN failures for paypal? [17:43:45] the only thing in our backlog is: https://phabricator.wikimedia.org/T107384 [17:43:53] it's in unscheduled [17:44:22] yeah that's not hte one, i'm talking abou the bug from yesterday morning [17:44:26] where we all got all the fail-spam [17:44:34] awight ejegg cwdent XenoRyet AndyRussG? [17:44:53] atgo: ooh yeah I dropped that one like it was hot [17:44:58] No task yet! [17:45:01] hi awight! [17:45:03] * AndyRussG 's ignorant [17:45:08] * AndyRussG waves [17:45:08] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work, and 2 others: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1650059 (MeganHernandez_WMF) Hey @awight if we have last year's Lila letter... [17:45:10] ugh. snoop. [17:45:17] aww [17:45:21] :( [17:46:10] ejegg: aftermornoon! [17:47:18] awight, I put some comments on a couple of your patches, but was too shy to -1 [17:47:42] oh wait, you just responded :P [17:48:36] (Abandoned) Ejegg: Add Amazon SDK [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/238984 (owner: Ejegg) [17:49:04] awight: do we need a task for the IPN issue? [17:49:35] (PS3) Awight: Update to the 20150904 thank you letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/238365 (https://phabricator.wikimedia.org/T110232) [17:50:39] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work, and 2 others: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1650085 (awight) @MeganHernandez_WMF Great, thanks for the confirmation. T... [17:51:12] dstrine: Definitely. It's something we should keep a record of. [17:51:28] I can make that... [17:51:56] Fundraising-Backlog: donatewiki access for Trilogy - https://phabricator.wikimedia.org/T110038#1650105 (atgo) @awight i'm talking to @meganhernandex_wmf right now. The images are hosted on commons, but for size tweaks & such it's much easier for them if it's on donatewiki. @pcoombe has been doing lots of ine... [17:53:44] Fundraising-Backlog: Paypal audit can fail and generate massive amounts of fail mail - https://phabricator.wikimedia.org/T112919#1650111 (DStrine) NEW [17:54:14] made a task: https://phabricator.wikimedia.org/T112919?workflow=create [17:54:17] in backlog [17:57:19] ejegg: Thanks for asking about the translations! I updated https://wikitech.wikimedia.org/wiki/Fundraising/Translation as a reminder for next year. [17:58:05] nice [17:58:45] (Abandoned) Ejegg: Minor Amazon formatting cleanup [extensions/DonationInterface] (amazon) - https://gerrit.wikimedia.org/r/238603 (owner: Ejegg) [17:59:40] Fundraising-Backlog: donatewiki access for Trilogy - https://phabricator.wikimedia.org/T110038#1650126 (awight) I can relent on this, we do trust Trilogy, I'm just pushing back as a matter of limiting the potential for accidents, and clarifying process. This is still a pretty hand-wavy rationale, can someon... [18:04:23] Fundraising-Backlog: Backfill from Aug 25-Sept 17 PayPal audit outage - https://phabricator.wikimedia.org/T112920#1650136 (awight) NEW [18:05:23] Fundraising-Backlog: Paypal IPN processing is broken - https://phabricator.wikimedia.org/T112919#1650144 (awight) [18:11:21] Fundraising-Backlog: [EPIC] Banner history post launch - https://phabricator.wikimedia.org/T112923#1650175 (DStrine) NEW [18:13:36] AndyRussG: I'm jiggling banner history task dependencies a bit, I'll keep you posted... [18:13:56] Moving banner history ID -> contribution association to the next epic [18:14:04] awight: hrm? OK... I'm combing over ur patch finally, also... :) [18:14:24] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Patch-For-Review: Associate banner history ID with contribution ID - https://phabricator.wikimedia.org/T112022#1650199 (awight) [18:14:25] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: [Mini epic] Activate Banner History! - https://phabricator.wikimedia.org/T112020#1650198 (awight) [18:14:45] awight: sorry which epic? [18:14:46] Fundraising-Backlog: [EPIC] Banner history post launch - https://phabricator.wikimedia.org/T112923#1650203 (awight) [18:14:48] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic, Patch-For-Review: [epic] Banner History MVP - https://phabricator.wikimedia.org/T78089#1650202 (awight) [18:15:11] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Patch-For-Review: Associate banner history ID with contribution ID - https://phabricator.wikimedia.org/T112022#1622923 (awight) [18:15:11] Fundraising-Backlog: [EPIC] Banner history post launch - https://phabricator.wikimedia.org/T112923#1650175 (awight) [18:15:42] ejegg: the amazon 1 hour test is almost ready right? you were just waiting on one thing today? [18:15:43] ah hmm [18:15:55] AndyRussG: dstrine just created an epic to make it clear what's blocking the next BH milestone (activate on a campaign) from the next cleanup steps [18:15:58] dstrine: well, the internal test at least! [18:16:25] awight: I don't understand [18:17:32] AndyRussG: I just moved T112022 from blocking https://phabricator.wikimedia.org/T112020 to blocking https://phabricator.wikimedia.org/T112923 [18:17:37] ejegg: ah sorry [18:17:42] dstrine: I'm about to make a card for handling communications errors better - right now if some unexpected error (e.g. firewall probs) falls through the cracks, the overlay goes away with no explanation [18:17:59] yeah ok [18:18:26] Pretty sure this reflects something we were already talking about, that we should start collecting banner history before worrying about the association with donations. [18:19:34] AndyRussG: Does that sound right to you? [18:20:19] AndyRussG: Awight: and I were thinking it might be good to have an epic that we can use to descope issues and stay focused on what is needed to put the first version live. I'm not able to make the call or what gets punted. I just made an organizational space [18:20:44] fundraising-tech-ops, Traffic, operations, IPv6, Patch-For-Review: Enable IPv6 on donate.wikimedia.org - https://phabricator.wikimedia.org/T73267#1650219 (BBlack) Thanks! I'm going to do it now, and yeah gerrit will log the merge here regardless. [18:21:16] awight: dstrine: I don't understand how "Banner history MVP" (https://phabricator.wikimedia.org/T78089) is blocked by "Banner history post launch" (https://phabricator.wikimedia.org/T112923), since the launch lanuches an MVP [18:22:50] fundraising-tech-ops, Traffic, operations, IPv6, Patch-For-Review: Enable IPv6 on donate.wikimedia.org - https://phabricator.wikimedia.org/T73267#1650229 (BBlack) (btw, the relevant TTLs are 600s, so you may not see the full effect for at least 10 minutes. Maybe longer for some clients, if they... [18:23:06] AndyRussG: Good point, unlinking now [18:23:10] AndyRussG I didn't make that connection in Phab [18:23:24] Fundraising-Backlog: [EPIC] Banner history post launch - https://phabricator.wikimedia.org/T112923#1650236 (awight) [18:23:26] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic, Patch-For-Review: [epic] Banner History MVP - https://phabricator.wikimedia.org/T78089#1650235 (awight) [18:23:50] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Handle Amazon SDK client communication failures and any other error that bubbles up to the Mediawiki API - https://phabricator.wikimedia.org/T112924#1650242 (Ejegg) NEW a:Ejegg [18:23:50] regardless the task called MVP has clearly grown beyond the term MVP [18:24:15] If only we had a "relates to" connection [18:24:16] AndyRussG: The second thing I wanted to descope is the KV TTL business... From my very uninformed perspective, it seems like there's still conversation to be had with the performance engineer(s), and that what we're currently doing isn't bad enough to block deployment. It's actually quite good ;) [18:24:25] Re: priorities, I think the priority should be review of the KVStore TTL (https://gerrit.wikimedia.org/r/#/c/237526/), deployment of that and other undeployed accumulated patches, and completion of "Associate banner history ID with contribution ID" (https://phabricator.wikimedia.org/T112022)... anyway, that'd be my reading of how to get as quickly as possible to what's most strongly desired by the FR [18:24:59] i'm going to get some lunch, back in a bit [18:25:09] awight: ah! as far as I know, there's no objections to the KV TTL from performance... (did I miss something?) [18:25:10] But there's no reason to rush deployment of the donation ID thing. [18:25:24] AndyRussG: I thought performance was asking for that? [18:25:47] (ttl) [18:26:07] awight: yes, but it's all ready for review, should work fine, so I don't know why we shouldn't try to get it through? [18:26:22] we certainly can, but at a different priority level [18:26:39] awight: Is there much more to do on it? [18:27:06] I'd rather have it through before real users start getting the data, because otherwise we'll have to take into account old, un-ttl-tagged data on user machines [18:27:39] IIR, there's discussion about whether we really need to do an additional localstorage check every time through [18:27:53] okay, makes sense [18:27:59] awight: we asked performance and they said, yes we do [18:28:20] sorry, maybe u missed that? /me looks for where I wrote it [18:28:40] That was my understanding also, but I didn't hear them say they felt strongly enough to block deployment [18:28:49] Anyway, if you're avoiding migration headaches I can get behind that. [18:29:00] awight: one sec, lemme pull up the details [18:29:01] Sorry, I thought there was already an expiration mechanism [18:29:22] awight: there's an expiration mechanism for BH but it leaves cruft in localStorage after the user is no longer in the campaign [18:29:41] So they said specifically that a global expiration mechanism is needed [18:30:50] kk [18:31:27] localStorage [18:40:53] awight: sorry for the delay, just found the explanation from Krinkle: "There's a very finite amount of space and there are a lot of players. We're already at high capacity (I'd etimate 80%) of the roughly 5M space available." [18:41:01] I should have put it in the phab task, not just IRC [18:43:02] cwdent|afk: i think i just donated successfully! [18:44:25] (CR) Awight: KVStore: Items have limited TTL (4 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237526 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG) [18:44:28] (PS8) Awight: KVStore: Items have limited TTL [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237526 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG) [18:44:35] (CR) Awight: [C: 2] KVStore: Items have limited TTL [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237526 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG) [18:44:54] AndyRussG: There was something else you mentioned, EventLogging data is disappearing on meta.beta? [18:46:05] Hmm reading https://wikitech.wikimedia.org/wiki/Analytics/EventLogging/TestingOnBetaLabs [18:46:51] awight: yeah last time I checked... Many thanks BTW!!!!! [18:46:57] (Merged) jenkins-bot: KVStore: Items have limited TTL [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237526 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG) [18:47:58] ouch [18:47:59] ok [18:48:30] (CR) Ejegg: [C: -1] "Found a typo - should I just fix that at the source? https://meta.wikimedia.org/w/index.php?title=Fundraising/Tran" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/238365 (https://phabricator.wikimedia.org/T110232) (owner: Awight) [18:49:06] ejegg: sure! [18:49:15] (CR) Awight: Update to the 20150904 thank you letter (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/238365 (https://phabricator.wikimedia.org/T110232) (owner: Awight) [18:50:00] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Analytics-EventLogging, and 3 others: Betawiki EventLogging data is disappearing? - https://phabricator.wikimedia.org/T112926#1650382 (awight) NEW [18:50:19] AndyRussG: Can you peek at ^ [18:50:21] awight dstrine you both look pretty deep in work stuff, but i'm at a pause and going for noms [18:51:29] (CR) AndyRussG: "Thanks!!!!" (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237526 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG) [18:54:36] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Analytics-EventLogging, and 3 others: Betawiki EventLogging data is disappearing? - https://phabricator.wikimedia.org/T112926#1650405 (Ottomata) eventlogging and database have been moved to deployment-eventlogg... [18:56:52] (CR) Ejegg: "Fixed the English version on wiki." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/238365 (https://phabricator.wikimedia.org/T110232) (owner: Awight) [19:10:53] anyone feel like opening up this page and checking the console for CN errors? http://en.wikipedia.beta.wmflabs.org/wiki/Main_Page [19:11:08] I was getting some a minute ago but it may have been 'cause stuff was just updating on the cluster [19:13:34] AndyRussG: Not getting any errors here. [19:13:45] XenoRyet: fantastic ;) thanks! [19:13:55] No worries :) [19:25:43] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Analytics-EventLogging, and 2 others: Beta Cluster EventLogging data is disappearing? - https://phabricator.wikimedia.org/T112926#1650603 (greg) [19:28:03] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Analytics-EventLogging, and 2 others: Beta Cluster EventLogging data is disappearing? - https://phabricator.wikimedia.org/T112926#1650613 (AndyRussG) Many thanks @Ottomata!! K I see it now in /var/log/eventlogg... [19:28:29] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Analytics-EventLogging, and 2 others: Beta Cluster EventLogging data is disappearing? - https://phabricator.wikimedia.org/T112926#1650620 (greg) >>! In T112926#1650405, @Ottomata wrote: > What is the proper cha... [19:30:57] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Analytics-EventLogging, and 2 others: Beta Cluster EventLogging data is disappearing? - https://phabricator.wikimedia.org/T112926#1650640 (Ottomata) Ok, thanks. I think I migrated this service very hastily, si... [19:31:15] AndyRussG: clean console here too, all the way through closing the banner [19:31:23] ejegg: fantastic :) [19:33:43] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Analytics-EventLogging, and 2 others: Beta Cluster EventLogging data is disappearing? - https://phabricator.wikimedia.org/T112926#1650654 (greg) I think it let's anyone email it. I clean the backlog daily, fwiw... [19:34:51] AndyRussG: wait, so nested EL schemas turn out to not be supported? [19:35:09] ejegg: XenoRyet: awight: anyone else possibly interested in some wee distraction: feel like poking at http://en.wikipedia.beta.wmflabs.org/wiki/Main_Page?country=AQ&bannerHistoryLogRate=1 too? [19:36:08] AndyRussG: Basic question--is this beta labs or the beta cluster? [19:36:37] awight: they're supported in EL and the data goes into the log. The schema validates and is logged as JSON as correct--see the file mentioned in the Phab task. However there's an issue with the bit that passes it on to MySQL. I think it's just they need to quote a string. [19:36:46] AndyRussG: no errors there either, all the way through clicking the doughnut button [19:36:51] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic, Patch-For-Review: [epic] Banner History MVP - https://phabricator.wikimedia.org/T78089#1650681 (awight) [19:36:56] ejegg: woohoo! [19:37:21] ejegg: are you on iceweasel 40? [19:38:23] awight: supposedly Ellery has no problem with getting the data just as JSON so it's not a blocker [19:38:45] yep, 40.0.3 [19:38:57] awight: beta cluster [19:39:02] and localstorage seems to have some good banner history entries [19:39:03] cwdent: do you need a task for "default to credit card (so it doesn't need to be in the url)" [19:39:07] strange... cos it's on labs. OK thanks! [19:39:27] AndyRussG: So Ellery wouldn't be able to query, he'd be importing a raw log? [19:39:52] dstrine: actually yeah, want to make a general solution for that and dedupe some code so it's probably worth a point [19:39:54] awight: he's OK with that. The MySQL just logs the nested structure as a JSON string anyway [19:40:05] cool. [19:40:24] awight: re: clusters and labs, I dunno then, I'm looking at this: https://wikitech.wikimedia.org/wiki/Analytics/EventLogging/TestingOnBetaCluster [19:40:52] awight: I'd thought it was fixed in this task, but just looking at it now, I misread: https://phabricator.wikimedia.org/T110462 [19:41:10] the mysql, I mean [19:41:34] Fundraising Sprint Tom Waits: default to credit card (so it doesn't need to be in the url) - worldpay 1 hour test - https://phabricator.wikimedia.org/T112946#1650716 (DStrine) NEW a:cwdent [19:42:03] Fundraising Sprint Tom Waits: default to credit card (so it doesn't need to be in the url) - worldpay 1 hour test - https://phabricator.wikimedia.org/T112946#1650725 (DStrine) [19:42:04] Fundraising Sprint Tom Waits, Fundraising-Backlog: Review audit parsing, review whether existing stuff is working. (Worldpay 1 hour test) - https://phabricator.wikimedia.org/T112807#1650724 (DStrine) [19:42:08] thanks dstrine [19:42:11] Fundraising Sprint Tom Waits: default to credit card (so it doesn't need to be in the url) - worldpay 1 hour test - https://phabricator.wikimedia.org/T112946#1650716 (DStrine) [19:43:14] Fundraising Sprint Tom Waits, Unplanned-Sprint-Work: default to credit card (so it doesn't need to be in the url) - worldpay 1 hour test - https://phabricator.wikimedia.org/T112946#1650716 (DStrine) [19:43:20] Fundraising-Backlog, Analytics-EventLogging: Nested EventLogging data doesn't get copied to MySQL - https://phabricator.wikimedia.org/T112947#1650731 (awight) NEW [19:45:31] Fundraising-Backlog, Analytics-EventLogging: Nested EventLogging data doesn't get copied to MySQL - https://phabricator.wikimedia.org/T112947#1650741 (awight) [19:49:59] Looks like the review column has pretty well cleared out, and I need something new to do. Any suggestions? [19:50:17] I was kind of looking at that Amazon last name thing, but I'm open to other suggestions too. [19:50:19] (PS1) Cdentinger: worldpay iframe styles [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239188 [19:50:25] XenoRyet: Cool! See anything in the sprint backlog or in Fu-Ba sprint +1 that looks interesting? [19:50:57] ejegg: ^ do you know if the Amazon last name task still reflects the work that needs doing? [19:50:59] (CR) jenkins-bot: [V: -1] worldpay iframe styles [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239188 (owner: Cdentinger) [19:51:24] awight, XenoRyet yeah, I think it does! [19:51:35] thanks! [19:52:04] Didn't look like any approach had been settled on yet, but I had started thinking about the interesting but impossible task of name parsing. [19:52:09] ejegg: Where did you make your edit? [19:52:17] https://meta.wikimedia.org/w/index.php?title=Fundraising/Translation/Thank_you_email_20150904/en&action=history [19:52:25] ooh [19:52:36] god there's something kind of "publish" roadblock [19:53:03] and I don't see how to get to it [19:53:22] what is jenkins complaining about there? a bunch of glyph files missing? [19:53:38] cwdent: eh? What bug is this? [19:53:50] https://integration.wikimedia.org/ci/job/mwext-DonationInterface-testextension-zend/1847/console [19:54:09] ejegg: "mark for translation". I dont see it , though! [19:54:27] oh, odd [19:55:00] hmm, problem is still there [19:55:06] ejegg: you should get yourself on this list: https://meta.wikimedia.org/w/index.php?title=Special:ListUsers&group=translationadmin [19:55:11] I swear I used to be on that [19:55:43] ohh, it's here: https://meta.wikimedia.org/wiki/Fundraising/Translation/Thank_you_email_20150904 [19:55:47] but not in /en [19:56:07] right, there's a "mark for translation" action we can't access w/o permissions [19:56:32] also, all of the translators fixed the typo, so we don't actually need anything re-translated [19:56:39] ino :( [19:56:47] thanks for confirming that, btw! [19:57:54] ejegg: when you clicked on "Doughnut", you moved to meta on beta cluster and had this banner ID in your URL? ad6d6c5133ef2ee1 [19:58:23] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work, and 2 others: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1650811 (awight) @Jrobell, @MeganHernandez_WMF, @Pcoombe: Ejegg just fixed... [19:58:46] confirmed tests pass locally, kicking jenkins [19:59:11] AndyRussG: I definitely went to meta, checking history for id [19:59:36] (CR) Cdentinger: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239188 (owner: Cdentinger) [19:59:50] yep, that was the id [20:00:33] Fundraising-Backlog: Backfill from Aug 25-Sept 17 PayPal audit outage - https://phabricator.wikimedia.org/T112920#1650820 (jrobell) @awight Does this mean PayPal donations have not been recorded during this period - ie. test results might be skewed? thanks! [20:00:36] what the hell jenkins [20:00:43] (PS4) Awight: Update to the 20150904 thank you letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/238365 (https://phabricator.wikimedia.org/T110232) [20:02:04] ejegg: fantastic! sendLog() also seems to work on my native android browser, supposedly which doesn't support sendBeacon [20:03:11] If anyone would like to try the doughnut link on Safari or IE and send me the log ID that'd be fantastic, too! [20:03:33] I' [20:03:39] I'll do IE for you after standup [20:04:07] Actually would technically be Edge I guess. Got a Win 10 box right here. [20:04:33] XenoRyet: cool! Hmm I dunno if that supports it... [20:05:07] AndyRussG: you around? [20:05:10] Yea, looks like not. Button does nothing in Edge [20:05:30] dstrine: yep, just joining [20:05:33] XenoRyet: ohno! [20:05:47] Fundraising Sprint Tom Waits, Fundraising-Backlog: Sprint T goal (End Q1 + code slush): amazon & worldpay 1-hour test ready, banner history being used by fr-online - https://phabricator.wikimedia.org/T108406#1650848 (atgo) [20:06:17] dstrine: one sec, connection issues [20:06:28] I was just going to ask [20:06:43] its cool [20:06:55] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work, and 2 others: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1650862 (jrobell) thanks @awight [20:10:20] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Handle Amazon SDK client communication failures and any other error that bubbles up to the Mediawiki API - https://phabricator.wikimedia.org/T112924#1650878 (Ejegg) [20:11:05] Fundraising Sprint Tom Waits, Fundraising-Backlog: Style iframe contents more if necessary. (worldpay 1hour test) - https://phabricator.wikimedia.org/T112809#1650884 (cwdent) a:cwdent [20:12:00] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work, and 2 others: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1650886 (jrobell) Done! thank you @ejegg and @awight. [20:31:46] awight: poke about nuking some cache dir on jenkins? [20:31:56] or feel free to learn me [20:32:06] cwdent: thx! [20:32:09] lemme see... [20:33:04] hey atgo-lunch I have a couple of questions about the reports [20:33:13] hey eileen! [20:33:34] The actions button isn’t working in 4.6 due to broken css /js [20:33:46] just with the new stuff or in general? [20:33:48] & I chatted with Coleman about the best 4.6 approach [20:33:51] the new stuff [20:34:14] & he favours it having the look & feel of the actions drop-down on the search screens [20:34:18] AndyRussG: favor of... perhaps you can email ewulczyn a snippet of the eventlogging logfile, just to accelerate learning curves... [20:34:52] are you fussed about whether the appearance changes to fit core preferences for 4.6 [20:35:01] eileen: not at all [20:35:15] AndyRussG: Regarding Edge, the doughnut button is working now. Sent me the right place with bannerHistoryLogID=72cd87a77950ca69 [20:35:16] rather get things upstreamed as long as functionality stays the same [20:35:32] ok cool. It’s more maintainable & I think he is good at getting UI right [20:35:39] great [20:36:07] eileen: If this helps with anything, it's fair to deploy our 4.6 upgrade without the Giant Rabbit patches, until those are ready. [20:36:21] From what I can see the changes to buttons & report rendering are worth upstreaming as I port - but private reports might be a more moving targer [20:36:22] IMO that's sort of preferable cos then we have a more stable baseline. [20:36:36] Perfect, yeah that's a lower priority feature [20:36:41] awight: cool - I need to reply to the email on that - but, in terms of the triggers [20:36:41] (PS1) Awight: Correctly encode HTML entities in our debugging block. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/239218 [20:36:47] * awight tenses [20:37:00] I:-) [20:37:22] I guess my question is to flesh that out from a security point of view [20:37:41] ie. the triggers have a risk of priviledge escalation [20:38:25] Do you think it's possible to either * run without the triggers for the moment, or * consolidate trigger changes to only happen during migration? [20:38:28] but, assuming you know what is in them - then what extra risk is there with them? [20:38:36] (CR) Ejegg: [C: 2] "Looks good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/238365 (https://phabricator.wikimedia.org/T110232) (owner: Awight) [20:38:41] so, the triggers do a few things [20:38:49] The only risk I'm worried about is randomly giving Civi escalated privs [20:39:00] The triggers don't strike me as a risk per se [20:39:18] right - so as long as people understand what the triggers are actuallly doing it’s ok [20:39:19] ? [20:39:35] ie. the priviedge is only to add the triggers [20:39:55] & only the triggers added during the period when the upgrade script is running can be added [20:39:57] absolutely, yeah the only question is how to add the triggers via a sane process [20:40:20] What did you think about my horrible kludge to output the trigger statements to a file? [20:40:35] ok & altering the creds in civicrm.settings.php while the upgrade runs is not ok? [20:40:44] (CR) Ejegg: [C: 2] "Nice catch! Just curious, why ENT_HTML401?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/239218 (owner: Awight) [20:41:22] (I mean - they could go in a file - but it seems to me that it’s more work to do that & I’m not sure what it adds in security over just changing the creds for the 30 min period) [20:42:13] (CR) Awight: "> why ENT_HTML401?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/239218 (owner: Awight) [20:42:33] rats, we lost the chance to ask Jeff_Green [20:42:57] awight: I can put that in an email [20:43:23] eileen: We can certainly ask ^ our tech ops person, I'm probably not doing a faithful job of representing him [20:43:36] sure [20:43:38] I vaguely remember this being his preference from the last time we talked about it [20:43:57] at least, "don't ever give Civi mysql root" was something I believe he'd agree with [20:44:02] OK - it’s possible to do it your way - but I feel like it introduces other risks [20:44:16] ejegg: So there's an email thread I should read about this Amazon report download? [20:44:30] eileen: Don't triggers get added whenever we add custom fields 'n' stuff? [20:44:31] in terms of altering the upgrade script & it breaking on us as a result [20:44:37] :( right [20:44:42] awight: only if db logging is on [20:44:46] XenoRyet: yep! one sec, I'll find the subject [20:44:52] without DB logging triggers are used to [20:45:05] eileen: oh, the audit feature? [20:45:06] 1) maintain modified date on the contact record (new field) [20:45:22] 2) clean up notes & records using entity_id [20:45:28] 3) tidy up phone numbers [20:45:32] cwdent: Can you try removing the commented-out glyph classes? [20:45:36] & yep - logging is the audit feature [20:45:40] ok [20:45:55] - so if you want the audit feature & no super it means that only ops can add custom fields [20:46:02] booo [20:46:18] or that the custom fields don’t create an audit trail - or something [20:46:21] lemme see if I can dig up the conversation so far [20:46:22] awight: sure [20:46:35] XenoRyet: ok, I forwarded you the email with the details [20:47:12] ejegg: Cool thanks. I'll read through that, then probably pester you for more info after. [20:48:21] eileen: oh hey, Jeff_Green replied to our thread "Testing 4.6 upgrade" [20:48:27] (PS2) Cdentinger: worldpay iframe styles [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239188 [20:50:37] awight: yeah - I’ll reply to that - I feel like if he wants to track the sql run then really he wants the whole upgrade script - not just the triggers [20:51:31] eileen: I was thinking that, too... [20:52:01] awight: yep comments broke the build nbd [20:52:06] i wonder why it just started tho [20:52:34] awight: cool, yeah sounds right [20:52:38] XenoRyet: great! [20:52:44] XenoRyet: thanks! [20:52:49] I wonder what it was? [20:52:58] eileen: You probably read the upstream bug about this... http://bugs.mysql.com/bug.php?id=39489 [20:53:18] Fundraising-Backlog, Recurring-Donations: Make different monthly receipt for recurring donors - https://phabricator.wikimedia.org/T112966#1651193 (atgo) NEW [20:53:58] AndyRussG: I did see that it was giving me an object not supported type error. Just went away though. [20:54:04] Fundraising-Backlog, Recurring-Donations: Create option for EOY receipt for recurring donors - https://phabricator.wikimedia.org/T103447#1390450 (atgo) [20:54:13] Fundraising-Backlog, Analytics-EventLogging: Nested EventLogging data doesn't get copied to MySQL - https://phabricator.wikimedia.org/T112947#1651209 (Ottomata) FYI, although not 100% announced yet, EventLogging data is going into HDFS now, so you should be able to query them using Hive there. There are... [20:54:20] Though Edge is giving me a bunch of these DOM7009: Unable to decode image at URL: 'http://en.wikipedia.org/wiki/Special:HideBanners?duration=604800&category=BannerHistorytest&reason=close' with MIME: 'image/png'. [20:54:20] XenoRyet: when and where did u see the error? [20:54:34] when closing the banner. [20:54:49] awight: my reading of that is not that it is a bug - but that it is a feature which kind of makes sense [20:54:51] ah, that's got nothing to do with the new code then [20:54:52] XenoRyet: ah yes that's normal [20:54:53] The object not supported error was in the console when clicking the button. [20:55:07] Time-wise it was right at the start of standup. [20:55:12] ie. in a slave/master environment triggers can represent a privilledge elevation [20:55:25] XenoRyet: hmmm I'm worried about the object not supported... the close button thing is OK [20:56:26] Yea, can't replicate the object not supported thing anymore. [20:57:05] XenoRyet: hummm [20:57:16] Maybe by clearing your cookies and your cache? [20:57:35] Just did that, still no bug. Creepy that it would just dissapear. [20:59:13] (PS12) Awight: WIP Banner diet mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 [21:00:09] (CR) Awight: WIP Banner diet mixin (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (owner: Awight) [21:01:04] (PS13) Awight: Banner diet mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (https://phabricator.wikimedia.org/T112017) [21:01:14] (PS14) Awight: Banner diet mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (https://phabricator.wikimedia.org/T112017) [21:02:02] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic, Patch-For-Review: [epic] Banner History MVP - https://phabricator.wikimedia.org/T78089#1651252 (awight) [21:02:05] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Show large screen banner and then top screen banner without losing an impression - https://phabricator.wikimedia.org/T90919#1651251 (awight) [21:02:38] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Special:HideBanners should output a valid PNG - https://phabricator.wikimedia.org/T112969#1651253 (Ejegg) NEW [21:03:46] AndyRussG: Just tried it in a couple of other places. IE11 seems to work fine. IE9 has no errors, but doesn't show the banner and the formatting looks messed up. [21:04:41] XenoRyet: hmm thanks! Do you feel like digging into the IE9 issue? [21:04:57] I guess I should download those... what were they, VMs provided just for IE testing? [21:05:55] Na, I'm happy to help. [21:06:11] AndyRussG: We still have that crossbrowsertesting account, if you want [21:06:17] XenoRyet: also! ^ [21:06:55] https://office.wikimedia.org/wiki/Browser_testing_and_design_tools#CrossBrowserTesting [21:09:30] awight: ahh right... [21:10:04] Though IIRC running your own VM was more comfy when it comes down to debugging w/ dev tools [21:10:57] (PS1) Ejegg: Handle errors thrown by Amazon SDK [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239284 (https://phabricator.wikimedia.org/T112924) [21:11:39] (CR) jenkins-bot: [V: -1] Handle errors thrown by Amazon SDK [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239284 (https://phabricator.wikimedia.org/T112924) (owner: Ejegg) [21:13:38] (PS2) Ejegg: Handle errors thrown by Amazon SDK [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239284 (https://phabricator.wikimedia.org/T112924) [21:14:04] (CR) jenkins-bot: [V: -1] Handle errors thrown by Amazon SDK [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239284 (https://phabricator.wikimedia.org/T112924) (owner: Ejegg) [21:15:45] (CR) Awight: [C: -2] "CR would be great--but we're currently blocking merge depending on Civi admins reviewing whether the output is too spammy." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/238636 (https://phabricator.wikimedia.org/T105918) (owner: Awight) [21:16:30] (PS3) Ejegg: Handle errors thrown by Amazon SDK [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239284 (https://phabricator.wikimedia.org/T112924) [21:16:56] (CR) jenkins-bot: [V: -1] Handle errors thrown by Amazon SDK [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239284 (https://phabricator.wikimedia.org/T112924) (owner: Ejegg) [21:19:18] Fundraising-Backlog: Backfill from Aug 25-Sept 17 PayPal audit outage - https://phabricator.wikimedia.org/T112920#1651351 (awight) Good question. Historically, PayPal comes in almost entirely through the listener, and the audit system is the source for about 0.5% of the donations in Civi. During the period... [21:19:50] Fundraising-Backlog: Backfill from Aug 25-Sept 17 PayPal audit outage - https://phabricator.wikimedia.org/T112920#1651359 (awight) BTW, once the data is backfilled we should be able to re-run test results and the results should be trustworthy. [21:29:30] mvp: alias localsettingstest="rm /srv/core/LocalSettings.php && ln -s ~/.localsettings/LocalSettings.test.php /srv/core/LocalSettings.php" [21:29:32] etc [21:30:17] (Abandoned) Jdlrobson: Hygiene: Simplify the module you add to the page [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/213987 (owner: Jdlrobson) [21:31:29] Fundraising-Backlog: Backfill from Aug 25-Sept 17 PayPal audit outage - https://phabricator.wikimedia.org/T112920#1651426 (awight) Waiting for a response from PayPal, currently the situation seems to be that we should not parse the audit files from Aug 25, 26, and 27th. This would be accomplished by moving... [21:31:57] cwdent: ln -sf ftw [21:32:09] is that follow links? [21:32:18] it blows away any existing link [21:32:22] on nice [21:32:38] that's pretty much the approach I take, can't say it works very well though [21:33:13] yeah it's basic [21:33:22] it would be nice to split the files up into sections [21:34:20] atgo: re your email, isn't it the utm_campaign thing we added this morning? [21:34:39] you get dinged for not having a campaign cause it's abnormal [21:34:58] so i added one in the url and now they go through [21:35:27] Fundraising-Backlog: Backfill from Aug 25-Sept 17 PayPal audit outage - https://phabricator.wikimedia.org/T112920#1651460 (awight) Okay, suspect files are currently waiting in /archive//audit/paypal/archive/hold-T112920/ [21:48:10] Fundraising-Backlog: Backfill from Aug 25-Sept 17 PayPal audit outage - https://phabricator.wikimedia.org/T112920#1651554 (awight) Threw one more broken file in the bucket, SAR-20150916.01.002.CSV -- none of the 93 subscription creations from that file were parseable. [21:49:27] (CR) AndyRussG: "Fantastic, getting there!!! :D Thoughts 'n' questions:" (6 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (https://phabricator.wikimedia.org/T112017) (owner: Awight) [21:49:48] cwdent: I believe that filename includes a vertical bar. [21:49:58] AndyRussG: thanks! [21:50:12] awight: likewise! [21:50:16] Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, and 2 others: Adding 1 Custom field to "primary fields" export list: Do Not Solicit - https://phabricator.wikimedia.org/T105918#1651565 (CaitVirtue) Wow, that's a ton of field... [21:50:32] lol [21:50:47] they know how to ham it up alright [21:55:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Find a more nuanced way to add a few custom fields to the default exports - https://phabricator.wikimedia.org/T112983#1651572 (awight) NEW a:awight [22:00:12] (PS3) Cdentinger: worldpay iframe styles [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239188 [22:02:12] awight: do you think Ellery will be offended if I send a text file with the results of grepping the log? I mean, it might sound like I didn't think he could ssh 'n' grep himself? [22:02:33] nope, I think that's just helpful [22:03:12] awight: K! [22:07:10] AndyRussG: ah, I'm making a card that might be a natural place to attach that data. [22:07:16] Fundraising Sprint Tom Waits, Fundraising-Backlog, Research-and-Data: Spike: Review banner history log data and confirm that it satisfies use cases - https://phabricator.wikimedia.org/T112986#1651625 (awight) NEW a:ellery [22:07:18] ^ there [22:10:57] Fundraising Sprint Tom Waits, Fundraising-Backlog, Research-and-Data: Spike: Review banner history log data and confirm that it satisfies use cases - https://phabricator.wikimedia.org/T112986#1651645 (AndyRussG) Here's a tidbit of the log from the beta cluster. Entries with the "r" property were random... [22:12:12] Fundraising Sprint Tom Waits, Fundraising-Backlog, Research-and-Data: Review banner history log data and confirm that it satisfies use cases - https://phabricator.wikimedia.org/T112986#1651666 (awight) [22:12:54] XenoRyet: https://dev.modern.ie/tools/vms/linux/ [22:13:11] Cool [22:13:27] Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, and 2 others: Adding 1 Custom field to "primary fields" export list: Do Not Solicit - https://phabricator.wikimedia.org/T105918#1651675 (DStrine) @CaitVirtue Adam already made... [22:14:00] Fundraising-Backlog: Parse PayPal audit data from Aug 25-Aug 27 + Sep 16 gaps - https://phabricator.wikimedia.org/T112989#1651682 (awight) NEW [22:14:02] Been using that crossbrowsertesting site, but this seems useful too. [22:14:20] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Parse PayPal audit data from Aug 25-Aug 27 + Sep 16 gaps - https://phabricator.wikimedia.org/T112989#1651682 (awight) [22:14:39] Fundraising-Backlog: Backfill from Aug 25-Sept 17 PayPal audit outage - https://phabricator.wikimedia.org/T112920#1651692 (awight) [22:14:40] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Parse PayPal audit data from Aug 25-Aug 27 + Sep 16 gaps - https://phabricator.wikimedia.org/T112989#1651682 (awight) Open>Resolved [22:14:52] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Backfill from Aug 25-Sept 17 PayPal audit outage - https://phabricator.wikimedia.org/T112920#1650136 (awight) [22:15:34] gotta head out for a while, but i'll check back in late [22:16:00] cya! [22:18:34] Fundraising-Backlog: Outdated cert on GC iframe? - https://phabricator.wikimedia.org/T112990#1651713 (CCogdill_WMF) NEW [22:20:00] re the taske above, not sure if that is sensitive info… lmk if it is [22:20:27] awight: the queue consumer does not know how to read from redis right now? [22:22:54] seems to write to it fine...wondering how much work you think that will be [22:25:17] cwdent: reading from redis is probably a few days of work [22:25:29] But you can use that drush command... [22:25:29] dang [22:25:46] ok, will do [22:25:57] i just feel like it's speculative to edit the data by hand and try to feed it in [22:25:58] drush -v -v donations-process-messagefile FILE.json [22:26:16] Can't you just spin up a mw-vagrant and forward 61613? [22:26:30] how much ram does it need? [22:26:52] awight: whad'ya think of adding a shim to ext.centralNotice.display.state.js to deal with all the history reason codes? It could be done so nothing else has to change when we get rid of the codes [22:26:56] my little server only has 2G [22:27:01] * AndyRussG pushes awight to multitaskland [22:27:12] which is plenty for most stuff when no browser is present [22:27:47] AndyRussG: Probably not worth it, and also an encapsulation fail [22:28:00] want me to share what I really think? :p [22:28:09] awight: ¡por supuesto? [22:28:11] ! [22:28:24] hehehe that was about it [22:28:38] ¿de veras? [22:28:57] I have little opinion about that actually [22:29:18] and yes, it's an encapsulation fail, except when you think that encapsulation is so you don't have to go around changing little bits of code hiding here and there, which is exactly what it would do [22:29:59] i.e. if it were longlived it'd be bad, but as a temporary shim, its evilness becomes inverted ;D [22:34:45] (CR) Awight: Banner diet mixin (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (https://phabricator.wikimedia.org/T112017) (owner: Awight) [22:36:17] (PS15) Awight: Banner diet mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (https://phabricator.wikimedia.org/T112017) [22:47:19] (CR) Ori.livneh: Migrate to a terser cookie name and format (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235979 (https://phabricator.wikimedia.org/T110353) (owner: Ori.livneh) [22:47:25] (PS13) Ori.livneh: Migrate to a terser cookie name and format [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235979 (https://phabricator.wikimedia.org/T110353) [22:58:12] eileen: fwiw, thanks to your detailed write-up, I'm leaning towards punting the triggers issue for now. Since #1 and #2 are functionality we currently don't have, and not essential for Civi to work properly, I think we can wait until after the upgrade. [22:58:45] awight: yeah - the issue is that hacking them out of the upgrade script adds it’s own risks [22:59:12] ;) fr-tech is a risky job [22:59:39] :-) [23:00:22] AndyRussG: Where did we land on recording impressions that aren't part of a BH-enabled campaign? I was pretty keen on that myself, but did ewulczyn say he didn't care? [23:00:40] Or is that happening already and I didn't see? [23:02:23] awight: I don 't think there's anything special about BH and non-BH campaigns for wrt S:RI [23:03:14] awight: AFIK all FR campaigns will continue to get 100% S:RI until they can get the same thru Special:BannerLoader [23:04:27] No not S:RI but BH. Like, I thought it was pretty important to know if someone sees 10 WLM banners in between BH-enabled campaign impressions. [23:06:47] awight: it seems like the message import wants the civi-specific currency code ID? [23:06:52] is there a way to get that in DI? [23:07:04] nooo [23:07:10] That doesn't ring a bell [23:07:14] What's the error? [23:07:19] There might be a field name issue [23:07:25] lessee [23:08:02] yeah it wanted the field name currency instead of currency code [23:08:12] so i copied that over and it complained about EUR [23:08:15] See wmf_civicrm_normalize_contribution_amounts for the grizzly details [23:08:27] so i changed it to the ID from the WP adapter and it didn't like that either [23:08:31] awight: in that case the WLM campaign would have to have BH enabled, and it would get sent back sampled, like all BH [23:08:33] cwdent: that's a serious gotcha. You need to refresh the exchange_rates at least once [23:08:42] ok i'll take a look [23:09:07] cwdent: try https://civicrm.LOCAL/admin/config/exchange_rates/show [23:09:13] erm just forget the https [23:09:15] sheesh [23:09:52] AndyRussG: But, is that data ewulczyn wants, and we should be thinking about a roadmap to make that happen? [23:10:10] Sorry I am all context-switch glitchy today [23:10:55] awight: I think not until he asks ;) [23:11:11] np! context-switchy-twitchy is my life 8p [23:13:13] awight: i don't see anything in that table...is there a drush command to refresh? [23:13:27] I'm not too comfortable with that... I don't see any notes saying that this was discussed, although I remember bringing it up and very vaguely remember a "maybe". I'd like to at least get a definite "no" from Ellery [23:13:40] cwdent: yes. it should be a link at the top of that page? [23:14:23] There we go. /admin/config/exchange_rates [23:14:29] There's probably a drush command too... [23:17:01] Fundraising Sprint Tom Waits, Fundraising-Backlog, Research-and-Data: Review banner history log data and confirm that it satisfies use cases - https://phabricator.wikimedia.org/T112986#1651909 (awight) Do you want the history log to include banner impressions from other campaigns? Do you want a record... [23:17:16] AndyRussG: OK I made a note on ellery's increasingly fun task [23:19:16] awight: sorry to bug you but Class 'CurrencyRates' not found [23:19:24] vendor is up to date... [23:20:16] cc'd all [23:21:17] awight: one sec [23:26:23] (PS1) Awight: More inline help for mixins [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/239302 [23:26:48] cwdent: That's from DonationInterface, I think [23:27:02] cwdent: Are you running drush? [23:27:16] nah just the link you sent [23:27:43] cwdent: Do you have this horrific line in your settings.php? [23:27:43] require_once __DIR__ . '/../../vendor/autoload.php'; [23:27:47] ah yeah it's in vendor/di [23:27:49] * awight just plain dies [23:28:02] hehe, checking [23:28:10] It won't be there unless u add it :( [23:28:15] major permaculture fail [23:29:55] now i see em [23:29:56] thanks! [23:30:02] so you think it probably just wants EUR? [23:30:25] not cool. https://www.drupal.org/node/2404989 [23:30:40] yeah [23:30:50] ugh [23:30:54] If the message says "currency_code" that's a problem, too. [23:31:16] We may have standardized the field name and overlooked WP [23:31:28] um. no [23:32:15] yeah i was wondering about that [23:32:23] DonationQueue should have done that mapping. Can you paste your json (pm)? [23:32:24] was just gonna get it to parse before doing the Right Thing [23:32:28] sure [23:44:38] dstrine: bart? [23:49:38] gtg [23:53:54] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix Fundraising CiviCRM installation gotchas - https://phabricator.wikimedia.org/T113005#1652012 (awight) NEW