[03:09:01] Fundraising Sprint Tom Waits, MediaWiki-extensions-CentralNotice: Banners not showing on IE9 - https://phabricator.wikimedia.org/T113013#1652244 (AndyRussG) NEW [03:12:06] Fundraising Sprint Tom Waits, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Fix banners on IE9 - https://phabricator.wikimedia.org/T113013#1652271 (AndyRussG) [05:03:17] xkill is so fun to use [06:50:37] Fundraising-Backlog: Synthezise missing subscriptions - https://phabricator.wikimedia.org/T113027#1652500 (awight) NEW [14:52:21] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work, and 2 others: Deploy 2015 Lila thank you email + typo fix for br-pt - https://phabricator.wikimedia.org/T110232#1653312 (Pcoombe) Thanks @awight and @Ejegg. Any idea when this can be de... [14:59:52] Fundraising-Backlog: [EPIC] Amazon (embedded) internal test - https://phabricator.wikimedia.org/T108102#1653324 (faidon) [15:00:07] (CR) Ejegg: "Recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239284 (https://phabricator.wikimedia.org/T112924) (owner: Ejegg) [16:02:52] the long jimmy quote still says we have 93 staff [16:03:19] cwdent: yeah, way out of date. I don't think any of the real links point to that though [16:03:40] I think I found the issue with those dumb font files failing tests: https://gerrit.wikimedia.org/r/239402/ [16:04:23] ah is that a custom minifier? [16:04:59] yeah... [16:06:23] I kinda like it when core changes impact us - gives me a reason to go digging around [16:06:23] i still wonder why it cropped up all of the sudden [16:06:30] always turns up something interesting [16:06:37] ooh it was a change? [16:06:43] the change I linked in the comment was very recent [16:07:00] yeah, just merged yesterday [16:07:05] nice [16:08:23] OK, added all the reviewers of the breakage patch, plus some randos from the history of CSSMin.php [16:09:02] but maybe we should just go ahead and delete that part of bootstrap.css in case the fix doesn't get speedy review [16:10:59] ejegg: i actually did that already :P [16:11:08] oh, nice! [16:11:34] ahh, i see it now [16:14:02] ejegg: turns out the queue consumer can take WP messages after all [16:14:20] i was trying to send 2 at a time in a json array is why it bailed before [16:14:54] ohhh [16:15:07] yeah, guess that would choke it [16:15:41] cwdent: did you see the news? Worldpay is filing for an IPO! [16:15:41] Hi! Has anyone been getting this error "Archives directory /vagrant/cache/apt/partial is missing" in vagrant? [16:16:00] ejegg: ha ha ha [16:16:02] * cwdent reaches for wallet [16:16:15] buying short calls? [16:16:22] It happened before and I thought it was due to the machnine being uncleanly aborted, but it just happened again following a normal shutdown [16:16:45] Heh well now would be a good time to turn on the pressure maybe [16:17:30] AndyRussG: I've never seen that one [16:17:35] Hrrmmm [16:17:38] thanks! [16:17:50] but the partial directory is just used while downloading, right? [16:17:54] AndyRussG: could be related http://www.cyberciti.biz/faq/debian-ubuntu-linux-earchive-directory-varcacheaptarchivespartial-ismissing/ [16:18:43] cwdent: thx! yeah I tried that very solution yesterday, but then it started complaining about other dirs missing, so I assumed it was some kinda disk corruption problem [16:18:49] ohh, do you suppose something in vagrant is trying to clean up apt stuff with just 'rm' [16:19:05] ejegg: hmmm [16:19:27] yeah now it's weird that there'd be corruption twice in a row in exactly the same dr [16:21:09] Also important news: http://www.bbc.com/news/science-environment-34278595 [16:21:53] hehe [16:22:03] hah [16:23:08] https://twitter.com/Amazing_Maps/status/644609175180476416 [16:24:16] nice! I wonder what that expands to when you take transmission loss into account [16:25:45] wow [16:27:13] Hmmm maybe I need to upgrade my vagrant version [16:29:37] (CR) Ejegg: [C: 2] "CSS changes look reasonable. And thanks for working around test breakage introduced by I5a3cdeb7d53485f161ccf8133e76850cdf5b4579 !" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239188 (owner: Cdentinger) [16:29:42] (PS4) Ejegg: worldpay iframe styles [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239188 (owner: Cdentinger) [16:31:17] (CR) Ejegg: [C: 2] "re- +2-ing 'cause I confounded CI with a last-second rebase" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239188 (owner: Cdentinger) [16:31:23] Hmmm no I'm on 1.7.4, which is the latest... [16:31:55] I want to know the % of that world box that is occupied by China and the US respectively [16:32:10] ty for the review ejegg ! [16:32:20] ty for the css twiddling! [16:32:49] (PS4) Ejegg: Handle errors thrown by Amazon SDK [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239284 (https://phabricator.wikimedia.org/T112924) [16:33:03] Hopefully that guy ^^^ is now viable [16:33:05] dstrine: man I wish I didn't have to heat my home by burnish stuff [16:33:06] (Merged) jenkins-bot: worldpay iframe styles [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239188 (owner: Cdentinger) [16:33:06] i'll deploy DI in a bit to get rid of the inline styles on the iframe container and then everything will look good [16:33:35] cwdent: any chance that extra error handling could tag along? [16:33:44] (CR) jenkins-bot: [V: -1] Handle errors thrown by Amazon SDK [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239284 (https://phabricator.wikimedia.org/T112924) (owner: Ejegg) [16:33:47] phooey [16:33:50] AndyRussG: I'm hoping you are at least on natural gas [16:33:53] At least I cool it by electricity generated by hydro... only that comes from having flooded massive areas of first nations territories decades ago [16:34:04] dstrine: yea it's natural gas... but... really a lot of it! [16:34:23] hehe, ejegg yeah i can wait a bit, doing some related fiddling and i'll cr that whenever it's ready [16:34:24] oh Canada ;) [16:34:25] "my home" = borrowed from the landlord at a cost [16:34:37] oh, i just rebased before yours had fully merged [16:35:13] (PS5) Ejegg: Handle errors thrown by Amazon SDK [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239284 (https://phabricator.wikimedia.org/T112924) [16:35:15] I so need to mow my lawn but I don't want to go for a gas mower... maybe I could use my teeth [16:35:38] scythe? [16:35:39] depending on the land you have around it, you could use geothermal. If you dig deep enough the temperature differential is huge [16:35:48] you could re-use it at halloween [16:36:13] i just found out the giant maker space in my town is heated by geothermal in the winter! [16:37:03] cwdent: jenkins-bot liked PS5! [16:37:38] AndyRussG: http://www.washingtonpost.com/wp-dyn/content/article/2011/01/31/AR2011013104862.html [16:38:44] nice, checking now [16:39:10] i really disappointed myself last night [16:39:35] as a programmer things like the fence post problem should be in my tool chain [16:39:49] but what did i do but build one too few roof trusses [16:39:58] d'oh! [16:40:22] heh, zero-based counting in carpentry [16:40:30] hehe yep [16:40:53] it extra sucks because i had a good factory for building them but now i'm going to have one snowflake truss that will inevitably be a little weird [16:41:05] [0,4) [16:43:13] ejegg: so this last one was just a couple more translations? [16:43:35] dstrine: right! heh several years ago I went to the house of a friend that was heated by geothermal. Really neat! But also... chilly! [16:43:54] couple more translations? [16:44:33] donate_interface-donate-error-try-a-different-card-html [16:44:33] I dunno how much they spent to have a righteously heated but chilly home in the winter [16:45:00] oh, are you comparing across different patch sets? I did rebase past a bunch of translation updates [16:45:15] AndyRussG: there might be a few variables in that...namely their taste in temperature? [16:45:20] but my code didn't change after PS3 [16:45:33] heh they seemed proud of it at least :) [16:45:38] maybe that affected their taste [16:45:55] ejegg: cwdent: when would be a good time to get some pointers for where to start hacking on the banner log id in the contribution tracker? [16:46:34] AndyRussG: I still don't know if we should add the specific history log ID to that table [16:46:46] I'm still getting vagrant errors but I could take notes :) [16:46:56] I thought we'd agreed on a way to keep it more anonymized [16:47:13] like adding a new table that just contained IDs of history logs that correlated with some donation [16:47:14] ejegg: yes... I mean, I don't know what else is in that table :) [16:47:22] ah OK sounds good [16:47:33] which extension should manage that table? [16:48:16] Hmm [16:48:26] DonationInterface could drop a message in another queue [16:48:27] I think we want to be able to say what stage they got to in the process, or at least just clicked on donate vs. actually donated [16:48:58] DI is the one that creates the actual page people go to right after the banner, right? [16:49:17] and it could be inserted into a table by the consumer for the stats tables, like payments-initial and payments-fraud [16:49:38] I think those consumers are in CRM, but let me confirm [16:49:46] ejegg: K... hmmm... :) [16:54:05] Fundraising Sprint Queen, Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint The Pogues, and 3 others: Set up import for Major Gifts events payment/invitation tool - https://phabricator.wikimedia.org/T101191#1653699 (LeanneS) Thanks all. I tested the impor... [16:55:50] dstrine: thanks! have I been very pixelated and roboty of late? [16:56:13] ejegg: if that were the case, then it'd be a question of patching DI _and_ the CRM, right? [16:57:26] AndyRussG: There is always a bit of a delay and you seem to have more connection issues. Audio issues seem to be pretty constant. [16:57:54] we could even get you an android tablet [16:58:08] there are some cheap solutions [16:58:14] dstrine: yeah I do notice the delay on this end too... Maybe it's a Wifi issue [16:58:37] you seem to have feedback even when you use a headset [16:58:50] dstrine: thanks! I have one, actually... but I don't think there's a problem with the computer itself [16:59:39] dstrine: ah yes that feedback was just 'cause my headphones were turned up too loud, and they are big and leak audio [17:02:09] (CR) Cdentinger: [C: 2] Handle errors thrown by Amazon SDK [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239284 (https://phabricator.wikimedia.org/T112924) (owner: Ejegg) [17:02:37] (CR) jenkins-bot: [V: -1] Handle errors thrown by Amazon SDK [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239284 (https://phabricator.wikimedia.org/T112924) (owner: Ejegg) [17:04:06] Fundraising Sprint Queen, Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint The Pogues, and 3 others: Set up import for Major Gifts events payment/invitation tool - https://phabricator.wikimedia.org/T101191#1653729 (CCogdill_WMF) @LeanneS, if you expand t... [17:38:20] ... http://xkcd.com/ [17:55:20] (PS1) Ejegg: Prevent potential DOM-based XSS [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239427 [18:03:40] (PS6) Ejegg: Handle errors thrown by Amazon SDK [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239284 (https://phabricator.wikimedia.org/T112924) [18:05:40] (CR) Ejegg: "PS6: log exception message but show generic error to user" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239284 (https://phabricator.wikimedia.org/T112924) (owner: Ejegg) [18:09:40] (CR) Cdentinger: [C: 2] "security training ftw" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239284 (https://phabricator.wikimedia.org/T112924) (owner: Ejegg) [18:10:09] (Merged) jenkins-bot: Handle errors thrown by Amazon SDK [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239284 (https://phabricator.wikimedia.org/T112924) (owner: Ejegg) [18:11:04] ejegg|mtg: ¯\_(ツ)_/¯ [18:12:30] heh [18:14:55] ejegg: want me to deploy? [18:15:02] i'm ready whenever [18:15:12] cool [18:17:33] (PS1) Cdentinger: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/239432 [18:17:55] rgh ejegg you mind bumping the submodule pointer on core? [18:18:03] i'll get my local copy cleaned up today [18:18:13] will do [18:18:30] and it's ok to self merge that merge right? [18:18:38] yep! [18:21:45] dstrine: atgo: Sorry, I got ambushed by a 9am meeting thus am WFH [18:21:57] oh it's all good [18:22:18] office is packed anyway, I assume [18:22:40] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/239433 [18:23:07] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/239432 (owner: Cdentinger) [18:23:39] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/239433 (owner: Ejegg) [18:23:42] no worries! [18:24:00] ok cwdent, all set! [18:24:08] cool, gong [18:24:11] *i [18:24:17] err Fri deployment is happening? [18:24:39] awight: css + logging tweaks to non-active gateways [18:24:39] ooh it's friday [18:24:46] yeah... [18:24:48] :-\ [18:25:15] the people want their css tweak... [18:25:30] OK just to make the reasoning clear--you're free to be crazy whenever u want. but * gotta own any potential fallout over the weekend, and * if it involves any donor services load, that sux [18:25:31] ok, the amazon thing is more than a logging tweak [18:25:59] ok, taking a look at all the things touched here [18:26:05] yeah, i can pull the plug [18:26:47] I'm definitely not stopping you, just wanted to be sure I'm doing my cultural transmission piece [18:27:04] eh it's a good guideline [18:27:09] this is what i need: https://gerrit.wikimedia.org/r/#/c/239188/4/worldpay_gateway/forms/js/esop.js [18:27:30] Usually we limit deployments to critical bugfixing [18:27:53] changes are very contained! [18:27:53] Another way to look at this is, will anyone be testing the updated .js over the weekend? [18:28:24] well PPena said they wanted to see it today [18:28:24] I'd be curious to see Amazon working today... [18:28:29] kk [18:28:31] it just gets rid of a stupid inline style i put in [18:28:37] that is making the iframe look bad [18:29:03] no problem, just keep your weekend plans open :p [18:29:14] awight: did you notice that ejegg found out why those commented out css classes were blowing up jenkins? actually a change to mw core [18:29:21] my changes are bigger, but they just give us more info and not leave the donor hanging when any SDK calls throw an exception [18:29:35] and are strictly limited to amazon.adapter.php [18:29:50] Keep me out of it :) [18:30:03] heh [18:30:09] cwdent its ok if we dont change it today- I was just excited to see the new CSS [18:30:29] cwdent if it makes sense to deploy it on Monday, lets do that [18:30:39] PPena: we try not to deploy on friday, but this is so minor (famous last words) [18:30:48] i'll defer to ejegg [18:31:03] * awight pretends to look uninterested [18:31:11] cwdent: i'm inclined to go, just 'cause amazon is off already [18:31:11] lol [18:31:21] kk, hold my beer [18:31:23] heh [18:31:59] cwdent awight ejegg totally up to you guys! [18:32:01] mental note: keep syringe stocked with Thorazine in case the inmates get restive in December [18:33:27] * ejegg practices dodging tranquilizer darts [18:33:49] ejegg: saw some stuff in vendor change [18:34:07] on code update [18:34:11] ah, that's all permission changes [18:34:25] or should be, anyway [18:35:09] there certainly was no vendor change in those two patches merged since yesterday's last deploy [18:35:38] yeah i didn't see anything [18:35:49] I think the code_update script unsets some risky permissions after / during checkout [18:36:17] but yeah, those lines could make us miss real changes. Will add a task to make that less noisy [18:36:34] aaah gotcha [18:36:37] yeah ok, pushing out [18:36:53] all done [18:37:09] I see no changes / all i see is racist faces [18:37:34] PPena: new css is up! looks better [18:38:46] !log updated payments from 1bdd287b083032ff418434ad6bb6920735af918a to 4d9d165c40070e036176dba8987243f6dbc7415e [18:38:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:39:07] cwdent omg omg [18:39:12] uuuh smashpig failmail [18:39:20] ooh, lemme see [18:39:20] cwdent same link? [18:39:25] bet it's amazon [18:39:38] yep [18:39:40] PPena: yep! [18:40:46] I'm still amazed that you worked around WP's XML endpoint um not understanding XML... [18:41:03] cwdent Yay! still no CVV though? is it because its the french form? [18:43:24] cwdent ending to megan and Jessica so they can try again. Assuming the fraud stuff was dealt with? [18:43:40] PPena: yep it was just that we weren't providing a campaign [18:44:00] we'll see if they add CVV to the frame [18:44:12] but if not we'll just keep dinging them the 53 points [18:44:32] which won't make it fail as long as we provide a campaign and there aren't other fraud risk factors [18:45:18] awight: yeah that double encoding thing is a joke [18:46:42] well, I have a bit of work cut out for me... freaking IPN handler has to talk back to Amazon, so that's another whitelist request. And adapter isn't setting gateway txn id somehow [18:48:03] ejegg: was this just turned up by the extra logging, or is it a new problem? [18:48:16] Fundraising Sprint Queen, Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint The Pogues, and 3 others: Set up import for Major Gifts events payment/invitation tool - https://phabricator.wikimedia.org/T101191#1654266 (XenoRyet) @LeanneS That's definitely n... [18:50:18] Fundraising Sprint Queen, Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint The Pogues, and 3 others: Set up import for Major Gifts events payment/invitation tool - https://phabricator.wikimedia.org/T101191#1654280 (CCogdill_WMF) @XenoRyet Thanks! If it's... [18:51:26] cwdent: this was the first time I was able to get far enough to make a donation. [18:51:49] I gave an actual dollar, but it's not getting into Civi either of the ways it should [18:54:21] Fundraising Sprint Queen, Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint The Pogues, and 3 others: Set up import for Major Gifts events payment/invitation tool - https://phabricator.wikimedia.org/T101191#1654288 (atgo) @ccogdill_wmf what's the volume o... [18:55:16] cwdent so you are currently not hiding CVV... they really havent added it yet, correct? [18:55:54] Fundraising Sprint Queen, Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint The Pogues, and 3 others: Set up import for Major Gifts events payment/invitation tool - https://phabricator.wikimedia.org/T101191#1654302 (CCogdill_WMF) @atgo I don't have a good... [18:56:15] PPena: that's correct, i just checked the markup to be sure and it's not there [18:56:28] cool, will follow up with them [19:00:39] Fundraising Sprint Queen, Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint The Pogues, and 3 others: Set up import for Major Gifts events payment/invitation tool - https://phabricator.wikimedia.org/T101191#1654306 (CaitVirtue) I'd be surprised if it was... [19:02:17] Fundraising Sprint Queen, Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint The Pogues, and 3 others: Set up import for Major Gifts events payment/invitation tool - https://phabricator.wikimedia.org/T101191#1654315 (XenoRyet) @atgo @CCogdill_WMF I agree... [19:19:50] XenoRyet: not sure if you're already doing this, but it's always a good idea to do experimental imports on staging before production, cos of how difficult it is to delete corrupted data [19:23:57] Yea, probably should've done that before I let folks take a crack at the live one. I figured they wouldn't do anything they didn't know how to back out themselves, but that was probably not the safest assumption. [19:25:16] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1654371 (ellery) Is that really necessary? If so, this is an important use case you... [19:26:03] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: PayPal audit parser is not associating donations with the correct contribution_tracking record - https://phabricator.wikimedia.org/T113087#1654373 (awight) NEW [19:26:11] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: PayPal audit parser is not associating donations with the correct contribution_tracking record - https://phabricator.wikimedia.org/T113087#1654373 (awight) a:awight [19:27:38] XenoRyet: If nothing has been imported yet, it's not too late! [19:27:54] Have you deployed to staging CRM yet? [19:28:15] I don't think it has. They tried one, but I think it just flat failed, no corrupted import. [19:28:29] No, ejegg was going to help me with that but then we both got distracted. [19:32:53] Uncaught exception: Could not open extension /usr/lib/x86_64-linux-gnu/hhvm/extensions/current/fss.so: /usr/lib/x86_64-linux-gnu/hhvm/extensions/current/fss.so: cannot open shared object file: No such file or directory [19:32:53] ==> default: Error: composer self-update returned 255 instead of one of [0] [19:32:53] ==> default: Error: /Stage[main]/Php::Composer/Exec[update_composer]/returns: change from notrun to 0 failed: composer self-update returned 255 instead of one of [0] [19:33:08] ^ vagrant hmmm [19:34:58] AndyRussG: first ddg result is https://www.mail-archive.com/mediawiki-commits@lists.wikimedia.org/msg274339.html [19:35:01] heh [19:35:07] AndyRussG: have you updated mw-vagrant lately? [19:35:16] That was annoying, but should have been fixed recently [19:35:36] https://phabricator.wikimedia.org/T110257 [19:35:47] Ah, not merged yet [19:35:49] awight: cwdent: just did a git pull in my vagrant directory before spinning up a totally fresh instance [19:36:02] Well, that particular error goes away on the second run :( [19:36:32] Oh, that the vagrant up, then vagrant provision thing? [19:36:50] awight: ah K thanks. Yes, it did last time. Since I had some issues before, I was wondering if that was related [19:37:56] I think I applied that patch and still got the bug, but I got pushed off looking into it before I could look into it more than just the one try at vagrang up. I'll try again when I get a moment. [19:38:01] oooh [19:42:02] I just merged the fss.so fix, for the next time one of us destroys and rebuilds vagrant. [19:46:32] awight: thx! [19:51:41] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Amazon donation messages not setting gateway_transaction_id - https://phabricator.wikimedia.org/T113089#1654423 (Ejegg) NEW a:Ejegg [19:54:09] aargh, hosed my local unit test setup! Cannot redeclare class FakeMaintenance??? [19:54:25] wat [19:54:28] how? [19:54:46] i switched to master and back to fundraising/REL1_25 [19:55:00] nuking vendor and re-doing composer update both times [19:55:03] make sure there's nothing unchecked in, then git clean -fd? [19:55:20] that sounds like it should be harmless [19:55:22] yeah, let's see what that does [19:55:22] try composer install rather than update? [19:55:29] that will wipe everything btw [19:55:33] that isn't in git [19:55:42] awight: I think core doesn't check in composer.loc [19:55:43] k [19:56:00] so switching branches gives you the mismatched .json / .lock error [19:56:18] core-master doesn't check it in, but we do [19:56:27] ooh, right! [19:56:31] lemme try that [19:58:10] thpbpht. FakeMaintenance error [19:58:26] how are you invoking the tests? [19:58:34] that screwy makefile [19:58:36] I remember getting some dup class errors depending on the cli [19:58:39] ah oh god [20:00:36] This works for me: php tests/phpunit/phpunit.php --group DonationInterface [20:00:45] ejegg: fwiw i found out the reason the makefile works is it's wrapping the phpunit call so you can just do: php /srv/core/tests/phpunit/phpunit.php --configuration /srv/core/tests/phpunit/suite.xml --group DonationInterface [20:01:12] mfw http://i.imgur.com/ZlUUWAf.gif [20:01:16] yeah, same dang thing for either of those [20:01:29] ahh, bubbles [20:02:02] and grep -r FakeMaintenance only turns up that class definition once... [20:12:12] (PS1) AndyRussG: Add mw.centralNotice.getData() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/239449 [20:12:33] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Amazon donation messages not setting gateway_transaction_id - https://phabricator.wikimedia.org/T113089#1654511 (Ejegg) [20:12:34] Fundraising-Backlog: [EPIC] Amazon embedded 1-hour test version - https://phabricator.wikimedia.org/T108106#1654510 (Ejegg) [20:12:37] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Handle Amazon SDK client communication failures and any other error that bubbles up to the Mediawiki API - https://phabricator.wikimedia.org/T112924#1654512 (Ejegg) [20:12:49] Fundraising-Backlog: [EPIC] Amazon (embedded) internal test - https://phabricator.wikimedia.org/T108102#1654514 (Ejegg) [20:12:50] Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, and 2 others: Handle result of Amazon API calls - https://phabricator.wikimedia.org/T108123#1654513 (Ejegg) Open>Resolved [20:12:57] Fundraising-Backlog: [EPIC] Amazon (embedded) internal test - https://phabricator.wikimedia.org/T108102#1512386 (Ejegg) [20:12:58] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Comb Amazon out of our Mustache - https://phabricator.wikimedia.org/T111424#1654515 (Ejegg) Open>Resolved [20:13:22] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Amazon donation messages not setting gateway_transaction_id - https://phabricator.wikimedia.org/T113089#1654423 (Ejegg) [20:13:35] (CR) jenkins-bot: [V: -1] Add mw.centralNotice.getData() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/239449 (owner: AndyRussG) [20:20:05] Fundraising-Backlog: donatewiki access for Trilogy - https://phabricator.wikimedia.org/T110038#1654537 (Pcoombe) @awight I'm not sure what's "hand-wavy" about the fact that anyone can create an account on Commons and vandalise images that are potentially being seen by millions of people. It's been a [long st... [20:25:52] You should hear the gross things I say at the dinner table!! [20:26:14] My kids then join in and Mariana's the only one who objects [20:30:58] (PS2) AndyRussG: Add mw.centralNotice.getData() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/239449 [20:35:26] Fundraising-Backlog, fundraising-tech-ops: Outdated cert on GC iframe? - https://phabricator.wikimedia.org/T112990#1654628 (atgo) @jgreen what do you think about this? [20:38:23] Fundraising-Backlog: donatewiki access for Trilogy - https://phabricator.wikimedia.org/T110038#1654656 (awight) Sorry, I didn't mean to imply that the security concerns were vague. I'm not convinced personally, as other campaigns are using unprotected commons images and I'm not aware of any issues, but I'll... [20:44:30] (PS1) Ejegg: Update Pay with Amazon SDK to dev-master [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/239454 [20:46:17] (CR) Ejegg: [C: 2 V: 2] "self-merging library update" [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/239454 (owner: Ejegg) [20:47:58] (PS1) Ejegg: Update PayWithAmazon to dev-master [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/239456 [20:48:29] (CR) Ejegg: [C: 2] "self-merging library update" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/239456 (owner: Ejegg) [20:48:31] (Merged) jenkins-bot: Update PayWithAmazon to dev-master [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/239456 (owner: Ejegg) [21:21:28] eileen: Hope you're having a Saturday! [21:22:06] awight: yeah - just turned my laptop on to clear emails & stuff [21:22:15] will turn it off in a mo [21:22:32] ah glad to hear it ;) I'll save this question for Monday! [21:22:43] you can ask if you want… [21:22:52] mmmpf! [21:24:38] I was conisdering mass deleting a bad batch of imported contributions... I've talked myself into a different approach, though, just repairing the data in-place. [21:25:40] hmm - contribution data gets more complex after 4.2 - but in 4.2 it’s not too scary [21:26:10] I'd want to remove the contacts, too. [21:26:45] can’t you just delete them via the UI? [21:27:13] In the long term, my plan is that there's an option when importing contacts + contributions, that refines data if it already exists. [21:27:26] sort of an immediate dedupe [21:27:34] eileen: naw, this is thousands [21:28:13] The merge import could be used by IPN listener and audit jobs. [21:29:08] yeah - I guess that’s already possible kind of at least for contacts, for contributions ifyou have the contribution ID is is [21:29:44] Cool! Looking forward to learning [21:30:26] I think I would probably choose in order - delete through the UI & re-import, repair via sql & delete via sql & re-import [21:30:47] the FKs are pretty good on #3 - but not 100% [21:30:53] I expect [21:30:58] yeah that really scares me [21:31:11] I've definitely hosed my dev database to the point that Civi won't run [21:31:51] :-) [21:31:57] what is wrong with the import? [21:33:20] It turns out, the PayPal audit file parser hasn't been associating contributions with our tracking table, which is required for banner test results. [21:33:33] hmm [21:33:59] Usually, this would only affect 0.5% of donations so we overlooked the issue, but the IPN listener went down recently, so this was our last-ditch source [21:34:10] ooh, I was wondering how all the other gateway IPNs hooked up utm stuff [21:34:33] I think it's always just contribution_tracking.id [21:34:57] oh, does the ipn listener query ct? [21:35:07] We need to clean that up btw, it's a problem that Civi forces us to make a unique trxn_id [21:35:44] because any sequence generator would be a SPOF? [21:35:51] ejegg: it could if needed, but I don't think so. IIRC the real-time listener just passes through contribution tracking ID [21:36:09] k [21:36:18] no way, atomic sequences are available all over [21:36:52] err, s/atomic/robust [21:37:42] what's the problem with needing a unique id then? [21:37:52] yeah we could probably get a schema change in core to make unique transacaction id per processor pretty easily (easy to explain the need) - need to explain rationale more to go further [21:38:21] My problem is that we already have unique IDs on each table, so it's just confusing to be mainting extra shit appended to the end of the gateway_txn_id [21:38:34] *maintaining [21:39:09] the join to contribution id uses trxn_id rather than the table id I think [21:39:11] oh, gotcha [21:39:11] :-( [21:39:21] eileen: unfortunately, processors are different about their txn_ids, for some they are reused [21:39:27] yeah [21:39:29] e.g. when refunding [21:39:42] or with subscription charges [21:40:33] do they *all* have some extra unique identifier in that case - an action or anything - or not even that? [21:40:48] I think the contribution_recur table has a similar issue, we should be storing the upstream txn_id but we have to concatenate with gateway name and sometimes timestamp in order to satisfy the schema [21:41:12] eileen: I'm not convinced that a global unique ID makes sense for financial stuff [21:41:52] Each entity already comes with keys that make it easy to address the third charge and so on [21:42:07] hmm - I think we should try to sort that out in the CiviCRM schema - although not for 4.6 [21:46:57] (PS1) Ejegg: Amazon: Set txn id on $this->transaction_response [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239505 (https://phabricator.wikimedia.org/T113089) [21:47:21] ^^^ ought to get the txn ID right on the Amazon donation queue messages [21:48:53] ok - I’m going to go do Saturday stuff - catch you next week [21:51:49] (PS1) Awight: Parse and send the contribution tracking ID, if available [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/239507 (https://phabricator.wikimedia.org/T113087) [21:52:23] see ya! [21:53:59] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Design better unique ID regimen for CiviCRM - https://phabricator.wikimedia.org/T113102#1654958 (awight) NEW [21:56:42] (CR) Krinkle: "A few minor issues. Let me know what you think." (4 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/237526 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG) [22:04:07] Fundraising-Backlog: Recharge minFraud account - https://phabricator.wikimedia.org/T113105#1655014 (awight) NEW a:awight [22:06:42] I'd like to deploy https://gerrit.wikimedia.org/r/239507 today, if anyone can CR [22:11:26] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Analytics-EventLogging, and 2 others: Beta Cluster EventLogging data is disappearing? - https://phabricator.wikimedia.org/T112926#1655055 (greg) >>! In T112926#1650405, @Ottomata wrote: > Please use that insta... [22:12:11] ejegg: XenoRyet: cwdent: ^ [22:14:31] it seems the tables have turned [22:15:02] phooey, i gotta run [22:15:14] i'll take a look [22:16:46] :) thanks [22:17:10] Feel free to emphasize the fact that I'm cray [22:17:59] heh, looks harmless [22:18:47] not familiar with this repo but two non-voting checks fail...anything to worry about? [22:18:50] What could go wrong [22:19:01] ooh, a leg! there might be a leg down there [22:19:13] checking... [22:19:51] Build step 'Execute shell' marked build as failure [22:19:52] yeah it looks chronic, there's nothing in the files I touched at least [22:19:55] wat [22:20:06] oh yeah, [22:20:14] for both of em [22:20:16] needs cleanup but it's not caused by this patch [22:20:24] Those are linting [22:20:35] word [22:20:45] (CR) Cdentinger: [C: 2] Parse and send the contribution tracking ID, if available [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/239507 (https://phabricator.wikimedia.org/T113087) (owner: Awight) [22:20:46] pyflakes is pretty close, we should do that and set the job to voting [22:21:02] thanks for enabling my self-destruction! [22:21:07] hehe [22:50:56] awight: ejegg|away: cwdent: XenoRyet: if you're interested, I'm talkign to Krinkle on wikimedia-perf about the kvStore TTL. Looks like we have to redo it because of a few issues, especially multiple tabs open from the same site [22:59:08] lol, that abbreviated chan name cracks me up every time [22:59:23] "we saved you six characters." [23:04:54] it's...perf [23:05:37] awight: i just left some comments in that doc megan sent, actually there's a technical question or two [23:06:27] Yes I perf understand the perf benefits of perf(unctorily) cutting out the fat [23:10:10] (PS1) Awight: One-off script to repair payment audit import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/239516 (https://phabricator.wikimedia.org/T113087) [23:11:14] heheh not bad [23:13:01] (PS1) Awight: Merge master into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/239518 [23:13:11] (CR) Awight: [C: 2] Merge master into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/239518 (owner: Awight) [23:13:14] (Merged) jenkins-bot: Merge master into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/239518 (owner: Awight) [23:22:21] !log update fundraising-tools from 3e0e3ae799a507b378d0ece3e71631b10b361329 to e1b60fa2c258fd4ff55905b03a4d8886132278c1 [23:22:28] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:23:50] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: PayPal audit parser is not associating donations with the correct contribution_tracking record - https://phabricator.wikimedia.org/T113087#1655205 (awight) Fix to the audit parser is deployed. The one off s... [23:28:50] Fundraising-Backlog, fundraising-tech-ops: Paypal IPN processing is broken - https://phabricator.wikimedia.org/T112919#1655215 (awight) p:Triage>High [23:29:36] Fundraising-Backlog, fundraising-tech-ops: Paypal IPN processing is broken - https://phabricator.wikimedia.org/T112919#1650111 (awight) @Jgreen: It looks like one of PayPal's API servers is in a new net block? We need to connect to ipnpb.paypal.com but it's unreachable from barium. [23:30:06] awight: per ccogdill's comment in that email the WP donation is in civi, that must mean the queue jobs are working? [23:30:17] :) [23:30:28] it was cool to find it there! [23:30:57] yeah i am glad to see that! i wasn't sure if they'd make it to civi without extra fiddling [23:34:52] Speaking of civi... [23:35:40] I got both Leanne's file and my test file to import perfectly on local, and both to fail in the manner she described on staging, so it's not to do with the file. [23:36:08] cool XenoRyet, that’s good news! I’ll check with Leanne on Monday and make sure she was using the right file [23:36:25] oh wait - I misread that [23:36:29] I'm sure she was. [23:36:39] This is looking like a different issue. [23:36:48] got it [23:36:57] cwdent: awesome! [23:37:20] XenoRyet: hopefully it's something simple. Sorry, did you try: [23:37:30] just keep us updated, XenoRyet. Invites are going out Monday, so we’ll be getting contributions soon [23:37:36] cd drupal; drush cc registry [23:37:47] Ugh, another totally unacceptable gotcha. [23:38:00] Anyway, I was going to ask, when I made code changes locally I had to update the modules to get them to take. Is there something similar that needs done when this kind of thing gets deployed? [23:38:00] Drupal has its own class registry, and you have to purge this whenever deploying new classes. [23:38:21] FYI Trilogy has a portal we can use to manage donation data in the meantime so I don’t think it’s the end of the world if it’s not working ASAP [23:40:01] awight: if u have a second for more multitasking, maybe I could run past you ejegg|away's thoughts on the banner history ID? It was, DI sends the bh id to a queue, I think ejegg|away said, one that's handled by CRM [23:40:32] That provoked progress. Now it's complaining that the 'Trilogy' payment insturment is not found. [23:41:35] AndyRussG: I'm reading through the doc you sent, and the global banner history log fits perfectly, don't you think? [23:41:56] XenoRyet: woohoo! Have you run 'drush -v -v updatedb' [23:42:10] Nope, I'm guessing that's gonna do it. [23:42:38] AndyRussG: That would be perfect, it would be handled like the other utm_- params [23:43:37] Yea, that's gonna get it I think. it asked to update and add the payment insturment. That was the bit I was missing, did that all via the UI on my local, didn't know the drush commands. [23:44:24] awight: one sec, my clipboard is a singleton and doesn't multitask or multitopic [23:44:42] Ok, files going into staging properly now. [23:45:04] drush is a monstrosity, but one hairy paw better than the UI [23:45:09] awesome, nice work! [23:45:17] awight: [23:45:17] [23:45:18] DonationInterface could drop a message in another queue [23:45:18] and it could be inserted into a table by the consumer for the stats tables, like payments-initial and payments-fraud [23:45:18] I think those consumers are in CRM, but let me confirm [23:45:18] [23:45:30] So how do we fix production? Just log in and run those commands? [23:45:42] yep! [23:46:29] AndyRussG: Are you still planning to do the work on the other side of our shop? [23:47:10] awight: I'm gonna try! if you have some specific tips and pointers to start I'm more than happy to hear 'em :) [23:47:35] * XenoRyet looks around for where he just read what server production civi lives on [23:47:39] Cool! Sure, I'm happy to do it the way ejegg suggests too, but I think it would be simpler to add a column to contribution_tracking. [23:47:43] No extra queue required [23:48:22] We pass the BH id as the utm_banner_history param or something, then the few pieces of code responsible for creating and updating contribution_tracking just copy that into the new column. [23:49:23] awight: the reason for not adding a column to contribution_fracking is privacy. We're not flagging specific amounts or any other details, just where they got in the donation process [23:49:30] * AndyRussG is ignorant, not sure if that makes sense [23:50:06] I don't quite get it [23:50:18] What are we flagging? [23:51:21] I was imagining we want to associate the contribution with the banner history ID [23:52:19] awight: no, Ellery confirmed that's not where he's going. We're signaling whether a banner history resulted in a donation vs. just a click on donate [23:52:22] According to our privacy policy, we could make that association as soon as the user begins the donation pipeline. A more conservative place to make the link would be as the donation is imported into the CRM [23:52:43] Resulted in a successful donation? [23:53:21] awight: yeah I think so. Or at least, they went through the entire process [23:53:41] Though I imagining removing fraud attempts from the data would be useful, come to think of it... [23:56:09] I think the plan will depend on exactly where in the donation pipeline we want to mark the banner history as having donated. [23:56:22] yeah indeed [23:56:24] But to keep it simple, we could use EventLogging for that, I suppose! [23:56:45] awight: hmm I think EL isn't installed on the wiki in question? [23:57:05] Though maybe installing it is simpler than anything else? [23:57:06] Good point. [23:57:28] yeah maybe best to keep those wikis as lean as possible [23:57:32] Probably not, cos we wouldn't want to send to the central WMF server, so would have to run one of those too [23:57:41] heh indeed [23:58:29] I like the idea of passing the BH id on to the queue consumer, cos DonationInterface like you're saying should not take on extra responsibilities [23:59:20] We don't have EL in the queue consumer either... Never mind my "keep it simple" stupidity [23:59:53] not stupidity!