[00:07:20] <wikibugs>	 Fundraising-Backlog, Release: make-wmf-branch should cut wmf/* branches from named extension deployment branches - https://phabricator.wikimedia.org/T113428#1664788 (awight) NEW
[00:08:22] <awight>	 Anyone want to kick this so we don't have to go into it every week?  https://gerrit.wikimedia.org/r/#/c/230705/4
[00:09:06] <ejegg>	 awight: needs manual rebase
[00:09:33] <krrrit-wm>	 (PS5) AndyRussG: KVStore: batched, more resilient implementation of TTL for items [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385)
[00:09:44] <K4-713>	 Seriously though, how is this only just coming up?
[00:10:26] <awight>	 K4-713: it's been a few times now.  I had the same conversation with Krenair a month ago, apparently, which is where that patch came from.
[00:10:42] <awight>	 I'm glad someone said something--it seems it's eating a hole in people's hearts
[00:10:51] <awight>	 I don't blame them
[00:10:59] <K4-713>	 Ideally we'd hear about it before they seem to want to light us on fire.
[00:11:08] <K4-713>	 ...but okay.
[00:11:12] <awight>	 but I still get to smash fingers when I see random people effing with our deployment branches
[00:11:18] <K4-713>	 Well, yeah.
[00:11:19] <awight>	 and self-merging without discussion
[00:11:33] <K4-713>	 That's punishable by... oooh, large fines.
[00:12:48] <krrrit-wm>	 (CR) AndyRussG: KVStore: batched, more resilient implementation of TTL for items (4 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG)
[00:13:29] <krrrit-wm>	 (CR) AndyRussG: KVStore: batched, more resilient implementation of TTL for items (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG)
[00:14:43] <krrrit-wm>	 (CR) AndyRussG: "Many thanks!!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG)
[00:19:05] <wikibugs>	 Fundraising-Backlog: DonationInterface "deployment" branch should be renamed - https://phabricator.wikimedia.org/T113430#1664828 (awight) NEW
[00:21:28] <krrrit-wm>	 (CR) Krinkle: KVStore: batched, more resilient implementation of TTL for items (4 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG)
[00:29:06] <awight>	 K4-713: oh we definitely have been taking advantage of cherry-picking on deployment, but glad to hear it doesn't keep you up at night :)
[00:30:12] <K4-713>	 HA
[00:30:15] <K4-713>	 ...well, good.
[00:30:19] <K4-713>	 Use what you got.
[00:30:42] <K4-713>	 I mean, if we have to have that headache in the first place.
[00:30:48] <K4-713>	 (yes)
[00:33:33] <wikibugs>	 Fundraising-Backlog: DonationInterface "deployment" branch should be renamed - https://phabricator.wikimedia.org/T113430#1664852 (Krenair) A wmf/* name would restrict merge access to wmf-deployment, a fundraising/* name would restrict merge access to fundraising. I think you want fundraising/* (but obviously...
[00:34:14] <awight>	 I just spent ten minutes peeling gauze off in a way that minimized loss of glued, gooey flesh.  I'm gonna go sweep the house and find a brewski...
[00:38:39] <K4-713>	 Guuuuh.
[00:38:51] <K4-713>	 Blaaaaargh.
[00:40:12] <awight|afk>	 I don't wanna get dust on my servo actuators
[00:40:49] <atgo-away>	 ... wat?
[00:41:14] <atgo-away>	 i know i've been in & out, but the dog eye thing seems worse today so i'm going to take her to get checked out right meow
[00:41:36] <awight|afk>	 http://1.media.dorkly.cvcdn.com/78/46/5ae73cd3e1dff51e6f405f38487d921c.jpg
[00:41:39] <awight|afk>	 oh no!
[00:42:31] <K4-713>	 :(
[00:42:41] <K4-713>	 atgo-away: Good luck!
[00:43:03] <atgo-away>	 awight that poison oak looks like it's taken a turn for the awesome
[00:43:15] <krrrit-wm>	 (CR) Krinkle: KVStore: batched, more resilient implementation of TTL for items (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG)
[00:43:23] <K4-713>	 Yeah. Can I get some robot arm?
[00:43:29] <K4-713>	 Preferably two.
[00:43:39] <K4-713>	 I'd row funny with just one.
[00:43:45] <K4-713>	 ...circles.
[00:43:55] <K4-713>	 So many circles.
[00:44:17] <krrrit-wm>	 (CR) Krinkle: [C: -1] "I haven't verified, but I suspect the make*Function generator is not compatible with the fact that keys are removed during iterations. As " (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG)
[00:44:59] <wikibugs>	 Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: PayPal audit parser is not associating donations with the correct contribution_tracking record - https://phabricator.wikimedia.org/T113087#1664853 (awight) Oops, still need to backfill the broken association...
[00:49:10] <cwdent>	 awight|afk: i wasn't logged into operations so i have no scrollback but i guess i blew something up
[00:50:20] <awight|afk>	 it was silly.
[00:50:35] <awight|afk>	 Poor main cluster deployers have been skirting the DI deployment branch forever
[00:50:41] <cwdent>	 is deployment the wrong branch to merge into?
[00:50:48] <cwdent>	 sorry i've been a hot mess today
[00:50:56] <awight|afk>	 Nah it's fine, although we'll probably rename to avoid confusion.
[00:51:11] <awight|afk>	 But so our frack deployments were fucking with people doing wmf-cluster deployment
[00:51:26] <awight|afk>	 it looked like we were being sloppy and merging to deployment w/o actually deploying.
[00:51:58] <awight|afk>	 So going forward, we'll let DI go out to the main cluster with the usual train; we're only relying on it for access to translated messages from donatewiki templates.
[00:52:36] <awight|afk>	 That's the https://gerrit.wikimedia.org/r/#/c/230705 please do kick
[00:53:05] <awight|afk>	 or whatev, I think I made my point over there
[00:53:57] <cwdent>	 awight|afk: shoot ok so i should have deployed a different branch?
[00:54:59] <awight|afk>	 no, we're fine
[00:55:21] <awight|afk>	 The wmf main cluster shouldn't have been set up to cut releases from our deployment branch.
[00:57:00] <cwdent>	 what did i do that was funky?  don't we usually deploy that branch?
[00:57:09] <cwdent>	 "deployment"
[00:57:33] <awight|afk>	 it's fine!
[00:58:23] <awight|afk>	 What was happening was, we would do our fr-cluster thing and then the next time anyone went to deploy mediawiki on the main cluster, it would look like we started something we couldn't finish
[00:59:26] <cwdent>	 because DI on the main cluster was at an earlier revision?
[01:00:30] <cwdent>	 oh, because DI is on there just for the translations?
[01:00:38] <awight|afk>	 I think cos the main cluster release tool checks out our "deployment" version... but now that I'm thinking about it, I don't quite get that last step
[01:00:46] <awight|afk>	 yeah, DI is just there for donatewiki translations
[01:01:24] <awight|afk>	 https://donate.wikimedia.org/wiki/MediaWiki:Donate_interface-amount-error
[01:01:37] <cwdent>	 so they deploy the deployment branch...but there had been several merges to that branch since the last main cluster deploy?
[01:16:30] <cwdent>	 awight|afk: well i'm gonna sign off but let me know how i should adjust my workflow...i think it sounds like we should be using branches name something different than deployment?  anyway thanks for understanding my lack of understanding
[01:41:44] <awight|afk>	 cwdent|afk: The problem was entirely on the main cluster side...
[01:42:02] <awight|afk>	 Sorry you're so burned from the master/deploy snafu
[01:42:03] <awight|afk>	 :p
[01:51:08] <krrrit-wm>	 (CR) AndyRussG: KVStore: batched, more resilient implementation of TTL for items (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG)
[02:13:48] <krrrit-wm>	 (CR) AndyRussG: "> I haven't verified, but I suspect the make*Function generator is" (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG)
[03:05:20] <krrrit-wm>	 (PS6) AndyRussG: KVStore: batched, more resilient implementation of TTL for items [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385)
[03:08:35] <krrrit-wm>	 (CR) AndyRussG: "This PS: slurps an array of all keys at the outset, instead of relying on their numerical index." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG)
[03:27:44] <krrrit-wm>	 (CR) AndyRussG: "Hi @ori, follow-up on IRC: the other concern I have here is how this may interact with campaigns in progress during the migration, since w" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235979 (https://phabricator.wikimedia.org/T110353) (owner: Ori.livneh)
[03:28:51] <krrrit-wm>	 (CR) AndyRussG: [C: 2] "Thanks!! :)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234835 (owner: Glaisher)
[03:32:42] <krrrit-wm>	 (CR) AndyRussG: "Great idea, thanks!! Just one detail: usually we don't hard-code URLs into the source code, though (or at least, we shouldn't). What about" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234831 (owner: Glaisher)
[05:26:11] <krrrit-wm>	 (PS1) Eileen: T99836 Civi46: remove calls to pesudoconstant:phoneType [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/240303
[05:30:37] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] T99836 Civi46: remove calls to pesudoconstant:phoneType [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/240303 (owner: Eileen)
[06:30:01] <krrrit-wm>	 (PS1) Eileen: CRM-17156 do not log user id in unit test context [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/240307
[06:31:01] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] CRM-17156 do not log user id in unit test context [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/240307 (owner: Eileen)
[06:31:33] <krrrit-wm>	 (CR) Eileen: "argh - that's not right - I think the branch name is wrong - let me check" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/240307 (owner: Eileen)
[06:54:29] <krrrit-wm>	 (CR) Krinkle: [C: -1] KVStore: batched, more resilient implementation of TTL for items (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG)
[08:28:31] <krrrit-wm>	 (Abandoned) Eileen: CRM-17156 do not log user id in unit test context [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/240307 (owner: Eileen)
[08:31:46] <krrrit-wm>	 (PS1) Eileen: CRM-17156 do not log user id in unit test context [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/240320
[08:32:42] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] CRM-17156 do not log user id in unit test context [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/240320 (owner: Eileen)
[08:34:08] <krrrit-wm>	 (Abandoned) Eileen: T99836 Civi46: change contributionType to financialType [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/240288 (owner: Eileen)
[08:36:03] <krrrit-wm>	 (Abandoned) Eileen: T99836 Civi46 : change submodule version to 4.6.9 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/240156 (owner: Eileen)
[10:09:53] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team: [WMDE-Fundraising] Add validation api to the fundraising app - https://phabricator.wikimedia.org/T112063#1665765 (Tobi_WMDE_SW)
[10:10:06] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team: [WMDE-Fundraising] Add validation api to the fundraising app - https://phabricator.wikimedia.org/T112063#1624022 (Tobi_WMDE_SW)
[11:07:00] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Implement validator class for donations - https://phabricator.wikimedia.org/T112076#1665843 (Tobi_WMDE_SW)
[11:07:05] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Add validation api to the fundraising app - https://phabricator.wikimedia.org/T112063#1665844 (Tobi_WMDE_SW)
[11:07:55] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Implement general communication mechanism for the sensitive banner - https://phabricator.wikimedia.org/T112058#1665847 (Tobi_WMDE_SW)
[11:08:02] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Request CentralNotice adminship rights - https://phabricator.wikimedia.org/T112059#1665848 (Tobi_WMDE_SW)
[11:10:05] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Create entry point class/application for server requests coming from the sensitive banner - https://phabricator.wikimedia.org/T112061#1665853 (Tobi_WMDE_SW)
[11:10:11] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Implement basic tracking of the actual banner usage - https://phabricator.wikimedia.org/T112068#1665854 (Tobi_WMDE_SW)
[11:11:54] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-08-12, TCB-Team-Fundraising-Sprint-2015-08-26, TCB-Team-Fundraising-Sprint-2015-09-02, TCB-Team-Fundraising-Sprint-2015-09-10, and 3 others: [WMDE-Fundraising] Move Piwik to its own VM - https://phabricator.wikimedia.org/T105289#1665859 (Tobi_WMDE_SW)
[11:14:08] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Implement general communication mechanism for the sensitive banner - https://phabricator.wikimedia.org/T112058#1665862 (Tobi_WMDE_SW) p:Triage>Normal
[11:14:58] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Request CentralNotice adminship rights - https://phabricator.wikimedia.org/T112059#1665863 (Tobi_WMDE_SW) p:Triage>Normal
[11:15:08] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Add validation api to the fundraising app - https://phabricator.wikimedia.org/T112063#1665864 (Tobi_WMDE_SW) p:Triage>Normal
[11:15:12] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Implement validator class for donations - https://phabricator.wikimedia.org/T112076#1665865 (Tobi_WMDE_SW) p:Triage>Normal
[11:15:17] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Implement basic tracking of the actual banner usage - https://phabricator.wikimedia.org/T112068#1665866 (Tobi_WMDE_SW) p:Triage>Normal
[11:15:21] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Create entry point class/application for server requests coming from the sensitive banner - https://phabricator.wikimedia.org/T112061#1665867 (Tobi_WMDE_SW) p:Triage>Normal
[11:15:40] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Switch target URL of MCP iframe - https://phabricator.wikimedia.org/T113368#1665876 (Tobi_WMDE_SW)
[11:15:44] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Switch target URL of MCP iframe - https://phabricator.wikimedia.org/T113368#1663172 (Tobi_WMDE_SW)
[11:21:38] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-23: [WMDE-Fundraising] Deploy current master - https://phabricator.wikimedia.org/T113464#1665896 (Tobi_WMDE_SW) NEW
[11:24:34] <krrrit-wm>	 (PS2) Glaisher: Add help link to Special:CentralNotice and Special:CentralNoticeBanners/edit [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234831
[11:24:55] <krrrit-wm>	 (PS3) Glaisher: Add help link to Special:CentralNotice and Special:CentralNoticeBanners/edit [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234831
[11:25:49] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-23: [WMDE-Fundraising] Deploy current master - https://phabricator.wikimedia.org/T113464#1665911 (Tobi_WMDE_SW)
[11:27:09] <krrrit-wm>	 (CR) Glaisher: "It can now be overriden by using the relevant mediawiki messages (see commit message) as PS2 calls SpecialPage::addHelpLink() rather than " [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234831 (owner: Glaisher)
[11:29:42] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Deploy current master - https://phabricator.wikimedia.org/T113464#1665926 (Tobi_WMDE_SW)
[11:30:53] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Automate database updates for deployments - https://phabricator.wikimedia.org/T113465#1665927 (Tobi_WMDE_SW) NEW
[11:31:08] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Automate database updates for deployments - https://phabricator.wikimedia.org/T113465#1665934 (Tobi_WMDE_SW)
[11:32:37] <krrrit-wm>	 (PS2) Glaisher: Campaign: Add missing @param to documentation [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234835
[11:33:14] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Plan for automated code updates and configuration changes for deployment - https://phabricator.wikimedia.org/T113466#1665937 (Tobi_WMDE_SW) NEW
[11:34:03] <krrrit-wm>	 (CR) Glaisher: "I guess PS1 didn't go through because there was an unmerged dependency on it. Removed that in PS2 as this doesn't really depend on it." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234835 (owner: Glaisher)
[11:36:58] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Plan for automated code updates and configuration changes for deployment - https://phabricator.wikimedia.org/T113466#1665963 (Tobi_WMDE_SW)
[11:40:09] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Create PGP key pair for encryption - https://phabricator.wikimedia.org/T112067#1665968 (Tobi_WMDE_SW) p:Triage>High
[11:41:04] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Implement GET data encryption & decryption for data transmission between the banner and the fundraising app - https://phabricator.wikimedia.org/T112066#1665971 (Tobi_WMDE_SW) p:Triage>High
[11:50:25] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Deploy current master - https://phabricator.wikimedia.org/T113464#1665988 (Tobi_WMDE_SW)
[11:52:29] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Automate database updates for deployments - https://phabricator.wikimedia.org/T113465#1666008 (Tobi_WMDE_SW)
[11:52:51] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Plan for automated code updates and configuration changes for deployment - https://phabricator.wikimedia.org/T113466#1666009 (Tobi_WMDE_SW)
[11:53:21] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Implement general communication mechanism for the sensitive banner - https://phabricator.wikimedia.org/T112058#1666011 (Tobi_WMDE_SW) p:Normal>High
[11:53:28] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Add validation api to the fundraising app - https://phabricator.wikimedia.org/T112063#1666012 (Tobi_WMDE_SW) p:Normal>High
[11:53:34] <wikibugs>	 TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Implement validator class for donations - https://phabricator.wikimedia.org/T112076#1666013 (Tobi_WMDE_SW) p:Normal>High
[12:59:12] <krrrit-wm>	 (CR) AndyRussG: KVStore: batched, more resilient implementation of TTL for items (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG)
[16:04:58] <krrrit-wm>	 (CR) Awight: [C: 2] "Great! Tokens are hard..." [wikimedia/fundraising/crm/drupal] (contrib) - https://gerrit.wikimedia.org/r/240276 (owner: Ejegg)
[16:05:05] <krrrit-wm>	 (Merged) jenkins-bot: Upgrade to Drupal 7.39 upstream [wikimedia/fundraising/crm/drupal] (contrib) - https://gerrit.wikimedia.org/r/240276 (owner: Ejegg)
[16:36:13] <krrrit-wm>	 (PS7) AndyRussG: KVStore: batched, more resilient implementation of TTL for items [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385)
[16:38:31] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] KVStore: batched, more resilient implementation of TTL for items [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG)
[16:40:47] <krrrit-wm>	 (PS8) AndyRussG: KVStore: batched, more resilient implementation of TTL for items [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385)
[16:42:26] <krrrit-wm>	 (CR) AndyRussG: [C: -1] "This PS: A possible approach for the dicey key index bit. -1 'cause I'm still working out a couple issuies..." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG)
[16:53:20] <AndyRussG>	 issuies: plural of issuey, i.e. a small issue
[17:03:39] <wikibugs>	 Fundraising-Backlog: donatewiki access for Trilogy - https://phabricator.wikimedia.org/T110038#1666832 (Pcoombe) Open>Resolved a:Pcoombe Apologies, I hadn't realised admins had the access to do this! It's done now, I've created accounts for them and sent instructions on how to upload images.
[17:04:43] <wikibugs>	 Fundraising-Backlog: donatewiki access for Trilogy - https://phabricator.wikimedia.org/T110038#1666836 (awight) Awesome, thanks for doing the footwork!
[17:14:00] <AndyRussG>	 awight: cwdent: K4-713: dstrine: atgo-away: any comments on these very brief notes about our work over the past 7 days, for the scrum-of-scrums? https://etherpad.wikimedia.org/p/Scrum-of-Scrums
[17:14:11] <AndyRussG>	 (See the Fundraising Tech section under today's date.)
[17:14:18] <AndyRussG>	 Meeting starts in 15 min :)
[17:14:29] <atgo>	 looks good
[17:14:32] <cwdent>	 looks good AndyRussG
[17:14:41] <awight>	 u got it!
[17:14:49] <awight>	 Thanks for representing
[17:15:04] <AndyRussG>	 cwdent: atgo: awight: cool beans, muchas mercis
[17:15:26] <AndyRussG>	 np :) /me applies hair gel
[17:15:29] <krrrit-wm>	 (PS2) Awight: Prevent potential DOM-based XSS [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239427 (owner: Ejegg)
[17:15:30] <AndyRussG>	 jk
[17:16:22] <AndyRussG>	 awight: cwdent: ejegg|away: atgo: dstrine: pls lmk if you think of anything else you'd like me to bring up!
[17:17:44] <krrrit-wm>	 (CR) Awight: [C: 2] "Thanks! I took a look at the error strings too, and they look safe." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239427 (owner: Ejegg)
[17:17:51] <krrrit-wm>	 (PS3) Awight: Add mw.centralNotice.getData() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/239449 (owner: AndyRussG)
[17:18:02] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: JPMorgan Import Not Working - https://phabricator.wikimedia.org/T113381#1666882 (CaitVirtue) @Leanne - can you let @atgo know how quickly we need this fixed?  This week?
[17:18:33] <krrrit-wm>	 (Merged) jenkins-bot: Prevent potential DOM-based XSS [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239427 (owner: Ejegg)
[17:18:49] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: JPMorgan Import Not Working - https://phabricator.wikimedia.org/T113381#1666883 (CaitVirtue) Trying again, @LeanneS, can you let @atgo know how quickly you need this fixed?  This week?
[17:19:00] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: JPMorgan Import Not Working - https://phabricator.wikimedia.org/T113381#1666884 (atgo) @caitvirtue looks like my comments didn't go through. Sorry!! 9/30 is the new sprint start date. @leannes does that work for you? If not, let's escalate this to "Unbr...
[17:20:55] <krrrit-wm>	 (CR) Awight: [C: 2] Add mw.centralNotice.getData() (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/239449 (owner: AndyRussG)
[17:25:12] <krrrit-wm>	 (CR) Awight: Use Civi method to cancel recurring via qc (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/239900 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg)
[17:25:16] <krrrit-wm>	 (PS2) Awight: Use Civi method to cancel recurring via qc [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/239900 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg)
[17:28:57] <krrrit-wm>	 (PS1) Legoktm: Use valid spdx license identifier [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/240409
[17:34:24] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] Use Civi method to cancel recurring via qc [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/239900 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg)
[17:36:46] <awight>	 ejegg|away: youch, civicrm_activity is taking up 1GB
[17:37:15] <awight>	 eh I guess it's not so bad cos only a few hundred rows.
[17:38:07] <cwdent>	 dang those are some big rows
[17:38:10] <ejegg|semihere>	 whoa, a few hundred rows taking that much space?
[17:38:11] <awight>	 Jeff_Green: all those *export_temp* tables should be dropped, too
[17:38:25] <awight>	 hehe /me waves at air
[17:39:05] <ejegg|semihere>	 that will be a ton more rows if we ever use the civimail stuff
[17:40:05] <krrrit-wm>	 (CR) Awight: [C: 2] "Win! Donno why the tests are failing, though" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/239900 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg)
[17:40:35] <awight>	 yeah I was thinking that as well...  4k per contribution.  Could be worse
[17:41:11] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: JPMorgan Import Not Working - https://phabricator.wikimedia.org/T113381#1666993 (LeanneS) @atgo this should be fine, but could you prioritize it in the new sprint so that we can close out August numbers? Thanks!
[17:41:15] <awight>	 gah, civicrm_log at 13M rows
[17:41:28] <Jeff_Green>	 ejegg few hundred rows no, > 200M
[17:41:59] <Jeff_Green>	 i don't really understand how we can possibly have 200M rows worth of cached searches
[17:42:26] <awight>	 Jeff_Green: we were marveling at other bloated rows, civicrm_activity in that example
[17:42:30] <ejegg|semihere>	 that sounds right. activity table gets an entry for basically any interaction with a donor.
[17:42:45] <awight>	 but civicrm_prevnext_cache, yeah that's a crime
[17:42:48] <Jeff_Green>	 wow
[17:43:03] <ejegg|semihere>	 oh, 200m in activity or cache?
[17:44:20] <Jeff_Green>	 civicrm_prevnext_cache was 23M, not >200M that I originally said
[17:45:12] <awight>	 I see 11M
[17:45:28] <awight>	 Definitely nuking it, but wondering if we're looking at different things.
[17:45:32] <krrrit-wm>	 (Merged) jenkins-bot: Add mw.centralNotice.getData() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/239449 (owner: AndyRussG)
[17:45:33] <awight>	 I'm running "show table status"
[17:45:46] <Jeff_Green>	 oh, huh. i did select count(*)
[17:46:10] <awight>	 still 11M.  Maybe something was purged?
[17:46:20] <awight>	 though I doubt it :)
[17:46:30] <Jeff_Green>	 possibly replag. I checked lutetium
[17:46:36] <awight>	 truncating...
[17:46:58] <awight>	 rats, this is the innodb thing eileen was lookng into
[17:47:08] <awight>	 ah, 30s not terrible
[17:47:17] <Jeff_Green>	 what innodb thing?
[17:47:29] <krrrit-wm>	 (CR) Jforrester: [C: 2] Use valid spdx license identifier [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/240409 (owner: Legoktm)
[17:47:39] <Jeff_Green>	 awight lutetium reads 11.4M now
[17:48:12] <Jeff_Green>	 and now 1 :-)
[17:48:27] <awight>	 Jeff_Green: https://issues.civicrm.org/jira/browse/CRM-10700
[17:48:33] <awight>	 progress
[17:49:45] <Jeff_Green>	 what is an "FK" ?
[17:50:32] <ejegg|semihere>	 foreign key?
[17:51:15] <Jeff_Green>	 ah
[17:53:21] <Jeff_Green>	 awight are you done truncating tables? if so I'll start the dump again
[17:53:47] <awight>	 Jeff_Green: yep, all done!
[17:55:12] <Jeff_Green>	 great
[17:57:50] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] Use Civi method to cancel recurring via qc [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/239900 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg)
[18:12:03] <wikibugs>	 Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Backfill missing associations between PayPal audited donations and contribution_tracking - https://phabricator.wikimedia.org/T113503#1667140 (awight) NEW a:awight
[18:12:14] <wikibugs>	 Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Backfill missing associations between PayPal audited donations and contribution_tracking - https://phabricator.wikimedia.org/T113503#1667140 (awight)
[18:12:19] <wikibugs>	 Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: PayPal audit parser is not associating donations with the correct contribution_tracking record - https://phabricator.wikimedia.org/T113087#1667150 (awight)
[18:13:55] <krrrit-wm>	 (Merged) jenkins-bot: Use valid spdx license identifier [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/240409 (owner: Legoktm)
[18:18:20] <krrrit-wm>	 (CR) Aaron Schulz: "I meant "+channel:DBPerformance +message:*CNDatabase* +message:*writes*". Anyway, since that query has no results, then non of the GETs th" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234164 (https://phabricator.wikimedia.org/T92357) (owner: Aaron Schulz)
[18:32:10] <wikibugs>	 Fundraising-Backlog, Recurring-Donations: Make different monthly receipt for recurring donors - https://phabricator.wikimedia.org/T112966#1667262 (atgo) We're going to try to move along with this, @meganhernandez_wmf and @atgo to do design for monthly option.
[18:32:22] <wikibugs>	 Fundraising-Backlog, Recurring-Donations: Make different monthly receipt for recurring donors - https://phabricator.wikimedia.org/T112966#1667263 (atgo) a:MeganHernandez_WMF
[18:45:24] <krrrit-wm>	 (PS2) Ejegg: Delete PayflowPro [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/206339
[18:46:02] <krrrit-wm>	 (CR) Ejegg: [V: 2] "Sweeping out some Gerrit dust bunnies" [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/206339 (owner: Ejegg)
[18:47:40] <krrrit-wm>	 (Abandoned) Ejegg: Update minfraud API to 1.60 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/179039 (owner: Ejegg)
[18:49:48] <krrrit-wm>	 (Abandoned) Cdentinger: make a/b widget return some fake data [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/214084 (owner: Cdentinger)
[18:51:34] <cwdent>	 ejegg|semihere: what do you think of merging or abandoning these dash patchsets?  i can't imagine getting back to that task and finding them super relevant
[18:52:00] <cwdent>	 a new view of some sort might be a good idea for the slush
[18:52:08] <krrrit-wm>	 (PS3) Awight: Use DB slaves for Campaign reads on GET requests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234164 (https://phabricator.wikimedia.org/T92357) (owner: Aaron Schulz)
[18:52:14] <ejegg|semihere>	 man, it's been a while
[18:52:29] <cwdent>	 srs
[18:52:43] <ejegg|semihere>	 taking a look
[18:53:08] <cwdent>	 there's two: https://gerrit.wikimedia.org/r/#/c/215758/ https://gerrit.wikimedia.org/r/#/c/216343/
[18:53:34] <krrrit-wm>	 (CR) Awight: "I'm not sure we want to use the slave db for GET requests, could you explain the argument for that? I think the problem we're working aro" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234164 (https://phabricator.wikimedia.org/T92357) (owner: Aaron Schulz)
[18:56:44] <K4-713>	 Hey... who owns gerrit these days?
[18:56:52] <AndyRussG>	 K4-713: it's open source
[18:56:56] <K4-713>	 lol... I mean outs.
[18:56:59] <K4-713>	 *ours.
[18:57:05] <ejegg|semihere>	 cwdent: that a/b test one looks decent
[18:57:22] <AndyRussG>	 We already patented it? I guess that's why no one else uses it ;)
[18:57:26] <krrrit-wm>	 (CR) Ori.livneh: [C: 1] "Awight: the problem with replag is replag; working around it by hitting the master database isn't a sensible strategy, since it ultimately" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234164 (https://phabricator.wikimedia.org/T92357) (owner: Aaron Schulz)
[18:57:27] <K4-713>	 hargh
[18:58:11] <AndyRussG>	 ejegg|semihere: I forgot about SoS and missed it!! ...just kidding, it was all good
[18:58:25] <ejegg|semihere>	 heh, glad to hear it
[18:58:26] * AndyRussG makes a dash for the valley
[18:59:09] <AndyRussG>	 skips through the desert
[18:59:19] <AndyRussG>	 :)
[19:03:12] <awight>	 K4-713: what kind of gerrit issues?  You could ask QChris, or I usually just shout in #wikimedia-dev
[19:04:23] <K4-713>	 I'm already on the trail, but thanks.
[19:04:30] <krrrit-wm>	 (Abandoned) Ejegg: Prime [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/134859 (owner: Ssmith)
[19:05:47] <krrrit-wm>	 (Abandoned) Ejegg: WIP add datepicker libs and subview [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/147693 (owner: Ssmith)
[19:06:03] <krrrit-wm>	 (CR) Ori.livneh: [C: 2] "I can't see a plausible argument for why this isn't the right thing to do, so I can take the responsibility for this." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234164 (https://phabricator.wikimedia.org/T92357) (owner: Aaron Schulz)
[19:06:45] <krrrit-wm>	 (Abandoned) Ejegg: Fix requirejs loading + add SQL string to popover [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/148145 (owner: Ssmith)
[19:07:15] <krrrit-wm>	 (Merged) jenkins-bot: Use DB slaves for Campaign reads on GET requests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234164 (https://phabricator.wikimedia.org/T92357) (owner: Aaron Schulz)
[19:09:15] <krrrit-wm>	 (CR) Aaron Schulz: "If CN admins didn't see their own changes, that would be a ChronologyProtector bug (or it doing something very weird)." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234164 (https://phabricator.wikimedia.org/T92357) (owner: Aaron Schulz)
[19:11:14] <krrrit-wm>	 (CR) Awight: "@ori hehe, the problem was not that "no one is willing to take responsibility for pulling the trigger on this change"" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234164 (https://phabricator.wikimedia.org/T92357) (owner: Aaron Schulz)
[19:23:05] <awight>	 err, I may have sent a bunch of failmail
[19:50:41] <krrrit-wm>	 (Abandoned) Ejegg: push to github before committing refactor to knockout.js [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/149469 (owner: Ssmith)
[19:51:22] <krrrit-wm>	 (Abandoned) Ejegg: Add popover for SQL query access [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/147648 (owner: Ssmith)
[19:52:28] <krrrit-wm>	 (Abandoned) Ejegg: Modify fraud widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/147212 (owner: Ssmith)
[19:52:52] <krrrit-wm>	 (Abandoned) Ejegg: Add big english component [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/168323 (owner: Ssmith)
[19:53:46] <krrrit-wm>	 (Abandoned) Ejegg: Have Big English reload every 5 minutes [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/176991 (owner: Ssmith)
[19:54:22] <krrrit-wm>	 (Abandoned) Ejegg: Fix issue with label on USD/sec chart [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/177014 (owner: Ssmith)
[19:54:57] <krrrit-wm>	 (Abandoned) Ejegg: Format hourly totals to currency [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/177023 (owner: Ssmith)
[19:55:22] <krrrit-wm>	 (Abandoned) Ejegg: fix navbar padding on collapse [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/177024 (owner: Ssmith)
[19:55:31] <wikibugs>	 Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Backfill missing associations between PayPal audited donations and contribution_tracking - https://phabricator.wikimedia.org/T113503#1667628 (awight) {F2628896}
[19:56:06] <awight>	 ejegg|semihere: Wanna double-check the SQL ^ here
[19:56:21] <krrrit-wm>	 (Abandoned) Ejegg: Add the x-by-y chart widget [wikimedia/fundraising/dash] (X-by-Y-chart) - https://gerrit.wikimedia.org/r/178246 (owner: Ssmith)
[19:56:52] <ejegg|semihere>	 will do awight
[19:58:29] <krrrit-wm>	 (CR) AndyRussG: "@ori, with all due respect, I would have much rather you waited a little longer before merging. If something is high priority, please let " [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234164 (https://phabricator.wikimedia.org/T92357) (owner: Aaron Schulz)
[20:00:06] <awight>	 AndyRussG: nicely said
[20:03:16] <awight>	 Gonna walk the dogs for a bit...
[20:07:00] <wikibugs>	 Fundraising-Backlog, Recurring-Donations: Create option for EOY receipt for recurring donors - https://phabricator.wikimedia.org/T103447#1667680 (MBeat33) We currently manually send Year-end donation summary emails at donor request, from giving@wikimedia.org. In Q3 2015, we sent ~38 of these, which, thou...
[20:08:39] <atgo>	 awight|walk: dogS?
[20:11:58] <krrrit-wm>	 (CR) Aaron Schulz: "By the way are there phab tasks for the previous complaints people had? Those could be useful." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234164 (https://phabricator.wikimedia.org/T92357) (owner: Aaron Schulz)
[20:13:06] <wikibugs>	 Fundraising-Backlog: Teach ccogdill to get failed payment data through grep - https://phabricator.wikimedia.org/T113268#1660337 (atgo) @ejegg @awight can you update the name of this task to reflect the new reality please?
[20:20:06] <wikibugs>	 Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1667748 (MeganHernandez_WMF) Hey @Jgreen checking to see if the impression numbers...
[20:23:21] <wikibugs>	 Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1667761 (Jgreen) >>! In T97676#1667748, @MeganHernandez_WMF wrote: > Hey @Jgreen ch...
[20:25:17] <wikibugs>	 Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1667768 (ellery) @jgreen do the banner impression numbers in the table  pgheres.ban...
[20:27:38] <atgo>	 cwdent: that cvv thing is enormous! goodness.
[20:27:46] <atgo>	 worked for me, no scrolling
[20:30:00] <wikibugs>	 Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Backfill missing associations between PayPal audited donations and contribution_tracking - https://phabricator.wikimedia.org/T113503#1667780 (Ejegg) SQL looks good to me.
[20:30:30] <atgo>	 hey awight|walk do you think you'll be in tomorrow?
[20:30:59] <awight>	 atgo: No, I'm daying off.  Anything I can do though
[20:31:08] <atgo>	 we have a lunch?
[20:32:03] <awight>	 oh sorry!  What's the agenda?
[20:35:35] <dstrine>	 awight: nothing formal but since atgo is ditching up I'll find a time way in the future
[20:35:45] <dstrine>	 *ditching us
[20:36:00] <awight>	 ditching in what way?  don't scare me
[20:36:47] <wikibugs>	 Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Analytics-EventLogging, and 2 others: Promise returned from LogEvent should resolve when logging is complete - https://phabricator.wikimedia.org/T112788#1667801 (Ejegg) @awight, did you move this by mistake?...
[20:38:35] <wikibugs>	 Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Analytics-EventLogging, and 2 others: Promise returned from LogEvent should resolve when logging is complete - https://phabricator.wikimedia.org/T112788#1667810 (awight) Sorry, it looks like I never CR+1'd eve...
[20:39:16] <wikibugs>	 Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Analytics-EventLogging, and 2 others: Promise returned from LogEvent should resolve when logging is complete - https://phabricator.wikimedia.org/T112788#1667814 (Nuria) @ejegg Thank you for your changes , sorr...
[20:45:34] <wikibugs>	 Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1667863 (Jgreen) >>! In T97676#1667768, @ellery wrote: > @jgreen do the banner impr...
[20:48:00] <wikibugs>	 Fundraising-Backlog: iFrame should be in French - https://phabricator.wikimedia.org/T113527#1667886 (atgo) NEW
[21:04:14] <wikibugs>	 Fundraising-Backlog: [BUG] Donation form stuck with 0 as donation amount; donors can't modify it - https://phabricator.wikimedia.org/T113530#1667947 (MBeat33) NEW
[21:05:53] <wikibugs>	 Fundraising-Backlog: [BUG] Donation form stuck with 0 as donation amount; donors can't modify it - https://phabricator.wikimedia.org/T113530#1667956 (awight) That's bad.  Let's start by putting in logging for this conditionl
[21:14:06] <krrrit-wm>	 (PS9) AndyRussG: KVStore: batched, more resilient implementation of TTL for items [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385)
[21:15:40] <wikibugs>	 Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Backfill missing associations between PayPal audited donations and contribution_tracking - https://phabricator.wikimedia.org/T113503#1668021 (awight) Need one more script--this one removes the ct_id records which were created by...
[21:15:41] <awight>	 ejegg: One more ridiculous script, ^
[21:17:30] <ejegg>	 awight, AndyRussG : discussing need for logEvent promise over in -analytics
[21:17:50] <AndyRussG>	 ejegg: thx!
[21:17:55] <awight>	 k
[21:18:13] <AndyRussG>	 awight: no script is ridiculous
[21:18:27] <awight>	 :( no ewulczyn
[21:18:28] <AndyRussG>	 They have a right to their own logic
[21:18:46] <awight>	 AndyRussG: these are SQL to repair some stuff in Civi...  Really sketchy way to proceed.
[21:19:40] <cwdent>	 brb
[21:27:11] <wikibugs>	 Fundraising-Backlog: [BUG] Donation form stuck with 0 as donation amount; donors can't modify it - https://phabricator.wikimedia.org/T113530#1668076 (atgo) @mbeat33 do you know if they're coming in through banners, etc?  Scheduling this for Q2 work. Thanks!
[21:27:19] <Jeff_Green>	 awight: I think I have a fix for the mysql snafu. if we --skip-triggers on the mysqldump the bug-triggering DELIMITER lines won't be involved
[21:27:50] <wikibugs>	 Fundraising-Backlog: [BUG] Donation form stuck with 0 as donation amount; donors can't modify it - https://phabricator.wikimedia.org/T113530#1668077 (atgo) Also - do we agree that this is "unbreak now!" or is this something we can solve in the next sprint?
[21:27:52] <awight>	 ok, sort of great :)
[21:27:55] <Jeff_Green>	 I re-dumped both db's, currently loading dev_civicrm, when that's done I'll re-load dev_drupal
[21:28:09] <Jeff_Green>	 it actually sorta kinda makes sense to treat them separately, to me
[21:28:44] <awight>	 It's fine w/ me, sounds like the triggers are not totally essential
[21:28:47] <awight>	 for now
[21:28:59] <awight>	 so it's okay if they're inconsistent at some points
[21:29:04] <Jeff_Green>	 right, and they pretty much require root access
[21:29:22] <awight>	 as long as... the old triggers are dropped so we don't get any schema issues
[21:29:22] <Jeff_Green>	 i've always thought triggers should be though of as code, not data
[21:29:34] <awight>	 fo real
[21:29:34] <Jeff_Green>	 all the trigger stuff has to be done separately
[21:29:59] <awight>	 it's a little incongruously modern, that Civi wants to do dynamic trigger things
[21:30:16] <awight>	 ... almost like Civi got kidnapped and replaced
[21:30:27] <krrrit-wm>	 (CR) AndyRussG: "AFIK issuies should be solved in this PS..." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG)
[21:30:43] <Jeff_Green>	 ha.
[21:30:50] <Jeff_Green>	 meanwhile I have to run, dinner time
[21:31:24] <awight>	 chow!
[21:36:45] <wikibugs>	 Fundraising-Backlog: [BUG] Donation form stuck with 0 as donation amount; donors can't modify it - https://phabricator.wikimedia.org/T113530#1668108 (MBeat33) @atgo we're asking donors for urls/banners, but so far only have the one confirmed bulk email link. I would bet the US donor from today came via banne...
[21:36:46] <wikibugs>	 Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner history: always send a temporary log ID, and never send back two logs on the same pageview - https://phabricator.wikimedia.org/T113421#1668109 (atgo)
[21:36:49] <wikibugs>	 Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Fix banners on IE8 and IE9 - https://phabricator.wikimedia.org/T113013#1668110 (atgo)
[21:36:51] <wikibugs>	 Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: default to credit card (so it doesn't need to be in the url) - worldpay 1 hour test - https://phabricator.wikimedia.org/T112946#1668111 (atgo)
[21:45:18] <wikibugs>	 Fundraising-Backlog: [BUG] Donation form stuck with 0 as donation amount; donors can't modify it - https://phabricator.wikimedia.org/T113530#1668174 (atgo) p:Unbreak!>High I'm going to lower the priority to High and we'll look at it in the next sprint.
[21:57:44] <krrrit-wm>	 (PS14) Ori.livneh: Migrate to a terser cookie name and format [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235979 (https://phabricator.wikimedia.org/T110353)
[21:59:58] <cwdent>	 i didn't get the meeting reminder for chicken
[22:00:02] * cwdent fired
[22:02:15] <dstrine>	 anybody want some chicken?
[22:02:23] <dstrine>	 shrimp chicken that is ...
[22:03:05] <dstrine>	 AndyRussG:  ejegg : ?
[22:03:24] <AndyRussG>	 dstrine: hi!
[22:05:33] <ejegg>	 restarting browser
[22:18:30] <krrrit-wm>	 (PS10) Awight: KVStore: batched, more resilient implementation of TTL for items [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG)
[22:28:42] <wikibugs>	 Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: iFrame should be in French - https://phabricator.wikimedia.org/T113527#1668361 (DStrine)
[22:29:24] <wikibugs>	 Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Change "continue" button for credit card logos, suppress logos from within iframe - https://phabricator.wikimedia.org/T113304#1668365 (DStrine)
[22:32:03] <wikibugs>	 Fundraising-Backlog: Legacy PayPal IPN listener should syslog - https://phabricator.wikimedia.org/T113386#1668372 (DStrine)
[22:32:30] <wikibugs>	 Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Change "continue" button for credit card logos, suppress logos from within iframe - https://phabricator.wikimedia.org/T113304#1668377 (atgo) Hey @ppena can you let us know which logos we should be displaying and in which order?...
[22:32:48] <wikibugs>	 Fundraising Sprint Tom Waits, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Paypal IPN log is not replicated to log server? - https://phabricator.wikimedia.org/T113323#1668379 (awight) Open>Invalid a:awight Subtask is the real work.
[22:32:54] <wikibugs>	 Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Sample XML for a GC USD credit card donation - https://phabricator.wikimedia.org/T113365#1668382 (atgo) Open>Resolved
[22:35:19] <wikibugs>	 Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate: New banner messages not added to message group - https://phabricator.wikimedia.org/T106856#1668390 (DStrine)
[22:36:28] <wikibugs>	 Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, and 3 others: Publishing translations for central notice banners fails - https://phabricator.wikimedia.org/T104774#1668392 (DStrine)
[22:36:39] <wikibugs>	 Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Move shared client-side functions to an mw.something module - https://phabricator.wikimedia.org/T111436#1668394 (DStrine)
[22:36:40] <krrrit-wm>	 (Abandoned) Ejegg: Change font to SourceSansPro [wikimedia/fundraising/dash] (StyleTemplating) - https://gerrit.wikimedia.org/r/134950 (owner: Ssmith)
[22:38:21] <wikibugs>	 Fundraising-Backlog: [epic] worldpay  1 hour test in France - https://phabricator.wikimedia.org/T110113#1668403 (DStrine)
[22:38:22] <wikibugs>	 Fundraising Sprint Tom Waits, Fundraising-Backlog: Queue messages should be consumable. (worldpay 1 hour test) - https://phabricator.wikimedia.org/T112808#1668402 (DStrine) Open>Resolved
[22:38:23] <krrrit-wm>	 (Abandoned) Ori.livneh: Only call MobileContext::getMobileUrl() for non-relative URLs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/226751 (owner: Ori.livneh)
[22:47:15] <K4-713>	 cwdent: This is for you: http://knowyourmeme.com/photos/962640-this-is-fine
[22:47:23] <K4-713>	 It's about Worldpay.
[22:47:42] <cwdent>	 awesome
[22:49:47] <wikibugs>	 Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Nightly Amazon report download - https://phabricator.wikimedia.org/T109654#1668463 (atgo) p:Triage>High
[22:49:59] <wikibugs>	 Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Nightly Amazon report download - https://phabricator.wikimedia.org/T109654#1555302 (atgo)
[22:50:00] <wikibugs>	 Fundraising-Backlog: [EPIC] Amazon embedded 1-hour test version - https://phabricator.wikimedia.org/T108106#1668466 (atgo)
[22:50:07] <wikibugs>	 Fundraising-Backlog: [EPIC] Amazon embedded campaign ready version - https://phabricator.wikimedia.org/T108109#1668468 (atgo)
[22:50:08] <wikibugs>	 Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Nightly Amazon report download - https://phabricator.wikimedia.org/T109654#1555302 (atgo)
[22:58:11] <awight>	 LOL: how many times did you reboot?
[22:59:18] <awight>	 dstrine: thx ^
[23:04:45] <cwdent>	 awight: it seems like DI is eating a php error or something
[23:05:05] <cwdent>	 i keep getting {"errors":{"general":"There was an error processing your request."}} in this ajax call
[23:05:08] <cwdent>	 but nothing in any logs
[23:05:16] <awight>	 that's annoying
[23:06:14] <awight>	 That's not a PHP error though, it's a validation error
[23:06:32] <awight>	 We make all the errors generic so scammers don't get info back about their stolen cards
[23:06:48] <cwdent>	 ooh, interesting
[23:07:06] <awight>	 This is on production?
[23:07:24] <awight>	 I thought we syslogged the real errors
[23:07:29] <awight>	 the real validation errros
[23:07:50] <cwdent>	 nah on my box
[23:07:55] <cwdent>	 i bet i know what the problem is
[23:08:03] <cwdent>	 added card subtype
[23:08:05] <awight>	 cwdent: That one:             $this->logger->info( "Failed Validation. Aborting $transaction " . print_r( $this->getValidationErrors(), true ) );
[23:08:18] <awight>	 definitely worth the time to set up your box so you can see the syslogging
[23:08:46] <cwdent>	 awight: i definitely see stuff logged like that
[23:10:39] <awight>	 Hmm, maybe worldpay isn't calling the parent::do_transaction
[23:11:17] <awight>	 no, it is
[23:11:34] <awight>	 cwdent: so what's the ajax call that gives you an error but w/ no logging?  Sounds like a bug
[23:11:52] <ejegg>	 cwdent: that sounds like an uncaught exception
[23:12:07] <awight>	 It's caught enuf to output ajax
[23:12:09] <ejegg>	 no, sorry, nvm
[23:12:10] <awight>	 erm json
[23:12:37] <ejegg>	 api.php actually catches 'em all and returns some json
[23:12:46] <ejegg>	 but it wouldn't have our error message
[23:13:12] <awight>	 where is the catch?
[23:13:16] <cwdent>	 it's this action:di_wp_validate
[23:13:31] <ejegg>	 lemme see now...
[23:13:46] <awight>	 wow, I didn't realize we were actually using api.php like good citizens
[23:14:36] <awight>	 cool--add some logging to worldpay_gateway/worldpay.api.php line 28
[23:15:03] <awight>	 it can be the same as gateway_common/gateway.adapter.php line 1039
[23:15:50] <ejegg>	 ApiMain.php's executeActionWithErrorHandling
[23:16:47] <awight>	 I think it's actually coming from that worldpay.api.php line, cos it contains the error in json produced by DI
[23:18:32] <awight>	 ejegg: you have another minute to look at https://phabricator.wikimedia.org/T113503 ?
[23:18:55] <ejegg>	 oh right! will do
[23:18:58] <awight>	 I wanna get this data repaired today if possible, if only cos I'm taking Thursday off.
[23:19:01] <awight>	 thx!
[23:19:28] <cwdent>	 Cannot access protected property WorldpayAdapter::$logger
[23:19:34] <cwdent>	 is there a good reason that has to be protected?
[23:19:45] <awight>	 create a new one, a la...
[23:20:07] <ejegg>	 GatewayPage does
[23:20:15] <awight>	 DonationLoggerFactory::getLogger( $gateway );
[23:24:48] <krrrit-wm>	 (PS2) Awight: Update drupal and ctools [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/240279 (owner: Ejegg)
[23:25:00] <krrrit-wm>	 (CR) Awight: [C: 2] Update drupal and ctools [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/240279 (owner: Ejegg)
[23:25:36] <krrrit-wm>	 (CR) Awight: [C: 2] "self-merge is okay too!" [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/240277 (owner: Ejegg)
[23:25:47] <ejegg>	 awight: do you expect many of those rows to exist?
[23:25:54] <krrrit-wm>	 (PS2) Awight: Import refund data from CSV [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/239994 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg)
[23:26:12] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] Update drupal and ctools [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/240279 (owner: Ejegg)
[23:27:13] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] Import refund data from CSV [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/239994 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg)
[23:27:52] <awight>	 ejegg: maybe 5-10%, I didn't check how many but it looks like a minority
[23:27:57] <ejegg>	 ah, cool
[23:28:04] <awight>	 It was just the days when both the audit and IPN were down
[23:28:07] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] Merge branch 'contrib' - 7.39 update [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/240277 (owner: Ejegg)
[23:28:11] <awight>	 Want an example that isn't associated?
[23:28:22] <ejegg>	 gotcha.  Where did the '..Others' come from?
[23:28:35] <awight>	 select * from drupal.contribution_tracking where id=27799750;
[23:28:59] <awight>	 It seems that's a random PayPal field we pull in, in case any helpful source info was in there.
[23:29:06] <awight>	 "Others" is not what I was hoping for :)
[23:29:15] <ejegg>	 ah, hmm
[23:31:22] <ejegg>	 ok, that all looks solid
[23:31:42] <wikibugs>	 Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Backfill missing associations between PayPal audited donations and contribution_tracking - https://phabricator.wikimedia.org/T113503#1668715 (Ejegg) That one looks good too!
[23:32:16] <krrrit-wm>	 (CR) Awight: [C: 2] "Great, just two things commented inline, fine to wait for another patch." (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/239994 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg)
[23:33:03] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] Import refund data from CSV [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/239994 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg)
[23:33:32] <cwdent>	 Failed Validation. Aborting... Array (     [general] => There was an error processing your request. )
[23:33:37] <cwdent>	 sigh
[23:33:41] * cwdent opens xdebug
[23:34:34] <ejegg>	 grr, invalid contribution_type_id in all those crm CI tasks.  I notice drush updatedb says 'No database updates required' - that expected, awight?
[23:35:02] <awight>	 ejegg: did the schema change?
[23:35:32] <awight>	 didn't look like it from the Drupal 7.39 patch
[23:35:52] <ejegg>	 no, just forgot that we don't need to run all our install scripts on the db that CI restores
[23:36:57] <awight>	 Right, interesting... I think they're run earlier in the CI script by civicrm-buildkit, then that db is restored
[23:37:07] * awight scratches
[23:37:48] <awight>	 wow, I hadn't thought about that--so that's cross-job contamination
[23:41:16] <awight>	 AndyRussG: hi again :) yeah, donatewiki is a strange landing page world, where pcoombe makes donation forms entirely in wikitext template language.
[23:41:30] <awight>	 I'd like to stop that, but it's what we have currently
[23:41:37] <awight>	 Check it out: https://donate.wikimedia.org/w/index.php?title=Special:FundraiserLandingPage&country=US&uselang=en&utm_medium=spontaneous&utm_source=fr-redir&utm_campaign=spontaneous
[23:42:06] <ejegg>	 what about it?
[23:42:51] <awight>	 ejegg: moved a convo from -analytics, me and AndyRussG were chatting about how a redirect through donatewiki might be able to store the BH data
[23:42:56] <awight>	 to EL, server side
[23:44:08] <ejegg>	 and we can't add EL to paymentswiki cause we don't want it touching anything else?
[23:44:48] <awight>	 cos: too late in the year, I'm pretty confident Jeff_Green would not enjoy that, and also cos we don't want a pipe sending anything from frack to the main cluster
[23:44:57] <awight>	 and ellery shouldn't have to build his tools in frack
[23:44:59] <ejegg>	 yeah, makes sense
[23:45:50] <AndyRussG>	 awight: ejegg: the donate wiki is not where you go after a banner
[23:45:51] <AndyRussG>	 ?
[23:45:54] * AndyRussG checks a banner
[23:46:03] <awight>	 Most banners send people directly to paymentswiki now
[23:46:29] <awight>	 There was a period in which they would go to donatewiki, but now it's mostly for special effects (/me comes up empty-handed to explain what those might be)
[23:48:15] <wikibugs>	 Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Backfill missing associations between PayPal audited donations and contribution_tracking - https://phabricator.wikimedia.org/T113503#1667140 (awight) Should be done now.  @MeganHernandez_WMF, can you verify that the 9/16 PayPal...
[23:48:55] <AndyRussG>	 awight: ejegg: so the paypal button in a banner sent me directly to the PayPa site...
[23:49:24] <ejegg>	 yeah?  How the heck are we getting contribution tracking on that?
[23:50:22] <awight>	 AndyRussG: there's a quick redirect, try turning on "persist" in the network tab
[23:50:41] <AndyRussG>	 yeah just doing that
[23:50:55] <awight>	 Glad it looked invisible ;)
[23:51:18] <AndyRussG>	 https://payments.wikimedia.org/index.php/Special:GatewayFormChooser?uselang=en&language=en&currency_code=CAD&country=CA&paymentmethod=paypal
[23:51:24] <ejegg>	 aha!
[23:51:24] <awight>	 excellent.
[23:51:37] <awight>	 I think it even redirects twice, in that case.  Sad.
[23:52:09] <AndyRussG>	 Ah indeed https://payments.wikimedia.org/index.php?title=Special:PaypalGateway&appeal=JimmyQuote&ffname=paypal&recurring=&utm_medium=sitenotice&utm_campaign=&utm_source=B1516_0916_mlBELU_dsk_lg_dsn_ppl_blk.no-LP.paypal&language=en&country=CA&currency_code=CAD&utm_key=2&payment_method=paypal&frequency=onetime&amount=3&amountGiven=&uselang=en
[23:52:50] <awight>	 Interesting--fyi the GatewayFormChooser URL params are missing a lot of info, I think it comes in via POST
[23:52:59] <awight>	 just in case you wanted to email that around or anything.
[23:56:24] * awight rubs hands at the thought that AndyRussG might get into payments systems and fix our FUD
[23:56:46] <AndyRussG>	 awight: hmmm... I was doing a banner preview, maybe different if I simulated actually being in the campaign
[23:57:06] <awight>	 It'll be the same.
[23:57:11] <AndyRussG>	 In Soviet WMF, the FUD fixes you!
[23:57:18] <awight>	 yeah, the banner makes a combo GET+POST
[23:57:31] <AndyRussG>	 wut? how do you do that?
[23:57:40] * awight leaves a kopek by the Big Bro shrine
[23:57:56] <awight>	 it's a terrible practice.  You just post to an URL with params
[23:58:06] <AndyRussG>	 Ahhh right yes
[23:58:16] <AndyRussG>	 So really a POST
[23:58:23] <awight>	 I guess that's not technically a GET, true!  but get-style url params
[23:58:57] <AndyRussG>	 Heh a POST that really wanted to be a GET
[23:59:12] * AndyRussG represses self
[23:59:18] <awight>	 It's sad cos it means that there are multiple data paths in the banner code
[23:59:37] <AndyRussG>	 Trickle-down client-server architecture
[23:59:46] <ejegg>	 awight: so... if some other build nuked the refund and chargeback payment instruments, I just delete the whole workspace up on the CI box to get a fresh db rebuilt, right?