[00:00:39] err, the wikimedia-fundraising-civicrm folder anyhow [00:00:56] ejegg: ouch [00:01:01] yeah that's always fair game [00:01:16] but we got problems if we're really missing test isolation like that. Making a card... [00:02:14] On the bright side, I think the ur-database would be created before the test is run, so the contamination would just be from _install hooks, not the tests themselves. [00:03:07] phooey, no permissions and no sudo rm on CI slave 1011 [00:04:05] Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Config: Civi CI is using contaminated database dumps - https://phabricator.wikimedia.org/T113559#1668974 (awight) NEW [00:04:09] I haz [00:04:12] Lemme add you [00:04:16] thanks! [00:04:41] ah, I may be able to add myself via Nova... [00:05:11] I hope not... [00:05:18] oh, weird. [00:05:32] You have projectadmin for Ejegg, but Eeggleston is a regular member. [00:05:40] Should I erase ejegg and add yr formal one? [00:05:40] heh [00:05:47] well, I'm logged in as ejegg [00:05:55] I kinda like the short version... [00:06:04] * awight avoids looking at WMF-ness of accounts [00:06:28] awight: ejegg: after the redirect to the payment processors, how do would get back to our own sites with the banner history intact? [00:06:31] so, I'm gonna try adding myself on nova:sudoers [00:06:32] well, you should already have admin [00:06:34] k [00:06:55] yes that should work [00:07:54] wheee! dir nuked [00:08:04] mmm gotta sup, back in a bit and I'll get any backskrill [00:08:04] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Config: Civi CI is using contaminated database dumps - https://phabricator.wikimedia.org/T113559#1669000 (awight) [00:08:09] l8r! [00:08:21] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/239900 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg) [00:08:27] backskrill!! Already talking like a payments guru :p [00:10:59] ah, i guess recheck isn't magic for gate-and-submit [00:11:25] think we need to toggle the +2 on those [00:15:25] Want to ignore the failing tests? [00:15:51] sure, i'll just V+ them myself [00:16:04] This might be a real issue [00:16:48] it'll definitely get worse as the 4.6 work ramps up [00:17:01] (CR) Ejegg: [V: 2] "Tests failing due to https://phabricator.wikimedia.org/T113559" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/239900 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg) [00:17:34] I guess it failed cos you only nuked one server? [00:17:38] Do the tests pass locally? [00:18:00] no, i didn't actually re-trigger [00:18:10] looks like it did trigger, and failed [00:18:22] they pass on my local. ok! [00:18:41] oops [00:18:56] oh yeah, different server [00:19:14] We can always restrict the job to a single node to debug stuff like this... [00:19:20] But the issue is pretty clear [00:20:35] maybe add a different build job name for 4.6 branch for now? [00:20:49] good idea! [00:21:45] well... it's probably easier to just not restore the db [00:21:47] ever [00:22:07] guessing that means CI takes longer [00:22:17] (PS3) Ejegg: Import refund data from CSV [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/239994 (https://phabricator.wikimedia.org/T110367) [00:23:02] yeah, fine by me [00:23:26] (CR) jenkins-bot: [V: -1] Import refund data from CSV [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/239994 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg) [00:24:39] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/239994 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg) [00:24:51] meh, just kick it [00:25:19] want to see at least one of these pass! [00:25:27] :) [00:28:26] I'm no longer convinced the SQL is leaking between tests. [00:28:32] hmm [00:28:38] Note that the store and restore happen after the drush install [00:28:48] But I did find knobs to turn it off... [00:29:08] yeah, and I definitely nuked the dir on 1014 [00:31:56] (PS1) Awight: Prevent civicrm-buildkit from storing SQL dumps [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/240624 (https://phabricator.wikimedia.org/T113559) [00:35:09] Looking at your first change, it really couldn't have caused this failure [00:36:50] And the failure happened after my rebase! [00:37:24] new parent is "revert commits on wrong branch"... hmm, looking at that diff now [00:38:18] There was an unreverted 4.6 change [00:39:29] (PS1) Awight: Revert "4.6 upgrade preparation, replace contribution_type with financial_type" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/240625 [00:39:49] oho! [00:39:50] I'll rebase your change onto that just to see. [00:40:13] nah, actually I'll go walk in circles instead [00:40:21] Stop working! [00:40:50] heh, spent a long time semihere today, might stick around a lil bit [00:41:07] hehe I know the feeling [00:41:22] brb, then [00:41:32] (CR) Ejegg: [C: 2] "Good catch! Thought I had em all..." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/240625 (owner: Awight) [00:50:00] oops, gtg [01:10:42] (PS4) Ejegg: Import refund data from CSV [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/239994 (https://phabricator.wikimedia.org/T110367) [01:21:12] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Change "continue" button for credit card logos, suppress logos from within iframe - https://phabricator.wikimedia.org/T113304#1669268 (Ppena) yes that is correct! Thanks! [01:29:35] (PS1) Ejegg: Make refund import logic reusable [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/240630 (https://phabricator.wikimedia.org/T110367) [01:35:53] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Change "continue" button for credit card logos, suppress logos from within iframe - https://phabricator.wikimedia.org/T113304#1669314 (atgo) Here's a link for the CB file - this (and the rest) should be hosted already for the ol... [01:40:57] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/240277 (owner: Ejegg) [01:44:36] (CR) Ejegg: Import refund data from CSV (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/239994 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg) [01:46:16] (PS3) Ejegg: Update drupal and ctools [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/240279 [02:01:53] Fundraising-Backlog: Update WMF logo(s) in Amazon config - https://phabricator.wikimedia.org/T113563#1669382 (Ejegg) NEW [02:29:21] Fundraising-Backlog: Create tools to retrieve relevant information from logs in a useful format - https://phabricator.wikimedia.org/T113268#1669428 (Ejegg) [02:57:46] (PS11) AndyRussG: KVStore: batched, more resilient implementation of TTL for items [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385) [03:17:03] (PS15) Ori.livneh: Migrate to a terser cookie name and format [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235979 (https://phabricator.wikimedia.org/T110353) [05:25:50] (CR) Awight: "For the record, we determined that the issue was caused by a bad patch to application schema code. Looks like civicrm-buildkit makes the " [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/240624 (https://phabricator.wikimedia.org/T113559) (owner: Awight) [05:26:21] (PS2) Awight: Prevent civicrm-buildkit from storing SQL dumps [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/240624 (https://phabricator.wikimedia.org/T113559) [05:58:50] (CR) Awight: [C: 1] "Looks great" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG) [07:55:18] (CR) Siebrand: [C: 1] "i18n/L10n reviewed." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234736 (owner: Glaisher) [11:47:34] TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Switch target URL of MCP iframe - https://phabricator.wikimedia.org/T113368#1670342 (WMDE-leszek) a:WMDE-leszek [12:12:47] TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Switch target URL of MCP iframe - https://phabricator.wikimedia.org/T113368#1670428 (WMDE-leszek) Pull request on github: https://github.com/wmde/fundraising/pull/693 [12:18:38] TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Create PGP key pair for encryption - https://phabricator.wikimedia.org/T112067#1670445 (kai.nissen) a:kai.nissen [13:59:09] (PS1) Cdentinger: gather payment_submethod, show radio buttons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240699 [13:59:58] (CR) jenkins-bot: [V: -1] gather payment_submethod, show radio buttons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240699 (owner: Cdentinger) [14:03:03] (PS2) Cdentinger: gather payment_submethod, show radio buttons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240699 [14:54:25] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: PayPal audit parser is not associating donations with the correct contribution_tracking record - https://phabricator.wikimedia.org/T113087#1670872 (Pcoombe) [14:54:27] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Backfill missing associations between PayPal audited donations and contribution_tracking - https://phabricator.wikimedia.org/T113503#1670870 (Pcoombe) Open>Resolved Looks good, they're showing up for me. Thanks Adam! @Meg... [15:16:00] (PS12) AndyRussG: KVStore: batched, more resilient implementation of TTL for items [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385) [15:17:44] (CR) AndyRussG: KVStore: batched, more resilient implementation of TTL for items (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240170 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG) [15:51:02] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Analytics-Backlog, and 3 others: Promise returned from LogEvent should resolve when logging is complete - https://phabricator.wikimedia.org/T112788#1671043 (Nuria) [15:52:22] (PS1) Cdentinger: iframe in french [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240728 [16:06:47] (CR) Siebrand: [C: 1] "i18n/L10n reviewed." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (https://phabricator.wikimedia.org/T112017) (owner: Awight) [16:39:41] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: 'Continue' button should say 'Donate' when there are no further steps - https://phabricator.wikimedia.org/T113624#1671216 (Ejegg) NEW a:Ejegg [16:45:08] Fundraising-Backlog: Scope PayPal express checkout - https://phabricator.wikimedia.org/T113625#1671268 (atgo) NEW [16:49:50] (CR) Cdentinger: [C: 2] Fix Amazon communication stats recording [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240163 (owner: Ejegg) [16:50:01] (CR) AndyRussG: "Neat!! Just some minor nitpicks... ;) (See inline.)" (4 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235979 (https://phabricator.wikimedia.org/T110353) (owner: Ori.livneh) [16:51:22] (Merged) jenkins-bot: Fix Amazon communication stats recording [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240163 (owner: Ejegg) [16:51:32] thanks cwdent! [16:51:41] TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Implement GET data encryption & decryption for data transmission between the banner and the fundraising app - https://phabricator.wikimedia.org/T112066#1671313 (kai.nissen) a:kai.nissen [16:57:57] (PS1) Ejegg: Send Amazon donor to fail page on unknown errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240740 (https://phabricator.wikimedia.org/T112924) [16:58:38] I'mma deploy a crm update in a bit unless anyone has objections [17:01:20] ejegg: you bet! i'm talking to tyler right now about deploying DI master on the main cluster [17:01:34] ah, cool [17:01:38] i'm still trying to understand what got everyone confused the other day [17:02:12] i don't get why deploying deployment on the cluster is a bad idea [17:02:29] seems safer than master... [17:02:31] yeah, i'm not totally clear on that either... [17:03:03] cwdent: I'm pretty sure the config settings for the cluster mean that it's not actually turned on any place but DonateWiki [17:03:12] and there, it's only used for i18n messages [17:04:00] yeah that's my understanding [17:10:30] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/240749 [17:17:46] (PS1) Ejegg: Change Amazon's form button from Continue to Donate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240755 (https://phabricator.wikimedia.org/T113624) [17:18:08] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, Patch-For-Review: 'Continue' button should say 'Donate' when there are no further steps - https://phabricator.wikimedia.org/T113624#1671216 (Ejegg) [17:23:04] Fundraising-Backlog: Should we remove name fields from WMF hosted part of WorldPay ESOP form? - https://phabricator.wikimedia.org/T113303#1671575 (atgo) @cwdent just wanted to confirm - I don't think I've seen anything from WorldPay. It's not possible to either suppress the field or autofill it from the firs... [17:27:45] Fundraising-Backlog: Should we remove name fields from WMF hosted part of WorldPay ESOP form? - https://phabricator.wikimedia.org/T113303#1671623 (cwdent) @atgo added that to the list of questions we have out to them, will update asap [17:28:34] ejegg: ok i got a good explanation of the deployment branch problem, it's actually interesting [17:30:02] when they do swat deploy, they are deploying the wmf_25xxx type branches that were cut at the last train deploy, so any patches people want up need to have been cherry picked into those [17:30:15] and listed on the swat page [17:30:43] but if it's not set up to track master, they don't cut the deploy branch, they just deploy the tracked branch [17:30:57] so if that has new commits since the last train deploy that are not listed for the swat it's gonna look weird [17:30:57] Fundraising-Backlog: Should we remove name fields from WMF hosted part of WorldPay ESOP form? - https://phabricator.wikimedia.org/T113303#1671646 (CCogdill_WMF) @atgo from my perspective, doing a QA of the data after the 1 hour test sounds fine to me. Can you remind me what rule we're using to split the name... [17:31:50] cwdent: oh weird [17:32:24] still doesn't explaing why it would just be a problem now [17:32:44] since we never list DI stuff in swat [17:32:51] ejegg: that's true, tyler thought it was just a coincidence [17:33:12] guess all the other swat deployers were just ignoring DI stuff till now [17:33:13] he said it was within the last few months that submodule bumps became automatic [17:33:24] huh, ok [17:33:46] lemme see if adam's create-branch config patch got merged [17:34:13] ejegg: tyler said to add mukunda as reviewer cause that's his repo [17:34:14] 'cause I want to do another DI deploy once the rest of my little Amazon patches get reviewed [17:34:24] ok, I'll add mukunda [17:35:11] ejegg: yeah i'm gonna want a deploy too, happy to trade you some review if you have time [17:35:24] i have one that might have problems [17:35:28] for sure, taking a look at the list [17:35:40] https://gerrit.wikimedia.org/r/#/c/240699/ [17:38:58] Fundraising-Backlog: Update WMF logo(s) in Amazon config - https://phabricator.wikimedia.org/T113563#1671682 (atgo) [17:38:59] Fundraising-Backlog: [EPIC] Amazon embedded 1-hour test version - https://phabricator.wikimedia.org/T108106#1671681 (atgo) [17:40:09] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, Patch-For-Review: 'Continue' button should say 'Donate' when there are no further steps - https://phabricator.wikimedia.org/T113624#1671687 (atgo) [17:40:11] Fundraising-Backlog: [EPIC] Amazon embedded 1-hour test version - https://phabricator.wikimedia.org/T108106#1512420 (atgo) [17:45:05] (CR) Ejegg: [C: -1] "Suggested alternate solution to card selection inline" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240699 (owner: Cdentinger) [17:48:31] (CR) Cdentinger: gather payment_submethod, show radio buttons (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240699 (owner: Cdentinger) [17:50:38] (CR) Cdentinger: [C: 2] Send Amazon donor to fail page on unknown errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240740 (https://phabricator.wikimedia.org/T112924) (owner: Ejegg) [17:52:59] (Merged) jenkins-bot: Send Amazon donor to fail page on unknown errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240740 (https://phabricator.wikimedia.org/T112924) (owner: Ejegg) [18:02:43] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/240749 (owner: Ejegg) [18:05:46] !log disabled CRM jenkins jobs [18:05:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:08:05] !log updated civicrm from 9fa38d06a75363a8009bce7ced190e39c75b68bc to 190f689ff7aec7fecefdf5af501293685c55e041 [18:08:10] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:10:43] grr, module re-enablement is taking longer than I've ever seen [18:17:41] ok, all set [18:17:53] !log reenabling CRM jenkins jobs [18:17:58] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:18:33] ejegg: Would my Major Gifts patch have gone out with that, or is this a different thing? [18:18:43] XenoRyet: yep, that went up too [18:18:49] hope that's ok! [18:19:19] Yea, perfect. Thanks [18:34:03] Fundraising Sprint Queen, Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint The Pogues, and 3 others: Set up import for Major Gifts events payment/invitation tool - https://phabricator.wikimedia.org/T101191#1672080 (XenoRyet) @CCogdill_WMF @LeanneS Requ... [19:07:41] Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, and 2 others: GC error causing donors to create multiple recurring donations - https://phabricator.wikimedia.org/T110367#1672169 (Ejegg) Open>Resolved All of the refunde... [19:18:37] (CR) Ejegg: [C: -1] "Suggestion inline to avoid hardcoding 'FR'" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240728 (owner: Cdentinger) [19:21:52] (PS3) Cdentinger: gather payment_submethod, show radio buttons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240699 [19:22:33] ejegg: i had to refactor some stuff to make the countries available to the payment methods ^ [19:33:47] ok, taking a look! [19:34:17] cwdent: I've just got one more change I'd like to deploy - https://gerrit.wikimedia.org/r/240755 [19:36:07] (PS2) Cdentinger: Change Amazon's form button from Continue to Donate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240755 (https://phabricator.wikimedia.org/T113624) (owner: Ejegg) [19:36:18] (CR) Cdentinger: [C: 2] Change Amazon's form button from Continue to Donate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240755 (https://phabricator.wikimedia.org/T113624) (owner: Ejegg) [19:36:22] looks good! [19:36:59] (Merged) jenkins-bot: Change Amazon's form button from Continue to Donate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240755 (https://phabricator.wikimedia.org/T113624) (owner: Ejegg) [19:39:25] thanks! [19:45:32] Fundraising-Backlog: Should we remove name fields from WMF hosted part of WorldPay ESOP form? - https://phabricator.wikimedia.org/T113303#1672287 (MBeat33) @atgo sounds like a fine thing to test, just one name. How much of a 'thing' is it that French donors use the firstnameLASTNAME caps protocol? I wonder i... [19:48:14] (CR) Ejegg: "Functionality looks good! I just disagree with the 'FIXME'. And it's got a typo :P" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240699 (owner: Cdentinger) [19:50:35] Fundraising-Backlog: Should we remove name fields from WMF hosted part of WorldPay ESOP form? - https://phabricator.wikimedia.org/T113303#1672298 (atgo) You mean changing it? That seems like a separate issue to me, since they'd probably do that no matter which fields we use :) [19:51:20] (PS2) Cdentinger: iframe in french [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240728 [19:52:17] (PS3) Cdentinger: iframe in french [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240728 [19:53:34] cwdent: didn't want to use the var_map? [19:54:18] ejegg: will it still get the value if i don't add it to the transaction structure? [19:55:19] yeah, the normal value gathering process first looks for a constant value in the 'values' key, then looks in the var_map to get the appropriate value from staged data [19:55:50] i think it also looks in account_info somewhere along the line [19:56:02] ah gotcha, i'll try that [20:01:55] (PS4) Cdentinger: iframe in french [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240728 [20:02:15] looks good! [20:02:26] Do they accept upper and lower case? [20:02:33] I'm not sure if we normalize to one or the other [20:03:00] ejegg: not sure, i'll check [20:03:17] yeah looks fine [20:03:22] yeah, doesn't look like we do strtoupper on that. [20:03:23] cool! [20:03:27] dstrine: standup? [20:03:32] glad they're not brittle on /something/! [20:04:14] (PS5) Ejegg: iframe in french [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240728 (owner: Cdentinger) [20:05:36] ha, the one thing [20:05:38] Fundraising-Backlog: Should we remove name fields from WMF hosted part of WorldPay ESOP form? - https://phabricator.wikimedia.org/T113303#1672340 (MBeat33) I was thinking that if we have a single field for name and we receive "frenchDONOR" as first & last names (it seems like common usage in French to indica... [20:05:43] probably cause it's windows [20:05:47] (CR) Ejegg: [C: 2] "Très Bien!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240728 (owner: Cdentinger) [20:06:21] (Merged) jenkins-bot: iframe in french [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240728 (owner: Cdentinger) [20:11:57] (PS4) Cdentinger: gather payment_submethod, show radio buttons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240699 [20:15:22] (PS5) Ejegg: gather payment_submethod, show radio buttons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240699 (owner: Cdentinger) [20:17:26] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Nightly Amazon report download - https://phabricator.wikimedia.org/T109654#1672389 (DStrine) [20:21:22] Sorry for that "Oh shit" moment, water spilled on laptop. I think it's ok but I'm just gonna be sure before turning it on again [20:23:09] dstrine ejegg atgo cwdent XenoRyet ^ [20:23:21] 10-4 [20:31:45] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: iFrame should be in French - https://phabricator.wikimedia.org/T113527#1672478 (atgo) @cwdent can we resolve this one? [20:32:12] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Change "continue" button for credit card logos, suppress logos from within iframe - https://phabricator.wikimedia.org/T113304#1672481 (atgo) @cwdent should this be "doing"? [20:33:34] Fundraising-Backlog: Should we remove name fields from WMF hosted part of WorldPay ESOP form? - https://phabricator.wikimedia.org/T113303#1672487 (atgo) [20:33:35] Fundraising-Backlog: [epic] Worldpay campaign ready in France - https://phabricator.wikimedia.org/T110114#1672486 (atgo) [20:33:46] Fundraising-Backlog: Should we remove name fields from WMF hosted part of WorldPay ESOP form? - https://phabricator.wikimedia.org/T113303#1661290 (atgo) Making this a blocking task for the campaign ready version while we investigate. [20:33:57] atgo: going to deploy both of those this afternoon [20:34:00] Fundraising-Backlog: Should we remove name fields from WMF hosted part of WorldPay ESOP form? - https://phabricator.wikimedia.org/T113303#1672493 (atgo) [20:34:01] Fundraising-Backlog: [epic] worldpay 1 hour test in France - https://phabricator.wikimedia.org/T110113#1672492 (atgo) [20:34:52] Fundraising-Backlog: Hide name fields from WMF portion of form - https://phabricator.wikimedia.org/T113657#1672500 (atgo) NEW [20:35:15] Fundraising-Backlog: Hide name fields from WMF portion of form - https://phabricator.wikimedia.org/T113657#1672500 (atgo) [20:35:48] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Nightly Amazon report download - https://phabricator.wikimedia.org/T109654#1672516 (Ejegg) Documentation on the report format and on the API calls to request and download them: http://amazonpayments.s3.amazonaws... [20:37:23] cwdent: mind kicking this one through the goal posts? https://gerrit.wikimedia.org/r/240157 [20:38:29] (PS6) Ejegg: gather payment_submethod, show radio buttons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240699 (https://phabricator.wikimedia.org/T113304) (owner: Cdentinger) [20:38:57] sure thing [20:39:13] (CR) Ejegg: [C: 2] "Looking good!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240699 (https://phabricator.wikimedia.org/T113304) (owner: Cdentinger) [20:39:20] ty [20:39:42] (CR) Cdentinger: [C: 2] Fix Amazon completion message ID [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/240157 (https://phabricator.wikimedia.org/T109649) (owner: Ejegg) [20:39:43] Monring [20:39:44] (Merged) jenkins-bot: gather payment_submethod, show radio buttons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240699 (https://phabricator.wikimedia.org/T113304) (owner: Cdentinger) [20:39:48] (Merged) jenkins-bot: Fix Amazon completion message ID [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/240157 (https://phabricator.wikimedia.org/T109649) (owner: Ejegg) [20:39:48] hi eileen ! [20:39:52] how goes? [20:40:41] pretty good! Getting really close to done on a couple of different processor integration upgrades [20:40:58] nice! [20:41:08] How's everything in NZ? [20:42:47] pretty ood. a bit wet [20:42:51] good not ood [20:43:04] is there a distinct rainy season? [20:43:44] nah - it’s 4 seasons - but they are pretty mild in the part of NZ where I live [20:44:36] gets cold down south & at elevation [20:44:40] ok nerd question ... eileen ...have you gone to see the shire? is it worth it? [20:44:58] (PS1) Ejegg: Revert "Revert "Merge branch 'master' into deployment"" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/240883 [20:45:03] dstrine: you mean the one from the film - it’s always been a bit pricey TBH [20:45:12] Phew, laptop all good, apparently [20:45:12] oh really?1 [20:45:17] now everyone wants to revert the revert [20:45:36] hehe, nice commit msg [20:46:23] price for a whole family would be $225 NZD [20:46:32] oh wow [20:46:54] yeah - the thing is they can’t have volume so - they can have price [20:47:04] do they have actors and stuff filling the space? Or is it relatively empty? [20:47:07] eileen: I missed one of your 4.6 patches in my 'revert', so you probably need to cherry pick ef9b4bde2a75f76a7cd999280fd647f7d58498de back on to the 4.6 branch [20:47:18] ejegg: opps! [20:47:25] my bad [20:47:46] I did wonder if you had had a really clever trick for reverting them since you seemed to do it so quickly & all into 1 commit [20:48:28] i did git revert sha...sha, then git rebase -i and made all the picks into squashes [20:48:50] ah right - so manual - but quick :-) [20:48:55] but I didn't start quite early enough [20:49:16] did it cause any problems? [20:49:35] tests picked it up i guess? [20:50:28] yep tests FTW. I got confused for a bit when payment instruments were missing [20:50:36] but awight tracked down the cause [20:51:22] (CR) Ejegg: [C: 2 V: 2] Revert "Revert "Merge branch 'master' into deployment"" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/240883 (owner: Ejegg) [20:51:24] cool [20:51:52] 2 small questions [20:52:00] sure [20:52:18] 1) do you define a ‘Donations’ DB connection? If so what does that look like [20:52:32] hmm, let me see [20:53:19] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/240887 [20:53:35] 2) If I’m adding tests to wmf_civicrm.module - which is just a bunch of helper functions - is there a preference to what I call the test classes? One class per function? One class for the file? [20:55:26] (I figure it makes sense to add the tests to the small functions like wmf_civicrm_tag_contact_for_review that need to be edited for 4.6) [20:56:09] eileen: I think the 'donations' db connection points to whichever database holds you 'contribution_tracking' table [20:56:31] I believe that table is written to by the mediawiki donations frontend [20:57:16] hmm - I’m not sure I have one … is that separate to both civi & drupal? [20:57:40] how does it get defined - I’m seeing “Exception: donations database is not defined” [20:57:52] I think it may be in the drupal database [20:58:07] Oh, you add it as another db in drupal's settings.php [20:58:31] just a second entry in your $databases array [20:58:35] ok - cool [21:00:37] cwdent: ready to do this thing? [21:01:04] ejegg: yep all good here [21:01:14] do you want to pull the trigger or should i? [21:01:46] I'll do it this time [21:01:54] unless you want to [21:01:58] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/240887 (owner: Ejegg) [21:02:43] nah i'm fine [21:06:19] (PS1) Ejegg: Update DonationInterface for deployment [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/240896 [21:06:50] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface for deployment [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/240896 (owner: Ejegg) [21:09:01] eileen: for tests, please feel free to break them out into any groupings that feel appropriate. Probably don't need for one per function, unless it's a gnarly one that needs 5+ tests [21:09:16] ejegg: ok cool [21:09:54] cwdent: about to pull the trigger. Want to start observing logs? [21:10:05] sure gimme 2 seconds [21:10:54] fire when ready [21:14:57] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1672662 (ellery) @Jgreen Does that mean the data in pgheres.bannerimpressions is i... [21:15:55] !log updated payments-wiki from 8428499feb8760d63faf681d53995697a2ba0fa7 to dc78ff5157b59a8f475dc86194a1059c2d6b2fad [21:16:00] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:16:08] aaarg moar coffee! [21:16:19] my brain betrays me! [21:16:41] ejegg: everything's looking good [21:17:13] nice, so far so good with Amazon too [21:17:25] o/ [21:17:26] gonna deploy that SmashPig update before I test though [21:18:14] !log updated SmashPig from d1baa32267eaad7d69b47c657f4853eb306fad6b to bf302444eae8236734fd43883b06c7b2512b1532 [21:18:20] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:20:22] Fundraising-Backlog: [epic] worldpay 1 hour test in France - https://phabricator.wikimedia.org/T110113#1672691 (cwdent) [21:20:23] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: iFrame should be in French - https://phabricator.wikimedia.org/T113527#1672688 (cwdent) Open>Resolved a:cwdent deployed [21:22:08] nice, got all the extra info in the lods [21:22:11] *logs [21:25:59] dstrine: I just pinged Krinkle (Timo) on #wikimedia-perf. His status sez away but he's been not away and participating recently... I'll let u know the result [21:27:55] (PS1) Ejegg: Don't remove overlay when redirecting [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240902 [21:29:14] cwdent: tiny JS tweak to deal with a thing I noticed ^^ There was enough time after overlay disappeared and before next page loaded that I could have hit 'donate' again. [21:32:03] ah ha! [21:32:44] (CR) Cdentinger: [C: 2] Don't remove overlay when redirecting [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240902 (owner: Ejegg) [21:33:12] (Merged) jenkins-bot: Don't remove overlay when redirecting [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240902 (owner: Ejegg) [21:33:50] ejegg: yeah that UI state stuff is always messy, but i bet we can centralize a lot of the messiness in the next version [21:34:32] or just gradually...but yeah i cut and pasted a lot of js [21:34:46] for the new WP form [21:35:49] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Change "continue" button for credit card logos, suppress logos from within iframe - https://phabricator.wikimedia.org/T113304#1672768 (atgo) hey @cwdent looking at the form. Could we order the logos (from le... [21:37:55] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1672781 (atgo) hey @ellery - right now we've got it in Q2, which means we'll hopefu... [21:37:55] ejegg: it seems like the way to order the card buttons is to rearrange the array...if i was proper i'd probably give them a weight or something, do you think it's worth it? [21:38:28] huh, i'd just go for order now [21:38:46] (CR) Ori.livneh: Migrate to a terser cookie name and format (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235979 (https://phabricator.wikimedia.org/T110353) (owner: Ori.livneh) [21:38:56] (PS16) Ori.livneh: Migrate to a terser cookie name and format [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235979 (https://phabricator.wikimedia.org/T110353) [21:39:08] that's one of the things they like to a/b test, so when we do the 'real' solution we should make it reesponsive to some querystring thing [21:45:02] atgo: when you said that for Megan getting BH activated next week was significant, did you mean, getting it activated first thing Monday morning, or sometime during the week? I think it's not impossible to get it out for this evening's "SWAT" deploy [21:45:10] OK I’ve hit something - in 4.2 preferred languages are not validated when creating a contact but in 4.6 they are - against the languages option_value [21:45:16] well shoot AndyRussG - that's rad [21:45:29] in the test the record being created is en_IL - which is not valid [21:45:44] she needs to start playing with this asap and getting used to accessing the data [21:46:03] it would be great to do a training session or something with her while she's in a closer time zone - maybe she and ellery can look at it next week if there's more data there :D [21:46:27] atgo: it'd be more prudent to wait to test the changes a bit first, though, so first thing Monday is the saner choice. That's why I'm asking [21:46:42] atgo: we can do a training on beta before it's actually deployed to production [21:46:52] let's do monday [21:46:58] atgo: ^ I mean, test on Beta [21:47:05] atgo: OK [21:47:13] AndyRussG: whatever works. she's more concerned about getting used to using the data than the front end [21:47:21] so, closer to prod is probably better for that [21:47:25] ah OK [21:47:54] cool, yeah I was just wondering if there was a big enough difference of this evening vs. Monday morning to merit winging it [21:48:19] (in the sense of, pushing it out w/ out trying it much on the beta cluster, which is where it goes when it's merged but not deployed) [21:48:36] atgo: 'till when is she in SF? [21:48:43] early the following week [21:48:47] monday morning is fine AndyRussG [21:49:02] atgo: K many thanks!!! :) [21:49:23] https://www.quora.com/Is-Wikipedia-being-intentionally-slowed-in-order-to-encourage-donation [21:52:29] AndyRussG: heh. you could point to some fr-vs-perf team exchanges to refute that! [21:53:10] ejegg: heh indeed! Though... there was also that discussion about how banner bump influences donations! [21:53:37] Though that's not fiddling with WP speed, if it were to happen, it'd be fiddling w/ banner display speed [21:54:21] In any case, I'm sure the opposite is true: greater speed = better experience = more donations [21:54:42] yeah, i'd hop so! [21:54:54] *hope [21:56:05] (PS1) Cdentinger: reorder cards and hide iframe card images [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240906 [21:58:47] At least greater speed = better fulfilment of our goals, and that trumps any impact speed would have on donations, in any case [21:59:51] yep. gotta be fast to keep em coming back and hopefully editing someday [22:02:43] (PS1) Ejegg: Don't close Amazon order reference in DI [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240909 [22:02:53] AndyRussG: thanks for the update above [22:04:37] dstrine: np likewise! [22:08:51] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Handle Amazon SDK client communication failures and any other error that bubbles up to the Mediawiki API - https://phabricator.wikimedia.org/T112924#1672898 (Ejegg) Open>Resolved [22:08:53] Fundraising-Backlog: [EPIC] Amazon embedded 1-hour test version - https://phabricator.wikimedia.org/T108106#1672899 (Ejegg) [22:09:47] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1672900 (Jgreen) >>! In T97676#1672662, @ellery wrote: > @Jgreen Does that mean the... [22:11:09] Fundraising Sprint Queen, Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint The Pogues, and 3 others: Set up import for Major Gifts events payment/invitation tool - https://phabricator.wikimedia.org/T101191#1672912 (LeanneS) @XenoRyet I just tested using... [22:11:26] Fundraising-Backlog: [EPIC] Amazon embedded 1-hour test version - https://phabricator.wikimedia.org/T108106#1672923 (Ejegg) [22:11:28] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, Patch-For-Review: 'Continue' button should say 'Donate' when there are no further steps - https://phabricator.wikimedia.org/T113624#1672922 (Ejegg) Open>Resolved [22:11:32] Fundraising-Backlog: [EPIC] Amazon embedded 1-hour test version - https://phabricator.wikimedia.org/T108106#1512420 (Ejegg) [22:11:33] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Patch-For-Review: Implement Amazon payment notification listener - https://phabricator.wikimedia.org/T109649#1672924 (Ejegg) Open>Resolved [22:15:17] ejegg: so it's ok to leave orders unfinished like this? do they need to get added to a queue or something? [22:16:40] or does the ipn listener get a message from amazon that we could use to signal that? [22:17:16] Yeah, I was planning to do it from the IPN listener. [22:17:26] gotta run for now, but I'll check in again late! [22:34:25] Fundraising-Backlog: [BUG] Donation form stuck with 0 as donation amount; donors can't modify it - https://phabricator.wikimedia.org/T113530#1673017 (MBeat33) The US donor from 9/23 confirmed that they used a pop-up banner from a Wikipedia page. Zendesk #157441 [23:40:17] (PS1) Eileen: T99836 remove apiv2 Entity Tag call [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/240925 [23:40:19] (PS1) Eileen: T99836 Civi46: adapt to pre-hook standardisation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/240926 [23:40:21] (PS1) Eileen: T99836 Civi46 update refund test for changed parameter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/240927 [23:43:30] (CR) jenkins-bot: [V: -1] T99836 Civi46 update refund test for changed parameter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/240927 (owner: Eileen) [23:45:41] dstrine: great news! Krinkle gives us his thumbs-up to review and merge the patch we're waiting on ourselves. He hasn't looked at the very final version yet and is traveling tomorrow, but he's fine w/ us merging so it goes to the beta cluster, and then on Monday he'll give it a final once-over just before we deploy [23:48:36] (CR) Eileen: "This is passing locally - but not on gerrit - which makes me think it's not actually grabbing the right CiviCRM commit" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/240927 (owner: Eileen) [23:56:11] cool!