[02:12:01] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: PayPal audit parser is not associating donations with the correct contribution_tracking record - https://phabricator.wikimedia.org/T113087#1679850 (MeganHernandez_WMF) PayPal donations from 9/16 are showing... [03:30:06] (CR) AndyRussG: Migrate to a terser cookie name and format (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235979 (https://phabricator.wikimedia.org/T110353) (owner: Ori.livneh) [03:30:45] (CR) AndyRussG: "Thanks!!!!" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235979 (https://phabricator.wikimedia.org/T110353) (owner: Ori.livneh) [05:46:06] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: PayPal audit parser is not associating donations with the correct contribution_tracking record - https://phabricator.wikimedia.org/T113087#1679912 (awight) Open>Resolved Thank you for the help with this! [05:46:07] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Backfill from Aug 25-Sept 17 PayPal audit outage - https://phabricator.wikimedia.org/T112920#1679914 (awight) [05:46:57] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Sample XML for a GC USD credit card donation - https://phabricator.wikimedia.org/T113365#1679916 (awight) a:awight [08:14:42] (CR) Siebrand: "i18n/L10n reviewed." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181234 (owner: Awight) [08:14:54] (CR) Siebrand: "i18n/L10n reviewed." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (https://phabricator.wikimedia.org/T112017) (owner: Awight) [08:16:36] (CR) Siebrand: [C: 1] "i18n/L10n reviewed." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/239302 (owner: Awight) [13:14:24] TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Implement GET data encryption & decryption for data transmission between the banner and the fundraising app - https://phabricator.wikimedia.org/T112066#1680703 (WMDE-leszek) PR on github: https://github.com/wmde/Wikipedia.de/pull/7 [13:39:21] right, now to see if we can fix these irc notifications [13:59:13] https://gerrit.wikimedia.org/r/#/c/241652/ [15:46:49] AndyRussG: I know you've said a bunch of this before, but once the pending work is deployed, new banners "could" use banner history right? If this is the case, do we need to give specific instructions on enabling it? what sort of tools will the fr-online (non technical) people have at their disposal? [15:47:40] dstrine: hi! yes, following (hopefully what will be) today's deploy, it will be possible to enable banner history on production [15:48:19] do we need to give a mini training session to anyone? [15:48:21] dstrine: we should agree with FR-creative about which campaign they want to enable it on and watch it closely for the logged events and make sure the numbers are all good [15:48:46] dstrine: good idea! Yeah hadn't thought about it, but it makes sense [15:49:25] Also we'll need to coordinate with the-wub about new code to put in at least one in-banner script to make logs sent 100% of the time for donors [15:49:38] I could wrangle the meeting. do you know who should be in it? Megan is very interested, I'm guessing Ellery and Peter Coombe? [15:49:41] and to pass along the log ID parameters to donationINterface [15:50:17] I think also Jessica Robell? I guess Megan and Peter could confirm who else [15:50:32] ok I will also ask them in the standup at 10 [15:50:41] dstrine: let's wait and see how today's deploy goes [15:50:46] kk [15:50:58] I'll at least get a list of interested parties [15:51:04] dstrine: yeah that sounds great [15:51:16] dstrine: we can do the training session after the first campaign is enabled for sure [15:51:52] something tells me that no one outside fr-tech knows how to enable this [15:52:54] dstrine: that's OK. It's pretty easy. We can do the steps for the first activation by IRC and e-mail [15:54:09] one thing you could ask is for them to determine what values they will want for these parameters: [15:54:09] Sample rate (should be between 0 and 1 inclusive) [15:54:09] Maximum age of log entries (in days)Maximum number of entries to keep in log [15:54:13] do we need to make sure this is a true test campaign? Is it possible we could get some negative impact if we use this on a regular campaign? [15:55:00] dstrine: I guess best would be to enable it on a test campaign on production first, say on aa wikibooks (a closed project that we use for this kind of thing) [15:57:16] ok cool... I think we should start an email thread about that specifically even before this deploy so people know what they need to do next [15:57:41] dstrine: sure! [15:58:11] I'll say all of this at the standup today at 10 and then start an email [15:59:14] thanks AndyRussG ! [15:59:22] dstrine: K u bet! [15:59:25] thanks likewsie! [15:59:28] likewise [16:09:10] cwdent: do you know how hard would it be in git to merge all of master into wmf_deploy *except* one patch that's in master? Is it silly to even think about that? [16:10:57] hmmm.. [16:11:19] are you ever going to want that patch applied to deploy? [16:12:26] Maybe one day 8ṕ [16:13:38] you could make a new branch of master [16:13:43] cwdent: it's this patch that was merged outside our team even though we'd asked to wait https://gerrit.wikimedia.org/r/#/c/234164/ [16:13:59] ooh yeah i remember that [16:14:13] then revert the commit on master and merge [16:14:15] I'm looking it over carefully now and there are issues [16:14:28] then pull master into the new branch and rebase that commit on top [16:14:30] cwdent: Hmm dunno if that could work on Gerrit [16:14:48] yeah i meant the new branch locally, just to save your work [16:14:55] cwdent: maybe we should just cherry-pick onto wmf_deploy the patches that we do want [16:14:57] Fundraising-Backlog: Help setting up a Top Prospects report in Civi - https://phabricator.wikimedia.org/T113904#1681391 (CaitVirtue) [16:15:39] Fundraising-Backlog: Help setting up a Top Prospects report in Civi - https://phabricator.wikimedia.org/T113904#1679603 (CaitVirtue) [16:16:23] Fundraising-Backlog: Help setting up a Top Prospects report in Civi - https://phabricator.wikimedia.org/T113904#1679603 (CaitVirtue) {F2643142} [16:16:27] cwdent: or merge the patches _before_ the one I'm not sure about, and cherry-pick the ones after [16:16:42] or... just finish reviewing and fixing this patch that was foisted upon us [16:16:50] heh [16:18:03] actually AndyRussG i think you could rebase -i and just delete the commit you don't want [16:19:14] cwdent: hmmm interesting point... I guess one worry is that it'll mess up the relationship between master and wmf_deploy such that future merges of master into deploy become messy [16:19:56] I guess I'll give it another hour of fixing it and see where we get [16:20:14] yep, that's why i thought branching that commit to a new patch set on top of the merged master might be cleanest [16:20:33] it sounds messy any way you slice it [16:22:46] like slicing a ripe tomato. No matter what it's gonna splatter somewhere [16:23:03] * AndyRussG slices git repo [16:23:24] Heh that's what git needs: git merge --slice! [16:23:30] like array.slice [16:57:03] (CR) Ejegg: [C: 1] "Great stuff! Could use an update to campaignManager.js to make the parameter field set appear below the help-msg text." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/239302 (owner: Awight) [17:04:49] (PS3) Ejegg: Link to the regular wiki editor for banner content [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181234 (owner: Awight) [17:05:45] (CR) Ejegg: [C: 2] "Nice to have! Would it also be useful in the list of banners, where another 'preview on wiki' link exists?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181234 (owner: Awight) [17:06:32] ejegg: fr-online is thinking about doing a 1 hour test tomorrow ... it that ok for you? will you have to watch much? [17:06:50] sorry for amazon [17:07:06] dstrine: I will definitely want to watch! [17:07:15] Fundraising-Backlog: Add Report Criteria to exported report data - https://phabricator.wikimedia.org/T113978#1681673 (CaitVirtue) NEW [17:07:24] It's fine by me - All the stuff is in place to make donations work [17:08:53] I've got a couple of patches to reduce the amount of time donors wait after clicking 'Donate', but if I don't get to test them today I'll wait till after the 1 hr test [17:12:37] ejegg: fr-online is asking for 10am test for Amazon tomorrow. Is that cool? We can cancel or move backlog grooming for this stuff [17:13:15] dstrine: sure, 10 pacific / 1 eastern is fine by me! [17:13:39] ok cool... and sorry for not translating :P [17:13:48] hey, no problem! [17:14:03] Moving backlog grooming would be nice though [17:14:55] cwdent: fr-online is wondering if 10am on Thursday would be good for france 1 hour test. would that be ok for you? [17:15:27] sure sounds good [17:15:43] ok thanks! I'll confirm all this on the emails [17:16:25] AndyRussG: fr-online would like to test on aa wikibooks. I'll start an email on that [17:16:40] dstrine: OK sounds fantastic :) [17:17:04] (CR) Ori.livneh: Migrate to a terser cookie name and format (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235979 (https://phabricator.wikimedia.org/T110353) (owner: Ori.livneh) [17:18:04] ejegg: hi! How's it going? ping https://gerrit.wikimedia.org/r/#/c/240960/ ;) (If u have time... It'd be fun to get it out today...) [17:18:49] hi AndyRussG! It's a beautiful Monday here in MA. Taking a look at that patch [17:19:04] ejegg: fantasmic, much appreciated! [17:19:21] Heh here we have rain, but at least it's pretty "warmish" still [17:27:44] AndyRussG: So after this patch, the banner click function reads the ID from cn.bannerHistoryLogger.id, right? [17:27:53] ejegg: yep! [17:28:11] kewl [17:28:32] (PS3) Ejegg: BannerHistoryLogger: always send log ID, never send twice [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240960 (https://phabricator.wikimedia.org/T113421) (owner: AndyRussG) [17:28:40] :) [17:28:57] (CR) Ejegg: [C: 2] "Looks like it'll do the trick!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/240960 (https://phabricator.wikimedia.org/T113421) (owner: AndyRussG) [17:29:24] (Abandoned) Awight: update SmashPig lib [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/241136 (owner: Awight) [17:29:41] (Abandoned) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/241135 (owner: Awight) [17:29:47] ejegg: thanks much! I'll have another patch along 4 anyone with a yankering for CNCR in a bit :) [17:29:53] (Abandoned) Awight: update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/241137 (owner: Awight) [17:30:02] Or is it hankering? [17:30:03] okeydokey [17:30:06] :) [17:30:07] (Abandoned) Awight: update SmashPig lib [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/241128 (owner: Awight) [17:31:48] (PS1) Awight: Update SmashPig lib [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/241698 [17:32:39] (CR) jenkins-bot: [V: -1] Update SmashPig lib [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/241698 (owner: Awight) [17:33:52] Fundraising-Backlog: Add Report Criteria to exported report data - https://phabricator.wikimedia.org/T113978#1681868 (CaitVirtue) Ex: Contribution Amount - greater than "100" ...AND... Contribution Status IN Completed or Settled or Paid ...AND... Charitable Contributions Decile = 10 [17:37:32] (CR) Ejegg: "Looks potentially useful, but we'd need more changes to set the extra x-headers the IPN handler depends on" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/210279 (owner: Awight) [17:38:54] (PS1) Awight: update SmashPig lib [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/241700 [17:39:15] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/241701 [17:39:17] (PS1) Awight: update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/241702 [17:42:28] (PS2) Awight: Update SmashPig lib; disable Lynx reconciliation test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/241698 [17:44:31] (Abandoned) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/241701 (owner: Awight) [17:44:48] (PS2) Awight: update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/241702 [17:44:50] (PS1) Awight: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/241705 [17:45:13] (CR) Awight: [C: 2] Update SmashPig lib; disable Lynx reconciliation test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/241698 (owner: Awight) [17:45:39] (CR) Awight: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/241705 (owner: Awight) [17:45:53] (CR) Awight: [C: 2] update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/241702 (owner: Awight) [17:46:03] (CR) AndyRussG: Migrate to a terser cookie name and format (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235979 (https://phabricator.wikimedia.org/T110353) (owner: Ori.livneh) [17:47:22] awight: hi! how're the arms? Mmm just wondering... didja get a chance to make some headway on the banner hide reason shim? In case maybe we could put that out today, too... :) thanks in advance!! [17:48:28] Fundraising Sprint Queen, Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint The Pogues, and 3 others: Set up import for Major Gifts events payment/invitation tool - https://phabricator.wikimedia.org/T101191#1681950 (CCogdill_WMF) Open>Resolved [17:48:42] Fundraising Sprint Queen, Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint The Pogues, and 3 others: Set up import for Major Gifts events payment/invitation tool - https://phabricator.wikimedia.org/T101191#1379606 (CCogdill_WMF) Looks like it's all good,... [17:48:59] AndyRussG: naw, haven't done anything over the weekend. I can make that the next thing I work on, though! [17:49:15] (Merged) jenkins-bot: Update SmashPig lib; disable Lynx reconciliation test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/241698 (owner: Awight) [17:49:17] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/241705 (owner: Awight) [17:49:19] (Merged) jenkins-bot: update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/241702 (owner: Awight) [17:49:20] awight: cool thanks!!!! [17:49:47] awight: sorry I didn't mean to imply u should weekendslave /me runs from union rep [17:50:11] Heh on a related note, teachers at my kids' school voted to strike! [17:50:15] hehe. /me hums Internationale [17:50:18] oh wow [17:50:20] Probably wouldn't happen until next month [17:50:22] I hope that works out for everyone [17:50:53] And hope the teachers aren't already demoralized [17:50:59] The teachers at the French school system are striking on Wednesday [17:51:18] Not at all! They voted like 80% in favor of the strike, though they're still negotiating [17:51:31] If they do strike, we have plan to bring them cookies [17:52:39] The administration must be applying the new global norms to help squeeze schools. So scary, they're adopting the overwhelmingly successful American strategies of hiring MBA material to university dean seats and so on [17:52:58] In the shape of some commie symbol [17:53:47] http://bit.ly/1NXDqRT [17:54:06] 5 years of cookies, nom nom nom! [17:54:40] awight: it's a province-wide thing, which is the level of gov't that's responsible for public ed here. Yeah they're cutting back on special ed teachers and services, making classes bigger, and trying to foist more paperwork on the profs... ah and freezing salaries [17:54:51] Heheh nice [17:54:52] (PS2) Awight: update SmashPig lib [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/241700 [17:55:02] (Abandoned) Awight: update SmashPig lib [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/241700 (owner: Awight) [17:55:59] * AndyRussG clings to social safety net [17:56:01] Fundraising-Backlog: test task for amazon campaign ready - https://phabricator.wikimedia.org/T113995#1681995 (DStrine) NEW a:DStrine [17:56:06] dammit. What's motiviating the rabid dismantling of basic shared services in CA? [17:56:17] Fundraising-Backlog: test task for amazon campaign ready - https://phabricator.wikimedia.org/T113995#1682005 (DStrine) [17:57:41] awight: supposedly public deficit reduction [17:58:54] * awight kicks a parked police cruiser [17:59:23] awight: the ironic thing is that candidate for the "social democratic" party here (elections in October) for many years belonged to the same party that's doing cutbacks the here in Quebec now [17:59:26] (PS1) Awight: update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/241710 [17:59:57] (Abandoned) Awight: update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/241710 (owner: Awight) [18:00:09] Heh the police cruisers here are all covered with police union stickers denouncing the gov't union negotiation tactics, soo [18:00:10] too [18:00:14] (PS1) Awight: update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/241711 [18:00:23] (CR) Awight: [C: 2] update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/241711 (owner: Awight) [18:00:25] (Merged) jenkins-bot: update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/241711 (owner: Awight) [18:01:23] !log update crm from 190f689ff7aec7fecefdf5af501293685c55e041 to 7003cc38797848631d0c4d5f6ff68ab1d6118ad8 [18:01:29] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:01:50] awight: https://c2.staticflickr.com/8/7470/15527069964_e54d134f44.jpg [18:04:04] wheeee! [18:04:05] Fundraising-Backlog: Improve UI for primary mailing address - https://phabricator.wikimedia.org/T113996#1682023 (CaitVirtue) NEW [18:06:58] The top of the sticker means, "_we_ didn't steal anything" (in reference to corruption scandals) [18:08:04] awight: hey, looks like the audit worked [18:09:14] (PS1) Awight: Play nice if we don't own this file type [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/241714 [18:10:25] cwdent: It's propped up at least, but there were no RECON type files in this batch, so we don't know yet if it's going to work for the French backend. [18:11:08] aah, is that different from audit? didn't we see some of the same transactions in the audit file? [18:11:30] We saw some visually, but didn't parse through the script yet [18:11:38] yeah, this is the audit script--same thing as nightly reconciliation [18:11:52] hey! [18:11:52] /job/Worldpay nightly audit parser/383/console [18:11:55] confirmed working. [18:12:34] \o/ [18:12:43] Rats, the audit script doesn't emit txn ids [18:13:22] cwdent: worldpay-25633699.0 [18:13:35] all "?" for the Hebrew characters :( [18:13:43] But that's expected [18:14:10] Fundraising Sprint Tom Waits, Fundraising-Backlog: Review audit parsing, review whether existing stuff is working. - https://phabricator.wikimedia.org/T112807#1682058 (awight) [18:14:29] doh [18:14:40] yeah...we should probably find out where we're losing those [18:15:13] wanna make a task? [18:15:20] sure thing [18:15:29] thank you! [18:15:40] Fundraising-Backlog: Auto-Notifications of Upcoming Birthday of Major Donor - https://phabricator.wikimedia.org/T113998#1682063 (CaitVirtue) NEW [18:16:00] congrats, awight and cwdent [18:16:25] \o/ [18:16:56] Fundraising-Backlog: Access for Joseph Seddon (new part-time contractor for fundraising) - https://phabricator.wikimedia.org/T113999#1682070 (jrobell) NEW [18:17:29] dstrine: Looks like atgo was working on https://phabricator.wikimedia.org/T113529 -- should we reassign? [18:18:17] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner history: encode all hide reasons - https://phabricator.wikimedia.org/T113813#1682077 (awight) [18:19:03] Fundraising-Backlog: Hebrew characters not making it into Worldpay donations - https://phabricator.wikimedia.org/T114000#1682081 (cwdent) NEW [18:19:07] awight: cwdent: ejegg: XenoRyet: K4-713: opinions on the geopolitical consequences of reverting https://gerrit.wikimedia.org/r/#/c/234164/ ? I'm digging into a patch to make it safer but it's a frigging rabbit hole [18:19:16] AndyRussG: I'll look at the reason enum thing now, but it would be nice to close out https://gerrit.wikimedia.org/r/#/c/236229/ when you get the chance [18:19:56] awight: yeah I'd love to also.. Just thinking in terms of what's most essential for a pre-MVP deploy, still hoping for today [18:20:03] AndyRussG: yeah I didn't like that either. I can revert if that might keep the blowback out of your more critical work [18:22:07] Wikimedia-Fundraising-CiviCRM: Process to enter and track multi-year gifts - https://phabricator.wikimedia.org/T114001#1682098 (Krenair) [18:22:21] AndyRussG: the alternative is that we let it lie for a minute, and ask our users to be especially alert to replag effects and report them. [18:22:23] awight: thanks! eh I don't mind reverting, and you can grab the +2 honnors? [18:24:40] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Process to enter and track multi-year gifts - https://phabricator.wikimedia.org/T114001#1682101 (CaitVirtue) [18:25:22] awight: the problem isn't the replag. Or at least, I'm not thinking about that, not sure how serious it would be. The problem is: 1) there are more code paths that might really need to hit master, that I'm working on right now, but it's a rat's nest, really; 2) mixing front-end logic so deep into the back-end so as to switch DB on whether it's post or get is horrific, and 3) the real thing it's trying to solve [18:25:22] is that users w/ admin rights are hitting master db when they get a banner and call Special:BannerLoader [18:25:49] AndyRussG: oh really [18:26:03] I remember you mentioned that, but didn't notice that this was the URL in question. [18:26:09] That's a lot easier to change [18:26:16] : always hit the slave db [18:26:40] (PS17) Awight: Banner diet mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (https://phabricator.wikimedia.org/T112017) [18:26:49] awight: you mean on Special:BannerLoader, right? [18:26:52] yep [18:27:46] AndyRussG: I don't see that URL listed in https://phabricator.wikimedia.org/T92357 -- how did you determine it was the problem? [18:28:01] I would have thought that any admin UI traffic would emit these errors [18:28:12] mmm, any GET traffic [18:28:14] awight: yeah I think so. K I'm gonna make a revert patch, then a follow-on WIP patch that contains the DB improvements I've been adding, and then another separate one that forces Special:BannerLoader to hit the slave [18:28:48] Any chance I can talk you into doing the S:BL patch first, and separate the rest of the improvements into another discussion? [18:28:50] awight: AaronSchulz told me. One sec I'll pull up the queries he mentioned [18:28:56] ok awesome, that's good enuf for me. [18:29:22] awight: the problem is that I want to deploy ASAP and don't want this @|$ patch, which is merged and has other patches on top of it, to go out [18:29:46] Exactly--that's why I'm hoping we can not do other, undertested improvements [18:30:02] So I want to revert, but also demonstrate that the patch would need more work to be viable, hence rollling it into a WIP patch [18:30:22] gotcha [18:30:35] heheh /me plows ahead like he knows what he's doing [18:30:37] ok, we're not trying to push this out today--agreed! [18:32:14] K4-713: you might want to be on conflict alert :( We've decided to revert https://gerrit.wikimedia.org/r/#/c/234164/ cos it's destabilizing today's deployment. [18:32:27] Oops. [18:32:56] AndyRussG: I take it you're up to your eyeballs at the moment? [18:32:59] K4-713: one sec, coming [18:33:08] Don't worry about it if you're in the middle of a mess. [18:33:29] K4-713: not an extraordinary one [18:33:29] :) [18:33:42] * K4-713 squints [18:38:26] AndyRussG: I think I lost you. [18:39:45] K4-713: https://gerrit.wikimedia.org/r/#/c/234164/ [18:39:49] yep [18:40:53] AndyRussG: I think this room is broken. [18:41:01] Hmm [18:41:06] Walls cavaing in? [18:44:46] K4-713: hello? [18:45:00] K4-713: I cannot hear you [18:45:16] WMF wifi foo [19:02:42] awight: K4 suggests instead of reverting, cherry picking around that patch so we just don't deploy it yet [19:04:47] AndyRussG: hahaha, cryptorevert [19:05:02] If it's wrong, we should revert it... [19:05:07] awight: indeed, yeah it'll be like a fun albatross [19:05:49] awight: I'm not 100% sure it's 100% wrong... Just large enough percentages to not want to deploy it like a madman [19:06:08] OK it's up to you, we can wait to revert or fix of course [19:06:12] wrong! :P [19:06:13] just kidding. i have no idea what you're talking aobut [19:06:22] <_< [19:06:35] * awight quickly puts the lid back on the magic lantern [19:07:05] hehehe [19:07:13] atgo: hi! [19:07:36] hi AndyRussG! [19:07:50] awight: I wanted to check the right process to merge master to the feature branch - git review ? (some comments here https://phabricator.wikimedia.org/T99836#1673576) [19:08:44] (PS19) Ori.livneh: Migrate to a terser cookie name and format [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235979 (https://phabricator.wikimedia.org/T110353) [19:08:58] * atgo shuts up about how awesome the super blood moon was with two lightning storms on either side last night [19:09:07] ohh nice [19:09:51] atgo: woo amazing :) [19:10:17] You deserve it! [19:14:50] Fundraising-Backlog: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1682291 (CCogdill_WMF) NEW [19:20:14] Fundraising-Backlog: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1682323 (CCogdill_WMF) [19:34:26] Fundraising-Backlog: Better payment method indexing in DonationInterface - https://phabricator.wikimedia.org/T114013#1682362 (cwdent) NEW [19:58:23] (PS1) AndyRussG: WIP Temporary fix for DB master/slave switching [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241752 [20:00:03] eileen: To merge from trunk? yeah, I do "git cherry -v featurebranch master" then paste that output into the commit message for "git merge master". [20:00:28] There's one gotcha, you have to git commit --amend after the merge in order to make get a Change-Id in the commit message [20:00:45] awight OK I will give it a go [20:01:32] finally, git review [20:01:35] (CR) AndyRussG: "Also looking into caching improvements on Special:BannerLoader." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234164 (https://phabricator.wikimedia.org/T92357) (owner: Aaron Schulz) [20:01:37] cool, lmk how it goes! [20:02:54] (PS1) Awight: WIP enum for banner hide reasons [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241753 (https://phabricator.wikimedia.org/T113813) [20:03:40] (CR) jenkins-bot: [V: -1] WIP enum for banner hide reasons [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241753 (https://phabricator.wikimedia.org/T113813) (owner: Awight) [20:30:44] AndyRussG: you wanted to take over that patch? [20:30:53] awight: what works best 4 you? [20:31:05] I can keep plugging away, if there are other pots you're stirring [20:31:18] I was about to eliminate the reasonCode stuff... [20:31:33] and do the mapping transparently in bannerHistory [20:32:18] awight: yeah that totally makes sense! [20:32:41] That probably means I should move the mapping out of display.state and into bannerHistory, that sound right? [20:32:42] awight: if u have time to do it now, please go 4 it! really sorry to be rushing [20:32:50] no prob, I'll do my best [20:33:12] awight: mmm not sure... I was thinking about it but I think it makes most sense in state [20:33:20] but it could be either really [20:33:29] ok sure I'll leave it for now [20:34:12] AndyRussG: you still want statusCode to end in ".reasonCode"? [20:34:45] awight: yeah something like that, I don't want to fiddle w/ the EL schema at this point [20:35:36] cool [20:37:42] awight: I think u can latch onto cancelBanner and setBannerLoadedButHidden methods in state, remove the reasonCode parameters, and use the map to auto-set the reason code there, what do you think? [20:38:38] totally [20:39:10] :) [20:40:20] K I'm gonna book the SWAT deploy finally (there's still lots of space) [20:41:26] (PS2) Awight: WIP enum for banner hide reasons [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241753 (https://phabricator.wikimedia.org/T113813) [20:45:13] AndyRussG: looks like that WIP actually does the job. [20:45:43] Checking whether it handles the legacy cookie case... [20:46:29] awight: fantastic, thanks so much! yeah checking out the latest and greatest now :) [20:49:48] eileen: lmk if I can help with anything! [20:50:47] awight: cool - I’m just trying to wrangle the patches in [20:52:22] AndyRussG: One small difference, you had statusCode set to not append the code if it was missing, I'm using an "other" code instead. [20:52:42] awight: that sounds great, yea! [20:52:54] mrrrg now I'm getting nervous!! [20:53:13] Maybe we should just call it off. Who wants banner history anyway? [20:53:19] hehe [20:53:23] (PS1) Eileen: T99836 remove apiv2 Entity Tag call [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241892 [20:53:25] (PS1) Eileen: T99836 Civi46: adapt to pre-hook standardisation [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241893 [20:53:27] (PS1) Eileen: T99836 Civi46 update refund test for changed parameter [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241894 [20:53:29] (PS1) Eileen: T99836 Civi46 adapt to DAO BAO rename to CRM_Mailing_DAO_MailingJob [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241895 [20:53:30] better to remain celibate [20:53:31] (PS1) Eileen: Merge from master : Revert commits on wrong branch [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241896 (https://phabricator.wikimedia.org/T110367) [20:54:23] awight: There are some more after the ones I just put up for review - but I think I need to get https://gerrit.wikimedia.org/r/#/c/240953/ merged before I can include it as the submodule from the crm repo [20:54:31] (CR) jenkins-bot: [V: -1] T99836 remove apiv2 Entity Tag call [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241892 (owner: Eileen) [20:55:44] (CR) jenkins-bot: [V: -1] T99836 Civi46: adapt to pre-hook standardisation [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241893 (owner: Eileen) [20:56:16] eileen: u know anything about the test failures? [20:56:16] WD php: Exception: 'civicrm_contribution' is not a valid option for [error] [20:56:19] field used_for in wmf_civicrm_update_7016() (line 871 of [20:56:22] /mnt/jenkins-workspace/workspace/wikimedia-fundraising-civicrm/src/wikimedia/fundraising/crm/sites/all/modules/wmf_civicrm/wmf_civicrm.install). [20:56:27] (PS3) Awight: Enum for banner hide reasons [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241753 (https://phabricator.wikimedia.org/T113813) [20:56:31] (CR) jenkins-bot: [V: -1] T99836 Civi46 update refund test for changed parameter [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241894 (owner: Eileen) [20:57:08] (CR) jenkins-bot: [V: -1] T99836 Civi46 adapt to DAO BAO rename to CRM_Mailing_DAO_MailingJob [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241895 (owner: Eileen) [20:57:25] awight: yeah - that is a patch combo thing [20:57:44] that one is fixed with all the right patches on the right version…. [20:57:57] ah, so like crm vs civicrm repos? [20:58:00] rats [20:58:09] (CR) jenkins-bot: [V: -1] Merge from master : Revert commits on wrong branch [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241896 (https://phabricator.wikimedia.org/T110367) (owner: Eileen) [20:58:12] yeah - it needs the right version of both [20:58:53] there’s some interrelatedness [20:59:42] (CR) Cdentinger: [C: 2] "can only help" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/241714 (owner: Awight) [20:59:54] eileen: Did you see that I had to revert ef9b4bde2a75f76a7cd999280fd647f7d58498de separately? We missed it in the big master-branch revert, so it wouldn't have been added to the feature branch when you reverted the revert. [21:00:19] awight: yeah - that was on my list to figure out after I’d worked out getting master merged [21:00:27] cool [21:00:44] (I don’t know if you read that comment on https://phabricator.wikimedia.org/T99836#1673576 [21:01:00] (Merged) jenkins-bot: Play nice if we don't own this file type [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/241714 (owner: Awight) [21:01:59] eileen: Would you prefer that we merge these if they look remotely sane, and do more testing on the final product, or that I do thorough review on each patch? [21:02:20] awight: I think that if there are no alarm bells you should merge [21:02:26] great [21:02:53] the goal is to get to a stable state with tests passing & an upgraded instance to view [21:03:23] & then figure out what needs to happen before upgrading (what testing we can do & what blockers have to be fixed pre-upgrade) [21:07:12] (CR) Awight: [C: -1] T99836 remove apiv2 Entity Tag call (4 comments) [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241892 (owner: Eileen) [21:07:32] (CR) Awight: [C: 2] T99836 Civi46: adapt to pre-hook standardisation [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241893 (owner: Eileen) [21:07:46] (CR) Awight: [C: 2] T99836 Civi46 update refund test for changed parameter [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241894 (owner: Eileen) [21:09:58] (CR) Awight: [C: -1] "tiny typo" (2 comments) [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241895 (owner: Eileen) [21:10:10] (CR) Awight: [C: 2] Merge from master : Revert commits on wrong branch [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241896 (https://phabricator.wikimedia.org/T110367) (owner: Eileen) [21:15:28] (PS2) Eileen: T99836 Civi46 adapt to DAO BAO rename to CRM_Mailing_DAO_MailingJob [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241895 [21:15:54] (CR) jenkins-bot: [V: -1] T99836 Civi46 adapt to DAO BAO rename to CRM_Mailing_DAO_MailingJob [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241895 (owner: Eileen) [21:16:24] (CR) Awight: [C: 2] T99836 Civi46 adapt to DAO BAO rename to CRM_Mailing_DAO_MailingJob (1 comment) [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241895 (owner: Eileen) [21:16:28] (CR) Eileen: "I've pushed an amend now" (1 comment) [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241895 (owner: Eileen) [21:16:49] (CR) jenkins-bot: [V: -1] T99836 Civi46 adapt to DAO BAO rename to CRM_Mailing_DAO_MailingJob [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241895 (owner: Eileen) [21:20:47] (CR) AndyRussG: Enum for banner hide reasons (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241753 (https://phabricator.wikimedia.org/T113813) (owner: Awight) [21:22:14] (PS2) Eileen: T99836 remove apiv2 Entity Tag call [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241892 [21:22:20] (PS4) Awight: Enum for banner hide reasons [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241753 (https://phabricator.wikimedia.org/T113813) [21:22:24] (CR) Awight: Enum for banner hide reasons (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241753 (https://phabricator.wikimedia.org/T113813) (owner: Awight) [21:22:27] (PS5) Awight: Enum for banner hide reasons [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241753 (https://phabricator.wikimedia.org/T113813) [21:22:45] (CR) jenkins-bot: [V: -1] T99836 remove apiv2 Entity Tag call [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241892 (owner: Eileen) [21:23:10] (CR) Awight: [C: 2] T99836 remove apiv2 Entity Tag call (1 comment) [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241892 (owner: Eileen) [21:23:12] (CR) Eileen: "new patch submitted now" (1 comment) [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241892 (owner: Eileen) [21:23:20] (CR) Awight: [V: 2] T99836 remove apiv2 Entity Tag call [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241892 (owner: Eileen) [21:23:27] (PS2) Awight: T99836 Civi46: adapt to pre-hook standardisation [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241893 (owner: Eileen) [21:23:33] (CR) Awight: [V: 2] T99836 Civi46: adapt to pre-hook standardisation [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241893 (owner: Eileen) [21:23:41] eileen: setUp can be removed now... no big deal [21:23:48] (PS2) Awight: T99836 Civi46 update refund test for changed parameter [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241894 (owner: Eileen) [21:23:53] (CR) Awight: [V: 2] T99836 Civi46 update refund test for changed parameter [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241894 (owner: Eileen) [21:24:14] (PS2) Awight: Merge from master : Revert commits on wrong branch [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241896 (https://phabricator.wikimedia.org/T110367) (owner: Eileen) [21:24:19] (CR) Awight: [V: 2] Merge from master : Revert commits on wrong branch [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241896 (https://phabricator.wikimedia.org/T110367) (owner: Eileen) [21:24:31] (PS3) Awight: T99836 Civi46 adapt to DAO BAO rename to CRM_Mailing_DAO_MailingJob [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241895 (owner: Eileen) [21:24:36] (CR) Awight: [V: 2] T99836 Civi46 adapt to DAO BAO rename to CRM_Mailing_DAO_MailingJob [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241895 (owner: Eileen) [21:24:38] awight ok - I removed it - but you might have merged first [21:24:50] ;) sorry [21:24:57] (CR) jenkins-bot: [V: -1] Merge from master : Revert commits on wrong branch [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241896 (https://phabricator.wikimedia.org/T110367) (owner: Eileen) [21:25:01] but I think there is something else that touches that file that might not be in yet [21:25:02] (PS3) Awight: Merge from master : Revert commits on wrong branch [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241896 (https://phabricator.wikimedia.org/T110367) (owner: Eileen) [21:25:07] (CR) Awight: [V: 2] Merge from master : Revert commits on wrong branch [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241896 (https://phabricator.wikimedia.org/T110367) (owner: Eileen) [21:25:45] awight: did you also see this one https://gerrit.wikimedia.org/r/#/c/240953/ [21:25:55] (CR) Awight: [C: 2 V: 2] "Cool!" [wikimedia/fundraising/crm/civicrm] (4.6.9-deploy) - https://gerrit.wikimedia.org/r/240953 (owner: Eileen) [21:26:21] (PS2) Awight: T99836 Civi46: remove calls to pesudoconstant:phoneType [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/240303 (owner: Eileen) [21:27:32] (CR) Awight: [C: 2 V: 2] "Assuming we're okay using the results of the old schema install..." [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/240303 (owner: Eileen) [21:33:02] (PS5) Awight: Include custom fields in default export [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/238636 (https://phabricator.wikimedia.org/T105918) [21:33:27] (Abandoned) Awight: Include custom fields in default export [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/238636 (https://phabricator.wikimedia.org/T105918) (owner: Awight) [21:35:22] (PS3) Awight: Don't close Amazon order reference in DI [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240909 (https://phabricator.wikimedia.org/T113809) (owner: Ejegg) [21:35:41] (CR) Awight: [C: 2] Don't close Amazon order reference in DI [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240909 (https://phabricator.wikimedia.org/T113809) (owner: Ejegg) [21:36:01] thanks awight! [21:36:08] (CR) Awight: "3.3s ± 500%" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240909 (https://phabricator.wikimedia.org/T113809) (owner: Ejegg) [21:36:26] ejegg: just kick me if I'm overlooking stuff u need! [21:36:32] (Merged) jenkins-bot: Don't close Amazon order reference in DI [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/240909 (https://phabricator.wikimedia.org/T113809) (owner: Ejegg) [21:36:41] (PS2) Awight: Close Amazon order reference when capture completes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/241247 (https://phabricator.wikimedia.org/T113809) (owner: Ejegg) [21:36:43] heh, thanks [21:39:12] (CR) Awight: "What happens if the message never comes through IPN?" (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/241247 (https://phabricator.wikimedia.org/T113809) (owner: Ejegg) [21:41:05] (CR) AndyRussG: Enum for banner hide reasons (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241753 (https://phabricator.wikimedia.org/T113813) (owner: Awight) [21:41:05] Fundraising Sprint Tom Waits, Fundraising-Backlog: Fix Worldpay audit parsing - https://phabricator.wikimedia.org/T113782#1682991 (awight) [21:41:14] awight: patch looks great, just an issue in the commit message! [21:41:45] hehe great [21:42:41] awight: just smoke testing here too :) [21:42:53] (PS6) Awight: Enum for banner hide reasons [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241753 (https://phabricator.wikimedia.org/T113813) [21:42:56] thanks! [21:45:27] AndyRussG: you trying to get https://gerrit.wikimedia.org/r/#/c/240960 out as well? [21:45:34] That one makes me nervous... [21:45:47] awight: why? [21:45:52] sessionId [21:46:06] awight: it's not an ID stored anywhere on the client [21:46:30] Do you think we should hold off? It'd unfulfil one of Ellery's requirements, but we could just not push that one out yet [21:46:49] I'd rather store an ID in localStorage, but I assume you avoided that due to respect for privacy? [21:47:01] awight: correct, it's not stored anywhere [21:47:21] awight: always different on every pageview, it's not really a log id, but more like a log-pageview-id [21:47:25] I'm not seeing the risk [21:47:53] awight: you mean, not a risk, so deploy? Or u don't follow ^ ? [21:47:55] and I guess the reasoning is that session ID is good enuf, cos the log will be reset if it's sent? [21:48:07] awight: sorry wat? [21:48:15] * awight turns down my headphones [21:48:26] awight: the log isn't resent ever on the same pageview, that's one of the points of that patch [21:49:03] My thoughts are * session ID doesn't seem to guarantee that we're actually deduping, and * I don't understand how storing a longer-lived ID would be a privacy risk [21:49:04] (PS1) Eileen: Revert "Revert "4.6 upgrade preparation, replace contribution_type with financial_type"" [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241905 [21:49:06] It may be resent from one pageview to the next, by virtue of random sampling, but the two are never associated. Ellery doesn't care. Source: Ellery [21:49:21] awight: Ellery doesn't care to dedup [21:49:28] His analysis is gonna be simpler than that [21:49:30] what the... ok [21:49:42] (CR) jenkins-bot: [V: -1] Revert "Revert "4.6 upgrade preparation, replace contribution_type with financial_type"" [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241905 (owner: Eileen) [21:49:43] Basically pageview is the base unit of analysis [21:49:46] then I have no complaints [21:49:57] ;p woohoo! [21:50:32] :) glad to see you in a real slash n burn mood [21:52:22] oh hah, I see now that this patch was already merged anyway [21:52:34] * awight dodders back to desk [21:53:03] (PS1) Eileen: Revert "Revert commits on wrong branch" [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241907 [21:53:15] I'm moving that task to Pending Deployment [21:53:29] (CR) jenkins-bot: [V: -1] Revert "Revert commits on wrong branch" [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241907 (owner: Eileen) [21:54:05] (PS3) Ejegg: Close Amazon order reference when capture completes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/241247 (https://phabricator.wikimedia.org/T113809) [21:54:14] (CR) Awight: [C: 2 V: 2] Revert "Revert "4.6 upgrade preparation, replace contribution_type with financial_type"" [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241905 (owner: Eileen) [21:57:47] (CR) AndyRussG: Enum for banner hide reasons (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241753 (https://phabricator.wikimedia.org/T113813) (owner: Awight) [21:58:28] slash 'n burn, yeah on somebody else's acrage! [21:58:44] :) [21:58:44] awight: ^ 'nother tweak [21:58:47] :) [21:59:31] (CR) Awight: [C: 2] "OK, thanks! I guess we can wait until we have a glut of unclosed donations to worry about the missed ones..." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/241247 (https://phabricator.wikimedia.org/T113809) (owner: Ejegg) [22:00:23] (Merged) jenkins-bot: Close Amazon order reference when capture completes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/241247 (https://phabricator.wikimedia.org/T113809) (owner: Ejegg) [22:00:40] (Abandoned) Eileen: Revert "Revert commits on wrong branch" [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241907 (owner: Eileen) [22:02:31] AndyRussG: you happen to know where 'donate' comes from? [22:02:38] awight: donations? [22:02:44] I would have thought the wmfwiki thank-you page [22:03:02] Here? https://www.mediawiki.org/wiki/Extension:CentralNotice/Special:RecordImpression [22:03:15] oh, dear [22:03:29] ok thx, there are few here that I didn't see in the wild [22:03:31] (ps. don't worry about a bunch of those, many are outdated I'm pretty sure) [22:03:51] awight: remember those are codes that show up in S:RI, not necessarily in any cookies [22:04:31] awight: empty and alterImpressionData are nought [22:04:48] I guess even those that never make it to a cookie are needed, sorry I waz confused [22:05:02] so yeah I guess add 'em all, can't hurt [22:05:18] I'm scraping the impression logs to check... [22:05:32] (PS1) Eileen: T9936 Civi46: remove calls to pseudoconstants:individualPrefix & Suffix [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241911 [22:05:34] (PS1) Eileen: T99836 Civi46: ensure that preferred language exists when creating a contact [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241912 [22:05:36] (PS1) Eileen: T99836 Civi46 fix ensure_prefix & ensure_suffix for 4.6 [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241913 [22:05:38] (PS1) Eileen: T99836 fix dumb typo in test [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241914 [22:06:19] (CR) jenkins-bot: [V: -1] T9936 Civi46: remove calls to pseudoconstants:individualPrefix & Suffix [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241911 (owner: Eileen) [22:06:31] cvv cvn cv2 WHICH IS IT [22:06:57] (CR) jenkins-bot: [V: -1] T99836 Civi46: ensure that preferred language exists when creating a contact [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241912 (owner: Eileen) [22:07:11] cwdent: I think there are more... [22:07:30] https://en.wikipedia.org/wiki/Card_security_code [22:07:33] CSC [22:07:46] (CR) jenkins-bot: [V: -1] T99836 Civi46 fix ensure_prefix & ensure_suffix for 4.6 [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241913 (owner: Eileen) [22:07:47] CVC2 CID CVE [22:07:56] CVN2 [22:08:00] CVV2 [22:08:23] (CR) jenkins-bot: [V: -1] T99836 fix dumb typo in test [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241914 (owner: Eileen) [22:08:44] baffling [22:09:44] (PS1) AndyRussG: Merge commit 'ff754b0f6176' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/241917 [22:09:52] AndyRussG: crap. in a recent sample, 367 'close' and 250 'other' [22:10:27] awight: 367 close and other where? [22:10:45] awight: ur sampling cookies from the logs or somthin'? [22:10:49] In the banner impression parser logs... job #39465 [22:11:26] awight: cool! So what's the problem? [22:11:53] awight: it's an MVP [22:12:25] in the case of this patch, something is better than nothing [22:12:39] even if it's only 3/4 of a something [22:12:52] though in fact I think it's much more than that [22:13:19] so long as we're not affecting user experience and increasing the data's usefulness in some degree, it's all cool, I think! [22:13:32] :D [22:15:38] Should I self-merge? ^ Just gonna cherry pick the rest that we want [22:16:52] (PS7) Awight: Enum for banner hide reasons [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241753 (https://phabricator.wikimedia.org/T113813) [22:17:04] (PS8) Awight: Enum for banner hide reasons [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241753 (https://phabricator.wikimedia.org/T113813) [22:17:18] AndyRussG: yeah totally self-merge the branch stuff [22:17:25] weeeeeeeeeefsdnlsdfkjlsfksfg [22:17:26] * awight find self staring at sed -r 's/^\.*reason=\([a-zA-Z]+\)\.*$/\1/' [22:17:37] WHY all the escaping [22:17:56] (CR) jenkins-bot: [V: -1] Enum for banner hide reasons [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241753 (https://phabricator.wikimedia.org/T113813) (owner: Awight) [22:17:57] Still not recognizing the capture [22:18:23] awight: ah just add in donate and any more that strike your fancy, and I'll merge it! :) [22:18:32] (PS9) Awight: Enum for banner hide reasons [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241753 (https://phabricator.wikimedia.org/T113813) [22:18:42] I'll write a followon patch if I find more [22:19:10] awight: fantastic thanks so much!!!!!!!!!! [22:20:16] (CR) AndyRussG: [C: 2] "Thanks a ton!!!! :D" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241753 (https://phabricator.wikimedia.org/T113813) (owner: Awight) [22:20:30] zcat beaconImpressions-sampled100.tsv-20150928-220001.log.gz | grep 'reason=' | sed -r 's/^.*reason=([a-zA-Z]+).*$/\1/' [22:20:46] lol "cookies" [22:21:30] (CR) AndyRussG: [C: 2] Merge commit 'ff754b0f6176' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/241917 (owner: AndyRussG) [22:21:42] (PS1) AndyRussG: KVStore: batched, more resilient implementation of TTL for items [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/241923 (https://phabricator.wikimedia.org/T111385) [22:22:26] (CR) AndyRussG: [C: 2] KVStore: batched, more resilient implementation of TTL for items [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/241923 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG) [22:23:13] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Banner history: encode all hide reasons - https://phabricator.wikimedia.org/T113813#1683251 (awight) [22:23:28] (PS1) AndyRussG: BannerHistoryLogger: always send log ID, never send twice [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/241926 (https://phabricator.wikimedia.org/T113421) [22:24:22] Fundraising-Backlog: [epic] Worldpay campaign ready in France - https://phabricator.wikimedia.org/T110114#1683255 (awight) [22:24:24] Fundraising Sprint Tom Waits, Fundraising-Backlog: Review audit parsing, review whether existing stuff is working. - https://phabricator.wikimedia.org/T112807#1683254 (awight) Open>Resolved [22:24:30] Fundraising Sprint Tom Waits, Fundraising-Backlog: Review audit parsing, review whether existing stuff is working. - https://phabricator.wikimedia.org/T112807#1646663 (awight) Confirmed working. [22:25:13] Hmm Jenkins is taking a while to merge stuff? [22:26:11] Looks like it, https://integration.wikimedia.org/zuul/ [22:26:18] (CR) AndyRussG: [C: 2] BannerHistoryLogger: always send log ID, never send twice [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/241926 (https://phabricator.wikimedia.org/T113421) (owner: AndyRussG) [22:27:00] Should I wait for the enum patch to merge to master before cherry-pick? hmmm I guess not [22:27:19] Well no, I will, what if Gerrit creates a merge patch [22:27:22] (PS1) Awight: Add more banner hide reasons [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241938 (https://phabricator.wikimedia.org/T113813) [22:27:55] AndyRussG: usually it's fine to do, I've never seen Gerrit create merge patches. But it can become incredibly confusing if you end up amending ;) [22:28:01] Just did that to myself this morning... [22:28:09] Hmmm [22:28:11] AndyRussG: ^ a few more hide reasons [22:28:18] apparently, we still see "empty" [22:28:20] yikes [22:28:32] (CR) Cdentinger: Fixmes (1 comment) [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/216854 (owner: Awight) [22:29:20] (PS1) Eileen: T99836 Civi46: reapply commits reverted in master [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/241943 [22:29:22] (CR) jenkins-bot: [V: -1] T99836 Civi46: reapply commits reverted in master [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/241943 (owner: Eileen) [22:29:30] (CR) Awight: Fixmes (1 comment) [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/216854 (owner: Awight) [22:30:38] eileen: ah sorry, I thought the commit was just one thing, with the wrong commit message, but I see now it really is a mashup! [22:30:50] (PS2) Awight: T99836 Civi46: reapply commits reverted in master [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/241943 (owner: Eileen) [22:31:13] (Merged) jenkins-bot: Enum for banner hide reasons [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241753 (https://phabricator.wikimedia.org/T113813) (owner: Awight) [22:31:15] (Merged) jenkins-bot: Merge commit 'ff754b0f6176' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/241917 (owner: AndyRussG) [22:31:18] (Merged) jenkins-bot: KVStore: batched, more resilient implementation of TTL for items [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/241923 (https://phabricator.wikimedia.org/T111385) (owner: AndyRussG) [22:31:22] (Merged) jenkins-bot: BannerHistoryLogger: always send log ID, never send twice [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/241926 (https://phabricator.wikimedia.org/T113421) (owner: AndyRussG) [22:31:40] (CR) jenkins-bot: [V: -1] T99836 Civi46: reapply commits reverted in master [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/241943 (owner: Eileen) [22:31:50] awight: yeah - It was! so good that you were on the ball with it [22:32:50] (Abandoned) Eileen: T99836 Civi46: reapply commits reverted in master [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/241943 (owner: Eileen) [22:33:00] * awight attempts to revert own confusion [22:33:22] awight: well - if you see I then put it against master again! [22:33:42] LOL thanks, I was just about to merge... [22:33:50] ! [22:34:18] (PS1) Eileen: T99836 Civi46: reapply commits reverted in master [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241947 [22:34:27] * awight puts merge keys in the cookie jar by door for the evening [22:35:01] (CR) jenkins-bot: [V: -1] T99836 Civi46: reapply commits reverted in master [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241947 (owner: Eileen) [22:35:11] ok - right branch THIS time.... [22:36:30] (PS1) AndyRussG: Enum for banner hide reasons [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/241948 (https://phabricator.wikimedia.org/T113813) [22:37:03] (CR) Awight: [C: 2 V: 2] T99836 Civi46: reapply commits reverted in master [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241947 (owner: Eileen) [22:37:28] (CR) AndyRussG: [C: 2] Enum for banner hide reasons [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/241948 (https://phabricator.wikimedia.org/T113813) (owner: AndyRussG) [22:37:40] eileen: Very minor thing, we have a convention where the bug number goes in the commit msg footer, e.g. https://gerrit.wikimedia.org/r/#/c/241948/ [22:38:09] awight: OK - I’ll switch to that [22:38:17] thx! [22:38:24] awight: cwdent: ejegg: XenoRyet: this is the tip of wmf_deploy that we'd deploy in a few minutes.... last-minute smoke tests welcome!! [22:39:08] * AndyRussG breaks out ie11 vm's [22:39:31] Great, testing now! [22:39:48] cool, i'll pull it down [22:39:57] yeah me too [22:40:06] amazing thanks!!!! [22:40:16] It's missing the close reason patch... probably just didn't merge yet [22:40:37] yep [22:40:38] awight: what is, origin/wmf_deploy? [22:40:41] yeah [22:40:47] it's still pending submit in Zuul [22:40:48] yea I just +2'ed it [22:41:12] (kick) that did it [22:41:26] heh nice! [22:42:19] hrm, reset=1 doesn't work any more [22:43:39] awight: orly? Isn't that hard-coded into banner scripts? what are u testing that with? [22:43:41] (PS1) Eileen: Civi46 update refund test for changed parameter (no 2) [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241949 [22:45:52] Fundraising-Backlog: Make the Search bar work for non-exact searches - https://phabricator.wikimedia.org/T114053#1683376 (CaitVirtue) NEW [22:47:40] not seeing anything breaking in cn so far [22:47:46] what should reset=1 do again? [22:48:07] AndyRussG's right that it's only implemented in banner code now--but it's supposed to clear hide cookies [22:48:16] gotcha [22:48:36] (CR) jenkins-bot: [V: -1] Civi46 update refund test for changed parameter (no 2) [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241949 (owner: Eileen) [22:48:48] I'm trying to figure out why the banner isn't displaying when I already have hide cookies, though--I guess there's no builtin way to reset now [22:49:04] awight: right. So it'll only work when you get a banner on prod that has those scripts. Later if u like we can add it to like to the codebase [22:49:11] Or was it already there and I forgot it? [22:49:18] If u like, for now, just delete the cookie [22:49:54] Sure. Our users are all fine with that! [22:50:18] awight: ? [22:50:25] reset should work on prod [22:50:28] I think! [22:50:54] awight: in any case, if it's a problem, it's not new with what's about to go out, but from 3 weeks ago [22:50:59] Not being sarcastic :) The only people who will need to clear cookies are CN admins, and they'll already know to do it [22:51:45] Might be worth mentioning in the release notes, though, if it wasn't already. [22:52:10] awight: confirmed that it was never directly in CN code, so their workflow in theory shouldn't change, it's only on-wiki, already in their stuff [22:52:24] ok great, that's what I see too. [23:06:15] (PS1) Eileen: Civi46 adjust expected return array in testImport [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241957 [23:07:00] (CR) Awight: [C: 2] Civi46 adjust expected return array in testImport [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241957 (owner: Eileen) [23:07:06] (CR) Awight: [V: 2] Civi46 adjust expected return array in testImport [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241957 (owner: Eileen) [23:07:16] (PS5) Awight: More inline help for mixins [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/239302 [23:11:18] i'm going to see if i can't flash in this skylight before it starts raining. back later! [23:12:14] (PS1) Eileen: Merge from master :Include custom fields in default export [wikimedia/fundraising/crm/civicrm] (4.6.9-deploy) - https://gerrit.wikimedia.org/r/241966 (https://phabricator.wikimedia.org/T105918) [23:12:51] (PS6) Awight: More inline help for mixins [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/239302 [23:13:01] (CR) Awight: "Thanks!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/239302 (owner: Awight) [23:15:16] eileen: fyi, it's fine to self-merge merges like that! [23:15:27] awight ah cool [23:15:41] (although given my mess so far in getting the right branch!!!) [23:16:07] hehe it's also fine to get a second opinion if anything seems fishy [23:16:46] (PS1) Eileen: Civi46: adapt to pre-hook standardisation (2) [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241970 (https://phabricator.wikimedia.org/T99836) [23:16:59] (PS2) Awight: Civi46: adapt to pre-hook standardisation (2) [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241970 (https://phabricator.wikimedia.org/T99836) (owner: Eileen) [23:17:05] I think I’ve nearly gotten all the local patches into gerrit... [23:17:09] (CR) Awight: [C: 2 V: 2] Civi46: adapt to pre-hook standardisation (2) [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241970 (https://phabricator.wikimedia.org/T99836) (owner: Eileen) [23:18:18] awight: cwdent|afk: ejegg: XenoRyet: K4-713: all deploy'd [23:18:30] So far, so good! [23:18:43] nice... [23:18:51] Yay! [23:19:01] (CR) Eileen: [C: 2] "merge from master" [wikimedia/fundraising/crm/civicrm] (4.6.9-deploy) - https://gerrit.wikimedia.org/r/241966 (https://phabricator.wikimedia.org/T105918) (owner: Eileen) [23:19:17] Awesome [23:20:21] Yeah! site's still up, apprently!! [23:20:34] * AndyRussG anticipates breathing a sigh of relief ;p [23:21:49] (CR) Eileen: [V: 2] Merge from master :Include custom fields in default export [wikimedia/fundraising/crm/civicrm] (4.6.9-deploy) - https://gerrit.wikimedia.org/r/241966 (https://phabricator.wikimedia.org/T105918) (owner: Eileen) [23:24:01] AndyRussG: wow! [23:24:04] (PS1) Eileen: Civi46: update to latest version of the submodule [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241975 [23:24:18] works gut so far! [23:24:37] close banner, reload, mw.centralNotice.getData( 'statusCode' ); [23:25:55] (CR) jenkins-bot: [V: -1] Civi46: update to latest version of the submodule [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241975 (owner: Eileen) [23:27:21] (PS2) Eileen: Civi46: update to latest version of the submodule [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241975 [23:27:58] (CR) jenkins-bot: [V: -1] Civi46: update to latest version of the submodule [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241975 (owner: Eileen) [23:29:21] XenoRyet: ejegg: awight: K4-713: cwdent|afk: all good on chrome, FF, IE11... [23:29:50] Anyone have an iPhone to test on? https://en.wikipedia.org/wiki/Main_Page?country=IL should get u a WLM banner... [23:32:05] (PS3) Awight: CentralNotice should use content rather than interface language [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/197741 (https://phabricator.wikimedia.org/T53475) [23:32:16] not I [23:33:25] (CR) jenkins-bot: [V: -1] CentralNotice should use content rather than interface language [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/197741 (https://phabricator.wikimedia.org/T53475) (owner: Awight) [23:34:12] eileen: If you want the 1-minute background for https://phabricator.wikimedia.org/T88836 , we created import templates which should cover all existing use cases. [23:34:14] Banners also still showing on native Android browser and FF for Android, at least on my silly phone [23:34:45] eileen: We want to get some third parties out of our Civi instance, and have them fill out spreadsheets instead, so we can do quality control and to improve security. [23:34:48] awight: what does an import template refer too? [23:34:59] That bug links to our two examples [23:35:08] They're just spreadsheets with columns for everything we care about. [23:36:59] awight: & then you script import them? [23:37:10] Currently, there's a UI for importing [23:37:31] also working fine on IE10 [23:37:32] It's really crude, all it offers are radio buttons and filename matching to set file type, and a log pager. [23:37:45] eileen: This is the offline2civicrm module [23:37:52] ah cool [23:38:37] should we talk about the staging server update [23:39:19] Sure! just to finish up the import topic--don't feel like you have to go to this meeting, but your experience will be really valuable to get us away from a custom importer in the future. [23:39:37] Want me to set up the staging migration? [23:39:56] awight: ok - why do you choose not to use the CivICRM import ui? Doesn’t cover multiple entities? [23:40:04] too annoying? [23:40:10] Mostly cos I didn't know how to :( [23:40:20] The field mappings thing did annoy me right outta the ballpark [23:40:50] also, there's some custom logic which coaxes vendor file formats into fields that can be consumed by Civi [23:41:22] Finally, we want to go through our regular wmf_civicrm message import entry point cos there's stuff in there which is not properly encapsulated in Civi hooks. [23:41:53] fwiw I did an extension that makes that import UI import against any api - so that import UI *could* be used against a custom api [23:42:06] cool! [23:42:30] I’d love to see if converted to an angular form though... [23:42:50] sure, I have no love for the Drupal forms api [23:42:51] (PS1) Ejegg: WIP download reports from Amazon [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/242007 (https://phabricator.wikimedia.org/T109654) [23:43:12] dstrine-away: awight: ejegg: cwdent|afk: XenoRyet: K4-713: so if it's OK with everyone, and provided no deploy issues surface, I'll send an e-mail a little later to say that we can start testing BH on prod! [23:43:32] Great news! [23:43:32] nice! [23:44:41] awesome! [23:51:37] dstrine-away: awight: ejegg: cwdent|afk: XenoRyet: K4-713: yeah!!! Thanks so much, all :D [23:58:05] awight sorry - I didn’t see above - yes would good to try the staging migration again - there are a couple of unreviewed patches - not sure if it’s best to do them first? [23:58:40] yeah let's finish the CR [23:59:06] (PS2) Awight: T9936 Civi46: remove calls to pseudoconstants:individualPrefix & Suffix [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241911 (owner: Eileen) [23:59:40] (CR) Awight: [C: 2 V: 2] T9936 Civi46: remove calls to pseudoconstants:individualPrefix & Suffix [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241911 (owner: Eileen) [23:59:47] (PS2) Awight: T99836 Civi46: ensure that preferred language exists when creating a contact [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241912 (owner: Eileen)