[00:01:21] (CR) Awight: [C: 2 V: 2] "oh wow, thx!" [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241912 (owner: Eileen) [00:01:29] (PS2) Awight: T99836 Civi46 fix ensure_prefix & ensure_suffix for 4.6 [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241913 (owner: Eileen) [00:06:31] (CR) Awight: T99836 Civi46 fix ensure_prefix & ensure_suffix for 4.6 (2 comments) [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241913 (owner: Eileen) [00:06:37] (PS2) Awight: T99836 fix dumb typo in test [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241914 (owner: Eileen) [00:06:46] (CR) Awight: [C: 2 V: 2] T99836 fix dumb typo in test [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241914 (owner: Eileen) [00:07:07] (CR) jenkins-bot: [V: -1] T99836 Civi46 fix ensure_prefix & ensure_suffix for 4.6 [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241913 (owner: Eileen) [00:07:21] eileen: Still one left. I'll jump on IRC later tonight and try to get the upgrade running overnight. What's your schedule to"day"? [00:07:54] (CR) jenkins-bot: [V: -1] T99836 fix dumb typo in test [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241914 (owner: Eileen) [00:09:09] bye! [00:12:31] (CR) Eileen: "The error we are seeing on the tests indicates it is not running against 4.6 because in 4.6 the LocationType api DOES exist" [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241913 (owner: Eileen) [00:22:43] awight I’ll be around all day (my time) [00:22:57] I think there are 3 left? [01:28:27] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Banner history: encode all hide reasons - https://phabricator.wikimedia.org/T113813#1683769 (AndyRussG) Open>Resolved [01:28:29] Fundraising-Backlog: [EPIC] Banner history post launch - https://phabricator.wikimedia.org/T112923#1683770 (AndyRussG) [01:28:49] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Banner history: always send a temporary log ID, and never send back two logs on the same pageview - https://phabricator.wikimedia.org/T113421#1683771 (AndyRussG) Open>Resolved [01:29:27] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: [Mini epic] Activate Banner History! - https://phabricator.wikimedia.org/T112020#1683773 (AndyRussG) [01:29:30] Fundraising Sprint Queen, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, and 12 others: CentralNotice: key-value storage for new campaign-associated mixins/banner history - https://phabricator.wikimedia.org/T94763#1172159 (AndyRussG) [01:29:33] Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, and 3 others: Give KVStore items limited TTL - https://phabricator.wikimedia.org/T111385#1683772 (AndyRussG) Open>Resolved [01:30:03] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: Fix error for non-ECMA5 browsers in ext.centralNotice.display - https://phabricator.wikimedia.org/T112590#1683775 (AndyRussG) Open>Resolved [01:30:30] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic, Patch-For-Review: [epic] Banner History MVP - https://phabricator.wikimedia.org/T78089#1683777 (AndyRussG) [01:30:33] Fundraising Sprint Queen, Fundraising Sprint ODB, Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), and 5 others: Banner history mixins and data - https://phabricator.wikimedia.org/T90918#1683776 (AndyRussG) Open>Resolved [01:31:21] Fundraising Sprint Enya, Fundraising Tech Backlog, Fundraising-Backlog, § Fundraising Sprint Abba, and 4 others: Do banner hiding with mixins - https://phabricator.wikimedia.org/T86100#1683780 (AndyRussG) [01:31:24] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic, Patch-For-Review: [epic] Banner History MVP - https://phabricator.wikimedia.org/T78089#835293 (AndyRussG) [01:31:27] Fundraising Sprint Queen, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, and 12 others: CentralNotice: key-value storage for new campaign-associated mixins/banner history - https://phabricator.wikimedia.org/T94763#1683778 (AndyRussG) Open>... [01:31:30] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Epic, Patch-For-Review, and 2 others: Special:RecordImpression should die in a fire - https://phabricator.wikimedia.org/T45250#1683782 (AndyRussG) [01:31:36] bwahahahahaha [03:42:36] (CR) AndyRussG: [C: 2] "Amazing!!! Thanks so much!!!! :D" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235979 (https://phabricator.wikimedia.org/T110353) (owner: Ori.livneh) [03:50:52] (Merged) jenkins-bot: Migrate to a terser cookie name and format [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235979 (https://phabricator.wikimedia.org/T110353) (owner: Ori.livneh) [05:19:51] (PS2) Awight: Add more banner hide reasons [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241938 (https://phabricator.wikimedia.org/T113813) [05:19:56] (PS3) Awight: Add more banner hide reasons [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241938 (https://phabricator.wikimedia.org/T113813) [05:33:44] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Banner history: encode all hide reasons - https://phabricator.wikimedia.org/T113813#1683927 (awight) Ping: https://gerrit.wikimedia.org/r/#/c/241938/ [05:53:09] (PS1) Awight: Rename lookup function [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/242061 [05:53:11] (PS1) Awight: WIP Remove alterFunctionMissing stuff [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/242062 [05:53:13] (PS1) Awight: Link to bug in TODO [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/242063 [09:28:03] TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Fix failing export script - https://phabricator.wikimedia.org/T114090#1684222 (kai.nissen) NEW a:kai.nissen [10:04:15] (CR) Siebrand: [C: 1] "i18n/L10n reviewed." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/239302 (owner: Awight) [10:06:59] (CR) Siebrand: "i18n/L10n reviewed." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (https://phabricator.wikimedia.org/T112017) (owner: Awight) [10:53:20] TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Fix failing export script - https://phabricator.wikimedia.org/T114090#1684222 (kai.nissen) [15:25:00] i notice that the contributiontracking submodule in the payments mw branch does not have extension.json [15:54:53] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: "JimmyQuote" should be default appeal on payments - https://phabricator.wikimedia.org/T114127#1685351 (Pcoombe) NEW [16:04:55] (PS1) Pcoombe: Make "JimmyQuote" default appeal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242169 (https://phabricator.wikimedia.org/T114127) [16:19:38] AndyRussG|thnrgx: Congrats on getting banner history out and thanks for sending those emails. [16:29:46] the-wub: and K4-713 looking at the blocker email for amazon... is this really a blocker for the 1 hour test? [16:30:39] as I understand it, the 1 hour test is more for functionality [16:31:11] if there are significant UX problems that block donation, then they would block the 1 hour test right? [16:32:18] dstrine: I try not to make any calls on what I think of as "creative". :p [16:32:35] Totally up to the-wub and meganhernandez. [16:33:02] (CR) XenoRyet: [V: 2] Link to bug in TODO [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/242063 (owner: Awight) [16:33:21] cwdent: thanks for replying to that email, do you know how hard it would be to change the default message? [16:33:21] (CR) XenoRyet: [C: 2] Link to bug in TODO [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/242063 (owner: Awight) [16:33:34] K4-713: yeah I totally get that [16:33:36] dstrine: Changing the default is super-easy, though. I don't even think it'll take a code update: Just a settings deploy. [16:33:48] oh great [16:34:15] the-wub: are you watching any of this?^^^^ [16:34:19] yeah, sounds like the best idea, that text is way out of date [16:34:28] 93 employees [16:34:32] cwdent: You want to take this one? [16:34:39] Yeah, we should get railed for that nonsense. [16:34:39] dstrine: yeah, I think it's a blocker. we can't really be telling people we have 93 staff anymore. [16:34:45] i will poke at it! [16:34:47] :) [16:34:58] * cwdent is so scared of those localsettings files [16:35:04] the-wub: ok thanks [16:35:46] cwdent: thanks!!! do you want to wait for ejegg|away or awight? [16:35:49] cwdent: Hint: $wgDonationInterfaceAppealWikiTemplate [16:36:02] I could update the appeal on payments, but that would need Jeff to unlock it for me. and it's easier to change the default in code than going through and editing all the different translations [16:36:21] *on paymentswiki [16:36:29] K4-713: thanks! [16:36:33] dstrine: nah i can do it [16:36:43] cwdent: Totally. Let me know if I can provide more hints. [16:36:55] the-wub: this may only mean a few minutes delay, i'd like to avoid calling off the 1 hour test ... just delaying it a bit. [16:44:11] cwdent: I think that's the appeal parameter [16:44:38] oh right, you're looking to change the default when there is no param [16:44:46] so yeah, what K4-713 said [16:44:59] :) [16:45:07] yep, just trying to find the mapping between appeal name and template [16:45:14] Ha. [16:45:19] It's probably not there at all. [16:45:22] ...on-wiki. [16:45:37] is it in a db? [16:45:39] is https://gerrit.wikimedia.org/r/#/c/242169/ not right? I don't think there is a variable for the appeal (although there is a TODO comment for that) [16:45:43] Well, basically. [16:45:57] cwdent: I mean, in that all wiki pages are eventually in a db. [16:46:19] gotcha, so JimmyQuote is a wiki page? [16:46:21] You've got a local version of the payments wiki setup, yeah? [16:46:35] yep [16:46:49] Easy trick: If you go to a payment page on your local... there's a red link that goes straight to the thing you're missing. [16:46:49] ooh i get it [16:46:51] click the red link [16:46:53] :D [16:46:56] looks like it's just 'Appeal-default' [16:47:13] ejegg: On your local? Or in prod? [16:47:17] when there is no parameter [16:47:23] ejegg: i see that in the mustache tpl [16:47:24] This is one of those things you override in localsettings. [16:47:32] Could be anything in the wild. [16:47:56] so i just set it to literally JimmyQuote to get that page? [16:48:05] Well, with all the language mess, yeah. [16:48:16] Well, there's the AppealWikiTemplate, but that has magic words 'appeal' and 'language' that can be overridden via QS: $appeal = $request->getText( 'appeal', 'Appeal-default' ) [16:48:41] I think somebody took the language logic out of the code and put it in the easily editable localsetting config var to.... make... this... more difficult? [16:48:51] cwdent, K4-713: oh yeah, you probably want to copy https://payments.wikimedia.org/index.php/Template:LanguageSwitch to your local wiki if it isn't there already [16:49:06] Eh, I don't really do that anymore. :p [16:49:14] when i try bad values in prod i see stuff like: Template:2011FR/invalidappeal/text/en [16:49:14] I saw it in DonationInterface.php, though. [16:49:39] cwdent: ...when you say "try bad values in prod"... [16:50:15] cwdent: you can also set $wgWorldpayGatewayAppealWikiTemplate if you only want to affect Worldpay [16:50:20] cwdent: grep DonationInterface.php for the overrideable var... it's got a pattern on it. [16:50:27] ejegg: We don't. [16:50:37] oh [16:50:40] Also this is for Amazon, but also for totally bad old info. [16:50:56] shouldn't we just fix the text of the Appeal-default page then? [16:51:11] We still want to be able to override the appeal for QS to a/b test, right? [16:51:15] The thing is: Due to PCI, this is now Difficult. [16:51:25] And yes we do. [16:51:34] This is a bandaid. Also there's an email thread that says all these things. :p [16:51:47] ah ha [16:51:54] K4-713: i just meant put in templates that don't exist in the url [16:52:02] Oh, whew. [16:52:07] oh haha [16:52:09] no not that [16:52:12] oooh, dang... I see what happens with that [16:52:25] so we need to store appeal in session [16:52:30] Eventually. [16:52:33] Not today. [16:52:40] k [16:53:26] brb, need to go find more electricity [16:54:42] changing the config to JimmyQuote does try to load "Template:JimmyQuote" -- but the page title has all that other stuff in prod: "2011FR/invalidappeal/text/en" [16:54:50] is that language switcher stuff that will Just Work? [16:56:30] yep [16:56:38] or... no [16:56:42] that's just subpages [16:56:54] language switcher is a special page dealie [16:57:37] oh ok [16:58:05] so should it be "2011FR/JimmyQuote/text/en" ? [16:58:09] the global? [16:58:19] sorry i know nothing about this part [16:58:27] yeah, just swap $language for en [16:59:02] * K4-713 grumbles about complicated settings [16:59:22] This is why functions exist. [16:59:46] When we fix this, we need to do it while remembering today. [17:00:30] $wgDonationInterfaceAppealWikiTemplate = "2011FR/JimmyQuote/text/$language"; [17:00:37] this is what we want in the live settings file? [17:01:31] cwdent: Are you including the "LanguageSwitch|" part? [17:01:55] Or, was that not in prod to begin with [17:01:56] ? [17:02:24] uhmm [17:03:17] ??? I see nothing at all for that var in LocalSettings on the deploy box [17:03:18] K4-713: i do not see that string in the prod localsettings [17:03:23] whatever that's worth [17:03:29] Okay, so it's doing what's in DonationInterface.php. [17:03:40] Which does include the LanguageSwitch bit on the beginning. [17:03:54] Standard override technique. [17:03:59] oooh i see [17:04:27] so what swaps in $appeal? [17:04:33] shouldn't we change it there? [17:04:33] Mustache.php [17:04:35] The appeal param. [17:04:46] ...from the URL, ultimately. [17:05:32] It really looks like somebody refactored this bit to make very little sense. [17:05:44] Let me back up. [17:05:46] Appeal-default [17:05:46] dstrine: hi! thanks and yw! Yeah I didn't remember how we agreed to do it, figured I might as well just mention it :) [17:06:04] ejegg: is Appeal-default a thing somewhere? [17:06:10] that's in Mustache.php [17:06:37] sorry yeah...what does it do? [17:06:43] I hastily threw that logic together trying to imitate what happens in rapidHTML [17:06:46] that 2nd param on gettext [17:06:58] So, ideally: We should be able to override the default appeal with a simple setting, which should change based on a simple URL param if one if specified. [17:06:58] oh, that's what's used if the param doesn't exist [17:07:27] Looks like changing the default to something concrete will remove our ability to change out the appeal at all. [17:07:31] ...at the moment. [17:08:37] the-wub: Are you using any other appeals right now, aside from JimmyQuote? Like, for anything? [17:08:46] when the-wub said this had been on his wishlist for awhile i went uh oh...there must be a reason it doesn't get done [17:08:49] If not, let's just change it. [17:09:09] K4-713: really? changing the appeal in the URL seems to work on my local [17:09:17] It would. [17:09:42] But, do you have a hard default defined? [17:09:48] oooh i get it, so that ancient text is actually called Appeal-default [17:09:54] K4-713: we use some for major gifts things. not right at the moment though. it's a thing we want to test more of [17:10:06] (PS1) Ejegg: Make default appeal configurable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242193 [17:10:17] the-wub: It looks to me like URL params changing only works if you don't override the var. [17:10:25] Which is silly. Those exist to be overridden. [17:10:53] the-wub: Anyway: Are you using any other appeals? [17:11:07] If not, we can change it and get on with the test. [17:11:18] ejegg: yeah that PS looks good [17:11:37] K4-713: i think ejegg just pushed some code that can fix it more better [17:11:51] we should still do what K4 said and make the inital value persist in session [17:11:58] Oh, sure. Just go ahead and fix it for real. :p [17:11:58] yeah [17:12:01] but that PS is a start [17:12:40] and it sets the default... default to JimmyQuote [17:13:23] hi! Just catching up--so there's the default. but are we also pursuing debugging why the appeal param isn't being restored from session data? [17:13:29] i heard christopher walken read that sentence ejegg [17:13:44] awight: simplistic logic in Mustache.php [17:13:51] looking straight at the QS param [17:13:51] ugh, crappy public wifi [17:13:52] ooh cool [17:14:11] "cool" as in, should be an easy fix ;) [17:14:36] e.g. stuff we might have looked a lot harder at if the template switch wasn't just incidental to getting astropay out [17:15:01] * ejegg just misused e.g. [17:15:09] ejegg: do you need to change gateway_forms/RapidHtml.php too? or is that just not used any more? [17:15:10] weird, the RapidHtml code uses $appeal_name = $this->make_safe( $wgRequest->getText( 'appeal', 'Appeal-default' ) ); [17:15:14] random non-technical question, but if we don't like this very old text, can we just find it and over-write it with the jimmy quote? [17:15:31] ugh [17:15:32] the-wub: It's used for most gateways, we're very slowly transitioning to Mustache templating [17:15:42] dstrine: good call. [17:15:49] dstrine: PCI says we need Jeff to unlock wiki editing on payments. [17:15:54] So... yes, but not right now. [17:15:58] dstrine: there are many translations to change. and payments wiki is locked at the moment. I thought it would just be easier to change the code [17:16:00] (PS2) Cdentinger: Make default appeal configurable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242193 (owner: Ejegg) [17:16:13] ejegg: just fixed a test ^ but i think it's good [17:16:17] ok now I get it, that's what we would need Jeff for.. ok thanks! [17:17:09] oop, thanks! [17:17:54] np, want me to merge? [17:18:01] sure! [17:18:25] (CR) Cdentinger: [C: 2] Make default appeal configurable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242193 (owner: Ejegg) [17:20:31] the-wub: Wondering, have you tried adding the &appeal=JimmyQuote param to the Amazon URL? [17:20:40] lol... read email. [17:20:46] awight: the problem is when you come back from the amazon login page [17:21:11] Did read, but I'm not convinced--I see people coming into the initial Amazon page with no appeal= [17:21:37] do you have to set it in the return url? [17:21:38] grep appeal= payments-amazon_gateway [17:21:40] nothing [17:21:43] "When we return to the AmazonGateway after logging in" [17:21:46] (Merged) jenkins-bot: Make default appeal configurable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242193 (owner: Ejegg) [17:21:49] ...was the problem. [17:22:00] So, not the initial page load. [17:22:03] K4-713: I got that. But it's not being set initially either. [17:22:06] cwdent: returnURL is incredibly restrictive [17:22:16] the-wub: ^^? [17:22:25] awight: it's fine on first load, but then after they go back following login it gets lost. fixing that is probably another task. [17:22:58] awight: where would you see appeal= in the log anyway? [17:23:02] awight: this is banner I'm testing from: https://en.wikipedia.org/?banner=B15_mlWW_dsk_lg_amazon&force=1&country=US - it sets appeal = JimmyQuote [17:24:11] Here's the initial URL: https://payments.wikimedia.org/index.php/Special:GatewayFormChooser?uselang=en&language=en¤cy_code=USD&country=US&paymentmethod=amazon [17:24:14] no appeal [17:24:36] I got an appeal. [17:24:37] This was from https://en.wikipedia.org/?banner=B15_mlWW_dsk_sm_amazon&force=1&country=US [17:25:11] It's only there for a second before the redirect, but it's all huge and not wordy. [17:25:13] Here's from the lg banner: https://payments.wikimedia.org/index.php/Special:GatewayFormChooser?uselang=en&language=en¤cy_code=USD&country=US&paymentmethod=amazon [17:25:21] Still no appeal [17:25:32] Where are other people seeing the appeal param? [17:25:42] I'm not, but I'm seeing the actual appeal. [17:25:47] And there hasn't been a deploy yet, so... [17:26:09] awight: What do you bet it's in the formchooser. [17:26:33] K4-713: k, I do see the appeal=JimmyQuote after the redirect, so yeah it must be from the formchooser. [17:26:41] I also looked in the POST params and there's no appeal specified. [17:26:50] awight: I get an appeal btom B15_mlWW... https://payments.wikimedia.org/index.php?title=Special:AmazonGateway&appeal=JimmyQuote&ffname=amazon&recurring=&utm_medium=sitenotice&utm_campaign=&utm_source=B15_mlWW_dsk_lg_amazon.no-LP.amazon&language=en&country=US¤cy_code=USD&utm_key=8&payment_method=amazon&frequency=onetime&amount=3&amountGiven=&uselang=en [17:26:53] ./special/GatewayFormChooser.php: 'appeal' => "JimmyQuote", [17:26:59] ...okay. [17:27:04] ejegg: That's the second redirect [17:27:04] I don't know what to tell you. :p [17:27:16] aha! [17:27:21] The initial complaint didn't mention a param. [17:27:32] I mentioned that we should support those. [17:27:32] the-wub: K4-713 cwdent ejegg just a time check, are we still trying to do this test ... imminently? Or will these changes take a while? It is kind of late at night for the-wub right? [17:27:42] awight: You know, for the bigger fix. [17:27:42] the-wub: how you doing? [17:28:01] Seems like everything's on the right track, I'm just playing halfback to increase the odds of the right fix [17:28:25] I'm happy to deploy the code change or just a settings change now [17:28:26] dstrine: I can probably hang around for another hour but that's about it [17:28:34] ejegg: I'd say fire away. [17:28:43] +1 [17:28:45] If it's just that one thing and i18n. Or just that one thing. [17:28:57] Let's not complicate ourselves unduly. :) [17:29:05] OK, let's just do the localsettings [17:29:16] there's another change to not close order reference [17:29:23] We can do it for real after the test. [17:29:41] ok, adding a localsettings override [17:30:00] so is ejegg deploying the fix that will make this work? [17:30:21] Level-1 bandaid, yes. [17:30:22] want to be respectful of the-wub 's time [17:30:23] just going to have jimmyquote be the only appeal for now? [17:30:25] kk [17:31:07] added $wgDonationInterfaceAppealWikiTemplate = 'LanguageSwitch|2011FR/JimmyQuote/text|$language'; [17:31:16] great [17:31:26] rsyncing [17:31:59] !log updated appeal template setting on payments-wiki [17:32:05] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:32:23] Looks very unexploded. [17:32:30] :) [17:32:39] rapidhtml still gets the old one [17:32:50] got jimmy quote coming back from amazon login [17:32:57] i'd say we're ready to test [17:33:21] the-wub: ^^ [17:33:27] * K4-713 is a pingmachine [17:33:27] yay! [17:33:54] ok great. thanks K4-713 and everyone. [17:34:09] the-wub: You're seeing the problem gone? [17:34:15] Gone-being. [17:34:18] thanks for catching the issue the-wub ! [17:34:58] Hmm. [17:35:18] K4-713: yes, I see JimmyQuote after logging in. prepping the campaign now. [17:35:31] ejegg: When we make the card for the all-over fix, we should grep everything for "JimmyQuote" and make it use the real thing. [17:35:38] I think awight found a leak. [17:35:51] K4-713: yep, I just grepped and awight's discovery is the only instance [17:35:59] cool [17:36:16] Hm. Did you poke around for just anything that says "appeal"? [17:36:17] There's also an issue that neither the RapidHtml nor Mustache forms actually get appeal from the session. [17:36:45] yep [17:37:49] (PS2) Awight: Link to bug in TODO [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/242063 [17:42:57] okay, about to put campaign up. Just going to use small banners for simplicity. https://meta.wikimedia.org/w/index.php?title=Special:CentralNotice&subaction=noticeDetail¬ice=C1516_enUS_dsk_FR [17:43:52] the-wub: cool, looks good! [17:45:25] Fundraising-Backlog: [EPIC] Banner history post launch - https://phabricator.wikimedia.org/T112923#1685941 (awight) [17:45:26] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Banner history: encode all hide reasons - https://phabricator.wikimedia.org/T113813#1685939 (awight) Resolved>Open Reopening to highlight remaining patch. [17:46:34] dstrine, K4-713 , ejegg : campaign is up! [17:46:41] woohoo [17:46:56] awesome! [17:47:00] and they're rolling in [17:48:26] some great WP urls: [17:48:31] https://en.wikipedia.org/wiki/McGriddles#Criticism [17:48:41] https://en.wikipedia.org/wiki/McRib#In_popular_culture [17:48:52] https://en.wikipedia.org/wiki/Sealed_crustless_sandwich#Patent_reexamination [17:48:54] * ejegg feels uneasy [17:49:03] yeah... [17:49:17] For all the amusement those afford, I still think we shouldn't see em [17:49:23] +1 [17:49:54] sorry, stop linking stuff? [17:49:57] Especially since we do nothing but fraud check [17:50:08] cwdent: Ah, we're just griping that referrer should not be logged [17:50:16] = no fun at all [17:50:27] ooh, gotcha [17:50:31] i thought you were like shut up casey [17:50:37] we're sick of links [17:52:00] error log is eerily still [17:52:04] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Privacy: Stop logging HTTP referrer - https://phabricator.wikimedia.org/T114148#1686021 (awight) NEW [17:52:24] we seem to have achieved quiet [17:52:35] Netsplit? [17:55:33] TCB-Team-Fundraising-Sprint-2015-08-12, TCB-Team-Fundraising-Sprint-2015-08-26, TCB-Team-Fundraising-Sprint-2015-09-02, TCB-Team-Fundraising-Sprint-2015-09-10, and 3 others: [WMDE-Fundraising] Move Piwik to its own VM - https://phabricator.wikimedia.org/T105289#1686079 (kai.nissen) a:WMDE-Fisch... [17:56:00] (CR) Awight: "@Paladox: Would you mind pointing me to docs about the manifest you mentioned? Is this just the composer.json file (which is not needed b" [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/213315 (https://phabricator.wikimedia.org/T87903) (owner: Parent5446) [17:58:05] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Privacy: Stop logging HTTP referrer - https://phabricator.wikimedia.org/T114148#1686092 (Ejegg) see https://gerrit.wikimedia.org/r/232218/ At least once, it's been useful to visit the referrer and investigate (some Chinese forum suggesting... [18:00:06] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Privacy: Stop logging HTTP referrer - https://phabricator.wikimedia.org/T114148#1686111 (awight) What if we rely on the weblog for this sort of investigation? We could use a standard log analysis package... [18:07:12] (PS4) Awight: CentralNotice should use content rather than interface language [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/197741 (https://phabricator.wikimedia.org/T53475) [18:08:12] (CR) jenkins-bot: [V: -1] CentralNotice should use content rather than interface language [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/197741 (https://phabricator.wikimedia.org/T53475) (owner: Awight) [18:12:42] (PS1) Awight: WIP Convert DonationInterface to extension registration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) [18:13:10] (CR) jenkins-bot: [V: -1] WIP Convert DonationInterface to extension registration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [18:13:47] (CR) Paladox: "@Awright please see T100745" [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/213315 (https://phabricator.wikimedia.org/T87903) (owner: Parent5446) [18:15:31] (CR) Awight: "Thanks! Looks like legoktm fixed this in 81bf26fc." [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/213315 (https://phabricator.wikimedia.org/T87903) (owner: Parent5446) [18:18:13] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Convert CentralNotice to use extension registration - https://phabricator.wikimedia.org/T108721#1686196 (awight) We have a problem here, that extension setup is controlled by conditionals, and different hooks are registered on infrastructure vs sub... [18:21:10] 330 Amazon donations so far [18:22:11] amazing [18:24:51] ejegg: wow, looks like the messages are coming in from both payments and the listener, and both have all the donor details! [18:25:21] awight: listener ones only have it because completion_message_id [18:25:31] that's perfect [18:25:37] seems to work! [18:26:14] And I'm dumping the JSON message in the logs too, for audit txn reconstruction. Just like you advised for astropay [18:29:21] Confirmed that messages from both sources are exactly the same--only difference is whether or not the fee is recorded, which I think you already noted. [18:30:28] Thank-you letters are being sent. [18:32:09] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: JPMorgan Import Not Working - https://phabricator.wikimedia.org/T113381#1686274 (CaitVirtue) @DStrine can you please prioritize this toward the beginning of the sprint? thx! [18:32:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Missing Donation in Civi/Showing as Duplicate - https://phabricator.wikimedia.org/T113263#1686282 (CaitVirtue) @DStrine can you please prioritize this toward the beginning of the sprint? thx! [18:33:19] K4-713: nice one [18:33:36] ? [18:33:43] Oh, ha. [18:33:44] :D [18:34:37] dang, we're just dropping the IPN messages as duplicates instead of updating the record with fees [18:37:31] ejegg: I don't see the task for some reason, but that would be covered by the more general "refinement" feature [18:38:11] gotcha [18:38:23] (CR) Awight: "@eileen: I had some questions inline, the only blocker is that prefix_id should be an integer and it looks like we're passing the string v" [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241913 (owner: Eileen) [18:38:35] (CR) Awight: [C: -1] T99836 Civi46 fix ensure_prefix & ensure_suffix for 4.6 [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241913 (owner: Eileen) [18:39:22] We don't care much about fees, though, cos Finance only looks at the aggregate percentage. [18:39:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: JPMorgan Import Not Working - https://phabricator.wikimedia.org/T113381#1686308 (DStrine) @CaitVirtue it's in sprint 1 at the top. [18:40:26] Fundraising-Backlog: Sprint U (9/30-10/14) goal: Worldpay and Amazon campaign ready - https://phabricator.wikimedia.org/T109908#1686309 (DStrine) [18:41:05] (CR) Awight: "This should be in the SmashPig repo instead?" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/242007 (https://phabricator.wikimedia.org/T109654) (owner: Ejegg) [18:42:45] (CR) Ejegg: "Good call. Bonus: one less vendor submodule to deal with." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/242007 (https://phabricator.wikimedia.org/T109654) (owner: Ejegg) [18:47:58] Fundraising-Backlog: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1686337 (CaitVirtue) NEW [18:52:31] XenoRyet: I wanna un-WIP that SDK mutation and merge it to master on my github so composer install can use it. Anything look like it needs to be fixed first? [18:54:55] ah, probably unit tests... [19:05:01] (CR) Eileen: T99836 Civi46 fix ensure_prefix & ensure_suffix for 4.6 (1 comment) [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241913 (owner: Eileen) [19:06:02] eileen: Trying to wrap my head around this--so you can pass prefix_id="Sra."? [19:06:10] or just "11"? [19:06:16] awight: either [19:07:00] the api does some handling on those internally [19:07:04] ejegg: Na, nothing jumping out at me. [19:07:31] eileen: How does it tell the difference between a numeric prefix and an actual prefix id? [19:07:32] Thanks XenoRyet! [19:07:49] I'm pretty creeped out that there isn't a second "prefix" param [19:08:04] Getting errors trying to run the tests on the version straight from the amzn repo, but I'll still try to get those in order [19:08:18] awight: hmm - yeah - it would look in the value field & then do a look up [19:08:48] (CR) Awight: [C: 2 V: 2] "Thanks for the explanation!" [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241913 (owner: Eileen) [19:09:04] the reason it does it that was is to some extent historical - the api took things that worked ‘somewhere’ and made them work everywhere [19:20:56] hey all I just saw a paypal email come through.. anything to worry about? [19:21:45] That sure does look bad. [19:22:41] Disabling PP... [19:23:26] do we need to inform anyone? [19:23:34] do anything with banner? [19:23:35] yeah, I'll do that after I disable [19:23:38] kk [19:29:45] awight: thanks for jumping on that [19:30:43] thanks for noticing! [19:30:48] I was deep in the TPG survey [19:31:11] ah thanks for that too! :) [19:34:47] K4-713: are you engineered to eat things around noon? [19:34:54] I hope so. [19:35:08] I think I swallowed a bug. [19:35:09] XenoRyet: OK, updated the docs and unit tests and pushed to master. Should be a stable basis for adding those other GetReportList params [19:35:14] bad tolerances [19:35:41] ejegg: Cool, I'll pull the new version. [19:35:58] word. I also sent a pull request to you on GH [19:37:45] XenoRyet: awight suggested we move the downloader scripts/classes from tools into SmashPig. Sounds worth it to me, just to avoid the hassle of adding a 'vendor' submodule in tools [19:38:14] Yea, sounds like a logical place for it, now that you mention. [19:38:55] I think I'll need to fix the IPN handler stuff for the new client class names, so I'll split it into one commit updating the lib and another commit adding the rudimentary downloader [19:40:03] Makes sense [19:46:21] Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Infrastructure: Job wikimedia-fundraising-civicrm fails on branch civi-4.6.9-deploy causing force merges that breaks Zuul scheduler - https://phabricator.wikimedia.org/T114165#1686662 (hashar) NEW [19:48:36] (CR) AndyRussG: "Thanks!!! Besides "empty" (see inline), I guess there are banner scripts that use "seen" and "cookies" as reasons?" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241938 (https://phabricator.wikimedia.org/T113813) (owner: Awight) [19:49:34] awight|fud: so 2 more patches to review & then re-try the update on staging? [19:49:44] (which will take hours won’t it?) [19:56:40] (PS1) Ejegg: Update Amazon SDK [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/242267 (https://phabricator.wikimedia.org/T109654) [20:05:47] (PS1) Ejegg: Update Amazon SDK [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242283 (https://phabricator.wikimedia.org/T109654) [20:07:40] Fundraising Sprint Tom Waits, Fundraising-Backlog: Hebrew characters not making it into Worldpay donations - https://phabricator.wikimedia.org/T114000#1686826 (DStrine) [20:21:20] Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Infrastructure: Job wikimedia-fundraising-civicrm fails on branch civi-4.6.9-deploy causing force merges that breaks Zuul scheduler - https://phabricator.wikimedia.org/T114165#1686881 (hashar) Since `wikimedia/fundraising/crm` uses submodules, I guess... [20:23:06] Just looking I don’t have a next meeting in my calender - but there is one tomorrow - is it wrong? [20:23:42] (that one is about shrimps I believe) [20:27:06] all: we got the all-clear from paypal. I'm going to re-enable the campaigns [20:31:58] campaigns are back up [20:32:08] the-wub: I'm in a meeting with awight|fud and he is cool with that. He also says thanks! [20:47:17] Fundraising-Backlog: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1686996 (DStrine) @CaitVirtue when would you like this done? [20:48:32] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Make the CiviCRM Search bar work for non-exact searches - https://phabricator.wikimedia.org/T114053#1686999 (awight) [20:49:31] Fundraising Sprint Tom Waits, Fundraising-Backlog: Hebrew or other non-Latin characters not making it into Worldpay donations - https://phabricator.wikimedia.org/T114000#1687010 (awight) [20:51:06] Fundraising-Backlog: test task for amazon campaign ready - https://phabricator.wikimedia.org/T113995#1687022 (DStrine) Open>Invalid [20:51:07] Fundraising-Backlog: [EPIC] Amazon embedded campaign ready version - https://phabricator.wikimedia.org/T108109#1687024 (DStrine) [20:51:17] Fundraising-Backlog: test task for amazon campaign ready - https://phabricator.wikimedia.org/T113995#1681995 (DStrine) [20:51:18] Fundraising-Backlog: [EPIC] Amazon embedded campaign ready version - https://phabricator.wikimedia.org/T108109#1512442 (DStrine) [20:52:13] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Default appeal should be configurable, initial query string value should be stored in session - https://phabricator.wikimedia.org/T114127#1687033 (Ejegg) [20:52:25] Fundraising-Backlog: Track whether the reader began a donation workflow, include in banner history log - https://phabricator.wikimedia.org/T113821#1676882 (awight) Need to check with @Ellery about requirements. [20:56:40] Fundraising-Backlog, fundraising-tech-ops: Spike: Do we have to make changes on orphan rectification box to support new GC SSL ciphers - https://phabricator.wikimedia.org/T113392#1687082 (awight) [21:01:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Import unsubscribe data from Silverpop - https://phabricator.wikimedia.org/T112674#1687119 (awight) @CCogdill_WMF: Can you let us know whether this impacts your mailings? [21:04:23] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Import unsubscribe data from Silverpop - https://phabricator.wikimedia.org/T112674#1687125 (CCogdill_WMF) No, it doesn't impact my work directly. I know Major Gifts feels like they don't have total visibility into what their donors' preferences are, so... [21:06:39] (PS1) Ori.livneh: Migrate to a terser cookie name and format [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/242346 (https://phabricator.wikimedia.org/T110353) [21:06:55] (CR) Ori.livneh: [C: 2] Migrate to a terser cookie name and format [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/242346 (https://phabricator.wikimedia.org/T110353) (owner: Ori.livneh) [21:14:20] (Merged) jenkins-bot: Migrate to a terser cookie name and format [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/242346 (https://phabricator.wikimedia.org/T110353) (owner: Ori.livneh) [21:24:24] awight: you figure running the amazon downloader as a drush command using a SmashPig class is better, or adding a standalone script in SmashPig to run it? [21:24:36] Mostly a matter of configuration [21:24:57] though I guess the existing downloaders already have the paths in two places [21:25:50] Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Infrastructure: Job wikimedia-fundraising-civicrm fails on branch civi-4.6.9-deploy causing force merges that breaks Zuul scheduler - https://phabricator.wikimedia.org/T114165#1687225 (awight) @hashar: Thanks for the tips! Yeah I think that consisten... [21:26:06] ejegg: good question. [21:26:40] I'll leave any calls to Context:: and config out of the downloader class for flexibility, just take parameters in the constructor [21:26:41] I think a standalone SmashPig script is the direction we want to go in. [21:26:45] ok, cool [21:27:03] Yeah, we can put a drush wrapper around it in the future--but I want the drush glue to be as light as possible [21:27:16] right on [21:27:25] Ideally, we'd be delegating directly to SmashPig or DonationInterface [21:27:58] yep - I just don't want the SmashPig lib we're using there to depend on some config file buried deep in vendor [21:31:27] That should change either way... [21:32:24] SmashPig needs to be looking in /etc/fundraising, first of all: https://phabricator.wikimedia.org/T113301 [21:34:47] ah, gotcha [21:45:18] (PS1) Eileen: Civi46: fix another call to ContributionType [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/242360 [21:45:52] (CR) jenkins-bot: [V: -1] Civi46: fix another call to ContributionType [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/242360 (owner: Eileen) [21:46:33] eileen_: Let's fix one of those branch names now--hashar was saying that my forced merges are breaking CI for other people :( [21:47:05] awight: I did add a civi-4.6.9-deploy to civicrm before [21:47:12] but it doesn’t seem to have picked up [21:47:14] cool thx [21:47:20] hmm [21:47:25] Can we take the "-deploy" suffix off? [21:47:41] I guess you added cos to distinguish it from the CiviCRM "uncompiled" source? [21:47:59] ^cos^ [21:48:34] awight: yeah - that was the reason [21:48:51] & then of course I needed a branch in master & I called it the same thing [21:48:58] sorry in crm [21:49:18] right--I don't want to use that suffix in crm/ cos that has its own compilation step, which we aren't doing in this branch [21:49:20] but then it occurred to me people wouldn’t know what 4.6 referred to [21:49:31] OK [21:49:38] so call both civi-4.6 [21:49:50] or possibly civi-4.6.9 [21:50:15] that works for me. But we should plan our branches soon, before it becomes really confusing! [21:50:22] :-) [21:51:07] yeah - the big issue is how we are going to manage upstream fixes - I tend to prefer to branch & rebase over upstream to keep the patches tidy [21:51:21] & to drop them as they get upstreamed [21:52:17] Fundraising Tech Backlog: Worldpay HCG search by email address - https://phabricator.wikimedia.org/T114183#1687273 (MBeat33) NEW [21:52:31] I really like * using the upstream repo so we get history and it's easy to make patches, and * developing in the uncompiled repo [21:53:10] yeah - I think that makes sense - we probably want a process around building it using civibuild & checking it in [21:53:19] +1 [21:53:36] I'm seriously considering a Makefile [21:54:15] timing-wise - these are things we would work on after change-freeze & ‘things have settled down’ after the upgrade? [21:54:40] before I create the new branches - do you want to merge the other patches - this one should be easy https://gerrit.wikimedia.org/r/#/c/241949/1/sites/all/modules/wmf_civicrm/tests/phpunit/RefundTest.php [21:54:50] donno, I'd want our repo structure to be pretty solid by the time we switch production over [21:55:13] eileen_: unfortunately, I'm not supposed to be doing the forced merges [21:55:37] ah - because you are having to over-ride if ci fails? [21:55:59] ok- so i will create the branches now [21:56:15] yeah, I don't understand how it's breaking things but I hear it is [21:57:10] re the repo structure I will look to add a non-deployment branch too in the civispace - I could call it raw :-) [21:58:11] awight: so in terms of how switch over will go - I’m not sure when the final date is - I think atgo suggested it might be mid-Oct not the 1 Oct code-freeze per K4-713’s email [22:05:29] awight: ejegg: cwdent: XenoRyet: K4-713: ori asked to deploy the terser cookie patch after I +2'd it yesterday. I didn't know much what to say, I think it's going out now [22:05:37] (PS1) Eileen: Civi46: fix another call to ContributionType [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242363 [22:05:40] (PS1) Eileen: Civi46 update CiviCRM submodule version [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242364 [22:05:54] OK, I can take a look when it's up [22:06:08] (Abandoned) Eileen: Civi46: fix another call to ContributionType [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/242360 (owner: Eileen) [22:06:17] (CR) jenkins-bot: [V: -1] Civi46: fix another call to ContributionType [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242363 (owner: Eileen) [22:06:48] (CR) jenkins-bot: [V: -1] Civi46 update CiviCRM submodule version [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242364 (owner: Eileen) [22:07:32] (Abandoned) Eileen: Civi46: update to latest version of the submodule [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241975 (owner: Eileen) [22:07:37] ejegg: thanks! I'm semi-here too, I'll also peek, pls ping if you see anything fish-like :D [22:10:56] (PS1) Eileen: Civi46 update refund test for changed parameter (no 2) [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242365 [22:11:04] (CR) jenkins-bot: [V: -1] Civi46 update refund test for changed parameter (no 2) [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242365 (owner: Eileen) [22:11:09] (Abandoned) Eileen: Civi46 update refund test for changed parameter (no 2) [wikimedia/fundraising/crm] (civi-4.6.9-deploy) - https://gerrit.wikimedia.org/r/241949 (owner: Eileen) [22:12:45] awight: that looks promising - the error is a 4.6 error now - but I’m not sure why it’s happening as it should be fixed (but that is something I can dig into) [22:13:57] awesome [22:14:04] looking... [22:14:16] Do you get that locally? [22:14:45] These don't look healthy, fwiw: array_diff() expects parameter 2 to be an array or collection [warning] [22:14:50] bootstrap.inc:47 [22:14:57] Invalid argument supplied for foreach() bootstrap.inc:57 [warning] [22:15:35] Now I don't see the crm/civicrm checkout [22:15:59] oof, I think I edited this job config a while ago to use submodule... undoing that now [22:18:42] awight: something unrelated has gone wrong locally so fixing that to re-test [22:19:39] eileen_: okay, I reverted the job config so it uses zuul-cloner for all submodules now. that should make the branch glue work correctly. [22:21:09] ok - the problem we are seeing now could be a caching issue - I’ll dig into that [22:21:41] (CR) Awight: "recheck" [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242363 (owner: Eileen) [22:23:44] eileen_: fyi, INFO:zuul.Cloner:Prepared wikimedia/fundraising/crm/civicrm repo with branch civi-4.6.9 [22:23:59] That latest on failed with a 4.2 only error API (LocationType,create) [22:23:59] New error is Exception: 'civicrm_contribution' is not a valid option for field used_for in wmf_civicrm_update_7016() (line 871 of /mnt/jenkins-workspace/workspace/wikimedia-fundraising-civicrm/src/wikimedia/fundraising/crm/sites/all/modules/wmf_civicrm/wmf_civicrm.install). [22:24:07] eileen_: https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm/860/consoleFull [22:24:12] that error is 4.6 only - so that is a good thing [22:24:25] I reran the test after undoing my zuul-cloner workaround [22:24:44] the fact it’s on line 871 tells me that it has tried to create the used_for too - but failed I guess [22:25:08] eileen_: Are you able to run tests locally? It should just be "phpunit" [22:25:09] or else (probable) there is a caching issue [22:25:29] yeah - I had them working & need to re-fix them - but that bug was fixed locally & the fix is in there [22:25:47] anyway - I’ll work on that [22:26:54] What is the status with re-upgrading staging? I’m aware I’ll have time after you are gone to tackle the other [22:27:34] Any time--I'm waiting until we have a stable civi-4.6.9 to deploy [22:27:44] Or can push a WIP thing if you'd like, fine by me. [22:28:27] awight: well - is it a case of you fire it off before you leave for the day & let it run? [22:28:39] if so you should just go with the version we have at that point [22:28:51] eileen_: can do! [22:29:27] eileen_: at this head? e73520c3185d67f3a4a89f9cd3326a047c176ce1 [22:29:30] re that error on the tests - it’s fine locally there are 3 unresolved local errors & that is because I need to discuss them [22:29:31] https://gerrit.wikimedia.org/r/#/c/242365/ [22:30:42] you can upgrade staging with what is currently in that branch - the incomplete commits didn’t seem to be the blocker last time so I don’t think they will be a problem this time [22:31:24] (PS1) Ejegg: Add Amazon audit downloader class and script [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242375 (https://phabricator.wikimedia.org/T109654) [22:31:25] ok, perfect. I just started restoring the dbs to their 4.2 state, *under tmux* this time. [22:31:36] cool [22:31:44] (Abandoned) Ejegg: WIP download reports from Amazon [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/242007 (https://phabricator.wikimedia.org/T109654) (owner: Ejegg) [22:32:07] the test failures I haven’t fixed are where it is attempting to update a custom_field with a set of options & is passing an invalid option [22:32:17] this was permissable in 4.2 & not in 4.6 [22:32:43] & it seems like the expected behaviour was ‘no error, possibly save the data, but don’t include it in the email’ [22:33:19] so to get ‘no error, but don’t include it in the email’ in 4.6 we would validate & strip [22:33:39] to get ‘no error, save the data’ we would add an option [22:33:45] K4-713, cwdent, awight, XenoRyet: I'm going to deploy the closeOrderReference changes to DI and SmashPig unless anyone has any objections [22:33:57] none here [22:33:59] sounds good! [22:34:01] I got nuthin. [22:34:03] kewl [22:34:05] Go for it [22:34:12] unanimous! [22:34:14] Overwhelming aye! [22:34:34] I agreeing too - since everyone else is [22:34:38] hehe [22:34:44] :D [22:35:36] Also the first bit of the default appeal thing - just fixing it for Mustache [22:36:41] interestingly the rapidhtml forms don't seem to be noticing the global change [22:36:46] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/242377 [22:37:00] cwdent: that global is only used by Mustache [22:37:14] oh, yeah that same code is in rapidhtml.php [22:37:16] rapidHtml still has appeal-default hardcoded [22:37:20] derp [22:37:47] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/242377 (owner: Ejegg) [22:37:48] is the goal to purge that stuff entirely? [22:37:52] rapidhtml [22:38:08] yeah, flush that and its hundreds of templates down the tubes [22:39:46] nice [22:41:31] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/242382 [22:41:44] Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Infrastructure: Job wikimedia-fundraising-civicrm fails on branch civi-4.6.9-deploy causing force merges that breaks Zuul scheduler - https://phabricator.wikimedia.org/T114165#1687553 (awight) Open>Resolved a:awight Looks like the named branc... [22:41:51] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/242382 (owner: Ejegg) [22:41:59] Fundraising-Backlog: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1687560 (CaitVirtue) This week? Next week at the latest. [22:42:52] Fundraising-Backlog: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1687572 (DStrine) We can move it into next sprint (which starts tomorrow). [22:43:28] Fundraising-Backlog: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1687575 (CaitVirtue) Great, thank you! [22:46:22] (CR) Awight: "IMO it makes sense to include any strings we see in the wild, mostly as a debugging aid. If we omit "empty" for example, it's possible th" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241938 (https://phabricator.wikimedia.org/T113813) (owner: Awight) [22:47:33] !log updated SmashPig from bf302444eae8236734fd43883b06c7b2512b1532 to 513ec01123e6dbb97b00888a3610a7c5ec24a63b [22:47:38] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:49:53] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1687605 (awight) Everything Jgreen is saying is true ;) there's no effect on exist... [22:50:43] !log updated payments-wiki from 3b0915a51a0fd567bdf22f3d4e17548a83e735d8 to bc4bcc44d2337d7a69c5a39f11ff45efdf0c8e11 [22:50:48] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:52:47] Cool, IPN listener closed the order reference just fine [22:52:57] Rad! [22:53:09] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, and 2 others: Close Amazon order reference asynchronously - https://phabricator.wikimedia.org/T113809#1687611 (Ejegg) Open>Resolved [22:53:19] ejegg: So should we stop the flow of messages from DI now? [22:53:20] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: [Mini epic] Activate Banner History! - https://phabricator.wikimedia.org/T112020#1687614 (Ejegg) [22:53:29] ejegg: nice, first try [22:53:35] ... if they aren't completed until IPN gets them. [22:55:19] awight: oh, DonationInterface still captures the payment [22:55:34] I figure that merits a 'completed' message still [22:55:38] hmm [22:55:40] even if we don't know the fee yet [22:55:50] the velocity this sprint is really going to throw off our average :P [22:55:53] We don't want to send a TY letter until the charge is actually made [22:55:59] we are 44 SP! [22:56:00] What is the "completion" step? [22:56:48] dstrine: https://upload.wikimedia.org/wikipedia/commons/7/74/D10_antiprism.jpg [22:56:58] dstrine: do we level up? [22:56:59] awight: closing the order reference just tidies up our console [22:57:03] * cwdent starts picking spells [22:57:24] shows that we don't intend to try to charge again (e.g. for shipping or tax) [22:57:30] ejegg: Okay, great then! [22:57:35] cwdent: you personally get +10 hassle protection and 3 levels [22:58:10] \o/ [22:59:41] AndyRussG: gets an endurance buff and ejegg gets a one-time-use "Set customer service queue to 0" special [23:00:22] DM is in the house! [23:00:32] a million hit points and maximum charisma! [23:01:12] you guys are approaching a random chance at a boss fight on 11/16 so don't act all high and mighty [23:01:27] ;) [23:01:40] * dstrine can go all day like this [23:03:58] * cwdent uses prestidigitation [23:06:29] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Parse new Amazon transaction reports and import into Civi - https://phabricator.wikimedia.org/T111425#1687647 (Ejegg) p:Triage>Normal a:Ejegg [23:15:50] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Another spike in unsettled GC 600s - https://phabricator.wikimedia.org/T114192#1687669 (awight) NEW [23:16:02] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Another spike in unsettled GC 600s - https://phabricator.wikimedia.org/T114192#1687676 (awight) [23:16:45] dstrine: wut? [23:17:31] sorry we went way into a RPG metaphor [23:20:35] dstrine: ah np, yeah that's outside my universe ;p [23:20:46] I'll google... [23:20:48] :) [23:22:03] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Another spike in unsettled GC 600s - https://phabricator.wikimedia.org/T114192#1687693 (MBeat33) [23:23:24] (CR) Awight: [C: -1] "rats--needs a manual rebase. Looking forward to this feature!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234736 (owner: Glaisher) [23:34:10] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Config, Patch-For-Review: Civi CI is using contaminated database dumps - https://phabricator.wikimedia.org/T113559#1687709 (awight) Open>Invalid a:awight I misunderstood what was happening here, the test failure wa... [23:41:08] eileen: Restoring the Civi db now... at least another hour to go before I can run the upgrade. [23:41:25] cool [23:47:49] (PS1) Eileen: Civi46 adjust function to get tests passing [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242410 [23:48:57] (CR) jenkins-bot: [V: -1] Civi46 adjust function to get tests passing [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242410 (owner: Eileen) [23:49:19] K4-713: Wanna look at some logs for a minute? I'm confused. [23:52:11] (CR) Eileen: "OK - those test fails are real progress! It's getting through the installer now!" [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242410 (owner: Eileen) [23:52:42] (PS1) Eileen: Civi46 add install functions test [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242412 [23:53:56] (CR) jenkins-bot: [V: -1] Civi46 add install functions test [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242412 (owner: Eileen)