[00:02:10] (CR) Ejegg: [C: 1] "Looks good, and seems to work just like the onwiki code! Seems odd that page views while we're waiting for the cycle to restart count tow" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (https://phabricator.wikimedia.org/T112017) (owner: Awight) [00:07:41] (CR) Awight: Banner diet mixin (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (https://phabricator.wikimedia.org/T112017) (owner: Awight) [00:09:47] (PS18) Awight: Banner diet mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (https://phabricator.wikimedia.org/T112017) [00:15:59] cwdent: ejegg: err, .1.2? [00:16:17] ??? [00:16:20] (CR) Awight: "PS18: manual rebase" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (https://phabricator.wikimedia.org/T112017) (owner: Awight) [00:16:36] (CR) Ejegg: "Just needs the reason logic updated to account for Ia28c3503b17bf18dc7fb18ba0cf9bd61d2703f6b being merged first" (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (https://phabricator.wikimedia.org/T112017) (owner: Awight) [00:16:45] ejegg: That latest WP email makes it look like we're appending the order id suffix repeatedly [00:17:20] oh yeah, that. We're using ct_it.numAttempt.sub-txn-suffix [00:17:27] eileen: starting another migration process... [00:17:36] ejegg: oh, great then! [00:17:54] where the sub-txn-suffix is nothing for the sale, and .0 / .1 / .2 for the other things we do [00:19:27] (PS19) Awight: Banner diet mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (https://phabricator.wikimedia.org/T112017) [00:19:56] (CR) Awight: "PS19: Update hiding API" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (https://phabricator.wikimedia.org/T112017) (owner: Awight) [00:20:58] eileen: fyi, time drush -v -v civicrm-upgrade-db |& tee /tmp [00:20:58] /civi-migration.log [00:21:13] /tmp/civi-migration.log [00:21:23] Gotta run for now! [00:24:12] (CR) Ejegg: [C: 2] "Nice! Important step away from on-wiki banner scripts." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (https://phabricator.wikimedia.org/T112017) (owner: Awight) [00:26:27] (PS2) Ejegg: Rename lookup function [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/242061 (owner: Awight) [00:27:12] (CR) Ejegg: [C: 2] "Semantic!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/242061 (owner: Awight) [00:34:19] (CR) AndyRussG: "Woohoo! Amazing work, folks!! :D" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236229 (https://phabricator.wikimedia.org/T112017) (owner: Awight) [00:36:18] Fundraising Sprint Queen, Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, and 4 others: Freaky banner arguments cause redirect to (nonexistent) Worldpay form. - https://phabricator.wikimedia.org/T108605#1691858 (awight) Open>declined Wil... [06:09:06] (CR) Siebrand: [C: 1] "i18n/L10n reviewed." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234736 (owner: Glaisher) [07:41:53] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising Tech Backlog, and 3 others: Configure new CiviCRM staging instance for testing 4.6 upgrade - https://phabricator.wikimedia.org/T112314#1692238 (awight) @Jgreen, what do you think about `mysqldbc... [07:54:50] Fundraising Sprint UB40, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Install 4.6 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1692252 (awight) I get the following warnings when running the migration locally: ``` Undefined variable: curr... [08:17:15] (PS1) Awight: Log upgrade steps [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/242820 [08:18:43] (CR) jenkins-bot: [V: -1] Log upgrade steps [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/242820 (owner: Awight) [08:18:56] (PS1) Awight: Log upgrade steps [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242821 [08:19:38] (CR) jenkins-bot: [V: -1] Log upgrade steps [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242821 (owner: Awight) [08:52:46] (PS2) Awight: Log upgrade steps [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/242820 (https://phabricator.wikimedia.org/T99842) [08:52:48] (PS1) Awight: Pretty-print upgrade outputs [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/242827 (https://phabricator.wikimedia.org/T99842) [08:53:33] (PS2) Awight: Log upgrade steps [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242821 (https://phabricator.wikimedia.org/T99842) [08:54:09] (PS1) Awight: Pretty-print upgrade outputs [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242828 (https://phabricator.wikimedia.org/T99842) [08:54:12] (CR) jenkins-bot: [V: -1] Log upgrade steps [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/242820 (https://phabricator.wikimedia.org/T99842) (owner: Awight) [08:54:19] (CR) jenkins-bot: [V: -1] Pretty-print upgrade outputs [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/242827 (https://phabricator.wikimedia.org/T99842) (owner: Awight) [08:54:21] (CR) jenkins-bot: [V: -1] Log upgrade steps [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242821 (https://phabricator.wikimedia.org/T99842) (owner: Awight) [08:54:44] (CR) jenkins-bot: [V: -1] Pretty-print upgrade outputs [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242828 (https://phabricator.wikimedia.org/T99842) (owner: Awight) [08:56:01] (PS1) Awight: Include .gitreview [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242830 [08:56:30] (CR) jenkins-bot: [V: -1] Include .gitreview [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242830 (owner: Awight) [09:26:18] (PS1) Amire80: Spelling correction: disply -> display [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/242833 [09:59:51] (CR) Siebrand: [C: 2] "i18n/L10n reviewed." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/242833 (owner: Amire80) [10:01:18] (Merged) jenkins-bot: Spelling correction: disply -> display [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/242833 (owner: Amire80) [10:29:39] TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team-Fundraising-Sprint-2015-09-30, TCB-Team: [WMDE-Fundraising] Request CentralNotice adminship rights - https://phabricator.wikimedia.org/T112059#1692568 (WMDE-leszek) [10:31:32] Fundraising Tech Backlog, Browser-Tests, Continuous-Integration-Infrastructure: Create unit and integration tests for Fundraising extensions to identify breaking MediaWiki changes - https://phabricator.wikimedia.org/T89404#1692578 (zeljkofilipin) I have just noticed that there was no activity on this... [12:12:12] Fundraising-Backlog: Access for Joseph Seddon (new part-time contractor for fundraising) - https://phabricator.wikimedia.org/T113999#1692976 (jrobell) Hi all, Just double checking when Joseph's access could be ready and set up? Do you need any additional info? Thank you! [12:21:25] TCB-Team-Fundraising-Sprint-2015-09-30, TCB-Team: [WMDE-Fundraising] Create HTML contents of the banner with regard on having magic values filled by CN - https://phabricator.wikimedia.org/T112055#1693008 (WMDE-Fisch) a:WMDE-Fisch [12:41:59] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising Tech Backlog, and 3 others: Configure new CiviCRM staging instance for testing 4.6 upgrade - https://phabricator.wikimedia.org/T112314#1693039 (Jgreen) I've never used it, let's give it a try. W... [13:12:38] Wikimedia-Fundraising, Continuous-Integration-Config, Patch-For-Review: wikimedia/fundraising/tools should pass python lint checks (flake8) - https://phabricator.wikimedia.org/T114218#1688544 (hashar) [13:12:50] Wikimedia-Fundraising, Continuous-Integration-Infrastructure, Patch-For-Review, WorkType-Maintenance: Switch wikimedia/fundraising/slander to use tox as an entry point - https://phabricator.wikimedia.org/T114250#1689433 (hashar) [13:27:22] Fundraising-Backlog: Access for Joseph Seddon (new part-time contractor for fundraising) - https://phabricator.wikimedia.org/T113999#1693155 (Jgreen) >>! In T113999#1692976, @jrobell wrote: > Just double checking when Joseph's access could be ready and set up? Do you need any additional info? He's already... [13:31:48] Wikimedia-Fundraising, Continuous-Integration-Infrastructure, Patch-For-Review, WorkType-Maintenance: Switch wikimedia/fundraising/slander to use tox as an entry point - https://phabricator.wikimedia.org/T114250#1693171 (hashar) [15:37:09] (PS2) Ejegg: WIP Amazon audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242644 (https://phabricator.wikimedia.org/T111425) [15:41:37] morning ejegg [15:41:53] hi cwdent [15:42:10] just getting buckled in for the WP test [15:42:29] audit parser said it ran 23hr ago so guessing it'll run again in an hour? [15:42:41] ok, cool [15:42:47] excited? [15:42:53] oh yeah :) [15:43:27] if it does choke on the new data is it okay to still run the test and fix it after? [15:43:49] i'm also watching civi and the logs [15:43:49] probably - depends what kind of fixing it would mean [15:44:12] yeah, probably just a regex tweak like you had mentioned? [15:44:40] right, as long as the only fix would be in the parser [15:45:05] do you have other concerns? [15:45:51] I mean, if we needed to revert the order id suffix for some reason it might be a reason to cancel the test [15:45:54] but I [15:46:18] 'm just thinking super-cautious here -- not expecting to need that [15:47:21] ah sure, well we should have a few minutes after the parser runs to make that call [15:47:28] yah [15:48:05] I wonder if the files from yesterday are generated already [15:48:26] i don't think it would bust anything to try running the downloader early [15:49:23] oh good idea, just through the console? [15:50:26] i was thinking via jenkins [15:50:32] just to keep the logs in the same place [15:50:52] but i don't want the parser running right after [15:51:09] will disable that for a sec [15:51:11] how come? [15:51:22] i just want to take a look at the file first [15:51:31] ehh, guess it wouldn't hurt [15:51:32] good idea [15:51:53] do you do "schedule build" to make it run? [15:52:04] and "disable project" to turn off? [15:52:05] yep! [15:52:58] i was happy to find that the chromebook actually knows how to use an ssh tunnel [15:53:28] since all my keys are on my server i tunnel to that and then from there to jenkins [15:53:39] pretty impressed that it actually works, ssh is magic [15:54:44] srsly [15:55:28] ok, hitting the downlod button [15:56:30] looks like we have at least a couple 0930 files [15:56:49] cool, i think it's just 3 or so from megan [15:58:15] oh huh, no RECON whatevers [15:58:44] sorry, what are those? [15:59:12] I thought those were the audit files, but I may be mistaken [16:01:43] just turned the parser back on [16:02:00] so it'll be triggered by the scheduled download run coming up [16:02:17] groovy [16:02:19] thanks [16:08:35] ejegg: any reason not to punch that job early? [16:08:58] I don't think we have a file to process yet [16:09:13] ooh, the RECON file you mentioned? [16:09:23] yeah, i just checked the regex in the WP audit processor [16:09:42] gotcha [16:37:25] ejegg: looks like the parser ran and i don't see any errors! [16:37:42] nice! [16:38:54] hmm, I don't see a new recon file though [16:39:07] darn [16:39:17] Yeah, it would have logged a file name too [16:39:36] we just need to think happy thoughts today, right? [16:39:56] yep [16:40:06] ejegg: this just means they haven't uploaded a new one right? [16:40:12] yeah [16:40:26] guess we can't do much about that [16:40:43] I don't know how long it usually takes [17:00:50] hi awight / AndyRussG / K4-713 ! [17:01:00] ejegg: hi! [17:01:11] mornoon! [17:01:12] heh... two of us are about to be in a meeting. [17:01:30] ejegg: What's up? [17:01:55] not much, just saw all of you show up within minutes of each other! [17:02:06] well, not much except for the WP test starting now [17:02:14] cool! [17:02:19] K4-713: ping? [17:02:23] and... seeing the first donor [17:02:23] yep [17:02:31] waaawoooo [17:02:48] yaaay! [17:03:17] MBeat: ^ fyi [17:03:28] :) [17:03:34] boat loads [17:03:47] the amount of traffic still boggles my mind [17:03:48] MBeat: figured you were already all over that ;) [17:04:18] cwdent: I know! and we don't even give them a goddam reacharound... [17:04:31] hehe [17:05:18] k, two donors so far [17:05:38] It's weirdly dwarfed by PayPal, not a good sign [17:06:01] hmm [17:06:14] awight: where are you watching? civi? [17:06:16] --pouring in now! [17:07:29] only one error so far - Failed transaction because QueryTokenData failed [17:08:59] ejegg: fwiw, the XML said "Invalid Credit Card Number" [17:09:06] yah, just saw that [17:09:16] TODO: parse that into an error we can log [17:09:28] 7210 [17:11:26] Fundraising-Backlog: Parse and log "Invalid Credit Card Number" errors from Worldpay - https://phabricator.wikimedia.org/T114390#1693942 (cwdent) NEW [17:11:49] O_O [17:11:50] thanks [17:12:06] look, no hands ;) [17:12:25] hehe [17:12:36] ==> payments.error <== [17:12:36] Oct 1 17:12:26 payments1002 worldpay_gateway: 27932337:27932337.0 cURL transaction to Worldpay Gateway failed: (28) Operation timed out after 7001 milliseconds with 0 bytes received [17:12:40] awkward. [17:12:51] This is probably more traffic than they've gotten since the great war [17:13:05] damn [17:13:15] pwnd [17:13:29] bam [17:13:32] Hopefully the firetrucks can get to Bletchey Park [17:14:54] Hmm, we're preeetty close to that cutoff for a lot of these API calls: 5s is common [17:15:24] Donno if the curl timeout is just at the TCP level, or if it includes the entire communication [17:15:36] * awight butchers some more words [17:16:06] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Donate button on Amazon form should only show up when a card is selected - https://phabricator.wikimedia.org/T114198#1693968 (DStrine) [17:16:08] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Fix banners on IE8 and IE9 - https://phabricator.wikimedia.org/T113013#1693971 (DStrine) [17:16:10] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog: default to credit card (so it doesn't need to be in the url) - worldpay 1 hour test - https://phabricator.wikimedia.org/T112946#1693972 (DStrine) [17:16:13] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog, and 2 others: Write banner diet campaign mixin - https://phabricator.wikimedia.org/T112017#1693973 (DStrine) [17:16:15] Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, and 4 others: Triage what to do with civi-core patches: extensions, upstream, or abandon - https://phabricator.wikimedia.org/T99836#1693974 (DStrine) [17:17:51] awight: good question [17:22:19] Wikimedia-Fundraising: Back button breaks the banner form - https://phabricator.wikimedia.org/T114391#1694006 (awight) NEW [17:36:07] cwdent: Trying to make one of these: http://book.civicrm.org/user/current/organising-your-data/smart-groups/ [17:36:54] https://civicrm.wikimedia.org/civicrm/group/search?reset=1&force=1&context=smog&gid=283 [17:37:35] ah ha, nice [17:41:31] Fundraising-Backlog: Access for Joseph Seddon (new part-time contractor for fundraising) - https://phabricator.wikimedia.org/T113999#1694102 (Jgreen) p:Triage>Normal [17:42:05] Fundraising-Backlog: Access for Joseph Seddon (new part-time contractor for fundraising) - https://phabricator.wikimedia.org/T113999#1682070 (Jgreen) adding @awight for civicrm user setup [17:44:49] awight: did you want this task (T114391) in wikimedia-fundraising or fundraising backlog? [17:45:43] dstrine: ^ is a the-wub thing, so I wasn't sure where to file it. I think wikimedia-fundraising? [17:46:28] oh ok.. the-wub is this the correct project and board for you? [17:46:30] dstrine: yeah wikimedia-fundraising is fine. I will check it out [17:46:33] ok [17:46:35] thanks! [17:55:08] (CR) Awight: [C: 2] Throw exception on duplicate CSV header [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242732 (owner: Ejegg) [17:55:40] (CR) Awight: [C: 2] "Thanks!" [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/242572 (https://phabricator.wikimedia.org/T114250) (owner: Hashar) [17:55:42] (Merged) jenkins-bot: Introduce tox entry point and run flake8 [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/242572 (https://phabricator.wikimedia.org/T114250) (owner: Hashar) [17:56:21] (CR) Awight: [C: 2] "Yes please." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/242498 (https://phabricator.wikimedia.org/T114218) (owner: Hashar) [17:56:23] (Merged) jenkins-bot: Throw exception on duplicate CSV header [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242732 (owner: Ejegg) [17:56:25] (Merged) jenkins-bot: tox integration to run the flake8 linter [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/242498 (https://phabricator.wikimedia.org/T114218) (owner: Hashar) [17:58:12] (CR) Awight: [C: 2 V: 2] CRM-17306 fix location update action [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242423 (owner: Eileen) [17:58:39] (CR) Awight: "recheck" [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242410 (owner: Eileen) [18:04:32] (PS1) Ejegg: Refactor BaseAuditProcessor main loop [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242933 [18:14:32] (PS2) Ejegg: Refactor BaseAuditProcessor main loop [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242933 (https://phabricator.wikimedia.org/T111425) [18:18:56] (PS3) Ejegg: WIP Amazon audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242644 (https://phabricator.wikimedia.org/T111425) [18:23:16] via thcipriani: TIL: hitting f in a gerrit diff brings up the patch-set diff list [18:47:59] Fundraising Sprint Tom Waits, Fundraising-Backlog, Research-and-Data, Unplanned-Sprint-Work: Review banner history log data and confirm that it satisfies use cases - https://phabricator.wikimedia.org/T112986#1694365 (ellery) @AndyRussG is this data in HDFS on the analytics cluster now as well? [18:52:32] (PS1) Ejegg: Add report type to filename [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242941 (https://phabricator.wikimedia.org/T111425) [19:17:11] (Abandoned) Eileen: Civi46 update refund test for changed parameter (no 2) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242427 (owner: Eileen) [19:17:46] (Abandoned) Eileen: Civi46 update CiviCRM submodule version [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242426 (owner: Eileen) [19:19:47] (Abandoned) Eileen: Civi46 adjust function to get tests passing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242428 (owner: Eileen) [19:22:55] Fundraising-Backlog, fundraising-tech-ops, Performance: Serve cache control headers for static resources on paymentswiki - https://phabricator.wikimedia.org/T114404#1694505 (awight) NEW [19:23:17] (PS1) AndyRussG: Do Not Track: Don't even accumulate log or call EL [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/242946 [19:25:35] eileen: Yay! real 696m32.792s [19:25:43] the upgrade completed [19:26:08] (PS1) Eileen: Civi46 adjust function to get tests passing [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242950 [19:26:12] woohoo [19:26:23] I sent you some tiny patches which will give us a little info about intermediate steps, btw [19:26:53] awight: cool [19:27:07] so - is that like 11 hours? [19:27:11] (CR) jenkins-bot: [V: -1] Civi46 adjust function to get tests passing [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242950 (owner: Eileen) [19:27:20] eileen: Should I leave the staging site at 4.6 now, or you wanna retest anything about the upgrade? [19:28:00] yep, 11.5h [19:28:06] awight: leave it for now - we should do a ‘click around’ [19:28:23] but, I’ll look at what you sent in case we want to re-run over the weekend since it’s sloooww [19:28:57] awight: ah - test is like my local now! [19:28:58] https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm/878/console [19:29:14] awight: but I need to discuss the remaining failure [19:30:03] That looks like something I should fix, I wrote the wmf_campaigns module [19:30:07] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Nightly Amazon report download - https://phabricator.wikimedia.org/T109654#1694555 (XenoRyet) a:XenoRyet>None [19:30:34] awight: the issue is that the test is passing invalid options values [19:30:41] & civicrm used to accept & ignore [19:30:44] but not it rejects [19:31:04] so either you don’t really need to pass invalid option values & the test could be changed [19:31:12] or the code needs to pre-validate the values [19:31:23] & drop them if not valid [19:31:38] unless … you really need them saved even if not pre-existing [19:31:53] but then… one of the tests seems to ensure they don’t wind up in the emails… [19:32:47] Pretty sure those tests are supposed to create the option values before using them [19:32:51] I can fix... [19:32:55] ah ok [19:34:16] awight: if you fix then you won’t be able to get it into my dependency chain to get the final tests green ligh [19:34:16] t [19:34:17] Fundraising Sprint UB40, Fundraising-Backlog: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1694569 (XenoRyet) a:XenoRyet [19:34:35] unless I cherry-pick if off your sandbox [19:35:05] hmm? I'll just write the fix on top of civi-4.6.9 + you can do as you wish [19:35:29] We can also cheat the tests some more, but it seems like a good time to slow down and get the green lights if you agree [19:36:06] (CR) Eileen: [C: 2] "I so ++ on this!" [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242830 (owner: Awight) [19:36:39] (CR) jenkins-bot: [V: -1] Include .gitreview [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242830 (owner: Awight) [19:36:40] awight: yeah we are only that one issue away from the green lights now [19:40:49] Fundraising Sprint UB40, Fundraising-Backlog: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1694597 (XenoRyet) @CaitVirtue Was the "2015 San Francisco Event" value going to appear on the actual spreadsheet, or did you want the importer to auto-populate the... [19:48:11] awight: how can I grab a patch that is showing in gerrit but not get merged - ie cherry-pick but from what’s showing in gerrit [19:48:29] There are a few ways [19:48:46] The simplest is to use "git review -d 12345" [19:48:46] with the changeset number [19:49:02] awight: ok - I’ll try that! [19:49:20] Then, there are some more interesting things you can do right under "Patch Set N", next to "Download" [19:49:41] That will give you git commands to paste which will e.g. fetch only, for easy cherry-picking [19:52:36] cool - took me a while to see the url was changing [20:01:58] (CR) Eileen: [C: 2] "I am very +1 on this - PR submitted to core https://github.com/civicrm/civicrm-drupal/pull/319" [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242828 (https://phabricator.wikimedia.org/T99842) (owner: Awight) [20:03:18] http://robacarp.com/images/skitchd/2015.10.01.14.01.45-AdBlock.png [20:08:46] Fundraising Sprint UB40, Fundraising-Backlog: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1694742 (CaitVirtue) @LeanneS - I'm kicking @XenoRyet's question to you: "Was the "2015 San Francisco Event" value going to appear on the actual spreadsheet, or did... [20:09:56] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Nightly Amazon report download - https://phabricator.wikimedia.org/T109654#1694745 (Ejegg) a:Ejegg [20:10:15] (CR) jenkins-bot: [V: -1] Pretty-print upgrade outputs [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242828 (https://phabricator.wikimedia.org/T99842) (owner: Awight) [20:29:26] cwdent: sorry, booted [20:30:49] we thought you got rubbed out [20:30:51] said too much [20:53:32] off to do some shingling, ttyl [20:59:24] Fundraising Sprint UB40, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: JPMorgan Import Not Working - https://phabricator.wikimedia.org/T113381#1695072 (XenoRyet) a:XenoRyet [21:01:21] Fundraising Sprint UB40, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: JPMorgan Import Not Working - https://phabricator.wikimedia.org/T113381#1663419 (XenoRyet) @CaitVirtue @LeanneS Is there a sample JP Morgan file I can get for testing purposes? [21:08:02] Fundraising Sprint UB40, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: JPMorgan Import Not Working - https://phabricator.wikimedia.org/T113381#1695111 (LeanneS) @XenoRyet attached. Thanks! {F2651506} [21:09:35] eileen: Does OptionValue.create really require option_group_id, or can I pass an option_group_name? [21:10:07] awight: Uhm... [21:10:15] hang on a sec [21:10:18] hm? [21:10:56] This is strange, // $params['name']['api.aliases'] = array('label'); [21:11:21] awight: option_group_id should accept a name [21:12:08] try doing [21:12:55] drush cvapi OptionValue.getoptions field = option_group_id [21:13:19] basically if will look for a match in the keys & then the values [21:14:02] Fundraising Tech Backlog, Team-Practices-This-Week: Measure Maintenance Fraction for FR-Tech - https://phabricator.wikimedia.org/T114328#1695147 (JAufrecht) a:K4-713>JAufrecht [21:14:42] Fundraising Tech Backlog, Team-Practices-This-Week: Measure Maintenance Fraction for FR-Tech - https://phabricator.wikimedia.org/T114328#1691674 (JAufrecht) Next step: Joel to schedule meeting with David and Katie to figure out priority/capacity. [21:15:32] So, here is my mums wisdom on the banner ad - because Mum’s always think they know best & never hesitate to share that belief with their kids https://docs.google.com/document/d/1FPv4i6x3kg8Q6LpWzrBoMAM1Sq0c9be-IOcbra_glPA/edit?usp=sharing [21:15:41] Fundraising Sprint UB40, Fundraising-Backlog: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1695157 (LeanneS) @XenoRyet Since this will likely be used for other events, let's proceed with 2015 San Francisco Event being a value to add to the actual spreadsheet. [21:16:26] eileen: !!! "horrified" [21:16:33] Strong leader! [21:16:36] :-) [21:16:50] yes - so horrified she felt entitled to email me about it! [21:16:53] She even got the screenshot in there? [21:17:10] yes! [21:17:15] I love that the real complaint is just a grammatical trifle :D [21:17:40] She has read desktop publishing books you know - she’s an expert in layout.... [21:17:54] Well, we should target her with our more tasteful ad series [21:20:22] eileen: /o just looked up the chat logs, I missed a bit there. Thanks, I'll do a getoptions--but I was hoping that wouldn't be necessary, and I could pass option_group_name as a string [21:20:27] right - yes - so anyone who looks up scottish history or geneology should get that version [21:20:33] awight: you can [21:20:36] what I mean is [21:20:42] getoptions tells you want it accepts [21:21:01] ie. option_group_id accepts the keys or the values of get_options [21:21:30] oh! [21:21:32] thx [21:21:42] I think _id is a bad suffix, in that case. [21:21:45] & as long as you know that they can’t be confused (safe in that case) you can pass the name as ‘option_group_id’ -=> ‘prefix’ [21:21:58] awight: yeah - it’s kind of historical [21:22:23] but any field that you can do ‘getoptions’ on works like that in the api [21:22:39] (You can usually tell in the xml files) [21:28:42] Fundraising Tech Backlog, Team-Practices-This-Week: Measure Maintenance Fraction for FR-Tech - https://phabricator.wikimedia.org/T114328#1695236 (JAufrecht) [21:31:54] (PS1) Eileen: CRM-17322 output upgrade as text [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243028 [21:33:27] (CR) Awight: [C: 2] "Awesome!" [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243028 (owner: Eileen) [21:33:31] (CR) Eileen: "I've submitted an amended version of this based on feedback from CiviCRM core team https://gerrit.wikimedia.org/r/#/c/243028/" [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242828 (https://phabricator.wikimedia.org/T99842) (owner: Awight) [21:35:39] (CR) jenkins-bot: [V: -1] CRM-17322 output upgrade as text [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243028 (owner: Eileen) [21:54:37] (CR) Eileen: [C: 1] "Looks good to me - I've created a PR to upstream it" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/242820 (https://phabricator.wikimedia.org/T99842) (owner: Awight) [21:57:02] ejegg: didja get the invite? [21:58:13] AndyRussG: yep, I see it. Thanks! [21:58:21] ejegg: fantastic, thanks much!!!! [22:05:32] Fundraising Sprint UB40, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Install 4.6 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1695430 (Eileenmcnaughton) I've added a JIRA to track the enotice https://issues.civicrm.... [22:54:49] (PS1) Awight: Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243041 (https://phabricator.wikimedia.org/T99838) [22:55:26] (CR) jenkins-bot: [V: -1] Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243041 (https://phabricator.wikimedia.org/T99838) (owner: Awight) [22:56:17] I feel like that's a problem we already solved... [22:57:08] oh, now I see what you were saying, eileen -- those patches both break the tests. [22:57:23] maybe a merge commit... [22:57:45] sorry back up a bit [22:58:15] (PS1) XenoRyet: Add Direct Mail Appeal column to Trilogy Importer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243042 (https://phabricator.wikimedia.org/T114155) [22:58:19] the patch you just submitted fails on things that are fixed in the ones I have in my git review [22:58:20] That neither your last test fix nor mine fixes all the failing tests... [22:58:23] yep [22:58:33] no - they need to all run together [22:58:48] I think I need to cherry-pick yours into my dependency chain [22:59:14] I was thinking of doing a branch merge and taking the Change-Id headers off of our patches. [22:59:26] This gerrit thing is silly. Forced-merge, here I go! [23:00:06] btw, these are the people who were sad about the forced submits: #wikimedia-releng [23:00:44] (PS2) Awight: Civi46 adjust function to get tests passing [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242950 (owner: Eileen) [23:01:22] (CR) jenkins-bot: [V: -1] Civi46 adjust function to get tests passing [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242950 (owner: Eileen) [23:01:53] eileen: I think I just caused something bad to happen by rebasing your patch ^ [23:02:13] (CR) Awight: Civi46 adjust function to get tests passing (2 comments) [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242950 (owner: Eileen) [23:02:26] awight: hmm - I was going to try cherry-picking your patch into my git review [23:02:46] great, I'm stepping away from the ledge! [23:05:58] (CR) Eileen: Civi46 adjust function to get tests passing (2 comments) [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242950 (owner: Eileen) [23:06:26] (PS1) Eileen: Civi46 remove call to old function. [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243045 [23:06:28] (PS1) Eileen: Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243046 (https://phabricator.wikimedia.org/T99838) [23:07:40] (CR) jenkins-bot: [V: -1] Civi46 remove call to old function. [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243045 (owner: Eileen) [23:08:37] (CR) Awight: [C: -1] Add report type to filename (3 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242941 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [23:09:21] (CR) jenkins-bot: [V: -1] Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243046 (https://phabricator.wikimedia.org/T99838) (owner: Eileen) [23:09:37] Strange, you turned into the owner. I'll mention in the history so it doesn't look like you accidentally self-merged. [23:10:24] (CR) Awight: "author: awight." [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243046 (https://phabricator.wikimedia.org/T99838) (owner: Eileen) [23:10:28] awight: ok - looks like we still have it failing tho [23:10:47] Good point :) [23:12:31] fails locally too [23:18:31] (PS1) Awight: Create campaign option group [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243052 (https://phabricator.wikimedia.org/T99838) [23:18:33] (CR) jenkins-bot: [V: -1] Create campaign option group [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243052 (https://phabricator.wikimedia.org/T99838) (owner: Awight) [23:18:39] * awight blinks [23:19:03] (PS2) Awight: Create campaign option group [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243052 (https://phabricator.wikimedia.org/T99838) [23:19:14] aaah wrong branch [23:19:45] (PS1) Awight: Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243053 (https://phabricator.wikimedia.org/T99838) [23:19:51] (CR) jenkins-bot: [V: -1] Create campaign option group [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243052 (https://phabricator.wikimedia.org/T99838) (owner: Awight) [23:20:00] (Abandoned) Awight: Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243053 (https://phabricator.wikimedia.org/T99838) (owner: Awight) [23:21:32] eileen: hmm, I passed a string in option_group_id and got CiviCRM_API3_Exception: A fatal error was triggered: One of parameters (value: appeal_20080709183729) is not of the type Int [23:21:52] Should I do the ID lookup, or u think something simpler is going on? [23:22:06] was that on create? [23:22:16] yeah, OPtionValue->create [23:22:23] I would expect that to work [23:22:33] it does locally... [23:22:38] but - there is always a risk of cached values in tests... [23:23:01] or of the option_group that exists locally not existing in the test db [23:23:15] true, I'll run my schema install again [23:25:21] I was confused for ages because something got created in one run of the tests & then affected all subsequent ones - I’m used to Civi tests that blow stuff away - all the time! [23:25:22] Still works locally. Maybe the Civi repo regressed [23:25:36] These do blow away the db, AFAIK [23:25:38] should I push to a feature branch? [23:25:51] The only shortcoming is that the filesystem could have files from a stale checkout. [23:25:58] additional files only, I believe... [23:26:08] eileen: Push which? [23:26:18] which test fail are you looking at - cos I think I’m getting a fail.. [23:26:28] push the entire chain of commits [23:26:35] Anything you want [23:26:36] to a sandbox branch I mean [23:26:46] oh, sandbox branches don't have CI if you're wondering [23:28:58] Fundraising Tech Backlog: Worldpay HCG search by email address - https://phabricator.wikimedia.org/T114183#1695737 (MBeat33) [23:29:02] ok - so first on the tests - there are 3 failing tests - on CI & my local but not yours [23:29:14] so, are all 3 fixed for you? [23:29:36] I’m seeing CiviCRM_API3_Exception: 'fooCamp959551493NOT' is not a valid option for field custom_489 [23:29:40] (CR) Ejegg: "Yeah, that stuff doesn't belong here. I'm going to leave throttling to the SDK and let the the different client classes override the wait" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242941 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [23:29:49] eileen: on that last test, the crm/civicrm repo was checked out as master [23:29:59] what about your local? [23:30:12] All tests are green for me [23:30:22] RUnning the whole suite... [23:30:29] hmm - no I get the same 3 fails [23:30:42] what is your crm/civirm HEAD? [23:30:46] Tests: 92, Assertions: 256, Skipped: 1. [23:30:48] no fails [23:30:52] more actually but those are new tests I’m trying to write  [23:32:00] I never write an application w/ more than 256 assertions, so I can tell if any fail [23:32:39] awight: I just pushed my local to sandbox/eileen/civi-4.6.9 [23:32:47] ok thx [23:32:51] which is the same as gerrit is seeing [23:33:27] gah [23:33:31] passes [23:33:50] I have crm/civicrm 0e1726f265b63ea9ec3b1b5552f989152d374510 btw [23:34:48] eileen: ah, u cherry-picked an old patchset though [23:35:05] try da780a1fb0600c5dbbe7c7ae80272121cd3ef8ec [23:35:07] dang [23:35:15] I hate this rebase/amend crap [23:35:23] I also hate that I'm getting used to it. [23:36:24] OK now I can reproduce yr test failures, with the sandbox branch you pushed. [23:36:29] Both mysteries solved... [23:37:36] yay [23:37:43] (Abandoned) Awight: Create campaign option group [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243052 (https://phabricator.wikimedia.org/T99838) (owner: Awight) [23:37:59] (Abandoned) Awight: Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243041 (https://phabricator.wikimedia.org/T99838) (owner: Awight) [23:38:52] (CR) Eileen: "Actually this should be against civi-4.6.9-deploy" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/242820 (https://phabricator.wikimedia.org/T99842) (owner: Awight) [23:39:17] eileen: just bookkeeping--mind if I delete the civi-4.6.9-deploy branch in favor of civi-4.6.9? [23:39:32] go for it! [23:40:59] I'm also deleting 4.6.9-deploy, unless that's a thing? [23:43:53] (PS2) Ejegg: Add report type to filename [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242941 (https://phabricator.wikimedia.org/T111425) [23:44:59] awight: go fo that too [23:46:00] (CR) Awight: Add report type to filename (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242941 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [23:48:28] k, deleted the decoy branches. [23:50:31] (PS3) Ejegg: Add report type to filename [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242941 (https://phabricator.wikimedia.org/T111425) [23:51:27] did they go quack? [23:51:56] (CR) Awight: [C: 2] Add report type to filename [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242941 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [23:52:06] Tasted kind of woody [23:52:07] ty awight! [23:58:01] :-)