[00:06:19] <krrrit-wm>	 (Merged) jenkins-bot: Add report type to filename [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242941 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg)
[00:14:20] <krrrit-wm>	 (PS1) Awight: Help text for the impression diet feature [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243069
[00:17:10] <awight>	 eileen: holler if I can do anything
[00:17:30] <eileen>	 awight: are you working on that failing test - or do you want me to?
[00:17:39] <awight>	 Sorry--it passes now!
[00:17:46] <eileen>	 oh - where!
[00:17:49] <awight>	 u just have to grab the later patchset--want me to rebase?
[00:17:55] <awight>	 one moment...
[00:18:22] <eileen>	 (can you push the patch to my sandbox branch if you haven’t?)
[00:19:59] <krrrit-wm>	 (PS1) Awight: Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243074 (https://phabricator.wikimedia.org/T99838)
[00:20:24] <awight>	 Try to get to https://gerrit.wikimedia.org/r/#/c/242830/ when the rubble starts to clear--that will help us not push to the master branch
[00:21:42] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243074 (https://phabricator.wikimedia.org/T99838) (owner: Awight)
[00:21:47] * awight hides
[00:22:10] <krrrit-wm>	 (PS1) Eileen: Create campaign option group [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243076 (https://phabricator.wikimedia.org/T99838)
[00:22:11] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] Create campaign option group [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243076 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[00:22:45] <krrrit-wm>	 (Abandoned) Eileen: Create campaign option group [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243076 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[00:23:07] <krrrit-wm>	 (PS1) Eileen: Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243077 (https://phabricator.wikimedia.org/T99838)
[00:23:08] <awight>	 hakking...
[00:23:45] <awight>	 eh? ok, I'll just create a patch on https://gerrit.wikimedia.org/r/243077 and you can squash if you want.
[00:24:07] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243077 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[00:24:30] <krrrit-wm>	 (PS2) Awight: Civi46 remove call to old function. [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243045 (owner: Eileen)
[00:24:50] <krrrit-wm>	 (CR) Awight: [C: 2 V: 2] Civi46 remove call to old function. [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243045 (owner: Eileen)
[00:24:59] <eileen>	 hmm - did I not pull the right patch into my chain of patches?
[00:25:07] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] Civi46 remove call to old function. [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243045 (owner: Eileen)
[00:25:45] <awight>	 I don't think it was anyone's fault... stupid Gerrit is causing trouble to get noticed
[00:26:39] <krrrit-wm>	 (PS2) Awight: Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243077 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[00:27:12] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243077 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[00:27:40] <eileen>	 awight: errors in last run look unchanged...
[00:27:52] <awight>	 It's killin' me
[00:28:09] <awight>	 pretty sure i can reproduce
[00:30:53] <awight>	 good: 00:00:05.158 INFO:zuul.Cloner:Prepared wikimedia/fundraising/crm/civicrm repo with branch civi-4.6.9
[00:33:03] <awight>	 eileen: Do you think the option value should be automatically created if unknown?
[00:34:09] <awight>	 I don't like any of the alternatives: 1) automatically create option value, which leaves us open to spam, 2) create the contribution w/o campaign if it doesn't exist, which loses data, 3) explode and nothing gets into the db
[00:34:41] <eileen>	 awight: I suppose there is one other
[00:34:46] <awight>	 We were doing (2) previously, when Civi would silently eat it
[00:34:55] <eileen>	 which would be create + disable after import
[00:35:10] <eileen>	 so, it would hit the DB but not be active
[00:35:10] <awight>	 does that help with the spam factor?
[00:35:17] <awight>	 interesting
[00:35:27] <eileen>	 well it brings you to your status quo really
[00:35:38] <eileen>	 ie it gets into the DB
[00:35:44] <eileen>	 but is not an active option
[00:36:05] <awight>	 I'm starting to lean towards (3)
[00:36:15] <eileen>	 explode?
[00:36:17] <awight>	 We have a mechanism for manual review and resubmission...
[00:36:36] <eileen>	 ah I guess I don’t have much context for it
[00:36:37] <awight>	 This sort of is a serious condition, that someone is running a rogue donation campaign or spoofing one
[00:37:02] <eileen>	 & it would affect stuff coming in from the queue wouldn’t it
[00:37:12] <eileen>	 so it’s a) highly ununusal (I hope)
[00:37:18] <awight>	 The offending message would trigger a failmail to us, then just that message will be rejected into a donations-damaged queue
[00:37:32] <awight>	 yeah, this should be very unusual, and would generally mean someone forgot to set up a campaign in Civi
[00:37:48] <eileen>	 ok so wrap in a try-catch & notify if there is an exception?
[00:38:01] <awight>	 Implementation would be I just tell the tests this is normal, actually
[00:38:16] <eileen>	 right - because currently it IS blowing up
[00:38:30] <eileen>	 & if it blows up you already have queue management ?
[00:39:10] <awight>	 yep, at long as we translate into a WmfException
[00:42:28] <eileen>	 awight: OK - the test should check for that - cos I think that might NOT be working ATM
[00:42:38] <eileen>	 (but get it merged before you do that)
[00:42:57] <eileen>	 ie make it pass & then re-tweak for WMF-exception check if we can
[00:44:16] <eileen>	 awight: btw https://docs.google.com/a/wikimedia.org/spreadsheets/d/1qtCfcyBS7d0XHb9FBkYw5NYM3D0n44IEa-FQ6YoLf-0/edit?usp=sharing
[00:44:37] <eileen>	 (I had to drop a to-do list somewhere for when I think of things)
[00:48:56] <krrrit-wm>	 (Abandoned) Awight: Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243074 (https://phabricator.wikimedia.org/T99838) (owner: Awight)
[00:49:07] <krrrit-wm>	 (Abandoned) Awight: Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243046 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[00:49:15] <krrrit-wm>	 (PS1) Awight: Create campaign option group [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243088 (https://phabricator.wikimedia.org/T99838)
[00:49:17] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] Create campaign option group [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243088 (https://phabricator.wikimedia.org/T99838) (owner: Awight)
[00:49:39] <krrrit-wm>	 (PS2) Awight: Create campaign option group [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243088 (https://phabricator.wikimedia.org/T99838)
[00:50:34] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] Create campaign option group [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243088 (https://phabricator.wikimedia.org/T99838) (owner: Awight)
[00:50:45] <awight>	 omg
[00:50:54] <awight>	 branch.
[00:51:51] <krrrit-wm>	 (PS3) Awight: Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243077 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[00:52:29] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243077 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[00:52:53] <eileen>	 awight: that latest one is missing all the other dependencies....
[00:53:04] <awight>	 I can't watch.  what should the parent be?
[00:53:27] <awight>	 407849aa93ed224fd99833af148466e2b17fc980 ?
[00:53:55] <krrrit-wm>	 (PS4) Awight: Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243077 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[00:54:46] <eileen>	 I can’t follow
[00:54:50] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243077 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[00:54:58] <eileen>	 basically EVERY patch that is queued is needed for a full pass!
[00:55:35] <eileen>	 but I think this one is the top of my chain https://gerrit.wikimedia.org/r/#/c/242412/
[00:56:36] <wikibugs>	 Fundraising Sprint Tom Waits, Fundraising-Backlog, Research-and-Data, Unplanned-Sprint-Work: Review banner history log data and confirm that it satisfies use cases - https://phabricator.wikimedia.org/T112986#1695923 (AndyRussG) @ellery: I'm not sure... I don't know how to query it on HDFS. But I ca...
[00:56:46] * awight prays to releng monsters
[00:57:58] <krrrit-wm>	 (CR) Awight: [C: 2 V: 2] Civi46: fix another call to ContributionType (1 comment) [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242363 (owner: Eileen)
[00:58:22] <krrrit-wm>	 (CR) Awight: [C: 2 V: 2] Civi46 update CiviCRM submodule version [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242364 (owner: Eileen)
[00:58:45] <krrrit-wm>	 (CR) Awight: [C: 2 V: 2] Civi46 update refund test for changed parameter (no 2) [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242365 (owner: Eileen)
[00:59:16] <awight>	 eileen: Question about https://gerrit.wikimedia.org/r/#/c/242410/1/sites/all/modules/wmf_civicrm/wmf_civicrm.install,unified
[00:59:35] <eileen>	 yep
[00:59:38] <awight>	 I think I commented on another version of this :x
[00:59:45] <eileen>	 (did my comment replies show?)
[00:59:45] <awight>	 but whassup with _7035?
[01:00:02] <eileen>	 I had earlier copied & pasted 7034
[01:00:14] <eileen>	 & not committed that but not the change
[01:00:22] <eileen>	 so it’s a dupe of 7034
[01:00:35] <awight>	 ah k thx
[01:01:04] <krrrit-wm>	 (CR) Awight: [C: 2 V: 2] Civi46 adjust function to get tests passing [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242410 (owner: Eileen)
[01:02:24] <krrrit-wm>	 (CR) Eileen: "really? really truly - it's merged?!?!?" [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242410 (owner: Eileen)
[01:03:54] <krrrit-wm>	 (CR) Awight: "Looking forward to seeing what this is about once the other tests pass. I'll hold off on the merge." (2 comments) [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242412 (owner: Eileen)
[01:04:52] <krrrit-wm>	 (PS5) Awight: Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243077 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[01:05:48] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243077 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[01:05:51] <krrrit-wm>	 (PS3) Awight: Civi46 remove call to old function. [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243045 (owner: Eileen)
[01:06:03] <krrrit-wm>	 (CR) Awight: [C: 2 V: 2] Civi46 remove call to old function. [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243045 (owner: Eileen)
[01:06:45] <krrrit-wm>	 (PS6) Awight: Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243077 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[01:06:56] <awight>	 ok THAT should be what I work on ^
[01:07:13] <awight>	 baby is awake, gtg!
[01:10:36] <AndyRussG>	 awight: cya!
[01:11:40] <awight|ether>	 babye!
[01:12:10] <krrrit-wm>	 (CR) Eileen: [V: 2] Include .gitreview [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242830 (owner: Awight)
[01:13:10] <krrrit-wm>	 (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242830 (owner: Awight)
[01:17:49] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243077 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[02:14:52] <krrrit-wm>	 (Abandoned) Eileen: Civi46 adjust function to get tests passing [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242950 (owner: Eileen)
[02:16:23] <krrrit-wm>	 (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243028 (owner: Eileen)
[07:20:10] <krrrit-wm>	 (Abandoned) Awight: Pretty-print upgrade outputs [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242828 (https://phabricator.wikimedia.org/T99842) (owner: Awight)
[07:24:55] <wikibugs>	 Fundraising Sprint UB40, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Prepare queue messages for testing on upgraded Civi - https://phabricator.wikimedia.org/T114466#1696321 (awight) NEW
[07:28:54] * awight|ether waves at eileen_ 
[07:29:05] <eileen_>	 hey
[07:33:30] <eileen_>	 awight|ether: must be midnight there...
[07:35:10] <awight|ether>	 I've been sliding by with about 7 hr of work these past few days :(
[07:35:48] <awight>	 Finishing up that wmf_campaigns fix so it's not blocking the twinkling green lists, looks easy at a second glance.
[07:38:32] <eileen_>	 awight: cool - be nice to get it green
[07:39:00] <eileen_>	 I have other patches on the civi side - reports - that I was waiting to push through when the lights were green
[07:50:42] <awight>	 Ran into some trouble again--now I'm no longer getting a Civi exception if I try to create a contribution with an invalid option value in the campaign custom field.
[07:51:16] <krrrit-wm>	 (PS7) Awight: Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243077 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[07:52:11] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243077 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[07:52:29] <krrrit-wm>	 (PS1) Eileen: Add test class for reports [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243118
[07:53:23] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] Add test class for reports [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243118 (owner: Eileen)
[08:01:14] <eileen_>	 awight: does the value exist in your test instance now
[08:01:34] <eileen_>	 nb - those tests I pushed are WIP - I kind of wanted to be able to demo that concept
[08:10:34] <krrrit-wm>	 (PS8) Awight: Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243077 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[08:11:31] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243077 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[08:13:15] <krrrit-wm>	 (PS1) Awight: Cleanup: Drupal 7 hook_update_N signature [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243120
[08:14:12] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] Cleanup: Drupal 7 hook_update_N signature [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243120 (owner: Awight)
[08:18:34] <krrrit-wm>	 (PS9) Awight: Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243077 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[08:19:30] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243077 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[08:47:02] <krrrit-wm>	 (PS10) Awight: Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243077 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[08:47:57] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243077 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[08:48:45] <krrrit-wm>	 (PS11) Awight: Create campaign option group [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243077 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[08:54:53] <krrrit-wm>	 (PS12) Awight: Campaign option values must exist [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243077 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[09:00:40] <wikibugs>	 Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [epic] Port our CiviCRM customizations to 4.6 upstream, and to extensions - https://phabricator.wikimedia.org/T99838#1696408 (awight)
[09:07:07] <krrrit-wm>	 (CR) Awight: "It's so simple! Except the funky glue, of course--it would be nice if that could be directly reused from core rather than duplicated." (2 comments) [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243118 (owner: Eileen)
[09:23:13] <wikibugs>	 Wikimedia-Fundraising, Continuous-Integration-Infrastructure: Add YAML lint test in wikimedia/fundraising/tools to remove the Jenkins job 'yamllint' - https://phabricator.wikimedia.org/T114470#1696438 (hashar) NEW
[09:24:56] <wikibugs>	 Wikimedia-Fundraising, Continuous-Integration-Infrastructure: Add YAML lint test in wikimedia/fundraising/tools to remove the Jenkins job 'yamllint' - https://phabricator.wikimedia.org/T114470#1696438 (hashar) There is no Jenkins job running tox yet because it defines a flake8 env and the repo does not p...
[09:34:35] <wikibugs>	 Wikimedia-Fundraising, Continuous-Integration-Infrastructure: Add YAML lint test in wikimedia/fundraising/tools to remove the Jenkins job 'yamllint' - https://phabricator.wikimedia.org/T114470#1696468 (jayvdb) The yamllint in jenkins is doing roughly the same as the only other Python tool that I can quic...
[10:31:22] <krrrit-wm>	 (PS1) Hashar: Rough YAML linter for *.yaml.example files [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/243134 (https://phabricator.wikimedia.org/T114470)
[10:32:36] <krrrit-wm>	 (CR) Hashar: "check experimental" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/243134 (https://phabricator.wikimedia.org/T114470) (owner: Hashar)
[10:34:01] <krrrit-wm>	 (CR) Hashar: "So:" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/243134 (https://phabricator.wikimedia.org/T114470) (owner: Hashar)
[10:47:51] <krrrit-wm>	 (CR) John Vandenberg: [C: 1] "it works as described on the box" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/243134 (https://phabricator.wikimedia.org/T114470) (owner: Hashar)
[10:48:42] <wikibugs>	 Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, and 4 others: Triage what to do with civi-core patches: extensions, upstream, or abandon - https://phabricator.wikimedia.org/T99836#1696675 (atgo) @eileen - thanks for this...
[13:37:18] <krrrit-wm>	 (PS1) Hashar: Composer entry point to run tests [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/243173 (https://phabricator.wikimedia.org/T104264)
[13:37:53] <krrrit-wm>	 (CR) Hashar: "check experimental" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/243173 (https://phabricator.wikimedia.org/T104264) (owner: Hashar)
[13:42:14] <wikibugs>	 Fundraising Tech Backlog, Fundraising-Backlog, Continuous-Integration-Config, Patch-For-Review: Enable PHPUnit testing on the wikimedia/fundraising/SmashPig repo - https://phabricator.wikimedia.org/T104264#1696952 (hashar) a:hashar https://gerrit.wikimedia.org/r/#/c/243173/ Add the `composer te...
[14:17:22] <krrrit-wm>	 (PS1) AndyRussG: WIP BannerHistoryLog: timeout for users without sendBeacon [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243180
[14:17:24] <krrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP BannerHistoryLog: timeout for users without sendBeacon [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243180 (owner: AndyRussG)
[15:55:39] <krrrit-wm>	 (PS2) Awight: Cleanup: Drupal 7 hook_update_N signature [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243120
[16:06:26] <wikibugs>	 Fundraising-Backlog: Access for Joseph Seddon (new part-time contractor for fundraising) - https://phabricator.wikimedia.org/T113999#1697403 (jrobell) Thank you @Jgreen. Yes, Joseph has already signed the necessary paperwork. I have added his initial contact details to the contact page [https://office.wikime...
[16:24:25] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Outdated cert on GC iframe? - https://phabricator.wikimedia.org/T112990#1697468 (Jgreen) Open>Resolved a:Jgreen We fit this category, and I confirmed that the trustwave CA is included: "If you are using an up-to-date CA truststore you will only have to...
[16:55:33] <cwdent>	 well i beat the rain: https://goo.gl/photos/qTRnAatvwiwXHGJz7
[16:58:39] <wikibugs>	 Fundraising-Backlog: [epic] worldpay  1 hour test in France - https://phabricator.wikimedia.org/T110113#1697561 (cwdent)
[17:04:16] <krrrit-wm>	 (PS1) Ejegg: Update Amazon SDK fork [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/243211 (https://phabricator.wikimedia.org/T109654)
[17:04:30] <krrrit-wm>	 (CR) Ejegg: [C: 2 V: 2] Update Amazon SDK fork [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/243211 (https://phabricator.wikimedia.org/T109654) (owner: Ejegg)
[17:08:04] <krrrit-wm>	 (PS1) Ejegg: Update SDK, use new GetReportList parameters [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/243213 (https://phabricator.wikimedia.org/T109654)
[17:27:04] <ejegg>	 that shed looks good cwdent!
[17:53:20] <dstrine>	 cwdent: that's awesome!
[17:53:46] <XenoRyet>	 Did I miss a shed pic?
[17:54:53] <cwdent>	 :)
[17:57:12] <cwdent>	 Xenoryet https://goo.gl/photos/qTRnAatvwiwXHGJz7
[17:57:44] <XenoRyet>	 NIce.  That is a good lookin' building.
[18:33:17] <krrrit-wm>	 (PS1) Ejegg: Move some WMF-specific links to settings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/243225 (https://phabricator.wikimedia.org/T108699)
[19:00:03] <krrrit-wm>	 (PS2) Ejegg: Ensure card selected before clicking 'Donate' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242432 (https://phabricator.wikimedia.org/T114198)
[20:04:38] <AndyRussG>	 ewulczyn___: hi! how's it going?
[20:05:12] <ewulczyn___>	 @AndyRussG pretty good, whats up?
[20:06:26] <AndyRussG>	 not much, since I just happend to see you here, I thought I'd ask if you'd had a chance to query the banner history data... I have access to Hive but I don't know really how to query yet...
[20:06:32] <AndyRussG>	 ewulczyn___: ^
[20:07:03] <dstrine>	 ejegg: standup?
[20:07:51] <ewulczyn___>	 not yet, but I can take a look at the france data today
[20:12:38] <ejegg>	 oops, sorry!
[20:14:29] <AndyRussG>	 ewulczyn___: if u get a chance, that'd be amazing!! I'll be around for most of the afternoon and evening, I think
[20:14:46] <AndyRussG>	 ewulczyn___: LMK if u have any questions or issues pls :)
[20:15:43] <ewulczyn___>	 @AndyRussG as far as I can tell, there is no data for the france campaign in hive
[20:16:26] <ewulczyn___>	 i'm looking for data in this path: /wmf/data/raw/eventlogging/eventlogging_CentralNoticeBannerHistory
[20:17:32] <AndyRussG>	 ewulczyn___: Hmmm.... I can see them in Kafka like this: kafkacat -o beginning -t eventlogging_CentralNoticeBannerHistory -b kafka1012.eqiad.wmnet:9092
[20:20:04] <ewulczyn___>	 there may be a delay, I can check again later
[20:20:48] <ewulczyn___>	 how is the data from kafka getting into hdfs ?
[20:33:59] <ewulczyn___>	 @AndyRussG never mind, I see it now, I had the wrong day
[20:39:00] <wikibugs>	 Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Nightly Amazon report download - https://phabricator.wikimedia.org/T109654#1698474 (Ejegg) Changes to the SDK: https://github.com/ejegg/login-and-pay-with-amazon-...
[20:40:40] <AndyRussG>	 ewulczyn___: great!
[20:49:01] <cwdent>	 ejegg: btw if you're interested you can get a signed cert for free here: http://www.startssl.com/
[20:49:32] <cwdent>	 it's kind of a pain but works great, current ciphers and green bar and everything
[20:59:12] <ejegg>	 cwdent: yeah!  I got one from them for ejegg.com, i just didn't bother with one for my local dev
[21:24:38] <wikibugs>	 Fundraising Tech Backlog: Worldpay HCG search by email address - https://phabricator.wikimedia.org/T114183#1698627 (Ppena)
[21:24:39] <wikibugs>	 Fundraising-Backlog: [epic] Worldpay campaign ready in France - https://phabricator.wikimedia.org/T110114#1698626 (Ppena)
[21:25:59] <wikibugs>	 Fundraising Sprint UB40, Fundraising Tech Backlog, Unplanned-Sprint-Work: Worldpay HCG search by email address - https://phabricator.wikimedia.org/T114183#1698642 (DStrine)
[21:30:44] <ewulczyn___>	 @AndyRussG how do I know if the last event in the log led to a donation?
[21:31:03] <AndyRussG>	 ewulczyn___: hi! sadly that part is not yet on the cluser :(
[21:31:50] <AndyRussG>	 ewulczyn___: it's implemented in Banner History but the Donation Interface side isn't yet, working on it...
[21:32:32] <ewulczyn___>	 @AndyRussG ok. can you give me a sense of how I can tell once its implemented?
[21:34:16] <AndyRussG>	 ewulczyn___: Yea! From civi, you'll be able to query a table of associations of banner history id <=> donor id
[21:35:31] * AndyRussG looks for the exact name of the field
[21:36:15] <AndyRussG>	 ewulczyn___: rather, I mean contribution_tracking_id
[21:37:11] <AndyRussG>	 So, the log ids that are not associated with a contribution_tracking_id were pageviews in which donate was not clicked
[21:38:19] <krrrit-wm>	 (CR) Eileen: [C: 2] "This all looks good to me ... especially the GREEN test light" [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243077 (https://phabricator.wikimedia.org/T99838) (owner: Eileen)
[21:38:29] <AndyRussG>	 ewulczyn___: Since I have not experience actually querying civi, I'm not sure about more details, but my understanding is that that's something you can do... right?
[21:38:53] <krrrit-wm>	 (CR) Eileen: "recheck" [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242412 (owner: Eileen)
[21:40:31] <AndyRussG>	 ewulczyn___: I think that with the contribution_tracking_id you can get all kinds of additional data, including whether the donations were successful, no?
[21:41:52] <AndyRussG>	 Re: the timestamps, sure that should be easy
[21:43:08] <krrrit-wm>	 (CR) Eileen: "So the fails now are the ones I'm getting locally - this test manually includes the boostrap file in the module -as does the install & I h" [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242412 (owner: Eileen)
[21:43:15] <AndyRussG>	 ewulczyn___: there're also some interesting tidbits in this Phabricator task, though not the task's main topic per se: https://phabricator.wikimedia.org/T114078
[21:44:19] <AndyRussG>	 For example, we could further minify log entries with a smaller format, along the lines of "B_ID|C_ID|TIMESTAMP|S_ID"
[21:45:02] <AndyRussG>	 (in mform's comment: https://phabricator.wikimedia.org/T114078#1690191)
[21:46:34] <AndyRussG>	 Dunno if doing that'd be worth it in terms of the more work for processing?
[21:47:35] <AndyRussG>	 Also, Nuria mentioned there were some EL errors, which I was able to see initially when I clicked on the link in her coment, but then later on I couldn't find them (even when I changed the windo of the grafana viewer). I guess I can ask EL infrastructure folks about that one, tho....
[21:47:37] <AndyRussG>	 https://phabricator.wikimedia.org/T114078#1691538
[21:48:03] <krrrit-wm>	 (CR) Eileen: "I don't think we can re-use core - unless we convert the core function for the globals into a static one in core but might be a hard case" (1 comment) [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243118 (owner: Eileen)
[21:49:08] <ewulczyn___>	 @AndyRussG yeah, I can query civi. Its great to be able to get more info about the donation that way. Can you tell me more about when events are logged? On a donation, the log is always sent correct? If so, how are you ensuring that the log was not  also sent on the last "pageview in the campaign"?
[21:49:37] <AndyRussG>	 ewulczyn___: it's in the BH code, one sec!
[21:49:58] <ewulczyn___>	 @AndyRussG do you want to do a quick hangout?
[21:50:48] <krrrit-wm>	 (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242830 (owner: Awight)
[21:53:48] <AndyRussG>	 ewulczyn___: sure! one sec
[21:54:35] <AndyRussG>	 ewulczyn___: K any time now
[21:55:27] <AndyRussG>	 ewulczyn___: rrrg something wrong with my hangouts, just lemme restart them
[21:55:33] <AndyRussG>	 (I did hear it ring)
[22:01:35] <krrrit-wm>	 (PS2) Awight: Include .gitreview [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242830
[22:33:40] <wikibugs>	 Fundraising Sprint UB40, Fundraising Tech Backlog, Unplanned-Sprint-Work: Worldpay HCG search by email address - https://phabricator.wikimedia.org/T114183#1698877 (cwdent) I just checked the logs and confirmed that we are still sending this field, so they must have stopped recording it, or just aren't...