[02:00:24] Fundraising-Backlog, Analytics-EventLogging: Nested EventLogging data doesn't get copied to MySQL - https://phabricator.wikimedia.org/T112947#1701213 (AndyRussG) Thanks!! @ellery, now that the data is going into HDFS, is this task still relevant? Do you have plans to query banner history logs via MySQL s... [02:08:33] (PS1) AndyRussG: ext.centralNotice.display: public getData() -> getDataProperty() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243604 [09:27:44] TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team-Fundraising-Sprint-2015-09-30, TCB-Team: [WMDE-Fundraising] Request CentralNotice adminship rights - https://phabricator.wikimedia.org/T112059#1701541 (WMDE-leszek) Adminship rights are requested at https://met... [12:24:54] (CR) Siebrand: [C: 1] "i18n/L10n reviewed." (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243069 (owner: Awight) [12:27:33] (CR) Siebrand: [C: 2] Remove i18n shim [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243377 (owner: Paladox) [12:28:57] (Merged) jenkins-bot: Remove i18n shim [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243377 (owner: Paladox) [12:51:16] Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Infrastructure: Job wikimedia-fundraising-civicrm fails on branch civi-4.6.9-deploy causing force merges that breaks Zuul scheduler - https://phabricator.wikimedia.org/T114165#1701893 (hashar) Happy you managed to fix it :-} [14:31:12] nick cwdent [14:45:49] cwdent: hi! how was your weekend? [14:47:58] AndyRussG: morning! it was pretty good, how about you? [14:50:01] cwdent: mm not bad... we took it pretty easy, our most significant outing was to the "big library" yesterday https://en.wikipedia.org/wiki/Biblioth%C3%A8que_et_Archives_nationales_du_Qu%C3%A9bec [14:50:27] Lots of great kids' books :) [14:50:47] cwdent: I was gonna ask, to you have any quick pointers for where to look to understand the hooks system of DonationInterface? [14:51:01] Perusing the code, it looks a lot less messy than I have been led to believe ;) [14:51:22] wow that is a seriously big library [14:51:47] AndyRussG: hehe just you wait [14:51:47] Yeah! It's really amazing. By joining you also get access to a zillion online journals and stuff from home, too [14:52:44] viva canada [14:53:01] Oh wait here's the main site https://en.wikipedia.org/wiki/Grande_Biblioth%C3%A8que [14:53:14] I mean the main article [14:53:56] hehe, literally big library [14:53:57] The US also haz libraries!! [14:54:12] yep, longmont actually has a great library [14:54:29] but it doesn't have no WP article :) [14:55:18] Heh no sockpupet marketer creating WP articles like here ;) [14:56:36] haha, ouch [14:56:54] AndyRussG: soo...hooks system in DI? afaik it's the same as normal MW [14:57:01] are you referring to something specific? [14:58:00] cwdent: yeah awight suggested that I hook into the pre-process hook for putting the banner history ID into a queue [14:59:06] ah ha, let me look [14:59:21] i wonder if he means on payments wiki? [14:59:28] is CN even installed there? [15:00:38] i know donationinterface is installed everywhere because it contains some translations [15:00:45] cwdent: however it seems that's called from GatewayAdapter from do_transaction_internal(), and it's done by creating a function in each payment processor, since it goes by a call to $this->executeIfFunctionExists( 'pre_process_' . $transaction ); [15:01:53] cwdent: yeah we're talking about on payments wiki. When the user clicks donate, they go to payments as normal, and BH id (not the whole history) is included as a URL param, and I have to associate that with contribution_tracking_id and throw it in a queue [15:02:25] aah, gotcha, so we can associate the donation with the history? [15:02:26] hmm I didn't even think to look for normal hooks calls :) [15:02:31] yep [15:02:47] That's the only significant peice of the puzzle that's still missing [15:03:08] i see this GatewayHandoff hook, i wonder if that's the one? [15:03:13] also GatewayPostProcess [15:04:50] Hmmm maybe it'll be one of those then... Yeah maybe there are normal hooks, and then pre_process that isn't normal 8p fun!! [15:05:07] I guess it's just a question of knowing in the whole process where the right part to do it is [15:05:34] I guess somewhere where we know contribution_trakcing_id is available, and of course unified code for all payment processors [15:07:37] is ctid available before the donation is finalized? [15:08:45] cwdent: yeah... via DonationData? Not sure... We have to do this on the first pass, for processors like PayPal [15:08:53] Or rather because of processors like that [15:09:29] right right...there is a lot of state in the donate process [15:10:02] yeah! [15:13:57] hey guys! [15:14:46] wb atgo [15:14:53] where are you at? [15:14:59] cwdent: i just tried to donate via the WP french form with my amex and it didn't go through :D [15:15:02] lisbon! [15:15:39] nice [15:21:35] atgo: hi! [15:22:08] atgo: check out the BH data flowing into our servers! https://grafana.wikimedia.org/#/dashboard/db/eventloggingschema?from=now-12h&var-schema=CentralNoticeBannerHistory [15:22:22] Gotta do a bit of driving, back in 45min - 1 hr :) [15:23:05] how's things friends? [15:23:14] AndyRussG|a-whey: go data go! [15:23:19] :D [15:36:00] you guys are so rad. [15:41:20] were you in lisbon last week atgo? [15:41:26] i'm in lisbon right now! [15:41:32] got here day before yesterday [15:41:51] where were you last week? [15:58:01] (PS6) Paladox: [WIP] Add extension.json, empty php entry point [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (owner: Awight) [15:58:13] (CR) Awight: Help text for the impression diet feature (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243069 (owner: Awight) [15:58:23] (CR) Paladox: [C: 1] "Rebased." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (owner: Awight) [15:58:52] cwdent ibiza [16:04:10] atgo: wow, looks amazing [16:08:45] Fundraising-Backlog: Help setting up a Top Prospects report in Civi - https://phabricator.wikimedia.org/T113904#1702348 (CaitVirtue) Updated link to explanation of TargetSmart codes: https://collab.wikimedia.org/wiki/Fundraising/MajorGiftsandFoundations#Key_to_TargetSmart_Coding [16:09:08] Fundraising-Backlog: Help setting up a Top Prospects report in Civi - https://phabricator.wikimedia.org/T113904#1702349 (CaitVirtue) [16:11:01] Fundraising Sprint UB40, Fundraising Tech Backlog, Unplanned-Sprint-Work: Worldpay HCG search by email address - https://phabricator.wikimedia.org/T114183#1702381 (atgo) p:Triage>High [16:14:53] cwdent: it did not suck :P [16:25:19] atgo: FYI Ellery has checked that he's able to query the data, too :) [16:25:26] awesome [16:34:20] Fundraising-Backlog: Dedupe data in Silverpop file - https://phabricator.wikimedia.org/T107045#1702532 (atgo) @ccogdill_wmf can you give us some concrete examples for when this is coming up. @mbeat33 it would be helpful to leave them unmerged for the time being, thanks. [16:43:11] Fundraising-Backlog: More communication between Silverpop and Civi - https://phabricator.wikimedia.org/T114671#1702587 (CaitVirtue) NEW [16:51:26] Fundraising-Backlog: Spike: Investigate NULL country - https://phabricator.wikimedia.org/T112021#1702629 (atgo) @awight can we merge this into T99128? [16:52:30] Fundraising-Backlog: Dedupe data in Silverpop file - https://phabricator.wikimedia.org/T107045#1702635 (CCogdill_WMF) Sure, @atgo. @MBeat33 can you help with this, and send the next couple of examples you come across? Here are two example contact records Michael merged on 8/25: https://civicrm.wikimedia.org... [16:55:22] Fundraising-Backlog: Dedupe data in Silverpop file - https://phabricator.wikimedia.org/T107045#1702650 (MBeat33) You bet, @CCogdill_WMF. I scanned for any examples from Italy today and didn't see any, but will add any new ones here. [16:57:10] PPena: missing audit files seem like a good guess as to why the refund wouldn't show up in civi [16:57:22] Fundraising-Backlog: Spike: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1702664 (atgo) [16:57:31] cwdent cool, thats great [16:57:40] cwdent have we seen any audit files yet [16:57:41] ? [16:58:07] lemme check [17:08:52] (CR) Awight: "Is it okay that we don't list the hooks in extension.json?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (owner: Awight) [17:13:32] (PS4) Awight: Add npm support, Add composer.json [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243379 (owner: Paladox) [17:14:35] (CR) Awight: [C: 2] "Thank you!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243379 (owner: Paladox) [17:15:26] (CR) Paladox: "Thanks." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243379 (owner: Paladox) [17:16:01] (Merged) jenkins-bot: Add npm support, Add composer.json [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243379 (owner: Paladox) [17:16:07] (CR) Paladox: "Well not really which either way you would like it to work. You would need to do a callback and put the hooks in a different file." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (owner: Awight) [17:20:51] Fundraising-Backlog: Help setting up a Top Prospects report in Civi - https://phabricator.wikimedia.org/T113904#1702733 (atgo) Is this something we could have Giant Rabbit help with? [17:24:06] (CR) Awight: "Sorry, I don't quite understand what I should do here. I see a "callbacks" key in ExtensionRegistry.php, but it seems to be unused:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (owner: Awight) [17:24:52] Fundraising-Backlog: EXTERNAL: Worldpay Audit file - https://phabricator.wikimedia.org/T114676#1702745 (Ppena) NEW [17:25:44] Fundraising-Backlog: EXTERNAL: CVV error code - https://phabricator.wikimedia.org/T114677#1702753 (Ppena) NEW [17:27:42] Fundraising-Backlog: EXTERNAL: Name field hide on iframe & Iframe translations - https://phabricator.wikimedia.org/T114679#1702800 (Ppena) NEW [17:35:43] awight: hi! how's it going? Mmm if u got a sec to provide more details about what u meant by hooking into the pre_process hook for throwing BH ID into the queue? I didn't find a standard MW hook for that (though there are others), only a call to a pre_process_ method that has to be implemented by subclasses of GatewayAdapter... ? [17:36:14] Since we need some common code for all processors, I don't know where to hook into that [17:36:18] AndyRussG: Definitely! Gimme a few minutes to wrap up another thing [17:36:33] And was just looking for the first place to be sure we can have a contribution_tracking_id [17:36:38] awight: cool, thanks much! [17:40:02] On a side note, my tip of the day is, when you're putting away leftovers, it may not be a good idea to put the rice and the salad in the same container [17:40:32] * AndyRussG eats cold rice w/ BBQ sauce and lettuce [17:42:05] Fundraising Sprint UB40, Fundraising-Backlog: EXTERNAL: Worldpay Audit file - https://phabricator.wikimedia.org/T114676#1702882 (DStrine) [17:42:19] Fundraising Sprint UB40, Fundraising-Backlog: EXTERNAL: Worldpay Audit file - https://phabricator.wikimedia.org/T114676#1702890 (DStrine) a:Ppena [17:44:10] Fundraising-Backlog: EXTERNAL: Name field hide on iframe & Iframe translations - https://phabricator.wikimedia.org/T114679#1702894 (DStrine) [17:44:25] Fundraising Sprint UB40, Fundraising-Backlog: EXTERNAL: Name field hide on iframe & Iframe translations - https://phabricator.wikimedia.org/T114679#1702900 (DStrine) a:Ppena [17:45:12] Fundraising Sprint UB40, Fundraising Tech Backlog, Unplanned-Sprint-Work: EXTERNAL: Worldpay HCG search by email address - https://phabricator.wikimedia.org/T114183#1702906 (DStrine) a:Ppena [17:45:36] Fundraising-Backlog: Spike: Investigate NULL country - https://phabricator.wikimedia.org/T112021#1702908 (awight) [17:48:51] Fundraising-Backlog: Spike: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1702918 (awight) @CCogdill_WMF: If it's easy, can you try to estimate how badly the https-only snafu is damaging clickthrough rates? [17:49:01] Fundraising-Backlog: [EPIC] Worldpay France post launch - https://phabricator.wikimedia.org/T114682#1702919 (DStrine) NEW [17:50:03] Fundraising-Backlog: EXTERNAL: CVV error code - https://phabricator.wikimedia.org/T114677#1702930 (DStrine) [17:50:47] Fundraising-Backlog: EXTERNAL: Email info referenced on Merchant Reference 2 field - https://phabricator.wikimedia.org/T114678#1702776 (DStrine) [17:53:00] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [milestone] Engage exclusively uses spreadsheet imports - https://phabricator.wikimedia.org/T114683#1702936 (awight) NEW [17:53:06] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [milestone] Engage exclusively uses spreadsheet imports - https://phabricator.wikimedia.org/T114683#1702945 (awight) [17:54:25] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, and 6 others: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1702964 (awight) [17:54:26] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [milestone] Engage exclusively uses spreadsheet imports - https://phabricator.wikimedia.org/T114683#1702936 (awight) [17:58:37] Fundraising Sprint UB40, Fundraising-Backlog: Sprint UB40 (9/30-10/14) goal: Worldpay and Amazon campaign ready - https://phabricator.wikimedia.org/T109908#1702991 (DStrine) [17:59:42] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Train Engage in how to fill out the generic import templates - https://phabricator.wikimedia.org/T114687#1703001 (awight) NEW [18:01:09] AndyRussG: hi! back from the other coal face [18:01:58] awight: hey gotta keep that CO2-emmiting gold flowing [18:02:46] I saw this awesome poster in Berlin, "Google sounds just like 'coal' (ugol) in Russian" [18:03:10] Talking about how much energy is used for our asinine searching and being advertised to [18:03:23] um... okay, finding the function I was mentioning... [18:03:43] Only 500 pixels needed to warm up ur vodka [18:05:05] It looks like as soon as DonationData is instantiated, you're guaranteed to have a contribution_tracking_id, right? [18:05:18] AndyRussG: extras/custom_filters/custom_filters.body.php validate() [18:05:44] That would be a decent place to scramble another queue message [18:06:41] awight: hmmm... What does that function do? [18:07:19] For some reason, I can't google for that poster ;) [18:08:15] heh [18:09:26] Wow, I'm having trouble proving that the function is called at all [18:11:41] Fundraising-Backlog, fundraising-tech-ops, Security, operations: Delete gadolinium:/a/log/fundraising/ - https://phabricator.wikimedia.org/T92336#1703088 (Jgreen) [18:11:50] AndyRussG: ./DonationInterface.php:$wgHooks['GatewayValidate'][] = array( 'Gateway_Extras_CustomFilters::onValidate' ); [18:11:53] whew [18:12:33] the-wub: and AndyRussG now that there is at least one banner using banner history... do we need this "training session"? [18:13:13] dstrine: I think it'd be fun a little ways on, just to answer any questions there may be. Also, the part of the system that links BH to donations is not online yet, so we have yet to see how that works out ;p [18:13:19] it's pretty difficult to get people into a room [18:13:36] dstrine: ah right... mmm I wouldn't stress about it :) [18:15:20] awight: (w)ow [18:15:27] hmmm [18:15:33] AndyRussG: is this captured in a phab task yet? " Also, the part of the system that links BH to donations is not online yet, so we have yet to see how that works out ;p" [18:15:51] Is that the ID task you have in progress? [18:16:04] yep [18:16:10] dstrine: yes, it's part of T112022 [18:16:20] kk [18:18:17] awight: are these extras kinda like mixins for DI then? [18:18:28] eh, just dangling like hooks [18:18:32] more like extensions [18:18:53] Hmm [18:18:55] * awight blurs more lines [18:20:12] awight: if sending the BH id along is something that should always happen (let's say, provided a bannerHistoryLogID param is present) does it make sense to make it an add-on that is enabled or disabled per gateway? [18:20:56] Sine I don't know yet hardly anything about the organization of this code, I should defer to others on this, just wondering out loud :) [18:21:00] I don't see a reason to tie it to gateways [18:21:01] s/Sine/Since [18:21:50] but we might want to decouple even further from the core functionality, like add it in a new class and fire using another append to that same hook [18:22:19] (CR) Paladox: "No every extension/skin uses the callback if a certain feature for example a hook is not compatible with extension.json the work around is" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (owner: Awight) [18:26:57] (PS2) Ejegg: Back-end logic for Amazon recurring donations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/243360 (https://phabricator.wikimedia.org/T111430) [18:28:06] awight: ah K .... Hmm I was confused... Mmm so just to see if I understand, GatewayAdapter runs the GatewayValidate hook, handled by onValidate(), which calls validate(), which in turn runs the GatewayCustomFilter hook, correct? [18:28:42] yeah, either of those hooks should be good--probably best to go with the GatewayValidate hook [18:28:44] And you think we should queue the association of BHID and contribution_tracking_id from a handler on that last hook [18:28:48] yes [18:29:07] and adapt that payments-antifraud queue code to send to a new queue [18:29:12] (CR) Ejegg: "Looks good! seems to need manual rebase though" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243069 (owner: Awight) [18:29:13] awight: it doesn't matter that this has nothing to do with validation? [18:29:15] with just the BHID and CTID [18:29:21] mmm. that is unfortunate [18:29:39] But we can clean that up later :-/ [18:30:13] I think it has the contract we want, at least--seems to run once per donation, before we make any decisions about whether or not to process [18:31:05] awight: hmmm... K back in a bit, meating... [18:31:08] thanks! [18:31:55] (PS2) Awight: Help text for the impression diet feature [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243069 [18:41:50] (PS1) XenoRyet: Fix JPMorgan Importer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243716 (https://phabricator.wikimedia.org/T113381) [18:51:12] * awight ahems towards ejegg [18:51:20] Recurring? [18:51:34] we need to manage expectations a bit :p [18:55:04] Fundraising-Backlog: Spike: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1703263 (CCogdill_WMF) @awight I don't have any good data to support this. It is hard to make a comparison like this because I either have to compare email behavior with emails that have completel... [19:09:39] (PS1) Cdentinger: Enable setting default payment method [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/243724 (https://phabricator.wikimedia.org/T112946) [19:10:19] (CR) jenkins-bot: [V: -1] Enable setting default payment method [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/243724 (https://phabricator.wikimedia.org/T112946) (owner: Cdentinger) [19:10:45] * Seddon highfives K4-713 [19:11:14] Exploding high-five! [19:11:16] :D [19:11:24] Seddon: How have you been? [19:11:47] K4-713: Very Well :) guess who is back :D [19:11:57] Yeah, I heard about that this morning! [19:12:10] K4-713: Wooop I am famous [19:12:41] Naturally. Hehe, I bet a lot has changed since last time. [19:12:58] There is a degree of sanity you're probably not used to. [19:13:46] I blame atgo-meetings. [19:13:55] so many much meetings! [19:13:57] hi Seddon! [19:14:09] K4-713: ..... hold on I was promised outrageous working hours, stress, fallouts and faulty systems..... I have been brought in under false pretenses :P [19:14:09] K4-713: speaking of which, i'm nearly ready whenever you are [19:14:25] atgo-meetings: Word. I'm in place and eating things. [19:15:01] Fundraising Sprint UB40, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Edits to LYBUNT report - https://phabricator.wikimedia.org/T88819#1703288 (XenoRyet) a:XenoRyet [19:15:25] Seddon: Ah, those were the good ol' days. [19:15:31] Meeeeeeemories.... [19:19:54] ejegg: yow, setting default payment method breaks a lot of assumptions, at least the way i did it in https://gerrit.wikimedia.org/r/243724 [19:20:07] oh yeah? [19:20:18] i bet there's somewhere better to put it that would have fewer side effects [19:20:29] taking a look [19:20:30] but i don't know the lay of the land well enough [19:20:39] thanks [19:21:35] K4-713: looking forward to this year though. Missed it [19:23:17] cwdent: maybe in setGatewayDefaults? [19:24:21] ah, but you want to have it available for setValidForm... [19:25:16] also setGatewayDefaults looks like it's only defined by the child classes, i was thinking it'd be nice to be able to set it donationinterface-wide, but maybe that's not realistic [19:28:04] hmm. i still think setGatewayDefaults would be the right place for it - a gateway might pick a different default method depending on the donor's country, for example [19:30:19] ah ok, i had just imagined it being a config value [19:33:35] if i do getGlobal inside one of the child gateways it'll look for wgChildGateway? [19:34:55] yeah, the gateway-prefixed version always overrides the DonationInterface - prefixed version [19:36:12] cool, thanks [19:41:06] Fundraising-Backlog: Spike: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1703358 (awight) Sounds like a healthy dose of caution about doing non-math stuff with numbers, but maybe you can extrapolate a ballpark estimate out of the existing data? What is the range of cl... [19:42:22] cwdent: What is default payment method for? Is there a use case? [19:43:01] awight: https://phabricator.wikimedia.org/T112946 [19:43:04] Not to try to shut it down... just making sure we're doing a sensible thing wrt UX [19:43:16] That card was... sort of invalid though [19:43:28] sure, i think it just came up because i didn't know how to construct banner urls [19:43:31] right [19:43:39] so i sent out one w/o pm [19:44:08] If it's not a thing that will actually happen, maybe there is higher priority work? [19:44:16] (CR) Ejegg: "Looks like good behavior! Could maybe make doNotTrackEnabled a variable rather than a fn and/or swap the postBannerHandler bailout for ju" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/242946 (owner: AndyRussG) [19:44:42] awight: yeah probably, just sorta following the board, but happy to rearrange at standup [19:46:51] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog, Patch-For-Review: default to credit card (so it doesn't need to be in the url) - worldpay 1 hour test - https://phabricator.wikimedia.org/T112946#1703382 (awight) This might not be required, if it doesn't happen in real wor... [19:48:25] cwdent: ^ hehe invalidated [19:48:56] (Abandoned) Cdentinger: Enable setting default payment method [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/243724 (https://phabricator.wikimedia.org/T112946) (owner: Cdentinger) [19:48:59] and how [19:50:18] Sorry for the context switch, I'm just hoping to lessen the heartbreak a day later :p [19:50:32] Fundraising Sprint Tom Waits, Fundraising-Backlog: Review audit parsing, review whether existing stuff is working. - https://phabricator.wikimedia.org/T112807#1703388 (awight) [19:50:33] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog, Patch-For-Review: default to credit card (so it doesn't need to be in the url) - worldpay 1 hour test - https://phabricator.wikimedia.org/T112946#1703386 (awight) Open>Invalid Not a thing at this point. [19:51:01] nah it was gonna be a drag anyway [19:51:05] it breaks like 15 tests [19:51:16] :D [19:51:24] We can find something else to break even more tests. [19:51:43] * cwdent buckles in [19:53:01] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Implement recurring logic in Amazon gateway adapter - https://phabricator.wikimedia.org/T111430#1703391 (awight) The patches look good so far! *ahemming* a bit about sprintliness, though... [19:54:33] (PS2) Awight: Move some WMF-specific links to settings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/243225 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [19:55:13] Fundraising-Backlog: [EPIC] Worldpay as english backup processor - https://phabricator.wikimedia.org/T114701#1703392 (DStrine) NEW [19:55:20] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Implement recurring logic in Amazon gateway adapter - https://phabricator.wikimedia.org/T111430#1703401 (atgo) @ejegg we had this task already to deal with this (currently "unscheduled") we should decide if this is a priori... [19:59:39] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Implement recurring logic in Amazon gateway adapter - https://phabricator.wikimedia.org/T111430#1703423 (Ejegg) Yeah, I cheated a bit here. I needed to figure out what I could assume about recurring donation gateway IDs in... [20:00:07] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Implement recurring logic in Amazon gateway adapter - https://phabricator.wikimedia.org/T111430#1703428 (awight) Makes sense! Thanks for the lookahead algorithm :) [20:00:43] awight: hi! /me interrupts awight again... Mmm off-topic during my checkin with K4 she suggested that maybe validate isn't the best place to sen the BHID since maybe it doesn't always get called... Also she thought maybe it would be OK just to throw BHID in with donationdata... I don't know the details of the logging issues u mentioned, neway just passing on the comments :) [20:00:52] (CR) Awight: "Hehehe, now you're butchering this repo with the best of em :p" (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/243225 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [20:02:30] (PS1) Eileen: CRM-17176 further fix to navigation reset [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243737 [20:02:32] (PS1) Eileen: CRM-17326 add isset check to timezone retrieval [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243738 [20:02:34] (PS1) Eileen: CRM-17311 wrap call to watchdog in function_exists [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243739 [20:16:13] Fundraising-Backlog: [EPIC] Worldpay as english backup processor - https://phabricator.wikimedia.org/T114701#1703480 (Ppena) For processing Amex, we need to request WP to unblock international cards (after French campaign). * At that time we may decide to either keep AMEX in the French flo... [20:19:13] hey! anyone around? [20:19:29] did any big changes/experiments go live Thursday? [20:19:42] Apparently the mobile site is rendered unusable but it only seems to impact a small subset of users [20:19:48] ^ AndyRussG ? [20:20:21] jdlrobson: :( no nothing went out for CN on Thursday [20:20:28] any banner tests? [20:20:36] jdlrobson: that may be... Which mobile users? [20:20:45] I've got a Welsh and Korean :) [20:21:01] jdlrobson: one sec I'll tell you where the banner with BannerHistory activated is targeting [20:21:02] oh wait might be germany not Wales [20:21:15] also Thai [20:21:27] looking for any kind of lead.. [20:25:40] jdlrobson: this is the only campaign with new code running on it, BannerHistory, is this one: https://meta.wikimedia.org/w/index.php?title=Special:CentralNotice&subaction=noticeDetail¬ice=C15_enWW_ipd_lw_FR [20:26:06] AndyRussG: how can i manually opt into that? [20:26:11] jdlrobson: you can see the countries and languages and wikis targeted... May have to look at the logs for when it BH was enabled [20:26:25] jdlrobson: some extra URL params, one sec [20:27:21] Fundraising-Backlog, Recurring-Donations, Epic: Amazon recurring (Epic) - https://phabricator.wikimedia.org/T107391#1703516 (Ejegg) [20:27:52] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Recurring donation module should be able to charge Amazon recurring donations - https://phabricator.wikimedia.org/T111431#1703519 (Ejegg) [20:27:54] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Implement recurring logic in Amazon gateway adapter - https://phabricator.wikimedia.org/T111430#1703520 (Ejegg) [20:27:57] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Implement Amazon recurring widget client-side - https://phabricator.wikimedia.org/T111428#1703521 (Ejegg) [20:27:59] Fundraising-Backlog, Recurring-Donations, Epic: Amazon recurring (Epic) - https://phabricator.wikimedia.org/T107391#1493759 (Ejegg) [20:29:22] Fundraising Sprint UB40, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, Patch-For-Review: Implement Amazon recurring widget client-side - https://phabricator.wikimedia.org/T111428#1603672 (Ejegg) [20:29:56] Fundraising Sprint UB40, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, Patch-For-Review: Implement recurring logic in Amazon gateway adapter - https://phabricator.wikimedia.org/T111430#1703539 (Ejegg) [20:31:38] jdlrobson: go to https://en.wikipedia.org/wiki/Main_Page?country=IT&device=ipad&randomcampaign=0.1 [20:31:57] jdlrobson: to confirm that you're getting the campaign, in the console you can say mw.centralNotice.data.campaign [20:32:24] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243028 (owner: Eileen) [20:32:33] ah it's ipad only? [20:32:42] in which case i don't think this is to blame [20:33:00] it should respond with the campaign name, "C15_enWW_ipd_lw_FR" [20:33:08] jdlrobson: yep just Ipad [20:33:12] or iPad [20:33:18] or IpaD [20:33:56] AndyRussG: ooh, "randomcampaign": cool! even documented, https://www.mediawiki.org/wiki/Extension:CentralNotice#Overriding_selection [20:34:17] awight: just don't try using camel case, though! [20:34:23] Seriously [20:34:47] Just seemed like camelcase was not a thing in URL param names [20:35:06] (CR) Awight: "Thanks for the cleanup!" [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243028 (owner: Eileen) [20:35:24] jdlrobson: note that you probably won't see a banner right away, I think it has some pageview-counter thing that only shows it after a few pageviews [20:35:39] jdlrobson: lmk if I can help with anything else! [20:35:57] (CR) Eileen: "That was Coleman's suggestions on my upstream PR" [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243028 (owner: Eileen) [20:36:43] awight: didja see my silly comment on this one? [20:36:45] https://gerrit.wikimedia.org/r/#/c/241938/ [20:42:49] pretty amazing: http://dinakelberman.tumblr.com/ [20:44:00] cwdent: water storage? [20:44:43] keep scrolling [20:44:43] AndyRussG: strange, I swear I pushed a new patchset... doing so for real now. [20:47:22] awight: thx! [20:47:32] cwdent: you're trying to drive me insane, right? [20:47:36] (jk) [20:48:13] cwdent: Thanks! way over the line now [20:48:29] hehe np guise [20:51:21] awight: to get latest repo on staging do we just ssh to it & do a git pull? [20:51:22] (PS3) AndyRussG: Do Not Track: Don't even accumulate log or call EL [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/242946 [20:54:16] (CR) AndyRussG: "Thanks! I switched to a variable, but left the handler for DNT users, and in fact changed the handler bow-out so it still will purge old l" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/242946 (owner: AndyRussG) [20:59:20] AndyRussG: AaronSchulz just mentioned something important wrt the db_master patches... There's an implicit transaction around each request, so it's not possible to ever read from slave and see changes made to master during that same request. [20:59:38] Also, he said that we should be guaranteed to see the changes if we read from master. [21:00:03] You can see replag here, https://tendril.wikimedia.org/ [21:00:12] It does spike occasionally, like when... people edit a page. [21:00:28] no big deal, he was just keeping tabs on our fixes to his fix [21:01:09] (PS4) Ejegg: Do Not Track: Don't even accumulate log or call EL [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/242946 (owner: AndyRussG) [21:01:30] (PS4) Awight: Add more banner hide reasons [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241938 (https://phabricator.wikimedia.org/T113813) [21:01:52] (CR) Ejegg: [C: 2] "Cleaning up already-stored data is a nice touch!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/242946 (owner: AndyRussG) [21:03:47] (Merged) jenkins-bot: Do Not Track: Don't even accumulate log or call EL [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/242946 (owner: AndyRussG) [21:04:22] awight: I just tried doing a git pull on staging but hit file permission errors in the git directory [21:05:07] aww [21:05:11] I hate that. [21:05:23] aaarg power failue! [21:05:24] failure! [21:05:28] See how long the phone tethering lasts... [21:05:30] (PS5) Awight: Add more banner hide reasons [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241938 (https://phabricator.wikimedia.org/T113813) [21:13:23] (PS3) Ejegg: Move some WMF-specific links to settings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/243225 (https://phabricator.wikimedia.org/T108699) [21:16:03] (CR) Ejegg: "Addressed escaping, extra language parameter, and CamelCase." (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/243225 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [21:19:39] In 4.6 there is a permission to see the sql output for a report - should I give this to a particular role - e.g in the wmf_civicrm upgrade script - although I’m not sure the roles exist in the there to assign to… [21:31:27] (PS5) AndyRussG: BannerHistoryLogger: ensureLogSent() timeout for users without sendBeacon [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243180 [21:31:28] (CR) jenkins-bot: [V: -1] BannerHistoryLogger: ensureLogSent() timeout for users without sendBeacon [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243180 (owner: AndyRussG) [21:32:49] (CR) Eileen: "why hasn't this merged?" [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242830 (owner: Awight) [21:33:02] (CR) Awight: [C: 2] CRM-17176 further fix to navigation reset [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243737 (owner: Eileen) [21:33:04] (CR) AndyRussG: [C: 2] "Thanks 4 awesome log-diving!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241938 (https://phabricator.wikimedia.org/T113813) (owner: Awight) [21:33:34] (PS6) AndyRussG: BannerHistoryLogger: ensureLogSent() timeout for users without sendBeacon [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243180 [21:33:40] (PS2) Awight: CRM-17176 further fix to navigation reset [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243737 (owner: Eileen) [21:33:48] (PS2) Awight: CRM-17326 add isset check to timezone retrieval [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243738 (owner: Eileen) [21:36:52] (Merged) jenkins-bot: Add more banner hide reasons [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241938 (https://phabricator.wikimedia.org/T113813) (owner: Awight) [21:37:11] (CR) Awight: [C: 2] CRM-17326 add isset check to timezone retrieval [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243738 (owner: Eileen) [21:37:27] (PS2) Awight: CRM-17311 wrap call to watchdog in function_exists [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243739 (owner: Eileen) [21:37:58] (CR) Awight: [C: 2] "Should we error_log otherwise?" [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243739 (owner: Eileen) [21:38:07] (Merged) jenkins-bot: CRM-17176 further fix to navigation reset [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243737 (owner: Eileen) [21:39:51] (Merged) jenkins-bot: CRM-17326 add isset check to timezone retrieval [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243738 (owner: Eileen) [21:40:48] Wikimedia-Fundraising-CiviCRM: Migration to add custom roles and give permissions - https://phabricator.wikimedia.org/T114714#1703728 (awight) NEW [21:40:52] eileen: ^ fyi [21:41:09] :-) [21:41:23] (PS3) Awight: Ensure card selected before clicking 'Donate' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242432 (https://phabricator.wikimedia.org/T114198) (owner: Ejegg) [21:41:35] (CR) Awight: [C: 2] "Fancy! Will require some UX testing" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242432 (https://phabricator.wikimedia.org/T114198) (owner: Ejegg) [21:41:38] (Merged) jenkins-bot: CRM-17311 wrap call to watchdog in function_exists [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243739 (owner: Eileen) [21:41:42] (PS4) Awight: Move some WMF-specific links to settings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/243225 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [21:41:53] (PS3) AndyRussG: ext.centralNotice.display: Expose the names of enabled campaign mixins [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243479 [21:42:28] awight: didja see my relaying of K4 comments ^ about DI BH stuff above? [21:42:54] (CR) Cdentinger: [C: 1] "I had to do the same thing for the Square import file, I wonder if we should generalize this." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243716 (https://phabricator.wikimedia.org/T113381) (owner: XenoRyet) [21:43:34] (CR) Awight: "Much more provincial! I missed how you're dealing with HTML entities now... Mustache does the right thing?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/243225 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [21:44:03] AndyRussG: oops, yeah. It's not good enough to send through the main queue cos we won't get anything from PayPal, for example [21:44:30] I don't know about the claim that GatewayValidate isn't guaranteed to run always, I'd need to poke around more [21:44:41] awight: ahh K.. Rrrg sorry if we've been through that before, yeah I remember 8p [21:44:48] (CR) Ejegg: "Yep, I swapped {{{ }}} for {{ }} to tell it to escape the output" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/243225 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [21:45:21] awight: how about a new hook, like "InitialDonationDataReady" or "DonationDataReady"? [21:45:21] AndyRussG: argh, yeah she's right that the hook is not always called. For example, with PayPal [21:45:28] yurp [21:45:50] (yurp = "I think that's the one she was worried about") [21:46:08] New hook is the right thing to do :( [21:46:17] awight: K gotcha :) [21:46:43] awight: does that sound like the right hook name? I'm not sure if DonationData is further populated after the initial instantiation, I guess it must be [21:47:02] but if I understand correctly, after instantiation we always have a contribution_tracking_id [21:47:35] (CR) Awight: [C: 2] Move some WMF-specific links to settings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/243225 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [21:47:40] (PS4) Awight: Ensure card selected before clicking 'Donate' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242432 (https://phabricator.wikimedia.org/T114198) (owner: Ejegg) [21:48:14] (PS2) XenoRyet: Fix JPMorgan Importer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243716 (https://phabricator.wikimedia.org/T113381) [21:48:39] (PS7) AndyRussG: BannerHistoryLogger: ensureLogSent() timeout for users without sendBeacon [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243180 [21:49:34] (CR) Cdentinger: [V: 2] Fix JPMorgan Importer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243716 (https://phabricator.wikimedia.org/T113381) (owner: XenoRyet) [21:50:18] ejegg: cwdent: XenoRyet: awight: new hook for DI, in which to send BHID: "DonationDataInstantiated"? "DonationDataReady"? "InitialDonationData"? Something else? [21:50:34] (I could be completely off here) [21:51:16] (PS4) AndyRussG: ext.centralNotice.display: Expose the names of enabled campaign mixins [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243479 [21:51:24] cwdent: Thanks. We probably should generalize that one of these days. Maybe when the next importer requires it. [21:51:28] AndyRussG: lessee, maybe stick with the "Gateway" theme so we're not overly coupled to implementation [21:51:57] Hmmm K, Gateway what then? And ideal place to run it? [21:52:04] XenoRyet: yeah, we could come up with a set of filters [21:52:28] lord knows php type juggling ends with regex [21:52:57] (Merged) jenkins-bot: Move some WMF-specific links to settings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/243225 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [21:53:03] (CR) AndyRussG: "Thanks!!!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/242946 (owner: AndyRussG) [21:53:46] AndyRussG: "GatewayReady", at the end of what's currently __construct, you agree? [21:54:04] I'd like to move all that crap out of the constructor, but... another day [21:54:56] cwdent: CR+2 -- I think u only V+@ [21:54:56] 2 [21:54:57] 'd [21:54:58] awight: sounds sweet! I'll wade through that code some more and LYK if I finde issues [21:55:18] Thanks again! [21:55:33] Those V radio buttons are too close to the CR ones, I did that the other day too. [21:55:49] (PS2) Awight: Add 'recurring' switch to mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/243358 (https://phabricator.wikimedia.org/T111428) (owner: Ejegg) [21:56:06] (CR) Cdentinger: [C: 2] "v+2 != CR" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243716 (https://phabricator.wikimedia.org/T113381) (owner: XenoRyet) [21:56:15] derp [21:57:02] (Merged) jenkins-bot: Fix JPMorgan Importer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243716 (https://phabricator.wikimedia.org/T113381) (owner: XenoRyet) [21:57:16] (CR) Awight: [C: 2] "What could go wrong ;)" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/243358 (https://phabricator.wikimedia.org/T111428) (owner: Ejegg) [21:57:41] (Merged) jenkins-bot: Ensure card selected before clicking 'Donate' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242432 (https://phabricator.wikimedia.org/T114198) (owner: Ejegg) [21:57:54] (PS8) Awight: BannerHistoryLogger: ensureLogSent() timeout for users without sendBeacon [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243180 (owner: AndyRussG) [21:58:28] (CR) Ejegg: Add 'recurring' switch to mustache forms (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/243358 (https://phabricator.wikimedia.org/T111428) (owner: Ejegg) [22:03:00] (CR) Awight: [C: -1] "Great, except the POST?" (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243180 (owner: AndyRussG) [22:03:08] (PS5) Awight: ext.centralNotice.display: Expose the names of enabled campaign mixins [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243479 (owner: AndyRussG) [22:04:09] (CR) Awight: [C: 2] ext.centralNotice.display: Expose the names of enabled campaign mixins [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243479 (owner: AndyRussG) [22:06:17] (CR) Cdentinger: [C: 2] Add Direct Mail Appeal column to Trilogy Importer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243042 (https://phabricator.wikimedia.org/T114155) (owner: XenoRyet) [22:06:58] (CR) Awight: [C: -1] "Thanks for working on this! Is it possible to regenerate that composer.lock with --no-dev, or does that hose the tests?" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/243173 (https://phabricator.wikimedia.org/T104264) (owner: Hashar) [22:07:01] (Merged) jenkins-bot: Add Direct Mail Appeal column to Trilogy Importer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243042 (https://phabricator.wikimedia.org/T114155) (owner: XenoRyet) [22:08:15] (CR) Awight: [C: 2] "Funky! Is it necessary to include the tests/ CI glue?" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/243134 (https://phabricator.wikimedia.org/T114470) (owner: Hashar) [22:08:17] (Merged) jenkins-bot: Rough YAML linter for *.yaml.example files [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/243134 (https://phabricator.wikimedia.org/T114470) (owner: Hashar) [22:12:49] (CR) Awight: "+1 for pushing the amount cleanup to the base class" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243716 (https://phabricator.wikimedia.org/T113381) (owner: XenoRyet) [22:12:59] (CR) AndyRussG: BannerHistoryLogger: ensureLogSent() timeout for users without sendBeacon (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243180 (owner: AndyRussG) [22:13:40] ejegg, awight this thing get jammed up somehow? https://gerrit.wikimedia.org/r/#/c/243358/ [22:13:48] Yay EL! [22:13:54] (CR) Awight: [C: 2] Add 'recurring' switch to mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/243358 (https://phabricator.wikimedia.org/T111428) (owner: Ejegg) [22:14:03] * awight hammers with a pillow [22:14:18] huh [22:14:20] did ejegg's comment slip in before the bot or something? [22:14:20] (Merged) jenkins-bot: Add 'recurring' switch to mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/243358 (https://phabricator.wikimedia.org/T111428) (owner: Ejegg) [22:14:21] That'll be $200 [22:14:23] thanks! [22:14:47] I'll get it to you next time i pass 'GO' [22:15:11] (PS2) Awight: Add Amazon recurring widget and front-end logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/243359 (https://phabricator.wikimedia.org/T111428) (owner: Ejegg) [22:15:15] (CR) Awight: [C: 2] Add Amazon recurring widget and front-end logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/243359 (https://phabricator.wikimedia.org/T111428) (owner: Ejegg) [22:15:23] (PS3) Awight: Back-end logic for Amazon recurring donations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/243360 (https://phabricator.wikimedia.org/T111430) (owner: Ejegg) [22:15:44] (Merged) jenkins-bot: Add Amazon recurring widget and front-end logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/243359 (https://phabricator.wikimedia.org/T111428) (owner: Ejegg) [22:15:45] The best part is if you have to pull out a nail that you hammered with a pillow... with the back end of the pillow [22:15:51] heh [22:16:22] Welcome David Lynch [22:16:24] * cwdent freaks out [22:16:51] Is he visiting Colorado? [22:17:43] Aw, atgo is gone. [22:17:52] * K4-713 looks sad [22:18:00] AndyRussG: we just hired a guy named that [22:18:11] * K4-713 squints [22:18:21] AndyRussG: :D /me refrains from making any jokes about other types of fastener [22:18:31] don't do it! [22:19:02] cool! [22:21:23] What's the rule for DI filename case? [22:21:36] * K4-713 giggles [22:21:47] It has to be really crazy [22:21:51] AndyRussG: Depends on what day of the week it is. [22:21:55] FAQURL is a good example :p [22:22:07] Don't forget to figure in phase of the moon, and if it's... a parent class or not. [22:22:38] Though, there are different answers if it descends from a mediawiki class, or if it's one of ours. [22:22:50] * K4-713 slaps self repeatedly [22:22:55] different by design? [22:23:03] noo don't do that! 8p [22:23:14] If I don't somebody else will. And I can't really argue. [22:23:30] Um, the prevailing thing is straight caml case LikeThat.php and try not to inherit from... anything ;) [22:24:09] I aways thought you should do all lowercase with dots between words, but only if you feel especially fancy today. [22:24:28] ...I'm not helping, am I? [22:24:28] * awight jams snuff up nose [22:24:59] :-) [22:25:03] Feel fancy and/or hostile toward not-linux-based systems. [22:25:12] Maybe both. [22:25:36] Actually, wait. That's kind of the same thing. [22:26:13] (PS3) Awight: Log upgrade steps [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242821 (https://phabricator.wikimedia.org/T99842) [22:27:11] (CR) Awight: "@eileen: I agree it should be on civi-4.6.9, will abandon this patch if it's ok?" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/242820 (https://phabricator.wikimedia.org/T99842) (owner: Awight) [22:28:10] (CR) Eileen: "Yeah - I've done a PR upstream too" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/242820 (https://phabricator.wikimedia.org/T99842) (owner: Awight) [22:29:27] (Abandoned) Awight: Log upgrade steps [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/242820 (https://phabricator.wikimedia.org/T99842) (owner: Awight) [22:33:16] i'm going to take the dog for a walk, back later [22:34:59] awight: K4-713: hmmm.... K, I'll go w/ my gut and add a "banner_history" subdirectory of "extras" and create a file called "BannerHistoryLogIdProcessor", or something similar [22:35:23] containing a class of the same name [22:35:27] because. [22:42:28] AndyRussG: excellent_thanks :) [22:48:09] heheh [22:49:00] AndyRussG: Yep, that checks out. :p [22:49:15] atgo: Was this intentional? https://phabricator.wikimedia.org/T114701#1703482 [22:49:27] it was a whole thing [22:49:29] Maybe it was about PPena's deleted comment? [22:49:30] k [22:49:37] updated [22:49:38] Fundraising-Backlog: [EPIC] Worldpay as english backup processor - https://phabricator.wikimedia.org/T114701#1703900 (atgo) [22:49:40] yeah i asked her to delete [22:49:51] now we're back [22:50:53] Fundraising-Backlog: [EPIC] Worldpay as english backup processor - https://phabricator.wikimedia.org/T114701#1703909 (awight) [22:50:54] Fundraising-Backlog, Easy: TransDetVer2 audit parsing is broken - https://phabricator.wikimedia.org/T113787#1703910 (awight) [22:50:58] atgo: ! [22:51:12] ? [22:51:12] Fundraising-Backlog: [EPIC] Worldpay as english backup processor - https://phabricator.wikimedia.org/T114701#1703392 (awight) [22:51:13] atgo: Did you by any chance register to go to the dev summit? [22:51:13] Fundraising-Backlog, Patch-For-Review: Unbreak WMF-hosted Worldpay workflow - https://phabricator.wikimedia.org/T112665#1703912 (awight) [22:51:18] K4-713: oui [22:51:23] atgo: Groovy! [22:51:25] That's all. [22:51:26] Fundraising-Backlog, Patch-For-Review: Unbreak WMF-hosted Worldpay workflow - https://phabricator.wikimedia.org/T112665#1641838 (awight) [22:51:38] awight: Do you have a second for some irl? I have a Confused. [22:52:03] K4-713: yeah all of Reading is going :) [22:52:08] Fundraising-Backlog: Only block French cards on France form. - https://phabricator.wikimedia.org/T113789#1703916 (awight) [22:52:09] woot [22:59:28] atgo: it's like midnight there right? [22:59:35] yes [22:59:46] * dstrine wonders what atgo is doing working [23:01:16] this is how i do when working in europe [23:01:23] better to be online when you cats are [23:26:45] K4-713: awight: cool thanks [23:32:29] Wikimedia-Fundraising, Continuous-Integration-Infrastructure, Patch-For-Review: Add YAML lint test in wikimedia/fundraising/tools to remove the Jenkins job 'yamllint' - https://phabricator.wikimedia.org/T114470#1704097 (jayvdb) Open>Resolved a:hashar [23:56:53] (PS1) Eileen: Add gitreview to CiviCRM 4.6 branch [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243839 [23:56:57] (CR) jenkins-bot: [V: -1] Add gitreview to CiviCRM 4.6 branch [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243839 (owner: Eileen) [23:58:40] (Abandoned) Eileen: Add gitreview to CiviCRM 4.6 branch [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243839 (owner: Eileen)