[00:04:14] (PS2) Ejegg: Associate refunds with parent transactions [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244000 (https://phabricator.wikimedia.org/T111425) [00:15:32] http://www.theguardian.com/artanddesign/2015/oct/06/renoir-sucks-at-painting-protest-boston-max-geller [00:15:51] hehe. good stuff [00:16:30] that blog has some funny comments on his more atrocious works [00:18:09] ok, have a good evening all! [00:37:01] (PS4) Ejegg: WIP Amazon audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242644 (https://phabricator.wikimedia.org/T111425) [03:00:08] (PS1) AndyRussG: Add banner history log ID processor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 [05:22:31] (PS2) Awight: Add banner history log ID processor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (owner: AndyRussG) [05:23:21] (CR) jenkins-bot: [V: -1] Add banner history log ID processor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (owner: AndyRussG) [05:23:45] Blocked-on-Fundraising-Tech, Wikimedia-Fundraising, HTTPS: links.email.donate.wikimedia.org should offer HTTPS - https://phabricator.wikimedia.org/T74514#1707841 (Nemo_bis) I guess T114010 is now the blocker, when it's resolved this bug can be fixed. [05:25:13] Fundraising-Backlog: Spike: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1682291 (Nemo_bis) [05:25:14] Blocked-on-Fundraising-Tech, Wikimedia-Fundraising, HTTPS: links.email.donate.wikimedia.org should offer HTTPS - https://phabricator.wikimedia.org/T74514#1707845 (Nemo_bis) [05:26:40] Blocked-on-Fundraising-Tech, Wikimedia-Fundraising, HTTPS: links.email.donate.wikimedia.org should offer HTTPS - https://phabricator.wikimedia.org/T74514#758165 (Nemo_bis) [05:30:42] Fundraising-Backlog: Spike: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1707854 (Nemo_bis) > we had to change the link domain which tracks email clicks to links.wikimedia.mkt4477.com. It's not ideal, and donors are already starting to notice An Italian donor wrote to... [05:31:40] (CR) Eileen: Civi46 set contact_default_language on upgrade (1 comment) [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243874 (https://phabricator.wikimedia.org/T99836) (owner: Eileen) [05:35:39] (CR) Awight: [C: 2] "Nice work learning all of DonationInterface's gluey boilerplate, already." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (owner: AndyRussG) [05:36:16] (CR) jenkins-bot: [V: -1] Add banner history log ID processor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (owner: AndyRussG) [06:02:35] (CR) Awight: [C: -1] "A few minor things to clean up, and a blocker I overlooked on the first pass, sorry!" (7 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (owner: AndyRussG) [06:08:16] (PS1) Awight: Don't assume that gateway and gateway_txn_id fields will be present [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244118 [06:09:10] (CR) Awight: "Grab Ic6f2407751bf0f to avoid e_strict warnings about missing fields..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (owner: AndyRussG) [06:16:11] (CR) Awight: Add banner history log ID processor (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (owner: AndyRussG) [09:34:54] TCB-Team-Fundraising-Sprint-2015-10-07: [WMDE-Fundraising] Bug: Paypal donations are missing data in the "backend" module - https://phabricator.wikimedia.org/T114864#1708142 (WMDE-leszek) NEW [11:04:31] TCB-Team-Fundraising-Sprint-2015-09-30, TCB-Team: [WMDE-Fundraising] Add show and hide mechanisms to the banner - https://phabricator.wikimedia.org/T112056#1708290 (WMDE-Fisch) a:WMDE-Fisch [11:10:27] TCB-Team-Fundraising-Sprint-2015-09-30, TCB-Team-Fundraising-Sprint-2015-10-07, TCB-Team: [WMDE-Fundraising] Create HTML contents of the banner with regard on having magic values filled by CN - https://phabricator.wikimedia.org/T112055#1708312 (Tobi_WMDE_SW) [11:10:33] TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team-Fundraising-Sprint-2015-09-30, TCB-Team-Fundraising-Sprint-2015-10-07, TCB-Team: [WMDE-Fundraising] Plan for automated code updates and configuration changes for deployment - https://phabricator.wikimedia.org/T113466#1708313 (Tobi_WMDE_SW) [11:10:39] TCB-Team-Fundraising-Sprint-2015-09-30, TCB-Team-Fundraising-Sprint-2015-10-07, TCB-Team: [WMDE-Fundraising] Add form validation to the sensitive banner - https://phabricator.wikimedia.org/T112057#1708314 (Tobi_WMDE_SW) [11:11:12] TCB-Team-Fundraising-Sprint-2015-10-07, TCB-Team: [WMDE-Fundraising] Fix script for purging personal data from the database - https://phabricator.wikimedia.org/T114874#1708320 (kai.nissen) NEW [11:14:39] TCB-Team-Fundraising-Sprint-2015-10-07, TCB-Team: [WMDE-Fundraising] Bug: Paypal donations are missing data in the "backend" module: restore the data - https://phabricator.wikimedia.org/T114864#1708331 (Tobi_WMDE_SW) p:Triage>High [11:15:26] TCB-Team-Fundraising-Sprint-2015-10-07, TCB-Team: [WMDE-Fundraising] Fix the backend code - https://phabricator.wikimedia.org/T114875#1708337 (Tobi_WMDE_SW) NEW [11:15:46] TCB-Team-Fundraising-Sprint-2015-10-07, TCB-Team: [WMDE-Fundraising] Fix the backend code - https://phabricator.wikimedia.org/T114875#1708337 (Tobi_WMDE_SW) [11:16:29] TCB-Team-Fundraising-Sprint-2015-10-07, TCB-Team: [WMDE-Fundraising] Bug: Paypal donations are missing data in the "backend" module: restore the data - https://phabricator.wikimedia.org/T114864#1708142 (Tobi_WMDE_SW) p:High>Normal [11:33:21] TCB-Team-Fundraising-Sprint-2015-10-07, TCB-Team: [WMDE-Fundraising] Fix script for purging personal data from the database - https://phabricator.wikimedia.org/T114874#1708405 (kai.nissen) [11:34:15] TCB-Team-Fundraising-Sprint-2015-09-30, TCB-Team-Fundraising-Sprint-2015-10-07, TCB-Team: [WMDE-Fundraising] Add show and hide mechanisms to the banner - https://phabricator.wikimedia.org/T112056#1708412 (WMDE-Fisch) [11:34:37] TCB-Team-Fundraising-Sprint-2015-09-30, TCB-Team-Fundraising-Sprint-2015-10-07, TCB-Team: [WMDE-Fundraising] Create a test banner/campaign on CentralNotice - https://phabricator.wikimedia.org/T112054#1708422 (kai.nissen) [12:03:24] TCB-Team-Fundraising-Sprint-2015-10-07, TCB-Team: [WMDE-Fundraising] Fix the backend code to don't miss paypal donations - https://phabricator.wikimedia.org/T114875#1708473 (Tobi_WMDE_SW) [12:03:52] TCB-Team-Fundraising-Sprint-2015-10-07, TCB-Team: [WMDE-Fundraising] Deploy the backend fix to not miss paypal donations anymore - https://phabricator.wikimedia.org/T114875#1708337 (Tobi_WMDE_SW) [12:04:01] TCB-Team-Fundraising-Sprint-2015-10-07, TCB-Team: [WMDE-Fundraising] Deploy the backend fix to not miss paypal donations anymore - https://phabricator.wikimedia.org/T114875#1708337 (Tobi_WMDE_SW) a:kai.nissen [12:31:54] (CR) Hashar: "recheck" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/243173 (https://phabricator.wikimedia.org/T104264) (owner: Hashar) [12:32:51] Fundraising Tech Backlog, Fundraising-Backlog, Continuous-Integration-Config, Patch-For-Review: Enable PHPUnit testing on the wikimedia/fundraising/SmashPig repo - https://phabricator.wikimedia.org/T104264#1708519 (hashar) Open>Resolved Seems all fine :-} [13:06:03] TCB-Team-Fundraising-Sprint-2015-09-30, TCB-Team-Fundraising-Sprint-2015-10-07, TCB-Team: [WMDE-Fundraising] Add form validation to the sensitive banner - https://phabricator.wikimedia.org/T112057#1708603 (WMDE-leszek) Relevant pull request on github: https://github.com/wmde/fundraising/pull/723 [14:48:18] (PS1) Awight: Allow "include" tag in Twig templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244163 [14:52:27] (PS2) Awight: Remove recurring clause from Bengali thank-you letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244163 [14:52:29] (PS1) Awight: Remove unused recurring info template partial [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244166 [14:54:51] (CR) Ejegg: [C: 2] Don't assume that gateway and gateway_txn_id fields will be present [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244118 (owner: Awight) [14:55:23] (Merged) jenkins-bot: Don't assume that gateway and gateway_txn_id fields will be present [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244118 (owner: Awight) [15:00:14] (CR) Ejegg: "Maybe leave a placeholder comment reminding us the recurring phrase is missing in this translation?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244163 (owner: Awight) [15:50:17] ejegg: am i right thinking wmf_audit is for manually importing into civi and the stuff in smashpig is the jenkins jobs and they don't really have anything else to do with each other? [15:52:08] cwdent: no, why would we make it that simple? [15:52:29] Jenkins runs a drush script defined in wmf_audit [15:52:31] hehe [15:52:45] aah, parse-audit? [15:52:51] yep [15:53:13] it takes a gateway name and instantiates the appropriate AuditProcessor class (again defined in wmf_audit) [15:53:39] then calls get_audit_parser on that class [15:53:54] get_audit_parser instantiates a class defined in SmashPig [15:54:32] and the ones in smashpig define the formats? [15:55:01] yeah, the classes in smashpig basically just parse the files [15:55:35] then the AuditProcessor classes in wmf normalize the parsed data, [15:56:06] ok gotcha, so i should hopefully just need a modified version of one of the WP files in smashpig [15:56:07] find any missing info in the payments cluster logs [15:56:18] check for duplicates [15:56:28] and feed the stuff right into civi [15:56:36] cwdent: yeah, sounds right [15:56:51] great [15:57:01] so here's the other thing i'm wondering, they sent xls [15:57:17] i see one csv and one fixed-length filetype in smashpig for wp [15:57:21] ah, right, I'm not sure what lib we're using for that [15:58:46] i wonder if we'll want to convert it or parse as xls or ask them to send something different [15:59:35] hmm, i dunno [16:00:07] if we want to convert it, we could either do that in php in smashpig, or do it in python at the end of the downloader script [16:03:52] i'm guessing the format and layout will randomly change a few times [16:12:55] hey ejegg, can I ask you an Amazon question? [16:17:46] sure MBeat, what's up? [16:38:47] Fundraising Sprint UB40, Fundraising-Backlog: EXTERNAL: Worldpay Audit file - https://phabricator.wikimedia.org/T114676#1709307 (cwdent) Formal update: they stopped sending them because of the merchant ID switch. We can get the WPG audit files delivered via SFTP as normal, and in several common formats,... [16:51:25] (CR) Ejegg: [C: -1] "Don't merge yet - I'm going to move the mock classes into the SDK" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244000 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [16:57:32] (PS3) AndyRussG: Add banner history log ID processor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 [16:58:19] (CR) jenkins-bot: [V: -1] Add banner history log ID processor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (owner: AndyRussG) [17:10:12] Fundraising-Backlog: Out of date donation page still active (and possibly an audit of all available donation pages and inbound links?) - https://phabricator.wikimedia.org/T114910#1709423 (CaitVirtue) NEW [17:28:44] any scrum of scrums news or requests, AndyRussG / cwdent / XenoRyet / K4-713 ? [17:28:44] Na, nothing from me. [17:28:44] all good here! [17:28:44] Hey ejegg, nah nothing substantial here :) thanks 4 asking! [17:28:44] ok, cool [17:28:44] ejegg: hmm. Not that I know of. Unless you want to remind people that we're in Q2 and please poke us directly if they're going to do anything that might have an effect on, say, CentralNotice for the next few months. [17:28:57] Ah, worth mentioning! [17:28:59] K4-713: ya good point :) [17:29:14] ejegg: dunno if you're planning already to mention it, but BH was enabled on a live campaign this week... [17:29:16] There's going to be an email about that in a bit, but not today because it hasn't been written yet. :) [17:29:34] ok, i'll mention banner history too [17:29:44] ejegg: cool! I mean, if you think it's appropriate :) [17:29:54] Totally. [17:30:04] ejegg: SoS is just the other engineering teams right? [17:30:08] I think we should err on the side of oversharing on those things. [17:30:12] cwdent: yeah [17:30:16] I feel a songe-mail coming on! [17:30:29] *music swells* [17:30:40] *cut to somebody typing quietly* [17:31:26] Can you write a codefreeze e-mail to be sung to the tune of "Let it go" (Frozen) ? [17:31:44] OK, I mean, I know you can, I mean, do you want to? [17:31:48] :D [17:32:23] Code never bothered me anyway? [17:36:31] hahaha [17:36:31] I'm thinking way too hard about what the lyrics should be now. [17:36:34] What does it mean for gateway adapter to stage and unstage data? Also, is the normal way to get data out of a GatewayAdapter just to add a get method specifically for the kind of data you want? I see very few accesses to DonationData outside GatewayAdapter [17:36:42] Ah. [17:36:49] * K4-713 clears throat [17:36:50] I could add getContributionTrackingId() [17:37:15] Staging is the process of taking our normalized data, and preparing it to go out to a 3rd party. [17:37:30] ...wait 1, brb [17:37:34] Ah makes sense [17:39:09] Fundraising-Backlog: Out of date donation page still active (and possibly an audit of all available donation pages and inbound links?) - https://phabricator.wikimedia.org/T114910#1709569 (CaitVirtue) [17:50:26] (CR) Awight: "@ejegg: on second thought, this isn't the source. The wiki page is the master, and this was the old letter, so all the placeholders are i" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244163 (owner: Awight) [17:50:28] K4-713: wrt my specific question ^ 'bout how to get data, I see now the doc sez use getData_Unstaged_Escaped [17:50:30] ejegg: bump ^ [17:50:31] () [17:51:19] awight: sorry, didn't realize the urgency of that update... [17:51:34] meh, it's fine, just some low-level campaigns [17:51:41] (CR) Ejegg: [C: 2] Remove recurring clause from Bengali thank-you letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244163 (owner: Awight) [17:52:07] (CR) Ejegg: [C: 2] Remove unused recurring info template partial [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244166 (owner: Awight) [17:53:00] XenoRyet: is it cool to deploy: [17:53:00] + 22c0e8553a6fc444c0349332020595dcd03b3c7c Add Direct Mail Appeal column to Trilogy Importer [17:53:13] Yea, totally cool. [17:53:40] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/244218 [17:54:25] weird, I got disconnect mid-paste [17:54:41] + 8fc9f90a5c7955d1f5dd1ad664fc620459cf20cd Fix JPMorgan Importer [17:54:44] will also go out [17:54:59] (CR) Awight: [C: 2 V: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/244218 (owner: Awight) [17:55:09] Yea, that one is ready too. [17:55:18] Eagerly awaited I've heard. [17:55:24] great! [17:55:57] + 8fc9f90a5c7955d1f5dd1ad664fc620459cf20cd Fix JPMorgan Importer [17:55:57] ? [17:56:04] !log update fundraising crm from 7003cc38797848631d0c4d5f6ff68ab1d6118ad8 to f25fbe856b92373104985185db77311ea3a4d841 [17:56:09] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:56:22] (CR) Ejegg: [C: -1] "Don't merge yet, going to update SDK again and download refund reports too - they have the parent capture IDs and can save us a bunch of A" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/243213 (https://phabricator.wikimedia.org/T109654) (owner: Ejegg) [17:59:22] build fixed [17:59:24] nice awight [17:59:45] i am heading out for a bit but can we talk about this in the afternoon? https://phabricator.wikimedia.org/T114676 [18:00:06] cwdent: mos definitely [18:00:23] hoo-ray [18:00:29] talk to you in a bit [18:10:03] (PS4) AndyRussG: WIP Add banner history log ID processor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 [18:10:44] (CR) jenkins-bot: [V: -1] WIP Add banner history log ID processor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (owner: AndyRussG) [18:10:52] (CR) AndyRussG: "Thanks!!!! :)" (8 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (owner: AndyRussG) [18:12:45] (CR) Awight: WIP Add banner history log ID processor (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (owner: AndyRussG) [18:13:59] awight: I actually have no evidence the DI patch is working yet, other than no obvious errors... Should have put WIP on the first version... [18:15:29] (CR) Awight: [C: 1] "Done and done!" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (owner: AndyRussG) [18:16:37] CI errors can't possibly be related to your patch... not good. [18:23:18] Fundraising Sprint UB40, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Prepare queue messages for testing on upgraded Civi. Test them. - https://phabricator.wikimedia.org/T114466#1709757 (awight) [18:23:48] (CR) Awight: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (owner: AndyRussG) [18:24:30] Hmm wasn't sure... [18:25:47] (PS3) Awight: TODO Less special-casing in DataValidator [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200096 [18:26:08] AndyRussG: Yow. That took way longer than 1. [18:26:16] Er, did you get everything answered? [18:26:27] Staging is for Them. Normalization is for Us. [18:26:28] K4-713: np! You didn't give any units, so, no error messages [18:26:34] hehe [18:26:52] I think all IRC is in a try block anyway :) [18:27:27] K4-713: yeah got it! So, unstaging is converting from the processor's format to ours, for a message coming from the processor, I imagine... [18:27:48] Yeah solved the specific doubt about how to finagle the data from the adapter [18:28:04] s/doubt/question/ [18:29:27] AndyRussG: yep, exactly what unstaging is. The name bothers me, cos it's not the inverse of staging... but it eventually makes sense if you let it settle long enough [18:29:39] * AndyRussG jiggles brain [18:30:47] Heh it all depends on how you play the metaphor [18:30:48] s [18:31:29] ah. I hadn't thought about the theater analogy [18:31:34] yep. [18:34:14] I used to think of it as a pipeline, with the data moving sequentially from raw to normalized, to staged and then unstaged, but once you think about multiple API calls, that starts to fall apart. [18:34:36] The bulk of the normalized data is not actually transmitted over most API calls [18:38:42] Yeah! I imagine as such [18:39:17] Rrrrg dunno if it's better to have "let it go" or visions of refactored DI code runing involuntarily through my brain.... [18:39:37] s/visions/fantasies/ [18:42:52] Anything that touches donation data can be thought of as a transformation function, (transformation_name, normalized_donation_data, inputs specific to the transformation) -> (normalized_donation_data', outputs specific to the transformation) [18:43:40] Currently we keep the outputs in stagedData, but I would question the usefulness of keeping it around after sending it off to the vendor. [18:44:03] Same with unstaged data, once we consume it, we probably want to throw it out. [18:45:27] I imagine a class for each transformation, then a way to compose transformations as a super-transformation [18:46:23] We could have reusable pieces like, address transformation, and subclass of address transformation to be used in some wacky country or processor dialect. [18:46:56] if the country matches, aggregate_transformation += wacky_country_xform [18:49:26] We should start a refactor 2016: https://www.mediawiki.org/wiki/Extension:DonationInterface/Refactor_2015 [18:52:26] But as far as getData_Unstaged_Escaped goes... I'd rather say $adapter->getData()->field [18:52:45] In fact, we should only ever "get normalized data [18:52:48] "get" [18:55:04] "Escaped" isn't even a thing here, AFAIK [18:55:30] Yikes. I keep falling in holes today. [18:56:24] ... just like it says in the docstring for getData_Unstaged_Escaped: "This is the ONLY getData type function anything should be using...." [18:56:37] but with a shorter name, like "->" [18:57:14] It would be cool to have getData() return an object, anyway [18:57:23] We changed the escaping strategy once. [18:57:28] K4-713: Hunting wabbits? [18:57:38] Well, it is wabbit season. [18:58:14] If I ever get a forehead tattoo, it's going to be "Wabbit Season" in gothic block letters. [18:58:24] I'm still thrilled that there was ever so briefly a town issuing drone hunting permits. Let's bring that back as a boutique, pay-to-slay private unnature reserve. [18:58:43] I would not eff with you in that cell block. [18:59:00] You and the guy with "redruM" [18:59:38] * K4-713 nods [19:00:06] Яebrum [19:02:39] Everyone: Can you update the https://www.mediawiki.org/wiki/Fundraising_tech/Training matrix? VisualEditor is great at tables. [19:04:57] I /think/ i'm up to date there. checking [19:05:12] AndyRussG: cwdent|afk: XenoRyet: when u get a chance ^^. This is good to know as we pile up nuts for winter. [19:05:15] Thanks! [19:05:23] Yea, will do. [19:05:32] awight: k! [19:05:36] Oh yeah, I see lots of activity! Cool. [19:07:11] Looks like we need to add a few rows [19:50:15] (PS1) Ejegg: Update Amazon SDK fork [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/244259 [19:50:37] (CR) Ejegg: [C: 2 V: 2] Update Amazon SDK fork [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/244259 (owner: Ejegg) [19:52:47] (PS2) Ejegg: Update SDK, use new GetReportList parameters [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/243213 (https://phabricator.wikimedia.org/T109654) [19:53:33] (PS3) Ejegg: Update SDK, use new GetReportList parameters [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/243213 (https://phabricator.wikimedia.org/T109654) [19:55:03] (PS2) Ejegg: Make SDK classes mockable [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/243998 [19:58:54] (PS3) Ejegg: Make SDK classes mockable [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/243998 [19:59:29] (PS3) Ejegg: Associate refunds with parent transactions [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244000 (https://phabricator.wikimedia.org/T111425) [20:00:44] (PS1) Ejegg: Audit parser: fees are listed as negative [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244290 (https://phabricator.wikimedia.org/T111425) [20:07:38] how come there is no base class for the reconciliation files in smashpig? [20:10:53] (PS1) Ejegg: Update Amazon SDK fork [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/244329 [20:12:52] (CR) Ejegg: [C: 2 V: 2] Update Amazon SDK fork [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/244329 (owner: Ejegg) [20:15:35] (PS4) Ejegg: Update SDK, use new GetReportList parameters [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/243213 (https://phabricator.wikimedia.org/T109654) [20:15:57] (PS4) Ejegg: Make SDK classes mockable [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/243998 [20:16:13] (PS4) Ejegg: Associate refunds with parent transactions [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244000 (https://phabricator.wikimedia.org/T111425) [20:19:06] (PS5) Ejegg: Associate refunds with parent transactions [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244000 (https://phabricator.wikimedia.org/T111425) [20:19:19] (CR) jenkins-bot: [V: -1] Associate refunds with parent transactions [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244000 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [20:21:35] (PS5) Ejegg: Update SDK, use new GetReportList parameters [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/243213 (https://phabricator.wikimedia.org/T109654) [20:21:46] (PS5) Ejegg: Make SDK classes mockable [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/243998 [20:21:56] (PS6) Ejegg: Associate refunds with parent transactions [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244000 (https://phabricator.wikimedia.org/T111425) [20:24:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM: Persist query criteria and make it possible for other users to see your search results by permalink - https://phabricator.wikimedia.org/T114946#1710199 (awight) NEW [20:25:23] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM: Persist query criteria and make it possible for other users to see your search's results by permalink - https://phabricator.wikimedia.org/T114946#1710209 (awight) [21:13:38] ejegg: You know anything about those Amazon msgs missing a gateway_txn_id? [21:14:54] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM: Persist query criteria and make it possible for other users to see your search's results by permalink - https://phabricator.wikimedia.org/T114946#1710422 (Eileenmcnaughton) QFKey is a session cookie - so not seeing others results is baked in &... [21:16:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM: Persist query criteria and make it possible for other users to see your search's results by permalink - https://phabricator.wikimedia.org/T114946#1710428 (awight) Ah ha. A side question--why include the session cookie in the URL if cookies are... [21:27:20] awight: ooh, that sounds bad. Looking [21:27:30] It's very infrequent. [21:27:45] oh, missing "currency" too. [21:28:32] awight: aah, i'm sending refunds down the wrong queue [21:29:16] ooh [21:29:21] right that would do it [21:29:36] Good thing the fields aren't normalized :D [21:29:44] hah [21:30:02] * awight makes that task while it's on my mind [21:32:48] awight: oh huh, we don't even have a refund queue configured for SmashPig [21:33:53] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface: Formalize message type for all donation queue wire formats - https://phabricator.wikimedia.org/T114955#1710492 (awight) NEW [21:37:18] (PS1) Ejegg: Send Amazon refunds down the refund queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244357 [21:39:20] Fundraising-Backlog: Legacy PayPal IPN listener should syslog - https://phabricator.wikimedia.org/T113386#1710534 (atgo) Does this need to happen urgently? We're going to be reworking PayPal in Q3 - ok to leave until then? [21:39:58] Fundraising-Backlog, Easy: WPUS: TransDetVer2 audit parsing is broken - https://phabricator.wikimedia.org/T113787#1710538 (atgo) [21:42:10] Fundraising-Backlog: Hebrew or other non-Latin characters not making it into Worldpay donations - https://phabricator.wikimedia.org/T114000#1710548 (DStrine) [21:42:11] Fundraising-Backlog: [EPIC] Worldpay France post launch - https://phabricator.wikimedia.org/T114682#1710547 (DStrine) [21:42:20] Fundraising-Backlog: Legacy PayPal IPN listener should syslog - https://phabricator.wikimedia.org/T113386#1710549 (awight) This is a safety thing, so IMO it's worth the small effort to do the redundant work. [21:42:29] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog, Patch-For-Review: Associate banner history ID with contribution ID - https://phabricator.wikimedia.org/T112022#1710551 (AndyRussG) Following the merging [[ https://gerrit.wikimedia.... [21:43:49] (PS5) AndyRussG: WIP Add banner history log ID processor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (https://phabricator.wikimedia.org/T112022) [21:44:21] (CR) jenkins-bot: [V: -1] WIP Add banner history log ID processor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (https://phabricator.wikimedia.org/T112022) (owner: AndyRussG) [21:46:22] (CR) Awight: [C: 2] "verified!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244357 (owner: Ejegg) [21:46:38] (Merged) jenkins-bot: Send Amazon refunds down the refund queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244357 (owner: Ejegg) [21:51:34] dstrine: back! [21:52:50] i think my charger might be deadsville [21:52:58] luckily, travel buddy has one that works [21:55:38] (PS2) Awight: Audit parser: fees are listed as negative [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244290 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [21:56:27] (CR) Awight: [C: 2] "Negative depending on your perspective..." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244290 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [21:56:42] (Merged) jenkins-bot: Audit parser: fees are listed as negative [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244290 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [21:58:06] Fundraising-Backlog: Spike: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1710660 (CCogdill_WMF) @awight I don't mean to be obstinate, but I really do not have any good data with which I can make those comparisons. Every country and email really does behave very differe... [21:59:35] awight: hmm, were you avoiding putting those reprt type classes in config to get around having to initialize a smashpay context within CRM? [22:02:20] dstrine: be there in a sec! [22:04:58] ejegg: no, we should absolutely do that! [22:05:42] Fundraising Sprint UB40, Fundraising-Backlog: Worldpay Audit file - https://phabricator.wikimedia.org/T114676#1710696 (DStrine) a:Ppena>cwdent [22:10:47] dstrine sorry what? [22:14:45] Fundraising-Backlog: [epic] worldpay 1 hour test in France - https://phabricator.wikimedia.org/T110113#1710825 (cwdent) [22:14:46] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog: Style iframe contents more if necessary. (worldpay 1hour test) - https://phabricator.wikimedia.org/T112809#1710824 (cwdent) Open>Resolved [22:18:00] Fundraising-Backlog: SPIKE: assess the condition of adyan for english back processing - https://phabricator.wikimedia.org/T114958#1710840 (DStrine) NEW a:cwdent [22:18:11] Fundraising-Backlog: SPIKE: assess the condition of adyan for english backup processing - https://phabricator.wikimedia.org/T114958#1710848 (DStrine) [22:20:53] Fundraising-Backlog: Spike: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1710862 (atgo) [22:21:10] Fundraising-Backlog: SPIKE: assess the condition of adyen for english backup processing - https://phabricator.wikimedia.org/T114958#1710864 (atgo) [22:22:48] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM: Persist query criteria and make it possible for other users to see your search's results by permalink - https://phabricator.wikimedia.org/T114946#1710874 (Eileenmcnaughton) I think you can have more than one qfkey on the go - to prevent the mul... [22:24:25] Fundraising-Backlog: SPIKE: assess the condition of adyen for english backup processing - https://phabricator.wikimedia.org/T114958#1710886 (DStrine) [22:25:20] Fundraising-Backlog: SPIKE: assess the condition of adyen for english backup processing - https://phabricator.wikimedia.org/T114958#1710840 (DStrine) [22:25:33] Fundraising-Backlog: SPIKE: assess the condition of adyen for english backup processing - https://phabricator.wikimedia.org/T114958#1710911 (awight) [22:27:03] Fundraising-Backlog: Spike: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1710925 (DStrine) [23:03:38] thanks for being awesome, guys. you totally turned my evening around from wanting to destroy my computer [23:07:19] destroy it anyway! [23:14:30] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM: Persist query criteria and make it possible for other users to see your search's results by permalink - https://phabricator.wikimedia.org/T114946#1711054 (awight) I suppose, if we start persisting a query and its criteria, then we could have a... [23:38:24] atgo: woo, sounds like I missed the best part :) In any case, Catalina, our magical cat, is happy to hear this [23:38:45] as am I [23:48:48] Gotta do kid things. ttyl!