[00:07:35] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Create new civicrm repo - https://phabricator.wikimedia.org/T114831#1711206 (atgo) Moving to "not fr-tech" column because I think this is a Jeff thing. Please correct my mistake if I'm wrong :) [00:09:13] Fundraising-Backlog: Out of date donation page still active (and possibly an audit of all available donation pages and inbound links?) - https://phabricator.wikimedia.org/T114910#1711215 (atgo) Good catch, @caitvirtue. I'm thinking about triaging this and it seems like a good thing to look into at a quieter... [00:10:08] Fundraising Sprint UB40, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Train Engage in how to fill out the generic import templates - https://phabricator.wikimedia.org/T114687#1711217 (atgo) I think at Chicken we talked about this being in the current sprint. [00:10:20] Fundraising-Backlog: Out of date donation page still active (and possibly an audit of all available donation pages and inbound links?) - https://phabricator.wikimedia.org/T114910#1711220 (CaitVirtue) No urgency, just noticed it and didn't want to forget. Later is no problem. [00:16:51] Fundraising-Backlog, Epic: [epic] Handle gateway (sub) accounts throughout pipeline - https://phabricator.wikimedia.org/T102701#1711235 (atgo) p:High>Normal [00:17:10] Fundraising-Backlog, Epic: [epic] Handle gateway (sub) accounts throughout pipeline - https://phabricator.wikimedia.org/T102701#1371806 (atgo) Downgrading priority until this becomes a blocker for integration work. [01:06:40] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog, Patch-For-Review: Associate banner history ID with contribution ID - https://phabricator.wikimedia.org/T112022#1711428 (AndyRussG) The sendBeaconlessness workaround works, or at lea... [08:09:23] Fundraising Tech Backlog, Fundraising-Backlog: Make a form without city/state for a test - https://phabricator.wikimedia.org/T86239#1711765 (atgo) p:Low>Normal [08:19:37] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1711771 (atgo) Hey guys - what's the next steps for getting the tighter sampling in... [08:29:49] Fundraising Sprint UB40, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Show large screen banner and then top screen banner without losing an impression - https://phabricator.wikimedia.org/T90919#1711784 (atgo) [08:29:50] Fundraising-Backlog: [EPIC] Banner history post launch - https://phabricator.wikimedia.org/T112923#1711783 (atgo) [14:50:42] Fundraising-Backlog: Spike: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1712513 (Pcoombe) I do agree that the current domains are a real problem. If we just want to send people to donate.wikimedia.org, it should be possible to get by without an intermediate redirect... [17:02:09] Fundraising-Backlog: Spike: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1712928 (CCogdill_WMF) > Disadvantages of this: > - Can't track links outside of donatewiki > - Can't track different links within an email (unless we start tacking more stuff onto utm_source) I... [17:37:36] the-wub: hi! got a sec to talk about banner scripts for banner history logging on donate? (Also later or tomorrow is fine if ur busy. :) ) [17:38:16] now's not great AndyRussG. tomorrow? [17:38:23] the-wub: u bet! :) [17:38:41] thx! [18:09:11] "Drush command terminated abnormally due to an unrecoverable error" is the least helpful error message [18:10:27] Fundraising-Backlog: Out of date donation page still active (and possibly an audit of all available donation pages and inbound links?) - https://phabricator.wikimedia.org/T114910#1713146 (Pcoombe) a:Pcoombe Thanks @CaitVirtue, I'll look into it. [18:10:34] Fundraising-Backlog: Out of date donation page still active (and possibly an audit of all available donation pages and inbound links?) - https://phabricator.wikimedia.org/T114910#1713148 (Pcoombe) p:Triage>Normal [18:18:36] cwdent: sounds like a catch and re-throw situation [18:19:04] or at least print the message [18:20:45] hmm I'm just about to get into drush in fact [18:20:57] Anyone know if we're getting awight today? [18:23:57] not sure [18:25:05] (PS1) Cdentinger: WIP WPG RECON [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244483 [18:25:07] (CR) jenkins-bot: [V: -1] WIP WPG RECON [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244483 (owner: Cdentinger) [18:26:58] (PS1) Cdentinger: WIP WPG RECON [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244484 [18:28:37] (Abandoned) Cdentinger: WIP WPG RECON [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244483 (owner: Cdentinger) [18:30:01] (PS1) Cdentinger: WIP WPG RECON (SMASHPIG) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244486 [18:50:32] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM: Change default Activity status from "Scheduled" to "Complete" - https://phabricator.wikimedia.org/T115036#1713251 (CaitVirtue) NEW [18:50:52] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM: Change default Activity status from "Scheduled" to "Complete" - https://phabricator.wikimedia.org/T115036#1713265 (CaitVirtue) [19:01:41] atgo_: hi! pls lmk if I can be of assistance clearing anything up about BH here :) [19:06:41] (PS1) Ejegg: Require config files each time a config is constructed [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244493 [19:07:28] hey AndyRussG! thank you [19:07:42] np! [19:07:45] (CR) Awight: [C: 2] Require config files each time a config is constructed [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244493 (owner: Ejegg) [19:07:55] we're definitely in the court of needing ellery & megan to sort through and see what works/doesn't [19:08:06] i put the meeting up in case they're having trouble wrapping their minds around it [19:08:13] ellery mentioned you guys had connected? [19:08:17] thanks awight! [19:09:04] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM: Change default Activity status from "Scheduled" to "Complete" - https://phabricator.wikimedia.org/T115036#1713343 (atgo) @caitvirtue thanks! no need to tag individual team members onto tasks. We'll triage and sort through them internally. [19:09:44] Fundraising Tech Backlog, MediaWiki-extensions-CentralNotice: Make banner impression accounts available somewhere public - https://phabricator.wikimedia.org/T115042#1713344 (awight) [19:10:51] atgo: yeah we talked through more details last Friday evening via Hangout [19:11:13] cool, thanks AndyRussG [19:13:31] (PS1) Ejegg: Parse multiple types of Amazon reports [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244494 (https://phabricator.wikimedia.org/T111425) [19:13:32] np! Yeah at the end Ellery seemed clear and down with what we're getting and how, though if there's any confusion or questions from any parties, a meeting sounds great... moar meetings beats less meatings in such cases, I think :) [19:13:33] (CR) jenkins-bot: [V: -1] Parse multiple types of Amazon reports [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244494 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [19:13:36] atgo: ^ [19:13:51] sounds good [19:14:01] i'll wait to hear if megan & he think they've got what they need and then cancel [19:15:02] K ... yeah whatever works is fine here :) [19:16:08] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Make banner impression accounts available somewhere public - https://phabricator.wikimedia.org/T115042#1713361 (atgo) [19:19:14] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, WorkType-NewFunctionality: Create an import method for matching gifts and payroll deductions - https://phabricator.wikimedia.org/T115044#1713380 (awight) NEW a:awight [19:22:44] (PS2) Ejegg: Require config files each time a config is constructed [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244493 [19:23:39] (PS6) Ejegg: Update SDK, use new GetReportList parameters [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/243213 (https://phabricator.wikimedia.org/T109654) [19:23:48] (PS6) Ejegg: Make SDK classes mockable [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/243998 [19:23:51] Fundraising Sprint UB40, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Train Engage in how to fill out the generic import templates - https://phabricator.wikimedia.org/T114687#1713405 (awight) We had the first discussion about this, and Engage will try doing a sample a... [19:23:58] (PS7) Ejegg: Associate refunds with parent transactions [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244000 (https://phabricator.wikimedia.org/T111425) [19:24:08] Fundraising Sprint UB40, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Train Engage in how to fill out the generic import templates - https://phabricator.wikimedia.org/T114687#1713407 (awight) a:awight [19:26:48] (PS2) Ejegg: Parse multiple types of Amazon reports [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244494 (https://phabricator.wikimedia.org/T111425) [19:27:13] (CR) Ejegg: "PS2: rebase" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244494 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [19:28:49] Fundraising Sprint UB40, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Install 4.6 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1713418 (awight) [19:28:50] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising Tech Backlog, and 3 others: Configure new CiviCRM staging instance for testing 4.6 upgrade - https://phabricator.wikimedia.org/T112314#1713416 (awight) Open>Resolved [19:28:51] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [epic] Upgrade Civi to 4.6 & integrate new reporting - https://phabricator.wikimedia.org/T77910#1713419 (awight) [19:29:31] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising Tech Backlog, and 3 others: Configure new CiviCRM staging instance for testing 4.6 upgrade - https://phabricator.wikimedia.org/T112314#1631890 (awight) Note to anyone trying this--you need to d... [19:31:51] (PS3) Awight: Refactor BaseAuditProcessor main loop [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242933 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [19:50:15] http://vanilla-js.com/ [19:50:44] (CR) Awight: [C: 2] "Super classy! I added some notes on improving some of the code that got moved around, for a rainy day." (7 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242933 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [19:51:29] (Merged) jenkins-bot: Refactor BaseAuditProcessor main loop [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242933 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [19:53:21] (CR) Awight: [C: 2] Update SDK, use new GetReportList parameters [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/243213 (https://phabricator.wikimedia.org/T109654) (owner: Ejegg) [19:53:40] (Merged) jenkins-bot: Update SDK, use new GetReportList parameters [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/243213 (https://phabricator.wikimedia.org/T109654) (owner: Ejegg) [19:56:10] (CR) Awight: [C: 2] Make SDK classes mockable [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/243998 (owner: Ejegg) [19:56:24] (Merged) jenkins-bot: Make SDK classes mockable [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/243998 (owner: Ejegg) [20:04:53] (PS1) AndyRussG: CNDatabase::getDb(): Also default to DB_MASTER if it was used before [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/244499 [20:05:58] awight: and AndyRussG standup? [20:06:04] aah thx [20:06:47] can't make it [20:27:41] Stuff maybe to merge/check out, in case we want to ask for a CentralNotice swat deploy today: https://gerrit.wikimedia.org/r/#/c/244499/ https://gerrit.wikimedia.org/r/#/c/243604/ Thanks in advance!! [20:37:38] (PS2) Awight: ext.centralNotice.display: public getData() -> getDataProperty() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243604 (owner: AndyRussG) [20:37:49] (CR) Awight: [C: 2] "good idea!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243604 (owner: AndyRussG) [20:39:06] (Merged) jenkins-bot: ext.centralNotice.display: public getData() -> getDataProperty() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/243604 (owner: AndyRussG) [20:40:30] (PS5) Ejegg: WIP Amazon audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242644 (https://phabricator.wikimedia.org/T111425) [20:44:41] awight: thx! [20:48:19] awight: do you have any thoughts on things I can do to help QA the 4.6 Civi version? I’m thinking I could go through test coverage & see what is missing on the wmf side. [20:49:19] (& I’ll pull from upstream & start thinking about the repo) [20:54:34] eileen_: If I run a report on staging civi, it somehow is redirecting me to prod civi for the result! [20:54:47] ejegg: what is the link? [20:55:25] from https://civicrm.frdev.wikimedia.org/ I just selected the WMF LYBUNT 2014 from the reports menu [20:56:15] ejegg: you gotta reset the URLs... lemme see [20:56:17] Fundraising-Backlog: [BUG] TY email for GC transaction shows incorrect donation amount; discrepancy between GC & CIVI - https://phabricator.wikimedia.org/T115053#1713693 (MBeat33) NEW [20:56:53] looks like that one has a hard-coded link in the nav menu [20:56:58] ejegg: something about updateConfigBackend [20:56:59] ideally fix on production [20:57:01] hmm [20:57:22] /civicrm/admin/setting/updateConfigBackend?reset=1 [20:57:36] but yeah what eileen_ said, I guess it's a totally different problem. [20:58:08] I just updated on staging [20:58:18] I think the others are OK - will do sql to check [20:59:16] ah, ok [20:59:18] back in a few [21:01:23] ejegg: that link should open correctly now! [21:01:32] awesome, trying it out [21:02:12] oh right, doesn't automatically run before you can set filters! [21:02:14] nice [21:02:34] running... [21:02:44] yeah - I think that was actually the most important feature of the Giant Rabbit work from what I can tell [21:03:29] see the url has output=criteria in it - core wanted the view-mode to be optional not a global change - so you choose when saving [21:03:53] ah, nice [21:04:05] wow, that returned a LOT faster than on prod [21:04:41] same number of rows... but total seems to be $900 off [21:04:50] though that is out of 12 million [21:05:03] will try to export and diff [21:08:53] ejegg: did you see the developer tab? [21:09:05] to grab the sql from? [21:10:01] (nb I won’t rule out that I might have entered a couple of contributions to check that or edited some - although I don’t recall it) [21:10:49] In other news - mail through CiviCRM is now set to log activities rather than send mail & I tested that OK [21:12:01] eileen_: nice! [21:13:01] The differences might be legit - I think staging was based on a not-quite-current prod dump [21:13:16] ejegg: yeah a week or more old [21:13:48] just seeing 1 donor in each that's not in the other, and differing lifetime totals on 3 others. spot checking them for recent changes [21:18:07] (PS7) Paladox: [WIP] Add extension.json, empty php entry point [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (owner: Awight) [21:18:21] (CR) Paladox: "Rebased." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (owner: Awight) [21:19:53] ejegg: I’m trying a report that I expect to be slow - so if you find it suddenly slow that’s why [21:19:59] ok [21:20:45] eileen_: I'm not seeing the developer tab - that would be above the report next to 'Email Delivery' and 'Access'? [21:21:18] oh, probably a permission [21:21:25] ejegg: it will only show after you have done view results [21:21:40] hmm, already did that [21:22:14] is this on the lybunt? [21:22:17] yeah [21:23:41] if you do membership report (quick to run :) do you see it beside filters? [21:24:44] lemme see... [21:25:00] I don’t see it on the lybunt report - it probably overrides the function that adds it [21:25:24] err, yeah, i vaguely recall doing some hacky stuff there [21:28:54] ejegg: I just pushed up something to git review that might work for it [21:31:19] actually - still trying to get it up - go slow [21:32:01] oh wow! [21:37:27] Fundraising-Backlog: Dedupe data in Silverpop file - https://phabricator.wikimedia.org/T107045#1713903 (CCogdill_WMF) A note from Trilogy: please make sure the dedupe is not case sensitive. Thanks! [21:37:41] (PS1) Eileen: CRM-17144 add developer tab to lybunt [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/244593 [21:38:04] ejegg: that fix seems to work - I put both queries to show [21:39:59] thanks! [21:40:14] eileen_: Sorry I let that last note slip by! I don't have a very detailed picture of how to QA, either. [21:40:44] So far, just that we have Civi admins run their stuff, and that we try normal automated pipeline things to be sure we aren't corrupting data or hitting new code paths. [21:41:33] awight: yeah it’s a bit tricky isn’t it! [21:42:19] The iceberg on the horizon is that rolling back an upgrade would be a first-class mess. [21:42:47] I can go through the wmf modules a bit more carefully & see what test gaps there are - possibly renaming contribution_type to financial type even where it is just a variable to try to make that greppable [21:42:55] It would be impossible to rescue and work done in the system between the upgrade + the rollback [21:43:23] test gaps... we've probably got 5% coverage :( [21:44:02] hmm - OK - so perhaps looking at test coverage is a good focus for me for the next couple of days [21:44:10] where it touches on Civi [21:44:33] That sounds like a huge task... [21:44:51] a huge task would be getting all the gaps closed [21:45:12] but I can increase the cover & maybe find some things that don’t work [21:45:39] the other area I could look at is the refund form & the reports that don’t complete I guess [21:45:51] but, WRT the latter - some of the reports may not be really used [21:46:08] WRT the former I guess I need to figure out what the refund form patch does! [21:46:30] oh, the other things is the exception stuff didn’t really port so I need to understand that better [21:47:24] (CR) Awight: [C: 2] Associate refunds with parent transactions (5 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244000 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [21:47:59] I think the refund feature has been implemented upstream already. [21:48:56] Agreed that we should wait to see what reports are actually used before fixing. I think it's a very small set. In the future, I'm hoping we have an audit log that would tell us exactly which reports get run. [21:49:29] (Merged) jenkins-bot: Associate refunds with parent transactions [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244000 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [21:51:07] awight: hmm refund patch isn’t working [21:53:09] eileen_: Isn't that already implemented upstream? [21:54:01] awight: yeah - I’m not sure it’s not just implemented for events - checking (we haven’tt really used it - although customers do enter negative contributions) [21:54:13] https://issues.civicrm.org/jira/browse/CRM-11503?focusedCommentId=47764&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-47764 [21:56:07] ok - looks like you change the status to refunded [21:57:12] We change the status, but we also create a second contribution with a negative amount. I guess in 4.6 that would be a new financial line item. [21:57:24] We want to keep the old contribution, but zero out the total. [21:58:13] eileen_: the civi-4.6.9 branch doesn't have a tools directory. Was that intentional? Deployment thing? [21:58:14] awight: so this is how is looks using the new way [21:58:17] https://civicrm.frdev.wikimedia.org/civicrm/contact/view?reset=1&force=1&cid=11455189&selectedChild=contribute [21:58:33] awight: so tools is not part of deploy version [21:58:45] ok, cool [21:59:04] I think I might start writing up some notes / thoughts on how the branches look in a few mins [21:59:31] Too bad, it looks like the Refund action doesn't create that second contribution. [21:59:58] no - it reflect in in the financial lines as you say [22:00:04] ok? [22:00:21] Where do I find that? [22:00:25] I guess the change is OK as long as the reporting reflects it how you want? [22:00:36] yep [22:01:10] I don't see these line items you speak of... [22:01:20] they are quite hidden.... [22:01:35] so, I guess we need to find out what reports people run & then check how the reports look WRT refunds [22:01:42] totally. [22:01:51] I like the UI so far [22:02:15] the 4.6 ui in general? [22:02:17] The overlay that lets you get back to your search context is refreshing [22:02:20] yeah [22:02:33] Much less of a rabbithole feeling [22:02:44] yeah [22:03:27] (CR) Awight: [C: 2] "Nice safety webbing!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/244499 (owner: AndyRussG) [22:04:25] what about the exception stuff - that didn’t really port. At first I thought it was just for extra error data - but I think if it doesn’t throw the right exception it won’t be handled correctly [22:04:31] eileen_: The main report I know of, where refunds really matter, is the Gateway Renconciliation report. We wrote that, so no problem to hack the where clause. [22:04:47] (Merged) jenkins-bot: CNDatabase::getDb(): Also default to DB_MASTER if it was used before [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/244499 (owner: AndyRussG) [22:04:56] eileen_: That does sound like a problem. Perhaps we can grep for the civi exception class in WMF modules [22:05:07] other than that, I'm okay with losing the extra debug data [22:05:46] awight: ok - I’ll take a look & see what I can figure out there [22:06:03] (PS6) Ejegg: Amazon audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242644 (https://phabricator.wikimedia.org/T111425) [22:06:05] (CR) jenkins-bot: [V: -1] Amazon audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242644 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [22:06:54] btw I discovered the data in the civi exception is affected by permissions - ie only users with administer civicrm see the sql that failed [22:07:09] which doesn’t quite work in testing [22:08:05] That's probably a good idea--we accidentally sent some restricted data about the db connection in our failure alerts, at one point. [22:08:30] yeah - that stuff doesn’t show at all I don’t think [22:08:42] whew! [22:08:52] but, there should be a test-override to get the sql when running tests without a permission [22:09:08] & the permission should probably be debug civicrm now [22:10:02] Probably best if tests don't rely on special behavior in the code under test [22:11:06] awight: no -it’s more for when they fail to see more info [22:11:57] (CR) Awight: [C: 2] "Hooray for tests!" (3 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244494 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [22:12:14] (Merged) jenkins-bot: Parse multiple types of Amazon reports [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244494 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [22:25:21] awight: ejegg: cwdent: XenoRyet: what are your thoughts on a deploy? Should we try to get something on today's SWAT deploy? I'm imagining just cherry-picking more patches needed for BH [22:26:35] (PS1) Eileen: Revert "wmf-sunset-patch add refund form" [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/244603 [22:26:55] I think that since the DB patch has merged (thanks awight!) I can just link to that in the CR of the previous DB patch, and that should help avoid any discord surrounding the fact that we don't deploy it or its predecessor today [22:27:31] AndyRussG: do CN and DI have to go at the same time? [22:27:40] does CN go out on swat? [22:27:47] AndyRussG: sounds good to me [22:27:56] ejegg: (repeating thoughts 4 comment above, in case u didn't see them) what are your thoughts on a deploy? Should we try to get something on today's SWAT deploy? I'm imagining just cherry-picking more patches needed for BH. I think that since the DB patch has merged (thanks awight!) I can just link to that in the CR of the previous DB patch, and that should help avoid any discord surrounding the fact that we [22:27:56] don't deploy it or its predecessor today [22:28:00] cwdent: it can, if we update the wmf_deploy branch pointer [22:28:24] gotcha [22:28:28] AndyRussG: thanks! taking a look at the diff [22:28:58] cwdent: yeah ^ the new CN stuff is needed to link BH to donations, and if we don't deploy today, it'd be a lot harder to get the link out before mid next week [22:29:19] ejegg: cool! Hmm lemme put here which patches I'd like to cherry-pick [22:31:02] ah, I see there are quite a few little things in the chute [22:31:14] ejegg: yeah, it'd be a cherrry-pick of 4 I think [22:31:15] https://gerrit.wikimedia.org/r/#/c/243604/ [22:31:41] https://gerrit.wikimedia.org/r/#/c/243479/ [22:31:55] https://gerrit.wikimedia.org/r/#/c/243180/ [22:32:13] and https://gerrit.wikimedia.org/r/#/c/242946/ [22:33:41] Apologies for hogging the deploys with stuff I've been working on, it's just with the idea of getting a fully working BH out ASAP, we could get the rest of the great CN stuff you guys have worked on deployed next week, maybe? Would that be OK? [22:38:25] please do hog the deploys, you're rolling forward the golden egg! [22:38:53] Heh we'll see if a duckling hatches [22:39:52] Looking at the code for the wmf_unsubscribe module I feel like it doesn’t work - anyone able to confirm? [22:39:59] AndyRussG: yeah, those patches seem pretty safe! [22:40:12] eileen_: doesn't work on 4.6? [22:40:25] ejegg: awight: cwdent: thanks! [22:40:28] it seems to include a file that I don’t think exists [22:41:55] require_once drupal_get_path( 'module', 'wmf_common' ) . '/civicrm_api_check.php'; [22:41:56] eileen_: I think you're right--yeah we stopped using the unsubscribe UI, and now we rely on a MediaWiki extension that sends queue messages to the wmf_unsubscribe_qc.module consumer [22:42:04] awight: cool [22:43:36] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Deprecate wmf_unsubscribe module - https://phabricator.wikimedia.org/T115066#1714072 (awight) NEW [22:43:37] thanks! [22:43:43] ^^ task to deprecate... [22:45:32] (PS1) AndyRussG: Do Not Track: Don't even accumulate log or call EL [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/244606 [22:45:58] awight: I like deprecating... [22:46:49] totally-- we love that too. I think cwdent has bragged that his overall github Lines of Code stats are negative sum [22:46:54] hired. [22:47:38] hehe yeah, at my last job they were [22:47:57] that's badass. [22:48:27] 100k lines of churn or so [22:48:32] but net negative [22:50:05] awight: ejegg: cwdent: XenoRyet: mm cherry-pick conflicts, I think I need to add in the hide banner patch too [22:50:15] works for me [22:50:27] yeah, that one sounds good too [22:50:43] You could go ahead with the full merge too, if it looks like a slow weekend at home :p [22:51:16] Gonna go clean up my propaganda flyers... back in 10 [22:52:37] awight|afk: ejegg: cwdent: XenoRyet: no it doesn't work! it's too much differences.... [22:52:49] I'm just gonna merge in the whole damn master branch and hope for the best, K? [22:52:54] !!!! @@|@! [22:53:01] godspeed [22:53:08] Hold my beer... [23:04:23] (PS1) Ejegg: Activate the Amazon audit module [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/244611 [23:05:40] (PS1) AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/244613 [23:06:06] (PS7) Ejegg: Amazon audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242644 (https://phabricator.wikimedia.org/T111425) [23:06:08] (PS1) Ejegg: Fix audit error handling [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244615 [23:06:10] (PS1) Ejegg: Tests for Amazon audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244616 (https://phabricator.wikimedia.org/T111425) [23:06:14] (CR) jenkins-bot: [V: -1] Amazon audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242644 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [23:06:16] (CR) jenkins-bot: [V: -1] Fix audit error handling [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244615 (owner: Ejegg) [23:06:18] (CR) jenkins-bot: [V: -1] Tests for Amazon audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244616 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [23:06:20] (CR) AndyRussG: [C: 2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/244613 (owner: AndyRussG) [23:06:35] awight: ejegg|afk: cwdent: XenoRyet: look good? [23:06:35] (PS2) Ejegg: Fix audit error handling [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244615 [23:06:47] (PS8) Ejegg: Amazon audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242644 (https://phabricator.wikimedia.org/T111425) [23:07:00] (PS2) Ejegg: Tests for Amazon audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244616 (https://phabricator.wikimedia.org/T111425) [23:07:28] (Merged) jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/244613 (owner: AndyRussG) [23:08:48] (CR) jenkins-bot: [V: -1] Tests for Amazon audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244616 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [23:23:59] awight: ejegg|afk: cwdent: XenoRyet: FYI the whole thing is going out now. It's a scap (a deploy script needed when there are i18n message changes) so it'll take a while. I'll LYK when there's stuff to test! [23:24:08] Fundraising-Backlog: Spike: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1714120 (awight) About my earlier comment--we wholeheartedly agree that this is a big problem, I was just fishing for numbers so we could explain to everyone exactly how much of a problem it is.... [23:24:40] AndyRussG: ok! good luck [23:24:48] cwdent: heheheh thanks! [23:24:57] cool AndyRussG! [23:25:23] cwdent: ejegg|semihere: awight: XenoRyet: anyone who'd like to check out the wmf_deploy branch and bang on it here or there is quite welcome, too!!! [23:25:29] (CR) Awight: [C: 2] Fix audit error handling [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244615 (owner: Ejegg) [23:26:47] (Merged) jenkins-bot: Fix audit error handling [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244615 (owner: Ejegg) [23:30:03] No issues locally so far!!! [23:37:52] (CR) Awight: [C: 2] Amazon audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242644 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [23:38:34] (Merged) jenkins-bot: Amazon audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242644 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [23:46:01] ejegg|semihere: awight: I'm getting "PHP Notice: Did not find alias for special page 'Random'. Perhaps no aliases are defined for it? [Called from SpecialPageFactory::getLocalNameFor in /home/lap/Development/mw1/includes/specialpage/SpecialPageFactory.php at line 645] in /home/lap/Development/mw1/includes/debug/MWDebug.php on line 300, referer: http://localhost/mw1/index.php/Special:CentralNotice [23:46:02] in the server log" due to the SpecialPage::getTitleFor( 'Random' ) in Special:CentralNoticeBanners [23:46:33] ouch. [23:46:36] Digging... [23:49:13] AndyRussG: languages/messages/MessagesEn.php [23:49:22] apparently the canonical name is 'Randompage'?? [23:49:37] which makes me question the purpose of aliases... but that's another issue [23:49:49] awight: Roan is scapping right now [23:50:00] ok, e_notice isn't a blocker at least. [23:50:10] I don't even think that'll get logged on prod (unfortunately) [23:50:11] awight: ah OK, yeah I have no idea [23:50:16] had no idea [23:50:26] It's still possible to preview banners [23:50:38] maybe this was the case even before this change? Lemme check... [23:51:27] (PS1) Awight: Use a more canonical name for Special:Randompage [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/244625 [23:51:28] Maybe try that locally ^ [23:51:54] awight: K it was already happening on our previous version of the deploy branch [23:54:24] awight: maybe the alias changed? [23:55:55] Maybe it's something to do with my local setup, or some config that's only on prod?