[00:00:33] It seems that Randompage has been the canonical alias for evar [00:01:22] awight: then why does it work on prod? that code has said 'Random' 4 evar too.... [00:01:40] maybe it just works (TM) even though it creates an error [00:01:56] and just no one notices or cares about the error? [00:03:01] (CR) AndyRussG: [C: 2] "Weeee an un-random randomfix!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/244625 (owner: Awight) [00:04:10] (Merged) jenkins-bot: Use a more canonical name for Special:Randompage [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/244625 (owner: Awight) [00:04:21] Good question! [00:04:59] awight: yeah that's it... it works locally (I just wasn't seeing any random pages 'cause I only had 1 page on my local wiki) [00:05:06] funky [00:05:14] I don't like that it used to work, either [00:05:25] ok, gotta do some kid things, see you soon and good luck! [00:05:27] So it probly doesn't work in other languages, maybe, but no one bothered, and the error has been ommitted [00:05:32] awight: thanks much!!!!! have fun, thx! [00:46:53] ejegg|semihere: cwdent: XenoRyet: FWIW, the deploy finished, but I'm still getting old code on enwiki [00:46:58] Some unexpected RL issue [00:47:52] Anyone interested may follow on -operations channel :) [01:32:14] K RL issue fixed! New code is out now, seems to work :) [01:40:12] yay [02:09:54] eileen: yeah! Phew it was pretty nerve-racking [02:10:34] AndyRussG: the Civi upgrade will be scary when it happens… [02:11:16] Heh sometimes it's just, check it over as thoroughly as resources allow, and the hold your breath! [02:11:57] yeah!! [02:15:12] Heh have to do some chores (though I'll be ping-able if anything bad were to happen) TTY soon! :) [02:15:57] :-) [02:26:03] (PS1) Eileen: CIvi46 Update to latest 4.6.9 version [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/244631 (https://phabricator.wikimedia.org/T99838) [03:32:02] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Create new civicrm repo - https://phabricator.wikimedia.org/T114831#1714423 (Eileenmcnaughton) This is probably something we need to co-ordinate with Jeff. The way the wmf CiviCRM repo currently w... [04:38:43] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog: Style iframe contents more if necessary. (worldpay 1hour test) - https://phabricator.wikimedia.org/T112809#1714449 (Ppena) Not sure if this was the original point o this ticket, but it would be good (not launch blocker) to cha... [05:43:21] (CR) Siebrand: [C: 1] "i18n/L10n reviewed." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200094 (owner: Awight) [06:51:21] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog: Style iframe contents more if necessary. (worldpay 1hour test) - https://phabricator.wikimedia.org/T112809#1714562 (atgo) That's in the iframe I believe. Can you follow up with world pay? [14:34:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Easy: Deprecate wmf_unsubscribe module - https://phabricator.wikimedia.org/T115066#1715206 (awight) [14:35:45] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy: Special:HideBanners should output a valid PNG - https://phabricator.wikimedia.org/T112969#1715217 (awight) [14:36:33] Fundraising-Backlog: CRM consumers should be able to read from Redis - https://phabricator.wikimedia.org/T112832#1715219 (awight) [14:36:44] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy: default submit in Special:CentralNotice is wrong - https://phabricator.wikimedia.org/T49223#1715221 (awight) [14:39:13] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy, Patch-For-Review: CentralNotice: JS code style, JSCS and JSDuck - https://phabricator.wikimedia.org/T111387#1715229 (awight) [14:39:30] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Easy: CiviCRM quicksearch has annoying key behavior - https://phabricator.wikimedia.org/T111128#1715231 (awight) [14:43:24] Fundraising Tech Backlog, Fundraising-Backlog, Easy: Make a form without city/state for a test - https://phabricator.wikimedia.org/T86239#1715241 (awight) [14:44:14] Fundraising Sprint Lou Reed, Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, Fundraising-Backlog, and 4 others: CentralNotice mobile modules should not be loaded in the head - https://phabricator.wikimedia.org/T100372#1715243 (awight) @AndyRussG: This card should be retitled, I think? [14:44:36] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [epic] Upgrade Civi to 4.6 & integrate new reporting - https://phabricator.wikimedia.org/T77910#1715249 (awight) [14:44:37] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CI tests are failing for Civi 4.6 branch - https://phabricator.wikimedia.org/T113422#1715247 (awight) Open>Resolved a:awight [14:45:18] Fundraising-Backlog, fundraising-tech-ops: Spike: Do we have to make changes on orphan rectification box to support new GC SSL ciphers - https://phabricator.wikimedia.org/T113392#1715251 (awight) Open>Resolved False alarm, GC has confirmed that there were glitches on their side. [14:46:33] Fundraising-Backlog, Easy: Auto-Notifications of Upcoming Birthday of Major Donor - https://phabricator.wikimedia.org/T113998#1715259 (awight) [14:48:13] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Privacy: Stop logging HTTP referrer - https://phabricator.wikimedia.org/T114148#1715262 (awight) [14:49:33] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Easy: Remove "getInfo" methods from CRM test classes - https://phabricator.wikimedia.org/T105769#1715266 (awight) [14:50:36] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Easy: Quotation marks are low on Jimmy quote - https://phabricator.wikimedia.org/T94049#1715267 (awight) [14:51:14] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Easy: Point amp cache to $WORKSPACE - https://phabricator.wikimedia.org/T91911#1715269 (awight) [14:51:55] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Easy, Patch-For-Review: Convert DonationInterface to use extension registration - https://phabricator.wikimedia.org/T108763#1715271 (awight) [14:52:24] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Easy: Have Civi export name data in UTF-8 format - https://phabricator.wikimedia.org/T90834#1715273 (awight) [14:54:09] Fundraising-Backlog, Wikimedia-Site-Requests, Easy: Geolocation not available on wikimediafoundation.org - https://phabricator.wikimedia.org/T73747#1715275 (awight) [14:54:27] Fundraising Tech Backlog, Fundraising-Backlog, Easy: Do not log CC exp date - https://phabricator.wikimedia.org/T86234#1715278 (awight) [14:56:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Deploy new TY letter - https://phabricator.wikimedia.org/T102018#1715293 (awight) Open>Resolved Closing as duplicate... can't find the original. [14:58:11] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Easy: Don't require "language" parameter in FundraisingLandingPage - https://phabricator.wikimedia.org/T107365#1715302 (awight) [14:58:26] Fundraising-Backlog, Astropay, Easy: Astropay errors should be red text and not popup - https://phabricator.wikimedia.org/T107363#1715304 (awight) [14:58:46] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Easy: Verify that DonationInterface doesn't require "uselang" parameter - https://phabricator.wikimedia.org/T107364#1715305 (awight) [15:00:09] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Convert CentralNotice to use extension registration - https://phabricator.wikimedia.org/T108721#1715306 (awight) [15:00:22] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Easy, and 2 others: WMF-specific links and emails should be in LocalSettings - https://phabricator.wikimedia.org/T108699#1715307 (awight) [15:01:31] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Easy, and 2 others: WMF-specific links and emails should be in LocalSettings - https://phabricator.wikimedia.org/T108699#1527715 (awight) The patch looks great, but perhaps we want to point to local wiki pages i... [15:02:10] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Easy: Don't make donors guess minimum donation amount - https://phabricator.wikimedia.org/T105618#1715321 (awight) [15:04:07] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Create UI for limiting banner impressions (banner diet?) - https://phabricator.wikimedia.org/T105109#1715325 (awight) [15:04:10] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog, and 2 others: Write banner diet campaign mixin - https://phabricator.wikimedia.org/T112017#1715327 (awight) [15:04:29] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog, and 2 others: Write banner diet campaign mixin - https://phabricator.wikimedia.org/T112017#1622856 (awight) Copying an important comment from T105109: > This should be the default beha... [15:35:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Easy: Change title of search box on Find Contributions page to only read "Contributor Name" - https://phabricator.wikimedia.org/T104885#1715426 (awight) [15:35:44] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy: Clone button for campaigns - https://phabricator.wikimedia.org/T91078#1715429 (awight) [15:36:39] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-Vagrant, Easy: Make it easier to use the fundraising puppet role on labs - https://phabricator.wikimedia.org/T102304#1715434 (awight) [15:36:57] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Easy: Make CRM version stamp thing robust on dev boxes - https://phabricator.wikimedia.org/T88376#1715435 (awight) [15:37:29] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Drupal password reset doesn't work - https://phabricator.wikimedia.org/T103457#1715444 (awight) Open>Invalid a:awight Reopen if it happens again. [15:38:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi Send Receipt? check box - review and filter what info it generates, or disable - https://phabricator.wikimedia.org/T108088#1715453 (awight) [15:38:31] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Easy: Add a parameter which forces creation of a 600 orphan - https://phabricator.wikimedia.org/T107826#1715455 (awight) [15:39:55] Fundraising Tech Backlog, Fundraising-Backlog, Recurring-Donations: Redirect old PayPal IPN URL to active listener - https://phabricator.wikimedia.org/T107384#1715462 (awight) Good to clean up, but noting here that we're still getting this data through nightly audit. [15:40:37] Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-DonationInterface, Easy: Display a flag and/or country name on the donation form - https://phabricator.wikimedia.org/T96046#1715465 (awight) [15:45:41] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog: Style iframe contents more if necessary. (worldpay 1hour test) - https://phabricator.wikimedia.org/T112809#1715473 (Ppena) Are you sure? I've always thought that the bug, blue "Continue" button at the end of the iframe is on o... [16:01:19] (PS1) Ejegg: Shameless self-promotion [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244703 [16:15:34] (PS1) Ejegg: Minor cleanup [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244705 [16:18:20] (PS1) Ejegg: Set subscr_id on Amazon recurring if missing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244708 (https://phabricator.wikimedia.org/T111431) [16:49:55] (Abandoned) AndyRussG: WIP Temporary fix for DB master/slave switching [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241752 (owner: AndyRussG) [17:02:16] (CR) AndyRussG: "Here's the follow-on we went with: I206db01aa." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234164 (https://phabricator.wikimedia.org/T92357) (owner: Aaron Schulz) [17:48:57] good morning everyone [17:49:40] 'mornin [18:02:00] Hi! [18:05:16] dstrine: yesterday's deploy went dandy, I'm about to send out an e-mail about it... [18:42:02] (CR) Ejegg: Parse multiple types of Amazon reports (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244494 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [18:42:19] (CR) Ejegg: Associate refunds with parent transactions (4 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/244000 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [18:47:37] AndyRussG: cool!!! [18:48:24] dstrine: :) [18:49:53] dstrine: once we update the banner scripts, we'll actually be 90% of the way to associating banner histories with donors, since Ellery will be able to tell with 99% accuracy which banner histories are for donate-clickers. The remaining bit, on the DonationInterface and Civi side of things, will give us 100% and more details [18:51:28] AndyRussG: which phab task maps to that second part? [18:53:05] (CR) Ejegg: [C: 2 V: 2] Activate the Amazon audit module [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/244611 (owner: Ejegg) [18:53:45] dstrine: it's all the same phab task T112022 [18:53:45] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244616 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [18:54:18] AndyRussG: ah ok [19:01:56] dstrine: enabling this is actually something we could do but I wouldn't want to do so without talking to Peter Coombe (the-wub), but I haven't seen him online at all today... Have you any news of him today by any chance? [19:03:05] his calendar shows as "home" and he's busy all day [19:03:43] Ah hmm K thx! [19:05:44] cwdent|afk: ejegg: XenoRyet: where does the Civi database get created/updated from? Where should I define a DB table to be used by a module under queue2civicrm? [19:06:06] AndyRussG: it happens in .install files [19:07:25] Hmm, it looks like the tables are defined in a _schema() drupal hook function [19:08:27] There are also _update_XXYY functions that you can see in wmf_reports for example [19:08:35] lemme see if we ever create tables in those [19:08:57] aarg sounds complexy [19:09:47] aah, ok, I see some table creation in donor_review.install [19:10:56] AndyRussG: you can probably adapt donor_review_update_7001() and add it to queue2civicrm.install [19:12:00] ejegg: ah K that sounds nice :) so queue2civicrm is a module itself? What about the subdirectories? They also have .module files, and sometimes .install files [19:12:10] Maybe submodules? Should I read up about drupal modules? [19:12:26] yep, those are submodules [19:13:02] but i think that's just by convention - don't know if the directory nesting actually changes how they act [19:17:52] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog: Style iframe contents more if necessary. (worldpay 1hour test) - https://phabricator.wikimedia.org/T112809#1716047 (atgo) @cwdent can you confirm? CSS I believe controls styling but not text. [19:18:50] ejegg: K... hmm where is it configured which modules are activaged and where they live? [19:19:08] activaged = activated + enraged [19:19:15] Kinda like hangry but for drupal modules [19:19:17] hehe [19:19:29] they're activated and deactivated in the database [19:19:39] you can use a drush command to list them and their status [19:19:42] drush pml [19:19:55] and drush en moduleName to enable [19:20:06] drush dis modulename to disable [19:20:11] ejegg: Ah humm... so it's something we do manually? Or via puppet? [19:21:12] there's a script in the civicrm-buildkit that activates them [19:21:28] app/config/wmff/install.sh [19:22:02] I'm not sure, but I think puppet uses that script to set its civi instance up [19:23:13] ejegg: k :) [19:30:20] ejegg: where is that app dir? I don't see it on m'vagrant... [19:30:35] oh huh, maybe it's done differently [19:30:41] lemme see [19:34:17] AndyRussG: ok, i found a list of drupal modules in puppet/modules/crm/manifests/init.pp [19:34:27] ejegg: woohoo thanks! [19:34:33] Mmm what version of drupal are we on? [19:34:40] 7.39 [19:34:43] (just seems the doc is different for different versions) [19:34:47] K cool [19:34:50] ooh, that list needs a couple updates [19:35:32] ejegg: so that's just for vagrant? I guess for production we just pester jgreen then? [19:35:49] AndyRussG: nope, on production we use drush commands [19:35:54] Ah K [19:36:00] gotcha :) [19:51:10] ejegg: 'nother quick question :) so our install of civi is tied to Drupal, even though civi is compatible with joomla, etc, right? So for our own stuff we just write Drupal modules? [19:51:19] eileen: hi! ^ ? [19:51:26] AndyRussG: yeah, we're tied to drupal [19:51:37] ( "^" means "see above message") [19:51:41] ejegg: k thx [19:52:00] the abstraction layer to make cross-CRM modules is kindof a pain [19:54:06] awww hmm oh well [19:55:20] What's this funky git repo structure? The main repo is the outer one, org.wikimedia.civicrm in vagrant, and drupa and civicrm are just included upstream repos? [19:55:53] nope, we've got our own repos for the upstream code [19:56:11] I don't think we've tampered with drupal much [19:56:37] but we customized civi enough that we needed to call in eileen when we wanted to upgrade [20:06:37] Fundraising Sprint UB40, Fundraising-Backlog: [BUG] TY email for GC transaction shows incorrect donation amount; discrepancy between GC & CIVI - https://phabricator.wikimedia.org/T115053#1716287 (DStrine) p:Triage>High [20:07:55] Fundraising Sprint UB40, Fundraising-Backlog, Unplanned-Sprint-Work: [BUG] TY email for GC transaction shows incorrect donation amount; discrepancy between GC & CIVI - https://phabricator.wikimedia.org/T115053#1713693 (DStrine) [20:29:57] hello from scenic philadelphia! [20:30:02] (airport) [20:32:10] helloo [20:40:31] Fundraising Tech Backlog, Fundraising-Backlog, Recurring-Donations: Redirect old PayPal IPN URL to active listener - https://phabricator.wikimedia.org/T107384#1716375 (atgo) Ok. I'm moving this to Q3 in conjunction with the PayPal upgrade we'll be doing. [20:41:07] Fundraising Tech Backlog, Fundraising-Backlog, Recurring-Donations: Redirect old PayPal IPN URL to active listener - https://phabricator.wikimedia.org/T107384#1493671 (atgo) [20:41:08] Fundraising-Backlog, Epic: [epic] PayPal upgrade - https://phabricator.wikimedia.org/T87621#1716377 (atgo) [20:41:46] eileen1: you're incrementing! [20:42:31] ohh There are many me's [20:44:39] Fundraising-Backlog, Easy: Auto-Notifications of Upcoming Birthday of Major Donor - https://phabricator.wikimedia.org/T113998#1716393 (atgo) p:Triage>Low [20:44:50] Fundraising-Backlog, Easy: Auto-Notifications of Upcoming Birthday of Major Donor - https://phabricator.wikimedia.org/T113998#1716397 (atgo) Great idea, @caitvirtue! I'm not sold that putting this in the Q2 bucket is a great idea, but we can revisit later in the quarter. [20:57:46] Fundraising Sprint UB40, Fundraising-Backlog, Unplanned-Sprint-Work: [BUG] TY email for GC transaction shows incorrect donation amount; discrepancy between GC & CIVI - https://phabricator.wikimedia.org/T115053#1716436 (Ejegg) I've ruled out a CiviCRM problem - the queue consumer logs show the message... [21:56:46] MBeat can you view this task? https://phabricator.wikimedia.org/T115053 [21:57:08] yes [21:58:10] ejegg: and I don't have the security level to view this task and we don't know what setting made it more private [21:58:50] do you know which setting control this? [21:59:19] Is it normal that I have these untracked files in my org.wikimedia.civicrm directory? sites/default/civicrm-install.php sites/default/drupal-install.php [22:00:14] AndyRussG, not 100% sure since my current vagrant is a bit of a snowflake, but I have those untracked as well. [22:02:07] MBeat: would you know how to adjust the security? [22:02:32] lemme look [22:03:19] Edit Task > Security - what level should it be? [22:04:28] dstrine I see options for none, software security bug, other confidential issue, access request [22:19:58] !log took down Fundraising campaigns [22:20:04] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:05:21] XenoRyet: ah k thanks :) [23:06:00] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog: Style iframe contents more if necessary. (worldpay 1hour test) - https://phabricator.wikimedia.org/T112809#1716705 (cwdent) You can sort of change text with the stylesheet but it's hacky...you can like hide the element and rep... [23:55:10] (PS1) Ejegg: Make sure we're recording the right amount [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244829