[00:00:08] (PS4) Eileen: CRM-17310 my reports [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243860 [00:00:10] (PS2) Eileen: remove accidentally committed .gitignore in the drupal folder [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243983 [00:00:12] (PS3) Eileen: CRM-14232 default not filling for contact preferred language [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243864 [00:06:20] (CR) Eileen: "I've pushed an update to cover these" (2 comments) [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243860 (owner: Eileen) [00:16:15] gtg [00:36:29] (PS1) Eileen: Remove custom quicksearch hook [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/246450 [00:39:48] (PS5) Eileen: CRM-17310 my reports [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243860 [00:56:25] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising Sprint Vengaboys, and 4 others: Prepare CiviCRM 4.6 upstream and Giant Rabbit branches - https://phabricator.wikimedia.org/T99837#1727148 (atgo) Feedback about reporting below. Let me know if it... [01:05:13] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising Sprint Vengaboys, and 4 others: Prepare CiviCRM 4.6 upstream and Giant Rabbit branches - https://phabricator.wikimedia.org/T99837#1727168 (Eileenmcnaughton) I'm seeing your report - so I'll dig... [07:54:17] Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Infrastructure: CI for Civi: provision and run tests under Jenkins/Zuul - https://phabricator.wikimedia.org/T86103#1727426 (hashar) A left over task is {T91911} it has a pull request with upstream. @awight let us know if you need any more support / t... [07:54:32] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Easy, Upstream: Point amp cache to $WORKSPACE - https://phabricator.wikimedia.org/T91911#1727427 (hashar) [15:02:12] Fundraising-Backlog: Recent iframe errors from up-to-date browsers - https://phabricator.wikimedia.org/T112181#1728291 (MBeat33) We are seeing more of these iframe errors - I am following up with 4 donors for more specs, but an Italian donor using Windows 10, internet explorer 11 and Firefox sent a screensho... [15:05:39] Fundraising-Backlog: Recent iframe errors from up-to-date browsers - https://phabricator.wikimedia.org/T112181#1728294 (Ppena) @Mbeat [15:05:59] Fundraising-Backlog: Recent iframe errors from up-to-date browsers - https://phabricator.wikimedia.org/T112181#1728295 (Ppena) @Mbeat what is the final count of people affected so far? [15:08:00] Fundraising-Backlog: Recent iframe errors from up-to-date browsers - https://phabricator.wikimedia.org/T112181#1728296 (MBeat33) @PPena, as many as 14 this month, but tough to know for sure as some donors go on to use other browsers [16:10:02] good morning awight & ejegg [16:13:23] ejegg: re:Amazon being ready, are you able to announce that to the rest of fr-online? Or do you still have anything to tidy up? [16:15:44] Fundraising-Backlog: Sprint X goal (11/11 - 11/25): - https://phabricator.wikimedia.org/T115622#1728427 (atgo) [16:16:26] Fundraising-Backlog: Sprint Y goal: - https://phabricator.wikimedia.org/T115623#1728430 (atgo) NEW [16:16:54] hi cwdent [16:17:09] Fundraising-Backlog: Sprint Y goal (11/25 - 12/9): - https://phabricator.wikimedia.org/T115623#1728445 (atgo) [16:17:24] dstrine: just running a few more audit files and looking at the recorded contributions [16:17:34] then I'll write the email to fr-online [16:17:45] Fundraising-Backlog: Sprint Y goal (11/25 - 12/9): Kick off Big English!! - https://phabricator.wikimedia.org/T115623#1728430 (atgo) [16:17:59] Fundraising-Backlog: Sprint X goal (11/11 - 11/25, Thanksgiving & payment processor freak week): - https://phabricator.wikimedia.org/T115622#1728452 (atgo) [16:19:55] ejegg: ok thanks! [16:22:20] surprise new error from WP, test isn't going to happen [16:22:34] aw man [16:22:51] * cwdent deep breaths [16:26:20] i don't believe this has deployed yet: https://gerrit.wikimedia.org/r/#/c/245980/ [16:26:47] might have something to do with it [16:26:52] but we've never sent this field before [16:28:47] yeah, there's a few things in the DI deploy pipeline [16:28:50] ejegg: looks like quite a few commits since we've deployed DI...how do you feel about one? [16:28:51] heh [16:29:22] I'm feeling pretty confident that the recurring stuff doesn't break one-time amazon donations [16:30:25] three of those were already deployed in a cherry-pick on Friday [16:30:40] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, WorkType-NewFunctionality: Create an import method for matching gifts and payroll deductions - https://phabricator.wikimedia.org/T115044#1728489 (CaitVirtue) The side effects that Adam describes above are untenable for our team. Specifically, the fi... [16:30:49] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Train Engage in how to fill out the generic import templates - https://phabricator.wikimedia.org/T114687#1703001 (atgo) [16:31:50] cool, well ejegg if you have no objections i'll deploy [16:31:58] let's do it! [16:37:04] (PS1) Cdentinger: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/246700 [16:39:08] (CR) Cdentinger: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/246700 (owner: Cdentinger) [16:39:43] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Edits to LYBUNT report - https://phabricator.wikimedia.org/T88819#1728518 (CaitVirtue) @XenoRyet I'm available if you have questions on this! thx. [16:43:33] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Estimate closing the gap for Civi to be up to snuff - https://phabricator.wikimedia.org/T115627#1728536 (atgo) NEW [16:44:59] come on zuul [16:45:07] take forever [16:47:46] Sorry we're stuck in this priorities meeting [16:47:53] This WP thing sounds epic [16:48:18] cwdent: you can force that merge if desired [16:48:58] it's almost there [16:51:24] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/246700 (owner: Cdentinger) [16:55:15] (PS1) Cdentinger: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/246707 [16:56:50] (CR) Cdentinger: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/246707 (owner: Cdentinger) [16:59:22] whew, back now [17:01:23] hiya [17:01:42] just waiting on rel125 to merge [17:11:51] hey AndyRussG - do we have a way to get data about the banner bump? [17:11:57] like… do we know if it's changed? [17:12:17] atgomez1: hi! We don't have anything just "available" [17:12:32] one sec [17:13:40] atgomez1: it'd be a bit of investigation. How much depends on how detailed data they want [17:13:58] atgomez1: ...or how accurate they want the data [17:14:52] atgomez1: I'd assume they would like to study how it impacts donations? that _would_ involve building out some special infrastructure, I think [17:15:26] Otherwise, we could just add some "points" for performance timings and run some tests on different platforms [17:15:55] Best of course would be to measure in real-world conditions [17:16:12] And the best way to do that would be to ask how the Perf team is doing similar stuff for other components, and follow that [17:16:42] (PS1) Ejegg: Update name pattern for Amazon audit to find logs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/246708 (https://phabricator.wikimedia.org/T111425) [17:16:48] So it could be anything from a tiny task to a pretty big one [17:18:41] !log updated payments from ba8f80ec7a858074cd3856a52f3758cf96571f67 to bdec3220030a396e2a447763e40b940a332e2ab8 [17:18:45] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:19:07] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Edits to LYBUNT report - https://phabricator.wikimedia.org/T88819#1728696 (XenoRyet) @CaitVirtue Yea, I've been getting my head around the whole thing, but I was just about to reach out. If... [17:20:46] cwdent: well, Amazon donation still seems to work [17:21:17] * cwdent wipes brow [17:22:05] got a tiny fix for audit parsing if you have a sec after any post-deploy checks [17:22:10] https://gerrit.wikimedia.org/r/246708 [17:30:30] cwdent: so... it was the new parameter that we weren't passing until they asked us to? You'd think they would have mentioned "oh, suddenly nothing will work unless you make this undocumented change" [17:31:42] wow. yeah I suppose so [17:31:58] awight: well we don't necessarily know that was it yet [17:32:03] might still fail post fraud check [17:32:26] Just watched the Office Space fax machine beatdown for therapy ;) [17:33:07] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1728741 (Jgreen) >>! In T97676#1726675, @ellery wrote: > 1:10 is already much bette... [17:39:10] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1728747 (awight) @ellery: just noting that there's still an open question for you,... [17:40:38] (CR) Awight: [C: 2] Update name pattern for Amazon audit to find logs (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/246708 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [17:40:46] thanks awight [17:41:23] (Merged) jenkins-bot: Update name pattern for Amazon audit to find logs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/246708 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [17:41:28] Lmk if it's annoying that I merge things where I've also commented that things need fixin... [17:42:15] nah, I'm fine fixing in follow-on patches [17:42:53] awight: ejegg: cwdent: XenoRyet: hi! rrg I got the drupal hoook to run to create the BH table in civi... Now trying to understand other queue consuming code... [17:43:17] nice [17:43:23] thx! [17:43:25] * AndyRussG wipes brow [17:43:34] Silly invisible typos [17:43:44] I got a bit Byzantine on the queue consuming code... [17:43:54] Which other queue consuming stuff should I be copying again? Also does the BH in Civi need any kind of interface, web, drush or otherwise? [17:44:12] I was kinda assuming it'd just run and be queried db-side, but maybe I'm wrong 8p [17:44:14] wmf_unsubscribe_qc is a good sample, IIR [17:44:28] cool! [17:44:35] nah, no UI requierd [17:44:36] red [17:45:02] drush commands? I see unsubscribe has'em [17:45:23] yes! [17:45:28] we'll need that to run the job from [17:45:29] Jenkins [17:45:31] K [17:45:40] * awight glares at key [17:45:46] awight: ahhh K [17:46:03] So the queue consumers are all drush commands run as jobs from Jenkins? [17:46:14] yep [17:46:26] K gotcha :) [17:48:14] I should write this somewhere... fyi, when writing new Drupal code we're trying to put all the business logic in real classes. The global function thing mandated by Drupal is horrific, so we'd like to make those functions really short and just dispatch to more reusable classes. [17:49:12] hmmm K [17:49:20] is drush queue-list anything? [17:49:24] * AndyRussG can't find the code 4 that [17:49:55] wat is that [17:51:14] AndyRussG: looks like that's built into drush, something unrelated [17:56:38] awight: ahh k thx! [17:58:12] hmm http://drushcommands.com/drush-6x/queue/queue-list [17:58:34] ahahaha! [17:59:03] sorry nothing [17:59:45] * AndyRussG hides behind straightjacket [17:59:53] s/behind/in/ [18:02:00] These function and file naming conventions are killing me, BTW [18:02:03] AndyRussG: just cos you'll probably run into this question, you'll want to use a "batch time" limit to prevent overlapping jobs [18:02:16] AndyRussG: There is nothing redeeming in Drupal [18:02:33] But I was looking forward to overlapping jobs! [18:02:33] It's even a huge PITA to admin or use [18:02:35] (jk) [18:02:40] Hmmm [18:02:56] Should we have gone for Joomla instead then= [18:02:57] ? [18:03:01] hehe [18:03:29] only if we time-travelled fifteen years back or so and it was a good option :p [18:04:28] hmmm K legacy! [18:04:52] also, why does putting honey on a PB sandwich make the PB less sticky? [18:04:55] sorry jk again [18:06:59] I know... I find myself happily gawing my limbs off when writing Drupal modules. [18:09:23] (PS1) Ejegg: Comment out trigger creation [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/246714 [18:10:22] (PS5) Ejegg: Tests for Amazon audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244616 (https://phabricator.wikimedia.org/T111425) [18:10:29] drawback: people have a limited number of limbs, but could write a nearly unlimited amount of drupal code [18:10:49] awight: where are these "real classes" ^ of which you speak? [18:10:55] * awight gasps at the opaque URLs referenced on their own documentation pages, e.g. https://www.drupal.org/node/146843 [18:11:07] AndyRussG: e.g. wmf_common/Queue.php [18:11:28] (CR) jenkins-bot: [V: -1] Tests for Amazon audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244616 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [18:11:34] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/246715 [18:11:34] rather than a mush of global functions à la wmf_civicrm.module [18:12:01] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/246715 (owner: Ejegg) [18:13:05] !log updated CiviCRM from 17dc351d92a8437c93b4a9fa2385840b3581dad6 to ddfaa209f5b5af4aa0cf3403da91d39b3c52acc1 [18:13:09] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:13:10] (CR) Awight: WIP add banner_history module (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/246425 (https://phabricator.wikimedia.org/T112022) (owner: AndyRussG) [18:20:47] awight: wmf_common? what, function names without underscores?!?? [18:21:42] also, how does that interface with the drupal module structure? Should I be putting stuff in there? or maybe somewhere else? [18:24:12] IMO, you're good writing a new banner_history module, cos this is elective infrastructure. [18:24:59] You could squeeze in parallel to tracking.inc if you wanted, but that's a poor example to follow cos the code is not paired with the schema, etc. [18:26:10] Yeah, prefixed functions are maddening, it takes a disproportionate chunk of one's brain to allow one to ignore those, IMO [18:26:46] need some function prefix glasses [18:26:56] (PS1) Cdentinger: Just send IsCVNMEM is every request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/246716 [18:27:34] PT/S is the last request we were NOT sending IsCVNMEM so ^ [18:28:15] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fulltext search for name and org name in Civi - https://phabricator.wikimedia.org/T115536#1728849 (awight) [18:29:42] (PS2) Awight: Just send IsCVNMEM with every request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/246716 (owner: Cdentinger) [18:31:20] derp [18:31:43] (CR) Awight: [C: 2] "Please note on T112665 that IsVerify is now broken for the wmf-hosted workflow..." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/246716 (owner: Cdentinger) [18:32:09] (Merged) jenkins-bot: Just send IsCVNMEM with every request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/246716 (owner: Cdentinger) [18:33:10] AndyRussG: those goggles can cause irreversible damage :( looking for the study now, but I remember up-down swapped kittens never got better. [18:33:36] noooo I did not want to imagine that! [18:33:45] * AndyRussG needs a brain-rinse [18:34:01] nooo don't google [18:34:05] don't [18:34:06] do- [18:34:46] sorry [18:34:53] that totally did happen [18:35:08] Turns out, even humans can very quickly get used to right-left swapping [18:35:55] https://books.google.com/books?id=L260oWc2vmQC&pg=PA245&lpg=PA245&dq=kittens+up+down+glasses&source=bl&ots=8mD-jfKVNX&sig=zNQ98kInbUJg7u2MlCqLYRRF6S0&hl=en&sa=X&ved=0CE4Q6AEwDGoVChMIod2fjI_FyAIVyZuICh2aEALp#v=onepage&q=kittens%20up%20down%20glasses&f=false [18:36:15] http://onlinelibrary.wiley.com/doi/10.1113/jphysiol.1976.sp011361/pdf [18:37:14] (PS1) Cdentinger: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/246717 [18:37:25] * awight is soothed by how absurd the world is [18:37:33] "We also found, with the test litter of kittens, that head restraining devices irritated the kittens considerably" [18:37:40] * AndyRussG cries [18:38:03] (CR) Cdentinger: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/246717 (owner: Cdentinger) [18:38:22] (CR) jenkins-bot: [V: -1] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/246717 (owner: Cdentinger) [18:40:23] (CR) Awight: "recheck" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/246717 (owner: Cdentinger) [18:40:40] (CR) Awight: [C: 2 V: 2] "Overriding asinine Jenkins thing" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/246717 (owner: Cdentinger) [18:41:05] Deleting Jenkins as a reviewer seems to help :p [18:41:11] haha [18:41:13] wat [18:41:24] !log updated refund queue name in IPN listener settings [18:41:26] mentioning that in -releng [18:41:28] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:42:40] #wikimedia-releng, fyi [18:43:01] (PS1) Ejegg: Fix default refund queue name [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/246720 [18:43:14] (PS1) Cdentinger: Update DonationInterface for deploy [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/246721 [18:44:07] (CR) Cdentinger: [C: 2] Update DonationInterface for deploy [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/246721 (owner: Cdentinger) [18:47:23] cwdent: fyi, legoktm just forwarded the background on that build failure: https://phabricator.wikimedia.org/T90816 -- it's an upstream thing, where parallel builds cause faceplant [18:47:44] "recheck" would have been enuf [18:47:48] hmm [18:47:56] hopefully I didn't break everything by forcing the submit :) [18:47:59] I think you guys might be using old versions of libraries? [18:48:05] 18:38:11 npm WARN deprecated grunt-jscs-checker@0.8.1: Package was renamed to 'grunt-jscs' [18:48:05] I'm sure of it... [18:48:40] https://www.mediawiki.org/wiki/User:Legoktm/ci most everyone else is on 2.1.0 [18:48:44] What's the best way to stay up-to-date? I like the thought that CI support could be isolated in a separate repo, btw... [18:49:34] James_F and I typically do batch upgrades with a script, except it would have skipped this one because it's not using the name "grunt-jscs" [18:50:11] https://gerrit.wikimedia.org/r/#/q/status:merged+topic:bump-dev-deps,n,z [18:55:00] Fundraising-Backlog, Continuous-Integration-Config: Use the name "grunt-jscs" in all Fundraising CI glue - https://phabricator.wikimedia.org/T115642#1728902 (awight) NEW [18:56:01] Fundraising-Backlog, Continuous-Integration-Config: Use the name "grunt-jscs" in all Fundraising CI glue - https://phabricator.wikimedia.org/T115642#1728909 (awight) [18:58:00] (CR) Awight: "@ejegg: What about setting this in config overrides, instead? Seems like our production name is the inconsistent one, and we could leave " [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/246720 (owner: Ejegg) [18:59:32] (CR) Awight: [C: 2] "Thanks!" [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/246450 (owner: Eileen) [19:02:36] so publish and submit does not actually submit? [19:04:43] cwdent: I think it only works if the V+2 is already granted [19:05:08] Clearly Drupal's naming of its queue function "watchdog" instead of "watchcat" was a grave mistake [19:05:16] sorry I meant log function [19:05:26] ahh [19:05:27] another grave mistake! [19:05:36] what was the fix for Archives directory /vagrant/cache/apt/partial is missing. ? [19:05:36] (CR) Awight: [C: 2] CRM-17310 my reports (1 comment) [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243860 (owner: Eileen) [19:06:25] (CR) Ejegg: "Sure, that works. I'll make sure the vagrant SmashPig config matches the queues defined in vagrant Civi" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/246720 (owner: Ejegg) [19:06:31] (Abandoned) Ejegg: Fix default refund queue name [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/246720 (owner: Ejegg) [19:06:42] (Merged) jenkins-bot: Remove custom quicksearch hook [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/246450 (owner: Eileen) [19:07:30] (Merged) jenkins-bot: CRM-17310 my reports [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243860 (owner: Eileen) [19:08:29] (CR) Awight: [C: -1] "Thanks! A little unclear that this is a multiline comment..." (1 comment) [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/246714 (owner: Ejegg) [19:08:44] !log updated payments from bdec3220030a396e2a447763e40b940a332e2ab8 to 33b3bd6bee11b3cc9de1570584a23354d0b6525f [19:08:49] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [19:10:39] (CR) Awight: "@AndyRussG: rats, can't be automatically rebased" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235759 (https://phabricator.wikimedia.org/T111387) (owner: AndyRussG) [19:11:51] (CR) Awight: [C: 2] "Awesome!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/240630 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg) [19:11:55] (PS2) Awight: Make refund import logic reusable [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/240630 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg) [19:12:08] (PS4) Awight: Add help link to Special:CentralNotice and Special:CentralNoticeBanners/edit [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234831 (owner: Glaisher) [19:14:18] (CR) Awight: [C: 1] "Thanks! I think this satisfies AndyRussG's comment, but will defer to him. Documentation links seems like a pretty safe thing to hardcod" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234831 (owner: Glaisher) [19:15:32] (CR) Awight: [C: -1] "-1'ing because I think that reflects the status of the blocking task. Please correct me if this is wrong!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239925 (owner: Cdentinger) [19:25:34] (PS4) Awight: Truncate referrers when hosts match a pattern [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/232218 (https://phabricator.wikimedia.org/T110564) (owner: Ejegg) [19:37:29] (PS1) Ejegg: Use random temp dirs in unit tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/246764 [19:38:24] (PS6) Ejegg: Tests for Amazon audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244616 (https://phabricator.wikimedia.org/T111425) [19:38:26] (PS1) Awight: Update civicrm submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/246766 (https://phabricator.wikimedia.org/T105918) [19:38:49] (CR) Awight: [C: 2] Update civicrm submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/246766 (https://phabricator.wikimedia.org/T105918) (owner: Awight) [19:38:53] (Merged) jenkins-bot: Update civicrm submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/246766 (https://phabricator.wikimedia.org/T105918) (owner: Awight) [19:39:18] (CR) jenkins-bot: [V: -1] Tests for Amazon audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244616 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [19:39:57] (PS7) Ejegg: Tests for Amazon audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244616 (https://phabricator.wikimedia.org/T111425) [19:40:39] (CR) Ejegg: Tests for Amazon audit processor (5 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244616 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [19:41:21] !log update crm from ddfaa209f5b5af4aa0cf3403da91d39b3c52acc1 to a4e74f6f38e6cff16ecf79d28d6e4de9499a5017 [19:41:25] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [19:41:31] (CR) Ejegg: "PS6: rebased onto tempDir patch" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/244616 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [19:44:22] (PS2) Awight: Use random temp dirs in unit tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/246764 (owner: Ejegg) [19:45:31] (PS2) Ejegg: Comment out trigger creation [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/246714 [19:46:05] (CR) Awight: [C: 2] "Reuse! Fancy!" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/246764 (owner: Ejegg) [19:47:13] Love that auto-substitution of - for _ in function names vs. drush command names [19:47:16] (Abandoned) Ejegg: WIP move subscription cancel into its own script [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/236204 (https://phabricator.wikimedia.org/T110917) (owner: Ejegg) [19:47:33] (PS1) Awight: Update French thank-you [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/246770 (https://phabricator.wikimedia.org/T115496) [19:51:09] Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, and 4 others: Adding 1 Custom field to "primary fields" export list: Do Not Solicit - https://phabricator.wikimedia.org/T105918#1729107 (awight) @CaitVirtue: This is ready... [19:51:55] (Merged) jenkins-bot: Use random temp dirs in unit tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/246764 (owner: Ejegg) [19:52:01] AndyRussG: it's made entirely of evil dancing toothpicks and barbed-wire floss [19:52:13] oulch! [19:52:57] just getting in a Halloweeny mood [19:53:26] heh [19:56:27] Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: Deploy new French TY email - https://phabricator.wikimedia.org/T115496#1729117 (awight) @jrobell: okay, the new French letter is deployed to the staging server! [19:58:38] Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: Deploy new French TY email - https://phabricator.wikimedia.org/T115496#1729125 (awight) a:awight [20:05:32] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: Record actual amount charged regardless of what's in session - https://phabricator.wikimedia.org/T115171#1729155 (Ejegg) a:Ejegg [20:43:16] Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: Deploy new French TY email - https://phabricator.wikimedia.org/T115496#1729276 (Pcoombe) @jrobell Forgive the pedantry, but donations in the Netherlands are also tax-deductible (https://wikimediafoundation.org/wiki/Tax_Deductibility/e... [20:58:05] eileen: What was that error you were getting? [20:58:39] awight: code coverage error? [20:59:43] I'll have to re-run it - give me 10 to get it [21:04:46] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Edits to LYBUNT report - https://phabricator.wikimedia.org/T88819#1729376 (Eileenmcnaughton) Are you fixing on 4.2 or 4.6 - because you might be looking at quite different behaviours between t... [21:05:09] Why is the same help message repeated here unsubscribe_queue_consume_drush_command() and here unsubscribe_queue_consume_drush_help() ? [21:05:15] Should I do that? [21:06:40] hmm, not seeing the _help hook at http://www.drush.org/en/master/commands/ [21:07:47] ahh, elsewhere I find : [21:07:51] The drush_help hook is an optional place to describe a command in long form. If the command only requires a brief description, use the description key in COMMANDFILE_drush_command()." [21:07:54] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Edits to LYBUNT report - https://phabricator.wikimedia.org/T88819#1729397 (awight) I believe we're using entirely custom code for the LYBUNT report, that relies on precomputed values rather th... [21:08:07] AndyRussG: yeah, the duplication is really unfortunate [21:08:19] AndyRussG: so, no need unless you have a longer description available [21:08:30] ejegg: ah ok thx [21:09:02] fwiw, the different paths are run when you do general 'drush help', vs 'drush help my-command' [21:11:51] Wikimedia-Fundraising: Back button breaks the banner form - https://phabricator.wikimedia.org/T114391#1729478 (atgo) @awight is this an fr-tech thing or a @pcoombe thing? [21:12:09] Fundraising-Backlog, Continuous-Integration-Config, Patch-For-Review, WorkType-Maintenance: Switch wikimedia/fundraising/slander to use tox as an entry point - https://phabricator.wikimedia.org/T114250#1729480 (atgo) [21:12:21] Wikimedia-Fundraising: Back button breaks the banner form - https://phabricator.wikimedia.org/T114391#1729484 (awight) It's a banner thing! [21:12:22] Ahh k gotcha [21:12:33] Fundraising Tech Backlog, Fundraising-Backlog, Continuous-Integration-Config, Patch-For-Review: wikimedia/fundraising/tools should pass python lint checks (flake8) - https://phabricator.wikimedia.org/T114218#1729495 (atgo) [21:16:50] Fundraising Tech Backlog, Team-Practices-This-Week: Measure Maintenance Fraction for FR-Tech - https://phabricator.wikimedia.org/T114328#1729508 (Awjrichards) p:Triage>Normal [21:22:24] (CR) Eileen: CRM-17310 my reports (1 comment) [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243860 (owner: Eileen) [21:23:10] (CR) Eileen: "Oh - that didn't work did it - because it was merged - will do another" [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243860 (owner: Eileen) [21:24:59] awight: I think it makes sense to merge the annotations? https://gerrit.wikimedia.org/r/#/c/235359/ or just leave in gerrit? [21:28:45] (PS1) Eileen: CRM-17310 further fix to my reports [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/246786 [21:28:47] (CR) Awight: [C: 2] "Fantastic work!" (2 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/235359 (https://phabricator.wikimedia.org/T99836) (owner: Eileen) [21:29:23] (PS2) Eileen: CRM-17310 further fix to my reports [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/246786 [21:30:21] (Merged) jenkins-bot: Annotate CiviCRM patches [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/235359 (https://phabricator.wikimedia.org/T99836) (owner: Eileen) [21:32:44] eileen: shall we work on the new repo today? [21:33:06] awight: sure - good idea [21:33:22] It looks like we're best off with an entirely new repo, true? [21:33:33] yeah [21:33:52] https://www.mediawiki.org/wiki/Git/New_repositories/Requests [21:33:58] I can file it... [21:33:59] they can be branches - but i think that's confusing [21:34:08] we need more than one.... [21:34:10] yeah plus I really wouldn't want to rename the "master" branch [21:34:46] the distmaker script expects 5 repos I think [21:34:47] It would be nice to break with the current wikimedia/crm/civicrm pattern, if you can think of an improvement on that? [21:34:53] ooh [21:35:01] okay, that's a good start :) [21:35:14] civicrm-core civicrm-packages civicrm-drupal civicrm-joomla civicrm-wordpress [21:35:46] (hopefully we can drop out the last 2 - I did log against buildkit & can possibly hit Tim up about it) [21:36:05] https://github.com/civicrm/civicrm-buildkit/issues/190 [21:37:55] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Integrate thank-you module with CiviCRM receipt feature - https://phabricator.wikimedia.org/T115662#1729584 (awight) NEW [21:44:01] (Abandoned) Eileen: Pretty-print upgrade outputs [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/242827 (https://phabricator.wikimedia.org/T99842) (owner: Awight) [21:46:30] (CR) Eileen: "Did you hit this when installing locally? I feel like we kind of left it in in the end - but now I'm feeling confused." [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/246714 (owner: Ejegg) [21:46:58] eileen: do you prefer wikimedia/fundraising/civicrm-core or wikimedia/fundraising/civicrm/core ? [21:51:16] (CR) Ejegg: "Yep, this was preventing me from running the upgrade script, even if I granted trigger permissions, since it was trying to redefine an exi" [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/246714 (owner: Ejegg) [21:53:16] (PS2) Ejegg: Update French thank-you [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/246770 (https://phabricator.wikimedia.org/T115496) (owner: Awight) [21:53:38] (CR) Ejegg: [C: 2] Update French thank-you [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/246770 (https://phabricator.wikimedia.org/T115496) (owner: Awight) [21:54:50] (Merged) jenkins-bot: Update French thank-you [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/246770 (https://phabricator.wikimedia.org/T115496) (owner: Awight) [22:01:28] awight: use civicrm-core [22:01:42] it matches the upstream repo name which helps [22:03:03] awesome [22:03:04] ok, creating now [22:03:37] Are -joomla and -wordpress optional? [22:03:53] meh, small difference [22:05:33] using e.g. https://github.com/civicrm/civicrm-core ... [22:08:20] awight: just thinking about that [22:08:44] the reason fuzion needed the full 5 was that we didn't follow their branch names [22:08:58] ie. we have 4.6.9 whereas core only has 4.6 [22:09:42] I think that still applies - unless we can sort out the issue above against buildkit - but I'm not feeling like tim is online atm so might have a delay getting that answer [22:09:42] ooh [22:09:49] they should have a release branch [22:10:02] yeah - they tag a release [22:10:09] nvm actually, I prefer rel_4.6 i think [22:10:21] cos the branch pointer shoulud never change [22:10:44] right - the reason fuzion does one per point release is every point release I do a rebase [22:10:53] ie. git checkout -b 4.6.10 [22:10:54] so you think we should do the initial clone from fuzion's repo? [22:11:00] git pull —rebase origin 4.6 [22:11:25] starting point is this branch [22:11:27] https://github.com/fuzionnz/civicrm-core/commits/4.6.9-wmf [22:12:03] which is a few patches behind the deploy but I can fix that easily [22:12:41] awesome. and for the other 4, also fuzion? [22:13:56] yes - so I created a wmf specific branch for each of them to generate the tarball I checked in originally [22:13:57] https://github.com/fuzionnz/civicrm-packages/commits/4.6.9-wmf [22:14:47] just to be annoying the drupal one uses different branch names https://github.com/fuzionnz/civicrm-drupal/commits/7.x-4.6.9-wmf [22:16:14] ok. https://github.com/fuzionnz/civicrm-joomla/commits/4.6.9-wmf and https://github.com/fuzionnz/civicrm-wordpress/commits/4.6.9-wmf [22:16:36] https://www.mediawiki.org/wiki/Git/New_repositories/Requests [22:16:38] at the end. [22:16:39] filed! [22:17:03] Someone usually gets to those within a few hours or days. [22:18:18] awight: so in order to compile from those repos to a tarball & ultimately git [22:18:25] a script needs to run on them [22:18:56] the easiest way to run the script is to set up a dist instance using buildkit [22:19:04] youch. Should we make a sixth repo to hold the compiled stuff? [22:20:13] right so the 6th repo could be the existing one [22:20:20] ooh, interesting [22:20:28] but the "master" branch will be what? [22:20:31] ie. once it's all compiled we untar & commit to master [22:20:55] are all the compiled things encapsulated in civicrm-core? [22:21:08] yeah - so if you look here http://dist.civicrm.org/ [22:21:23] civicrm has a dist site created by buildkit [22:21:42] & then they run a nightly cron (which is quite straight-forward) [22:21:57] & it generates a tarball for every code change [22:22:12] m [22:22:25] m [22:22:43] ie each hash represents a code change - the by-date links are all symlinks [22:22:46] -mari u0gvbfdris learning all the letters [22:23:40] what about, civicrm-dist, master branch is all the repos saved in a flat structure, and deployment is compiled? [22:23:40] :-) [22:23:42] I don't like it... [22:24:19] hmm - so you mean civicrm-dist is basically a bunch of submodule pointers? [22:24:41] ooh, interesting. [22:24:52] I really wish the compiled stuff were going into a build directory [22:24:59] such a PITA to have it mixed in with code [22:25:32] by that you mean you wish that the civicrm-core repo was the same as the relevant folder in deployed? [22:26:29] yes, exactly [22:26:37] the thinking going forwards is that things are being moved from packages to composer - but that doesn't make the version in the repo much closer [22:26:41] not the way the world is moving, unfortunately [22:27:21] composer is cleaner but you still have to checkout & then run 'something' [22:27:26] the way our other repos work fwiw, which I am not particularly proud of but it works, is that the master branch gitignores vendor/, and the deployment branch has a submodule vendor/ [22:28:34] so, to get the initial commit for 4.6.9 I basically used those 5 source directories & ran the script & grabbed the tarball & untarred it & checked it in [22:29:26] That sounds perfect. We should have a script that does that [22:29:31] yeah [22:29:34] I agree [22:29:57] maybe stop before checking in... [22:30:16] git review rather than check in maybe [22:30:43] i mean, this compile script should end its responsibility well before any git operations. [22:30:50] if we want a second script to git it up, that's fine [22:30:54] ok [22:31:02] but currently we don't have that for any other repos [22:31:10] so would be worth the effort to standardize what we're doing. [22:31:39] so ideally we would also set-up jenkins to run civicrm-core unit tests over our repos [22:31:50] Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Create new civicrm repo - https://phabricator.wikimedia.org/T114831#1729762 (awight) Filed requests here, https://www.mediawiki.org/wiki/Git/New_repositories/Requests [22:32:03] daily or something (although it is a bit slow/hungry) [22:32:48] yes!! [22:32:57] core has jenkins set up to both run the tests & build the tarballs [22:33:21] i don't see us needing tarballs until anyone else uses our stuff [22:33:39] but I get whatchu mean--we should run full tests on every new release tag [22:33:53] preferrably before deploying, but in parallel at the least. [22:34:00] it's just the way distmaker currently works - I could talk to tim about having an option to output to a folder [22:34:25] & my pref for doing it in the civibuild dis env is just that it makes it easier [22:34:55] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Integrate thank-you module with CiviCRM receipt feature - https://phabricator.wikimedia.org/T115662#1729772 (awight) [22:34:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi Send Receipt? check box - review and filter what info it generates, or disable - https://phabricator.wikimedia.org/T108088#1729773 (awight) [22:42:33] so awight I guess the question is - once we have the repos do we a) compile a bunch of instructions for people to set up buildkit locally & generate the tarballs or b) set up a job on 'a' server somewhere that does it (currently I have a job on a fuzion server but that's not the long-term plan…) [22:43:16] eileen: sorry, I just had to give Mari a new job--scrubbing her own poopy underwear :) [22:43:22] been looking forward to that moment [22:43:56] you're saying the tarball thing is hardcoded? That's annoying, but maybe there's at least an intermediate directory already? [22:45:17] civibuild is def the way to go, I agree. Happy to make lots of compromise to get the benefit of a reusable build script. [22:45:29] Tell me it doesn't create the databases, though? [22:48:01] awight: just trying it locally to see what happens… civibuild create dist [22:48:22] also - I got some feedback from tim https://github.com/civicrm/civicrm-buildkit/issues/190 [22:52:41] awight: it DID create dbs - once per dist install - not once per build [22:53:14] my guess is that will mean I can run civicm unit tests against it [22:54:18] what now? is it possible to run just the build part and not do into db-land? [22:54:29] just for the sake of elapsed time, if nothing else... [22:54:54] We'll be running this deployment script during some pretty dear prime time... [22:55:09] awight: in terms of running the build generate - that still only takes a couple of minutes [22:55:55] k [22:56:16] hmm - I'm going to try to get tim on irc based on his latest comments [22:57:00] https://etherpad.wikimedia.org/p/Civi_release_process [22:57:38] awight: wanna go on civicrm channel? [22:58:19] totally [23:04:53] Fundraising-Backlog: `drush parse-audit --test` moves files around - https://phabricator.wikimedia.org/T115675#1729843 (cwdent) NEW [23:13:25] Fundraising-Backlog: Recent iframe errors from up-to-date browsers - https://phabricator.wikimedia.org/T112181#1729851 (MBeat33) another donor provided feedback: OS: Windows-7 Ultimate, 64-bit Browser: Windows Internet Explorer, Version 11. {F2724820} ZD160488 [23:44:05] Wikimedia-Fundraising: Back button breaks the banner form - https://phabricator.wikimedia.org/T114391#1729888 (AndyRussG) Hopefully it's not related (?) but the [[ https://meta.wikimedia.org/w/index.php?title=MediaWiki%3AFR2013%2FResources%2FBannerFormCore.js&type=revision&diff=14112275&oldid=12835241 | bann... [23:46:40] (CR) Eileen: "Your comment is bothering me a bit - was it the drop statement that caused the issue?" [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/246714 (owner: Ejegg) [23:48:06] (CR) Eileen: "or was it that the trigger SHOULD have been dropped in order to create but that part was commented out..." [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/246714 (owner: Ejegg)