[01:00:27] (CR) Awight: [C: 2] "Thanks! It also seems silly to translate an HTTP error, but I agree with this conservative fix." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/247096 (owner: Alex Monk) [01:01:11] (Merged) jenkins-bot: Replace call to old wfMsg function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/247096 (owner: Alex Monk) [14:51:45] Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: Deploy new French TY email - https://phabricator.wikimedia.org/T115496#1734967 (jrobell) Hi @awight, I have updated the Thank you email in French again and re-published. Would you be able to set it up for staging? FYI, this was th... [14:54:10] (Abandoned) Pcoombe: Make "JimmyQuote" default appeal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242169 (https://phabricator.wikimedia.org/T114127) (owner: Pcoombe) [15:16:10] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: URGENT: Renee needs an updated SSL cert for CiviCRM - https://phabricator.wikimedia.org/T115873#1735013 (CaitVirtue) NEW [15:20:12] (PS1) Cdentinger: Tighten worldpay®ex_for_recon for WPG [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/247286 [15:52:41] Fundraising-Backlog: Recent iframe errors from up-to-date browsers - https://phabricator.wikimedia.org/T112181#1735111 (MBeat33) another donor reported an iframe error using Internet Explorer, 11.096, with flash player blocked - but they were able to then use Chrome. ZD160920 [16:44:39] cwdent: Anything I can do to help with the stuff? [16:44:51] You still have a submodule logjam? [16:45:03] awight: i think i might have figured it out [16:45:14] it's nasty! [16:45:17] composer install vs update behavior [16:45:26] finally just read about it [16:45:45] blaaahrgh [16:45:46] right [16:46:30] we're checking in composer.lock, so you'll want to use composer install to sync your vendor/ with everyone else, but composer update when you're pushing new versions of libraries [16:46:58] yeah...update updates .lock? [16:47:13] we're tracking "dev-master" in .json for smashpig...what does that mean exactly? [16:47:38] awight: also https://gerrit.wikimedia.org/r/#/c/247286/ [16:47:55] regex_for_* get called w/ magic [16:49:03] yep, update updates .lock [16:49:52] dev-master is evil magick which causes composer update to lock to the head of the "master" branch directly in the VCS repo, rather than going through packagist. [16:50:09] but ejegg has been updating packagist release pointers as well, fyi [16:50:40] (CR) Awight: [C: 2] "win!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/247286 (owner: Cdentinger) [16:50:48] interesting... does --no-dev cause it to not? [16:51:07] or, what does dev- mean? why not just master? [16:51:19] --no-dev causes it to skip the development dependencies, "require-dev" key I believe [16:51:39] (Merged) jenkins-bot: Tighten worldpay®ex_for_recon for WPG [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/247286 (owner: Cdentinger) [16:51:45] donno why "dev-", I'm taking it for granted as something hardcoded into composer [16:52:10] good enough for me [16:52:30] Phew finally got that @·$!! banner history queue command to execute!!! [16:52:58] It's a dirty world, but it still spins... [16:54:22] spewing dirt out into space? [16:55:07] I just had to play find-the-lie in this tutorial http://www.sitepoint.com/drupal-create-drush-command/ [16:55:16] gah [16:55:44] I don't see it, do I want to? [16:56:32] AndyRussG: I usually read http://www.drush.org/en/master/commands/ [16:56:36] Eh don't worry you don't have to want to ;p [16:56:47] totally useless, but the info you need is somewhere in between the useless [16:56:54] "The first thing we need to do is add a new file to our module’s folder with the name ending in .drush.inc. Drush will scan the codebase and pick it up based on this name to load the functions we declare inside. It is also best practice to name this file after the module you place it in." [16:57:14] What's lieful there? [16:58:02] Rather it has to be .drush.inc [16:58:36] I think it can be named anything... [16:58:57] Try it! Go to unsubscribe_queue_consume.drush.inc and rename everything in there to unsubscribbe_queue_consume [16:59:05] It won't work unless you rename the file too [16:59:10] nooo [16:59:19] omg i hate Drupal and everything it stands for [16:59:19] wait, really? [16:59:29] At least that's what happened here [16:59:42] I mean, maybe my Drupal gained consciousness and is working to deceive me [16:59:53] I swear I defined multiple drush commands in a single file [17:00:18] yeah, exchange_rates.drush.inc defines both exchange-rates-update and exchange-rates-backfill [17:01:26] The thing that always gets me is that the hook_drush_command defines some commands which secretly map to function names drush+s/-/_/g [17:01:40] That's the part of Rails I really detest as well... [17:01:53] yeah... [17:01:56] oh god, the singular-plural mapping [17:02:26] yeah what a completely useless exercise [17:02:28] and confusing to boot [17:02:53] ejegg: well, I rename exchange_rates.drush.inc to exchange_rates_foo.drush.inc and do drush cc drush [17:03:00] but--you can redefine how to form the plural, if you have a table called "people"!! [17:03:10] and drush exchange-rates-backfill stops working [17:03:23] AndyRussG: maybe you have to drush cc drush? [17:03:29] Yes I did that [17:03:36] or :p destroy the VM. j/k I hope [17:03:36] hmm, let me try [17:04:16] It's not the module name, either--see unsubscribe_queue_consume.drush.inc [17:04:35] AndyRussG: I hit another fantasmic bug in drush, where sometimes it will insist on running "make-thank-you" instead of the "thank-you" job, based on some screwy command alias thing [17:04:36] the module is wmf_unscubscribe_qc [17:05:07] Hum! maybe related? [17:05:31] I just moved make_thank_you.drush.inc to make_thank_you2.drush.inc and it works... [17:05:47] awight: drush cc drush? [17:05:48] no! creepy [17:06:00] yeah it worked before I cleared the cache, and now it don't [17:06:04] AndyRussG: ok, i renamed exchange_rates and cleared cache and it can't find the commands inside it [17:06:18] lemme try disabling and re-enabling [17:06:25] I think we need to force the rescan [17:06:37] Hah! So our conscious Drupals are consipring together [17:07:08] ejegg: drush cc registry [17:07:51] even scarier!!! drush cc drush with the renamed .drush.inc caused drush commands from about half of our modules to disappear. [17:07:55] awight: still can't find the command [17:07:58] AndyRussG: so um... you're not alone :) [17:08:06] ejegg: me neither [17:08:07] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New SSL cert for Rosie Lewis - https://phabricator.wikimedia.org/T115889#1735453 (CaitVirtue) NEW [17:08:13] awight: whoa, really? like all the dependent modules? [17:08:13] none of us are [17:09:16] Now I renamed make_thank_you2 back to its original name, and *all* of the custom drush commands went away. [17:09:20] charmant [17:09:46] awight: cache? [17:09:52] oh nvm, I was in crm/ and not crm/drupal [17:10:15] guh, disable/enable didn't pick up the commands in the changed file [17:10:32] maybe it's a new feature, not yet in the doc? [17:10:40] mangle_all_hell [17:11:25] AndyRussG: well, I just reproduced exactly what you're talking about, again. [17:11:31] I think at some point I saw cc all not actually clearing everything [17:11:47] woo! [17:11:59] I get a hilarious error half the times I run drush cc all: [17:12:05] Drush command terminated abnormally due to an unrecoverable error. [error] [17:12:05] You can I think delete the cache itself, in my vagrant I think it's under /tmp [17:12:08] Error: Undefined index: code in [17:12:10] crm/sites/default/files/civicrm/templates_c/en_US/%%40/40D/40D353E1%%fatal.tpl.php, [17:12:14] line 52 [17:12:16] fatal error template dies fatally [17:12:16] :p [17:12:34] heh [17:12:34] amazing [17:12:58] Let's base mediawiki 3.0 on this [17:12:59] so it can die twice? It's not alive, it's undead! [17:13:17] hey AndyRussG - just to confirm, there's no reason at all that we shouldn't turn on banner history for the low level campaigns? [17:13:20] Maybe we can turn it into a new web browser [17:14:19] atgomez: as far as I know!! no one has seen anything unusual in donation rates right when Peter turned on BH logging for donate-clickers last week, right? someone checked? [17:14:32] i'll check [17:14:59] * awight chuckles [17:15:25] atgomez: cool! [17:16:50] i'm not sure what the blocker would be [17:17:19] atgomez: I think AndyRussG is being cautious that perhaps something in the new code is causing us to lose people [17:17:32] There's no reason to think that's happening--but we also have no evidence it is not [17:18:09] yeah, fair enough [17:18:14] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog: Parse Amazon last name data differently (or: review the way we receive Amazon name data) - https://phabricator.wikimedia.org/T86720#1735505 (Ejegg) [17:18:16] Fundraising-Backlog, Wikimedia-Fundraising, Epic: [epic] Amazon upgrade - https://phabricator.wikimedia.org/T87625#1735504 (Ejegg) [17:18:39] Fundraising-Backlog, Wikimedia-Fundraising, Epic: [epic] Amazon upgrade - https://phabricator.wikimedia.org/T87625#995438 (Ejegg) [17:18:40] Fundraising-Backlog: [EPIC] Amazon (embedded) internal test - https://phabricator.wikimedia.org/T108102#1735508 (Ejegg) Open>Resolved [17:18:56] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog: Parse Amazon last name data differently (or: review the way we receive Amazon name data) - https://phabricator.wikimedia.org/T86720#974825 (Ejegg) [17:18:57] Fundraising-Backlog: [EPIC] Amazon embedded 1-hour test version - https://phabricator.wikimedia.org/T108106#1735510 (Ejegg) [17:19:40] Fundraising-Backlog, Wikimedia-Fundraising, Epic: [epic] Amazon upgrade - https://phabricator.wikimedia.org/T87625#995438 (Ejegg) [17:19:41] Fundraising-Backlog: [EPIC] Amazon embedded 1-hour test version - https://phabricator.wikimedia.org/T108106#1735512 (Ejegg) Open>Resolved [17:20:03] Fundraising-Backlog, Wikimedia-Fundraising, Epic: [epic] Amazon upgrade - https://phabricator.wikimedia.org/T87625#995438 (Ejegg) [17:20:04] Fundraising-Backlog: [EPIC] Amazon embedded campaign ready version - https://phabricator.wikimedia.org/T108109#1735514 (Ejegg) Open>Resolved [17:21:19] atgomez: ^ yeah exactkt what awight said :) [17:21:59] atgomez: the new code that is running with the change that the-wub put out there runs exactly when people click to donate [17:22:15] So if there were some unexpected Javascript errors happening there, it could actually impact on donations [17:26:27] awight: composer install on crm deployment ended up with changed files in vendor such as composer/autoload_classmap.php and composer/installed.json that i don't see in other recent smashpig updates [17:26:57] atgomez: Do you know anything about ewulczyn's availability? Doesn't seem like he was planning to jump on FR until December or something? [17:28:10] nm! --no-dev [17:28:55] cwdent: gaaah. yeah, I hit that constantly. [17:32:24] commit smashpig -> update composer.lock -> commit crm -> merge to deployment -> composer install -> commit vendor -> bump submodule on crm/deployment [17:32:28] i don't see what's so complicated [17:33:24] heh, i keep meaning to script some of that crap [17:34:07] * awight breaks a champagne bottle on the vapor script :p [17:34:31] I swear I'm gonna write a Makefile, it's sort of a pasttime [17:34:55] https://github.com/adamwight/photo-booth/blob/master/Makefile [17:35:10] bash++ [17:36:07] ejegg: https://phabricator.wikimedia.org/T115771 [17:36:07] awight: thinking about the fullscreen banner swap mixin, seems like we might need to extend the mixin API [17:36:13] ooh [17:36:20] in what way? [17:36:24] AndyRussG: ^ [17:36:29] cwdent: oh cool [17:36:31] no pressure :p [17:37:26] awight: well, the mixin needs to let you pick one banner in a bucket as the 'fullscreen' banner, and another as the follow-on [17:37:44] and needs to have that pair of settings per bucket [17:38:27] so it's not as simple as a fixed number of parameters whose values are simple data types [17:38:49] ejegg: it can set the new bucket in the post-banner hook if it chooses to start with a full-screen, no? [17:39:00] ejegg: good questions on the phab task, BTW [17:39:14] Wikimedia-Fundraising-CiviCRM: Civi Question & Possible Task: Is there a more detailed change log than the one on the contact summary page? - https://phabricator.wikimedia.org/T88447#1735588 (awight) @CaitVirtue: I'm going to use this as the tracking task for "Civi change log sucks" that you mentioned last w... [17:39:24] AndyRussG: sure, that part fits with the current API [17:39:32] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi Question & Possible Task: Is there a more detailed change log than the one on the contact summary page? - https://phabricator.wikimedia.org/T88447#1011901 (awight) [17:39:39] I guess it's just the admin interface we'd need to extend [17:40:07] ejegg: Scary that yo umention [17:40:23] that you mention "bucket"... I'd like to move away from overloading the bucket concept, if possible [17:40:39] But totally, I like the idea of a banner picker for the mixin fields [17:40:41] awight: yeah that's another thing for... one day [17:40:55] I think fullscreen can be implemented entirely w/o buckets [17:41:10] ejegg: what do we need to extend for the admin interface? [17:42:07] AndyRussG: I thought we would need a pair of settings for each bucket, while the current interface only allows for a fixed number of parameters [17:42:46] unless we want to extend the schema for a banner to include 'isFullscreen' or something [17:43:37] even so, we'd need some way to designate a particular small banner as the followon to a particular large banner [17:44:00] ejegg: I imagined you were saying that the campaign mixin params should include a banner picker for that [17:45:22] ejegg: awight: I think we can go for a MVP just for December that just works for buckets A and B, following along in the pattern set out by existing scripts for this, no? [17:45:25] yeah, either a banner picker in the mixin params, or a callback that lets the mixin params mess with the banner assignment input area below [17:45:38] Eventually yes, different treatments etc etc, though I don't think we can do that now [17:46:00] (PS1) Cdentinger: Update SmashPig to b8ca986501838d5feacabd91473d6ee352e84bc4 [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/247306 [17:46:08] For now I'd suggest just work to not miss impressions for Dec, maybe I'm wrong of course [17:46:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi search by language should ignore variant - https://phabricator.wikimedia.org/T115896#1735619 (awight) NEW [17:46:29] AndyRussG: ah, I thought this task was where we wanted to get rid of that bucket swap voodoo. gotcha [17:46:54] ok, happy to scale back the requirements [17:47:05] * awight mmmphfs about how nice it would be... but slow is beautiful [17:47:53] is this supposed to go on master? https://gerrit.wikimedia.org/r/#/c/247306/ [17:47:54] ejegg: woo yeah that would be fun!! yeah sooooon I'd hope!! ;p [17:48:07] sorry if stuff wasn't clear 8p [17:48:24] cwdent: yeah, vendor only has a master branch [17:48:30] needs docs :( [17:48:42] is there a wiki page? if not i will make one [17:50:00] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Advanced search date range pulldown should populate date range fields - https://phabricator.wikimedia.org/T115897#1735630 (awight) NEW [17:50:13] maybe i'll update https://www.mediawiki.org/wiki/Fundraising_tech/Deployment [17:50:44] AndyRussG: no worries, i just got overambitious! [17:51:19] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Quicksearch (search bar) by email is unreliable - https://phabricator.wikimedia.org/T115898#1735637 (awight) NEW [17:52:15] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Advanced Search needs an OR operator - https://phabricator.wikimedia.org/T115900#1735651 (awight) NEW [17:52:18] awight: does that patch look ok? [17:52:27] the crm/vendor update [17:52:39] cwdent: looks perfect! [17:52:49] +1 [17:53:52] (CR) Cdentinger: [C: 2] Update SmashPig to b8ca986501838d5feacabd91473d6ee352e84bc4 [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/247306 (owner: Cdentinger) [17:54:16] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Remember some form settings in Advanced Search - https://phabricator.wikimedia.org/T115901#1735661 (awight) NEW [17:54:44] ejegg: cool, yeah I'm really glad that at least some of us haven't had overambitiousness sucked out of us by cold realism ;) [17:55:03] * awight shudders at how cold it is [17:55:59] ugh, awight ejegg i ended up with: psr/log/Psr/Log/LoggerAwareTrait.php [17:56:00] psr/log/Psr/Log/LoggerTrait.php [17:56:05] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Determine a process and schedule for renewing SSL certificates in Civi - https://phabricator.wikimedia.org/T115902#1735672 (CaitVirtue) NEW [17:56:07] i guess from composer? [17:56:20] ejegg: didja notice that there is one script that always does A -> C and B -> D bucketswitch on seen fullscreen, and another re-shuffles chosing C or D randomly for all fullscreenseeners [17:56:27] ? [17:56:30] cwdent: oh yeah, what a pain [17:56:43] should i commit those? [17:56:53] nope, it makes CI barf [17:57:02] aah, just delete? [17:57:09] ooh, maybe we should .gitignore them [17:57:17] cwdent: yeah, just delete for now [17:57:24] word [18:00:59] AndyRussG: ah, I didn't notice. I guess the c-d shuffle would be an option in the mixin [18:01:33] ejegg: yeah sounds great! [18:02:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Remember some form settings in Advanced Search - https://phabricator.wikimedia.org/T115901#1735712 (CaitVirtue) [18:03:47] ejegg: now that I think of it, I guess we might also ask atgo and the-wub just to be sure they'd use that... [18:03:52] https://meta.wikimedia.org/wiki/MediaWiki:FR2014/Resources/ChangeBucket-AtoC-BtoD.js [18:04:07] https://meta.wikimedia.org/wiki/MediaWiki:FR2014/Resources/ChangeBucket.js [18:04:23] https://meta.wikimedia.org/wiki/MediaWiki:FR2014/Resources/ShowHideCheckFullscreen.js [18:04:38] thanks! [18:04:46] will do [18:10:16] yw likewise thanks! [18:10:30] TIL there's a place in Québec called Matapédia https://en.wikipedia.org/wiki/Matap%C3%A9dia%2C_Quebec [18:10:50] Not named after a morbid online encyclopedia [18:11:13] awight|testfest, ejegg: so after a bunch of shuffling i'm sitting on crm/deployment with 4 cherry picked commits and 1 vendor submodule update. i worry that if i squash it all into one commit git won't know those 4 merged from master (even though merging twice should be no-op) ... what's the best approach here? push up all 5 patches at once? [18:13:29] cwdent: hmm, is there risky stuff to cherry pick around? [18:14:07] ejegg: i think awight|testfest said e981304 Update French thank-you [18:14:33] ah, I see [18:15:03] yeah, I'd just push 'em all up and deal with the grrit-spam [18:15:30] cool, ty [18:16:00] incoming [18:16:04] (PS1) Cdentinger: Don't move "empty" recon files in test mode [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/247314 [18:16:06] (PS1) Cdentinger: update SmashPig to ignore blank lines in worldpay audit [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/247315 [18:16:08] (PS1) Cdentinger: File-extension-proof WP audit filename parsing. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/247316 [18:16:10] (PS1) Cdentinger: Tighten worldpay®ex_for_recon for WPG [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/247317 [18:16:12] (PS1) Cdentinger: update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/247318 [18:16:34] there's no button to +2 a whole dep chain is there? [18:17:15] nah, sorry! [18:17:49] hehe. is it okay to do all those myself? [18:19:42] yep! [18:20:41] (CR) Cdentinger: [C: 2] Don't move "empty" recon files in test mode [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/247314 (owner: Cdentinger) [18:20:53] (CR) Cdentinger: [C: 2] update SmashPig to ignore blank lines in worldpay audit [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/247315 (owner: Cdentinger) [18:20:55] (Merged) jenkins-bot: update SmashPig to ignore blank lines in worldpay audit [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/247315 (owner: Cdentinger) [18:21:02] (CR) Cdentinger: [C: 2] File-extension-proof WP audit filename parsing. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/247316 (owner: Cdentinger) [18:21:11] (CR) Cdentinger: [C: 2] Tighten worldpay®ex_for_recon for WPG [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/247317 (owner: Cdentinger) [18:21:25] (CR) Cdentinger: [C: 2] update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/247318 (owner: Cdentinger) [18:21:38] * cwdent shakes out mouse hand [18:25:44] ejegg: since cherry pick made new shas git doesn't know about those merges [18:26:08] just wait for them to disappear with the next actual merge? [18:26:15] ah right, but like you said the next merge will still be no-ops [18:26:28] yeah, should be fine [18:26:32] cool [18:27:06] seems like an option to merge a range of commits would be useful, but there's probably some fatal flaw that's not occurring to me [18:43:13] (CR) Awight: [C: 2] CRM-17310 further fix to my reports [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/246786 (owner: Eileen) [18:44:20] (Merged) jenkins-bot: CRM-17310 further fix to my reports [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/246786 (owner: Eileen) [18:55:02] why bother with vendor being a submodule? is it used somewhere besides crm? [18:55:57] cwdent: For consistency with mw-core deployment :(, but also to keep the spam out of the crm repo [18:57:07] aah interesting [19:00:21] (PS1) Awight: More updates to the French thank-you template [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/247328 (https://phabricator.wikimedia.org/T115496) [19:00:32] Fundraising-Backlog, Wikimedia-Fundraising, Epic: [epic] Amazon upgrade - https://phabricator.wikimedia.org/T87625#1735944 (atgo) Open>Resolved [19:17:45] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Show large screen banner and then top screen banner without losing an impression - https://phabricator.wikimedia.org/T90919#1735992 (Ejegg) Per IRC, decided that MVP is just to duplicate... [19:31:13] Fundraising Sprint Queen, Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint The Pogues, and 5 others: Log DonationInterface fatal errors to syslog - https://phabricator.wikimedia.org/T107918#1736023 (Jgreen) >>! In T107918#1732808, @Jgreen wrote: > I roll... [19:46:21] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1736061 (Jgreen) >>! In T97676#1729945, @ellery wrote: > @awight Thanks for double... [19:56:45] !log updated crm from a4e74f6f38e6cff16ecf79d28d6e4de9499a5017 to 6ad0ad090c23ee41003138a6676131abf70c72f4 [20:08:23] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Show large screen banner and then top screen banner without losing an impression - https://phabricator.wikimedia.org/T90919#1736116 (Ejegg) a:Ejegg [20:15:20] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: WMF Civi admins test their normal workflows on the staging server - https://phabricator.wikimedia.org/T114823#1736131 (awight) Test plan: https://docs.google.com/spreadsheets/d/1CdJQywpH2ZR0ba... [20:15:22] Internet flaked [20:15:29] Relocating [20:31:30] awight|fud: dstrine I note one test review is that a search on Oct results is empty - do the testers know the data is from Sep? [20:33:38] K4-713: I have a question [20:34:39] did i miss anything exciting? [20:43:05] Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: Deploy new French TY email - https://phabricator.wikimedia.org/T115496#1736198 (awight) @jrobell @pcoombe Okay, the next iteration is ready to test on the staging server. If it looks good, please merge https://gerrit.wikimedia.org/r/... [20:44:00] eileen: I'll comment on the test plan... [20:44:20] cool [20:44:50] (PS1) Ejegg: Always return bucket as int, not string [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247457 [20:45:20] btw wmf_audit is winning the test coverage competition with 56% cover [20:45:36] shocking! [20:45:50] Where can I find that scoreboard? [20:47:16] I managed to get it run locally [20:47:38] I'll email a screen shot but the html is better because you can click [20:48:56] hmm maybe I'll tar the html [20:49:13] eileen: Okay, 3 of the complaints were based on the date issue that you pointed out. I'll send an email to the group... [20:49:20] (PS1) Ejegg: WIP Large banner limit mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247460 (https://phabricator.wikimedia.org/T90919) [20:49:40] :-) [20:59:39] cwdent, awight, eileen - anything I can help with? [21:00:11] ejegg: if you're bored! i'm trying to figure out if those audit files worked right [21:00:24] sure, lemme take a look [21:03:47] seeing some queue consumer log lines with source audit and gateway worldpay, so that looks good [21:05:14] (PS1) Eileen: Fix e-strict errors [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/247462 (https://phabricator.wikimedia.org/T99836) [21:07:35] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243118 (owner: Eileen) [21:19:22] AndyRussG: want to take a look at the first draft? https://gerrit.wikimedia.org/r/247460 [21:19:41] ejegg: sure you bet! [21:19:47] thanks! [21:19:52] likewise! :) [21:20:24] eileen: What are your thoughts about the 4.6 deployment branch? Sorry that days have gone by... [21:20:41] Need to hear back about the randomization option, and ask what kind of compatibility they need with existing scripts [21:21:45] eileen: We're still talking about adapting the inner logic from gitify? [21:23:51] awight: hmm I think last I was leaning to adapting civibuild to output to a dir [21:24:05] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1736341 (LeanneS) @XenoRyet I just tested with this column, and the value didn't import into the Civi contributi... [21:24:21] gitify DOES generate DAO etc [21:24:31] but it doesn't clean up the non-deploy files [21:25:02] I'm definitely interested in compromise here, so take anything I say with extra salt! [21:25:14] I guess we can try that with .gitignore but I worry we'd still get conflicts around that [21:25:15] but my last thought was that we would .gitignore the non-deployment files [21:25:26] you can always git clean -fd [21:25:52] I'll give it a go. I don't know if it's still the case but the script used to also compress packages [21:25:55] also--it's not that cool to switch back and forth between master + deployment anyway, best practice is more to have two checkouts, one for each branch [21:26:03] ok [21:30:54] atgomez1: 2 questions about reports [21:31:00] Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Script to compile civicrm into deployment form - https://phabricator.wikimedia.org/T115925#1736349 (awight) NEW [21:32:29] hey eileen! i'm not getting notifications from Adium. May need to finda nother client again [21:32:30] sigh. [21:32:33] what's up? [21:32:42] 1) The Giant Rabbit work changed the buttons to Save & Save a Copy. In core they were changed to Update & Save a Copy. On staging you have the Giant Rabbit version but I've started to think the core labels are actually clearer (& easier techincally) [21:32:57] let's do it [21:33:03] Update is better [21:33:05] cool - will patch that back [21:33:08] thank you :) [21:33:41] 2) regarding the warning when updating - I'm wondering whether it makes sense to look into having a revert after instead of a confirm [21:33:49] hm [21:33:57] what would the difference in the UX be? [21:34:00] Coleman suggested the confirm could be annoying in some circumstances [21:34:13] is he with civi core? [21:34:18] yeah [21:34:34] hmm [21:34:41] I'm thinking after you save there would be an alert saying you have updated but if you made a mistake click here to revert [21:34:54] well, i'm willing to take lessons on thsi from whoever. But we should make it extra clear to people that tis is happening [21:35:10] his suggestion was actually to do some more calculations on whether to present the confirm [21:35:22] alright [21:35:25] but, I thought once that complexity was in there there was extra work anyway [21:35:32] hm [21:35:35] i'm not totally following [21:36:21] so, in the past I've seen emails from Coleman to UX stuff saying it's less annoying to give people a chance to undo mistakes than to confirm they really mean to do something [21:36:39] yeah that's OK. will the undo only exist on the first go? or would it be visible all the time? [21:36:51] say, for example that i accidentally changed Caitlin V's report [21:36:55] that she uses all the time [21:37:09] how would she know the change had happened? would she be able to revert it once the error was clear? [21:37:12] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Show large screen banner and then top screen banner without losing an impression - https://phabricator.wikimedia.org/T90919#1071078 (Ejegg) Questions for @PCoombe and... [21:37:13] you don't think you'd realise immediately? [21:37:26] we'd have to cache what had happened to be able to revert it [21:37:33] i don't know… i don't actually use civi hardly at all [21:37:38] I was imagining very short-term caching [21:37:46] that edge case is my concern - not the one where people realize it [21:37:54] so you're thinking more like gmail's "undo send" feature? [21:38:15] I guess so - I assume that only works if you do it straight away [21:38:24] yeah it has like 10 seconds to undo [21:38:34] but basically it just doesn't send it until those 10 seconds have elapsed [21:39:02] right - yeah - this would be more like we stash the original values somewhere for a little bit [21:39:13] hmm [21:39:57] Well I can have a go at getting a confirm back in there - unless it's really un-annoying we might not be able to upstream it though [21:40:06] Does the unsubscribe_qc_disable checkbox in the civi unsubscribe module config do nothing? [21:40:34] Just wondrin' [21:40:34] yeah [21:40:48] i'm just a little worried eileen - but maybe this is osmething we can take up with the end users [21:41:04] atgomez1: yes - makes sense [21:41:13] i'd be interested in talking to coleman a bit more, too. i see what he's saying, but that doesn't solve the case i'm concerned about [21:41:19] i'll put something out to them right now [21:41:30] AndyRussG: ooh, that sounds fictitious. Looking... [21:41:38] depending on where we think this sits timing wise it could also be something for when I am in SF in 2 weeks [21:42:17] atgomez1: let me get the update button change first so they don't see it changing too much [21:42:19] AndyRussG: confirmed, nothing uses that. [21:43:04] awight: cool thanks! K at least I'm understanding stuff... [21:43:55] :) [21:44:45] gotta head out for a bit. back in an hr or so! [21:44:50] cya! [21:45:14] Also, is there any reason "Maximum number of items processed" is a drop-down... other than so that "unlimited" can be a distinct option? [21:46:23] AndyRussG: um, no. That's an artifact, please go with a freeform field now. [21:46:43] awight: k gotcha! [21:47:05] The idea was that we wanted to have a built-in maximum on job size, that was very hard to exceed accidentally. But I'd prefer to rely on batch_time now. [21:47:44] (PS1) Eileen: cover [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/247468 [21:47:59] Generally, I think batch_time should be the only limit, and batch_size should only be used during slow-start. [21:48:12] what is slow-start? [21:48:45] If we have doubts about a job's health, we'll start it up by running exactly one item through, then maybe 5, then full throttle. [21:48:50] eileen: sounds good. also you're coming here?? [21:49:10] Jobs are terminated by whichever is tripped first: batch size or batch time. [21:49:23] i'd like to get 4.6 live on prod before that if possible.. we're getting closer and closer to december and this is a big chnage [21:49:56] (Abandoned) Eileen: cover [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/247468 (owner: Eileen) [21:50:02] awight: OK yeah that's cool... But so similar to as unsubscribe, allow config of both, and normally we'll just leave batch size set to unlimited? [21:50:52] atgomez1: yes! [21:50:57] AndyRussG: yep [21:50:58] wow cool! [21:51:01] I am going to be there in early nov [21:51:13] awight: K [21:51:21] Prob will come into the office on 6 Nov & then some days the following week [21:51:29] eileen: neat! sorry I'll miss you--or are you going in January too? [21:51:30] ah great! you shuld put that on the FR calendar [21:51:45] atgomez1: I'll have to figure out how! [21:51:58] eileen: i just shared the calendar with you [21:52:24] AndyRussG: nothing in Jan that I know of - weather is better here in Jan! [21:52:38] Heh I imagine [21:52:55] atgomez1: So, I was thinking about just the confirm button issue not going out with 4.6 - not holding the whole thing [21:52:56] Mmm yeah my family will be jealous that I'll be getting a break from the cold... 8p [21:53:37] oh SF is considered warm? I'm worried it's going to be cold in Nov - I've never been to SF in Nov before... [21:56:11] eileen: it's all relative! Montreal will be like -10 C or colder... [21:56:18] ouch! [21:56:31] In fact on Saturday we had our first snow! Quite early [21:57:10] A couple of years ago I tried to muster up some sympathy from a friend in Canada because I was in the middle of winter - it fell over when he found out the temperature was 15c & he also had 15c wherever he was in his summer [21:57:29] But it's it's gonna be cold - snow is cool [21:59:42] I just discovered our weather reports come with a recommendation of how many layers of clothing! [21:59:54] eileen: that sounds like the right plan, and in fact we can use that as a way to talk to users about it [22:00:09] call out that to them as a possible issue [22:00:16] atgomez: cool [22:00:25] I mean I can do 'just something' [22:00:43] eileen: Ah yes in fact when it's spring here, and it's 15 degrees, people start going around in shorts [22:00:44] but, my reservation is that if we want to alter it later then we might get kick-back [22:01:21] AndyRussG: well this is correct - it says 2 layers of clothing & that is what I have http://www.metservice.com/towns-cities/whangarei [22:02:35] Actually the thing I'm excited about is that it's going to rain. We are on tank water & just added 7000 litres capacity so I want it to fill up - this summer is supposed to be a massive drought [22:03:01] Ah hmmm [22:03:07] Interesting [22:03:23] Yeah SF has had that issue quite a bit! [22:03:32] yeah! [22:03:45] K I'm gonna go and vote for the apparently probably least awful candidate [22:03:52] cya in a bit! [22:03:52] :-) [22:05:22] (PS2) Eileen: Add test class for reports [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243118 [22:09:19] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Worldpay frontend donation missing payment_method - https://phabricator.wikimedia.org/T115932#1736509 (awight) NEW [22:17:02] (PS1) Eileen: Change label from 'Save' to 'Update' on report options. [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/247471 (https://phabricator.wikimedia.org/T99837) [22:21:51] atgomez: staging is now shoing the Update Report button rather than Save [22:23:55] (CR) Awight: [C: -1] Add test class for reports (6 comments) [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243118 (owner: Eileen) [22:25:25] dang I just tried to search on gateway = coinbase to see if I could see what one of the testers was hitting - & of course it's now doing a killer query [22:25:53] sorry! [22:26:39] that machine has 16 CPUs, wind up a few more :) [22:26:51] :-) [22:27:43] I spoke to Jeff last week about getting the ability to show processes from other users at the mysql level but didn't get that finished [22:27:57] you can actually... hold on [22:28:10] it did finish though - I'm off to the slow query log to see what ran :-) [22:28:35] rad [22:29:10] gotta run, probably for the evening. g'speed, all! [22:33:27] well, something is different with the new audit files [22:33:30] new error [22:40:22] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Record actual amount charged regardless of what's in session - https://phabricator.wikimedia.org/T115171#1736633 (DStrine) [22:42:03] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Implement recurring logic in Amazon gateway adapter - https://phabricator.wikimedia.org/T111430#1736654 (DStrine) [22:42:04] thanks eileen [22:42:24] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Implement Amazon recurring widget client-side - https://phabricator.wikimedia.org/T111428#1736659 (DStrine) [22:43:08] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog: EXTERNAL: Worldpay HCG search by email address - https://phabricator.wikimedia.org/T114183#1736671 (DStrine) [22:53:28] "Unserialization"? Since when is that a word? [22:57:51] Fundraising-Backlog: Scope PayPal express checkout - https://phabricator.wikimedia.org/T113625#1736731 (atgo) [22:58:30] Mixed tabs and spaces? [22:59:04] cwdent: do you know if ^ that's a thing in our civi codebase? Do we use one or the other now? [22:59:29] AndyRussG: good question...lemme look [22:59:47] cwdent: for example, exchange_rates.module [22:59:58] i think it should all be tabs [23:00:25] but some errant spaces would not surprise me [23:02:00] cwdent: Hmmm yeah I seem to have found a large space base [23:02:14] K I'll do tabs because tabs :) [23:02:16] thx! [23:13:47] MBeat: just a question on some of the testing feedback… [23:13:58] sure thing [23:14:09] I see that searching on gateway=coinbase is really slow [23:14:21] in 4.2 is that slow-but-gets-there or not-slow [23:15:01] (or reasonaby-not-slow if you don't want to commit to not-slow :-) [23:15:53] in the old Civi it gets there in a usable amount of time [23:16:15] I’d go so far as: not slow [23:16:36] OK - in my testing of the query directly it suggests that using = rather than like would make a big difference [23:16:57] in 4.2 do you know if it will match on something that is like Coinbase but not actually Coinbase [23:17:20] (my suspicion is it has changed from gateway='Coinbase' to gateway LIKE '%Coinbase%' [23:17:27] not sure; would I specify something in the Gateway field to get that? [23:17:38] I entered the PSP name with no characters or wildcards [23:18:04] If you search for oinbas in the gateway field does it still find the coinbase entries [23:20:04] nope [23:20:23] OK so that is what has changed - I'll think about how to deal with it! [23:20:44] but it answers what a hybrid pig/sheep would sound like [23:21:02] :-) [23:37:45] MBeat: if you have a changes can you try searching on 4.2 gateway= Coinbas% [23:38:12] I think it's doing a LIKE - but not adding a % in 4.2 [23:38:19] & in 4.6 it's adding a % [23:45:30] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1736992 (XenoRyet) @LeanneS When I tested locally, I noticed the value had to exactly match something that exi... [23:49:40] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: WMF Civi admins test their normal workflows on the staging server - https://phabricator.wikimedia.org/T114823#1737024 (Eileenmcnaughton) I have logged https://issues.civicrm.org/jira/browse/C... [23:59:38] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1737062 (LeanneS) @XenoRyet Yes, I entered exactly as 2015 San Francisco Event.