[00:00:29] (PS1) Ejegg: Update civicrm submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/247483 (https://phabricator.wikimedia.org/T105918) [00:03:44] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1737068 (XenoRyet) @LeanneS Hmm... Just to cover my bases, this was on production and not staging? Assuming... [00:10:23] ejegg: i see what you were saying now, those logger messages from SP never make it to the drush output [00:12:52] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1737095 (LeanneS) @XenoRyet Yep, this was in production. Do you have access to the server? I can place the file... [00:13:05] cwdent: yeah, kind of annoying like that [00:13:56] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1737100 (XenoRyet) @LeanneS I do have access. Just let me know which server and in what directory you put it.... [00:14:06] (CR) Cdentinger: [C: 2] Update civicrm submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/247483 (https://phabricator.wikimedia.org/T105918) (owner: Ejegg) [00:23:30] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1737141 (LeanneS) @XenoRyet Great! Here is the path: Fundraising - Tech - Major Gifts - Trilogy [00:24:00] (PS1) Cdentinger: Move Context/Logger init to wmf_audit_main [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/247490 [00:48:09] (PS1) Cdentinger: add EXPIRED to handled transaction types [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/247493 [02:33:11] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1737270 (ellery) Is this task being tracked on two tickets? Anyway, you can make th... [07:02:33] (CR) Awight: [C: 2] "Much more centrally located!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/247490 (owner: Cdentinger) [07:03:11] (CR) Awight: [C: 2] add EXPIRED to handled transaction types [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/247493 (owner: Cdentinger) [07:03:33] (Merged) jenkins-bot: Move Context/Logger init to wmf_audit_main [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/247490 (owner: Cdentinger) [07:03:35] (Merged) jenkins-bot: add EXPIRED to handled transaction types [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/247493 (owner: Cdentinger) [07:23:26] Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: Deploy new French TY email - https://phabricator.wikimedia.org/T115496#1737406 (jrobell) Thank you @awight. It looks good to me! Thank you for deploying. [08:14:37] (CR) Siebrand: [C: 1] "i18n/L10n reviewed." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247460 (https://phabricator.wikimedia.org/T90919) (owner: Ejegg) [11:19:30] hi all [11:19:56] i got a trouble with Central Banner extension [11:20:11] i saw on the extension page that help could be found here [11:20:38] the load.php for the module return [11:20:56] "devices":[] [11:21:34] instead of the list of devices set (who is correctly set in the Central notice adminitration) [11:22:03] i use interwiki, the French version work [11:22:13] the trouble occur only in english version [11:22:37] does anyone got an idea from where it come from ? [11:23:01] for Central Banner extension i meant Central Notice extension [11:23:49] the result of load.php for the french version return "devices":["android","desktop","ipad","iphone","unknown"] (who is correct) [11:33:31] (CR) Pcoombe: [C: 2] "Thanks Adam!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/247328 (https://phabricator.wikimedia.org/T115496) (owner: Awight) [11:35:31] Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: Deploy new French TY email - https://phabricator.wikimedia.org/T115496#1737883 (Pcoombe) Thanks Adam, this is merged and ready to be deployed in production. [11:37:29] ok, i found, there was some table added on an update, and thoose table wasn t in my shared db list ... :P [11:37:35] thanks anyway, bye ! [15:09:34] the-wub_: Already read my mail? - We don't get impressions again :-/ ( although everything is configured correctly ) [15:10:19] CFisch_home: yes, and think I've found the problem is on our end. I'm just filing a phabricator task now [15:10:37] k thx [15:15:31] Fundraising-Backlog: Banner impressions not updating on lutetium - https://phabricator.wikimedia.org/T116021#1738472 (Pcoombe) NEW [15:21:26] (PS1) Awight: Merge remote-tracking branch 'origin/master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/247583 [15:21:51] (CR) Awight: [C: 2] Merge remote-tracking branch 'origin/master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/247583 (owner: Awight) [15:21:53] (Merged) jenkins-bot: Merge remote-tracking branch 'origin/master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/247583 (owner: Awight) [15:23:07] !log update fundraising CRM from 6ad0ad090c23ee41003138a6676131abf70c72f4 to 738e8c3f8079765841ed4c5f79ecf066c541c7b9 [15:23:14] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [15:23:20] morning awight, could you take a look at https://phabricator.wikimedia.org/T116021 when you have a chance? [15:23:28] Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: Deploy new French TY email - https://phabricator.wikimedia.org/T115496#1738529 (awight) Deployed! [15:23:49] the-wub_: sure! [15:23:56] yikes [15:26:23] Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: Deploy new French TY email - https://phabricator.wikimedia.org/T115496#1738538 (Pcoombe) Open>Resolved Awesome, thank you! [15:27:39] Fundraising-Backlog: Banner impressions not updating on lutetium - https://phabricator.wikimedia.org/T116021#1738543 (awight) @Jgreen We stopped receiving beaconImpressions files at around 22:37:31 UTC, yesterday. Please let us know what you find, it's critical for FR-online... Thanks! [15:27:47] Fundraising-Backlog, fundraising-tech-ops: Banner impressions not updating on lutetium - https://phabricator.wikimedia.org/T116021#1738545 (awight) [15:27:52] the-wub_: Confirmed :( [15:28:23] cmjohnson1: Want to take a poke at our banner impression log pipeline? https://phabricator.wikimedia.org/T116021 [15:28:27] Looks bad... [15:28:43] but hopefully it's just a file replication thing [15:32:19] (PS1) Cdentinger: Update SmashPig lib [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/247585 [15:34:34] (CR) Cdentinger: [C: 2] Update SmashPig lib [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/247585 (owner: Cdentinger) [15:34:58] cwdent: hi! lmk if I can do anything, supporting the audit is top o' the list [15:35:46] cmjohnson: donno if you got my pings ^^ looks like some of our file replication stopped, it's urgent to fix... [15:35:58] awight: great! just going to deploy smashpig [15:37:25] Fundraising-Backlog, fundraising-tech-ops: Banner impressions not updating on lutetium - https://phabricator.wikimedia.org/T116021#1738597 (awight) Confirmed broken. It looks like file replication stopped, or the upstream logs are not being generated. [15:40:32] Fundraising-Backlog, Recurring-Donations, Epic: Amazon recurring (Epic) - https://phabricator.wikimedia.org/T107391#1738618 (Ejegg) [15:40:34] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Implement recurring logic in Amazon gateway adapter - https://phabricator.wikimedia.org/T111430#1738617 (Ejegg) Open>Resolved [15:41:02] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Implement recurring logic in Amazon gateway adapter - https://phabricator.wikimedia.org/T111430#1738619 (awight) *wow!* [15:41:06] Fundraising-Backlog, Recurring-Donations, Epic: Amazon recurring (Epic) - https://phabricator.wikimedia.org/T107391#1493759 (Ejegg) [15:41:08] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Implement Amazon recurring widget client-side - https://phabricator.wikimedia.org/T111428#1738620 (Ejegg) Open>Resolved [15:42:14] awight: how did you get all those commits to merge in just one gerrit change? [15:42:27] merge vs cherry-pick [15:43:15] hrm yeah...so git merge master? [15:43:59] yep, or cos I'm bad about maintaining my local branches, git checkout origin/deployment; git cherry -v origin/deployment origin/master; git merge origin/master [15:45:26] We're assuming the wallet widget renders with a default method selected. When this isn't the case, the SetOrderReferenceDetails call comes back with constraint 'PaymentPlanNotSet - The buyer has not been able to select a Payment method for the given Order Reference'. [15:45:54] <_< [15:47:31] (PS1) Cdentinger: Merge remote-tracking branch 'origin/master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/247590 [15:49:02] erk [15:49:06] mousepaste [15:52:18] the-wub_: Hello! I'm trying to replace the fullscreen banner swap code with a campaign mixin. If you have a minute, I've got some questions about features at https://phabricator.wikimedia.org/T90919 [15:52:18] (PS1) Cdentinger: 60c9f5e add EXPIRED to handled transaction types [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/247592 [15:54:12] ejegg: thanks. it's next on my list of things to look at [15:54:22] rockin! [15:54:36] to quote my favourite show "I've got a to-do list longer than a Leonard Cohen song" [15:54:45] heh [15:55:25] (CR) Cdentinger: [C: 2] Merge remote-tracking branch 'origin/master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/247590 (owner: Cdentinger) [15:55:44] (CR) Cdentinger: [C: 2] 60c9f5e add EXPIRED to handled transaction types [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/247592 (owner: Cdentinger) [15:58:52] (PS1) Cdentinger: update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/247594 [15:59:13] (CR) Cdentinger: [C: 2] update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/247594 (owner: Cdentinger) [15:59:15] (Merged) jenkins-bot: update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/247594 (owner: Cdentinger) [16:04:17] Jeff_Green: you have any time to look at https://phabricator.wikimedia.org/T116021 ? [16:06:40] yeah, but it looks like ottomata is already on it, right? [16:07:03] Jeff_Green: where's that happening? [16:07:31] he pinged me in the ops channel a few minutes ago with a minor puppet change to fix permissions [16:07:38] ah hrm ok thx [16:11:59] awight: gonna deploy crm for smashpig update [16:12:05] cool! [16:13:40] !log updated fundraising crm from 738e8c3f8079765841ed4c5f79ecf066c541c7b9 to 22dc4bd7d041126a1d2a0d4acb9a288bfdc1b435 [16:13:50] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [16:37:19] awight apparently puppet was deleting the log rotation user on erbium, ottomata and chase fixed that [16:38:28] Jeff_Green: word, thank you! [16:39:27] i don't see any logs from today though, when did this start happening? [16:39:40] I pasted the time into the bug--22:30 UTC or so [16:39:55] 18 hr ago I guess [16:40:04] huh [16:46:42] cwdent: found audit record looks *really* happy... 16:23:33 WD wmf_civicrm: Found value for payment_instrument Credit Card: Carte [notice] [16:46:45] 16:23:33 Bleue :23 [16:46:47] suave [16:47:17] cwdent: Feel confident enuf to send out an announcement? [16:47:46] nice! [16:48:01] yeah i'd say so...i'm fixing the refund ID and adding tests [16:48:32] damn, it even came in with utm_- data [16:48:40] ok the :45 cron job blatted some files. yay [16:48:42] cool--refund ID is not a blocker btw [16:48:49] Jeff_Green: Thanks! [16:48:56] awight: great, want me to send the all clear then? [16:49:12] * Jeff_Green lunch horn sounds [16:49:23] cwdent: please! [16:50:38] the-wub: Next banner impressions job will run in a few minutes, at which point all the missing data should be backfilled... I'll ping you again when the job finishes. [16:51:22] Fundraising Sprint Vengaboys, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Banner impressions not updating on lutetium - https://phabricator.wikimedia.org/T116021#1738940 (awight) [16:54:50] the-wub: Are we planning to start the FR campaign today? [16:55:17] cwdent just closed the last blocker... [16:55:27] awight: not sure. you'll have to ask jessica or megan [16:55:32] k! [16:55:42] the-wub: Okay, the impressions should all be backfilled now [16:56:25] the-wub: ooh, sorry! There's a hole, actually, from yesterday until a few moments ago. [16:56:31] I don't know if we'll ever get that data. [16:56:34] But new stuff is coming in. [16:56:52] wow that was quick! thanks awight [16:57:06] awight: what times does the hole cover? [16:57:12] I'll paste into the bug... [16:57:53] ok thanks [16:58:36] Fundraising Sprint Vengaboys, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Banner impressions not updating on lutetium - https://phabricator.wikimedia.org/T116021#1738978 (awight) So, looks like we'll have a permanent hole in the data, from 2015-10-10 22:15 to 2015-10-20 16:45... [17:00:10] Be right there, hangouts is being dumb. [17:02:41] AndyRussG: ejegg got time to talk backlog? [17:03:11] dstrine: boo! [17:05:19] Fundraising Sprint Vengaboys, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Banner impressions not updating on lutetium - https://phabricator.wikimedia.org/T116021#1739018 (WMDE-Fisch) Thanks for looking into that and fixing it so quickly! [17:10:29] Fundraising Sprint Lou Reed, Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, MediaWiki-extensions-CentralNotice, and 3 others: CentralNotice mobile modules should not be loaded in the head - https://phabricator.wikimedia.org/T100372#1739027 (AndyRussG) [17:12:36] Fundraising-Backlog: [BUG] Spike: Why is Donation form stuck with 0 as donation amount; donors can't modify it. Fix why. - https://phabricator.wikimedia.org/T113530#1739028 (awight) [17:13:21] Fundraising Sprint Vengaboys, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Banner impressions not updating on lutetium - https://phabricator.wikimedia.org/T116021#1739029 (Jgreen) I don't think that's the case, the log rotation script backs off if it wasn't able to access the... [17:14:48] Fundraising Sprint Lou Reed, Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, MediaWiki-extensions-CentralNotice, and 3 others: CentralNotice mobile modules should not be loaded in the head - https://phabricator.wikimedia.org/T100372#1739032 (atgo) @andyrussg why remove the backlog project? [17:21:10] Fundraising-Backlog: Sprint W (10/28 - 11/11) goal: code freeze! - https://phabricator.wikimedia.org/T112816#1739067 (atgo) [17:25:34] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Create an alert for suspicious dips in banner impressions - https://phabricator.wikimedia.org/T116047#1739102 (awight) NEW [17:29:54] Fundraising-Backlog: `drush parse-audit --test` moves files around - https://phabricator.wikimedia.org/T115675#1739145 (awight) @cwdent You closed this? [17:30:32] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising Sprint Vengaboys, and 3 others: Write banner diet campaign mixin - https://phabricator.wikimedia.org/T112017#1739148 (Pcoombe) I tried this for a campaign aa.wikibooks, all looks good to me. Th... [17:31:15] Fundraising-Backlog: Hide name fields from WMF portion of form - https://phabricator.wikimedia.org/T113657#1739151 (atgo) p:High>Low [17:32:09] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising Sprint Vengaboys, and 3 others: Write banner diet campaign mixin - https://phabricator.wikimedia.org/T112017#1739156 (Pcoombe) Q: If I use the same cookie name, will the mixin be compatible wit... [17:35:51] Fundraising-Backlog: `drush parse-audit --test` moves files around - https://phabricator.wikimedia.org/T115675#1739167 (cwdent) Open>Resolved a:cwdent Fixed in https://gerrit.wikimedia.org/r/#/c/247314/ [17:36:31] Fundraising-Backlog: [epic] Worldpay campaign ready in France - https://phabricator.wikimedia.org/T110114#1739172 (cwdent) [17:36:32] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog: Worldpay Audit file - https://phabricator.wikimedia.org/T114676#1739170 (cwdent) Open>Resolved This is working now. [17:39:04] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Worldpay frontend donation missing payment_method - https://phabricator.wikimedia.org/T115932#1739183 (atgo) p:High>Normal [17:39:11] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Worldpay frontend donation missing payment_method - https://phabricator.wikimedia.org/T115932#1736509 (atgo) p:Normal>Low [17:41:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New SSL cert for Rosie Lewis - https://phabricator.wikimedia.org/T115889#1739204 (atgo) p:Triage>High a:Jgreen [17:41:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: URGENT: Renee needs an updated SSL cert for CiviCRM - https://phabricator.wikimedia.org/T115873#1739212 (atgo) @jgreen - check this one out [17:42:20] Fundraising-Backlog: [BUG] GC100 Auth Fail Errors 10/18 very high fail rate - https://phabricator.wikimedia.org/T115818#1739216 (atgo) @mbeat33 - did you hear anything from GC? [17:43:57] Fundraising-Backlog: [BUG] GC100 Auth Fail Errors 10/18 very high fail rate - https://phabricator.wikimedia.org/T115818#1739232 (awight) I believe I responded in email, but I looked through their alerts and there was nothing that could be related to this. Either they don't know about the error, or it was a... [17:44:04] Fundraising Tech Backlog, Fundraising-Backlog, Technical-Debt: Track submodule branches in .gitmodules - https://phabricator.wikimedia.org/T115771#1739233 (atgo) [17:45:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: URGENT: Renee needs an updated SSL cert for CiviCRM - https://phabricator.wikimedia.org/T115873#1739242 (Jgreen) a:Jgreen [17:46:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Determine a process and schedule for renewing SSL certificates in Civi - https://phabricator.wikimedia.org/T115902#1739249 (CaitVirtue) Yes, a list and a Ops-initiated process to renew the certs with a week or two remaining on the old cert, so as to ens... [17:47:23] Fundraising-Backlog: [BUG] GC100 Auth Fail Errors 10/18 very high fail rate - https://phabricator.wikimedia.org/T115818#1739253 (MBeat33) @atgo I asked GC yesterday, and just prompted Sal about verifying whether it was Wells Fargo again. [17:47:26] Fundraising Tech Backlog, Fundraising-Backlog, Continuous-Integration-Config, Technical-Debt: Use the name "grunt-jscs" in all Fundraising CI glue - https://phabricator.wikimedia.org/T115642#1739254 (atgo) [17:48:52] Fundraising-Backlog, Continuous-Integration-Config, Patch-For-Review, WorkType-Maintenance: Switch wikimedia/fundraising/slander to use tox as an entry point - https://phabricator.wikimedia.org/T114250#1739273 (awight) @hashar Thank you, this is awesome! Just letting you know however that we've pu... [17:52:12] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Show large screen banner and then top screen banner without losing an impression - https://phabricator.wikimedia.org/T90919#1739297 (Pcoombe) @Ejegg >>! In T90919#1... [17:55:12] Fundraising Sprint Vengaboys, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Banner impressions not updating on lutetium - https://phabricator.wikimedia.org/T116021#1739319 (Pcoombe) p:Unbreak!>High @awight @jgreen Thanks for fixing! If it is possible to get the missing da... [17:55:26] (PS1) Cdentinger: Fix refund ID and add a couple WP tests [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/247620 [18:06:37] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog: Parse Amazon last name data differently (or: review the way we receive Amazon name data) - https://phabricator.wikimedia.org/T86720#1739387 (awight) @CCogdill_WMF and @MeganHernandez_WMF We touched on this briefly today, and... [18:06:50] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog: Parse Amazon last name data differently (or: review the way we receive Amazon name data) - https://phabricator.wikimedia.org/T86720#1739389 (MBeat33) The new Amazon Seller Central portal allows for searching by email address,... [18:17:42] (CR) Awight: [C: 2] "Wow, tests even!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/247620 (owner: Cdentinger) [18:17:46] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: URGENT: Renee needs an updated SSL cert for CiviCRM - https://phabricator.wikimedia.org/T115873#1739441 (Jgreen) cert generated and email/sms'd to Renee [18:20:32] Fundraising Sprint Vengaboys, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Banner impressions not updating on lutetium - https://phabricator.wikimedia.org/T116021#1739456 (awight) @Jgreen Thanks for pointing that out! Confirmed that there is no hole in the data, the first new... [18:21:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: URGENT: Renee needs an updated SSL cert for CiviCRM - https://phabricator.wikimedia.org/T115873#1739459 (Jgreen) Open>Resolved [18:23:19] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising Sprint Vengaboys, and 3 others: Write banner diet campaign mixin - https://phabricator.wikimedia.org/T112017#1739460 (awight) >>! In T112017#1739156, @Pcoombe wrote: > Q: If I use the same cook... [18:23:57] Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice: Announce new banner diet feature - https://phabricator.wikimedia.org/T115783#1739463 (awight) p:Triage>Normal a:awight [18:24:56] (Merged) jenkins-bot: Fix refund ID and add a couple WP tests [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/247620 (owner: Cdentinger) [18:26:44] AndyRussG: kinda basic question - there's nothing in the current on-wiki scripts that prevents users from being randomly assigned to the small-banner buckets from the start, is there? I'm not seeing it, if so. [18:27:42] ejegg: There is this horrific thing, a global config var that determines what modulo we use on the initial random number generated for bucket assignment [18:27:48] It's been set at 2 forever. [18:27:57] ooh, thanks! [18:28:17] wgNoticeNumberOfControllerBuckets [18:28:24] ejegg: ^ eso [18:28:26] cool [18:28:32] thanks again! [18:28:36] :) [18:35:49] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog: Parse Amazon last name data differently (or: review the way we receive Amazon name data) - https://phabricator.wikimedia.org/T86720#1739568 (CCogdill_WMF) @awight this isn't a scientific assumption, but my experience of revie... [18:38:27] (PS2) Ejegg: Large banner limit mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247460 (https://phabricator.wikimedia.org/T90919) [18:38:33] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog: Parse Amazon last name data differently (or: review the way we receive Amazon name data) - https://phabricator.wikimedia.org/T86720#1739595 (awight) @CCogdill_WMF Good point--Amazon is currently only for the US, where first-n... [18:39:03] AndyRussG: what do you think of allowing banner mixins to specify default values for parameters? [18:39:26] (campaign mixins) [18:39:48] right, campaign mixins! That last patch is doing it in a kind of hokey way, using a hardcoded default when the param is blank [18:39:51] ejegg: hi! on the second questions ^ yes that's an excellent idea, we should do it... awight also brought it up early on [18:39:59] and, +1 [18:40:07] thanks! [18:40:30] yeah, I like the explicit default, cos then we can display that in the admin UI [18:40:38] yep [18:40:54] ejegg: on the first question, the limitation is in the config I think? The system only randomly assignes buckets A (0) and B (1) [18:41:13] AndyRussG: thanks! awight dredged that variable up for me [18:41:16] C and D are reserved for such javascripty assignemnts [18:41:48] ejegg: ah woops sorry yeah just saw the backscrool, thanks awight :) [18:42:32] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog: Parse Amazon last name data differently (or: review the way we receive Amazon name data) - https://phabricator.wikimedia.org/T86720#1739609 (CCogdill_WMF) @awight sure, let's remember this as Amazon expands. I'm thinking abou... [18:43:26] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Determine a process and schedule for renewing SSL certificates in Civi - https://phabricator.wikimedia.org/T115902#1739614 (CaitVirtue) Clarification: I want their to be a most-robust customer service component. Just issuing the certs and sending the... [18:47:12] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog: Parse Amazon last name data differently (or: review the way we receive Amazon name data) - https://phabricator.wikimedia.org/T86720#1739654 (awight) [18:52:11] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1739669 (awight) Confirmed that the campaign is intact. All the pipeline does is s... [18:52:56] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1739673 (awight) Also, for the record we are now talking about beaconImpressions fi... [19:00:17] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New SSL cert for Rosie Lewis - https://phabricator.wikimedia.org/T115889#1739695 (Jgreen) p:High>Normal I don't think it makes sense to issue the new cert until she comes back from leave, since she will need to install it... [19:13:23] (PS3) Ejegg: Large banner limit mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247460 (https://phabricator.wikimedia.org/T90919) [19:13:25] (PS1) Ejegg: Allow mixins to specify default parameter values [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247637 [19:14:33] (CR) Ejegg: [C: -1] "PS3: rebase onto default value patch. PS4 will be updated with default values for this mixin." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247460 (https://phabricator.wikimedia.org/T90919) (owner: Ejegg) [19:21:29] (PS3) AndyRussG: WIP add banner_history module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/246425 (https://phabricator.wikimedia.org/T112022) [19:29:36] (PS4) Ejegg: WIP Large banner limit mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247460 (https://phabricator.wikimedia.org/T90919) [19:44:44] (PS5) Ejegg: Large banner limit mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247460 (https://phabricator.wikimedia.org/T90919) [19:46:12] AndyRussG: Ready for review, if you have some time. Added bucket randomize and cookie name options per the-wub's feedback. [19:46:30] ejegg: woohoo! infact I just git review -d'd it :) [19:46:37] nice! [19:46:43] (like 1 min ago...) [19:46:57] just looking now at the dependencies too... [20:03:31] (CR) AndyRussG: "Great, thanks!!!! Would it make sense to also ensure a number and add a jsdoc comment about this contract for setBucket()?" (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247457 (owner: Ejegg) [20:10:31] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Advanced Search needs an OR operator - https://phabricator.wikimedia.org/T115900#1740005 (Eileenmcnaughton) Do people know about search builder? [20:16:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New SSL cert for Rosie Lewis - https://phabricator.wikimedia.org/T115889#1740012 (atgo) If I understand correctly, she's coming in here and there to help out and show the rest of the team some things for December. As such, she... [20:34:12] (PS2) Ejegg: Always return bucket as int, not string [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247457 [20:39:33] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising Tech Backlog, and 4 others: Configure new CiviCRM staging instance for testing 4.6 upgrade - https://phabricator.wikimedia.org/T112314#1740064 (DStrine) [20:39:49] Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, and 4 others: Spike: Lots of 21000050 errors for Globalcollect, since July - https://phabricator.wikimedia.org/T107845#1740065 (DStrine) [20:40:40] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Nightly Amazon report download - https://phabricator.wikimedia.org/T109654#1740068 (DStrine) [20:40:49] Fundraising-Backlog, Continuous-Integration-Config, Patch-For-Review, WorkType-Maintenance: Switch wikimedia/fundraising/slander to use tox as an entry point - https://phabricator.wikimedia.org/T114250#1740069 (hashar) Such a pity, poor `slander`. At least there is a test entry point and CI is bei... [20:41:06] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Parse new Amazon transaction reports and import into Civi - https://phabricator.wikimedia.org/T111425#1740073 (DStrine) [20:41:31] Fundraising Sprint UB40, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, WorkType-Maintenance: CI tests are failing for Civi 4.6 branch - https://phabricator.wikimedia.org/T113422#1740076 (DStrine) [20:45:40] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog, WorkType-NewFunctionality: Style iframe contents more if necessary. (worldpay 1hour test) - https://phabricator.wikimedia.org/T112809#1740100 (DStrine) [20:46:10] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: Banner history: encode all hide reasons - https://phabricator.wikimedia.org/T113813#1740104 (DStrine) [20:55:18] Regarding the testers reports - there is a second staging specific issue - ie I turned off outgoing email but they logged that an email didn't go out [21:29:31] (CR) AndyRussG: [C: 2] "Coolbeans!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247457 (owner: Ejegg) [21:30:10] (PS2) AndyRussG: Allow mixins to specify default parameter values [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247637 (owner: Ejegg) [21:41:24] (Merged) jenkins-bot: Always return bucket as int, not string [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247457 (owner: Ejegg) [22:07:18] Fundraising Sprint Vengaboys, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: DonationInterface is attempting to I_OWP twice in a row - https://phabricator.wikimedia.org/T116089#1740312 (awight) NEW [22:14:36] AndyRussG: remind me what the new secret URL params are? [22:14:37] https://en.wikipedia.org/wiki/Main_Page?banner=C1516_itIT_dsk_hi_FR&country=IT&force=1&reset=1 [22:14:40] doesn't do it [22:14:57] haha nvm, that's not a banner. [22:15:25] oh, still not working! [22:15:26] https://en.wikipedia.org/wiki/Main_Page?banner=B1516_1019_itIT_dsk_p1_lg_dsn_ppl_wht&country=IT&force=1&reset=1 [22:16:54] https://meta.wikimedia.org/w/index.php?title=Requests_for_new_languages/Wikibooks_Sindhi&banner=B1516_1019_itIT_dsk_p1_lg_dsn_ppl_wht&uselang=it&force=1&country=IT [22:16:57] works [22:18:47] awight: one sec :) [22:19:49] Fundraising Sprint Vengaboys, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: DonationInterface is attempting to I_OWP twice in a row - https://phabricator.wikimedia.org/T116089#1740371 (awight) Okay, it looks like these people switched CC type. This is supposed to give them a new orde... [22:20:46] awight: tried adding some more default settings and audit dirs to CRM role in vagrant https://gerrit.wikimedia.org/r/247741/ [22:23:22] awight: can I help fake up a batch of queue messages for testing staging? [22:23:30] Fundraising Sprint Vengaboys, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: DonationInterface is attempting to I_OWP twice in a row without renewing the order_id - https://phabricator.wikimedia.org/T116089#1740374 (awight) [22:26:36] ejegg: thanks! [22:26:51] ejegg: How do you think we should test... [22:27:03] There's already automated unit tests for each of the queue types... [22:27:28] I was sort of imagining we do an integration test where we actually connect to ActiveMQ, but that's a lot of ops work with little reward. [22:28:01] yeah, I was wondering if we could configure DonationQueue to double-queue some messages [22:28:12] oof [22:28:19] I mean in two different queues [22:28:24] we can just inject messages by hand [22:28:33] but I don't want to touch the production queue server [22:28:37] right [22:28:38] We had... an accident with that once [22:28:47] slurped a bunch of real messages. [22:28:55] ah, don't want that [22:29:20] can we make DonationQueue send to two different servers? [22:29:25] I donno how valuable the integration tests are. [22:29:40] ejegg: we could, but I'd rather not [22:29:48] k [22:29:49] touching production in any way is just not a good idea [22:30:14] we could push our test messages to a test queue server, tho [22:30:19] but I don't think we have one set up [22:30:20] (PS1) Eileen: CRM-17422 remove prefixing of wildcard to search. [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/247748 (https://phabricator.wikimedia.org/T99836) [22:30:29] Ah, no staging mq, huh? [22:30:31] :( [22:30:33] it's a bear [22:30:55] My unformed thought is that queue consumption is actually a "should-have" for the upgrade... [22:31:08] We can always leave jobs down for a day if they're broken. [22:31:28] What do you think about looking over the consumer unit tests? [22:31:43] btw, there is a drush command for importing a json file into each consumer [22:31:53] hmm. No worries about queue consumer performance? [22:31:57] nah [22:32:09] Ah, json file would still test that [22:32:12] on second thought... definitely. [22:32:40] Just to throw it in there - I would like to ensure we are covering failures in the q because the exception stuff didn't really port & I don't have a good handle on whether a changed exception could cause .. something [22:32:56] It was much slower than realtime a few years ago, and I had to do a lot of nasty things in civi-core and in our code to get to current "speeds" [22:33:06] eileen1: great point! [22:33:27] oh yeah, we should throw some malformed messages at it too [22:33:50] ejegg: what about, adding profiling (could just be time()) around the queue consumers? [22:34:13] cos the startup cost dwarfs whatever the consumer does [22:34:44] awight: yeah, that would be good info. I was picturing testing larger batches too [22:35:09] ah, that doesn't exist yet---but it could! [22:35:16] MBeat: I think I have the slow search on coinbase fixed on staging now … [22:35:24] The drush import from json commands are annoyingly not reusing common code [22:35:37] awesome, thanks eileen1 [22:36:16] The problem is I'm not sure how many of the reported issues were duplicates - I think I see 2 variants of that one in the s/sheet [22:36:24] (ie 2 fields) [22:36:43] just tested frdev, it’s fast [22:37:21] on that search? cool! [22:37:56] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Install 4.6 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1740428 (Eileenmcnaughton) Test plan link https://docs.google.com/spreadsheets/d/1CdJQywpH2ZR0ba... [22:38:43] awight: dstrine any thoughts about how we triage the testers feedback? I feel I've fixed one of the issues they found [22:39:26] Any real issues should become Phabricator tasks... [22:39:32] makes them easier to handle [22:39:36] we were going to give the testers until EOD today to test. Then I was going to make phabricator tasks [22:39:59] eileen1: You also avoided a lot of bugs about "Doesn't find October data" :D [22:40:51] eileen1: it looked like you are not in tomorrow so I booked some time with awight to do a pass... then I'm going to add to phab [22:41:32] Feel free to make a card or not for the issue you've already fixed... [22:41:41] dstrine: yeah tomorrow is pretty out - I'll be juggling Fuzion work with calfclub.... [22:41:50] erm I'll explain [22:42:10] I think I got the short version from standup, that there were "%" wildcards around the gateway name? [22:42:10] Being a 'country school' the big event on the school calender is calfclub [22:42:11] eileen1: that's fine I'll robo-add things [22:42:14] hehehe [22:42:38] awight: yeah - they were adding wildcards CRM-17422 [22:42:42] awight: and eileen1 please be careful to not add screen shots that have donor data. I was going to block out PII before I added to phab [22:42:48] eileen1: Do you suspect those were added to any other fields? [22:43:25] awight: it is definitely affecting all custom fields (was) [22:43:59] hence there are at least 2 'errors' on the s/sheet that were diff custom fields [22:44:15] ooh [22:44:26] I don't think we can afford wildcards on *any* field [22:44:47] ah, "was" gotcha--you fixed for all fields [22:45:07] I fixed for all custom fields [22:45:32] & I think it still warrants more digging on other fields so check [22:45:42] because I think there *might* be exposure there [22:47:10] Wikimedia-Fundraising-CiviCRM: Slowness on 4.6 upgrade when searching on custom fields - https://phabricator.wikimedia.org/T116096#1740468 (Eileenmcnaughton) NEW a:Eileenmcnaughton [22:47:33] awight: it's a bit of a shell but I added that one [22:47:42] awight: sorry what were you trying to test with the above parameters for the banner? ^ [22:50:27] AndyRussG: actually, I still have a related question... https://aa.wikibooks.org/wiki/Main_Page?country=UK&uselang=aa -- https://meta.wikimedia.org/w/index.php?title=Special:CentralNotice&subaction=noticeDetail¬ice=test [22:50:37] Wondering why the banner never shows up? [22:50:48] awight: K checking [22:50:54] oh nvm [22:50:55] date [22:51:08] Ah hmm yes could be ;) [22:51:35] awight: remember that you can't test any campaign mixin functionality with the banner= parameter [22:55:01] (CR) AndyRussG: Allow mixins to specify default parameter values (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247637 (owner: Ejegg) [22:56:47] d'oh [22:57:05] we should add a "preview campaign" link to the campaign editor.... [22:57:26] hrm, https://aa.wikibooks.org/wiki/Main_Page?country=UK&uselang=aa&campaign=test ? [22:57:31] that isn't working either. [22:57:43] wait... I wasn't using the banner= param [22:59:15] (PS3) Ejegg: Allow mixins to specify default parameter values [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247637 [22:59:31] (CR) Awight: [C: 2] "Nice fix! Maybe there should be a configuration setting to default to infix search, though?" [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/247748 (https://phabricator.wikimedia.org/T99836) (owner: Eileen) [23:00:18] AndyRussG: It's present in choicedata, https://aa.wikibooks.org/w/load.php?debug=true&lang=aa&modules=ext.centralNotice.choiceData&only=scripts&skin=vector&version=ef78b2d4b076 [23:00:32] (Merged) jenkins-bot: CRM-17422 remove prefixing of wildcard to search. [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/247748 (https://phabricator.wikimedia.org/T99836) (owner: Eileen) [23:00:55] awight: sorry what are u looking for? [23:01:10] (CR) Eileen: "Yeah - at the core level I established the change happened since 4.4 & I questioned on the JIRA whether it was an intentional change or un" [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/247748 (https://phabricator.wikimedia.org/T99836) (owner: Eileen) [23:01:24] AndyRussG: I'm wondering why the banner isn't showing up... I also don't see the impressionDiet mixin loaded, I thought that was through ResourceLoader? [23:01:55] awight: ah K... Yes it is. Checking then... :) sorry for my slowbraindedness [23:02:19] It's necessary to slow your brain down when dealing with me, not your fault :p [23:02:19] (CR) Eileen: "NB ref https://issues.civicrm.org/jira/browse/CRM-17422" [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/247748 (https://phabricator.wikimedia.org/T99836) (owner: Eileen) [23:05:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New SSL cert for Rosie Lewis - https://phabricator.wikimedia.org/T115889#1740597 (CaitVirtue) Yes, she'll be in the office tomrrow. [23:07:12] awight: strange going into debug [23:08:57] thanks, hopefully I'm not pulling you away from anything! [23:09:09] (more important) [23:11:32] awight: not in the least, rather convincing kid 2 to take a shower and kid 1 to prepare her oral presentation has been taking me away from this 8p [23:11:42] :) [23:11:48] kids are cray cray [23:11:51] Seems like everyone's duly organized now... for the next 5 minutes [23:12:16] Yeah we need to get them into a more independent headspace [23:16:34] aww, I'm still having fun with the mind meld [23:16:45] Started this crappy doc, fyi: https://www.mediawiki.org/wiki/Extension:CentralNotice/Impression_diet [23:17:09] awight: neat! not crappy ;) [23:17:36] less crappy than nothing! [23:18:08] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New SSL cert for Rosie Lewis - https://phabricator.wikimedia.org/T115889#1740656 (atgo) p:Normal>High Raising back to High given the situation - @jgreen of course adjust as you see fit. [23:18:44] got a test data schema to make some fake donation queue messages: https://www.mockaroo.com/787ef4e0 [23:19:20] importing will probably choke on no contribution tracking tho [23:19:54] ejegg: ooooh [23:20:03] naw, it creates one if it's missing [23:20:07] ah, cool [23:20:29] did I say, awesome! [23:20:59] thanks! I think cwdent found this site when he was working on dash [23:21:14] yeah, it's pretty great [23:22:38] ohhh [23:22:55] awight: ooooh that's one of my fave CentralNotice gotchas [23:23:00] Try this URL: https://aa.wikibooks.org/wiki/Main_Page?country=GB&uselang=aa [23:23:18] omfg [23:23:21] that's hilarious [23:23:28] ejegg: what do you say when the time comes we tag team dash into node4? [23:23:48] o-o` [23:24:04] cwdent: sure, I'm up for learning it. As long as we've got a good oauth lib... [23:24:05] See, the country's name in the UI is UK, but that's not a country code, though it's also 2 uppercase letters... [23:25:06] awight: d'oh! didn't realize the process-messagefile was limited to a single queue message. Might try to extend that to take arrays too [23:25:26] ejegg: yea i think it's pretty much backwards compatible [23:25:33] but has a lot of awesome new features [23:25:51] ah, cool. I should read up on it! [23:26:17] AndyRussG: Now I also have those badly singed synapses to remember such a vile fact :) [23:27:04] awight: it's actually not the first time I've dived into debugger to find that exact issue... on that exact same campaign 8/ [23:27:24] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Advanced Search needs an OR operator - https://phabricator.wikimedia.org/T115900#1740667 (CaitVirtue) That sounds like something I may have been introduced to at some point, but I seem to recall it was too hard to use to incorporate into the daily routine. [23:27:25] mebbe we should add US and CA [23:27:44] (United Samoan island and Catalonia) [23:27:55] Heh [23:28:26] Or we could just remove the geotargeting... [23:28:38] I think it was once ipad only, eh? [23:28:42] it's nice just to know it works... but yeah [23:28:51] ugh yeah and figuring out those device strings is not fun [23:29:07] awight: feature idea: a URL flag to turn on campaign selection debugging! to tell you why campaigns weren't chosen [23:29:10] At one point, I was gonna fix the banner preview link to choose a country, lang, and device from the actual campaign [23:29:14] HRM [23:29:52] awight: heh fun but I think the banner= param trumps all that and so no mixin code would run [23:30:36] well, u like my idea of a Campaign Preview link, with campaign= ? [23:30:42] or even campaign_random= [23:34:06] awight: maybe... it'd have to have a server-side thing to pull in the campaign object normally pulled in via choiceData [23:40:55] I think that's already available in the campaign editor form builder. [23:42:15] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Record actual amount charged regardless of what's in session - https://phabricator.wikimedia.org/T115171#1740680 (awight) I take back my objection here, this sounds lik... [23:47:01] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Unsubscribe link doesn't work on upgraded staging 4.6 - https://phabricator.wikimedia.org/T116112#1740685 (Eileenmcnaughton) NEW a:Eileenmcnaughton [23:47:45] awight: hmmm yes but not as an API I think, just added into the form? [23:52:02] "Luckily", it's still html concatenation [23:55:32] awight: do I hear a hacky song coming on?