[00:05:43] (PS7) AndyRussG: Add banner history log ID processor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (https://phabricator.wikimedia.org/T112022) [00:08:49] (CR) jenkins-bot: [V: -1] Add banner history log ID processor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (https://phabricator.wikimedia.org/T112022) (owner: AndyRussG) [00:17:33] (PS1) Cdentinger: pass donation amount to iframe and reset session on return [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/247946 [01:07:25] Hi [01:07:42] how do i grand priviledge for a user to create a banner [01:07:43] ? [01:08:00] there is a bug i want to fix reported by krinkle [01:08:55] Hi r054l13! I'm just about to run, but you might join the centralnotice-admins@lists.wikimedia.org mailing list [01:09:18] I could think of other options tomorrow! feel free to post the bug here also and I'll subscribe and check it out :) [01:09:42] AndyRussG: ok [01:10:27] Bug is: https://phabricator.wikimedia.org/T72462 [01:13:28] r054l13: got it :) [01:15:07] but can someone help on how to make user create banner, grant the permission? [01:18:55] r054l13: not sure about that, maybe ask on the list above? Or some admins on Meta? [01:20:42] ok AndyRussG|a-whey [01:28:01] (PS1) Rosalieper: $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247962 (https://phabricator.wikimedia.org/T72462) [01:28:07] (CR) jenkins-bot: [V: -1] $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247962 (https://phabricator.wikimedia.org/T72462) (owner: Rosalieper) [01:32:15] (PS2) Rosalieper: $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247962 (https://phabricator.wikimedia.org/T72462) [01:32:21] (CR) jenkins-bot: [V: -1] $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247962 (https://phabricator.wikimedia.org/T72462) (owner: Rosalieper) [01:33:39] (PS3) Rosalieper: $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247962 (https://phabricator.wikimedia.org/T72462) [01:34:17] AndyRussG|a-whey: look at what i have did and see if it makes sense [01:35:56] *did -> done [07:01:19] (CR) Siebrand: [C: -1] "Many files have their non-executable mode set to new mode 100755. That should be removed. File content changes only are expected in this p" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247962 (https://phabricator.wikimedia.org/T72462) (owner: Rosalieper) [07:17:59] Fundraising Sprint Vengaboys, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Deploy Media Wiki Interface subject line in French - https://phabricator.wikimedia.org/T116199#1744807 (jrobell) Thank you very much @ejegg for getting to this so quickly! Much appreciated. [07:46:44] (PS1) Rosalieper: $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247990 (https://phabricator.wikimedia.org/T72462) [07:52:19] (Abandoned) Rosalieper: $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247962 (https://phabricator.wikimedia.org/T72462) (owner: Rosalieper) [08:20:33] how do i grant permission to user to create banner in CentralNotice extension [08:37:27] (CR) Rosalieper: "I added the picture itself to the resource/infrastructure/ directory and modified the code that renders the close button on the banners in" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247990 (https://phabricator.wikimedia.org/T72462) (owner: Rosalieper) [08:52:47] r054l13: on what wiki? [08:56:12] Nemo_bis: MediaWiki [08:56:24] r054l13: yes, but which MediaWiki wiki [08:56:37] what domain name, if you prefer [08:56:57] Nemo_bis: i am working on a bug: https://phabricator.wikimedia.org/T72462 [08:57:07] Nemo_bis: CentralNotice Extension [08:57:15] Nemo_bis: CentralNotice Extension [08:57:24] wait, i don't understand you. [08:57:36] is domain name == extension? [08:58:21] no [08:58:30] Nemo_bis: then what do you mean? [08:58:37] I need to know what website you are trying to test the thing on. [09:01:05] It seems it's faster for me to provide answers for all cases rather than trying to get an understandable question. :) [09:01:36] 1) Case 1: you are running the wiki yourself, e.g. in MediaWiki vagrant. Check what permissions are defined by the extension and assign them to the group the user belongs to. [09:02:01] 2) Case 2: you are testing on a Wikimedia wiki. You can't give anyone permission to manage CentralNotice. [09:02:42] 3) Case 3: you are testing on another wiki, maybe a wmflabs wiki or a MediaWiki wiki hosted by someone other than a Wikimedia person. Ask the system administrator to do the change. [09:03:04] r054l13: does this answer your question? [09:15:15] Fundraising-Backlog, Continuous-Integration-Config, Patch-For-Review, WorkType-Maintenance: Switch wikimedia/fundraising/slander to use tox as an entry point - https://phabricator.wikimedia.org/T114250#1745000 (hashar) Open>Resolved a:hashar Jan did the deployment and validated it is worki... [09:16:31] (CR) Hashar: "recheck" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/81470 (owner: Hashar) [09:17:15] (CR) Hashar: "check experimental" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/81470 (owner: Hashar) [09:20:35] Fundraising Tech Backlog, Fundraising-Backlog, Continuous-Integration-Config, Patch-For-Review: wikimedia/fundraising/tools should pass python lint checks (flake8) - https://phabricator.wikimedia.org/T114218#1745007 (hashar) The repository now has the tox integration to easily run the linter:... [09:29:06] Nemo_bis: i am testing locally and i am not using vagrant [09:29:06] i installed the extension and tried to use it after making the fix [09:33:44] Nemo_bis: do you understand me now? [09:39:42] yes, see answer 1 [09:40:59] Nemo_bis: it iss not quite clear to me, i mean answer 1 [09:40:59] Nemo_bis: how do i check the permission? [09:47:49] (CR) Awight: [C: -1] Add banner history log ID processor (6 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (https://phabricator.wikimedia.org/T112022) (owner: AndyRussG) [11:05:45] Wikimedia-Fundraising, Easy, JavaScript, Technical-Debt: CentralNotice banner uses deprecated globals such as "wgUserGroups", "sajax_init_object" and "sajax_debug_mode" - https://phabricator.wikimedia.org/T86871#1745142 (He7d3r) I believe the old banners are usually copied and pasted into new ones,... [11:43:11] Hey guys: Is it intended, that loading banners does not work for IE8 anymore? [11:47:13] CFisch_WMDE: no, there's a bug about this https://phabricator.wikimedia.org/T113013 [11:47:36] damn ;-) [11:47:38] IE7 and below are intentionally not supported though [11:47:49] jepp I know, thanks [14:27:42] apparently cwd reg expired [14:27:43] nice [15:09:06] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Record actual amount charged regardless of what's in session - https://phabricator.wikimedia.org/T115171#1745502 (cwdent) Patch for review: https://gerrit.wikimedia.org... [15:52:57] Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Worldpay frontend donation missing payment_method - https://phabricator.wikimedia.org/T115932#1745608 (cwdent) p:Low>High [15:55:00] Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Worldpay frontend donation missing payment_method - https://phabricator.wikimedia.org/T115932#1745610 (DStrine) [15:55:18] Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Worldpay frontend donation missing payment_method - https://phabricator.wikimedia.org/T115932#1745611 (cwdent) Three of these have come in so far this morning, so I bumped priority and... [16:04:35] Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Worldpay frontend donation missing payment_method - https://phabricator.wikimedia.org/T115932#1745632 (atgo) We just turned the campaign on, so probably a good thing to address before... [16:40:01] (CR) Ejegg: "You may be able to leave off the changes to the resultswitcher and just let the DonationData constructor harvest 'amount' from the URL. T" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/247946 (owner: Cdentinger) [16:47:14] (CR) Ejegg: [C: -1] "I like the thought of saving a DNS lookup! Needs a couple fixes." (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247990 (https://phabricator.wikimedia.org/T72462) (owner: Rosalieper) [17:56:12] (PS2) Rosalieper: $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247990 (https://phabricator.wikimedia.org/T72462) [17:56:18] (CR) jenkins-bot: [V: -1] $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247990 (https://phabricator.wikimedia.org/T72462) (owner: Rosalieper) [18:00:52] (PS3) Rosalieper: $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247990 (https://phabricator.wikimedia.org/T72462) [18:00:57] (CR) jenkins-bot: [V: -1] $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247990 (https://phabricator.wikimedia.org/T72462) (owner: Rosalieper) [18:03:34] (PS4) Rosalieper: $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247990 (https://phabricator.wikimedia.org/T72462) [18:03:38] (CR) jenkins-bot: [V: -1] $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247990 (https://phabricator.wikimedia.org/T72462) (owner: Rosalieper) [18:04:59] (PS5) Rosalieper: $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247990 (https://phabricator.wikimedia.org/T72462) [18:18:12] (PS6) Rosalieper: $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247990 (https://phabricator.wikimedia.org/T72462) [19:10:57] Fundraising-Backlog: CiviCRM upgrade: Search bar: Default search field is name only - https://phabricator.wikimedia.org/T116310#1746177 (DStrine) NEW [19:12:05] Fundraising-Backlog: CiviCRM upgrade: Search bar: Default search field is name only - https://phabricator.wikimedia.org/T116310#1746194 (DStrine) [19:17:21] Fundraising-Backlog: CiviCRM upgrade: Simple Lookups: timeout attempting to look up matching gifts given in August - https://phabricator.wikimedia.org/T116313#1746211 (DStrine) NEW [19:19:33] Fundraising-Backlog: CiviCRM upgrade: tracking donor moves: adding an activity should default to ""completed"" not ""scheduled"" - https://phabricator.wikimedia.org/T116314#1746218 (DStrine) NEW [19:27:02] Fundraising-Backlog: CiviCRM upgrade: unsubscribe from bulk email 504 timeout - https://phabricator.wikimedia.org/T116315#1746227 (DStrine) NEW [19:29:54] Fundraising-Backlog: CiviCRM upgrade: merging contacts button does not appear - https://phabricator.wikimedia.org/T116316#1746240 (DStrine) NEW [19:34:52] Fundraising-Backlog: CiviCRM upgrade: Donation Processing: no refund button after clicking Edit transaction - https://phabricator.wikimedia.org/T116317#1746265 (DStrine) NEW [19:45:08] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1746298 (XenoRyet) @LeanneS I can see where this didn't work on production, but I'm having trouble replicating... [20:06:35] dstrine-meeting: funny hangout issues, trying to log in [20:11:13] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1746374 (LeanneS) @XenoRyet I believe this is because it is a newer Direct Mail Appeal option and Staging only... [20:12:00] Fundraising-Backlog: CiviCRM upgrade: merging contacts button does not appear - https://phabricator.wikimedia.org/T116316#1746376 (DStrine) p:Low>Normal [20:12:27] Fundraising-Backlog: CiviCRM upgrade: Donation Processing: no refund button after clicking Edit transaction - https://phabricator.wikimedia.org/T116317#1746378 (DStrine) p:Low>Normal [20:15:25] Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Unplanned-Sprint-Work: Script to compile civicrm into deployment form - https://phabricator.wikimedia.org/T115925#1746390 (Eileenmcnaughton) a:Eileenmcnaughton [20:17:04] Fundraising-Backlog: CiviCRM upgrade: merging contacts button does not appear - https://phabricator.wikimedia.org/T116316#1746399 (DStrine) p:Normal>Low [20:18:59] Fundraising Sprint Vengaboys, Fundraising-Backlog: SPIKE: assess the condition of adyen for english backup processing - https://phabricator.wikimedia.org/T114958#1746403 (atgo) [20:20:48] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Prepare queue messages for testing on upgraded Civi. Test them. - https://phabricator.wikimedia.org/T114466#1746407 (Eileenmcnaughton) Did you test some rejects to ensure the except... [20:33:52] Fundraising-Backlog: CiviCRM upgrade: merging contacts button does not appear - https://phabricator.wikimedia.org/T116316#1746442 (Ejegg) It looks like selecting an action from the dropdown automatically submits the form, but it doesn't have a spinner and takes a while to load the next page. I tried it with... [20:36:54] Fundraising-Backlog: CiviCRM upgrade: unsubscribe from bulk email 504 timeout - https://phabricator.wikimedia.org/T116315#1746462 (DStrine) p:Low>Normal [20:38:32] Fundraising-Backlog: CiviCRM upgrade: unsubscribe from bulk email 504 timeout - https://phabricator.wikimedia.org/T116315#1746467 (DStrine) Open>declined [20:41:52] Fundraising-Backlog: CiviCRM upgrade: Simple Lookups: timeout attempting to look up matching gifts given in August - https://phabricator.wikimedia.org/T116313#1746473 (DStrine) [20:43:00] Fundraising-Backlog: CiviCRM upgrade: Simple Lookups: timeout attempting to look up matching gifts given in August - https://phabricator.wikimedia.org/T116313#1746211 (DStrine) @LeanneS This is from the civicrm upgrade. Can you give more information on this bug? What were you attempting to do? [20:43:48] eileen: '38. In 1996, a man broke into a radio station in Wanganui and took the manager hostage, demanding that they play the http://edition.cnn.com/WORLD/fringe/9603/03-27/index.html song “Rainbow Connection”.' I mean, that's a pretty sweet song. [20:44:06] Fundraising Sprint Vengaboys, Fundraising-Backlog: CiviCRM upgrade: Simple Lookups: timeout attempting to look up matching gifts given in August - https://phabricator.wikimedia.org/T116313#1746211 (DStrine) [20:44:29] hah! [20:47:11] also, it's pretty cool to see the CNN site still has its 1996 pages up with the original formatting [20:54:49] Oh hey guys. [20:55:38] atgomez: You around? [20:59:01] :/ [20:59:04] cold [20:59:08] hahaha [20:59:17] Hey, how's France? [20:59:32] the donations are rolling in [20:59:40] one small bug i'm about to have a fix for [20:59:56] speak of the failmail [21:02:02] heh [21:02:43] cwd: Just one? [21:02:54] That's pretty fantastic. [21:03:07] far as i can tell anyway [21:03:22] the worst ones just quietly butcher data for a month before being noticed [21:05:01] Sounds about right. [21:15:57] K4-713: i went to grab lunch, but i am now around [21:16:20] atgomez: Yo. I was just checking in. [21:16:30] yo [21:16:41] all's well. i'm all alone in the office [21:16:44] happy birthday!! [21:16:45] Mostly to say "Wow, I took longer than I thought to get where I was going today" [21:16:49] Thank you! [21:17:06] ohh bad flight stuff? [21:17:18] (PS1) Cdentinger: require payment method for worldpay esop [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248244 [21:17:18] Nah, I'm just an idiot. [21:17:23] :D [21:17:43] happy bday k4! [21:18:05] cwd: Thanks! [21:18:07] ha ok K4-713. [21:18:12] good to get humbled once in a while ;) [21:18:14] atgomez: I forgot to set an alarm this morning, and then I forgot I was flying out of SF instead of Oakland... [21:18:22] oh NO [21:18:28] that's… impressive [21:18:35] I made it to the plane with like... ten minutes to spare. [21:18:36] though i have definitely gone to the wrong airport before [21:18:38] oh wow! [21:19:13] Also: No more "let's talk over drinks" the night before a flight. [21:20:02] hahahahah did you not see my PSA about this a month ago?? [21:20:07] I did. [21:20:15] And I think I absolutely agreed with it at the time. [21:20:21] hahahahhaha [21:20:54] So Much Oops. [21:22:30] yep [21:22:42] luckily, you can bounce back from it quickly once actually reaching your destination! [21:22:44] (CR) Katie Horn: [C: 2] require payment method for worldpay esop [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248244 (owner: Cdentinger) [21:23:17] Yes! [21:23:30] thanks K4-713 ! [21:23:48] (CR) Ejegg: [C: -1] "Almost there! I hope you are able to try it out locally in a couple of different browsers." (4 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247990 (https://phabricator.wikimedia.org/T72462) (owner: Rosalieper) [21:23:48] cwd: No problem. :) [21:27:44] what was happening was someone's session expires while the page to fill out the form to get the iframe is sitting there [21:28:19] Man. [21:28:23] they fill out the form and do an ajaxy post and a geoip lookup finds their country and from that builds out a whole new session that goes through the pipeline just fine missing only payment method [21:28:32] People really just zone out in the middle of things like that, don't they? [21:28:38] which i could not reproduce cause i didn't have php5-geoip installed [21:29:10] In the middle of making a credit card payment: "Oh shit: I really should go spackle the den..." [21:29:11] they do indeed [21:29:41] or they just click a youtube video [21:29:44] 16 hours later [21:29:49] oh hey what's this tab [21:31:56] we've all been there [21:32:17] i actually do that on purpose sometimes… like if i don't have my credit card on me i'll open the tab to come back to later [21:33:23] (CR) Ejegg: [C: -1] "I don't think this is the right way to go - won't it just give them an error message that they can't do anything about? We should either " [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248244 (owner: Cdentinger) [21:33:52] oops, sorry K4-713, didn't see you'd already approved that! [21:35:26] ejegg: Good point, though... [21:36:49] cwd: Are you hoping to get that fix out soon? [21:37:31] i was just commenting [21:37:53] i'm ok waiting and doing it better [21:38:10] we should be able to salvage the bad data this is creating right? just fill in payment methods [21:38:38] (CR) Cdentinger: "Yeah you're right, I was trying to do the minimum thing but it's a bad user experience." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248244 (owner: Cdentinger) [21:38:41] Or, wait for the audit. [21:38:54] oh good call [21:39:05] This is why I love the nightly reconciliation. [21:39:13] yeah that's a great feature [21:39:16] eventual consistency [21:39:37] We could either grep through emails and hand-repair a minor mess, or... wait a few hours. :) [21:39:49] K4-713: we're still having the ct_id change between initial landing and the real charge [21:40:06] That's so... odd. [21:40:13] If we want to associate all the tracking info with the donation, we need to re-submit it on the api call [21:40:23] 'cause we render most of it into hidden fields on the form [21:40:37] K4-713: new session, new ct_id [21:40:48] (Merged) jenkins-bot: require payment method for worldpay esop [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248244 (owner: Cdentinger) [21:41:03] only the referrer is now the worldpay gateway itself [21:41:07] ejegg: Hargh. Well, you should be able to pass in the contribution tracking id in querystring. [21:41:22] It used to come in already set like that from donate wiki. [21:41:39] However, there's probably a ton of logic to make sure that gets nuked now. [21:41:58] ah ha, maybe we should put that in a hidden field? [21:42:07] cwd: it's already there! [21:42:07] One of those SERIOUSLY_RESET_ENTIRE_SESSION_ALL_THINGS_ARGH() functions. [21:42:30] I think what I'm saying is that this is probably my fault. [21:42:32] along with all the utm_ fields, payment_method, referrer, etc [21:42:50] oh, so i wonder why payment_method is dropping off [21:42:57] I just don't know why these donors are getting through the token checks [21:43:15] Doesn't it reset if they don't? [21:43:16] yeah i was about to do some var dumping [21:43:17] cwd: we're not actually submitting the form, just making an ajax call to api.php [21:43:51] mismatched token message basically says "your session has expired, start over" [21:44:28] Even on an api call? [21:44:44] just checking for that now [21:44:47] Or, does it just try to automatically recover and do something strange? [21:45:07] That wouldn't surprise me. [21:45:26] wierd, looks like it /should/ be checking tokens and adding an error message if no match [21:45:42] Good, good... [21:46:02] What about if there's no token at all? [21:46:21] although that error message just tells them to fill out the fields and submit again, which won't help 'cause the token will be the same as on the last ajax call [21:46:36] What if it somehow thinks it's a "start entirely over" situation? [21:46:39] so the expiry error should come back with a fresh token [21:47:13] heh well i don't have it sending payment_method in the api call [21:47:25] which would probably also "fix" this [21:47:35] Probably couldn't hurt. [21:47:41] but the session disparity would remain [21:47:42] cwd I think the api call should post back the whole set of hidden fields in the form [21:47:42] ...probably. [21:47:56] Is there a chance that we're overusing the final status somewhere? [21:48:00] oh, dang. not sending token either... [21:48:11] AHA [21:48:21] :S [22:13:04] (PS1) Cdentinger: error and reload if session expired on api call [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248259 [22:13:33] (CR) jenkins-bot: [V: -1] error and reload if session expired on api call [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248259 (owner: Cdentinger) [22:18:57] (PS2) Cdentinger: error and reload if session expired on api call [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248259 [22:43:07] (PS1) Eileen: Set gitreview to point to civi-4.6.9 [wikimedia/fundraising/civicrm-drupal] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248260 [22:43:38] (PS2) Cdentinger: pass donation amount in return url [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/247946 [22:44:03] (PS1) Eileen: Set gitreview to point to civi-4.6.9 [wikimedia/fundraising/civicrm-packages] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248261 [23:02:35] (PS3) Ejegg: error and reload if session expired on api call [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248259 (owner: Cdentinger) [23:03:58] (CR) Ejegg: [C: 2] "This looks like it'll work. TODO: WP api.php request should also fail on blank token / no session." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248259 (owner: Cdentinger) [23:04:24] (Merged) jenkins-bot: error and reload if session expired on api call [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248259 (owner: Cdentinger) [23:11:06] (CR) Ejegg: [C: 2] "Now THAT's an elegant solution!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/247946 (owner: Cdentinger) [23:11:42] (Merged) jenkins-bot: pass donation amount in return url [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/247946 (owner: Cdentinger) [23:16:51] (PS1) Eileen: Fix Permission Check on Sheduled and Sent Mailings list [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248265 [23:20:51] (PS1) Eileen: CRM-17000 bypass separatevalues for getfields for performance [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248266 [23:20:52] (PS1) Eileen: CRM-14232 default not filling for contact preferred language [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248267 [23:20:55] (PS1) Eileen: CRM-17422 remove prefixing of wildcard to search. [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248268 (https://phabricator.wikimedia.org/T99836) [23:20:56] (PS1) Eileen: CRM-17310 my reports [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248269 [23:20:58] (PS1) Eileen: CRM-17310 further fix to my reports [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248270 [23:21:00] (PS1) Eileen: Include .gitreview [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248271 [23:51:53] (CR) Ejegg: [C: 2] "Wow, there are almost an equal number of places where using the singular and the plural. Civi really needs to decide on one or the other." [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248265 (owner: Eileen) [23:52:37] (CR) Ejegg: [V: 2] "Wow, there are almost an equal number of places using the singular and the plural. Civi really needs to decide on one or the other." [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248265 (owner: Eileen) [23:52:53] (CR) Eileen: "Yeah - sigh - that one goes way back too :-(" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248265 (owner: Eileen) [23:54:10] (CR) Eileen: "Worse - they actually mean slightly different things!" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248265 (owner: Eileen)