[00:25:16] (CR) Eileen: [C: 2] "I'm going to self-verify this because it is already in the deployment repo & this is just part of the initial sync of the dev repo with th" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248266 (owner: Eileen) [00:27:13] (CR) Eileen: [V: 2] "I'm going to self-verify this because it is already in the deployment repo & this is just part of the initial sync of the dev repo with th" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248266 (owner: Eileen) [00:51:59] (PS1) Eileen: CRM-17435 Add option to generate drupal_7 directory version [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248274 [00:55:18] (PS1) Eileen: stop ignoring packages & drupal so we can submodule them [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248275 (https://phabricator.wikimedia.org/T115925) [01:00:15] (PS2) Eileen: stop ignoring packages & drupal so we can submodule them [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248275 (https://phabricator.wikimedia.org/T115925) [01:00:22] (PS1) Eileen: Add script for compiling deployment repo [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248276 (https://phabricator.wikimedia.org/T1152925) [01:07:50] Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, and 2 others: Script to compile civicrm into deployment form - https://phabricator.wikimedia.org/T115925#1747257 (Eileenmcnaughton) I haven't really tried this end-to-end yet because the instruc... [01:23:53] (PS7) Rosalieper: $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247990 (https://phabricator.wikimedia.org/T72462) [03:27:26] (CR) Krinkle: [C: -1] $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247990 (https://phabricator.wikimedia.org/T72462) (owner: Rosalieper) [03:45:28] (PS8) Rosalieper: $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247990 (https://phabricator.wikimedia.org/T72462) [03:49:15] (CR) Rosalieper: "submitted the new patch set." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247990 (https://phabricator.wikimedia.org/T72462) (owner: Rosalieper) [03:54:13] Krinkle: did you see it? i submitted the changes you asked for [03:54:14] :) [03:54:44] r054l13: Yes, but there's a few dozen other changes I'm reviewing now :) [03:55:05] Krinkle: ok, just let me know the changes and i will do it. [04:29:45] (CR) Eileen: "Note the main discussion of this is on JIRA CRM-17435 & in the readme in the commit that follows on from this & adds WMF specific 'stuff'" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248274 (owner: Eileen) [04:35:26] Krinkle: waiting [04:44:44] (CR) Eileen: Add test class for reports (6 comments) [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243118 (owner: Eileen) [08:20:40] Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Worldpay frontend donation missing payment_method - https://phabricator.wikimedia.org/T115932#1747584 (awight) p:High>Unbreak! [08:37:57] (PS1) Eileen: CRM-17422 fix - Change in custom field search behaviour impacting on performance [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248294 (https://phabricator.wikimedia.org/T99842) [13:36:38] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1747925 (Jgreen) >>! In T97676#1739669, @awight wrote: > Confirmed that the campaig... [16:06:21] (PS8) AndyRussG: Add banner history log ID processor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (https://phabricator.wikimedia.org/T112022) [16:06:47] (CR) jenkins-bot: [V: -1] Add banner history log ID processor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (https://phabricator.wikimedia.org/T112022) (owner: AndyRussG) [16:07:04] (CR) AndyRussG: Add banner history log ID processor (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (https://phabricator.wikimedia.org/T112022) (owner: AndyRussG) [16:13:54] ejegg: do you see a reason to revert f78bb09b1bb93d66f87ea121385846670a05a768 ? [16:14:18] i don't think it will even do anything [16:15:13] no, I don't think we need to [16:15:32] cool, think i'll deploy this stuff then [16:15:33] sort of a belt-and-suspenders thing [16:15:35] thanks for the cr! [16:15:37] hehe yeah [16:16:30] i was also thinking in the abstract shouldn't checkTokens fail if there are no tokens? realize there might be Implications™ [16:20:45] cwd: depends on where [16:21:04] (PS1) Cdentinger: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/248358 [16:21:11] for donors just entering the flow, blank token should be fine [16:21:22] but on the api.php post, yeah, blank should fail [16:22:28] ejegg: yeah i meant like at the function level, like something called checkTokens should require tokens [16:22:42] and maybe a separate thing to ask if there are any [16:23:31] want to patch that api up for sure, just thinking about the best behavior [16:23:38] hmm, yeah, that's what I would have expected too [16:25:22] cool well i'll look into that anyway [16:25:28] see what a refactor would look like [16:26:00] right on [16:26:53] ejegg: assume this is ok to go? https://gerrit.wikimedia.org/r/#/c/247096/ [16:27:12] lemme take a look [16:27:24] oh yeah, totally [16:29:19] ejegg: i haven't dug at this yet but i swear i used to run DI tests with --group DonationInterface but suddenly (as of a couple days ago) that's not finding any tests [16:29:29] did i change something or did something change? [16:29:43] you're not on deployment branch, are you? [16:30:08] heh nope but i did make that mistake before [16:30:24] err, let me see if it changed for me. What version of core? [16:30:39] 1_25 [16:30:57] (CR) Cdentinger: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/248358 (owner: Cdentinger) [16:32:10] finds 'em all on my machine! [16:32:32] umm... failing a bunch though [16:32:44] uh oh [16:32:59] won't that fail on jenkins?? [16:33:26] weird, all the xml comparisons are failing because the actual has the element stripped off [16:33:50] you'd think... but maybe I've inadvertantly messed with some php setting [16:34:26] huh [16:34:34] there are a lot of moving parts :) [16:35:10] yeah... you can't think of any offhand that would make strip that xml intro, can you? [16:36:25] ejegg: hrm well short tags might mess with it [16:36:28] the yeah, that one [16:36:42] I'll look into short tags, thanks! [16:36:53] yup! should be in php.ini [16:36:57] or maybe fpm.conf [16:37:19] oh, not the php file start, this is the XML generated for API requests [16:37:55] could it be mistaking that for php tags? [16:38:21] i've definitely had stuff like that happen with short tags on [16:38:32] don't think so, but I'll dig in [16:43:30] (PS1) Cdentinger: update DonationInterface [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/248365 [16:44:40] (CR) Cdentinger: [C: 2] update DonationInterface [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/248365 (owner: Cdentinger) [16:46:48] ejegg: doesn't that core commit usually take like 10 minutes and run the tests and stuff? that merged instantly [16:48:25] i see it in zuul...but i also just pulled the change down [16:48:27] cwd: weird, the log on the zuul page shows it taking 3 minutes [16:48:30] i'm confused [16:48:55] Your branch is up-to-date with 'origin/fundraising/REL1_25'. [16:48:56] wait, it shows it's still running [16:49:14] yeah [16:49:42] but it sure looks like it already merged to me [16:49:48] am i missing something? [16:49:55] ah, I think you can 'publish' or 'publish and submit' in this branch [16:50:12] and 'publish and submit' will insta-merge if it already has v+2 [16:51:02] aah, nice [16:51:46] tyler says the new phab stuff is not any better than gerrit [16:51:53] after using it for awhile [16:52:00] * cwd dies a little inside [16:52:04] aww, man [16:53:00] it's got a cli tool called arcanist that he says is just as frustrating [16:53:55] Surely the web UI must be more efficient [16:54:22] yeah, i mean the hard link between the tickets and the bugs would be great [16:54:58] i wonder if anyone at wmf has explored https://about.gitlab.com/ [16:55:37] all open source, huh? [16:55:58] yep, if it's basically open source github, GREAT [16:56:06] hmm, nice [16:56:12] i haven't actually used it [16:56:30] but gerrit and differential both suffer from the same thing [16:56:50] git only needs like 2 centralized features to make it awesome: pull requests and comments [16:57:05] not a whole insane software suite of bad abstractions [16:57:28] imo [16:57:34] it's already a swiss army knife [16:58:25] that sounds about right! [16:58:26] anyhoo imma deploy DI [16:58:30] err wait...it's friday [16:58:42] i will take full responsibility [16:58:44] heh, oh, that [16:58:47] k [16:58:53] but i think it's better to plug this leak before the weekend [16:59:00] the failmails [16:59:01] yeah, guess so [16:59:34] after the deploy settles, let's see if the audit caught yesterday's fails [17:00:19] yeah [17:04:38] !log updated payments from 4d38158f3d3a3a6da85d809a6cdc557e46c45d0c to 71d2d927f4efac1a639aaf7627c765f48d1b129c [17:04:44] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:05:03] everything looks working...confirmed session cookie stuff works [17:06:29] nice, nice [17:06:31] ejegg: hrm i see what must be perms error in jenkins [17:07:55] oh? [17:08:24] one sec, finding 2fa [17:09:04] of course it moved the files and overwrote perms [17:09:15] ah, the audit files [17:09:58] oh, this is the 'cannot chmod' warning? I think that's been there a while [17:10:26] ooh, ok, interesting [17:10:44] apparently it didn't find any new ones...i'll check the audit file for some known missing [17:11:52] i don't see em, but i think it can take a couple days to get into the audit file [17:13:12] ok [17:13:45] looks like it parsed properly and everything [17:14:14] there are also those 10 that it's never going to find because they're spread out weird in the logs [17:14:28] how do you mean? [17:15:22] err wait, no this wasn't the dates after all [17:15:40] it's that they are marked with WP's order ID, before we had them start using ours [17:15:53] so the log file parser isn't looking for the same string [17:16:51] i thought it was the dates at first [17:17:24] we could manually massage those somehow, or else it's just going to find them every day for eternity [17:19:33] hmm, we should do /something/ soon to make sure those donors get thanked [17:21:32] Will the Stomp message header contain a description property with the queue name? [17:21:55] ejegg|afk: i think they were actually all test donations [17:22:14] 10/1 was the first live stuff [17:23:00] AndyRussG: The queue name won't be added as a header, unless funny stuff happens like requeueing to another queue [17:24:46] What was the special effect you were looking for? [17:25:14] There's an open bug to tighten down an explicit "message class" [17:25:15] awight: eh not terribly important, just wanted to include the name of the actual queue the message is on in the error messages [17:25:27] In which code? [17:25:34] throw new WmfException( 'BANNER_HISTORY', [17:25:34] 'Couldn\'t parse queue message from ' . [17:25:35] variable_get( 'banner_history_queue', '/queue/banner-history-test' ) . [17:25:35] '.' [17:25:35] ); [17:25:39] aha [17:25:51] The individual message processor in banner_history.module [17:26:15] I think there's a try-catch block in the dequeue loop [17:26:21] I can say variable_get etc. but I thought if the message itself knew what queue it was from, that'd be more debuguous [17:27:04] Yeah I think so! But the messages go somewhere... [17:27:06] Maybe report the queue name around modules/wmf_common/Queue.php line 112 [17:27:12] (I assume...) [17:28:24] If you've defined the BANNER_HISTORY error as non-fatal, and set the "reject" flag on that error type in WmfException.php, then error-causing messages will be requeued into -damaged [17:29:37] awight: ah K nice! Yeah did that :) [17:29:38] hey dstrine - i'm going to call in from my laptop so you can give up browne for the retro if you'd like [17:29:50] ah ok [17:29:51] will do [17:31:55] atgomez: Sorry I'm WFH too! Just woke up from yesterday's crayzee [17:38:13] Fundraising-Backlog: gatewayadapter/checkTokens() should handle missing tokens - https://phabricator.wikimedia.org/T116399#1748648 (cwdent) NEW [17:44:38] Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Worldpay frontend donation missing payment_method - https://phabricator.wikimedia.org/T115932#1748703 (cwdent) Open>Resolved a:cwdent This has 2 lines of defense now: https://... [17:44:39] Fundraising-Backlog: [epic] Worldpay campaign ready in France - https://phabricator.wikimedia.org/T110114#1748706 (cwdent) [17:47:07] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Record actual amount charged regardless of what's in session - https://phabricator.wikimedia.org/T115171#1748730 (cwdent) Open>Resolved Deployed [17:47:44] Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Worldpay frontend donation missing payment_method - https://phabricator.wikimedia.org/T115932#1736509 (cwdent) [17:54:28] Fundraising Sprint Vengaboys, Fundraising-Backlog: CiviCRM upgrade: Simple Lookups: timeout attempting to look up matching gifts given in August - https://phabricator.wikimedia.org/T116313#1748765 (LeanneS) @Dstrine Sure. I was using the Find Contributions function to look up the total $ amount for matchi... [18:08:28] (PS1) Ejegg: Fix name of staged variable risk_score [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248382 (https://phabricator.wikimedia.org/T114958) [18:08:34] (PS1) Ejegg: Build expected XML with same merchant ID as actual [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248384 [18:08:54] (CR) jenkins-bot: [V: -1] Fix name of staged variable risk_score [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248382 (https://phabricator.wikimedia.org/T114958) (owner: Ejegg) [18:19:56] (PS2) Ejegg: Fix name of staged variable risk_score [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248382 (https://phabricator.wikimedia.org/T114958) [18:20:18] (CR) jenkins-bot: [V: -1] Fix name of staged variable risk_score [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248382 (https://phabricator.wikimedia.org/T114958) (owner: Ejegg) [18:23:09] (PS3) Ejegg: Fix name of staged variable risk_score [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248382 (https://phabricator.wikimedia.org/T114958) [18:29:29] Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: SPIKE: assess the condition of adyen for english backup processing - https://phabricator.wikimedia.org/T114958#1748941 (Ejegg) We're currently using hosted payment pages, in an iframe. It's still enabled on production, and almost wor... [18:31:34] Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: SPIKE: assess the condition of adyen for english backup processing - https://phabricator.wikimedia.org/T114958#1748945 (Ejegg) a:cwdent>Ejegg [18:37:51] Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: SPIKE: assess the condition of adyen for english backup processing - https://phabricator.wikimedia.org/T114958#1748985 (atgo) @ejegg amazing!! [18:40:46] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1748993 (awight) That's correct. Please add the appeal using this URL: https://civicrm.frdev.wikimedia.org/adm... [18:41:08] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1748994 (awight) Meanwhile, can you change the event name to one that existed in September, for testing purposes? [18:41:09] Fundraising-Backlog: Out of date donation page still active (and possibly an audit of all available donation pages and inbound links?) - https://phabricator.wikimedia.org/T114910#1748995 (Pcoombe) Okay, I've fixed the links in that template on meta. It may take some time to propagate. The other pages on wik... [18:45:45] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1749005 (XenoRyet) Yea, using last year's appeal reproduces the bug. This will give me something to go on for... [18:51:37] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1749023 (ellery) Special:BanenrLoader currently does not include the campaign as a... [18:52:47] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Document how to create new campaigns in Civi - https://phabricator.wikimedia.org/T116415#1749032 (awight) NEW [18:53:44] Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: SPIKE: assess the condition of adyen for english backup processing - https://phabricator.wikimedia.org/T114958#1749041 (Ppena) As a bit of context here: These forms worked with a few % lower success rate than our current forms. The... [18:54:16] dstrine: yeesh, you look busy at the moment. But I was hoping to get a dump of whatever happened yesterday wrt. the Civi upgrade. If there are any more or fewer blockers. If how we track things changed. [18:56:06] Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: SPIKE: assess the condition of adyen for english backup processing - https://phabricator.wikimedia.org/T114958#1749042 (atgo) As a backup processor for this December, I think we should plan on the shortest path to success an revisit a... [18:56:15] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: Followup tasks after Civi 4.6 upgrade (tracking) - https://phabricator.wikimedia.org/T116416#1749043 (awight) NEW [18:57:50] awight: yeah lots of meetings :( [18:57:56] I should be out by 12:30 [18:58:04] I can ping you [18:58:18] k [19:03:19] ccogdill: Wondering if you know anything about a "2015 SF" campaign--did you create that? [19:03:41] for the Major gifts event, I assume? [19:03:45] yeah [19:03:48] I didn’t create the campaign name [19:03:56] maybe Leanne did when importing contributions... [19:04:03] she says she didn't... [19:04:07] hah [19:04:09] Anna? [19:04:13] sorry to bother you with this [19:04:17] I'll ask her next [19:04:28] no problem. If it’s not Anna I’m not sure who [19:04:33] But I'm curious because there's a training gap, we need to create campaigns through a new custom interface [19:04:39] I want to make sure everyone involved is CC'd [19:04:50] I'll add you just fyi [19:05:17] sounds good [19:07:11] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: WMF campaigns forms should reject utm_campaign names if they include a whitespace - https://phabricator.wikimedia.org/T116419#1749078 (awight) NEW [19:07:35] AndyRussG|mmmtn: Any opinions on this new contributor's patch, besides the commit message needing to be updated? https://gerrit.wikimedia.org/r/247990 I [19:07:43] (CR) Awight: [C: 2] Fix name of staged variable risk_score [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248382 (https://phabricator.wikimedia.org/T114958) (owner: Ejegg) [19:07:51] awight: I'm free now. Re civicrm, we only brought in one bug to this sprint: https://phabricator.wikimedia.org/T116313 We didn't have enough information so we brought it in just in case. Leanne has just responded. What do you think of severity? [19:08:11] (Merged) jenkins-bot: Fix name of staged variable risk_score [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248382 (https://phabricator.wikimedia.org/T114958) (owner: Ejegg) [19:08:38] AndyRussG|mmmtn: I'm hesitant to merge it myself because I suggested a lot of how it was caded [19:08:41] *coded [19:08:51] awight: I also commented on two possible bugs in the test plan. I was asking your advice on priority for those too. [19:08:55] dstrine: that looks like a near-blocker [19:08:59] kk [19:09:05] k, looking at the plan [19:09:06] glad we added it! :) [19:09:10] thanks awight [19:10:36] dstrine: Let's add "should haves" to https://phabricator.wikimedia.org/T116416 and [19:10:49] "must haves" to https://phabricator.wikimedia.org/T99842 or https://phabricator.wikimedia.org/T99844 [19:10:54] you think? [19:11:01] ah ok [19:11:13] hey awight, I think you got the wrong Anna [19:11:20] I mean Anna Stillwell :D [19:11:27] argh, thx [19:11:42] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [Epic] Followup tasks after Civi 4.6 upgrade - https://phabricator.wikimedia.org/T116416#1749091 (DStrine) [19:11:57] Fundraising Sprint Vengaboys, Fundraising-Backlog: CiviCRM upgrade: Simple Lookups: timeout attempting to look up matching gifts given in August - https://phabricator.wikimedia.org/T116313#1749094 (awight) [19:11:58] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Install 4.6 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1749093 (awight) [19:12:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Document how to create new campaigns in Civi - https://phabricator.wikimedia.org/T116415#1749096 (awight) [19:12:34] Fundraising-Backlog: CiviCRM upgrade: Donation Processing: no refund button after clicking Edit transaction - https://phabricator.wikimedia.org/T116317#1749099 (DStrine) [19:12:35] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [Epic] Followup tasks after Civi 4.6 upgrade - https://phabricator.wikimedia.org/T116416#1749043 (DStrine) [19:12:47] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [Epic] Followup tasks after Civi 4.6 upgrade - https://phabricator.wikimedia.org/T116416#1749043 (DStrine) [19:12:48] Fundraising-Backlog: CiviCRM upgrade: merging contacts button does not appear - https://phabricator.wikimedia.org/T116316#1749101 (DStrine) [19:12:59] dstrine: I think the date range thing is a near-blocker, too [19:13:09] Fundraising-Backlog: CiviCRM upgrade: tracking donor moves: adding an activity should default to ""completed"" not ""scheduled"" - https://phabricator.wikimedia.org/T116314#1749108 (DStrine) [19:13:10] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [Epic] Followup tasks after Civi 4.6 upgrade - https://phabricator.wikimedia.org/T116416#1749043 (DStrine) [19:13:26] Fundraising-Backlog: CiviCRM upgrade: Search bar: Default search field is name only - https://phabricator.wikimedia.org/T116310#1749112 (DStrine) [19:13:27] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [Epic] Followup tasks after Civi 4.6 upgrade - https://phabricator.wikimedia.org/T116416#1749043 (DStrine) [19:14:37] awight: any civi stuff I can help with? Don't think I can move forward on Adyen without Friday-deploying that bit [19:15:03] hehehe [19:15:08] mm, you can't run it locally? [19:15:30] Extra help on Civi would be awesome, though, I'm starting to sweat [19:15:37] Not that I'm lifting much [19:16:02] suppose I could run locally, but I'd rather have the end-to-end test with logs and audits and all [19:16:16] ejegg: Neat! I'll take a look at it in a bit :) [19:16:17] that should be possible locally [19:16:22] any particular civi task you can point me at? [19:16:41] sure! I'm just now sorting things into blockers, and should-haves [19:16:49] https://phabricator.wikimedia.org/T116416 [19:16:54] and https://phabricator.wikimedia.org/T99842 [19:16:56] for tracking [19:17:11] cool, i'll start there [19:17:33] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi 4.6 date range fields are unusably annoying - https://phabricator.wikimedia.org/T116420#1749123 (awight) NEW [19:17:56] ejegg: Helping sort out real bugs from the test plan doc would be helpful as well [19:18:09] * awight counts duplicate words in dismay [19:29:54] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: WMF Campaign page whitescreens if metadata is missing - https://phabricator.wikimedia.org/T116423#1749161 (awight) NEW [19:31:27] hey awight just wanted to check in with you since you weren't around yesterday [19:31:52] awight: I think I entered all the relevant bugs from the test plan. there were 6 [19:32:07] looks like T116313 was another version of one we resolved [19:32:54] awight: there were 1 or 2 complaints about not getting emails but all emails were disabled right? [19:33:10] (PS1) Awight: Fail gracefully if campaigns were added using the native Civi interface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/248414 (https://phabricator.wikimedia.org/T116423) [19:33:23] eileen: hi! [19:33:30] hey! [19:33:45] yeah emails were disabled! [19:33:47] eileen: I'm trying to sort bugs by whether they're blockers, at the moment... [19:34:35] eileen: I think this is a big one, https://phabricator.wikimedia.org/T116420, and it might be easy to workaround [19:35:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi 4.6 date range fields are unusably annoying - https://phabricator.wikimedia.org/T116420#1749191 (awight) [19:35:52] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: WMF Campaign page whitescreens if metadata is missing - https://phabricator.wikimedia.org/T116423#1749193 (awight) [19:35:53] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [Epic] Followup tasks after Civi 4.6 upgrade - https://phabricator.wikimedia.org/T116416#1749192 (awight) [19:35:56] ah - the reason they have ranges is the range is saved & then your 'contributions this month' smart group is always this month - even if this changes [19:36:06] Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, Patch-For-Review: WMF Campaign page whitescreens if metadata is missing - https://phabricator.wikimedia.org/T116423#1749161 (awight) [19:36:56] eileen: Not quite following that [19:38:48] awight: if you do a search on membership.join_date = 'last month' [19:38:53] & create a smart group [19:39:03] then in Sep that will show Aug signups [19:39:12] & in Oct that will show Sep sign-ups [19:39:29] That sounds nice. So that's the case with all the date options? [19:39:30] which is quite different to rendering the dates into the fields [19:39:33] yes [19:39:36] ook [19:39:52] So I guess the fix is just a tweak to make the date range dropdown look right [19:39:57] and some training [19:40:18] yeah - I emailed Coleman just now to see what his thoughts are on it [19:40:22] It be really luxurious if the date range were translated into a static field though, so the user could double-check the exact dates [19:40:26] thx! [19:40:47] I think when you render the search it shows the dates. [19:40:56] the most disconcerting detail is that the dropdown says -any-, but when you click on it, it looks like "use date range" is already selected [19:42:52] ccogdill: Wondering, do you actually use the "unsubscribe from spam" link? [19:43:07] awight yes, I know donor services does [19:43:19] MBeat can confirm lest the process has changed since I was there... [19:43:34] yes, we still use it [19:43:55] pretty regularly after bulk emails [19:44:12] re unsub from spam - the part that was Civi related did work - or it wouldn't have gotten to the stomp-hang [19:44:43] ccogdill: MBeat: That feature was originally supposed to be a self-service thing for donors [19:45:05] All it does is, set is_opt_out on the contact record. [19:45:13] Can we switch to doing that directly? [19:45:21] yeah, it’s just a lot faster than looking up the record... [19:45:29] ooh [19:45:30] wow [19:45:42] cos it's insanely complex on the backend [19:45:54] k, well i’ll leave that up to Mbeat :) [19:46:17] It's not an emergency, we can keep this feature around until we've built something beter. [19:47:06] I’d be inclined to still be able to use it if it doesn’t break anything elsewhere; the updating donor records process is pretty slow [19:47:24] good feedback to have [19:47:54] but if it turns out to cause monkeywrenches, just holler and I can update how DS does it to setting is_opt_out [19:49:09] Naw, I was hoping to cut the leg off, but the fact that it's useful is enough reason to keep it working [19:51:36] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Unsubscribe link doesn't work on upgraded staging 4.6 - https://phabricator.wikimedia.org/T116112#1749250 (awight) [19:51:37] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [Epic] Followup tasks after Civi 4.6 upgrade - https://phabricator.wikimedia.org/T116416#1749249 (awight) [19:51:54] eileen: I'll configure the STOMP stuff so we can finish testing things that use it... [19:52:33] awight: OK - it makes it low risk it's it's stomp - ie. the civi stuff didn't fail in that process [19:52:47] so, the stuff that has changed was OK [19:52:55] just changed the config, retesting now [19:53:03] cool [19:53:47] works. [19:54:23] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: WMF Civi admins test their normal workflows on the staging server - https://phabricator.wikimedia.org/T114823#1749261 (awight) [19:54:24] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [Epic] Followup tasks after Civi 4.6 upgrade - https://phabricator.wikimedia.org/T116416#1749260 (awight) [19:54:26] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Unsubscribe link doesn't work on upgraded staging 4.6 - https://phabricator.wikimedia.org/T116112#1749258 (awight) Open>Resolved Confirmed that the queueing w... [19:56:24] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Prepare queue messages for testing on upgraded Civi. Test them. - https://phabricator.wikimedia.org/T114466#1749268 (awight) [19:57:51] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Prepare queue messages for testing on upgraded Civi. Test them. - https://phabricator.wikimedia.org/T114466#1696321 (awight) [19:58:53] eileen: I've been meaning to ask--we abandoned my patch to report each upgrade step as it happens, but is there an updated patch yet? [19:59:09] I want to run the upgrade one more time with that enabled, maybe once you're through working today [19:59:10] awight: didn't that go in in a different form? [19:59:22] I looked a few days ago and didn't see anything obvious. [19:59:25] I'm not working today - sat - was just checking in [19:59:28] We didn't have a specific task to track that, either [19:59:29] oh! [19:59:46] sorry then, don't get sucked into the vortex! [19:59:53] :-) [20:00:08] * awight updates own flat view of the world [20:00:13] :-) [20:00:54] ejegg: Finally reading your comments on https://phabricator.wikimedia.org/T114466 -- so there were no errors, true? [20:01:24] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Prepare queue messages for testing on upgraded Civi. Test them. - https://phabricator.wikimedia.org/T114466#1749283 (awight) [20:01:36] (PS5) AndyRussG: WIP add banner_history module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/246425 (https://phabricator.wikimedia.org/T112022) [20:01:50] awight: correct, no errors [20:02:00] word! [20:02:07] ejegg: did you try any that triggered exceptions? [20:03:22] Lemme write a unit test for that. We're mainly worried about Civi exceptions, right? [20:03:48] awight: yeah - I'm concerned that you might be expecting the error in one format & that might have changed [20:04:04] eileen: nope, i'll try that next [20:04:36] ok - I'm away but email me if anything seems to be blocking Tuesday (Monday)'s upgrade [20:36:15] awight: MBeat one more thing we may not have tested is whether people's smartgroups work [20:36:44] what is a smartgroup? [20:36:59] Your saved search groups... [20:37:25] ah, got it [20:39:50] that’s not a feature I have used, but I’m happy to test, eileen [20:40:10] MBeat: do other people use it? [20:40:40] I had a customer have trouble (with some specific circumstances) updating a smart group [20:40:47] pretty sure no one on my DS team does, but that’s as much as I can attest to [20:41:00] ok - that's cool [20:41:22] see what awight says when he's out of stand-up [20:41:31] ok [20:42:00] eileen: No, we've gone over smart groups a few times, and I've created useful ones, but the attention span is very brief [20:42:08] Nobody will notice if they stopped working [20:42:10] :-) [20:42:12] cool [20:42:47] eileen: last thing! Should I look for an upstream patch to report upgrade steps? [20:43:40] oh nvm, I found breadcrumbs [20:43:41] https://issues.civicrm.org/jira/browse/CRM-17324 [20:43:57] I'll backport that PR [20:45:18] aah sorry, my patch was merged [20:45:27] eileen: the queue importer seems to throw the expected exceptions with malformed queue messages [20:46:42] ejegg: I think the concern is that I had done some nasty hacking to cause some errors to throw exceptions rather than die or set subtle error fields; and also surfaced some database debug logging in the exception details [20:46:54] eileen removed that cos it was unportably crazy [20:47:01] ooh, where was that? [20:47:32] must have been one of those patches you sorted out a while back... [20:47:45] https://gerrit.wikimedia.org/r/#/c/235359/ -> [20:47:55] https://gerrit.wikimedia.org/r/#/c/235359/4/patches/civicrm-4.2.19-drupal-wmf-api.patch [20:48:08] thanks! [20:48:19] https://gerrit.wikimedia.org/r/#/c/235359/4/patches/civicrm-4.2.19-drupal-wmf-exception.patch [20:48:49] I think that was all [20:49:58] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Time the upgrade itself, and note the load it puts on the database - https://phabricator.wikimedia.org/T115736#1749406 (awight) See upstream patch https://github.com/civicrm/civicrm-... [20:50:20] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Edits to LYBUNT report - https://phabricator.wikimedia.org/T88819#1749411 (CaitVirtue) @XeonRyet Civi Home Page - Reports - LYBUNT MG 2014 [20:50:47] hehe xeonryet [20:50:55] xenonxeno [20:53:24] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Install 4.6 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1749423 (awight) [20:53:25] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Install a safety mechanism to audit manually entered data - https://phabricator.wikimedia.org/T115731#1749420 (awight) Open>declined a:awight Cancelling--we won't be able to get this done in time. [20:53:37] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1749424 (Jgreen) >>! In T97676#1749023, @ellery wrote: > Special:BanenrLoader curre... [20:55:31] awight: it doesn't look like anything programmatically different is going to depend on that, just that we might not get useful information in error messages and fail mail, right? [20:55:32] (CR) Awight: [C: 2 V: 2] CRM-14232 default not filling for contact preferred language [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248267 (owner: Eileen) [20:55:49] (CR) Awight: [C: 2 V: 2] CRM-17422 remove prefixing of wildcard to search. [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248268 (https://phabricator.wikimedia.org/T99836) (owner: Eileen) [20:56:51] ejegg: I'm hoping so. The only catch I can think of is that some of our modules might expect a CiviCRM_API3_Exception and it won't be thrown [20:58:05] Looks like ./wmf_civicrm/wmf_civicrm.module is the only place to look [20:58:22] (CR) Awight: [C: 2 V: 2] CRM-17310 my reports [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248269 (owner: Eileen) [20:58:33] (CR) Awight: [C: 2 V: 2] CRM-17310 further fix to my reports [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248270 (owner: Eileen) [20:58:56] (CR) Awight: [C: 2 V: 2] Include .gitreview [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248271 (owner: Eileen) [21:01:49] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1749449 (ellery) Hmm. I thought Special:RecordImpression was retired and replaced b... [21:04:52] ejegg: so the adyen thing looks working? [21:05:11] cwd: well, almost. I tried in prod and got an error, but it was a trivial fix [21:05:27] haven't deployed or set up credentials locally yet [21:05:52] right on [21:06:08] did you do the original integration? know if it was a pain like worldpay? [21:07:18] cwd: nope, we haven't really been using them since before I got here [21:07:44] all I've done with it till now is patch things where site-wide refactors broke tests [21:08:03] word [21:08:36] well i'm done-ish with worldpay for a minute, want me to mess with adyen? [21:08:52] sure, if you want [21:09:10] i'll see if i can get it running locally [21:09:17] I guess that one patch has near zero likelihood of mesing up anything else if we were to deploy [21:09:51] yeah doesn't look like it touches any live code [21:10:58] (CR) Awight: [C: -1] "Only blocker is the note about obliterating .git in the target directory." (3 comments) [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248274 (owner: Eileen) [21:11:13] (CR) Awight: CRM-17435 Add option to generate drupal_7 directory version (1 comment) [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248274 (owner: Eileen) [21:11:24] we should talk about scripting some deploy stuff too [21:11:56] just some bash scripts could really save a lot of time and potential for errors [21:12:26] yeah... the merge might need some interactivity [21:12:34] yep [21:12:39] and the +2ing [21:12:47] but it would be nice to automatically generate the commit message for that [21:13:00] but i think there's more than enough boilerplate to be worth it [21:13:08] all the branch switching too [21:13:11] yes and yes [21:13:26] post deploy i have to go clean up my mess before getting back to work [21:14:05] but i think probably everyone has a subtly different setup [21:14:22] but it could be good to talk about that too [21:14:53] splitting the steps would be nice; git checkout things in their own function, composer in its own, merge in another [21:15:16] yep [21:15:20] type a "random" code [21:15:55] i'd be happy to take a crack at it [21:16:21] yeah - do we want to standardize on something like - a mw core checkout with swappable extensions folders ( 1 with symlinks to working dirs, 1 with actual checkouts of deployed versions ) ? [21:16:46] that's what i do [21:16:52] very easy to automate [21:17:39] awight develops against trunk, and I'm developing against fundraising/REL1_25 - should we all go to one or the other? [21:17:57] or make that configurable? [21:18:32] there is a git branch equivalent of cd - [21:18:41] switch to whatever branch i was last on [21:18:46] oh, cool [21:18:58] so you could potentially start from where ever [21:19:03] I've been resorting to reflog to remind myself what I was doing [21:19:16] reflog is a life saver [21:19:56] ejegg: my deployment repo is always set to fundraising/REL1_25, and that's where we'd be running this script [21:20:05] ok [21:20:15] git checkout - [21:20:40] maybe we should standardize on having a separate deployment repo from our dev repo then [21:20:59] How would you merge and cherry-pick? [21:21:20] oh sry, you're just saying two clones [21:21:53] fwiw, I'm working on this same problem here, https://gerrit.wikimedia.org/r/#/c/248274/ [21:22:38] fun [21:22:39] (less than exemplary) built-in scripts for compiling Civi master into the distributable form [21:23:14] does it get deployed as tarball? [21:24:05] I'm even more swayed than usual by the argument for always putting objects into a separate dir, so sure I can second the motion to standardize on using two clones when deploying [21:24:23] cwd: eileen removed the tarball logic from this build script, for our use case [21:24:46] (CR) Ejegg: [C: 1] "The code looks good to me, and it seems to work locally, at least in Firefox and Chrome! Please update the commit message to reflect the " [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247990 (https://phabricator.wikimedia.org/T72462) (owner: Rosalieper) [21:31:29] hey AndyRussG - is there a phab task yet for ellery's request about campaign name? [21:36:34] (CR) Awight: Add script for compiling deployment repo (4 comments) [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248276 (https://phabricator.wikimedia.org/T1152925) (owner: Eileen) [21:37:25] atgomez: yes, lemme dig it up. I confirmed that it's already resolved. [21:38:14] atgomez: 50 + - unlike gitify and civibuild this script & the distmaker it calls do not require database access. [21:38:17] [21:38:18] gah [21:38:20] Awight [21:38:28] atgomez: https://phabricator.wikimedia.org/T115925 [21:38:33] dear god [21:38:35] not that one, either [21:38:45] atgomez: https://phabricator.wikimedia.org/T97676 [21:38:46] That one. [21:39:15] Looks like there is a new concern, so nvm my "resolved" above. [21:41:23] (CR) Awight: "Okay, I see the rationale for choosing distmaker as the starting point," [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248274 (owner: Eileen) [21:42:18] also AndyRussG: btw https://phabricator.wikimedia.org/T97676, ewulczyn has a question I can't answer authoritatively [21:49:00] awight: will this resolve the campaign name issue? [21:50:00] from email: "Banner History QA check in" [21:57:05] (CR) Awight: [C: 2] "This is sort of a big departure from upstream... but I guess it's a lot nicer than creating a new repo just to contain our submodule struc" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248275 (https://phabricator.wikimedia.org/T115925) (owner: Eileen) [22:10:41] awight: thx, I'll answer! [22:13:27] I'm thinking of playing with family for the rest of the day, I'll be regrettably online over the weekend to look at Civi upgrade things. Anything I can do before I take off? [22:17:11] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Improve date range search fields better - https://phabricator.wikimedia.org/T116443#1749661 (awight) NEW [22:17:12] awight: all good here for now, thanks 4 asking! [22:17:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Improve date range search fields better - https://phabricator.wikimedia.org/T116443#1749661 (awight) [22:17:22] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi 4.6 date range fields are unusably annoying - https://phabricator.wikimedia.org/T116420#1749668 (awight) [22:17:35] great! [22:18:33] (PS9) Rosalieper: $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247990 (https://phabricator.wikimedia.org/T72462) [22:19:59] (PS10) Rosalieper: $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247990 (https://phabricator.wikimedia.org/T72462) [22:21:25] Fundraising-Backlog: CiviCRM upgrade: Donation Processing: no refund button after clicking Edit transaction - https://phabricator.wikimedia.org/T116317#1749676 (awight) This was implemented by a custom feature in 4.2. Now it's built-in, but the interface has changed. Report here on the new process for doin... [22:24:29] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi 4.6 date range fields are unusably annoying - https://phabricator.wikimedia.org/T116420#1749694 (awight) p:Triage>High @Eileenmcnaughton explained why T115897 isn't the right solution. Editing the task description to pare down this task into... [22:24:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi 4.6 date range fields are unusably annoying - https://phabricator.wikimedia.org/T116420#1749696 (awight) [22:27:40] (PS11) Rosalieper: $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247990 (https://phabricator.wikimedia.org/T72462) [22:28:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import fails with database error - https://phabricator.wikimedia.org/T116445#1749707 (awight) NEW [22:29:37] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Trilogy Import - Gift Data section didn’t populate - https://phabricator.wikimedia.org/T116446#1749715 (awight) NEW [22:32:20] kbye! [22:44:06] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1749757 (AndyRussG) @ellery, sadly we haven't yet been able to ditch Special:Record... [23:02:28] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Trilogy Import - Gift Data section didn’t populate - https://phabricator.wikimedia.org/T116446#1749783 (XenoRyet) a:XenoRyet [23:27:56] (PS6) AndyRussG: Add banner_history module to consume BH log id associations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/246425 (https://phabricator.wikimedia.org/T112022) [23:31:28] (PS12) Aklapper: Make $wgNoticeCloseButton not load closeWindow19x19.png from upload.wikimedia.org [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247990 (https://phabricator.wikimedia.org/T72462) (owner: Rosalieper) [23:39:59] awight... is not here. [23:40:06] Dangit. [23:40:47] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import fails with database error - https://phabricator.wikimedia.org/T116445#1749845 (Ejegg) Looking in the logs, the problem was an insert into civicrm_address with a Swedish address that contained ä characters in the street and city. However... [23:41:02] ejegg: You still around? [23:41:09] yep, what's up K4-713 ? [23:41:25] And... do you remember why we have two places that country comes from in the data? [23:41:56] you mean the querystring and the geoip lookup? [23:41:56] I think contribution tracking and the donor's reported country don't always match? [23:42:03] o rly? [23:42:11] I'm trying to do some SQL-fu. [23:42:28] i thought we only used geoip when we didn't have querystring [23:42:38] :/ [23:43:50] Yeah... the way the data is landing now, there's a contribution tracking country, and a civicm country ISO code. [23:44:01] ...tied to the donor's reported location, I think. [23:44:11] I just don't know why those two things would ever be different. [23:44:51] NBD, though. I'm just screwing around with KPIs. [23:44:54] Huh, only geoip use I can see is in DonationData, and it's bypassed if country is already a valid ISO code [23:45:06] does that happen after we save contribution tracking, i wonder? [23:45:23] M.... [23:45:26] ...maybe... [23:45:27] OH. [23:45:31] Paypal. [23:45:39] oh? [23:45:44] They send donor data in the IPN. [23:45:58] Then we remarry to the contribution tracking ID, and people may be travelling. [23:46:00] Ahh, totally divorced from our contribution tracking [23:46:09] ...thank goodness. [23:46:20] hehe, data marriage metaphors [23:46:20] I thought I might be cracking up there for a second. [23:47:40] Okay, for the sake of "count of countries that donated this week" I'm going with contribution tracking data, then. [23:48:17] where the person donated from, sounds good [23:48:21] Yep. [23:52:18] well, i'm gonna hang up my spurs for the weekend. see you later, all! [23:52:37] ejegg: ok, see you too :)