[00:10:29] (PS3) Rosalieper: "uses" key added in localisation files [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/248612 (https://phabricator.wikimedia.org/T41266) [02:28:07] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Orphaned action is emitting warnings during Civi upgrade - https://phabricator.wikimedia.org/T116522#1752242 (Eileenmcnaughton) Probably not specifically related to the upgrade but r... [02:29:54] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import fails with database error - https://phabricator.wikimedia.org/T116445#1752243 (Eileenmcnaughton) In terms of priority - is this something to dig more on while the upgrade is running - ie. not a blocker but needing fairly immediate action? [02:31:51] Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Create new civicrm repo - https://phabricator.wikimedia.org/T114831#1752245 (Eileenmcnaughton) Yes - I agree - I was imagining we would go live with the code we hav... [02:37:22] (CR) Eileen: CRM-17435 Add option to generate drupal_7 directory version (3 comments) [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248274 (owner: Eileen) [02:41:23] (CR) Eileen: Add script for compiling deployment repo (3 comments) [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248276 (https://phabricator.wikimedia.org/T1152925) (owner: Eileen) [02:44:21] (CR) Eileen: "I originally looked at a separate repo to have the submodule structure - ie. the repo would hold the 3 repo dirs. However, the packages di" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248275 (https://phabricator.wikimedia.org/T115925) (owner: Eileen) [05:21:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import fails with database error - https://phabricator.wikimedia.org/T116445#1752305 (awight) Agreed! We might also find that it's only an issue on the staging server... [05:22:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import fails with database error - https://phabricator.wikimedia.org/T116445#1752307 (awight) [05:22:57] Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Install Civi 4.6 to production - https://phabricator.wikimedia.org/T99844#1752306 (awight) [05:23:29] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import fails with database error - https://phabricator.wikimedia.org/T116445#1749707 (awight) [05:23:31] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [Epic] Followup tasks after Civi 4.6 upgrade - https://phabricator.wikimedia.org/T116416#1752308 (awight) [05:24:07] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Orphaned action is emitting warnings during Civi upgrade - https://phabricator.wikimedia.org/T116522#1752311 (awight) [05:24:09] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: [epic] Install 4.6 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1752310 (awight) [05:24:15] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Orphaned action is emitting warnings during Civi upgrade - https://phabricator.wikimedia.org/T116522#1751449 (awight) [05:24:18] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [Epic] Followup tasks after Civi 4.6 upgrade - https://phabricator.wikimedia.org/T116416#1749043 (awight) [05:25:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, WorkType-NewFunctionality: Create an import method for matching gifts and payroll deductions - https://phabricator.wikimedia.org/T115044#1752315 (awight) [05:25:40] Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Install Civi 4.6 to production - https://phabricator.wikimedia.org/T99844#1752314 (awight) [05:25:41] Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Create new civicrm repo - https://phabricator.wikimedia.org/T114831#1752316 (awight) [05:25:51] Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Create new civicrm repo - https://phabricator.wikimedia.org/T114831#1707340 (awight) [05:25:52] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [Epic] Followup tasks after Civi 4.6 upgrade - https://phabricator.wikimedia.org/T116416#1752317 (awight) [05:27:18] (CR) Awight: [C: 2] "Great first pass!" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248274 (owner: Eileen) [05:37:11] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, WorkType-NewFunctionality: Create an import method for matching gifts and payroll deductions - https://phabricator.wikimedia.org/T115044#1752334 (awight) [05:37:41] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Trilogy Import - Gift Data section didn’t populate - https://phabricator.wikimedia.org/T116446#1752337 (awight) [05:37:42] Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Install Civi 4.6 to production - https://phabricator.wikimedia.org/T99844#1300198 (awight) [05:38:06] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi 4.6 date range fields are unusably annoying - https://phabricator.wikimedia.org/T116420#1752339 (awight) [05:38:08] Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Install Civi 4.6 to production - https://phabricator.wikimedia.org/T99844#1300198 (awight) [05:38:14] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Trilogy Import - Gift Data section didn’t populate - https://phabricator.wikimedia.org/T116446#1749715 (awight) [05:38:15] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi 4.6 date range fields are unusably annoying - https://phabricator.wikimedia.org/T116420#1749123 (awight) [05:38:17] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [Epic] Followup tasks after Civi 4.6 upgrade - https://phabricator.wikimedia.org/T116416#1752340 (awight) [05:39:03] Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Corrupt dashboard items are throwing warnings during Civi upgrade - https://phabricator.wikimedia.org/T116521#1752344 (awight) [05:39:04] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: [epic] Install 4.6 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1752343 (awight) [05:42:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi 4.6 date range fields are unusably annoying - https://phabricator.wikimedia.org/T116420#1752346 (awight) A potential fix, out to colemanw and @eileenmcnaughton for review: https://gist.github.com/adamwight/9d54c9b0d37ac4b025e7 [05:57:34] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Corrupt dashboard items are throwing warnings during Civi upgrade - https://phabricator.wikimedia.org/T116521#1752351 (awight) [05:57:41] Fundraising Sprint UB40, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Orphaned action is emitting warnings during Civi upgrade - https://phabricator.wikimedia.org/T116522#1752353 (awight) [12:00:39] (CR) Siebrand: [C: -1] "i18n/L10n reviewed." (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/248612 (https://phabricator.wikimedia.org/T41266) (owner: Rosalieper) [12:39:19] (PS4) Rosalieper: "uses" key added in localisation files [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/248612 (https://phabricator.wikimedia.org/T41266) [13:58:19] Fundraising-Backlog: Recent iframe errors from up-to-date browsers - https://phabricator.wikimedia.org/T112181#1752965 (MBeat33) This donor was using Firefox 41.0.1 on Windows 7 64-bit. ZD161933 {F2817749} [15:56:36] (CR) Rosalieper: "Please someone needs to merge https://gerrit.wikimedia.org/r/#/c/247990/ before this can be merged because i did a squash commit." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/248612 (https://phabricator.wikimedia.org/T41266) (owner: Rosalieper) [16:18:08] (CR) Ejegg: "Just a clarification - the contribution_id column in the contribution_tracking table is a foreign key to the id column of civicrm's civicr" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/246425 (https://phabricator.wikimedia.org/T112022) (owner: AndyRussG) [16:39:35] hey awight - what's the story with the civi upgrade? [16:39:44] want to make sure we're not going to interrupt MG and whatnot [16:39:49] i didn't realzie we'd missed them on the email there [16:47:54] Jeff_Green: same question? ^ [16:48:06] oh awight's not online. that explains that ;) [16:51:04] (CR) Rosalieper: [C: 1] "Has been tested and it look fine." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247990 (https://phabricator.wikimedia.org/T72462) (owner: Rosalieper) [16:51:08] atgomez: i'm gonna have to defer to awight on the specifics, all I know is we are still scheduled to start at 1PM pacific, with the possibility of other people blocking [16:51:51] Fundraising Sprint Vengaboys: Banner History: further minify log sent and always include campaign name - https://phabricator.wikimedia.org/T116613#1753846 (AndyRussG) NEW [16:52:08] Fundraising Sprint Vengaboys: Banner History: further minify log sent and always include campaign name - https://phabricator.wikimedia.org/T116613#1753856 (AndyRussG) a:AndyRussG [16:53:38] Hi ejegg cwd! Can anyone help me run DI tests? I'm trying to debug tests here https://gerrit.wikimedia.org/r/#/c/244109/ [16:53:41] thx in advance! [16:55:20] ok. Jeff_Green it looks like cvirtue and awight are meeting in an hourish to work things out. we may need to pull the brake if they're not comfortabel. [16:55:44] Hi AndyRussG [16:55:48] :) [16:55:49] very odd.. [16:55:50] atgomez: ok no prob [16:55:52] also… i forgot my laptop charger so i'll be on and off IRC using another computer/conserving battery :P [16:56:30] my DI tests are still not running [16:56:48] ejegg: there you are, [16:56:50] ejegg: hey [16:58:22] oh i finally got em [16:58:31] r054l13: I'll mention it again [16:58:50] ejegg: someone was to look at it, so did he/she/ [16:58:52] ? [16:59:29] AndyRussG: do you just need to run the tests locally to diagnose the failures? [16:59:50] r054l13: sorry for the delay, I'm looking at it now! [16:59:58] I guess not - like I said, the fundraising team is trying to get a lot of things wrapped up before the crazy month of December. I even have some patches waiting for review! [17:00:06] AndyRussG: ok, no problem :) [17:00:21] ejegg: hahahaha..... [17:00:44] ejegg: wow, it seems the December month is really crazy and you all are very busy [17:00:51] (I think you're talking about this one? https://gerrit.wikimedia.org/r/#/c/247990/ ? I see you have another patch in review too!) [17:01:09] AndyRussG: yes, both of them [17:01:28] r054l13: K... even if we're busy please don't hesitate to ask us for review or any other questions you have any time :) [17:01:39] AndyRussG: ok [17:01:40] r054l13: I think that second patch should not have been squashed [17:01:53] ejegg: yes, but i had no choice [17:02:08] this git review at times is really giving me some headache :) [17:02:51] r054l13: yeah, git-review does complain about submitting one on top of an unmerged commit, but it's a perfectly legitimate thing to do, if the second commit depends on the first [17:03:01] just type yes and it will go ahead. [17:03:10] ejegg: thanks. [17:03:20] ejegg: so i should not squash again next time :) [17:03:57] how can grrrit-wm go offline? [17:03:59] if the second commit is unrelated, it's better to create a separate local branch for each commit, each starting independently from master [17:04:00] this is not good [17:04:17] ejegg: ok, i get it [17:04:37] r054l13: the grrrit-wm you see in here is just a chatbot programmed to announce changes - when it goes offline, the real gerrit site is still up. [17:05:10] ejegg: ok, but what if some changes are not announced, is that not ... [17:05:29] just curious though [17:05:37] AndyRussG: how far with the patch review? [17:05:41] AndyRussG: are they ok? [17:05:53] r054l13: Many of us subscribe to projects in the gerrit web interface, so we are automatically added as reviewers for anything submitted to a certain project [17:06:03] then they show up on our gerrit homepage [17:06:49] ejegg: wow, that is really tasks automation :) [17:06:54] i love computing :) [17:09:58] r054l13: I'm just looking at the close button patch now. Looks very nice! I have just one concern: that it may load the close button image on every page view for all users, even when it's not used (which is most of the time) [17:10:00] AndyRussG / cwd: here's a fix for something that was breaking a lot of my tests locally. cwd, I thought this was an xml declaration problem, just 'cause the newline in the string messed up the comparison display in phpunit output. https://gerrit.wikimedia.org/r/248384 [17:10:35] AndyRussG: yeah, that was my concern too. However, it'll still be part of the cached css [17:11:02] though of course, that's likely to change on each deploy, given how much goes into it [17:11:21] AndyRussG: i and ejegg worked on that :) [17:11:38] AndyRussG: embedding was suggested in the task [17:11:48] ejegg: r054l13: I'll add a comment on the patch and ask for further review from the Performance folks. (r054l13: that's the team at the WMF that works to make the site as fast as possible.) [17:12:24] r054l13: please don't be discouraged if there are further comments!!! :) It's not easy to get all the details (though often fun!!) [17:12:48] well, AndyRussG no problem [17:12:59] ejegg: ah in the Phabricator task? K... [17:13:00] check the i18n patch too and let me see what comes up :) [17:13:29] r054l13: The i18n patch needs to be un-squashed and resubmitted [17:13:58] ejegg: ok, let me do that now and submit for review :) [17:14:16] Ah hmmm I see the Phabricator task mentions an image that's already in core... [17:14:35] AndyRussG: I think it was in a skin [17:15:06] Ahh heh right the task then says, "Let's not do that"... [17:15:11] * AndyRussG reads the _whole_ task description [17:15:19] ah ha, subtle [17:15:32] ejegg: how do i unsquash it now? [17:15:34] although oojs-ui does have some close buttons in it [17:15:41] remember it is two commits in one, can i undo it? [17:15:48] r054l13: I think you can find the old patch by running 'git reflog' [17:16:13] then note the id on the line before you squashed. [17:16:43] I'm looking at how the patch loads stuff in the Network tab, but I don't see quite where the image would come in... [17:17:02] yes i notted [17:17:03] when you have the id, you can create a new branch off master with 'git checkout -b i18nfix master' [17:17:28] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Trilogy Import - Gift Data section didn’t populate - https://phabricator.wikimedia.org/T116446#1753998 (atgo) @leannes @caitvirtue is this a blocker for the event? If so, please escalate to "unbreak now!" priority. [17:17:41] and then run 'git cherry-pick ' with the id from the pre-squash line in reflog [17:17:43] done [17:17:49] ok [17:18:17] nice, now you should have an independent commit you can push for review without git-review complaining [17:18:24] waiit [17:18:37] (PS2) Cdentinger: Build expected XML with same merchant ID as actual [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248384 (owner: Ejegg) [17:18:51] (CR) Cdentinger: [C: 2] Build expected XML with same merchant ID as actual [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248384 (owner: Ejegg) [17:19:36] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Trilogy Import - Gift Data section didn’t populate - https://phabricator.wikimedia.org/T116446#1754012 (CaitVirtue) p:High>Unbreak! [17:20:19] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Trilogy Import - Gift Data section didn’t populate - https://phabricator.wikimedia.org/T116446#1749715 (CaitVirtue) @atgo Set priority to unbreak now. I'm not even sure what this had to do with the upgrade. As I understan... [17:22:56] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Trilogy Import - Gift Data section didn’t populate - https://phabricator.wikimedia.org/T116446#1754042 (atgo) @caitvirtue this isn't related to the upgrade, this is the Trilogy Import. Is this the issue you need to be dealt... [17:23:32] Fundraising Sprint Vengaboys, Fundraising-Backlog: Banner History: further minify log sent and always include campaign name - https://phabricator.wikimedia.org/T116613#1754045 (DStrine) [17:23:41] Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: DonationInterface is attempting to I_OWP twice in a row without renewing the order_id - https://phabricator.wikimedia.org/T116089#1754046 (DStrine) [17:24:44] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1754051 (CaitVirtue) p:High>Unbreak! [17:25:14] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Trilogy Import - Gift Data section didn’t populate - https://phabricator.wikimedia.org/T116446#1754052 (CaitVirtue) Yikes, I didn't realize there were two issues here. Across the board, getting Trilogy data into Civi needs... [17:25:47] (CR) AndyRussG: "Thanks @Rosalieper!! :)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247990 (https://phabricator.wikimedia.org/T72462) (owner: Rosalieper) [17:26:51] Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Trilogy Import - Gift Data section didn’t populate - https://phabricator.wikimedia.org/T116446#1754053 (atgo) [17:27:35] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1754063 (atgo) @xenoryet just wanted to call out that this is critical for the MG team and their upcoming event... [17:28:00] (PS5) Rosalieper: "uses" key added in localisation files [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/248612 (https://phabricator.wikimedia.org/T41266) [17:28:01] ejegg: submitted a patch :) [17:28:12] ejegg: let me cherry pick on the web Interface [17:28:14] to master [17:29:49] (PS2) Cdentinger: Remebmer appeal, make RapidHTML use configurable default [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/246894 (https://phabricator.wikimedia.org/T114127) (owner: Ejegg) [17:30:24] Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Trilogy Import - Gift Data section didn’t populate - https://phabricator.wikimedia.org/T116446#1754088 (XenoRyet) @atgo @CaitVirtue I'm working on this one as we s... [17:31:27] ejegg: can you cherry pick for me to master and then review? [17:32:56] r054l13: Did you try creating a separate branch locally? 'git checkout -b i18nfix origin/master' should do it, in case your local master already has unmerged stuff on it [17:32:57] (Merged) jenkins-bot: Build expected XML with same merchant ID as actual [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248384 (owner: Ejegg) [17:34:06] ejegg: cwd: awight: This is what happens when I try tests DI locally... [17:34:06] /vagrant/mediawiki-fr/tests/phpunit$ php phpunit.php --group DonationInterface [17:34:06] [Mon Oct 26 17:33:28 2015] [hphp] [6083:7f4190346d00:0:000001] [89ede9:89f158:89fa54:89fd73:8b380e:8b642f:a3c681:7ce830:7f418833fec5:7ca349] [17:34:06] Fatal error: Function already defined: wfEntryPointCheck in /vagrant/mediawiki/maintenance/Maintenance.php on line 25 [17:34:20] ejegg: i did it but it seems i missed something [17:34:22] AmI doingit right? [17:34:41] but i just tried another option [17:34:42] i did a reset to the point before the squash or rebase [17:34:53] then had the patch back :) [17:36:13] r054l13: ok, that step is good. Now to make the patch not depend on the close button fix, you need to start a new branch off of origin/master (with that last command), and cherry-pick your commit over to that branch [17:38:02] ejegg: ohhh, i already submitted the patch like 3 mins ago :) [17:39:17] AndyRussG: I would have expected that to work... spinning up my own vagrant to compare. [17:39:45] Trying locally as well [17:40:45] awight: when testing config changes in vagrant, is there an easy way to re-apply just one module? [17:41:40] thx!! [17:42:05] (PS6) Rosalieper: "uses" key added in localisation files [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/248612 (https://phabricator.wikimedia.org/T41266) [17:42:23] AndyRussG, ejegg, the i18n patch set is up [17:42:29] check it out and merge if possible :) [17:42:36] ok, it's on my to-do list! [17:42:38] ejegg: not that I know of--but reprovisioning should only take 10 seconds or so [17:42:48] you use "vagrant provision"? [17:43:03] awight: ah, yeah, but I didn't think it picked up the changed file [17:43:22] might have been looking in the wrong place though, just realized the crm dir has moved [17:43:33] Ooh funky [17:43:37] yeah I think that's your issue [17:43:42] guest:/srv is no longer a thing [17:43:49] ejegg: ok [17:43:50] right on [17:44:09] but--changed files in /srv wouldn't have done anything anyway. You're talking about .pp changes, right? [17:44:35] awight: yep, adding a bunch more variable-get defaults [17:44:47] to crm's init.pp [17:54:03] AndyRussG: huh that is weird indeed -- i'm not running them on vagrant [17:54:11] (sorry was in 1on1 w k4) [17:54:50] cwd: np!! Hmm so at least the "php phpunit.php --group DonationInterface" but is correct? [17:57:26] AndyRussG: you are up for the i18n patch :) [17:57:59] r054l13: probably--I don't know for sure when I'll get to it... hopefully later today!! :) [17:58:51] AndyRussG: ok :) [17:59:05] (PS1) Ejegg: Reset adapter account config in test setup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248924 [17:59:06] r054l13: thanks for undersatnding our craziness :) [17:59:25] AndyRussG: actually there is this dir /srv/core/tests [17:59:33] (core is mw1_25) [17:59:44] with some shims because...i don't really know why [17:59:47] but what i run is: [17:59:54] php /srv/core/tests/phpunit/phpunit.php --configuration /srv/core/tests/phpunit/suite.xml --group DonationInterface [18:00:00] (poached this from the Makefile) [18:00:09] cwd: gah! [18:00:19] AndyRussG: hahaha...., np!!! [18:00:57] cwd: hmm lemme try the config bit [18:01:51] awight: am i doing it wrong? [18:02:36] cwd: sounds like you'd get the same result just saying what I said, from your core/tests/phpunit directory? [18:02:48] Though indeed that lets you run tests without cd'ing around [18:03:05] getting the same result w/ /vagrant/mediawiki-fr/tests/phpunit$ php phpunit.php --group DonationInterface --configuration suite.xml [18:03:11] I mean, same as above [18:04:54] gah, for some reason my mediawiki-fr is still on rel1_23, even after destroy and re-up. Guess it's cause I didn't nuke the whole vagrant/mediawiki dir? [18:06:11] AndyRussG: heh yeah you're right [18:06:47] ejegg: didn't you say you used the Makefile to run the tests? [18:07:12] cwd I used to, but lately php phpunit.php --group=DonationInterface has been working for me [18:07:16] on my actual box [18:07:34] just trying to get it to work in vagrant now [18:07:35] cwd: Oh, I'm just sad that all of us have needed different workarounds [18:07:40] I tried that too, BTW, that ejegg-provided tip helped me get CN tests going again, but no dice here... [18:07:44] /vagrant/mediawiki-fr/tests/phpunit$ make phpunit FLAGS="--group DonationInterface" [18:07:44] php phpunit.php --configuration /vagrant/mediawiki-fr/tests/phpunit/suite.xml --group DonationInterface [18:07:44] [Mon Oct 26 18:07:00 2015] [hphp] [18343:2ba595a43080:0:000001] [89ede9:89f158:89fa54:89fd73:8b380e:8b642f:a3c681:7ce830:2ba59d6a9ec5:7ca349] [18:07:45] Fatal error: unknown class ApiFormatWddx in /vagrant/mediawiki-fr/tests/phpunit/includes/api/format/ApiFormatWddxTest.php on line 76 [18:07:45] make: *** [phpunit] Error 255 [18:08:15] heh, I'm getting a different missing file: Fatal error: File not found: /vagrant/mediawiki/includes/profiler/ProfilerFunctions.php in /vagrant/mediawiki-fr/maintenance/doMaintenance.php on line 60 [18:08:48] awight: well i'm all about writing some internal utils that will formalize a bunch of this stuff [18:08:52] incidentally [18:09:20] You could get some buy-in to slash and burn the phpunit.php script... [18:09:23] it's awful [18:09:35] sounds fun [18:10:01] Fundraising Sprint Vengaboys, Fundraising-Backlog: Banner History: further minify log sent and always include campaign name - https://phabricator.wikimedia.org/T116613#1754269 (AndyRussG) [18:10:19] (PS1) AndyRussG: BannerHistoryLogger: futher minify EL data and always include campaign [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/248925 (https://phabricator.wikimedia.org/T116613) [18:11:09] AndyRussG: well, I can reproduce your error [18:11:30] awight: weee! Which, the Jenkins one or the local vagrant one? [18:11:56] the local vagrant phpunit failure [18:12:00] wfEntryPointCheck [18:12:07] awight: cool-oh! [18:12:20] awight: can u also un-reproduce it? [18:12:29] You ran composer update in mediawiki-fr yet? [18:12:35] yep [18:12:39] k [18:12:40] lemme try again just to be very sure [18:13:06] awight: ejegg: cwd: I had been trying to dive into Jenkins to see how Jenkins runs the tests, but I ran away from that one before I found it [18:14:06] XenoRyet: ^ hi! Sorry I didn't see you were here now... Just trying to get DonationInterface tests running, in case ur interested... ;p [18:14:09] I'm seeing that PHPVersionCheck.php is always require_once'd, but maybe there's some symlink magic that breaks the comparison [18:14:54] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [epic] Upgrade Civi to 4.6 & integrate new reporting - https://phabricator.wikimedia.org/T77910#1754287 (awight) [18:15:57] Mebbe the place to ask is in fact #wikimedia-releng, tho [18:16:06] hmm, 'reboot' in vagrant is not helpful - seems to come back up without things mounted [18:16:13] good call. Mail the dog fud back to sender [18:16:30] ejegg: I think that should be "vagrant reload" in the host env [18:16:44] awight: word [18:22:46] AndyRussG: Ooh, I just noticed MW_INSTALL_PATH is pointing to /vagrant/mediawiki, not /vagrant/mediawiki-fr [18:23:17] ejegg: hmmm.... that's in some config somewhere, I guess [18:24:11] Heh also I had noticed /vagrant/mediawiki-fr/extensions/DonationInterface/tests/unittest.sh during my travels, dunno if it's a relic? [18:24:26] Or rather something else? [18:24:36] oh huh, lemme take a look [18:24:40] * AndyRussG cowers behind his own ignorance [18:27:01] export MW_INSTALL_PATH=/vagrant/mediawiki-fr/ && php phpunit.php --group DonationInterface [18:27:20] produces no errors, runs no tests tho [18:27:55] yeah, same here! [18:27:57] hmm [18:28:18] oh hey, i didn't have payments role enabled! That's why I was stuck on 1_23 I guess [18:28:51] had manually updated, but going to enable role to get all the localsettings and such [18:32:58] enabled, provisioned, and still no tests executed... [18:33:49] grr, unknown database 'wiki' [18:48:36] ejegg: fwiw, puppet doesn't do any git updates once you have a mediawiki-fr dir, you'll always have to update manually [18:50:06] awight: ah, thanks! [18:53:54] AndyRussG: ejegg yeah I just debugged that we're including PHPVersionCheck.php twice, cos one is in mediawiki/ and the other in mediawiki-fr/ [18:54:27] awight: MW_INSTALL_PATH off? [18:54:50] not setting it yet [18:55:09] hmm, it was already set when I sshed in [18:55:18] oh, lemme check! [18:55:42] I get the same behavior as you when I set the var to mediawiki-fr, lots of running, no tests [18:56:01] ejegg: you're right, it's already set in the vagrant user's shell [18:56:21] yah, but like you say, no find tests [18:57:04] I've had this problem so many times... [18:58:30] awight: ejegg: cwd|afk: what K4-713 just suggested is running tests locally in a MW install with only DI and the most minimal possible LocalSettings [18:59:11] :) [18:59:42] AndyRussG: will mushing the EL data into a single field make it tougher to extract and analyze? Guessing you discussed this with ellery and he's ok splitting on | [19:01:40] AndyRussG: I don't think it's worth the effort [19:01:55] i.e. I expect you'll have the same problem [19:02:52] fwiw, https://www.mediawiki.org/wiki/MediaWiki-Vagrant#Running_and_debugging_unit_tests [19:03:33] ahh, www-data, huh? [19:03:38] weak. [19:03:46] And it totally defaults to mediawiki/ [19:03:50] yerp [19:05:14] no dice: sudo -u www-data MW_INSTALL_PATH=/vagrant/mediawiki-fr php5 tests/phpunit/phpunit.php --group DonationInterface [19:05:55] works but no tests? [19:06:03] yep [19:06:25] I'm sad about having hit this issue a hundred times now, and still can't explain how I solve it. I think MW_INSTALL_PATH is my usual fu [19:06:38] and we've all switched our extensions/DonationInterface back to master, right? [19:06:51] good call. [19:07:02] tests are there, yes [19:07:15] guh [19:08:00] AndyRussG: hey, still not on it? [19:08:17] ejegg: hey, you too, is your todo list not on my task? [19:08:18] i'm just tearing it all out and rebuilding - had enough old cruft in there that I couldn't even browse the payments-wiki on vagrant [19:08:39] r054l13: it's on the list, just trying to fix our unit tests first! [19:08:59] ohhh, ejegg that has more priority, fix it first please :) [19:09:23] the Unit test is very important :) [19:09:37] it has to be fixed first :) [19:16:29] Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Trilogy Import - Gift Data section didn’t populate - https://phabricator.wikimedia.org/T116446#1754580 (CaitVirtue) @XenoRyet OK, cool. Thanks! [19:16:45] ejegg: Of course, I destroyed my vagrant instance since the last time I ran tests successfully. [19:17:00] ah well... [19:17:23] fresh instance just finished provision, let's see where I get [19:17:59] oh man, no more unicorn in the MOTD? [19:20:43] ejegg: awight: Yeah Ellery did say specifically that he's fine w/ EL data mushing and splitting [19:20:48] ok, cool! [19:21:46] ../settings.d/wikis/paymentswiki/LocalSettings.php is never included... [19:21:53] oh! [19:22:06] even with a (broken): MW_INSTALL_PATH=`pwd` php tests/phpunit/phpunit.php --wiki paymentswiki --group DonationInterface [19:24:34] awight: hmmm [19:25:00] I got unicorn! [19:25:16] yeah, I got unicorn after I reloaded. [19:25:20] woohoo! [19:25:38] My oldest daughter had a good laugh at poor unicorn yesterday [19:28:15] !! [19:33:56] Crickets on -releng [19:52:02] Well here's what I get dunning DI tests on my local install: [19:52:04] $ php phpunit.php --group DonationInterface [19:52:04] PHPUnit already present [19:52:04] PHPUnit 3.7.37 by Sebastian Bergmann. [19:52:04] Configuration read from /home/lap/Development/mw1/tests/phpunit/suite.xml [19:52:04] E.EEEEEEEEE.EEEEEEEEEEEEEEEEEEEEEEEE.EEE.EEEEEE.E.E.E..EEEE 59 / 10851 ( 0%) [19:52:06] EEEEEEE.EEEEEEEEEE.EEEEEEEEEEEEEEEEEEEEEEE.EE.EEEEEEEEEEE.E 118 / 10851 ( 1%) [19:52:08] EEEEEEEEEE.E.E.EEEE.EE.E.EEEEEEEEEEEE.EEEEEEEEEEEEEEEE.EEEE 177 / 10851 ( 1%) [19:52:10] EE.......................................................EE 236 / 10851 ( 2%) [19:52:13] EEEEEEEEEE..............E.EEEEEEEEEEEEEEEEE.lap@laptop:~/Development/mw1/tests/phpunit$ [19:52:19] ...and no further output 8p [19:52:40] AndyRussG: I think you need to look at your path [19:52:45] civicrm adds an old phpunit [19:53:08] & it's probably in your path - so you need to make sure the right one is earlier in your path [19:54:14] eileen: hmmm thanks, I should have mentioned that I'm running from tests/phpunit/ in my local Mediawiki core install [19:54:52] There's a phpunit.php file right in there, though maybe you're thinking of something else? [19:55:09] Also, this is on my local (real) machine, and I only have civi installed on my virtual machine [19:55:22] Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Trilogy Import - Gift Data section didn’t populate - https://phabricator.wikimedia.org/T116446#1754739 (atgo) Thanks @xenoryet [19:57:56] Andy RussG - It's just the phpunit version number 'looks low' [19:59:29] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Patch-For-Review: Use contentlanguage for CentralNotice banners - https://phabricator.wikimedia.org/T53475#1754761 (Whatamidoing-WMF) @Nemo_bis, could you clarify your comment? Imagine that I go to the Italian Wikipedia. Imagine that my in... [20:01:00] eileen: ah hmm OK interesting [20:01:04] thx! [20:08:09] (CR) Cdentinger: [C: 2] "one mostly meaningless comment" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/246894 (https://phabricator.wikimedia.org/T114127) (owner: Ejegg) [20:08:42] (Merged) jenkins-bot: Remebmer appeal, make RapidHTML use configurable default [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/246894 (https://phabricator.wikimedia.org/T114127) (owner: Ejegg) [20:13:34] Fundraising Sprint Vengaboys, Fundraising-Backlog: CiviCRM upgrade: Simple Lookups: timeout attempting to look up matching gifts given in August - https://phabricator.wikimedia.org/T116313#1754851 (Eileenmcnaughton) I believe this was a symptom of the 'like bug' we fixed earlier. Should we close since Lea... [20:14:23] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Record actual amount charged regardless of what's in session - https://phabricator.wikimedia.org/T115171#1754859 (DStrine) [20:18:26] Krinkle: hey, did you see AndyRussG comment? [20:25:48] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Bubble up CiviCRM database error message - https://phabricator.wikimedia.org/T116493#1754897 (Eileenmcnaughton) Note that if debugging is turned on (ie the civicrm setting) the error message & backtrace are output to the screen. This is usually consider... [20:33:05] this is what i was picturing myself as on that call: https://www.youtube.com/watch?v=_CjiK288Rc0 [20:37:07] awight|eat: so should we put T99836 &7 to 'done' since any follow issues are now their own tickets? [20:38:18] atgomez: Were https://phabricator.wikimedia.org/T116446 and https://phabricator.wikimedia.org/T114155#1754063 the two Trilogy issues you were talking about, or is there another one? [20:39:39] yes XenoRyet i believe so [20:39:41] thank you!! [20:40:33] Cool, yea, those are the same thing. One's the original ticket that never quite got closed because of the bug, the other is the bug. When I get a fix we'll be able to close both. [20:43:51] awight: You were saying something about underscores related to this Trilogy bug? [20:44:08] eileen: Agreed! & 8 as well, I think. We can make followon tasks subtasks of one of these, maybe. [20:44:40] XenoRyet: yah, there's this atrocious thing to be aware of, that the Civi api addresses custom fields by ID, like "custom_23" [20:44:57] Those IDs might be different on every installation, so we have some functions to do the aliasing at runtime. [20:46:28] Ok, that's interesting. [20:47:21] awight: T77910 might be the 'master' to keep open? [20:48:01] I'd be surprised I ever had it working on local if that was the problem. Still probably worth a look though. [20:49:01] awight: so, what is your pick on most important to do before upgrade now? [20:51:50] eileen: I'm resigned about doing anything strictly before the upgrade [20:52:19] ? [20:52:32] but of the outstanding stuff, I think my priorities are like # date ranges # custom hook for Engage (I haven't documented this anywhere yet), # make imports work [20:53:03] eileen: oh, just meaning none of it actually blocks the upgrade, but they are bugs we don't want anyone to actually experience [20:53:06] re imports - should I email Leanne & get a copy of the csv she tried to use? Would she still have it? [20:53:10] So we can fix during/right after upgrade as you said. [20:53:29] eileen: sure! fyi, don't suggest emailing donor data though [20:53:38] Do you have fileserver access yet? [20:53:50] yeah - so in the next couple of days I can tackle some - or can look at the missing hook tests [20:53:58] I do have fileserver - not prod civi tho [20:54:49] (hook tests = T115426) [20:55:19] & I think we can close this https://phabricator.wikimedia.org/T116313 [20:55:35] eileen: Oh, I can give you prod civi! [20:56:16] cool [20:57:16] eileen: in the mail... [20:58:50] got it! [21:02:53] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: [epic] Install 4.6 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1755116 (awight) [21:02:54] Fundraising Sprint Vengaboys, Fundraising-Backlog: CiviCRM upgrade: Simple Lookups: timeout attempting to look up matching gifts given in August - https://phabricator.wikimedia.org/T116313#1755113 (awight) Open>Resolved a:awight Great! [21:08:06] eileen: so um just to be explicit, it's fine to exchange donor data files on the fileserver. [21:09:09] ok - cool - I see you commented on the google doc [21:09:31] but I probably need to follow up with an email [21:17:23] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import fails with database error - https://phabricator.wikimedia.org/T116445#1755156 (Eileenmcnaughton) [21:17:26] Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Test Engage role-specific save hooks - https://phabricator.wikimedia.org/T116660#1755158 (awight) NEW [21:18:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import fails with database error - https://phabricator.wikimedia.org/T116445#1749707 (Eileenmcnaughton) Leanne - are you able to put a copy of the csv you were trying to import on the file server & give me the location? It seems to have had Swe... [21:19:07] eileen: Jeff_Green: I'm planning on leaving the drupal db untouched during the upgrade. This means, live payments will be landing in drupal.contribution_tracking [21:19:20] We don't want to roll back the drupal database for this reason (if campaigns are left up). [21:19:58] eileen: Do you think that's safe, that the civi schema migration avoids touching anything in the drupal db / nothing will need to be rolled back if we abort? [21:20:27] awight: correct - the drupal DB should be untouched [21:21:00] the user table is the only strong linkage & that's not going to be altered [21:21:08] Not that we should think this way--but it will pretty much pay for our time to do the upgrade, if we can leave campaigns up :) [21:22:56] and foo from the contribution_tracking table only makes it into the civicrm db when queues are consumed, is that right? [21:23:19] yes [21:23:23] great [21:23:54] so from my perspective I think the thing to do is stop replication from db1025->db1008 as soon as we shut down civicrm [21:23:56] hmm, system table may be worth rewinding [21:24:05] just for civi module versions [21:24:37] ejegg: I don't think that'll be touched, until we drush upgradedb [21:24:40] err updatedb [21:24:47] awight: ah, ok [21:25:00] which is a good point! I hadn't put that as an upgrade step [21:25:18] should be [21:25:28] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/248996 [21:25:48] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/248996 (owner: Ejegg) [21:26:07] system table is in civicrm or drupal? [21:26:07] Jeff_Green: ejegg identified one bit that will change in the drupal db, but it's something we can roll back by updating a single column in a signel row. [21:26:11] drupal.system [21:27:08] eileen: I don't see the updatedb step in http://wiki.civicrm.org/confluence/display/CRMDOC/Upgrading+CiviCRM+for+Drupal+7 [21:27:14] How does that usually work? [21:27:29] does the upgrader run that for you? [21:27:29] awight ok. [21:27:35] I don't think I had to run it locally [21:27:57] It's usually only if the drupal module has a versioned schema. [21:28:46] ejegg: okay, the module version stays the same, 7400 [21:29:01] ah, no change at all then! [21:29:24] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/248997 [21:30:02] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/248997 (owner: Ejegg) [21:32:35] awight: I don't think the drupal upgrade step needs to run - [21:32:59] !log update payments from 71d2d927f4efac1a639aaf7627c765f48d1b129c to 7fd1e880b6a45d79fc305b39f3fee2f324324136 [21:33:02] the module version last changed a couple of years ago when they fiddled with some module weights I think [21:33:03] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:33:47] eileen: cool, I confirmed in the code [21:35:36] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import fails with database error - https://phabricator.wikimedia.org/T116445#1755224 (LeanneS) @Eileenmcnaughton Of course. This is the file path: Fundraising - Tech - Major Gifts - Coinbase. Thanks! [21:39:48] XenoRyet: what encoding do you have for that CSV? [21:40:35] doesn't look like latin-1 or utf-8 [21:41:01] awight: is this the same csv or a diff one you are talking about? [21:41:18] oh sorry, eileen not XenoRyet ! [21:41:20] yeah the Coinbase one [21:41:47] Ok, yea. I was pretty sure mine was utf-8 [21:41:50] cool - I'm just getting to it - I haven't been on the filesever much so remembering the steps :-) [21:41:52] Had me double checking [21:45:03] eileen: I see 0xcc5f for the Swedish character... [21:45:25] looks like we should push back on Coinbase [21:45:59] awight: you are ahead of me - are you saying it is an invalid swedish char? [21:46:16] seems to be a bad character encoding [21:47:01] awight: cool! [21:47:25] I can look at improving error reporting if that would help [21:48:05] Searching for the address, I see that it should be Järfälla [21:48:17] eileen: sure! yeah db error is a bad way to fail here [21:50:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import fails with database error - https://phabricator.wikimedia.org/T116445#1755282 (awight) @LeanneS Coinbase gives us a CSV file, right? Or are you opening an XLS and resaving it before the import? The root issue seems to be a bad file enc... [21:50:56] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Adyen rejects merchant signature - https://phabricator.wikimedia.org/T116667#1755284 (Ejegg) NEW [21:56:34] AndyRussG: Am I imagining things, or were you involved in an Outreachy already? [21:59:24] awight: I was involvedish in one earlier this year, though ragesoss did the vast majority of the work [22:00:21] Ah! marxarelli was hoping to chat with a vet... [22:01:15] Ah hmmm a pseudovet I may be [22:01:30] Desk officer :p [22:01:36] Though he'd do better to grab ragesoss, if he's willing [22:01:40] a vet of comentoring with me, at least! [22:02:23] I wouldn't want to teach him my laxness [22:04:52] AndyRussG: that's where i'm at, comentoring w/ ragesoss! [22:05:15] ragesoss: i guess the meat of my question was basically: when/how do we usually kick things off? [22:05:15] awight: ragesoss: marxarelli: it it's useful for a chat, I'm available basically anytime on my calendar. we could all talk sometime, too, if that makes sense! awight also helped mentor the year before in fact [22:06:02] mmm. not really. I got the free lunch and then bailed due to Fundraising seasonality [22:08:20] well that's a good technique ;p it actually was a huge help [22:08:30] if i've learned one thing about you, awight, it's that you're a staunch objectivist, so that makes sense [22:08:44] O_O [22:08:46] marxarelli: it'd be great to have a chat about the project sometime soon. I think the main kickoff will be whenever the applicaitons are do, as I expect there will be several to evaluate for this project. [22:10:46] Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Test Engage role-specific save hooks - https://phabricator.wikimedia.org/T116660#1755395 (awight) This doesn't cause any errors, but our defaults and rules no longer work correctly. Fixing... [22:11:17] ragesoss: that would be great! [22:11:49] let me know a good time for you. my schedule is pretty flexible. [22:12:06] except for today, when I'm doing a terrible job of taking a day off, and need to go chop some vegetables. [22:12:11] which is to say, bye for now. [22:12:22] ragesoss: will do. see ya [22:14:07] ragesoss: see ya! [22:14:26] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import fails with database error - https://phabricator.wikimedia.org/T116445#1755417 (LeanneS) @awight It comes as an encrypted csv. I then decrypt and resave for import. The address for the Swedish donor shows as garbled. [22:17:04] Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Confirm that ecom script is compatible with Civi 4.6 - https://phabricator.wikimedia.org/T116674#1755422 (awight) NEW [22:18:17] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import fails with database error - https://phabricator.wikimedia.org/T116445#1755449 (awight) @LeanneS Sort of great news! Please tell Coinbase to send us "UTF-8" encoded CSVs, and that should solve our problem. [22:19:25] eileen: ^ we can probably leave the error checking for later, if you wish. Your choice! [22:19:54] We confirmed that the file encoding is bogus, and the immediate fix is to get Coinbase to send us better data :) [22:20:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import fails with database error - https://phabricator.wikimedia.org/T116445#1755459 (awight) p:High>Normal [22:22:29] eileen: Any idea why a custom field import_batch_number no longer appears in the contribution edit form? [22:23:04] (PS1) Eileen: Revert "CRM-17075 further fix to handling entity reference in search form" [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/249007 [22:23:16] eileen: aah nvm, this only applies to specific contribution types [22:24:15] ... but the fields still don't work even with the financial type set to an applicable one. possibly a contrib vs financial type casualty? [22:24:25] awight: cwd: ejegg: XenoRyet: is it indeed a good idea ask about running DI tests on [22:24:29] #wikimedia-releng [22:24:42] sure! I tried earlier with no response... [22:24:45] or is it bad that we don't know how to run our own tests? [22:24:52] Ah K [22:24:58] Any ideas who I should ping? [22:25:05] AndyRussG: Yeah! I think the angle might be to specifically ask about multiwiki and unit tests [22:25:30] awight figured out that it wasn't including LocalSettings from the settings.d/wikis/paymentswiki folder [22:26:05] there's a --wiki argument to maintenance scripts for use with multiwiki, but it didn't seem to help for that phpunit script [22:26:54] ejegg: awight: I'm also trying to just run it locally on a single wiki [22:27:00] ahh [22:27:23] It does run a bunch of tests but reports a zillion errors and exits without saying what they are [22:27:32] aw man... [22:27:48] I tell ya! [22:28:25] AndyRussG: that sounds fun, too. [22:28:47] the fun never ends :) [22:29:06] yeah I run into an issue almost any time I run phpunit.php [22:29:16] instant fun--just add tears! [22:29:23] :-) [22:29:57] Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Adyen rejects merchant signature - https://phabricator.wikimedia.org/T116667#1755506 (Ejegg) a:Ejegg [22:30:21] eileen: so, this looks fine: https://civicrm.frdev.wikimedia.org/civicrm/admin/custom/group?action=update&reset=1&id=9 [22:31:04] (PS1) Eileen: Revert "CRM-17075 further fix to handling entity reference in search form" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/249010 [22:31:14] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Update Adyen adapter to use SHA-265 signature - https://phabricator.wikimedia.org/T116679#1755513 (Ejegg) NEW [22:31:44] (CR) Awight: [C: 2] Revert "CRM-17075 further fix to handling entity reference in search form" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/249010 (owner: Eileen) [22:31:57] (PS1) Ejegg: Stage risk_score before signature [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/249011 (https://phabricator.wikimedia.org/T116667) [22:32:24] (CR) Awight: [C: 2] Stage risk_score before signature [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/249011 (https://phabricator.wikimedia.org/T116667) (owner: Ejegg) [22:32:42] lightning CR! Thanks awight [22:32:54] (Merged) jenkins-bot: Stage risk_score before signature [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/249011 (https://phabricator.wikimedia.org/T116667) (owner: Ejegg) [22:32:56] look, no hands! [22:33:50] dstrine: Just having fun... https://etherpad.wikimedia.org/p/Task_dimensions [22:34:44] gonna deploy that and the appeal fix [22:35:19] eileen: I'm getting lots of these warnings from the edit custom group form: Notice: Undefined index: 13_a_b in CRM_Custom_Form_Group::getFormattedList() (line 549 of /X/crm/civicrm/CRM/Custom/Form/Group.php). [22:35:31] awight: yeah cool If we had a real project management tool (like JIRA) all of this would be easy to track. some of it would even be automatic [22:35:34] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/249014 [22:35:37] Want me to file a bug for this separate issue? [22:35:45] (PS2) Eileen: Revert "CRM-17075 further fix to handling entity reference in search form" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/249010 [22:36:01] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/249014 (owner: Ejegg) [22:36:29] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import fails with database error - https://phabricator.wikimedia.org/T116445#1755568 (LeanneS) Sounds good! I'll make the request. [22:37:58] awight: you want me to look at those notices? [22:38:00] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/249016 [22:38:10] eileen: it's only on my local as it turns out [22:38:16] ah cool [22:38:21] but I'll make a bug for the bigger issue... [22:38:22] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/249016 (owner: Ejegg) [22:39:23] Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Custom group on specific contribution types not working - https://phabricator.wikimedia.org/T116682#1755572 (awight) NEW [22:39:27] eileen: that one ^ [22:39:38] !log updated payments from 7fd1e880b6a45d79fc305b39f3fee2f324324136 to 4baa5a66a4510414d6b43b59f1b1cda2341c17fd [22:39:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:40:43] awight: OK are you looking at that - or shall I? [22:41:14] eileen: I accidentally fixed it :) [22:41:38] I opened the custom group editor and saved. Must have been something about the formatting of that silly column that encodes options [22:41:39] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Default appeal should be configurable, initial query string value should be stored in session - https://phabricator.wikimedia.org/T114127#1755580 (Ejegg) Open>Reso... [22:43:02] hmmm [22:43:03] eileen: you want me to look at a generic solution, or should we just do this open/save thing on the upgraded production? [22:43:24] I guess it depends if there is anything that is higher priority [22:43:42] there is :) ok I'll make a note for later. [22:43:44] I was just trying to add a test on the merge_hook function [22:43:51] whew, awesome! [22:44:29] & I think you want me to check your proposed fix on the date ui [22:44:42] sure! [22:45:52] Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Custom group on specific contribution types not working - https://phabricator.wikimedia.org/T116682#1755606 (awight) This was fixed by opening and saving the groups that had type restrictions. We should TODO write a gen... [22:46:14] Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Custom group on specific contribution types not working - https://phabricator.wikimedia.org/T116682#1755608 (awight) [22:46:16] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: [epic] Install 4.6 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1755607 (awight) [22:46:21] awight: and eileen I started a google doc to draft the "what's changing in 4.6" email: https://docs.google.com/a/wikimedia.org/document/d/12wBEGXbHeH5UQ9K3TU1E805eLPFkOWUTgLoIzI3mD4s/edit?usp=sharing [22:46:29] Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Custom group on specific contribution types not working - https://phabricator.wikimedia.org/T116682#1755572 (awight) [22:46:31] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [Epic] Followup tasks after Civi 4.6 upgrade - https://phabricator.wikimedia.org/T116416#1755609 (awight) [22:46:38] I can only think of 2 things at the moment [22:48:25] thanks! [22:52:11] Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review, WMF-deploy-2015-10-27_(1.27.0-wmf.4): SPIKE: assess the condition of adyen for english backup processing - https://phabricator.wikimedia.org/T114958#1755625 (Ejegg) Now loading their CC form in iframe, but getting 'Invalid Merchant... [22:54:08] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import fails with database error - https://phabricator.wikimedia.org/T116445#1755631 (CaitVirtue) @awight I know the action item lies with us (MGF) now, but can we wait to deprioritize this until we hear back from Coinbase? My goal is for this... [22:56:31] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import fails with database error - https://phabricator.wikimedia.org/T116445#1755642 (awight) p:Normal>High Yes, actually it's best if your team manages the priorities! I had reduced the priority to make the other issues pop out, but rea... [23:06:50] d'oh, of course I should have checked the file encoding on that Coinbase thing! [23:08:58] meh, we didn't have access to the file until today [23:11:40] no, I saw it on the fileshare [23:12:02] oh! I looked for it for 15 minutes and fainted [23:12:11] but of course when I synthesized a fake one I must have saved it UTF-8 [23:12:14] yep [23:12:41] the imports are buried under fundraising/tech someplace now [23:12:52] I seem to remember them being elsewhere [23:14:15] Probably in N places for N-1 issues [23:17:23] Anyone getting this error from vagrant CRM? Can't connect to local MySQL server through socket '/dev/null' [23:18:00] I already have this in the crm/templates/settings.php.erb, [23:18:01] 'host' => '127.0.0.1', // FIXME: Use socket [23:18:07] So I know I've been here before [23:19:29] my god... nvm [23:20:33] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Indicate predictable server-side timeouts on the client-side. - https://phabricator.wikimedia.org/T116691#1755742 (Ejegg) NEW [23:21:24] awight: figured it out? [23:22:04] seems like we can go back to host='localhost', like in that patch ^ [23:22:15] Now I'm up against another dozen drush errors though. [23:22:17] What a heap! [23:22:24] wheee [23:36:01] cwd|afk: Need perms to comment! [23:36:15] (weird) [23:59:16] (PS1) Eileen: Add test for contact.merge action [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/249028 (https://phabricator.wikimedia.org/T115426)