[00:02:50] (PS1) Awight: Update field name to -financial_type [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/249029 (https://phabricator.wikimedia.org/T116660) [00:03:01] Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Test and fix Engage role-specific save hooks - https://phabricator.wikimedia.org/T116660#1755954 (awight) [00:03:29] eileen: Did you happen to get to my date range patch? [00:03:42] Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Test and fix Engage role-specific save hooks - https://phabricator.wikimedia.org/T116660#1755158 (awight) a:awight [00:05:07] Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi 4.6 date range fields are unusably annoying - https://phabricator.wikimedia.org/T116420#1755959 (awight) [00:05:20] (CR) Eileen: [C: 2] "I agree!" [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/249029 (https://phabricator.wikimedia.org/T116660) (owner: Awight) [00:05:23] Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi 4.6 date range fields are unusably annoying - https://phabricator.wikimedia.org/T116420#1755961 (awight) a:awight [00:05:36] Thanks! [00:07:27] awight: I haven't yet [00:07:35] I fished out the emails :-) [00:07:37] (Merged) jenkins-bot: Update field name to -financial_type [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/249029 (https://phabricator.wikimedia.org/T116660) (owner: Awight) [00:07:39] but I can do [00:08:12] Lemme know if you need any more frenetic context shifts ;) [00:10:52] (PS1) Eileen: add test for contact.merge action [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/249034 (https://phabricator.wikimedia.org/T115426) [00:11:01] :-) [00:11:12] just gonna stop for lunch & then I'll take a look [00:16:05] (CR) Awight: [C: 2] "Pretty exasperating to read the surrounding code, but this looks like an improvement!" (4 comments) [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/249034 (https://phabricator.wikimedia.org/T115426) (owner: Eileen) [00:17:03] (Merged) jenkins-bot: add test for contact.merge action [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/249034 (https://phabricator.wikimedia.org/T115426) (owner: Eileen) [00:18:58] (PS3) Awight: Add test class for reports [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243118 (owner: Eileen) [00:21:13] (CR) Awight: [C: 2] Add test class for reports [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243118 (owner: Eileen) [00:21:19] (CR) Awight: Add test class for reports (1 comment) [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243118 (owner: Eileen) [00:21:56] awight: one thing - we need to make sure the submodule commit is the latest on civicrm repo before we upgrade [00:22:08] (Merged) jenkins-bot: Add test class for reports [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243118 (owner: Eileen) [00:22:14] (PS2) Awight: CRM-17422 fix - Change in custom field search behaviour impacting on performance [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248294 (https://phabricator.wikimedia.org/T99842) (owner: Eileen) [00:22:24] (CR) Awight: [C: 2] CRM-17422 fix - Change in custom field search behaviour impacting on performance [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248294 (https://phabricator.wikimedia.org/T99842) (owner: Eileen) [00:22:55] (CR) Awight: [V: 2] Revert "CRM-17075 further fix to handling entity reference in search form" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/249010 (owner: Eileen) [00:23:10] (PS2) Awight: CRM-17435 Add option to generate drupal_7 directory version [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248274 (owner: Eileen) [00:23:19] (CR) Awight: [V: 2] CRM-17435 Add option to generate drupal_7 directory version [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248274 (owner: Eileen) [00:23:26] (PS3) Awight: stop ignoring packages & drupal so we can submodule them [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248275 (https://phabricator.wikimedia.org/T115925) (owner: Eileen) [00:23:30] (CR) Awight: [V: 2] stop ignoring packages & drupal so we can submodule them [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248275 (https://phabricator.wikimedia.org/T115925) (owner: Eileen) [00:23:40] eileen: definitely! [00:23:48] (PS2) Awight: Add script for compiling deployment repo [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248276 (https://phabricator.wikimedia.org/T1152925) (owner: Eileen) [00:24:02] (Merged) jenkins-bot: CRM-17422 fix - Change in custom field search behaviour impacting on performance [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/248294 (https://phabricator.wikimedia.org/T99842) (owner: Eileen) [00:24:28] be back to poke at things in a few hours. [00:25:56] (CR) Eileen: add test for contact.merge action (2 comments) [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/249034 (https://phabricator.wikimedia.org/T115426) (owner: Eileen) [01:49:54] (PS9) AndyRussG: Add banner history log ID processor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (https://phabricator.wikimedia.org/T112022) [01:51:55] (CR) AndyRussG: "Bwahahahahahahah!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (https://phabricator.wikimedia.org/T112022) (owner: AndyRussG) [03:00:24] (CR) AndyRussG: "Thanks @Ejegg!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/246425 (https://phabricator.wikimedia.org/T112022) (owner: AndyRussG) [03:08:30] (CR) AndyRussG: "P.S. Aaaargh now I think I see what u were saying!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/246425 (https://phabricator.wikimedia.org/T112022) (owner: AndyRussG) [03:09:46] (PS7) AndyRussG: Add banner_history module to consume BH log id associations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/246425 (https://phabricator.wikimedia.org/T112022) [04:04:56] Fundraising-Backlog: Handle "QueryTokenData failed" messages from Worldpay - https://phabricator.wikimedia.org/T116712#1756223 (cwdent) NEW [06:40:53] Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Format Monolog messages to be easier to grep, bucket them - https://phabricator.wikimedia.org/T115746#1756364 (awight) [06:41:35] Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice: Announce new banner diet feature - https://phabricator.wikimedia.org/T115783#1756366 (awight) Open>Resolved [06:42:19] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: [epic] Install 4.6 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1756370 (awight) [06:42:20] Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Confirm that ecom script is compatible with Civi 4.6 - https://phabricator.wikimedia.org/T116674#1756368 (awight) Open>Resolved a:awight [07:28:40] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: All Civi hook code paths must be covered by PHPUnit tests - https://phabricator.wikimedia.org/T115426#1756405 (Eileenmcnaughton) Hmm - I have found I need to set some per... [07:29:16] Wikimedia-Fundraising-CiviCRM: Slowness on 4.6 upgrade when searching on custom fields - https://phabricator.wikimedia.org/T116096#1756406 (Eileenmcnaughton) Open>Resolved [07:32:50] (PS1) Eileen: Set search to default to date-rate for contribuion date [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/249071 (https://phabricator.wikimedia.org/T116420) [08:17:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Performance: Civi: don't be so crazy about "SET NAMES utf8" - https://phabricator.wikimedia.org/T116724#1756448 (awight) NEW [15:53:36] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1757745 (Jgreen) > @Jgreen, most of that looks right. I didn't know about the landi... [15:55:45] (CR) Awight: [C: 2] "Works perfectly!" [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/249071 (https://phabricator.wikimedia.org/T116420) (owner: Eileen) [15:57:04] Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi 4.6 date range fields are unusably annoying - https://phabricator.wikimedia.org/T116420#1757771 (awight) a:awight>Eileenmcnaughton [15:57:11] Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Custom group on specific contribution types not working - https://phabricator.wikimedia.org/T116682#1757772 (awight) a:awight [15:57:41] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Show large screen banner and then top screen banner without losing an impression - https://phabricator.wikimedia.org/T90919#1757777 (awight) [15:57:44] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising Sprint Vengaboys, and 3 others: Write banner diet campaign mixin - https://phabricator.wikimedia.org/T112017#1757776 (awight) Open>Resolved [15:59:31] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1757785 (Jgreen) We need to get this cut over ASAP, as it is blocking Tech Ops in s... [16:00:46] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Time the upgrade itself, and note the load it puts on the database - https://phabricator.wikimedia.org/T115736#1757794 (awight) @eileenmcnaughton Please take a peek at the log above,... [16:01:19] (PS2) Awight: Set search to default to contribution date range [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/249071 (https://phabricator.wikimedia.org/T116420) (owner: Eileen) [16:24:27] https://twitter.com/rmlewisuk/status/656762307494682624 [16:26:09] heh [16:27:22] related http://www.theatlantic.com/notes/2015/09/a-new-universal-new-yorker-cartoon-caption-id-like-to-add-you-to-my-professional-network-linkedin/406783/ [16:28:58] perfect [16:33:32] Fundraising-Backlog, Wikimedia-Fundraising, WMF-Design, Wikimedia-General-or-Unknown, and 2 others: [[wmf:Benefactors]] not displaying well on Mobile - https://phabricator.wikimedia.org/T87805#1757940 (awight) Not sure, let's put it in the fr-tech pile until we find a better person... [16:33:53] (CR) Ejegg: [C: 2] "Looks fine to me, sounds like the main user of this data is happy with trading string unpacking for campaign names." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/248925 (https://phabricator.wikimedia.org/T116613) (owner: AndyRussG) [16:34:16] ejegg: hi! thanks :) [16:34:24] Hi AndyRussG! [16:34:41] How's the end-of-October weather? [16:34:56] I had to bring in a few plants from the cold to avoid freezing them already... [16:38:01] My windowbox plants are mostly dead, but there are a couple hardy flowers hanging on. [16:38:11] It's been below freezing a few nights already [16:38:38] Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, WMF-deploy-2015-10-27_(1.27.0-wmf.4): Adyen rejects merchant signature - https://phabricator.wikimedia.org/T116667#1757963 (Ejegg) Open>Resolved [16:40:57] AndyRussG: Do you want to weigh in on the 'large banner limit' mixin? Avoiding the word 'fullscreen' everywhere but the cookie :) [16:41:05] https://gerrit.wikimedia.org/r/247460 [16:41:49] ejegg: yes! that's the first thing on my plate this "morning" (was just getting some silly paperwork out of the way before getting to it) [16:42:21] Thanks 4 the ping about it BTW :) [16:42:29] thank you! [16:43:39] Ah here's a fun thing BTW http://apologygenerator.ca/ [16:43:53] (of course .ca) ! [16:54:18] https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#submit-change [16:54:20] hmmmm [17:00:56] dstrine: be there in 2 min [17:01:32] me too, hangout issues [17:04:32] AndyRussG: kk [17:08:44] Fundraising-Backlog: [EPIC] Worldpay as english backup processor? - https://phabricator.wikimedia.org/T114701#1758177 (awight) [17:14:40] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising Sprint Vengaboys, and 2 others: Associate banner history ID with contribution_tracking ID - https://phabricator.wikimedia.org/T112022#1758212 (awight) [17:14:48] Fundraising-Backlog: Track whether the reader began a donation workflow, include in banner history log - https://phabricator.wikimedia.org/T113821#1758215 (awight) [17:14:49] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising Sprint Vengaboys, and 2 others: Associate banner history ID with contribution_tracking ID - https://phabricator.wikimedia.org/T112022#1622923 (awight) [17:16:55] Fundraising Sprint UB40, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Compile release notes and gotchas for CiviCRM, retrain - https://phabricator.wikimedia.org/T99841#1758225 (awight) [17:17:11] Fundraising Sprint UB40, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Compile release notes and gotchas for CiviCRM - https://phabricator.wikimedia.org/T99841#1758227 (awight) [17:17:27] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [epic] Port our CiviCRM customizations to 4.6 upstream, and to extensions - https://phabricator.wikimedia.org/T99838#1758231 (awight) [17:17:28] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [epic] Upgrade Civi to 4.6 & integrate new reporting - https://phabricator.wikimedia.org/T77910#1758232 (awight) [17:17:30] Fundraising Sprint UB40, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Compile release notes and gotchas for CiviCRM - https://phabricator.wikimedia.org/T99841#1300169 (awight) Open>Resolved a:awight [17:17:32] Fundraising Sprint UB40, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Compile release notes and gotchas for CiviCRM - https://phabricator.wikimedia.org/T99841#1758233 (DStrine) a:awight>None [17:21:42] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Create an alert for suspicious dips in banner impressions - https://phabricator.wikimedia.org/T116047#1758248 (DStrine) Some team members would like to fold this into dash updates. We may reconsider this in those discussions. [17:23:40] Fundraising-Backlog: Parse and log "Invalid Credit Card Number" errors from Worldpay - https://phabricator.wikimedia.org/T114390#1758259 (DStrine) [17:26:50] Wikimedia-Fundraising, WMF-Design, Wikimedia-General-or-Unknown, Easy, Mobile: [[wmf:Benefactors]] not displaying well on Mobile - https://phabricator.wikimedia.org/T87805#1758272 (DStrine) [17:27:03] Wikimedia-Fundraising, WMF-Design, Wikimedia-General-or-Unknown, Easy, Mobile: [[wmf:Benefactors]] not displaying well on Mobile - https://phabricator.wikimedia.org/T87805#1758273 (atgo) Hey @pcoombe - do you have any thoughts about this? Or perhaps someone who we could ask for help? [17:30:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Performance: Civi: don't be so crazy about "SET NAMES utf8" - https://phabricator.wikimedia.org/T116724#1756448 (DStrine) [17:31:35] Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Pause the queue consumer and build up a big batch, use that batch for benchmarking - https://phabricator.wikimedia.org/T116781#1758289 (awight) NEW [17:35:58] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic, I18n: [Epic] Use translatable pages for banner content - https://phabricator.wikimedia.org/T116235#1758330 (awight) [17:36:33] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Indicate predictable server-side timeouts on the client-side. - https://phabricator.wikimedia.org/T116691#1758337 (DStrine) [17:37:27] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Indicate predictable server-side timeouts on the client-side. - https://phabricator.wikimedia.org/T116691#1758347 (awight) Cool idea! [17:37:51] !log disabled donation queue consumer to build up queue for benchmark [17:37:54] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:38:13] Fundraising-Backlog: Handle "QueryTokenData failed" messages from Worldpay - https://phabricator.wikimedia.org/T116712#1756223 (cwdent) Also log the invalid cc errors [18:12:12] Fundraising Sprint UB40, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Compile release notes and gotchas for CiviCRM - https://phabricator.wikimedia.org/T99841#1758600 (awight) a:Eileenmcnaughton [18:17:32] gonna run some errands [18:33:58] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1758782 (awight) We do want landingpages.tsv.log, it's processed and statistics abo... [18:36:24] Fundraising Sprint Vengaboys, Fundraising-Backlog, Analytics, Analytics-Cluster, Unplanned-Sprint-Work: Landing page impression log parser should get sample rate from filenames - https://phabricator.wikimedia.org/T116800#1758791 (awight) NEW a:awight [18:38:34] Fundraising Sprint Vengaboys, Fundraising-Backlog, Analytics, Analytics-Cluster, Unplanned-Sprint-Work: Impression log parsers should get sample rate from filenames - https://phabricator.wikimedia.org/T116800#1758813 (awight) [18:43:51] AndyRussG: hi [18:44:08] AndyRussG: did you check it? and did Krinkle say something about the patch? [18:44:17] r054l13: on sec, in a meeting [18:46:11] Ahhh, ok, sorry to disturb :) [18:46:11] AndyRussG: i will be waiting :) [18:57:13] (PS1) Awight: Match filenames at any sample rate [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/249203 (https://phabricator.wikimedia.org/T116800) [19:01:13] (CR) Ejegg: [C: 2 V: 2] Match filenames at any sample rate [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/249203 (https://phabricator.wikimedia.org/T116800) (owner: Awight) [19:09:56] !log updated DjangoBannerStats from 57a0392b3f43b65050b01a0465e120ed609a769e to 12e819a04a40ee6fab5dd55fcaf072661df31106 [19:10:00] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [19:28:23] Fundraising Sprint Vengaboys, Fundraising-Backlog, Analytics, Analytics-Cluster, and 2 others: Impression log parsers should get sample rate from filenames - https://phabricator.wikimedia.org/T116800#1759039 (awight) Open>Resolved [19:28:26] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1759040 (awight) [19:33:07] K4-713: we've got about 1400 donation queued up - think that's a good number for a benchmark? [19:33:14] *donations [19:33:55] Can u estimate from the last few jobs? [19:34:08] We need to fill up at least a 90-second processing window (job time limit) [19:34:19] ah, lemme check [19:34:26] actually-i'm already logged in there, I can see too [19:35:37] ought to be plenty - it's doing 3 or so per second [19:35:50] I'm seeing 10/sec... but that's still enuf [19:37:24] huh, it's a little stuttery - log shows lots of donations at 17:33:31 and 17:33:32 but then jumps to 17:33:34 before showing more [19:37:25] Counting pretty tightly around the inner loop and ignoring the long queue waits once it's empty... [19:37:39] ok, opening the floodgates [19:37:49] * awight splashes into galoshes [19:38:03] I'm swimming in raw sewage! I love it [19:38:27] !enabled donation queue consumer [19:38:38] * ejegg dives into money pit [19:38:48] derp [19:38:57] !log enabled donation queue consumer [19:38:59] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [19:39:57] awesome! [19:40:19] Fundraising-Backlog: French donation form: "incorrect number" message generating donor confusion - https://phabricator.wikimedia.org/T116812#1759066 (MBeat33) NEW [19:40:28] yep, looks like about 10/sec [19:40:33] That puppy is swift... I think we get burst peaks of 2 donations/sec coming in. [19:43:33] found an hour with 3.3/sec at the launch of last year's big english, but that still leaves cushion for an import that takes twice as long [19:44:06] weird! [19:44:15] oh sorry, the incoming rate. yes, great! [19:44:55] It's also okay if we go into less-than-realtime processing, as long as the queue doesn't fill to maximum disk [19:45:00] yah [19:45:58] sorry i went offline, but can you look at it wen you finish the meeting? Andy [19:49:01] Krinkle: are you there? [19:49:11] ejegg: hey, good evening(GMT+1) [19:49:25] r054l13: In #wikimedia-dev I mentioned that I can't mentor this, which I said from the beginning. [19:49:42] Hi r054l13 [19:49:46] Please collaborate with fundraising people here about the patch. [19:52:04] Krinkle: but AndyRussG wanted your permission about it. [19:57:52] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Technical-Debt: We are failing to send AstroPay stats to Ganglia - https://phabricator.wikimedia.org/T116817#1759131 (awight) NEW [19:58:22] Fundraising-Backlog: French donation form: "incorrect number" message generating donor confusion - https://phabricator.wikimedia.org/T116812#1759140 (MBeat33) [20:00:23] ejegg: hi, please review my patches please [20:00:37] Fundraising-Backlog: French donation form: "incorrect number" message generating donor confusion - https://phabricator.wikimedia.org/T116812#1759155 (atgo) This is something we'll have to hunt down with WorldPay. @ppena can you pursue this? [20:02:46] (PS1) Awight: Remove bad code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/249231 (https://phabricator.wikimedia.org/T116817) [20:07:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Technical-Debt: We are failing to send AstroPay stats to Ganglia - https://phabricator.wikimedia.org/T116817#1759181 (awight) I also added it to the old config, so we don't strictly need this patch. [20:12:17] Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: DonationInterface is attempting to I_OWP twice in a row without renewing the order_id - https://phabricator.wikimedia.org/T116089#1759210 (awight) p:Unbreak!>High [20:13:42] Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: DonationInterface is attempting to I_OWP twice in a row without renewing the order_id - https://phabricator.wikimedia.org/T116089#1759221 (DStrine) @mbeat33 can you let us know how urg... [20:14:26] Fundraising-Backlog, Technical-Debt: Build Frig - https://phabricator.wikimedia.org/T116820#1759230 (cwdent) NEW [20:18:56] ejegg|meeting: Sorry I ran out there. Impromptu things. [20:20:27] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Prepare queue messages for testing on upgraded Civi. Test them. - https://phabricator.wikimedia.org/T114466#1759261 (awight) a:awight [20:23:59] Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: DonationInterface is attempting to I_OWP twice in a row without renewing the order_id - https://phabricator.wikimedia.org/T116089#1759274 (MBeat33) I have not seen another since this t... [20:32:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Technical-Debt: We are failing to send AstroPay stats to Ganglia - https://phabricator.wikimedia.org/T116817#1759291 (atgo) @awight should we add this to sprint? [20:36:47] (CR) Ejegg: [C: -1] "Unfortunately, it looks like this bug is obsolete! The UI is no longer using the centralnotice-number-uses i18n key. Do you want to submi" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/248612 (https://phabricator.wikimedia.org/T41266) (owner: Rosalieper) [20:58:35] Uruguay's wholesome interest in paddocks began in 2011: https://www.google.com/trends/explore#geo=UY-MO&q=paddock [20:58:59] ah nvm: t_0 [21:01:26] r054l13: hi! So, just to explain to you a little about the software development processes at work here.. Almost everyone is on a team that sets goals together. It's actually pretty difficult because there is an almost infinite amount of stuff that any team _could_ do, so everyone does a lot of prioritizing. For example, for Fundraising, the most intense donation campaigns are coming up in a month, and so [21:01:26] we are working hard to make sure everything is in place for that--backup payment processors, analytics data, thank-you emails--Fundraising relies on a pretty complicated software system so there are a lot of tasks, big and small. Work gets prioritized and organized into work periods called "sprints". Here is the workboard for our current sprint, which ends tomorrow evening: https://phabricator.wikimedia. [21:01:26] org/tag/fundraising_sprint_vengaboys/ [21:02:24] There is so much that could possibly go in a sprint, that every week we have several meetings to determine what we should do and what has to fall by the wayside. Here's the board with stuff that may or may not go in upcoming sprints: https://phabricator.wikimedia.org/tag/fundraising-backlog/ [21:03:41] Most teams work in a similar way. Everyone is trying to get the tasks they have taken on done, and also do code review for the tasks that other people wrote code for, and deploy (i.e. send to the real Web sites) the new code that's been written [21:04:20] Everyone also is very clear that there are loads of tasks waiting on the sidelines, that would be really useful, but that have been deprioritized 'cause other stuff is even more important [21:06:30] The whole prioritization process is so involved that there are two people on the team whose jobs focus mainly on organizing development work: atgomez (Anne) who is the product manager, and is in touch with the non-tech Fundraising team (i.e., people who design the banners and such) and helps decide what is most important for their needs, and dstrine (David) who helps organize meetings and our work boards and [21:06:30] makes sure the team has a healthy work dynamic [21:07:07] r054l13: I'm explaining all this so you'll have an idea why people may not be able to review patches so quickly. It's just there's soooo much to do and soooo much that everyone has already committed to doing [21:07:56] I understand it may not be the best dynamic for working with volunteers, which is unfortunate, and should be improved, especially since the WMF is really a social movement and volunteer-based in the most important aspects [21:09:27] (CR) Ejegg: [C: 1] "A definite improvement! Could delete a var and regularize some WS." (4 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/249231 (https://phabricator.wikimedia.org/T116817) (owner: Awight) [21:10:06] However it's where we're at right now... So, some people may have different reactions when being asked to review patches that were not planned... Often here on Fundraising when we're hoping to get external review from the Performance team, we may have to wait up to a week for things that are not very urgent. But it's understandable [21:11:53] r054l13: So, please don't be discouraged about volunteering or participating, but also please understand that it's not a simple dynamic going on, and that it's important to keep your eyes open to understand how people are working and how you can best collaborate [21:12:12] r054l13: Does any of that make sense? Hope it's helpful!!! :) [21:20:10] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy: BUG: Campaign date fields cannot be edited as text - https://phabricator.wikimedia.org/T97159#1759490 (matmarex) [21:20:46] atgomez: are you able to have another go at saving a private report - I just remembered that I never did check that process through properly [21:21:04] & it 'appeared' like you hadn't actually ticked the private reports box [21:21:12] dang [21:31:18] (PS2) Awight: Remove bad code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/249231 (https://phabricator.wikimedia.org/T116817) [21:31:32] (CR) Awight: Remove bad code (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/249231 (https://phabricator.wikimedia.org/T116817) (owner: Awight) [21:32:20] Hi Fundraising, I was referred here by Help:Centralnotice. I'm trying to set up some kind of notification/banner for the 5 million articles celebration on ENWP. How does one do this? [21:32:42] eileen: Sounds like it's not hurting anything, and could wait until followup work? [21:33:09] Pine: Hello! This is actually the lair of Fundraising Tech, but we can help connect you with the right people to ask... [21:33:18] awight: yes [21:33:19] ok [21:33:37] Pine: Any metawiki admin or CentralNotice admin has permissions to run campaigns [21:34:11] https://meta.wikimedia.org/w/index.php?title=Special:ListUsers&group=centralnoticeadmin [21:34:17] (plus the admins) [21:34:42] (CR) Ejegg: "Code looks good! Just a note on the field description and a gripe about our defaults." (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/246425 (https://phabricator.wikimedia.org/T112022) (owner: AndyRussG) [21:34:43] Ok, but how does one set up a campaign under the new scheme? I'm quite unfamiliar with this, aside from being on the receiving end of banners. [21:35:12] It's probably best to work with an existing CN admin for your first banner... they know things that we don't! And then you can get permissions yourself, if you think it was fun ;) [21:35:28] I really don't need more hats, but thanks anyway [21:35:55] That's what I'm saying :D [21:36:16] It's not exactly fun. Do any of the names on that list jump out as a good collaborator? [21:36:53] Here are some more notes for understanding what's involved behind the scenes: https://www.mediawiki.org/wiki/Extension:CentralNotice [21:37:35] Help:CentralNotice is probably better user documentation, though. [21:37:49] This section is still accurate, https://meta.wikimedia.org/wiki/Help:CentralNotice#Campaigns [21:39:27] You want to decide how to target the audience, sounds like language=en, project=wikipedia. Then, create a banner--you probably want to copy and paste from one of the existing banners as a starting point. Adapt your content, try it out and iterate, then add the banner to your campaign and choose how many times you want each person to see the banner... [21:40:10] Can I delegate the entirety of this task to someone who's familiar with it? I can't be doing this for hours... [21:40:22] matanya: any chance you can help? [21:40:48] some context please? [21:41:01] reading the scroll back can take some time [21:41:08] :) Trying to create a centralnotice banner for the ENWP 5 millionth article celebration [21:41:29] And I am a complete novice with Centralnotice [21:41:46] And I can't be working on this all afternoon [21:41:50] hop to -stewards [21:41:55] sure! [21:41:56] there are some experts there [21:42:06] Great, thanks for the redirect! [21:42:16] i need to find my bed ... sure :) [21:42:48] We write the software and are always happy to help however we can, but yeah the admins will have a much better idea of how to actually run successful campaigns. [21:43:18] (PS6) AndyRussG: Large banner limit mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247460 (https://phabricator.wikimedia.org/T90919) (owner: Ejegg) [21:43:36] if it is not done by tommorow, poke me, and i'll see if i can help [21:52:55] (PS1) Ejegg: Upgrade to Drupal 7.41 upstream [wikimedia/fundraising/crm/drupal] (contrib) - https://gerrit.wikimedia.org/r/249303 [21:53:28] awight: thanks for offering edits to the email. Is it cool if I fire this off? [21:53:57] I'll bcc fr-all and cc fr-tech [21:56:11] dstrine: totes [21:56:20] Thanks again for writing the great letter! [21:56:26] It's like your IRC summoning superpower... [21:56:54] cool and thanks for the input [21:57:06] I seem to throw temper tantrums about work only when it's a task that someone already generously volunteered to do, and they're usually finished by the time I fuss :D [21:57:22] got auth'd requests to gerrit api working [21:57:23] holla [21:58:52] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Patch-For-Review: Use contentlanguage for CentralNotice banners - https://phabricator.wikimedia.org/T53475#1759719 (Romaine) I am not sure if this proposal is a good idea in the way it has been described above: as I read there to replace the s... [22:02:35] r054l13: did you see the comments I wrote about an hour ago here? [22:02:56] (CR) Ejegg: "One more suggestion - we might get duplicate queue messages if people reload the initial payments page. Do you want to enforce uniqueness " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/246425 (https://phabricator.wikimedia.org/T112022) (owner: AndyRussG) [22:05:41] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice should do everything SiteNotice does - https://phabricator.wikimedia.org/T116844#1759761 (awight) NEW [22:08:04] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Patch-For-Review: Use contentlanguage for CentralNotice banners - https://phabricator.wikimedia.org/T53475#1759780 (awight) @Romaine Great points, I think you're right that we need to offer both flavors of language targeting. [22:08:59] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Patch-For-Review: Offer contentlanguage targeting for CentralNotice banners - https://phabricator.wikimedia.org/T53475#1759781 (awight) [22:10:29] doing that scarerrand.. [22:11:44] AndyRussG: i did not [22:11:51] sorry i was out for a while [22:11:58] but i did not see it please :) [22:12:04] AndyRussG: are you still around? [22:14:18] AndyRussG: yes i saw it, It really makes some sense and i understand everything [22:14:56] r054l13: ah OK great :) [22:15:22] AndyRussG: actually from my small experience, i know that software development takes many things into consideration [22:16:01] prioritisation is also part of it, but i was just doing and asking this because i will soon maybe be a participant in Outreacchy and my codebase contribution matters alot [22:16:21] r054l13: sorry if this kind of explanation is not posted anywhere clearly... Maybe it's something to talk to qgil about (he's the Engineering Community Manager) [22:16:30] so i wanted more code to be in the codebase. I don't know if you understand me. My mentors said i should fix more bugs :) [22:17:33] r054l13: right! that certainly makes sense... still, if your stuff has been submitted to Gerrit and is just waiting for review, it's visible so anyone can see what you've done [22:17:47] no one can blame you for others not yet having time for review :) [22:18:05] thanks for staying enthusiatstic!! :) [22:21:10] AndyRussG: no problem, i have one more question. Have you read the proposal? [22:21:35] r054l13: no, which proposal? [22:22:21] my Outreachy proposal :) [22:22:26] Should send you the link AndyRussG ? [22:22:33] Yes please! :) [22:22:49] https://phabricator.wikimedia.org/T116223 [22:23:04] that is the phab task, have a look and send me comments if any please :) [22:29:11] r054l13: OK! [22:53:16] (CR) Ejegg: [C: 2] Remove bad code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/249231 (https://phabricator.wikimedia.org/T116817) (owner: Awight) [22:57:32] (CR) AndyRussG: [C: -1] "Fantastic!! :)" (4 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247460 (https://phabricator.wikimedia.org/T90919) (owner: Ejegg) [23:00:59] AndyRussG: how do you see it or are you still reading? [23:01:55] r054l13: ah heh mmm sorry if I wasn't clear, yes I'll have a look at the propsal, but I'm not able to look at it exactly now 8p [23:02:20] At a quick glance it seemed quite interesting! [23:02:27] ok AndyRussG no problem :) [23:02:40] AndyRussG: anytime is free but before 2nd which is the deadline :) [23:02:58] Ah K I understand :) [23:05:24] Thanks AndyRussG! It looks like pre-banner mixins still run when testing with 'banner' in the QS - is that not the case? [23:06:04] ejegg: hum... what URL are u using? [23:06:19] was just looking through the code... [23:06:37] Also I'm confused because it looks like the cookie gets set at the root path even though it shouldn't, I think? [23:07:02] let me actually step through and check before I bother you about it... [23:07:19] umm, lemme see what the jq cookie docs say [23:08:50] ejegg: check out ext.centralNotice.startUp.js. The entry point for when banner parm is there is displayTestingBanner(). That just fetches the banner, shouldn't run any mixin hooks [23:09:03] Gotta sup, back in a bit! :) [23:09:09] aha, thanks! [23:09:18] P.S. Yeah the docs contributed 2 my confusion... [23:09:18] enjoy [23:09:24] thx! cya 'round [23:22:07] (PS7) Ejegg: Large banner limit mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247460 (https://phabricator.wikimedia.org/T90919) [23:22:25] (CR) Ejegg: Large banner limit mixin (4 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247460 (https://phabricator.wikimedia.org/T90919) (owner: Ejegg) [23:51:25] Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, and 2 others: We are failing to send AstroPay stats to Ganglia - https://phabricator.wikimedia.org/T116817#1760236 (atgo) [23:58:38] Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, and 2 others: We are failing to send AstroPay stats to Ganglia - https://phabricator.wikimedia.org/T116817#1759131 (awight)