[00:01:14] just missing a db entry for the menu link [00:02:22] err, nope, entry exists but router_path is wrong for some reason [00:03:56] totally not civi-related [00:04:34] Good news! [00:04:56] If you do find anything, I'm trying to at least link it to https://phabricator.wikimedia.org/T77910 for now [00:05:07] (even drupal-related) [00:05:20] cool [00:06:42] Search seems much faster! [00:08:46] yeah! [00:08:58] bummer, lybunt just died [00:09:14] awight: it looks like we should be able to slow-start jenkins by modifying the config.xml files directly [00:09:34] Okay, that works for me [00:10:14] ooh, I wonder if this killed the lybunt report I just tried to view: PHP Fatal error: Allowed memory size of 268435456 bytes exhausted (tried to allocate 4 bytes) in /srv/org.wikimedia.civicrm/civicrm/packages/DB/DataObject.php on line 559 [00:10:21] I'm not sure yet why there's only one job that is disabled that way though [00:10:51] Jeff_Green: I think that's the only one that's usually disabled. All the rest are on [00:11:30] seeing a bunch of Failed to parse trxn_id: null, INVALID_MESSAGE Missing gateway. [00:11:39] huh ok [00:12:40] ejegg: Jeff_Green: There are a few that are normally disabled, I believe. silverpop "export only"; globalcollect recurring "damaged" or something [00:13:53] oh right [00:14:05] silverpop export only has "false" but doesn't appear to have any timer trigger [00:14:12] ooh [00:14:28] I'm on board with this XML munging thing [00:14:48] i'm not 100% sure what it will take to un-munge :-P [00:15:04] still studying [00:17:54] ok 21 of 30 have timer-triggers [00:19:04] and of those, only "GlobalCollect missed recurring (DEPRECATED)" is disabled [00:19:18] That sounds just right [00:19:23] so I think the thing to do is disable just the ones that have timer triggers [00:19:25] and fire it up [00:19:37] and be ready to run [00:21:27] amback [00:22:57] eileen1: Hey! [00:23:12] I'm taking off in a few minutes, will be gone for 2 hours perhaps. [00:23:51] ok you think all is ok? [00:24:18] anything specific I should check? [00:24:29] IMO, all we have left is to * do sanity checking on the GUI, and * slow-start Jenkins jobs, running each job at 1 batch size 1 a few times before enabling on the old schedule. [00:24:38] ok [00:24:40] Anything on the test plan is especially fair game [00:24:54] which code is o live now? [00:24:56] You feel confident? [00:24:56] I'll be ready to start jenkins in a few minutes [00:24:57] viewing WMF LYBUNT results is whitescreening for me [00:25:06] trying to determine why [00:25:06] eileen1: It's currently civi-4.6.9-deployment [00:25:22] ok so 'final' code [00:25:32] ejegg: is that the same on staging? [00:25:48] eileen1: I'll take a look [00:26:07] OK, seems to be hitting a memory limit [00:26:20] You think we can leave it on that branch for the day? [00:26:20] ejegg: you want to slow-start some jobs once Jenkins is up? [00:26:32] PHP Fatal error: Allowed memory size of 268435456 bytes exhausted (tried to allocate 4 bytes) in /srv/org.wikimedia.civicrm/civicrm/packages/DB/DataObject.php [00:26:39] awight: sure, will do [00:26:45] eileen1: No, I think we have deployment-prep-4.6.9 on staging currently [00:26:49] ejegg: thanks! [00:27:00] ejegg: - this one ? https://civicrm.wikimedia.org/civicrm/report/instance/50?reset=1&output=criteria [00:27:12] eileen1: It's easy to check out any branch on staging, but fyi changing the production deployment branch name requires a jeff setting. [00:27:32] awight: ok cool so I think I like having staging stay on what we tested for now [00:27:40] in case there are any diffs [00:28:32] eileen1: this one: https://civicrm.wikimedia.org/civicrm/report/contribute/wmf_lybunt?reset=1 [00:28:32] ejegg: that url from above did resolve - diff lybunt? [00:29:16] eileen1: cool--leave it like it is, then? [00:29:29] awight: I think so [00:29:52] ejegg: if you add &output=criteria to the url you get a chance to edit it [00:30:02] (giant rabbit improvement) [00:30:23] ah, right, I was just trying to create a new report from the template [00:30:37] OK, disappearing for a couple of hours and then highly distracted for another hour. Sorry, and good luck! [00:30:44] have fun! [00:30:54] I'll be online later to mop and stuff :D [00:31:01] what a party! [00:31:07] :-) [00:31:23] does anyone here have a working jenkins login? [00:31:35] Jeff_Green: I do, I'll try logging in now [00:31:43] ok gimme a minute to fire it up [00:32:01] once i do can you just poke around and make sure it looks like jobs are actually disabled? [00:32:18] yep, will do [00:32:26] I'll try my login too, I just haven't used it in ~year so I don't know [00:33:02] ejegg: well using year = 2015 they both spin into long queries... [00:33:30] oh, I tried with the default and even 2005 seems to do the same [00:33:42] dang, they like this report [00:33:48] sorry 2005 I mean [00:34:07] trying 2015 now, just for kicks [00:34:25] ok started [00:35:20] grr, connection reset [00:35:38] ok, other browser can do it [00:35:49] 'please wait, jenkins is getting ready..' [00:36:02] hmmm. [00:36:06] HRMM. [00:36:09] login screen [00:36:16] aargh, and login failure loop [00:36:27] ok, I'm in [00:36:44] yep, all disabled except the unscheduled ones [00:36:50] yayyyyyy! woot. [00:36:58] woot indeed [00:37:20] my login doesn't work. oh well. [00:37:23] maybe I'll start with a batch of TY emails [00:37:35] Jeff_Green: just try like 6 times in a row and it might [00:37:40] ha [00:37:54] re. starting, just start small whatever you do, in case of trouble [00:38:07] yep! [00:39:17] ejegg: I'll see if I can see what is happening with that report [00:39:19] eileen1: Oh, those lybunts are probably not a new issue. I forgot they always run it with a pretty restrictive donor group filter [00:39:31] That 'custom lybunt' shows the filter [00:39:46] ah ok [00:40:09] if I filter by contribution type it fails - which is a regression but can fix easily [00:40:56] aargh, ty mail sender fails [00:41:49] Error: joinAdd: civicrm_tag has no link with civicrm_entity_tag in civicrm_api3() (line 45 of civicrm/api/api.php) [00:41:56] that's the one that just came in [00:42:58] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Thank You mail send broken on Civi 4.6 - https://phabricator.wikimedia.org/T117143#1767648 (Ejegg) NEW [00:43:11] ok. I think there's nothing much for me to do now, so I'm going to go offline for now. I'll have my phone, please SMS or phone if anything comes up [00:43:20] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Thank You mail send broken on Civi 4.6 - https://phabricator.wikimedia.org/T117143#1767656 (Ejegg) [00:43:22] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [epic] Upgrade Civi to 4.6 & integrate new reporting - https://phabricator.wikimedia.org/T77910#1767655 (Ejegg) [00:46:43] that tag error is in the custom api for entity tag I think [00:46:59] our stuff, right? [00:47:27] same error locally... exploring [00:47:40] yeah - it's a port from 4.2 [00:48:02] this class [00:48:03] CRM_Core_BAO_EntityTag [00:48:06] line 80 [00:50:41] ejegg: am I right in thinking this issue will stop those thank-yous going out but once fixed they will process away - ie it's majorly annoying but minor impact ATM? [00:51:01] well, we can't let them get much staler... [00:51:20] ok [00:51:21] But I think we have a couple days [00:51:43] right - that was what I was trying to understand [00:52:01] ah, right, not the most critical bit. [00:52:07] I think the fix is pretty easy - but just wondering whether it was screaming rush [00:52:11] I'm going to try importing a few contributions [00:52:16] from the queue [00:52:52] ok - regarding that bug - how did you replicate it locally? [00:55:03] drush ty [00:55:52] eileen1: just need to have at least 1 recent contribution in the db (less than 2 wks I think) with nothing in the thank_you_sent or no_thank_you custom fields in wmf contribution extra [00:56:34] ejegg: I can get to it in a test so I can fix [00:56:47] rockin! [01:00:53] OK, donations queue consume worked for one [01:01:08] will try with bigger batches [01:03:44] ah, drat. errors [01:05:03] oh, utm_source isn't freeform? [01:05:48] ah, that's direct_mail_appeal, not utm_source [01:14:22] so confused where that's being set... [01:15:41] aha, there it is [01:19:22] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi 4.6 Can't import contributions with a utm_campaign - https://phabricator.wikimedia.org/T117146#1767706 (Ejegg) NEW [01:19:45] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi 4.6 Can't import contributions with a utm_campaign - https://phabricator.wikimedia.org/T117146#1767714 (Ejegg) [01:19:46] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [epic] Upgrade Civi to 4.6 & integrate new reporting - https://phabricator.wikimedia.org/T77910#1767713 (Ejegg) [01:21:19] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi 4.6 Can't import contributions with a utm_campaign - https://phabricator.wikimedia.org/T117146#1767719 (Eileenmcnaughton) Adam & I discussed this a bit & he thought it would be OK I think in that we would only... [01:22:40] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi 4.6 Can't import contributions with a utm_campaign - https://phabricator.wikimedia.org/T117146#1767723 (Eileenmcnaughton) ie. we discussed the general change - custom fields not validating input from the api [01:27:41] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi 4.6 Can't import contributions with a utm_campaign - https://phabricator.wikimedia.org/T117146#1767726 (Ejegg) I think the 'whitelisted' thing makes sense. Looking into doing that in the normalization. Plann... [01:28:10] slight change of plans... [01:28:22] Looks like it's been eventful! [01:29:28] away for a bit - back online in about 30 - I have a fix for the entity_tag one [01:31:14] ok! [01:31:22] ejegg: "I think the 'whitelisted' thing makes sense. Looking into doing that in the normalization. Planning to stash all the d_m_a values, then only assign d_m_a if utm_campaign matches one of those." [01:31:46] yeah, does that sound right? [01:31:46] That sounds like a solid stepping stone--maybe emit a warning when it doesn't match... [01:32:16] I bet there is gonna be a lot more of this type of error... [01:32:24] awight: that's a lot of warnings! None of the CN campaigns are in 'appeal' [01:32:59] hrm. very true, nvm [01:33:17] ... I wonder what I was think the first time around... [01:34:05] ejegg: I'll turn over more rocks in Jenkins, then? [01:34:20] please do! [01:34:26] ty mail send fails on entity tags [01:34:42] the only other one i've tried is donation queue consume [01:35:23] eileen said she had a patch for the entity tags, so I'll wait on that. [01:40:19] (PS1) Ejegg: Only copy valid campaigns to appeal field [wikimedia/fundraising/crm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249943 (https://phabricator.wikimedia.org/T117146) [01:41:21] (CR) jenkins-bot: [V: -1] Only copy valid campaigns to appeal field [wikimedia/fundraising/crm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249943 (https://phabricator.wikimedia.org/T117146) (owner: Ejegg) [01:41:23] (CR) Awight: [C: 2] Only copy valid campaigns to appeal field [wikimedia/fundraising/crm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249943 (https://phabricator.wikimedia.org/T117146) (owner: Ejegg) [01:41:30] (CR) Awight: [V: 2] Only copy valid campaigns to appeal field [wikimedia/fundraising/crm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249943 (https://phabricator.wikimedia.org/T117146) (owner: Ejegg) [01:45:46] awight: did we have CiviCase or CiviGrant enabled for a while? [01:49:13] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: AstroPay audit parser fails with "gateway not found" exception - https://phabricator.wikimedia.org/T117148#1767749 (awight) NEW [01:49:27] ejegg: Yeah we tried them both--mostly just in staging, but I think I enabled both in production. [01:49:42] Anything going on there? [01:49:49] odd smells? [01:49:53] oh, just neiter of them are enabled in prod now [01:49:57] back [01:50:00] wb [01:50:41] ejegg: ah hmmm em. Let's leave it for now, then [01:50:45] wait for a complaint... [01:51:10] weren't people using them to get reminders of things? [01:52:29] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Update Exchange Rates job should emit some logs - https://phabricator.wikimedia.org/T117149#1767756 (awight) NEW [01:52:57] ejegg: Maybe add a "followup" subtask? [01:53:02] will do [01:54:22] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Enable CiviGant / CiviCase in 4.6 - https://phabricator.wikimedia.org/T117150#1767762 (Ejegg) NEW [01:54:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Enable CiviGant / CiviCase in 4.6 - https://phabricator.wikimedia.org/T117150#1767770 (Ejegg) [01:58:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Globalcollect recurring job config is screwy - https://phabricator.wikimedia.org/T117151#1767771 (awight) NEW [01:58:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Enable CiviGrant / CiviCase in 4.6? - https://phabricator.wikimedia.org/T117150#1767777 (awight) [02:02:03] looks like we need to replace all instances of next_sched_contribution with next_sched_contribution_date [02:02:54] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Globalcollect recurring job needs fixes for Civi 4.6 - https://phabricator.wikimedia.org/T117152#1767785 (awight) NEW [02:03:13] eileen: awesome, a solution already! [02:03:23] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Globalcollect recurring job needs fixes for Civi 4.6 - https://phabricator.wikimedia.org/T117152#1767785 (awight) 19:01 < eileen> looks like we need to replace all instances of next_sched_contribution with next_sched_contribution_date [02:03:28] awight: didn't you fix the wmf_campaigns list whitescreen? [02:03:37] ejegg: Might still be in CR? [02:03:42] oh, lemme see [02:04:35] ah, merged to master yesterday. probably after the master -> 4.6.9 merge [02:04:57] seems to explain it [02:05:08] awight: what branch do I do a git review against ? [02:05:21] Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: WMF Campaign page whitescreens if metadata is missing - https://phabricator.wikimedia.org/T116423#1767792 (awight) Needs merge to civi-4.6.9-deployment [02:06:08] eileen: good question! I started a dirty tradition of reviewing to the civi-4.6.9-deployment branch, just to save us some speedbumps during this phase [02:06:27] might as well continue there, so it's clear what needs to be merged nicer later. [02:07:19] (PS1) Ejegg: Fail gracefully if campaigns were added using the native Civi interface [wikimedia/fundraising/crm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249946 (https://phabricator.wikimedia.org/T116423) [02:07:28] cherry-picked it over [02:07:54] thanks! [02:07:57] (PS2) Ejegg: Fail gracefully if campaigns were added using the native Civi interface [wikimedia/fundraising/crm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249946 (https://phabricator.wikimedia.org/T116423) [02:08:09] (CR) Ejegg: [C: 2 V: 2] Fail gracefully if campaigns were added using the native Civi interface [wikimedia/fundraising/crm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249946 (https://phabricator.wikimedia.org/T116423) (owner: Ejegg) [02:08:49] Now I recall clearly why it's good to test throughly *before* deploying :( [02:08:59] hehe [02:09:04] who has time for that? [02:09:13] this has been quite a "day" [02:09:30] oof, how much have you slept in the last 36 hours? [02:09:37] Mari's awake! I gotta do fun stuff [02:09:47] yay fun! [02:10:07] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: Amazon audit download fails - https://phabricator.wikimedia.org/T117153#1767800 (awight) NEW [02:10:35] huh? That should have zilch to do with Civi [02:10:57] uh, firewall thing? [02:15:56] (PS1) Eileen: Update references to civicrm_contribution_recur.next_sched_recur_date to new field name [wikimedia/fundraising/crm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249950 (https://phabricator.wikimedia.org/T117152) [02:16:43] (CR) jenkins-bot: [V: -1] Update references to civicrm_contribution_recur.next_sched_recur_date to new field name [wikimedia/fundraising/crm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249950 (https://phabricator.wikimedia.org/T117152) (owner: Eileen) [02:18:09] awight: so it can't actually run tests on that branch can it? [02:18:30] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: Amazon audit download fails - https://phabricator.wikimedia.org/T117153#1767832 (Ejegg) @Jgreen, is the firewall allowing outgoing access from Jenkins/Civi to the mws.amazonservices.com IP addr... [02:29:49] eileen: nope, we need to force submit for now :( [02:30:14] (PS2) Awight: Update references to civicrm_contribution_recur.next_sched_recur_date to new field name [wikimedia/fundraising/crm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249950 (https://phabricator.wikimedia.org/T117152) (owner: Eileen) [02:30:38] (CR) Awight: [C: 2 V: 2] Update references to civicrm_contribution_recur.next_sched_recur_date to new field name [wikimedia/fundraising/crm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249950 (https://phabricator.wikimedia.org/T117152) (owner: Eileen) [02:36:39] need to head out for now. good luck ! [02:37:54] thanks! [02:42:50] eileen: Looks like that's all the outstanding patches? [02:43:00] Want me to deploy another iteration of civi-4.6.9-deployment? [02:43:55] awight|parentoid: so - I just pushed up the one for global recur failures [02:44:04] am working on the one for the thank you failure [02:44:13] not sure what else is outstanding [02:44:13] I think I merged the globalcollect recurring one [02:44:20] to live? [02:44:25] or to the branch [02:44:27] no, just the branch [02:44:35] ok, I'll deploy what we have so far [02:44:57] !log updated CRM from 61c8c13efb31f7e75564d9a01fa879db0690fb78 to 367cd85954697c6ad4311deb2799fe9ba08b5d9d [02:45:05] cool [02:45:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [02:45:28] retrying the main consumer... [02:47:35] !log donations queue consumer reenabled [02:47:39] It's alive! [02:47:41] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [03:02:38] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [epic] Upgrade Civi to 4.6 & integrate new reporting - https://phabricator.wikimedia.org/T77910#1767870 (awight) [03:02:39] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Globalcollect recurring job needs fixes for Civi 4.6 - https://phabricator.wikimedia.org/T117152#1767867 (awight) Open>Resolved a:awight Confirmed working. [03:02:50] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [epic] Upgrade Civi to 4.6 & integrate new reporting - https://phabricator.wikimedia.org/T77910#831558 (awight) [03:02:51] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi 4.6 Can't import contributions with a utm_campaign - https://phabricator.wikimedia.org/T117146#1767872 (awight) Open>Resolved a:awight Confirmed working. [03:13:28] (PS1) Eileen: Fix thank_you to not use ported 4.2 custom api [wikimedia/fundraising/crm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249954 [03:14:08] (PS1) Eileen: Fix thank_you to not use ported 4.2 custom api [wikimedia/fundraising/crm] (master-plus-4.6.9) - https://gerrit.wikimedia.org/r/249955 [03:14:10] (PS1) Eileen: Add test for Fix thank_you to not use ported 4.2 custom api [wikimedia/fundraising/crm] (master-plus-4.6.9) - https://gerrit.wikimedia.org/r/249956 [03:14:14] (CR) jenkins-bot: [V: -1] Fix thank_you to not use ported 4.2 custom api [wikimedia/fundraising/crm] (master-plus-4.6.9) - https://gerrit.wikimedia.org/r/249955 (owner: Eileen) [03:14:16] (CR) jenkins-bot: [V: -1] Add test for Fix thank_you to not use ported 4.2 custom api [wikimedia/fundraising/crm] (master-plus-4.6.9) - https://gerrit.wikimedia.org/r/249956 (owner: Eileen) [03:14:18] (CR) jenkins-bot: [V: -1] Fix thank_you to not use ported 4.2 custom api [wikimedia/fundraising/crm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249954 (owner: Eileen) [03:17:28] (CR) Awight: [C: 2 V: 2] "Looks great!" [wikimedia/fundraising/crm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249954 (owner: Eileen) [03:17:43] (CR) Eileen: "On reading the code I concluded the extracted lines were resolving an array of tags that applied to the given contribution." [wikimedia/fundraising/crm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249954 (owner: Eileen) [03:21:58] (PS1) Eileen: Add deprecation comments to 4.2 custom api [wikimedia/fundraising/crm/civicrm] (master-plus-4.6.9) - https://gerrit.wikimedia.org/r/249958 [03:24:12] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Thank You mail send broken on Civi 4.6 - https://phabricator.wikimedia.org/T117143#1767892 (Eileenmcnaughton) The branch situation is confusing at the moment. I added submitted a fix to 4.6.9-deployment, a test to... [03:27:12] awight|parentoid: ok - that's the 2 things I was looking into - do you have a feel of what else is not working? [03:38:08] eileen: A few things [03:38:10] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Thank You mail send broken on Civi 4.6 - https://phabricator.wikimedia.org/T117143#1767900 (Eileenmcnaughton) Looks like i didn't comment them right & they weren't linked :-( Merged to deployment https://gerrit.wi... [03:38:22] that I'm gonna look at in a few minutes [03:38:32] all linked as blockers on https://phabricator.wikimedia.org/T77910 [03:38:40] https://phabricator.wikimedia.org/T117153 (probably firewall config) [03:38:50] https://phabricator.wikimedia.org/T117148 [03:39:28] that's it for known bugs (that need immediate fixin)! [03:39:58] want me to deploy the TY fix? [03:40:01] ok I was hoping that those 2 would have disappeared since I don't know what the cause is :-) [03:40:10] do we need those other two patches, or are they just followup stuff? [03:40:18] the latter [03:40:25] they aren't on deployment branch [03:40:31] great! I'll deploy, then... [03:40:46] (with insane monkey on my kbd [03:41:46] literally attempting to drool crackers into it [03:42:36] !log update CRM from 367cd85954697c6ad4311deb2799fe9ba08b5d9d to e0cad7215192464941d0ec282a70cb608619cf2f [03:42:43] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [03:43:05] eileen: There's a testing UI if you wish... [03:43:29] admin/config/thank_you/test [03:43:36] this kid thing is blowing up [03:44:13] as in a literal kid [03:45:02] the real mccoy [03:50:06] back [03:50:24] that test UI might not hit the code path you changed, though... [03:51:32] aww too bad, yeah it doesn't test that code. [03:51:37] well, I'll just slow-start then [03:53:03] looks good! We'll need to test that tags stuff, still, but now it's normal priority [03:54:58] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [epic] Upgrade Civi to 4.6 & integrate new reporting - https://phabricator.wikimedia.org/T77910#1767912 (awight) [03:54:59] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Thank You mail send broken on Civi 4.6 - https://phabricator.wikimedia.org/T117143#1767909 (awight) Open>Resolved a:awight Blocking issue is resolved. Remaining work in a subtask. [03:56:19] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Follow-up to EntityTag changes; test thank-you with tags - https://phabricator.wikimedia.org/T117160#1767913 (awight) NEW [03:56:42] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Follow-up to EntityTag changes; test thank-you with tags - https://phabricator.wikimedia.org/T117160#1767913 (awight) [03:56:43] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [Epic] Followup tasks after Civi 4.6 upgrade - https://phabricator.wikimedia.org/T116416#1767919 (awight) [03:58:05] eileen: contribution date range still has that horizontal layout... you think my patch is OK to add to what you've done already? [03:58:25] awight: yes I do [03:58:44] we should follow that up a bit more upstream too [03:59:08] I was less keen on the disabled fields showing tho [04:00:26] (PS1) Awight: Give contribution date range a tighter layout [wikimedia/fundraising/crm/civicrm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249959 (https://phabricator.wikimedia.org/T116420) [04:00:38] sure, happy to leave that out for now, your main fix was great [04:01:16] (CR) jenkins-bot: [V: -1] Give contribution date range a tighter layout [wikimedia/fundraising/crm/civicrm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249959 (https://phabricator.wikimedia.org/T116420) (owner: Awight) [04:01:24] (CR) Eileen: [C: 2] "I think this looks better too." [wikimedia/fundraising/crm/civicrm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249959 (https://phabricator.wikimedia.org/T116420) (owner: Awight) [04:01:47] (CR) Awight: [V: 2] Give contribution date range a tighter layout [wikimedia/fundraising/crm/civicrm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249959 (https://phabricator.wikimedia.org/T116420) (owner: Awight) [04:02:12] (PS1) Awight: bump civicrm submodule [wikimedia/fundraising/crm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249960 [04:02:27] (CR) Awight: [C: 2 V: 2] bump civicrm submodule [wikimedia/fundraising/crm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249960 (owner: Awight) [04:03:48] !log update CRM from e0cad7215192464941d0ec282a70cb608619cf2f to 60c4a8e5fc4efb6ac38a520e652afe187e8c177b [04:03:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [04:05:43] awight:that astropay error suggests it was generated against master-plus-4.6.9 not civicrm-4.6.9-deploymnet [04:06:07] ie the line number doesn't correspond to the code that I think is on master now [04:06:08] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [Epic] Followup tasks after Civi 4.6 upgrade - https://phabricator.wikimedia.org/T116416#1767937 (awight) [04:06:10] Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: WMF Campaign page whitescreens if metadata is missing - https://phabricator.wikimedia.org/T116423#1767936 (awight) Open>Resolved [04:06:20] although I'm not sure if the error occurred before the code change? [04:06:23] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [epic] Upgrade Civi to 4.6 & integrate new reporting - https://phabricator.wikimedia.org/T77910#1767940 (awight) [04:06:23] Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Install Civi 4.6 to production - https://phabricator.wikimedia.org/T99844#1767939 (awight) [04:06:25] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising Tech Backlog, and 3 others: [epic] Install 4.6 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1767938 (awight) Open>Resolved [04:06:39] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising Tech Backlog, and 3 others: [epic] Install 4.6 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1300182 (awight) [04:06:40] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising Tech Backlog, and 3 others: Time the upgrade itself, and note the load it puts on the database - https://phabricator.wikimedia.org/T115736#1767942 (awight) Open>Resolved [04:06:59] eileen: scary! [04:07:02] checking that now [04:07:28] hmm - not sure actually [04:09:10] so my take is 4.6.9-deploymnet has this https://git.wikimedia.org/blob/wikimedia%2Ffundraising%2Fcrm/78dee8f09e1cd7ec11fdab4cbeaef6bd6f419022/sites%2Fall%2Fmodules%2Fwmf_audit%2Fwmf_audit.module [04:10:05] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Clean up CRM branches - https://phabricator.wikimedia.org/T117162#1767944 (awight) NEW [04:12:23] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: AstroPay audit parser fails with "gateway not found" exception - https://phabricator.wikimedia.org/T117148#1767952 (awight) drush en astropay_audit [04:13:42] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: AstroPay audit parser fails with "gateway not found" exception - https://phabricator.wikimedia.org/T117148#1767953 (awight) Open>Resolved a:awight [04:13:43] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [epic] Upgrade Civi to 4.6 & integrate new reporting - https://phabricator.wikimedia.org/T77910#1767955 (awight) [04:14:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Amazon audit download fails - https://phabricator.wikimedia.org/T117153#1767956 (awight) p:Normal>High [04:23:53] eileen: Whaddyu think about the branch cleanup? Maybe we leave things like this over the weekend, and try to deploy the civi-core stuff next week? [04:24:06] We'll probably have to push some more hotfixes, if that changes anything. [04:25:36] awight: do we def have the right version of wmf_audit on prod? [04:26:02] I'm all for getting things stable & then having a cool-off period [04:26:23] but, just not sure about that Astropay error & whether it denotes the code is not the right version [04:26:35] eileen: sorry--I fixed it a minute ago [04:26:40] ah cool [04:26:56] looks like I took the lowest-hanging fruit :D--it was just "drush en astropay_audit" [04:27:05] :-) [04:27:14] so is smashing pig ok? [04:27:24] I never expected to ask that [04:27:42] hehe, we need to assign more eccentric names from here out [04:28:27] eileen: I guess I'll announce our victory? [04:29:29] I can't look [04:29:59] :) [04:30:12] what u mean? [04:30:45] I'm scared when you announce victory everything will come crashing down [04:31:06] ah :) that was my first guess [04:49:16] eileen: Don't feel obliged to continue working on this! [04:50:00] I might jab some sharp sticks at it later, but I think the urgent stuff is over now... [04:50:30] awight: I'll check in tomorrow - email m if you see anything [04:50:43] thanks again for the amazing push on this! [04:51:30] it's looking good? [04:51:36] cwd: ravishing! [04:51:46] :D [04:51:51] feel free to jab at the UI (non-destructively)! [04:52:19] normal live url? [04:52:33] or better, feel free to not think about work until tomorrow :) [04:52:37] yeah, same URL [05:05:26] she's a beaut! [05:06:44] hearse trading, I see... [05:26:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Amazon audit download fails - https://phabricator.wikimedia.org/T117153#1767988 (awight) Correction, I said in email that < 1% of Amazon donations come in through the audit channel, but I see now there is another group with NUL... [05:43:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Reports "Save a Copy" is broken - https://phabricator.wikimedia.org/T117166#1767992 (awight) NEW [05:48:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Report criteria is not displayed in web results - https://phabricator.wikimedia.org/T117168#1768009 (awight) NEW [05:48:53] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Report criteria is not displayed in web results - https://phabricator.wikimedia.org/T117168#1768009 (awight) [06:01:43] Fundraising Sprint William Shatner, Fundraising-Backlog, Continuous-Integration-Config, Unplanned-Sprint-Work, Patch-For-Review: Tests on deployment branches of wikimedia/fundraising/crm falling causing to force merge (and deadlock of Zuul) - https://phabricator.wikimedia.org/T117062#1768025 (aw... [06:04:25] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Clean up CRM branches - https://phabricator.wikimedia.org/T117162#1768037 (awight) [06:10:40] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Reports "Save a Copy" is broken - https://phabricator.wikimedia.org/T117166#1768041 (awight) [06:29:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Log of Civi reports executed; permalink to history items - https://phabricator.wikimedia.org/T117170#1768043 (awight) NEW [06:30:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Audit log of Civi reports as they are run; permalink to frozen or live results - https://phabricator.wikimedia.org/T117170#1768050 (awight) [06:31:31] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Do Not Solicit column in custom LYBUNT report? - https://phabricator.wikimedia.org/T117171#1768052 (awight) NEW [06:32:48] Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Install Civi 4.6 to production - https://phabricator.wikimedia.org/T99844#1768060 (awight) [06:32:50] Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising Tech Backlog, Fundraising-Backlog, and 4 others: Stop calling CREATE FUNCTION from application code - https://phabricator.wikimedia.org/T117044#1768059 (awight) Open>Resolved [06:34:06] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Clean up CRM branches - https://phabricator.wikimedia.org/T117162#1768062 (awight) [06:34:07] Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Civi upgrade drush script should return non-zero error code on failure - https://phabricator.wikimedia.org/T117040#1768063 (awight) [06:34:09] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [Epic] Followup tasks after Civi 4.6 upgrade - https://phabricator.wikimedia.org/T116416#1768061 (awight) [06:34:55] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Clean up CRM branches - https://phabricator.wikimedia.org/T117162#1767944 (awight) [06:40:11] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [epic] Upgrade Civi to 4.6 & integrate new reporting - https://phabricator.wikimedia.org/T77910#1768080 (awight) [06:40:12] Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Install Civi 4.6 to production - https://phabricator.wikimedia.org/T99844#1768078 (awight) Open>Resolved a:awight [07:04:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import fails with database error - https://phabricator.wikimedia.org/T116445#1768085 (awight) @ejegg I see 0xcc5f for the umlaut, in the CSV file, which is also what shows up in the stack trace. Where do you see 0xc3a4 in an error message? I... [07:13:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Saving a contact is very slow - https://phabricator.wikimedia.org/T117172#1768093 (awight) NEW [07:16:24] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Saving a contact is very slow, and broken - https://phabricator.wikimedia.org/T117172#1768099 (awight) [07:19:46] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Saving a contact is very slow, and broken - https://phabricator.wikimedia.org/T117172#1768102 (awight) Trying simply disabling "Check for Similar Contacts" in the Display Preferences admin console. [07:21:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Saving a contact is very slow, and broken - https://phabricator.wikimedia.org/T117172#1768103 (awight) Nope, resetting to true. [07:52:43] (PS1) Awight: Add a setting to disable the dedupe on edit [wikimedia/fundraising/crm/civicrm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249972 (https://phabricator.wikimedia.org/T117172) [07:53:34] (CR) jenkins-bot: [V: -1] Add a setting to disable the dedupe on edit [wikimedia/fundraising/crm/civicrm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249972 (https://phabricator.wikimedia.org/T117172) (owner: Awight) [08:03:48] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Saving a contact is very slow, and broken - https://phabricator.wikimedia.org/T117172#1768168 (awight) [08:06:24] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Dedupe rules with the same name exist, but cannot be saved - https://phabricator.wikimedia.org/T117177#1768169 (awight) NEW [08:07:23] Wikimedia-Fundraising-CiviCRM: Dedupe rule should not be run when saving - https://phabricator.wikimedia.org/T117178#1768176 (awight) NEW [08:08:57] Wikimedia-Fundraising-CiviCRM: Dedupe rule should not be run when saving - https://phabricator.wikimedia.org/T117178#1768183 (awight) Open>Invalid a:awight Eh. the civicrm_contact table was locked due to the silverpop export. [08:10:23] Wikimedia-Fundraising-CiviCRM: Can't save dedupe rule due to mystery - https://phabricator.wikimedia.org/T117179#1768186 (awight) NEW [08:11:08] Wikimedia-Fundraising-CiviCRM: Can't save dedupe rule due to mystery - https://phabricator.wikimedia.org/T117179#1768193 (awight) Deleted that rule for now. [08:17:47] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Saving a contact is very slow, and broken - https://phabricator.wikimedia.org/T117172#1768194 (awight) Workaround: I'm switching the "Supervised" rules to "General" for each contact type, so t... [10:21:35] Fundraising Sprint William Shatner, Fundraising-Backlog, Continuous-Integration-Config, Unplanned-Sprint-Work, and 2 others: Tests on deployment branches of wikimedia/fundraising/crm falling causing to force merge (and deadlock of Zuul) - https://phabricator.wikimedia.org/T117062#1768365 (hashar) [13:00:48] the-wub: we might be 5 min late [13:01:37] okay, no problem CFisch_WMDE. I am in the hangout [13:38:55] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Amazon audit download fails - https://phabricator.wikimedia.org/T117153#1768714 (Jgreen) > couldn't connect to host @ /X/org/wiki >>! In T117153#1767832, @Ejegg wrote: > @Jgreen, is the firewall allowing outgoing access from J... [14:29:17] Fundraising-Backlog: Civi access for Donor Services contractor - https://phabricator.wikimedia.org/T117214#1768837 (MBeat33) NEW [15:11:35] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Amazon audit download fails - https://phabricator.wikimedia.org/T117153#1768962 (Ejegg) Bah, looks like that address pool wasn't as stable as advertised. I'm seeing it resolve to 54.239.25.28 now. Still in the us-east pool, a... [15:35:56] (CR) Ejegg: [C: 2 V: 2] "Works as advertised! Minor quibble about contact_ajax_check_similar vs ajaxPopupsEnabled vs isDedupeOnSave, but I won't let naming conven" [wikimedia/fundraising/crm/civicrm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249972 (https://phabricator.wikimedia.org/T117172) (owner: Awight) [15:36:55] (CR) jenkins-bot: [V: -1] Add a setting to disable the dedupe on edit [wikimedia/fundraising/crm/civicrm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/249972 (https://phabricator.wikimedia.org/T117172) (owner: Awight) [15:46:04] (PS1) Ejegg: Bump Civi submodule [wikimedia/fundraising/crm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/250026 [15:46:52] (CR) jenkins-bot: [V: -1] Bump Civi submodule [wikimedia/fundraising/crm] (civi-4.6.9-deployment) - https://gerrit.wikimedia.org/r/250026 (owner: Ejegg) [15:59:03] Fundraising-Backlog: Worldpay donation form error: expiration date year dropdown doesn't work - https://phabricator.wikimedia.org/T117228#1769151 (MBeat33) NEW [15:59:37] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Saving a contact is very slow, and broken - https://phabricator.wikimedia.org/T117172#1769164 (CaitVirtue) Just so you know, the original error doesn't sound too different from the functionalit... [16:00:22] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Do Not Solicit column in custom LYBUNT report? - https://phabricator.wikimedia.org/T117171#1769171 (CaitVirtue) Yes please, the report should include that column [16:20:57] Fundraising-Backlog: Worldpay donation form error: expiration date year dropdown doesn't work - https://phabricator.wikimedia.org/T117228#1769240 (MBeat33) [16:21:07] morning ejegg [16:21:17] hi cwd ! [16:21:28] where would you recommend putting js config like the suggested timeout value? [16:21:58] cwd: It would be another (gateway) global in DonationInterface.php [16:22:05] oh man [16:22:07] then you have to make it available client-side [16:22:17] as i type that WP writes back and says they can increase the timeout [16:22:28] Heh, awesome! [16:22:28] that's how you vivify WP [16:22:34] I still think it's a good feature [16:22:38] and yes it is exactly 180 seconds [16:23:00] how long should we make it? [16:23:39] oh, at least 30 minutes... let's see what our session timeout is [16:23:50] I've heard php session timeout is a bit unpredictable [16:25:00] sounds about righ [16:25:02] t [16:25:18] so yeah, let's ask for 30 minutes [16:25:41] not like we have inventory levels or fluctuating prices to worry about [16:25:53] yeah good point [16:25:59] spose that's what that's about [16:27:02] So, to feed the global to the client side, you register a MakeGlobalVariablesScript hook [16:27:25] see amazon_gateway.body.php line 32 and amazon.adapter.php line 450 [16:28:08] It would be really nice if that was a feature of ResourceLoader module registration though [16:28:17] I wonder if there's a reason it isn't... [16:31:54] interesting, does each project do its own thing to set things in js/mw? [16:32:04] sure seems like it would be good to generalize [16:32:34] hmm, there's also this hook https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderGetConfigVars [16:32:59] but yeah, I think you have to use one of those two hooks, or do some horrible javascript generation [16:33:09] (like we do in the old forms) [16:46:06] Fundraising-Backlog: Worldpay: donors receive error messages despite successful contribs - https://phabricator.wikimedia.org/T117239#1769339 (MBeat33) NEW [16:46:36] cwd yikes ^^ [16:47:32] Fundraising-Backlog: Worldpay donation form error: expiration date year dropdown doesn't work - https://phabricator.wikimedia.org/T117228#1769349 (cwdent) @MBeat33 - yeah that's another thing in the iframe hosted by WP so there's nothing we can directly but can perhaps get them to fix it. If i could reprodu... [16:48:02] ugh [16:48:05] it's falling apart [16:51:37] Fundraising-Backlog: Worldpay donation form error: expiration date year dropdown doesn't work - https://phabricator.wikimedia.org/T117228#1769356 (MBeat33) thanks, @cwdent - if any of the donors we've queried reply, I'll add their browsers here [16:52:15] ejegg: the one pictured says success in the log [16:52:26] yeah.... [16:52:32] i have no idea why we'd serve an error page [16:55:03] dang, that donor even completed the whole thing within 2 min [16:55:14] no time for anything to expire there [16:56:42] yeah, all 4 look just fine in the log [16:58:02] ok, so we definitely need to log every time we send somebody to a fail page [17:03:37] only 1 WP specific place it could be happening [17:04:05] and it sure looks like it wouldn't happen on anything but a failed transaction [17:12:12] damn [17:12:17] oh hey, that's not the fail page [17:12:20] that's a fail form [17:12:30] take a look at the url [17:12:36] it hasn't been redirected [17:13:17] now what does that mean... [17:13:30] hmm, like the first page? [17:14:43] so, somehow it's rendering a RapidHTML error form there [17:16:18] oh weird [17:17:36] ah wait, maybe that is the fail page for worldpay. nvm [17:23:19] cwd: oh, ok, that's the 'RapidFail' behavior [17:23:36] so it's still coming through 'getFailPage' [17:25:23] ejegg: gotcha [17:25:31] i'm checking every place that gets called [17:26:13] ugh, we need something more durable than ct_id in the logs [17:26:43] So, that donor's txn went through at 19:00:27 [17:27:56] Oh weird... [17:28:10] ...nah, nvm [17:30:25] atgomez: Any word from the Civi users? [17:33:12] cwd: so, we should se a 'Redirecting to...' log line anywhere that we called displayFailPage() [17:34:05] but there are none of those in the wp logs for more than a minute after that transaction goes through [17:34:42] ejegg: i was just looking at that [17:34:48] there's a coincidental 'redirecting' log line at the same moment the successful donor first hit the iframe ( before popout ) [17:35:21] but that 00:21 log line is associated with a legitimately failed txn for a donor with a different email address [17:37:57] i don't see any redirect message not directly preceded by "Not sending queue message for status failed." [17:38:48] oy [17:44:36] cwd it's also bugging me that the clock in the screenshot is at 17:35, which should be 16:35 in our logs if the donor's on CET. But lots of people have their clocks wrong. [17:45:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM upgrade: Donation Processing: no refund button after clicking Edit transaction - https://phabricator.wikimedia.org/T116317#1769661 (awight) [17:45:12] if we could see the whole url that might help correlate [17:45:15] yep [17:45:24] atgomez: In actual defense of Shatner's music career, I officially submit the following: https://www.youtube.com/watch?v=ainyK6fXku0 [17:45:48] Wikimedia-Fundraising-CiviCRM: Email Templates Not Populating - https://phabricator.wikimedia.org/T117255#1769667 (LeanneS) NEW [17:46:13] "produced and arranged by Ben Folds" probably helped. [17:46:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM upgrade: Donation Processing: no refund button after clicking Edit transaction - https://phabricator.wikimedia.org/T116317#1769674 (awight) We should find this new button. But part of the issue is that we have some manual process for certain st... [17:51:20] for no reason other than you made me think of this I submit to you [17:51:20] https://www.youtube.com/watch?v=AGF5ROpjRAU [17:51:46] K4-713: I offer a response: https://www.youtube.com/watch?v=rmPOWJtsEGc [17:53:28] chasemp: Oh yeah. That already haunts my dreams. [17:53:46] same, biiilllbooooooo [17:53:55] why god why [17:54:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM upgrade: Donation Processing: no refund button after clicking Edit transaction - https://phabricator.wikimedia.org/T116317#1769764 (MBeat33) I am unsure of how to use the new interface; is there an alternative to the old button marked Refund? {... [17:54:29] indy-strine: I... wow. [17:55:01] yes I already sent that to some people, I knew in about 30s but it just got more magical [17:55:07] In absolute terms, the bilbo song is worse [17:55:43] if by worse you mean humanities crowning acheivement, then yes [17:56:45] chasemp: I think you and I have very different definitions for the word "achievement" [17:56:53] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM upgrade: Donation Processing: no refund button after clicking Edit transaction - https://phabricator.wikimedia.org/T116317#1769769 (awight) It doesn't look like there's an alternative. Also, I see that there are two entries for Contribution Typ... [17:57:07] bahahaha [18:00:08] Fundraising-Backlog: Worldpay: donors receive error messages despite successful contribs - https://phabricator.wikimedia.org/T117239#1769797 (Ejegg) The last one ( 8626582382 ) is associated with a donor who tried twice - the first time ended with a failure message. Could that have been open in another tab?... [18:00:23] Wikimedia-Fundraising-CiviCRM: Email Templates Not Populating - https://phabricator.wikimedia.org/T117255#1769799 (LeanneS) @awight those are the same steps I took, but no message was appearing on my end. I just tried again and clicked on Plain-Text Format, and then was able to see the template. This is a se... [18:03:33] :) [18:05:02] dang ejegg|afk good find [18:09:38] I'm gonna be mostly not working today... [18:10:53] Wikimedia-Fundraising-CiviCRM: Email Templates Not Populating - https://phabricator.wikimedia.org/T117255#1769832 (LeanneS) The templates that I tried using were the 3 with "2014/15 Benefactor Email" in the name. [18:11:02] Wikimedia-Fundraising-CiviCRM: Email Templates Not Populating - https://phabricator.wikimedia.org/T117255#1769833 (awight) Noting that the template content is retrieved using a JS call to /civicrm/ajax/template, so we should look for errors there. [18:16:12] Fundraising-Backlog: Worldpay: donors receive error messages despite successful contribs - https://phabricator.wikimedia.org/T117239#1769850 (atgo) As an aside - @ejegg could we change the mailto link on the error page to include that URL pasted into the body of the email? I was thinking about this a while a... [18:21:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Main View of CiviCRM contact record doesn't show much useful info - https://phabricator.wikimedia.org/T117265#1769866 (CaitVirtue) NEW [18:23:58] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Main View of CiviCRM contact record doesn't show much useful info - https://phabricator.wikimedia.org/T117265#1769889 (CaitVirtue) [18:24:51] Fundraising-Backlog: Worldpay: donors receive error messages despite successful contribs - https://phabricator.wikimedia.org/T117239#1769920 (Ejegg) Great idea @atgo! [18:28:03] K4-713: http://www.huffingtonpost.com/entry/harrison-ford-plane-crash-hot-dog-suit-kimmel_56335dbce4b00aa54a4db00e [18:29:53] Fundraising-Backlog: Worldpay: donors receive error messages despite successful contribs - https://phabricator.wikimedia.org/T117239#1769947 (MBeat33) definitely! thanks @atgo [18:30:19] Wikimedia-Fundraising-CiviCRM: Email Templates Not Populating - https://phabricator.wikimedia.org/T117255#1769952 (awight) I watched the weblog during some of these requests--we used "FY2014/15 Benefactor Email ($1K+)". On LeanneS's computer, nothing appeared in the HTML message preview, but plaintext was p... [18:35:27] Fundraising-Backlog: Include URL of error page in mailto: link when donation fails - https://phabricator.wikimedia.org/T117271#1769972 (atgo) NEW [18:47:59] cwd, ejegg, XenoRyet: I'm going to do a tiny payments setting change. Any objections? [18:48:18] what sort K4-713 ? [18:48:19] nope [18:48:30] cwd: antifraud tweak. [18:48:36] No objections here. [18:48:45] do it [18:49:22] wooo [18:56:34] !log antifraud tweak on payments wiki [18:56:38] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [19:00:56] ejegg: i notice all those client side amazon config settings are commented out in DonationInterface.php [19:01:34] Oh, the account config is shown as an example in a comment, sure [19:01:58] the real values in live localsettings? [19:02:03] yep [19:02:24] think iframe timeout should be like that or just set in DI? [19:02:46] should have a reasonable default in DI [19:02:54] cool [19:03:09] hopefully wp can get the real timeout fixed soon [19:03:13] yeah! [19:07:36] !log antifraud tweak on payments wiki (again) [19:07:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [19:38:15] hey [19:38:32] ejegg: hi and you too AndyRussG [19:38:33] AndyRussG: you have not reviewed my patch :) [19:38:39] r054l13: hi! [19:38:46] it is taking too long, whats going on? [19:38:51] r054l13: true, I will get to it, tho! [19:45:10] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import fails with database error - https://phabricator.wikimedia.org/T116445#1770251 (Ejegg) @awight, I was using bless, but xxd gives the same result when I run it on Report_orders_10-19-2015.csv straight from the file server. (slightly redact... [19:50:27] hey cwd, in email from WP-Adam about the expiration date dropdown error, he’s asking for Order #s - is that the same as a transaction ID? [19:51:12] MBeat: i think so, 123123123.0 etc [19:52:05] if donors can’t submit the card #s, then there wouldn’t be any order #s, right? trick question? [19:52:40] MBeat: heheh well i think the iframe request will still be on their system [19:52:53] thought i'm not sure what they'll be able to glean from that [19:53:29] thanks, cwd - is there any way I can access a few iframe request #s to send them? [19:54:11] MBeat: i should be able to look them up [19:55:12] donor email would be the easiest way -- we decided otr is okay right K4-713 ? [19:57:09] MBeat: these people never made it past the iframe right? they couldn't submit it? [19:57:39] right, they just stopped at the expiration date & didn’t send info to WP [19:58:41] i can't imagine what WP thinks they're going to learn from the iframe request then [19:58:50] cwd: otr is great. [19:58:54] it won't contain any browser information for instance [19:59:04] which is almost definitely the culprit [20:02:25] i will install adium/otr in a bit & send a few, thank you [20:03:35] great! thanks MBeat [20:03:52] thank you for looking em up cwd [20:04:07] you bet [20:05:34] (PS1) Ejegg: Log reasons for redirects to fail/ty pages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/250062 [21:05:59] (PS5) Cdentinger: refresh page on configurable token expiry [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/249797 [21:41:26] Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, WorkType-Maintenance: Worldpay frontend donation missing payment_method - https://phabricator.wikimedia.org/T115932#1770460 (K4-713) [21:41:54] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: Record actual amount charged regardless of what's in session - https://phabricator.wikimedia.org/T115171#1770468 (K4-713) [21:42:49] Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, and 2 others: Adyen rejects merchant signature - https://phabricator.wikimedia.org/T116667#1770474 (K4-713) [21:43:09] Fundraising Sprint Vengaboys, Fundraising-Backlog, WorkType-Maintenance: CiviCRM upgrade: Simple Lookups: timeout attempting to look up matching gifts given in August - https://phabricator.wikimedia.org/T116313#1770477 (K4-713) [21:44:24] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, WorkType-Maintenance: Worldpay Audit file - https://phabricator.wikimedia.org/T114676#1770479 (K4-713) [21:44:41] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: Implement recurring logic in Amazon gateway adapter - https://phabricator.wikimedia.org/T111430#1770480 (K4-713) [21:44:59] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Implement Amazon recurring widget client-side - https://phabricator.wikimedia.org/T111428#1770481 (K4-713) [21:45:20] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, WorkType-Maintenance: WMF Civi admins test their normal workflows on the staging server - https://phabricator.wikimedia.org/T114823#1770488 (K4-713) [21:45:35] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Unsubscribe link doesn't work on upgraded staging 4.6 - https://phabricator.wikimedia.org/T116112#1770489 (K4-713) [21:45:51] Fundraising Sprint Vengaboys, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work, WorkType-Maintenance: Banner impressions not updating on lutetium - https://phabricator.wikimedia.org/T116021#1770490 (K4-713) [21:46:04] Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, WorkType-Maintenance: Confirm that ecom script is compatible with Civi 4.6 - https://phabricator.wikimedia.org/T116674#1770492 (K4-713) [21:47:07] Fundraising Sprint Vengaboys, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review, WorkType-Maintenance: Deploy Media Wiki Interface subject line in French - https://phabricator.wikimedia.org/T116199#1770508 (K4-713) [21:47:25] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Patch-For-Review, WorkType-NewFunctionality: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1770512 (K4-713) [21:48:18] Fundraising Sprint Vengaboys, Fundraising-Backlog, Analytics, Analytics-Cluster, and 3 others: Impression log parsers should get sample rate from filenames - https://phabricator.wikimedia.org/T116800#1770514 (K4-713) [21:48:32] Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Pause the queue consumer and build up a big batch, use that batch for benchmarking - https://phabricator.wikimedia.org/T116781#1770515 (K4-713) [22:29:55] hi thought I'd check in - but don't see many people about [22:30:22] hiya eileen [22:36:15] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Saving a contact is very slow, and broken - https://phabricator.wikimedia.org/T117172#1770636 (Eileenmcnaughton) I think we should hold a ticket open to assess this from a longer term point of... [22:42:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Reports "Save a Copy" is broken - https://phabricator.wikimedia.org/T117166#1770647 (Eileenmcnaughton) I should take a look at this. It sounds wrong. I wouldn't change save a copy wording unless you feel really strongly or can convince core team it's be... [22:52:29] what's this fun new feature where we get 2 emails for every email from worldpay? [23:03:51] Fundraising-Backlog: Worldpay: donor seeing multiple charges - https://phabricator.wikimedia.org/T117295#1770688 (MBeat33) NEW [23:05:42] MBeat: yow [23:05:47] the bugs are rollin in [23:07:58] yep [23:16:56] cwd: that sounds ..handy? [23:17:31] double the fun! [23:23:17] Fundraising-Backlog: Worldpay: donor seeing multiple charges - https://phabricator.wikimedia.org/T117295#1770728 (atgo) p:Triage>Unbreak! We should investigate if there's any chance this is on our side as soon as we can. (Monday is probably fine) [23:23:26] Fundraising Sprint William Shatner, Fundraising-Backlog, Unplanned-Sprint-Work: Worldpay: donor seeing multiple charges - https://phabricator.wikimedia.org/T117295#1770730 (atgo) [23:32:06] Fundraising Sprint William Shatner, Fundraising-Backlog, Unplanned-Sprint-Work: Worldpay: donor seeing multiple charges - https://phabricator.wikimedia.org/T117295#1770766 (cwdent) Agreed. I just scanned the logs for one of them and found a timeout followed by a successful charge. This would imply s...